platform/upstream/efl.git
4 years agoeina: add new definitions to a old enum
Marcel Hollerbach [Sat, 11 Apr 2020 17:55:27 +0000 (19:55 +0200)]
eina: add new definitions to a old enum

this is sadly needed due to the fact that we have a .eo defnition in the
.eot file which contains the flags keyword.

Differential Revision: https://phab.enlightenment.org/D11739

4 years agoelementary: these definitions are in real header files
Marcel Hollerbach [Sat, 11 Apr 2020 17:32:38 +0000 (19:32 +0200)]
elementary: these definitions are in real header files

there is no reason to have them in the .eot files. They are also not
namespaced in the way we want to have types.

Differential Revision: https://phab.enlightenment.org/D11738

4 years agoevas: remove dead struct definition
Marcel Hollerbach [Fri, 10 Apr 2020 13:47:11 +0000 (15:47 +0200)]
evas: remove dead struct definition

this is not used anywhere

Differential Revision: https://phab.enlightenment.org/D11737

4 years agoeo: install eot files correctly
Marcel Hollerbach [Sun, 19 Apr 2020 19:37:37 +0000 (21:37 +0200)]
eo: install eot files correctly

eina_types.eot is needed in order to fetch all needed informations.

Differential Revision: https://phab.enlightenment.org/D11736

4 years agoelementary: do not install legacy .eo files
Marcel Hollerbach [Sun, 19 Apr 2020 19:37:03 +0000 (21:37 +0200)]
elementary: do not install legacy .eo files

they do not have any purpose to be installed on the filesystem.

Differential Revision: https://phab.enlightenment.org/D11735

4 years agomeson: do not install .eo files of not installed header files
Marcel Hollerbach [Sun, 19 Apr 2020 19:33:48 +0000 (21:33 +0200)]
meson: do not install .eo files of not installed header files

Differential Revision: https://phab.enlightenment.org/D11733

4 years agorelease: Update NEWS and bump version for 1.24.0-beta3 release
Stefan Schmidt [Tue, 21 Apr 2020 09:22:33 +0000 (11:22 +0200)]
release: Update NEWS and bump version for 1.24.0-beta3 release

4 years agoevas_object_textblock: add null check for return of eina_inlist_remove
WooHyun Jung [Tue, 21 Apr 2020 05:37:23 +0000 (14:37 +0900)]
evas_object_textblock: add null check for return of eina_inlist_remove

4 years agoecore-drm2: Change ERR to WRN
Christopher Michael [Mon, 20 Apr 2020 23:31:44 +0000 (19:31 -0400)]
ecore-drm2: Change ERR to WRN

No real need for these to be ERR because we are not going to crash if
these happen anyway.

4 years agoecore-evas-wayland: Fix formatting
Christopher Michael [Fri, 17 Apr 2020 16:52:00 +0000 (12:52 -0400)]
ecore-evas-wayland: Fix formatting

NB: No functional changes

4 years agomarquee: add stack above between p_obj and textblock. 10/231310/1
Bowon Ryu [Tue, 21 Apr 2020 06:25:43 +0000 (15:25 +0900)]
marquee: add stack above between p_obj and textblock.

Stacks p_obj for marquee animation on the existing textblock.
Adjust the z-index with this.
This prevents other ui elements from being placed between the textblock and p_obj.

Change-Id: I2f71ef66233938b3c758eac5c1b3548c5d107d42
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
4 years agoeolian: fix C type serialization of error() submit/tizen/20200420.213352
Daniel Kolesa [Mon, 20 Apr 2020 12:36:14 +0000 (14:36 +0200)]
eolian: fix C type serialization of error()

4 years agoeolian: only warn instead of erroring on unused imports
Daniel Kolesa [Mon, 20 Apr 2020 12:19:26 +0000 (14:19 +0200)]
eolian: only warn instead of erroring on unused imports

4 years agoexactness-inspect: do not use sprintf
Marcel Hollerbach [Mon, 20 Apr 2020 06:46:45 +0000 (08:46 +0200)]
exactness-inspect: do not use sprintf

there is not yet a CID for this, but we should probebly not do that.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11731

4 years agoexactness-inspect: remove abscure xor check
Marcel Hollerbach [Fri, 17 Apr 2020 13:17:52 +0000 (15:17 +0200)]
exactness-inspect: remove abscure xor check

this is a obscure check, if this was ever reached, then it would simply
crash, because one pointer will be NULL, but strcmp will be called on
it.

CID 1419854

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11722

4 years agodoxygen docs: Fix all invalid @param names
Xavi Artigas [Mon, 20 Apr 2020 10:22:44 +0000 (12:22 +0200)]
doxygen docs: Fix all invalid @param names

There were quite a few of these...

4 years agoexactness: make sure we handle a negative file descriptor
Stefan Schmidt [Fri, 17 Apr 2020 13:23:44 +0000 (15:23 +0200)]
exactness: make sure we handle a negative file descriptor

In an error case the fd could be negative here and we should check
before feeding it into fdopen(). This is the same patch we used in
recorder.c

CID: 1422194

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11728

4 years agoexactness: make sure we handle a negative file descriptor
Stefan Schmidt [Fri, 17 Apr 2020 12:12:48 +0000 (14:12 +0200)]
exactness: make sure we handle a negative file descriptor

In an error case the fd could be negative here and we should check
before feeding it into fdopen().

CID: 1422197

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11725

4 years agoexactness: handle case where eet_data_image_write() fails
Stefan Schmidt [Fri, 17 Apr 2020 12:06:57 +0000 (14:06 +0200)]
exactness: handle case where eet_data_image_write() fails

We never checked how many bytes had been written. Check on return and
propagate error upwards to caller.

CID: 1419856

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11724

4 years agoexactness: remove unused code
Stefan Schmidt [Fri, 17 Apr 2020 11:35:38 +0000 (13:35 +0200)]
exactness: remove unused code

We no longer support the old .rec format and we can always expect the
file to be exu. Coverity found this block to be always true so the else
part could not be reached.

CID: 1421996

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11723

4 years agoelm theme - add support for smooth restart for e
Carsten Haitzler (Rasterman) [Sun, 19 Apr 2020 22:27:01 +0000 (23:27 +0100)]
elm theme - add support for smooth restart for e

just extra data item and extra program only used if it's a new e

4 years agocanvas svg: fix memory leak. 24/231124/2
Hermet Park [Fri, 17 Apr 2020 09:14:48 +0000 (18:14 +0900)]
canvas svg: fix memory leak.

free svg node commands & points data after usage.

@fix

Change-Id: I598b93a083699e032c12f53b01dda1b6573d2b62

4 years agoelm_spinner: Prevent to create inc/dec button in list spinner. 08/229908/2
Woochanlee [Mon, 6 Apr 2020 10:06:51 +0000 (19:06 +0900)]
elm_spinner: Prevent to create inc/dec button in list spinner.

There is no inc/dec button in list spinner UX

@tizen_feature

Change-Id: Ic4eff7193f2b782c29d27037164c002f06def200

4 years agoelm - theme - add outline style for frames submit/tizen/20200419.220844
Carsten Haitzler (Rasterman) [Sun, 19 Apr 2020 17:41:08 +0000 (18:41 +0100)]
elm - theme - add outline style for frames

new standard style. outline.

4 years agoeolian: globally enable eolian_state_check, except for beta classes
Daniel Kolesa [Sat, 18 Apr 2020 23:53:50 +0000 (01:53 +0200)]
eolian: globally enable eolian_state_check, except for beta classes

Beta classes won't have their namespaces validated at this point.
It is possible to set EOLIAN_CHECK_NAMESPACES_BETA=1 to enable
checking those as well, if you want to fix them all.

4 years agoremove unused imports in eo/eot files
Daniel Kolesa [Sat, 18 Apr 2020 23:44:50 +0000 (01:44 +0200)]
remove unused imports in eo/eot files

4 years agoeolian: add composites into hard deps when checking
Daniel Kolesa [Sat, 18 Apr 2020 23:43:33 +0000 (01:43 +0200)]
eolian: add composites into hard deps when checking

This prevents composites from being considered unused imports.

4 years agoevas_textblock/evas_text/evas_textgrid: pick textrun fonts
Carsten Haitzler (Rasterman) [Sat, 18 Apr 2020 16:36:25 +0000 (17:36 +0100)]
evas_textblock/evas_text/evas_textgrid: pick textrun fonts

Summary:
Picking font on textrun, will now give priority into font picked by the user, regardless of script type.
picking font due script can cause many inconvenient results

Example of wrong results:  (User font is **NotoColorEmoji**)
{F3847118} -> add 'a' at the end (notice how text render is wrong) {F3847119} -> add tab before 'a' (text rendering now is right) {F3847120}

After Change results: (User font is **NotoColorEmoji**)
{F3847118}  -> add 'a' at the end -> {F3847122}-> add tab before 'a' -> {F3847123}

Also now the following lines will be shown exactly the same, regardless of characters order
```
"가123A321"
"A321가123"
"123가A321"
"A가123321"
```

Test Plan:
```
#include <Elementary.h>
/*
gcc -o example test.c `pkg-config --cflags --libs elementary`
*/

EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
   Evas_Object *win, *en;

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_util_standard_add("", "");
   elm_win_autodel_set(win, EINA_TRUE);

   en = elm_entry_add(win);
   elm_entry_scrollable_set(en, EINA_TRUE);
   evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL);

   elm_entry_text_style_user_push(en,"DEFAULT='font=NotoColorEmoji font_size=30 color=red'");
   elm_object_text_set(en, "&#x262a;123456a");

   evas_object_show(en);

   elm_object_content_set(win, en);
   evas_object_resize(win, 400, 200);
   evas_object_show(win);

   elm_run();

   return 0;
}
ELM_MAIN()
```

Reviewers: woohyun, bowonryu, tasn, raster, cedric

Reviewed By: tasn

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8556

Differential Revision: https://phab.enlightenment.org/D11302

4 years agoevas_textgrid: update text props to use current script font
Ali [Sat, 18 Apr 2020 16:36:11 +0000 (17:36 +0100)]
evas_textgrid: update text props to use current script font

Summary:
This update make the textgrid same as evas_text and evas_textblock to use current picked font for text_props instead of script_font

This patch will fix terminology emoji rendering when used applying D11302.

Reviewers: raster, woohyun

Reviewed By: woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11729

4 years agoevas render - flush, dont clear unref/clean arrays on render done
Carsten Haitzler (Rasterman) [Sat, 18 Apr 2020 16:28:10 +0000 (17:28 +0100)]
evas render - flush, dont clear unref/clean arrays on  render done

we build these arrays to hold tjhings to clean up when done ... but if
one frame happens ot have a lot - the allocation stays huge as we only
clean not flush, so flush to keep memory down.

@optimize

4 years ago[Genlist] Unfreeze event fix submit/tizen/20200417.234115
Godly T.Alias [Wed, 15 Apr 2020 17:53:48 +0000 (23:23 +0530)]
[Genlist] Unfreeze event fix
Unfreeze event is not occuring properly. If item is on deletion genlist remains in freezed state Unfreeze genlist regardless of deletion state

Change-Id: I50d517edb85811ea6c367f2d22d80f5759bce326
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
4 years agoecore_anim: fix animator ticking logic to gain accuarte
Wonki Kim [Sat, 11 Apr 2020 03:51:24 +0000 (12:51 +0900)]
ecore_anim: fix animator ticking logic to gain accuarte

ecore_loop_time has set by a improper timestamp just before animator callback is invoked.

ecore_animator is built over ecore_thread. ticking is handled in 'thread_func'
and a tick is fired by calling ecore_thread_feedback with a timestamp argument.

In notify func, ecore_time_loop_set has take place with the argument from thread func.
the argument could be unacceptable because notify function is invoked asynchronously.
if there were many thing to do in the loop, time gap must be incresed.

animator tick leads elm logic to calculate next position in animating.
so it is neccessary to use actual time for the calculating.

this patch fixes the animator to set loop time by a actual time.

Change-Id: I1f00a5d074a78da5a87fba55bc1ab13a4f1311df

4 years agoecore_wl: To use vsync as custom source of animator
Hosang Kim [Wed, 8 Apr 2020 03:58:20 +0000 (12:58 +0900)]
ecore_wl: To use vsync as custom source of animator

This patch includes below patches
ecore: fixed wrong codes regarding ecore_anim_vsync
ecore: Remove condition about timeout in animator with vsync
ecore_anim : Add safety code to ecore_anim
ecore_anim: Fix don't call animator_cb
ecore_wayland: Remove codes irrelevant to poll()

@tizen_only

Change-Id: I2223cc9b4574d17b99f91c5b7e6c8587c9e7852f
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
4 years agoAdd debug information to ecore_wl2
ch.jeong47 [Thu, 9 Apr 2020 04:55:12 +0000 (13:55 +0900)]
Add debug information to ecore_wl2

- add debug information which for analyzing of many issues related to touch event.
Sometimes we need more information regarding touch events of ecore_wl2.

Change-Id: I0c495c2b25fef7a6062febeddd43f7753a67e406
Signed-off-by: ch.jeong47 <ch.jeong47@samsung.com>
4 years agospinner: flick to open feature
HyukSoon Choi [Mon, 13 Apr 2020 10:10:41 +0000 (19:10 +0900)]
spinner: flick to open feature

Change-Id: Ice51bbca22d07552193e3c10bb1a22c33481e365
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
4 years agoedje : add new feature of color class can be aliased by item data in the group
SangHyeon Jade Lee [Tue, 7 Apr 2020 08:18:27 +0000 (17:18 +0900)]
edje : add new feature of color class can be aliased by item data in the group

search object color_class can be aliased different name by looking into
item.data of group style.

data {
   item: "color/aliased_color_class_name" "original_color_class_name"
}

@tizen_only

Change-Id: Ic94f51d3066d8942ad86f6f3ef91de29917be9b7

4 years ago[Genlist] Avoid unnecessary refcount in item
Godly T.Alias [Wed, 15 Apr 2020 17:10:01 +0000 (22:40 +0530)]
[Genlist] Avoid unnecessary refcount in item
Item is not getting deleted. Refcount was not becoming < 1.Unref the item for allowing item to be deleted

Change-Id: Iaf8b71bb06c7c6f5a3e70fc89796e815e5336424
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
4 years ago[Genlist] Contribution of item free optimization on clear
Godly T.Alias [Wed, 15 Apr 2020 12:44:43 +0000 (18:14 +0530)]
[Genlist] Contribution of item free optimization on clear

Change-Id: Id229f881b45dfc27ecf4f7bda8b22648c0e4d2c7
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
4 years ago[Genlist] Avoid non alignable items being aligned during recalculations
Godly T.Alias [Wed, 15 Apr 2020 03:57:55 +0000 (09:27 +0530)]
[Genlist] Avoid non alignable items being aligned during recalculations

Change-Id: Iec2208485f4b5e62e954270eb2c5f78c08637161
Signed-off-by: Yukti Pandey <yukti.pandey@samsung.com>
4 years ago[Genlist] Safety checks to avoid crashes
Godly T.Alias [Tue, 14 Apr 2020 06:00:37 +0000 (11:30 +0530)]
[Genlist] Safety checks to avoid crashes

Change-Id: Ic951e1382b7e82488b82a2cec042bb0ab50b026c
Signed-off-by: Yukti Pandey <yukti.pandey@samsung.com>
4 years agoRevert "evas_textblock: pick textrun fonts"
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 18:19:52 +0000 (19:19 +0100)]
Revert "evas_textblock: pick textrun fonts"

This reverts commit 9b987c67e1e38602ba2e4c9c990798e99d938bbe.

this breaks color emoji in terminology (evas textgrid).

4 years agoexactness-inspect: unit1 can never be NULL
Marcel Hollerbach [Fri, 17 Apr 2020 13:15:41 +0000 (15:15 +0200)]
exactness-inspect: unit1 can never be NULL

checkinf for it beeing NULL means that we would have to equip every
usage of unit1 with a check, but that is useless.

CID 1419859

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11721

4 years agoexactness-inspect: fix NULL access
Marcel Hollerbach [Fri, 17 Apr 2020 13:11:26 +0000 (15:11 +0200)]
exactness-inspect: fix NULL access

ii might be NULL so we should ensure it is not NULL to call item_select

CID 1419865

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11720

4 years agoexactness-inspect: sanitize if clause
Marcel Hollerbach [Fri, 17 Apr 2020 13:08:27 +0000 (15:08 +0200)]
exactness-inspect: sanitize if clause

these if clause where a bit bottom up, and the xor operation here seemed
totally wrong, with this code we are simply displaying both entiteis of
the two structs when they are there. *or* we are replacing it with the
fallback.

CID1419875

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11719

4 years agoelm - genlist test - handl g_data being null
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 11:47:34 +0000 (12:47 +0100)]
elm - genlist test - handl g_data being null

fix CID 1396944 1396946

4 years agoecore - examples - fix gnutls fd handler example warnings
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 11:28:35 +0000 (12:28 +0100)]
ecore - examples - fix gnutls fd handler example warnings

just error returns not being checked. not an issue really, but this
silences warnings.

fix CID 1164185 715896 98094 1400818

4 years agoecore - proc env - fix values return NULL case - coverity
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 11:14:19 +0000 (12:14 +0100)]
ecore - proc env - fix values return NULL case - coverity

this fixes CID 1419857

4 years agoevas cache - up padding just in case i was off by one
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 10:04:38 +0000 (11:04 +0100)]
evas cache - up padding just in case i was off by one

coverity was complaining but it's a false positive - it seems to not
realze the loadopts_append does nul terminate at the end.

4 years agotests/elm: add image tests to verify internal object size is clamped to object size
Mike Blumenkrantz [Wed, 25 Mar 2020 14:07:56 +0000 (10:07 -0400)]
tests/elm: add image tests to verify internal object size is clamped to object size

ensure that this doesn't break again

ref 11587

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11599

4 years agocanvas svg: fix memory leak.
Hermet Park [Fri, 17 Apr 2020 09:14:48 +0000 (18:14 +0900)]
canvas svg: fix memory leak.

free svg node commands & points data after usage.

@fix

4 years agoevas_textblock: prevent segfault if there are no style
Ali [Thu, 16 Apr 2020 15:51:31 +0000 (15:51 +0000)]
evas_textblock: prevent segfault if there are no style

```
#include <Elementary.h>

EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
   Evas_Object *win, *textblock;

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_util_standard_add("", "");
   elm_win_autodel_set(win, EINA_TRUE);

   textblock = evas_object_textblock_add(win);
   evas_object_resize(textblock, 360, 360);
   evas_object_show(textblock);
   evas_object_textblock_text_markup_set(textblock, "<b>b</b>");
   evas_object_resize(win, 360, 360);
   evas_object_show(win);
   elm_run();

   return 0;
}
ELM_MAIN()
```

this application will crash.

Any font format specified in text, if there are now style will cause the crash.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11686

4 years agoeina/value: use correct time types when comparing time types
Mike Blumenkrantz [Thu, 16 Apr 2020 14:44:03 +0000 (10:44 -0400)]
eina/value: use correct time types when comparing time types

these functions all expect struct timeval, as the name implies

../src/lib/eina/eina_value.c: In function ‘_eina_value_type_tm_compare’:
../src/lib/eina/eina_value.c:3358:19: warning: array subscript 1 is outside array bounds of ‘time_t[1]’ {aka ‘long int[1]’} [-Warray-bounds]
 3358 |    struct timeval ret = *input;
      |                   ^~~
../src/lib/eina/eina_value.c:3569:11: note: while referencing ‘ta’
 3569 |    time_t ta, tb;
      |           ^~
../src/lib/eina/eina_value.c:3358:19: warning: array subscript 1 is outside array bounds of ‘time_t[1]’ {aka ‘long int[1]’} [-Warray-bounds]
 3358 |    struct timeval ret = *input;
      |                   ^~~
../src/lib/eina/eina_value.c:3569:15: note: while referencing ‘tb’
 3569 |    time_t ta, tb;

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11715

4 years agoeina_content: free eina content in the test:
Marcel Hollerbach [Fri, 17 Apr 2020 08:49:30 +0000 (10:49 +0200)]
eina_content: free eina content in the test:

Fix the unbelievable High prioritized CID 1420314

4 years agoelm/win: declare prototype for ecore_evas_dnd_mark_motion_used
Mike Blumenkrantz [Thu, 16 Apr 2020 16:10:52 +0000 (12:10 -0400)]
elm/win: declare prototype for ecore_evas_dnd_mark_motion_used

../src/lib/elementary/efl_ui_win.c: In function ‘_motion_cb’:
../src/lib/elementary/efl_ui_win.c:9271:14: warning: implicit declaration of function ‘ecore_evas_dnd_mark_motion_used’ [-Wimplicit-function-declaration]
 9271 |              ecore_evas_dnd_mark_motion_used(ee, seat);
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Differential Revision: https://phab.enlightenment.org/D11717

4 years agoexactness: limit length for font_path to stay in buffer
Stefan Schmidt [Thu, 16 Apr 2020 14:25:29 +0000 (16:25 +0200)]
exactness: limit length for font_path to stay in buffer

We get fonts_dir from a getenv() without and length check. Make sure
that we stay in the given buffer size when stitching the file path
together.

CID: 1422195

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11718

4 years agoexactness: fix typo in function name
Stefan Schmidt [Thu, 16 Apr 2020 13:35:36 +0000 (15:35 +0200)]
exactness: fix typo in function name

Simple spelling mistake. overlay instead of overloay.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11714

4 years agoexactness: remove no longer used code since move to preload
Stefan Schmidt [Thu, 16 Apr 2020 13:32:58 +0000 (15:32 +0200)]
exactness: remove no longer used code since move to preload

This has been around for prg handling before we switched to preload. No
need for it anymore. Found when looking for a Coverity issue, which also
got fixed now by luck. :-)

CID: 1421994

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11713

4 years agoevas_textblock: remove special treat for variation sequence text run
Ali [Fri, 17 Apr 2020 05:26:14 +0000 (14:26 +0900)]
evas_textblock: remove special treat for variation sequence text run

Summary:
Now there are no need for special care for variation sequence text run break.
General method will care about all types of characters\

this is also related to D11096

Reviewers: woohyun, bowonryu

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11602

4 years agoevas_textblock: pick textrun fonts
Ali Alzyod [Fri, 17 Apr 2020 03:28:41 +0000 (12:28 +0900)]
evas_textblock: pick textrun fonts

Summary:
Picking font on textrun, will now give priority into font picked by the user, regardless of script type.
picking font due script can cause many inconvenient results

Example of wrong results:  (User font is **NotoColorEmoji**)
{F3847118} -> add 'a' at the end (notice how text render is wrong) {F3847119} -> add tab before 'a' (text rendering now is right) {F3847120}

After Change results: (User font is **NotoColorEmoji**)
{F3847118}  -> add 'a' at the end -> {F3847122}-> add tab before 'a' -> {F3847123}

Also now the following lines will be shown exactly the same, regardless of characters order
```
"가123A321"
"A321가123"
"123가A321"
"A가123321"
```

Test Plan:
```
/*
gcc -o example test.c `pkg-config --cflags --libs elementary`
*/

EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
   Evas_Object *win, *en;

   elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);

   win = elm_win_util_standard_add("", "");
   elm_win_autodel_set(win, EINA_TRUE);

   en = elm_entry_add(win);
   elm_entry_scrollable_set(en, EINA_TRUE);
   evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
   evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL);

   elm_entry_text_style_user_push(en,"DEFAULT='font=NotoColorEmoji font_size=30 color=red'");
   elm_object_text_set(en, "&#x262a;123456a");

   evas_object_show(en);

   elm_object_content_set(win, en);
   evas_object_resize(win, 400, 200);
   evas_object_show(win);

   elm_run();

   return 0;
}
ELM_MAIN()
```

Reviewers: woohyun, bowonryu, tasn, raster, cedric

Reviewed By: tasn

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8556

Differential Revision: https://phab.enlightenment.org/D11302

4 years agoevas_test: change START_TEST to EFL_START_TEST accepted/tizen/unified/20200421.150402 submit/tizen/20200416.215157
Ali [Thu, 16 Apr 2020 16:03:23 +0000 (12:03 -0400)]
evas_test: change START_TEST to EFL_START_TEST

Summary: evas_test: change START_TEST to EFL_START_TEST

Reviewers: zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11716

4 years agoecore_evas: fix fallback code
Marcel Hollerbach [Thu, 16 Apr 2020 09:32:35 +0000 (09:32 +0000)]
ecore_evas: fix fallback code

this was using a stringshare reference that was deleted. While that is
true, the stringshare reference will always be alive, because 2 people
took a reference. Anyways, this code is now searching the other way
arround, which makes the code also easier.

fixes: CID1420331

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11712

4 years agotests/elm: explicitly destroy hoversel while active
Mike Blumenkrantz [Wed, 8 Apr 2020 17:21:27 +0000 (13:21 -0400)]
tests/elm: explicitly destroy hoversel while active

verify that there's no errors when this happens

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11704

4 years agotests/elm: add hoversel test to verify edge of canvas positioning
Mike Blumenkrantz [Fri, 3 Apr 2020 15:50:19 +0000 (11:50 -0400)]
tests/elm: add hoversel test to verify edge of canvas positioning

ensure that T8642 doesn't reoccur

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11647

4 years agoelm/hoversel: force calc on internal hover object during activate
Mike Blumenkrantz [Fri, 3 Apr 2020 15:38:11 +0000 (11:38 -0400)]
elm/hoversel: force calc on internal hover object during activate

hoversel can't accurately determine its location until the hover object
has been calculated, so this needs to always happen before the hoversel
is made visible in order to correctly position the hover

fix T8642

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11646

4 years agotests/elm: add hoversel behavior tests
Mike Blumenkrantz [Thu, 2 Apr 2020 17:59:28 +0000 (13:59 -0400)]
tests/elm: add hoversel behavior tests

this verifies all smart callbacks for a hoversel to ensure they're triggered
as expected

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11644

4 years agoelm/hoversel: remove unnecessary internal callback deletion
Mike Blumenkrantz [Thu, 2 Apr 2020 17:58:26 +0000 (13:58 -0400)]
elm/hoversel: remove unnecessary internal callback deletion

this already happens automatically on every item destruction and passes
the item data through there to ensure the correct callback is removed

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11643

4 years agoelm/hoversel: use a wref to accurately track internal hover object
Mike Blumenkrantz [Thu, 2 Apr 2020 17:57:21 +0000 (13:57 -0400)]
elm/hoversel: use a wref to accurately track internal hover object

this pointer is never unset, which can cause errors when attempting to
access it after the hoversel has been deactivated

Differential Revision: https://phab.enlightenment.org/D11642

4 years agotests/elm: add callback tests for elm_list
Mike Blumenkrantz [Mon, 13 Apr 2020 16:43:21 +0000 (12:43 -0400)]
tests/elm: add callback tests for elm_list

basic tests to verify behavior for triggering callbacks when selecting items

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11703

4 years agoefreet - disable strict as this makes things less functional...
Carsten Haitzler (Rasterman) [Thu, 16 Apr 2020 12:33:37 +0000 (13:33 +0100)]
efreet - disable strict as this makes things less functional...

4 years agoefreet - also look in lib in /usr/local/share/pixmaps too
Carsten Haitzler (Rasterman) [Thu, 16 Apr 2020 12:19:36 +0000 (13:19 +0100)]
efreet - also look in lib in /usr/local/share/pixmaps too

4 years agoefreet - look in /usr/local/share/pixmaps too
Carsten Haitzler (Rasterman) [Thu, 16 Apr 2020 12:03:45 +0000 (13:03 +0100)]
efreet - look in /usr/local/share/pixmaps too

4 years agoevas_textblock : fix text insertion & selection with ps in single line
Ali [Thu, 16 Apr 2020 11:03:31 +0000 (20:03 +0900)]
evas_textblock : fix text insertion & selection with ps in single line

Summary:
when we have text that contains <ps> (example "p1<ps>p2") in a single line mode
and the cursor position is after the ps tag
then we try to insert any character using the keyboard it will show segmentation fault.
also with the same text if we try to select the text we will notice that it is corrupted.

this should resolve https://phab.enlightenment.org/T8594

Test Plan:
  #define EFL_EO_API_SUPPORT 1
  #define EFL_BETA_API_SUPPORT 1

  #include <Eina.h>
  #include <Elementary.h>
  #include <Efl_Ui.h>

  static void
  _gui_quit_cb(void *data EINA_UNUSED, const Efl_Event *event EINA_UNUSED)
  {
     efl_exit(0);
  }

  static void
  _gui_setup()
  {
     Eo *win, *box;

     win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get(),
                   efl_ui_win_type_set(efl_added, EFL_UI_WIN_TYPE_BASIC),
                   efl_text_set(efl_added, "Hello World"),
                   efl_ui_win_autodel_set(efl_added, EINA_TRUE));

     // when the user clicks "close" on a window there is a request to delete
     efl_event_callback_add(win, EFL_UI_WIN_EVENT_DELETE_REQUEST, _gui_quit_cb, NULL);

     box = efl_add(EFL_UI_BOX_CLASS, win,
                  efl_content_set(win, efl_added),
                  efl_gfx_hint_size_min_set(efl_added, EINA_SIZE2D(360, 240)));

     Eo *text = efl_add(EFL_UI_TEXTBOX_CLASS, box,
             efl_gfx_hint_weight_set(efl_added, 1.0, 1.0),
             efl_gfx_hint_align_set(efl_added, 1.0, 1.0),
             efl_pack(box, efl_added));

             efl_text_interactive_selection_allowed_set(text, EINA_TRUE);
             efl_text_multiline_set(text,EINA_FALSE);

             efl_text_markup_set(text, "p1<ps>p2");
  }

  EAPI_MAIN void
  efl_main(void *data EINA_UNUSED, const Efl_Event *ev EINA_UNUSED)
  {
     _gui_setup();
  }
  EFL_MAIN()

Reviewers: ali.alzyod, woohyun, zmike, bu5hm4n, segfaultxavi, stefan_schmidt

Reviewed By: ali.alzyod, woohyun

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11621

4 years agotoolbar - dont create icon objects then del if icon is null
Carsten Haitzler (Rasterman) [Thu, 16 Apr 2020 08:58:02 +0000 (09:58 +0100)]
toolbar - dont create icon objects then del if icon is null

if icon is null just never create an icon obj.. but if it's not null
it's intended so even if blank, don't delete it - so things line up.

4 years agoRevert "evas: text_cursor: check return value and print error"
Stefan Schmidt [Thu, 16 Apr 2020 09:12:50 +0000 (11:12 +0200)]
Revert "evas: text_cursor: check return value and print error"

This reverts commit c6df676a70b0e66f67d053982a46b030805b956b.

Thsi is failing the evas testsuite. My bad in not checking this locally
before commiting.

4 years agoevas_common_font: prevent leaking RGBA_Font
Ali [Wed, 15 Apr 2020 10:30:15 +0000 (10:30 +0000)]
evas_common_font: prevent leaking RGBA_Font

prevent leaking RGBA_Font in the for loop,

CID: 1382852

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11709

4 years agoevas: text_cursor: check return value and print error
Ali [Wed, 15 Apr 2020 07:58:17 +0000 (07:58 +0000)]
evas: text_cursor: check return value and print error

Make sure we check the return of evas_textblock_cursor_geometry_bidi_get() and print an error if needed.

CID:1425191

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11707

4 years agoecore_cocoa: fix compile error using 10.15 SDK
Bo Anderson [Wed, 11 Mar 2020 00:34:28 +0000 (00:34 +0000)]
ecore_cocoa: fix compile error using 10.15 SDK

4 years agogenlist : deffer on focus update to find proper focus item
SangHyeon Jade Lee [Tue, 14 Apr 2020 08:09:34 +0000 (17:09 +0900)]
genlist : deffer on focus update to find proper focus item

Change-Id: I6315c42075eb1ec6b60714c93ca6de633ef070fd

4 years agoEfl.Canvas.Vg.Container: Prevent duplicate transpacency calculation.
JunsuChoi [Tue, 14 Apr 2020 02:38:27 +0000 (11:38 +0900)]
Efl.Canvas.Vg.Container: Prevent duplicate transpacency calculation.

Summary:
If Vg.Container has transparency, this is calculated by _evas_vg_render
in Efl.Canvas.Vg.Object. Therefore, there is no need to propagate
the transparency of the container to the child. _evas_vg_render pre-draws
all children and calculates transparency in batches for avoid duplicate calculation.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11692

Change-Id: I6e5ddcc7067c9c063918cd6ca545aa8679d66a5b

4 years agoEctor: Refer to visibility of Ector_Renderer when doing rle_update.
JunsuChoi [Mon, 13 Apr 2020 04:41:17 +0000 (13:41 +0900)]
Ector: Refer to visibility of Ector_Renderer when doing rle_update.

Summary:
An object with visibility false may not have a normal path or data.
It can cause invalid access or affect other ector renderers.
This is a patch to prevent them.

Test Plan: N/A

Reviewers: Hermet, kimcinoo, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11689

Change-Id: I6b587be1a24cf3208d749564fc9e24ce25ae299a

4 years ago[Gengrid] Circular Gengrid
hyunseok yang [Mon, 13 Apr 2020 08:31:52 +0000 (17:31 +0900)]
[Gengrid] Circular Gengrid

Change-Id: I8cc34390cfc1d496fd75806b12bb2289108d2189
Signed-off-by: hyunseok yang <hs0219.yang@samsung.com>
4 years agogenlist : apply show_center_align internal API to support wearable OneUi
SangHyeon Jade Lee [Mon, 13 Apr 2020 09:18:42 +0000 (18:18 +0900)]
genlist : apply show_center_align internal API to support wearable OneUi

Change-Id: I17fca8b5f139b5ddc12ea68d98909d9107bebce7

4 years agogenlist: fix wrong return type
SangHyeon Jade Lee [Mon, 13 Apr 2020 06:41:01 +0000 (15:41 +0900)]
genlist: fix wrong return type

Change-Id: Ie559847ca82d5d999148458916c4d58e99efc914

4 years agoindex: Change dot's color on bezel rotation
HyukSoon Choi [Mon, 13 Apr 2020 06:14:47 +0000 (15:14 +0900)]
index: Change dot's color on bezel rotation

Change-Id: Ib97249bc205229f4333ea0f9b048fc94c4603f40
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
4 years ago[naviframe] Add signal for text sliding on genlist title item.
hyunseok yang [Fri, 10 Apr 2020 07:05:53 +0000 (16:05 +0900)]
[naviframe] Add signal for text sliding on genlist title item.

[Model] Tizen5.5
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] N/A
[Problem] Add signal for text sliding on genlist title item.
[Measure] N/A
[Checking Method] N/A
[Team] UIFW
[Developer] hyunseok yang
[Change Type] Commit Propagation

Change-Id: I94fcfb0573f64adfc9a5eb42216545b0f3c2e45a
Signed-off-by: hyunseok yang <hs0219.yang@samsung.com>
4 years agoefl_ui_clock: remove unused API - field_value_apply
HyukSoon Choi [Mon, 13 Apr 2020 01:54:12 +0000 (10:54 +0900)]
efl_ui_clock: remove unused API - field_value_apply

Change-Id: I5b63a4ebd515683e35a5d8717346d3618aac30bb
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
4 years agoClear highlight here to increase performance instead of push finished
hyunseok yang [Fri, 10 Apr 2020 03:57:45 +0000 (12:57 +0900)]
Clear highlight here to increase performance instead of push finished

Change-Id: Ice8d23ad2887228d9aaa772e0ec96ed1618da313
Signed-off-by: hyunseok yang <hs0219.yang@samsung.com>
4 years agoupdate po
HyukSoon Choi [Thu, 9 Apr 2020 09:59:31 +0000 (18:59 +0900)]
update po

- add new msgid : WDS_DB_TBBODY_DOUBLE_TAP_TO_VIEW_DETAILS

Change-Id: Ica93d2c803579c28682f717173940ebf6c687cba
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
4 years agoedje_legacy: emit text changed signal
Seungwan woo [Wed, 8 Apr 2020 06:11:16 +0000 (15:11 +0900)]
edje_legacy: emit text changed signal

Change-Id: I4df5d41615a778059bb9bed3617d6fd78e94fd35
Signed-off-by: Seungwan woo <s-w.woo@samsung.com>
4 years agoGenlist: Avoid highlight animation on opening of genlist / item show
godlytalias14573465 [Thu, 9 Apr 2020 11:11:41 +0000 (16:41 +0530)]
Genlist: Avoid highlight animation on opening of genlist / item show

Change-Id: I5877a6c3e626440cdb452793338dec193b72adaf
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
4 years agoefl_ui_check - Handle any non-zero value
HyukSoon Choi [Tue, 7 Apr 2020 09:55:12 +0000 (18:55 +0900)]
efl_ui_check - Handle any non-zero value

Change-Id: Iff6ccce26b9b826a1c46dd7fcc2b3515bcbf639f
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
4 years agoedje_calc: adding null pointer exception to avoid crash
Seungwan woo [Wed, 8 Apr 2020 05:00:46 +0000 (14:00 +0900)]
edje_calc: adding null pointer exception to avoid crash

Change-Id: I917e5f392b4382775ed9939063a210f4553ca36d
Signed-off-by: Seungwan woo <s-w.woo@samsung.com>
4 years agoChange tizen_vector for progress according to OneUI1.5
HyukSoon Choi [Wed, 8 Apr 2020 01:20:47 +0000 (10:20 +0900)]
Change tizen_vector for progress according to OneUI1.5

Change-Id: I062f401a8d4ff5702ce26b9b03e4e8b39ce5b337
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
4 years agoGesture Layer: Fix return type
godlytalias14573465 [Thu, 9 Apr 2020 05:21:24 +0000 (10:51 +0530)]
Gesture Layer: Fix return type

Change-Id: Ibcc70983d189e0fff11afd20c976c907dc771120
Signed-off-by: godlytalias14573465 <godly.talias@samsung.com>
4 years agopopup: add safe code for notify position
Taehyub Kim [Thu, 9 Apr 2020 05:25:19 +0000 (14:25 +0900)]
popup: add safe code for notify position

when calculating scroller size, notify position y value is used.
If parent position of notify is changed, the position of notify should be recalculated
for calculating correct scroller size.

Change-Id: I58a4f51ab39ab13844a0354cff761b8dc237ffc4

4 years agodatetime - Added a hook to get the current value of fields
HyukSoon Choi [Fri, 3 Apr 2020 07:22:26 +0000 (16:22 +0900)]
datetime - Added a hook to get the current value of fields

Change-Id: I525ad767c5f3b11459bc8b3ec53556665b1e2701
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
4 years agospec: resolve migration build error submit/tizen/20200416.001154
Jongmin Lee [Wed, 15 Apr 2020 23:09:20 +0000 (08:09 +0900)]
spec: resolve migration build error

8cb3113...meson: do not install namespace problem legacy files

This commit skip installing some of eo files, so that modify spec
file accordingly.

Change-Id: I6fffca56dcf7f4176ca50cb87b4ff7a4bbc66410

4 years agotests/efl: use alloca for composite model test future to avoid leak
Mike Blumenkrantz [Wed, 15 Apr 2020 14:44:09 +0000 (10:44 -0400)]
tests/efl: use alloca for composite model test future to avoid leak

CID 1407236

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11711

4 years agoelm menu - fix segv on deletion/shutdown where parent was not done ok
Carsten Haitzler (Rasterman) [Wed, 15 Apr 2020 12:02:54 +0000 (13:02 +0100)]
elm menu - fix segv on deletion/shutdown where parent was not done ok

@fix

4 years agorelease: Update NEWS and bump version for 1.24.0-beta2 release
Stefan Schmidt [Wed, 15 Apr 2020 11:50:55 +0000 (13:50 +0200)]
release: Update NEWS and bump version for 1.24.0-beta2 release