platform/upstream/dotnet/runtime.git
5 years agoRemove obsolete CodeCoverageAssemblyAttribute (dotnet/corefx#41674)
Viktor Hofer [Wed, 9 Oct 2019 13:27:48 +0000 (15:27 +0200)]
Remove obsolete CodeCoverageAssemblyAttribute (dotnet/corefx#41674)

Commit migrated from https://github.com/dotnet/corefx/commit/e0ad7cfd08719242c4613ffb9574cd77328a7ba6

5 years agoTiny typo in polymorphic (dotnet/corefx#41678)
Stefan [Wed, 9 Oct 2019 13:24:39 +0000 (15:24 +0200)]
Tiny typo in polymorphic (dotnet/corefx#41678)

Tiny typo in polymorphic

Commit migrated from https://github.com/dotnet/corefx/commit/30b2d788a1687e8aded0ba51a6122635a4d2eb1a

5 years agoHttpstress: add max execution time argument (dotnet/corefx#41643)
Eirik Tsarpalis [Wed, 9 Oct 2019 10:53:42 +0000 (11:53 +0100)]
Httpstress: add max execution time argument (dotnet/corefx#41643)

HttpStress: add max execution time arg

Adds -maxExecutionTime cli argument.
Enables nullable annotations.

Commit migrated from https://github.com/dotnet/corefx/commit/630924d0ccfbac62195927c0f4514fe33d47c729

5 years agoAdd support for reading/writing key files for explicit parameter ECC
Jeremy Barton [Wed, 9 Oct 2019 05:56:00 +0000 (22:56 -0700)]
Add support for reading/writing key files for explicit parameter ECC

Add support for reading/writing key files for explicit parameter ECC

* Prime curves
  * ECPrivateKey
  * Pkcs8
  * EncryptedPkcs8
  * SubjectPublicKeyInfo
* Characteristic-2 curves
  * ECPrivateKey
  * Pkcs8
  * EncryptedPkcs8
  * SubjectPublicKeyInfo

Commit migrated from https://github.com/dotnet/corefx/commit/a7ee8cdccce7d2607d58f9b93ce319209a238f7a

5 years agoSeveral improvements to SocketsHttpHandler perf (dotnet/corefx#41640)
Stephen Toub [Wed, 9 Oct 2019 01:22:47 +0000 (21:22 -0400)]
Several improvements to SocketsHttpHandler perf (dotnet/corefx#41640)

* Do not force-parse TryAddWithoutValidation headers in SocketsHttpHandler

When enumerating headers to write them out, do not force them to be parsed if the user explicitly asked for them not to be with "WithoutValidation".  If the key/values are incorrectly formatted, the request may end up being written incorrectly on the wire, but that's up to the developer explicitly choosing it.

* Revert HttpRequestHeaders.ExpectContinue optimization

Several releases ago, when we weren't paying attention to ExpectContinue, we optimized away the backing field for it into a lazily-initialized collection; that made it cheaper when not accessed but more expensive when accessed, which was fine, as we wouldn't access it from the implementation and developers would rarely set it.  But now SocketsHttpHandler checks it on every request, which means we're paying for the more expensive thing always. So, revert the optimization for this field.

* Avoid allocating a string[] per header

When we enumerate the headers to write them out, we currently allocate a string[] for each.  We can instead just fill the same array over and over and over.

Commit migrated from https://github.com/dotnet/corefx/commit/4d346a9ab7b6e619dae3784283acb87bb7a825c9

5 years agoHandle "too small" success from CNG and clear out decryption residuals
Jeremy Barton [Tue, 8 Oct 2019 20:37:58 +0000 (13:37 -0700)]
Handle "too small" success from CNG and clear out decryption residuals

* When NCryptEncrypt or NCryptDecrypt reports success with a cbResult value that doesn't make sense, normalize the error to NTE_BUFFER_TOO_SMALL.
* When resizing arrays for the array-returning implementation, clear out the temporary arrays to reduce the amount of time they're sitting in memory before the GC clears the memory for reissuance.

Commit migrated from https://github.com/dotnet/corefx/commit/7c586d32edce94c910fc8b402f4adedaa3cf05fd

5 years agoAddress misc feedback and issues from recent perf changes (dotnet/corefx#41414)
Steve Harter [Tue, 8 Oct 2019 20:02:15 +0000 (15:02 -0500)]
Address misc feedback and issues from recent perf changes (dotnet/corefx#41414)

Commit migrated from https://github.com/dotnet/corefx/commit/8655ef98455f8a8924a4ab4ff62009c1a23d4033

5 years agoUpdate hex value for DarkSeaGreen color (dotnet/corefx#41561)
Zappy Zhao [Tue, 8 Oct 2019 18:54:37 +0000 (11:54 -0700)]
Update hex value for DarkSeaGreen color (dotnet/corefx#41561)

Commit migrated from https://github.com/dotnet/corefx/commit/ebb2d2e05f3dc5932696123c42fd3ca3d1469d4d

5 years agoAdd ImmutableInterlocked.Update overloads for ImmutableArray (dotnet/corefx#41600)
Stephen Toub [Tue, 8 Oct 2019 18:46:26 +0000 (14:46 -0400)]
Add ImmutableInterlocked.Update overloads for ImmutableArray (dotnet/corefx#41600)

* Add ImmutableInterlocked.Update overloads for ImmutableArray

The implementations and tests just copy the exist Update overloads, tweaked to work with ImmutableArray.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/9de37814fe28f497c8679b52772f2e5dd7f73306

5 years agoDisable finalization of bogus SafeWaitHandles (dotnet/corefx#41636)
Jan Kotas [Tue, 8 Oct 2019 18:33:47 +0000 (11:33 -0700)]
Disable finalization of bogus SafeWaitHandles (dotnet/corefx#41636)

Fixes dotnet/corefx#41635

Commit migrated from https://github.com/dotnet/corefx/commit/72f5cff116fdfa71f44090281e091b0dcbc31f8f

5 years agoMerge pull request dotnet/corefx#41639 from dotnet/ViktorHofer-domainsock
David Shulman [Tue, 8 Oct 2019 18:22:18 +0000 (11:22 -0700)]
Merge pull request dotnet/corefx#41639 from dotnet/ViktorHofer-domainsock

Disable UnixDomainSock ConcurrentSendReceive test

Commit migrated from https://github.com/dotnet/corefx/commit/70abb3e52f2b744f2f9d8de77dc1175baec5eb88

5 years agoBumping the version of OOB packages to match product version (dotnet/corefx#41623)
Anirudh Agnihotry [Tue, 8 Oct 2019 18:06:55 +0000 (11:06 -0700)]
Bumping the version of OOB packages to match product version (dotnet/corefx#41623)

* update package version for oob packages as well

* ServiceVersion -> PatchVersion

Commit migrated from https://github.com/dotnet/corefx/commit/4e0541e71d7ff69aaebccd28ca8b6b7dba9e76ee

5 years agoPrevent ImplicitTransform of index getter method (dotnet/corefx#41418)
John Salem [Tue, 8 Oct 2019 17:58:42 +0000 (10:58 -0700)]
Prevent ImplicitTransform of index getter method (dotnet/corefx#41418)

* Prevent TransformSpec from attempting to implicitly create a delegate for index properties

* Add tests

Commit migrated from https://github.com/dotnet/corefx/commit/2b8d0577ee97ff312ef074ab36f264ebedcccfbf

5 years agoRemove System.Linq dependency from System.Security.Cryptography.X509Certificates
Stephen Toub [Tue, 8 Oct 2019 16:57:21 +0000 (12:57 -0400)]
Remove System.Linq dependency from System.Security.Cryptography.X509Certificates

System.Linq was only being used in two places:
- In Pkcs10CertificateRequestInfo, it was using Collection<>.Select(...).ToArray().  We can replace it with a simple for loop, which is both faster (e.g. fewer delegate invocations) and fewer generic instantiations (no one else is going to have an instantiation with AttributeAsn).
- In LoadMachineStores on Linux, it was using Prepend.  We can avoid the need for Prepend (and the associated allocations) entirely by slightly reorganizing the method and using a local function.

Commit migrated from https://github.com/dotnet/corefx/commit/5ad15fcb189a9c232051d03c1e889f985f62232b

5 years agoDisable UnixDomainSock ConcurrentSendReceive test
Viktor Hofer [Tue, 8 Oct 2019 16:12:37 +0000 (18:12 +0200)]
Disable UnixDomainSock ConcurrentSendReceive test

Commit migrated from https://github.com/dotnet/corefx/commit/3f2b7a06a585e26fffd20cbe0984177b092198d7

5 years agoAvoid non documented exceptions in BinaryFormatter.Deserialize (dotnet/corefx#40215)
birkmose [Tue, 8 Oct 2019 16:07:03 +0000 (18:07 +0200)]
Avoid non documented exceptions in BinaryFormatter.Deserialize (dotnet/corefx#40215)

* dotnet/corefx#35491 Fixes issue with BinaryFormatter.Deserialize throwing other exceptions than those specified in the documentation (only supposed to throw SerializationException or SecurityException).

* Update UnitySerializationHolderTests to test the expected behaviour of BinaryFormatter.Deserialize. Fix naming error in SerializationGuardTests.

Commit migrated from https://github.com/dotnet/corefx/commit/1736bfa5f06d4d3a60742142f0aaf601bd4db788

5 years agoHttpWebRequest caches HttpClient in simple cases (dotnet/corefx#41462)
Alexander Nikolaev [Tue, 8 Oct 2019 09:22:15 +0000 (11:22 +0200)]
HttpWebRequest caches HttpClient in simple cases (dotnet/corefx#41462)

HttpWebRequest caches and tries to reuse a single static HttpClient instance when it's safe to share the same instance among concurrent requests with the given parameters.
Fixes dotnet/corefx#15460

Commit migrated from https://github.com/dotnet/corefx/commit/95e35e10d7c52a7eea38c2ae6402d29e2a01efc6

5 years agoFix copy&paste globalization test bug (dotnet/corefx#41624)
Jan Kotas [Tue, 8 Oct 2019 05:16:18 +0000 (22:16 -0700)]
Fix copy&paste globalization test bug (dotnet/corefx#41624)

Commit migrated from https://github.com/dotnet/corefx/commit/c1092870c306b8da256e455cec0814486255d0c1

5 years agoImprove test coverage for Span-based globalization APIs (dotnet/corefx#41224)
Jan Kotas [Mon, 7 Oct 2019 23:22:34 +0000 (16:22 -0700)]
Improve test coverage for Span-based globalization APIs (dotnet/corefx#41224)

* Improve test coverage for Span-based globalization APIs

* More interesting test cases

Commit migrated from https://github.com/dotnet/corefx/commit/14d971cdeb7b625bb7b753d48760f2cb98b32358

5 years agoDisable arm64 tests on Win and limit UWP testing (dotnet/corefx#41609)
Viktor Hofer [Mon, 7 Oct 2019 23:15:43 +0000 (01:15 +0200)]
Disable arm64 tests on Win and limit UWP testing (dotnet/corefx#41609)

* Disable arm64 tests on Win and limit UWP testing

Commit migrated from https://github.com/dotnet/corefx/commit/91b7973e902416c73edfa345a5c7ae945707d29e

5 years agoDisable flaky member descriptor test (dotnet/corefx#41613)
Viktor Hofer [Mon, 7 Oct 2019 23:14:22 +0000 (01:14 +0200)]
Disable flaky member descriptor test (dotnet/corefx#41613)

Commit migrated from https://github.com/dotnet/corefx/commit/ac07a15aa385abf6f41c6d307c473130336fb8de

5 years agoIgnore ERROR_NOT_FOUND in File.Encrypt test (dotnet/corefx#41604)
Jan Kotas [Mon, 7 Oct 2019 23:10:21 +0000 (16:10 -0700)]
Ignore ERROR_NOT_FOUND in File.Encrypt test (dotnet/corefx#41604)

Makes the test pass when EFS (Encrypted File System) is not available.

I have also fixed the interop definition for Encrypt/DecryptFile P/Invokes while I was on it.

Fixes dotnet/corefx#39211

Commit migrated from https://github.com/dotnet/corefx/commit/8c8bf07d52389d8a2948460d4f7e0dba112c20a0

5 years agoUpdate infra owners (dotnet/corefx#41620)
Eric StJohn [Mon, 7 Oct 2019 22:22:17 +0000 (15:22 -0700)]
Update infra owners (dotnet/corefx#41620)

Commit migrated from https://github.com/dotnet/corefx/commit/72670835126cb48d39f842a3fda021e808944f58

5 years agoRemove unnecessary LINQ usage from System.Text.Json (dotnet/corefx#41553)
Stephen Toub [Mon, 7 Oct 2019 22:01:26 +0000 (18:01 -0400)]
Remove unnecessary LINQ usage from System.Text.Json (dotnet/corefx#41553)

* Remove unnecessary LINQ usage from System.Text.Json

* Fix netstandard build

Commit migrated from https://github.com/dotnet/corefx/commit/2d69a2494b3c1602d9332bab3794e00d1b4858c7

5 years agoFileSystem.Unix.File.Move uses "rename" in more cases (dotnet/corefx#40611)
Sylvain [Mon, 7 Oct 2019 20:50:47 +0000 (22:50 +0200)]
FileSystem.Unix.File.Move uses "rename" in more cases (dotnet/corefx#40611)

* FileSystem.Unix.File.Move use rename in more cases, avoid link/copy when possible, improve performance on file systems that do not support hard links, such as FAT

* Adapt Unit Tests for accounting FileSystemWatcher events fired by FileSystem.Unix.File.Move implementation that use rename in more cases, avoiding link/copy when possible

Commit migrated from https://github.com/dotnet/corefx/commit/89b087ba5548338bb604db4e1cca0e42f8273e2b

5 years agoUpdating corefx prerequisites for latest VS 2019 workloads (dotnet/corefx#41606)
Ahson Khan [Mon, 7 Oct 2019 19:07:30 +0000 (12:07 -0700)]
Updating corefx prerequisites for latest VS 2019 workloads (dotnet/corefx#41606)

* Updating corefx prerequisites for latest VS 2019 workloads

* Add netfx 4.7.2 SDK to the list

Commit migrated from https://github.com/dotnet/corefx/commit/d0ebc1987e8d0f56b00fd23ad0dab8d0ad1f02c3

5 years agoAdd ConcurrentDictionary.TryRemove(KeyValuePair) (dotnet/corefx#41597)
Stephen Toub [Mon, 7 Oct 2019 18:19:57 +0000 (14:19 -0400)]
Add ConcurrentDictionary.TryRemove(KeyValuePair) (dotnet/corefx#41597)

Commit migrated from https://github.com/dotnet/corefx/commit/a62579502cb9e86b761c2249d0d04af3d827b3a3

5 years agoFix naming of System.Text.Json methods in docs (dotnet/corefx#41562)
FyiurAmron [Mon, 7 Oct 2019 15:51:44 +0000 (17:51 +0200)]
Fix naming of System.Text.Json methods in docs (dotnet/corefx#41562)

Commit migrated from https://github.com/dotnet/corefx/commit/81dfdbcad0937707346cadc3968c0c67241c64f8

5 years agoRemove System.Linq dependency from System.Security.Cryptography.Encoding (dotnet...
Stephen Toub [Mon, 7 Oct 2019 15:49:18 +0000 (11:49 -0400)]
Remove System.Linq dependency from System.Security.Cryptography.Encoding (dotnet/corefx#41567)

* Remove System.Linq dependency from System.Security.Cryptography.Encoding

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/2f40d22fddf3e08187a95454958bd42a37ef7ad0

5 years agoAdded a test scenario to verify that Nullable<T> is not assignable from T (dotnet...
Vladimir Sadov [Sun, 6 Oct 2019 22:39:00 +0000 (15:39 -0700)]
Added a test scenario to verify that  Nullable<T> is not assignable from T (dotnet/corefx#41577)

* Added a test scenario to verify that T is not assignable to  Nullable<T>

* PR feedback. Replaced `var` with concrete `Type`.

Commit migrated from https://github.com/dotnet/corefx/commit/38aa9151607cb63bb569beb42880057ba2cd3da0

5 years agoFix HtmlEncode handling of surrogate pairs (dotnet/corefx#41576)
Stephen Toub [Sun, 6 Oct 2019 02:33:18 +0000 (22:33 -0400)]
Fix HtmlEncode handling of surrogate pairs (dotnet/corefx#41576)

Due to a regression that came as part of changing the code from using pointers to using spans, when the surrogate pair isn't at the beginning of the the input, it's incorrectly encoded.

Commit migrated from https://github.com/dotnet/corefx/commit/6de42378223c6cb138d28f812c440092718c7a19

5 years agoExpose, test, and use ExceptionDispatchInfo.SetCurrentStackTrace
Stephen Toub [Sat, 5 Oct 2019 18:12:52 +0000 (14:12 -0400)]
Expose, test, and use ExceptionDispatchInfo.SetCurrentStackTrace

Commit migrated from https://github.com/dotnet/corefx/commit/615990343a9400e46122debf48a5fb08ec452787

5 years agoRemove System.Linq dependency from System.Net.NetworkInformation (dotnet/corefx#41566)
Stephen Toub [Sat, 5 Oct 2019 11:53:40 +0000 (07:53 -0400)]
Remove System.Linq dependency from System.Net.NetworkInformation (dotnet/corefx#41566)

It was only being used on Unix, and the uses are all easily replaced with more efficient implementations.

Commit migrated from https://github.com/dotnet/corefx/commit/e3fe1db114a283b8719ed1d02a1e26d57010cb55

5 years agoRemove unused usings from System.Security.Cryptography.Xml (dotnet/corefx#41568)
Stephen Toub [Sat, 5 Oct 2019 11:34:28 +0000 (07:34 -0400)]
Remove unused usings from System.Security.Cryptography.Xml (dotnet/corefx#41568)

I was looking for uses of "using System.Linq;".  One file had it, but it turned out to be unused/unnecessary, so as long as I was removing it, I ran VS' "remove unused usings" on the project.

Commit migrated from https://github.com/dotnet/corefx/commit/418c2e84dbf159100463f172227fbe7460b36533

5 years agoReplace Stack with Stack<T> in XmlDataLoader (dotnet/corefx#41569)
Stephen Toub [Sat, 5 Oct 2019 11:20:25 +0000 (07:20 -0400)]
Replace Stack with Stack<T> in XmlDataLoader (dotnet/corefx#41569)

This looks like the only remaining uses of the non-generic Stack in a trimmed web api app.

Commit migrated from https://github.com/dotnet/corefx/commit/052f4af24c1ccaa9bb42735fbdc2e99cadef1e66

5 years agoRemoving Microsoft.bcl* packages (dotnet/corefx#41270)
Anirudh Agnihotry [Fri, 4 Oct 2019 23:44:56 +0000 (16:44 -0700)]
Removing Microsoft.bcl* packages (dotnet/corefx#41270)

* removing Microsoft.bcl packages

* targetframework conditions modified

* adding versionless config to avoid binplace

* uap standard conflicts

* remove package configurations

* negation if and remove exclude reference asset property

* adding choosing when statement

* using attribute

* Moveing packages to include to the common

* ChooseWhen -> IF

Commit migrated from https://github.com/dotnet/corefx/commit/99ea2b5aebf7361a5baa638c978cb6214fca5217

5 years agoRemove System.Linq dependency from System.Security.Cryptography.Algorithms (dotnet...
Stephen Toub [Fri, 4 Oct 2019 23:14:30 +0000 (19:14 -0400)]
Remove System.Linq dependency from System.Security.Cryptography.Algorithms (dotnet/corefx#41554)

It's not being used.  Remove it.

Commit migrated from https://github.com/dotnet/corefx/commit/a434a52ae3f1175bc1cad8b1a02b0921ef3b1f55

5 years agoRemove unnecessary System.Linq usage from Microsoft.CSharp (dotnet/corefx#41552)
Stephen Toub [Fri, 4 Oct 2019 20:53:22 +0000 (16:53 -0400)]
Remove unnecessary System.Linq usage from Microsoft.CSharp (dotnet/corefx#41552)

Most of the usage was just as easily (if not more easily) done without LINQ.  In some cases the use was entirely superfluous (e.g. MethodReturningNewArray().ToArray()).

Commit migrated from https://github.com/dotnet/corefx/commit/09698dd91c53e123d3a0f1240b5f611b3c14639c

5 years agoReplace PrintF with Console.WriteLine and cleanups (dotnet/corefx#41540)
Adeel Mujahid [Fri, 4 Oct 2019 18:48:15 +0000 (21:48 +0300)]
Replace PrintF with Console.WriteLine and cleanups (dotnet/corefx#41540)

* Replace PrintF with Console.WriteLine and cleanups

* PR feedback: simplify WriteLine arguments

Commit migrated from https://github.com/dotnet/corefx/commit/c28a9e69902bcbc0d742732630bd6e82ac922d5b

5 years agoupdating packageindex with stable versions (dotnet/corefx#41511)
Anirudh Agnihotry [Fri, 4 Oct 2019 15:29:14 +0000 (08:29 -0700)]
updating packageindex with stable versions (dotnet/corefx#41511)

* updating packageindex with stable versions

* disabling harverst stable packages

Commit migrated from https://github.com/dotnet/corefx/commit/b5ef4ea045bdd3dc8d528e6408360bf812eefd17

5 years agoDemonstrate converters for Dictionary<TKey, TValue> where TKey is not String (dotnet...
Steve Harter [Thu, 3 Oct 2019 22:49:04 +0000 (17:49 -0500)]
Demonstrate converters for Dictionary<TKey, TValue> where TKey is not String (dotnet/corefx#41469)

Commit migrated from https://github.com/dotnet/corefx/commit/eff9fbf446468ca411bf5e0475916f316eea7223

5 years ago Consolidate PrintController code and cleanup some interop (dotnet/corefx#36736)
Hugh Bellamy [Thu, 3 Oct 2019 21:42:42 +0000 (22:42 +0100)]
 Consolidate PrintController code and cleanup some interop (dotnet/corefx#36736)

* Consolidate PrintController code and cleanup some interop

* Cleanup access modifiers in PrintDocument

* Add tests and fix debug assert failures

* Remove argument validation from APIs that should be called from internal members only and update tests

Commit migrated from https://github.com/dotnet/corefx/commit/07262aa6bce06f1e270e6a9b494bfe6eb1260b08

5 years agoAdd CollectionsMarshal ref assemblies (dotnet/corefx#41306)
Ben Adams [Thu, 3 Oct 2019 20:25:00 +0000 (21:25 +0100)]
Add CollectionsMarshal ref assemblies (dotnet/corefx#41306)

* Add CollectionsMarshal

* Feedback

* nits

* Feedback

* Update src/System.Runtime.InteropServices/tests/System/Runtime/InteropServices/CollectionsMarshalTests.cs

Co-Authored-By: Ahson Khan <ahkha@microsoft.com>
* Reference collections

Commit migrated from https://github.com/dotnet/corefx/commit/74cfdadd73fc5bc385727ea9e9d7f368926f29fc

5 years agoUpdate coding-style.md (dotnet/corefx#41506)
Haresh Ambaliya [Thu, 3 Oct 2019 19:55:51 +0000 (01:25 +0530)]
Update coding-style.md (dotnet/corefx#41506)

* Update coding-style.md

Changed Keyboard shortcut to show white space.

* Update coding-style.md

@gfoidl I have added about how to enable View White Space. I think we are good now.

Commit migrated from https://github.com/dotnet/corefx/commit/d39276b9d4af15aebd829eaf1fbd7d43212a1f15

5 years ago[System.Drawing.Common] Fix argument name in exception of Bitmap constructor (dotnet...
Filip Navara [Thu, 3 Oct 2019 17:59:55 +0000 (19:59 +0200)]
[System.Drawing.Common] Fix argument name in exception of Bitmap constructor (dotnet/corefx#41494)

* [System.Drawing.Common] Fix argument name in exception of Bitmap constructor

* Fix test for NetFX

Commit migrated from https://github.com/dotnet/corefx/commit/78c2b959d814fffd2345d056576fe417a9405751

5 years agoUpdate experimental IsShipping and block stable properties (dotnet/corefx#41513)
Santiago Fernandez Madero [Thu, 3 Oct 2019 16:26:07 +0000 (09:26 -0700)]
Update experimental IsShipping and block stable properties (dotnet/corefx#41513)

Commit migrated from https://github.com/dotnet/corefx/commit/d217998bc5a3dfdc21ae22dd6161ea6c8f71f30c

5 years ago[System.Drawing.Common] Relax IconTests.CorrectColorDepthExtracted test (dotnet/coref...
Filip Navara [Thu, 3 Oct 2019 01:19:22 +0000 (03:19 +0200)]
[System.Drawing.Common] Relax IconTests.CorrectColorDepthExtracted test (dotnet/corefx#41495)

* [System.Drawing.Common] Relax IconTests.CorrectColorDepthExtracted to work on newer libgdiplus on Unix

* Address PR comment

Commit migrated from https://github.com/dotnet/corefx/commit/a50e056c5a62fb6dfe2e9475be47b93d33661700

5 years ago[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41280)
dotnet-maestro[bot] [Thu, 3 Oct 2019 00:36:36 +0000 (00:36 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#41280)

* Add unit tests for Utf8Span, react to Utf8String changes

* Regenerating the reference sources for System.Runtime.Intrinsics.Experimental

* Update dependencies from https://github.com/dotnet/coreclr build 20191001.3

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19501.3
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19501.3
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19501.3

* Move corefx alpine build containers to 3.9

Commit migrated from https://github.com/dotnet/corefx/commit/c8c2917540a568869ba761afa6e4dba6edeb433b

5 years agoIncreasing arm64 timeout on Linux (dotnet/corefx#41504)
Viktor Hofer [Wed, 2 Oct 2019 17:54:42 +0000 (19:54 +0200)]
Increasing arm64 timeout on Linux (dotnet/corefx#41504)

Commit migrated from https://github.com/dotnet/corefx/commit/fa9b26c9eeaadac927dbec4857c3c4f214d666c9

5 years agoPrevent Setting SmtpClient.UseDefaultCredentials clearing Credentials (dotnet/corefx...
Nabeel Valley [Wed, 2 Oct 2019 01:07:26 +0000 (03:07 +0200)]
Prevent Setting SmtpClient.UseDefaultCredentials clearing Credentials (dotnet/corefx#41271)

* Ensure setting UseDefaultCredentials to False does not clear Credentials

* Remove reference comments

* Rename tests to align with convention

* Correctly set _transport.Credentials

* Include SmtpClient._transport.Credentials in tests, move tests to own file

* Change filename and refactor UN/PW

Commit migrated from https://github.com/dotnet/corefx/commit/dcc9f626eeb0751d4ba4499f623aac42d2e95c10

5 years agoDon't display any GUI during test run. (dotnet/corefx#38042)
joshudson [Tue, 1 Oct 2019 22:53:50 +0000 (15:53 -0700)]
Don't display any GUI during test run. (dotnet/corefx#38042)

Commit migrated from https://github.com/dotnet/corefx/commit/6c892a14e4da5e1ec0c5c766c7625c4d2d51ffb6

5 years agoSynchronize Http/2 HPack implementation between CoreFx and ASP.NET Core (dotnet/coref...
Justin Kotalik [Tue, 1 Oct 2019 22:36:01 +0000 (07:36 +0900)]
Synchronize Http/2 HPack implementation between CoreFx and ASP.NET Core (dotnet/corefx#41069)

Commit migrated from https://github.com/dotnet/corefx/commit/547a2936f07203ad7ac03603fa96d443542ee307

5 years agoSmtpClientTest.TestZeroTimeout: FailFast to get CI coredump (dotnet/corefx#41087)
Tom Deseyn [Tue, 1 Oct 2019 21:29:33 +0000 (23:29 +0200)]
SmtpClientTest.TestZeroTimeout: FailFast to get CI coredump (dotnet/corefx#41087)

* SmtpClientTest.TestZeroTimeout: FailFast to get CI coredump

* Remove nop else block

Commit migrated from https://github.com/dotnet/corefx/commit/4a223a0bd4d539dce1b5eea3f7657ada5217baeb

5 years agofreezing the version for the pipes (dotnet/corefx#41473)
Anirudh Agnihotry [Tue, 1 Oct 2019 21:04:34 +0000 (14:04 -0700)]
freezing the version for the pipes (dotnet/corefx#41473)

Commit migrated from https://github.com/dotnet/corefx/commit/3619b5d8367ddabcf9945479a98018fab891b486

5 years agoRemove unnecessary dependencies from System.Net.Http (dotnet/corefx#41470)
Stephen Toub [Tue, 1 Oct 2019 19:43:41 +0000 (15:43 -0400)]
Remove unnecessary dependencies from System.Net.Http (dotnet/corefx#41470)

Commit migrated from https://github.com/dotnet/corefx/commit/e4cfb1761f20b182919db2aeb6ba92b48492c469

5 years agoDisable Save_SimpleSettings_Ok test in all platforms (dotnet/corefx#41477)
Santiago Fernandez Madero [Tue, 1 Oct 2019 19:42:47 +0000 (12:42 -0700)]
Disable Save_SimpleSettings_Ok test in all platforms (dotnet/corefx#41477)

Commit migrated from https://github.com/dotnet/corefx/commit/39cdcd49b65c642673f3c5eb229f6a1cede6a832

5 years agoAnnotate System.Diagnostics.DiagnosticSource for nullable (dotnet/corefx#41241)
buyaa-n [Tue, 1 Oct 2019 18:52:31 +0000 (11:52 -0700)]
Annotate System.Diagnostics.DiagnosticSource for nullable (dotnet/corefx#41241)

* Annotate System.Diagnostics.DiagnosticSource for nullable

Commit migrated from https://github.com/dotnet/corefx/commit/c5ab5e44f1ea915e45d74e8d3f4fa0af2b645805

5 years agofix broken link (dotnet/corefx#41471)
Fyers [Tue, 1 Oct 2019 17:04:45 +0000 (19:04 +0200)]
fix broken link (dotnet/corefx#41471)

Commit migrated from https://github.com/dotnet/corefx/commit/b50cbccbb844fbb05bb36826a51a2824bd5fbaa5

5 years agoUpdate issue-guide.md
Karel Zikmund [Tue, 1 Oct 2019 16:53:35 +0000 (09:53 -0700)]
Update issue-guide.md

Fixing GH handle of @saurabh500

Commit migrated from https://github.com/dotnet/corefx/commit/fff161638cc714f66fe06155049afdb01a97949b

5 years agoFind zip file end of central directory backwards up to max possible size (resubmit...
Carlos Sanchez Lopez [Tue, 1 Oct 2019 16:10:58 +0000 (09:10 -0700)]
Find zip file end of central directory backwards up to max possible size (resubmit due to build break) (dotnet/corefx#41451)

Issue
Huge zip files without an end of central directory take a long time to throw because we seek to the end then search backwards for the EOCD signature all the way to the end.

Fix
Ensure we only search for the signature from the end within the maximum possible number of bytes where it can be found. If the signature is not found, we fail faster.
Submitting again due to build break caused by a conflict in the files modified by this commit.

Note
This may be a breaking change for the edge case where a zip file contains an EOCD comment with the maximum length + additional trailing garbage.

Commit migrated from https://github.com/dotnet/corefx/commit/861259bf87d8e4ee2c4f8dab31b73d377faff77d

5 years ago[WIP] Try fixing failing IpPacketInformationTest (dotnet/corefx#41411)
Eirik Tsarpalis [Mon, 30 Sep 2019 23:32:12 +0000 (16:32 -0700)]
[WIP] Try fixing failing IpPacketInformationTest (dotnet/corefx#41411)

Try fixing failing IpPacketInformationTest

Commit migrated from https://github.com/dotnet/corefx/commit/969ce665afee70b2d591e5c271525c927a8834d0

5 years ago[master] Update dependencies from 4 repositories (dotnet/corefx#41424)
dotnet-maestro[bot] [Mon, 30 Sep 2019 22:19:00 +0000 (22:19 +0000)]
[master] Update dependencies from 4 repositories (dotnet/corefx#41424)

* Update dependencies from https://github.com/dotnet/arcade build 20190927.2

- Microsoft.DotNet.XUnitExtensions - 5.0.0-beta.19477.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19477.2
- Microsoft.DotNet.VersionTools.Tasks - 5.0.0-beta.19477.2
- Microsoft.DotNet.ApiCompat - 5.0.0-beta.19477.2
- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.19477.2
- Microsoft.DotNet.Build.Tasks.Configuration - 5.0.0-beta.19477.2
- Microsoft.DotNet.Build.Tasks.Feed - 5.0.0-beta.19477.2
- Microsoft.DotNet.Build.Tasks.Packaging - 5.0.0-beta.19477.2
- Microsoft.DotNet.CodeAnalysis - 5.0.0-beta.19477.2
- Microsoft.DotNet.CoreFxTesting - 5.0.0-beta.19477.2
- Microsoft.DotNet.GenAPI - 5.0.0-beta.19477.2
- Microsoft.DotNet.GenFacades - 5.0.0-beta.19477.2
- Microsoft.DotNet.Helix.Sdk - 5.0.0-beta.19477.2
- Microsoft.DotNet.RemoteExecutor - 5.0.0-beta.19477.2

* Update dependencies from https://github.com/dotnet/core-setup build 20190927.25

- Microsoft.NETCore.App - 5.0.0-alpha1.19477.25
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19477.25
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19477.25

* Update dependencies from https://github.com/dotnet/corefx build 20190927.7

- runtime.native.System.IO.Ports - 5.0.0-alpha1.19477.7
- Microsoft.NETCore.Platforms - 5.0.0-alpha1.19477.7

* Update dependencies from https://github.com/dotnet/standard build 20190927.1

- NETStandard.Library - 2.2.0-prerelease.19477.1

* Update dependencies from https://github.com/dotnet/core-setup build 20190928.4

- Microsoft.NETCore.App - 5.0.0-alpha1.19478.4
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19478.4
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19478.4

* Update dependencies from https://github.com/dotnet/standard build 20190928.2

- NETStandard.Library - 2.2.0-prerelease.19478.2

* Update dependencies from https://github.com/dotnet/core-setup build 20190929.2

- Microsoft.NETCore.App - 5.0.0-alpha1.19479.2
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19479.2
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19479.2

* Enable nullable in source projects that are full facades and generate a
not supported assembly with annotations in it

Commit migrated from https://github.com/dotnet/corefx/commit/4eece5734d828ee8bf3393a04b71d80d5d5e4828

5 years agoRevert "Find zip file end of central directory backwards up to max possible size...
Eric StJohn [Mon, 30 Sep 2019 20:04:17 +0000 (13:04 -0700)]
Revert "Find zip file end of central directory backwards up to max possible size (dotnet/corefx#41007)" (dotnet/corefx#41449)

This reverts commit dotnet/corefx@9d9c06f82eb4675a2aa56f07fe55a78039147784.

Commit migrated from https://github.com/dotnet/corefx/commit/a9ebd33cbaef9b9eba9a0dbae178cc2814d62db4

5 years agoUpdate Microsoft.Windows.Compatibility package for WCF and remove S.R.WindowsRuntime...
Santiago Fernandez Madero [Mon, 30 Sep 2019 18:12:29 +0000 (11:12 -0700)]
Update Microsoft.Windows.Compatibility package for WCF and remove S.R.WindowsRuntime* (dotnet/corefx#41419)

Commit migrated from https://github.com/dotnet/corefx/commit/34c1f84b18034406a6b7b91e8af641d22a3bf6ec

5 years agoFind zip file end of central directory backwards up to max possible size (dotnet...
Carlos Sanchez Lopez [Mon, 30 Sep 2019 17:46:27 +0000 (10:46 -0700)]
Find zip file end of central directory backwards up to max possible size (dotnet/corefx#41007)

Issue
Huge zip files without an end of central directory take a long time to throw because we seek to the end then search backwards for the EOCD signature all the way to the end.

Fix
Ensure we only search for the signature from the end within the maximum possible number of bytes where it can be found. If the signature is not found, we fail faster.

Note
This may be a breaking change for the edge case where a zip file contains an EOCD comment with the maximum length + additional trailing garbage.

Commit migrated from https://github.com/dotnet/corefx/commit/9d9c06f82eb4675a2aa56f07fe55a78039147784

5 years agoUpdate System.Data ownership (dotnet/corefx#41416)
Carlos Sanchez Lopez [Mon, 30 Sep 2019 16:26:20 +0000 (09:26 -0700)]
Update System.Data ownership (dotnet/corefx#41416)

Commit migrated from https://github.com/dotnet/corefx/commit/9677a1458017796e4f42ae04c73cffce9e99aef2

5 years agoMake ResolveEventArgs.Name not nullable (dotnet/corefx#41415)
Santiago Fernandez Madero [Fri, 27 Sep 2019 23:23:20 +0000 (16:23 -0700)]
Make ResolveEventArgs.Name not nullable (dotnet/corefx#41415)

Commit migrated from https://github.com/dotnet/corefx/commit/7e9a177824cbefaee8985a9b517ebb0ea2e17a81

5 years agoAdded tests to cover all reachable branches when backed by JsonNode (dotnet/corefx...
AntonLandor [Fri, 27 Sep 2019 22:17:59 +0000 (00:17 +0200)]
Added tests to cover all reachable branches when backed by JsonNode (dotnet/corefx#41252)

Commit migrated from https://github.com/dotnet/corefx/commit/867c317528b0dfcebd608d10968f24320ee316ab

5 years agoAdd CentOS 8 runtime ids (dotnet/corefx#41397)
Omair Majid [Fri, 27 Sep 2019 21:58:00 +0000 (17:58 -0400)]
Add CentOS 8 runtime ids (dotnet/corefx#41397)

CentOS 8 has been released:
https://wiki.centos.org/Manuals/ReleaseNotes/CentOSLinux8

    $ cat /etc/os-release
    NAME="CentOS Linux"
    VERSION="8 (Core)"
    ID="centos"
    ID_LIKE="rhel fedora"
    VERSION_ID="8"
    PLATFORM_ID="platform:el8"
    PRETTY_NAME="CentOS Linux 8 (Core)"
    ANSI_COLOR="0;31"
    CPE_NAME="cpe:/o:centos:centos:8"
    HOME_URL="https://www.centos.org/"
    BUG_REPORT_URL="https://bugs.centos.org/"
    CENTOS_MANTISBT_PROJECT="CentOS-8"
    CENTOS_MANTISBT_PROJECT_VERSION="8"
    REDHAT_SUPPORT_PRODUCT="centos"
    REDHAT_SUPPORT_PRODUCT_VERSION="8"

Commit migrated from https://github.com/dotnet/corefx/commit/6f82bd59a05ea9556397596ae9e59f39b904b222

5 years agoAdd some DebuggerDisplay attributes in System.Linq (dotnet/corefx#41386)
Stephen Toub [Fri, 27 Sep 2019 18:19:52 +0000 (14:19 -0400)]
Add some DebuggerDisplay attributes in System.Linq (dotnet/corefx#41386)

Commit migrated from https://github.com/dotnet/corefx/commit/e667c29636a622eb4f9493f75232b44e0ae90b29

5 years agoAnnotate System.IO.Compression for nullable (dotnet/corefx#41322)
buyaa-n [Fri, 27 Sep 2019 16:41:52 +0000 (09:41 -0700)]
Annotate System.IO.Compression for nullable (dotnet/corefx#41322)

Nullable annotation for System.IO.Compression

Commit migrated from https://github.com/dotnet/corefx/commit/967eb3c5cb5fd36c8bb56d06f4c840f6a7a5a754

5 years agoRemove a few initialization allocations from Cng (dotnet/corefx#41373)
Stephen Toub [Fri, 27 Sep 2019 03:22:52 +0000 (20:22 -0700)]
Remove a few initialization allocations from Cng (dotnet/corefx#41373)

Save four "startup" allocations in System.Security.Cryptography.Cng.

- Appending the '\0' is better done at the call site, because then the concat is done with two constants at compile time.
- There's no benefit to using ToCharArray instead of just passing in the string.
- Once we get rid of those, we can just inline the construction into the declarations.

Commit migrated from https://github.com/dotnet/corefx/commit/296c0e71ddcc4885d30af18dea829c1923cfdc5c

5 years agoAdd System.Object converter sample to have semantics similar to Newtonsoft Json.NET...
Steve Harter [Thu, 26 Sep 2019 21:34:50 +0000 (16:34 -0500)]
Add System.Object converter sample to have semantics similar to Newtonsoft Json.NET (dotnet/corefx#41323)

Commit migrated from https://github.com/dotnet/corefx/commit/946628c1fe463cc058db5a53723ca3867428de01

5 years agoMake Delegate.GetMethodInfo extension return non-nullable (dotnet/corefx#41367)
Stephen Toub [Thu, 26 Sep 2019 21:31:10 +0000 (14:31 -0700)]
Make Delegate.GetMethodInfo extension return non-nullable (dotnet/corefx#41367)

Commit migrated from https://github.com/dotnet/corefx/commit/e0338a64488dde44c94c843bb15df8dc21138aa9

5 years agoAvoid ToCharArray allocation in JsonCamelCaseNamingPolicy (dotnet/corefx#41363)
Stephen Toub [Thu, 26 Sep 2019 21:30:31 +0000 (14:30 -0700)]
Avoid ToCharArray allocation in JsonCamelCaseNamingPolicy (dotnet/corefx#41363)

Commit migrated from https://github.com/dotnet/corefx/commit/4cfc7ecdf44fee10b86477c67eb9c7d335cf3269

5 years agoDisable S.N.Security tests on arm64 Windows (dotnet/corefx#41370)
Viktor Hofer [Thu, 26 Sep 2019 21:04:43 +0000 (23:04 +0200)]
Disable S.N.Security tests on arm64 Windows (dotnet/corefx#41370)

Commit migrated from https://github.com/dotnet/corefx/commit/4fd8e9f3dcbf7484e3cc4b2d77c649a48f1e29ac

5 years agoAdd Alpine 3.10 to CI (dotnet/corefx#41355)
Viktor Hofer [Thu, 26 Sep 2019 19:52:36 +0000 (21:52 +0200)]
Add Alpine 3.10 to CI (dotnet/corefx#41355)

Commit migrated from https://github.com/dotnet/corefx/commit/ea0ff6679926b6d964347c63db7f3598d53e44f2

5 years agoadd more IsSuffix test cases (dotnet/corefx#41353)
Adam Sitnik [Thu, 26 Sep 2019 18:51:36 +0000 (20:51 +0200)]
add more IsSuffix test cases (dotnet/corefx#41353)

Commit migrated from https://github.com/dotnet/corefx/commit/79eb17cf22dc69ac94f900794468d998254e7bd8

5 years agoStartsWith more edge cases (dotnet/corefx#41350)
Adam Sitnik [Thu, 26 Sep 2019 13:40:44 +0000 (15:40 +0200)]
StartsWith more edge cases (dotnet/corefx#41350)

* add test case for ICU-20832

* add ""o\u0000\u0308".StartsWith("o") test case

Commit migrated from https://github.com/dotnet/corefx/commit/933f5ddb717307ea75c939058c23c16e3849176e

5 years agoUpdate windows.yml (dotnet/corefx#41328)
Viktor Hofer [Thu, 26 Sep 2019 04:53:38 +0000 (06:53 +0200)]
Update windows.yml (dotnet/corefx#41328)

Commit migrated from https://github.com/dotnet/corefx/commit/84369a81077db9041d9d542f91b642efc4091b7d

5 years agoFix DeflateStream.CopyTo for concatenated payloads (dotnet/corefx#41190)
Eric StJohn [Wed, 25 Sep 2019 23:19:34 +0000 (16:19 -0700)]
Fix DeflateStream.CopyTo for concatenated payloads (dotnet/corefx#41190)

* Fix DeflateStream.CopyTo for concatenated payloads

Support for concatenated payloads was added in dotnet/corefx@55f2293ddda3c972fcc2d94915b03bc8556e8c9b.

With this DeflateStream will continue to attempt to read after it
encounters a payload footer if it has more data left and that data
begins with the proper header format.

This caused a bug in CopyTo where it assumed that if the inflater
returned 0 bytes inflated it was done with that buffer.
This can happen in a couple cases:
1. The footer for a payload occurs on a buffer boundary, such that the
first call to Inflate for that buffer reads only the footer and returns
0 data. This was reported by a customer.
2. One of the concatenated payloads is 0 length.

Previously the CopyTo implementation would skip the remainder of the
buffer in this case, then proceed with a new buffer.  This new buffer
would start and an arbitrary offset in the compressed data, which likely
isn't a valid header, and an exception would be thrown:
```
System.IO.InvalidDataException : The archive entry was compressed using an unsupported compression method.
```

Fix this by continuing to copy so long as the we haven't run out of
data, regardless of wether or not the inflater happens to read a 0
length chunk.

* Address feedback

* Fix regression introduced in refactoring

* Apply suggestions from code review

Co-Authored-By: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Commit migrated from https://github.com/dotnet/corefx/commit/b832f6ccdebd18469e4b6d03c1c9b2c9c6c14374

5 years agoimprove stability of FileSystemWatcher tests (dotnet/corefx#40543)
Tomas Weinfurt [Wed, 25 Sep 2019 21:30:10 +0000 (14:30 -0700)]
improve stability of FileSystemWatcher tests (dotnet/corefx#40543)

* improve stability of watcher tests

* feedback from review

* more feedback

* disable parallelization for dangerous tests

* enable FileSystemWatcher_File_Create_ForceLoopRestart  again

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/e8fd8931d488d2e06a25a49c0d722b67f35e10fa

5 years agoImplement HashAlgorithmName.FromOid and TryFromOid.
Kevin Jones [Wed, 25 Sep 2019 21:09:27 +0000 (17:09 -0400)]
Implement HashAlgorithmName.FromOid and TryFromOid.

Commit migrated from https://github.com/dotnet/corefx/commit/eda554cfbcceda02db621ab8233d1b53e653681a

5 years agoChange dependsOn Parameter when calling post-build tempalte to react to Arcade breaki...
Ricardo Arenas [Wed, 25 Sep 2019 20:47:17 +0000 (13:47 -0700)]
Change dependsOn Parameter when calling post-build tempalte to react to Arcade breaking change (dotnet/corefx#41318)

Commit migrated from https://github.com/dotnet/corefx/commit/78f27e44cd74b1a6eb66401099645c6871251dfc

5 years agoExploration: Retry STATUS_UNSUCCESSFUL from CNG (dotnet/corefx#41300)
Jeremy Barton [Wed, 25 Sep 2019 16:32:27 +0000 (09:32 -0700)]
Exploration: Retry STATUS_UNSUCCESSFUL from CNG (dotnet/corefx#41300)

* Exploration: Retry STATUS_UNSUCCESSFUL from CNG

* Restore Array.Resize to separate changes

Commit migrated from https://github.com/dotnet/corefx/commit/ac99a1b7168bd32046a954c3f06012c0fa909bed

5 years agoSerializer perf improvements (dotnet/corefx#41238)
Steve Harter [Wed, 25 Sep 2019 15:46:41 +0000 (10:46 -0500)]
Serializer perf improvements (dotnet/corefx#41238)

Commit migrated from https://github.com/dotnet/corefx/commit/527595f14c6b3ee307d301ae42d68c29cad545d0

5 years ago[master] Update dependencies from 4 repositories (dotnet/corefx#41216)
dotnet-maestro[bot] [Tue, 24 Sep 2019 23:09:05 +0000 (01:09 +0200)]
[master] Update dependencies from 4 repositories (dotnet/corefx#41216)

* Update global.json

* Disable DependentUpon convention for resources

* Update dependencies from https://github.com/dotnet/core-setup build 20190920.7

- Microsoft.NETCore.App - 5.0.0-alpha1.19470.7
- Microsoft.NETCore.DotNetHostPolicy - 5.0.0-alpha1.19470.7
- Microsoft.NETCore.DotNetHost - 5.0.0-alpha1.19470.7

* Update dependencies from https://github.com/dotnet/corefx build 20190921.2

- runtime.native.System.IO.Ports - 5.0.0-alpha1.19471.2
- Microsoft.NETCore.Platforms - 5.0.0-alpha1.19471.2

* Cleanup netcoreapp targeting pack restore

For .NETCore2x the SDK implictily references the targeting pack via
a PackageReference so to binplace the assemblies we just need to reset
the PrivateAssets and IsImplicitlyDefined attributes.

For .NETCore >= 3 we don't need to reset any attributes on the
FrameworkReference.

We default to the version that is bundled within the SDK in the
Microsoft.NETCoreSdk.BundledVersions.props file.

* Update dependencies from https://github.com/dotnet/standard build 20190922.1

- NETStandard.Library - 2.2.0-prerelease.19472.1

* Update SDK to 3.0.100 stable

* Simplify code in netcoreapp.depproj

* Update packageIndex inbox matrix for S.R.Emit

* Manual darc update from build '20190923.5'

Commit migrated from https://github.com/dotnet/corefx/commit/90f7cc01418c059f496528beeca77c5f5549e6fc

5 years agoAdd more Unicode validation tests (dotnet/corefx#41265)
Levi Broderick [Tue, 24 Sep 2019 22:09:53 +0000 (15:09 -0700)]
Add more Unicode validation tests (dotnet/corefx#41265)

* Add more Unicode validation tests

* PR feedback and add more char tests

Commit migrated from https://github.com/dotnet/corefx/commit/b59265f6dda8e0462f17b96d85e1356245261de9

5 years agoUpdate windows-instructions.md
Viktor Hofer [Tue, 24 Sep 2019 20:45:20 +0000 (22:45 +0200)]
Update windows-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/4515def03be39fe09f20d47059c9e85438d23825

5 years agoFixing outdated method name (dotnet/corefx#41285)
oleggolovkovuss [Tue, 24 Sep 2019 19:54:36 +0000 (22:54 +0300)]
Fixing outdated method name (dotnet/corefx#41285)

.Net Core release notes lead to this sample for JSON serializing, it's using non-existent static `ToString` method though, this changes updates the docs

Commit migrated from https://github.com/dotnet/corefx/commit/629eea822f258f8d5771b96286eba8ff8c89d997

5 years agoAnnotate System.Threading.Tasks.Parallel for nullability (dotnet/corefx#41249)
Stephen Toub [Tue, 24 Sep 2019 19:53:19 +0000 (12:53 -0700)]
Annotate System.Threading.Tasks.Parallel for nullability (dotnet/corefx#41249)

Commit migrated from https://github.com/dotnet/corefx/commit/0298da07f3252e645d7d9509cfd4f19615043f7a

5 years agoAnnotate System.ComponentModel.Primitives for nullable (dotnet/corefx#41185)
buyaa-n [Tue, 24 Sep 2019 17:05:58 +0000 (10:05 -0700)]
Annotate System.ComponentModel.Primitives for nullable (dotnet/corefx#41185)

* Annotate System.ComponentModel.Primitives for nullable

Commit migrated from https://github.com/dotnet/corefx/commit/da147ece700c2502b91e57d99213feadcfb9c1f0

5 years agoReplace RS4 with Client19H1 in CI (dotnet/corefx#41277)
Viktor Hofer [Tue, 24 Sep 2019 13:49:41 +0000 (15:49 +0200)]
Replace RS4 with Client19H1 in CI (dotnet/corefx#41277)

Commit migrated from https://github.com/dotnet/corefx/commit/6549a93fb462f581696af11a3be076d36309dc7e

5 years agoDisable UWP pkg publishing to fix official builds (dotnet/corefx#41279)
Viktor Hofer [Tue, 24 Sep 2019 10:46:11 +0000 (12:46 +0200)]
Disable UWP pkg publishing to fix official builds (dotnet/corefx#41279)

Commit migrated from https://github.com/dotnet/corefx/commit/0a51b2d9b191a12768d4d1410d0c200bba558522

5 years agoRemove some unnecessary string concatenation from CertificatePal.AppendPrivateKeyInfo...
Stephen Toub [Tue, 24 Sep 2019 05:22:44 +0000 (22:22 -0700)]
Remove some unnecessary string concatenation from CertificatePal.AppendPrivateKeyInfo (dotnet/corefx#41274)

Commit migrated from https://github.com/dotnet/corefx/commit/f2292af3a1794378339d6f5c8adcc0f2019a2cf9

5 years agoFix validity encoding for cert dates after 2049
Jeremy Barton [Tue, 24 Sep 2019 02:22:35 +0000 (19:22 -0700)]
Fix validity encoding for cert dates after 2049

During the change from the reflection serializer to asn.xslt generation we lost
the metadata that said that X.509 Time GeneralizedTime values need to ignore
fractional seconds.

That means we're generating fractional seconds when the input DateTimeOffset
has them, which means we violate RFC in our generated certificates.

Commit migrated from https://github.com/dotnet/corefx/commit/8a65f0b14cb3f29272a18b2f6dbe4bebfd4d4177

5 years agoRemove person who left the company (dotnet/corefx#41272)
Carlos Sanchez Lopez [Tue, 24 Sep 2019 00:10:16 +0000 (17:10 -0700)]
Remove person who left the company (dotnet/corefx#41272)

Commit migrated from https://github.com/dotnet/corefx/commit/5f3673cbcd0bc161c1d3d8cef531e8e57bcfcbed

5 years agoError out clearly when trying to use COM objects with the DLR. (dotnet/corefx#40075)
Jeremy Koritzinsky [Mon, 23 Sep 2019 23:30:46 +0000 (16:30 -0700)]
Error out clearly when trying to use COM objects with the DLR. (dotnet/corefx#40075)

* Throw an exception in the dynamic binder when trying to dynamically resolve a COM object without an enabled COM binder.

* Add test for exception throw on dynamic usage with COM.

* Update test to validate the change in each binder.

* PR Feedback.

* Add missing using.

Commit migrated from https://github.com/dotnet/corefx/commit/5ed05b311925509d3cd4b6938d4935ca31cdaf92

5 years agoRemoving microsoft.private.corefx.uap (dotnet/corefx#41187)
Anirudh Agnihotry [Mon, 23 Sep 2019 21:01:49 +0000 (14:01 -0700)]
Removing microsoft.private.corefx.uap (dotnet/corefx#41187)

* removing microsoft.private.corefx.uap

* removing uap specific changes in ,.targets

* add uap-windowsNT

Commit migrated from https://github.com/dotnet/corefx/commit/49ba6ef9cb8120c87eae636fc41b79e07e88e707

5 years agoAdditional enum tests for System.Linq.Expressions.Interpreter.CallInstruction (dotnet...
Charles Stoner [Mon, 23 Sep 2019 16:24:45 +0000 (09:24 -0700)]
Additional enum tests for System.Linq.Expressions.Interpreter.CallInstruction (dotnet/corefx#41218)

Commit migrated from https://github.com/dotnet/corefx/commit/f9919e1ce5ca407f55d078af003af642c1b44d92