review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

reed@google.com [Fri, 3 Jan 2014 16:22:48 +0000 (16:22 +0000)]

Add onNewLockPixels, that returns rowbytes and relies on info in pixelref

This reverts commit 890a6ec633c1f54891104a072a8964b4c2c81af9.

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/110593003

git-svn-id: http://skia.googlecode.com/svn/trunk@12883 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 3 Jan 2014 16:04:11 +0000 (16:04 +0000)]

make results_test.py work better within python unittest framework

BUG=
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/122443006

git-svn-id: http://skia.googlecode.com/svn/trunk@12882 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 3 Jan 2014 13:43:01 +0000 (13:43 +0000)]

assert in setPixelRef that the pr matches the bitmap's config

BUG=
R=halcanary@google.com

Review URL: https://codereview.chromium.org/120063003

git-svn-id: http://skia.googlecode.com/svn/trunk@12880 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 3 Jan 2014 07:01:45 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12875 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 2 Jan 2014 22:21:47 +0000 (22:21 +0000)]

An SkOSWindow for Unix may experience stuttering, with missed events or long delays before events are processed when using SkEvent.postDelay().

The issue is with the use of a select loop to watch for events coming into the x11 file descriptor for the display. It turns out there may be XEvents queued in memory but not yet processed that need to be handled before entering the select loop. See: http://developerweb.net/viewtopic.php?id=3184

BUG=1960
R=reed@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/123303004

git-svn-id: http://skia.googlecode.com/svn/trunk@12874 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 2 Jan 2014 22:20:49 +0000 (22:20 +0000)]

Function pointers -> templates in SkPictureFlat.

These flatten/unflatten function pointers were driving me nuts when reading the
generated assembly for this code. We don't need the flexibility of function
pointers here, so let's use templates to make it more manageable. You'll
notice we get much better typing now on flatten/unflatten.

BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/123213004

git-svn-id: http://skia.googlecode.com/svn/trunk@12873 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Thu, 2 Jan 2014 21:45:03 +0000 (21:45 +0000)]

Get rid of DEFINE_TESTCLASS_SHORT() macro.

Instead tests should be written using DEF_TEST() macro, which is much
nicer and simplifies the process of setting up an unit test.

BUG=None
TEST=skpskgr_test, pathops_unittest
R=mtklein@google.com

Review URL: https://codereview.chromium.org/117863005

git-svn-id: http://skia.googlecode.com/svn/trunk@12870 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Thu, 2 Jan 2014 20:43:26 +0000 (20:43 +0000)]

Update 4 skimage expectations.

Grab expectations missed in codereview:102213009, sicne the bots were slow:
-  Test-ChromeOS-Daisy-MaliT604-Arm7-Debug
-  Test-ChromeOS-Daisy-MaliT604-Arm7-Release
-  Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind
-  Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-ASAN

BUG=
R=epoger@google.com

Review URL: https://codereview.chromium.org/93713007

git-svn-id: http://skia.googlecode.com/svn/trunk@12869 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 2 Jan 2014 19:42:15 +0000 (19:42 +0000)]

take 2: create simple 'skpmaker' tool to generate SKP files for testing

(re-landing https://codereview.chromium.org/108343006 without the build breakages)

BUG=skia:1943
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/112253004

git-svn-id: http://skia.googlecode.com/svn/trunk@12866 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 2 Jan 2014 18:51:38 +0000 (18:51 +0000)]

Revert of https://codereview.chromium.org/108343006/
Reason for revert: broke some builds

R=rmistry@google.com, mtklein@google.com
TBR=mtklein@google.com, rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1943

Author: epoger@google.com

Review URL: https://codereview.chromium.org/102243012

git-svn-id: http://skia.googlecode.com/svn/trunk@12865 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 2 Jan 2014 18:10:34 +0000 (18:10 +0000)]

create simple 'skpmaker' tool to generate SKP files for testing
(needed to create self-test for render_pictures)

BUG=skia:1943
R=rmistry@google.com, mtklein@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/108343006

git-svn-id: http://skia.googlecode.com/svn/trunk@12864 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 2 Jan 2014 18:07:46 +0000 (18:07 +0000)]

remove SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR and make fInfo const

BUG=
R=halcanary@google.com

Review URL: https://codereview.chromium.org/107373004

git-svn-id: http://skia.googlecode.com/svn/trunk@12863 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Thu, 2 Jan 2014 17:29:28 +0000 (17:29 +0000)]

Add a release procedure to SkMallocPixelRef; remove SkDataPixelRef

This works in a way that is similar to SkData.

SkMallocPixelRef::NewWithProc

    Motivation: Chrome has a ETC1PixelRef which calls delete[] on the
    pixles on destruction.  There is no reason for them to almost
    duplicate our class, when we can provide them a more flexible
    class.  Example use:

      static void delete_uint8_proc(void* ptr, void*) {
        delete[] static_cast<uint8_t>(ptr);
      }
      SkPixelRef* new_delete_pixref(const SkImageInfo& info,
                                    SkColorTable* ctable) {
        size_t rb = info.minRowBytes();
        return SkMallocPixelRef::NewWithProc(
          info, rb, ctable,
          new uint8_t[info.getSafeSize(rb)],
          delete_uint8_proc, NULL);
      }

SkMallocPixelRef::NewWithData

Motivation:  This allows up to eliminate SkDataPixelRef.  We
    modified SkImage_Raster to use MallocPixelRef rather than
    SkDataPixlRef.

Also:  Unit tests in tests/MallocPixelRefTest.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/106883006

git-svn-id: http://skia.googlecode.com/svn/trunk@12861 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 2 Jan 2014 16:19:53 +0000 (16:19 +0000)]

Make tests output spin on the same line by default.

-v now gives a cleaned-up version of the existing output (every test timed, useless information removed)

Example output, default:
  [ 36/193] PathOpsCubicIntersectionOneOffTest
then later when finished...
  [193/193] BlurMaskFilter

Example output, -v:  (note, codereview is messing up my pretty spacing)
Skia UnitTests: --resourcePath resources SK_RELEASE SK_SCALAR_IS_FLOAT skia_arch_width=32
[  1/193]     0ms PathOpsSimplifyDontFailOneTest
[  2/193]     0ms PathOpsSimplifyFailOneTest
[  3/193]    30ms PathOpsSkpTest
[  4/193]    21ms PathOpsSimplifyFailTest
....
[182/193]  1026ms BlitRow
[183/193]   808ms AAClip
[184/193]  4333ms Math
[185/193]  5068ms PackBits
[186/193]  2265ms DrawText_DrawPosText
[187/193]  9163ms PathOpsRectsThreadedTest
[188/193]  5540ms GLPrograms
[189/193]     0ms GLInterfaceValidation
[190/193]     2ms DeferredCanvas
[191/193]     1ms ClipCache
[192/193]    30ms BlurMaskFilter
[193/193] 10396ms PathOpsOpCubicsThreadedTest
Finished 193 tests, 0 failures, 0 skipped.  (622610 internal tests)

BUG=
R=halcanary@google.com, mtklein@google.com, bungeman@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/109513002

git-svn-id: http://skia.googlecode.com/svn/trunk@12860 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 2 Jan 2014 16:15:32 +0000 (16:15 +0000)]

Remove unused function.

BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/121113005

git-svn-id: http://skia.googlecode.com/svn/trunk@12859 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Thu, 2 Jan 2014 13:15:13 +0000 (13:15 +0000)]

Add Options to SkDecodingImageGenerator, simplify API.

Motivation: We want to remove redundant classes from Skia. To
that end we want to remove SkImageRef and its subclasses and
replace their uses with SkDiscardablePixelRef +
SkDecodingImageGenerator. Since Android uses SkImageRef, we need
to make sure that SkDecodingImageGenerator allows all of the
settings that Android exposes in BitmapFactory.Options.

To that end, we have created an Options struct for the
SkDecodingImageGenerator which lets the client of the generator set
sample size, dithering, and bitmap config.

We have made the SkDecodingImageGenerator constructor private
and replaced the SkDecodingImageGenerator::Install functions
with a SkDecodingImageGenerator::Create functions (one for
SkData and one for SkStream) which now take a
SkDecodingImageGenerator::Options struct.

Also added a ImageDecoderOptions test which loops through a list
of sets of options and tries them on a set of 5 small encoded
images.

Also updated several users of SkDecodingImageGenerator::Install to
follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp,
and PictureTest.cpp, CachedDecodingPixelRefTest.cpp.

We also added a new ImprovedBitmapFactory Test which simulates the
exact function that Android will need to modify to use this,
installPixelRef() in BitmapFactory.

R=reed@google.com, scroggo@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12744

Review URL: https://codereview.chromium.org/93703004

git-svn-id: http://skia.googlecode.com/svn/trunk@12855 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 2 Jan 2014 07:01:35 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12853 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mike@reedtribe.org [Wed, 1 Jan 2014 20:32:45 +0000 (20:32 +0000)]

speedup SkRect::intersect

git-svn-id: http://skia.googlecode.com/svn/trunk@12851 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Tue, 31 Dec 2013 14:29:52 +0000 (14:29 +0000)]

Add default resource path for skia test cases in gm and bench tools.

BUG=skia:1765
TEST=./out/Release/gm --match downsamplebitmap_image
R=mtklein@google.com, scroggo@google.com, yunchao.he@intel.com

Review URL: https://codereview.chromium.org/120873002

git-svn-id: http://skia.googlecode.com/svn/trunk@12850 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 31 Dec 2013 07:01:36 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12849 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 30 Dec 2013 19:21:22 +0000 (19:21 +0000)]

ComputeRowBytes must not overflow width when it shifts

BUG=
R=halcanary@google.com

Review URL: https://codereview.chromium.org/122473002

git-svn-id: http://skia.googlecode.com/svn/trunk@12848 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 30 Dec 2013 16:52:00 +0000 (16:52 +0000)]

fix drawVertices when we have both colors and textures

fix: don't re-call setContext on the composshader (i.e. on the tricolor shader) for each triangle,
since the trishader handles that explicitly. Just call setContext on the original shader.

BUG=

Review URL: https://codereview.chromium.org/102193006

git-svn-id: http://skia.googlecode.com/svn/trunk@12847 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 30 Dec 2013 16:21:06 +0000 (16:21 +0000)]

Possibly uninitialized SkRgnBuilder fStorage.

fStorage needs to be initialized regardless of SkRgnBuilder::init()'s
outcome - otherwise the destructor can end up freeing garbage.

BUG=330293
R=reed@google.com, fmalita@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/122313002

git-svn-id: http://skia.googlecode.com/svn/trunk@12846 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 30 Dec 2013 15:51:25 +0000 (15:51 +0000)]

reenable vertices gm, adding picture support

BUG=

Review URL: https://codereview.chromium.org/112913005

git-svn-id: http://skia.googlecode.com/svn/trunk@12845 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 30 Dec 2013 15:48:10 +0000 (15:48 +0000)]

Fixing crash found by fuzzer

A previous fix only partially fixed this issue by adding validation on some inputs of SkImageInfo. If anything invalid is detected in SkImageInfo, unfortunately, this can cause getSafeSize() to do an illegal memory access while calling bytesPerPixel(), which could have a bad color type at this point.

A possible fix is to simply make sure we are in a valid state before calling getSafeSize().

BUG=329254
R=reed@google.com, mtklein@google.com, bsalomon@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/107003006

git-svn-id: http://skia.googlecode.com/svn/trunk@12844 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 30 Dec 2013 14:40:38 +0000 (14:40 +0000)]

Revert "Revert of https://codereview.chromium.org/113823003/"

This reverts commit 68b4b32066ea0ba9dbb5d326a836f8a54297b7aa.

BUG=

Review URL: https://codereview.chromium.org/122293002

git-svn-id: http://skia.googlecode.com/svn/trunk@12842 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 30 Dec 2013 14:24:37 +0000 (14:24 +0000)]

Revert of https://codereview.chromium.org/113823003/
Reason for revert: need to update callsites in linux codecs

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=

Author: reed@google.com

Review URL: https://codereview.chromium.org/122283002

git-svn-id: http://skia.googlecode.com/svn/trunk@12841 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 30 Dec 2013 14:14:42 +0000 (14:14 +0000)]

remove Sk64 from public API, and start to remove usage internally

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/113823003

git-svn-id: http://skia.googlecode.com/svn/trunk@12840 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Mon, 30 Dec 2013 07:01:37 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12838 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mike@reedtribe.org [Mon, 30 Dec 2013 04:34:44 +0000 (04:34 +0000)]

disable gm/vertices until I can find/fix all warnings

git-svn-id: http://skia.googlecode.com/svn/trunk@12837 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mike@reedtribe.org [Mon, 30 Dec 2013 04:27:22 +0000 (04:27 +0000)]

really disable replay

git-svn-id: http://skia.googlecode.com/svn/trunk@12836 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mike@reedtribe.org [Mon, 30 Dec 2013 04:20:38 +0000 (04:20 +0000)]

suppress pictures for vertices for now

git-svn-id: http://skia.googlecode.com/svn/trunk@12835 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mike@reedtribe.org [Mon, 30 Dec 2013 04:07:34 +0000 (04:07 +0000)]

add gm::vertices

git-svn-id: http://skia.googlecode.com/svn/trunk@12834 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 26 Dec 2013 15:50:29 +0000 (15:50 +0000)]

Revert of https://codereview.chromium.org/119943002/
Reason for revert: False alert on zheng.xu's original CL - it didn't break anything.

R=bungeman@google.com, reed@google.com, zheng.xu@arm.com, robertphillips@google.com, rmistry@google.com
TBR=bungeman@google.com, reed@google.com, rmistry@google.com, robertphillips@google.com, zheng.xu@arm.com
NOTREECHECKS=true
NOTRY=true
BUG=

Author: bensong@google.com

Review URL: https://codereview.chromium.org/117963003

git-svn-id: http://skia.googlecode.com/svn/trunk@12822 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 24 Dec 2013 07:01:39 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12820 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 23 Dec 2013 22:47:15 +0000 (22:47 +0000)]

create unittest for gm/rebaseline_server/results.py

NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/117413006

git-svn-id: http://skia.googlecode.com/svn/trunk@12819 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Sat, 21 Dec 2013 19:07:40 +0000 (19:07 +0000)]

Adding additional optional parameters to imagediffdb to make calling from Cluster Telemetry possible.

R=epoger@google.com

Review URL: https://codereview.chromium.org/117823008

git-svn-id: http://skia.googlecode.com/svn/trunk@12816 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 21 Dec 2013 07:01:35 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12812 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 20 Dec 2013 21:49:33 +0000 (21:49 +0000)]

Adds non-1 scalar to config names.

BUG=
R=robertphillips@google.com, bungeman@google.com, halcanary@google.com, scroggo@google.com, borenet@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/106823005

git-svn-id: http://skia.googlecode.com/svn/trunk@12811 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Fri, 20 Dec 2013 21:35:51 +0000 (21:35 +0000)]

Empty skimage expectations for Logan

R=scroggo@google.com

Review URL: https://codereview.chromium.org/110393005

git-svn-id: http://skia.googlecode.com/svn/trunk@12809 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Fri, 20 Dec 2013 19:22:35 +0000 (19:22 +0000)]

Rebaseline for WebP

What I did:

#!/bin/sh
cd expectations/skimage
for D in *; do
    [ -d "$D" ] || continue
    [ -f "${D}/expected-results.json" ] || continue
    gsutil cp \
        "gs://chromium-skia-gm/skimage/actuals/${D}/actual-results.json" \
        "${D}/expected-results.json"
done
cd ../..

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/102213009

git-svn-id: http://skia.googlecode.com/svn/trunk@12805 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Fri, 20 Dec 2013 16:35:22 +0000 (16:35 +0000)]

Fix Red/Blue decoding problem in WebP.

Added unit test with lossless webp data.

BUG=skia:1402

Will need to rebaseline webp expectations for some systems.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/105443005

git-svn-id: http://skia.googlecode.com/svn/trunk@12803 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 20 Dec 2013 15:56:52 +0000 (15:56 +0000)]

Allow multiple concurrent timers.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/118473006

git-svn-id: http://skia.googlecode.com/svn/trunk@12802 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Fri, 20 Dec 2013 14:48:38 +0000 (14:48 +0000)]

Change bench_pictures configs

Aiming at CPU vs GPU

R=epoger@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/111893004

git-svn-id: http://skia.googlecode.com/svn/trunk@12799 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Fri, 20 Dec 2013 14:35:24 +0000 (14:35 +0000)]

Skimage expectations for Valgrind builder

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/115693005

git-svn-id: http://skia.googlecode.com/svn/trunk@12797 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 20 Dec 2013 14:24:21 +0000 (14:24 +0000)]

Revert "Revert "begin to remove SkLONGLONG and wean Skia off of Sk64""

This reverts commit 15b986baf026a3da5e2cac8106a1b753df242c39.

BUG=

Review URL: https://codereview.chromium.org/119353003

git-svn-id: http://skia.googlecode.com/svn/trunk@12796 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 20 Dec 2013 13:52:54 +0000 (13:52 +0000)]

Revert of https://codereview.chromium.org/101423004/
Reason for revert: broke some win7 bots

R=bungeman@google.com, reed@google.com, zheng.xu@arm.com, robertphillips@google.com, rmistry@google.com
TBR=bungeman@google.com, reed@google.com, zheng.xu@arm.com
NOTREECHECKS=true
NOTRY=true
BUG=

Author: bensong@google.com

Review URL: https://codereview.chromium.org/119943002

git-svn-id: http://skia.googlecode.com/svn/trunk@12794 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 20 Dec 2013 07:01:36 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12793 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 20 Dec 2013 04:39:12 +0000 (04:39 +0000)]

This patch makes SkScalerContext_FreeType to be the only one which embolden the glyphs.

Add bench cases for different font styles.

BUG=
R=bungeman@google.com, reed@google.com

Author: zheng.xu@arm.com

Review URL: https://codereview.chromium.org/101423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12792 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 19 Dec 2013 23:17:56 +0000 (23:17 +0000)]

Disable SkFloat unit test due to Chromium-side compilation errors

git-svn-id: http://skia.googlecode.com/svn/trunk@12791 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 19 Dec 2013 22:28:48 +0000 (22:28 +0000)]

Revert "begin to remove SkLONGLONG and wean Skia off of Sk64"

This reverts commit 784890196fdab96289f9389db43aca01f35db0f9.

Revert "use LL suffix for 64bit literal"

This reverts commit 9634295aff9bffd7a3875a0ca4a9b1a27d0793fc.

BUG=

Review URL: https://codereview.chromium.org/116543009

git-svn-id: http://skia.googlecode.com/svn/trunk@12790 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 19 Dec 2013 22:18:51 +0000 (22:18 +0000)]

use LL suffix for 64bit literal

BUG=

Review URL: https://codereview.chromium.org/108683009

git-svn-id: http://skia.googlecode.com/svn/trunk@12789 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 19 Dec 2013 21:54:27 +0000 (21:54 +0000)]

begin to remove SkLONGLONG and wean Skia off of Sk64

BUG=
R=caryclark@google.com

Review URL: https://codereview.chromium.org/99433009

git-svn-id: http://skia.googlecode.com/svn/trunk@12788 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 19 Dec 2013 21:36:35 +0000 (21:36 +0000)]

rebaselinedownsamplebitmap_image_high_mandrill_512.png

BUG=skia:1879

Review URL: https://codereview.chromium.org/101413010

git-svn-id: http://skia.googlecode.com/svn/trunk@12787 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Thu, 19 Dec 2013 20:57:45 +0000 (20:57 +0000)]

Sanitize bitmaps produced by libgif

Motivation: fix the bug linked to below.

Some rare GIFs in the wild have a color table of size smaller than 256
and have one or more pixels with values that index out side of the
colortable.  Since it would be expensive to check the index every time
we do a color lookup, we sanitize it at the source, in
SkImageDecoder_libgif.cpp.  The new function sanitize_indexed_bitmap
checks each pixel to see if the index is outside of its allowed mask,
and if so, sets that pixel to point at color 0.

The bit mask optimization in this function relies on the fact that GIF
requires the color table size to be a power of 2.

To test:

$ skia_images_gif_suppressDecoderWarnings=0 \
..../render_pictures \
--bbh grid 256 256 --clone 1 --config 8888 --mode tile 256 256 \
    -r ..../http___www_cafe24_com_.skp -w /tmp

This should show verbose errors.

BUG=skia:1946
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/103343006

git-svn-id: http://skia.googlecode.com/svn/trunk@12786 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 19 Dec 2013 20:54:47 +0000 (20:54 +0000)]

Some more medium/MIP downsample gpu rebaslines and misc gpu innocuous rebaselines

Review URL: https://codereview.chromium.org/106523004

git-svn-id: http://skia.googlecode.com/svn/trunk@12785 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 19 Dec 2013 20:44:04 +0000 (20:44 +0000)]

rebaseline clipped-bitmap-shaders GMs for gpu

Review URL: https://codereview.chromium.org/119443002

git-svn-id: http://skia.googlecode.com/svn/trunk@12784 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Dec 2013 20:01:34 +0000 (20:01 +0000)]

rebaseline_server: stop catching KeyboardInterrupt (ctrl-C)

(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/115863003

git-svn-id: http://skia.googlecode.com/svn/trunk@12783 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 19 Dec 2013 19:37:10 +0000 (19:37 +0000)]

Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2)

https://codereview.chromium.org/118533003/

git-svn-id: http://skia.googlecode.com/svn/trunk@12781 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 19 Dec 2013 19:36:18 +0000 (19:36 +0000)]

rebaseline medium quality downscale images after mipmap change

Review URL: https://codereview.chromium.org/113803004

git-svn-id: http://skia.googlecode.com/svn/trunk@12780 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 19 Dec 2013 19:34:22 +0000 (19:34 +0000)]

Provide last resort for fCapHeight in SkFontHost_FreeType::onGetAdvancedTypefaceMetrics.

This was a pre-existing issue, but r12689 uncovered it in more cases.
Since there was no last resort, fonts without a cap height used
uninitialized data as their cap height here.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/114773004

git-svn-id: http://skia.googlecode.com/svn/trunk@12779 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Dec 2013 19:08:31 +0000 (19:08 +0000)]

rebaseline_server: add more timing and progress info to server-side log

(SkipBuildbotRuns)
BUG=skia:1941
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/105213007

git-svn-id: http://skia.googlecode.com/svn/trunk@12777 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Dec 2013 18:22:32 +0000 (18:22 +0000)]

create tools/tests/run_all.py to run all our Python self-tests within tools

Eventually, we want all of these self-tests to be written in Python;
this change makes it easier for us to add new Python self-tests, and discourages
the addition of bash self-tests.

BUG=skia:677,skia:1943
NOTRY=True
R=rmistry@google.com, scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/112163004

git-svn-id: http://skia.googlecode.com/svn/trunk@12775 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Dec 2013 17:00:46 +0000 (17:00 +0000)]

Accept displacement with no displacement input

BUG=
R=senorblanco@google.com, senorblanco@chromium.org, sugoi@google.com, bsalomon@google.com, bsalomon@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/104853005

git-svn-id: http://skia.googlecode.com/svn/trunk@12773 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Dec 2013 16:20:04 +0000 (16:20 +0000)]

Rebaseline for Nexus7 tile multithreads config. Widens the range for benched calculated from average.

BUG=
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/118593002

git-svn-id: http://skia.googlecode.com/svn/trunk@12772 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Dec 2013 16:18:01 +0000 (16:18 +0000)]

Add detection of mip support

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/102853005

git-svn-id: http://skia.googlecode.com/svn/trunk@12771 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Dec 2013 16:12:25 +0000 (16:12 +0000)]

Move distance field font code into GrDistanceFieldTextContext.

This avoids the SkDraw path and renders the distance field glyphs directly from
GrDistanceFieldTextContext. It also disables LCD, subpixel and autohinting, and
removes the supporting code when rendering DF fonts.

R=reed@google.com, bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/85653004

git-svn-id: http://skia.googlecode.com/svn/trunk@12770 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 19 Dec 2013 15:41:12 +0000 (15:41 +0000)]

New baselines for xfermodeimagefilter post-r12652.

TBR=reed@google.com
BUG=

Review URL: https://codereview.chromium.org/118803003

git-svn-id: http://skia.googlecode.com/svn/trunk@12769 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 19 Dec 2013 15:00:18 +0000 (15:00 +0000)]

fix win build

git-svn-id: http://skia.googlecode.com/svn/trunk@12768 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 19 Dec 2013 14:22:03 +0000 (14:22 +0000)]

remove unused SkFixed and SkFract functions

BUG=
R=caryclark@google.com

Review URL: https://codereview.chromium.org/113873008

git-svn-id: http://skia.googlecode.com/svn/trunk@12767 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 19 Dec 2013 13:41:48 +0000 (13:41 +0000)]

Yet another round of valgrind suppressions

https://codereview.chromium.org/116053004/

git-svn-id: http://skia.googlecode.com/svn/trunk@12766 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 19 Dec 2013 10:39:59 +0000 (10:39 +0000)]

Add cast to fix Win* compile complaint/failure

R=tomhudson@google.com, reed@google.com
TBR=tomhudson@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/100313005

git-svn-id: http://skia.googlecode.com/svn/trunk@12764 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 19 Dec 2013 07:01:38 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12763 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 18 Dec 2013 23:56:59 +0000 (23:56 +0000)]

Revert r12758 (Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2) - https://codereview.chromium.org/118533003) due to Chromium-side compilation issues

git-svn-id: http://skia.googlecode.com/svn/trunk@12762 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

vandebo@chromium.org [Wed, 18 Dec 2013 22:20:16 +0000 (22:20 +0000)]

Update expectations for r12729

"[PDF] Fix clipping in xfermode improvement."

TBR=bungeman@google.com

Review URL: https://codereview.chromium.org/112343007

git-svn-id: http://skia.googlecode.com/svn/trunk@12761 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

tfarina@chromium.org [Wed, 18 Dec 2013 22:15:12 +0000 (22:15 +0000)]

Get rid of DEFINE_TESTCLASS() macro.

Remaining tests were rewrite to use DEF_TEST() macro instead. This fixes
the FIXME in TestClassDef.h

BUG=None
TEST=tests
R=mtklein@google.com

Review URL: https://codereview.chromium.org/114563003

git-svn-id: http://skia.googlecode.com/svn/trunk@12760 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 21:58:53 +0000 (21:58 +0000)]

Remove SkBitmapAlphaThresholdShader

R=bsalomon@google.com

Author: zork@chromium.org

Review URL: https://codereview.chromium.org/108653012

git-svn-id: http://skia.googlecode.com/svn/trunk@12759 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 21:09:21 +0000 (21:09 +0000)]

Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows (Take 2)

Requires changes from https://codereview.chromium.org/99053007/ before this can be rolled in Chromium DEPS. If this begins breaking the build due to an early roll, please contact bajones@chromium.org before reverting.

BUG=326382
R=bsalomon@chromium.org
TBR=bsalomon@chromium.org

Author: bajones@chromium.org

Review URL: https://codereview.chromium.org/118533003

git-svn-id: http://skia.googlecode.com/svn/trunk@12758 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 19:49:27 +0000 (19:49 +0000)]

Android now uses Harfbuzz-NG. No need to keep code specific to the old version of Harfbuzz around!

R=scroggo@google.com, reed@google.com, bungeman@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/107663012

git-svn-id: http://skia.googlecode.com/svn/trunk@12756 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 19:47:57 +0000 (19:47 +0000)]

fix off-by-one error with rotated HQ scaling

BUG=
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/118193005

git-svn-id: http://skia.googlecode.com/svn/trunk@12755 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 18 Dec 2013 19:00:47 +0000 (19:00 +0000)]

Add cast to fix Win* compile complaint/failure

https://codereview.chromium.org/100313005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12750 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 18 Dec 2013 18:48:08 +0000 (18:48 +0000)]

Address memory leak in SkScaledImageCache

https://codereview.chromium.org/107443009/

git-svn-id: http://skia.googlecode.com/svn/trunk@12749 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 18:33:15 +0000 (18:33 +0000)]

Revert of https://codereview.chromium.org/93703004/
Reason for revert: Test failures

R=scroggo@google.com, djsollen@google.com, reed@google.com, halcanary@google.com
TBR=djsollen@google.com, halcanary@google.com, reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/103753007

git-svn-id: http://skia.googlecode.com/svn/trunk@12747 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 18:28:07 +0000 (18:28 +0000)]

Expose more SkPaint fields in Lua API.

Adds getters (but not setters) for most SkPaint fields.

R=reed@google.com, robertphillips@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/105143009

git-svn-id: http://skia.googlecode.com/svn/trunk@12746 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Wed, 18 Dec 2013 17:40:25 +0000 (17:40 +0000)]

Add Options to SkDecodingImageGenerator, simplify API.

Motivation: We want to remove redundant classes from Skia. To
that end we want to remove SkImageRef and its subclasses and
replace their uses with SkDiscardablePixelRef +
SkDecodingImageGenerator. Since Android uses SkImageRef, we need
to make sure that SkDecodingImageGenerator allows all of the
settings that Android exposes in BitmapFactory.Options.

To that end, we have created an Options struct for the
SkDecodingImageGenerator which lets the client of the generator set
sample size, dithering, and bitmap config.

We have made the SkDecodingImageGenerator constructor private
and replaced the SkDecodingImageGenerator::Install functions
with a SkDecodingImageGenerator::Create functions (one for
SkData and one for SkStream) which now take a
SkDecodingImageGenerator::Options struct.

Also added a ImageDecoderOptions test which loops through a list
of sets of options and tries them on a set of 5 small encoded
images.

Also updated several users of SkDecodingImageGenerator::Install to
follow new call signature - gm/factory.cpp, LazyDecodeBitmap.cpp,
and PictureTest.cpp, CachedDecodingPixelRefTest.cpp.

We also added a new ImprovedBitmapFactory Test which simulates the
exact function that Android will need to modify to use this,
installPixelRef() in BitmapFactory.

R=reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/93703004

git-svn-id: http://skia.googlecode.com/svn/trunk@12744 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 18 Dec 2013 17:28:55 +0000 (17:28 +0000)]

Suppress questionable gpu errors

https://codereview.chromium.org/118283002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12743 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 18 Dec 2013 17:25:33 +0000 (17:25 +0000)]

Update bench pictures to time image decode & upload costs

https://codereview.chromium.org/117583002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12742 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 16:50:13 +0000 (16:50 +0000)]

Rebaselining displacement gms

Rebaseline needed because of changes made in https://codereview.chromium.org/101623007/

BUG=
R=senorblanco@chromium.org, senorblanco@google.com, bsalomon@google.com, bsalomon@chromium.org, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/101643003

git-svn-id: http://skia.googlecode.com/svn/trunk@12741 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 18 Dec 2013 15:49:32 +0000 (15:49 +0000)]

replace SkScalarMulRound(a,b) with SkScalarRountToInt(a*b)

BUG=
R=sugoi@google.com

Review URL: https://codereview.chromium.org/111393010

git-svn-id: http://skia.googlecode.com/svn/trunk@12740 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 15:28:24 +0000 (15:28 +0000)]

rebaseline_server: write JSON files using Unix line endings, even on Windows

(SkipBuildbotRuns)
BUG=skia:1815
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com, epoger@google.com

Author: epoger@gmail.com

Review URL: https://codereview.chromium.org/117783004

git-svn-id: http://skia.googlecode.com/svn/trunk@12739 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Wed, 18 Dec 2013 15:27:39 +0000 (15:27 +0000)]

Split atomic and mutex implementations and make inlinable.

Skia cannot use Chromium's implementation of mutex (Lock) due to static
initializers. However, we would like to be able to use Chromium's
implementation of atomics. This motivates the split of implementation.

Skia's atomic and mutex calls should be inlinable, especially the atomics.
These calls often compile down to very few instructions, and we currently have
the overhead of a function call. This motivates the header implementation.

There is still a desire for the build system to select the implementation, so
the SK_XXX_PLATFORM_H pattern for header files is introduced. This allows the
build system to control which platform specific header files are chosen.

The Chromium side changes (most of which will need to go in before this change
can be found at https://codereview.chromium.org/19477005/ .
The Chromium side changes after this lands can be seen at
https://codereview.chromium.org/98073013 .

Review URL: https://codereview.chromium.org/19808007

git-svn-id: http://skia.googlecode.com/svn/trunk@12738 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Wed, 18 Dec 2013 15:08:35 +0000 (15:08 +0000)]

SamplePicture no longer uses SkImageRef

Motivation: in an attempt to simplify life, we are depricating
SkImageRef and its subclasses. To that end, SamplePicture will now
use SkDiscardablePixelRef.

Also, fixed missing resource.

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/116423006

git-svn-id: http://skia.googlecode.com/svn/trunk@12737 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 14:55:02 +0000 (14:55 +0000)]

Adjusts Ubuntu bench multi_4_threads values. Widens range to cope with the new average instead of 25th.

BUG=
R=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/108653014

git-svn-id: http://skia.googlecode.com/svn/trunk@12736 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 18 Dec 2013 07:01:56 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12734 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 18 Dec 2013 05:19:22 +0000 (05:19 +0000)]

remove last remnant of SK_SCALAR_IS_FIXED code

move SkScalarMean into its only caller, reducing out public API exposure

BUG=

Review URL: https://codereview.chromium.org/117133004

git-svn-id: http://skia.googlecode.com/svn/trunk@12733 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 18 Dec 2013 05:06:52 +0000 (05:06 +0000)]

move SkScalarMean into its only caller, reducing out public API exposure

BUG=

Review URL: https://codereview.chromium.org/117973002

git-svn-id: http://skia.googlecode.com/svn/trunk@12732 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 18 Dec 2013 04:59:26 +0000 (04:59 +0000)]

move SkScalarLog2 into its only client, in a move to reduce our public API surface area

BUG=

Review URL: https://codereview.chromium.org/93643004

git-svn-id: http://skia.googlecode.com/svn/trunk@12731 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 18 Dec 2013 04:45:37 +0000 (04:45 +0000)]

Add a setTimer() function.

Seemed simple, but required adding a Global class that contains all the global state (instance and context) for our running V8 instance. Also moved canvas.inval to be just inval() at the global level.

BUG=
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/103143009

git-svn-id: http://skia.googlecode.com/svn/trunk@12730 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 17 Dec 2013 23:38:28 +0000 (23:38 +0000)]

[PDF] Fix clipping in xfermode improvement.

In some cases, the wrong clip (src clip instead of initial clip) was used.
Switch almost exclusively to initial clip because it is safe and generates a smaller result.

BUG=chromium:328009
R=reed@google.com, bungeman@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/116423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12729 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 17 Dec 2013 23:37:38 +0000 (23:37 +0000)]

add virtual destructor for SkExample to fix build error.

The original SkExample have virtual function draw(), but have no virtual destructor. This may lead to memory leak when free the instance of derived class of SkExample. The latest skia code show error when build SkiaExamples by "ninja -C out/Release SkiaExamples":
error: ‘class SkExample’ has virtual functions and accessible non-virtual destructor.

R=caryclark@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/98463013

git-svn-id: http://skia.googlecode.com/svn/trunk@12728 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom