Youngbok Shin [Fri, 20 Apr 2018 10:13:39 +0000 (19:13 +0900)]
elementary: Do text/content set when new theme is applied
The feature which restores text/content when an Edje's theme is changed
is moved to Edje. But, it is not perfect.
It couldn't restore text/content of inside of its "group" part.
Before fixing issue about "group" part from Edje,
the feature has to be in efl_ui_layout.
@tizen_fix
Change-Id: I9895e424c27d6e0d96598ee82015f5e2048bb7e2
Bowon Ryu [Mon, 23 Apr 2018 10:27:22 +0000 (19:27 +0900)]
slider: apply tizen_vector
@tizen_fix
Change-Id: I145d937d64824eda222968cfe5cebd973be4a36f
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Woochan Lee [Mon, 23 Apr 2018 07:55:34 +0000 (16:55 +0900)]
efl_ui_win_socket: Prevent application crash.
When creation a window in indicator app,
The spcify ecore_evas as the prarent in efl_ui_win_finalize_internal(),
However calling efl_parent_get() in the evas constructor will calling the implemented below logic.
It returns null and make a crash.
Change-Id: Icd3d0b7652959ffe505ba5d728119179ed7c52b5
JunsuChoi [Mon, 23 Apr 2018 06:24:53 +0000 (15:24 +0900)]
button : Apply tizen_vector for support to vector_ux
Change-Id: I9005ad0c4d019430748693353bd431ec1238ed6b
Wonki Kim [Mon, 23 Apr 2018 03:34:04 +0000 (12:34 +0900)]
Replace removed function to another
elm_wdg_item_del has been removed so that this patch replace it with alternative one.
Change-Id: I35af3d4b1e9c63a3c0ff341facc8823be93132a0
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Fri, 20 Apr 2018 11:58:50 +0000 (20:58 +0900)]
fix a incremental support patch
Change-Id: If3f7ecbdc8dedb46ec9e63704d686cebfece900f
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Bowon Ryu [Fri, 20 Apr 2018 10:14:25 +0000 (19:14 +0900)]
evas_engine: remove logically dead code
Summary:
"plane" exception value is already filtered at line 1791.
execution cannot reach this statement.
Reviewers: cedric, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5973
Change-Id: I087597502dedd64bf48670904533e61e76b0d530
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Youngbok Shin [Fri, 20 Apr 2018 06:04:29 +0000 (15:04 +0900)]
edje: fix backward compatibility issue caused by legacy cursor funcs
Summary:
edje_object_part_text_cursor_prev/next/up/down has return value.
It has to return EINA_TRUE when only it successed.
But, when these funcs moved to legacy, it changed to return EINA_TRUE
whenever it fails or success. It must return EINA_FALSE when it fails.
@fix
Test Plan:
- Run test suite
make check
Reviewers: herdsman, raster, cedric, woohyun
Differential Revision: https://phab.enlightenment.org/D5972
Change-Id: I4290a3a4725bdfdc39f8dcceda559bc484fcf36d
Bowon Ryu [Fri, 20 Apr 2018 09:44:07 +0000 (18:44 +0900)]
efl_ui_progressbar: add null check
Summary: a segmentation fault occurs once the argument is not valid.
Test Plan: N/A
Reviewers: cedric, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5974
Change-Id: I0936de4e70d45e0c7997aa640a73371664a743b1
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Fri, 20 Apr 2018 09:28:23 +0000 (18:28 +0900)]
ecore_con: remove unused code
Test Plan: N/A
Reviewers: cedric, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5975
Change-Id: I385f259fec80eca5764c94fa74578cf612657ae5
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Jaehyun Cho [Fri, 20 Apr 2018 08:34:00 +0000 (17:34 +0900)]
efl_net_control_access_point-connman: Fix build warning
Change-Id: I2fad4b1e3cb439fbb1d2b8b0871d91232e99fa7c
Jongmin Lee [Fri, 20 Apr 2018 02:01:17 +0000 (11:01 +0900)]
elm: resolve possible memory leak
Change-Id: Ic2210ee1209ba6b4d5e803f4e6e7b7b9c1f590d5
Hermet Park [Fri, 20 Apr 2018 06:47:40 +0000 (15:47 +0900)]
ector cairo: fix a memory leak.
Here don't need to use heap memory.
@fix
Change-Id: I96eedad3f816f6bef29bf665f4ba262e11e3066a
Jaehyun Cho [Fri, 20 Apr 2018 05:25:10 +0000 (14:25 +0900)]
efl_net_control_access_point-connman: Remove unused code
if the method is EFL_NET_CONTROL_ACCESS_POINT_PROXY_METHOD_UNSET, then
the function is returned before.
Change-Id: Ia558b6f13757fd2aa6af554603a6822983b5a7fc
Jongmin Lee [Fri, 20 Apr 2018 01:11:24 +0000 (10:11 +0900)]
elm: resolve possible memory leak
Change-Id: I044d2cf83d61cdfb400ed582a315f2cdcf4b3f6c
Jongmin Lee [Fri, 20 Apr 2018 00:24:41 +0000 (09:24 +0900)]
eio: resolve possible memory leak
Change-Id: I7a240ca7289236c1067e10e379bfcf8e496af904
Jongmin Lee [Fri, 20 Apr 2018 00:57:39 +0000 (09:57 +0900)]
elm: resolve possible memory leak
Change-Id: I4e5cb2d3ad78a8982bb7ebddae49806f742112de
Jongmin Lee [Fri, 20 Apr 2018 00:36:42 +0000 (09:36 +0900)]
elm: resolve possible memory leak
Change-Id: Iaa67e1207ad9d394993d1fca6be4b46e94ab2f98
Jongmin Lee [Thu, 19 Apr 2018 23:50:18 +0000 (08:50 +0900)]
ecore_wl_dnd: correct wrong variable assignment
Change-Id: I86110206ec3abaacf8b001333be8f7f8e0e33200
Jongmin Lee [Fri, 20 Apr 2018 05:37:52 +0000 (14:37 +0900)]
elm: resolve possible null dereference
Change-Id: I418d0fc2474edcb94e0ea5e5ca1cfc4875562108
Hermet Park [Fri, 20 Apr 2018 02:44:43 +0000 (11:44 +0900)]
edje: Don't access a garbage pointer.
set null to avoid multiple access.
At 221 line, it tries to free tmp again.
Change-Id: Ia995bc5fb69ad5a7aab1adf93eeba6ad9bf2617c
Hermet Park [Fri, 20 Apr 2018 04:10:58 +0000 (13:10 +0900)]
edje edje_cc: fix memory leak.
This token has temporary alloc'd memory.
We should free it before loosing its ptr address.
@fix
Change-Id: I1e88b4fb9dbab570a0bb3199f807eace9da2a94d
Wonki Kim [Mon, 16 Apr 2018 18:21:17 +0000 (11:21 -0700)]
elementary: Remove unreachable code lines
Summary: This patch removes unreacahble code lines
Reviewers: cedric, woohyun, eagleeye
Differential Revision: https://phab.enlightenment.org/D5923
Change-Id: Ibb2ef323ed815147dcb2a34983bbd20488bec571
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Wonki Kim [Mon, 16 Apr 2018 18:18:27 +0000 (11:18 -0700)]
Fix a shutdown logic to be reachable in some case
Summary:
move evas_async_events_shutdown: to out of EVAS_CSERVE2 ifdef block
to make it reachable.
Reviewers: cedric, woohyun
Differential Revision: https://phab.enlightenment.org/D5926
Change-Id: I89d9d65e27891fe1127543480be4322c84de2689
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Wonsik Jung [Fri, 20 Apr 2018 04:05:37 +0000 (13:05 +0900)]
[EvasTBMengine] fix the overwritten im2
Fix the overwritten im2 in eng_image_native_set
Change-Id: If771597e0eaafe8139ea5ab8a97980b2202dd0eb
Wonki Kim [Thu, 12 Apr 2018 01:43:46 +0000 (10:43 +0900)]
elementary: Fix misused comma operation
a statement 'sid->pan_obj,' has nothing to do with logic
so that this patch removes it.
Change-Id: Ib7c543ff09d06f6cb1b56500051af3ceeefcc977
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Wed, 11 Apr 2018 12:16:19 +0000 (21:16 +0900)]
elementary/scroll_manager: Remove unreachable code block
this patch removes unreachable code block
Change-Id: I5a115841fa9c92a145cc07d971a3a6a43d406c13
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Youngbok Shin [Fri, 20 Apr 2018 05:08:05 +0000 (14:08 +0900)]
edje: add missing fade image and fix position managing for marquee objects
@tizen_fix
Change-Id: Iceb96e7200f5b8132c5cf1949a3df76b1b9d77ab
Joogab Yun [Fri, 20 Apr 2018 01:56:16 +0000 (10:56 +0900)]
evas : fixed coverity issue for resource leak
(CID 83275)
Change-Id: I74a27a823dc98c10b63b04f0ae824afc84cc9edf
JunsuChoi [Tue, 10 Apr 2018 04:38:21 +0000 (13:38 +0900)]
eo : Add null check
Summary:
This commit add null check on __efl_auto_unref_set.
In EO_OBJ_POINTER, if obj_id is null, obj can also be null.
Test Plan: N/A
Reviewers: woohyun, kimcinoo, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5869
Change-Id: Ieb043953811655494fdcf0138465d3b273924e5a
Wonki Kim [Thu, 12 Apr 2018 02:07:53 +0000 (11:07 +0900)]
elementary: Fix a potensional overflowing
both tv_sec and
100000000 are evaluated using 32bit arithmetic
this patch cast tv_sec to 64bit integer to avoid the overflowing
Change-Id: I93d96c94c4ed20d24c197a94b370eea28bd79791
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Youngbok Shin [Fri, 20 Apr 2018 01:59:46 +0000 (10:59 +0900)]
edje: Fix backward compat issue caused by color_class
It is being discussed in the following task.
https://phab.enlightenment.org/T6885
@tizen_fix
Change-Id: I1e0a3158c95f56621966d8e3749bd14507546cec
Wonki Kim [Fri, 20 Apr 2018 07:20:35 +0000 (16:20 +0900)]
Add omitted changes for tizen/elm_genlist
while rebasing, some changes from upstream/elm_genlist are omitted
to rebase onto sandbox/upgrade/efl120
this patch add the changes
Change-Id: Ieb847850a87809faab6454ae55aa77bd6df44c3e
Wonki Kim [Fri, 20 Apr 2018 05:38:37 +0000 (14:38 +0900)]
Add related files for incremental build
Change-Id: I035b4ecf29085c5b06c0bf4aafc4babd1aee7e40
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Doyoun Kang [Fri, 20 Apr 2018 00:30:19 +0000 (09:30 +0900)]
elementary: fix bug for setting/unsetting alpha win
there was a bug for unsetting alpha window using elm_win_alpha_set(win, EINA_FALSE).
if an app called elm_win_alpha_set(win, EINA_FALSE), the opaque geometry always set to (0,0,0,0).
this patch fixes this bug.
Change-Id: I1a773e677a48596e267bc82d9e95a866b52c590d
Doyoun Kang [Fri, 20 Apr 2018 00:07:28 +0000 (09:07 +0900)]
ecore_wl2: fix bug for getting window's active angle
Change-Id: I40fe5b819eaaa9f416af13469b61a58459b066a4
Doyoun Kang [Thu, 19 Apr 2018 23:12:42 +0000 (08:12 +0900)]
ecore_wl2: check window's property is null in ecore_wl2_window_active_angle_get
Change-Id: I9fecf63ef1b4848e4b0389c129be851ab00d9519
Seunghun Lee [Thu, 19 Apr 2018 12:51:25 +0000 (21:51 +0900)]
ecore_buffer: Fix warning that returned value at void function.
Change-Id: I1f4b4c3fb962d6cdf0c50f8cbbea6c90e2253238
JengHyun Kang [Thu, 19 Apr 2018 13:15:23 +0000 (22:15 +0900)]
ecore_evas: check evas_device's description value is null
Change-Id: If6197c8c6dd1270c6db80a4fe3b32b37f35b96c1
Jaehyun Cho [Wed, 18 Apr 2018 05:33:44 +0000 (14:33 +0900)]
efl_ui_layout: Fix not to use background/shadow part interface in legacy
"background" and "shadow" part interface was designed to be used in efl
ui interface only.
Therefore, "background" and "shadow" part interface is not used in
legacy.
Change-Id: If01a121df68d3365860f169df68c1f001f4d74e1
Jiyoun Park [Wed, 18 Apr 2018 10:38:19 +0000 (19:38 +0900)]
Revert "efl_part: support background part name for elm legacy obj"
This reverts commit
88faa367ff5022b0ea78b6bd8fbe0c385bba1f97.
Change-Id: Ie8a57a82f2bff670a2d197c259f762cc79519a22
Signed-off-by: Jiyoun Park <jy0703.park@samsung.com>
Jiyoun Park [Tue, 17 Apr 2018 01:47:46 +0000 (10:47 +0900)]
ecore_wl2_window: check keyboard device when ecore_wl2_window_input_get request
we need to discuss to adding ecore_wl2_window_keyborad_get API.
currently, multi seat situation, app has possibility to get another window's input device.
so we also need to set up policy related with multi seat
Change-Id: I36ec697309922990cbe6e8f366094cc66743ebcb
Taehyub Kim [Tue, 17 Apr 2018 02:45:40 +0000 (11:45 +0900)]
efl_part: support background part name for elm legacy obj
Change-Id: Iaeadc8adb356cda97f482370fa38c58912d1b495
Hosang Kim [Mon, 16 Apr 2018 04:07:22 +0000 (13:07 +0900)]
efl_ui_win: move setting borderless code.
Change-Id: I5a5827001a7437e9c3766c1492d5634f7dda62e7
Doyoun Kang [Mon, 16 Apr 2018 04:01:05 +0000 (13:01 +0900)]
ecore_wl2: remove checking zxdg_toplevel value in ecore_wl2_window_lower
There was a different operation for lowering window between ecore_wl_window and ecore_wl2_window.
So, we fixed this issue.
Change-Id: I818d89cca609538046673d7351b349cde523530a
YeongJong Lee [Mon, 16 Apr 2018 08:19:11 +0000 (17:19 +0900)]
efl_ui_win: add "focused" and "unfocused" signals emission
Summary:
Win is root of focus manager. it means Win is logical node and "focused" and
"unfocused" signals in Win aren't handled by focus manager.
Win needs to emit the signals itself.
Reported by eagleeye, jsuya
Test Plan:
1. elementary_test -to 'window states'
2. Check that "WIN FOCUS: focused" and "WIN FOCUS: unfocused" printed.
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: jsuya, cedric, eagleeye
Differential Revision: https://phab.enlightenment.org/D5931
Change-Id: I8dfbd5eaa6f467623bebec6dc2bf51d1f611c314
Hosang Kim [Wed, 18 Apr 2018 09:46:58 +0000 (18:46 +0900)]
edje_cc_handlers: fix parsing min/max value.
@tizen_fix
Change-Id: I8d14841da826b4a5c7fb76a0d93069d48bb193ab
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Bowon Ryu [Thu, 12 Apr 2018 14:02:33 +0000 (23:02 +0900)]
elm_toolbar: lookup_order implements
@tizen_fix
Change-Id: I4e8f461f65d0e222d375275816f89e6d208e8d28
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Thu, 12 Apr 2018 10:16:32 +0000 (19:16 +0900)]
elm_icon: lookup_order implements
@tizen_fix
Change-Id: I65dbdd39c8b12ec258737a6f987919fd3dadc3be
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Fri, 13 Apr 2018 07:01:22 +0000 (16:01 +0900)]
ecore_win32: can change the app icon at runtime in Windows.
this patch for windows hosting.
@tizen_fix
Change-Id: Ice63a911ff906eb4cd51239a1b1ad9c0879d91c9
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Daekwang Ryu [Wed, 11 Apr 2018 04:19:45 +0000 (13:19 +0900)]
evas_gl: remove unreachable code
Change-Id: I03d1c940b616a9fa499c592ad274c6247f52353a
Jiyoun Park [Fri, 13 Apr 2018 06:27:18 +0000 (15:27 +0900)]
elm_win: Pend the rotation until app set the rotation.
Currently, camera use the elm_win_rotation_with_resize_set.
it rotate the canvas, and chage the win size also.
The reason why they use this api is to use the object rotation effect during the rotation.
If window server send rotation event during the rotation, or efl client deal with the rotation
during the app's rotation effect, it cause flickering.
Before, X backend , landscape rotation
1. set the available rotation set only 0
2. window server didn't send rotation effect
3. apps listen the devicd rotation callback
4. apps set elm_win_rotation_with_resize_set 90 or 270
5. efl client set the X property related with rotation
6. window server deals with the rotation by app side.
But now window server don't want to support this api , becuase client rotation causes the whole of rotation policy.
Opensource side, server need to support this situation, but we need to time to discuss.
to support compatibility, add this code until we find the final solution.
this concept is
1. app set pending rotation using aux_hint (it means app will deal with the rotation)
2. efl client doesn't deal with server's rotation
3. do the rotation job by app just like the server's rotation.
Change-Id: Ic1edecbdc729f9202be0977215bb770275f9cb74
Change-Id: I23d411e5856971985767be358fff56b81489b5b2
SangHyeon Lee [Fri, 13 Apr 2018 04:10:37 +0000 (13:10 +0900)]
Efl_promise: fix missing va_end after va_start used
Change-Id: Ie5c219bec42059c3898cf3885238aa1f23dc4974
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
JengHyun Kang [Wed, 4 Apr 2018 07:47:01 +0000 (16:47 +0900)]
ecore_wl2: support a tizen_keyrouter event_surface event
Change-Id: Ia4fca9e1650fd0f3f90b2b26b7e3b8fe343f0b9b
Doyoun Kang [Thu, 12 Apr 2018 06:42:50 +0000 (15:42 +0900)]
ecore_wl2: check window's alpha or transparent value in ecore_wl2_window_opaque_region_set
Change-Id: I5b86811a574d0e0f5b3af033a925c345af78e38d
Hosang Kim [Wed, 11 Apr 2018 09:08:41 +0000 (18:08 +0900)]
ecore_wl2_input: delete unnecessary code.
Change-Id: Id516c3ee947e34c050041dcefac2a527859526b4
Hosang Kim [Wed, 11 Apr 2018 06:19:44 +0000 (15:19 +0900)]
efl_ui_win: fix passing null pointer issue.
Change-Id: I7dbe8898e364708452e6474448376c3bea645d02
Doyoun Kang [Wed, 11 Apr 2018 08:48:00 +0000 (17:48 +0900)]
ecore_wl2: modify code for ecore_wl2_window_alpha_set
Change-Id: I4d30f7ba7963e0bf999cc907747249842bc4f1f2
Shinwoo Kim [Tue, 10 Apr 2018 11:38:47 +0000 (20:38 +0900)]
ecore_evas_wayland: handle 0x0 content problem
Someone could NOT use elementary and use ecore_evas only. In this case, content
size which is defined by elementary is 0x0. If content size is 0x0, then frame
size is equal to window size. But the frame size is defined by elementary as
well. So if there is not a content, then the frame size should be 0.
Change-Id: Idb41799c84ee7a9879bb67ed3a86afed9318ae16
Joogab Yun [Wed, 11 Apr 2018 02:06:04 +0000 (11:06 +0900)]
evas : add missed patch about rotation, ratio and flip for tbm_surface of video
Change-Id: I0a59cd1df7523711274dd4dee821ecc0fd85ed66
Doyoun Kang [Wed, 11 Apr 2018 01:02:58 +0000 (10:02 +0900)]
ecore_wl2: add code to use tizen_policy's aux hint protocol
Change-Id: Ibb41fb3e69e96b6cfe22ae826de61fc19d867751
JunsuChoi [Tue, 10 Apr 2018 06:16:28 +0000 (15:16 +0900)]
evas: add null check
Summary:
this commit add null check.
In EVAS_OBJECT_DATA_SAFE_GET, if eo_obj is null, obj can also be null.
and In _efl_canvas_output_async_block() can return null.
Test Plan: N/A
Reviewers: woohyun, kimcinoo, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5870
Change-Id: Id0e4cc4cbcab80655a387964b5f90a516eb2d3ba
JunsuChoi [Tue, 10 Apr 2018 06:22:54 +0000 (15:22 +0900)]
ecore_fb: fix divided by zero
Summary:
w and h must not be zero.
because of the divide_by_zero exception occurs on line 649 and 653.
Test Plan: N/A
Reviewers: woohyun, kimcinoo, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5873
Change-Id: I15226d204255ff0e94f464d4486fb322d0647157
JunsuChoi [Mon, 9 Apr 2018 10:36:09 +0000 (19:36 +0900)]
atspi : fix memory leak
If return at check iter_entry, it occured memory leak form ret
Change-Id: I596346bba33ba3af3426aa2a45d1f8e7c533bdd2
JunsuChoi [Fri, 6 Apr 2018 05:21:27 +0000 (14:21 +0900)]
[atspi] Add null check for free
if value plug_id is not null, eina_str_split_full can return null
so, split value need to check for null
Change-Id: I9bbe0db45ea6ef5df98f2b13468e5590c1e5ce6a
Jeonghyun Yun [Tue, 3 Apr 2018 01:24:08 +0000 (10:24 +0900)]
edje_util: apply Tizen's color_class feature _edje_color_class_recursive_find in color_class_get
@tizen_fix
Change-Id: I612768216ab99889f09c6b6b6a53e38224d7a432
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
Joogab Yun [Tue, 27 Mar 2018 07:16:50 +0000 (16:16 +0900)]
evas : apply wayland-egl-tizen
Change-Id: Ifcc01de1b48a030a9eaf0d31f1aee8c1152e05ff
Joogab Yun [Mon, 9 Apr 2018 02:14:03 +0000 (11:14 +0900)]
evas : fixed covertiy issues, resource leak and Uninitialized scalar
variable
(CID : 83275, 113958)
Change-Id: I64477e6d833dfb6b6107b80cf9646552630b575f
Taehyub Kim [Thu, 5 Apr 2018 12:08:44 +0000 (21:08 +0900)]
cbhm_helper: fix the memory leak
Change-Id: Ida7f1fce683d927259814d38248a82c0f72ffb48
Taehyub Kim [Thu, 5 Apr 2018 11:07:59 +0000 (20:07 +0900)]
elc_popup: fix the memory leak
Change-Id: I5e08ac83dc8750e40465969f2a71bf7bd1c9e13f
Seunghun Lee [Fri, 6 Apr 2018 05:13:16 +0000 (14:13 +0900)]
ecore_buffer: Add preferred engine "tbm" for buffer.
Change-Id: Iee988a4df7188f92296ab067a3080ff3f55d5ee3
Seunghun Lee [Thu, 5 Apr 2018 01:43:44 +0000 (10:43 +0900)]
ecore_buffer: fix coverity issues
CID: 113926 113686 113713 114064 113785 113667 113660
Change-Id: I48ae86d74ffec2c57a0397da04d4fb3fdc4b0007
Dmitriy Evgenevich Gonzha [Mon, 2 Oct 2017 13:32:32 +0000 (16:32 +0300)]
Fix ASan build with edje_cc on aarch64
On EFL theme build we have too many embryo_cc processes.
With ASan environment It leads to build error because of
OOM error.
Such case with unlimited embryo_cc is already fixed in
current EFL git:
From: "Carsten Haitzler (Rasterman)" <raster@rasterman.com>
Date: Mon, 13 Jun 2016 14:11:20 +0900
Subject: [PATCH] edje_cc - limit embryo_cc instances in bg to something
sensible
so compiling current efl theme seems to spawn 178 instances of
embryo_cc in the background (then collect results). this is a bit
excessive and may be a source of issues. this may be causing T3874
perhaps due to embryo_cc's not launching (fork failing or something
else) and we don't check if fork fails. so try limit to 8 embryo_cc's
in the bg which is more reasonable than the currently "unlimited"
which leads to 178 currently...
i hope this fixes T3874
@fix
Change-Id: Ib799ca82719458b613105bbc43214b038f404827
Signed-off-by: Dmitriy Evgenevich Gonzha <d.gonzha@samsung.com>
WooHyun Jung [Thu, 5 Apr 2018 07:25:52 +0000 (16:25 +0900)]
edje_entry: fix wrong merge with upstream code
Change-Id: I1bdb1a6c07dec4b73dd581e0ffa588aa7ca17284
WooHyun Jung [Thu, 5 Apr 2018 05:08:21 +0000 (14:08 +0900)]
elm_entry: free unused memory
Change-Id: I9e7ad3e7f2f0abfc6003412ddbd4de15ae8154e3
Boram Park [Wed, 4 Apr 2018 23:48:54 +0000 (08:48 +0900)]
ecore_evas_wl: remove uselesss function
Change-Id: I9d7ee1691867f2618c610d2645a1cfd8ddc2c45b
Jongmin Lee [Tue, 3 Apr 2018 23:44:39 +0000 (08:44 +0900)]
resolve possible memory leak
Change-Id: I1464b3849e53e41c465e269fdc03ebcf268e45c2
SangHyeon Lee [Thu, 5 Apr 2018 03:30:54 +0000 (12:30 +0900)]
genlist : fix indentation error
fix the indentation error detected by coverity 113858
Change-Id: Ib42c56a8055c14c36c74cb9eeb63342324b56643
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Seunghun Lee [Wed, 4 Apr 2018 11:26:03 +0000 (20:26 +0900)]
ecore_buffer: check null before referencing object.
Change-Id: I0593d8f89dc2b95c7ab29c5b37832adbbde9a547
WGID: 342308
Seunghun Lee [Wed, 4 Apr 2018 11:20:38 +0000 (20:20 +0900)]
ecore_buffer: Fix the error passing null argument.
Change-Id: Ie6a526421d8d0dfd4680bb73c6ac24e420380442
WGID: 342158
JengHyun Kang [Wed, 4 Apr 2018 09:34:48 +0000 (18:34 +0900)]
fix svace issues: dereferenced null check
Change-Id: I0665fe690c8a4eece64723b8b22bd2fb2e2ae75d
JunSeok, Kim [Wed, 4 Apr 2018 08:14:07 +0000 (17:14 +0900)]
ecore_event_message_filter: add logic to delete event_filter from defered delete
Enlightenment crash occured during calling ecore_event_filters_del in
callback function.
It caused by ecore_event_filter remaining in filters list.
So, add remove logic in filters_delete remove loop.
Change-Id: Ia2c5c877fc091e06e4c2a3a96df86fca1fe8c6cd
JunsuChoi [Tue, 3 Apr 2018 10:18:17 +0000 (19:18 +0900)]
Atspi: enhance finding next and prev item on screen's edge
1) The content of list is checked that is screen out when genlist's content_pos_set is called.
Therefore, the content of the item is excluded from check that is screen out.
2) the content_pos_set of genlist differs by 1 pixel from the final call when scrolled up and down.
If the item size is 360x360 on a 360x360 size screen, scrolling upward (0,360) to (0, 0)
will be called until the y coordinate of the highlight object in content_pos_set is 1.
But downward is not same. if scrolling downward (0,0) to (0,360)
will be called y coordinate of highlight object in final called content_pos_set is 360.
This part can be modified according to the content_pos_set call convention.
3) delta_y means the direction of the scroll. However, old_y and y do not have the proper orientation
when content_pos_set is called twice. Therefore, we use delta_y_backup temporarily.
[dlogutil]
When scroll up
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 0, hy = 0, y = 0
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = -45, hy = 0, y = 45
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 0, hy = -45, y = 45
...
...
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = -1, hy = -358, y = 359
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 0, hy = -359, y = 359
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = -1, hy = -359, y = 360
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 0, hy = -359, y = 360
When scroll down
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 0, hy = 0, y = 360
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 43, hy = 0, y = 317
...
...
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 2, hy = 357, y = 1
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 0, hy = 359, y = 1
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 1, hy = 359, y = 0
E/EFL ( 3219): elementary<3219> elm_genlist.c:9997 _elm_genlist_elm_interface_scrollable_content_pos_set() delta_y = 0, hy = 360, y = 0
Change-Id: I4cdd109336fc631ade84b3926050541ba93665d7
Shinwoo Kim [Tue, 3 Apr 2018 10:09:54 +0000 (19:09 +0900)]
Emit "elm,key,action,activate" signal
An widget could be activated by key event, or AT-client such as screen-reader.
User could want to get sound feedback for this kind of activation.
The "elm,key,action,activate" signal will work for this.
Change-Id: I8aa53a2ca93b0426f5d8f4a4d13897af851c9141
JunsuChoi [Tue, 3 Apr 2018 10:04:37 +0000 (19:04 +0900)]
atspi : Add eldbus arguments for GetDefaultLabelInfo
Change-Id: I96668b49190d9e989c99aa7fa0c4c8bbed4e318f
Shinwoo Kim [Tue, 3 Apr 2018 09:16:47 +0000 (18:16 +0900)]
atspi: do not emit HIGHLIGHTED signal if ecore evas is obscured
The obscured application could call elm_atspi_component_highlight_grab.
The elm_atspi_component_highlight_grab emits STATE_HIGHLIGHTED signal.
This makes another visible application loses its highlight.
Example:
The "power system popup" could launch the "touch sensitivity".
Before showing the "touch sensitivity", the "wearable home" shows for a moment.
At this poisnt, the "wearable home" tries to grab highlight.
Change-Id: Ie5eacb70175e2c98de0c354ba23cbc3fb930e49f
JunsuChoi [Tue, 3 Apr 2018 08:29:00 +0000 (17:29 +0900)]
atspi : Add attributes support for the default label.
If "default_label" attribute is appended "enabled_without_window" from window,
it works with default labels for some roles.
and if "default_label" attribute is appended "disabled"
from object that work default label, it don't work default label
Change-Id: Ia40757a299869a168e546343af32ec4247b720bb
Shinwoo Kim [Tue, 3 Apr 2018 07:10:20 +0000 (16:10 +0900)]
atspi: not accept redundant leaf object
An object which role is ELM_ATSPI_ROLE_REDUNDANT_OBJECT, has been acceptable
so far regardless its children. So it was possible to find its children.
But it does not make sense to accept ELM_ATSPI_ROLE_REDUNDANT_OBJECT object if
it does not have children.
There was an issue on Browser application because we accepted REDUNDANT leaf
object. There is a button which role is ELM_ATSPI_ROLE_REDUNDANT_OBJECT, this
button would be used for conveying focus event to embedded web page.
The button was accepted, so it was not possible grab an object on web page.
Please refer to following part of accessibility tree. It is not possible to
get Elm_Atspi_Ewk_Wrapper, if Elm_Button is accepted for "GetNavigableAtPoint"
Elm_Layout
- Elm_Button [redundant object][0,148,1080,1604]
- Elm_Atspi_Ewk_Wrapper [embedded][0,148,1080,1604]
Change-Id: I382ececdce1e0e849d9040d6a5f2ba29cfaccb99
Shinwoo Kim [Tue, 3 Apr 2018 05:26:43 +0000 (14:26 +0900)]
atspi: fix translation domain for naviframe item
The naviframe item have used its VIEW object for accessible name and
description. But the naviframe item did not care about the translation
domain. So there was a translation problem.
Change-Id: Id0decd8a988d9c39c259fb8c6b19a4cfd64e8383
Shinwoo Kim [Tue, 3 Apr 2018 10:06:40 +0000 (19:06 +0900)]
atspi: do not expose name of PASSWORD_TEXT
The AT-client could get the name of PASSWORD_TEXT.
This could be fixed in _elm_entry_elm_interface_atspi_accessible_name_get,
but user defined accessible name should be accessible by the AT-client,
so _elm_widget_elm_interface_atspi_accessible_name_get is proper place.
Change-Id: I5b87dec7611ab24c79b3fa8831e2cabd4ff8a824
Shinwoo Kim [Tue, 3 Apr 2018 06:59:30 +0000 (15:59 +0900)]
atspi: use correct object for highlight_grabbing
elm_object_accessibility_highlight_set is using VIEW object as a "target"
object for the ELM_WIDGET_ITEM_CLASS object. And the "target" object is used
for all highlight related lines in the elm_win including highlight_grabbing.
So when the elm_widget sets highlight_grabbing for the ELM_WIDGET_ITEM_CLASS
object, the VIEW object should be used.
Change-Id: Id7f5595193a140e6b3d8f2c9c5a94ed9a505d890
Shinwoo Kim [Tue, 3 Apr 2018 06:23:21 +0000 (15:23 +0900)]
atspi: fix name, description callback issue
The accessible name, description callback did not work for the naviframe item.
Because the naviframe item has used VIEW object for its accessible object.
If user calls elm_atspi_accessible_name_cb_set(naviframe_item, cb, data),
then the callback cb should set to VIEW object, not naviframe item, because
atspi_accessible_name_get is using the VIEW object.
Change-Id: I0eba9b7a86256edb4eb82ff569869ad3e8490ddf
Jongmin Lee [Tue, 3 Apr 2018 02:00:41 +0000 (11:00 +0900)]
resolve some functions missed return statement
Change-Id: I759be28099f3537050ea980aca65a01a7b965522
Lauro Moura [Wed, 11 Apr 2018 23:03:32 +0000 (20:03 -0300)]
examples: Improve efl_mono and eolian_cxx build
The examples were either not build or using repeated rules due to
_EOLIAN_DEP_GEN not being set correctly was Makefile_Eolian_Helper.am
assumes it being inclueded from src/, while each example folder has its
own .am inside its folder.
Lauro Moura [Wed, 11 Apr 2018 01:50:05 +0000 (22:50 -0300)]
efl_mono: Add namespace on helpers.
Make it easier on finding where those functions are coming from.
Lauro Moura [Wed, 11 Apr 2018 01:30:40 +0000 (22:30 -0300)]
efl_mono: Proper support for @class methods.
Previously, class methods were implemented as regular instance methods.
This commits generates C# static methods for @class methods on the
*Concrete classes (and their childs).
Carsten Haitzler (Rasterman) [Thu, 12 Apr 2018 19:16:25 +0000 (04:16 +0900)]
elm entry - fix wayland bug by not updating selection until after mse up
or update with a small delay after any change and check mouse button
mask to avoid some bizarre mouse up event that is stopping the
selection form continuing with a mouse up event... so this works
around that and still works.
Carsten Haitzler (Rasterman) [Thu, 12 Apr 2018 17:42:00 +0000 (02:42 +0900)]
efl selection - fix another binary buffer treates as string bug
as per subject.
@fix
Carsten Haitzler (Rasterman) [Thu, 12 Apr 2018 17:37:16 +0000 (02:37 +0900)]
efl selection - fix entry <-> plain text compy and paste in wl
efl didnt convert markup to plain text when pasting markup -> text.
this fixes that and enables middle mouse paste etc. etc.
@fix
Change-Id: Ica7787adcf85c19e423c358ce9f89d50c882d1ff
Carsten Haitzler (Rasterman) [Thu, 12 Apr 2018 14:59:03 +0000 (23:59 +0900)]
efl selection manager - fix anoyther binary buffer treated as string bug
yet another "binary buffer" (pointer + size) streated as a string with
strdup + strlen which is oh so wrong. this fixes up some cnp in
wayland with garbage at the end of strings
@fix