profile/ivi/qtdeclarative.git
12 years agoDon't draw itty-bitty particles
Alan Alpert [Thu, 15 Sep 2011 07:29:06 +0000 (17:29 +1000)]
Don't draw itty-bitty particles

They look terrible when rounding errors catch up. Jerky movement and
flickering between N and N+1 square pixels when rendered.

Change-Id: Id27caa38de70a10537382962cc29a0f1254a91fc
Reviewed-on: http://codereview.qt-project.org/4949
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
12 years agoDon't layout while applying model changes
Bea Lam [Mon, 3 Oct 2011 01:03:39 +0000 (11:03 +1000)]
Don't layout while applying model changes

Task-number: QTBUG-21742
Change-Id: I0e01b9ac9f033108410ccd431329dd7d50edb8f2
Reviewed-on: http://codereview.qt-project.org/5903
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
12 years agocurrentIndex not updated correctly if list is initially empty
Bea Lam [Thu, 29 Sep 2011 04:50:27 +0000 (14:50 +1000)]
currentIndex not updated correctly if list is initially empty

The currentIndex shouldn't be incremented when itemCount == 0 and
also it should be default to 0 after the first item is added.

Task-number: QTBUG-21643
Change-Id: Ia9418c0cd1cd659410123394c880dfe72557fa16
Reviewed-on: http://codereview.qt-project.org/5768
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoInitial commit of particle system autotests
Alan Alpert [Fri, 30 Sep 2011 08:25:17 +0000 (18:25 +1000)]
Initial commit of particle system autotests

Just some basic autotests for most of the elements.

Change-Id: I2d289f38f362a38c69e03ff92154c98db3c4c486
Reviewed-on: http://codereview.qt-project.org/5844
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoFix order of QSGItem mouse filtering.
Martin Jones [Mon, 3 Oct 2011 00:59:16 +0000 (10:59 +1000)]
Fix order of QSGItem mouse filtering.

QGraphicsView filtered child items beginning with the item's
parent, grandparent, greatgrandparent... QSGCanvas did the
opposite, which breaks the QML mouse handling element filtering logic.

Task-number: QTBUG-21446
Change-Id: I18e125305eef536237195895a7f41f88b532d4aa
Reviewed-on: http://codereview.qt-project.org/5819
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
12 years agoDon't move content forwards when items are moved down
Bea Lam [Fri, 23 Sep 2011 01:40:25 +0000 (11:40 +1000)]
Don't move content forwards when items are moved down

Previously, if items moved down within a view, the content position
would effectively drop down. E.g. for a (0,5,3) move that moved 3
items from 0 to 5, the content y would move to the position of index
3, since it became the new first item. However, this makes it
difficult to move transitions for move() operations in these cases
since these items do not move (since the content position moves
instead). With this fix, the content position does not move, and items
will always move if they are moved.

Note this behaviour was previously implemented for backwards
movements, e.g. a (5,0,3) move but was not enabled for a forwards
(0,5,3) move.

Change-Id: I1c5a19e3c36347a4aa0cf6e31c975967a7eeada9
Reviewed-on: http://codereview.qt-project.org/5576
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoDeclarative: Compile fix for Windows.
Friedemann Kleint [Fri, 30 Sep 2011 12:46:12 +0000 (14:46 +0200)]
Declarative: Compile fix for Windows.

Change-Id: I0e4d61aa400094b3b059c836ee9145c1af989f00
Reviewed-on: http://codereview.qt-project.org/5881
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
12 years agoInclude the textureid/glyph cache in the material sorting
Gunnar Sletta [Fri, 30 Sep 2011 13:46:17 +0000 (15:46 +0200)]
Include the textureid/glyph cache in the material sorting

Change-Id: Ic9740081e9e0e53801bbda64f6b147ab74102663
Reviewed-on: http://codereview.qt-project.org/5887
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yoann Lopes <yoann.lopes@nokia.com>
12 years agoDeclarative: Fix ASCII conversion warnings.
Friedemann Kleint [Fri, 30 Sep 2011 11:50:59 +0000 (13:50 +0200)]
Declarative: Fix ASCII conversion warnings.

Change-Id: Ide43c1e37eeda8e5dc2c2d24b99c3b4f96e1b53e
Reviewed-on: http://codereview.qt-project.org/5867
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
12 years agotests for canvas and a few bug fixes
Charles Yin [Thu, 22 Sep 2011 10:01:29 +0000 (20:01 +1000)]
tests for canvas and a few bug fixes

Change-Id: Icbbc7f2a0fe3b908963ce18afef51e25ea0170a0
Reviewed-on: http://codereview.qt-project.org/5805
Reviewed-by: Charles Yin <charles.yin@nokia.com>
12 years agoModify JS Object to QVariant conversion
Chris Adams [Mon, 26 Sep 2011 04:25:36 +0000 (14:25 +1000)]
Modify JS Object to QVariant conversion

Previously, JS Objects would be converted to a QVariantMap where
each value in the map was a QVariant from toVariant(propertyValue).
Unfortunately, this would result in a crash if the object had a
reference to another object which had a reference to the original
object, due to the circular reference.

This commit changes the conversion code to use
QV8Engine::variantMapFromJS() instead, which avoids cyclic references.

Task-number: QTBUG-21626
Change-Id: I129048c8704ae0d1095a02d0ce4c0fe5850b1b20
Reviewed-on: http://codereview.qt-project.org/5490
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoFix text input delay related test failures.
Andrew den Exter [Thu, 29 Sep 2011 02:31:30 +0000 (12:31 +1000)]
Fix text input delay related test failures.

Allow a small delay after mouse or key events for the events to be
processed before verifying the result, and use the QTRY_ macros to be
doubly sure.

Task-number: QTBUG-21690
Change-Id: I44e7fa58ef2e57572b6e342af7f4f18649144770
Reviewed-on: http://codereview.qt-project.org/5763
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
12 years agoRemove a few unneeded includes
Kent Hansen [Thu, 29 Sep 2011 09:36:24 +0000 (11:36 +0200)]
Remove a few unneeded includes

Change-Id: I63a9cda5000cc872ad5a5d3c4b55243b8afb0527
Reviewed-on: http://codereview.qt-project.org/5782
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoFix compilation with c++0x
Kent Hansen [Thu, 29 Sep 2011 11:36:30 +0000 (13:36 +0200)]
Fix compilation with c++0x

Change-Id: I5d94cfc03c2ecb9a49e185d23689c11f200ca907
Reviewed-on: http://codereview.qt-project.org/5794
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
12 years agoRemove Symbian-specific code from tests.
Jason McDonald [Wed, 28 Sep 2011 06:52:12 +0000 (16:52 +1000)]
Remove Symbian-specific code from tests.

Symbian is not a supported platform for Qt5, so this code is no longer
required.

Change-Id: I5cb6d3b41fbb9fa5fea6176ad949e4e7be7c30b5
Reviewed-on: http://codereview.qt-project.org/5767
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoRefactor ParticleSystem members
Alan Alpert [Thu, 29 Sep 2011 01:22:50 +0000 (11:22 +1000)]
Refactor ParticleSystem members

Leave m_ for private members.

Change-Id: Ia20565a7af6c5db45923eb349238b94b88472f7b
Reviewed-on: http://codereview.qt-project.org/5762
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
12 years agoImprove QDeclarativeIncubator JS API
Aaron Kennedy [Fri, 30 Sep 2011 04:26:28 +0000 (14:26 +1000)]
Improve QDeclarativeIncubator JS API

Change-Id: Ic06af88a8be68b41f563bfd6cd7322375cd29224
Task-number: QTBUG-21151
Reviewed-on: http://codereview.qt-project.org/5827
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoAdd a QSGCanvas incubation controller
Aaron Kennedy [Fri, 30 Sep 2011 04:26:56 +0000 (14:26 +1000)]
Add a QSGCanvas incubation controller

Change-Id: I0324c32240746b013eeefaae2dfaa390d6e777e5
Task-number: QTBUG-21151
Reviewed-on: http://codereview.qt-project.org/5828
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoFix issue with interpolating more than one path segment backwards.
Michael Brasser [Thu, 29 Sep 2011 23:04:11 +0000 (09:04 +1000)]
Fix issue with interpolating more than one path segment backwards.

Change-Id: I463010ed63d41be80db96e8306aef8caa3863ccf
Reviewed-on: http://codereview.qt-project.org/5821
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoText format AutoText should use StyledText instead of RichText.
Yann Bodson [Fri, 30 Sep 2011 03:55:07 +0000 (13:55 +1000)]
Text format AutoText should use StyledText instead of RichText.

Task-number: QTBUG-21723
Change-Id: Ife213be95985ad1022e2f60241e69ecd9f467caf
Reviewed-on: http://codereview.qt-project.org/5825
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
12 years agoRemove unnecessary members
Aaron Kennedy [Fri, 30 Sep 2011 00:10:13 +0000 (10:10 +1000)]
Remove unnecessary members

Change-Id: I9dcdd2333c42aff8a648d5caaa4411c342923d42
Task-number: QTBUG-21151
Reviewed-on: http://codereview.qt-project.org/5822
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoExpand documentation for QObject Module APIs
Chris Adams [Fri, 16 Sep 2011 06:32:19 +0000 (16:32 +1000)]
Expand documentation for QObject Module APIs

Previously, it was unclear whether or not a QObject Module API property
could be the target of an alias property.  This commit makes it clear
that a QObject Module API property cannot be aliased as the import
qualifier of the Module API does not identify an object within the
same component of any item which may wish to alias the module API.

Task-Number: QTBUG-21420
Change-Id: Ia286edfee4dcf1250e883738f219f8aef67c32eb
Reviewed-on: http://codereview.qt-project.org/5057
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoSupport rich text elements in QSGTextNode
Eskil Abrahamsen Blomfeldt [Mon, 19 Sep 2011 14:46:38 +0000 (16:46 +0200)]
Support rich text elements in QSGTextNode

In order to have the same text rendering mechanism regardless
of the contents of the document, we need to implement rich
text layout elements in the scene graph.

Currently we support the following:
- Text objects, floating and inline (including images)
- Tables
- Lists
- Only solid borders
- Frame background colors
- All the HTML text/text layout/font manipulation

Not supported yet:
- Other border types
- Border radius
- <hr />

Task-number: QTBUG-20917
Change-Id: I4112940e6bc4ad74ae749a727acdd7e6fec3f871
Reviewed-on: http://codereview.qt-project.org/5803
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
12 years agoFix tst_qsgmousearea clickThrough() test stability.
Martin Jones [Thu, 29 Sep 2011 03:55:36 +0000 (13:55 +1000)]
Fix tst_qsgmousearea clickThrough() test stability.

Change-Id: Iee87ea8e62bffd743e522f969c34fbc2f0a1443e
Reviewed-on: http://codereview.qt-project.org/5766
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoEnsure JS-owned QObjects are cleaned up on v8engine dtor
Chris Adams [Mon, 22 Aug 2011 05:04:01 +0000 (15:04 +1000)]
Ensure JS-owned QObjects are cleaned up on v8engine dtor

This commit ensures that the garbage collector is invoked during
engine destruction.  This commit also adds a unit test which
ensures that the JS GC destroys JS-owned C++ objects correctly
when the QDeclarativeEngine is destroyed.

Task-number: QTBUG-20377
Change-Id: I2de1f2dfd1e60cc2f76abb523b99bf169d2a5a13
Reviewed-on: http://codereview.qt-project.org/3285
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoDon't crash when QSGViewSection has a null parent.
Christian Kamm [Thu, 29 Sep 2011 12:57:25 +0000 (14:57 +0200)]
Don't crash when QSGViewSection has a null parent.

This is required to make qmlplugindump work.

Change-Id: I041adde3e48759f9c3ae166c887a26ccb8f264f9
Reviewed-on: http://codereview.qt-project.org/5800
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
12 years agoCompile after changes to QtBase
Lars Knoll [Thu, 29 Sep 2011 12:12:59 +0000 (14:12 +0200)]
Compile after changes to QtBase

qmime.h got removed in QtBase, compile again
after that change.

Change-Id: I3e9a0454a4528db1b96d901e93ef763ba15d1a1e
Reviewed-on: http://codereview.qt-project.org/5795
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoRemove more QByteArray<->QString conversions
Kent Hansen [Thu, 29 Sep 2011 08:29:22 +0000 (10:29 +0200)]
Remove more QByteArray<->QString conversions

Prefer to store types as QStrings. It's only when we manipulate
raw (compiled, meta-)data that utf conversion is needed.

Change-Id: Ie138a69c9a409804e1b90b21c1d60dedea35bddb
Reviewed-on: http://codereview.qt-project.org/5781
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
12 years agoFix warning: QString(const char*) is deprecated
Kent Hansen [Wed, 28 Sep 2011 11:38:41 +0000 (13:38 +0200)]
Fix warning: QString(const char*) is deprecated

Use fromUtf8() like the other functions in this class do.

Change-Id: If25c8e8dc2562f68774002bfd11719227cbb4713
Reviewed-on: http://codereview.qt-project.org/5715
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoQDeclarativeIncubationController docs
Aaron Kennedy [Thu, 29 Sep 2011 08:10:39 +0000 (18:10 +1000)]
QDeclarativeIncubationController docs

Change-Id: I1f5be66e111da7c94632de7adb318a056dd42ab0
Task-number: QTBUG-21151
Reviewed-on: http://codereview.qt-project.org/5780
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoDeclarative: Compile on Windows.
Friedemann Kleint [Wed, 28 Sep 2011 14:43:20 +0000 (16:43 +0200)]
Declarative: Compile on Windows.

- Remove UTF8 special characters from comments in qsgcontext2d.cpp.

Change-Id: I7ba71f7db72d6d31dec115483ff785a0ce79d0e2
Reviewed-on: http://codereview.qt-project.org/5738
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoFix compilation of qmlviewer
Kent Hansen [Thu, 29 Sep 2011 10:09:12 +0000 (12:09 +0200)]
Fix compilation of qmlviewer

"qmlruntime.cpp:123: error: invalid use of incomplete type"
 'const struct QMimeData'"

Change-Id: I427fee401e9fa7cd658c3d01e7530720141e4fa0
Reviewed-on: http://codereview.qt-project.org/5786
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
12 years agoSeparate the QtQuick 1 and 2 whatsnew docs.
Martin Jones [Wed, 28 Sep 2011 08:25:16 +0000 (18:25 +1000)]
Separate the QtQuick 1 and 2 whatsnew docs.

Change-Id: Ifb2d2604dff3a19ba03f5e8d82cd0dd8b6d8744a
Reviewed-on: http://codereview.qt-project.org/5688
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoFix compile of the non-threaded V4 interpreter.
Roberto Raggi [Wed, 28 Sep 2011 13:27:48 +0000 (15:27 +0200)]
Fix compile of the non-threaded V4 interpreter.

Change-Id: I263e9826c513f8edaaf510ff1206b588dfe92f7b
Reviewed-on: http://codereview.qt-project.org/5725
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
12 years agoFix TextInput and TextEdit inputMethodComposing autotests
Joona Petrell [Wed, 28 Sep 2011 14:47:19 +0000 (17:47 +0300)]
Fix TextInput and TextEdit inputMethodComposing autotests

In old QInputContext architecture events were send to focus
widget, which delivered the events to the text editor items.
In Qt5, input methods send events directly to the editor
object using QInputPanel::inputItem().

Task-number: QTBUG-21691

Change-Id: Ia219f0cc7caaeafc32f5d7674a6ab377e773d4fa
Reviewed-on: http://codereview.qt-project.org/5741
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoFix TextInput and TextEdit openInputPanel autotests
Joona Petrell [Wed, 28 Sep 2011 13:56:36 +0000 (16:56 +0300)]
Fix TextInput and TextEdit openInputPanel autotests

Task-number: QTBUG-21691

The change also removes showInputPanelOnClick code from the TextInput and
TextEdit, which was done to support Symbian^1 and ^3 fullscreen keyboards.
Now by default the keyboard always follows editor focus.

Change-Id: Id60a17fe51b3aa49ba9ea81b985e608e91c26145
Reviewed-on: http://codereview.qt-project.org/5733
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoQDeclarativeIncubator doc
Aaron Kennedy [Thu, 29 Sep 2011 06:06:27 +0000 (16:06 +1000)]
QDeclarativeIncubator doc

Change-Id: I4fdc9e55112187039dd6210e9bc92b1da183501b
Task-number: QTBUG-21151
Reviewed-on: http://codereview.qt-project.org/5776
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoRemove dead code in QDeclarativeSvgParser
Kent Hansen [Wed, 28 Sep 2011 11:45:39 +0000 (13:45 +0200)]
Remove dead code in QDeclarativeSvgParser

'toDouble(const QChar *&str)' is the only one still in use.

Change-Id: I3e5af822a4772f1f11c8ee7011e847963077587d
Reviewed-on: http://codereview.qt-project.org/5717
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agopulse calls should use ms instead of s
Kent Hansen [Thu, 29 Sep 2011 05:17:32 +0000 (07:17 +0200)]
pulse calls should use ms instead of s

This updates the examples to reflect the API change
that was done in commit f0dc82305eb9c9297d73cba67634e9e4bc4f3b84

Change-Id: Id08896cbe3a47adc0b02797faddf50281a24c625
Reviewed-on: http://codereview.qt-project.org/5702
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
12 years agoAsynchronous component instantiation
Aaron Kennedy [Mon, 5 Sep 2011 07:31:41 +0000 (17:31 +1000)]
Asynchronous component instantiation

This introduces two main:

    * the QML compiler executes in a separate thread
    * item instantiation can be interrupted and resumed to
      allow it to be split across multiple frames.

Task-number: QTBUG-21151
Change-Id: I9631c62bb77da3a2e0c37f0da3719533fdce4fef
Reviewed-on: http://codereview.qt-project.org/5676
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoBetter dirty marking
Alan Alpert [Fri, 23 Sep 2011 05:52:06 +0000 (15:52 +1000)]
Better dirty marking

Mark geometry as well per frame, and material when it changes.

Change-Id: I67dd68b67f04f2379534b71f3c8a6e367d9d4bd5
Reviewed-on: http://codereview.qt-project.org/5439
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoFix QSGCustomParticle initialization
Alan Alpert [Fri, 23 Sep 2011 04:59:06 +0000 (14:59 +1000)]
Fix QSGCustomParticle initialization

commit was failing because nodes weren't stored yet, which could lead to
an apparent loss of particles.

Change-Id: Ibde6aa75f6c43e2d485c163820e65e0c6ff8e952
Reviewed-on: http://codereview.qt-project.org/5437
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoFix tst_QSGListView::sectionsPositioning() test
Martin Jones [Wed, 28 Sep 2011 05:55:34 +0000 (15:55 +1000)]
Fix tst_QSGListView::sectionsPositioning() test

Change-Id: Ifdf43d43c4cb6f04798ee7ef93d7fa6dd5589640
Reviewed-on: http://codereview.qt-project.org/5669
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoRestructure imageelements and remove screenorientation examples.
Damian Jansen [Thu, 29 Sep 2011 02:35:17 +0000 (12:35 +1000)]
Restructure imageelements and remove screenorientation examples.

Change-Id: Ia23c905baab95f348c967b6769d7190c15eed19a
Reviewed-on: http://codereview.qt-project.org/5765
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Glenn Watson <glenn.watson@nokia.com>
12 years agoAdded triple click on TextInput to select text.
Rafael Brandao [Thu, 29 Sep 2011 00:53:15 +0000 (10:53 +1000)]
Added triple click on TextInput to select text.

Once it gets a double click, it'll start to monitor any other extra
click for a short duration. Once it is detected, the monitor stops
watching and all text is selected. It only works when selectByMouse
property is set, just like double click selecting current word.

Also added a test case that simulates clicking at the same point
and triggering the triple click, and another one that contemplates
movement of mouse between the second and the third click. Also test
timing between clicks.

Task-number: QTBUG-21038

Change-Id: I139f7ece2107f5dbfcba1836afb27aaa9b24fc57
Merge-request: 6
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Reviewed-on: http://codereview.qt-project.org/5761
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
12 years agoCatch up with API change to QTestLog::qWarn().
Jason McDonald [Wed, 28 Sep 2011 08:44:26 +0000 (18:44 +1000)]
Catch up with API change to QTestLog::qWarn().

Change-Id: I2db27f473a0f35530961fa70e35eb552be02e890
Reviewed-on: http://codereview.qt-project.org/5695
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoDon't do run svg tests when no svg is available
Gunnar Sletta [Wed, 28 Sep 2011 08:32:19 +0000 (10:32 +0200)]
Don't do run svg tests when no svg is available

Change-Id: I6625a9e1542ffc962d5b2c414832575e450a9e61
Reviewed-on: http://codereview.qt-project.org/5690
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoBuild with qt-in-namespace
Kent Hansen [Wed, 28 Sep 2011 07:57:04 +0000 (09:57 +0200)]
Build with qt-in-namespace

Change-Id: Ia57e4f14d94ad63194dad52892bedf316a58a79a
Reviewed-on: http://codereview.qt-project.org/5693
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoDon't crash when Image.source change
Gunnar Sletta [Tue, 27 Sep 2011 15:04:03 +0000 (17:04 +0200)]
Don't crash when Image.source change

QDeclarativePixmap::clear() may result in the texture being
scheduled for deletion, so we need to make sure that our texture
provider is updated properly whenever the source changes.

Change-Id: Ie21c6fcba4b0cd438250dc4c263b513060cc026e
Reviewed-on: http://codereview.qt-project.org/5673
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoAdd support for onLinkActivated with Text.StyledText
Yann Bodson [Tue, 27 Sep 2011 02:56:17 +0000 (12:56 +1000)]
Add support for onLinkActivated with Text.StyledText

Change-Id: If7efa09e0e42970c6cb6ca8725713eb4a6f97ac8
Reviewed-by: Michael Brasser
Reviewed-on: http://codereview.qt-project.org/5665
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Yann Bodson <yann.bodson@nokia.com>
12 years agoFix crash in String.arg()
Chris Adams [Mon, 19 Sep 2011 01:00:14 +0000 (11:00 +1000)]
Fix crash in String.arg()

This commit ensures that the String.arg() function works correctly,
by registering an anonymous function with the String Prototype object
which calls the StringArg function, ensuring that the "this" object
is valid (and passing the string as an argument to StringArg instead).

Change-Id: I0a8cbaa12b39beb03a237c3ab62c6e21fafdedbf
Reviewed-on: http://codereview.qt-project.org/4385
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoUse QBasicTimer rather than QTimer in SmoothedAnimation
Martin Jones [Wed, 28 Sep 2011 00:12:08 +0000 (10:12 +1000)]
Use QBasicTimer rather than QTimer in SmoothedAnimation

QBasicTimer does the same job for lower cost.

Change-Id: I11d7033b9c456129f3f984c8baafa717f5b25d99
Reviewed-on: http://codereview.qt-project.org/5649
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoEnable QSGTextEdit and QSGTextInput failures.
Andrew den Exter [Tue, 27 Sep 2011 05:53:46 +0000 (15:53 +1000)]
Enable QSGTextEdit and QSGTextInput failures.

Fix compilation errors and skip or expect fail any tests that don't
pass.  The following tasks have been created for failing tests:

QTBUG-21686
QTBUG-21689
QTBUG-21690
QTBUG-21691
QTBUG-21693

Change-Id: I3f5bb275e1a207ebdf86e3d523cdeda1f943eb63
Reviewed-on: http://codereview.qt-project.org/5583
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years ago[autotests] Added expected failure for developer build in currentIndex test.
Toby Tomkins [Tue, 27 Sep 2011 03:11:06 +0000 (13:11 +1000)]
[autotests] Added expected failure for developer build in currentIndex test.

Task-number: QTBUG-21682

Change-Id: Icbe3ef45c9c58b54c195993b837713aef1dd3ca2
Reviewed-on: http://codereview.qt-project.org/5571
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years ago[autotest] Abort an unstable test for developer build.
Toby Tomkins [Tue, 27 Sep 2011 04:20:49 +0000 (14:20 +1000)]
[autotest] Abort an unstable test for developer build.

Task-number: QTBUG-21688

Change-Id: I732c6dc8baa7942521cf3b9d4960a3f405d07aa2
Reviewed-on: http://codereview.qt-project.org/5577
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years ago[autotests] Added expected failures for developer build in a number of tests.
Toby Tomkins [Tue, 27 Sep 2011 03:42:45 +0000 (13:42 +1000)]
[autotests] Added expected failures for developer build in a number of tests.

Task-number: QTBUG-21683

Change-Id: I0cc6150daed38a8f2207fa848be79e8cc6c56b48
Reviewed-on: http://codereview.qt-project.org/5573
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years ago[autotest] Abort an unstable test for developer build.
Toby Tomkins [Tue, 27 Sep 2011 03:57:07 +0000 (13:57 +1000)]
[autotest] Abort an unstable test for developer build.

Task-number: QTBUG-21685

Change-Id: I96abcc88d861ce2c5b8778b56f34d42b58c4eb53
Reviewed-on: http://codereview.qt-project.org/5574
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years ago[autotests] Added expected failure for developer build.
Toby Tomkins [Tue, 27 Sep 2011 04:05:33 +0000 (14:05 +1000)]
[autotests] Added expected failure for developer build.

Task-number: QTBUG-21687

Change-Id: I46f8e9c693d0fe3de48ea0f3fd967cc5ca8d1d30
Reviewed-on: http://codereview.qt-project.org/5575
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoImproved testdata deployment.
Rohan McGovern [Tue, 27 Sep 2011 05:07:50 +0000 (15:07 +1000)]
Improved testdata deployment.

Don't embed the source path into the binary, instead find the testdata
relative to the test's binary at runtime.

Use DEPLOYMENT hints for installing testdata to a device.

Change-Id: I4005422bb76adf214166fe75d66e82fb18ded04e
Reviewed-on: http://codereview.qt-project.org/5578
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoManually apply SnapOneItem/Row changes from Qt 4.7
Martin Jones [Mon, 26 Sep 2011 03:13:02 +0000 (13:13 +1000)]
Manually apply SnapOneItem/Row changes from Qt 4.7

Apply following changes to Qt 5 for both QtQuick1 and QtQuick2 items:
cf23188de237009136fa1480ab8fd9e3ca364769
f85819fe083ae7c6804c884de68e906d153a6d11
09cd2f818208a83489fae034b80e6497b7cc83af

Task-number: QTBUG-20683
Change-Id: I974764e57e3004514bb4c9f46c5152ad07c136a7
Reviewed-on: http://codereview.qt-project.org/5484
Reviewed-by: Bea Lam <bea.lam@nokia.com>
12 years agoAdd QSGPaintedItem docs to module and fix non-standard wording.
Casper van Donderen [Wed, 21 Sep 2011 05:13:38 +0000 (07:13 +0200)]
Add QSGPaintedItem docs to module and fix non-standard wording.

Change-Id: I763b1fdabdac36935bd14005a9e38b2494319726
Reviewed-on: http://codereview.qt-project.org/5521
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Casper van Donderen <casper.vandonderen@nokia.com>
12 years agoAdd convenience macro for fast connects in declarative.
Michael Brasser [Thu, 22 Sep 2011 03:14:00 +0000 (13:14 +1000)]
Add convenience macro for fast connects in declarative.

We already follow this pattern several places, so
this commit creates a convenience macro for it, and replaces
previous usage where appropriate. Also adds the macro
several places as further optimization.

Change-Id: Ieff5ed6cc51c34d0a1c8aa42ac40314ea243477a
Reviewed-on: http://codereview.qt-project.org/5342
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years ago[autotests] Added expected failure for developer build in currentIndex test.
Toby Tomkins [Tue, 27 Sep 2011 03:02:25 +0000 (13:02 +1000)]
[autotests] Added expected failure for developer build in currentIndex test.

Task-number: QTBUG-21680

Change-Id: Ic33f4f4fc96529e0a3b2be4150829ab62fe078ff
Reviewed-on: http://codereview.qt-project.org/5565
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoPart of bug has re-occurred, relates to x{} behaviour.
Toby Tomkins [Tue, 27 Sep 2011 01:55:27 +0000 (11:55 +1000)]
Part of bug has re-occurred, relates to x{} behaviour.

Task-number: QTBUG-12295

Change-Id: Idcb9ceac1ad0b093e560ef793820a1ea2178c51e
Reviewed-on: http://codereview.qt-project.org/5483
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoDisable reordering as it is currently broken
Gunnar Sletta [Mon, 26 Sep 2011 08:45:28 +0000 (10:45 +0200)]
Disable reordering as it is currently broken

Change-Id: I28b622422aff62ea988a2918830338736df6fdbe
Reviewed-on: http://codereview.qt-project.org/5528
Reviewed-by: Kim M. Kalland <kim.kalland@nokia.com>
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
12 years agoMake surface format plugable from the scene graph plugin
Gunnar Sletta [Fri, 23 Sep 2011 14:24:06 +0000 (16:24 +0200)]
Make surface format plugable from the scene graph plugin

Also enable depth, stencil and samples by default as our default
renderer requires both depth and stencil and our default rounded
rectangles require multisampling

The user should be able to override the default format, by getting
the QSGCanvas::format(), modify it and set it back, but this
is currently not supported in QWindow, so that will have to wait

Change-Id: I1869003705709987ab2e9a3cebbeeec4d45a2021
Reviewed-on: http://codereview.qt-project.org/5464
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoDon't give move ids to moved inserts.
Andrew den Exter [Mon, 26 Sep 2011 06:42:17 +0000 (16:42 +1000)]
Don't give move ids to moved inserts.

Move ids identify a paired remove and insert, an insert that has a
move id but no corresponding remove breaks anything relying on that
identity.

Change-Id: I9512e298bc518c5abf5bca7523a375baf8a39407
Reviewed-on: http://codereview.qt-project.org/5512
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
12 years agoFix missing/outdated license headers.
Jason McDonald [Mon, 26 Sep 2011 04:55:21 +0000 (14:55 +1000)]
Fix missing/outdated license headers.

Change-Id: I381398b0c4f80db689a59797e2faeab5b14503eb
Reviewed-on: http://codereview.qt-project.org/5491
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoCall QWARN() instead of QTest::qWarn().
Jason McDonald [Mon, 26 Sep 2011 03:30:47 +0000 (13:30 +1000)]
Call QWARN() instead of QTest::qWarn().

The QWARN macro wraps QTest::qWarn(), but the former is the public API
and the latter is merely an implementation detail that is subject to
change.

Change-Id: I02ae5ea384875afb7f235ef8dff0768a56afaa53
Reviewed-on: http://codereview.qt-project.org/5486
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
12 years agoAbort entire test as failures continue.
Toby Tomkins [Mon, 26 Sep 2011 01:50:19 +0000 (11:50 +1000)]
Abort entire test as failures continue.

Change-Id: Ibf9d53e9a2e2ec125760f9f0ffb5a126273df7f2
Reviewed-on: http://codereview.qt-project.org/5482
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
12 years agoSupport margins in Flickable.
Martin Jones [Fri, 23 Sep 2011 06:13:51 +0000 (16:13 +1000)]
Support margins in Flickable.

It is sometimes desireable to leave a margin/add decoration around the
content of a Flickable.  This adds topMargin, leftMargin, bottomMargin
rightMargin, xOrigin and yOrigin properties to Flickable.

Task-number: QTBUG-21362
Change-Id: Ia24ea4c63e7a8de683b68100baac782c6f3a66bb
Reviewed-on: http://codereview.qt-project.org/5445
Reviewed-by: Bea Lam <bea.lam@nokia.com>
12 years agoFix QSGTextEdit::closeSoftwareInputPanel()
Joona Petrell [Thu, 22 Sep 2011 14:45:22 +0000 (17:45 +0300)]
Fix QSGTextEdit::closeSoftwareInputPanel()

Change-Id: If50486b3159a9e40b2808a2a18aff5668012ea76
Reviewed-on: http://codereview.qt-project.org/5400
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Pekka Vuorela <pekka.ta.vuorela@nokia.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
12 years agoGet rid of redundant type member from V4 instructions
Kent Hansen [Thu, 22 Sep 2011 11:40:48 +0000 (13:40 +0200)]
Get rid of redundant type member from V4 instructions

When interpretation is threaded, the type member is
redundant, since we can obtain the type from the
instruction address.

Getting rid of the type member can save at least one
byte per instruction (possibly more because of
alignment). On ia32, the Noop and Block instructions
become 4 bytes smaller.

The compiler has been refactored to leave it up to
the Bytecode class to decide whether the instruction
address or type (enum) should be stored.

To achieve this, the "low-level" Instr union was
renamed to V4Instr, and the new Instr struct
used by the compiler provides typedefs for
instantiating the data used by each particular
instruction. Lastly, the gen() function (instruction
emitter) was made template-based to provide the
instruction type.

The instructions Bool, Int, Real, String were
renamed to Load{Bool,Int,Real,String} to make the
new code more readable.

This approach follows a similar refactoring in the
QML-VME interpreter.

Change-Id: I9bf16b099a85afdfb719a25fb18047408882d61e
Reviewed-on: http://codereview.qt-project.org/5393
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
12 years agodo not pollute the global namespace
Gunnar Sletta [Thu, 22 Sep 2011 19:23:07 +0000 (21:23 +0200)]
do not pollute the global namespace

Change-Id: I6a6bd1b9ff89535c7af0f11dd9c501945ee0718b
Reviewed-on: http://codereview.qt-project.org/5428
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years ago[tests] Fix unit test compilation, now uses QWidget.
Toby Tomkins [Fri, 23 Sep 2011 05:52:07 +0000 (15:52 +1000)]
[tests] Fix unit test compilation, now uses QWidget.

Fixed unit test, also enabled this autotest to run.

Change-Id: I92ad1a17d1fa4674a0746767d6a4100b21999a43
Reviewed-on: http://codereview.qt-project.org/5440
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoRemove all font examples from qpa platform tests
Toby Tomkins [Fri, 23 Sep 2011 01:12:22 +0000 (11:12 +1000)]
Remove all font examples from qpa platform tests

Remove all font examples, and re-enable all platform example tests.

Task-number: QTBUG-21415

Change-Id: I87448cedd7f03b9483e8ec4d90474afa4d62b9c2
Reviewed-on: http://codereview.qt-project.org/5417
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoDefensive Programming
Alan Alpert [Fri, 23 Sep 2011 03:24:35 +0000 (13:24 +1000)]
Defensive Programming

Task-number: QTBUG-21623
Change-Id: Ib906e6b50041d4e72034d6828d4dc7c503ec7bb4
Reviewed-on: http://codereview.qt-project.org/5426
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoMake delegates visible
Alan Alpert [Fri, 23 Sep 2011 03:03:20 +0000 (13:03 +1000)]
Make delegates visible

Change-Id: Ia932396419e41692431a9ce5e964331700810677
Reviewed-on: http://codereview.qt-project.org/5424
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoDoc: Added a simple introduction to Qt and fixed links.
David Boddie [Thu, 16 Jun 2011 18:24:11 +0000 (20:24 +0200)]
Doc: Added a simple introduction to Qt and fixed links.

Change-Id: I941bde15897e3ae51756d0ae4d3d011a7a3c4511
Reviewed-on: http://codereview.qt-project.org/1976
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com>
Reviewed-by: Peter Yard <peter.yard@nokia.com>
12 years agoFix documentation
Alan Alpert [Thu, 22 Sep 2011 08:38:42 +0000 (18:38 +1000)]
Fix documentation

Had x in the y docs, and the pointX/Y weren't relative as the docs had
stated.

Change-Id: I709f3a30dc527d22abc2ab3987bea359c0e66214
Reviewed-on: http://codereview.qt-project.org/5376
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoUse m_pleaseReset more consistently
Alan Alpert [Thu, 22 Sep 2011 07:29:47 +0000 (17:29 +1000)]
Use m_pleaseReset more consistently

Everyone had their own, and so they could conflict or be randomly
un-initialized.

Change-Id: Ife2c5d9972b881235e4d3a5e2a33979174de2fbc
Reviewed-on: http://codereview.qt-project.org/5370
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoFurther delay animation creation in Behavior.
Michael Brasser [Thu, 22 Sep 2011 23:44:09 +0000 (09:44 +1000)]
Further delay animation creation in Behavior.

Previously we always created the animation on the first call to write,
regardless of whether the Behavior was enabled. Now we delay until the
animation is needed.

Change-Id: I14a319a4f045050fe6a99427b7c3804ef078d48d
Reviewed-on: http://codereview.qt-project.org/5414
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
12 years agoRemove fonts example from qpa platform tests
Toby Tomkins [Tue, 13 Sep 2011 06:26:21 +0000 (16:26 +1000)]
Remove fonts example from qpa platform tests

Task-number: QTBUG-21415

Change-Id: I82b1600fe74a50dee8651247fcd172f09ba45a64
Reviewed-on: http://codereview.qt-project.org/4724
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agopartial build fix replaced QApplication::setActiveWindow with requestActivateWindow...
Matthew Cattell [Thu, 22 Sep 2011 15:31:52 +0000 (17:31 +0200)]
partial build fix replaced QApplication::setActiveWindow with requestActivateWindow and added widgets-private

Change-Id: I6e2a3b51c10684de974a0954ca4182860d351eef
Reviewed-on: http://codereview.qt-project.org/5403
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoFix extra selection in QML TextEdit
Eskil Abrahamsen Blomfeldt [Thu, 22 Sep 2011 07:20:52 +0000 (09:20 +0200)]
Fix extra selection in QML TextEdit

QSGTextEdit::selectionEnd() interprets the selection end as the
first character after the selection, while QSGTextNode expects it
to be the end of the selection.

Task-number: QTBUG-21533
Change-Id: Ia928602f8a2f845f3990a443e62f640ea72aa1d4
Reviewed-on: http://codereview.qt-project.org/5363
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Jiang Jiang <jiang.jiang@nokia.com>
12 years agoMake the QML/VME interpreter threaded
Kent Hansen [Tue, 20 Sep 2011 09:38:26 +0000 (11:38 +0200)]
Make the QML/VME interpreter threaded

This gets rid of the two-level dispatch in the
interpreter loop, which gives a nice performance boost
when many VME instructions must be interpreted
(e.g., 40% faster for 100 StoreInteger instructions).

The threading is implemented in a similar way to the
V4 interpreter.

The way the compiler generates instructions has been
refactored, chiefly to get rid of the
QDeclarativeInstruction::setType() calls (when using
threading, we don't store the instruction type at all,
only the address).

As a nice bonus, the way instructions are defined now
(creating the specific instruction's data type, rather
than a generic (union) type) is more compact and less
error-prone.

Change-Id: If5cbd36b2526fd61b74854712711b06cd7e1ed7d
Reviewed-on: http://codereview.qt-project.org/5246
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
12 years agoMake the QML-VME interpreter "threading"-friendly
Kent Hansen [Mon, 19 Sep 2011 11:21:54 +0000 (13:21 +0200)]
Make the QML-VME interpreter "threading"-friendly

Get rid of the while (something); use labels and gotos instead.
This is done in preparation of making the interpreter threaded
(i.e. using computed goto to chain instructions together).

Change-Id: I8f41e5e8295db939225547364dec3f7466f71a2b
Reviewed-on: http://codereview.qt-project.org/5245
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
12 years agoStop managing lifetime of material
Alan Alpert [Thu, 22 Sep 2011 04:06:05 +0000 (14:06 +1000)]
Stop managing lifetime of material

Let scenegraph handle it in its own thread.

Task-number: QTBUG-21586
Change-Id: I5affcec4abbc79fff0c60e740d2c1cf04e3385f2
Reviewed-on: http://codereview.qt-project.org/5345
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Gunnar Sletta <gunnar.sletta@nokia.com>
12 years agoChange burst to use ms instead of s
Alan Alpert [Thu, 22 Sep 2011 05:11:28 +0000 (15:11 +1000)]
Change burst to use ms instead of s

Also renames that variable, and adds a burst example.

Change-Id: I53787612f287e71d9afb5618bd445c8aa72fd39e
Reviewed-on: http://codereview.qt-project.org/5349
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoConstrain while loop on item count
Alan Alpert [Thu, 22 Sep 2011 04:34:57 +0000 (14:34 +1000)]
Constrain while loop on item count

pos won't necessarily change, but item count does like in the above loop

Task-number: QTBUG-21315
Change-Id: Iaedabeacf4ebe3cd0505193395047b3d65a09442
Reviewed-on: http://codereview.qt-project.org/5347
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoRecognize deformable performance level properly
Alan Alpert [Thu, 22 Sep 2011 03:48:19 +0000 (13:48 +1000)]
Recognize deformable performance level properly

Task-number: QTBUG-21305

Change-Id: I88cfe56f0f22abc92a083b2a0a8da059ebefc652
Reviewed-on: http://codereview.qt-project.org/5344
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoTighter bounding box check
Alan Alpert [Thu, 22 Sep 2011 03:42:21 +0000 (13:42 +1000)]
Tighter bounding box check

Because the gernic check works on floats and how .toPoint rounds, we
need to redo the bounds checking inside Turbulence

Task-number: QTBUG-21564
Change-Id: Ib56a8d420d9abf8035360b7908e89e28938799a8
Reviewed-on: http://codereview.qt-project.org/5343
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Martin Jones <martin.jones@nokia.com>
12 years agoWheel event support in qmltestlib + few fixes.
juhvu [Wed, 21 Sep 2011 03:04:11 +0000 (13:04 +1000)]
Wheel event support in qmltestlib + few fixes.

added unit test and orientaion support for mouseWheel

Change-Id: I9c26dc762281bc32965769c151414ac0e177ad0f
Reviewed-on: http://codereview.qt-project.org/5272
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Juha Vuolle <juha.vuolle@nokia.com>
Reviewed-by: Charles Yin <charles.yin@nokia.com>
12 years agoAdditional ListView section header placement options
Martin Jones [Tue, 20 Sep 2011 05:58:05 +0000 (15:58 +1000)]
Additional ListView section header placement options

Add a section.labelPositioning property which can be a combination
of:

- ViewSection.InlineLabels - section labels are shown inline between
  the item delegates separating sections (default).
- ViewSection.CurrentLabelAtStart - the current section label sticks to
  the start of the view as it is moved.
- ViewSection.NextLabelAtEnd - the next section label (beyond all visible
  sections) sticks to the end of the view as it is moved.

Task-number: QTBUG-12880
Change-Id: I4601828337412bd3a83769c9b8df3f6d4d7474b8
Reviewed-on: http://codereview.qt-project.org/5192
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
12 years agoFix compilation with QT_NO_*
Tasuku Suzuki [Mon, 2 May 2011 09:23:47 +0000 (11:23 +0200)]
Fix compilation with QT_NO_*

Merge-request: 1206
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
(cherry picked from commit eb61f612fea1b76fe01ee237e5bd160f66aeca3d)

Conflicts:
src/network/access/qhttpthreaddelegate.cpp
src/network/access/qhttpthreaddelegate_p.h

Change-Id: Id4f8154d1b5f69ab490d9818facfdf5a733ec794
Reviewed-on: http://codereview.qt-project.org/4593
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
12 years agoqmlplugindump: Describe meta object revisions of exported types.
Christian Kamm [Wed, 21 Sep 2011 10:54:10 +0000 (12:54 +0200)]
qmlplugindump: Describe meta object revisions of exported types.

Adds the exportMetaObjectRevisions property to generated qmltypes files.

Change-Id: Iafe2fe408c88bb6dd02cbb558404a5f654431248
Reviewed-on: http://codereview.qt-project.org/5311
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
12 years agoFix processing of unary T_MINUS_MINUS tokens after semicolon insertion.
Roberto Raggi [Wed, 21 Sep 2011 08:18:40 +0000 (10:18 +0200)]
Fix processing of unary T_MINUS_MINUS tokens after semicolon insertion.

There was a typo in the code, instead of pushing a T_MINUS_MINUS token
the lexer synthesized a T_PLUS_PLUS.

Change-Id: I62dcf263ac363196231fe8f02e98f280899ef85a
Reviewed-on: http://codereview.qt-project.org/5293
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
12 years agoTest qmlmin using the QML/JS files from our test suite.
Roberto Raggi [Wed, 21 Sep 2011 09:00:30 +0000 (11:00 +0200)]
Test qmlmin using the QML/JS files from our test suite.

qmlmin was already tested using files from the
QtDeclarative examples. This patch adds all the files
from QtDeclarative test suite.

Change-Id: I2a7a0e4a45d53f70f53911a5985c860565f10b70
Reviewed-on: http://codereview.qt-project.org/5296
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
12 years agoqdeclarativesystempalette test: Add missing dependency
Kent Hansen [Wed, 21 Sep 2011 10:58:25 +0000 (12:58 +0200)]
qdeclarativesystempalette test: Add missing dependency

Change-Id: Iefc44448feb621fda81eed6d243bc4a8ee474e7f
Reviewed-on: http://codereview.qt-project.org/5313
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
12 years agoMake qdeclarativeapplication test compile again
Kent Hansen [Wed, 21 Sep 2011 11:02:38 +0000 (13:02 +0200)]
Make qdeclarativeapplication test compile again

It shouldn't depend on QtWidgets, but using
QGuiApplication doesn't work yet, so skip the
tests for now.

Change-Id: I79473a9ed0486d51c37f498a5e58c503f9533759
Reviewed-on: http://codereview.qt-project.org/5314
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>