platform/upstream/llvm.git
23 months ago[mlir][sparse] Fix Python interface for bufferization.alloc_tensor.
bixia1 [Thu, 10 Nov 2022 01:33:25 +0000 (17:33 -0800)]
[mlir][sparse] Fix Python interface for bufferization.alloc_tensor.

Add size_hint operand to the Python interface.
Fix pytaco.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D137754

23 months ago[sanitizer] Add symbolizer support for loongarch64
Youling Tang [Thu, 10 Nov 2022 05:38:07 +0000 (13:38 +0800)]
[sanitizer] Add symbolizer support for loongarch64

Reviewed By: xry111

Differential Revision: https://reviews.llvm.org/D137383

23 months ago[sanitizer][test] Fix FastUnwindTest on LoongArch
Youling Tang [Thu, 10 Nov 2022 05:35:49 +0000 (13:35 +0800)]
[sanitizer][test] Fix FastUnwindTest on LoongArch

Fixes the `FastUnwindTest` unit test for LoongArch.
This change is similar to RISCV D90574.

The following test cases pass after applying the patch:
```
$ ./runtimes/runtimes-bins/compiler-rt/lib/sanitizer_common/tests/Sanitizer-loongarch64-Test
...
[  FAILED  ] FastUnwindTest.Basic
[  FAILED  ] FastUnwindTest.FramePointerLoop
[  FAILED  ] FastUnwindTest.MisalignedFramePointer
[  FAILED  ] FastUnwindTest.FPBelowPrevFP
[  FAILED  ] FastUnwindTest.CloseToZeroFrame
```

Reviewed By: SixWeining, xen0n, MaskRay

Differential Revision: https://reviews.llvm.org/D137314

23 months ago[sanitizer] Add the settings of Read and Write flags in SignalContext for LoongArch
Youling Tang [Thu, 10 Nov 2022 05:34:19 +0000 (13:34 +0800)]
[sanitizer] Add the settings of Read and Write flags in SignalContext for LoongArch

The bit-30 in this `__flags` means the address error is due to memory load, and the
bit-31 means the address error is due to memory store. (see SC_ADDRERR_RD
and SC_ADDRERR_WR in kernel arch/loongarch/include/uapi/asm/sigcontext.h).

`illegal_write_test.cpp` and `illegal_read_test.cpp` have been tested and passed.

Reviewed By: SixWeining, xen0n, XiaodongLoong

Differential Revision: https://reviews.llvm.org/D137231

23 months ago[sanitizer] Add GetMaxVirtualAddress() support for LoongArch
Youling Tang [Thu, 10 Nov 2022 05:32:24 +0000 (13:32 +0800)]
[sanitizer] Add GetMaxVirtualAddress() support for LoongArch

Add support for getting the maximum virtual address, LoongArch has multiple
address space layouts, the default maximum virtual address of the current
user space is 47 bits. (from TASK_SIZE in the kernel for loongarch64).

Reviewed By: SixWeining

Differential Revision: https://reviews.llvm.org/D137219

23 months ago[ORC-RT] Add a SymbolStringPool class to the ORC runtime.
Lang Hames [Wed, 9 Nov 2022 23:21:45 +0000 (15:21 -0800)]
[ORC-RT] Add a SymbolStringPool class to the ORC runtime.

This is a counterpart to llvm::orc::SymbolStringPool. It holds uniqued,
ref-counted strings; and can be used to avoid redundant storage of strings,
and speed up comparison of strings held in the pool (these become pointer
comparisons).

23 months ago[ORC] Fix comments: SymbolStringPool is thread-safe, not multi-threaded.
Lang Hames [Wed, 9 Nov 2022 21:39:29 +0000 (13:39 -0800)]
[ORC] Fix comments: SymbolStringPool is thread-safe, not multi-threaded.

23 months ago[ORC-RT][MachO] Add RecordSectionsTracker utility to track metadata sections.
Lang Hames [Wed, 9 Nov 2022 01:40:11 +0000 (17:40 -0800)]
[ORC-RT][MachO] Add RecordSectionsTracker utility to track metadata sections.

Newly added sections can be processed by calling processNewSections. Calling
reset moves all sections back to the "new" state for reprocessing (expected to
be used by dlclose).

23 months ago[PowerPC] add a new subtarget feature fastMFLR
Chen Zheng [Tue, 8 Nov 2022 06:35:55 +0000 (01:35 -0500)]
[PowerPC] add a new subtarget feature fastMFLR

Some PowerPC CPU may have slow MFLR instruction, so we need to
schedule the MFLR and its store in function prologue away to
hidden the long latency for slow MFLR instruction.

This patch adds a new feature fastMFLR and the new feature will
be used in https://reviews.llvm.org/D137423.

Reviewed By: RolandF

Differential Revision: https://reviews.llvm.org/D137612

23 months ago[mlir][sparse] skip zeros during dense2sparse
Aart Bik [Wed, 9 Nov 2022 22:57:43 +0000 (14:57 -0800)]
[mlir][sparse] skip zeros during dense2sparse

This enables the full matmul integration test with runtime_lib=true/false!

Background:
https://github.com/llvm/llvm-project/issues/51657

Reviewed By: bixia

Differential Revision: https://reviews.llvm.org/D137750

23 months ago[bazel] Update gtest move to third-party
Jordan Rupprecht [Thu, 10 Nov 2022 04:48:11 +0000 (20:48 -0800)]
[bazel] Update gtest move to third-party

a11cd0d94ed3cabf0998a0289aead05da94c86eb moved googletest to third-party.

This creates a corresponding BUILD file in third-party/unittest, moved from the chunk in llvm/BUILD.bazel.

We must refine the .bazelignore which is setup to ignore the benchmarking library so that we don't ignore the new dir here.

23 months agoThe fillOp's value needs to casted
Prashant Kumar [Fri, 4 Nov 2022 17:09:22 +0000 (17:09 +0000)]
The fillOp's value needs to casted

During elementwise fusion the fillOp's value was directly
referred without casting which can create mismatching dtypes.

Reviewed By: mravishankar, ThomasRaoux

Differential Revision: https://reviews.llvm.org/D137447

23 months ago[libc++] Add a script to generate the libc++ BuildKite pipeline dynamically
Louis Dionne [Thu, 10 Nov 2022 02:50:51 +0000 (16:50 -1000)]
[libc++] Add a script to generate the libc++ BuildKite pipeline dynamically

23 months agocmake: Fix build with -DLLVM_BUILD_EXTERNAL_COMPILER_RT=ON
Tom Stellard [Thu, 10 Nov 2022 00:31:01 +0000 (00:31 +0000)]
cmake: Fix build with -DLLVM_BUILD_EXTERNAL_COMPILER_RT=ON

This was broken by a11cd0d94ed3cabf0998a0289aead05da94c86eb.

23 months ago[gn build] port a11cd0d94ed3 (gtest llvm/utils/unittest -> third-party/unittest)
Nico Weber [Thu, 10 Nov 2022 00:55:31 +0000 (19:55 -0500)]
[gn build] port a11cd0d94ed3 (gtest llvm/utils/unittest -> third-party/unittest)

23 months ago[mlir][vector] Convert extract_strided_slice to extract & insert chain
Lei Zhang [Thu, 10 Nov 2022 00:37:19 +0000 (19:37 -0500)]
[mlir][vector] Convert extract_strided_slice to extract & insert chain

This is useful for breaking down extract_strided_slice and potentially
cancel with other extract / insert ops before or after.

Reviewed By: ThomasRaoux

Differential Revision: https://reviews.llvm.org/D137471

23 months ago[AArch64][SVE] Migrate tests to use opaque pointers (NFC)
Dinar Temirbulatov [Thu, 10 Nov 2022 00:38:28 +0000 (00:38 +0000)]
[AArch64][SVE] Migrate tests to use opaque pointers (NFC)

    Test updates were performed using:
    https://gist.github.com/nikic/98357b71fd67756b0f064c9517b62a34

23 months ago[mlir][sparse] Add optional size_hint operand to bufferization.alloc_tensor.
bixia1 [Mon, 7 Nov 2022 21:46:29 +0000 (13:46 -0800)]
[mlir][sparse] Add optional size_hint operand to bufferization.alloc_tensor.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D137585

23 months ago[ORC] Fix typo in unit test.
Lang Hames [Thu, 10 Nov 2022 00:11:40 +0000 (16:11 -0800)]
[ORC] Fix typo in unit test.

23 months ago[flang] Support arith::FastMathFlagsAttr for fir::CallOp.
Slava Zakharin [Wed, 9 Nov 2022 23:18:50 +0000 (15:18 -0800)]
[flang] Support arith::FastMathFlagsAttr for fir::CallOp.

The main purpose of this patch is to propagate fastmath attribute
to SimplifyIntrinsicsPass, so that the inline code can inherit
the call operation's attributes. Even though I added translation
of fastmath from fir::CallOp to LLVM::CallOp, there are no fastmath
attributes in LLVM IR. It looks like the translation drops it.
This will need additional commits.

Reviewed By: jeanPerier

Differential Revision: https://reviews.llvm.org/D137602

23 months agoMove googletest to the third-party directory
Tom Stellard [Wed, 9 Nov 2022 16:51:34 +0000 (08:51 -0800)]
Move googletest to the third-party directory

Rre-commit of 59052468c3e38cab15582cefbb5133fd4c2ffce5 with a typo
fix in compiler-rt/CMakeLists.txt

23 months ago[flang] Propagate more FastMath flags to lowering.
Slava Zakharin [Wed, 9 Nov 2022 23:01:47 +0000 (15:01 -0800)]
[flang] Propagate more FastMath flags to lowering.

Plugged in propagation of nnan/nsz/arcp/afn/reassoc related options
to lowering/FirOpBuilder.

Reviewed By: jeanPerier, tblah, awarzynski

Differential Revision: https://reviews.llvm.org/D137580

23 months ago[CodeGen][AArch64] Enable LDAPR under +RCPC
Alexander Shaposhnikov [Wed, 9 Nov 2022 21:36:18 +0000 (21:36 +0000)]
[CodeGen][AArch64] Enable LDAPR under +RCPC

This is a follow-up to D126250 and enables LDAPR
if the RCPC extensions are enabled.

Test plan: ninja check-all

Differential revision: https://reviews.llvm.org/D137590

23 months ago[libc++] Add FTM for constexpr vector
Nikolas Klauser [Wed, 9 Nov 2022 20:01:42 +0000 (21:01 +0100)]
[libc++] Add FTM for constexpr vector

It looks like we forgot to set the FTM when adding constexpr vector support.

Reviewed By: ldionne, #libc

Spies: libcxx-commits, arichardson

Differential Revision: https://reviews.llvm.org/D137729

23 months ago[mlir][sparse] first end-to-end matmul with codegen
Aart Bik [Wed, 9 Nov 2022 21:05:43 +0000 (13:05 -0800)]
[mlir][sparse] first end-to-end matmul with codegen

(1) also fixes memory leak in sparse2dense rewriting
(2) still needs fix in dense2sparse by skipping zeros

Reviewed By: wrengr

Differential Revision: https://reviews.llvm.org/D137736

23 months agoRevert "[AArch64][SME] Disable GlobalISel/FastISel for SME functions."
Sander de Smalen [Wed, 9 Nov 2022 21:14:25 +0000 (21:14 +0000)]
Revert "[AArch64][SME] Disable GlobalISel/FastISel for SME functions."

Reverting the patch due to a buildbot failure.

This reverts commit e1e260cc64bd900d5f3f88187c60cb02d3a805f5.

23 months ago[Test][AIX][pg] Add 32-bit linker invocation tests
Michael Francis [Tue, 8 Nov 2022 19:37:29 +0000 (19:37 +0000)]
[Test][AIX][pg] Add 32-bit linker invocation tests

Differential Review: https://reviews.llvm.org/D137372

23 months ago[mlir][vector] Modify constraint and interface for warp reduce on f16 and i8
stanley-nod [Wed, 9 Nov 2022 19:26:20 +0000 (11:26 -0800)]
[mlir][vector] Modify constraint and interface for warp reduce on f16 and i8

Quantization method is crucial and ubiqutous in accelerating machine
learning workloads. Most of these methods uses f16 and i8 types.

This patch relaxes the type contraints on warp reduce distribution to
allow these types. Furthermore, this patch also changed the interface
and moved the initial reduction of data to a single thread into the
distributedReductionFn, this gives flexibility for developers to control
how they are obtaining the initial lane value, which might differ based
on the input types. (i.e to shuffle 32-width type, we need to reduce f16
to 2xf16 types rather than a single element).

Reviewed By: ThomasRaoux

Differential Revision: https://reviews.llvm.org/D137691

23 months ago[Test][AIX][p] Add 64-bit linker invocation tests
Michael Francis [Tue, 8 Nov 2022 19:32:44 +0000 (19:32 +0000)]
[Test][AIX][p] Add 64-bit linker invocation tests

Differential Review: https://reviews.llvm.org/D137373

23 months ago[compiler-rt][hwasan] Call __hwasan_library_loaded via
Leonard Chan [Tue, 8 Nov 2022 23:11:26 +0000 (23:11 +0000)]
[compiler-rt][hwasan] Call __hwasan_library_loaded via
__sanitizer_library_loaded on Fuchsia

Differential Revision: https://reviews.llvm.org/D133806

23 months ago[compiler-rt][hwasan] Do not call InitLoadedGlobals in __hwasan_init
Leonard Chan [Tue, 8 Nov 2022 23:06:19 +0000 (23:06 +0000)]
[compiler-rt][hwasan] Do not call InitLoadedGlobals in __hwasan_init

Fuchsia's libc provides a new hook (__sanitizer_module_loaded) which calls
hwasan_library_loaded in the startup path which will register globals in
loaded modules.

Differential Revision: https://reviews.llvm.org/D137676

23 months ago[llvm-diff] Fix false-positive diffs on forward-referencing phi nodes
Jannik Silvanus [Thu, 27 Oct 2022 07:14:40 +0000 (09:14 +0200)]
[llvm-diff] Fix false-positive diffs on forward-referencing phi nodes

When a phi node references a variable defined in a basic block dominated
by the the basic block containing the phi node, llvm-diff currently cannot determine
whether the variable is equivalent, and thus treats the phi node as different
and reports a difference. This leads to false positive differences as demonstrated
by the loop.ll diff, for which llvm-diff reports a diff when comparing the file
with itself.

Fix that issue by adding the concept of *equivalence assumptions*.
When encountering a pair of values which can neither be proven to be equivalent
nor to be non-equivalent, instead optimistically assume equivalence, and store
somewhere that the equivalence of the currently compared basic blocks depends
on this assumption.

Later, once all BBs have been processed, check all made assumptions and report
blocks as different whose equivalence was depending on an incorrect assumption,
or an assumption we could not prove to be correct.

In order to preserve the original diff report order, also schedule diffs
of blocks already known to be different using the same mechanism, so all block
diffs are now generated at the very end of function diffing.

In case an incorrect assumption was made, all further shown equivalences between
old and new values implictly depend on the incorrect assumption. Some of these
may in fact be not equivalent, but these are neither reverted nor reported,
because they are considered indirect diffs caused by an earlier direct diff.

See inline comments for an argument why we do not run into issues caused by circular
proof dependencies.

Differential Revision: https://reviews.llvm.org/D137318

23 months agoRevert "Move googletest to the third-party directory"
Tom Stellard [Wed, 9 Nov 2022 19:32:26 +0000 (11:32 -0800)]
Revert "Move googletest to the third-party directory"

This reverts commit 59052468c3e38cab15582cefbb5133fd4c2ffce5.

It looks like this patch breaks the build when compiler-rt is passed to
LLVM_ENABLE_PROJECTS instead of LLVM_ENABLE_RUNTIMES.

23 months ago[RISCV] Support BSET/BCLR/BINV in hasAllWUsers.
Craig Topper [Wed, 9 Nov 2022 19:16:00 +0000 (11:16 -0800)]
[RISCV] Support BSET/BCLR/BINV in hasAllWUsers.

These instructions set, clear, or invert a single bit. If their
users don't use the upper 32 bits, they don't use the upper 32 bits
of their input.

Additionally the second operand BSET/BCLR/BINV is a shift amount
which only uses 6 bits of the source.

Reviewed By: asb

Differential Revision: https://reviews.llvm.org/D137452

23 months ago[RISCV] Support shift/rotate amount operands in isAllUsesReadW.
Craig Topper [Wed, 9 Nov 2022 19:15:30 +0000 (11:15 -0800)]
[RISCV] Support shift/rotate amount operands in isAllUsesReadW.

These operands use 6 bits.

Reviewed By: asb

Differential Revision: https://reviews.llvm.org/D137450

23 months ago[RISCV] Improve support for ADD_UW/SHXADD_UW in hasAllWUsers.
Craig Topper [Wed, 9 Nov 2022 19:15:03 +0000 (11:15 -0800)]
[RISCV] Improve support for ADD_UW/SHXADD_UW in hasAllWUsers.

The first use operand of these is implicitly zero extended. We
can consider that a W read. If the use is the other operand, we
need to look through the instruction.

Reviewed By: asb

Differential Revision: https://reviews.llvm.org/D137449

23 months ago[RISCV] Support SB/SH/SW in hasAllWUsers in RISCVSExtWRemoval.
Craig Topper [Wed, 9 Nov 2022 19:14:21 +0000 (11:14 -0800)]
[RISCV] Support SB/SH/SW in hasAllWUsers in RISCVSExtWRemoval.

After D137446 we can see which operand is the user. If the user
is the value operand of a SB/SH/SW then the upper 32 bits aren't
used.

Reviewed By: asb

Differential Revision: https://reviews.llvm.org/D137448

23 months ago[RISCV] Rework hasAllWUsers in RISCVSExtWRemoval. NFCI
Craig Topper [Wed, 9 Nov 2022 07:40:15 +0000 (23:40 -0800)]
[RISCV] Rework hasAllWUsers in RISCVSExtWRemoval. NFCI

Instead of storing the uses to check in the worklist, store the
instruction we want to check uses for.

Now we pop and instruction from the worklist, loop over its uses
and check them. If it's something we need to look across, we'll push
it to the worklist.

By doing it this way, we can have access to which operand
of the user is using the instruction. This will allow supporting
store instructions since we'll be able to disambiguate the the value
operand and the pointer operand. We can also improve support for
*add.uw instructions and shift amount uses.

Reviewed By: mohammed-nurulhoque, asb

Differential Revision: https://reviews.llvm.org/D137446

23 months ago[clang] Mention vector in the description for -mno-implict-float.
Craig Topper [Wed, 9 Nov 2022 07:24:01 +0000 (23:24 -0800)]
[clang] Mention vector in the description for -mno-implict-float.

As far as I understand, this disables all integer vectors too.

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D134089

23 months ago[ORC] Add a unit test to verify that bound weak symbols can't be overridden.
Lang Hames [Wed, 9 Nov 2022 19:13:18 +0000 (11:13 -0800)]
[ORC] Add a unit test to verify that bound weak symbols can't be overridden.

Weak symbols can be overridden while they're in the NeverSearched state, but
should not be able to be overridden once they've been bound by some lookup.
Historically we guaranteed this by stripping the weak flag once a symbol as
bound, causing it to appear as if it were strong. In ffe2dda29f3 we changed
that behavior to retain weak flags on symbols (to facilitate tracking for
dynamic re-binding during dlopen). This test checks that we still fail as
required after ffe2dda29f3.

23 months agoMove googletest to the third-party directory
Tom Stellard [Wed, 9 Nov 2022 16:51:34 +0000 (08:51 -0800)]
Move googletest to the third-party directory

This will help improve the project's layering, so that sub-projects
that don't actually need any llvm code can still use googletest
without having to reference code in the llvm directory.

This will also make it easier to consolidate and simplify the standalone
build configurations.

Reviewed By: stellaraccident, lattner, probinson, phosek

Differential Revision: https://reviews.llvm.org/D131919

23 months agoUsing higher level interface to insert new arguments so arguments
Renaud-K [Wed, 9 Nov 2022 19:04:22 +0000 (11:04 -0800)]
Using higher level interface to insert new arguments so arguments
and their corresponding attributes are moved together

Differential revision: https://reviews.llvm.org/D13767

23 months ago[clangd] Fix the code action `RemoveUsingNamespace`
v1nh1shungry [Wed, 9 Nov 2022 20:04:20 +0000 (21:04 +0100)]
[clangd] Fix the code action `RemoveUsingNamespace`

Avoid adding qualifiers before user-defined literals

Reviewed By: tom-anders

Differential Revision: https://reviews.llvm.org/D137550

23 months agoHandle aliasing a non-top-level command.
Jim Ingham [Wed, 9 Nov 2022 18:11:16 +0000 (10:11 -0800)]
Handle aliasing a non-top-level command.

This didn't work previously because we had to check whether the incoming
command was an alias command, but if it wasn't we still used the result
of that lookup - which was by the command's node name.  That fails for
non-top-level commands.  In this case, the resolution is pretty simple since
we already have the node's CommandObject, so all we needed to do was turn
it into a shared pointer, for which I added enable_shared_from_this to the
CommandObject.

Differential Revision: https://reviews.llvm.org/D137662

23 months agoDon't try to create Expressions when the process is running.
Jim Ingham [Wed, 9 Nov 2022 18:03:30 +0000 (10:03 -0800)]
Don't try to create Expressions when the process is running.

We generally prohibit this at a higher level - for instance requiring
the process to be stopped for "expr".  But when we trigger an expression
for internal purposes (e.g. to fetch types from the ObjC runtime) we weren't
checking the process state.  Now we explicitly check this at the very start
of the job so we don't get into bad states.

Differential Revision: https://reviews.llvm.org/D137684

23 months ago[include-cleaner] Add dependency to fix build with shared libraries
Ilya Biryukov [Wed, 9 Nov 2022 17:31:14 +0000 (18:31 +0100)]
[include-cleaner] Add dependency to fix build with shared libraries

23 months agoRename unique-types2/TestUniqueTypes.py to TestUniqueTypes2.py
Jason Molenda [Wed, 9 Nov 2022 16:38:57 +0000 (08:38 -0800)]
Rename unique-types2/TestUniqueTypes.py to TestUniqueTypes2.py

lang/cpp/unique-types/TestUniqueTypes.py already exists.

23 months ago[X86] Replace unnecessary CVTPS2PI/CVTPS2DQ overrides with better base class defs
Simon Pilgrim [Wed, 9 Nov 2022 17:08:36 +0000 (17:08 +0000)]
[X86] Replace unnecessary CVTPS2PI/CVTPS2DQ overrides with better base class defs

Broadwell/Haswell were completely overriding the WriteCvtPD2I class defs - we can remove those overrides entirely by just choosing better class defs.

Also fixes the scheduler for a missing YMM folded case - confirmed with Agner + uops.info that the port usage is correct

23 months agoRevert "[amdgpu][lds] Use the same isKernel predicate consistently"
Jon Chesterfield [Wed, 9 Nov 2022 16:54:20 +0000 (16:54 +0000)]
Revert "[amdgpu][lds] Use the same isKernel predicate consistently"

Looks like this composed poorly with a nominally independent patch, will fix
This reverts commit 0ba0398517778514eb44cb7ba9bf9d4d20a856e0.

23 months ago[amdgpu][lds] Use the same isKernel predicate consistently
Jon Chesterfield [Wed, 9 Nov 2022 16:45:02 +0000 (16:45 +0000)]
[amdgpu][lds] Use the same isKernel predicate consistently

isKernelCC != isKernel(F->getCallingConv())
There's a test case (lower-kernel-lds.ll) that explicitly skips amdgpu_ps
so this change picks the isKernel predicate that continues to skip that
calling convention.

isKernel returns true for AMDGPU_KERNEL and SPIR_KERNEL. isKernelCC also
returns true for other calling conventions.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D136599

23 months agoRevert "[LLD] Enable --no-undefined-version by default."
Jon Chesterfield [Wed, 9 Nov 2022 16:17:33 +0000 (16:17 +0000)]
Revert "[LLD] Enable --no-undefined-version by default."

This reverts commit eedbe44b8755f7d162eee43cb3e8c9da1e61ebad.

23 months ago[AArch64][SME] Disable GlobalISel/FastISel for SME functions.
Sander de Smalen [Wed, 9 Nov 2022 15:53:53 +0000 (15:53 +0000)]
[AArch64][SME] Disable GlobalISel/FastISel for SME functions.

This patch ensures that GlobalISel and FastISel fall back to regular DAG ISel when:
* A function requires streaming-mode to be enabled at the start/end of the function.
  This happens when the function has no streaming interface, but does have a streaming body.
* A function requires a lazy-save to be committed at the start of the function.
  This happens if the function has the `aarch64_pstate_za_new` attribute.
* A call to a function requires a change in streaming-mode.
* A call to a function requires a lazy-save buffer to be set up.

Patch by @CarolineConcatto

Reviewed By: david-arm

Differential Revision: https://reviews.llvm.org/D136361

23 months ago[amdgpu][lds] Use a consistent order of fields in generated structs
Jon Chesterfield [Wed, 9 Nov 2022 15:57:38 +0000 (15:57 +0000)]
[amdgpu][lds] Use a consistent order of fields in generated structs

Avoids spurious and confusing test failures on changing implementation.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D136598

23 months ago[AArch64] NFC: Remove unused parameter from allocateLazySaveBuffer
Sander de Smalen [Tue, 8 Nov 2022 13:22:48 +0000 (13:22 +0000)]
[AArch64] NFC: Remove unused parameter from allocateLazySaveBuffer

23 months agoRevert "[mlir][linalg] Replace "string" iterator_types attr with enums in LinalgInter...
Oleg Shyshkov [Wed, 9 Nov 2022 14:59:54 +0000 (15:59 +0100)]
Revert "[mlir][linalg] Replace "string" iterator_types attr with enums in LinalgInterface."

Breaks linalg python tests. Would need to also update python/mlir/dialects/linalg/opdsl.

This reverts commit b809d73973bb5aeedeb6a18cac2a7b3111d0c8d2.

23 months ago[X86] Replace unnecessary CVTSD2SI/CVTSS2SI overrides with better base class defs
Simon Pilgrim [Wed, 9 Nov 2022 14:54:03 +0000 (14:54 +0000)]
[X86] Replace unnecessary CVTSD2SI/CVTSS2SI overrides with better base class defs

Broadwell/Haswell were completely overriding the WriteCvtSD2I/WriteCvtSS2I class defs - we can remove those overrides entirely by just choosing better class defs.

23 months ago[mlir][linalg] Replace "string" iterator_types attr with enums in LinalgInterface.
Oleg Shyshkov [Wed, 9 Nov 2022 14:42:40 +0000 (15:42 +0100)]
[mlir][linalg] Replace "string" iterator_types attr with enums in LinalgInterface.

[RFC: EnumAttr for iterator types in Linalg](https://discourse.llvm.org/t/rfc-enumattr-for-iterator-types-in-linalg/64535)

This affect touches and probably breaks most of the code that creates `linalg.generic`. A fix would be to replace calls to `getParallelIteratorTypeName/getReductionIteratorTypeName` with `mlir::utils::IteratorType::parallel/reduction` and types from `StringRef` to `mlir::utils::IteratorType`.

Due to limitations of tablegen, shared C++ definition of IteratorType enum lives in StructuredOpsUtils.td, but each dialect should have it's own EnumAttr wrapper. To avoid conflict, all enums in a dialect are put into a separate file with a separate tablegen rule.

Test dialect td files are refactored a bit.

Printed format of `linalg.generic` temporarily remains unchanged to avoid breaking code and tests in the same change.

Differential Revision: https://reviews.llvm.org/D137658

23 months ago[AArch64][SVE2] Add the SVE2.1 integer quadword reduction instructions
David Sherwood [Thu, 3 Nov 2022 11:04:43 +0000 (11:04 +0000)]
[AArch64][SVE2] Add the SVE2.1 integer quadword reduction instructions

This patch adds the assembly/disassembly for the following instructions:

addqv  : Unsigned add reduction of quadword vector segments
andqv  : Bitwise AND reduction of quadword vector segments
eorqv  : Bitwise exclusive OR reduction of quadword vector segments
orqv   : Bitwise inclusive OR reduction of quadword vector segments
smaxqv : Signed maximum reduction of quadword vector segments
sminqv : Signed minimum reduction of quadword vector segments
umaxqv : Unsigned maximum reduction of quadword vector segments
uminqv : Unsigned minimum reduction of quadword vector segments

The reference can be found here:
https://developer.arm.com/documentation/ddi0602/2022-09

Differential Revision: https://reviews.llvm.org/D137411

23 months ago[SCCP] Add tests for with.overflow intrinsics (NFC)
Nikita Popov [Wed, 9 Nov 2022 14:25:38 +0000 (15:25 +0100)]
[SCCP] Add tests for with.overflow intrinsics (NFC)

23 months agoFix Clang sphinx build
Aaron Ballman [Wed, 9 Nov 2022 14:19:24 +0000 (09:19 -0500)]
Fix Clang sphinx build

This addresses the issue found by:
https://lab.llvm.org/buildbot/#/builders/92/builds/35350

23 months ago[analyzer] Fix crash for array-delete of UnknownVal values.
Tomasz Kamiński [Wed, 9 Nov 2022 13:31:49 +0000 (14:31 +0100)]
[analyzer] Fix crash for array-delete of UnknownVal values.

We now skip the destruction of array elements for `delete[] p`,
if the value of `p` is UnknownVal and does not have corresponding region.
This eliminate the crash in `getDynamicElementCount` on that
region and matches the behavior for deleting the array of
non-constant range.

Reviewed By: isuckatcs

Differential Revision: https://reviews.llvm.org/D136671

23 months ago[Support] Format provider improvements
Vladislav Vinogradov [Wed, 2 Nov 2022 11:22:14 +0000 (14:22 +0300)]
[Support] Format provider improvements

Remove `std::forward` call for `iterator_range` iterator de-reference.
It fixes formatting usage for some tricky cases, like special ranges,
which de-reference to value type.

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D94769

23 months ago[mlir][Transform] Fix transform.sequence crash in the presence of propagated silencea...
Nicolas Vasilache [Wed, 9 Nov 2022 13:09:39 +0000 (05:09 -0800)]
[mlir][Transform] Fix transform.sequence crash in the presence of propagated silenceable errors and yield operations

Differential Revision: https://reviews.llvm.org/D137708

23 months ago[OpenCL] Guard read_write image3d with cl_khr_3d_image_writes
Sven van Haastregt [Wed, 9 Nov 2022 13:17:23 +0000 (13:17 +0000)]
[OpenCL] Guard read_write image3d with cl_khr_3d_image_writes

Not all `read_write image3d_t` occurrences in opencl-c.h were guarded
with `cl_khr_3d_image_writes`.  Align with `-fdeclare-opencl-builtins`.

23 months agoRevert "[Support] Format provider improvements"
Vladislav Vinogradov [Wed, 9 Nov 2022 13:14:39 +0000 (16:14 +0300)]
Revert "[Support] Format provider improvements"

This reverts commit 791bdba0b183371ca3e16bb8411a059b4f8636ac.

Bot failure: https://lab.llvm.org/buildbot/#/builders/223/builds/9914

23 months ago[Support] Format provider improvements
Vladislav Vinogradov [Wed, 2 Nov 2022 11:22:14 +0000 (14:22 +0300)]
[Support] Format provider improvements

Remove `std::forward` call for `iterator_range` iterator de-reference.
It fixes formatting usage for some tricky cases, like special ranges,
which de-reference to value type.

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D94769

23 months agoFix an unused-variable warning in release build, NFC.
Haojian Wu [Wed, 9 Nov 2022 12:03:12 +0000 (13:03 +0100)]
Fix an unused-variable warning in release build, NFC.

23 months ago[ARM] Move Triple::getARMCPUForArch into ARMTargetParser
Tomas Matheson [Sun, 23 Oct 2022 20:44:21 +0000 (21:44 +0100)]
[ARM] Move Triple::getARMCPUForArch into ARMTargetParser

This is very backend specific so either belongs in Toolchains/ARM or in
ARMTargetParser. Since it is used in lldb, ARMTargetParser made more sense.

This is part of an effort to move information about ARM/AArch64 architecture
versions, extensions and CPUs into their respective TargetParsers.

Differential Revision: https://reviews.llvm.org/D137564

23 months ago[Assignment Tracking][10/*] salvageDebugInfo for dbg.assign intrinsics
OCHyams [Wed, 9 Nov 2022 11:39:29 +0000 (11:39 +0000)]
[Assignment Tracking][10/*] salvageDebugInfo for dbg.assign intrinsics

The Assignment Tracking debug-info feature is outlined in this RFC:

https://discourse.llvm.org/t/
rfc-assignment-tracking-a-better-way-of-specifying-variable-locations-in-ir

Plumb in salvaging for the address part of dbg.assign intrinsics.

Reviewed By: jmorse

Differential Revision: https://reviews.llvm.org/D133293

23 months ago[SCCP] Add helper for getting constant range (NFC)
Nikita Popov [Wed, 9 Nov 2022 11:18:18 +0000 (12:18 +0100)]
[SCCP] Add helper for getting constant range (NFC)

Add a helper for the recurring pattern of getting a constant range
if the value lattice element is one, or a full range otherwise.

23 months ago[AArch64] Add support for the Cortex-X3 CPU
Victor Campos [Wed, 19 Oct 2022 13:03:57 +0000 (14:03 +0100)]
[AArch64] Add support for the Cortex-X3 CPU

Cortex-X3 is an Armv9-A AArch64 CPU.

This patch introduces support for Cortex-X3.

Technical Reference Manual: https://developer.arm.com/documentation/101593/latest

Reviewed By: dmgreen

Differential Revision: https://reviews.llvm.org/D136589

23 months ago[mlir][complex] Canonicalize complex.sub zero
Kai Sasaki [Wed, 9 Nov 2022 11:11:55 +0000 (12:11 +0100)]
[mlir][complex] Canonicalize complex.sub zero

Subtracting zero constant can be fold in no complex.sub operation.

Reviewed By: pifon2a

Differential Revision: https://reviews.llvm.org/D137523

23 months ago[Assignment Tracking][9/*] Don't drop DIAssignID in dropUnknownNonDebugMetadata
OCHyams [Wed, 9 Nov 2022 10:49:55 +0000 (10:49 +0000)]
[Assignment Tracking][9/*] Don't drop DIAssignID in dropUnknownNonDebugMetadata

The Assignment Tracking debug-info feature is outlined in this RFC:

https://discourse.llvm.org/t/
rfc-assignment-tracking-a-better-way-of-specifying-variable-locations-in-ir

A DIAssignID attachment is debug metadata, so don't drop it.

Reviewed By: jmorse

Differential Revision: https://reviews.llvm.org/D133292

23 months ago[Assignment Tracking][8/*] Add DIAssignID merging utilities
OCHyams [Wed, 9 Nov 2022 10:41:28 +0000 (10:41 +0000)]
[Assignment Tracking][8/*] Add DIAssignID merging utilities

The Assignment Tracking debug-info feature is outlined in this RFC:

https://discourse.llvm.org/t/
rfc-assignment-tracking-a-better-way-of-specifying-variable-locations-in-ir

Add method:

  Instruction::mergeDIAssignID(
      ArrayRef<const Instruction* > SourceInstructions)

which merges the DIAssignID metadata attachments on `SourceInstructions` and
`this` and replaces uses of the original IDs with the new shared one.

This is used when stores are merged, for example sinking stores out of a
if-diamond CFG or vectorizing contiguous stores.

Reviewed By: jmorse

Differential Revision: https://reviews.llvm.org/D133291

23 months ago[flang][NFC] move fir namespace into FortranVariableOpInterface ODS declaration
Jean Perier [Wed, 9 Nov 2022 10:40:56 +0000 (11:40 +0100)]
[flang][NFC] move fir namespace into FortranVariableOpInterface ODS declaration

This will be needed to be able to use this interface in HLFIR ODS operation definition
and get the right namespaces.

Differential Revision: https://reviews.llvm.org/D137702

23 months ago[flang][NFC] move HLFIR dialect definition in IR
Jean Perier [Wed, 9 Nov 2022 10:37:53 +0000 (11:37 +0100)]
[flang][NFC] move HLFIR dialect definition in IR

Transforms will need to be put in a different library to avoid circular
dependencies with other parts of the compiler. So create an IR
directory, this (flat include directory, IR and Transform directories in
lib) matches how dialects like LLVM dialect are implemented.

Differential Revision: https://reviews.llvm.org/D137701

23 months ago[M68k] Add support for atomic instructions
Sheng [Wed, 9 Nov 2022 10:37:03 +0000 (18:37 +0800)]
[M68k] Add support for atomic instructions

This adds support for atomic_load, atomic_store, atomic_cmpxchg
and atomic_rmw

Fixes #48236

Reviewed by: myhsu, efriedma

Differential Revision: https://reviews.llvm.org/D136525

23 months ago[M68k] Replace `IsM680x0` with predicates `AtLeastM680x0`
Sheng [Wed, 9 Nov 2022 10:25:09 +0000 (18:25 +0800)]
[M68k] Replace `IsM680x0` with predicates `AtLeastM680x0`

The former is incorrect.

Reviewed By: myhsu

Differential Revision: https://reviews.llvm.org/D137425

23 months ago[NFC][AMDGPU] Pre-commit tests for D136432.
Thomas Symalla [Wed, 9 Nov 2022 10:23:24 +0000 (11:23 +0100)]
[NFC][AMDGPU] Pre-commit tests for D136432.

23 months ago[AArch64] Support all extend/shift op for pattern: (ExtendOrShfitNode - Y) + Z -...
chenglin.bi [Wed, 9 Nov 2022 10:06:21 +0000 (18:06 +0800)]
[AArch64] Support all extend/shift op for pattern: (ExtendOrShfitNode - Y) + Z --> (Z - Y) + ExtendOrShfitNode

Followup rG325a3083b5b24
Add SRL/SRA/xxx_EXTEND/AND support

Reviewed By: dmgreen

Differential Revision: https://reviews.llvm.org/D137069

23 months agoReapply: [Assignment Tracking][7/*] Add assignment tracking functionality to clang
OCHyams [Tue, 8 Nov 2022 16:58:53 +0000 (16:58 +0000)]
Reapply: [Assignment Tracking][7/*] Add assignment tracking functionality to clang

Reverted in 98fa95492f3bbd5befdeb36c88a3ac5ef2740b4e.

The Assignment Tracking debug-info feature is outlined in this RFC:

https://discourse.llvm.org/t/
rfc-assignment-tracking-a-better-way-of-specifying-variable-locations-in-ir

This patch plumbs the AssignmentTrackingPass (AKA declare-to-assign), added in
the previous patch in this set, into the optimisation pipeline from
clang. clang/test/CodeGen/assignment-tracking/assignment-tracking.cpp is the
main test for this patch.

Note: while clang (with the help of the declare-to-assign pass) can now emit
Assignment Tracking metadata, the llvm middle and back ends don't yet
understand it.

Reviewed By: jmorse

Differential Revision: https://reviews.llvm.org/D132226

23 months agoFix D132221 rebase: Add flags to enable Assignment Tracking
OCHyams [Wed, 9 Nov 2022 09:11:02 +0000 (09:11 +0000)]
Fix D132221 rebase: Add flags to enable Assignment Tracking

The flags were not set up properly after rebasing the patch, causing bot
failures for D132226, for example:

https://lab.llvm.org/buildbot/#/builders/109/builds/50251

23 months ago[AArch64][SVE2] Add the SVE2.1 quadword structured load/store instructions
David Sherwood [Mon, 7 Nov 2022 10:18:34 +0000 (10:18 +0000)]
[AArch64][SVE2] Add the SVE2.1 quadword structured load/store instructions

This patch adds the assembly/disassembly for the following instructions:

ld2q : Contiguous load two-quadword structures to two vectors
ld3q : Contiguous load three-quadword structures to three vectors
ld4q : Contiguous load four-quadword structures to four vectors
st2q : Contiguous store two-quadword structures from two vectors
st3q : Contiguous store three-quadword structures to three vectors
st4q : Contiguous store four-quadword structures to four vectors

The reference can be found here:
https://developer.arm.com/documentation/ddi0602/2022-09

Differential Revision: https://reviews.llvm.org/D137554

23 months ago[test] Avoid legacy PM default pipelines (O0,O1 etc) when running opt
Bjorn Pettersson [Tue, 8 Nov 2022 07:04:39 +0000 (08:04 +0100)]
[test] Avoid legacy PM default pipelines (O0,O1 etc) when running opt

Two lit tests were found running something like this:
  opt -O<n> -pass-locked-to-legacy-PM ...

The expand-atomicrmw-xchg-fp.ll seem to have used -O1 just to ensure
that the -atomic-expand pass were thinking that it wasn't running at
O0 level. Same thing can be ensured by using the -codegen-opt-level=1
option, making it possible to avoid using O1 in that test case.

In the vector-reductions-expanded.ll test case it was possible to
split the RUN line into using two opt invocations. First running
"opt -O2" using the new PM, and then running "opt -expand-reductions"
using the legacy PM.

I think that given this patch we get closer to removing code related
to 'AddOptimizationPasses' in opt.cpp.

Differential Revision: https://reviews.llvm.org/D137626

23 months ago[X86] Support -march=sierraforest, grandridge, graniterapids.
Freddy Ye [Wed, 9 Nov 2022 08:12:25 +0000 (16:12 +0800)]
[X86] Support -march=sierraforest, grandridge, graniterapids.

Reviewed By: skan, pengfei, MaskRay

Differential Revision: https://reviews.llvm.org/D137153

23 months ago[RISCV] Add support for static chain
melonedo [Tue, 16 Aug 2022 04:56:59 +0000 (12:56 +0800)]
[RISCV] Add support for static chain

The static chain parameter is a special parameter that is not passed in the usual argument registers or stack space. For example, in x64 System V ABI it is always passed in R10. Although the ABI of RISCV does not assign a register for this purpose, GCC had support for it on RISC-V a long time ago, and it is exposed via `__builtin_call_with_static_chain` intrinsic, and assign t2 for static chain parameters. This patch also chose t2 for compatibility.

In LLVM, static chain parameters are handled by the `nest` attribute of an argument to a function ([D6332](https://reviews.llvm.org/D6332)), so tests are added to ensure `nest` arguments are handled correctly.

Reviewed By: kito-cheng, MaskRay

Differential Revision: https://reviews.llvm.org/D129106

23 months ago[AArch64] Precommit test for D137069; NFC
chenglin.bi [Wed, 9 Nov 2022 07:36:47 +0000 (15:36 +0800)]
[AArch64] Precommit test for D137069; NFC

23 months ago[compiler-rt] Set CMP0114 policy for standalone build
Vitaly Buka [Wed, 9 Nov 2022 06:59:03 +0000 (22:59 -0800)]
[compiler-rt] Set CMP0114 policy for standalone build

Fixes sanitizer-x86_64-linux-qemu bot.

23 months ago[OpenMP] Add map clause to the LIT test on use_device_addr clause
Animesh Kumar [Fri, 30 Sep 2022 17:14:42 +0000 (22:44 +0530)]
[OpenMP] Add map clause to the LIT test on use_device_addr clause

As per the OpenMP Spec, "A list item in a use_device_addr clause
must have a corresponding list item in the device data environment"
. Therefore a `map` clause is added which will make sure that the
respective list items are mapped to the device data environment
before the `use_device_addr` clause is specified. The CHECK lines
are also modified based on this change.

Differential Revision: https://reviews.llvm.org/D134974

23 months ago[libunwind] Check corrupted return address in unwind_phase2 when CET is enabled.
jinge90 [Wed, 9 Nov 2022 06:24:39 +0000 (14:24 +0800)]
[libunwind] Check corrupted return address in unwind_phase2 when CET is enabled.

If CET shadow stack is enabled, we count the number of stack frames skipped
and adjust CET shadow stack based on the number in libunwind unwind_phase2.
At the same time, we can enhance security via comparing the return address in
normal stack against counterpart in CET shadow stack, if they don't match,
it means the return address stored in normal stack has been corrupted and we
will return _URC_FATAL_PHASE2_ERROR in that case.

Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D136667

Signed-off-by: jinge90 <ge.jin@intel.com>
23 months ago[X86] Add In64BitMode requirement for MMXRI
Haohai Wen [Wed, 9 Nov 2022 06:08:01 +0000 (14:08 +0800)]
[X86] Add In64BitMode requirement for MMXRI

REX_W prefix is only encodable in 64bit.

Reviewed By: skan

Differential Revision: https://reviews.llvm.org/D137686

23 months ago[TypePromotion] Replace Zext to Truncate for the case src bitwidth is larger
chenglin.bi [Tue, 8 Nov 2022 21:07:44 +0000 (05:07 +0800)]
[TypePromotion] Replace Zext to Truncate for the case src bitwidth is larger

Fix: https://github.com/llvm/llvm-project/issues/58843

Reviewed By: samtebbs

Differential Revision: https://reviews.llvm.org/D137613

23 months ago[mlir][LLVM] Add base type and flag support to composite type
River Riddle [Tue, 8 Nov 2022 20:46:41 +0000 (12:46 -0800)]
[mlir][LLVM] Add base type and flag support to composite type

This requires defining the DIFlag enum from LLVM.

Differential Revision: https://reviews.llvm.org/D137667

23 months ago[mlir][sparse] fix SSA chain issue in dense2sparse conversion.
Peiming Liu [Wed, 9 Nov 2022 01:42:26 +0000 (01:42 +0000)]
[mlir][sparse] fix SSA chain issue in dense2sparse conversion.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D137683

23 months ago[mlir][sparse] extend foreach operation to iterator over sparse constant.
Peiming Liu [Wed, 9 Nov 2022 00:43:27 +0000 (00:43 +0000)]
[mlir][sparse] extend foreach operation to iterator over sparse constant.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D137679

23 months ago[mlir][arith] Add `select` support to WIE
Jakub Kuderski [Wed, 9 Nov 2022 01:34:31 +0000 (20:34 -0500)]
[mlir][arith] Add `select` support to WIE

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D137589

23 months ago[lld] Fix duplicate word typos. NFC
Fangrui Song [Wed, 9 Nov 2022 01:28:04 +0000 (17:28 -0800)]
[lld] Fix duplicate word typos. NFC

Based on lld/ part of D137338 but reflowed comments.

23 months ago[flang] Fix function result rewrite for CPTR type
Peixin-Qiao [Wed, 9 Nov 2022 01:24:38 +0000 (09:24 +0800)]
[flang] Fix function result rewrite for CPTR type

Not all derived type can be taken as abstract result. The CPTR type
should be treated as return by value so to interoperable with C
functions. Fix the function result rewrite for CPTR type, but it
should be generalized for all derived types. The ABI of
interoperability with C for derived type is architecture dependent,
which should be supported later.

Reviewed By: PeteSteinfeld, jeanPerier

Differential Revision: https://reviews.llvm.org/D137548

23 months ago[mlir][sparse] Factoring out NewCallParams class in SparseTensorConversion.cpp
wren romano [Wed, 9 Nov 2022 00:43:44 +0000 (16:43 -0800)]
[mlir][sparse] Factoring out NewCallParams class in SparseTensorConversion.cpp

The new class helps encapsulate the arguments to `_mlir_ciface_newSparseTensor` so that client code doesn't depend on the details of the API.  (This makes way for the next differential which significantly alters the API.)

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D137680

23 months agoMove the second instance of TestUniqueTypes.py to a unique file
Jim Ingham [Wed, 9 Nov 2022 00:57:57 +0000 (16:57 -0800)]
Move the second instance of TestUniqueTypes.py to a unique file
name.  lldb-dotest.py errors out if two tests have the same filename.