timothy_horton@apple.com [Mon, 2 Apr 2012 21:19:29 +0000 (21:19 +0000)]
ASSERTION FAILED: m_purgePreventCount in FontCache::getCachedFontData running svg/custom/animate-disallowed-use-element.svg
https://bugs.webkit.org/show_bug.cgi?id=81002
<rdar://problem/
11168969>
Reviewed by Simon Fraser.
Don't spend time rebuilding SVG text layout attributes if the document is being torn down, as
they won't be used, and can cause assertion failures in the font cache.
No new tests, as it fixes an intermittent assertion failure during document destruction.
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::willBeDestroyed):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 21:16:03 +0000 (21:16 +0000)]
svg/W3C-SVG-1.1/animate-elem-80-t.svg is flaky on mac
https://bugs.webkit.org/show_bug.cgi?id=82911
Unreviewed test_expectations update.
Fixing Mac 10.7 buildbot redness by marking animate-elem-80-t.svg as flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 21:15:23 +0000 (21:15 +0000)]
[BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load()
https://bugs.webkit.org/show_bug.cgi?id=80519
Source/WebCore:
Stop asserting in platformCachePolicyForRequest() as now it is expected
that the ResourceRequest might not have the right TargetType setup at
this time for main loads.
Patch by Lianghui Chen <liachen@rim.com> on 2012-04-02
Reviewed by Rob Buis.
No new tests as no change in behaviour.
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::platformCachePolicyForRequest):
Source/WebKit/blackberry:
Set the right TargetType for main loads if they are not already set in
dispatchWillSendRequest().
Also adjust NetworkRequest TargetType for decidePolicyForExternalLoad()
and dispatchDecidePolicyForNavigationAction() as they are called before
dispatchWillSendRequest() is called. Patch to change ResourceRequest
TargetType earlier has been rejected as in WebKit bug
https://bugs.webkit.org/show_bug.cgi?id=80713
Patch by Lianghui Chen <liachen@rim.com> on 2012-04-02
Reviewed by Rob Buis.
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Mon, 2 Apr 2012 21:10:28 +0000 (21:10 +0000)]
Fix issue with reflections and composited layers
https://bugs.webkit.org/show_bug.cgi?id=82636
Source/WebCore:
Reviewed by Alexey Proskuryakov
When tearing down GraphicsLayers which referene eachother via m_replicatedLayer/m_replicaLayer,
we need to clean up the replica layer pointers.
No new tests; tested by existing compositing and repaint tests.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::~GraphicsLayer):
(WebCore::GraphicsLayer::setReplicatedByLayer):
LayoutTests:
Reviewed by Alexey Proskuryakov
Unskip some compositing tests that should pass now.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Mon, 2 Apr 2012 21:07:37 +0000 (21:07 +0000)]
Source/WebCore: Add Oscillator/WaveTable implementation and tests
https://bugs.webkit.org/show_bug.cgi?id=82414
Oscillator represents an audio source generating a periodic waveform. It can be set to
a few commonly used waveforms. Additionally, it can be set to an arbitrary periodic
waveform through the use of a WaveTable object.
Reviewed by Kenneth Russell.
Tests: webaudio/oscillator-custom.html
webaudio/oscillator-sawtooth.html
webaudio/oscillator-sine.html
webaudio/oscillator-square.html
webaudio/oscillator-triangle.html
* DerivedSources.make:
* GNUmakefile.list.am:
Add Oscillator and WaveTable to build files.
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createOscillator):
(WebCore):
(WebCore::AudioContext::createWaveTable):
* Modules/webaudio/AudioContext.h:
Add create methods for Oscillator and WaveTable.
(WebCore):
(AudioContext):
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/AudioNode.h:
* Modules/webaudio/Oscillator.cpp: Added.
(WebCore):
(WebCore::Oscillator::create):
(WebCore::Oscillator::Oscillator):
(WebCore::Oscillator::~Oscillator):
(WebCore::Oscillator::setType):
(WebCore::Oscillator::calculateSampleAccuratePhaseIncrements):
(WebCore::Oscillator::process):
(WebCore::Oscillator::reset):
(WebCore::Oscillator::setWaveTable):
* Modules/webaudio/Oscillator.h: Added.
(WebCore):
(Oscillator):
(WebCore::Oscillator::type):
(WebCore::Oscillator::frequency):
(WebCore::Oscillator::detune):
Implement Oscillator as AudioSourceNode.
* Modules/webaudio/Oscillator.idl: Added.
* Modules/webaudio/WaveTable.cpp: Added.
(WebCore):
(WebCore::WaveTable::create):
(WebCore::WaveTable::createSine):
(WebCore::WaveTable::createSquare):
(WebCore::WaveTable::createSawtooth):
(WebCore::WaveTable::createTriangle):
(WebCore::WaveTable::WaveTable):
(WebCore::WaveTable::waveDataForFundamentalFrequency):
(WebCore::WaveTable::maxNumberOfPartials):
(WebCore::WaveTable::numberOfPartialsForRange):
(WebCore::WaveTable::createBandLimitedTables):
(WebCore::WaveTable::generateBasicWaveform):
* Modules/webaudio/WaveTable.h: Added.
(WebCore):
(WaveTable):
(WebCore::WaveTable::rateScale):
(WebCore::WaveTable::waveTableSize):
(WebCore::WaveTable::sampleRate):
(WebCore::WaveTable::numberOfRanges):
Implement WaveTable which is constructed given a set of Fourier coefficients.
* Modules/webaudio/WaveTable.idl: Added.
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
Add Oscillator and WaveTable files to build files.
LayoutTests: Add Oscillator/WaveTable implementation and tests
https://bugs.webkit.org/show_bug.cgi?id=82414
Reviewed by Kenneth Russell.
* webaudio/oscillator-custom-expected.wav: Added.
* webaudio/oscillator-custom.html: Added.
* webaudio/oscillator-sawtooth-expected.wav: Added.
* webaudio/oscillator-sawtooth.html: Added.
* webaudio/oscillator-sine-expected.wav: Added.
* webaudio/oscillator-sine.html: Added.
* webaudio/oscillator-square-expected.wav: Added.
* webaudio/oscillator-square.html: Added.
* webaudio/oscillator-triangle-expected.wav: Added.
* webaudio/oscillator-triangle.html: Added.
* webaudio/resources/oscillator-testing.js: Added.
(generateExponentialOscillatorSweep):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scherkus@chromium.org [Mon, 2 Apr 2012 21:05:09 +0000 (21:05 +0000)]
2012-04-02 David Dorwin <ddorwin@chromium.org>
Add layout test expectations for Chromium to exhibit support WebM types
https://bugs.webkit.org/show_bug.cgi?id=82925
Unreviewed.
* platform/chromium/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt: Added.
* platform/chromium/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
* platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt: Added.
* platform/chromium/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Mon, 2 Apr 2012 21:00:08 +0000 (21:00 +0000)]
Correct remaining LayoutUnit misuse in RenderReplaced and RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=82899
Reviewed by Darin Adler.
Removing remaining LayoutUnit misuse and compiler errors that exist in RenderReplaced
and RenderFlexibleBox once LayoutUnit becomes sub-pixel.
No new tests. No change in behavior.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems): Switching
a raw zero in a ternary operation to zeroLayoutUnit.
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild): Ditto for std::max.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint): Adding missing pixel snapping before painting.
(WebCore::RenderReplaced::computeReplacedLogicalWidth): Like above, switching
a raw zero to zeroLayoutUnit.
(WebCore::RenderReplaced::computePreferredLogicalWidths): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 20:58:10 +0000 (20:58 +0000)]
Crash due to floating object lists not properly being cleared
https://bugs.webkit.org/show_bug.cgi?id=74056
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-02
Reviewed by David Hyatt.
Source/WebCore:
Add a check to clearFloats() that determines when intruding floats
are being cleared and not re-added. In this condition, ensure
children with floats are also getting layout because they might
need to have the same intruding floats cleared from their floating
object lists also.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
LayoutTests:
This test creates a condition where an intruding float is changed so
that it no longer intrudes. The child of a sibling was not getting
properly updated during the next layout.
* fast/block/float/intruding-float-not-removed-from-descendant-crash-expected.txt: Added
* fast/block/float/intruding-float-not-removed-from-descendant-crash.html: Added
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 20:53:26 +0000 (20:53 +0000)]
[chromium] Layout Test svg/text/text-rescale.html is failing
https://bugs.webkit.org/show_bug.cgi?id=79454
Unreviewed Chromium test_expectations update.
Some the of results for svg/text/text-rescale.svg and svg/text/text-viewbox-rescale.svg
are just in need of rebaselining, while others are flakey. Clarifying
the situation in test_expectations.
* platform/chromium-linux/svg/text/text-rescale-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-viewbox-rescale-expected.txt: Removed.
* platform/chromium-mac/svg/text/text-rescale-expected.png: Added.
* platform/chromium-win/svg/text/text-rescale-expected.png: Added.
* platform/chromium-win/svg/text/text-rescale-expected.txt: Added.
* platform/chromium-win/svg/text/text-viewbox-rescale-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/svg/text/text-viewbox-rescale-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 20:46:07 +0000 (20:46 +0000)]
Align IDL to Typed Array Specification
https://bugs.webkit.org/show_bug.cgi?id=82919
Patch by Seo Sanghyeon <sh4.seo@samsung.com> on 2012-04-02
Reviewed by Darin Adler.
No tests. No change in behavior.
* html/canvas/Float32Array.idl:
* html/canvas/Float64Array.idl:
* html/canvas/Int16Array.idl:
* html/canvas/Int32Array.idl:
* html/canvas/Int8Array.idl:
* html/canvas/Uint16Array.idl:
* html/canvas/Uint32Array.idl:
* html/canvas/Uint8Array.idl:
* html/canvas/Uint8ClampedArray.idl:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 2 Apr 2012 20:45:32 +0000 (20:45 +0000)]
Skipping ASSERTING inspector/debugging tests.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 2 Apr 2012 20:38:04 +0000 (20:38 +0000)]
Skipping 2 Unicode tests that are crashing intermittently.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Mon, 2 Apr 2012 20:34:59 +0000 (20:34 +0000)]
WebKit should throttle memory pressure notifications in proportion to handler time
https://bugs.webkit.org/show_bug.cgi?id=82674
Rubber-stamped by Darin Adler.
Updated r112910: <http://trac.webkit.org/changeset/112910> to address
post checkin concerns raised in original bug.
No additional tests. This passes existing test and was verified using
manual tests on a small memory system with many websites open.
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 20:34:55 +0000 (20:34 +0000)]
[chromium] Layout Test svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm is flaky for DEBUG
https://bugs.webkit.org/show_bug.cgi?id=79455
Unreviewed Chromium test_expectations clean-up.
Closing another bug that is an instance of WK82232.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Mon, 2 Apr 2012 20:28:57 +0000 (20:28 +0000)]
Remove Source/JavaScriptCore/wtf and its empty subdirectories
Rubber-stamped by Eric Seidel.
Following the move of WTF from Source/JavaScriptCore/wtf to Source/WTF
(https://bugs.webkit.org/show_bug.cgi?id=75673), remove directory
Source/JavaScriptCore/wtf and its empty subdirectories.
* wtf: Removed.
* wtf/android: Removed.
* wtf/blackberry: Removed.
* wtf/chromium: Removed.
* wtf/dtoa: Removed.
* wtf/efl: Removed.
* wtf/gobject: Removed.
* wtf/gtk: Removed.
* wtf/mac: Removed.
* wtf/qt: Removed.
* wtf/qt/compat: Removed.
* wtf/tests: Removed.
* wtf/text: Removed.
* wtf/threads: Removed.
* wtf/threads/win: Removed.
* wtf/unicode: Removed.
* wtf/unicode/glib: Removed.
* wtf/unicode/icu: Removed.
* wtf/unicode/qt4: Removed.
* wtf/unicode/wince: Removed.
* wtf/url: Removed.
* wtf/url/api: Removed.
* wtf/url/src: Removed.
* wtf/win: Removed.
* wtf/wince: Removed.
* wtf/wx: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 2 Apr 2012 20:25:51 +0000 (20:25 +0000)]
Skipping flakey test on Mac.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 20:21:37 +0000 (20:21 +0000)]
REGRESSION(r110469): Some SVG Image related test is crashing on cr-mac
https://bugs.webkit.org/show_bug.cgi?id=80976
Unreviewed Chromium test_expectations clean-up
The tests reported in this bug are either no longer crashing or
crashing due to the same problem as Bug 82232. So they are being
consolidated in the test_expectations file.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 2 Apr 2012 20:17:51 +0000 (20:17 +0000)]
Skipping inspector/profiler/cpu-profiler-profiling.html
since it produces intermittent crashes.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Mon, 2 Apr 2012 20:14:07 +0000 (20:14 +0000)]
HistoryItem not updated properly when a form submission begins before a
previous form submission has finished.
https://bugs.webkit.org/show_bug.cgi?id=76686
Reviewed by Nate Chapin.
Source/WebCore:
Test: LayoutTests/fast/loader/form-submission-before-load-{get,post}.html
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadPostRequest):
LayoutTests:
* fast/loader/form-submission-before-load-get-expected.txt: Added.
* fast/loader/form-submission-before-load-get.html: Added.
* fast/loader/form-submission-before-load-post-expected.txt: Added.
* fast/loader/form-submission-before-load-post.html: Added.
* fast/loader/resources/form-submission-before-load-page2.html: Added.
* fast/loader/resources/form-submission-before-load-page3.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 2 Apr 2012 19:50:34 +0000 (19:50 +0000)]
Split remaining CSSRules into internal and CSSOM types
https://bugs.webkit.org/show_bug.cgi?id=82728
Reviewed by Andreas Kling.
This will complete the move to internal types for CSS rules. The only remaining unsplit type is
the CSSStyleSheet itself.
By separating internal types from the CSSOM we save memory immediately and enable future performance
optimizations as we are no longer tied to the structure of the API.
CSSOM type Internal type
CSSStyleRule StyleRule -> StyleRuleBase
CSSPageRule StyleRulePage -> StyleRuleBase
CSSFontFaceRule StyleRuleFontFace -> StyleRuleBase
CSSMediaRule StyleRuleMedia -> StyleRuleBlock -> StyleRuleBase
CSSImportRule StyleRuleImport -> StyleRuleBase
CSSCharsetRule String (owned by CSSStyleSheet)
CSSUnknownRule Never instantiated
WebKitCSSRegionRule StyleRuleRegion -> StyleRuleBlock -> StyleRuleBase
WebKitKeyframesRule StyleRuleKeyframes -> StyleRuleBase
WebKitKeyframeRule StyleKeyframe (owned by StyleRuleKeyframes)
StyleRuleBase is refcounted.
The CSSOM objects contain the public API functions and their implementations (almost) nothing else. Unlike the
CSSOM types they don't have parent pointers, saving memory.
The CSSOM tree is constructed on demand only. The CSSOM wrapper instances are constructed and owned by
the parent wrapper in the tree. Wrappers ref the corresponding internal type. The trees are kept in sync
when mutating.
All rules shrink by a pointer (from the parent pointer removal). The immediate memory savings from this patch are
larger as some earlier patches temporarily increased the memory use to allow incremental refactoring.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMBinding.h:
(WebCore):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::CSSFontFaceRule):
(WebCore::CSSFontFaceRule::style):
(WebCore::CSSFontFaceRule::cssText):
(WebCore):
* css/CSSFontFaceRule.h:
(WebCore):
(WebCore::CSSFontFaceRule::create):
(CSSFontFaceRule):
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSFontSelector.h:
(WebCore):
* css/CSSGrammar.y:
* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::create):
(WebCore::StyleRuleImport::StyleRuleImport):
(WebCore::StyleRuleImport::~StyleRuleImport):
(WebCore::StyleRuleImport::setCSSStyleSheet):
(WebCore::StyleRuleImport::isLoading):
(WebCore::StyleRuleImport::requestStyleSheet):
(WebCore::CSSImportRule::CSSImportRule):
(WebCore):
(WebCore::CSSImportRule::media):
(WebCore::CSSImportRule::cssText):
* css/CSSImportRule.h:
(StyleRuleImport):
(WebCore::StyleRuleImport::parentStyleSheet):
(WebCore::StyleRuleImport::clearParentStyleSheet):
(WebCore::StyleRuleImport::href):
(WebCore::StyleRuleImport::ImportedStyleSheetClient::ImportedStyleSheetClient):
(ImportedStyleSheetClient):
(CSSImportRule):
(WebCore::CSSImportRule::create):
(WebCore::CSSImportRule::href):
(WebCore::CSSImportRule::styleSheet):
(WebCore):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::~CSSMediaRule):
(WebCore::CSSMediaRule::insertRule):
(WebCore::CSSMediaRule::deleteRule):
(WebCore::CSSMediaRule::cssText):
(WebCore::CSSMediaRule::media):
(WebCore):
(WebCore::CSSMediaRule::length):
(WebCore::CSSMediaRule::item):
(WebCore::CSSMediaRule::cssRules):
* css/CSSMediaRule.h:
(WebCore):
(WebCore::CSSMediaRule::create):
(CSSMediaRule):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::style):
(WebCore::CSSPageRule::selectorText):
(WebCore::CSSPageRule::setSelectorText):
(WebCore::CSSPageRule::cssText):
* css/CSSPageRule.h:
(WebCore):
(WebCore::CSSPageRule::create):
(CSSPageRule):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParser::createMarginAtRule):
* css/CSSParser.h:
(WebCore):
(CSSParser):
* css/CSSPropertySourceData.h:
(WebCore):
* css/CSSStyleRule.cpp:
(WebCore):
(WebCore::selectorTextCache):
(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::~CSSStyleRule):
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleRule.h:
(WebCore):
(WebCore::CSSStyleRule::create):
(CSSStyleRule):
* css/CSSStyleSelector.cpp:
(RuleSet):
(WebCore::RuleSet::pageRules):
(WebCore::CSSStyleSelector::addKeyframeStyle):
(WebCore::CSSStyleSelector::sortAndTransferMatchedRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::CSSStyleSheet):
(WebCore::CSSStyleSheet::parserAppendRule):
(WebCore::CSSStyleSheet::createChildRuleCSSOMWrapper):
(WebCore::CSSStyleSheet::item):
(WebCore::CSSStyleSheet::clearCharsetRule):
(WebCore::CSSStyleSheet::clearRules):
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):
(WebCore::CSSStyleSheet::ensureCSSOMWrapper):
(WebCore):
(WebCore::CSSStyleSheet::ownerRule):
(WebCore::CSSStyleSheet::parentStyleSheet):
* css/CSSStyleSheet.h:
(WebCore):
(WebCore::CSSStyleSheet::create):
(CSSStyleSheet):
(WebCore::CSSStyleSheet::childRules):
(WebCore::CSSStyleSheet::importRules):
(WebCore::CSSStyleSheet::clearOwnerRule):
(WebCore::CSSStyleSheet::hasCharsetRule):
* css/StyleRule.cpp:
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::setProperties):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRulePage::~StyleRulePage):
(WebCore::StyleRulePage::setProperties):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleFontFace::~StyleRuleFontFace):
(WebCore::StyleRuleFontFace::setProperties):
(WebCore::StyleRuleBlock::StyleRuleBlock):
(WebCore::StyleRuleBlock::wrapperInsertRule):
(WebCore::StyleRuleBlock::wrapperRemoveRule):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleRegion::StyleRuleRegion):
* css/StyleRule.h:
(WebCore):
(WebCore::StyleRuleBase::type):
(StyleRuleBase):
(WebCore::StyleRuleBase::isCharsetRule):
(WebCore::StyleRuleBase::isFontFaceRule):
(WebCore::StyleRuleBase::isKeyframesRule):
(WebCore::StyleRuleBase::isMediaRule):
(WebCore::StyleRuleBase::isPageRule):
(WebCore::StyleRuleBase::isStyleRule):
(WebCore::StyleRuleBase::isRegionRule):
(WebCore::StyleRuleBase::isImportRule):
(WebCore::StyleRuleBase::sourceLine):
(WebCore::StyleRuleBase::deref):
(WebCore::StyleRuleBase::StyleRuleBase):
(WebCore::StyleRuleBase::~StyleRuleBase):
(StyleRule):
(WebCore::StyleRule::create):
(WebCore::StyleRule::parserAdoptSelectorVector):
(WebCore::StyleRule::wrapperAdoptSelectorList):
(StyleRuleFontFace):
(WebCore::StyleRuleFontFace::create):
(WebCore::StyleRuleFontFace::properties):
(StyleRulePage):
(WebCore::StyleRulePage::create):
(WebCore::StyleRulePage::selector):
(WebCore::StyleRulePage::properties):
(WebCore::StyleRulePage::parserAdoptSelectorVector):
(WebCore::StyleRulePage::wrapperAdoptSelectorList):
(StyleRuleBlock):
(WebCore::StyleRuleBlock::childRules):
(StyleRuleMedia):
(WebCore::StyleRuleMedia::create):
(WebCore::StyleRuleMedia::mediaQueries):
(StyleRuleRegion):
(WebCore::StyleRuleRegion::create):
(WebCore::StyleRuleRegion::selectorList):
* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
(WebCore):
* css/StyleSheet.h:
(WebCore):
(WebCore::StyleSheet::ownerRule):
(WebCore::StyleSheet::parentStyleSheet):
(StyleSheet):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
(WebCore):
(WebCore::StyleRuleKeyframes::~StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::parserAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperRemoveKeyframe):
(WebCore::StyleRuleKeyframes::findKeyframeIndex):
(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::setName):
(WebCore::WebKitCSSKeyframesRule::insertRule):
(WebCore::WebKitCSSKeyframesRule::deleteRule):
(WebCore::WebKitCSSKeyframesRule::findRule):
(WebCore::WebKitCSSKeyframesRule::cssText):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):
* css/WebKitCSSKeyframesRule.h:
(WebCore):
(StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::create):
(WebCore::StyleRuleKeyframes::keyframes):
(WebCore::StyleRuleKeyframes::name):
(WebCore::StyleRuleKeyframes::setName):
(WebCore::WebKitCSSKeyframesRule::create):
(WebCore::WebKitCSSKeyframesRule::name):
(WebKitCSSKeyframesRule):
* css/WebKitCSSRegionRule.cpp:
(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::~WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::cssText):
(WebCore::WebKitCSSRegionRule::length):
(WebCore):
(WebCore::WebKitCSSRegionRule::item):
(WebCore::WebKitCSSRegionRule::cssRules):
* css/WebKitCSSRegionRule.h:
(WebCore):
(WebCore::WebKitCSSRegionRule::create):
(WebKitCSSRegionRule):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ensureSourceData):
* inspector/InspectorStyleSheet.h:
(WebCore):
* svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::SVGFontFaceElement):
(WebCore::SVGFontFaceElement::parseAttribute):
(WebCore::SVGFontFaceElement::fontFamily):
(WebCore::SVGFontFaceElement::rebuildFontFace):
(WebCore::SVGFontFaceElement::insertedIntoDocument):
(WebCore::SVGFontFaceElement::removedFromDocument):
* svg/SVGFontFaceElement.h:
(WebCore):
(WebCore::SVGFontFaceElement::fontFaceRule):
(SVGFontFaceElement):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 19:48:03 +0000 (19:48 +0000)]
Rebaseline svg/W3C-SVG-1.1/animate-elem-XX-t.svg
https://bugs.webkit.org/show_bug.cgi?id=79568
Unreviewed test expectations update.
Patch by Philip Rogers <pdr@google.com> on 2012-04-02
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jesus@webkit.org [Mon, 2 Apr 2012 19:46:43 +0000 (19:46 +0000)]
[Qt][WK2] ResourceError::isCancellation() is always returning false
https://bugs.webkit.org/show_bug.cgi?id=82917
Reviewed by Noam Rosenthal.
We were missing the encoding of a boolean in ArgumentCoder<ResourceError>
and, therefore, we were getting always "false" for ResourceError::isCancellation()
for errors being sent through the IPC.
* Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scherkus@chromium.org [Mon, 2 Apr 2012 19:41:52 +0000 (19:41 +0000)]
2012-04-02 Andrew Scherkus <scherkus@chromium.org>
Add a layout test for videos that change resolutions during decoding.
https://bugs.webkit.org/show_bug.cgi?id=82686
Chromium has been bitten by these types of clips in the past hence the introduction
of a layout test. Test clips is only in VP8 as not all codecs support resolution
changes.
Reviewed by Eric Carlson.
* platform/chromium/media/resources/frame_size_change.webm: Added.
* platform/chromium/media/video-frame-size-change-expected.txt: Added.
* platform/chromium/media/video-frame-size-change.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 19:37:59 +0000 (19:37 +0000)]
Scroll position is lost after hide/show element
https://bugs.webkit.org/show_bug.cgi?id=72852
Source/WebCore:
Maintain the scroll position of an overflowing element in the ElementRareData when the scrollable
RenderLayer is destroyed, which can be used to restore the scroll position if the same element gets
back a RenderLayer.
WebKit behaviour will be the same as Firefox and IE. It differs from Opera as it does not reset the
scroll position when an element is moved to another location in the same document. However Opera resets
the scroll position for elements moved to another document, which matches other browsers.
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-04-02
Reviewed by Julien Chaffraix.
Test: fast/overflow/scroll-div-hide-show.html
* dom/Element.cpp:
(WebCore::Element::removedFromDocument):
Reset the saved scroll offset if the node is moved to another location in the same document or another one.
(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):
* dom/Element.h:
Add helper functions to access the layer scroll offset from the element's rare data.
* dom/ElementRareData.h:
(ElementRareData):
Add the scroll offset book-keeping.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
Restore the scroll offset.
(WebCore::RenderLayer::~RenderLayer):
Store the scroll offset if document is not being destroyed.
LayoutTests:
Patch by Rakesh KN <rakesh.kn@motorola.com> on 2012-04-02
Reviewed by Julien Chaffraix.
* fast/overflow/scroll-div-hide-show-expected.txt: Added.
* fast/overflow/scroll-div-hide-show.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 19:33:52 +0000 (19:33 +0000)]
[Chromium] Update expectations for SVG Lion results
https://bugs.webkit.org/show_bug.cgi?id=82926
Unreviewed Chromium SVG Lion expectations update.
* platform/chromium-mac-leopard/svg/css/getComputedStyle-basic-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Added.
* platform/chromium-mac-snowleopard/svg/batik/text/longTextOnPath-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/custom/massive-coordinates-expected.png: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.png: Added.
* platform/chromium-mac/svg/batik/filters/feTile-expected.png:
* platform/chromium-mac/svg/batik/filters/filterRegions-expected.png:
* platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
* platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
* platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
* platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
* platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
* platform/chromium-mac/svg/batik/text/longTextOnPath-expected.png:
* platform/chromium-mac/svg/batik/text/longTextOnPath-expected.txt:
* platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac/svg/batik/text/textEffect-expected.png:
* platform/chromium-mac/svg/batik/text/textEffect2-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
* platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac/svg/batik/text/textLayout-expected.png:
* platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
* platform/chromium-mac/svg/batik/text/textLength-expected.png:
* platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
* platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/batik/text/textPosition-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/svg/batik/text/textPosition2-expected.png:
* platform/chromium-mac/svg/batik/text/textProperties-expected.png:
* platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac/svg/batik/text/textStyles-expected.png:
* platform/chromium-mac/svg/batik/text/verticalText-expected.png:
* platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
* platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt: Added.
* platform/chromium-mac/svg/custom/massive-coordinates-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href1-attr-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-href2-attr-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGUseElement-svgdom-href2-prop-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Mon, 2 Apr 2012 19:06:04 +0000 (19:06 +0000)]
Skipping inspector/styles/override-screen-size.html on Mac.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 18:53:02 +0000 (18:53 +0000)]
Updating test expectations
https://bugs.webkit.org/show_bug.cgi?id=79568
Unreviewed test expectations update.
Patch by Philip Rogers <pdr@google.com> on 2012-04-02
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Mon, 2 Apr 2012 18:47:00 +0000 (18:47 +0000)]
Rename CSSPropertyLonghand files to StylePropertyShorthand.
https://bugs.webkit.org/show_bug.cgi?id=82905
Reviewed by Antti Koivisto.
r112880 renamed CSSPropertyLonghand class to StylePropertyShorthand, so the
files need to reflect this new name now.
No new tests : Just a renaming, No behaviour change intended.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSAllInOne.cpp:
* css/CSSComputedStyleDeclaration.cpp:
* css/CSSParser.cpp:
* css/CSSProperty.cpp:
* css/StylePropertySet.cpp:
* css/StylePropertyShorthand.cpp: Renamed from Source/WebCore/css/CSSPropertyLonghand.cpp.
(WebCore):
(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::webkitWrapShorthand):
(WebCore::shorthandForProperty):
* css/StylePropertyShorthand.h: Renamed from Source/WebCore/css/CSSPropertyLonghand.h.
(WebCore):
(StylePropertyShorthand):
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties):
(WebCore::StylePropertyShorthand::propertiesForInitialization):
(WebCore::StylePropertyShorthand::length):
* page/animation/AnimationBase.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 2 Apr 2012 18:23:19 +0000 (18:23 +0000)]
<rdar://problem/
11020155> and https://bugs.webkit.org/show_bug.cgi?id=82910
REGRESSION (98963 and 109091): Crash when creating a WebArchive of a page with @page style rules
Reviewed by Antti Koivisto.
Source/WebCore:
Test: webarchive/css-page-rule-crash.html
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addSubresourceStyleURLs): Page rules do not (currently) have subresource urls to get,
and are not CSSStyleRules.
LayoutTests:
* webarchive/css-page-rule-crash-expected.webarchive: Added.
* webarchive/css-page-rule-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 18:21:27 +0000 (18:21 +0000)]
Expectations update for svg/css/stars-with-shadow.html
https://bugs.webkit.org/show_bug.cgi?id=82916
Unreviewed expectations change.
This rationalizes expectations for several platforms.
* platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.txt: Removed.
* platform/chromium-mac/svg/css/stars-with-shadow-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
* platform/efl/svg/css/stars-with-shadow-expected.txt: Removed.
* platform/gtk/svg/css/stars-with-shadow-expected.txt: Added.
* svg/css/stars-with-shadow-expected.txt: Replaced.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 18:15:33 +0000 (18:15 +0000)]
Unreviewed, rolling out r112851.
http://trac.webkit.org/changeset/112851
https://bugs.webkit.org/show_bug.cgi?id=82915
Broke 3 Mac accessibility tests (Requested by enrica on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02
Source/WebCore:
* accessibility/AXObjectCache.cpp:
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::handleScrolledToAnchor):
(WebCore):
LayoutTests:
* accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
* accessibility/anchor-link-selection-and-focus.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Mon, 2 Apr 2012 18:13:37 +0000 (18:13 +0000)]
WebKit should throttle memory pressure notifications in proportion to handler time
https://bugs.webkit.org/show_bug.cgi?id=82674
Reviewed by Geoffrey Garen.
Changed the MemoryPressureHandler hold off timer to start timing after
respondToMemoryPressure runs. The delay time is now 20 times longer than the
time it took for respondToMemoryPressure to run with a minimum of 5 seconds.
This throttles the response to low memory events in the extreme case where
we are spending most of our time paging / swapping.
This is a Mac only change.
No additional tests. This passes existing test and was verified using
manual tests on a small memory system with many websites open.
* platform/mac/MemoryPressureHandlerMac.mm:
(WebCore):
(WebCore::MemoryPressureHandler::holdOff):
(WebCore::MemoryPressureHandler::respondToMemoryPressure):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 18:06:58 +0000 (18:06 +0000)]
Unreviewed, rolling out r112163.
http://trac.webkit.org/changeset/112163
https://bugs.webkit.org/show_bug.cgi?id=82914
Possible OOM issues (Requested by aklein on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::installDOMWindow):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
* bindings/v8/V8Proxy.h:
(WebCore::toV8):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore::v8HTMLImageElementConstructorCallback):
* bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
(WebCore::V8WebKitMutationObserver::constructorCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp:
(WebCore::V8WebSocket::constructorCallback):
* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
(WebCore::V8XMLHttpRequest::constructorCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 17:56:58 +0000 (17:56 +0000)]
Unreviewed, rolling out r112318.
http://trac.webkit.org/changeset/112318
https://bugs.webkit.org/show_bug.cgi?id=82912
Possible OOM issues (Requested by aklein on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):
(GetDomMapFunction):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::wrapSlow):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::wrapSlow):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::wrapSlow):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::wrapSlow):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::wrapSlow):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::wrapSlow):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::wrapSlow):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::wrapSlow):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::wrapSlow):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
* bindings/v8/V8DOMWrapper.h:
(V8DOMWrapper):
(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 17:52:10 +0000 (17:52 +0000)]
<img style='width: 100%' src='foo.svg'> gets pixellated when stretched
https://bugs.webkit.org/show_bug.cgi?id=81631
Unreviewed Chromium expectations update.
* platform/chromium-linux-x86/tables: Removed.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-linux/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
* platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-leopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-mac/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added.
* platform/chromium-win-vista/tables: Removed.
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.png:
* platform/chromium-win/fast/repaint/block-layout-inline-children-replaced-expected.txt:
* platform/chromium-win/fast/table/quote-text-around-iframe-expected.png: Modified property svn:mime-type.
* platform/chromium-win/fast/table/quote-text-around-iframe-expected.txt:
* platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png: Added.
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/writing-mode/block-level-images-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 2 Apr 2012 17:46:51 +0000 (17:46 +0000)]
Unreviewed, skip failing inspector test on GTK.
* platform/gtk/Skipped: Skip inspector/styles/override-screen-size.html
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 17:32:17 +0000 (17:32 +0000)]
Missing NULL check for vendor string from glGetString()
https://bugs.webkit.org/show_bug.cgi?id=82859
Patch by Srikumar Bonda <srikumar.b@gmail.com> on 2012-04-02
Reviewed by Kentaro Hara.
glGetString() possible to return NULL value.
Refer to http://www.opengl.org/sdk/docs/man/xhtml/glGetString.xml
for more information. The missing null check crashes webkit when
vendor name is not set (null) by glGetString().
No new tests because this is missing NULL check for
for openGL API response.
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::validateAttributes):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Mon, 2 Apr 2012 17:16:01 +0000 (17:16 +0000)]
Suppress HTMLMediaElement's text track code when !webkitVideoTrackEnabled()
https://bugs.webkit.org/show_bug.cgi?id=82906
Reviewed by Eric Carlson.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::scheduleLoad):
(WebCore::HTMLMediaElement::loadTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 2 Apr 2012 17:13:12 +0000 (17:13 +0000)]
Web Inspector: CPU time bar missing on top-level events in timeline panel
https://bugs.webkit.org/show_bug.cgi?id=82909
Reviewed by Pavel Feldman.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.addRecord):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Mon, 2 Apr 2012 17:10:34 +0000 (17:10 +0000)]
Renaming parameters for positioning a track cue
https://bugs.webkit.org/show_bug.cgi?id=78706
Source/WebCore:
Change WebVTT settings identifiers for spec change: D: -> vertical:, L: -> line:,
T: -> position:, S: -> size:, A: -> align:
Reviewed by Sam Weinig.
No new tests, existing tests updated for spec changes.
* html/track/TextTrackCue.cpp:
(WebCore::verticalGrowingLeftKeyword): Drive-by change to improve readability.
(WebCore::TextTrackCue::settingName): New, parse the settings keyword.
(WebCore::TextTrackCue::parseSettings): Update to match the current spec.
* html/track/TextTrackCue.h:
* html/track/WebVTTParser.h:
(WebCore::WebVTTParser::isValidSettingDelimiter): New.
LayoutTests:
Reviewed by Sam Weinig.
* media/track/captions-webvtt/missed-cues.vtt:
* media/track/captions-webvtt/sorted-dispatch.vtt:
* media/track/captions-webvtt/tc005-default-styles.vtt:
* media/track/captions-webvtt/tc014-alignment-bad.vtt:
* media/track/captions-webvtt/tc014-alignment-ltr.vtt:
* media/track/captions-webvtt/tc014-alignment.vtt:
* media/track/captions-webvtt/tc015-positioning-bad.vtt:
* media/track/captions-webvtt/tc015-positioning-ltr.vtt:
* media/track/captions-webvtt/tc015-positioning.vtt:
* media/track/captions-webvtt/tc016-align-positioning-bad.vtt:
* media/track/captions-webvtt/tc016-align-positioning.vtt:
* media/track/captions-webvtt/tc017-line-position-bad.vtt:
* media/track/captions-webvtt/tc017-line-position.vtt:
* media/track/captions-webvtt/tc018-align-text-line-position-bad.vtt:
* media/track/captions-webvtt/tc018-align-text-line-position.vtt:
* media/track/captions-webvtt/tc019-cue-size-bad.vtt:
* media/track/captions-webvtt/tc019-cue-size.vtt:
* media/track/captions-webvtt/tc020-cue-size-align-bad.vtt:
* media/track/captions-webvtt/tc020-cue-size-align.vtt:
* media/track/captions-webvtt/tc021-valign-bad.vtt:
* media/track/captions-webvtt/tc021-valign-ltr.vtt:
* media/track/captions-webvtt/tc021-valign.vtt:
* media/track/captions-webvtt/tc022-entities-wrong.vtt:
* media/track/captions-webvtt/tc022-entities.vtt:
* media/track/captions-webvtt/tc023-markup-bad.vtt:
* media/track/captions-webvtt/tc023-markup.vtt:
* media/track/captions-webvtt/tc024-timestamp-bad.vtt:
* media/track/captions-webvtt/tc024-timestamp.vtt:
* media/track/captions-webvtt/tc025-class-bad.vtt:
* media/track/captions-webvtt/tc025-class.vtt:
* media/track/captions-webvtt/tc026-voice-bad.vtt:
* media/track/captions-webvtt/tc026-voice.vtt:
* media/track/captions-webvtt/tc027-empty-cue.vtt:
* media/track/captions-webvtt/tc028-unsupported-markup.vtt:
Update settings for spec change.
* media/track/captions-webvtt/tc013-settings-bad-separation.vtt:
* media/track/captions-webvtt/tc013-settings.vtt:
* media/track/track-webvtt-tc013-settings-expected.txt:
* media/track/track-webvtt-tc013-settings.html:
Update test and results to skip illegal settings delimiters.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 16:39:14 +0000 (16:39 +0000)]
[Chromium] Unreviewed, CCLayerTreeHost runMultiThread is flaky.
Related bug: https://bugs.webkit.org/show_bug.cgi?id=80811
Disabled CCLayerTreeHostTestAddAnimationWithTimingFunction.runMultiThread.
* tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 16:23:30 +0000 (16:23 +0000)]
[Chromium] Unreviewed, mark http/tests/xmlhttprequest/upload-progress-events.html as crashy on Linux Debug
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 2 Apr 2012 16:22:25 +0000 (16:22 +0000)]
Add setting to disable Java for local files even if it is otherwise enabled
https://bugs.webkit.org/show_bug.cgi?id=82685
Reviewed by Anders Carlsson.
Source/WebCore:
* WebCore.exp.in:
Export setting setter.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::canEmbedJava):
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestPlugin):
* page/Navigator.cpp:
(WebCore::Navigator::javaEnabled):
Check for both isJavaEnabled and isJavaEnabledForLocalFiles.
* page/Settings.cpp:
(WebCore::Settings::setJavaEnabledForLocalFiles):
* page/Settings.h:
(WebCore::Settings::isJavaEnabledForLocalFiles):
Add new setting.
Source/WebKit2:
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetJavaEnabledForLocalFiles):
(WKPreferencesGetJavaEnabledForLocalFiles):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Add pref as SPI and forward to WebCore.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 16:13:16 +0000 (16:13 +0000)]
Some SVG tests are crashing
https://bugs.webkit.org/show_bug.cgi?id=82232
Unreviewed Chromium test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 16:07:53 +0000 (16:07 +0000)]
Web Inspector: Device metrics emulation should turn off when zero width and height are passed in
https://bugs.webkit.org/show_bug.cgi?id=82907
Currently this also requires the fontScaleFactor of 1 to be passed in, too. However, it results in
downsizing the FrameView to (0x0) on navigation with the open Inspector when the emulation is disabled.
Reviewed by Yury Semikhatsky.
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 2 Apr 2012 15:41:26 +0000 (15:41 +0000)]
LayoutTests: [r112391] Pixel test failure of svg/custom/preserve-aspect-ratio-syntax.svg
https://bugs.webkit.org/show_bug.cgi?id=82469
Unreviewed Chromium test_expectations update.
These tests are skipped on Mac and the Mac baselines are hence wrong.
Comments on Bug 82469 indicate that our results are correct.
* platform/chromium-linux/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac-leopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/chromium-win/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 2 Apr 2012 15:35:37 +0000 (15:35 +0000)]
[Qt][WK2] Set up plugin process on Unix
https://bugs.webkit.org/show_bug.cgi?id=72121
Reviewed by Simon Hausmann.
.:
* Source/QtWebKit.pro: Add PluginProcess subproject.
Source/WebKit2:
Setup plugin process for Qt and move the task of querying the plugins
to this process in order to avoid crashes due to plugin bugs or library
incompatibility.
* GNUmakefile.am:
* PluginProcess.pro: Added.
* PluginProcess/gtk/PluginProcessMainGtk.cpp:
(WebKit::PluginProcessMainGtk):
* PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::messageHandler):
(WebKit::initializeGtk):
(WebKit):
(WebKit::PluginProcessMain):
Implement entry point of the plugin process.
Handle -scanPlugin command line switch: produce meta data
of plugin on standard output and terminate. Move Gtk initialization
hack to there.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
Get rid of the Gtk initialization hack. We do not nead it here anymore.
* Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit):
(NetscapePluginModule):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::parseMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit):
(WebKit::NetscapePluginModule::getPluginInfo):
Get plugin meta data via PluginProcessproxy. If a failure
happened we ignore to use the plugin. Remove the concept
of stdout redirection since we can control it when launching
the process.
(WebKit::NetscapePluginModule::determineQuirks):
(WebKit::truncateToSingleLine):
(WebKit::NetscapePluginModule::scanPlugin):
Produce plugin meta data on standard output.
* Shared/ProcessExecutablePath.h: Added.
(WebKit):
* Shared/gtk/ProcessExecutablePathGtk.cpp: Added.
(findWebKitProcess):
(executablePathOfWebProcess):
(executablePathOfPluginProcess):
* Shared/qt/ProcessExecutablePathQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp.
(WebKit):
(WebKit::executablePath):
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
Factored the executable path determination into free functions
to avoid code duplication.
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint):
Added implementation for the override with the scale factor because
it is called from PluginProxy. It does not actually handle the case
when the scale factor is not 1. However it's ok because it can only
happen on Mac in the moment.
* Target.pri:
* UIProcess/Launcher/ProcessLauncher.h:
(ProcessLauncher):
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
Use the new functions to determine the executable path.
* UIProcess/Plugins/PluginProcessProxy.h:
(WebKit):
(RawPluginMetaData):
(PluginProcessProxy):
* UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
Launch plugin process and parse it's output to get the meta data
for the plugin.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Changed according to the removing of the flash hack. Do not try
to decide whether the plugin needs Gtk by it's name but instead
always get back the expected Gtk version (2). Only Gtk plugins
should ask for this anyway.
* qt/PluginMainQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.
(WebKit):
(main):
Tools:
* qmake/mkspecs/features/features.prf: Reenable plugins
and turn on plugin process.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 15:27:29 +0000 (15:27 +0000)]
[Chromium] Unreviewed, update test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 2 Apr 2012 15:17:12 +0000 (15:17 +0000)]
Unreviewed, rolling out r112868, r112879, and r112881.
http://trac.webkit.org/changeset/112868
http://trac.webkit.org/changeset/112879
http://trac.webkit.org/changeset/112881
https://bugs.webkit.org/show_bug.cgi?id=82901
"Build fail on bots." (Requested by kbalazs on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02
.:
* Source/QtWebKit.pro:
Source/WebKit2:
* GNUmakefile.am:
* PluginProcess.pro: Removed.
* PluginProcess/gtk/PluginProcessMainGtk.cpp:
(WebKit::PluginProcessMainGtk):
* PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::PluginProcessMain):
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
* Shared/Plugins/Netscape/NetscapePluginModule.h:
(NetscapePluginModule):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(StdoutDevNullRedirector):
(WebKit):
(WebKit::StdoutDevNullRedirector::StdoutDevNullRedirector):
(WebKit::StdoutDevNullRedirector::~StdoutDevNullRedirector):
(WebKit::initializeGTK):
(WebKit::NetscapePluginModule::applyX11QuirksBeforeLoad):
(WebKit::NetscapePluginModule::setMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::determineQuirks):
* Shared/ProcessExecutablePath.h: Removed.
* Shared/gtk/ProcessExecutablePathGtk.cpp: Removed.
* Shared/qt/ProcessExecutablePathQt.cpp: Removed.
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint):
* Target.pri:
* UIProcess/Launcher/ProcessLauncher.h:
(ProcessLauncher):
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit):
(WebKit::findWebKitProcess):
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Plugins/PluginProcessProxy.h:
(WebKit):
(PluginProcessProxy):
* UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
* qt/PluginMainQt.cpp: Removed.
Tools:
* MiniBrowser/gtk/GNUmakefile.am:
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 2 Apr 2012 15:06:38 +0000 (15:06 +0000)]
Unreviewed, GTK rebaseline after r112882.
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 2 Apr 2012 14:48:44 +0000 (14:48 +0000)]
Unreviewed. Skip inspector/profiler/heap-snapshot-inspect-dom-wrapper.html in
debug mode as it crashes.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 14:45:29 +0000 (14:45 +0000)]
Web Inspector: Implement frontend for device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82891
This change implements the backend-based device metrics emulation capability discovery,
UI (enablement checkbox + input controls), and a persistence setting
for the user-specified device metrics (screen width/height and an auxiliary font scale factor).
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
(WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
(WebInspector.SettingsScreen.prototype._showPaintRectsChanged):
(WebInspector.SettingsScreen.prototype.set _applyDeviceMetricsUserInput):
(WebInspector.SettingsScreen.prototype._setDeviceMetricsOverride):
(WebInspector.SettingsScreen.prototype._setDeviceMetricsOverride.set if):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement.createInput):
(WebInspector.SettingsScreen.prototype._createDeviceMetricsElement):
* inspector/front-end/UserAgentSupport.js: Added.
(WebInspector.UserAgentSupport.DeviceMetrics):
(WebInspector.UserAgentSupport.DeviceMetrics.parseSetting):
(WebInspector.UserAgentSupport.DeviceMetrics.parseUserInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isWidthValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isHeightValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.isFontScaleFactorValid):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.toSetting):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.widthToInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.heightToInput):
(WebInspector.UserAgentSupport.DeviceMetrics.prototype.fontScaleFactorToInput):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/helpScreen.css:
(.help-table > tr > th):
(.help-table > tr > td):
(#resolution-override-section):
* inspector/front-end/inspector.css:
(.hidden):
(.error-input):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 2 Apr 2012 14:29:43 +0000 (14:29 +0000)]
[GTK] Enable shadow-dom in build-webkit.
Rubber-stamped by Gustavo Noronha Silva.
* Scripts/build-webkit: Enable shadow-dom build, this is need to
have a working build currently.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 2 Apr 2012 14:28:22 +0000 (14:28 +0000)]
One more try to fix Qt build after r112868.
It's a misery why I don't have these build failures
locally.
* PluginProcess.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Mon, 2 Apr 2012 14:19:46 +0000 (14:19 +0000)]
Rename CSSPropertyLonghand class to StylePropertyShorthand.
https://bugs.webkit.org/show_bug.cgi?id=82624
Reviewed by Antti Koivisto.
Rename CSSPropertyLonghand to StylePropertyShorthand as what CSSPropertyLonghand
is representing is not a longhand but the list of longhands for a given shorthand.
Also in the same time switch all shorthand declarations to use CSSPropertyID enum
rather than a int so it is clear on what kind of data we are dealing with.
In a following patch I will rename CSSPropertyLonghand file.
No new tests : This is a refactoring, no behaviour change intended
* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForShorthandProperties):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSComputedStyleDeclaration.h:
(WebCore):
(CSSComputedStyleDeclaration):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillShorthand):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseShorthand):
(WebCore::CSSParser::parse4Values):
* css/CSSParser.h:
(WebCore):
(CSSParser):
* css/CSSProperty.cpp:
(WebCore::resolveToPhysicalProperty):
(WebCore::borderDirections):
(WebCore::CSSProperty::resolveDirectionAwareProperty):
* css/CSSPropertyLonghand.cpp:
(WebCore::backgroundShorthand):
(WebCore::backgroundPositionShorthand):
(WebCore::backgroundRepeatShorthand):
(WebCore::borderShorthand):
(WebCore::borderAbridgedShorthand):
(WebCore::borderBottomShorthand):
(WebCore::borderColorShorthand):
(WebCore::borderImageShorthand):
(WebCore::borderLeftShorthand):
(WebCore::borderRadiusShorthand):
(WebCore::borderRightShorthand):
(WebCore::borderSpacingShorthand):
(WebCore::borderStyleShorthand):
(WebCore::borderTopShorthand):
(WebCore::borderWidthShorthand):
(WebCore::listStyleShorthand):
(WebCore::fontShorthand):
(WebCore::marginShorthand):
(WebCore::outlineShorthand):
(WebCore::overflowShorthand):
(WebCore::paddingShorthand):
(WebCore::webkitAnimationShorthand):
(WebCore::webkitBorderAfterShorthand):
(WebCore::webkitBorderBeforeShorthand):
(WebCore::webkitBorderEndShorthand):
(WebCore::webkitBorderStartShorthand):
(WebCore::webkitColumnsShorthand):
(WebCore::webkitColumnRuleShorthand):
(WebCore::webkitFlexFlowShorthand):
(WebCore::webkitMarginCollapseShorthand):
(WebCore::webkitMarqueeShorthand):
(WebCore::webkitMaskShorthand):
(WebCore::webkitMaskPositionShorthand):
(WebCore::webkitMaskRepeatShorthand):
(WebCore::webkitTextEmphasisShorthand):
(WebCore::webkitTextStrokeShorthand):
(WebCore::webkitTransitionShorthand):
(WebCore::webkitTransformOriginShorthand):
(WebCore::webkitWrapShorthand):
(WebCore::shorthandForProperty):
* css/CSSPropertyLonghand.h:
(WebCore::StylePropertyShorthand::StylePropertyShorthand):
(WebCore::StylePropertyShorthand::properties):
(WebCore::StylePropertyShorthand::propertiesForInitialization):
(StylePropertyShorthand):
(WebCore):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::borderSpacingValue):
(WebCore::StylePropertySet::get4Values):
(WebCore::StylePropertySet::getLayeredShorthandValue):
(WebCore::StylePropertySet::getShorthandValue):
(WebCore::StylePropertySet::getCommonValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet::asText):
(WebCore):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
* css/StylePropertySet.h:
(WebCore):
(StylePropertySet):
* editing/EditingStyle.cpp:
(WebCore):
(WebCore::removePropertiesInStyle):
* page/animation/AnimationBase.cpp:
(WebCore::ShorthandPropertyWrapper::ShorthandPropertyWrapper):
(WebCore::addShorthandProperties):
* page/animation/CompositeAnimation.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 2 Apr 2012 14:15:34 +0000 (14:15 +0000)]
Fix Qt build after r112868.
* PluginProcess.pro: Add WTF into includepath.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 14:02:55 +0000 (14:02 +0000)]
[Chromium] Unreviewed, baseline for fast/dom/shadow/form-in-shadow.html
* platform/chromium/fast/dom/shadow/form-in-shadow-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Mon, 2 Apr 2012 13:58:45 +0000 (13:58 +0000)]
Adding Zalan Bujtas to committers list.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 2 Apr 2012 13:55:50 +0000 (13:55 +0000)]
Web Inspector: refactor UI breakpoint listeners.
https://bugs.webkit.org/show_bug.cgi?id=82481
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Breakpoint-added and breakpoint-removed events are currently dispatched on UISourceCode.
That allows us to move handlers that manage SourceFrame's breakpoint decorations from ScriptsPanel to SourceFrame.
SourceFrame's "Loaded" event is removed as it was only used by ScriptsPanel to restore SourceFrame's breakpoints.
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.addConditionalBreakpoint.didEditBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype.onTextViewerContentLoaded):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):
(WebInspector.ScriptsPanel.prototype._uiBreakpointAdded):
(WebInspector.ScriptsPanel.prototype._uiBreakpointRemoved):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.onTextViewerContentLoaded):
LayoutTests:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback.visit):
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
(initialize_ResourceTest):
* inspector/debugger/live-edit.html:
* inspector/debugger/set-breakpoint.html:
* inspector/debugger/source-frame.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 2 Apr 2012 13:44:48 +0000 (13:44 +0000)]
[Qt] Unreviewed gardening.
Web Inspector: Implement support for InspectorClient::overrideDeviceMetrics() in platforms other than Chromium
https://bugs.webkit.org/show_bug.cgi?id=82886
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-02
* platform/qt/Skipped: Skip inspector/styles/override-screen-size.html.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Mon, 2 Apr 2012 13:42:54 +0000 (13:42 +0000)]
Unreviewed, rolling chromium DEPS.
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 13:41:58 +0000 (13:41 +0000)]
Qt: Doc: Fix typo which marks document to be printed in console font.
https://bugs.webkit.org/show_bug.cgi?id=82893
Patch by Casper van Donderen <casper.vandonderen@nokia.com> on 2012-04-02
Reviewed by Simon Hausmann.
The qtwebkit-bridge.qdoc file contained a typo where a \c {} was
missing its closing curly bracket, this marked the rest of the page as
text to be printed using the code/console font.
* docs/qtwebkit-bridge.qdoc:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 13:37:43 +0000 (13:37 +0000)]
[Qt][WK2] Call resize on frameview in WebPage::resizeToContentsIfNeeded only when the size changes.
https://bugs.webkit.org/show_bug.cgi?id=82892
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-02
Reviewed by Kenneth Rohde Christiansen.
Check against the expanded size before calling resize on frameview.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setFixedVisibleContentRect):
(WebKit::WebPage::resizeToContentsIfNeeded):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Mon, 2 Apr 2012 13:36:48 +0000 (13:36 +0000)]
[BlackBerry] Take into account policy checks in ClipboardBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=82651
Reviewed by George Staikos.
Add policy checks in the methods we implemented.
Covered by existing tests.
* platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):
* platform/blackberry/ClipboardBlackBerry.h:
(WebCore::ClipboardBlackBerry::create):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 2 Apr 2012 13:12:41 +0000 (13:12 +0000)]
2012-04-02 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mark inspector/profiler/heap-snapshot-inspect-dom-wrapper.html as
slow.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 2 Apr 2012 13:08:27 +0000 (13:08 +0000)]
[Qt][WK2] Set up plugin process on Unix
https://bugs.webkit.org/show_bug.cgi?id=72121
Reviewed by Simon Hausmann.
.:
* Source/QtWebKit.pro: Add PluginProcess subproject.
Source/WebKit2:
Setup plugin process for Qt and move the task of querying the plugins
to this process in order to avoid crashes due to plugin bugs or library
incompatibility.
* GNUmakefile.am:
* PluginProcess.pro: Added.
* PluginProcess/gtk/PluginProcessMainGtk.cpp:
(WebKit::PluginProcessMainGtk):
* PluginProcess/qt/PluginProcessMainQt.cpp:
(WebKit::messageHandler):
(WebKit::initializeGtk):
(WebKit):
(WebKit::PluginProcessMain):
Implement entry point of the plugin process.
Handle -scanPlugin command line switch: produce meta data
of plugin on standard output and terminate. Move Gtk initialization
hack to there.
* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
Get rid of the Gtk initialization hack. We do not nead it here anymore.
* Shared/Plugins/Netscape/NetscapePluginModule.h:
(WebKit):
(NetscapePluginModule):
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::parseMIMEDescription):
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit):
(WebKit::NetscapePluginModule::getPluginInfo):
Get plugin meta data via PluginProcessproxy. If a failure
happened we ignore to use the plugin. Remove the concept
of stdout redirection since we can control it when launching
the process.
(WebKit::NetscapePluginModule::determineQuirks):
(WebKit::truncateToSingleLine):
(WebKit::NetscapePluginModule::scanPlugin):
Produce plugin meta data on standard output.
* Shared/ProcessExecutablePath.h: Added.
(WebKit):
* Shared/gtk/ProcessExecutablePathGtk.cpp: Added.
(findWebKitProcess):
(executablePathOfWebProcess):
(executablePathOfPluginProcess):
* Shared/qt/ProcessExecutablePathQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/qt/PluginProcessProxyQt.cpp.
(WebKit):
(WebKit::executablePath):
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
Factored the executable path determination into free functions
to avoid code duplication.
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::paint):
Added implementation for the override with the scale factor because
it is called from PluginProxy. It does not actually handle the case
when the scale factor is not 1. However it's ok because it can only
happen on Mac in the moment.
* Target.pri:
* UIProcess/Launcher/ProcessLauncher.h:
(ProcessLauncher):
* UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess):
Use the new functions to determine the executable path.
* UIProcess/Plugins/PluginProcessProxy.h:
(WebKit):
(RawPluginMetaData):
(PluginProcessProxy):
* UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp:
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit):
(WebKit::PluginProcessProxy::scanPlugin):
* UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit):
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::scanPlugin):
Launch plugin process and parse it's output to get the meta data
for the plugin.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Changed according to the removing of the flash hack. Do not try
to decide whether the plugin needs Gtk by it's name but instead
always get back the expected Gtk version (2). Only Gtk plugins
should ask for this anyway.
* qt/PluginMainQt.cpp: Copied from Source/WebKit2/UIProcess/Plugins/gtk/PluginProcessProxyGtk.cpp.
(WebKit):
(main):
Tools:
* qmake/mkspecs/features/features.prf: Reenable plugins
and turn on plugin process.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 2 Apr 2012 13:06:37 +0000 (13:06 +0000)]
[GTK][WK2] Initial FullScreen support
https://bugs.webkit.org/show_bug.cgi?id=75553
Reviewed by Martin Robinson.
Full screen display support in WebKitWebViewBase. Two functions
have been added to handle this. They're called by the
WebFullScreenManagerProxy when full screen display needs to be
managed for an HTML element.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate):
(webkitWebViewBaseCreateWebPage):
(onFullscreenGtkKeyPressEvent):
(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
* UIProcess/WebFullScreenManagerProxy.h:
(WebKit):
* UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:
(WebKit::WebFullScreenManagerProxy::enterFullScreen):
(WebKit::WebFullScreenManagerProxy::exitFullScreen):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 2 Apr 2012 13:01:07 +0000 (13:01 +0000)]
2012-04-02 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Mark newly added test as slow.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 2 Apr 2012 12:49:29 +0000 (12:49 +0000)]
Web Inspector: [refactoring] factor our frame aggregation logic to TimelineFrameController
https://bugs.webkit.org/show_bug.cgi?id=82735
Reviewed by Pavel Feldman.
- factor out frame aggregation logic from TimelineVerticalOverview into TimelineFrameController;
- if we don't have frames, pretend each top-level event is a frame (this preserves behavior of vertical overview);
- factor out time-by-category stats aggregation into class methods of TimelineModel for reuse accross timeline modules;
- do not filter top-level events by type in vertical overview mode;
* WebCore.gypi: Added TimelineFrameController.js
* WebCore.vcproj/WebCore.vcproj: ditto.
* inspector/compile-front-end.py: ditto.
* inspector/front-end/TimelineFrameController.js: Added.
(WebInspector.TimelineFrameController):
(WebInspector.TimelineFrameController.prototype._onRecordAdded):
(WebInspector.TimelineFrameController.prototype._onRecordsCleared):
(WebInspector.TimelineFrameController.prototype._addRecord):
(WebInspector.TimelineFrameController.prototype._flushFrame):
(WebInspector.TimelineFrameController.prototype._createSyntheticFrame): create a "frame" based on a single top-level record.
(WebInspector.TimelineFrameController.prototype.dispose): Remove listeners that we added in constructor.
(WebInspector.TimelineFrame):
* inspector/front-end/TimelineModel.js: Added utilities for aggregating times by categories.
(WebInspector.TimelineModel.aggregateTimeByCategories):
(WebInspector.TimelineModel.aggregateTimeForRecord):
* inspector/front-end/TimelineOverviewPane.js: Use frame information supplied by TimelineFrameController.
(WebInspector.TimelineOverviewPane.prototype._showTimelines):
(WebInspector.TimelineOverviewPane.prototype._setVerticalOverview):
(WebInspector.TimelineOverviewPane.prototype.addFrame):
(WebInspector.TimelineVerticalOverview.prototype.reset): Clear stored frames upon reset()
(WebInspector.TimelineVerticalOverview.prototype.update):
(WebInspector.TimelineVerticalOverview.prototype.addFrame):
(WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
(WebInspector.TimelineVerticalOverview.prototype.getWindowTimes):
* inspector/front-end/TimelinePanel.js: Create/dispose TimelineFrameController when switching to/from vertical overview mode.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats): Factored out statistics aggregation to utilities method in the model.
* inspector/front-end/WebKit.qrc: Added TimelineFrameController.js
* inspector/front-end/inspector.html: ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 12:20:44 +0000 (12:20 +0000)]
Web Inspector: Implement backend for device metrics emulation
https://bugs.webkit.org/show_bug.cgi?id=82827
Source/WebCore:
This change implements the inspector backend for the device metrics override feature,
as well as the respective InspectorClient capability detection.
When a navigation occurs in the override mode, the page auto-zooming ("fit width")
is initiated upon the first layout after the DOMContentLoaded event.
Reviewed by Pavel Feldman.
* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::canOverrideDeviceMetrics):
(WebCore::InspectorClient::overrideDeviceMetrics):
(WebCore::InspectorClient::autoZoomPageToFitWidth):
(InspectorClient):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didLayoutImpl):
* inspector/InspectorPageAgent.cpp:
(PageAgentState):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::restore):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::canOverrideDeviceMetrics):
(WebCore):
(WebCore::InspectorPageAgent::setDeviceMetricsOverride):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::loadEventFired):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::updateViewMetrics):
* inspector/InspectorPageAgent.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::getDouble):
(WebCore):
* inspector/InspectorState.h:
(InspectorState):
(WebCore::InspectorState::setDouble):
LayoutTests:
Follow the Web Inspector Protocol change.
Reviewed by Pavel Feldman.
* inspector/styles/override-screen-size.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 12:16:19 +0000 (12:16 +0000)]
Unreviewed, rolling out r112813 and r112837.
http://trac.webkit.org/changeset/112813
http://trac.webkit.org/changeset/112837
https://bugs.webkit.org/show_bug.cgi?id=82885
It made two tests crash on WK2 (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02
Source/WebCore:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* svg/SVGAllInOne.cpp:
* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::determineAnimatedPropertyType):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElement::applyResultsToTarget):
* svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::constructFromString):
(WebCore::SVGAnimatedAngleAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedAngleAnimator::animValWillChange):
(WebCore::SVGAnimatedAngleAnimator::animValDidChange):
(WebCore::SVGAnimatedAngleAnimator::calculateFromAndByValues):
(WebCore::SVGAnimatedAngleAnimator::calculateAnimatedValue):
* svg/SVGAnimatedAngle.h:
(WebCore):
* svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedEnumeration.cpp: Removed.
* svg/SVGAnimatedEnumeration.h:
(WebCore):
* svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValWillChange):
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::animValDidChange):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValWillChange):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::animValDidChange):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::stopAnimValAnimation):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::~SVGAnimatedType):
(WebCore::SVGAnimatedType::createAngle):
(WebCore::SVGAnimatedType::angle):
(WebCore::SVGAnimatedType::valueAsString):
(WebCore::SVGAnimatedType::setValueAsString):
(WebCore::SVGAnimatedType::setPreserveAspectRatioBaseValue):
(WebCore):
(WebCore::SVGAnimatedType::supportsAnimVal):
* svg/SVGAnimatedType.h:
(SVGAnimatedType):
* svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::findAnimatedPropertiesForAttributeName):
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::startAnimation):
(WebCore::SVGAnimatedTypeAnimator::stopAnimValAnimationForType):
(WebCore::SVGAnimatedTypeAnimator::animValDidChangeForType):
(WebCore::SVGAnimatedTypeAnimator::animValWillChangeForType):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::castAnimatedPropertyToActualType):
(WebCore::SVGAnimatedTypeAnimator::collectAnimatedPropertiesFromInstances):
* svg/SVGAnimatorFactory.h:
(WebCore::SVGAnimatorFactory::create):
* svg/SVGMarkerElement.cpp:
(WebCore):
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(SVGAnimatedListPropertyTearOff):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(SVGAnimatedPropertyTearOff):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
LayoutTests:
* svg/animations/animate-marker-orient-from-angle-to-angle-expected.txt: Removed.
* svg/animations/animate-marker-orient-from-angle-to-angle.html: Removed.
* svg/animations/animate-marker-orient-from-angle-to-auto-expected.txt: Removed.
* svg/animations/animate-marker-orient-from-angle-to-auto.html: Removed.
* svg/animations/animate-marker-orient-to-angle-expected.txt: Removed.
* svg/animations/animate-marker-orient-to-angle.html: Removed.
* svg/animations/script-tests/animate-marker-orient-from-angle-to-angle.js: Removed.
* svg/animations/script-tests/animate-marker-orient-from-angle-to-auto.js: Removed.
* svg/animations/script-tests/animate-marker-orient-to-angle.js: Removed.
* svg/animations/script-tests/svgangle-animation-deg-to-grad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-deg-to-rad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-deg.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-grad-to-rad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-deg.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgangle-animation-rad-to-grad.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgenum-animation-1.js: Removed.
* svg/animations/script-tests/svgenum-animation-10.js: Removed.
* svg/animations/script-tests/svgenum-animation-11.js: Removed.
* svg/animations/script-tests/svgenum-animation-12.js: Removed.
* svg/animations/script-tests/svgenum-animation-13.js: Removed.
* svg/animations/script-tests/svgenum-animation-2.js: Removed.
* svg/animations/script-tests/svgenum-animation-3.js: Removed.
* svg/animations/script-tests/svgenum-animation-4.js: Removed.
* svg/animations/script-tests/svgenum-animation-5.js: Removed.
* svg/animations/script-tests/svgenum-animation-6.js: Removed.
* svg/animations/script-tests/svgenum-animation-7.js: Removed.
* svg/animations/script-tests/svgenum-animation-8.js: Removed.
* svg/animations/script-tests/svgenum-animation-9.js: Removed.
* svg/animations/svgangle-animation-deg-to-grad-expected.txt:
* svg/animations/svgangle-animation-deg-to-rad-expected.txt:
* svg/animations/svgangle-animation-grad-to-deg-expected.txt:
* svg/animations/svgangle-animation-grad-to-rad-expected.txt:
* svg/animations/svgangle-animation-rad-to-deg-expected.txt:
* svg/animations/svgangle-animation-rad-to-grad-expected.txt:
* svg/animations/svgenum-animation-1-expected.txt: Removed.
* svg/animations/svgenum-animation-1.html: Removed.
* svg/animations/svgenum-animation-10-expected.txt: Removed.
* svg/animations/svgenum-animation-10.html: Removed.
* svg/animations/svgenum-animation-11-expected.txt: Removed.
* svg/animations/svgenum-animation-11.html: Removed.
* svg/animations/svgenum-animation-12-expected.txt: Removed.
* svg/animations/svgenum-animation-12.html: Removed.
* svg/animations/svgenum-animation-13-expected.txt: Removed.
* svg/animations/svgenum-animation-13.html: Removed.
* svg/animations/svgenum-animation-2-expected.txt: Removed.
* svg/animations/svgenum-animation-2.html: Removed.
* svg/animations/svgenum-animation-3-expected.txt: Removed.
* svg/animations/svgenum-animation-3.html: Removed.
* svg/animations/svgenum-animation-4-expected.txt: Removed.
* svg/animations/svgenum-animation-4.html: Removed.
* svg/animations/svgenum-animation-5-expected.txt: Removed.
* svg/animations/svgenum-animation-5.html: Removed.
* svg/animations/svgenum-animation-6-expected.txt: Removed.
* svg/animations/svgenum-animation-6.html: Removed.
* svg/animations/svgenum-animation-7-expected.txt: Removed.
* svg/animations/svgenum-animation-7.html: Removed.
* svg/animations/svgenum-animation-8-expected.txt: Removed.
* svg/animations/svgenum-animation-8.html: Removed.
* svg/animations/svgenum-animation-9-expected.txt: Removed.
* svg/animations/svgenum-animation-9.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 2 Apr 2012 12:13:31 +0000 (12:13 +0000)]
Unreviewed, rolling out r112651.
http://trac.webkit.org/changeset/112651
https://bugs.webkit.org/show_bug.cgi?id=82887
It doesn't work with older Qt5 (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02
Source/WebKit/qt:
* declarative/experimental/plugin.cpp:
* declarative/plugin.cpp:
(WebKitQmlPlugin::initializeEngine):
Source/WebKit2:
* UIProcess/API/qt/qquicknetworkreply_p.h:
* UIProcess/API/qt/qquicknetworkrequest_p.h:
* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qwebiconimageprovider_p.h:
* UIProcess/API/qt/qwebnavigationhistory.cpp:
* UIProcess/API/qt/qwebnavigationhistory_p.h:
* UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:
* UIProcess/qt/QtDialogRunner.cpp:
(QtDialogRunner::initForAlert):
(QtDialogRunner::initForConfirm):
(QtDialogRunner::initForPrompt):
(QtDialogRunner::initForAuthentication):
(QtDialogRunner::initForProxyAuthentication):
(QtDialogRunner::initForCertificateVerification):
(QtDialogRunner::initForFilePicker):
(QtDialogRunner::initForDatabaseQuotaDialog):
(QtDialogRunner::createDialog):
* UIProcess/qt/QtFlickProvider.cpp:
* UIProcess/qt/QtFlickProvider.h:
(QtFlickProvider):
* UIProcess/qt/WebPopupMenuProxyQt.cpp:
(WebKit::WebPopupMenuProxyQt::createItem):
(WebKit::WebPopupMenuProxyQt::createContext):
Tools:
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateVisualMockTouchPoints):
* MiniBrowser/qt/main.cpp:
* WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
* qmake/mkspecs/features/unix/default_post.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 2 Apr 2012 12:13:08 +0000 (12:13 +0000)]
[V8] Web Inspector: don't crash when resolving DOM wrapper heap snapshot node to JS object
https://bugs.webkit.org/show_bug.cgi?id=82872
Reviewed by Pavel Feldman.
Source/WebCore:
Don't resolve heap object to a JS object if it is a wrapper boilerplate.
Test: inspector/profiler/heap-snapshot-inspect-dom-wrapper.html
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
(WebCore):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):
LayoutTests:
* inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt: Added.
* inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: Added.
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Mon, 2 Apr 2012 12:06:01 +0000 (12:06 +0000)]
Write a test to confirm form elements work in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=82431
Reviewed by Dimitri Glazkov.
The Shadow DOM spec says form should work even if it is in a shadow tree.
This test confirms it.
* fast/dom/shadow/form-in-shadow.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 2 Apr 2012 11:57:12 +0000 (11:57 +0000)]
Unreviewed, rolling out r112659.
http://trac.webkit.org/changeset/112659
https://bugs.webkit.org/show_bug.cgi?id=82884
Undo the rollout of 112489 since this was not the cause of
failures (Requested by apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02
* css/CSSSegmentedFontFace.cpp:
(WebCore::appendFontDataWithInvalidUnicodeRangeIfLoading):
(WebCore):
(WebCore::CSSSegmentedFontFace::getFontData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 2 Apr 2012 11:50:00 +0000 (11:50 +0000)]
Add mechanism for mapping from StyleRules back to fully constructed CSSStyleRules
https://bugs.webkit.org/show_bug.cgi?id=82847
Reviewed by Andreas Kling.
Inspector is using CSSStyleSelector to calculate the CSS rules matched by a given element and
expects to be able to walk the parent chain. After 82728 the stylesheet object tree won't have
parent pointers and we are going to need another mechanism to support this.
The new code does not actually run without 82728.
* css/CSSStyleSelector.cpp:
(WebCore):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::loadFullDefaultStyle):
(WebCore::ensureDefaultStyleSheetsForElement):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
Add ensureFullCSSOMWrapperForStyleRule() method which traverses through all style
sheets that apply to the document and constucts wrappers for the rules. These wrappers
are cached to a map. The map can then be used for StyleRule -> CSSStyleRule lookups.
This uses quite a bit of memory so should not be used for any normal engine functions.
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::buildArrayForRuleList):
Use the new mechanism to get fully functional wrappers for rule objects without parent pointer.
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 2 Apr 2012 11:45:36 +0000 (11:45 +0000)]
[Qt] Unreviewed gardening, skip a new failing test because
ENABLE(SHADOW_DOM) is disabled.
Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-04-02
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 11:22:48 +0000 (11:22 +0000)]
[Chromium] Add baselines for fast/text/international/text-spliced-font.html
* platform/chromium-linux/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-linux/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-mac/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-win/fast/text/international/text-spliced-font-expected.png: Added.
* platform/chromium-win/fast/text/international/text-spliced-font-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 2 Apr 2012 11:16:06 +0000 (11:16 +0000)]
Unreviewed. Fix make distcheck issues.
Source/JavaScriptCore:
* GNUmakefile.list.am: Add missing file.
Source/WebCore:
* GNUmakefile.list.am: Remove duplicated files and add missing
header.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 2 Apr 2012 11:15:39 +0000 (11:15 +0000)]
Unreviewed, skipping one more crashing svg test in GTK because of
bug 82876.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 2 Apr 2012 11:06:42 +0000 (11:06 +0000)]
[GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=82877
Reviewed by Philippe Normand.
* Scripts/run-gtk-tests:
(TestRunner.run_tests): Use replace instead of lstrip to remove
the programs_path from the full path of unit tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Mon, 2 Apr 2012 10:47:36 +0000 (10:47 +0000)]
Add rounding to Plugin creation in SubframeLoader
https://bugs.webkit.org/show_bug.cgi?id=82221
Reviewed by Eric Seidel.
Adding rounding to the LayoutSize used to construct Plugins in SubframeLoader. Plugins, which
are widgets, are always placed on integer boundaries, which means their sizes can be rounded
without considering their location. See https://trac.webkit.org/wiki/LayoutUnit for details.
No new tests. No change in behavior.
* loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
(WebCore::SubframeLoader::createJavaAppletWidget):
(WebCore::SubframeLoader::loadPlugin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Mon, 2 Apr 2012 10:28:26 +0000 (10:28 +0000)]
in page anchor and keyboard navigation
https://bugs.webkit.org/show_bug.cgi?id=17450
Reviewed by Chris Fleizach.
Source/WebCore:
Ensure that the position of the caret and the focused element
get updated when following an anchor link.
The implementation is moved from platform specific files out to
AXObjectCache.cpp since it should be a cross-platform valid
solution. However, the new code is currently activated for the Mac
and GTK ports only, since the windows and chromium ports provide
their own specific code, and removing it now might break things.
Test: accessibility/anchor-link-selection-and-focus.html
* accessibility/AXObjectCache.cpp:
(WebCore):
(WebCore::AXObjectCache::handleScrolledToAnchor): Cross-platform
implementation of the fix, only activated for Mac and GTK for now.
* accessibility/gtk/AXObjectCacheAtk.cpp: Removed the GTK-specific
implementation of WebCore::AXObjectCache::handleScrolledToAnchor.
* accessibility/mac/AXObjectCacheMac.mm: Removed the Mac-specific
implementation of WebCore::AXObjectCache::handleScrolledToAnchor.
LayoutTests:
Added new test and expectations.
* accessibility/anchor-link-selection-and-focus-expected.txt: Added.
* accessibility/anchor-link-selection-and-focus.html: Added.
* platform/gtk/accessibility/anchor-link-selection-and-focus-expected.txt: Added.
* platform/chromium/test_expectations.txt: Skipped test for chromium.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 2 Apr 2012 10:20:28 +0000 (10:20 +0000)]
Unreviewed, skipping 2 crashing svg tests in GTK.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Mon, 2 Apr 2012 10:20:25 +0000 (10:20 +0000)]
[chromium] Disable ENABLE_INPUT_TYPE_COLOR for aura and android
https://bugs.webkit.org/show_bug.cgi?id=82863
Reviewed by Kent Tamura.
* features.gypi:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 2 Apr 2012 10:12:45 +0000 (10:12 +0000)]
[Chromium] Unreviewed, add baselines for fast/forms/date/date-appearance.html
* platform/chromium-linux/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-linux/fast/forms/date/date-appearance-expected.txt: Added.
* platform/chromium-mac/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-mac/fast/forms/date/date-appearance-expected.txt: Added.
* platform/chromium-win/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-win/fast/forms/date/date-appearance-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 2 Apr 2012 10:02:47 +0000 (10:02 +0000)]
[Chromium] Move a number of virtual functions from WebKitPlatformSupport.h into Platform.h
https://bugs.webkit.org/show_bug.cgi?id=82865
Reviewed by Kent Tamura.
Source/Platform:
Moving these functions into Platform.h allows them to be called from
Platform (aka WebCore/platform), as discussed in
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::mimeRegistry):
(WebKit::Platform::audioHardwareSampleRate):
(WebKit::Platform::audioHardwareBufferSize):
(WebKit::Platform::createAudioDevice):
(WebKit::Platform::sampleGamepads):
(WebKit::Platform::visitedLinkHash):
(WebKit::Platform::isLinkVisited):
(WebKit::Platform::signedPublicKeyAndChallengeString):
(WebKit::Platform::memoryUsageMB):
(WebKit::Platform::actualMemoryUsageMB):
(WebKit::Platform::lowMemoryUsageMB):
(WebKit::Platform::highMemoryUsageMB):
(WebKit::Platform::highUsageDeltaMB):
(WebKit::Platform::prefetchHostName):
(WebKit::Platform::createSocketStreamHandle):
(WebKit::Platform::userAgent):
(WebKit::Platform::cacheMetadata):
(WebKit::Platform::createThread):
(WebKit::Platform::currentThread):
(WebKit::Platform::decrementStatsCounter):
(WebKit::Platform::incrementStatsCounter):
(WebKit::Platform::loadResource):
(WebKit::Platform::loadAudioResource):
(WebKit::Platform::sandboxEnabled):
(WebKit::Platform::suddenTerminationChanged):
(WebKit::Platform::defaultLocale):
(WebKit::Platform::currentTime):
(WebKit::Platform::monotonicallyIncreasingTime):
(WebKit::Platform::setSharedTimerFiredFunction):
(WebKit::Platform::setSharedTimerFireInterval):
(WebKit::Platform::stopSharedTimer):
(WebKit::Platform::callOnMainThread):
(WebKit::Platform::getTraceCategoryEnabledFlag):
(WebKit::Platform::addTraceEvent):
(WebKit::Platform::histogramCustomCounts):
(WebKit::Platform::histogramEnumeration):
Source/WebKit/chromium:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Mon, 2 Apr 2012 09:54:53 +0000 (09:54 +0000)]
[Shadow DOM] Introduce ComposedShadowTreeWalker as a successor of ReifiedTreeTraversal APIs
https://bugs.webkit.org/show_bug.cgi?id=82009
Reviewed by Dimitri Glazkov.
.:
* Source/autotools/symbols.filter:
Source/WebCore:
ComposedShadowTreeWalker is intended to be a successor of current ReifiedTreeTraversal APIs.
ComposedShadowTreeWalker uses a cursor pattern and takes a starting node in its constructor.
A typical usage is:
for (ComposedShadowTreeWalker walker(node); walker.get(); walker.next()) {
...
}
Follow-up patches will update clients which use current ReifiedTreeTraversal APIs so that they use the Walker.
More tests will come along with these actual use cases in follow-up patches.
After that, I'll get rid of ReifiedTreeTraversal APIs in favor of the Walker.
Note that 'ComposedShadowTree' and 'ReifiedTree' has the same meaning.
Because ReifiedTree is not intuitive name, we are starting to use 'ComposedShadowTree' from now.
Test: fast/dom/shadow/composed-shadow-tree-walker.html
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedShadowTreeWalker.cpp: Added.
(WebCore):
(WebCore::isShadowHost):
(WebCore::shadowTreeFor):
(WebCore::shadowTreeOfParent):
(WebCore::ComposedShadowTreeWalker::ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::fromFirstChild):
(WebCore::ComposedShadowTreeWalker::firstChild):
(WebCore::ComposedShadowTreeWalker::traverseFirstChild):
(WebCore::ComposedShadowTreeWalker::lastChild):
(WebCore::ComposedShadowTreeWalker::traverseLastChild):
(WebCore::ComposedShadowTreeWalker::traverseChild):
(WebCore::ComposedShadowTreeWalker::traverseLightChildren):
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::nextSibling):
(WebCore::ComposedShadowTreeWalker::previousSibling):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
(WebCore::ComposedShadowTreeWalker::traverseSiblingInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToYoungerShadowRoot):
(WebCore::ComposedShadowTreeWalker::escapeFallbackContentElement):
(WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
(WebCore::ComposedShadowTreeWalker::parent):
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):
(WebCore::ComposedShadowTreeWalker::traverseNextSibling):
(WebCore::ComposedShadowTreeWalker::traversePreviousSibling):
(WebCore::ComposedShadowTreeWalker::next):
(WebCore::ComposedShadowTreeWalker::previous):
* dom/ComposedShadowTreeWalker.h: Added.
(WebCore):
(ComposedShadowTreeWalker):
(WebCore::ComposedShadowTreeWalker::get):
(WebCore::ComposedShadowTreeWalker::canCrossUpperBoundary):
(WebCore::ComposedShadowTreeWalker::assertPrecondition):
(WebCore::ComposedShadowTreeWalker::assertPostcondition):
* testing/Internals.cpp:
(WebCore::Internals::nextSiblingByWalker):
(WebCore):
(WebCore::Internals::firstChildByWalker):
(WebCore::Internals::lastChildByWalker):
(WebCore::Internals::nextNodeByWalker):
(WebCore::Internals::previousNodeByWalker):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def:
* win/WebKit2CFLite.def:
LayoutTests:
* fast/dom/shadow/composed-shadow-tree-walker-expected.txt: Added.
* fast/dom/shadow/composed-shadow-tree-walker.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 2 Apr 2012 09:37:42 +0000 (09:37 +0000)]
Unreviewed. Skip flaky unit tests.
* Scripts/run-gtk-tests:
(TestRunner):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 2 Apr 2012 09:29:24 +0000 (09:29 +0000)]
Web Inspector: breakpoints are not shown in sidebar pane after switching pretty-print mode.
https://bugs.webkit.org/show_bug.cgi?id=82768
Reviewed by Yury Semikhatsky.
Source/WebCore:
When UISourceCode is replaced with another in ScriptsPanel, newly added
UISourceCode could already have breakpoints. We should iterate over existing
breakpoints and add them to sidebar pane.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
LayoutTests:
* inspector/debugger/script-formatter-breakpoints-expected.txt:
* inspector/debugger/script-formatter-breakpoints.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 2 Apr 2012 09:18:01 +0000 (09:18 +0000)]
Teach RuleSet about modern memory management
https://bugs.webkit.org/show_bug.cgi?id=82856
Reviewed by Adam Barth.
No change in behavior, thus no tests.
* css/CSSStyleSelector.cpp:
(WebCore::RuleSet::create):
(RuleSet):
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::makeRuleSet):
(WebCore::CSSStyleSelector::appendAuthorStylesheets):
(WebCore::loadFullDefaultStyle):
(WebCore::loadSimpleDefaultStyle):
(WebCore::loadViewSourceStyle):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 2 Apr 2012 09:05:32 +0000 (09:05 +0000)]
Add a calendar picker indicator to date-type input fields
https://bugs.webkit.org/show_bug.cgi?id=80478
Reviewed by Hajime Morita.
Source/WebCore:
Add an indicator to date-type controls. The bahevior change is enclosed
with ENABLE_CALENDAR_PICKER.
- Remove spin buttons from date-type controls.
It's not so helpful if we have a calendar picker. We introduce
TextFieldInputType::shouldHaveSpinButton().
- Add CalendarPickerElement.
This is added into a shadow tree of a date-type control. It uses
RenderDetailsMarker.
We're going to add click handler and so on to CalendarPickerElement.
Test: fast/forms/date/date-appearance.html
* WebCore.gypi: Add CalendarPickerElement.{cpp,h}
* css/html.css:
(input::-webkit-calendar-picker-indicator):
* html/DateInputType.cpp:
(WebCore::DateInputType::createShadowSubtree): Insert CalendarPickerElement.
(WebCore::DateInputType::needsContainer):
Alwyas return true because we have an extra decoration element.
(WebCore::DateInputType::shouldHaveSpinButton):
Always return false to disable spin button.
* html/DateInputType.h:
(DateInputType): Add declarations.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::shouldHaveSpinButton):
(WebCore::TextFieldInputType::createShadowSubtree): Move some code to shouldHaveSpinButton().
* html/TextFieldInputType.h:
(TextFieldInputType): Add a declartion.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::CalendarPickerElement):
(WebCore::CalendarPickerElement::create):
(WebCore::CalendarPickerElement::createRenderer): Creates RenderDetailsMarker.
* html/shadow/CalendarPickerElement.h: Added.
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen): Always show a down arrow if this is in <input>.
* rendering/RenderDetailsMarker.h:
Source/WebKit/chromium:
* features.gypi: Enable CALENDAR_PICKER for non-Android platforms. This
doesn't affect any bahevior because INPUT_TYPE_DATE is disabled.
LayoutTests:
* fast/forms/date/date-appearance.html: Added.
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 2 Apr 2012 08:46:06 +0000 (08:46 +0000)]
Web Inspector: make timeline overview a view
https://bugs.webkit.org/show_bug.cgi?id=82861
Reviewed by Yury Semikhatsky.
- make TimelineOverviewPane a view;
- only update it if it's visible or upon wasShown().
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.wasShown): forced update.
(WebInspector.TimelineOverviewPane.prototype._updateCategoryStrips):
(WebInspector.TimelineOverviewPane.prototype._scheduleRefresh): skip refresh if not showing;
* inspector/front-end/TimelinePanel.js: timelineOverviewPane.show() instead of appendChild();
(WebInspector.TimelinePanel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 2 Apr 2012 08:24:13 +0000 (08:24 +0000)]
Build fix for ENABLE(SVG) && !ENABLE(FILTERS) after r112813.
* svg/SVGAnimatedEnumeration.cpp:
(WebCore::enumerationValueForTargetAttribute):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 2 Apr 2012 08:12:29 +0000 (08:12 +0000)]
webkitpy rebaseline.
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_test_set_with_json_output):
(test_run_test_set_with_json_source):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 2 Apr 2012 07:43:23 +0000 (07:43 +0000)]
Unreviewed, rebaseline after r112825.
The test baseline updated in r112825 is specific to GURL's way of
printing URLs so it belongs to the chromium platform directory.
* http/tests/security/no-popup-from-sandbox-top-expected.txt:
* platform/chromium/http/tests/security/no-popup-from-sandbox-top-expected.txt: Copied from LayoutTests/http/tests/security/no-popup-from-sandbox-top-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 2 Apr 2012 07:31:41 +0000 (07:31 +0000)]
[Chromium] Move another block of headers from WebKit/chromium/public/platform to Platform/chromium/public
https://bugs.webkit.org/show_bug.cgi?id=82862
Rubber-stamped by Eric Seidel.
Source/Platform:
* Platform.gypi:
* chromium/public/WebAudioBus.h: Copied from Source/WebKit/chromium/public/platform/WebAudioBus.h.
* chromium/public/WebAudioDevice.h: Copied from Source/WebKit/chromium/public/platform/WebAudioDevice.h.
* chromium/public/WebGamepad.h: Copied from Source/WebKit/chromium/public/platform/WebGamepad.h.
* chromium/public/WebGamepads.h: Copied from Source/WebKit/chromium/public/platform/WebGamepads.h.
* chromium/public/WebSocketStreamError.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamError.h.
* chromium/public/WebSocketStreamHandle.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamHandle.h.
* chromium/public/WebSocketStreamHandleClient.h: Copied from Source/WebKit/chromium/public/platform/WebSocketStreamHandleClient.h.
Source/WebCore:
This is part of the change discussed in
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html
* WebCore.gypi:
* platform/chromium/support/WebAudioBus.cpp: Copied from Source/WebKit/chromium/src/WebAudioBus.cpp.
Source/WebKit/chromium:
* WebKit.gyp:
* public/platform/WebAudioBus.h: Replaced.
* public/platform/WebAudioDevice.h: Replaced.
* public/platform/WebGamepad.h: Replaced.
* public/platform/WebGamepads.h: Replaced.
* public/platform/WebSocketStreamError.h: Replaced.
* public/platform/WebSocketStreamHandle.h: Replaced.
* public/platform/WebSocketStreamHandleClient.h: Replaced.
* src/WebAudioBus.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 2 Apr 2012 07:00:26 +0000 (07:00 +0000)]
Unreviewed, GTK svg rebaseline after r112806.
* platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.txt:
* platform/gtk/svg/[...]
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 2 Apr 2012 06:54:18 +0000 (06:54 +0000)]
[Chromium] Move thread-related APIs from WebKit into Platform
https://bugs.webkit.org/show_bug.cgi?id=82858
Reviewed by Eric Seidel.
Source/Platform:
* Platform.gypi:
* chromium/public/WebThread.h: Copied from Source/WebKit/chromium/public/platform/WebThread.h.
* chromium/public/WebThreadSafeData.h: Copied from Source/WebKit/chromium/public/platform/WebThreadSafeData.h.
Source/WebCore:
This is part of the change discussed in
https://lists.webkit.org/pipermail/webkit-dev/2012-March/020166.html
* WebCore.gypi:
* platform/chromium/support/WebThreadSafeData.cpp: Copied from Source/WebKit/chromium/src/WebThreadSafeData.cpp.
Source/WebKit/chromium:
* WebKit.gyp:
* public/platform/WebThread.h: Replaced.
* public/platform/WebThreadSafeData.h: Replaced.
* src/WebThreadSafeData.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Mon, 2 Apr 2012 05:21:32 +0000 (05:21 +0000)]
Perf-o-matic build fix after 112829 for Chromium-style tests.
* Websites/webkit-perf.appspot.com/report_process_handler.py:
(ReportProcessHandler.post):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc