platform/upstream/coreclr.git
5 years agoSupport building with VS2019 Preview (#22525)
Tanner Gooding [Tue, 12 Feb 2019 07:19:44 +0000 (23:19 -0800)]
Support building with VS2019 Preview (#22525)

* Support building with VS2019 Preview

* Fixing gen-buildsys-win to only set the architecture for the VS generator

* Refactoring Dev11/147911/fpcw.cpp so that it compiles under VS2019

* Removing the remaining traces of VS2015 build support

5 years agoDelete mda.cs and related dead code (#22535)
Stephen Toub [Tue, 12 Feb 2019 04:23:32 +0000 (23:23 -0500)]
Delete mda.cs and related dead code (#22535)

5 years agoMove ConditionalWeakTable to shared (#22531)
Stephen Toub [Tue, 12 Feb 2019 02:34:21 +0000 (21:34 -0500)]
Move ConditionalWeakTable to shared (#22531)

Leaves DependentHandle as being the runtime PAL

5 years ago Make Module partial to allow additional changed for Mono
Marek Safar [Mon, 11 Feb 2019 23:38:55 +0000 (00:38 +0100)]
 Make Module partial to allow additional changed for Mono

5 years agoAnnotate EventCounter as a relocated type (dotnet/corert#6990)
Michal Strehovský [Mon, 11 Feb 2019 14:22:08 +0000 (15:22 +0100)]
Annotate EventCounter as a relocated type (dotnet/corert#6990)

This moved to CoreLib and needs to be annotated as such for Project N.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoMove Volatile to shared (#22523)
Stephen Toub [Mon, 11 Feb 2019 23:18:25 +0000 (18:18 -0500)]
Move Volatile to shared (#22523)

* Move Volatile to shared

This largely takes corert's implementation, which uses Unsafe.As and volatile fields.

We could investigate also removing the JIT's replacements subsequently.

* Add [Intrinsic] attributes

5 years agoLocally define DLLEXPORT in ee_il_dll.cpp
Russ Keldorph [Mon, 11 Feb 2019 19:42:29 +0000 (11:42 -0800)]
Locally define DLLEXPORT in ee_il_dll.cpp

This prevents a desktop build break due to DLLEXPORT being undefined.  If
you know of a better place to put this, I'm happy to try it.  Otherwise,
this should unblock the desktop build.

5 years agoMove runincontext to src/tools
Russ Keldorph [Sat, 9 Feb 2019 00:20:15 +0000 (16:20 -0800)]
Move runincontext to src/tools

This SDK-style project is causing problems on some machines with VS
installs that can't build it.  For now, move it to a place where it
doesn't build with the tests.

5 years agoMove GCHandle to shared (#22499)
Stephen Toub [Mon, 11 Feb 2019 21:52:51 +0000 (16:52 -0500)]
Move GCHandle to shared (#22499)

* Move GCHandle to shared

* Cache the handle in a local to make it easier for JIT to generate good code

* Rename m_handle to _handle to match the coding conventions

* Delete isPinned argument for GCHandleInternalCompareExchange

* Add fast path to GCHandle.Alloc/Free FCalls

* Disable outdated test

5 years agoUpdate master label to preview4
Russ Keldorph [Mon, 11 Feb 2019 16:06:30 +0000 (08:06 -0800)]
Update master label to preview4

5 years agoprestub: fix ExternalMethodFixupWorker (#22519)
Konstantin Baladurin [Mon, 11 Feb 2019 16:20:50 +0000 (19:20 +0300)]
prestub: fix ExternalMethodFixupWorker (#22519)

Use DispatchToken::CreateDispatchToken to get token to resolve
virtual method in case of non interface MT.

5 years agoMake Nullable partial to allow additional method for in under Mono (#22518)
Marek Safar [Mon, 11 Feb 2019 11:33:29 +0000 (12:33 +0100)]
Make Nullable partial to allow additional method for in under Mono (#22518)

5 years agoCleanup DLL exports (#22500)
Jan Kotas [Sun, 10 Feb 2019 21:57:11 +0000 (13:57 -0800)]
Cleanup DLL exports (#22500)

5 years agoFix casing of interop directories (dotnet/corert#6982)
Jan Kotas [Sun, 10 Feb 2019 02:45:30 +0000 (18:45 -0800)]
Fix casing of interop directories (dotnet/corert#6982)

Match convention introduced by https://github.com/dotnet/corefx/pull/35085

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoMove eventpipe buffer to TLS (#21817)
Sung Yoon Whang [Sun, 10 Feb 2019 02:25:10 +0000 (18:25 -0800)]
Move eventpipe buffer to TLS (#21817)

* start ripping out eventpipe buffer to tls

* can now emit events from gc threads

* cleanup

* more cleanup

* more cleanup

* tested on linux

* Addressing PR comments

* Move things around a bit to build in Linux

* change eventpipe buffer deallocation code

* more cleanup

* this while loop doesnt do anything now

* Fix build

* fixing build

* More cleanup

* more pr comments

* Fix unix build

* more pr comments

* trying to add a message to assertion that seems to be causing CIs to fail

* more pr feedback

* handle non-2-byte aligned string payloads inside payload buffers

* some more cleanup

* Fix off by one error in null index calculation

* Make Get/SetThreadEventBufferList a static member of ThreadEventBufferList

* make only the methods public in ThreadEventBufferList

* Addressing noah's comments

* fix comment and last off by 1 error

5 years agoset up CoreLib to include EventCounter in build project (#22501)
Sung Yoon Whang [Sun, 10 Feb 2019 02:23:33 +0000 (18:23 -0800)]
set up CoreLib to include EventCounter in build project (#22501)

5 years agoAdd reporting exception from ResolveEHClause (#17947)
Jan Vorlicek [Sat, 9 Feb 2019 15:07:14 +0000 (16:07 +0100)]
Add reporting exception from ResolveEHClause (#17947)

* Add reporting exception from ResolveEHClause

When an exception, like EEFileLoadException happens in the
ResolveEHClause, it was not caught by the runtime and so it caused exit
with `terminating with uncaught exception of type EEFileLoadException*`
message without any additional details.

This change adds catching the exception, reporting its details and call
stack and then failing fast.

* Change StackSString to SString

* Ensure the catch clause types are loaded before EH

In crossgen-ed images, ensure the types used in catch clauses are loaded
before the function containing these clauses is executed. That ensures
that a failure to load the EH clause type will occur at that time
instead of during the EH stack walking that searches for the catch
handler.

* Fix EH clause class module check

* Remove the EH clause class module check

It turns out that even if the class was from the current module, it may
depend on types from other modules, so we still need to add a fixup for
it.

5 years agomove EventCounter to shared CoreLib (dotnet/corefx#35183)
Sung Yoon Whang [Sat, 9 Feb 2019 03:58:24 +0000 (19:58 -0800)]
move EventCounter to shared CoreLib (dotnet/corefx#35183)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoMove Array's SZGenericArrayEnumerator to shared partition (#22480)
Marek Safar [Sat, 9 Feb 2019 04:11:21 +0000 (05:11 +0100)]
Move Array's SZGenericArrayEnumerator to shared partition (#22480)

* Move Array's SZGenericArrayEnumerator to shared partition

* Remove legacy comment

* Move all array enumerators to a new file

5 years agoDelete EnvironmentAugments (#22485)
Jan Kotas [Sat, 9 Feb 2019 04:10:38 +0000 (20:10 -0800)]
Delete EnvironmentAugments (#22485)

5 years agoSet visibility option to hidden (#21924)
Adeel Mujahid [Sat, 9 Feb 2019 01:24:59 +0000 (03:24 +0200)]
Set visibility option to hidden (#21924)

5 years agoBitOps.TrailingZeroCount has inconsistent software fallback (#22333)
Grant [Fri, 8 Feb 2019 23:46:14 +0000 (15:46 -0800)]
BitOps.TrailingZeroCount has inconsistent software fallback (#22333)

Fix #22326

5 years ago[Official Build] Remove FreeBSD builds (#22451)
Jarret Shook [Fri, 8 Feb 2019 20:04:51 +0000 (12:04 -0800)]
[Official Build] Remove FreeBSD builds (#22451)

Currently all the FreeBSD machines are offline or in an unclean state
which blocks official builds from finishing.

5 years agoRevert "Revert "Re-point Jenkins to new Ubuntu ARM64 queue""
Russ Keldorph [Fri, 8 Feb 2019 19:03:42 +0000 (11:03 -0800)]
Revert "Revert "Re-point Jenkins to new Ubuntu ARM64 queue""

This reverts commit d617f96303c4b65b7b77ff5fa0d7aee38ebc19f8.

5 years agoMove GCSettings to shared (#22483)
Stephen Toub [Fri, 8 Feb 2019 16:57:48 +0000 (11:57 -0500)]
Move GCSettings to shared (#22483)

Mainly just type definitions and error handling that gets shared.

5 years agoPass official build id to build (#22468)
Sven Boemer [Fri, 8 Feb 2019 16:34:54 +0000 (08:34 -0800)]
Pass official build id to build (#22468)

This ensures that coreclr gets a version number based on the build id.

5 years agoUpdate CoreRT with shared array implementation
Jan Kotas [Thu, 7 Feb 2019 23:20:46 +0000 (15:20 -0800)]
Update CoreRT with shared array implementation

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoUpdate BuildTools, CoreFx, CoreSetup to preview1-03706-01, preview.19106.8, preview...
dotnet-maestro-bot [Fri, 8 Feb 2019 16:12:20 +0000 (08:12 -0800)]
Update BuildTools, CoreFx, CoreSetup to preview1-03706-01, preview.19106.8, preview-27406-8, respectively (master) (#22455)

* Update BuildTools, CoreFx, CoreSetup to preview1-03706-01, preview.19106.8, preview-27406-8, respectively

* Disabling some outdated System.ObjectModel CoreFX tests

* Undo BuildTools update

5 years agoJIT: Suppress emitting same-reg zero extending move (#22454)
Andy Ayers [Fri, 8 Feb 2019 16:10:57 +0000 (08:10 -0800)]
JIT: Suppress emitting same-reg zero extending move (#22454)

Add a peephole optimization to suppress emitting zero extending moves
if the previous instruction has already done a suitable zero extension.

Only implemented for x64 currently.

Closes #21923

5 years agoJIT: fix ifdef guarding an assert (#22460)
Andy Ayers [Fri, 8 Feb 2019 16:09:57 +0000 (08:09 -0800)]
JIT: fix ifdef guarding an assert (#22460)

We use `_TARGET_AMD64_`, not `_TARGET_X64_`.

5 years agoForce results of rejected multi-reg-returning tail-call candidates to temp. (#22364)
Eugene Rozenfeld [Fri, 8 Feb 2019 08:14:35 +0000 (00:14 -0800)]
Force results of rejected multi-reg-returning tail-call candidates to temp. (#22364)

* Force results of rejected multi-reg-returning tail-call candidates to temp.

Issue #20269 ran into an assert when trying to merge returns, one of which
is a call to a multi-reg-returning method. The repro in the bug is a pmi
of `System.Reflection.Metadata`. I added a simple repro test case.

Results of calls to multi-reg-returning methods are expected to
be saved to temps. Normally it's ensured by `impFixupCallStructReturn`;
however, it doesn't do that for tail-call candidates.

This change forces results of calls to multi-reg-returning methods
to temps if the tail call is rejected late in morph.

Fixes #20269.

5 years agoFinish removing Environment from corefx
Stephen Toub [Wed, 6 Feb 2019 04:13:26 +0000 (23:13 -0500)]
Finish removing Environment from corefx

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoFix the desktop warning (#22481)
Sergey Andreenko [Fri, 8 Feb 2019 06:01:50 +0000 (22:01 -0800)]
Fix the desktop warning (#22481)

5 years agoMove DateTime for Unix to shared partition (#22383)
Marek Safar [Fri, 8 Feb 2019 03:45:44 +0000 (04:45 +0100)]
Move DateTime for Unix to shared partition (#22383)

* Move DateTime for Unix to shared partition

* Keep CoreCLR specific implementation

5 years agoDisable more baseservices/threading/interlocked tests on Ubuntu.Arm64 (#22471)
Egor Chesakov [Fri, 8 Feb 2019 02:40:34 +0000 (18:40 -0800)]
Disable more baseservices/threading/interlocked tests on Ubuntu.Arm64 (#22471)

In the last two weeks the following tests have failed:

* baseservices/threading/interlocked/exchange/ExchangeTClass - 5 times
* baseservices/threading/interlocked/exchange/ExchangeTString - 13 times
* baseservices/threading/interlocked/exchange/ExchangeTString_1 - 12 times
* baseservices/threading/interlocked/exchange/ExchangeTString_2 - 20 times

In addition to the previously disabled tests (in #22304):

* baseservices/threading/interlocked/compareexchange/CompareExchangeTClass - 9 times
* baseservices/threading/interlocked/compareexchange/CompareExchangeTClass_1 - 32 times

All the failures happened on Ubuntu.1804.Arm64.Open Helix queue in Azure DevOps Pri1 jobs

**Related issue:** #22303

5 years agoFix race condition in g_pfnGetSystemTimeAsFileTime initialization (#22466)
Jan Kotas [Fri, 8 Feb 2019 02:35:15 +0000 (18:35 -0800)]
Fix race condition in g_pfnGetSystemTimeAsFileTime initialization (#22466)

Multiple threads initializing g_pfnGetSystemTimeAsFileTime at the same time can end up with different conclusions. Make the result consistent.

5 years agoAdd config option to disable tier 0 JIT (#22370)
Koundinya Veluri [Fri, 8 Feb 2019 01:51:29 +0000 (17:51 -0800)]
Add config option to disable tier 0 JIT (#22370)

Add config option to disable tier 0 JIT

Fixes https://github.com/dotnet/coreclr/issues/21856
- For methods that don't have pregenerated code, using tier 0 JIT can improve startup perf, and disabling tier 0 JIT can be useful to sacrifice some startup time to avoid issues of running tier 0 code for too long. In some cases, it may also be desirable to avoid tiering up much later.
- A fixed value for the call count indicates that tier 0 call counting is disabled. When disabled, the method starts at tier 1.
- Also modified call counting to start from a predetermined threshold and count down to zero, as it simplifies some things, allows for methods to have different thresholds, and likely is what we would want eventually anyway
- Took a small step towards eliminating knowledge of specific tier levels in code that should not care, though more is to be done there

5 years agoMerge pull request #22023 from BruceForstall/FixGSWithLocalloc
Bruce Forstall [Thu, 7 Feb 2019 23:19:06 +0000 (15:19 -0800)]
Merge pull request #22023 from BruceForstall/FixGSWithLocalloc

Fix ARM64 GS with localloc

5 years agoMore PAL layer cleanup for GNU and add build script support for GCC (#22369)
Sinan Kaya [Thu, 7 Feb 2019 21:39:13 +0000 (16:39 -0500)]
More PAL layer cleanup for GNU and add build script support for GCC (#22369)

* Declare throw only when compiling for c++

Prevent the definition from getting defined multiple times and
map it to throw() only when compiling c++ code.

* Suppress warnings for tests

Suppress:
 -Wno-write-strings
 -Wno-sign-compare
 -Wno-narrowing
 -fpermissive
 -Wno-int-to-pointer-cast

to allow tests to compile

* Add gcc option to build.sh script

Following clangx.y model add -gccx.y command line
arguments with gcc5 and gcc7 being the currnetly supported
options.

* Allow environment variable to be used for TOOLCHAIN

Remove CLANG specific compiler options as well.

* Hide non-GNU compiler options

* Do not include local directory if cross compiling

[  0%] Building CXX object src/pal/src/eventprovider/tracepointprovider/CMakeFiles/coreclrtraceptprovider.dir/__/lttng/traceptprovdotnetruntime.cpp.o
cc1plus: error: include location "/usr/local/include" is unsafe for cross-compilation [-Werror=poison-system-directories]

* Suppress unknown pragma warnings

src/pal/src/exception/seh-unwind.cpp:37:0:
warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas]
    #pragma clang diagnostic pop

Removing these cause compilation error on clang7 and arm as follows:

In file included from /bin/obj/Linux.arm.Debug/src/pal/src/libunwind/include/libunwind.h:9:
/src/pal/src/libunwind/include/libunwind-arm.h:247:9: error: empty struct has size 0 in C, size 1 in C++ [-Werror,-Wextern-c-compat]
typedef struct unw_tdep_save_loc
        ^
/src/pal/src/libunwind/include/libunwind-arm.h:288:9: error: empty struct has size 0 in C, size 1 in C++ [-Werror,-Wextern-c-compat]
typedef struct

* plt not useful for GNU and ARM64/ARM

src/pal/src/arch/arm64/callsignalhandlerwrapper.S: Assembler messages:
src/pal/src/arch/arm64/callsignalhandlerwrapper.S:31: Error: unexpected characters following instruction at operand 1 -- `bl signal_handler_worker@plt'
src/pal/src/arch/arm64/callsignalhandlerwrapper.S:32: Error: unexpected characters following instruction at operand 1 -- `bl signal_handler_worker@plt'

* Remove double const from argv in PAL_Initialize

Seeing compilation error with GNU for C source files as follows:

if (PAL_Initialize(argc, argv) != 0)
                          ^
src/pal/tests/palsuite/common/palsuite.h:21:0,
from src/pal/tests/palsuite/c_runtime/asinhf/test1/test1.c:18:
src/pal/inc/pal.h:374:1: note: expected ‘const char * const*’ but argument is of type ‘char **’

* Suppress format warnings using GNU for libunwind

warning: format ‘%li’ expects argument of type ‘long int’, but argument 3 has type ‘int’ [-Wformat=]
     Debug (4, " aligned frame, offset %li\n", f->cfa_reg_offset);

* Fix -fpermissive warnings for GNU

* Suppress unused variable warning in libunwind

src/pal/src/libunwind/include/libunwind-aarch64.h:201:5: warning: right-hand operand of comma expression has no effect [-Wunused-value]
 #define unw_tdep_getcontext(uc) (({     \
                                 ~~~~~~~~~
   unw_tdep_context_t *unw_ctx = (uc);     \
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   register uint64_t *unw_base asm ("x0") = (uint64_t*) unw_ctx->uc_mcontext.regs;  \
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   __asm__ __volatile__ (      \
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x0, x1, [%[base], #0]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x2, x3, [%[base], #16]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x4, x5, [%[base], #32]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x6, x7, [%[base], #48]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x8, x9, [%[base], #64]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x10, x11, [%[base], #80]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x12, x13, [%[base], #96]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x14, x13, [%[base], #112]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x16, x17, [%[base], #128]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x18, x19, [%[base], #144]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x20, x21, [%[base], #160]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x22, x23, [%[base], #176]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x24, x25, [%[base], #192]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x26, x27, [%[base], #208]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "stp x28, x29, [%[base], #224]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "str x30, [%[base], #240]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      "mov x1, sp\n" \
      ~~~~~~~~~~~~~~~~
      "stp x1, x30, [%[base], #248]\n" \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      : [base] "+r" (unw_base) : : "x1", "memory"); \
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   }), 0)

* Fix warning: ‘memset’ used with length equal to number of elements warning

Fix similar warnings to these by including the element size into total size
calculation.

src/pal/tests/palsuite/miscellaneous/SetEnvironmentVariableW/test1/test.cpp: In function ‘int main(int, char**)’:
src/pal/tests/palsuite/miscellaneous/SetEnvironmentVariableW/test1/test.cpp:89:31: warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
     memset(NewValue,0,BUF_SIZE);

* Define CLR specific compiler option CLR_CMAKE_COMPILER

By the time toolchain.cmake is called, the compiler detection from
cmake is not active. We need an intermediate definition to pass
to compiler detection.

5 years agoFix GCSample bit rot (#22462)
Jan Kotas [Thu, 7 Feb 2019 18:17:45 +0000 (10:17 -0800)]
Fix GCSample bit rot (#22462)

Fixes #22459

5 years agoMerge pull request #22435 from echesakovMSFT/TreatCLRTestExecutionArgumentsAsAnArrayI...
Egor Chesakov [Thu, 7 Feb 2019 17:58:32 +0000 (09:58 -0800)]
Merge pull request #22435 from echesakovMSFT/TreatCLRTestExecutionArgumentsAsAnArrayInBash

Treat CLRTestExecutionArguments as an array in generated Bash scripts

5 years agoFixing Utf8Formatter.Float to support all the same format specifiers as the utf16...
Tanner Gooding [Thu, 7 Feb 2019 17:12:08 +0000 (09:12 -0800)]
Fixing Utf8Formatter.Float to support all the same format specifiers as the utf16 formatter. (#22434)

* Fixing Utf8Formatter.Float to support all the same format specifiers as the utf16 formatter.

* Disabling some outdated CoreFX tests.

* Fixing TryFormatFloatingPoint to special-case format.IsDefault

5 years agoFix delegate creation for default interface methods on structs (#22427)
Michal Strehovský [Thu, 7 Feb 2019 16:48:09 +0000 (17:48 +0100)]
Fix delegate creation for default interface methods on structs (#22427)

We only need to find an unboxing stub if we resolved the interface to a valuetype method. If we resolved to a default interface method implementation, unboxing is not necessary.

5 years agoCleanup LLVM assumption (#22456)
Sinan Kaya [Thu, 7 Feb 2019 09:28:29 +0000 (04:28 -0500)]
Cleanup LLVM assumption (#22456)

We want to support GNU compilation for CoreCLR. Luckily both LLVM
and GNU compilers define __GNUC__ and there are a lot of things
they can share.

5 years agoFix CoreLib to include PasteArguments.Unix.cs correctly (#22453)
Stephen Toub [Thu, 7 Feb 2019 03:37:31 +0000 (22:37 -0500)]
Fix CoreLib to include PasteArguments.Unix.cs correctly (#22453)

5 years agoMove Array to shared partition (#22321)
Marek Safar [Thu, 7 Feb 2019 03:36:45 +0000 (04:36 +0100)]
Move Array to shared partition (#22321)

5 years agoImplement ManifestBasedResourceGroveler::GetNeutralResourcesLanguageAttribute (#22372)
Marek Safar [Thu, 7 Feb 2019 03:34:48 +0000 (04:34 +0100)]
Implement ManifestBasedResourceGroveler::GetNeutralResourcesLanguageAttribute (#22372)

* Implement ManifestBasedResourceGroveler::GetNeutralResourcesLanguageAttribute in shared managed code

* Remove native ::GetNeutralResourcesLanguage

5 years agoFix ARM64 GS with localloc
Bruce Forstall [Fri, 11 Jan 2019 01:06:49 +0000 (17:06 -0800)]
Fix ARM64 GS with localloc

Currently, all frame types place saved FP/LR at low addresses on the
frame, below the GS cookie. If a function has localloc, the dynamically
allocate and unsafe buffer will be lower than the saved FP/LR and
not the GS cookie won't properly protect the saved FP/LR.

This change introduces new frame types, used only for functions needing
a GS cookie and using localloc, saving FP/LR along with the rest of
the callee-saved registers at the top (highest addresses) of the frame,
above the GS cookie.

5 years agoIndex and Range updates (#22331)
Tarek Mahmoud Sayed [Wed, 6 Feb 2019 23:15:46 +0000 (15:15 -0800)]
Index and Range updates (#22331)

* Index and Range updates

* Address @mikedn  feedback

* Address Feedback

* more feedback

* Use Deconstruct in Range.GetOffsetAndLength

* Rename GetArrayRange to GetSubArray

* Temporary disable the old Corefx Range tests

* Return back the TimeSpan test disabling

* Fix Range jit test

* Exclude the jit test

* revert the changes in the jit Range test

* Address Suggested Feedback

5 years agoMerge pull request #22450 from BruceForstall/DisableFlakySystemNetTests
Bruce Forstall [Wed, 6 Feb 2019 21:51:30 +0000 (13:51 -0800)]
Merge pull request #22450 from BruceForstall/DisableFlakySystemNetTests

Disable flaky Linux/arm64 corefx System.Net.Sockets.Tests

5 years agoThrow an exception when passing strings by-value as out parameters. (#21513)
Jeremy Koritzinsky [Wed, 6 Feb 2019 21:05:28 +0000 (13:05 -0800)]
Throw an exception when passing strings by-value as out parameters. (#21513)

* Throw an exception when passing strings by-value as out parameters.

* Fix encoding

* Don't use override in this PR.

* Clean up Marshal_In

Marshal_In was copied back into existence from Marshal_InOut. Clean it up a bit.

* Remove extraneous whitespace.

* Fix failing test.

* Remove out attribute in COM string tests.

* Add back attribute and check for exception thow in COM tests.

* Add block comment to explain the implementation of Reverse_LPWStr_OutAttr in the NETServer.

* Only throw in a CLR->Native marshalling situation.

* Fix asserts from changed code-paths used in ILWSTRMarshaler.

* Add comment and explicitly load in a null value (instead of leaving it uninitialized).

* Apply suggestions from code review

Co-Authored-By: jkoritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
5 years agoAllow lcl_var structs to be widened to primitive types on unix amd64. (#22437)
Jarret Shook [Wed, 6 Feb 2019 21:00:54 +0000 (13:00 -0800)]
Allow lcl_var structs to be widened to primitive types on unix amd64. (#22437)

* Allow lcl_var structs to be widened to primitive types on unix amd64. The already happens on armarch

* Apply format patch

5 years agoDisable flaky Linux/arm64 corefx System.Net.Sockets.Tests
Bruce Forstall [Wed, 6 Feb 2019 20:33:43 +0000 (12:33 -0800)]
Disable flaky Linux/arm64 corefx System.Net.Sockets.Tests

Tracking: https://github.com/dotnet/coreclr/issues/21576

In general, any System.Net test that exhibits flakiness should be
disabled; we pay more in flakiness than we gain in coverage.

5 years agoTreat $(CLRTestExecutionArguments) as an array in Bash
Egor Chesakov [Tue, 5 Feb 2019 02:33:25 +0000 (18:33 -0800)]
Treat $(CLRTestExecutionArguments) as an array in Bash

5 years agoEnable baseservices/threading/paramthreadstart/ThreadStartString_1
Egor Chesakov [Tue, 5 Feb 2019 19:20:52 +0000 (11:20 -0800)]
Enable baseservices/threading/paramthreadstart/ThreadStartString_1

5 years agoAdd option to run tests in unloadable context (#22332)
Jan Vorlicek [Wed, 6 Feb 2019 11:23:08 +0000 (12:23 +0100)]
Add option to run tests in unloadable context (#22332)

This change adds new "runincontext" option to the tests/runtest.cmd that
allows running tests inside of an unloadable AssemblyLoadContext.
It also adds new property that allows tests to be marked as incompatible
with running this way. All known tests that have such issue are marked
in this PR too.

5 years agoMerge pull request #22433 from BruceForstall/DisableFailingLinuxArm64Test
Bruce Forstall [Wed, 6 Feb 2019 07:27:07 +0000 (23:27 -0800)]
Merge pull request #22433 from BruceForstall/DisableFailingLinuxArm64Test

Disable failing constrainedcall test

5 years agoMerge pull request #22438 from BruceForstall/DisableFailingXarchTests
Bruce Forstall [Wed, 6 Feb 2019 07:26:18 +0000 (23:26 -0800)]
Merge pull request #22438 from BruceForstall/DisableFailingXarchTests

Disable failing BestFitMapping tests

5 years agoMerge pull request #22439 from BruceForstall/DisableWaitOne2
Bruce Forstall [Wed, 6 Feb 2019 07:24:53 +0000 (23:24 -0800)]
Merge pull request #22439 from BruceForstall/DisableWaitOne2

Disable baseservices\threading\mutex\misc\waitone2 test

5 years agoMerge pull request #22444 from BruceForstall/DisableGThread23
Bruce Forstall [Wed, 6 Feb 2019 07:24:01 +0000 (23:24 -0800)]
Merge pull request #22444 from BruceForstall/DisableGThread23

Disable GThread23 test

5 years agoDisable GThread23 test
Bruce Forstall [Wed, 6 Feb 2019 03:00:16 +0000 (19:00 -0800)]
Disable GThread23 test

It fails regularly though randomly in the CI.

Tracking issue: https://github.com/dotnet/coreclr/issues/19339

5 years agoDisable failing constrainedcall test on Linux
Bruce Forstall [Tue, 5 Feb 2019 21:13:05 +0000 (13:13 -0800)]
Disable failing constrainedcall test on Linux

Tracked by https://github.com/dotnet/coreclr/issues/22423

5 years agoDisable baseservices\threading\mutex\misc\waitone2 test
Bruce Forstall [Wed, 6 Feb 2019 01:15:35 +0000 (17:15 -0800)]
Disable baseservices\threading\mutex\misc\waitone2 test

This test has been failing randomly in the CI on all architectures
for a long, long time.

Tracking issue: https://github.com/dotnet/coreclr/issues/6397

5 years agoDisable failing BestFitMapping tests
Bruce Forstall [Wed, 6 Feb 2019 00:55:30 +0000 (16:55 -0800)]
Disable failing BestFitMapping tests

Tests:
```
Interop\PInvoke\BestFitMapping\Char\AFT_PFT\AFT_PFT\AFT_PFT.cmd
Interop\PInvoke\BestFitMapping\Char\Assembly_False_False\Assembly_False_False\Assembly_False_False.cmd
Interop\PInvoke\BestFitMapping\LPStr\AFT_PFT\AFT_PFT\AFT_PFT.cmd
Interop\PInvoke\BestFitMapping\LPStr\Assembly_False_False\Assembly_False_False\Assembly_False_False.cmd
```

Tracked by https://github.com/dotnet/coreclr/issues/22436

5 years agoMerge pull request #22431 from BruceForstall/DisableCorefxFailingTests
Bruce Forstall [Tue, 5 Feb 2019 21:27:21 +0000 (13:27 -0800)]
Merge pull request #22431 from BruceForstall/DisableCorefxFailingTests

Disable failing Linux/arm64 corefx tests

5 years agoMerge pull request #22432 from BruceForstall/DisableWindowsArm64CorefxCronJobs
Bruce Forstall [Tue, 5 Feb 2019 20:46:35 +0000 (12:46 -0800)]
Merge pull request #22432 from BruceForstall/DisableWindowsArm64CorefxCronJobs

Disable Windows arm64 corefx cron jobs

5 years agoFix ProjectN build breaks (dotnet/corert#6954)
Michal Strehovský [Tue, 5 Feb 2019 17:03:52 +0000 (18:03 +0100)]
Fix ProjectN build breaks (dotnet/corert#6954)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoAvoid duplicate tree lookup in GetCollatorFromSortHandle (#22390)
Filip Navara [Tue, 5 Feb 2019 20:29:01 +0000 (21:29 +0100)]
Avoid duplicate tree lookup in GetCollatorFromSortHandle (#22390)

5 years agoMerge pull request #22425 from BruceForstall/UploadMsbuildLogs
Bruce Forstall [Tue, 5 Feb 2019 20:24:19 +0000 (12:24 -0800)]
Merge pull request #22425 from BruceForstall/UploadMsbuildLogs

Configure MSBuild debug path and save any logs

5 years agoDisable Windows arm64 corefx cron jobs
Bruce Forstall [Tue, 5 Feb 2019 20:03:26 +0000 (12:03 -0800)]
Disable Windows arm64 corefx cron jobs

These currently all fail with timeout. They also take way too much time
to run. We have good Linux/arm64 corefx test coverage already.

The issue of these runs being slow is tracked by
https://github.com/dotnet/coreclr/issues/21236.

5 years agoMerge pull request #22415 from adityamandaleeka/pinvoke_eh
Aditya Mandaleeka [Tue, 5 Feb 2019 20:21:50 +0000 (12:21 -0800)]
Merge pull request #22415 from adityamandaleeka/pinvoke_eh

Disable PInvoke inlining within try regions on ARM64

5 years agoUse Jenkins for Linux/arm32 testing (#22429)
Egor Chesakov [Tue, 5 Feb 2019 20:04:40 +0000 (12:04 -0800)]
Use Jenkins for Linux/arm32 testing (#22429)

5 years agoDisable failing Linux/arm64 corefx tests
Bruce Forstall [Tue, 5 Feb 2019 19:52:22 +0000 (11:52 -0800)]
Disable failing Linux/arm64 corefx tests

5 years agoMerge pull request #22421 from BruceForstall/RestrictArm64XunitParallelism
Bruce Forstall [Tue, 5 Feb 2019 19:04:07 +0000 (11:04 -0800)]
Merge pull request #22421 from BruceForstall/RestrictArm64XunitParallelism

Restrict arm64 parallelism to collections

5 years agoMerge pull request #22416 from BruceForstall/FixRunTestOutput
Bruce Forstall [Tue, 5 Feb 2019 19:02:50 +0000 (11:02 -0800)]
Merge pull request #22416 from BruceForstall/FixRunTestOutput

Fix runtest.py output

5 years agoCorrectly error out gracefully on setup-stress-dependencies when libcoredistools...
Jeremy Koritzinsky [Tue, 5 Feb 2019 18:38:57 +0000 (10:38 -0800)]
Correctly error out gracefully on setup-stress-dependencies when libcoredistools isn't available. (#22357)

5 years agoNotify dac when prejitted code is going to be used for a method (#22296)
Andy Ayers [Tue, 5 Feb 2019 08:43:23 +0000 (00:43 -0800)]
Notify dac when prejitted code is going to be used for a method (#22296)

This allows sos bpmd breakpoints to work on prejitted methods.

Closes #22265.

5 years agoAdd draft default interface methods specification (#21564)
Michal Strehovský [Tue, 5 Feb 2019 08:03:49 +0000 (09:03 +0100)]
Add draft default interface methods specification (#21564)

5 years agoFix marshalling UTF8 string struct member from native to managed. (#22408)
Jeremy Koritzinsky [Tue, 5 Feb 2019 06:16:43 +0000 (22:16 -0800)]
Fix marshalling UTF8 string struct member from native to managed. (#22408)

* Fix marshalling UTF8 string struct member from native to managed.

Fixes #22394

* PR Feedback.

5 years agoExtract addressing mode analysis from gtSetEvalOrder (#22387)
Carol Eidt [Tue, 5 Feb 2019 05:49:25 +0000 (21:49 -0800)]
Extract addressing mode analysis from gtSetEvalOrder (#22387)

* Extract addressing mode analysis from gtSetEvalOrder

5 years agoMerge pull request #22417 from BruceForstall/ExtractRuntestTimeout
Bruce Forstall [Tue, 5 Feb 2019 04:37:18 +0000 (20:37 -0800)]
Merge pull request #22417 from BruceForstall/ExtractRuntestTimeout

Extract setting __TestTimeout in runtest.py

5 years agoFix string.strlen (#22397)
Ben Adams [Tue, 5 Feb 2019 04:04:30 +0000 (05:04 +0100)]
Fix string.strlen (#22397)

* Add explanation comment

Fixes #22393

5 years agoMove SynchronizationContext to shared partition (#22389)
Marek Safar [Tue, 5 Feb 2019 03:43:10 +0000 (04:43 +0100)]
Move SynchronizationContext to shared partition (#22389)

* Move SynchronizationContext to shared partition

* Move WaitHelperNative to WaitHandle

5 years agoConfigure MSBuild debug path and save any logs
Bruce Forstall [Tue, 5 Feb 2019 03:00:39 +0000 (19:00 -0800)]
Configure MSBuild debug path and save any logs

We have had many problems in the CI with MSBuild failing, and not
capturing the failure logs.

See https://github.com/dotnet/coreclr/issues/20236.

So, for all msbuild invocations, set MSBUILDDEBUGPATH to a new,
distinguished, subdirectory of the bin\Logs directory, named
"MsbuildDebugLogs". Change the CI to upload any log files found
there.

5 years agoFix runtest.py output
Bruce Forstall [Mon, 4 Feb 2019 23:20:09 +0000 (15:20 -0800)]
Fix runtest.py output

1. Fix extra newline output
2. Remove extra output of failed logs
3. Catch errors with Unicode conversion

5 years agoRestrict arm64 parallelism to collections
Bruce Forstall [Tue, 5 Feb 2019 00:21:43 +0000 (16:21 -0800)]
Restrict arm64 parallelism to collections

Attempt to reduce test timeout failures by restricting test parallelism.

Attempts to address https://github.com/dotnet/coreclr/issues/22419

5 years agoHandle SPC in GetLoadContext
Steve MacLean [Mon, 4 Feb 2019 18:36:52 +0000 (13:36 -0500)]
Handle SPC in GetLoadContext

GetBindingContext() returns NULL for System.Private.CoreLib.  Add support
for this special case.

5 years agoExtract setting __TestTimeout
Bruce Forstall [Mon, 4 Feb 2019 23:41:29 +0000 (15:41 -0800)]
Extract setting __TestTimeout

Avoid setting or reporting setting it twice

5 years agoRe-enable tests blocked by 21964.
Aditya Mandaleeka [Mon, 4 Feb 2019 23:21:05 +0000 (15:21 -0800)]
Re-enable tests blocked by 21964.

5 years agoDisable PInvoke inlining within try regions on ARM64.
Aditya Mandaleeka [Mon, 4 Feb 2019 23:12:33 +0000 (15:12 -0800)]
Disable PInvoke inlining within try regions on ARM64.

5 years agoMerge pull request #22411 from BruceForstall/AlwaysArchiveLogs
Bruce Forstall [Mon, 4 Feb 2019 22:38:12 +0000 (14:38 -0800)]
Merge pull request #22411 from BruceForstall/AlwaysArchiveLogs

Always archive build logs

5 years agoAlways archive build logs
Bruce Forstall [Mon, 4 Feb 2019 21:30:12 +0000 (13:30 -0800)]
Always archive build logs

Even if the build fails. Add archiving in more cases where it was missing.

5 years agoDisable JIT/SIMD/Vector3Interop_ro on x64 Unix platforms
Egor Chesakov [Mon, 4 Feb 2019 17:54:47 +0000 (09:54 -0800)]
Disable JIT/SIMD/Vector3Interop_ro on x64 Unix platforms

Related issue: https://github.com/dotnet/coreclr/issues/22401

5 years agoDisable JIT/Regression/CLR-x86-JIT/v2.1/b152292 on all Unix platforms
Egor Chesakov [Mon, 4 Feb 2019 17:45:38 +0000 (09:45 -0800)]
Disable JIT/Regression/CLR-x86-JIT/v2.1/b152292 on all Unix platforms

Related issue: https://github.com/dotnet/coreclr/issues/20358

5 years agoMore compact implementation of Marshal.GenerateProgIdForType (#22395)
Jan Kotas [Mon, 4 Feb 2019 19:36:06 +0000 (11:36 -0800)]
More compact implementation of Marshal.GenerateProgIdForType (#22395)

5 years agoReenable corefx System.Linq.Expressions.Tests. (#22362)
Sergey Andreenko [Mon, 4 Feb 2019 19:13:24 +0000 (11:13 -0800)]
Reenable  corefx System.Linq.Expressions.Tests. (#22362)

5 years agoDelete exclusions that reference fixed issues. (#22355)
Sergey Andreenko [Mon, 4 Feb 2019 17:45:03 +0000 (09:45 -0800)]
Delete exclusions that reference fixed issues. (#22355)

* Delete exclusions for the issue that were fixed.

* Change the issue number for ThreadStartString_1

5 years agoFix arm32 unwind for large methods (#22381)
Andy Ayers [Mon, 4 Feb 2019 16:47:48 +0000 (08:47 -0800)]
Fix arm32 unwind for large methods (#22381)

* Fix arm32 unwind for large methods

For arm32, the unwinder bails out with an error if the method offset is not
within the fragment range. And the jit copies prolog unwind codes to all
fragments, so there's no need to walk back and find the root unwind record.

Closes #22260.

* re-enable test

5 years agoRemove code that was moved to System.Native (dotnet/corert#6932)
Filip Navara [Mon, 4 Feb 2019 13:09:20 +0000 (14:09 +0100)]
Remove code that was moved to System.Native (dotnet/corert#6932)

* Remove code that was already moved from System.Private.CoreLib.Native to System.Native.

* Move Interop files for System.Native to shared Interop directory.

* Add FeaturePortableThreadPool conditions to csproj files.

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
5 years agoMerge pull request #22378 from filipnavara/native_cpp_to_C
Jan Kotas [Mon, 4 Feb 2019 04:33:56 +0000 (20:33 -0800)]
Merge pull request #22378 from filipnavara/native_cpp_to_C

Convert System.Globalization.Native to C