Token refresh logic in the sample device (thin_room_light)

1. Token refresh logic is added to the sample device (thin_room_light)

Change-Id: I4fbeab1a3f665e065c3297e808a0145f751631d6
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11403
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Merge branch 'master' into cloud-interface

Change-Id: I9af09877a796742be84589e70c7e3dec522422f4
Signed-off-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Delete Device logic fixed in the account server

1. When a device is deleted, the device ID in each group is removed.
2. The device ID is added only in the resource publish case
3. footnote added

Change-Id: Ifdff14f0f3132a753b2a05cd4e1691657a8b3560
Signed-off-by: yeonghun.nam <yeonghun.nam@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11137
Reviewed-by: jung seungho <shonest.jung@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

fixed create response in message builder

when create response message, it is unnecessary to set observe option.

Change-Id: I293843dac9bdbcc3d1b88724d15c89f229649fde
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11661
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Cloud ACL Management

Cloud ACL Management

Patch #1-2: ACLTable, ACL Id, ACL Verify, request handler added
Patch #3-5: ACL resources renamed, DB API added
Patch #10: URI & Request Handler fixed
Patch #11-15: Support for Observe Added
Patch #16-18: Combine changes for acl verify and policy engine by Sunil Kumar
Patch #19: Issue fixed regarding DB document object to HashMap
Patch #20: Revisions in response to comments

Change-Id: I3acbe47d268cb6ad647317de39185cbd7bd552db
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10191
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Enable more unit tests on Windows

* Enable resource/c_common unit tests
* Enable resource/unittests binary (partially)
* Fix small unit test bugs related to MSVC
* Consolidate flags for gtest binaries on Windows

Change-Id: Iead5e4494f3cc0e597ccee4bd83e6d9978141972
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11609
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Resolve secure tcp build issue for Tizen

Build is failing for tizen if both SECURED and WITH_TCP is enabled.

Change-Id: Ib67fb59fe0ef37d7a0be7c157bfe4b6b86f652bf
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11797
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Rename all threading and synchronization to oc_*

* The threading and synchronization facilities were prefixed with
  ca_* when they lived in connectivity_abstraction. Now that the
  facilities have been moved to c_common, ca_* was renamed to oc_*

Change-Id: I0acc00680c42ebecd376ac238958875d9f1032e4
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11227
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Add generic thread & synchro facilities

* Split Windows and Posix threading and
  synchronization facilities into separate
  files.
* Add ca_thread_[new|free|wait]
* Moved facilities to a more generalized location
  within the iotivity directory hierarchy
* TODO: add ca_mutex_init

Change-Id: I7718a9f5bd07610f0f989ba4729cb89111331238
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10743
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

IOT-1072 Unfork libcoap: update forked headers

Make the .h files compatible between the forked libcoap and the official
libcoap, so that no breaking changes (only additions) are done to the
official libcoap, which other projects depend on the current
types/prototypes in.

Make any additions (that are beyond the official libcoap, but that are
already used by IoTivity code) to libcoap .h files follow the conventions of
libcoap, to make it more likely they'll be accepted back into the upstream
libcoap.  E.g., coap_transport_type -> coap_transport_t, etc.

Leaving WITH_UPSTREAM_LIBCOAP off by default on all OS's in this change.
Turning it on by default in certain OS's will be done as part of a
separate change.

Change-Id: I373ef818b8aeb7608c5e3511dc9880047946fbe0
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9373
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>

Add Copyright header.

Change-Id: I84b2af8096ac67b583c220dffc42fede8c3ca86a
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11829
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
(cherry picked from commit 9310a33d3e1af5023812d919f960f7d00013643e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/11871

[IOT-1294] install libraries when building WITH_RA_IBB flag

When building with the TEST option the libraries will be picked
up at run time.

Changed the order of libraries to prevent linker error related
to the pthread library.

Change-Id: I39e70dc33b774dcf46559306df0c5558975ec451
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11851
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>

IOT-1072 Unfork libcoap: add build flag

* Add WITH_UPSTREAM_LIBCOAP command line option for SCons
* Add libcoap downloader, starting on public 'develop' branch
* Move resource\csdk\connectivity\lib\SConscript to extlibs\libcoap
* Restructured forked libcoap to resemble GitHub version, using a
  separate include directory and #include "coap/file.h" where needed
* Modify tizen build scripts
* Note - most platforms will not yet build with WITH_UPSTREAM_LIBCOAP

Change-Id: I51a59701d903adb63ba73e09afd230b9a7fd8696
Signed-off-by: Daniel Ferguson <daniel.j.ferguson@intel.com>
Signed-off-by: David Antler <david.a.antler@intel.com>
Signed-off-by: Ajay Saini <ajay.saini@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9257
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Updated scons build configuration for Yocto

* Added i686 to the list of supported target architectures
  for a Yocto build.

Change-Id: I2b5b3191807ab7229cb3457f42a21a94a1d1611e
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/2873
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>

Flush 'Build for ...' messages before each build

During a run of 'auto_build.py', stdout buffering get taken over by the
subprocess module, causing print statements in 'auto_build.py' to not
output until the very end of a build. Calling 'sys.stdout.flush()'
causes stdout to be output before the next call to 'subprocess'.

Change-Id: Ibb193b5d30458a3d9be20d418ee22cac302ee819
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11823
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Seperate Android x86 and Armeabi Builds

- Does not change current builds
- Adds ability to run individual android builds in the matrix:
    - x86
    - Armeabi
    - IP Transport
    - Routing Manager
    - Bluetooth
    - Bluetooth Low Energy

Change-Id: I5fa2efc144f28ab74ed9d3e116cfa39d4f6d9d6a
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10239
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: George Nash <george.nash@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

ocpayload: Adding OCByteString support in representation

Add Bytestring handling in OCRepPayloadClone()
 along arrays/vectors of them.

Also added in native java (JNI) part for android
 inspired by existing code, note for later,
 original code might be double checked for potential MLK
 regarding local references to allocated objects within loops.
 Maybe those unref are not mandatory
 as they "are freed automatically after the native method returns."
 http://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html

Improved tests, it is assumed that contents of OCByteString
 are not duplicated when not wanted,
 plus style cleanup on surrounding code.

Note of my understanding of this design mixing C++ and C paradigms :

 - As OCByteString is a C structure there is no destructor
 - If assigned (no deep copy) into Payload class
   bytes will be freed by Payload's destructor as it "owns" it.
 - If contents are deep copied anywhere else
   then bytes should be also freed manually
   (in other classes' destructor ? like Payload).

Bug: https://jira.iotivity.org/browse/IOT-983
Change-Id: Icfa0657df9b332b4d11b737731636c8fb2a80001
Credits-to: youngman <yman.jung@samsung.com>
Origin: https://gerrit.iotivity.org/gerrit/#/c/8931/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/8931
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Fix for Jira issues [IOT-1157, IOT-1194]

[IOT-1157]: Added default case for mentioned switch statements.
[IOT-1194]: Removed unused structures and made
g_GatewayID in routingmanager.c as static.

Change-Id: I03ff080867d28e3d32a18bb74fa7a9a26e465774
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11775
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Cloud Client manual

Change-Id: I82f42e4fcdce91011eb4d6f0d329cfdd29a9789c
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11745
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

[IOT-1294] Fixed build failure for WITH_RA_IBB flags

When building code with the WITH_RA_IBB=1 the build
would fail with undefined references to code found in the external
code found in extlibs/libstrophe and extlibs/wksxmppxep.

The code was already being built but was not properly linked by the
linker. This commit adds the library paths and libraries needed to
pass the build.

Change-Id: Ia9a1a6c40f6eeed174caaeb428224b97ffb6b59d
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11717
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Improved support for Visual Studio

1. Use SCons's MSVC_VERSION variable to support multiple VS
versions, instead of more fragile IoTivity-specific solutions.

2. Don't execute vsvars32.bat "manually" from run.bat. Let SCons
execute that batch script when needed, based on the value of
MSVC_VERSION.

3. Remove VS version handling from gtest/SConscript. Use SCons for
building gtest (and eliminate the need for cmake on Windows).

4. Delete duplicated lines from build_common/windows/SConscript.

Change-Id: I6490a32533624b7959b0a30992c8f10811e7735e
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11727
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

Optimize stack for Arduino.

In RI, headeroptions are maintained as array with default size as this macro.
A default 100 headeroptions are too high and results in a structure size of 3KB+.
Moreover any vendor will not add 100 CoAP options.
Also optimized few clonings.

Change-Id: I65860c44ec1ba0c3ef2800a88f27ecad0f483568
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Signed-off-by: Veeraj Khokale <veeraj.sk@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10585
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Update a logic to convert a string UUID to oicuuid type

The previous convertStringToUUID function does not works well, which
can not convert from string UUID to oicuuid one, properly. Instead of it,
we use an existing API for that in srmutility, i.e. ConvertStrToUuid.

Change-Id: I09f407e8af1a4395bf1b406bdb0f1a729e75f1fe
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11725
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Cloud Acl Management for master branch

Cloud Acl Management moved from cloud-interface to master

Change-Id: Ib35221c06e5dc409dddeed641124d0505fea55a4
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11733
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Clean up ocrandom test

Change-Id: I1547651b8570940f2d08d76748333adab54a3a1b
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11651
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

eliminate [-Wcomment] warning

The JNI files mix C and C++ comments, so we get tons of annoying
warnings: "/*" within comment [-Wcomment]

Since the JNI layer is in C++ we remove the C comments.

Change-Id: I7fb5b2009a787e62de0b9b62ff7d06de4f33b699
Signed-off-by: Gregg Reynolds <reynolds-gregg@norc.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9109
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Petre Eftime <petre.p.eftime@intel.com>
Reviewed-by: Habib Virji <habib.virji@samsung.com>
Reviewed-by: George Nash <george.nash@intel.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

doc: Fix some typos in scons_script_how_to.txt

Maybe this file worth to be migrated to iotivity wiki in a scons page

Change-Id: I288da1273621a48add047993506ed40c107363ab
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11077
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Fix for IOT-1214: Incorrect use of tinyCBOR API in security code

mapSize is consistently larger than the actual size of doxmMap.
This results in an erroneous parse of the resulting payload wherein
the last key-value pair is truncated.

When creating containers, we must specify CborIndefiniteLength unless
we know the exact length the container.

Change-Id: I8beb6bc45ae41531e8a7528d9dbd254a27e14be9
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10455
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

yocto: connectivity should build as linux

Change-Id: I0f7a92ab21edbbbab9043e35a1bad4f429719b67
Bug: https://jira.iotivity.org/browse/IOT-1111
Origin: https://github.com/tizenteam/iotivity
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11713
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ziran Sun <ziran.sun@samsung.com>

Added jni/android implementation for trust cert chain
Provisioning client modified for save and provision cert chain

Change-Id: Iad4b7286ed9076026399d7f7088c4fc39d58c624
Signed-off-by: Sunil Kumar K R <sunil.k14@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11001
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Merge remote-tracking branch 'origin/notification-service'

Android wrapper service is updated.

Change-Id: Iec12e1b9f48b60913e5915e9b3a8bfcf7c4bd891
Signed-off-by: cc <ch79.cho@samsung.com>

Updated Android Provider sample according to latest APIs.

Change-Id: I3f8bab4b3992976648f6d20b7aa6b9aaedd83d65
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11693
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Added Consumer Sample app changes for Notification.

1. Updated to call latest Android APIs
2. Added Topics API calls

Change-Id: Id2ceab934c4a1527911b5e25e6a4f522d8fed9cc
Signed-off-by: abitha.s <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11691
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix windows build in master (2)

[Patch #2] Removed duplicate sqlite parse-config for tizen
[Patch #3] Fix typo that causes tizen build fail

Change-Id: I5976ad8a4013d20037a6871ae975bb9ed581cf17
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11689
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: dongik Lee <dongik.lee@samsung.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-by: Joonghwan Lee <jh05.lee@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

The wrapper unittest is not required"

Change-Id: I3646b0da24192b6a34ceef64f2b4fd602a9a99c8
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11675
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

fix warning caleadapter and fragmentation

Change-Id: Ib6a83e0c59f2dde92881eb077d7575658deffbb4
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11557
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Send normal GET response for register request to
non-observablbe resource(s).

Bug: https://jira.iotivity.org/browse/IOT-1279
Change-Id: I93be3d3dc79bfc782e98ded57ef6cc0122077d7c
Signed-off-by: Ziran Sun <ziran.sun@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11635
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Cloud Client

Implemented:
1. Cloud Client itself with menu and folders structure
2. CRL/ACL requests according latest spec

[Patch #2] Remove OCPayload to ACL/CRL convertion.
           Convert OCpayload back to char * and
           Use ACL/CRL resource functions to parse and update DB
[Patch #3] Add sync to menu and start userRequests as thread
[Patch #4] Save minor changes before merge both clients
[Patch #5] Merge CSR to this cloud client
[Patch #6] Clean-up changes. Merged cloud client works
[Patch #7] Save minor changes before move to cloud-interface branch
[Patch #8] Store private data
[Patch #9] Implement CRL on device according latest spec
[Patch #10] Minor Crl on device fixes
[Patch #11] Handle review comments
[Patch #12] Implement ACL get info on device according spec
            Remove OC_EXPORT from headers
[Patch #13] Fix CBOR encoding
[Patch #14] Crl last update, crl db changes, fix build error
[Patch #15] Crl Get/Post are fully implemented
[Patch #16] Acl fix uri path'es
[Patch #17] PKIX interface to SRM
[Patch #18] CRL rcsn fix (use String Array instead of String)
[Patch #19] ACL callbacks implemetation (parse and print recv data)
[Patch #20] Complete ACL callbacks
[Patch #21] Update Menu UI
[Patch #22] ACL uid's length fixes
[Patch #23] ACL ace request + CRL encoding fix
[Patch #24] Fix crash when receive empty aclist
[Patch #25] Set public data default encoding to DER
            Fix CRL initialization
[Patch #26, 27] Restore #24
[Patch #28] Fix build error related to PKIX
[Patch #29] ACL few fixes, clean-up code, add comments
[Patch #32] Clean-up csr + handle all review comments
[Patch #34] Revert ocpayload.c changes
[Patch #35] Fix build without WITH_TCP, CRL/ACL clean-up, error on exit
[Patch #37] Fix private data encoding
[Patch #38] Test build on Windows
[Patch #40] Remove accidental changes
[Patch #41] TLS sample fix
[Patch #42] CRL changes to use CBORPayload() functions
[Patch #43] ACL changes to use CBORpayload() + printAcl() + minor fixes
[Patch #44] Added extern C for external linkage to C++
[Patch #45] Revert #44 + acl fix
[Patch #47] Implement OC_LOG_PAYLOAD to show nested objects and arrays
[Patch #48] Fix review comments
            Add dynamic cipher based on SVR
            Change close notify to alert
[Patch #49] Add rootcer.crt and SaveTrustCert in cloudClient sample
[Patch #50] Change cipher priority and add choose cipher option in sample
[Patch #51] Remove accidental changes
[Patch #52] Add RSA cipher selection
[Patch #53] Huge changes in API and handlers to provide it to external team
[Patch #54] Minor fix, clean-up, add comments
[Patch #55] Resoved issue for save TrustCert with PEM in cloudClient sample
[Patch #56] UpdateACE fix, add CoAPs selection to Menu
[Patch #57] Few ACL requests fix, now all of them are working
[Patch #58] Add db file to command-line args + few fixes
[Patch #60] Add alert messages
[Patch #61] Fix cipher selection
[Patch #62] Fix Svace warnings
[Patch #63] Fix acl db issue. Create CBORpayloadToAcl2() for cloud response
            Because in latest spec its wrong we need this workaround
[Patch #64] Fix service folder build error when secured enabled
[Patch #65] Implement responses to cloud cpp wrapper API
[Patch #66] Minor fix to cloud cpp wrapper responses
[Patch #67] Fix Cbor allocation when credresource increase
[Patch #68] Revert wrong changes made in Patch #64
[Patch #69] Remove wrong changes in other SConscript files
[Patch #70] Fix minor build error
[Patch #71] Remove wrong changes from 2 source files + clean-up Sconscripts
[Patch #72] Return back credresource.c + fix crlresource.c for tizen
[Patch #73] Return back richdk scons
[Patch #74] Disable build stack samples without SECURED=1
[Patch #75] Fix OTM PIN
[Patch #76] Fix conflict
[Patch #77,78] Fix tizen build error
[Patch #80] Remove changes in secure stack samples
[Patch #81] Add ours headers to doxygen, update comments, add static
[Patch #83] Fix conflicts with master
[Patch #84] Add Discovery + Get/Put/Post device-to-device requests
            Separate most sample source code to cloud folder
[Patch #86] Arduino build fix
[Patch #87] Resolve merge conflict

Change-Id: Ib83b14a40d49df3b62dd5a1863777c8a5504a4e5
Signed-off-by: Jonsgung Lee<js126.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Joonghwan Lee<jh05.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Joonghwan Lee<jh05.lee@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Dmitriy Zhuravlev <d.zhuravlev@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Signed-off-by: Oleksandr Dmytrenko <o.dmytrenko@samsung.com>
Signed-off-by: Andrii Shtompel <a.shtompel@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10785
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>

SimpleBase code clean up

Remove warning and change main page

Change-Id: I1535fe015414462d9320fccddee6ddea9bb7a530
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11319
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

fixed multicast presence for sample related c-sdk.

Change-Id: I011b0575b34b957ef776a3ca56db0b3f2d751f2b
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11329
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1248] Fix multiple APIs throwing wrong exception

Change-Id: Ide5d534e301492bfd5499fa6d1cc7778bf5e7611
Signed-off-by: saurabh.s9 <saurabh.s9@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11671
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>
Tested-by: Randeep Singh <randeep.s@samsung.com>

add empty parameter checking in OCAccountManager

Since empty parameter checking for APIs in OCAccountManager is missing,
I added.

And modified signUp API according to the OCF cloud specification.

Change-Id: I23ecc376d3ac6522d411b7a0a9408d79f11fab24
Signed-off-by: Jaewook Jung <jw0213.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11667
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

remove warning for keepalive

- check return value for OCDoresource

Change-Id: Ia3efa0d8365dd60ecb0c0e7dc751d242bcffa97d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11633
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

add deleteLocalRef for findResource callback

since findResource callback is called for several times.
it is better to call DeleteLocalRef after the variables is used.

Change-Id: I4d7e7eee7bda8ecba2880371fcc1bc87a90e32c1
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11367
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Enable IPv6 Interface for Android, Tizen

Enable IPv6 Interface for Android, Tizen

Change-Id: Ic92d724556240e4a9f5f77ea2c4b546dc93c2226
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11379
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Development of CoAP-HTTP Proxy

Wiki page: https://wiki.iotivity.org/coap-http_proxy
JIRA Issue: https://jira.iotivity.org/browse/IOT-1128

Change-Id: I12a6c53589a428bdc1f94ea6d48a692ac07aabfe
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11601
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Update a policy of successful cloud provisioning

If an enrollee already has an ACL and certificate for communication
with Cloudserver, a mediator does not need to provide them.
That is, ACL and certificate provisioning can be skipped for this case.

Change-Id: Id22566e21c22f92b552a3861a41f0de83959dcf3
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11655
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix SetDoxmDeviceId()

Fix SetDoxmDeviceId()
PT check removed
sqlite3 linking removed

Change-Id: I3bced8ba7c8e65ef3b97bea7113eee5cdbde9168
Signed-off-by: Jongmin Choi <jminl.choi@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Merge "Merge remote-tracking branch 'origin/notification-service' Updated with static analysis."

resource-container: Change file permission of SampleResource sources

Removed the execute permission for the SampleResourceClient.cpp and
SampleResourceServer.cpp files in service/resource-encapsulation/examples/linux

Change-Id: I2ac6381ada31d76aead5e7139ea62d888d1a2877
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/4525
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Author: Ravi Nanjundappa <nravi.n@samsung.com>
Origin: 1.0.1
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11485
Reviewed-by: Uze Choi <uzchoi@samsung.com>

resource-encapsulation: Avoid reinterpret_cast in const_expr

As unsupported in C++11 standard and g++-6 or clang

Reported error message is:

  service/resource-encapsulation/src/serverBuilder/unittests/RCSResourceObjectTest.cpp:368:13:
  error: reinterpret_cast from integer to pointer
  reinterpret_cast<OCRequestHandle>(0x1234);

Problem was observed while building for Yocto with generic toolchain:
  i586-poky-linux-g++ (GCC) 6.2.0

For reference see p125 of:

  http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2013/n3797.pdf

Change-Id: I20b21ad1bdac40c2aec44706501343ae1d9d7b69
Bug: https://jira.iotivity.org/browse/IOT-1111
Origin: https://github.com/tizenteam/meta-oic
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11663
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

security: Improve with more specific error core and log of it

This improvement has been suggested by Randeep Singh at :

 https://gerrit.iotivity.org/gerrit/#/c/9521/

Also reducing presence of "goto:" is always welcome ;)

Change-Id: I2ca21c37105c530c92e2cfd4b6ae9e3cfbc06231
Origin: https://gerrit.iotivity.org/gerrit/#/c/9543/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/9543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Randeep Singh <randeep.s@samsung.com>

Merge remote-tracking branch 'origin/notification-service'
Updated with static analysis.

Change-Id: I73120da7cafc810f613fd2d9b265366ff773bbd3
Signed-off-by: cc <ch79.cho@samsung.com>

Add setCredID to mediator sample application

To tranfer a certificate to Enrollee, you need to specify a credential ID
corresponding to the certificate.

Change-Id: I79c39ff1a6f0f90175cfe11c6ca7ed719f3cf222
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11653
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Jira issues(IOT-1263)

IOT-1263:
  [ES][Linux] Get Location API can not get expected location
  (https://jira.iotivity.org/browse/IOT-1263)

Change-Id: Ifc0a088c3d7c8166fdc093976bebb3e84d036295
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11659
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix Jira issues(IOT-1268)

IOT-1268:
  [ES][Android] APIs crashed with null parameter
  (https://jira.iotivity.org/browse/IOT-1268)

Change-Id: I7b3bb5b9eb78df12b60e852a878ee73cb0d1c189
Signed-off-by: Parkhi <h_w.park@samsung.com>
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11521
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add a dependency in building notification-service for android.

After libnotification_provider_wrapper.so is created, its android SDK
should be built.

Change-Id: I6df993e6ccd60f29017cd2e47fe75b2d3cc78892
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11657
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove logs with non-LOGGING build option.

When notification service build on non-Logging mode, log is removed.
For the above reason, newly appeared warning is resolved.

Change-Id: Ibc7a1ee32e3063934ad5fccdaf363707ef5a247c
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11621
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Remove unused task type on consumer service.

Named TASK_CONSUMER_GET_TOPIC_LIST task is remove reason by unused.

Change-Id: Id65cca0a284a4c0d3f216fc74bc9c0d4bcc4edfa
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11631
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix for result of static analysis.

Pointer value casting is fixed for valid size.
If statement is fixed.

Change-Id: I4e6304769c683f78caca8eea4f4dc1da5c369a59
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11619
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>

Fix bug for select topic.

When consumer service get topic to provider, consumer id is excepted.
Consumer id is added on request get topic.
linux sample app is updated for print topic.

Change-Id: I383c2032856e034e80241cc49b1601fece04d230
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11625
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>

Add sendMessage for NSProviderSetConsumerTopic and bug fixes for API.

1. Add sendmessage when call NSProviderSetConsumerTopic function.
2. Add bug fixes for API ('\0' case)

Change-Id: If5c204909cb37220ea0c2f007e9224aae0c494b2
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11627
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Update consumer service termination logic.

When consumer service termination or stopped,
memory deallocation of thread, mutex, list object is added.

unit test of NSConsumerGetProvider is added.

Change-Id: I61c30b46645d5a88eeac7f4ed6ca06d5b3d1036e
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11615
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

modified observe exception, when channel is disconnected

Change-Id: I6309712296cb8269c9dba027d64e8656e8479428
Signed-off-by: Jung Seungho <shonest.jung@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11213
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Fixes for build errors hit by some versions of Visual Studio

Change-Id: Id8bcb4a5cd65d855b8e371c981f1c9bb4e6ed26d
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10929
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Dan Mihai <Daniel.Mihai@microsoft.com>

Fixed discarded-qualifiers warning

by asigning the const pointer type to a non-const pointer type
the code was discarding the const qualifier. Added const key
word to fix warning.

Change-Id: Ided09959ac9406ed80f69606e9ed065d2498ebd2
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11527
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jaehyun Cho <jaehyun3.cho@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

Fixed shift-negative-value warning

The compilar was interpreting the number zero '0' as a
signed number not an unsigned number. The left shift behavior
for signed numbers is undefined. The 'u' sufix was added to
tell the compilar that the '0' is an unsigned number.

Change-Id: Ida6c5c5ee2a7ea556755ca55d71858469a0691ac
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11525
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: jaehyun Cho <jaehyun3.cho@samsung.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

Fixed implicit-function-declaration warning for strncasecmp

Both csdk/security/src/aclresource.c and
csdk/security/src/pstatresource.c reports that there is an
implicit declaration of function 'strncasecmp' this means
the code does not see the 'strncasecmp' function from the
header.

The 'strncasecmp function exist in the strings.h header or
in string.h header. To have the funtion in the string.h
header the _GNU_SOURCE or _DEFAULT_SOURCE macro must be
defined.

Since aclresource.c explicity excludes strings.h if string.h
is found the _GNU_SOURCE macro was added.

The _GNU_SOURCE macro was used over the _DEFAULT_SOURCE
macro since there already apears to be a presidence for
the _GNU_SOURCE macro elsewhere in the code.

Change-Id: I2d29521d0f28811be2a58349a5bc8be39b17d76e
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11529
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>
Tested-by: Rick Bell <richard.s.bell@intel.com>

Fixed implicit-function-declaration warning for strnlen function

The strnlen is a GNU extension and not a standard C function and
is not avalible unless the macro _DEFAULT_SOURCE or _GNU_SOURCE is
defined.

It looks like _GNU_SOURCE already has a precidence so it was added
to the build script.

Change-Id: Ied150e5b97a965c1b4b240d364e49669bdad4f11
Signed-off-by: George Nash <george.nash@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11523
Reviewed-by: Larry Sachs <larry.j.sachs@intel.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Rick Bell <richard.s.bell@intel.com>

Fix setting adapter type value of Endpoint for TCP adapter.

These was no set adapter value in Endpoint previously.

Change-Id: Id52d3c4393943dac205c2953ceb3334a3e43f8bf
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11273
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fix for JIRA issue 1242, 1245, 1247

https://jira.iotivity.org/browse/IOT-1242
https://jira.iotivity.org/browse/IOT-1245
https://jira.iotivity.org/browse/IOT-1247

Change-Id: I93a5f2bf3780ed2dc0ab74cd9701d100c1bbcb87
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11545
Reviewed-by: Masud Bhuiyan <m.parves@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1265] fix writeCharacteristic success signal logic

Change-Id: Ib9a5b4ad18298fc2541fb128d964e2e634280cb2
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11539
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

[IOT-1272] added null checker for address in setAutoConnectionDevice API

Change-Id: Ib89a3856d3089d68e58e6d72112f76c59322f055
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11563
Reviewed-by: Suchita Sultana <suchita.rs@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Add logic for media contents.

Media contents parse and copy, remove logic is added at consumer service.

Change-Id: If2079e33fcb0f84f983212468786657cfdc91976
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11571
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Updated cpp wrapper UnitTest

1) Updated code according to latest API names.
2) Added new test cases required for checking topic resource apis

Change-Id: Ib68d1a8dfe1aea2bc07d50def87cc366d4f60a84
Signed-off-by: nikhil.a <nikhil.a7@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11503
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Add response logic for TopicListener.

Add response logic for OC_REST_POST case.
and call the NSSendTopicUpdationToConsumer().

Change-Id: I38de295bf143d504bb03cb090b6294a3d25017ec
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11565
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Update unit test and Fix bug.

Unit test is updated for apply latest consumer logic.
And unit test of basic topic operation is added.

Invalid memory access is fixed.

Change-Id: I0fd30c6e0eb3e97196e591b5754aaf38c814ffa2
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11569
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Undo revert "Generate iotivity_config.h at build time"

This reverts commit 8754a91b157e957b0c0ade9f07804cde2b3cd225.

Change-Id: I180eea046754d3c67fc12e426b675c569df57331
Signed-off-by: David Antler <david.a.antler@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11453
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>

[IOT-1270] Fix building with SECURED=0 for Windows

Don't try to link or export security-related APIs when SECURED=0.

Also, fix scons warning related to sqlite, in security/provisioning.

Change-Id: I61ddab0aeecdc917427bcc5051fb6be960b4b63f
Signed-off-by: Dan Mihai <Daniel.Mihai@microsoft.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11533
Reviewed-by: Kevin Kane <kkane@microsoft.com>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Soemin Tjong <stjong@microsoft.com>
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

[IOT-1259] README for cloud MQ updated

Change-Id: I9ea9e1e6ca1914bf196525506cf88621b15b9288
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11555
Reviewed-by: Md. Imtiaz Hossain <imtiaz.h@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Revert "Development of CoAP-HTTP Proxy"

This reverts commit fa393dc92a9ea0e8809d4474d54d916e845b2d0e.

Change-Id: Ic3754979f2d9e672437110d5ae076792cf421330
Signed-off-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11599
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Development of CoAP-HTTP Proxy

Wiki page: https://wiki.iotivity.org/coap-http_proxy
JIRA Issue: https://jira.iotivity.org/browse/IOT-1128

Change-Id: I14f3e6a68c83e5c2cebfedbe1a0e1247e3cb85c2
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10725
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Fix cainterface crash issue

GetStaticMethodID doesn't need to use DeleteGlobalRef.

Change-Id: Ifea9490e9e7fa142d92687363436a1b8529f43a3
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11437
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>

Update parse logic of introspectProvider result.

When received introspect provider result,
consumer service expect to get provider policy as type of boolean.
But, policy is integer type although provider side set boolean type.
So, parse logic of policy is updated to parse for given type by received payload.

Change-Id: I695e81179172376499345f9b1f6323a04325a015
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11383
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Remove NSMessage Storage of consumer service.

NSMessage storage is removed reason by unnecessariness functionality.
But, for the prevent of duplicated message, messageId and NSSyncType need to store.
So, linked list of information for message sync state is added.

Change-Id: Iea80b20a4ca44d9b17b2d3f0746d1f33212d9a3e
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11479
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add Unittest for topic.

1. Unregister topic case.
2. setTopic case.
3. unSet Topic case.

second patch,
remove warning code.

Change-Id: I8f918bcc23297311d86fcb7f4c13419b99b02d36
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11477
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add setting the icon image.

Add setting the icon image in NSSetMessagePayload.
Add NS_ATTRIBUTE_ICON_IMAGE in NSConstants.h

Change-Id: Ia1327da32c80737283ea54f8b2e9f2d4f376efb5
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11559
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Change while condition in resource broker

Removing possible infinite loop with while(1) condition

Change-Id: I07a85de3a38fad3265fd8712a8ce1c912fccf690
Signed-off-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11517
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Update logic of callback when provider discovered.

When consumer discover already discovered provider as unsubscribing,
does not callback to upper layer before,
but we decide to callback to upper layer, so related logic is updated.

Change-Id: Iddeb4577f94f941473452ad035949aaf7c135914
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11499
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

remove scons build warning from sample app

gets function is changed to input function to remove warining.

Change-Id: I1f2ad5c1962f81a2321597f078baf513a1b83227
Signed-off-by: ch79.cho <ch79.cho@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11481
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add Macro for related resource and bug fixes for Topic.

1. Add Macro - createResource, deleteResource
2. Add NS_FAIL for fail case in NSAddTopics Function.

Change-Id: Ic94403298cf824e9d7a47de91d8c42bfa84b1460
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11489
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix bug for callback as seperated thread.

Problem: It is degined that consumer service executes
     the registered callback function in different thread
But, the registered callback function for ProviderChanged event
      is called in same thread.

Fix: Separate the thread for this callback function execution
     from main thread

Change-Id: Ic4c9edce1c058a7e04aa7a38fad8f66f2e586d3d
Signed-off-by: KIM JungYong <jyong2.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11493
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Add condition for topic of sendNotification.

topic case is Null or '\0'.

Change-Id: I216fd165145bd7523810e8636919c95f89470ef0
Signed-off-by: jaesick.shin <jaesick.shin@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11465
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Merge "Merge remote-tracking branch 'origin/master' into notification-service" into notification-service

Removed build warning: Two different environments in C++ wrapper

Removed unUsed variable warnings
Removed warnings for printing variables

Change-Id: I5d6ba48df298c91f46ba7388ea355bc6a833a679
Signed-off-by: Abitha Shankar <abitha.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11501
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Chihyun Cho <ch79.cho@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>

Set unused OCDeviceInfo struct fields to NULL

Java DeviceInfo never uses the optional OCDeviceInfo fields,
these must be set to NULL to avoid potential corrupt data.

Change-Id: I7eda3be60d17591ab6169c0d487784c474f6325d
Signed-off-by: ljsachs <larry.j.sachs@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10165
Reviewed-by: Dave Thaler <dthaler@microsoft.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

build: Exit with return code from builds

[Trevor Bramwell <tbramwell@linuxfoundation.org>]
The exit code from scons calls is being silently ignored. Returning the
exit code from 'wait()' in auto_build.py and passing it to 'exit()'
should correctly fail builds.

[Philippe Coval <philippe.coval@osg.samsung.com>]
To sort out and sync ourselves, I added Bug-Id to commit message.
Content is same, feel free keep that link and push over.

Change-Id: I5afce52a3bddf7fb4e6b68acb57a1d51f3034067
Signed-off-by: Trevor Bramwell <tbramwell@linuxfoundation.org>
Author: Trevor Bramwell <tbramwell@linuxfoundation.org>
Bug: https://jira.iotivity.org/browse/IOT-1260
Origin: https://gerrit.iotivity.org/gerrit/#/c/11087/
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11087
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: David Antler <david.a.antler@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Merge remote-tracking branch 'origin/master' into notification-service

Change-Id: I46af88cce1a821841baa1fe3f5226537ae1eb83b
Signed-off-by: cc <ch79.cho@samsung.com>

Unit test development.
1. CSR update(update for new specification)
2. CSR unit test update for new specification.
3. Code refactoring.
4. Update CRL pubdatatype and express RCSN as Arralist of Strings
   as in specification.
5. Fix issues for CRL table, add new unit tests, add docs for
   CertificateConstants, CertificateManager, CertificateStorage.
6. Fix issue with subjectDN and issuerDN for CA certificate and for personal one.
   please remove cloud/account/keystore folder
7. Fix last update CRL issue.
8. Fix issuer name for CRL.
9. Fix issue with basic-constraints. Code refactoring.
10. Fix issue with CRL re-creation after account restart.
11. Fix issue with CRL subject name.
12. Replace Base64 to Der coding for CRL GET. Code refactoring.
13. Put CRL to db as BinaryData and remove CRL file.
14. Add new unit tests for CRL.
15. Add new unit tests for CSR and add documentation.

Change-Id: Iadef163d6cde2ca671b70a0cc05d9a73cbf9b8a3
Signed-off-by: Andrii Androsov <a.androsov@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/10977
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jee Hyeok Kim <jihyeok13.kim@samsung.com>

Add dependency to build Easy setup android application

Before building Android Mediator sample application, Easy setup SDK should
be built. This patch makes such a dependency.

Change-Id: I8e9ddbeac1f5f9a3ad12e4505de4423469b94bb5
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/11515
Reviewed-by: Phil Coval <philippe.coval@osg.samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>