Michael Biebl [Wed, 4 Feb 2015 20:31:26 +0000 (21:31 +0100)]
build-sys: mark systemd-firstboot man page as conditional
Rebuild Makefile-man.am accordingly.
Lennart Poettering [Wed, 4 Feb 2015 16:00:23 +0000 (17:00 +0100)]
timesyncd: downgrade more log messages from LOG_INFO to LOG_DEBUG
https://bugs.freedesktop.org/show_bug.cgi?id=87505
Let's make timesyncd less chatty.
Zbigniew Jędrzejewski-Szmek [Wed, 4 Feb 2015 15:24:02 +0000 (10:24 -0500)]
shared/capabilities: simplify assertions about bits
The assert added in
7d328b5446 was wrong. Also update the comments
and make sure we don't try to shift by type size.
Zbigniew Jędrzejewski-Szmek [Wed, 4 Feb 2015 14:39:36 +0000 (09:39 -0500)]
shared/util: drop duplicate log2u64 function
Zbigniew Jędrzejewski-Szmek [Wed, 4 Feb 2015 14:35:37 +0000 (09:35 -0500)]
man: fix diagrams in bootup(7)
Fallout from
798d3a524e.
Lennart Poettering [Wed, 4 Feb 2015 13:46:40 +0000 (14:46 +0100)]
timesyncd: reduce log chattiness a bit
Let's downgrade the statistics output from LOG_INFO to LOG_DEBUG.
https://bugs.freedesktop.org/show_bug.cgi?id=88926
Jay Faulkner [Wed, 4 Feb 2015 01:45:50 +0000 (17:45 -0800)]
nspawn: Allow module loading if CAP_SYS_MODULE is requested
nspawn containers currently block module loading in all cases, with
no option to disable it. This allows an admin, specifically setting
capability=CAP_SYS_MODULE or capability=all to load modules.
Tom Gundersen [Wed, 4 Feb 2015 08:23:24 +0000 (09:23 +0100)]
shared/capability: don't be too frugal on space for caps
We were dropping the most significant bit. Add an assert to make sure it does not happen again.
Fixes a bug introduced in
7d328b544621d4b1bec936dec612947ad8bfb65a.
Zbigniew Jędrzejewski-Szmek [Wed, 4 Feb 2015 02:14:13 +0000 (21:14 -0500)]
Reindent man pages to 2ch
Zbigniew Jędrzejewski-Szmek [Tue, 3 Feb 2015 01:28:39 +0000 (20:28 -0500)]
tmpfiles: fix compilation without acl support
Luke Shumaker [Wed, 4 Feb 2015 01:07:37 +0000 (20:07 -0500)]
cg_path_get_user_unit(): Did not correctly parse user-unit templates.
It ran either skip_session() or skip_user_manager(), then ran skip_slices()
iff skip_session() ran. It needs to run skip_slices() in either case.
Included is a test case demonstrating why.
Lennart Poettering [Wed, 4 Feb 2015 00:42:49 +0000 (01:42 +0100)]
core: don't reset log level to NOTICE if we get quiet on the kernel cmdline
quiet should really just have an effect on the stuff we dump on the
console, not what we log elsewhere.
Hence:
debug on kernel cmdline → interpreted by every tool, turns up
log levels to "debug" everywhere.
quiet on kernel cmdline → interpreted only by PID 1 (and
obviously the kernel) no alteration of the max log level, but
turns off status output.
http://lists.freedesktop.org/archives/systemd-devel/2014-December/026271.html
Lennart Poettering [Wed, 4 Feb 2015 00:42:46 +0000 (01:42 +0100)]
update TODO
Chris J Arges [Tue, 3 Feb 2015 23:56:06 +0000 (17:56 -0600)]
virt: add detect_vm_devicetree for powerpc arches
Check sysfs devicetree values in order to detect if we are running on a KVM
hypervisor on a powerpc architecture.
Tom Gundersen [Tue, 3 Feb 2015 14:44:50 +0000 (15:44 +0100)]
networkd: refactor socket activation a bit
Tom Gundersen [Tue, 3 Feb 2015 20:33:04 +0000 (21:33 +0100)]
sd-rtnl: allow sd_rtnl_open_fd() to be used on bound sockets
Tom Gundersen [Tue, 3 Feb 2015 14:44:12 +0000 (15:44 +0100)]
networkd: handle suspend events
Thomas Hindoe Paaboel Andersen [Tue, 3 Feb 2015 20:35:14 +0000 (21:35 +0100)]
partial revert of fed6df8
This one was acutally used to free xattr
Lennart Poettering [Tue, 3 Feb 2015 18:07:40 +0000 (19:07 +0100)]
core: open up DefaultDependencies= property for transient units
Johannes Hölzl [Tue, 3 Feb 2015 17:53:31 +0000 (18:53 +0100)]
core: busname_supported() should cache what it detects
Add the missing "static" to actually make this a cache.
Lennart Poettering [Tue, 3 Feb 2015 17:17:00 +0000 (18:17 +0100)]
journald: fix some xsprrintf() buffer size fallout
Lennart Poettering [Tue, 3 Feb 2015 17:16:35 +0000 (18:16 +0100)]
core: use some nice macros where appropriate
Lennart Poettering [Tue, 3 Feb 2015 17:16:17 +0000 (18:16 +0100)]
update TODO
Lennart Poettering [Tue, 3 Feb 2015 13:08:56 +0000 (14:08 +0100)]
update TODO
Lennart Poettering [Tue, 3 Feb 2015 12:53:01 +0000 (13:53 +0100)]
loopback-setup: simplify code a bit
Lennart Poettering [Tue, 3 Feb 2015 12:48:15 +0000 (13:48 +0100)]
loopback-setup: no need to redefine LOOPBACK_IFINDEX, we already have it in missing.h
Lennart Poettering [Tue, 3 Feb 2015 10:46:25 +0000 (11:46 +0100)]
update TODO
Harald Hoyer [Tue, 3 Feb 2015 09:43:24 +0000 (10:43 +0100)]
test-functions: search for the initrd and kernel according to the BLS
Also search for the initrd and kernel according to the boot loader
specification.
Harald Hoyer [Tue, 3 Feb 2015 09:44:27 +0000 (10:44 +0100)]
test-functions: use sfdisk without cyl,head,sectors
newer sfdisk implementations do not work with these anymore
Harald Hoyer [Tue, 3 Feb 2015 09:45:25 +0000 (10:45 +0100)]
test-functions:install_libnss() call dracut_install with all $NSS_LIBS
dracut_install() can cope with more than one file
Martin Pitt [Sun, 1 Feb 2015 23:19:33 +0000 (00:19 +0100)]
tests: install ldconfig.real for Debian based distros
In Debian based distributions ldconfig is just a shell wrapper around
ldconfig.real, for deferring it during package installation.
Martin Pitt [Sun, 1 Feb 2015 23:19:32 +0000 (00:19 +0100)]
tests: install hostname debug tool
This is mostly a vehicle to pull in libnsl.so which gets dlopen()ed by NSS
under certain NSS configurations.
Martin Pitt [Sun, 1 Feb 2015 23:19:31 +0000 (00:19 +0100)]
tests: install all required libnss modules
Don't assume "files" for everything in nsswitch. Instead, ask "getent passwd"
about which libnss modules it dlopen()s, and install these.
Martin Pitt [Sun, 1 Feb 2015 23:19:30 +0000 (00:19 +0100)]
tests: don't hardcode systemctl path
Get it from type -P instead, to support --enable-split-usr.
Martin Pitt [Sun, 1 Feb 2015 23:19:29 +0000 (00:19 +0100)]
tests: determine rootlibdir from pkg-config
Prefer asking pkg-config for the rootlibdir, to also support systems with
--enable-split-usr. Fall back to the hardcoded /usr/lib/systemd if that fails.
Martin Pitt [Sun, 1 Feb 2015 23:19:28 +0000 (00:19 +0100)]
tests: Make sushell optional in image creation
sushell does not exist in all distributions, and it can be changed with
configure --with-debug-shell, so make installation of it optional.
Zbigniew Jędrzejewski-Szmek [Tue, 3 Feb 2015 03:59:22 +0000 (22:59 -0500)]
build-sys: distribute systemd-networkd.socket
Zbigniew Jędrzejewski-Szmek [Tue, 3 Feb 2015 02:32:28 +0000 (21:32 -0500)]
network-address,test-network: avoid undefined behaviour
Zbigniew Jędrzejewski-Szmek [Mon, 2 Feb 2015 19:51:31 +0000 (14:51 -0500)]
shared/async: simplify asynchronous_job a bit
Zbigniew Jędrzejewski-Szmek [Mon, 2 Feb 2015 19:50:56 +0000 (14:50 -0500)]
test-dhcp-client: add a kludge to make valgrind happy
Zbigniew Jędrzejewski-Szmek [Mon, 2 Feb 2015 19:46:40 +0000 (14:46 -0500)]
test-dhcp-client: open a real udp socket for test execution
./test-dhcp-client would attempt to operate fd 0, i.e. stdin.
For example, './test-dhcp-client </dev/null' would fail with EPERM
because /dev/null cannot be used with epoll.
https://bugzilla.redhat.com/show_bug.cgi?id=1076119
Lennart Poettering [Tue, 3 Feb 2015 01:07:59 +0000 (02:07 +0100)]
update TODO
Lennart Poettering [Tue, 3 Feb 2015 01:05:59 +0000 (02:05 +0100)]
util: rework strappenda(), and rename it strjoina()
After all it is now much more like strjoin() than strappend(). At the
same time, add support for NULL sentinels, even if they are normally not
necessary.
Lennart Poettering [Mon, 2 Feb 2015 22:21:20 +0000 (23:21 +0100)]
networkd: minor simplification
Let's return the fd we found as return value in systemd_netlink_fd(),
instead of using call-by-reference.
Thomas Hindoe Paaboel Andersen [Mon, 2 Feb 2015 21:56:44 +0000 (22:56 +0100)]
remove unused variables
Lennart Poettering [Mon, 2 Feb 2015 20:54:23 +0000 (21:54 +0100)]
update TODO
Lennart Poettering [Mon, 2 Feb 2015 20:34:32 +0000 (21:34 +0100)]
units: so far we defaulted to 90s as default timeout for most things, let's do so for our oneshot services too
Fewer surprises, and stuff...
Lennart Poettering [Mon, 2 Feb 2015 20:34:09 +0000 (21:34 +0100)]
tmpfiles: let's always use DEFINE_PRIVATE_STRING_TABLE_LOOKUP_TO_STRING() instead of defining our own string tables
Lennart Poettering [Mon, 2 Feb 2015 20:28:33 +0000 (21:28 +0100)]
time-util: let's make xstrftime() useful for everybody, even if we only have a single user so far.
Lennart Poettering [Mon, 2 Feb 2015 20:28:19 +0000 (21:28 +0100)]
macro: document that DECIMAL_STR_MAX contains space for the trailing NUL byte
Sebastien Bacher [Mon, 2 Feb 2015 14:48:40 +0000 (15:48 +0100)]
bootchart: Ensure that systemd is the init called after using bootchart
When booting with systemd-bootchart, default to call the systemd binary
rather than the init binary on disk, which might be another init system.
Collecting data only works with booting systemd.
Topi Miettinen [Sun, 1 Feb 2015 06:49:02 +0000 (08:49 +0200)]
backlight: let udev properties override clamping
On my computer, the minimum brightness enforced by clamping in
backlight is too bright.
Let udev property ID_BACKLIGHT_CLAMP control whether the brightness
is clamped or not.
Martin Pitt [Mon, 2 Feb 2015 15:53:39 +0000 (16:53 +0100)]
cryptsetup: only warn on real key files
Simplify the check from commit 05f73ad to only apply the warning to regular
files instead of enumerating device nodes.
Sangjung Woo [Mon, 2 Feb 2015 11:25:02 +0000 (20:25 +0900)]
tmpfiles: Remove unnecessary blank line when configured with "--disable-resolved"
This patch removes unnecessary blank line in
/usr/lib/tmpfiles.d/etc.conf when configured with "--disable-resolved".
(i.e. ENABLE_RESOLVED is not defined)
Lennart Poettering [Mon, 2 Feb 2015 15:43:00 +0000 (16:43 +0100)]
update TODO
Cristian Rodríguez [Mon, 2 Feb 2015 15:06:05 +0000 (12:06 -0300)]
cryptsetup: Do not warn If the key is /dev/*random
Using /dev/urandom as a key is valid for swap, do not
warn if this devices are world readable.
Tom Gundersen [Sun, 1 Feb 2015 21:13:26 +0000 (22:13 +0100)]
networkd: support socket activation
Still keep the non-socket activation code around for starting from the commandline, but
will likely drop that too in the future.
Tom Gundersen [Sun, 1 Feb 2015 21:12:33 +0000 (22:12 +0100)]
sd-rtnl: introduce sd_rtnl_new_from_netlink
Tom Gundersen [Sun, 1 Feb 2015 20:04:35 +0000 (21:04 +0100)]
networkd-wait-online: add timeout
Default to timing out after 120 seconds without a network connection. Setting a
timeout of 0 disables the timeout.
Tom Gundersen [Sun, 1 Feb 2015 17:06:40 +0000 (18:06 +0100)]
sd-event: treat NULL callback for timer events like sig events
In both cases exit the event loop.
Tom Gundersen [Sun, 1 Feb 2015 14:13:17 +0000 (15:13 +0100)]
networkd-wait-online: support globbing for ignored devices
Marcel Holtmann [Mon, 2 Feb 2015 08:18:28 +0000 (09:18 +0100)]
hwdb: Update database of Bluetooth company identifiers
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 21:05:56 +0000 (16:05 -0500)]
man: switch yum to dnf for Fedora
The dnf name is here to stay, we might as well adjust.
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 20:26:46 +0000 (15:26 -0500)]
shared/capability: go frugal on space for caps
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 19:33:10 +0000 (14:33 -0500)]
Fix dropping of all capabilities
From fd.o bug 88898:
systemd-resolved fails to start:
Failed to drop capabilities: Operation not permitted
Broken in
f11943c53ec181829a821c6b27acf828bab71caa.
Drop all capabilities:
1. prctl(PR_SET_KEEPCAPS, keep_capabilities != 0) // 0 when we drop all
capabilities
2. setresuid() // bye bye capabilities
3. Add CAP_SETPCAP // fails because we have no capabilities
4. Reduce capability bounding set
5. Drop capabilities
6. prctl(PR_SET_KEEPCAPS, 0)
Capabilites should always be kept after setresuid() so that the capability
bounding set can be reduced.
Based-on-a-patch-by: mustrumr97@gmail.com
https://bugs.freedesktop.org/show_bug.cgi?id=88898
We must be careful not to leave PR_SET_KEEPCAPS on. We could use the
setresuid() call to drop capabilities, but the rules when capabilities
are dropped are fairly complex, since a transition to non-zero uid must
happen. Let's instead keep the capabilities during setresuid(), and drop
them later.
Michael Olbrich [Fri, 30 Jan 2015 08:49:55 +0000 (09:49 +0100)]
config_parse_set_status: put signals in the correct set
This was broken when the code was rearranged in "
1e2fd62d70ff
core/load-fragment.c: correct argument sign and split up long lines"
Zbigniew Jędrzejewski-Szmek [Tue, 27 Jan 2015 13:00:11 +0000 (08:00 -0500)]
Add a snprinf wrapper which checks that the buffer was big enough
If we scale our buffer to be wide enough for the format string, we
should expect that the calculation was correct.
char_array_0() invocations are removed, since snprintf nul-terminates
the output in any case.
A similar wrapper is used for strftime calls, but only in timedatectl.c.
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 17:29:27 +0000 (12:29 -0500)]
tmpfiles: accurately report creation results
Zbigniew Jędrzejewski-Szmek [Sat, 31 Jan 2015 06:03:09 +0000 (01:03 -0500)]
tmpfiles: remove dead branch
In the test, p is a path to a directory, always absolute. dent->d_name
is a single path component, so they cannot be equal. The comparison
was wrong also for other reasons: D type supports globs, so direct
comparisons using streq are not enough.
Zbigniew Jędrzejewski-Szmek [Sat, 31 Jan 2015 04:54:21 +0000 (23:54 -0500)]
units: set TimeoutSec on some oneshot services
Services which are not crucial to system bootup, and have Type=oneshot
can effectively "hang" the system if they fail to complete for whatever
reason. To allow the boot to continue, kill them after a timeout.
In case of systemd-journal-flush the flush will continue in the background,
and in the other two cases the job will be aborted, but this should not
result in any permanent problem.
Zbigniew Jędrzejewski-Szmek [Sun, 1 Feb 2015 04:03:25 +0000 (23:03 -0500)]
core/cgroup: fix embarrassing typo
https://github.com/docker/docker/issues/10280
Zbigniew Jędrzejewski-Szmek [Sat, 31 Jan 2015 17:25:12 +0000 (12:25 -0500)]
test-dhcp-client: remove linebreak
Tom Gundersen [Sat, 31 Jan 2015 14:27:49 +0000 (15:27 +0100)]
TODO
Tom Gundersen [Fri, 30 Jan 2015 18:54:01 +0000 (19:54 +0100)]
networkd: dhcp-server - start as soon as addresses have been set
We would otherwise wait for the interface to be completely configured, which
could take considerable time with IPv4LL. As a result nspawn was very slow
at obtaining IP addresses.
Tom Gundersen [Thu, 29 Jan 2015 06:34:34 +0000 (07:34 +0100)]
networkd-wait-online: allow specific devices to be ignored
In addition to the loopback device, also explicitly configured devices to be ignored.
Suggested by Charles Devereaux <systemd@guylhem.net>.
Tom Gundersen [Thu, 29 Jan 2015 06:26:58 +0000 (07:26 +0100)]
sd-rtnl: don't fail event handler when callback fails
As in sd-bus, simply log at debug level when a callback fails, but don't fail the event handler.
Otherwise any error returned by any callback will disable the rtnl event handler. We should
only do that on serious internal errors in sd-rtnl that we know cannot be recovered from.
Maxim Mikityanskiy [Thu, 29 Jan 2015 00:23:07 +0000 (01:23 +0100)]
core: make setting the shutdown watchdog configuration via dbus work
https://bugs.freedesktop.org/show_bug.cgi?id=88284
Kay Sievers [Fri, 30 Jan 2015 12:53:45 +0000 (13:53 +0100)]
Revert "sd-bus: change serialization of kdbus messages to qualify in their entirety as gvariant objects"
This breaks booting with kdbus.
This reverts commit
b381de4197157748ed96e469fcc372c23f842ae1.
Kay Sievers [Fri, 30 Jan 2015 09:59:47 +0000 (10:59 +0100)]
Revert "core: make setting the shutdown watchdog configuration via dbus work"
This reverts commit
df6e44c4affced590b0d19c594d9301ffd436591.
systemd --version segfaults.
Starting program: /usr/lib/systemd/systemd --version
Missing separate debuginfos, use: debuginfo-install systemd-216-16.fc21.x86_64
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
systemd 218
+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ -LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD +IDN
Program received signal SIGSEGV, Segmentation fault.
0x000055555557c9be in main (argc=2, argv=0x7fffffffe4d8) at src/core/main.c:1832
1832 arg_shutdown_watchdog = m->shutdown_watchdog;
(gdb) bt
(gdb) bt full
m = 0x0
Carlos Morata Castillo [Sat, 10 Jan 2015 01:08:21 +0000 (02:08 +0100)]
Updates in bash autocompletions
Hi,
I did ./check-undocumented.sh -b (my script just submitted) and checked
the results.
Cheers.
Peter Hutterer [Wed, 28 Jan 2015 04:05:01 +0000 (14:05 +1000)]
hwdb: add a touchpad hwdb
Currently used to tag devices in the new Lenovo *50 series and the X1 Carbon
3rd. These laptops re-introduced the physical trackpoint buttons that were
missing from the *40 series but those buttons are now wired up to the
touchpad.
The touchpad now sends BTN_0, BTN_1 and BTN_2 for the trackpoint. The same
button codes were used in older touchpads that had dedicated scroll up/down
buttons. Input drivers need to work around this and thus know what they're
dealing with.
For the previous gen we introduced INPUT_PROP_TOPBUTTONPAD in the kernel, but
the resulting mess showed that these per-device quirks should really live in
userspace.
The list currently includes the X1 Carbon 3rd PNPID, others will be added as
get to know which PNPID they have.
Zbigniew Jędrzejewski-Szmek [Thu, 29 Jan 2015 02:30:06 +0000 (21:30 -0500)]
systemctl: refuse --host with cat
This might be fixed one day, but for now it's better to fail.
https://bugzilla.redhat.com/show_bug.cgi?id=1186952
Lennart Poettering [Thu, 29 Jan 2015 02:43:34 +0000 (03:43 +0100)]
update TODO
Peter Hutterer [Thu, 29 Jan 2015 01:51:05 +0000 (11:51 +1000)]
Fix ordering of the 70-mouse.rule in the Makefile
Lennart Poettering [Thu, 29 Jan 2015 01:47:29 +0000 (02:47 +0100)]
coredump: drop caps while we are processing the coredump
https://bugs.freedesktop.org/show_bug.cgi?id=87354
Lennart Poettering [Thu, 29 Jan 2015 01:10:15 +0000 (02:10 +0100)]
Revert "journal: do not check for number of files"
This reverts commit
b914ea8d379b446c4c9fac4ba181771676ef38cd.
We really need to put a limit on all our resources, everywhere, and in
particular if we operate on external data.
Hence, let's reintroduce the limit, but bump it substantially, so that
it is guaranteed to be higher than any realistic RLIMIT_NOFILE setting.
Lennart Poettering [Thu, 29 Jan 2015 00:40:48 +0000 (01:40 +0100)]
man: turn new netdev table into a proper table
Maxim Mikityanskiy [Thu, 29 Jan 2015 00:23:07 +0000 (01:23 +0100)]
core: make setting the shutdown watchdog configuration via dbus work
https://bugs.freedesktop.org/show_bug.cgi?id=88284
Tom Gundersen [Wed, 28 Jan 2015 20:31:47 +0000 (21:31 +0100)]
man: netdev - add some minimal explanation to the different netdev kinds and modes
Would be awesome to expand on this a lot, as there is currently no decent documentation for most of these things.
Tom Gundersen [Wed, 28 Jan 2015 16:32:50 +0000 (17:32 +0100)]
networkd: tunnel - call tunnel modes ipip6, not ip4ipv6 to match ip(8)
Martin Pitt [Wed, 28 Jan 2015 17:14:01 +0000 (18:14 +0100)]
logind: handle closing sessions over daemon restarts
It may happen that you have several sessions with the same VT:
- Open a session c1 which leaves some processes around, and log out. The
session will stay in State=closing and become Active=no.
- Log back in on the same VT, get a new session "c2" which is State=active and
Active=yes.
When restarting logind after that, the first session that matches the current
VT becomes Active=yes, which will be c1; c2 thus is Active=no and does not get
the usual polkit/device ACL privileges.
Restore the "closing" state in session_load(), to avoid treating all restored
sessions as State=active. In seat_active_vt_changed(), prefer active sessions
over closing ones if more than one session matches the current VT.
Finally, fix the confusing comment in session_load() and explain it a bit
better.
https://launchpad.net/bugs/1415104
Lennart Poettering [Wed, 28 Jan 2015 16:48:05 +0000 (17:48 +0100)]
util: add comment explaining hostname_is_valid()
Lennart Poettering [Wed, 28 Jan 2015 16:48:01 +0000 (17:48 +0100)]
update TODO
Lennart Poettering [Wed, 28 Jan 2015 16:47:37 +0000 (17:47 +0100)]
sd-dhcp: chop of trailing dot of DHCP supplied host and domain nams
Martin Pitt [Wed, 28 Jan 2015 12:57:47 +0000 (13:57 +0100)]
rules: clean up stale CD drive mounts after ejection
Ejecting a CD with the hardware drive button only causes a change uevent, but
the device node stays around (just without a medium). Pick up these uevents and
mark the device as SYSTEMD_READY=0 on ejection, so that systemd stops the
device unit and consequently all mount units on it.
On media insertion, mark the device as SYSTEMD_READY=1 again.
https://bugs.freedesktop.org/show_bug.cgi?id=72206
https://bugzilla.opensuse.org/show_bug.cgi?id=909418
https://bugs.archlinux.org/task/42071
https://bugs.launchpad.net/bugs/1168742
Martin Pitt [Wed, 28 Jan 2015 12:53:25 +0000 (13:53 +0100)]
core/mount: add dependencies to dynamically mounted mounts too
Add unit dependencies for dynamic (i. e. not from fstab) mounts. With that,
mount units properly bind to their underlying device, and thus get
automatically stopped/unmounted when the underlying device goes away.
This cleans up stale mounts from unplugged devices.
Thanks to Lennart Poettering for pointing out the fix!
Lennart Poettering [Wed, 28 Jan 2015 14:11:49 +0000 (15:11 +0100)]
sysv-generator: no need to check for identical symlinks source and target twice
http://lists.freedesktop.org/archives/systemd-devel/2015-January/027594.html
Lennart Poettering [Wed, 28 Jan 2015 14:07:13 +0000 (15:07 +0100)]
core: output unit status output strings to console, only if we actually are changing unit state
Unit _start() and _stop() implementations can fail with -EAGAIN to delay
execution temporarily. Thus, we should not output status messages before
invoking these calls, but after, and only when we know that the
invocation actually made a change.
Lennart Poettering [Wed, 28 Jan 2015 13:22:13 +0000 (14:22 +0100)]
test: duplicate LIST_FOREACH_OTHERS test to check for corner cases of end and start of list
Lennart Poettering [Wed, 28 Jan 2015 13:03:31 +0000 (14:03 +0100)]
list: properly skip over first item in LIST_FOREACH_OTHERS