platform/upstream/libSkiaSharp.git
11 years agoFix errors when compiling with -Wall -Werror on Android.
djsollen@google.com [Thu, 7 Feb 2013 18:58:35 +0000 (18:58 +0000)]
Fix errors when compiling with -Wall -Werror on Android.

This CL also turns those features on by default on Android

Review URL: https://codereview.appspot.com/7313049

git-svn-id: http://skia.googlecode.com/svn/trunk@7645 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore fixes for ios build.
bsalomon@google.com [Thu, 7 Feb 2013 17:01:39 +0000 (17:01 +0000)]
More fixes for ios build.

git-svn-id: http://skia.googlecode.com/svn/trunk@7643 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to fix iOS build.
bsalomon@google.com [Thu, 7 Feb 2013 16:23:58 +0000 (16:23 +0000)]
Attempt to fix iOS build.

git-svn-id: http://skia.googlecode.com/svn/trunk@7642 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporary patch to BenchPictures gpu timing problem
robertphillips@google.com [Thu, 7 Feb 2013 16:21:22 +0000 (16:21 +0000)]
Temporary patch to BenchPictures gpu timing problem

https://codereview.appspot.com/7311059/

git-svn-id: http://skia.googlecode.com/svn/trunk@7641 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove legacy names no longer referenced in Chrome and WebKit.
bsalomon@google.com [Thu, 7 Feb 2013 14:43:04 +0000 (14:43 +0000)]
Remove legacy names no longer referenced in Chrome and WebKit.
Review URL: https://codereview.appspot.com/7311055

git-svn-id: http://skia.googlecode.com/svn/trunk@7640 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 7 Feb 2013 13:13:41 +0000 (13:13 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7637 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a perf regression introduced by r7594: when computing a texture cache key, use...
senorblanco@chromium.org [Thu, 7 Feb 2013 00:35:25 +0000 (00:35 +0000)]
Fix a perf regression introduced by r7594:  when computing a texture cache key, use the resolved (Top or Bottom) surface origin, never Default, otherwise we never get a cache hit.

Covered by polygon, path benches.  See also:  https://code.google.com/p/chromium/issues/detail?id=174749.

Review URL: https://codereview.appspot.com/7299059

git-svn-id: http://skia.googlecode.com/svn/trunk@7635 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed warning/error in PictureRenderer.cpp
robertphillips@google.com [Thu, 7 Feb 2013 00:13:34 +0000 (00:13 +0000)]
Fixed warning/error in PictureRenderer.cpp

TBR by scroggo@google.com

git-svn-id: http://skia.googlecode.com/svn/trunk@7634 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn picture rendering tools, draw the entire scaled image.
scroggo@google.com [Wed, 6 Feb 2013 22:32:57 +0000 (22:32 +0000)]
In picture rendering tools, draw the entire scaled image.

If --scale is used, limit the size of the image drawn to the
scaled picture size, rather than the original picture size.

BUG=https://code.google.com/p/skia/issues/detail?id=1095

Review URL: https://codereview.appspot.com/7307054

git-svn-id: http://skia.googlecode.com/svn/trunk@7633 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix function not predeclared warning on Mac.
bsalomon@google.com [Wed, 6 Feb 2013 21:44:21 +0000 (21:44 +0000)]
Fix function not predeclared warning on Mac.

TBR=robertphillips@google.com
Review URL: https://codereview.appspot.com/7314048

git-svn-id: http://skia.googlecode.com/svn/trunk@7632 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorver r7626, might trigger for some strange reason a heap corruption
edisonn@google.com [Wed, 6 Feb 2013 21:42:34 +0000 (21:42 +0000)]
rver r7626, might trigger for some strange reason a heap corruption

git-svn-id: http://skia.googlecode.com/svn/trunk@7631 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes a bug introduced by the new per-tile bench log format.
bensong@google.com [Wed, 6 Feb 2013 20:59:14 +0000 (20:59 +0000)]
Fixes a bug introduced by the new per-tile bench log format.
Review URL: https://codereview.appspot.com/7301056

git-svn-id: http://skia.googlecode.com/svn/trunk@7630 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdates gen_skp_ranges.py on recent changes of bench names, storage locations, etc.
bensong@google.com [Wed, 6 Feb 2013 20:51:55 +0000 (20:51 +0000)]
Updates gen_skp_ranges.py on recent changes of bench names, storage locations, etc.
Sample command: bench/gen_skp_ranges.py -r 7621:7621
It is slow due to cloud storage slowness. You can download the bench logs using gsutil and set the -d flag to make it super fast.
Review URL: https://codereview.appspot.com/7307052

git-svn-id: http://skia.googlecode.com/svn/trunk@7629 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for sign mismatch warning/error
robertphillips@google.com [Wed, 6 Feb 2013 20:42:14 +0000 (20:42 +0000)]
Fix for sign mismatch warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@7628 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd overdraw visualization to the debugger
robertphillips@google.com [Wed, 6 Feb 2013 20:13:54 +0000 (20:13 +0000)]
Add overdraw visualization to the debugger

https://codereview.appspot.com/7267043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7627 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a true Set class. Current use case is to be used with Pdf generator.
edisonn@google.com [Wed, 6 Feb 2013 18:54:13 +0000 (18:54 +0000)]
Add a true Set class. Current use case is to be used with Pdf generator.
Review URL: https://codereview.appspot.com/6749054

git-svn-id: http://skia.googlecode.com/svn/trunk@7626 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_STATIC_RECT_VB
bsalomon@google.com [Wed, 6 Feb 2013 18:53:12 +0000 (18:53 +0000)]
Remove GR_STATIC_RECT_VB
Review URL: https://codereview.appspot.com/7304055

git-svn-id: http://skia.googlecode.com/svn/trunk@7625 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm self-tests: generate JSON expectations, in addition to image expectations
epoger@google.com [Wed, 6 Feb 2013 18:41:04 +0000 (18:41 +0000)]
gm self-tests: generate JSON expectations, in addition to image expectations
Review URL: https://codereview.appspot.com/7310050

git-svn-id: http://skia.googlecode.com/svn/trunk@7624 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix WritePixels test on ANGLE.
bsalomon@google.com [Wed, 6 Feb 2013 18:17:50 +0000 (18:17 +0000)]
Fix WritePixels test on ANGLE.

Don't upload BGRA to RGBA if not supported (ES2 w/ EXT BGRA extension).

R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7305046

git-svn-id: http://skia.googlecode.com/svn/trunk@7622 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn --timeIndividualTiles back on in bench_pictures
borenet@google.com [Wed, 6 Feb 2013 16:27:38 +0000 (16:27 +0000)]
Turn --timeIndividualTiles back on in bench_pictures
Review URL: https://codereview.appspot.com/7299049

git-svn-id: http://skia.googlecode.com/svn/trunk@7620 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger builds after master restart
borenet@google.com [Wed, 6 Feb 2013 16:08:05 +0000 (16:08 +0000)]
Whitespace change to trigger builds after master restart

git-svn-id: http://skia.googlecode.com/svn/trunk@7618 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSet vertex layout prior to setVertexSourceToBuffer for GR_STATIC_RECT_VB
jvanverth@google.com [Wed, 6 Feb 2013 13:45:11 +0000 (13:45 +0000)]
Set vertex layout prior to setVertexSourceToBuffer for GR_STATIC_RECT_VB

git-svn-id: http://skia.googlecode.com/svn/trunk@7612 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSmall code cleaup: remove redundant if
edisonn@google.com [Wed, 6 Feb 2013 13:43:58 +0000 (13:43 +0000)]
Small code cleaup: remove redundant if
unreviewd, comment from previous cl

git-svn-id: http://skia.googlecode.com/svn/trunk@7611 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck for self-assignment in operator=
reed@google.com [Wed, 6 Feb 2013 12:47:14 +0000 (12:47 +0000)]
check for self-assignment in operator=

git-svn-id: http://skia.googlecode.com/svn/trunk@7610 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 6 Feb 2013 07:01:54 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7608 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotweak to spacing, to trigger build
mike@reedtribe.org [Wed, 6 Feb 2013 03:43:57 +0000 (03:43 +0000)]
tweak to spacing, to trigger build

git-svn-id: http://skia.googlecode.com/svn/trunk@7607 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf the stack is too deep we could get Stack Overflow in pdf's ContentEntry's destructor.
edisonn@google.com [Tue, 5 Feb 2013 23:13:39 +0000 (23:13 +0000)]
If the stack is too deep we could get Stack Overflow in pdf's ContentEntry's destructor.
Review URL: https://codereview.appspot.com/7313045

git-svn-id: http://skia.googlecode.com/svn/trunk@7605 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix calls to setVertexSourceToBuffer
robertphillips@google.com [Tue, 5 Feb 2013 22:55:18 +0000 (22:55 +0000)]
Fix calls to setVertexSourceToBuffer

git-svn-id: http://skia.googlecode.com/svn/trunk@7604 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bench crash (calling method on NULL object).
bsalomon@google.com [Tue, 5 Feb 2013 21:32:06 +0000 (21:32 +0000)]
Fix bench crash (calling method on NULL object).
Review URL: https://codereview.appspot.com/7305048

git-svn-id: http://skia.googlecode.com/svn/trunk@7603 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReinstate r7546: fix unused variable warning
jvanverth@google.com [Tue, 5 Feb 2013 21:05:04 +0000 (21:05 +0000)]
Reinstate r7546: fix unused variable warning

https://codereview.appspot.com/7309051

git-svn-id: http://skia.googlecode.com/svn/trunk@7602 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImproved compartmentalization of filter tool's optimizations & add new optimization
robertphillips@google.com [Tue, 5 Feb 2013 20:51:49 +0000 (20:51 +0000)]
Improved compartmentalization of filter tool's optimizations & add new optimization

https://codereview.appspot.com/7294049/

git-svn-id: http://skia.googlecode.com/svn/trunk@7601 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove vertex layout from GeometrySrcState to GrDrawState.
jvanverth@google.com [Tue, 5 Feb 2013 20:33:30 +0000 (20:33 +0000)]
Move vertex layout from GeometrySrcState to GrDrawState.

Also adds AutoStateRestore member to AutoGeometryPush to push DrawState as well
as GeometrySrcState. And removed vertex layout as an argument to a number of
functions -- they will get vertex layout info from the current DrawState.

Review URL: https://codereview.appspot.com/7286047

git-svn-id: http://skia.googlecode.com/svn/trunk@7600 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix master IP in submit_try
borenet@google.com [Tue, 5 Feb 2013 20:26:31 +0000 (20:26 +0000)]
Fix master IP in submit_try

Unreviewed.  Should have this reference:
http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7314045

git-svn-id: http://skia.googlecode.com/svn/trunk@7598 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7595 due to housekeeper warning-as-error.
bsalomon@google.com [Tue, 5 Feb 2013 20:09:41 +0000 (20:09 +0000)]
Revert r7595 due to housekeeper warning-as-error.

git-svn-id: http://skia.googlecode.com/svn/trunk@7596 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-enable static asserts with windows warning fix.
bsalomon@google.com [Tue, 5 Feb 2013 20:04:38 +0000 (20:04 +0000)]
Re-enable static asserts with windows warning fix.

git-svn-id: http://skia.googlecode.com/svn/trunk@7595 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement support for origin-TopLeft render targets. Note that the default behaviour...
senorblanco@chromium.org [Tue, 5 Feb 2013 19:50:46 +0000 (19:50 +0000)]
Implement support for origin-TopLeft render targets. Note that the default behaviour remains the same:  textures default to origin-TopLeft, render targets default to origin-BottomLeft, and backend textures default to origin-BottomLeft. However, the caller can override the default by setting fOrigin in GrTextureDesc, GrBackendTextureDesc or GrBackendRenderTargetDesc.

Review URL: https://codereview.appspot.com/7230049

git-svn-id: http://skia.googlecode.com/svn/trunk@7594 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for issue 1029: Debugger opens files with ^O, but crashes when opening files...
jvanverth@google.com [Tue, 5 Feb 2013 19:44:07 +0000 (19:44 +0000)]
Fix for issue 1029: Debugger opens files with ^O, but crashes when opening files through other methods

Don't append leading '/' if path is local

git-svn-id: http://skia.googlecode.com/svn/trunk@7593 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement support for origin-TopLeft render targets in GL backend.
scroggo@google.com [Tue, 5 Feb 2013 19:22:27 +0000 (19:22 +0000)]
Implement support for origin-TopLeft render targets in GL backend.

Committed: https://code.google.com/p/skia/source/detail?r=7545

Reverted in r7571; re-opening.

Review URL: https://codereview.appspot.com/7230049

git-svn-id: http://skia.googlecode.com/svn/trunk@7592 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix some 64 bit warnings on mac.
scroggo@google.com [Tue, 5 Feb 2013 18:49:00 +0000 (18:49 +0000)]
Fix some 64 bit warnings on mac.

SkAAClip:
Change fDataSize to a size_t, since that is how it is used in all
cases.

SkAlphaRuns.cpp:
Use SkToS32 when subtracting a pointer from another pointer to
return an int.

BUG=http://code.google.com/p/skia/issues/detail?id=1103

Review URL: https://codereview.appspot.com/7314043

git-svn-id: http://skia.googlecode.com/svn/trunk@7591 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix unbalanced Shader set/endContext calls in drawVertices
djsollen@google.com [Tue, 5 Feb 2013 17:00:02 +0000 (17:00 +0000)]
Fix unbalanced Shader set/endContext calls in drawVertices

Review URL: https://codereview.appspot.com/7309047

git-svn-id: http://skia.googlecode.com/svn/trunk@7588 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agohide the static-assert block altogether, until we can find a construct that
reed@google.com [Tue, 5 Feb 2013 16:42:28 +0000 (16:42 +0000)]
hide the static-assert block altogether, until we can find a construct that
doesn't have warngs on mac or windows

git-svn-id: http://skia.googlecode.com/svn/trunk@7586 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix (new annoying) warning (mac only I think)
reed@google.com [Tue, 5 Feb 2013 16:18:20 +0000 (16:18 +0000)]
fix (new annoying) warning (mac only I think)

git-svn-id: http://skia.googlecode.com/svn/trunk@7583 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake windows GrGLCreateNatriveInterface not us GL.h and not use linker to resolve...
bsalomon@google.com [Tue, 5 Feb 2013 16:14:15 +0000 (16:14 +0000)]
Make windows GrGLCreateNatriveInterface not us GL.h and not use linker to resolve gl functions. Instead load the GL library and use GetProcAddress.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7308047

git-svn-id: http://skia.googlecode.com/svn/trunk@7582 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoActually fix angle GLPrograms test.
bsalomon@google.com [Tue, 5 Feb 2013 15:44:21 +0000 (15:44 +0000)]
Actually fix angle GLPrograms test.

git-svn-id: http://skia.googlecode.com/svn/trunk@7578 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRestore variable to release builds.
jvanverth@google.com [Tue, 5 Feb 2013 14:15:31 +0000 (14:15 +0000)]
Restore variable to release builds.

git-svn-id: http://skia.googlecode.com/svn/trunk@7572 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r7545 (render target origin change) due to layout test issues (see https...
robertphillips@google.com [Tue, 5 Feb 2013 14:05:06 +0000 (14:05 +0000)]
Reverting r7545 (render target origin change) due to layout test issues (see https://codereview.chromium.org/12210002/)

git-svn-id: http://skia.googlecode.com/svn/trunk@7571 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 5 Feb 2013 07:02:01 +0000 (07:02 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7567 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove define for SK_IGNORE_GRADIENT_DITHER_FIX to trigger rebaselines
mike@reedtribe.org [Tue, 5 Feb 2013 02:58:00 +0000 (02:58 +0000)]
remove define for SK_IGNORE_GRADIENT_DITHER_FIX to trigger rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@7564 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNuke SkSingleInputImageFilter. 99% of its functionality was refactored into SkImageF...
senorblanco@chromium.org [Mon, 4 Feb 2013 22:57:21 +0000 (22:57 +0000)]
Nuke SkSingleInputImageFilter.  99% of its functionality was refactored into SkImageFilterUtils in https://code.google.com/p/skia/source/detail?r=7467, so it has outlived its usefulness.

Review URL: https://codereview.appspot.com/7277055

git-svn-id: http://skia.googlecode.com/svn/trunk@7563 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkToS32 to turn a ptrdiff_t into an int (on 64bit build)
reed@google.com [Mon, 4 Feb 2013 22:40:28 +0000 (22:40 +0000)]
use SkToS32 to turn a ptrdiff_t into an int (on 64bit build)

git-svn-id: http://skia.googlecode.com/svn/trunk@7562 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse XQuartz's version of OSMesa rather than Mac SDK's. It is newer and has a fix...
bsalomon@google.com [Mon, 4 Feb 2013 22:17:13 +0000 (22:17 +0000)]
Use XQuartz's version of OSMesa rather than Mac SDK's. It is newer and has a fix for a bug that unit tests and GM trigger.

git-svn-id: http://skia.googlecode.com/svn/trunk@7561 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove vestiges of 32BIT_GRADIENT flag, as we always dither gradients now
reed@google.com [Mon, 4 Feb 2013 21:03:11 +0000 (21:03 +0000)]
remove vestiges of 32BIT_GRADIENT flag, as we always dither gradients now
(even in chrome)
Review URL: https://codereview.appspot.com/7281049

git-svn-id: http://skia.googlecode.com/svn/trunk@7558 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd kMultiply_Mode to switch statement (fix warning)
reed@google.com [Mon, 4 Feb 2013 20:46:08 +0000 (20:46 +0000)]
add kMultiply_Mode to switch statement (fix warning)

git-svn-id: http://skia.googlecode.com/svn/trunk@7556 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoland https://codereview.appspot.com/7221086/ -- add Multiply xfermode matching CSS...
reed@google.com [Mon, 4 Feb 2013 20:06:00 +0000 (20:06 +0000)]
land https://codereview.appspot.com/7221086/ -- add Multiply xfermode matching CSS spec

git-svn-id: http://skia.googlecode.com/svn/trunk@7553 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSimplify and speed up SkIntroSort.
bungeman@google.com [Mon, 4 Feb 2013 19:54:15 +0000 (19:54 +0000)]
Simplify and speed up SkIntroSort.
https://codereview.appspot.com/7273048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7552 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCommit file missing from r7550
bsalomon@google.com [Mon, 4 Feb 2013 18:46:49 +0000 (18:46 +0000)]
Commit file missing from r7550

git-svn-id: http://skia.googlecode.com/svn/trunk@7551 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to fix GLPrograms test on ANGLE bot.
bsalomon@google.com [Mon, 4 Feb 2013 18:39:24 +0000 (18:39 +0000)]
Attempt to fix GLPrograms test on ANGLE bot.

R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7281050

git-svn-id: http://skia.googlecode.com/svn/trunk@7550 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGo from a 1x2 to a 2x2 dither cell, and change/simplify the logic for how we
reed@google.com [Mon, 4 Feb 2013 18:21:23 +0000 (18:21 +0000)]
Go from a 1x2 to a 2x2 dither cell, and change/simplify the logic for how we
compute the "dithered" version of a color to just a graduated fixed-point-round.
Also, add this new dither to conical and sweep, which before had no dithering.

Disabled for now using SK_IGNORE_GRADIENT_DITHER_FIX. Will enable this and
and rebaseline skia.

http://code.google.com/p/skia/issues/detail?id=1098
Review URL: https://codereview.appspot.com/7248046

git-svn-id: http://skia.googlecode.com/svn/trunk@7549 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoextend gradient_create bench to test opaque and alpha gradient ramps
reed@google.com [Mon, 4 Feb 2013 18:09:58 +0000 (18:09 +0000)]
extend gradient_create bench to test opaque and alpha gradient ramps

git-svn-id: http://skia.googlecode.com/svn/trunk@7548 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocleanup: use DEF_BENCH macro
reed@google.com [Mon, 4 Feb 2013 18:00:54 +0000 (18:00 +0000)]
cleanup: use DEF_BENCH macro

git-svn-id: http://skia.googlecode.com/svn/trunk@7547 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix unused variable warning
reed@google.com [Mon, 4 Feb 2013 17:59:02 +0000 (17:59 +0000)]
fix unused variable warning

git-svn-id: http://skia.googlecode.com/svn/trunk@7546 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement support for origin-TopLeft render targets in GL backend.
senorblanco@chromium.org [Mon, 4 Feb 2013 17:29:51 +0000 (17:29 +0000)]
Implement support for origin-TopLeft render targets in GL backend.

Review URL: https://codereview.appspot.com/7230049

git-svn-id: http://skia.googlecode.com/svn/trunk@7545 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd new gms for shallow_gradient, in preparation for improving their quality
reed@google.com [Mon, 4 Feb 2013 16:56:15 +0000 (16:56 +0000)]
add new gms for shallow_gradient, in preparation for improving their quality

git-svn-id: http://skia.googlecode.com/svn/trunk@7544 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange comment to avoid warning (don't end line comment with '\').
bungeman@google.com [Mon, 4 Feb 2013 16:24:44 +0000 (16:24 +0000)]
Change comment to avoid warning (don't end line comment with '\').

git-svn-id: http://skia.googlecode.com/svn/trunk@7542 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Mon, 4 Feb 2013 16:22:06 +0000 (16:22 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7541 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GPU unit tests use GrContexts of different GL types.
bsalomon@google.com [Mon, 4 Feb 2013 16:13:32 +0000 (16:13 +0000)]
Make GPU unit tests use GrContexts of different GL types.
Review URL: https://codereview.appspot.com/7281046

git-svn-id: http://skia.googlecode.com/svn/trunk@7540 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd sk_ignore_unused_variable to avoid warnings.
bungeman@google.com [Mon, 4 Feb 2013 15:58:08 +0000 (15:58 +0000)]
Add sk_ignore_unused_variable to avoid warnings.
https://codereview.appspot.com/7218045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7539 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd benchmark for stroked drawRect/drawOval/drawRRect, to prepare for optimizing
reed@google.com [Mon, 4 Feb 2013 14:57:28 +0000 (14:57 +0000)]
add benchmark for stroked drawRect/drawOval/drawRRect, to prepare for optimizing
those based on special-casing stroking for single-contour-convex shapes.

git-svn-id: http://skia.googlecode.com/svn/trunk@7537 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 4 Feb 2013 14:06:49 +0000 (14:06 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7535 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Mon, 4 Feb 2013 12:57:42 +0000 (12:57 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7533 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove kStyleCount out of Style enum, and into its own, to avoid
mike@reedtribe.org [Mon, 4 Feb 2013 05:17:10 +0000 (05:17 +0000)]
move kStyleCount out of Style enum, and into its own, to avoid
1. someone passing kStyleCount as a parameter
2. warnings about not handling all enum values in a switch

We should probably move to remove kCountFoo from all of our enums for these reasons.

git-svn-id: http://skia.googlecode.com/svn/trunk@7532 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH macro
mike@reedtribe.org [Mon, 4 Feb 2013 05:05:36 +0000 (05:05 +0000)]
use DEF_BENCH macro

git-svn-id: http://skia.googlecode.com/svn/trunk@7531 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Sun, 3 Feb 2013 21:04:27 +0000 (21:04 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7530 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAccelerate handling of clipRRect in calls to SkPictureUtils::GatherPixelRefs
junov@chromium.org [Fri, 1 Feb 2013 20:39:48 +0000 (20:39 +0000)]
Accelerate handling of clipRRect in calls to SkPictureUtils::GatherPixelRefs

BUG=https://code.google.com/p/chromium/issues/detail?id=173718
Review URL: https://codereview.appspot.com/7252048

git-svn-id: http://skia.googlecode.com/svn/trunk@7527 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: report max-pixel-error if comparing against PNG files (not checksums)
epoger@google.com [Fri, 1 Feb 2013 20:39:15 +0000 (20:39 +0000)]
gm: report max-pixel-error if comparing against PNG files (not checksums)
Review URL: https://codereview.appspot.com/7241064

git-svn-id: http://skia.googlecode.com/svn/trunk@7526 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove dither toggle logic into common helper functions, to make it easier to
reed@google.com [Fri, 1 Feb 2013 19:34:59 +0000 (19:34 +0000)]
Move dither toggle logic into common helper functions, to make it easier to
change their behavior later. No functional change.
Review URL: https://codereview.appspot.com/7241063

git-svn-id: http://skia.googlecode.com/svn/trunk@7525 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agolanding https://codereview.appspot.com/7225077/ -- tweak for GIF 5.x api
reed@google.com [Fri, 1 Feb 2013 19:05:48 +0000 (19:05 +0000)]
landing https://codereview.appspot.com/7225077/ -- tweak for GIF 5.x api

git-svn-id: http://skia.googlecode.com/svn/trunk@7523 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix init order warning
bsalomon@google.com [Fri, 1 Feb 2013 18:42:50 +0000 (18:42 +0000)]
Fix init order warning

git-svn-id: http://skia.googlecode.com/svn/trunk@7522 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove the kMultiply_Mode alias for kModulate_Mode. We plan to re-target kMultiply_Mode
reed@google.com [Fri, 1 Feb 2013 16:44:50 +0000 (16:44 +0000)]
remove the kMultiply_Mode alias for kModulate_Mode. We plan to re-target kMultiply_Mode
in the future, to match the CSS spec.

git-svn-id: http://skia.googlecode.com/svn/trunk@7518 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPrevent SkPictureUtils::GatherPixelRefs from generating bitmaps from gradient
junov@google.com [Fri, 1 Feb 2013 16:41:47 +0000 (16:41 +0000)]
Prevent SkPictureUtils::GatherPixelRefs from generating bitmaps from gradient
shaders.

BUG=https://code.google.com/p/chromium/issues/detail?id=173657
Review URL: https://codereview.appspot.com/7220074

git-svn-id: http://skia.googlecode.com/svn/trunk@7517 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly support SkPicture abort for Android due to the fragility of the existing API
djsollen@google.com [Fri, 1 Feb 2013 16:18:09 +0000 (16:18 +0000)]
Only support SkPicture abort for Android due to the fragility of the existing API

Review URL: https://codereview.appspot.com/7225083

git-svn-id: http://skia.googlecode.com/svn/trunk@7515 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix android errors when unflattening an SkImageRef_ashmem object.
djsollen@google.com [Fri, 1 Feb 2013 15:57:13 +0000 (15:57 +0000)]
Fix android errors when unflattening an SkImageRef_ashmem object.

Review URL: https://codereview.appspot.com/7228071

git-svn-id: http://skia.googlecode.com/svn/trunk@7514 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix unused var warning-as-error
bsalomon@google.com [Fri, 1 Feb 2013 15:42:59 +0000 (15:42 +0000)]
Fix unused var warning-as-error

git-svn-id: http://skia.googlecode.com/svn/trunk@7513 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't use NULL when comparing against ints/size_t (fixes warning)
reed@google.com [Fri, 1 Feb 2013 15:05:18 +0000 (15:05 +0000)]
don't use NULL when comparing against ints/size_t (fixes warning)

git-svn-id: http://skia.googlecode.com/svn/trunk@7512 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd width() and height() helpers
reed@google.com [Fri, 1 Feb 2013 15:01:24 +0000 (15:01 +0000)]
add width() and height() helpers

git-svn-id: http://skia.googlecode.com/svn/trunk@7511 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert name changes to SkBlendImageFilter. It (correctly) named its enum kMultiply_Mode,
reed@google.com [Fri, 1 Feb 2013 14:35:09 +0000 (14:35 +0000)]
revert name changes to SkBlendImageFilter. It (correctly) named its enum kMultiply_Mode,
and handled that itself internally, rather than calling SkXfermode. This CL removes
the kModulate_Mode alias from its list.

git-svn-id: http://skia.googlecode.com/svn/trunk@7509 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake drawIndexedInstances non-virtual and rewrite GrIODB's drawRect on top of drawInd...
bsalomon@google.com [Fri, 1 Feb 2013 14:19:27 +0000 (14:19 +0000)]
Make drawIndexedInstances non-virtual and rewrite GrIODB's drawRect on top of drawIndexedInstances.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7221078

git-svn-id: http://skia.googlecode.com/svn/trunk@7508 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.
rmistry@google.com [Fri, 1 Feb 2013 14:12:49 +0000 (14:12 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7507 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorestore cache-count for gradients to p.o.2. so we can perform fancier dithering
reed@google.com [Fri, 1 Feb 2013 12:59:40 +0000 (12:59 +0000)]
restore cache-count for gradients to p.o.2. so we can perform fancier dithering
in the future.
Review URL: https://codereview.appspot.com/7254043

git-svn-id: http://skia.googlecode.com/svn/trunk@7506 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange vertex buffer allocator functions to take size rather than layout, take two.
jvanverth@google.com [Thu, 31 Jan 2013 21:34:25 +0000 (21:34 +0000)]
Change vertex buffer allocator functions to take size rather than layout, take two.
Resubmission of r7498.

https://codereview.appspot.com/7228078

git-svn-id: http://skia.googlecode.com/svn/trunk@7501 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix warnings resulting from 7496.
bungeman@google.com [Thu, 31 Jan 2013 20:36:30 +0000 (20:36 +0000)]
Fix warnings resulting from 7496.

git-svn-id: http://skia.googlecode.com/svn/trunk@7500 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 31 Jan 2013 20:28:24 +0000 (20:28 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7499 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange vertex buffer allocator functions to take size rather than layout.
jvanverth@google.com [Thu, 31 Jan 2013 20:15:36 +0000 (20:15 +0000)]
Change vertex buffer allocator functions to take size rather than layout.

https://codereview.appspot.com/7228078

git-svn-id: http://skia.googlecode.com/svn/trunk@7498 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SHA1 and MD5 to utils.
bungeman@google.com [Thu, 31 Jan 2013 19:47:48 +0000 (19:47 +0000)]
Add SHA1 and MD5 to utils.
https://codereview.appspot.com/7071055/

git-svn-id: http://skia.googlecode.com/svn/trunk@7496 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded cast to make SkIntToScalar happy with size_t in debug (in SkDrawCommand.cpp)
robertphillips@google.com [Thu, 31 Jan 2013 16:52:43 +0000 (16:52 +0000)]
Added cast to make SkIntToScalar happy with size_t in debug (in SkDrawCommand.cpp)

git-svn-id: http://skia.googlecode.com/svn/trunk@7495 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoved unused variable
robertphillips@google.com [Thu, 31 Jan 2013 16:45:43 +0000 (16:45 +0000)]
Removed unused variable

git-svn-id: http://skia.googlecode.com/svn/trunk@7494 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: force all pixels opaque earlier in the process
epoger@google.com [Thu, 31 Jan 2013 16:30:55 +0000 (16:30 +0000)]
gm: force all pixels opaque earlier in the process
Review URL: https://codereview.appspot.com/7251043

git-svn-id: http://skia.googlecode.com/svn/trunk@7493 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate filter tool to allow more flexible filtering
robertphillips@google.com [Thu, 31 Jan 2013 15:56:22 +0000 (15:56 +0000)]
Update filter tool to allow more flexible filtering

https://codereview.appspot.com/7227055/

git-svn-id: http://skia.googlecode.com/svn/trunk@7492 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooptimize region::intersect when one wholly contains the other
reed@google.com [Thu, 31 Jan 2013 15:24:24 +0000 (15:24 +0000)]
optimize region::intersect when one wholly contains the other

clone of https://codereview.appspot.com/7237055/

git-svn-id: http://skia.googlecode.com/svn/trunk@7491 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd new test for region::intersect, when one is a rect, and it wholly contains
reed@google.com [Thu, 31 Jan 2013 15:23:44 +0000 (15:23 +0000)]
add new test for region::intersect, when one is a rect, and it wholly contains
a complex region.

git-svn-id: http://skia.googlecode.com/svn/trunk@7490 2bbb7eff-a529-9590-31e7-b0007b416f81