David Schleef [Thu, 24 Feb 2011 01:25:03 +0000 (17:25 -0800)]
aacparse: allow parsed frames on sink pad
David Schleef [Wed, 13 Oct 2010 23:12:02 +0000 (16:12 -0700)]
tests: fix baseparse test
David Schleef [Wed, 13 Oct 2010 22:39:55 +0000 (15:39 -0700)]
baseparse: Create baseparse library
Mark Nauwelaerts [Mon, 7 Feb 2011 13:46:57 +0000 (14:46 +0100)]
baseparse: tune QUERY_SEEKING response
Even if we currently do not have a duration yet, assume seekable if
it looks like we'll likely be able to determine it later on
(which coincides with needed information to perform seeking).
Fixes #641047.
Arun Raghavan [Tue, 8 Feb 2011 18:09:24 +0000 (23:39 +0530)]
baseparse: Update min/max bitrate before first posting them
This avoids posting an initial min-bitrate of G_UINTMAX and max-bitrate
of 0.
https://bugzilla.gnome.org/show_bug.cgi?id=641857
Arun Raghavan [Tue, 8 Feb 2011 18:20:13 +0000 (23:50 +0530)]
mpegaudioparse: Post CBR bitrate as nominal bitrate
Even if VBR headers are missing, we can't guarantee that a stream is in
fact a CBR stream, so it's safer to let baseparse calculate the average
bitrate rather than assume a CBR stream. However, in order to make
/some/ metadata available before the requisite number of frames have
been parsed, this posts the bitrate from the non-VBR headers as the
nominal bitrate.
https://bugzilla.gnome.org/show_bug.cgi?id=641858
Mark Nauwelaerts [Mon, 6 Sep 2010 12:10:11 +0000 (14:10 +0200)]
amrparse: a valid amr-wb frame should not have reserved frame type index
See #639715.
Mark Nauwelaerts [Thu, 27 Jan 2011 15:52:34 +0000 (16:52 +0100)]
ac3parse: improve handling of dependent substream frames
In particular, timestamps of these should track main-stream timestamps.
Mark Nauwelaerts [Fri, 21 Jan 2011 13:53:39 +0000 (14:53 +0100)]
baseparse: tune default duration estimate update interval
Rather than a fixed default frame count, estimate frame count to aim for
an interval duration depending on fps if available, otherwise use old
fixed default.
Mark Nauwelaerts [Fri, 14 Jan 2011 14:16:04 +0000 (15:16 +0100)]
baseparse: reverse playback; mind keyframes for fragment boundary
Mark Nauwelaerts [Thu, 13 Jan 2011 14:26:21 +0000 (15:26 +0100)]
amrparse: properly check for sufficient available data prior to access
Mark Nauwelaerts [Wed, 12 Jan 2011 13:40:37 +0000 (14:40 +0100)]
baseparse: ensure non-empty candidate frames
Mark Nauwelaerts [Tue, 11 Jan 2011 14:24:23 +0000 (15:24 +0100)]
baseparse: clarify some debug statements
Mark Nauwelaerts [Tue, 11 Jan 2011 14:24:02 +0000 (15:24 +0100)]
baseparse: properly track upstream timestamps
... rather than with a delay.
Mark Nauwelaerts [Tue, 11 Jan 2011 14:23:29 +0000 (15:23 +0100)]
baseparse: need proper frame duration to obtain sensible frame bitrate
Mark Nauwelaerts [Tue, 11 Jan 2011 14:22:51 +0000 (15:22 +0100)]
baseparse: proper initial values for index tracking variables
Mark Nauwelaerts [Tue, 11 Jan 2011 11:05:13 +0000 (12:05 +0100)]
baseparse: arrange for consistent event handling
Mark Nauwelaerts [Mon, 10 Jan 2011 15:59:59 +0000 (16:59 +0100)]
baseparse: header style cleaning
Mark Nauwelaerts [Mon, 10 Jan 2011 16:07:38 +0000 (17:07 +0100)]
baseparse: provide some more initial frame metadata in parse_frame
... and document accordingly.
Mark Nauwelaerts [Mon, 10 Jan 2011 15:56:36 +0000 (16:56 +0100)]
baseparse: refactor passthrough into format flags
Also add a format flag to signal baseparse that subclass/format can provide
(parsed) timestamp rather than an estimated one. In particular, such "strong"
timestamp then allows to e.g. determine duration.
Mark Nauwelaerts [Mon, 10 Jan 2011 14:34:48 +0000 (15:34 +0100)]
baseparse: introduce a baseparse frame to serve as context
... and adjust subclass parsers accordingly
Mark Nauwelaerts [Fri, 7 Jan 2011 15:39:51 +0000 (16:39 +0100)]
baseparse: restrict duration scanning to pull mode and avoid extra set_caps call
Mark Nauwelaerts [Fri, 7 Jan 2011 14:58:49 +0000 (15:58 +0100)]
baseparse: update some documentation
Also add some more debug.
Mark Nauwelaerts [Thu, 6 Jan 2011 10:41:44 +0000 (11:41 +0100)]
baseparse: allow increasing min_size for current frame parsing only
Also check that subclass actually either directs to skip bytes or
increases expected frame size to avoid going nowhere in bogus
indefinite looping.
Mark Nauwelaerts [Fri, 14 Jan 2011 14:26:37 +0000 (15:26 +0100)]
baesparse: fix refactor regression in loop based parsing
Mark Nauwelaerts [Thu, 6 Jan 2011 10:16:56 +0000 (11:16 +0100)]
baseparse: pass all available data to subclass rather than minimum
Also reduce some adapter calls and add a few debug statements.
Mark Nauwelaerts [Fri, 10 Dec 2010 14:59:49 +0000 (15:59 +0100)]
baseparse: fix reverse playback handling
Mark Nauwelaerts [Fri, 10 Dec 2010 13:56:13 +0000 (14:56 +0100)]
baseparse: minor typo and debug statement cleanup
Mark Nauwelaerts [Fri, 10 Dec 2010 13:40:05 +0000 (14:40 +0100)]
baseparse: reduce locking
... which is either already mute and/or implicitly handled by STREAM_LOCK.
Mark Nauwelaerts [Fri, 14 Jan 2011 13:08:38 +0000 (14:08 +0100)]
baseparse: avoid loop in frame locating interpolation
Mark Nauwelaerts [Wed, 19 Jan 2011 17:26:30 +0000 (18:26 +0100)]
flacparse: mind gst_buffer_unref not liking NULL
Fixes #639950.
Thiago Santos [Fri, 14 Jan 2011 19:30:11 +0000 (16:30 -0300)]
audioparsers: baseparse: Be careful to not lose the event ref
Don't unref the event if it hasn't been handled, because the caller
assumes it is still valid and might reuse it.
I ran into this problem when transcoding an AVI (with mp3 inside)
to gpp.
https://bugzilla.gnome.org/show_bug.cgi?id=639555
Tim-Philipp Müller [Thu, 13 Jan 2011 17:10:13 +0000 (17:10 +0000)]
dcaparse: fix sync word for 14-bit little endian coding
Fix copy'n'paste bug that made us look for the raw little endian
sync word twice instead of looking for the 14-bit LE sync word
as well. Fixes parsing of such streams (see #636234 for sample file).
Tim-Philipp Müller [Thu, 13 Jan 2011 16:27:04 +0000 (16:27 +0000)]
docs: minor baseparse docs/comment fixes
Remove copy'n'paste leftovers.
Edward Hervey [Thu, 6 Jan 2011 11:49:43 +0000 (12:49 +0100)]
flacparse: Fix unitialized variable on macosx
Mark Nauwelaerts [Mon, 13 Dec 2010 14:17:29 +0000 (15:17 +0100)]
ac3parse: relax bsid checking
... to the widest possible spec interpretation.
Fixes #637062.
Mark Nauwelaerts [Fri, 3 Dec 2010 17:11:56 +0000 (18:11 +0100)]
audioparsers: update some documentation
Mark Nauwelaerts [Fri, 3 Dec 2010 17:11:38 +0000 (18:11 +0100)]
mpegaudioparse: add to documentation
Mark Nauwelaerts [Fri, 3 Dec 2010 17:11:09 +0000 (18:11 +0100)]
dcaparse: add to documentation
Mark Nauwelaerts [Mon, 8 Nov 2010 18:58:31 +0000 (19:58 +0100)]
baseparse: increase keyframe awareness
... which is not particular relevant for audio parsing, but more so
in video cases. In particular, auto-determine if dealing with video (caps).
Mark Nauwelaerts [Wed, 1 Dec 2010 14:28:53 +0000 (15:28 +0100)]
ac3parse: use proper EAC-3 caps
Mark Nauwelaerts [Tue, 30 Nov 2010 14:41:02 +0000 (15:41 +0100)]
baseparse: avoid unexpected stray metadata
Mark Nauwelaerts [Tue, 30 Nov 2010 14:40:28 +0000 (15:40 +0100)]
baseparse: use proper _NONE output value when applicable
Edward Hervey [Thu, 25 Nov 2010 17:56:42 +0000 (18:56 +0100)]
audioparsers: Remove dead assignments
Andoni Morales Alastruey [Thu, 25 Nov 2010 16:14:23 +0000 (17:14 +0100)]
audioparse: fix possible division-by-zero
https://bugzilla.gnome.org/show_bug.cgi?id=635786
Mark Nauwelaerts [Wed, 17 Nov 2010 15:23:42 +0000 (16:23 +0100)]
baseparse: use correct offset when adding index entry
... bearing in mind that BUFFER_OFFSET is media specific and may not
reflect the basic offset after having been parsed.
Mark Nauwelaerts [Wed, 17 Nov 2010 13:30:09 +0000 (14:30 +0100)]
baseparse: enhancements for timestamp marked framed formats
That is, as such formats allow subclass to extract position from frame,
it is possible to extract duration (if not otherwise provided)
from (near) last frame, and a seek can fairly accurately target the required
position.
Fixes #631389.
Mark Nauwelaerts [Tue, 16 Nov 2010 16:06:14 +0000 (17:06 +0100)]
baseparse: refactor frame scanning peformed by _loop
Mark Nauwelaerts [Tue, 16 Nov 2010 17:04:00 +0000 (18:04 +0100)]
baseparse: slightly optimize sending of pending newsegment events
Mark Nauwelaerts [Tue, 16 Nov 2010 16:04:35 +0000 (17:04 +0100)]
baseparse: minor fixes and enhancements
Arrange for upstream as well as downstream flushing when seeking.
Also determine upstream size as well as seekability. Adjust some comments
to reality and employ debug statement in proper order.
Mark Nauwelaerts [Wed, 17 Nov 2010 14:33:36 +0000 (15:33 +0100)]
aacparse: minor cleanups
Mark Nauwelaerts [Wed, 17 Nov 2010 14:24:37 +0000 (15:24 +0100)]
aacparse: fix regression in ADIF src caps setting
Mark Nauwelaerts [Tue, 16 Nov 2010 11:11:53 +0000 (12:11 +0100)]
flacparse: parse seektable
Fixes #631389 (partially).
Mark Nauwelaerts [Tue, 16 Nov 2010 11:08:54 +0000 (12:08 +0100)]
flacparse: minor refactor and enable default baseparse segment clipping
Mark Nauwelaerts [Tue, 9 Nov 2010 18:38:25 +0000 (19:38 +0100)]
mpegaudioparse: fix silly leak in _reset
Mark Nauwelaerts [Fri, 29 Oct 2010 12:08:58 +0000 (14:08 +0200)]
baseparse: use only upstream duration if it provides one
Mark Nauwelaerts [Mon, 25 Oct 2010 12:15:50 +0000 (14:15 +0200)]
baseparse: reflow update_bitrate code
... which makes local variables represent real state better, and avoids
triggering unneeded updates/actions.
Mark Nauwelaerts [Mon, 25 Oct 2010 12:13:51 +0000 (14:13 +0200)]
baseparse: add some debug statements
Tim-Philipp Müller [Tue, 19 Oct 2010 22:25:54 +0000 (23:25 +0100)]
dcaparse: init variable to make osx build bot happy
gstdcaparse.c: In function 'gst_dca_parse_check_valid_frame':
gstdcaparse.c:246: warning: 'best_sync' may be used uninitialized in this function
Tim-Philipp Müller [Mon, 18 Oct 2010 23:15:20 +0000 (00:15 +0100)]
audioparsers: add very basic dts/dca parser
Still some issues, e.g. with seekable queries in totem, but also
processing already-chunked input (created with matroskademux ! gdppay).
Mark Nauwelaerts [Thu, 14 Oct 2010 14:48:21 +0000 (16:48 +0200)]
ac3parse: properly parse e-ac3 frame header
Also add a few debug statements.
Mark Nauwelaerts [Wed, 13 Oct 2010 09:00:01 +0000 (11:00 +0200)]
flacparse: tweak setting buffer metadata; avoid timestamp jitter
Fixes #631993.
Mark Nauwelaerts [Tue, 12 Oct 2010 16:07:49 +0000 (18:07 +0200)]
aacparse: streamline src caps setting
In particular, also set src caps whenever changes in stream warrant doing so.
Sebastian Dröge [Tue, 12 Oct 2010 08:28:33 +0000 (10:28 +0200)]
flacparse: Adjust unit tests to new flacparse behaviour
Garbage after frames is now included in the frames because flacparse
has no easy way to detect the real end of a frame. Decoders are
expected to everything after the frame because only decoding the
bitstream will reveal the real end of the frame.
Fixes bug #631814.
Sebastian Dröge [Tue, 12 Oct 2010 08:27:53 +0000 (10:27 +0200)]
flacparse: Don't drop the last frame if it is followed by garbage
See bug #631814.
Mark Nauwelaerts [Mon, 11 Oct 2010 15:49:46 +0000 (17:49 +0200)]
baseparse: perform bitrate handling and posting after newsegment sending
Mark Nauwelaerts [Mon, 11 Oct 2010 15:36:19 +0000 (17:36 +0200)]
baseparse: immediately post subclass provided bitrate
Mark Nauwelaerts [Mon, 11 Oct 2010 15:06:48 +0000 (17:06 +0200)]
flacparse: fix parsing with unknown framesizes
Fixes #631814 (mostly).
Sebastian Dröge [Thu, 7 Oct 2010 21:37:36 +0000 (23:37 +0200)]
flacparse: Simplify frame header parsing by using lookup tables
Based on a patch by Felipe Contreras.
See bug #631200.
Sebastian Dröge [Thu, 7 Oct 2010 21:28:08 +0000 (23:28 +0200)]
flacparse: Don't parse the complete FLAC frames but only look for valid frame headers
Thanks to Felipe Contreras for the suggestion. This is partially
based on his patches and makes flacparse more than 3.5 times faster.
Looking for valid frame headers is unlikely to give false positives
because every frame header is at least 9 bytes long, contains a
14 bit sync code and a 8 bit checksum over the first 8 bytes.
Fixes bug #631200.
Sebastian Dröge [Wed, 6 Oct 2010 16:32:51 +0000 (18:32 +0200)]
flacparse: Really post tags only after the initial newsegment event
The first newsegment event will be send by the first call to
gst_base_parse_push_buffer() if necessary, posting the tags
before that is not a good idea. Instead do it from the
GstBaseParse::pre_push_buffer vfunc.
Tim-Philipp Müller [Tue, 5 Oct 2010 10:17:52 +0000 (11:17 +0100)]
Revert "baseparse: add skip property"
This reverts commit
b5a3d60363d837a10f0533c141ec93d10b742312.
Reverting this for now, since no one really seems to remember why this
property exists or what it could possibly be good for. It seems to have
been in the original mp3parse since the beginning of time and was back-
ported from there.
Sebastian Dröge [Mon, 4 Oct 2010 08:41:52 +0000 (10:41 +0200)]
flacparse: Fix uninitialized variable compiler warnings
These warnings are wrong, the variables are only used if they were
initialized by the bit reader.
Felipe Contreras [Mon, 13 Sep 2010 23:48:58 +0000 (02:48 +0300)]
flacparse: fix picture parsing
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Sebastian Dröge [Sun, 3 Oct 2010 21:54:49 +0000 (23:54 +0200)]
flacparse: Push tags before the header buffers are pushed
Felipe Contreras [Mon, 2 Aug 2010 17:50:21 +0000 (20:50 +0300)]
flacparse: trivial caps fix
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Sebastian Dröge [Sun, 3 Oct 2010 21:50:29 +0000 (23:50 +0200)]
audioparser: Let the format string agree with the parameters to fix compiler warning
Sebastian Dröge [Sun, 3 Oct 2010 13:41:20 +0000 (15:41 +0200)]
ac3parse: Use unchecked versions of the bitreader get functions
We didn't check the return values anyway...
Arun Raghavan [Wed, 22 Sep 2010 10:14:43 +0000 (15:44 +0530)]
baseparse: Fix debug output
We lose the reference to the buffer after gst_pad_push(), so the debug
print should happen before.
https://bugzilla.gnome.org/show_bug.cgi?id=622276
Mark Nauwelaerts [Fri, 1 Oct 2010 10:34:55 +0000 (12:34 +0200)]
audioparsers: add flacparse unit test
... and tweak parser test helper in the process.
Mark Nauwelaerts [Wed, 29 Sep 2010 14:12:42 +0000 (16:12 +0200)]
baseparse: support reverse playback
... in pull mode or upstream driven.
Mark Nauwelaerts [Mon, 27 Sep 2010 10:16:43 +0000 (12:16 +0200)]
baseparse: remove done TODOs and update documentation
Mark Nauwelaerts [Sat, 25 Sep 2010 12:40:54 +0000 (14:40 +0200)]
baseparse: use determined seekability in answering SEEKING query
Mark Nauwelaerts [Sat, 25 Sep 2010 12:32:06 +0000 (14:32 +0200)]
baseparse: add skip property
Mark Nauwelaerts [Sat, 25 Sep 2010 11:59:39 +0000 (13:59 +0200)]
audioparsers: add ac3parse and mpegaudioparse unit test
Mark Nauwelaerts [Sat, 25 Sep 2010 11:59:18 +0000 (13:59 +0200)]
mpegaudioparse: initial version
... adequately equivalent to mp3parse, so lets boldly set it
to higher rank.
Mark Nauwelaerts [Sat, 25 Sep 2010 12:01:07 +0000 (14:01 +0200)]
aacparse: set minimum frame size at _start
... rather than one time at _init.
Mark Nauwelaerts [Sat, 25 Sep 2010 11:50:51 +0000 (13:50 +0200)]
audioparsers: refactor existing unit tests using common helper
Mark Nauwelaerts [Wed, 22 Sep 2010 13:07:09 +0000 (15:07 +0200)]
baseparse: use _set_frame_props to configure frame lead_in and lead_out
... provided a corresponding decoder with sufficient leading and following
frames to carry out full decoding for a particular segment.
Mark Nauwelaerts [Wed, 22 Sep 2010 12:13:17 +0000 (14:13 +0200)]
baseparse: use _set_duration to configure duration update interval
... as it logically belongs there as one or the other; either subclass
can provide a duration, or an estimate must be made (reguarly updated).
Mark Nauwelaerts [Wed, 22 Sep 2010 11:55:20 +0000 (13:55 +0200)]
baseparse: localize use of provided fps information
Mark Nauwelaerts [Wed, 22 Sep 2010 10:13:12 +0000 (12:13 +0200)]
baseparse: seek table and accurate seek support
Mark Nauwelaerts [Tue, 21 Sep 2010 11:57:10 +0000 (13:57 +0200)]
baseparse: proper and more extended segment and seek handling
That is, loop pause handling, segment seek support, newsegment for gaps, etc
Mark Nauwelaerts [Tue, 21 Sep 2010 08:57:04 +0000 (10:57 +0200)]
baseparse: add index support
Mark Nauwelaerts [Tue, 21 Sep 2010 07:59:56 +0000 (09:59 +0200)]
baseparse: refactor state reset
Mark Nauwelaerts [Mon, 20 Sep 2010 14:39:37 +0000 (16:39 +0200)]
baseparse: prevent indefinite resyncing
Mark Nauwelaerts [Mon, 20 Sep 2010 11:57:55 +0000 (13:57 +0200)]
baseparse: specific EOS handling if no output so far
Mark Nauwelaerts [Mon, 20 Sep 2010 11:31:57 +0000 (13:31 +0200)]
baseparse: adjust _set_frame_prop documentation and set default as claimed
Mark Nauwelaerts [Mon, 20 Sep 2010 11:30:54 +0000 (13:30 +0200)]
baseparse: fix bitrate copy-and-paste and update heuristic
Mark Nauwelaerts [Fri, 17 Sep 2010 16:33:29 +0000 (18:33 +0200)]
baseparse: post duration message if average bitrates is updated