Elinor Fung [Tue, 26 Mar 2019 21:49:44 +0000 (14:49 -0700)]
Add alias for build option to just build/run tests (dotnet/core-setup#5564)
Commit migrated from https://github.com/dotnet/core-setup/commit/
feb4180dcc6a5c9dc3ca5810e02c15a377277db8
Elinor Fung [Mon, 25 Mar 2019 23:57:29 +0000 (16:57 -0700)]
Expose function for locating hostfxr (dotnet/core-setup#5522)
* Add nethost library and implement nethost_get_hostfxr_path
* Add basic tests for nethost_get_hostfxr_path
Commit migrated from https://github.com/dotnet/core-setup/commit/
6001915623d99527f5af3252b9d19694935ae4a8
Swaroop Sridhar [Mon, 25 Mar 2019 21:46:01 +0000 (14:46 -0700)]
Package Microsoft.DotNet.Build.Bundle as a tool (dotnet/core-setup#5555)
Package Microsoft.DotNet.Build.Bundle as a tool similar to ILLink.Tasks
so that it can be consumed by the ToolSet repo.
(https://github.com/dotnet/toolset/pull/541)
Packaging the bundler as a lib causes version compatibility check failures.
Commit migrated from https://github.com/dotnet/core-setup/commit/
142a83f6580b3e409e7a2de4ff7a3b27807474bd
Davis Goodin [Mon, 25 Mar 2019 18:03:54 +0000 (13:03 -0500)]
Improve .NET Shared Framework bundle installer accessibility (dotnet/core-setup#5549)
* Add missing 'Name' attributes to bundle installer
'Image' and 'Text' tags were missing 'Name' attributes.
* Shrink text bounds to fit inside parent
Fixes "An element's BoundingRectangle must be contained within its parent element."
* Fix tab stops: add links, remove text
Some links couldn't be navigated to, and some non-interactive text on the welcome screen could be focused.
Commit migrated from https://github.com/dotnet/core-setup/commit/
28fb2967251f3d63cb8a9c82529f671836941bdd
Vitek Karas [Mon, 25 Mar 2019 17:36:54 +0000 (10:36 -0700)]
Fix framework ordering if graphs (dotnet/core-setup#5542)
If both the app and framework (for example ASP.NET) have dependency on the root Microsoft.NETCore.App and these references are for different versions the product may not find `hostpolicy`.
The problem happens if the framework (ASP.NET for example) has a reference to lower (but still compatible) version to what the app has. In such case the app will resolve the framework and put it into the list. Then we process ASP.NET framework which gets added to the end of that list as well. And then we process references for ASP.NET, we find that the reference to NETCore.App is compatible with the one we already have (soft-roll-forward). In this case the NETCore.App should be moved to the end of the list (the list is ordered such that the root framework should be last), but the code used to only do that if the versions were an exact match.
The fix is to always move the dependent framework to the last position.
Tests we already added as part of the framework resolution test improvement, but commented out as they were failing. Just uncommenting the tests.
Commit migrated from https://github.com/dotnet/core-setup/commit/
b29f3d524a111a2b1c77a4c1362761d2988c6532
Davis Goodin [Mon, 25 Mar 2019 15:23:03 +0000 (10:23 -0500)]
Add .NET Standard 2.1 Targeting Pack (dotnet/core-setup#5535)
* Add .NET Standard 2.1 Targeting Pack
* has no platforms => has no shared framework
* 2.1.0-* netstandard version
* Fix rpm/deb version: use ProductBandVersion
Commit migrated from https://github.com/dotnet/core-setup/commit/
6a73779c901b957a8107aefbd3f48542b60c538a
Davis Goodin [Mon, 25 Mar 2019 14:47:45 +0000 (09:47 -0500)]
Add internal notice to targeting pack nupkg desc (dotnet/core-setup#5536)
Commit migrated from https://github.com/dotnet/core-setup/commit/
167dbc84e5c98ff196e936345d6c274ce6b0860c
Vitek Karas [Sat, 23 Mar 2019 11:41:45 +0000 (04:41 -0700)]
Generalize test settings for framework resolution tests (dotnet/core-setup#5524)
Add ability to easily apply settings (roll forward and so on) in a dynamic way (picking location via variable).
This simplifies testing of settings combinations.
Commit migrated from https://github.com/dotnet/core-setup/commit/
7d83e1fa27bb2ef3e3623f37370023446a3d3dbe
Swaroop Sridhar [Sat, 23 Mar 2019 00:42:24 +0000 (17:42 -0700)]
Publish Microsoft.Dotnet.Build.Bundle package (dotnet/core-setup#5537)
This change publishes the Bundle tool as a package for consumption in the toolset/sdk repos.
The changes are:
Enable package publishing for the Bundler
Add a property in sdk.props so help find the tool easily from the MSBuild tooling
(similar to https://github.com/mono/linker/pull/487/files)
Commit migrated from https://github.com/dotnet/core-setup/commit/
dfe2a49a40ebde28481454573f4d8a8c460a0b6b
Swaroop Sridhar [Fri, 22 Mar 2019 21:43:20 +0000 (14:43 -0700)]
Add a README file for the bundler (dotnet/core-setup#5526)
Add a README file for the bundler
Add a readme file that explains why the Bundler is in the core-setup repo,
and why it is built as a command line tool.
Commit migrated from https://github.com/dotnet/core-setup/commit/
8a6ed3585d14e939d36fecf2b94547e1425e8a2b
Davis Goodin [Fri, 22 Mar 2019 18:54:03 +0000 (13:54 -0500)]
Fix WindowsDesktop file list root attributes (dotnet/core-setup#5533)
Stop automatically inheriting the .NET Core targeting pack's values.
Commit migrated from https://github.com/dotnet/core-setup/commit/
42bdab6aa6ebfb40e9cb99de2542b6fb326bf44f
Vitek Karas [Fri, 22 Mar 2019 09:08:13 +0000 (02:08 -0700)]
Improve roll forward spec and tests (dotnet/core-setup#5516)
Commit migrated from https://github.com/dotnet/core-setup/commit/
b58bfb6da1e5d538f8f2e8a80184943378a5dd9f
Davis Goodin [Fri, 22 Mar 2019 02:27:56 +0000 (21:27 -0500)]
Fix daily build symbol publish (dotnet/core-setup#5525)
Commit migrated from https://github.com/dotnet/core-setup/commit/
c3f419792ab78a235acb622bb42070eb2d8ce069
Steve MacLean [Thu, 21 Mar 2019 20:38:56 +0000 (16:38 -0400)]
Implement SemVer 2.0.0 (dotnet/core-setup#4953)
Implement SemVer 2.0.0 https://semver.org/spec/v2.0.0.html
Add unit test code.
Add end to end SemVer 2.0.0 tests
Respond to comments
Optimize char set check
Commit migrated from https://github.com/dotnet/core-setup/commit/
8ee7c85052193cbf064b7da16c34a8f50d94695a
Nikita Potapenko [Thu, 21 Mar 2019 08:46:28 +0000 (10:46 +0200)]
Update licence info (dotnet/core-setup#5258)
Commit migrated from https://github.com/dotnet/core-setup/commit/
18780678da576d8c629066f50af30159a8859b2f
Vitek Karas [Wed, 20 Mar 2019 21:09:16 +0000 (14:09 -0700)]
Include header files in projects (dotnet/core-setup#5514)
Currently the project files generated by CMake which can be opened in VS don't contain any header files. For the most part intellisense works, but simple Find In Files mostly doesn't and some other navigation in VS is a bit flaky.
This change adds the header files to the projects.
This is Windows only as CMake doesn't generate any project files on Linux/macOS.
Adds header files to the SOURCES list on windows only.
Commit migrated from https://github.com/dotnet/core-setup/commit/
e2ead1e8128bfc31af2b86688f86b014ecde1a75
Jeremy Koritzinsky [Wed, 20 Mar 2019 20:34:18 +0000 (13:34 -0700)]
IJW Host (dotnet/core-setup#5185)
* First pass porting mscoree/mscoreei's IJW hosting hooks into a new .NET Core host. Functions that use runtime data structures are stubbed out.
* Use Windows heap functions for allocating executable memory.
* Add IJW activation design document.
* Add talking point about loading dependencies from *.deps.json* files and what work needs to be done for those.
* Clean up design doc.
* Update design doc.
* Feedback.
* Clean up the PEDecoder since we don't need to port over all of the validation, just enough to ensure that the assembly is a .NET assembly.
* The OS will verify that the IJW image and the IJW host are the same architecture, so we don't need to branch on architecture.
* Clean up ijwhost and PEDecoder code based on review feedback.
* Refactor corehost.cpp and add implementations of functions to fetch IJW delegates from hostfxr.
* Move hostfxr resolution into separate file and make corehost only relevant for the exe hosts.
* Make get_latest_fxr local to fxr_resolver.cpp
* Implement fxr wire-up for ijwhost.
* Rvas are already mapped for loaded images.
* Don't use stubs if being loaded into currently running runtime.
* Update IJW activation doc based on updated info about callbacks.
* Implement token resolution from thunks. Fix calling a users native entry-point from _CorDllMain.
* Correctly resolve side-by-side hostfxr from ijwhost and comhost. Correctly handle an empty TPA when appending S.P.CL. Pass app-path to delegate.
* Update design doc.
* Remove unneeded validation.
* Fix assembler selection for ARM/ARM64.
* Fix indentation.
* Remove dead code in PEDecoder.
* Fix missing CommandLineToArgvW symbol in arm/arm64 builds.
* Fix ARM/ARM64 build by bringing over custom arm assembler supporting cmake from coreclr.
* Remove IJWBootstrapThunk opaque class. Rename all non-exported apis to match the snake_case convention in this repo.
* Remove exports.cpp files per pr feedback.
* Use an enum to specify which delegate to load from the runtime in the hostfxr<->hostpolicy API.
* Fix x86 build
* Make x86 implementation of get_thunk_from_cookie clearer.
* Symbol export changes needed for x86 as found by testing.
* Remove ijw-exe-specific path.
* clean up ijwhost.cpp since we only have one entrypoint into hostfxr from ijwhost now.
* Use enum for delegate getter in hostfxr-exposed api as well.
* PR Feedback.
* Add ijwhost to Microsoft.NetCore.DotNetAppHost package.
* Setup tracing on comhost and ijwhost entry points.
* PR Feedback.
* Remove IsILOnly checks.
* Clean up design doc.
* More cleanup on IJW activation design doc
* swallow tracing on IJW. Remove as much of corhdr.h as possible.
* Fix bad copy-paste in the install command in ijwhost cmake script.
* Fix cmake
* Add error message to trace for failure to find the "corehost_get_coreclr_delegate" entrypoint.
* Sign ijwhost. Fixes dotnet/core-setup#5485.
Commit migrated from https://github.com/dotnet/core-setup/commit/
bc7bcc646567a261c0ae113d5fe43f17469af4ae
Jan Vorlicek [Wed, 20 Mar 2019 14:56:53 +0000 (15:56 +0100)]
Disable using clang 3.9 for linux ARM cross build (dotnet/core-setup#5515)
* Disable using clang 3.9 for linux ARM cross build
The clang 3.9 was found to be generating broken code when cross
building for arm/armel long time ago for coreclr repo builds.
It was generating e.g. incorrect code for interlocked operations.
Now with a recent change in core-setup (adding linking of libatomic.a),
it started to generate broken code in core-setup too (leading to
SIGILL in libhostpolicy.so).
This change disables usage of clang 3.9 for ARM cross building, like
we do in the coreclr repo.
* Update docker image used to build for linux arm
The updated image contains clang 5.0
Commit migrated from https://github.com/dotnet/core-setup/commit/
9ae2a9af66c0c44e7078b3dcc37fc66a350a3cb1
Vitek Karas [Wed, 20 Mar 2019 10:46:00 +0000 (03:46 -0700)]
Exact spec of framework version resolution (dotnet/core-setup#5202)
Commit migrated from https://github.com/dotnet/core-setup/commit/
ff91750c447ebdfa762683197a72b92f66464f1f
Davis Goodin [Tue, 19 Mar 2019 21:55:28 +0000 (16:55 -0500)]
Create targeting pack macOS pkg installer (dotnet/core-setup#5504)
Commit migrated from https://github.com/dotnet/core-setup/commit/
41ebaaa81cfd9810920388933de07ded53128bcc
John Beisner [Tue, 19 Mar 2019 21:17:14 +0000 (14:17 -0700)]
Enable upgrade-in-place Shared Framework bundle installer (dotnet/core-setup#5509)
*'upgrade-in-place' Shared Framework bundle installer.
Commit migrated from https://github.com/dotnet/core-setup/commit/
1c42c6215b8183cb55b85ee046a9a3521fc76d64
Davis Goodin [Tue, 19 Mar 2019 21:06:51 +0000 (16:06 -0500)]
Move pkg tools import for runtime.json override (dotnet/core-setup#5512)
IncludeRuntimeJson was being overridden by dir.props, but the value in dir.props should have been overridden.
Commit migrated from https://github.com/dotnet/core-setup/commit/
b0cfc6e820a94a1251e4fbb8cc2411ca351e3209
Davis Goodin [Tue, 19 Mar 2019 17:30:36 +0000 (12:30 -0500)]
Don't save CI packages as artifacts (dotnet/core-setup#5508)
Publishing to a build artifact can take long enough to time out the build, and isn't useful very often.
Commit migrated from https://github.com/dotnet/core-setup/commit/
4d6b497d03a1758b9beed08a0b3fa258bc78160d
Vitek Karas [Tue, 19 Mar 2019 15:14:46 +0000 (08:14 -0700)]
Framework resolution tests (dotnet/core-setup#5502)
* Framework resolution tests
Backfill detailed tests for framework resolution behavior, specifically
around roll-forward.
Introduces some new test helpers
* hostpolicy mock, to avoid actually loading and running coreclr just to
validate selected frameworks
* Builder-like API for `.runtimeconfig.js`
* Builder-like API for shared frameworks
* Some helper classes to limit file copy while keeping the tests fully
isolated
Commit migrated from https://github.com/dotnet/core-setup/commit/
e42109d82608c0c0a6123f9b70c21ab632b08d07
Davis Goodin [Mon, 18 Mar 2019 22:55:20 +0000 (17:55 -0500)]
Create WindowsDesktop targeting pack MSIs, fix registry entry ref counting (dotnet/core-setup#5491)
* Create targeting pack MSIs through pkgproj
* Use generated GUIDs for MSI Provider components
Fixes ref-counting for registry keys. Registry entries could be left behind on uninstall because the static GUID with a changing registry key path broke ref counting.
* Fix GetUpgradeCode comment
Commit migrated from https://github.com/dotnet/core-setup/commit/
165bba0c0e5b74cb545649c626f27c404dce2b55
Vitek Karas [Mon, 18 Mar 2019 20:39:51 +0000 (13:39 -0700)]
Update the roll forward doc to document no inheritance (dotnet/core-setup#5497)
The original version of the doc defined that chained framework references would inherit effective roll forward settings (with possible overrides).
But the code never implemented the behavior. The behavior in code is such that each `.runtimeconfig.json` is processed in isolation.
Changing the document to match the code.
Commit migrated from https://github.com/dotnet/core-setup/commit/
c638300eb750c6e731495a756a8e35e11e7bd844
Aaron Robinson [Sat, 16 Mar 2019 22:41:24 +0000 (15:41 -0700)]
COMHost logging and registration bugs (dotnet/core-setup#5496)
Initialize logging during registration
Set default name for COM server entry
Handle cases where GUIDs supplied in .clsidmap are not in full GUID format
Commit migrated from https://github.com/dotnet/core-setup/commit/
606cf1f607d23f0ae5557c580e55f4f99d6d4ece
Elinor Fung [Sat, 16 Mar 2019 18:08:26 +0000 (11:08 -0700)]
Only run long path test if machine-wide setting is enabled (dotnet/core-setup#5492)
Commit migrated from https://github.com/dotnet/core-setup/commit/
60d8fb31b7e96b1682d1a4efba713aee91413c1b
Davis Goodin [Fri, 15 Mar 2019 17:34:22 +0000 (12:34 -0500)]
Revert "Remove MyGet feed restore sources (dotnet/core-setup#5484)" (dotnet/core-setup#5488)
This reverts commit dotnet/core-setup@
a155796b825e025d29dba469cad7686e23aa40b3.
Commit migrated from https://github.com/dotnet/core-setup/commit/
1d00c6fcd8679b1e7930636ca2194d7c9151d84a
Jeremy Barton [Fri, 15 Mar 2019 16:28:18 +0000 (09:28 -0700)]
Restore support for UTF-8 BOM/Preamble on loading JSON.
Commit migrated from https://github.com/dotnet/core-setup/commit/
65af8133a3a6ceb3abe7baa39f4898e55b86ce01
Swaroop Sridhar [Fri, 15 Mar 2019 03:10:53 +0000 (20:10 -0700)]
Implement Single-file Bundler (dotnet/core-setup#5286)
* Implement Single-file Bundler
This change implements the single-file bundler, according to this
[design document](https://github.com/dotnet/designs/blob/master/accepted/single-file/design.md)
The change also adds a test-case that:
* Bundles the contents of a self-contained console app publish directory along with all sub-directories
* Extracts the contents to a new location
* Runs the extracted app to verify successful execution
TBD:
* Add more tests tests once the host-changes to process the bundle are implemented.
* Localization of output strings.
Issue: https://github.com/dotnet/coreclr/issues/20287
Commit migrated from https://github.com/dotnet/core-setup/commit/
1bcd5d5ec790b9d6ade0ff8619bd0acfe6e50269
Davis Goodin [Thu, 14 Mar 2019 21:34:15 +0000 (16:34 -0500)]
Remove MyGet feed restore sources (dotnet/core-setup#5484)
Commit migrated from https://github.com/dotnet/core-setup/commit/
a155796b825e025d29dba469cad7686e23aa40b3
Vitek Karas [Thu, 14 Mar 2019 17:29:32 +0000 (10:29 -0700)]
Use tests folder for test artifacts (dotnet/core-setup#5478)
Commit migrated from https://github.com/dotnet/core-setup/commit/
aa0913a7b96bc77935f48d85efe2f67434945c84
Davis Goodin [Thu, 14 Mar 2019 15:44:33 +0000 (10:44 -0500)]
Maintain readme table: add 3.0 + 2.2 columns, remove 2.0 column, add table tooling (dotnet/core-setup#5468)
* Normalize table to reduce diff
* Create task to regen table based on existing links
This commit includes a table regeneration run to see that nothing was lost.
* Add 2.2 + 3.0, remove 2.0
* Clarify table regen task and target
* Fix Ubuntu 14.04 3.0 links
Commit migrated from https://github.com/dotnet/core-setup/commit/
b0f767dd8b7af4ff62d9a704aeea18f0aaf75719
Vitek Karas [Thu, 14 Mar 2019 14:30:16 +0000 (07:30 -0700)]
Clarify why renaming dotnet.exe is blocked. (dotnet/core-setup#5476)
Commit migrated from https://github.com/dotnet/core-setup/commit/
f8edc0e02e4389efe98a9ba762d72228eb8c345e
Vitek Karas [Wed, 13 Mar 2019 23:37:29 +0000 (16:37 -0700)]
Backfill license headers (dotnet/core-setup#5469)
Commit migrated from https://github.com/dotnet/core-setup/commit/
b944f5ba22e7b4733e6437cb57d65e425cedac3d
Elinor Fung [Wed, 13 Mar 2019 17:08:17 +0000 (10:08 -0700)]
Update dotnet.exe win32 manifest to support long paths (dotnet/core-setup#5335)
* Update dotnet.exe win32 manifest to support long paths
* Add test using a Win32 API with long paths
Fixes dotnet/core-setup#5262
Commit migrated from https://github.com/dotnet/core-setup/commit/
a76107370efa277c49c44298ffded862e2999d57
Jeremy Koritzinsky [Tue, 12 Mar 2019 22:29:30 +0000 (15:29 -0700)]
Use the CMake install target to place binaries instead of MSBuild post-processing (dotnet/core-setup#5397)
We generate an install target to place our binaries and symbols in the right location via CMake, but we never use it. Additionally, we effectively replicate that functionality in `core-host/build.proj`.
This PR switches the native build to place the native output via the CMake install target and removes the MSBuild scripting that was duplicating it.
Also fixes a few build bugs in our RID construction in `src/corehost/build.sh` with cross-compilation.
Commit migrated from https://github.com/dotnet/core-setup/commit/
76887daf5a142dcae756882ff1849f620dfe1aa4
Davis Goodin [Tue, 12 Mar 2019 21:24:49 +0000 (16:24 -0500)]
Add pkgproj-based DEB/RPM build for targeting packs (dotnet/core-setup#5369)
* Pkgproj-based DEB/RPM build for targeting packs
* Code review fixes
Make clean displayName clearer.
Add '-a' to 'docker system prune'.
Fix comments for fpm and debuild tool checks.
* Fix bad indent
Commit migrated from https://github.com/dotnet/core-setup/commit/
f6441d4af6030bd40eb0440038bbe4d522d266cf
John Beisner [Tue, 12 Mar 2019 21:07:28 +0000 (14:07 -0700)]
The AppHost and the global registry key (dotnet/core-setup#5455)
* The AppHost needs to consider the self-registered dotnet installation location when searching for the HostFXR.
Commit migrated from https://github.com/dotnet/core-setup/commit/
ede9e16b4b2396475bdc38700ed6205b3df4c0bf
Davis Goodin [Tue, 12 Mar 2019 20:45:54 +0000 (15:45 -0500)]
Clean up RPM dotnet symlink to fix build failure (dotnet/core-setup#5451)
Commit migrated from https://github.com/dotnet/core-setup/commit/
43f5f662f30718de0ea2bda2f8abd759a6ad9863
Elinor Fung [Tue, 12 Mar 2019 18:39:58 +0000 (11:39 -0700)]
Test rename (dotnet/core-setup#5440)
* Test rename
- Remove 'GivenThatICareAbout' prefix from file and class names
- Remove unnecessary public sets
- Rename/shorten test project fixture variable names
- Consistent formatting of assertions for Pass/Fail and HaveStdOut/Err
Commit migrated from https://github.com/dotnet/core-setup/commit/
1956cfc197079daf1facaaf1dba2e24dad383bdb
Vitek Karas [Mon, 11 Mar 2019 20:16:28 +0000 (13:16 -0700)]
Test cleanup (dotnet/core-setup#5410)
* Test cleanup
* PR Feedback
Commit migrated from https://github.com/dotnet/core-setup/commit/
c285e76a5b768dcb4434f0349e5fcc78bf9c9e29
Vitek Karas [Mon, 11 Mar 2019 16:07:21 +0000 (09:07 -0700)]
Fix comhost to actually have exports (dotnet/core-setup#5431)
This regression was introduced in dotnet/core-setup#5228
Commit migrated from https://github.com/dotnet/core-setup/commit/
e9cb90761197c4fce33c24f17af77d42e488605d
Vitek Karas [Sun, 10 Mar 2019 06:59:21 +0000 (22:59 -0800)]
Move method bodies out of header files (dotnet/core-setup#5406)
Commit migrated from https://github.com/dotnet/core-setup/commit/
e2a3635ab218108042058465ac03de4c4fe1fca6
Vitek Karas [Sat, 9 Mar 2019 20:47:02 +0000 (12:47 -0800)]
Remove small amount of code duplication in cmake files. (dotnet/core-setup#5409)
Commit migrated from https://github.com/dotnet/core-setup/commit/
f7fde3da40fd616e65cbb85e8d45621de061f05a
Vitek Karas [Fri, 8 Mar 2019 21:49:23 +0000 (13:49 -0800)]
Split libhost.h into multiple headers and cleanup (dotnet/core-setup#5391)
Commit migrated from https://github.com/dotnet/core-setup/commit/
3586f526ae50b9c1f7e31019a317a7358f1f2170
Davis Goodin [Fri, 8 Mar 2019 21:22:29 +0000 (15:22 -0600)]
Remove host RPM postinstall, install the symlink (dotnet/core-setup#5380)
Rather than using postinstall and postuninstall scripts to maintain a /usr/bin/dotnet symlink, have the RPM package install the symlink file itself. This reduces the complexity of the host package.
Commit migrated from https://github.com/dotnet/core-setup/commit/
76f2f1e43f8951d7ef4a3f059be4a9ae9c849f7a
John Beisner [Fri, 8 Mar 2019 19:50:02 +0000 (11:50 -0800)]
Registry component mistakenly reinstated; see: (dotnet/core-setup#5393)
Registry component mistakenly reinstated
Commit migrated from https://github.com/dotnet/core-setup/commit/
007088847d7e6fe1943bdb6f93ca24eb7a94cf9a
Vitek Karas [Fri, 8 Mar 2019 17:41:00 +0000 (09:41 -0800)]
Fix native build warnings (dotnet/core-setup#5389)
Commit migrated from https://github.com/dotnet/core-setup/commit/
54afeff31b17226d98b9a25c7c6d9abd6b4d35fc
Vitek Karas [Fri, 8 Mar 2019 10:39:07 +0000 (02:39 -0800)]
Host testing proposal (dotnet/core-setup#5153)
Commit migrated from https://github.com/dotnet/core-setup/commit/
df98d5ca0ac0d3c9db6af6c0cfc3586bf656f9b5
Vitek Karas [Fri, 8 Mar 2019 06:30:09 +0000 (22:30 -0800)]
Enable usage of VS 2019 for native build (dotnet/core-setup#5378)
Commit migrated from https://github.com/dotnet/core-setup/commit/
d02dcc19cc95bd23a73200f4582550b18283e1a1
Elinor Fung [Thu, 7 Mar 2019 23:14:05 +0000 (15:14 -0800)]
Merge pull request dotnet/core-setup#5372 from elinor-fung/removeShadowedVariable
Remove shadowed variable in resolve_fxr_path for libhost
Commit migrated from https://github.com/dotnet/core-setup/commit/
428f39706c125c7baf4e52e4d2fdc5d5373d1a95
Elinor Fung [Thu, 7 Mar 2019 19:37:43 +0000 (11:37 -0800)]
Remove shadowed variable in resolve_fxr_path for libhost
Collapse resolving fxr for apphost and libhost to just have the same
code path as they use the same logic.
Commit migrated from https://github.com/dotnet/core-setup/commit/
40f436cdfac6ed10d1afe2e0db0eb0aacc7aca92
Davis Goodin [Thu, 7 Mar 2019 16:32:17 +0000 (10:32 -0600)]
Pad BuildNumberMinor with zeros (dotnet/core-setup#5367)
Commit migrated from https://github.com/dotnet/core-setup/commit/
fc66563da7f08eb66e2b82eefec3a5660bacce23
Vitek Karas [Wed, 6 Mar 2019 20:49:48 +0000 (12:49 -0800)]
Introduce TestArtifact and some refactoring. (dotnet/core-setup#5352)
Commit migrated from https://github.com/dotnet/core-setup/commit/
dc843c54682ef408062de0212706b4930853522f
Davis Goodin [Wed, 6 Mar 2019 17:30:50 +0000 (11:30 -0600)]
Add linux-musl-arm64 (Alpine) build leg (dotnet/core-setup#5345)
* Add linux-musl-arm64 leg
* Add Alpine leg dependency
* Use MCR for build images
Commit migrated from https://github.com/dotnet/core-setup/commit/
16ec3ca95de9f0c3bfedfc4b983219901bf2e2b8
Davis Goodin [Wed, 6 Mar 2019 01:22:46 +0000 (19:22 -0600)]
Remove NuGet http cache for Windows builds (dotnet/core-setup#5343)
Windows builds (specifically ARM builds in CI) use static machines, which may have an out of date cache that NuGet considers alive. Ensure the cache is not used by deleting it.
Commit migrated from https://github.com/dotnet/core-setup/commit/
b101d0c16d3d08da1bd846050d55e25878d30d28
dotnet-maestro-bot [Tue, 5 Mar 2019 23:34:26 +0000 (15:34 -0800)]
Update BuildTools to preview1-03805-01 (dotnet/core-setup#5339)
Commit migrated from https://github.com/dotnet/core-setup/commit/
8587170572b3f0691937287942d472a2c3a126d0
Vitek Karas [Tue, 5 Mar 2019 16:36:28 +0000 (08:36 -0800)]
Remove unused test project and fixture settings (dotnet/core-setup#5332)
Simplify computation of platform specific file names.
Remove unnecessary private fields.
Remove unnecessary methods.
Commit migrated from https://github.com/dotnet/core-setup/commit/
a8a3922bed6ab591c777ead9aeb14dbc6e21dae3
Aaron Robinson [Mon, 4 Mar 2019 21:01:46 +0000 (13:01 -0800)]
Statically link against atomic.a on Linux-ARM32 platforms (dotnet/core-setup#5322)
Commit migrated from https://github.com/dotnet/core-setup/commit/
5e82a65b7267950f2613b79de8068a6751f63eaa
Aaron Robinson [Fri, 1 Mar 2019 19:35:26 +0000 (11:35 -0800)]
Remove usage of atomic and rely on lock instead. (dotnet/core-setup#5294)
Commit migrated from https://github.com/dotnet/core-setup/commit/
d0e3248d57e20c6eba223c6ca9e18dafbb9cea72
Eric Erhardt [Fri, 1 Mar 2019 17:46:42 +0000 (11:46 -0600)]
Remove DependencyModel's dependency on PlatformAbstractions (dotnet/core-setup#5218)
* Remove DependencyModel's dependency on PlatformAbstractions
Working towards dotnet/core-setup#5213
Commit migrated from https://github.com/dotnet/core-setup/commit/
e43465a759f9d887aa8d605faeaf4508c581f2db
William Godbe [Thu, 28 Feb 2019 23:52:19 +0000 (15:52 -0800)]
Merge pull request dotnet/core-setup#5279 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools to preview1-03727-01 (master)
Commit migrated from https://github.com/dotnet/core-setup/commit/
337e5143677b4c798ea126930f4e695b1c3d58db
dotnet-maestro-bot [Thu, 28 Feb 2019 22:53:03 +0000 (14:53 -0800)]
Update BuildTools to preview1-03727-01
Commit migrated from https://github.com/dotnet/core-setup/commit/
9594b98f38b01040e81d99d9e35a7bc96e2713c2
Steve MacLean [Thu, 28 Feb 2019 20:06:43 +0000 (15:06 -0500)]
Merge pull request dotnet/core-setup#5270 from sdmaclea/improve_message
Improve missing framework error message
Commit migrated from https://github.com/dotnet/core-setup/commit/
1ebfe6a0cd66aec3451b9153b0511018bc379900
Kathleen Dollard [Thu, 28 Feb 2019 19:33:27 +0000 (14:33 -0500)]
Update src/corehost/cli/fxr/fx_muxer.cpp
Co-Authored-By: sdmaclea <stmaclea@microsoft.com>
Commit migrated from https://github.com/dotnet/core-setup/commit/
7f8e81f99d41c27e1bb6006d117d0ad8aca7fb97
Steve MacLean [Thu, 28 Feb 2019 17:31:23 +0000 (12:31 -0500)]
Fix test bugs (dotnet/core-setup#5274)
* Fix bug in GivenThatICareAboutMultilevelSDKLookup
* Fix bug in GivenThatICareAboutSDKLookup
Commit migrated from https://github.com/dotnet/core-setup/commit/
7f95266bc111575413875bacb9a9ab299f96e3c4
Steve MacLean [Wed, 27 Feb 2019 21:10:36 +0000 (16:10 -0500)]
Improve missing framework error message
Commit migrated from https://github.com/dotnet/core-setup/commit/
b2918e232f48bdf3040a1a8aa0f37cba7a6b7254
Michal Strehovský [Thu, 28 Feb 2019 02:29:37 +0000 (03:29 +0100)]
Use partial crossgen for select assemblies on Linux (dotnet/core-setup#5252)
Measurements show that doing partial crossgen on these assemblies captures about two thirds of the size savings we could achieve by partially crossgenning everything.
Only doing this for Linux, since Linux containers are more size-conscious.
Commit migrated from https://github.com/dotnet/core-setup/commit/
0d80fe3cfdceeb0873222176573a7add30f5db85
William Godbe [Tue, 26 Feb 2019 22:38:37 +0000 (14:38 -0800)]
Merge pull request dotnet/core-setup#5245 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools to preview1-03723-01 (master)
Commit migrated from https://github.com/dotnet/core-setup/commit/
45018dc1e7721a1aee92bb7a66e083c559f164df
Jeremy Koritzinsky [Tue, 26 Feb 2019 19:29:38 +0000 (11:29 -0800)]
Merge pull request dotnet/core-setup#5255 from jkoritzinsky/sharedfx-no-comhost
Remove comhost from the shared framework generation.
Commit migrated from https://github.com/dotnet/core-setup/commit/
e6b35cfcb749ceecafb9b205637b18f71ea4cc11
Jeremy Koritzinsky [Tue, 26 Feb 2019 18:43:08 +0000 (10:43 -0800)]
Remove comhost from the shared framework generation.
Commit migrated from https://github.com/dotnet/core-setup/commit/
38cae4bdcffe38cecad06319ad9bfdbe98347e49
dotnet-maestro-bot [Tue, 26 Feb 2019 16:40:28 +0000 (08:40 -0800)]
Update BuildTools to preview1-03723-01
Commit migrated from https://github.com/dotnet/core-setup/commit/
46e4932708130bd99d894ff4307516a224b6c67d
John Beisner [Sat, 23 Feb 2019 00:48:21 +0000 (16:48 -0800)]
Modify the InstallLocation registry key; core-setup (dotnet/core-setup#5238)
* Modify the 'InstallLocation' registry key.
Commit migrated from https://github.com/dotnet/core-setup/commit/
b344ca9aafbc18e3a75cd5237ff9c1b30aa15987
Davis Goodin [Fri, 22 Feb 2019 00:19:35 +0000 (18:19 -0600)]
Add WindowsDesktop targeting pack nupkg, refactor pkg projects (dotnet/core-setup#5214)
* Refactor pkg projects
Instead of '.builds' projects, get Project items by calling a target in '.pkgproj' projects.
Move more common props/targets together.
* Add WindowsDesktop targeting pack nupkg
* Stop placing all files in data/ dir, only txt
* Change Pack nupkg type to DotnetPlatform
* Rename framework targets files
* Remove source redist: obsolete
* Require version files to be found and exist
Explicitly check if they exist to throw a clear error. The ReadAllText call would catch this, but it's verbose and doesn't say what the item's name is.
* DetermineRuntimeDependencies is not an override
* Remove package-specific asset exclusion
Use ExcludeAssets=All for CoreRT package to restore it but exclude Windows.winmd from redist.
Commit migrated from https://github.com/dotnet/core-setup/commit/
2f91bd28d0c77eb72275f46ddd7cfc9f10196ba7
Vitek Karas [Thu, 21 Feb 2019 21:29:34 +0000 (13:29 -0800)]
Cleanup native build (dotnet/core-setup#5228)
Refactor cmake files to avoid code duplication.
Fix comhost to have native resources on Windows - that is version and other properties.
Turn on parallel build on Windows - on my machine the native build took 125 second before and 40 after this change.
Commit migrated from https://github.com/dotnet/core-setup/commit/
758461c8933699dca0cb5f8e4fa712ab35d1d277
William Godbe [Tue, 19 Feb 2019 21:40:41 +0000 (13:40 -0800)]
Merge pull request dotnet/core-setup#5183 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools to preview1-03715-01 (master)
Commit migrated from https://github.com/dotnet/core-setup/commit/
ab25ef254ce33af5878041a6ea4ae7dde4f5a011
dotnet-maestro-bot [Tue, 19 Feb 2019 21:02:34 +0000 (13:02 -0800)]
Update BuildTools to preview1-03715-01
Commit migrated from https://github.com/dotnet/core-setup/commit/
6c10c131657a116b744b0be5bb57340a91d7cb23
Jan Kotas [Tue, 19 Feb 2019 16:19:35 +0000 (08:19 -0800)]
Fix product name included in the binaries (dotnet/core-setup#5203)
Commit migrated from https://github.com/dotnet/core-setup/commit/
701b4d6176bc896b81115d22773a4b203f0be838
Next Turn [Mon, 18 Feb 2019 16:08:50 +0000 (00:08 +0800)]
Update environment variables (dotnet/core-setup#5192)
* Update environment variables
* Fix json snippet
* Fix text formats
Commit migrated from https://github.com/dotnet/core-setup/commit/
6d5e4a7932cbd58b2d087e3c28c6a80944ef8db3
William Godbe [Thu, 14 Feb 2019 19:59:44 +0000 (11:59 -0800)]
Merge pull request dotnet/core-setup#5159 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools to preview1-03713-01 (master)
Commit migrated from https://github.com/dotnet/core-setup/commit/
793c41bad68f15fee17b67c5faaa0eaa2d102595
dotnet-maestro-bot [Thu, 14 Feb 2019 18:19:26 +0000 (10:19 -0800)]
Update BuildTools to preview1-03713-01
Commit migrated from https://github.com/dotnet/core-setup/commit/
41a329ef318529fd31509f7e905e67e22b66b649
Davis Goodin [Thu, 14 Feb 2019 17:12:56 +0000 (11:12 -0600)]
Create framework assembly list file in .NET Core targeting pack (dotnet/core-setup#5168)
* Create framework assembly list file
* Fix FileUtilities private static style
* Remove package ID prefix from PlatformManifest.txt
* Proactively detect/report missing public key token
Commit migrated from https://github.com/dotnet/core-setup/commit/
493c6287a2bd54c41a71cc88cbfb7c8ee06ee812
Steve MacLean [Thu, 14 Feb 2019 16:15:08 +0000 (11:15 -0500)]
Merge pull request dotnet/core-setup#5156 from NextTurn/master
Clean up
Commit migrated from https://github.com/dotnet/core-setup/commit/
564452f46b9aba1c3b5b1fa7f4837204ae738061
Vitek Karas [Thu, 14 Feb 2019 11:52:25 +0000 (03:52 -0800)]
Update the host-component document (dotnet/core-setup#5152)
Add `comhost` into the list.
Use platform agnostic wording and library names.
Reword certain description to provide more precise and detailed information.
Commit migrated from https://github.com/dotnet/core-setup/commit/
dd4e2d073662f992c9148f13c793b4b360325990
Davis Goodin [Thu, 14 Feb 2019 00:35:25 +0000 (18:35 -0600)]
Create targeting pack MSI installers (dotnet/core-setup#5114)
* Create targeting pack MSI
This change has the targeting pack pkgproj create an install layout based on the nupkg's data/ dir. That's picked up by the targeting pack installer project the same way it is for hostfxr and shared framework. In general, the targeting pack installer project is a copy of existing installers with very little changed.
In official builds, build the full platform manifest on win-x86, not just win-x64. Both platforms' installers need the full manifest.
* Change install dir "ref" => "packs"
* "Microsoft .NET Core Targeting Pack" branding
* Remove "netcoreapp" from MSI filename
The name "dotnet-targeting-pack" brings it in line with installer names like "dotnet-runtime" and "dotnet-host".
* Fix targeting pack powershell script: PR comments
I plan to remove this script entirely, but it might as well be a little cleaner while development is ongoing.
* Fix DependencyKey: Dotnet_CLI => Dotnet_Core
* Fix typo: GeneratedGui => GeneratedGuid
Commit migrated from https://github.com/dotnet/core-setup/commit/
0f10c29471af71b020b0c1513f28356660df1eab
William Godbe [Wed, 13 Feb 2019 20:03:17 +0000 (12:03 -0800)]
Merge pull request dotnet/core-setup#5149 from wtgodbe/preview4
Update branding for preview4
Commit migrated from https://github.com/dotnet/core-setup/commit/
d6b36de6b69f5a71ba64d4fa08824f8d5d4e1c14
wtgodbe [Wed, 13 Feb 2019 19:28:42 +0000 (11:28 -0800)]
Fix branding
Commit migrated from https://github.com/dotnet/core-setup/commit/
8edd59240ab03a791b922535a242803bf2aec729
Next Turn [Wed, 13 Feb 2019 17:19:34 +0000 (01:19 +0800)]
Delete corehost.md
Commit migrated from https://github.com/dotnet/core-setup/commit/
fe1ae457e2704d8553baa09ffc2c4d9cc81ddd87
Next Turn [Wed, 13 Feb 2019 13:44:33 +0000 (21:44 +0800)]
Update Runtime Resolution
Commit migrated from https://github.com/dotnet/core-setup/commit/
689d9a427144cd07efc068041aaf6a4675abe6a9
wtgodbe [Tue, 12 Feb 2019 23:55:45 +0000 (15:55 -0800)]
Update branding for preview4
Commit migrated from https://github.com/dotnet/core-setup/commit/
b1c441526532ed2979070a747eae681a135355f8
Vitek Karas [Tue, 12 Feb 2019 23:23:18 +0000 (15:23 -0800)]
Simplify computation of oldest framework reference (dotnet/core-setup#5142)
Instead of passing the list of oldest references all the way down to the code which performs roll forwards, simply assign to it when we enumerate reerences for the first time.
The only difference is that in case of a failure the oldest reference will be filled while before it would not be fully up to date.
Commit migrated from https://github.com/dotnet/core-setup/commit/
70d4423e3c6f6b4439c8ecfdc2c33ccf595a5b93
Aaron Robinson [Tue, 12 Feb 2019 21:00:28 +0000 (13:00 -0800)]
Add COM host to the AppHost package (dotnet/core-setup#5145)
Commit migrated from https://github.com/dotnet/core-setup/commit/
fc4720a5141a52d17e411a86c8c7a6189f1f1fe9
Aaron Robinson [Tue, 12 Feb 2019 17:38:10 +0000 (09:38 -0800)]
COM Activation host (dotnet/core-setup#4577)
* Add new comhost library for COM activation
- Supports reading clsidmap as file or resource
- Supports registration and unregistration of COM server
* Replace COREHOST_MAKE_DLL define with EXPORT_SHARED_API
* Convert CoreClr instance loading API from a flat C-style to a class API . This will make having multiple CoreClr instances in the same process easier in the future.
* Move internal execute* APIs to the fx_muxer.cpp compilation unit
Add initial/erroring implementation for get_com_activation_delegate() to fx_muxer_t.
* Create coreclr_property_bag_t for property management.
* Extract coreclr property creations into a reusable class.
* Report process ID during test run.
* Remove the new corehost_ensure_load() export since the previous semantics
of reinitializing hostpolicy were designed for testing.
* Fix P/Invoke signature for hostfxr_get_native_search_directories to define
the calling convention and remove usage of StringBuilder.
* Properly propagate the host command on reinitialization
Remove additional uses of global variables where possible
* Don't add the COM server assembly to the TPA
Ensure the COM server assembly deps.json isn't added to the AppContext
* Feedback on error propagation
Commit migrated from https://github.com/dotnet/core-setup/commit/
1d95ece515edbbad0ef8f8980424d3e3bce49cb2
William Godbe [Mon, 11 Feb 2019 22:24:13 +0000 (14:24 -0800)]
Merge pull request dotnet/core-setup#5134 from wtgodbe/Yaml30
Add CI for release/3.0
Commit migrated from https://github.com/dotnet/core-setup/commit/
c237a360fea89d7e7c00727718c1c1ec5347249e
Pavel Krymets [Mon, 11 Feb 2019 21:08:32 +0000 (13:08 -0800)]
Close HKEY handle after use (dotnet/core-setup#5133)
Commit migrated from https://github.com/dotnet/core-setup/commit/
87fdb3f16df7e432c4905d38b8957bf0fb72fd2a
wtgodbe [Mon, 11 Feb 2019 20:32:10 +0000 (12:32 -0800)]
Add PR trigger
Commit migrated from https://github.com/dotnet/core-setup/commit/
d5de9d94a1ca92837baeca509ec445813c9a5766
wtgodbe [Mon, 11 Feb 2019 20:22:09 +0000 (12:22 -0800)]
Add CI for release/3.0
Commit migrated from https://github.com/dotnet/core-setup/commit/
ce108d54bc01699bac2ed8468af6071e0ab5cf59
dotnet-maestro-bot [Sun, 10 Feb 2019 07:15:07 +0000 (23:15 -0800)]
Update BuildTools to preview1-03706-01 (dotnet/core-setup#5098)
Commit migrated from https://github.com/dotnet/core-setup/commit/
99c3e2835a69e0a23c49fbbaa4e558c45fd6047b