Daniel Stenberg [Thu, 27 Jan 2011 13:37:25 +0000 (14:37 +0100)]
ares: memory leak fix
The double name resolve trick used with c-ares could leave allocated
memory in 'temp_ai' if the operation was aborted in the middle.
Daniel Stenberg [Thu, 27 Jan 2011 12:59:11 +0000 (13:59 +0100)]
ares_query_completed_cb: don't touch invalid data
When this callback is called due to the destruction of the ares handle,
the connection pointer passed in as an argument may no longer pointing
to valid data and this function doesn't need to do anything with it
anyway so we make sure it doesn't.
Bug: http://curl.haxx.se/mail/lib-2011-01/0333.html
Reported by: Vsevolod Novikov
Kamil Dudka [Thu, 27 Jan 2011 09:55:02 +0000 (10:55 +0100)]
nss: avoid memory leaks and failure of NSS shutdown
... in case more than one CA is loaded.
Bug: https://bugzilla.redhat.com/670802
Dan Fandrich [Thu, 27 Jan 2011 01:02:33 +0000 (17:02 -0800)]
Mention that sftp quote commands can be quoted
Daniel Stenberg [Tue, 25 Jan 2011 17:09:54 +0000 (18:09 +0100)]
tests: more multiple headers checks
Daniel Stenberg [Tue, 25 Jan 2011 11:06:50 +0000 (12:06 +0100)]
HTTP: memory leak on multiple Location:
The HTTP parser allocated memory on each received Location: header
without properly freeing old data. Starting now, the code only considers
the first Location: header and will blissfully ignore subsequent ones.
Bug: http://curl.haxx.se/bug/view.cgi?id=3165129
Reported by: Martin Lemke
Daniel Stenberg [Mon, 24 Jan 2011 21:18:43 +0000 (22:18 +0100)]
FAQ: clarify 5.13 how to stop a transfer
Guenter Knauf [Sat, 22 Jan 2011 08:52:09 +0000 (09:52 +0100)]
Fixed C++ style comment not allowed in ISO C90.
Dan Fandrich [Fri, 21 Jan 2011 22:27:10 +0000 (14:27 -0800)]
Mention axTLS in some more documentation
Daniel Stenberg [Thu, 20 Jan 2011 22:17:22 +0000 (23:17 +0100)]
runtests.pl: make -s not show skipped tests
Amr Shahin [Tue, 18 Jan 2011 22:39:47 +0000 (00:39 +0200)]
unittest: add 3 tests to test1300
Testing Curl_llist_insert_next
Darshan Mody [Thu, 20 Jan 2011 20:11:22 +0000 (12:11 -0800)]
Fixed compile using OpenSSL versions < 0.9.4a
Daniel Stenberg [Wed, 19 Jan 2011 22:14:55 +0000 (23:14 +0100)]
main: make the tlsauth options always present
... to not make the connection between the tool and the libcurl used
tighter than necessary, the tlsauth options are now always present but
if the used libcurl doesn't have TLSAUTH support it will return failure.
Also, replaced strncmp() with strequal to get case insensitive matching.
Daniel Stenberg [Wed, 19 Jan 2011 21:45:02 +0000 (22:45 +0100)]
symbols-in-versions: add the new TLSAUTH-SRP symbols
Daniel Stenberg [Wed, 19 Jan 2011 20:27:06 +0000 (21:27 +0100)]
configure: TLS-SRP wasn't added as a feature
Test case 1014 failed since TLS-SRP was correctly set to the features
variable so curl-config --features didn't output it.
Daniel Stenberg [Wed, 19 Jan 2011 20:02:54 +0000 (21:02 +0100)]
dist: add new certs to tarball
Quinn Slack [Wed, 19 Jan 2011 19:35:02 +0000 (20:35 +0100)]
TLS-SRP: support added when using GnuTLS
Daniel Stenberg [Wed, 19 Jan 2011 12:19:44 +0000 (13:19 +0100)]
CURLOPT_SSL_VERIFYPEER: more clarifications
The default value is 1.
curl _uses_ a default CA bundle, it doesn't install one.
Drop the references to 7.10 as that is now >8 years old!
Daniel Stenberg [Wed, 19 Jan 2011 12:06:36 +0000 (13:06 +0100)]
TheArtOfHttpScripting: extended
Extended the intial HTTP protcol part and added a mention of --trace and
--trace-ascii.
Replaced most URLs in the text to use example.com instead of all the
made up strange names.
Shortened a bunch of lines.
Daniel Stenberg [Wed, 19 Jan 2011 11:54:17 +0000 (12:54 +0100)]
curl_easy_setopt.3: clarify VERIFYHOST/PEER
Extended the descriptions somewhat and made the options get listed next
to each other.
Daniel Stenberg [Tue, 18 Jan 2011 22:41:57 +0000 (23:41 +0100)]
RELEASE-NOTES: mention contributors
Daniel Stenberg [Tue, 18 Jan 2011 22:40:48 +0000 (23:40 +0100)]
RELEASE-NOTES: synced with
7fcbdd68b9e
Guenter Knauf [Tue, 18 Jan 2011 14:02:45 +0000 (15:02 +0100)]
Fixed configure define for Win32.
Submitted by Vincent Torri.
Kamil Dudka [Tue, 18 Jan 2011 12:53:43 +0000 (13:53 +0100)]
nss: fix a bug in handling of CURLOPT_CAPATH
... and update the curl.1 and curl_easy_setopt.3 man pages such that
they do not suggest to use an OpenSSL utility if curl is not built
against OpenSSL.
Bug: https://bugzilla.redhat.com/669702
Guenter Knauf [Mon, 17 Jan 2011 00:27:57 +0000 (01:27 +0100)]
Avoid redefines.
Daniel Stenberg [Sat, 15 Jan 2011 21:46:03 +0000 (22:46 +0100)]
curl.1: fix spelling
Bug: http://curl.haxx.se/bug/view.cgi?id=3157232
Reported by: John Bradshaw
Guenter Knauf [Fri, 14 Jan 2011 11:39:54 +0000 (12:39 +0100)]
Added casts to silent gcc warnings.
Yang Tse [Thu, 13 Jan 2011 14:54:14 +0000 (15:54 +0100)]
build: BCC - makefile.b32 tweak
Get rid of stdout redirection to NUL and move stderr redirection
into RM and RMDIR macros.
Yang Tse [Thu, 13 Jan 2011 14:33:34 +0000 (15:33 +0100)]
build: BCC - makefile.b32 tweak
Check for BCCDIR environment var done now as other checks.
Guenter Knauf [Thu, 13 Jan 2011 04:55:09 +0000 (05:55 +0100)]
Use env var for PSDK instead of hardcoded path.
Guenter Knauf [Thu, 13 Jan 2011 01:55:26 +0000 (02:55 +0100)]
Enabled SSPI support by default.
Guenter Knauf [Thu, 13 Jan 2011 01:48:11 +0000 (02:48 +0100)]
Use MAKE macro with BCC targets.
Yang Tse [Wed, 12 Jan 2011 22:28:19 +0000 (23:28 +0100)]
docs - update BCC INSTALL section
Yang Tse [Wed, 12 Jan 2011 19:53:28 +0000 (20:53 +0100)]
build: BCC - require Borlands's MAKE for Makefile.b32 processing.
Yang Tse [Wed, 12 Jan 2011 17:07:04 +0000 (18:07 +0100)]
build: BCC - recover lost functionality from commit
3d813204260b37289411
Borland's $(MAKEDIR) expands to the path where make.exe is located,
use this feature to define BCCDIR when user has not defined BCCDIR.
Yang Tse [Wed, 12 Jan 2011 01:35:14 +0000 (02:35 +0100)]
build: use external preprocessor cpp32 when building with Borland C
Yang Tse [Wed, 12 Jan 2011 01:33:39 +0000 (02:33 +0100)]
build: allow usage of Borland 5.5.1 external preprocessor cpp32
Guenter Knauf [Tue, 11 Jan 2011 17:32:38 +0000 (18:32 +0100)]
Disable LDAP support since BCC headers are insufficient.
Guenter Knauf [Tue, 11 Jan 2011 17:22:42 +0000 (18:22 +0100)]
Instead of exiting with error lets set BCCDIR self.
Guenter Knauf [Tue, 11 Jan 2011 16:51:14 +0000 (17:51 +0100)]
Some Borland C++ makefile tweaks.
Guenter Knauf [Tue, 11 Jan 2011 16:40:13 +0000 (17:40 +0100)]
Borland C++ doesnt have struct sockaddr_storage.
Daniel Stenberg [Mon, 10 Jan 2011 23:14:36 +0000 (00:14 +0100)]
connect: use UDP correctly
The idea that the protocol and socktype is part of name resolving in the
libc functions is nuts. We keep the name resolver functions assume
TCP/STREAM and we make sure that when we want to connect to a UDP
service we use the correct UDP/DGRAM set instead. This bug was because
the ->protocol field was not always set correctly.
This bug was only affecting ipv6-disabled non-cares non-threaded builds.
Bug: http://curl.haxx.se/bug/view.cgi?id=3154436
Reported by: "dperham"
Quinn Slack [Mon, 10 Jan 2011 12:53:01 +0000 (13:53 +0100)]
SSL: fix memory leak
In OOM situation. Follow-up fix to commit
a9cd4f4ed49e1a0.
Daniel Stenberg [Wed, 5 Jan 2011 23:47:37 +0000 (00:47 +0100)]
gtls: fix memory leak
Bug: http://curl.haxx.se/mail/lib-2011-01/0079.html
Reported by: Quinn Slack
Marcel Roelofs [Wed, 5 Jan 2011 16:01:07 +0000 (17:01 +0100)]
HTTP: HTTP Negotiate authentication using SSPI
Only under Windows
Daniel Stenberg [Thu, 6 Jan 2011 22:41:01 +0000 (23:41 +0100)]
cmake: removed two files
CMake/CheckTypeSize.c.in and CMake/CheckTypeSize.cmake were removed in
the previous cmake commit
Dan Fandrich [Thu, 6 Jan 2011 07:53:24 +0000 (23:53 -0800)]
Made unit_setup() return an error code to abort the test early
This makes it possible to skip the call to unit_stop() in such
cases. Also use Curl_safefree() in unit test 1302 so it will
pass the memory torture test.
Daniel Stenberg [Wed, 5 Jan 2011 23:19:17 +0000 (00:19 +0100)]
SSH: speedcheck clobbered existing error
The just added speedcheck must not ruin the error code if already set
due to a problem.
Brad King [Wed, 5 Jan 2011 16:32:41 +0000 (17:32 +0100)]
CMake: Use upstream CheckTypeSize module
The CheckTypeSize module that comes with CMake 2.6.2 and above does
everything we need and also supports cross-compiling. Avoid duplicating
an older version of it here. This also fixes a cross-compiling error
because the old line
include ("${CMAKE_MODULE_PATH}/CheckTypeSize.cmake")
failed because CMAKE_MODULE_PATH is a search path and not a directory.
Signed-off-by: Brad King <brad.king@kitware.com>
Daniel Stenberg [Wed, 5 Jan 2011 13:09:53 +0000 (14:09 +0100)]
SSH: acknowledge speedcheck
Check for speedcheck limits during the state machine traversals
Daniel Stenberg [Tue, 4 Jan 2011 22:12:25 +0000 (23:12 +0100)]
tests: <info> tag corrections
Daniel Stenberg [Tue, 4 Jan 2011 22:10:45 +0000 (23:10 +0100)]
unittest: 1303 tests Curl_timeleft
I came up with 33 different ways to call it and verify that it returns the
correct return code.
Daniel Stenberg [Tue, 4 Jan 2011 22:09:19 +0000 (23:09 +0100)]
curlcheck.h: add fail()
fail is a new function/macro that a test case can use to indicate a test
failure for cases when the standard macros are not sufficient.
Daniel Stenberg [Tue, 4 Jan 2011 22:07:58 +0000 (23:07 +0100)]
Curl_timeleft: s/conn/data in first argument
As the function doesn't really use the connectdata struct but only the
SessionHanadle struct I modified what argument it wants.
Dan Fandrich [Tue, 4 Jan 2011 20:59:44 +0000 (12:59 -0800)]
Fixed path to allow out-of-tree builds
Kamil Dudka [Tue, 4 Jan 2011 12:52:54 +0000 (13:52 +0100)]
nss: avoid CURLE_OUT_OF_MEMORY given a file name without any slash
Bug: https://bugzilla.redhat.com/623663
Daniel Stenberg [Tue, 4 Jan 2011 15:51:41 +0000 (16:51 +0100)]
ignore: all executable unit test cases
Daniel Stenberg [Tue, 4 Jan 2011 15:50:59 +0000 (16:50 +0100)]
tests: add 1302 to the package
Daniel Stenberg [Tue, 4 Jan 2011 15:42:31 +0000 (16:42 +0100)]
unittest: test base64 encode/decode
Daniel Stenberg [Tue, 4 Jan 2011 15:41:42 +0000 (16:41 +0100)]
curlcheck.h: avoid using NULL pointers
Daniel Stenberg [Tue, 4 Jan 2011 15:31:54 +0000 (16:31 +0100)]
curlcheck.h: add verify_memory
This check verifies that a pointer contains the correct data.
Daniel Stenberg [Tue, 4 Jan 2011 15:14:23 +0000 (16:14 +0100)]
curlcheck.h: add newlines in error messages
Daniel Stenberg [Tue, 4 Jan 2011 15:13:58 +0000 (16:13 +0100)]
unittest: verify curl_strequal
Daniel Stenberg [Tue, 4 Jan 2011 09:20:28 +0000 (10:20 +0100)]
get_cert_chain: support larger data sets
512 bytes turned out too short for some data, so now we allocate a
larger buffer instead
Bug: http://curl.haxx.se/mail/archive-2011-01/0002.html
Daniel Stenberg [Mon, 3 Jan 2011 23:07:30 +0000 (00:07 +0100)]
RELEASE-NOTES: synced with
83e9fb21aabbec2
Daniel Stenberg [Mon, 3 Jan 2011 22:47:34 +0000 (23:47 +0100)]
curlcheck.h: add fail_if() fix code
The UNITTEST_START and UNITTEST_STOP defines needed to do a new brace
level so that test cases can declare variables fine and still remain
fine C89 code.
Daniel Stenberg [Mon, 3 Jan 2011 22:47:13 +0000 (23:47 +0100)]
unittests: basic docs
Daniel Stenberg [Mon, 3 Jan 2011 21:52:50 +0000 (22:52 +0100)]
ignore: unit test files
Daniel Stenberg [Mon, 3 Jan 2011 21:42:46 +0000 (22:42 +0100)]
unittests: a dedicated feature in tests
The test runner script now knows if unittests can run and the unit test
setup file says it is one. I also made runtests.pl deal with no
<command> tag set, so that the description file can get even simpler.
Daniel Stenberg [Mon, 3 Jan 2011 21:16:16 +0000 (22:16 +0100)]
unittesting: build a separate static lib
When configure --enable-debug has been used, all files in lib/ are now
built twice and a separate static library crafted for unit-testing will
be linked. The unit tests in the tests/unit subdir will use that
library.
Daniel Stenberg [Sat, 1 Jan 2011 16:33:42 +0000 (17:33 +0100)]
unittest: framework for unit-testing
This is the first approach at doing fairly clean and easy to write and
debug unit tests.
Daniel Stenberg [Mon, 3 Jan 2011 12:34:13 +0000 (13:34 +0100)]
SSH: avoid PATH_MAX with alloc
We cannot assume that PATH_MAX will be enough for the remote path name
so allocating room for it is the only sensible approach.
Daniel Stenberg [Mon, 3 Jan 2011 08:40:40 +0000 (09:40 +0100)]
TODO: get rid of PATH_MAX
Daniel Stenberg [Sun, 2 Jan 2011 22:41:49 +0000 (23:41 +0100)]
Curl_nss_connect: avoid PATH_MAX
Since some systems don't have PATH_MAX and it isn't that clever to
assume a fixed maximum path length, the code now allocates buffer space
instead of using stack.
Reported by: Samuel Thibault
Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=608521
Daniel Stenberg [Sat, 1 Jan 2011 14:35:53 +0000 (15:35 +0100)]
SFTP: make pwd output result to header callback
Sending "pwd" as a QUOTE command only sent the reply to the
DEBUGFUNCTION. Now it also sends an FTP-like header to the header
callback to allow similar operations as with FTP, and apps can re-use
the same parser.
Daniel Stenberg [Sat, 1 Jan 2011 14:33:57 +0000 (15:33 +0100)]
pubkey_show: allocate buffer to fit any-size result
The loop condition was wrong so keys larger than 340 bits would overflow
the local stack-based buffer.
Daniel Stenberg [Thu, 30 Dec 2010 22:49:03 +0000 (23:49 +0100)]
CURLINFO_FTP_ENTRY_PATH: sftp support
Luke Amery [Thu, 30 Dec 2010 01:43:45 +0000 (12:43 +1100)]
ssh: honour the CURLINFO_FTP_ENTRY_PATH curl_getinfo option
Pierre Joye [Tue, 28 Dec 2010 18:55:00 +0000 (19:55 +0100)]
IDN: use win32 API if told to
The functionality is provided in a new source file: lib/idn_win32.c
Yang Tse [Tue, 28 Dec 2010 15:52:20 +0000 (16:52 +0100)]
test harness: take in account that Windows does not support LD_PRELOAD
configure.ac: Test harness libhostname library will not be built for Windows.
runtests.pl: LD_PRELOAD mechanism will not be used to load libhostname
library on operating systems which lack LD_PRELOAD support.
Daniel Stenberg [Mon, 27 Dec 2010 08:55:13 +0000 (09:55 +0100)]
c-ares: fix cancelled resolves
When built IPv6-enabled, we could do Curl_done() with one of the two
resolves having returned already, so when ares_cancel() is called the
resolve callback ends up doing funny things (sometimes resulting in a
segfault) since it would try to actually store the previous resolve even
though we're shutting down the resolve.
This bug was introduced in commit
8ab137b2bc9630ce so it hasn't been
included in any public release.
Bug: http://curl.haxx.se/bug/view.cgi?id=3145445
Reported by: Pedro Larroy
Brad Hards [Sat, 25 Dec 2010 01:13:43 +0000 (12:13 +1100)]
Typo / spelling fixes.
Brad Hards [Sat, 25 Dec 2010 00:56:04 +0000 (11:56 +1100)]
Use angle address, as for the rest of the example.
Also spelling fix for RECIPIENT #define.
Brad Hards [Sat, 25 Dec 2010 00:54:41 +0000 (11:54 +1100)]
Add angle brackets to addresses in easy SMTP examples, as for smtp-multi example.
Daniel Stenberg [Thu, 23 Dec 2010 21:52:32 +0000 (22:52 +0100)]
cookies: tricked dotcounter fixed
Providing multiple dots in a series in the domain field (domain=..com) could
trick the cookie engine to wrongly accept the cookie believing it to be
fine. Since the tailmatching would then match all .com sites, the cookie would
then be sent to all of them.
The code now requires at least one letter between each dot for them to be
counted. Edited test case 61 to verify this.
Daniel Stenberg [Thu, 23 Dec 2010 21:19:25 +0000 (22:19 +0100)]
multi: connect fail => use next IP address
When using the multi interface and connecting to a host name that
resolves to multiple IP addresses, there was no logic that made it
continue to the next IP if connecting to the first address times
out. This is now corrected.
Daniel Stenberg [Thu, 23 Dec 2010 21:18:16 +0000 (22:18 +0100)]
smtp-multi: put recipient within <brackets>
Even if libcurl might to do it for us, it is more correct.
Daniel Stenberg [Thu, 23 Dec 2010 13:36:07 +0000 (14:36 +0100)]
ossl_seed: no more RAND_screen
RAND_screen() is slow, not thread-safe and not needed anymore since OpenSSL
uses the thread-safe win32 CryptoAPI nowadays.
Daniel Stenberg [Wed, 22 Dec 2010 14:29:21 +0000 (15:29 +0100)]
multi: inhibit some verbose outputs
The info about pipe status and expire cleared are clearly debug-related
and not anything mere mortals will or should care about so they are now
ifdef'ed DEBUGBUILD
Daniel Stenberg [Wed, 22 Dec 2010 13:53:13 +0000 (14:53 +0100)]
SMTP tests: updated MAIL FROM use
They were all wrong previously since none used the <brackets> they
should for MAIL FROM. Now libcurl adds them itself if the app doesn't so
they end up wrong less easy.
Daniel Stenberg [Wed, 22 Dec 2010 13:44:10 +0000 (14:44 +0100)]
CURLOPT_MAIL_FROM: document the bracket situation
Brad Hards [Wed, 22 Dec 2010 13:41:53 +0000 (14:41 +0100)]
SMTP: add brackets for MAIL FROM
Similar to what is done already for RCPT TO, the code now checks for and
adds angle brackets (<>) around the email address that is provided for
CURLOPT_MAIL_RCPT unless the app has done so itself.
Guenter Knauf [Wed, 22 Dec 2010 03:45:41 +0000 (04:45 +0100)]
Added support for axTLS to NetWare build.
Guenter Knauf [Wed, 22 Dec 2010 02:34:13 +0000 (03:34 +0100)]
Fixed include: memory.h -> curl_memory.h.
Brad Hards [Wed, 22 Dec 2010 00:57:48 +0000 (11:57 +1100)]
smtp-tls: add a missing newline
Without this you won't get the next (Subject) line.
Brad Hards [Sat, 18 Dec 2010 23:22:44 +0000 (10:22 +1100)]
Typo fixes.
Patrick Monnerat [Tue, 21 Dec 2010 13:23:37 +0000 (14:23 +0100)]
New curl/curl.h definitions added to ILE/RPG binding.
Yang Tse [Mon, 20 Dec 2010 23:14:55 +0000 (00:14 +0100)]
build: sort configuration hunks in lib/Makefile.vc6
sorted to reflect same internal order as the one shown
in the usage message.
Daniel Stenberg [Mon, 20 Dec 2010 21:21:06 +0000 (22:21 +0100)]
getparameter: add error check
if add2list() returns an error, bail out!
Daniel Stenberg [Mon, 20 Dec 2010 21:17:41 +0000 (22:17 +0100)]
loadhostpairs: return errorcode
Make sure that Curl_cache_addr() errors are propagated to callers of
loadhostpairs().
(this loadhostpairs function caused a scan-build warning due to the
'dns' variable getting assigned but never used)