Refactor duplicated SCons/Python test run code.

Moved duplicated code test run code to a Python module under
tools/scons.  Support for Valgrind suppressions was also added.

Change-Id: I31d0bf7879116a358439e387dcd5fd87bbbecc9d
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1678
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Changing occlient get request query

Since the server starts on any random port, the test
engineers have to do a multicast discovery before sending
a unciast request. Increasing the request query "power" value
to account for this delay. This is related to IOT 610.

Change-Id: Ibc5805cc2dc4a7236800230ab380aa7a1481edd0
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1698
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Mark Tung <mark.y.tung@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added new OCStack Error Code for Unauthorized Req (IOT-609)

A Server can deny a REST request from a Client if
'Access Control List' does not authorize the request.
Server returns CoAP 401 error code to Client originating the
request. RI layer at client incorrectly translates it to
OC_STACK_ERROR which does not provide specific failure reason
to Client Application.

Change-Id: I127060d186a021c676c36bc6148e264bdcb60fde
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1684
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Memory Leak recources not released in case of failure.

Multiple Mutex are initialized in this function, if one of them fails
previous allocated resources should be released.

Change-Id: I869cfce4dce6c3858443833df523b6234eae3761
Signed-off-by: Vikas Gupta <vs.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1664
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Enabled EDR and BLE adapter in RI

- Added EDR and BLE connectivity types for sending Response.
- Parsing of EDR and BLE adapter address in Request URI.

Verification of IP and EDR adapter was done in Tizen with the above changes.

Change-Id: I70ebc099497ab744c4d822e65c94e0610d338e13
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1634
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update soft-sensor-manager to use updated OIC Virtual Resource definitions

modify ssm resource finder to use changed OIC Virtual Resource
and to get connectivity type of found resources

Change-Id: Ia91fa7e1aed17f614c1dbc5bae9cc37668091174
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1686
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Changed TAGs in CA source files to be more specific.

TAGs in almost all source files were just "CA".
Changed them to be more specific to help when looking at the logs.

Change-Id: I895e9c29c66fc8b61dde43177954affd1534c708
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1679
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak in CA android sample

Endpoint allocated memory in CA sample is not freed.

Change-Id: I3a8b2716a469b808a788952866709bf188ad0e56
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1635
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Removing unnecessary code for ca samples

after recent ipv6 plumbing changes, this code is not used
hence removing the unused code

Change-Id: I0e3b0cd1aee394fcba2a35f0021ed3a2f7068352
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1630
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

things-manager: change file permission of cpp files

Removed the execute permission for the source (.cpp) files from things-manager.

Change-Id: Id5290623f6fc68fe5cc6d623b93eae0e72a2998a
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1670
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Add check for dos2unix package in build process.

This check will prompt the enduser to retrieve the package themselves.

Change-Id: Ic58302f1491ac787822f70ed43939eca81c746f7
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1652
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

put NULL check and corrected the debug log in CASendThreadProcess

Change-Id: I49d3dd4afb71724e6a17cbfb43e777a1efae20e9
Signed-off-by: sonu1.yadav <sonu1.yadav@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1643
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed broken platform and device discovery

The stack result was not being set on forming
the payload. Also, the device payload was being set
into the incorrect variable.

Change-Id: I18875b9ba0bd9776f0914317617c3c5d66ed64f8
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1681
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Improve logging in the stack.

Log messages in the stack mostly hinted at WHERE the call flow was
going.
Added logging to say WHAT the execution is doing. Helps tremendously
with debugging the logs if we can see what important params are passed
into functions.

Change-Id: I50a2ebf4be2d4eea527015cad01d27e5d03e6004
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1640
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated android examples to use OcConnectivityType.CT_DEFAULT since
IPV4 is no longer supported

Change-Id: Ie158c53924d934cd83450297e125c61d71b6bc79
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1677
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed Double-passing in the cbor parser

The Cbor Parser incorrectly missed a break in the parsing
after a double.  This patch repairs that, plus fixes some of
the spacing issues that seem to have come in due to a find/replace

Change-Id: Ife48886bc8d1391cd7e7361ea49eb3aff318431d
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1676
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Removed Dead Code from CBOR merge

Somehow a bit of code from the OCSerialization.h got left
over from the development process.  This commit removes it,
since it is dead code.

Change-Id: I9b692086f3a00b5ff0f4e1b38c25239fe9d40b96
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1675
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixing collection samples

Wrong property name was being used for resource and
values being added incorrectly to the payload after
CBOR changes.

Change-Id: Id3e4c8c20bae0feee33efb1f5c1479da76f680c9
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1673
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Removing unnecessary use of IPV6 flags.

Previously, default flags were interpreted as both
IPv4 and IPv6 and "[ ]" was added around the IP address
in presence uri. This was wrong for IPv4. Changing the
addition of brackets exclusive to IPv6 and removing IPv6
flag from caipserver since it is not supported yet.

Change-Id: Ic103f9f0f10dcda3252e95404bc6f1a19d56597b
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1653
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Merge "Merge 'security-basecamp' branch into master with CBOR"

Merge 'security-basecamp' branch into master with CBOR

security-basecamp for 0.9.2 is merged in master brach.

Change-Id: Ia5cd2710a688d3e631009ed03f7e5eb97aba5d24
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>

fixed linux, android sample app in CA

- add the payload length
- resolve the compile warning

Change-Id: I2766090765790283afecc05f052ec77b85252334
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1658
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

add descriptor in andorid BLE server

actually, it had removed previously for Tizen 2.4
but as not only Tizen 2.4 delay to release but also
OIC spec/linux BLE is supporting descriptor.
we decided that it should add.

Change-Id: I07e8b42e566d56d71bd65f5b590f40484c4a8492
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1656
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix Discovery Payload parsing for Secure Port

Discovery response with CBOR was not parsing Secure Port info
in Policy Node.

Change-Id: I8db9e38dc08c3153ab62d58c8ac6fe6872eede7c
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1650
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Improved OIC Virtual Resource definitions (IOT-603)

There were multiple instances of same virtual resource strings
within C stack. This was a cause of 'many' recent un-intended bugs
in the Ioptivity stack. Updated octypes public interface to publish
'reserved' virtual resources and those can be used by applications.
Also updated associated sample applications.

Change-Id: I587727a63dace0086cc27b994bdf238ad203daa4
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1620
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix Discovery Payload

We were accidentally accessing the resource types
instead of interface name when doing discovery response.
The issue could be seen on running collection samples.

Change-Id: Iabd132e1a8b85b1c8f9890ae2db1a35983bee938
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1651
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

CBOR rebase onto master for merge/review

The CA layer has been converted to use binary data, rather
than string data to support CBOR as a transport.  The CSDK has
been changed to use the OCPlatform object model instead of json
strings.  Underneath this, the JSON encoding has been replaced
with CBOR.

Also, some of the previous blockwise transfer functionality has
been removed, since the blockwise-transfer functionality has been
pushed ot the CA stack.

Change-Id: I6423a5180643cea3d311ec7497b246117f7c02b0
Signed-off-by: Erich Keane <erich.keane@intel.com>
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1613
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix for the Jira issue IOT-524

This patch addresses the first part of IOT-524.
Added the --prefix option to install all the build output files
in the user preferred location, if opted for.
All exe files will go into PREFIX/bin and all library files will
go into PREFIX/lib
For ex: /home/XYZ/bin and /home/XYZ/lib

Change-Id: Id1ab0fe0ca0ed0b3b86095df87f172448c366daf
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1439
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

remove unnecessary codes in android BLE

there are many unnecessary wait/mutex/flag.
it will bring slow performance.

Change-Id: I8cb9c4c93d522c5c32669aab569da1a6ff22511a
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1617
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix IOT-605: fridgeclient executable's abnormal termination

Change-Id: Idcfcd4296d76742859e10b44f36f3ca56ce76ca0
Signed-off-by: sonu1.yadav <sonu1.yadav@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1644
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Implemented C++/Android API for OCRegisterPersistentStorageHandler()

Add C++ secure sample client and server test app using c++ persistent
storage handler.
Add Android secure sample client app with persistent storage API.

[Patch set 2]: 1. Enhanced Android secure_simpleclient app to choose SVR DB file.
       2. Fixed setting.gradle for android sample.
               3. Add UTC for Persistent Storage in Plaform Config.
[Patch 3]: 1. Fix Sconscript to install SVR DB file for unit test.
[Patch 4]: 1. Fixed jenkins build break.

[Patch 7]: Fixed build issue due linux provisioning client during andriod build.
[Patch 8]: removed secure_simpleclient/server and modified simpleclient/server
[patch 10]: Removed Dialog box for db file selection.
            Modify simpleserver for PS changes.
[Patch 11]: Addressed Review Comments.
[Patch 13]: Rebased to security-basecamp branch
[Patch 14]: Updated Android Server sample to publish non-secure resource
    (otherwise it will break Android client-server non-secure
     test case)

Change-Id: Ica2fc26e65b228a02bc400f87e9780798c19c700
Signed-off-by: Sandeep Sharma <sandeep.s9@samsung.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1491
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed broken observation cancellation.

Observe Cancel was broken because the uri from the client callback was
not copied into the request object. This caused connectivity to eat the
request witout sending it out.

Change-Id: Ib0ab815647897f2815fdffc3011e9977a003ac5f
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1637
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed Fridge sample with constructResourceObject

The constructResourceObject takes a host string, which isn't compatible
with the current OCDevAddr address.  This patch parses said string, and
converts it properly to an OCDevAddr.

Change-Id: Id86f3832e596aa8869794a1d33915e158fe85008
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1624
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed CA request/response handler over write issue

ocstack register HandleCARequest and handleCAResponse using CARegisterHandler
and save values in global variables to handle request and response.
Provisioning API is also using CARegisterHandler and over writing those handlers.
This change resolves this issue.

Change-Id: Id8d86edb487e58ad1c6a5ed5b0211c4b8b28cd6e
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1577
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

In case of Just works provisioning,
Close the temporary dtls session after the ownership transfer.
Now, PT will use the PSK based session for ACL provisioning.

patch#6 : rebase with master
patch#8 : Fix the ownership transfer. But ACL provisioning will still fail.
patch#10 : Change to the copy CAEndPoint_t of addDevice() using memcpy
patch#12 : Resolve provisioning credential issuses.
          (missing the provisioning status intialization to the provision of
           two or more times.)
patch#14 : Resolved mem leak in sendCARequest(). Updated doOwnershipTransfer()
   to disable anon ECDH before leaving the method.
patch#15 : Remove .gitignore which was added accidently in previous patch.
patch$16 : Remove the code that invokes the CASelectCipherSuite().

Change-Id: I5e5ef061c46c4a81615cd923dc915fc028699d74
Signed-off-by: leechul <chuls.lee@samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1628
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fixed Secure Resource Mgr Policy Engine to allow for wildcard resource URIs.

The Policy Engine was not checking for wilcard resource URIs in Access Control List entry (URI = "*"); this has been added per Security Spec A v0.96r3.

Change-Id: Iff6d8618cee2d177aa1b03dc3c58a78cd1fd6061
Signed-off-by: Nathan Heldt-Sheller <nathan.heldt-sheller@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1626
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Fixed broken presence after IPv6 plumbing merge to 

Presence wasn't working for multiple reasons. oc/presence was not moved
to oic/ad, probably lost in the merge to master.
resourceUri in CA data structures was moved form the endpoint to the
CAInfo struct. But wasn't included in a clone operation which resulted
in a race condition when the memory was free'd in the main thread before
being accessed by the thread in CA.
Other adapter/flag issues.
Unicast presence failed to work because host() from OCResource only
returned the IP without the port.

Change-Id: If2e46f4677ebe369cbaee9609de38c369bf4c524
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Signed-off-by: Erich Keane <erich.keane@verizon.net>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1424
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Changed C Samples to use correct adapter type

The  C Samples were broken as a result of changing
the samples for IPv6. Also, removed port 6298 from
unicast discovery query and replaced some printf()
with OC_LOG(). Removed Differentiation between
IPv4 and IPv6 in the samples.

Change-Id: I83859aaf468c991ca5406014359476d0f43d5745
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1623
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed an invalid read/write caused by deleted temporary

The copy used a std::copy mechanism on optionData, which
resulted in the temporary being deleted before the function
returned.  This creates a variable to hold the temporary so that
the string won't be deleted before use.

Change-Id: I5da2601b730e27d42e244b52ba6cdd69a0e28fb4
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1622
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Updated Secure Sample for new resource discovery response

Resource Discovery response was udpated to be compliance with
OIC Specification. This change is to correctly parse the
discovery response.

Change-Id: I3c16f0ed827f5f993def01e7741c592b1ad1926b
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1614
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>

Add Destructor to free new allocated resource in Ctor.

~Middle() and ~RestInput() destrcutors added which deletes allocated
memory in Ctors.

Change-Id: I29823cde6c7b28325fde9b40f088f83994ebc6a5
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1522
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

csdk: Fixes cppcheck issue in security dir.

This patch fixes the the below issue reported by cppcheck tool in security dir:
"(error) Possible null pointer dereference: jsonObj - otherwise it is
 redundant to check if jsonObj is null at line 259
(error) Possible null pointer dereference: jsonStr1 - otherwise it is
redundant to check if jsonStr1 is null at line 132"

Null value check of jsonObj and jsonStr1 are removed as it in unnecessary here.

Change-Id: I6c0676a58780afea3026c3e1332c8ecac7c0dd1e
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1508
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[CA] RI sample occlient fix for not able to send get unicast data

fixed OCconectivity type and port number adding to uri

Change-Id: Ie99e66dd6c7840008d9f0cfc41089d183907c585
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1503
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated android BLE code

I have replaced previous property and permission code
with Property_Notify which mentioned OIC ble spec.
(https://workspace.openinterconnect.org/
 apps/org/workgroup/oswg/download.php/1568/
 OIC_BLE_Transport_Profile.pdf)

Change-Id: I7002ba70c9f0d267ef9f695c0cb3ee3688dd9a77
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1532
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated the comments as per Jira IOT-573

Please update

Change-Id: Idd318b1f6d2359deb1653b323d35159ffb9fbd8f
Signed-off-by: sanilgupta <sanil.g@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1473
Reviewed-by: Ravi Nanjundappa <nravi.n@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Replaced printf with Serial.println() in arduino CASample

Change-Id: I8ab085b2ca330789255d8397d42cf483a9d97187
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1600
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix Android TinyDtls build issue in Debug mode

For Android build currently debug.c is not included.
In this case NDEBUG flag must be defined.
Provided a correct fix

Change-Id: Icaa4364a3e87bc33e9e7165977838ba1ea328506
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1618
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Pandey <abhi.siso@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Resolved compilation issues of BLE adapter in Tizen and Arduino

Change-Id: If9c4d1ade926733a3959808e9b3cfc6880e91cb3
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1594
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Updated gitignore to ignore dependencies folder

Ignore 'dep' folder created in iotivity tree when
android build is invoked.

Change-Id: Ibd9630a9d4327c44518d632fb8f39ffd3509b9f3
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1615
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix failure to respond when SRM says Access Denied.

The enum types for forbidden request and unauthorized request in
CAResponseResult_t added as part of security where misisng in a sanity
check switch case. This caused the forbidden and unauthorized response
codes to be classified as invalid.

Change-Id: Idc53a50422e3d5e43a847395a2389da351ea6baf
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1610
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: Sachin Agrawal <sachin.agrawal@intel.com>

Updated android code based on OcConnectivityType changes due to IPv6 support

Change-Id: Ic3c332dc72c5ab87f971b346eae0cb5456ac58a7
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1495
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Bernie Keany <bernie.keany@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Adding GuiClient example for android

Change-Id: I4c0930032ccfc7814965f152846d16561bd3ed76
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1543
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fixed Tizen CASample to select proper Transport type.

Change-Id: I74c8cc3a768501c8620b9f558a1e15da04d79e08
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1596
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[Tizen][DTLS] Fix for broken DTLS build in Tizen

Fixed broken DTLS build in Tizen

Change-Id: If281be0640fd11a830655102bc9cd091a82a0df8
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1599
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

modify the preprocessor to stop the thread in ipadapter

In case I use a ndk-build for android sample build,
the MULTI_THREAD is not defined.
because preprocessor was defined within Sconscript.
so I modified the code to stop the send thread.

Change-Id: I732fad2120fe243b6b976230aa395fdbb385dda1
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1588
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[Tizen][BLE] Fix for broken BLE build

Fixed broken BLE build for Tizen

Change-Id: I508404f97ef5ef19f1b9820519e44c1d911158da
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1601
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak in policyengine

Temp allocated memory in policyengine is unsed and not freed before
exit.

Change-Id: I1a1f3587c521b83ba764248f00547a2e8997c865
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1592
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Tested-by: Sachin Agrawal <sachin.agrawal@intel.com>

things-manager: sampleapp: fix name of musicplayer

The musicplayer should be named MusicplayerApp as it is referenced
under that name some lines below.

Change-Id: I351ee4316bbb19a67a0afc16882cb2192a2ff07f
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1445
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Changed discovery JSON for spec compliance to contain device ID.

New json schema does not have properties field for resources.
Everything is now a property.
Device ID as string UUID is included in discovery responses once per
response as opposed to being a part of every resource earlier.

Device Ids as part of every resource rep is also accepted and will be
used in resource construction if present.
Refactored filtering and encoding for resource into separate functions.
Removed unnecessary repeated strcmp() to figure out type of virtual
uri.

Change-Id: Ib995e819c8ab63aae6abff956941698d6919f9c4
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/934
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix string copy issue in Credential resource unit test.

Update getCredList to correctly pass length of destination buffer while
using OICStrcpy.

Change-Id: I4763d295fc1da92831956bf9ed4a34e90718c7f3
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1553
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>

Integrated single/multi thread for interface controller and connectivity manager.

Merged serperated files by using #SINGLE_THREAD and #MULTI_THREAD flags.

Signed-off-by: jw1103.kim <jw1103.kim@samsung.com>
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Change-Id: I2d7b38d86226bdfc03c7a7b12626c2c4459ad305
Signed-off-by: jw1103.kim <jw1103.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/783
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

things-manager: Fix cppcheck issues in TMSampleApp for tizen

This patch fixes the below issues
reported by cppcheck tool in TMSampleApp dir for tizen.
"(error) Possible null pointer dereference: popup_fields ...."

It is invliad to set the member of popup_field to NULL if
popup_field itself is NULL.
Removed such statements from the code.

Change-Id: Ie1457662cb2727e5bab5e21886db6bece2f356a7
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1511
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

soft-sensor-manager: Fixes cppcheck issue for arduino SampleApp

This patch fixes the the below issue reported by cppcheck tool
in stack dir: "(error) Possible null pointer dereference:
entityHandlerRequest - otherwise it is redundant to check if
entityHandlerRequest is null at line 114"

Dereferencing of entityHandlerRequest->resJSONPayload is done if
flag includes OC_REQUEST_FLAG.

The patch also includes removal of some unnecessary blank lines

Change-Id: I8d9d7c40df5602b9d55de8d948871a2c485798a2
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1510
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix for a previous check-in related to secure resources

In case where resources are not SECURE, port does not need to be set.

Change-Id: Ic1559534ccd8b002ecd862775ca8a07aa62b356f
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1563
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Updated C++ SDK for discovering secure resources

On discovering secure resources, OCResource object needs to be
updated with 'secure' flag and appropriate port for secure resource.

Change-Id: I0a09ae1e6d9bcc73b7d97b9dcaae02955d63cb2d
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1545
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: sandeep sharma <sandeep.s9@samsung.com>
Reviewed-by: Woochul Shim <woochul.shim@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

integrated caretransmission single/multi thread

Merged serperated files by using #SINGLE_THREAD flags

Change-Id: I8c0162b6220a221146ffa1428f25612aa0cfc0c4
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/950
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

fixed Android Sample App build issue

to import Log was missed
so it was not built

Change-Id: I702b220bddd9ba0243a47eeca718326eb17fa9f6
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1561
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix defects of IOT-534 in Things Manager

Exception handling logic is added in group application.
startPresence for enabling presence check is added in speaker and musicplayer apps.

Change-Id: I12f6589154e27d288417d3fdd6413b867499a2bf
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1547
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Add handling for error case in GroupManager::getActionSetfromString.

Delete action in case something went wrong during parsing.

Change-Id: I0e72db223ef21d0e89351d238532e168b2ca1177
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1523
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix a potential crash in PPM, in case of incomlete xml.

Handle the case when pluginInfo tag is missing in the Configuration
file.

Change-Id: I0bc8e14a875a71bd2254d5ef917b3dc7652339f8
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1538
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix delete array memory issue

Memory assigned with new array is deleted with non-array delete

Change-Id: I7e3411104d805bab66a863fb2814e93def897def
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1429
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix some string used for group management feature

1. Instead of "oc", "oic" is used for decoding a JSON request in group management.
2. There are a difference of group interface string in octypes.h and ocapi.h.
   "oic.mi.def" will be used in the both.

Change-Id: I79763315926dc6e6bba3444db5ed94a68db65eb2
Signed-off-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1527
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: Junghyun Oh <junghyun.oh@samsung.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Resolved Tizen build issue

Change-Id: I8271eaf5f6a80b9efff5a1030ee94d91ab4569b4
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1533
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak in IP Monitor for tizen.

In CAWIFIConnectionStateChangedCb, netInfo pointer not freed.

Change-Id: I186ffd6ddc43a1fff717a06a6d8f445ba8165691
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1518
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

things-manager: Fix cppcheck errors

This patch fixes the errors reported by cppcheck tool for '(error) Mismatching
allocation and deallocation: newActionSet'.
Replaced free() calls with delete wherever the memory is allocated using new().

Change-Id: Icc22a8c7658c29afb8ed60b5cd9926e69ce3e6fb
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1506
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix memory leak in oicgroup file of cstack.

ClientRequestInfo *info memory leaked in case of SendAction() method
failure called in DoAction().

Change-Id: I81de9f0765cd9fdd3387ff98f6975df146dbbc2a
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1521
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Jihun Ha <jihun.ha@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix memory leak in SSM processQueryResult.

Update logic in CQueryEngine::processQueryResult to free
pDataReader in case of error.

Change-Id: I14cb27cd5c56731632fc6288cec555807f96ba97
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1520
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix memory leak in SSM executeContextQuery.

Update logic in CQueryEngine::executeContextQuery to free
clsContextQuery in case of error.

Change-Id: Ife66485b61a5f64ff5f190787482cdf6737850dd
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1519
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fix memory leak in SSM Sensor Processor

Fix memory leak in CResourceFinder::onExecute. Delete resource handler
in case of Error.

Change-Id: I3d2363ed0b2585ffcbc403417fd73f60e89f1a88
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1490
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

protocol-plugin: sample-app: add missing lib to mqttclient

The mqttclient file does not link successfully on OpenWrt with boost
1.58.0. Without this patch I am getting this error message:

out/linux/arm/release/service/protocol-plugin/sample-app/linux/mqtt/mqttclient.o: In function `_GLOBAL__sub_I_mqttclient.cpp':
mqttclient.cpp:(.text.startup+0x7a0): undefined reference to `boost::system::generic_category()'
mqttclient.cpp:(.text.startup+0x7a8): undefined reference to `boost::system::generic_category()'
mqttclient.cpp:(.text.startup+0x7b0): undefined reference to `boost::system::system_category()'
out/linux/arm/release/libppm.a(PluginManager.o): In function `_GLOBAL__sub_I_PluginManager.cpp':
PluginManager.cpp:(.text.startup+0x8): undefined reference to `boost::system::generic_category()'
PluginManager.cpp:(.text.startup+0x1c): undefined reference to `boost::system::generic_category()'
PluginManager.cpp:(.text.startup+0x28): undefined reference to `boost::system::system_category()'

Change-Id: Ib5728b37609de6b9b426888c77eb3522eb5e0b7d
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1446
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

stack: Fixes cppcheck issue in ocserverrequest

This patch fixes the the below issue reported by
cppcheck tool in stack dir:
"(error) Possible null pointer dereference:
ehResponse - otherwise it is redundant to check if
ehResponse is null at line 445
"

Dereferencing of ehResponse is done after NULL check.

Change-Id: I9cc20ce2386b5bdb08c4d9f9dbd2d143040f9a0f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1509
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: Erich Keane <erich.keane@intel.com>

csdk: Fixes issue reported by cppcheck tool

This patch fixes the the below issue reported by cppcheck tool:
"(error) Possible null pointer dereference: ReqInfo - otherwise it is
redundant to check if ReqInfo is null at line 234".

Null value check of ReqInfo is removed as it in unnecessary here, as this check is
already done and OIC_LOG_BUFFER is just printing the content of ReqInfo->info.token.

Change-Id: I8c15d8b582135c445fe89350dc67812e531c52d3
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1507
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Integrated singlethread and multithread files of BLE adapter.

Removed all "_singlethread" files related to BLE adapter.

Change-Id: Idad8e8a488d7b2d742f7082116f9bd4895175d8f
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1035
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Distributed Resource Hosting Sample App and ResourceHosting for JAVA API folder.

- Added new folder in NotificationManager folder
- "/NotificationManger/android/resource_hosting"

Modified notification-manager's Sconscript

- ~_JNI.cpp file is not included in Sconscript.

Changed folder name : ResourceHostingSampleApp->SampleResourceHosting

Deleted files : resourceCoordinator_JNI.cpp and resourceCoordinator_JNI.h in Notification/src folder.

Modified about ResourceHosing_JNI.h path is relative path to absolute path in ResourceHosing_JNI.cpp
Added "OCProcessFunc"'s  return value : none -> return;

Change-Id: I2c44c31f1399ca9722c4f2281ec2b8af1646ed21
Signed-off-by: doil.kwon <doil.kwon@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1487
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Integrated IP adapter Singlethread and Multithread files

Removed all "_singlethread" files related to IP adapter.

Change-Id: I8a096ca6b28f74afaa8d122bf416cb4b0733f185
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1010
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Update to OICSensorboard example

Change OC_ALL to CT_DEFAULT in client.cpp to compile with the latest API

Change-Id: I4654afefc72f9a95a41a23e36ed4f3172afe414d
Signed-off-by: Juliet Cai <juliet.z.cai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1493
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

fixed memory leak in CA

As the uri is moved from Endpoint to CAInfo structure currently.
but 'free()' was not updated at that time.
so 'free()' is also need in here and there.

Change-Id: I1b3429c29c769c5920dd427688e97b517dd94f66
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1488
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix send LE adapter sendRequestToAll

Change-Id: I5892851829b56e4a52d5b66d1711554b4b7c4530
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1458
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added camutex no operation file.

This change will be used for singlethread and multithread integration
to avoid the usage of #ifdef around camutex api's.

Change-Id: Ie483c16cd0ac1d194a77fd94a8b9dd459e75509a
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1455
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Changed BLE UUID defined in Tizen according to OIC Spec

Change-Id: I92dd97c6176484c621f37d6d946aee683c3da35d
Signed-off-by: vimala.v <vimala.v@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1475
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Added platform information to the android code, as per the spec compliance changes

Change-Id: I78fba71991d8e9da92f706f26166be86a6704c7c
Signed-off-by: Rahul Rahul <rahul.rahul@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1443
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

[CA] Fix for DTLS secure unicast port.

Not to set "reuse_address" option when secure unicast port is requested.

Change-Id: Ieffa4fda038946a02c500aa43a85041a2a3b77b3
Signed-off-by: koushik.girijala <g.koushik@samsung.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1440
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Adding IPv6 changes in Sample Apps.

This change is part of Multiadaptor/IPv6. Sample Apps needs to be updated to allow available
and currently suppoted connectivity types.

Change-Id: I701027d599e53183673abe2afd7b0f1a5fade885
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1406
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Restore host string behavior lost in IPv6 plumbing patch

Change-Id: Ia7120dd3d361e717f2a04782c3b59bdb841bc8bc
Signed-off-by: John Light <john.j.light@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1430
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

replaced uuids in Android BLE

I have replaced current uuids in android BLE
with new uuids which mentioned in OIC spec.
(https://workspace.openinterconnect.org/
 apps/org/workgroup/oswg/download.php/1568/
 OIC_BLE_Transport_Profile.pdf)

Change-Id: I409174458c0abc2c669f252e4e3ac44e9a040743
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1471
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix memory leak in SSM QueryEngine

Fix memory leak in processQueryResult. Allocate pModelData only when
previous operations were successful.

Change-Id: I4829c729d10233ee263c75af533c22782a4659ee
Signed-off-by: Ankur Bansal <ankur.b1@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1428
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Minji Park <minjii.park@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Changed OCRandom.h's define name to remove lead underscore

The lead underscore is reserved for standard library authors. In
this case, including OCRandom.h from C++ conflicted with the C++
random.h file!

Change-Id: Iff8d06ab7e0838fe8cf9d8af7e67a1fae00c2e4b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1459
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

clean up endpoint methods.

- There are not flexible things in CA codes which
  related to handling Endpoint.
  : all endpoint objects will be managed by remotehandler.c
  : all clone methods related to Endpoint will be managed
    by remotehandler.c (not AdapterUtil)

- fixed previous Transport type in some endpoint method
    since previous Type was still used in there (CA_LE / CA_EDR)
    so i replaced it with
    CA_ADAPTER_GATT_BTLE / CA_ADAPTER_RFCOMM_BTEDR
    (already done by https://gerrit.iotivity.org/gerrit/#/c/1401/)

Change-Id: Ib8400bbea0c3b4c005b8bec68ded2ed66c337c7b
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1404
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

IP adapter error handling

Ad dependencies got messed up, earlier patch set failed
Adding a fresh patch with right dependencies

Change-Id: Id55430b0d8ce502978e11e5102972fcb901e4472
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1181
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>

Fix compile warnings in SimpleClientServer for Linux

SimpleClientServer application for Linux was trying to check the address of array
'clientResponse->rcvdVendorSpecificHeaderOptions' which will always evaluate to 'true'.
Corrected by removing such checks in the code.

Change-Id: Id7306af0792646887740ab3c7952d5fffe8c760b
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1454
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>