Panu Matilainen [Wed, 23 Jan 2008 05:56:51 +0000 (07:56 +0200)]
Make uncompress macros match reality (_ vs __ prefix)
Panu Matilainen [Sat, 19 Jan 2008 09:40:59 +0000 (11:40 +0200)]
Add support for Geode CPU (rhbz#428979)
Patch from Dennis Gilmore
Panu Matilainen [Thu, 10 Jan 2008 11:39:00 +0000 (13:39 +0200)]
Define and use UGIDMAX instead of hardcoded 1024 all over
Panu Matilainen [Thu, 10 Jan 2008 11:35:03 +0000 (13:35 +0200)]
pgpHexStr() returns pointer to static buffer, return const char *
Panu Matilainen [Thu, 10 Jan 2008 09:48:31 +0000 (11:48 +0200)]
And *really* skip the leading % in --define, double duh :)
Panu Matilainen [Thu, 10 Jan 2008 06:44:21 +0000 (08:44 +0200)]
Fix thinko in macroname underscore conversion, duh
Panu Matilainen [Wed, 9 Jan 2008 16:56:34 +0000 (18:56 +0200)]
Document internal vs external BDB usage in INSTALL
Panu Matilainen [Wed, 9 Jan 2008 17:07:20 +0000 (19:07 +0200)]
Drop internal db from dist tarballs
- tarball down to almost 1/4 of earlier size
- check if internal db is present in configure, point to INSTALL if not
- distcheck needs --with-external-db now to have any chance at working
- leaving to hg for now for easy reversal if getting second thoughts ;)
Panu Matilainen [Wed, 9 Jan 2008 15:50:25 +0000 (17:50 +0200)]
Dirty hack to determine BDB .la name automatically
Panu Matilainen [Wed, 9 Jan 2008 09:11:49 +0000 (11:11 +0200)]
Implementation of triggerprein scriptlets.
Ported from rpm5.org work of Jeff Johnson to 4.4.x by Pascal Rigaux,
further adopted to fit HEAD...
Panu Matilainen [Wed, 9 Jan 2008 08:39:55 +0000 (10:39 +0200)]
Permit files with glob characters in *.rpm packages (#147383)
Patch from Alexander Suvorov
Panu Matilainen [Wed, 9 Jan 2008 08:34:08 +0000 (10:34 +0200)]
Avoid access(2) quirks querying symlinks, lstat(2) instead (#60288)
Ported from rpm5.org work of Jeff Johnson
Panu Matilainen [Wed, 9 Jan 2008 08:21:01 +0000 (10:21 +0200)]
Handle spaces in file path arguments correctly (#217258)
Ported from rpm5.org work of Jeff Johnson with some differences:
- place into rpmfileutil instead of rpmgi as it's more generic than just rpmgi
- rename rpmgiEscapeSpaces -> rpmEscapeSpaces
- return char *, not const char * as the return string must be freed by caller
Panu Matilainen [Wed, 9 Jan 2008 07:28:09 +0000 (09:28 +0200)]
Convert '-' to '_' within --define macro names (#124995)
Patch derived from rpm5.org of Jeff Johnson
Panu Matilainen [Wed, 9 Jan 2008 07:22:31 +0000 (09:22 +0200)]
Last 8 bytes of RSA modulus is keyid for V3 pubkeys (#205080)
- ported from rpm5.org work of Jeff Johnson
- minimal fix suitable for 4.4.2.x too, full rpm5.org changes require
api changes which would be ok for HEAD but that's a bigger task...
Panu Matilainen [Mon, 7 Jan 2008 14:09:20 +0000 (16:09 +0200)]
Set a default 0022 umask value always (#83006)
Patch derived from rpm5.org work of Jeff Johnson
Panu Matilainen [Mon, 7 Jan 2008 13:37:43 +0000 (15:37 +0200)]
Print --usage to stderr instead of stdout (rhbz#164021)
Patch derived from rpm5.org work of Jeff Johnson
Panu Matilainen [Mon, 7 Jan 2008 12:48:57 +0000 (14:48 +0200)]
Don't unlink non-temporary file in FSM_UNDO (rhbz#223931)
Ported from rpm5.org work of Jeff Johnson.
Panu Matilainen [Mon, 7 Jan 2008 12:25:24 +0000 (14:25 +0200)]
Fix field-width specifiers when no space between (rhbz#323221)
Ported from rpm5.org work of Jeff Johnson.
Panu Matilainen [Mon, 7 Jan 2008 11:57:10 +0000 (13:57 +0200)]
Handle "use vX.X.X" in perl dependency extraction (rhbz#140597)
Patch by Steven Prichard
Panu Matilainen [Fri, 4 Jan 2008 10:04:49 +0000 (12:04 +0200)]
Saner RPM_FORCEFREE_TYPE definition
Panu Matilainen [Fri, 4 Jan 2008 10:00:51 +0000 (12:00 +0200)]
Remove now useless nested function in debugedit
Panu Matilainen [Thu, 3 Jan 2008 10:37:03 +0000 (12:37 +0200)]
Lose unused pgpMpiHex()
Panu Matilainen [Wed, 2 Jan 2008 15:47:30 +0000 (17:47 +0200)]
Revert rpmfi bits from
01cd03ea8f8a
- nasty breakage from new signedness mismatches..
Panu Matilainen [Wed, 2 Jan 2008 15:02:06 +0000 (17:02 +0200)]
Signedness consistency in rpmfi interface vs internal structures
Panu Matilainen [Wed, 2 Jan 2008 14:18:55 +0000 (16:18 +0200)]
Avoid compressFilelist() stack overflow in pathological cases
- allocate dirNames etc arrays on heap, not stack
- the arrays can be rather large and alloca isn't very friendly when it
fails...
Panu Matilainen [Wed, 2 Jan 2008 13:02:18 +0000 (15:02 +0200)]
Teach (unused) headerFreeTag about RPM_FORCEFREE_TYPE
Panu Matilainen [Wed, 2 Jan 2008 12:44:58 +0000 (14:44 +0200)]
Gah, nss doesn't use size_t for lengths...
Panu Matilainen [Wed, 2 Jan 2008 12:37:16 +0000 (14:37 +0200)]
Assorted int -> size_t string size fixes in build code
Panu Matilainen [Wed, 2 Jan 2008 12:10:25 +0000 (14:10 +0200)]
More assorted int -> size_t uses
Panu Matilainen [Wed, 2 Jan 2008 11:55:16 +0000 (13:55 +0200)]
Assorted int -> size_t corrections for string lengths
Panu Matilainen [Wed, 2 Jan 2008 11:22:26 +0000 (13:22 +0200)]
Use size_t, not int for header format padding args
Panu Matilainen [Wed, 19 Dec 2007 10:05:56 +0000 (12:05 +0200)]
Add rpm_data_t (and _constdata_t) for header data, use everywhere
- consistent, easy to grep for and change...
- bogus consts removed where spotted
Panu Matilainen [Wed, 19 Dec 2007 12:13:34 +0000 (14:13 +0200)]
Const-pedantry here and there...
Panu Matilainen [Wed, 19 Dec 2007 11:19:55 +0000 (13:19 +0200)]
Const pedantry
Panu Matilainen [Wed, 19 Dec 2007 10:49:52 +0000 (12:49 +0200)]
Fix some const issues in macros
Panu Matilainen [Mon, 31 Dec 2007 09:56:06 +0000 (11:56 +0200)]
tgi doesnt need fts private include
Panu Matilainen [Sat, 22 Dec 2007 12:26:56 +0000 (14:26 +0200)]
Fix multi-line macro expansion in last line of spec (mdvbz#27417)
Patch from Pascal Rigaux:
1. creating functions restoreFirstChar(), copyNextLineFromOFI() and
copyNextLineFinish() out of copyNextLine()
2. creating function readLineFromOFI() out of readLine()
3. inline copyNextLine
4. if we can restoreFirstChar, then use it, otherwise read from file
(ie don't read from file when we have a remaining multiline macro in
spec->nextline)
Panu Matilainen [Wed, 19 Dec 2007 16:53:14 +0000 (18:53 +0200)]
Hum, NSS needs to be shut down too
- some ~80 bytes are still leaked apparently from somewhere within nss/nspr
Panu Matilainen [Wed, 19 Dec 2007 07:38:32 +0000 (09:38 +0200)]
Add dumb maintainer snapshot generator make rule
Panu Matilainen [Wed, 19 Dec 2007 07:12:59 +0000 (09:12 +0200)]
Ordering fix (don't use RPMSENSE_PREREQ) from Pascal Rigaux
Panu Matilainen [Wed, 19 Dec 2007 07:01:39 +0000 (09:01 +0200)]
Drop duplicate locale.h check
Panu Matilainen [Tue, 18 Dec 2007 19:33:40 +0000 (21:33 +0200)]
Avoid exiting too early due to nested rpmdbCheckSignals()
Panu Matilainen [Tue, 18 Dec 2007 11:42:42 +0000 (13:42 +0200)]
Update translations
Panu Matilainen [Tue, 18 Dec 2007 11:41:29 +0000 (13:41 +0200)]
Todo-update...
Panu Matilainen [Tue, 18 Dec 2007 10:53:57 +0000 (12:53 +0200)]
Drop bogus const from rpmReadPackageManifest argvptr
- it's malloced and needs freeing by the caller..
Panu Matilainen [Tue, 18 Dec 2007 10:53:16 +0000 (12:53 +0200)]
Cast to silence gcc..
Panu Matilainen [Tue, 18 Dec 2007 10:29:46 +0000 (12:29 +0200)]
One leftover reloc constfree..
Panu Matilainen [Tue, 18 Dec 2007 10:08:13 +0000 (12:08 +0200)]
Remove bunch of bogus cli-related consts...
Panu Matilainen [Tue, 18 Dec 2007 10:07:48 +0000 (12:07 +0200)]
Use constfree on relocations for now
- they're totally exposed all they way to rpmqv.c.. eww
Panu Matilainen [Tue, 18 Dec 2007 09:56:54 +0000 (11:56 +0200)]
Remove bogus const from rpmInstallSource*() parameters
- spec and cookie are malloced and need to be freed by caller
- unconst various other rpmQVK arguments & friends, no api exists to
free them so caller needs to handle anyway
Panu Matilainen [Tue, 18 Dec 2007 08:48:10 +0000 (10:48 +0200)]
Use constfree for rpmts suggestions
- goes down to rpmal returning fnpykey which is declared as const..
check this later
Panu Matilainen [Tue, 18 Dec 2007 08:46:39 +0000 (10:46 +0200)]
Stick constfree to extension cache cleanup
- deal with the header mess later on
Panu Matilainen [Tue, 18 Dec 2007 08:45:36 +0000 (10:45 +0200)]
Drop bogus const from headerFreeTag() data pointer
- no effect as it's hft is unused
- mark headerFreeData(), the real problem case, with _constfree() for
easy finding (inlined in header.h so can't use _constfree())
Panu Matilainen [Tue, 18 Dec 2007 08:30:35 +0000 (10:30 +0200)]
Drop bogus const from temp variable
Panu Matilainen [Tue, 18 Dec 2007 08:17:18 +0000 (10:17 +0200)]
Remove bogus const from rpmGlob argv return type
- it's malloced and must be freed by caller
Panu Matilainen [Tue, 18 Dec 2007 08:10:03 +0000 (10:10 +0200)]
Make fsm failedFile non-const like it really is
- callers need to free it so const is wrong
- cast away the hardlink-hackery in fsm instead
Panu Matilainen [Tue, 18 Dec 2007 07:54:46 +0000 (09:54 +0200)]
Drop bogus const from temp variable
Panu Matilainen [Tue, 18 Dec 2007 07:49:03 +0000 (09:49 +0200)]
Drop bogus const from zapRelation return
- the retval is malloced from rpmdsNewDNEVR() and must be freed by the caller
Panu Matilainen [Tue, 18 Dec 2007 07:40:33 +0000 (09:40 +0200)]
Drop bogus const from rpmts rootDir + curDir
Panu Matilainen [Tue, 18 Dec 2007 07:30:40 +0000 (09:30 +0200)]
Remove bogus const from rpmdb match iterator contents
Panu Matilainen [Tue, 18 Dec 2007 07:27:42 +0000 (09:27 +0200)]
Use constfree for rpmdb_s contents for now
- rpmdb_internal is included from several places over the tree
Panu Matilainen [Tue, 18 Dec 2007 07:19:22 +0000 (09:19 +0200)]
Use constfree for rpmhash key + data for now
- sometimes they point to real const data, sometimes not, eww
Panu Matilainen [Tue, 18 Dec 2007 07:08:04 +0000 (09:08 +0200)]
Use constfree for fsm path, opath for now
- neither should really be const but they sometimes point to real
const variables, sometimes not.. needs careful review
Panu Matilainen [Tue, 18 Dec 2007 05:51:45 +0000 (07:51 +0200)]
Drop const from fs mountpoint, contained within fs
Panu Matilainen [Mon, 17 Dec 2007 19:45:56 +0000 (21:45 +0200)]
Drop const from temporary variable
Panu Matilainen [Mon, 17 Dec 2007 17:15:14 +0000 (19:15 +0200)]
Use constfree for rpmte internals for now
- the internals are exposed all over the tree...
Panu Matilainen [Mon, 17 Dec 2007 17:11:33 +0000 (19:11 +0200)]
Use constfree for rpmfi internals for now
- the internals are exposed all over the tree...
Panu Matilainen [Mon, 17 Dec 2007 17:05:19 +0000 (19:05 +0200)]
Remove const from rpmal dirInfo dirname
- add comments wrt needle dirName - those are actual const pointers to
within rpmfi, must not free
Panu Matilainen [Mon, 17 Dec 2007 14:10:32 +0000 (16:10 +0200)]
Use constfree for psm failedFile for now
- failedFile is malloced by fsm, but removing the const from fsm
gets a bit hairy as failed it's not always malloced
(see changeset 4062:
02b0c237b675) so we'd have const-disabling casts instead
of freeing consts...
Panu Matilainen [Mon, 17 Dec 2007 13:32:25 +0000 (15:32 +0200)]
Include toplevel Makefile from Makefile.maint
- allow "make dist" in one step with .maint..
Panu Matilainen [Mon, 17 Dec 2007 13:30:01 +0000 (15:30 +0200)]
Drop db3 from dist subdirs
- db3/configure is covered by EXTRA_DIST already
Panu Matilainen [Mon, 17 Dec 2007 13:07:41 +0000 (15:07 +0200)]
Unconst psm pkgURL and rpmio_flags members
- fully contained within psm
Panu Matilainen [Mon, 17 Dec 2007 12:58:02 +0000 (14:58 +0200)]
Make psm opaque, add minimal methods to cover internal needs
Panu Matilainen [Mon, 17 Dec 2007 12:03:31 +0000 (14:03 +0200)]
Drop bogus const from dnlFreeIterator() param
Panu Matilainen [Mon, 17 Dec 2007 12:01:23 +0000 (14:01 +0200)]
Drop bogus const from fsmFsPath() return type
- path is malloced and caller needs to free
- additionally use size_t, not int for string size
Panu Matilainen [Mon, 17 Dec 2007 11:50:11 +0000 (13:50 +0200)]
transaction.c doesn't need fsm.h, rpmfi_internal does
Panu Matilainen [Mon, 17 Dec 2007 11:39:14 +0000 (13:39 +0200)]
Stick cpioMapFlags to fsm.h, they're only used by fsm.c
- allows FSM* typedefs to move to where they belong
Panu Matilainen [Mon, 17 Dec 2007 11:20:05 +0000 (13:20 +0200)]
Hide fsmIterator_s struct details, not needed outside fsm.c
Panu Matilainen [Mon, 17 Dec 2007 11:15:53 +0000 (13:15 +0200)]
Stuff hardLink_s inside fsm.c, add pointer typedef to fsm.h
- nothing outside fsm.c needs except for the declaration in fsm_s
Panu Matilainen [Mon, 17 Dec 2007 11:01:50 +0000 (13:01 +0200)]
badDeps is encapsulated within depends, doesn't need const
- remove ancient reference code
Panu Matilainen [Mon, 17 Dec 2007 10:37:01 +0000 (12:37 +0200)]
Use constfree for cleaning up pgp digest contents
- the contents are exposed within rpm (although not public interfaces)
but pgpCleanDig() should be used to free the struct
- pgpDig and pgpDigParams need encapsulation + api...
Panu Matilainen [Mon, 17 Dec 2007 09:38:12 +0000 (11:38 +0200)]
Don't bother configuring db3 directory if using external db
Panu Matilainen [Mon, 17 Dec 2007 09:19:55 +0000 (11:19 +0200)]
Make ChangeLog creation depend on .hg directory
- .hg dir timestamp changes on commits, otherwise updating ChangeLog
requires removing it
Panu Matilainen [Mon, 17 Dec 2007 08:32:16 +0000 (10:32 +0200)]
Unbreak internal dep generator
- more signed -> unsigned count type breakage
Panu Matilainen [Mon, 17 Dec 2007 08:05:37 +0000 (10:05 +0200)]
Unbreak array query formats
- signed -> unsigned count type change broke it..
Panu Matilainen [Sun, 16 Dec 2007 21:05:21 +0000 (23:05 +0200)]
pgpReadPkts returns malloced memory, unconstify
Panu Matilainen [Sun, 16 Dec 2007 20:50:30 +0000 (22:50 +0200)]
Lone module-private const .. remove
Panu Matilainen [Sun, 16 Dec 2007 19:28:37 +0000 (21:28 +0200)]
Unconstify macro contents, fully contained within macro module
Panu Matilainen [Sun, 16 Dec 2007 19:24:44 +0000 (21:24 +0200)]
Bogus const in temporary variables
Panu Matilainen [Sun, 16 Dec 2007 19:21:31 +0000 (21:21 +0200)]
More const removals
- both username cache and log records are fully contained within their
modules...
Panu Matilainen [Sun, 16 Dec 2007 19:20:05 +0000 (21:20 +0200)]
More constfree for spec exposed stuff for now
- openfileinfo seems easily made opaque, revisit later
Panu Matilainen [Sun, 16 Dec 2007 18:58:44 +0000 (20:58 +0200)]
Much of spec internals is exposed, let them be const for now
Panu Matilainen [Sun, 16 Dec 2007 18:46:56 +0000 (20:46 +0200)]
Remove couple of bogus const uses in temp variables
Panu Matilainen [Sun, 16 Dec 2007 18:39:46 +0000 (20:39 +0200)]
Unconstify FileListRec and AttrRec contents
- not exposed outside files.c
Panu Matilainen [Sun, 16 Dec 2007 18:04:30 +0000 (20:04 +0200)]
Unconstify rpmrc internal tables
- not exposed outside rpmrc, "protection" buys nothing
Panu Matilainen [Sun, 16 Dec 2007 17:00:07 +0000 (19:00 +0200)]
Fix default queryformat setting when _query_all_fmt not set
- \n in the rpmExpand() causes the result to always be non-null...
- also avoid unnecessary const free
Panu Matilainen [Sun, 16 Dec 2007 14:25:09 +0000 (16:25 +0200)]
Remove const from rpmMkTempFile file name parameter
- the temp name is malloced and needs to be freed by caller
Panu Matilainen [Sun, 16 Dec 2007 13:58:40 +0000 (15:58 +0200)]
Refactor rpmReSign() and associated file "management" a bit
- remove unused + useless "rc" parameter from manageFile()
- remove tempfile handling from manageFile(), create + open a tempfile
explicitly in rpmReSign()
- both copyFile() and manageFile() now require file names to be passed always
- split file closing into separate closeFile() function
Panu Matilainen [Sun, 16 Dec 2007 13:51:09 +0000 (15:51 +0200)]
Stupid reversed-logic thinko..