platform/core/dotnet/diagnostics.git
4 years ago@mikem8361 Disable signing validation (#1761)
Mike McLaughlin [Sat, 21 Nov 2020 04:47:02 +0000 (20:47 -0800)]
@mikem8361 Disable signing validation (#1761)

* Fix signing validation check

* Disable signing validation

4 years agoFix signing validation check (#1759)
Mike McLaughlin [Sat, 21 Nov 2020 00:56:45 +0000 (16:56 -0800)]
Fix signing validation check (#1759)

4 years agoLink the official documentation in the dev versions of the docs (#1757)
Sung Yoon Whang [Fri, 20 Nov 2020 23:45:00 +0000 (15:45 -0800)]
Link the official documentation in the dev versions of the docs (#1757)

4 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20201119.11 ...
dotnet-maestro[bot] [Fri, 20 Nov 2020 18:05:48 +0000 (18:05 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20201119.11 (#1756)

[master] Update dependencies from dotnet/aspnetcore

4 years agoUpdate the host runtime version ordering SOS uses (#1753)
Mike McLaughlin [Fri, 20 Nov 2020 00:41:50 +0000 (16:41 -0800)]
Update the host runtime version ordering SOS uses (#1753)

4 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20201118.9 (...
dotnet-maestro[bot] [Thu, 19 Nov 2020 13:44:31 +0000 (13:44 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20201118.9 (#1752)

[master] Update dependencies from dotnet/aspnetcore

4 years agoChanges for doubly linked freelists in the 64-bit GC (#1719)
Peter Sollich [Thu, 19 Nov 2020 13:34:18 +0000 (14:34 +0100)]
Changes for doubly linked freelists in the 64-bit GC (#1719)

In the 64-bit implementation, we now use one more bit in the method table pointer, so SOS needs to mask out one more bit as well.

Update SOS_BREAKING_CHANGE_VERSION to 2, so users get a warning if they are using an older SOS. This should almost always work just fine though, as the new bit is only set in rare cases during plan_phase.

4 years ago[master] Update dependencies from dotnet/runtime (#1751)
dotnet-maestro[bot] [Thu, 19 Nov 2020 00:07:49 +0000 (00:07 +0000)]
[master] Update dependencies from dotnet/runtime (#1751)

[master] Update dependencies from dotnet/runtime

 - Update feature line for VS package

 - Update global.json

 - Merge branch 'master' into darc-master-7ab7b02a-58a6-4608-81d9-07feca8a906b

4 years ago[master] Update dependencies from dotnet/aspnetcore (#1726)
dotnet-maestro[bot] [Wed, 18 Nov 2020 23:13:47 +0000 (23:13 +0000)]
[master] Update dependencies from dotnet/aspnetcore (#1726)

[master] Update dependencies from dotnet/aspnetcore

 - Merge branch 'master' into darc-master-b7a486a6-7eb8-4482-84d1-c75cc34c9150

4 years agoDisable MacOS createdump testing for 5.0 (#1750)
Mike McLaughlin [Wed, 18 Nov 2020 22:45:35 +0000 (14:45 -0800)]
Disable MacOS createdump testing for 5.0 (#1750)

4 years agoremove writedump tests for diagnostics client tests (#1741)
Sung Yoon Whang [Wed, 18 Nov 2020 17:26:03 +0000 (09:26 -0800)]
remove writedump tests for diagnostics client tests (#1741)

4 years agoUpdate to test 3.1.10/3.1.24 runtimes and build with 5.0.100 SDK (#1734)
Mike McLaughlin [Wed, 18 Nov 2020 17:13:42 +0000 (09:13 -0800)]
Update to test 3.1.10/3.1.24 runtimes and build with 5.0.100 SDK (#1734)

Upgrade to testing on 2.1.23 runtime

Stop testing latest runtime until DARC update to 6.0

4 years agoIncrease timeout on eventpipe session tests (#1739)
Sung Yoon Whang [Wed, 18 Nov 2020 17:05:15 +0000 (09:05 -0800)]
Increase timeout on eventpipe session tests (#1739)

4 years agoImplement --diagnostic-port option to dotnet-counters collect/monitor (#1691)
Sung Yoon Whang [Wed, 18 Nov 2020 11:32:17 +0000 (03:32 -0800)]
Implement --diagnostic-port option to dotnet-counters collect/monitor (#1691)

* add --port option to dotnet-counters

* print the correct path on UNIX and let user cancel out before target attaches

* clean up socket upon exit

* Add --port option to dotnet-trace

* fix arg validation logic

* use suspend option in env var

* change --port to --diagnostic-port

* Some refactoring suggested by code review

* fix merge errors

* one last bit of merge errors

4 years agoChange retry logic around everything being an (#1735)
Juan Hoyos [Wed, 18 Nov 2020 03:17:54 +0000 (19:17 -0800)]
Change retry logic around everything being an (#1735)

4 years agoUpdate IPC design doc (#1694)
John Salem [Tue, 17 Nov 2020 22:36:25 +0000 (14:36 -0800)]
Update IPC design doc (#1694)

Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
4 years agoUpdate dependencies from https://github.com/Microsoft/clrmd build 20201111.1 (#1733)
dotnet-maestro[bot] [Tue, 17 Nov 2020 20:34:29 +0000 (20:34 +0000)]
Update dependencies from https://github.com/Microsoft/clrmd build 20201111.1 (#1733)

[master] Update dependencies from microsoft/clrmd

4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201116.1 (#1732)
dotnet-maestro[bot] [Tue, 17 Nov 2020 19:19:25 +0000 (19:19 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201116.1 (#1732)

[master] Update dependencies from dotnet/symstore

4 years agoUpdate dependencies from https://github.com/dotnet/runtime build 20201116.8 (#1731)
dotnet-maestro[bot] [Tue, 17 Nov 2020 18:27:57 +0000 (18:27 +0000)]
Update dependencies from https://github.com/dotnet/runtime build 20201116.8 (#1731)

[master] Update dependencies from dotnet/runtime

4 years agoFix race condition in Exporters (#1729)
Sung Yoon Whang [Tue, 17 Nov 2020 04:22:15 +0000 (20:22 -0800)]
Fix race condition in Exporters (#1729)

4 years agoUse VS insertion package instead of Microsoft.NETCore.App package for non-shipping...
Jeremy Koritzinsky [Tue, 17 Nov 2020 03:54:46 +0000 (19:54 -0800)]
Use VS insertion package instead of Microsoft.NETCore.App package for non-shipping version. (#1712)

4 years agoRemove dotnet-analyze (#1728)
Juan Hoyos [Tue, 17 Nov 2020 03:10:21 +0000 (19:10 -0800)]
Remove dotnet-analyze (#1728)

4 years agoUse sccsid version.cpp variable to display SOS version on xplat (#1725)
Mike McLaughlin [Tue, 17 Nov 2020 00:19:56 +0000 (16:19 -0800)]
Use sccsid version.cpp variable to display SOS version on xplat (#1725)

Use the the windbg symbol cache path when running under windbg. dotnet-dump will still use the VS symbol cache path in %TEMP%

4 years ago[master] Update dependencies from dotnet/runtime (#1723)
dotnet-maestro[bot] [Mon, 16 Nov 2020 13:50:18 +0000 (13:50 +0000)]
[master] Update dependencies from dotnet/runtime (#1723)

[master] Update dependencies from dotnet/runtime

4 years agoUpdate dependencies from https://github.com/dotnet/runtime build 20201113.5 (#1721)
dotnet-maestro[bot] [Sun, 15 Nov 2020 00:24:56 +0000 (16:24 -0800)]
Update dependencies from https://github.com/dotnet/runtime build 20201113.5 (#1721)

Microsoft.NETCore.App , Microsoft.NETCore.App.Runtime.win-x64
 From Version 5.0.0-rtm.20529.3 -> To Version 5.0.0-rtm.20563.5

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201113.1 (#1722)
dotnet-maestro[bot] [Sat, 14 Nov 2020 22:12:58 +0000 (22:12 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201113.1 (#1722)

[master] Update dependencies from dotnet/symstore

4 years agoAdd support for configuration of custom metrics (#1713)
Wiktor Kopec [Fri, 13 Nov 2020 20:39:50 +0000 (12:39 -0800)]
Add support for configuration of custom metrics (#1713)

* Add support for configuration of custom metrics

* CR Feedback

4 years agoIncrease timeout for dotnet monitor tests to a minute (#1717)
Sung Yoon Whang [Fri, 13 Nov 2020 00:13:52 +0000 (16:13 -0800)]
Increase timeout for dotnet monitor tests to a minute (#1717)

4 years agoImplemented extended error processing for attaching to .NET Core 3.1 on macOS. (...
Mikhail Pilin [Thu, 12 Nov 2020 21:49:41 +0000 (22:49 +0100)]
Implemented extended error processing for attaching to .NET Core 3.1 on macOS. (#1707)

* Implemented extended error processing for attaching to .NET Core 3.1 on macOS.

* Update src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs

Co-authored-by: David Mason <davmason@microsoft.com>
* Update src/Microsoft.Diagnostics.NETCore.Client/DiagnosticsClient/DiagnosticsClient.cs

Co-authored-by: David Mason <davmason@microsoft.com>
* Create UnsupportedCommandException. Update tests and dotnet-dump.

Co-authored-by: David Mason <davmason@microsoft.com>
4 years ago[Test PR] Stabilize CIs (#1714)
Sung Yoon Whang [Thu, 12 Nov 2020 20:22:45 +0000 (12:22 -0800)]
[Test PR] Stabilize CIs  (#1714)

* stuff

* Better handle ImportERror on lldb helper script

* root cts for disposal

* code review feedback

4 years agoRelease tools (#1648)
Juan Hoyos [Thu, 12 Nov 2020 00:48:21 +0000 (16:48 -0800)]
Release tools (#1648)

* Add gather-drop wrapper script
* Add convenience dotnet scripts
* Add NuGet publishing script
* Add core of release tool
* Change behavior to stage files in there's a staging path injected
* Fix manifest aka ms link - strip out extensions
* Fix file stream mode
* Add predictable publishing path to manifest
* Add retry and verification
* Add tools section to the manifest.
* Add GitHub release script
* Verification of input parameters
* Add simple documentation on the release tool

4 years agoEgress for dotnet-monitor (#1677)
Justin Anderson [Wed, 11 Nov 2020 18:50:06 +0000 (10:50 -0800)]
Egress for dotnet-monitor (#1677)

File system and Azure Blob Storage egress.

4 years ago:lipstick: Correct the command's spelling/name. (#1711)
Pure Krome [Wed, 11 Nov 2020 02:21:39 +0000 (13:21 +1100)]
:lipstick: Correct the command's spelling/name. (#1711)

The command is `dotnet-dump` so I thought it might be appropriate to make sure the docs are correctly referring to the strict spelling/name of the command. Otherwise, I thought it was actually `dotnet` (the dotnet command) and then `dump` (the tool) ... where the tool is really `dotnet-dump`

4 years agoAdd instructions on dotnet-counter and dotnet-trace usage at startup (#1681)
Sung Yoon Whang [Tue, 10 Nov 2020 22:27:21 +0000 (14:27 -0800)]
Add instructions on dotnet-counter and dotnet-trace usage at startup (#1681)

* Add instructions on dotnet-counter and dotnet-trace usage on monitor/collect at startup

* typo

4 years agoAdd documentation on single file (#1709)
Juan Hoyos [Tue, 10 Nov 2020 21:25:52 +0000 (13:25 -0800)]
Add documentation on single file (#1709)

* Add documentation on single file tool deployments.
Co-authored-by: Noah Falk <noahfalk@users.noreply.github.com>
Co-authored-by: John Salem <josalem@microsoft.com>
4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201109.2 (#1710)
dotnet-maestro[bot] [Tue, 10 Nov 2020 17:43:17 +0000 (17:43 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201109.2 (#1710)

[master] Update dependencies from dotnet/symstore

4 years agoUse .NET Core runtime to host on Windows; fallback to desktop CLR (#1708)
Mike McLaughlin [Tue, 10 Nov 2020 07:20:12 +0000 (23:20 -0800)]
Use .NET Core runtime to host on Windows; fallback to desktop CLR (#1708)

Use .NET Core runtime to host on Windows; fallback to desktop CLR

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20201102.5 (#1705)
dotnet-maestro[bot] [Mon, 9 Nov 2020 13:40:10 +0000 (13:40 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20201102.5 (#1705)

[master] Update dependencies from dotnet/arcade

4 years agoClean up reversed server sockets upon exit (#1704)
Sung Yoon Whang [Sat, 7 Nov 2020 20:27:17 +0000 (12:27 -0800)]
Clean up reversed server sockets upon exit (#1704)

4 years agoUse SOS_PTR(x) when using %p with varargs (#1700)
Steve MacLean [Thu, 5 Nov 2020 22:36:37 +0000 (17:36 -0500)]
Use SOS_PTR(x) when using %p with varargs (#1700)

* Use SOS_PTR(x) when using %p with varargs
* On Windows copy native binaries for dotnet publish and for VS testing

4 years agoAdd proposal spec for dotnet-stack tool (#1696)
John Salem [Thu, 5 Nov 2020 21:34:30 +0000 (13:34 -0800)]
Add proposal spec for dotnet-stack tool (#1696)

4 years agoChange feed (#1699)
Juan Hoyos [Thu, 5 Nov 2020 20:08:02 +0000 (12:08 -0800)]
Change feed (#1699)

4 years agoSupport SOS testing on 6.0 master runtimes (#1695)
Mike McLaughlin [Wed, 4 Nov 2020 21:23:13 +0000 (13:23 -0800)]
Support SOS testing on 6.0 master runtimes (#1695)

Support SOS testing on 6.0 master runtimes

Add some new SOS test script defines: MAJOR_RUNTIME_VERSION_GE_3 or 5. This allows the some
tests to be enabled for 5 and higher (6) instead of just 5.

Add 5.0 version properties to config files: RuntimeVersion50/AspNetCoreVersion50. They are
currently set to "empty" until 5.0.0 package versions become stable.

Changed the SOS config files to check if the runtime version property is empty and not run the
option. This allows more control from InstallRuntimes.proj on what runtimes are used.

Add dotnet6 feeds and fixes

4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201103.1 (#1698)
dotnet-maestro[bot] [Wed, 4 Nov 2020 13:38:51 +0000 (13:38 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201103.1 (#1698)

[master] Update dependencies from dotnet/symstore

4 years agoFix Windows arm64 build by desktop framework support (#1697)
Mike McLaughlin [Wed, 4 Nov 2020 01:33:18 +0000 (17:33 -0800)]
Fix Windows arm64 build by desktop framework support (#1697)

4 years agoAdd using the DOTNET_ROOT env var to find host runtime (#1693)
Mike McLaughlin [Mon, 2 Nov 2020 20:10:35 +0000 (12:10 -0800)]
Add using the DOTNET_ROOT env var to find host runtime (#1693)

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20201029.1 (#1692)
dotnet-maestro[bot] [Mon, 2 Nov 2020 13:35:10 +0000 (13:35 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20201029.1 (#1692)

[master] Update dependencies from dotnet/arcade

4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201031.1 (#1689)
dotnet-maestro[bot] [Sun, 1 Nov 2020 17:41:58 +0000 (17:41 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201031.1 (#1689)

[master] Update dependencies from dotnet/symstore

4 years agoAdd desktop CLR hosting of the SOS managed code (#1688)
Mike McLaughlin [Sat, 31 Oct 2020 17:19:53 +0000 (10:19 -0700)]
Add desktop CLR hosting of the SOS managed code (#1688)

Add desktop CLR hosting of the SOS managed code

New !sethostruntime options "-netcore" and "-desktop".

 Update documents and code review feedback

4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201029.2 (#1687)
dotnet-maestro[bot] [Fri, 30 Oct 2020 17:12:24 +0000 (17:12 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201029.2 (#1687)

[master] Update dependencies from dotnet/symstore

4 years agoUpdate dependencies from https://github.com/dotnet/runtime build 20201029.3 (#1686)
dotnet-maestro[bot] [Fri, 30 Oct 2020 12:37:07 +0000 (12:37 +0000)]
Update dependencies from https://github.com/dotnet/runtime build 20201029.3 (#1686)

[master] Update dependencies from dotnet/runtime

4 years agoDocument changes to reverse server in ipc protocol doc (#1680)
Sung Yoon Whang [Thu, 29 Oct 2020 20:10:10 +0000 (13:10 -0700)]
Document changes to reverse server in ipc protocol doc (#1680)

* Document changes to reverse server in ipc protocol doc

* remove Preview 8

* Apply suggestions from code review

Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com>
Co-authored-by: Juan Hoyos <juan.hoyos@microsoft.com>
4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201028.1 (#1684)
dotnet-maestro[bot] [Thu, 29 Oct 2020 16:49:27 +0000 (16:49 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201028.1 (#1684)

[master] Update dependencies from dotnet/symstore

4 years ago[master] Update dependencies from dotnet/symstore (#1679)
dotnet-maestro[bot] [Wed, 28 Oct 2020 14:58:22 +0000 (14:58 +0000)]
[master] Update dependencies from dotnet/symstore (#1679)

[master] Update dependencies from dotnet/symstore

4 years agoStandardize and simplify dotnet-monitor options naming. (#1672)
Justin Anderson [Tue, 27 Oct 2020 23:49:16 +0000 (16:49 -0700)]
Standardize and simplify dotnet-monitor options naming. (#1672)

4 years agoMove to V3 Publishing (#1676)
Juan Hoyos [Mon, 26 Oct 2020 23:49:41 +0000 (16:49 -0700)]
Move to V3 Publishing (#1676)

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20201022.2 (#1674)
dotnet-maestro[bot] [Mon, 26 Oct 2020 17:22:44 +0000 (17:22 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20201022.2 (#1674)

[master] Update dependencies from dotnet/arcade

4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201023.1 (#1675)
dotnet-maestro[bot] [Mon, 26 Oct 2020 17:13:56 +0000 (17:13 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201023.1 (#1675)

[master] Update dependencies from dotnet/symstore

4 years agoFill ThreadPool command data from portable thread pool info when enabled (#1274)
Koundinya Veluri [Sun, 25 Oct 2020 00:15:12 +0000 (20:15 -0400)]
Fill ThreadPool command data from portable thread pool info when enabled (#1274)

Related to and depends on https://github.com/dotnet/runtime/pull/38225

When the managed portable thread pool is enabled:
- Made the `ThreadPool` command work as expected, including `ThreadPool -ti` to show in-memory hill climbing thread adjustment history
- After the command queries the native side for info, it looks for a couple of static variables to determine if the portable thread pool is available and enabled
- If it's enabled, it collects equivalent information from the managed side
- Verified that the command works with and without the changes in https://github.com/dotnet/runtime/pull/38225, and with the changes in both modes (portable thread pool enabled and disabled)

4 years agoCreates a new Pipeline Api that collects event source data. (#1566)
Wiktor Kopec [Fri, 23 Oct 2020 23:14:17 +0000 (16:14 -0700)]
Creates a new Pipeline Api that collects event source data. (#1566)

* Creates a new Pipeline Api that collects event source data.

* CR Feedback

* Fix issue when target process socket is already closed

* Additional CR Feedback

* Fix StopAsync

* Minor CR fixes

4 years agoFix some misc minor things (#1669)
Mike McLaughlin [Thu, 22 Oct 2020 18:57:59 +0000 (11:57 -0700)]
Fix some misc minor things (#1669)

Linux arm32 clrstack -f issue: https://github.com/dotnet/diagnostics/issues/1235

Fix dotnet-dump command error message where it is printing the whole stack.

4 years agoFix runtime/aspnetcore DARC updates (#1668)
Mike McLaughlin [Wed, 21 Oct 2020 19:58:56 +0000 (12:58 -0700)]
Fix runtime/aspnetcore DARC updates (#1668)

Fix runtime/aspnetcore DARC updates

* Update dependencies from https://github.com/dotnet/runtime build 20201014.4

Microsoft.NETCore.App
 From Version 5.0.0-rc.2.20479.6 -> To Version 5.0.0-rtm.20514.4

* Update dependencies from https://github.com/dotnet/runtime build 20201015.3

Microsoft.NETCore.App
 From Version 5.0.0-rc.2.20479.6 -> To Version 5.0.0-rtm.20515.3

* Update dependencies from https://github.com/dotnet/runtime build 20201017.6

Microsoft.NETCore.App
 From Version 5.0.0-rc.2.20479.6 -> To Version 5.0.0-rtm.20517.6

* Update dependencies from https://github.com/dotnet/runtime build 20201019.4

Microsoft.NETCore.App
 From Version 5.0.0-rc.2.20479.6 -> To Version 5.0.0-rtm.20519.4

4 years agoFix dotnet-dump cross-OS arm32 issues on Windows (#1667)
Mike McLaughlin [Tue, 20 Oct 2020 23:26:49 +0000 (16:26 -0700)]
Fix dotnet-dump cross-OS arm32 issues on Windows  (#1667)

Fix cross-OS arm32 issues on Windows

Remove the address sign extending in memory service

Fix sosstatus display and error messages for x86/arm32

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20201015.7 (#1659)
dotnet-maestro[bot] [Tue, 20 Oct 2020 20:17:06 +0000 (20:17 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20201015.7 (#1659)

[master] Update dependencies from dotnet/arcade

4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201019.2 (#1664)
dotnet-maestro[bot] [Tue, 20 Oct 2020 18:59:42 +0000 (18:59 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201019.2 (#1664)

[master] Update dependencies from dotnet/symstore

4 years agoUpdate dependencies from https://github.com/Microsoft/clrmd build 20201019.2 (#1665)
dotnet-maestro[bot] [Tue, 20 Oct 2020 16:53:44 +0000 (16:53 +0000)]
Update dependencies from https://github.com/Microsoft/clrmd build 20201019.2 (#1665)

[master] Update dependencies from microsoft/clrmd

4 years agoUpdate dependencies from https://github.com/dotnet/installer build 20200930.7 (#1630)
dotnet-maestro[bot] [Sat, 17 Oct 2020 00:50:25 +0000 (00:50 +0000)]
Update dependencies from https://github.com/dotnet/installer build 20200930.7 (#1630)

[master] Update dependencies from dotnet/installer

4 years agoRename reversed-server-address arg to diagnostic-port. (#1647)
Justin Anderson [Wed, 14 Oct 2020 21:37:55 +0000 (14:37 -0700)]
Rename reversed-server-address arg to diagnostic-port. (#1647)

4 years agoIncrease IpcClient connect timeout to accommodate resource constrained environments...
Justin Anderson [Wed, 14 Oct 2020 18:29:46 +0000 (11:29 -0700)]
Increase IpcClient connect timeout to accommodate resource constrained environments. (#1646)

4 years agoUpdate dependencies from https://github.com/Microsoft/clrmd build 20201013.1 (#1652)
dotnet-maestro[bot] [Wed, 14 Oct 2020 17:24:04 +0000 (17:24 +0000)]
Update dependencies from https://github.com/Microsoft/clrmd build 20201013.1 (#1652)

[master] Update dependencies from microsoft/clrmd

4 years agoMisc cleanup and fixes (#1650)
Mike McLaughlin [Tue, 13 Oct 2020 23:15:13 +0000 (16:15 -0700)]
Misc cleanup and fixes (#1650)

* Misc cleanup and fixes

Update System.CommandLine to version 2.0.0-beta1.20468.1.

* Fix SOSRunner to also wait on debuggee exit while waiting for webapp's pipe startup acknowledgment

* Fix some issues in SOSHost.GetThreadIdsByIndex found in my extensions branch

* Move the runtime module symbol loading from the runtime initialization
that happens for any command to the specific commands like stresslog
that may need to look up native symbols.

Moved the code to LoadRuntimeSymbols() and call it in GetValueFromExpression()
and in the dumplog (stress log) command.

* Add ParallelStacks.Runtime to THIRD-PARTY-NOTICES.TXT. Issue https://github.com/dotnet/diagnostics/issues/1549

* Remove any Apple licensed header files in swift-4.1

* Add lldb LICENSE.TXT

* Enable dumpheap -live/-dead on linux/macos

Issue: https://github.com/dotnet/diagnostics/issues/1618

* Add some diagnostic logging

* Add BinaryLocator to fix hanging clrmodules command as a workaround until clrmd is fixed.

4 years agoEnable dotnet-trace and dotnet-counters collection from startup (#1635)
Sung Yoon Whang [Tue, 13 Oct 2020 21:27:52 +0000 (14:27 -0700)]
Enable dotnet-trace and dotnet-counters collection from startup (#1635)

* add run to counters

* Add trace run command

* use acceptasync instead of sleeping... :p

* Counter run works now

* Fix incorrect cpu-usage descriptor

* use processlauncher to handle --

* remove unused code

* make dotnet-counters collect attachable at startup

* cleanup

* more refactoring

* Fix misbehaviors when stopping counters/child proc

* dotnet-trace collect can attach at startup now

* Fix IOException being thrown for Stop command

* Defer ResumeRuntime after we create EventPipeSession

* Change the default behavior to not redirect stdin/stdout/stderr

* terminate child proc upon exit

* remove useless code

* gracefully handle older versions that can't connect to reversed server.

* terminate child proc

* Fix build err'

* code review feedback

* Code review feedback

* Handle escape characters in argument string to child process

* fix build failure

* fix build failure

* Remove unused code

* Enable --counters option for default scenario as well

4 years agoWrite values with invariant culture and avoid some intermediate allocations (#1649)
Günther Foidl [Tue, 13 Oct 2020 20:38:31 +0000 (22:38 +0200)]
Write values with invariant culture and avoid some intermediate allocations (#1649)

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20201006.7 (#1645)
dotnet-maestro[bot] [Mon, 12 Oct 2020 12:53:58 +0000 (12:53 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20201006.7 (#1645)

[master] Update dependencies from dotnet/arcade

4 years agoAdd support for ComWrappers style CCWs and RCWs (#1623)
David Mason [Mon, 12 Oct 2020 06:51:14 +0000 (23:51 -0700)]
Add support for ComWrappers style CCWs and RCWs (#1623)

4 years agoUpdate dotnet-counters-instructions.md (#1644)
Ivan Maximov [Sun, 11 Oct 2020 21:45:42 +0000 (00:45 +0300)]
Update dotnet-counters-instructions.md (#1644)

fix command line example

4 years agoPort cross oxs-arm64 build support from runtime (#1642)
Steve MacLean [Sat, 10 Oct 2020 15:16:49 +0000 (11:16 -0400)]
Port cross oxs-arm64 build support from runtime (#1642)

* Add osx-arm64 support to tryrun.cmake
* Use clock_gettime_nsec_np for osx time source
* Cross build changes

4 years agoSimplify macOS build pool selection (#1641)
Steve MacLean [Sat, 10 Oct 2020 01:05:59 +0000 (21:05 -0400)]
Simplify macOS build pool selection (#1641)

4 years agoFix CLI example commands (#1638)
Ahmad Ibrahim [Fri, 9 Oct 2020 18:32:58 +0000 (20:32 +0200)]
Fix CLI example commands (#1638)

4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20201006.1 (#1636)
dotnet-maestro[bot] [Thu, 8 Oct 2020 23:53:42 +0000 (23:53 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20201006.1 (#1636)

[master] Update dependencies from dotnet/symstore

4 years agoAdd osx-arm64 to packages & CI (#1574)
Steve MacLean [Thu, 8 Oct 2020 00:47:48 +0000 (20:47 -0400)]
Add osx-arm64 to packages & CI (#1574)

* Add osx-arm64 to packages & CI

+ Revise osx-arm64 builds

  + Use vmImage: macOS-10.15
  + Use XCode 12.2

+ Fix comments

4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20200928.3 (#1629)
dotnet-maestro[bot] [Mon, 5 Oct 2020 12:49:16 +0000 (12:49 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20200928.3 (#1629)

[master] Update dependencies from dotnet/arcade

4 years agotypo (#1625)
Sung Yoon Whang [Fri, 2 Oct 2020 00:18:57 +0000 (17:18 -0700)]
typo (#1625)

4 years agoFix issues with single-file and hash generation (#1620)
Juan Hoyos [Wed, 30 Sep 2020 17:45:10 +0000 (10:45 -0700)]
Fix issues with single-file and hash generation (#1620)

* Fix SHA512 hashes for blobgroups and wrap pipeline logic in script

* Fix single-file tool signing for 5.0-RC1+ SDKs

* CR feedback

4 years agoUpdate dependencies from https://github.com/dotnet/runtime build 20200929.6 (#1621)
dotnet-maestro[bot] [Wed, 30 Sep 2020 17:31:12 +0000 (17:31 +0000)]
Update dependencies from https://github.com/dotnet/runtime build 20200929.6 (#1621)

[master] Update dependencies from dotnet/runtime

4 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20200929.2 (#1622)
dotnet-maestro[bot] [Wed, 30 Sep 2020 16:22:23 +0000 (16:22 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20200929.2 (#1622)

[master] Update dependencies from dotnet/symstore

4 years agoUpdate dependencies from https://github.com/Microsoft/clrmd build 20200922.1 (#1614)
dotnet-maestro[bot] [Mon, 28 Sep 2020 18:01:18 +0000 (18:01 +0000)]
Update dependencies from https://github.com/Microsoft/clrmd build 20200922.1 (#1614)

[master] Update dependencies from microsoft/clrmd

4 years agoUpdate dependencies from https://github.com/dotnet/installer build 20200927.2 (#1617)
dotnet-maestro[bot] [Mon, 28 Sep 2020 12:51:04 +0000 (12:51 +0000)]
Update dependencies from https://github.com/dotnet/installer build 20200927.2 (#1617)

[master] Update dependencies from dotnet/installer

4 years agoUpdate dependencies from https://github.com/dotnet/runtime build 20200925.5 (#1612)
dotnet-maestro[bot] [Sat, 26 Sep 2020 16:26:32 +0000 (09:26 -0700)]
Update dependencies from https://github.com/dotnet/runtime build 20200925.5 (#1612)

Microsoft.NETCore.App
 From Version 5.0.0-rc.2.20474.8 -> To Version 5.0.0-rc.2.20475.5

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
4 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20200925.17 ...
dotnet-maestro[bot] [Sat, 26 Sep 2020 16:17:47 +0000 (09:17 -0700)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20200925.17 (#1613)

Microsoft.AspNetCore.App.Ref
 From Version 5.0.0-rc.2.20474.12 -> To Version 5.0.0-rc.2.20475.17

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20200924.4 (#1610)
dotnet-maestro[bot] [Sat, 26 Sep 2020 01:52:02 +0000 (01:52 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20200924.4 (#1610)

[master] Update dependencies from dotnet/arcade

4 years agoAdd issue templates and code owners (#1604)
Juan Hoyos [Fri, 25 Sep 2020 21:15:08 +0000 (14:15 -0700)]
Add issue templates and code owners (#1604)

* Add issue templates and code owners

* Add dotnet info to the requests for information in bug reports

4 years agoFix testing on arm64. (#1608)
Mike McLaughlin [Fri, 25 Sep 2020 20:01:17 +0000 (13:01 -0700)]
Fix testing on arm64. (#1608)

Disabled installing and running on 2.1.x when arm/arm64.

Fix the test scripts for arm64 registers.

Upgraded to testing on 3.1.8 and 2.1.23.

Add IMachine::SetContextFlags() and IMachine::GetFullContextFlags() to better support
cross-architecture/cross-OS. Had to use a hard coded context flags for each architecture
because the normal DT_CONTEXT_FULL define only exists for the currently building arch.

The main reason `clrstack -i -a` was failing because the architecture bits in the context
flags were being passed into the DAC/DBI were wrong so the context wasn't being copied.

DAC/DBI context copy helper function that is very sensitive to the dst/src context flags
(at the architecture specific bit) matching.

```
void CORDbgCopyThreadContext(DT_CONTEXT* pDst, const DT_CONTEXT* pSrc)
{
    DWORD dstFlags = pDst->ContextFlags;
    DWORD srcFlags = pSrc->ContextFlags;
    LOG((LF_CORDB, LL_INFO1000000,
         "CP::CTC: pDst=0x%08x dstFlags=0x%x, pSrc=0x%08x srcFlags=0x%x\n",
         pDst, dstFlags, pSrc, srcFlags));

    if ((dstFlags & srcFlags & DT_CONTEXT_CONTROL) == DT_CONTEXT_CONTROL)
    {
        CopyContextChunk(&(pDst->Fp), &(pSrc->Fp), &(pDst->V),
                         DT_CONTEXT_CONTROL);
        CopyContextChunk(&(pDst->Cpsr), &(pSrc->Cpsr), &(pDst->X),
                         DT_CONTEXT_CONTROL);
    }

    if ((dstFlags & srcFlags & DT_CONTEXT_INTEGER) == DT_CONTEXT_INTEGER)
        CopyContextChunk(&(pDst->X[0]), &(pSrc->X[0]), &(pDst->Fp),
                         DT_CONTEXT_INTEGER);
```

Remove arm32/arm64 installs from global because they don't work on MacOS

4 years agoUpdate dependencies from https://github.com/dotnet/runtime build 20200924.8 (#1606)
dotnet-maestro[bot] [Fri, 25 Sep 2020 18:09:16 +0000 (11:09 -0700)]
Update dependencies from https://github.com/dotnet/runtime build 20200924.8 (#1606)

Microsoft.NETCore.App
 From Version 5.0.0-rc.2.20473.9 -> To Version 5.0.0-rc.2.20474.8

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
4 years agoTie lifetime of tracee processes to the lifetime of TestRunner (#1602)
Juan Hoyos [Fri, 25 Sep 2020 17:57:54 +0000 (10:57 -0700)]
Tie lifetime of tracee processes to the lifetime of TestRunner (#1602)

* Redirect mid-stream session-exit log to logger
* NETCore.Client process runner implements IDisposable

Co-authored-by: John Salem <josalem@microsoft.com>
4 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20200917.6 (#1590)
dotnet-maestro[bot] [Fri, 25 Sep 2020 16:30:50 +0000 (09:30 -0700)]
Update dependencies from https://github.com/dotnet/arcade build 20200917.6 (#1590)

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.RemoteExecutor
 From Version 5.0.0-beta.20427.5 -> To Version 5.0.0-beta.20467.6

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
4 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20200924.12 ...
dotnet-maestro[bot] [Fri, 25 Sep 2020 12:59:33 +0000 (12:59 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20200924.12 (#1607)

[master] Update dependencies from dotnet/aspnetcore

4 years agoUpdate dotnet-dump instructions to add table (#1603)
Dan Moseley [Fri, 25 Sep 2020 02:08:28 +0000 (19:08 -0700)]
Update dotnet-dump instructions to add table (#1603)

4 years agoApply suggestions from code review
Juan Hoyos [Fri, 25 Sep 2020 00:52:20 +0000 (17:52 -0700)]
Apply suggestions from code review

Co-authored-by: John Salem <josalem@microsoft.com>
4 years agoNETCore.Client process runner implements IDisposable
Juan Sebastian Hoyos Ayala [Thu, 24 Sep 2020 23:56:42 +0000 (16:56 -0700)]
NETCore.Client process runner implements IDisposable