platform/upstream/llvm.git
2 years ago[libc++][NFC] Fix incorrect synopsis in transform_view test
Louis Dionne [Thu, 30 Dec 2021 20:43:07 +0000 (15:43 -0500)]
[libc++][NFC] Fix incorrect synopsis in transform_view test

2 years ago[mlir][arith] fixing dependencies on memref/arith
Mogball [Thu, 30 Dec 2021 20:39:22 +0000 (20:39 +0000)]
[mlir][arith] fixing dependencies on memref/arith

2 years ago[Hexagon] Generate HVX/FP compare instructions
Krzysztof Parzyszek [Thu, 30 Dec 2021 19:44:48 +0000 (11:44 -0800)]
[Hexagon] Generate HVX/FP compare instructions

Co-authored-by: Anirudh Sundar Subramaniam <quic_sanirudh@quicinc.com>
2 years ago[ELF][LTO] Cache symbol table of lazy BitcodeFile
Fangrui Song [Thu, 30 Dec 2021 20:03:29 +0000 (12:03 -0800)]
[ELF][LTO] Cache symbol table of lazy BitcodeFile

Similar to D62188: a BitcodeFile's symbol table may be iterated twice, once in
--start-lib (lazy) state, and once in the non-lazy state. This patch
makes `parseLazy` save `symbols[i]` so that the non-lazy state does not need to
re-insert to the global symbol table. Avoiding a redundant `saver.save` may save
memory.

`Maximum resident set size (kbytes)` for a large --thinlto-index-only link:

* without the patch: 10164000
* with the patch: 10095716 (0.6% decrease)

Note: we can remove `saver.save` if `BitcodeCompiler::add` does not transfer the ownership
of `f.obj` in `checkError(ltoObj->add(std::move(f.obj), resols));`.

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D116390

2 years ago[RISCV] Add support for STRICT_LRINT/LLRINT/LROUND/LLROUND. Tests for other strict...
Craig Topper [Thu, 30 Dec 2021 19:41:59 +0000 (11:41 -0800)]
[RISCV] Add support for STRICT_LRINT/LLRINT/LROUND/LLROUND. Tests for other strict intrinsics.

This patch adds isel support for STRICT_LRINT/LLRINT/LROUND/LLROUND.

It also adds test cases for f32 and f64 constrained intrinsics that
correspond to the intrinsics in float-intrinsics.ll and
double-intrinsics.ll. Support for promoting the integer argument of
STRICT_FPOWI was added.

I've skipped adding tests for f16 intrinsics, since we don't have libcalls
for them and we have inconsistent support for promoting them in LegalizeDAG.
This will need to be examined more closely.

Reviewed By: asb

Differential Revision: https://reviews.llvm.org/D116323

2 years ago[Bazel] Make mlir:MemRefOpsTdFiles depend on :ArithmeticOpsTdFiles
Fangrui Song [Thu, 30 Dec 2021 19:47:54 +0000 (11:47 -0800)]
[Bazel] Make mlir:MemRefOpsTdFiles depend on :ArithmeticOpsTdFiles

2 years ago[MLIR] Add explicit `using` to disambiguate between multiple implementations from...
long.chen [Thu, 30 Dec 2021 07:56:09 +0000 (07:56 +0000)]
[MLIR] Add explicit `using` to disambiguate between multiple implementations from base classes (NFC)

Both of DenseElementsAttr and ElementsAttrTrait define the method of
getElementType, this commit makes it available on
DenseIntOrFPElementsAttr and DenseStringElementsAttr.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D116389

2 years ago[InferAttrs] Give strnlen the same attributes as strlen
Benjamin Kramer [Thu, 30 Dec 2021 19:35:45 +0000 (20:35 +0100)]
[InferAttrs] Give strnlen the same attributes as strlen

This moves the only string function out of the big list of math funcs.
And let's us CSE strnlen calls.

2 years ago[ELF][LTO] Call madvise(MADV_DONTNEED) on MemoryBuffer instances
Fangrui Song [Thu, 30 Dec 2021 19:36:57 +0000 (11:36 -0800)]
[ELF][LTO] Call madvise(MADV_DONTNEED) on MemoryBuffer instances

@tejohnson noticed that freeing MemoryBuffer instances right before
`lto->compile` can save RSS, likely because the memory can be reused by
LTO indexing (e.g. ThinLTO import/export lists).).

For ELFFileBase instances, symbol and section names are backed by MemoryBuffer,
so destroying MemoryBuffer would make some infrequent passes (parseSymbolVersion,
reportBackrefs) crash and make debugging difficult.
For a BitcodeFile, its content is completely unused, but destroying its
MemoryBuffer makes the buffer identifier inaccessible and may introduce
constraints for future changes.
This patch leverages madvise(MADV_DONTNEED) which achieves the major gain
without the latent issues.

`Maximum resident set size (kbytes): ` for a large --thinlto-index-only link:

* current behavior: 10146104KiB
* destroy MemoryBuffer instances: 8555240KiB
* madvise(MADV_DONTNEED) just bitcodeFiles  and lazyBitcodeFiles: 8737372KiB
* madvise(MADV_DONTNEED) all MemoryBuffers: 8739796KiB  (16% decrease)

Depends on D116366

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D116367

2 years ago[MLIR] Move AtomicRMW into MemRef dialect and enum into Arith
William S. Moses [Thu, 30 Dec 2021 05:59:58 +0000 (00:59 -0500)]
[MLIR] Move AtomicRMW into MemRef dialect and enum into Arith

Per the discussion in https://reviews.llvm.org/D116345 it makes sense
to move AtomicRMWOp out of the standard dialect. This was accentuated by the
need to add a fold op with a memref::cast. The only dialect
that would permit this is the memref dialect (keeping it in the standard dialect
or moving it to the arithmetic dialect would require those dialects to have a
dependency on the memref dialect, which breaks linking).

As the AtomicRMWKind enum is used throughout, this has been moved to Arith.

Reviewed By: Mogball

Differential Revision: https://reviews.llvm.org/D116392

2 years ago[Support] Expand `<CFGDIR>` as the base directory in configuration files.
Jack Andersen [Thu, 30 Dec 2021 18:42:13 +0000 (13:42 -0500)]
[Support] Expand `<CFGDIR>` as the base directory in configuration files.

Extends response file expansion to recognize `<CFGDIR>` and expand to the
current file's directory. This makes it much easier to author clang config
files rooted in portable, potentially not-installed SDK directories.

A typical use case may be something like the following:

```
# sample_sdk.cfg
--target=sample
-isystem <CFGDIR>/include
-L <CFGDIR>/lib
-T <CFGDIR>/ldscripts/link.ld
```

Reviewed By: sepavloff

Differential Revision: https://reviews.llvm.org/D115604

2 years ago[Support] Add MemoryBuffer::dontNeedIfMmap
Fangrui Song [Thu, 30 Dec 2021 18:42:28 +0000 (10:42 -0800)]
[Support] Add MemoryBuffer::dontNeedIfMmap

On *NIX systems, this API calls madvise(MADV_DONTNEED) on read-only file mappings.
It should not be used on a writable buffer.
The API is used to implement ld.lld LTO memory saving trick (D116367).

Note: on read-only file mappings, Linux's MADV_DONTNEED semantics match POSIX
POSIX_MADV_DONTNEED and BSD systems' MADV_DONTNEED.

On Windows, VirtualAllocEx MEM_COMMIT/MEM_RESET have similar semantics
but are unfortunately not drop-in replacements. dontNeedIfMmap is currently a no-op.

Reviewed By: aganea

Differential Revision: https://reviews.llvm.org/D116366

2 years ago[docs][llvm-profdata] Prefer double-dash long options
Fangrui Song [Thu, 30 Dec 2021 18:37:17 +0000 (10:37 -0800)]
[docs][llvm-profdata] Prefer double-dash long options

To match the `--help` message and most other utilities.

While here, change `option:: -output=output` to `option:: --output=<output>` and
omit the value name for the short options (convention of other utilities).

Reviewed By: snehasish

Differential Revision: https://reviews.llvm.org/D116353

2 years ago[Hexagon] Explicitly use integer types when rescaling a mask
Krzysztof Parzyszek [Sat, 12 Dec 2020 17:14:08 +0000 (11:14 -0600)]
[Hexagon] Explicitly use integer types when rescaling a mask

2 years ago[Hexagon] Handle HVX/FP {masked,wide} loads/stores
Krzysztof Parzyszek [Thu, 30 Dec 2021 17:03:31 +0000 (09:03 -0800)]
[Hexagon] Handle HVX/FP {masked,wide} loads/stores

Co-authored-by: Rahul Utkoor <quic_rutkoor@quicinc.com>
Co-authored-by: Anirudh Sundar Subramaniam <quic_sanirudh@quicinc.com>
2 years agoRevert "[lld] Add support for other demanglers other than Itanium"
Luís Ferreira [Thu, 30 Dec 2021 18:04:21 +0000 (18:04 +0000)]
Revert "[lld] Add support for other demanglers other than Itanium"

This reverts commit e60d6dfd5acdc821d391ad5af2c706397bdfd36a.

clang-ppc64le-rhel buildbot failed (https://lab.llvm.org/buildbot#builders/57/builds/13424):

    tools/lld/MachO/CMakeFiles/lldMachO.dir/Symbols.cpp.o: In function `lld::demangle(llvm::StringRef, bool)':
    Symbols.cpp:(.text._ZN3lld8demangleEN4llvm9StringRefEb[_ZN3lld8demangleEN4llvm9StringRefEb]+0x90): undefined reference to `llvm::demangle(std::string const&)'

2 years ago[Hexagon] Fix isTypeForHVX to recognize floating point types
Krzysztof Parzyszek [Thu, 30 Dec 2021 17:55:44 +0000 (09:55 -0800)]
[Hexagon] Fix isTypeForHVX to recognize floating point types

Co-authored-by: Sumanth Gundapaneni <sgundapa@quicinc.com>
2 years ago[mlir] Change SCF/Complex to prefixed (NFC)
Jacques Pienaar [Thu, 30 Dec 2021 17:57:51 +0000 (09:57 -0800)]
[mlir] Change SCF/Complex to prefixed (NFC)

See
https://llvm.discourse.group/t/psa-ods-generated-accessors-will-change-to-have-a-get-prefix-update-you-apis/4476

2 years ago[lld] Add support for other demanglers other than Itanium
Luís Ferreira [Thu, 30 Dec 2021 17:43:23 +0000 (17:43 +0000)]
[lld] Add support for other demanglers other than Itanium

LLVM core library supports demangling other mangled symbols other than itanium,
such as D and Rust. LLD should use those demanglers in order to output pretty
demangled symbols on error messages.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D116279

2 years ago[InstCombine] fold opposite shifts around an add
Sanjay Patel [Thu, 30 Dec 2021 17:01:06 +0000 (12:01 -0500)]
[InstCombine] fold opposite shifts around an add

((X << C) + Y) >>u C --> (X + (Y >>u C)) & (-1 >>u C)

https://alive2.llvm.org/ce/z/DY9DPg

This replaces a shift with an 'and', and in the case
where the add has a constant operand, it eliminates
both shifts.

As noted in the TODO comment, we already have this fold when
the shifts are in the opposite order (and that code handles
bitwise logic ops too).

Fixes #52851

2 years agoRevert "[InstCombine] fold opposite shifts around an add"
Sanjay Patel [Thu, 30 Dec 2021 16:54:55 +0000 (11:54 -0500)]
Revert "[InstCombine] fold opposite shifts around an add"

This reverts commit 2e3e0a5c288041745f88a06e66a831c236a3bb1f.
Some unintended diffs snuck into this patch.

2 years ago[InstCombine] fold opposite shifts around an add
Sanjay Patel [Thu, 30 Dec 2021 16:29:27 +0000 (11:29 -0500)]
[InstCombine] fold opposite shifts around an add

((X << C) + Y) >>u C --> (X + (Y >>u C)) & (-1 >>u C)

https://alive2.llvm.org/ce/z/DY9DPg

This replaces a shift with an 'and', and in the case
where the add has a constant operand, it eliminates
both shifts.

As noted in the TODO comment, we already have this fold when
the shifts are in the opposite order (and that code handles
bitwise logic ops too).

Fixes #52851

2 years ago[Hexagon] Handle HVX/FP shuffles, insertion and extraction
Krzysztof Parzyszek [Thu, 30 Dec 2021 16:40:49 +0000 (08:40 -0800)]
[Hexagon] Handle HVX/FP shuffles, insertion and extraction

Co-authored-by: Anirudh Sundar Subramaniam <quic_sanirudh@quicinc.com>
2 years agoRevert "[Hexagon] Don't build two halves of HVX vector in parallel"
Krzysztof Parzyszek [Thu, 30 Dec 2021 15:57:11 +0000 (07:57 -0800)]
Revert "[Hexagon] Don't build two halves of HVX vector in parallel"

This reverts commit ba07f300c6d67a2c6dde8eef216b7a77ac4600bb.

A build-vector sequence is made of pairs: rotate+insert. When constructing
a single vector, this results in a chain of 2*N instructions. The rotate
operation is a permute operation, but the insert uses a multiplication
resource: insert and rotate can execute in the same cycle, but obviously
they cannot operate on the same vector. The original halving idea is still
beneficial since it does allow for insert/rotate overlap, and for hiding
insert's latency.

2 years ago[NFC] Pre-commit NewGVN tests for wrong phi(undef, X) optimization
Nuno Lopes [Thu, 30 Dec 2021 15:41:44 +0000 (15:41 +0000)]
[NFC] Pre-commit NewGVN tests for wrong phi(undef, X) optimization

2 years ago[mlir][vector] Fix illegal vector.transfer + tensor.insert/extract_slice folding
Nicolas Vasilache [Thu, 30 Dec 2021 12:41:18 +0000 (12:41 +0000)]
[mlir][vector] Fix illegal vector.transfer + tensor.insert/extract_slice folding

vector.transfer operations do not have rank-reducing semantics.

Bail on illegal rank-reduction: we need to check that the rank-reduced
dims are exactly the leading dims. I.e. the following is illegal:
```
   %0 = vector.transfer_write %v, %t[0,0], %cst :
     vector<2x4xf32>, tensor<2x4xf32>
   %1 = tensor.insert_slice %0 into %tt[0,0,0][2,1,4][1,1,1] :
     tensor<2x4xf32> into tensor<2x1x4xf32>
```

Cannot fold into:
```
   %0 = vector.transfer_write %v, %t[0,0,0], %cst :
     vector<2x4xf32>, tensor<2x1x4xf32>
```
For this, check the trailing `vectorRank` dims of the insert_slice result
tensor match the trailing dims of the inferred result tensor.

Differential Revision: https://reviews.llvm.org/D116409

2 years ago[GVN] Set phi entries of unreachable predecessors to poison instead of undef
Nuno Lopes [Thu, 30 Dec 2021 13:25:57 +0000 (13:25 +0000)]
[GVN] Set phi entries of unreachable predecessors to poison instead of undef
This matches NewGVN's behavior.

2 years ago[lldb/qemu] More flexible emulator specification
Pavel Labath [Thu, 30 Dec 2021 14:02:23 +0000 (15:02 +0100)]
[lldb/qemu] More flexible emulator specification

This small patch adds two useful improvements:
- allows one to specify the emulator path as a bare filename, and have
  it be looked up in the PATH
- allows one to leave the path empty and have the filename be derived
  from the architecture.

2 years ago[NFC] Pre-commit test for InstSimplify phi(poison)
Nuno Lopes [Thu, 30 Dec 2021 12:33:27 +0000 (12:33 +0000)]
[NFC] Pre-commit test for InstSimplify phi(poison)

2 years ago[LoopFlatten] Move it to a LoopPassManager
Sjoerd Meijer [Thu, 30 Dec 2021 11:17:22 +0000 (11:17 +0000)]
[LoopFlatten] Move it to a LoopPassManager

In D109958 it was noticed that we could optimise the pipeline and avoid
rerunning LoopSimplify/LCSSA for LoopFlatten by moving it to a LoopPassManager.

Differential Revision: https://reviews.llvm.org/D110057

2 years ago[NewGVN][NFC] Add test for x + poison -> poison
Nuno Lopes [Thu, 30 Dec 2021 12:08:07 +0000 (12:08 +0000)]
[NewGVN][NFC] Add test for x + poison -> poison

2 years ago[InstSimplify] add 'x + poison -> poison' (needed for NewGVN)
Nuno Lopes [Thu, 30 Dec 2021 11:44:51 +0000 (11:44 +0000)]
[InstSimplify] add 'x + poison -> poison' (needed for NewGVN)

2 years ago[lldb] Remove lldbtest.getBuildFlags
Pavel Labath [Thu, 30 Dec 2021 10:22:26 +0000 (11:22 +0100)]
[lldb] Remove lldbtest.getBuildFlags

It was being used only in some very old tests (which pass even without
it) and its implementation is highly questionable.

These days we have different mechanisms for requesting a build with a
particular kind of c++ library (USE_LIB(STD)CPP in the makefile).

2 years ago[Opaqueptrs][IR Serialization] Improve inlineasm [de]serialization
Roman Lebedev [Thu, 30 Dec 2021 10:42:11 +0000 (13:42 +0300)]
[Opaqueptrs][IR Serialization] Improve inlineasm [de]serialization

The bitcode reader expected that the pointers are typed,
so that it can extract the function type for the assembly
so `bitc::CST_CODE_INLINEASM` did not explicitly store said function type.

I'm not really sure how the upgrade path will look for existing bitcode,
but i think we can easily support opaque pointers going forward,
by simply storing the function type.

Reviewed By: #opaque-pointers, nikic

Differential Revision: https://reviews.llvm.org/D116341

2 years ago[BitcodeReader] `bitc::CST_CODE_INLINEASM`: un-hardcode offsets
Roman Lebedev [Thu, 30 Dec 2021 10:39:39 +0000 (13:39 +0300)]
[BitcodeReader] `bitc::CST_CODE_INLINEASM`: un-hardcode offsets

2 years ago[RISCV] Teach VSETVLInsert to eliminate redundant vsetvli for vmv.s.x and vfmv.s.f.
jacquesguan [Mon, 27 Dec 2021 13:13:24 +0000 (21:13 +0800)]
[RISCV] Teach VSETVLInsert to eliminate redundant vsetvli for vmv.s.x and vfmv.s.f.

Differential Revision: https://reviews.llvm.org/D116307

2 years agoRevert "[AArch64] Add a tablegen pattern for UZP2."
Sjoerd Meijer [Thu, 30 Dec 2021 09:13:04 +0000 (09:13 +0000)]
Revert "[AArch64] Add a tablegen pattern for UZP2."

This reverts commit ada028c32f47ca84a0b7be5d1ab4e3c943f859a3.

A performance regression was reported that we need to investigate:

https://github.com/llvm/llvm-project/issues/52919

2 years ago[IROutliner] Move global namespace cl::opt inside llvm::
Fangrui Song [Thu, 30 Dec 2021 09:12:55 +0000 (01:12 -0800)]
[IROutliner] Move global namespace cl::opt inside llvm::

2 years ago[RISCV] Pre-commit test for Teach VSETVLInsert to eliminate redundant vsetvli for...
jacquesguan [Mon, 27 Dec 2021 13:03:45 +0000 (21:03 +0800)]
[RISCV] Pre-commit test for Teach VSETVLInsert to eliminate redundant vsetvli for vmv.s.x and vfmv.s.f.

Differential Revision: https://reviews.llvm.org/D116306

2 years ago[MC][test] Improve section_names.s
Fangrui Song [Thu, 30 Dec 2021 08:30:47 +0000 (00:30 -0800)]
[MC][test] Improve section_names.s

Add missing coverage like .tdata/.data1/.rodata1

2 years ago[ELFAsmParser] Optimize hasPrefix with StringRef::consume_front
Fangrui Song [Thu, 30 Dec 2021 08:16:03 +0000 (00:16 -0800)]
[ELFAsmParser] Optimize hasPrefix with StringRef::consume_front

2 years ago[ConstantFolding] Use ICmpInst::Predicate instead of plain integer
Serge Pavlov [Wed, 29 Dec 2021 04:40:03 +0000 (11:40 +0700)]
[ConstantFolding] Use ICmpInst::Predicate instead of plain integer

The function `ConstantFoldCompareInstruction` uses `unsigned short` to
represent compare predicate, although all usesrs of the respective
include file use definition of CmpInst also. This change replaces
predicate argument type in this function to `ICmpInst::Predicate`,
which allows to make code a bit clearer and simpler.

No functional changes.

Differential Revision: https://reviews.llvm.org/D116379

2 years ago[cmake] Tweak warning in `extend_path` helper function
John Ericson [Thu, 30 Dec 2021 07:00:50 +0000 (07:00 +0000)]
[cmake] Tweak warning in `extend_path` helper function

There was one more reference the word "install" I forgot to remove.

Follow-up to bde561c4813952847112600e5efe72d9015556f7 /
https://reviews.llvm.org/D115746

2 years ago[compiler-rt][cmake] Factor out extend_install_path function
John Ericson [Tue, 14 Dec 2021 19:52:02 +0000 (14:52 -0500)]
[compiler-rt][cmake] Factor out extend_install_path function

It is likely to become used again, if other projects want their own per-project
install directory variables. `install` is removed from the name since it is not inherently about installing.

Reviewed By: stephenneuendorffer

Differential Revision: https://reviews.llvm.org/D115746

2 years ago[OpenMP] Add missing `tt_hidden_helper_task_encountered` along with `tt_found_proxy_t...
Shilei Tian [Thu, 30 Dec 2021 04:22:37 +0000 (23:22 -0500)]
[OpenMP] Add missing `tt_hidden_helper_task_encountered` along with `tt_found_proxy_tasks`

In most cases, hidden helper task behave similar as detached tasks. That means,
for example, if we have to wait for detached tasks, we have to do the same thing
for hidden helper tasks as well. This patch adds the missing condition for hidden
helper task accordingly along with detached task.

Reviewed By: AndreyChurbanov

Differential Revision: https://reviews.llvm.org/D107316

2 years ago[RISCV] Use vmv.s.x instead of vfmv.s.f when the floating point scalar is 0.
jacquesguan [Wed, 29 Dec 2021 07:29:40 +0000 (15:29 +0800)]
[RISCV] Use vmv.s.x instead of vfmv.s.f when the floating point scalar is 0.

Use integer vector scalar move instruction when move 0 to avoid add a integer-float move instruction.

Differential Revision: https://reviews.llvm.org/D116365

2 years ago[NFC] Specify targets for clang stack-protector-guard.c
Qiu Chaofan [Thu, 30 Dec 2021 02:13:41 +0000 (10:13 +0800)]
[NFC] Specify targets for clang stack-protector-guard.c

The run line of stack-protector-guard.c doesn't specify the triple,
which means it depends on the platform running the test. This makes
some failure hidden.

Reviewed By: nickdesaulniers

Differential Revision: https://reviews.llvm.org/D116003

2 years ago[RISCV] Refactor immediate comparison instructions patterns
Chenbing.Zheng [Thu, 30 Dec 2021 01:31:01 +0000 (09:31 +0800)]
[RISCV] Refactor immediate comparison instructions patterns

The patterns of the immediate comparison instruction is rewrite here, and put similar code to a class.
Do not change any function of the original code, making the code more concise.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D116215

2 years agoCouple of post-commit tweaks on 4d58d1d5af31 based on maskray's feedback
David Blaikie [Thu, 30 Dec 2021 00:45:00 +0000 (16:45 -0800)]
Couple of post-commit tweaks on 4d58d1d5af31 based on maskray's feedback

2 years agoFix build of llvm-prettyprinters/gdb/mlir-support.cpp test
Mehdi Amini [Wed, 29 Dec 2021 23:08:37 +0000 (23:08 +0000)]
Fix build of llvm-prettyprinters/gdb/mlir-support.cpp test

This is just fixing the build itself, the test won't pass right now.

2 years agoDWARFVerifier: fix remaining tests and compact/rephrase the output
David Blaikie [Wed, 29 Dec 2021 22:47:43 +0000 (14:47 -0800)]
DWARFVerifier: fix remaining tests and compact/rephrase the output

2 years agoDWARFDie: don't try to compute a full template name for a template parameter packs
David Blaikie [Wed, 29 Dec 2021 22:04:38 +0000 (14:04 -0800)]
DWARFDie: don't try to compute a full template name for a template parameter packs

Otherwise these look a lot like actual templates (they have a name and
they have template parameters) but they don't participate in naming
(this doesn't come up in practice because a template parameter pack DIE
is never referenced from another DIE (so we don't do full name
rebuilding for it) or the subject of simplified template name rebuilding
(never has the _STN prefix)) - it could be tested with some hand crafted
DWARF but doesn't seem important/useful to do so.

This change is just for performance - to avoid trying to parse more
DIEs, etc, when it's not needed when computing the name in the DWARF
verifier.

2 years agoDWARFVerifier: Print the CU name and CU count to help visualize progress
David Blaikie [Wed, 29 Dec 2021 22:00:40 +0000 (14:00 -0800)]
DWARFVerifier: Print the CU name and CU count to help visualize progress

2 years ago[libc++] [NFC] Remove an unused parameter from `__sift_down`.
Arthur O'Dwyer [Wed, 29 Dec 2021 19:17:26 +0000 (14:17 -0500)]
[libc++] [NFC] Remove an unused parameter from `__sift_down`.

Differential Revision: https://reviews.llvm.org/D116382

2 years agoDWARFVerifier: Delay loading nested types in type dumping to improve performance
David Blaikie [Wed, 29 Dec 2021 21:11:16 +0000 (13:11 -0800)]
DWARFVerifier: Delay loading nested types in type dumping to improve performance

Avoid trying to resolve nested types that may not be needed because the name is
already provided by the outer DIE.

2 years ago[InstCombine] add more folds for unsigned overflow checks
Sanjay Patel [Wed, 29 Dec 2021 20:53:56 +0000 (15:53 -0500)]
[InstCombine] add more folds for unsigned overflow checks

 ((Op1 + C) & C) u<  Op1 --> Op1 != 0
 ((Op1 + C) & C) u>= Op1 --> Op1 == 0
 Op0 u>  ((Op0 + C) & C) --> Op0 != 0
 Op0 u<= ((Op0 + C) & C) --> Op0 == 0

https://alive2.llvm.org/ce/z/iUfXJN
https://alive2.llvm.org/ce/z/caAtjj

  define i1 @src(i8 %x, i8 %y) {
    ; the add/mask must be with a low-bit mask (0x01ff...)
    %y1 = add i8 %y, 1
    %pop = call i8 @llvm.ctpop.i8(i8 %y1)
    %ismask = icmp eq i8 %pop, 1
    call void @llvm.assume(i1 %ismask)

    %a = add i8 %x, %y
    %m = and i8 %a, %y
    %r = icmp ult i8 %m, %x
    ret i1 %r
  }

  define i1 @tgt(i8 %x, i8 %y) {
    %r = icmp ne i8 %x, 0
    ret i1 %r
  }

I suspect this can be generalized in some way, but this
is the pattern I'm seeing in a motivating test based on
issue #52851.

2 years ago[InstCombine] add tests for unsigned overflow of bitmask offset; NFC
Sanjay Patel [Wed, 29 Dec 2021 20:16:11 +0000 (15:16 -0500)]
[InstCombine] add tests for unsigned overflow of bitmask offset; NFC

2 years ago[InstCombine] add tests for lshr(add(shl())); NFC
Sanjay Patel [Tue, 28 Dec 2021 21:59:53 +0000 (16:59 -0500)]
[InstCombine] add tests for lshr(add(shl())); NFC

2 years ago[mlir][MemRef] Deprecate unspecified trailing offset, size, and strides semantics...
MaheshRavishankar [Wed, 29 Dec 2021 18:48:02 +0000 (10:48 -0800)]
[mlir][MemRef] Deprecate unspecified trailing offset, size, and strides semantics of `OffsetSizeAndStrideOpInterface`.

The semantics of the ops that implement the
`OffsetSizeAndStrideOpInterface` is that if the number of offsets,
sizes or strides are less than the rank of the source, then some
default values are filled along the trailing dimensions (0 for offset,
source dimension of sizes, and 1 for strides). This is confusing,
especially with rank-reducing semantics. Immediate issue here is that
the methods of `OffsetSizeAndStridesOpInterface` assumes that the
number of values is same as the source rank. This cause out-of-bounds
errors.

So simplifying the specification of `OffsetSizeAndStridesOpInterface`
to make it invalid to specify number of offsets/sizes/strides not
equal to the source rank.

Differential Revision: https://reviews.llvm.org/D115677

2 years ago[Hexagon] Don't build two halves of HVX vector in parallel
Krzysztof Parzyszek [Wed, 29 Dec 2021 19:00:01 +0000 (11:00 -0800)]
[Hexagon] Don't build two halves of HVX vector in parallel

There can only be one permute operations per packet, so this actually
pessimizes the code (due to the extra "or").

2 years ago[Hexagon] Improve BUILD_VECTOR codegen
Joshua Herrera [Wed, 29 Dec 2021 18:18:21 +0000 (10:18 -0800)]
[Hexagon] Improve BUILD_VECTOR codegen

For vectors with repeating values, old codegen would rotate and insert
every duplicate element. This patch replaces that behavior with a splat
of the most common element, vinsert/vror only occur when needed.

2 years ago[MLIR][LLVM] Expose powi intrinsic to MLIR
William S. Moses [Wed, 29 Dec 2021 08:08:01 +0000 (03:08 -0500)]
[MLIR][LLVM] Expose powi intrinsic to MLIR

Expose the powi intrinsic to the LLVM dialect within MLIR

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D116364

2 years ago[LV] Replace redundant tail-fold check with assert (NFC).
Florian Hahn [Wed, 29 Dec 2021 18:00:41 +0000 (19:00 +0100)]
[LV] Replace redundant tail-fold check with assert (NFC).

The code path can only be reached when folding the tail, so turn the
check into an assertion.

2 years ago[RISCV] Add a few more instructions to hasAllNBitUsers.
Craig Topper [Wed, 29 Dec 2021 17:14:32 +0000 (09:14 -0800)]
[RISCV] Add a few more instructions to hasAllNBitUsers.

2 years ago[Hexagon] Calling conventions for floating point vectors
Krzysztof Parzyszek [Wed, 29 Dec 2021 16:46:26 +0000 (08:46 -0800)]
[Hexagon] Calling conventions for floating point vectors

They are the same as for the other HVX vectors, but types need to be
listed explicitly. Also, add a detailed codegen testcase.

Co-authored-by: Abhikrant Sharma <quic_abhikran@quicinc.com>
2 years ago[Basic] Drop unnecessary const from return types (NFC)
Kazu Hirata [Wed, 29 Dec 2021 16:55:37 +0000 (08:55 -0800)]
[Basic] Drop unnecessary const from return types (NFC)

Identified with readability-const-return-type.

2 years ago[clang] Use nullptr instead of 0 or NULL (NFC)
Kazu Hirata [Wed, 29 Dec 2021 16:34:20 +0000 (08:34 -0800)]
[clang] Use nullptr instead of 0 or NULL (NFC)

Identified with modernize-use-nullptr.

2 years ago[clang] Remove unused "using" (NFC)
Kazu Hirata [Wed, 29 Dec 2021 16:27:29 +0000 (08:27 -0800)]
[clang] Remove unused "using" (NFC)

2 years ago[NewGVN] Use poison instead of undef to represent unreachable values
Nuno Lopes [Wed, 29 Dec 2021 15:48:30 +0000 (15:48 +0000)]
[NewGVN] Use poison instead of undef to represent unreachable values
This enables more simplifications and gets us closer to removing undef.
ping @alinas

2 years ago[Hexagon] Handle floating point splats
Krzysztof Parzyszek [Wed, 29 Dec 2021 14:52:24 +0000 (06:52 -0800)]
[Hexagon] Handle floating point splats

Co-authored-by: Anirudh Sundar Subramaniam <quic_sanirudh@quicinc.com>
2 years ago[Hexagon] Handle floating point vector loads/stores
Krzysztof Parzyszek [Wed, 29 Dec 2021 13:45:43 +0000 (05:45 -0800)]
[Hexagon] Handle floating point vector loads/stores

2 years ago[NewGVN] Prefer poison to undef when ranking operands
Nuno Lopes [Wed, 29 Dec 2021 12:38:14 +0000 (12:38 +0000)]
[NewGVN] Prefer poison to undef when ranking operands
ping @alinas

2 years ago[SYCL] Diagnose uses of zero length arrays
Mariya Podchishchaeva [Wed, 29 Dec 2021 10:46:15 +0000 (13:46 +0300)]
[SYCL] Diagnose uses of zero length arrays

Adds diagnosing on attempt to use zero length arrays, pointers, refs, arrays
of them and structs/classes containing all of it.
In case a struct/class with zero length array is used this emits a set
of notes pointing out how zero length array got into used struct, like
this:
```
struct ContainsArr {
  int A[0]; // note: field of illegal type declared here
};
struct Wrapper {
  ContainsArr F; // note: within field of type ContainsArr declared here
  // ...
}

// Device code
Wrapper W;
W.use(); // error: zero-length arrays are not permitted

```
Total deep check of each used declaration may result in double
diagnosing at the same location.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D114080

2 years agoFix lit feature name in 9dc4af327b12d
Sam McCall [Wed, 29 Dec 2021 12:18:11 +0000 (13:18 +0100)]
Fix lit feature name in 9dc4af327b12d

2 years agoRe-land "[clang] Add early exit when checking for const init of arrays."
Sam McCall [Wed, 29 Dec 2021 11:07:42 +0000 (12:07 +0100)]
Re-land "[clang] Add early exit when checking for const init of arrays."

This reverts commit 6d09aaecdfe51e13fc64d539aa7c9a790de341d7.

The test uses ulimit and ran into problems on some bots. Run on linux only.
There's nothing platform-specific about the code we're testing, so this
should be enough to ensure correctness.

2 years ago[AArch64] Remove outdated FIXME in test arm64-csel.ll. NFC.
Sjoerd Meijer [Thu, 23 Dec 2021 15:22:46 +0000 (15:22 +0000)]
[AArch64] Remove outdated FIXME in test arm64-csel.ll. NFC.

2 years ago[lldb/linux] Fix a bug in wait status handling
Pavel Labath [Wed, 29 Dec 2021 09:54:46 +0000 (10:54 +0100)]
[lldb/linux] Fix a bug in wait status handling

The MonitorCallback function was assuming that the "exited" argument is
set whenever a thread exits, but the caller was only setting that flag
for the main thread.

This patch deletes the argument altogether, and lets MonitorCallback
compute what it needs itself.

This is almost NFC, since previously we would end up in the
"GetSignalInfo failed for unknown reasons" branch, which was doing the
same thing -- forgetting about the thread.

2 years ago[lldb] Fix PR52702 by fixing bool conversion of Mangled
PoYao Chang [Mon, 27 Dec 2021 04:34:23 +0000 (12:34 +0800)]
[lldb] Fix PR52702 by fixing bool conversion of Mangled

Remove the Mangled::operator! and Mangled::operator void* where the
comments in header and implementation files disagree and replace them
with operator bool.

This fix PR52702 as https://reviews.llvm.org/D106837 used the buggy
Mangled::operator! in Symbol::SynthesizeNameIfNeeded. For example,
consider the symbol "puts" in a hello world C program:

// Inside Symbol::SynthesizeNameIfNeeded
(lldb) p m_mangled
(lldb_private::Mangled) $0 = (m_mangled = None, m_demangled = "puts")
(lldb) p !m_mangled
(bool) $1 = true          # should be false!!
This leads to Symbol::SynthesizeNameIfNeeded overwriting m_demangled
part of Mangled (in this case "puts").

In conclusion, this patch turns
callq  0x401030                  ; symbol stub for: ___lldb_unnamed_symbol36
back into
callq  0x401030                  ; symbol stub for: puts .

Differential Revision: https://reviews.llvm.org/D116217

2 years ago[lldb] Adjust TestModuleCacheSimple for D115951
Pavel Labath [Wed, 29 Dec 2021 09:00:00 +0000 (10:00 +0100)]
[lldb] Adjust TestModuleCacheSimple for D115951

Now that we are caching the dwarf index as well, we will always have
more than one cache file (when not using accelerator tables). I have
adjusted the test to check for the presence of one _symtab_ index.

2 years ago[lldb] Make ProcessLauncherPosixFork (mostly) async-signal-safe
Pavel Labath [Tue, 21 Dec 2021 12:59:14 +0000 (13:59 +0100)]
[lldb] Make ProcessLauncherPosixFork (mostly) async-signal-safe

Multithreaded applications using fork(2) need to be extra careful about
what they do in the fork child. Without any special precautions (which
only really work if you can fully control all threads) they can only
safely call async-signal-safe functions. This is because the forked
child will contain snapshot of the parents memory at a random moment in
the execution of all of the non-forking threads (this is where the
similarity with signals comes in).

For example, the other threads could have been holding locks that can
now never be released in the child process and any attempt to obtain
them would block. This is what sometimes happen when using tcmalloc --
our fork child ends up hanging in the memory allocation routine. It is
also what happened with our logging code, which is why we added a
pthread_atfork hackaround.

This patch implements a proper fix to the problem, by which is to make
the child code async-signal-safe. The ProcessLaunchInfo structure is
transformed into a simpler ForkLaunchInfo representation, one which can
be read without allocating memory and invoking complex library
functions.

Strictly speaking this implementation is not async-signal-safe, as it
still invokes library functions outside of the posix-blessed set of
entry points. Strictly adhering to the spec would mean reimplementing a
lot of the functionality in pure C, so instead I rely on the fact that
any reasonable implementation of some functions (e.g.,
basic_string::c_str()) will not start allocating memory or doing other
unsafe things.

The new child code does not call into our logging infrastructure, which
enables us to remove the pthread_atfork call from there.

Differential Revision: https://reviews.llvm.org/D116165

2 years ago[clang] Fix crash in bug52905
Chuanqi Xu [Wed, 29 Dec 2021 08:22:26 +0000 (16:22 +0800)]
[clang] Fix crash in bug52905

The root cause for the crash is the incorrect use of `cast`.
The actual type and cast-to type is different. This patch fixes the
crash by converting the `cast` to `dyn_cast`.

2 years ago[clang] Fix header guards (NFC)
Kazu Hirata [Wed, 29 Dec 2021 08:16:40 +0000 (00:16 -0800)]
[clang] Fix header guards (NFC)

Identified with llvm-header-guard.

2 years ago[Hexagon] Use range-based for loops (NFC)
Kazu Hirata [Wed, 29 Dec 2021 07:47:25 +0000 (23:47 -0800)]
[Hexagon] Use range-based for loops (NFC)

2 years ago[OpenMP][OpenACC] Update test after encoding change in D113126
Johannes Doerfert [Wed, 29 Dec 2021 07:29:07 +0000 (01:29 -0600)]
[OpenMP][OpenACC] Update test after encoding change in D113126

2 years agoReapply "[OpenMP][NFCI] Embed the source location string size in the ident_t"
Johannes Doerfert [Wed, 29 Dec 2021 07:07:53 +0000 (01:07 -0600)]
Reapply "[OpenMP][NFCI] Embed the source location string size in the ident_t"

This reverts commit 73ece231ee0cf048d56841f47915beb1db6afc26 and
reapplies 7bfcdbcbf368cea14a5236080af975d5878a46eb with mlir changes.
Also reverts commit 423ba12971bac8397c87fcf975ba6a4b7530ed28 and
includes the unit test changes of
16da2140045808b2aea1d28366ca7d326eb3c809.

2 years agoRevert "[OpenMP][FIX] Also update unit test after API change"
Mehdi Amini [Wed, 29 Dec 2021 07:08:58 +0000 (07:08 +0000)]
Revert "[OpenMP][FIX] Also update unit test after API change"

This reverts commit 16da2140045808b2aea1d28366ca7d326eb3c809.

Revert unit-test API update after previous revert of the API change.

2 years agoRevert "[OpenMP][NFCI] Embed the source location string size in the ident_t"
Mehdi Amini [Wed, 29 Dec 2021 06:57:36 +0000 (06:57 +0000)]
Revert "[OpenMP][NFCI] Embed the source location string size in the ident_t"

This reverts commit 7bfcdbcbf368cea14a5236080af975d5878a46eb.
Broke MLIR build

2 years ago[AST] Fix a warning
Kazu Hirata [Wed, 29 Dec 2021 06:52:56 +0000 (22:52 -0800)]
[AST] Fix a warning

This patch fixes:

  mlir/include/mlir/Tools/PDLL/AST/Types.h:54:3: error: definition of
  implicit copy assignment operator for 'Type' is deprecated because
  it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]

2 years ago[Attributor] Look through allocated heap memory
Johannes Doerfert [Wed, 29 Dec 2021 05:59:35 +0000 (23:59 -0600)]
[Attributor] Look through allocated heap memory

AAPointerInfo, and thereby other places, can look already through
internal global and stack memory. This patch enables them to look
through heap memory returned by functions with a `noalias` return.

In the future we can look through `noalias` arguments as well but that
will require AAIsDead to learn that such memory can be inspected by the
caller later on. We also need teach AAPointerInfo about dominance to
actually deal with memory that might not be `null` or `undef`
initialized. D106397 is a first step in that direction already.

Reviewed By: kuter

Differential Revision: https://reviews.llvm.org/D109170

2 years ago[OpenMP] Simplify all stores in the device code
Johannes Doerfert [Wed, 29 Dec 2021 05:55:32 +0000 (23:55 -0600)]
[OpenMP] Simplify all stores in the device code

Similar to loads, we want to be aggressive when it comes to store
simplification. Not everything in LLVM handles dead stores well when
address space casts are involved, we can simply ask the Attributor to do
it for us though.

Reviewed By: tianshilei1992

Differential Revision: https://reviews.llvm.org/D109998

2 years ago[OpenMP][FIX] Also update unit test after API change
Johannes Doerfert [Wed, 29 Dec 2021 06:16:56 +0000 (00:16 -0600)]
[OpenMP][FIX] Also update unit test after API change

2 years ago[OpenMP][NFC] Extract assumption helpers into own header file
Johannes Doerfert [Thu, 4 Nov 2021 13:48:19 +0000 (08:48 -0500)]
[OpenMP][NFC] Extract assumption helpers into own header file

2 years ago[OpenMP][NFCI] Embed the source location string size in the ident_t
Johannes Doerfert [Wed, 3 Nov 2021 17:28:11 +0000 (12:28 -0500)]
[OpenMP][NFCI] Embed the source location string size in the ident_t

One of the unused ident_t fields now holds the size of the string
(=const char *) field so we have an easier time dealing with those
in the future.

Differential Revision: https://reviews.llvm.org/D113126

2 years ago[Attributor][FIX] Ensure store uses are correlated with reloads
Johannes Doerfert [Sat, 11 Sep 2021 23:15:53 +0000 (18:15 -0500)]
[Attributor][FIX] Ensure store uses are correlated with reloads

While we skipped uses in stores if we can find all copies of the value
when the memory is loaded, we did not correlate the use in the store
with the use in the load. So far this lead to less precise results in the
offset calculations which prevented deductions. With the new
EquivalentUseCB callback argument the user of checkForAllUses can be
informed of the correlation and act on it appropriately.

Differential Revision: https://reviews.llvm.org/D109662

2 years ago[OpenMP][FIX] Make AAExecutionDomain deterministic
Johannes Doerfert [Tue, 28 Dec 2021 22:03:16 +0000 (16:03 -0600)]
[OpenMP][FIX] Make AAExecutionDomain deterministic

2 years ago[OpenMP][FIX] Make heap2shared deterministic
Johannes Doerfert [Sun, 26 Dec 2021 20:33:37 +0000 (14:33 -0600)]
[OpenMP][FIX] Make heap2shared deterministic

Issue #52875 reported non-determinism, this is the first step to avoid
it. We iterate over MallocCalls so we should keep the order stable.

2 years ago[OpenMP][NFC] Move address space enum into OMPConstants header
Johannes Doerfert [Wed, 3 Nov 2021 17:57:43 +0000 (12:57 -0500)]
[OpenMP][NFC] Move address space enum into OMPConstants header

2 years ago[OpenMP][NFC] Move headers into include folder
Johannes Doerfert [Wed, 3 Nov 2021 16:58:05 +0000 (11:58 -0500)]
[OpenMP][NFC] Move headers into include folder

2 years ago[MLIR] Expose atomicrmw and/or
William S. Moses [Tue, 28 Dec 2021 23:40:54 +0000 (18:40 -0500)]
[MLIR] Expose atomicrmw and/or

LLVM (dialect and IR) have atomics for and/or. This patch enables atomic_rmw ops in the standard dialect for and/or that lower to these (in addition to the existing atomics such as addi, etc).

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D116345

2 years ago[MLIR] Add constant folder for fptosi and friends
William S. Moses [Mon, 27 Dec 2021 21:07:11 +0000 (16:07 -0500)]
[MLIR] Add constant folder for fptosi and friends

This patch adds constant folds for FPToSI/FPToUI/SIToFP/UIToFP

Reviewed By: mehdi_amini, bondhugula

Differential Revision: https://reviews.llvm.org/D116321