platform/upstream/gstreamer.git
19 months agoav1parse: push all data once when input alignment not smaller than output.
He Junyan [Fri, 14 Oct 2022 07:46:16 +0000 (15:46 +0800)]
av1parse: push all data once when input alignment not smaller than output.

When the incoming data has big alignment than the output, we do not need to
call finish_frame() and exit the current handle_frame() for each splitted
frame. We can push them all at one shot with in one handle_frame(), whcih
may improve the performance and can help us to find the edge of TU.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3182>

19 months agoav1parse: Set the output buffer flags correctly.
He Junyan [Fri, 14 Oct 2022 07:27:52 +0000 (15:27 +0800)]
av1parse: Set the output buffer flags correctly.

The current code forgets to clear some flags and has some typo.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3182>

19 months agodocs: plugins-scanner: Handle interface used for plugin API properties
Thibault Saunier [Fri, 21 Oct 2022 09:11:13 +0000 (11:11 +0200)]
docs: plugins-scanner: Handle interface used for plugin API properties

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3236>

19 months agowebrtcbin: also add rtcp-fb ccm fir for video mlines by default
Matthew Waters [Thu, 20 Oct 2022 23:50:36 +0000 (10:50 +1100)]
webrtcbin: also add rtcp-fb ccm fir for video mlines by default

In addition to the 'nack pli' already added.  Both are supported by
rtpbin/rtpsession by default already.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3235>

19 months agobuild/gl: fix automatic dispmanx detection for rpi4
Matthew Waters [Tue, 4 Oct 2022 04:39:51 +0000 (05:39 +0100)]
build/gl: fix automatic dispmanx detection for rpi4

rpi4 doesn't contain dispmanx but still contains bcm_host.pc which
confuses the configure detection.  Add an explicit check for
EGL_DISPMANX_WINDOW_T to ensure that we only build with dispmanx when
the types are available.

Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/893
Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/issues/952
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3230>

19 months agowebrtcbin: Improve documentation of 'turn-server' property
Sangchul Lee [Wed, 19 Oct 2022 07:03:55 +0000 (16:03 +0900)]
webrtcbin: Improve documentation of 'turn-server' property

Description about how to set time-limited credentials is added.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3229>

19 months agodocs: plugin-scanner: Stop updating "long-name" metadata
Seungha Yang [Mon, 17 Oct 2022 18:08:44 +0000 (03:08 +0900)]
docs: plugin-scanner: Stop updating "long-name" metadata

The "long-name" value can be environment dependent, and it's not
actually used by our documentation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3208>

19 months agoparse: Adjust debug log level
Seungha Yang [Wed, 19 Oct 2022 13:30:38 +0000 (22:30 +0900)]
parse: Adjust debug log level

That's not an error case at all

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3228>

19 months agodocs/glcontextconfig: rename title to not be GstGLContext
Matthew Waters [Wed, 19 Oct 2022 11:08:17 +0000 (22:08 +1100)]
docs/glcontextconfig: rename title to not be GstGLContext

Can be confusing havint two pages that both have GstGLContext as the
title.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3227>

19 months ago{element,deviceprovider}factory: g_object_new() can't ever return NULL
Sebastian Dröge [Wed, 19 Oct 2022 10:34:28 +0000 (13:34 +0300)]
{element,deviceprovider}factory: g_object_new() can't ever return NULL

So treat it as the assertion it is.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3226>

19 months agoelementfactory: Handle element factory loading failure in gst_element_factory_create_...
Sebastian Dröge [Wed, 19 Oct 2022 10:33:39 +0000 (13:33 +0300)]
elementfactory: Handle element factory loading failure in gst_element_factory_create_valist() not as assertion

In gst_element_factory_create_with_properties() it is a normal error
path so let's keep this consistent.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3226>

19 months agogst: Use G_TYPE_INVALID instead of 0 for GTypes
Sebastian Dröge [Wed, 19 Oct 2022 10:28:06 +0000 (13:28 +0300)]
gst: Use G_TYPE_INVALID instead of 0 for GTypes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3226>

19 months agotests: parse-launch: remove assignment order tests
Mathieu Duponchelle [Wed, 14 Sep 2022 22:06:49 +0000 (00:06 +0200)]
tests: parse-launch: remove assignment order tests

These tests relied on setting the name of an element twice to verify
that the last one set took precedence, however name is a CONSTRUCT property
and the parser now errors out when such properties are set twice, in
g_object_new_with_properties .

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3026>

19 months agoparse: refactor to make use of gst_element_factory_make_with_properties
Mathieu Duponchelle [Tue, 13 Sep 2022 21:16:08 +0000 (23:16 +0200)]
parse: refactor to make use of gst_element_factory_make_with_properties

Instead of creating the element first, then setting properties and
presets, we gather those and construct the element with the properties.

This means users of gst_parse_launch can now set construct-only
properties.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1380

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3026>

19 months agogstminiobject: shares capacity increase
Bunio_FH [Tue, 18 Oct 2022 14:41:36 +0000 (16:41 +0200)]
gstminiobject: shares capacity increase

during the MSE (WebKit) tests from Apple suite:
https://hls-streaming.cdn-apple.com/hls_conformance/dist/v1.1/index.html?pretty=true&whitelist=MSE%20Suite
webkit attempts to add a single audio buffer containing ~35.5k frames.
when corresponding GstSamples are pulled buffer is being referenced
more than object capacity allows: 2^15-1. since the case could be considered
malformed a surgical patch is applied to increase the capacity.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3221>

19 months agofake{video|audio}sink: don't proxy properties at instance init.
Mathieu Duponchelle [Fri, 23 Sep 2022 16:25:41 +0000 (18:25 +0200)]
fake{video|audio}sink: don't proxy properties at instance init.

Instead proxy properties from the GstBaseSink class at class_init time,
and duplicate the rest of the fakesink properties manually.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1442

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3073>

19 months agocdparanoia: Ignore compiler warning coming from the cdparanoia header
Jordan Petridis [Wed, 6 Jul 2022 18:45:24 +0000 (21:45 +0300)]
cdparanoia: Ignore compiler warning coming from the cdparanoia header

When trying to build the plugin, GCC starts complaining about issues
with one of the cdparanoia headers and it block us from being able
to build the plugin with Werror.

The current warning in the header look like this:

```
[1/2] Compiling C object subprojects/gst-plugins-base/ext/cdparanoia/libgstcdparanoia.so.p/gstcdparanoiasrc.c.o
In file included from ../subprojects/gst-plugins-base/ext/cdparanoia/gstcdparanoiasrc.h:37,
                 from ../subprojects/gst-plugins-base/ext/cdparanoia/gstcdparanoiasrc.c:31:
/usr/include/cdda/cdda_interface.h:164:3: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  164 |   "Success",
      |   ^~~~~~~~~
...
/usr/include/cdda/cdda_interface.h:163:14: warning: ‘strerror_tr’ defined but not used [-Wunused-variable]
  163 | static char *strerror_tr[]={
      |              ^~~~~~~~~~~
[2/2] Linking target subprojects/gst-plugins-base/ext/cdparanoia/libgstcdparanoia.so
```

Last release of cdparanoia was in 2008, so our best bet for the
time is to ignore the warnings.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2722>

19 months agowebrtcbin: support adding TURN servers after pipeline start
Alba Mendez [Tue, 18 Oct 2022 09:16:20 +0000 (11:16 +0200)]
webrtcbin: support adding TURN servers after pipeline start

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/1680

When a TURN server is added for the first time, propagate
the change to all nice streams that already exist. This
lets us add servers after the pipeline has been started
(and streams have been added).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3217>

19 months agomeson: Use run_command check: true for windows binary subprojects
Nirbheek Chauhan [Wed, 19 Oct 2022 03:52:21 +0000 (09:22 +0530)]
meson: Use run_command check: true for windows binary subprojects

Fixes a warning about using the check kwarg

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3224>

19 months agoexamples: webrtc: mp-sendrecv: add bus handler
Sam Van Den Berge [Tue, 18 Oct 2022 13:28:32 +0000 (15:28 +0200)]
examples: webrtc: mp-sendrecv: add bus handler

Without this bus handler, messages posted to the bus will keep a ref to
their source elements, preventing them from being disposed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3219>

19 months agoexamples: webrtc: mp-sendrecv: set element states to NULL after removing them from...
Sam Van Den Berge [Tue, 18 Oct 2022 13:27:20 +0000 (15:27 +0200)]
examples: webrtc: mp-sendrecv: set element states to NULL after removing them from pipeline

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3219>

19 months agoexamples: webrtc: mp-sendrecv: remove wrong gst_object_unrefs
Sam Van Den Berge [Tue, 18 Oct 2022 13:17:40 +0000 (15:17 +0200)]
examples: webrtc: mp-sendrecv: remove wrong gst_object_unrefs

In !2958 some gst_object_unrefs were added. However these two don't
belong there because ownership is transfered due to the gst_bin_add_many
call a bit above.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3219>

19 months agosrtp: Fix test skipping when plugin option is disabled
Fabian Orccon [Mon, 17 Oct 2022 11:48:12 +0000 (06:48 -0500)]
srtp: Fix test skipping when plugin option is disabled

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3200>

19 months agod3d11videosink: Add "emit-present" property
Seungha Yang [Thu, 13 Oct 2022 15:17:52 +0000 (00:17 +0900)]
d3d11videosink: Add "emit-present" property

Controls the decision for "present" signal use, and
allows delayed "present" signal handler install via the property

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3176>

19 months agoplay: Add/fix various annotations
Sebastian Dröge [Mon, 17 Oct 2022 16:36:13 +0000 (19:36 +0300)]
play: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agosdp: Add/fix various annotations
Sebastian Dröge [Mon, 17 Oct 2022 11:43:42 +0000 (14:43 +0300)]
sdp: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agotag: Add/fix various annotations
Sebastian Dröge [Mon, 17 Oct 2022 11:51:03 +0000 (14:51 +0300)]
tag: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agoallocators: Add/fix various annotations
Sebastian Dröge [Mon, 17 Oct 2022 08:31:05 +0000 (11:31 +0300)]
allocators: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agovulkan: Add/fix various annotations
Sebastian Dröge [Mon, 17 Oct 2022 08:29:02 +0000 (11:29 +0300)]
vulkan: Add/fix various annotations

And fix a memory leak in gst_vulkan_display_wayland_new() in error
cases.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agod3d11: Add/fix various annotations
Sebastian Dröge [Mon, 17 Oct 2022 07:54:06 +0000 (10:54 +0300)]
d3d11: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agocuda: Add/fix various annotations
Sebastian Dröge [Mon, 17 Oct 2022 07:51:42 +0000 (10:51 +0300)]
cuda: Add/fix various annotations

And fix a memory leak when creating a CUDA context fails.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agocodecs: Add/fix various annotations
Sebastian Dröge [Mon, 17 Oct 2022 07:47:02 +0000 (10:47 +0300)]
codecs: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agobadaudio: Add/fix annotations
Sebastian Dröge [Mon, 17 Oct 2022 07:44:24 +0000 (10:44 +0300)]
badaudio: Add/fix annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agoges: Add/fix various annotations
Sebastian Dröge [Sat, 15 Oct 2022 16:36:47 +0000 (19:36 +0300)]
ges: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agortsp-server: Add/fix various annotations
Sebastian Dröge [Sat, 15 Oct 2022 09:40:04 +0000 (12:40 +0300)]
rtsp-server: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agocore: Add/fix various annotations
Sebastian Dröge [Sat, 15 Oct 2022 09:31:17 +0000 (12:31 +0300)]
core: Add/fix various annotations

And fix memory leaks/null pointer dereferences in GstUri in error cases.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agocheck: Add/fix various annotations
Sebastian Dröge [Sat, 15 Oct 2022 09:24:46 +0000 (12:24 +0300)]
check: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agonet: Add/fix various annotations
Sebastian Dröge [Sat, 15 Oct 2022 09:20:08 +0000 (12:20 +0300)]
net: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agobase: Add/fix annotations in GstQueueArray
Sebastian Dröge [Sat, 15 Oct 2022 09:18:28 +0000 (12:18 +0300)]
base: Add/fix annotations in GstQueueArray

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agogl: Add/fix various annotations
Sebastian Dröge [Sat, 15 Oct 2022 09:16:01 +0000 (12:16 +0300)]
gl: Add/fix various annotations

And fix a memory leaks in gst_gl_display_egl_new() error cases.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agovalidate: Add/fix various annotations
Sebastian Dröge [Sat, 15 Oct 2022 08:38:02 +0000 (11:38 +0300)]
validate: Add/fix various annotations

And fix monitor constructors to correctly check for valid arguments.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agopbutils: Add/fix various annotations
Sebastian Dröge [Fri, 14 Oct 2022 21:19:53 +0000 (00:19 +0300)]
pbutils: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agortp: Add/fix various annotations
Sebastian Dröge [Fri, 14 Oct 2022 21:00:03 +0000 (00:00 +0300)]
rtp: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agortsp: Add/fix various annotations
Sebastian Dröge [Fri, 14 Oct 2022 20:52:40 +0000 (23:52 +0300)]
rtsp: Add/fix various annotations

Also initialize out parameters so that they don't have an undefined
value in case of errors.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agocontroller: Add/fix various annotations
Sebastian Dröge [Fri, 14 Oct 2022 20:48:09 +0000 (23:48 +0300)]
controller: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agoapp: Add/fix various annotations
Sebastian Dröge [Fri, 14 Oct 2022 19:08:07 +0000 (22:08 +0300)]
app: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agoaudio: Add/fix various annotations
Sebastian Dröge [Fri, 14 Oct 2022 19:04:00 +0000 (22:04 +0300)]
audio: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agovideo: Add/fix various annotations
Sebastian Dröge [Fri, 14 Oct 2022 18:59:43 +0000 (21:59 +0300)]
video: Add/fix various annotations

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agowebrtc: Add/fix various annotations
Sebastian Dröge [Fri, 14 Oct 2022 18:51:17 +0000 (21:51 +0300)]
webrtc: Add/fix various annotations

And mark string parameters as const.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3194>

19 months agourisourcebin: Fix usage of raw and non-raw source provider
Edward Hervey [Mon, 17 Oct 2022 11:01:53 +0000 (13:01 +0200)]
urisourcebin: Fix usage of raw and non-raw source provider

The computation in analyze_source was wrong, and would state that the element
has "all raw source pads" if it had at least one.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1029

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3199>

19 months agortpbuffer: Initialize extended timestamp to the first wraparound period
Sebastian Dröge [Mon, 17 Oct 2022 15:38:43 +0000 (18:38 +0300)]
rtpbuffer: Initialize extended timestamp to the first wraparound period

This allows correct handling of wrapping around backwards during the
first wraparound period and avoids the infamous "Cannot unwrap, any
wrapping took place yet" error message.

It allows makes sure that for actual timestamp jumps a valid value is
returned instead of 0, which then allows the caller to handle it
properly. Not having this can have the caller see the same timestamp (0)
for a very long time, which for example can cause rtpjitterbuffer to
output the same timestamp for a very long time.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1500

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3202>

19 months agoexamples/webrtc: don't use factory_make_full() for enums
Matthew Waters [Tue, 18 Oct 2022 01:26:21 +0000 (12:26 +1100)]
examples/webrtc: don't use factory_make_full() for enums

They are not currently translated into their respective enum values and
will produce an error.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3210>

19 months agowasapi2: Add support for process loopback capture
Seungha Yang [Sun, 16 Oct 2022 15:40:46 +0000 (00:40 +0900)]
wasapi2: Add support for process loopback capture

Adding loopback capture mode for specified PID.

Note that this feature requires Windows 10 build 20348
(Windows 11/Windows Server 2022 or later),
and any process loopback related properties will not be exposed
if OS does not support it.

Example launch lines:
* wasapi2src loopback-mode=include-process-tree loopback-target-pid=<PID>
 Captures audio generated by an application (specified by PID)
 and its child process
* wasapi2src loopback-mode=exclude-process-tree loopback-target-pid=<PID>
 Captures desktop audio excluding PID and its child process

Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1278
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3195>

19 months agoci: Run windows jobs when win-* binary subprojects are updated
Nirbheek Chauhan [Mon, 17 Oct 2022 20:54:48 +0000 (02:24 +0530)]
ci: Run windows jobs when win-* binary subprojects are updated

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3209>

19 months agomeson: Update flex, bison, and nasm
Nirbheek Chauhan [Mon, 17 Oct 2022 20:51:07 +0000 (02:21 +0530)]
meson: Update flex, bison, and nasm

Latest flex is 2.6.4, bison is 3.8.2, nasm is 2.15.04

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3209>

19 months agoexamples/webrtc/signalling: Fix compatibility with Python 3.10
Sam Van Den Berge [Mon, 17 Oct 2022 08:39:18 +0000 (10:39 +0200)]
examples/webrtc/signalling: Fix compatibility with Python 3.10

Fix asyncio throwing a deprecation warning when using
asyncio.get_event_loop().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3196>

19 months agortmp2sink: Correctly return GST_FLOW_ERROR on error
Arun Raghavan [Fri, 14 Oct 2022 20:21:07 +0000 (16:21 -0400)]
rtmp2sink: Correctly return GST_FLOW_ERROR on error

If there is an error while connecting, the streaming task will be stopped, and
is_running() will be false, causing a GST_FLOW_FLUSHING to be returned. Instead,
we perform the error check (!self->connection) first, to return an error if
that's what occured.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3189>

19 months agogst-play: Don't leak the stream collection
Edward Hervey [Fri, 14 Oct 2022 14:12:45 +0000 (16:12 +0200)]
gst-play: Don't leak the stream collection

We are given a reference to the collection when parsing it from the
message. Just store it (instead of referencing it again).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3186>

19 months agowebrtc/nice: fix small leak of split strings
Mathieu Duponchelle [Fri, 14 Oct 2022 16:51:43 +0000 (18:51 +0200)]
webrtc/nice: fix small leak of split strings

g_strfreev previously stopped at our manual NULL-termination. Fix by
restoring the pointer after joining.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3188>

19 months agogst-docs: Fix typo in hotdoc kwarg
Nirbheek Chauhan [Thu, 13 Oct 2022 20:40:35 +0000 (02:10 +0530)]
gst-docs: Fix typo in hotdoc kwarg

The hotdoc module passes unknown keyword arguments as arguments to
hotdoc, and the fatal warnings argument is --fatal-warnings.

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2972#note_1586361

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3178>

19 months agowavparse: Avoid occasional crash due to referencing freed buffer.
Devin Anderson [Fri, 14 Oct 2022 01:23:04 +0000 (01:23 +0000)]
wavparse: Avoid occasional crash due to referencing freed buffer.

We've seen occasional crashes in the `wavparse` module associated with
referencing a buffer in `gst_wavparse_chain` that's already been freed.  The
reference is stolen when the buffer is transferred to the adapter with
`gst_adapter_push` and, IIUC, assuming the source doesn't hold a reference to
the buffer, the buffer could be freed during interaction with the adapter in
`gst_wavparse_stream_headers`.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3179>

19 months agortsp-client: Remove duplicate documentation
Edward Hervey [Fri, 14 Oct 2022 06:53:18 +0000 (08:53 +0200)]
rtsp-client: Remove duplicate documentation

Confuses the documentation builder, since it's documented twice it complains
about a missing "Since:" marker whereas it's present in the documentation
comment further down

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3180>

19 months agoriff: Mark jpeg as parsed
Julian Bouzas [Thu, 13 Oct 2022 15:21:42 +0000 (11:21 -0400)]
riff: Mark jpeg as parsed

This is needed so that autoplugging works with avidemux and JPEG decoders that
need parsed sink caps (eg rockchip 'mppjpegdec' decoder). It also works fine
with 'jpegdec' decoder regardless.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3175>

19 months agowavparse: Fix crash that occurs in push mode when header chunks are corrupted
Devin Anderson [Thu, 13 Oct 2022 00:20:45 +0000 (00:20 +0000)]
wavparse: Fix crash that occurs in push mode when header chunks are corrupted
in certain ways.

In the case that a test is provided for, the size of the `fmt ` chunk is
changed from 16 bytes to 18 bytes (bytes 17 - 20 below):
```
$ hexdump -C corruptheadertestsrc.wav
00000000  52 49 46 46 e4 fd 00 00  57 41 56 45 66 6d 74 20  |RIFF....WAVEfmt |
00000010  12 00 00 00 01 00 01 00  80 3e 00 00 00 7d 00 00  |.........>...}..|
00000020  02 00 10 00 64 61 74 61                           |....data|
00000028
```

(Note that the original file is much larger.  This was the smallest sub-file
I could find that would generate the crash.)

Note that, while the same issue doesn't cause a crash in pull mode, there's a
different issue in that the file is processed successfully as if it was a .wav
file with zero samples.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3173>

19 months agovp9parse: The show_existing_frame buffer should not be decode only.
He Junyan [Wed, 12 Oct 2022 08:11:47 +0000 (16:11 +0800)]
vp9parse: The show_existing_frame buffer should not be decode only.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3155>

19 months agovp9parse: Correct the pts for frames inside a super frame.
He Junyan [Tue, 11 Oct 2022 08:17:26 +0000 (16:17 +0800)]
vp9parse: Correct the pts for frames inside a super frame.

When the alignment is "FRAME" and the parse is likely connecting to
a decoder, the current PTS setting for VP9 frames inside a super
frame is not very correct.

For example, the super frame may begin with non-displayed frames and
end with a displayed frame. The current way will assign the PTS to
the first non-displayed frame, which is a decode-only frame and the
PTS will be discarded in the video decoder. While the last displayed
frame has invalid PTS, and so the video decoder needs to guess its
PTS based on the frame rate and previous frame's PTS. This is not a
decent and robust way. And more important, when the previous frames
provide DTS, the video decoder will also guess the PTS based on the
previous frames' DTS and trigger the warning like:

  gstvideodecoder.c:3147:gst_video_decoder_prepare_finish_frame: \
  <vavp9dec0> decreasing timestame

It sets the reordered_output and makes the decoder in free run mode.

We should correct the PTS for a super frame, let the non-displayed
frames have no PTS while set the correct PTS to the displayed one.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3155>

19 months agoavfvideosrc: Allow specifying crop coordinates during screen capture
Piotr Brzeziński [Fri, 7 Oct 2022 22:29:03 +0000 (00:29 +0200)]
avfvideosrc: Allow specifying crop coordinates during screen capture

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3153>

19 months agortsp-server: Free client if no connection could be created
Linus Svensson [Fri, 19 Aug 2022 14:16:26 +0000 (16:16 +0200)]
rtsp-server: Free client if no connection could be created

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3164>

19 months agomxfdemux: Add support for Canon XF-HEVC
Edward Hervey [Wed, 12 Oct 2022 09:12:50 +0000 (11:12 +0200)]
mxfdemux: Add support for Canon XF-HEVC

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1495

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3163>

19 months agomxfdemux: Don't leak index table segments on failures
Edward Hervey [Wed, 12 Oct 2022 09:12:14 +0000 (11:12 +0200)]
mxfdemux: Don't leak index table segments on failures

The segment was freed ... but not the contents :)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3163>

19 months agortsp-server: Add since marker for adjust_error_code
Peter Stensson [Tue, 11 Oct 2022 12:55:48 +0000 (14:55 +0200)]
rtsp-server: Add since marker for adjust_error_code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3157>

19 months agomeson: Update libsoup.wrap
Xavier Claessens [Tue, 11 Oct 2022 18:53:40 +0000 (14:53 -0400)]
meson: Update libsoup.wrap

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3162>

19 months agovideorate: Do not close segment when getting a same segment twice
Thibault Saunier [Fri, 7 Oct 2022 14:46:29 +0000 (11:46 -0300)]
videorate: Do not close segment when getting a same segment twice

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3059>

19 months agovideorate: Handle closing segment on EOS right after caps event
Thibault Saunier [Wed, 14 Sep 2022 19:39:48 +0000 (16:39 -0300)]
videorate: Handle closing segment on EOS right after caps event

The scenario is what we try in the tests:
- we have a segment with .stop set
- some frame(s) flow
- we get a CAPS event
- we get an EOS (before getting buffers after the CAPS event)

in that case, without that patch, the segment is not properly closed
which is not correct. In this patch we keep track of previous caps until
a new buffer arrives, this way in that situation we set previous caps
again, and close the segment with the previous buffer.

Fixes: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1352
in this specific case

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3059>

19 months agovalidate: Plug some leaks
Thibault Saunier [Wed, 21 Sep 2022 14:44:59 +0000 (11:44 -0300)]
validate: Plug some leaks

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3059>

19 months agooss4: Fix debug category initialization
Edward Hervey [Tue, 11 Oct 2022 13:00:37 +0000 (15:00 +0200)]
oss4: Fix debug category initialization

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1456

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3158>

19 months agowebrtc: Move GST_WEBRTC_ERROR_TYPE_ERROR at the end of the enum to keep ABI compatibility
Sebastian Dröge [Tue, 11 Oct 2022 10:09:20 +0000 (13:09 +0300)]
webrtc: Move GST_WEBRTC_ERROR_TYPE_ERROR at the end of the enum to keep ABI compatibility

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3154>

19 months agotests/webrtc: Add test for 'add-turn-server' action signal
Sangchul Lee [Thu, 6 Oct 2022 11:37:45 +0000 (20:37 +0900)]
tests/webrtc: Add test for 'add-turn-server' action signal

It just checks return value of the action signal.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3131>

19 months agosctpenc: Prohibit sending of interleaved message parts
Johan Sternerup [Thu, 10 Dec 2020 15:25:26 +0000 (16:25 +0100)]
sctpenc: Prohibit sending of interleaved message parts

Apparently we cannot start sending messages from another datachannel
before the previous message was completely sent. usrsctplib will
complain about being locked on another stream id and set
errno=EINVAL.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2454>

19 months agoopengl: Fix usage of eglCreate/DestroyImage
Nicolas Dufresne [Mon, 22 Aug 2022 20:33:23 +0000 (16:33 -0400)]
opengl: Fix usage of eglCreate/DestroyImage

The implementation was inconsistent between create and destroy. EGLImage
creation and destruction is requires for EGL 1.5 and up, while
otherwise the KHR version is only available if EGL_KHR_image_base
feature is set. Not doing these check may lead to getting a function
pointer to a stub, which is notably the case when using apitrace.

Fixes #1389

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2925>

19 months agortsp-server: Add support for adjusting request response on pipeline errors
Peter Stensson [Tue, 21 Jun 2022 07:51:55 +0000 (09:51 +0200)]
rtsp-server: Add support for adjusting request response on pipeline errors

The idea is to give the application the possibility to adjust the error
code when responding to a request. For that purpose the pipeline's bus
messages are emitted to subscribers through a signal handle-message.
The subscribers can then check those messages for errors and adjust
the response error code by overriding the virtual method
adjust_error_code().

Fixes #1294

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2972>

19 months agosplitmuxsrc: don't queue data on unlinked pads
Mathieu Duponchelle [Fri, 7 Oct 2022 23:03:13 +0000 (01:03 +0200)]
splitmuxsrc: don't queue data on unlinked pads

Once a pad has returned NOT_LINKED, the part reader shouldn't let its
corresponding data queue run full and eventually (after 20 seconds)
stall playback.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3145>

19 months agortpsource: Don't do probation for RTX sources
Sebastian Dröge [Mon, 3 Oct 2022 17:28:47 +0000 (20:28 +0300)]
rtpsource: Don't do probation for RTX sources

Disable probation for RTX sources as packets will arrive very
irregularly and waiting for a second packet usually exceeds the deadline
of the retransmission.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/181

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3112>

19 months agortp: examples: client-rtpaux: Provide correct caps by payload type and RTX pt map...
Sebastian Dröge [Mon, 3 Oct 2022 16:58:38 +0000 (19:58 +0300)]
rtp: examples: client-rtpaux: Provide correct caps by payload type and RTX pt map by session

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3112>

19 months agotests/check/rtpsession: extend test_internal_sources_timeout
George Kiagiadakis [Fri, 25 Jan 2019 22:04:50 +0000 (17:04 -0500)]
tests/check/rtpsession: extend test_internal_sources_timeout

to verify that rtx SSRCs do not BYE after timeout

See https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/360

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3112>

19 months agortpsession: Remember the corresponding media SSRC for RTX sources
Sebastian Dröge [Mon, 3 Oct 2022 16:12:55 +0000 (19:12 +0300)]
rtpsession: Remember the corresponding media SSRC for RTX sources

This allows timing out the RTX source and sending BYE for it when the
actual media source belonging to it is timed out.

This change only applies to sending sources from this session.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/360

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3112>

19 months agortpsource: Rename rtp_source_update_caps to rtp_source_update_send_caps
Sebastian Dröge [Mon, 3 Oct 2022 16:20:14 +0000 (19:20 +0300)]
rtpsource: Rename rtp_source_update_caps to rtp_source_update_send_caps

To make it clear that this is only used for sending RTP sources.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3112>

19 months agortpsession: Rename gst_rtp_session_sink_setcaps to gst_rtp_session_setcaps_recv_rtp
Sebastian Dröge [Mon, 3 Oct 2022 10:48:36 +0000 (13:48 +0300)]
rtpsession: Rename gst_rtp_session_sink_setcaps to gst_rtp_session_setcaps_recv_rtp

to make it clearer that this is for setting receiver caps and to make it
more consistent with gst_rtp_session_setcaps_send_rtp.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3112>

19 months agodecodebin3: allow to call "dispose" multiple times
Aleksandr Slobodeniuk [Thu, 6 Oct 2022 14:23:56 +0000 (16:23 +0200)]
decodebin3: allow to call "dispose" multiple times

https://docs.gtk.org/gobject/concepts.html#reference-counts-and-cycles

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3135>

19 months agodecklink: reset calculation of gst_decklink_video_src_update_time_mapping on no_signa...
Wojciech Kapsa [Fri, 7 Oct 2022 06:30:05 +0000 (08:30 +0200)]
decklink: reset calculation of gst_decklink_video_src_update_time_mapping on no_signal. When the HDMI cable was disconnected for a long time, the calculation took too much time. SDI cable works fine.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3132>

19 months agoci: Fix website regen on push
Nirbheek Chauhan [Fri, 7 Oct 2022 09:52:36 +0000 (15:22 +0530)]
ci: Fix website regen on push

Don't make the integrate stage manual, we need it to regen the website

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3134>

19 months agoaggregator: fix input buffering
Guillaume Desmottes [Fri, 7 Oct 2022 12:39:47 +0000 (14:39 +0200)]
aggregator: fix input buffering

We need to be able to buffer at least the aggregator latency +
upstream latency, which is the value used to compute the aggregator
deadline.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3138>

19 months agoMeson: Fix libxml2 fallback
Xavier Claessens [Fri, 7 Oct 2022 11:56:21 +0000 (07:56 -0400)]
Meson: Fix libxml2 fallback

The variable xml2lib_dep does not exist. The correct name is already in
the wrap file.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3136>

19 months agortspsrc: Retry SETUP with non-compliant URL resolution on "Bad Request" and "Not...
Sebastian Dröge [Thu, 6 Oct 2022 12:02:22 +0000 (15:02 +0300)]
rtspsrc: Retry SETUP with non-compliant URL resolution on "Bad Request" and "Not found"

Various RTSP servers/cameras assume base and control URL to be simply
appended instead of being resolved according to the relative URL
resolution algorithm as mandated by the RTSP specification.

To work around this, try using such a non-compliant control URL if the
server didn't like the URL used in the first SETUP request.

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1447
Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/922

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3127>

19 months agowebrtcbin: Fix pointer dereference before null check
Sangchul Lee [Thu, 22 Sep 2022 13:39:31 +0000 (22:39 +0900)]
webrtcbin: Fix pointer dereference before null check

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3129>

19 months agodecklink: Add new persistent-id property and sort devices by persistent ID
Wojciech Kapsa [Mon, 26 Sep 2022 11:57:15 +0000 (13:57 +0200)]
decklink: Add new persistent-id property and sort devices by persistent ID

The order of the devices iterator from the SDK is undefined and can
randomly change.

Keep the device-number property for backwards compatibility and
simplicity but prefer the persistent-id property and also use it for the
device provider implementation.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3078>

19 months agodecodebin3: fix mutex leaks
Aleksandr Slobodeniuk [Thu, 6 Oct 2022 11:03:26 +0000 (13:03 +0200)]
decodebin3: fix mutex leaks

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3126>

19 months agotranscodebin: Implement support for upstream stream selection
Thibault Saunier [Tue, 4 Oct 2022 22:19:57 +0000 (19:19 -0300)]
transcodebin: Implement support for upstream stream selection

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3128>

19 months agodecodebin3: Do not try to plug a decoder on raw formats
Thibault Saunier [Mon, 3 Oct 2022 18:20:53 +0000 (15:20 -0300)]
decodebin3: Do not try to plug a decoder on raw formats

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3123>

19 months agovideosink: Don't return unknown end-time from get_times()
Seungha Yang [Wed, 5 Oct 2022 15:00:59 +0000 (00:00 +0900)]
videosink: Don't return unknown end-time from get_times()

... in case of reverse playback. Otherwise basesink will not
wait for clock

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/3121>