Daniel Stenberg [Tue, 12 Jul 2011 21:24:52 +0000 (23:24 +0200)]
silence picky compilers: mark unused parameters
Modern gcc versions (4.6.X) get more picky by default and have started
to warn for unused parameters, but luckily gcc also allows us to mark
them as unused so that we can avoid the warnings.
Julien Chaffraix [Fri, 10 Jun 2011 15:26:34 +0000 (08:26 -0700)]
gssapi.c: Simplified the function.
Removed the parameters that were common to all our invocation.
Julien Chaffraix [Fri, 10 Jun 2011 15:16:06 +0000 (08:16 -0700)]
Added Curl_gss_init_sec_context.
This function wraps our calls to gss_init_sec_context so that we
have a unified way to talk to GSSAPI.
Julien Chaffraix [Mon, 27 Jun 2011 14:53:38 +0000 (07:53 -0700)]
http_negociate: Be consistent in gss_init_sec_context attributes.
This change makes this callsite match the rest of the code.
Daniel Stenberg [Mon, 4 Jul 2011 20:10:32 +0000 (22:10 +0200)]
code style: space between close paren and open brace
Daniel Stenberg [Mon, 4 Jul 2011 20:08:14 +0000 (22:08 +0200)]
checksrc: detect open brace without space
We use "if(condition) {" with a space between the close paren and the
open brace.
Daniel Stenberg [Mon, 4 Jul 2011 20:04:04 +0000 (22:04 +0200)]
polarssl.h: remove CVS leftover
Daniel Stenberg [Sun, 3 Jul 2011 20:13:18 +0000 (22:13 +0200)]
help output: more gnu like output
First, the -J/--remote-header-name was wrongly sorted in the --help
output as pointed out in bug report #3349271.
Then, I changed the format of the texts to follow the man page better in
that it now uses "-A, --long" intead of "-A/--long". I also made all
additional arguments get written as in "-A, --long FILENAME" instead of
the previous "<filename>" style.
Reported by: Herve Amblard
Bug: http://curl.haxx.se/bug/view.cgi?id=3349271
Daniel Stenberg [Sun, 3 Jul 2011 17:15:06 +0000 (19:15 +0200)]
sws: allow multiple commands in <servercmd>
Daniel Stenberg [Fri, 1 Jul 2011 20:57:28 +0000 (22:57 +0200)]
Curl_http_readwrite_headers: minor indent fix
Daniel Stenberg [Thu, 30 Jun 2011 07:58:45 +0000 (09:58 +0200)]
gitignore: config.cache
Daniel Stenberg [Thu, 30 Jun 2011 07:57:23 +0000 (09:57 +0200)]
docs: FTP quotes support '*' prefix to ignore errors
By default libcurl stops processing quote commands on failures.
Daniel Stenberg [Wed, 29 Jun 2011 18:42:02 +0000 (20:42 +0200)]
THANKS: new contributors from 7.21.7
Daniel Stenberg [Wed, 29 Jun 2011 10:26:23 +0000 (12:26 +0200)]
get_gss_name: proxy auth without proxy set equals error
Previously it would access a NULL pointer and die.
Bug: http://curl.haxx.se/mail/lib-2011-06/0170.html
Reported by: Christian Hagele
Daniel Stenberg [Tue, 28 Jun 2011 17:08:51 +0000 (19:08 +0200)]
examples: cleanup curl includes
Only <curl/curl.h> is needed typically and curl/types.h has been removed
Daniel Stenberg [Sun, 26 Jun 2011 21:12:08 +0000 (23:12 +0200)]
libtests: stop checking for CURLM_CALL_MULTI_PERFORM
CURLM_CALL_MULTI_PERFORM stopped being a valid return code from
curl_multi_perform back in 7.20.0. All the libcurl tests are ajusted to
this and no longer check for this return code. Makes them simpler.
Dan Fandrich [Fri, 24 Jun 2011 19:32:38 +0000 (12:32 -0700)]
Fixed test 1300 to pass the memory torture test
Dan Fandrich [Fri, 24 Jun 2011 05:38:33 +0000 (22:38 -0700)]
Display notes from setup file in testcurl.pl
Autobuild submitters can use this to add some text to their
setup files to describe issues they've found with the build
or tests. This could include laying blame on test failures on
network issues or dependent libraries, explaining away compiler
warnings or providing any additional information that could be
useful to people reviewing and investigating problems with the
publicly available autobuild logs. Note that persistent test
failures that are not issues with curl itself should normally be
fixed by excluding them from the test run instead.
This is an entirely optional field that is not entered by the
user the first time a new build is created.
Dan Fandrich [Fri, 24 Jun 2011 04:20:29 +0000 (21:20 -0700)]
Added a leap second test to test517
Daniel Stenberg [Thu, 23 Jun 2011 21:10:00 +0000 (23:10 +0200)]
runtests.pl: warn if a test is explicitly disabled
Just to make sure a user is aware of it.
Daniel Stenberg [Thu, 23 Jun 2011 11:02:47 +0000 (13:02 +0200)]
bump release: start working towards 7.21.8
Daniel Stenberg [Tue, 21 Jun 2011 21:18:05 +0000 (23:18 +0200)]
parsedate: detect more invalid dates better
Daniel Stenberg [Thu, 23 Jun 2011 07:31:12 +0000 (09:31 +0200)]
curl_formfree: clarify which pointer to free
Daniel Stenberg [Wed, 22 Jun 2011 21:12:39 +0000 (23:12 +0200)]
RELEASE-NOTES: mention security issue
20110623
libcurl inappropriate GSSAPI delegation. Full details at
http://curl.haxx.se/docs/adv_20110623.html
Daniel Stenberg [Wed, 22 Jun 2011 11:07:24 +0000 (13:07 +0200)]
RELEASE-NOTES: synced with
9016958aa8989
Daniel Stenberg [Tue, 7 Jun 2011 22:10:26 +0000 (00:10 +0200)]
Curl_input_negotiate: do not delegate GSSAPI credentials
This is a security flaw. See curl advisory
20110623 for details.
Reported by: Richard Silverman
Josue Andrade Gomes [Tue, 21 Jun 2011 18:05:06 +0000 (20:05 +0200)]
windows build: use correct MS CRT
Daniel Stenberg [Tue, 21 Jun 2011 15:54:25 +0000 (08:54 -0700)]
Merge pull request #23 from salty-horse/pop3_list_space
[pop3] remove extra space in LIST command
Ori Avtalion [Mon, 20 Jun 2011 22:33:32 +0000 (01:33 +0300)]
[pop3] remove extra space in LIST command
Some servers, e.g. mail.bezeqint.net:110, consider it a syntax error
Yang Tse [Tue, 21 Jun 2011 14:28:15 +0000 (16:28 +0200)]
http: fix compiler warning
compiler warning: conditional expression is constant
Yang Tse [Tue, 21 Jun 2011 14:06:56 +0000 (16:06 +0200)]
asyn-thread: fix compiler warning
compiler warning: variable is initialized but not referenced
Yang Tse [Tue, 21 Jun 2011 13:26:24 +0000 (15:26 +0200)]
cmake: remove spurious definition
Daniel Stenberg [Tue, 21 Jun 2011 06:44:42 +0000 (08:44 +0200)]
FAQ: more blurb on persistent connections
Yang Tse [Mon, 20 Jun 2011 22:02:49 +0000 (00:02 +0200)]
xc-translit.m4 fix quoting
Daniel Stenberg [Mon, 20 Jun 2011 20:20:22 +0000 (22:20 +0200)]
INSTALL: mention the GIT-INFO file
Dan Fandrich [Mon, 20 Jun 2011 19:01:38 +0000 (12:01 -0700)]
Added LOCAL_MODULE_TAGS to support Android gingerbread
Amr Shahin [Sun, 19 Jun 2011 00:27:22 +0000 (03:27 +0300)]
unitteset: Curl_llist_move
adding unit test for Curl_llist_move, documenting unit-tested functions
in llist.c, changing unit-test to unittest, replacing assert calls with
abort_unless calls
Daniel Stenberg [Fri, 17 Jun 2011 20:21:36 +0000 (22:21 +0200)]
CURLFORM_STREAM: acknowledge CURLFORM_FILENAME
The CURLFORM_STREAM is documented to only insert a file name (and thus
look like a file upload) in the part if CURLFORM_FILENAME is set, but in
reality it always inserted a filename="" and if CURLFORM_FILENAME wasn't
set, it would insert insert rubbish (or possibly crash).
This is now fixed to work as documented, and test 554 has been extended
to verify this.
Reported by: Sascha Swiercy
Bug: http://curl.haxx.se/mail/lib-2011-06/0070.html
Yang Tse [Fri, 17 Jun 2011 19:01:41 +0000 (21:01 +0200)]
configure: avoid direct usage of AS_TR_* macros
Yang Tse [Fri, 17 Jun 2011 18:59:58 +0000 (20:59 +0200)]
xc-translit.m4 provides transliteration macros with well defined behavior.
Daniel Stenberg [Tue, 14 Jun 2011 17:17:41 +0000 (19:17 +0200)]
RELEASE-NOTES: add more contributors for this release
Daniel Stenberg [Tue, 14 Jun 2011 12:45:44 +0000 (14:45 +0200)]
RELEASE-NOTES: synced with
0aedccc18a33a778535
Daniel Stenberg [Mon, 13 Jun 2011 20:32:00 +0000 (22:32 +0200)]
curl_formget: fix FILE * leak
Properly deal with the fact that the last fread() call most probably is
a short read, and when using callbacks in fact all calls can be short
reads. No longer consider a file read done until it returns a 0 from the
read function.
Reported by: Aaron Orenstein
Bug: http://curl.haxx.se/mail/lib-2011-06/0048.html
Daniel Stenberg [Mon, 13 Jun 2011 20:05:13 +0000 (22:05 +0200)]
curl_formget: treat CURLFORM_STREAM better
If a piece is set to use a callback to get the data, it should not be
treated as data. It unfortunately also requires that curl_easy_perform()
or similar has been used as otherwise the callback function hasn't been
figured out and curl_formget won't know how to get the content.
Daniel Stenberg [Mon, 13 Jun 2011 20:03:33 +0000 (22:03 +0200)]
curl_formget.3: CURLFORM_STREAM has its drawbacks
Due to a design flaw, the CURLFORM_STREAM option doesn't really work
with curl_formget until after curl_easy_perform (or similar).
Daniel Stenberg [Mon, 13 Jun 2011 17:02:38 +0000 (19:02 +0200)]
FAQ: binding clarification
We don't author the bindings, they are created outside the main project.
Dan Fandrich [Sun, 12 Jun 2011 00:02:37 +0000 (17:02 -0700)]
Added http as a dependency of test 1308
Daniel Stenberg [Sat, 11 Jun 2011 22:10:51 +0000 (00:10 +0200)]
test1309: added to the dist
Daniel Stenberg [Sat, 11 Jun 2011 21:01:09 +0000 (23:01 +0200)]
write: add return code checks when used
These were just warnings in test code but it still makes it nicer to not
generate them.
Daniel Stenberg [Sat, 11 Jun 2011 20:56:45 +0000 (22:56 +0200)]
long/int mess
Typecast when converting to int from long to avoid some compiler warnings
Yang Tse [Sat, 11 Jun 2011 16:39:34 +0000 (18:39 +0200)]
configure: OpenSSL API detection cleanup
Dan Fandrich [Sat, 11 Jun 2011 07:10:09 +0000 (00:10 -0700)]
Fixed test 1309 to pass the torture test
Removing dynamic allocations also simplifies the test.
Daniel Stenberg [Fri, 10 Jun 2011 18:19:35 +0000 (20:19 +0200)]
splay: add unit tests
The test code that was #ifdef'ed in the code was converted into unit
tests in test case 1309. I also removed the #if 0'ed code from splay.c
Daniel Stenberg [Fri, 10 Jun 2011 12:40:46 +0000 (14:40 +0200)]
unittest: mark all unit tested functions
With "@unittest: [num]" in the header comment for each tested function.
Shows we have a log way to go still...
Daniel Stenberg [Fri, 10 Jun 2011 11:17:17 +0000 (13:17 +0200)]
CURLOPT_WRITEHEADER: clarify the docs
Daniel Stenberg [Fri, 10 Jun 2011 10:03:29 +0000 (12:03 +0200)]
unit test formpost: added test case 1308
This is a few first rather basic tests of curl_formadd() and
curl_formget(). Should serve as building blocks to add more variations
to the test.
Yang Tse [Thu, 9 Jun 2011 20:55:16 +0000 (22:55 +0200)]
configure: warn if OpenSSL headers and library versions don't match
Yang Tse [Thu, 9 Jun 2011 17:03:10 +0000 (19:03 +0200)]
configure: get API info for a couple of OpenSSL functions (followup 2)
Yang Tse [Wed, 8 Jun 2011 22:45:38 +0000 (00:45 +0200)]
configure: get API info for a couple of OpenSSL functions (followup 1)
Yang Tse [Wed, 8 Jun 2011 13:57:36 +0000 (15:57 +0200)]
configure: fix recvfrom 5th arg type qualifier detection (followup)
Yang Tse [Wed, 8 Jun 2011 11:37:35 +0000 (13:37 +0200)]
configure: fix recvfrom 5th arg type qualifier detection
Kamil Dudka [Tue, 7 Jun 2011 13:57:13 +0000 (15:57 +0200)]
disconnect: wipe out the keeps_speed time stamp
When closing a connection, the speedchecker's timestamp is now deleted
so that it cannot accidentally be used by a fresh connection on the same
handle when examining the transfer speed.
Bug: https://bugzilla.redhat.com/679709
Yang Tse [Tue, 7 Jun 2011 16:35:42 +0000 (18:35 +0200)]
urldata: use uniform inclusion style for OpenSSL headers
Daniel Stenberg [Tue, 7 Jun 2011 11:40:11 +0000 (13:40 +0200)]
HTTP time condition: force closure for 200 OK
When a time condition isn't met, so that no body is delivered to the
application even though a 2xx response is being read from the server, we
must close the connection to avoid a re-use of the connection to be
completely tricked.
Added test 1128 to verify.
Daniel Stenberg [Tue, 7 Jun 2011 11:15:50 +0000 (13:15 +0200)]
RELEASE-NOTES: synced with
b772f3a32146d7d
Yang Tse [Mon, 6 Jun 2011 18:47:36 +0000 (20:47 +0200)]
configure: get API info for a couple of OpenSSL functions
Daniel Stenberg [Sun, 5 Jun 2011 10:06:50 +0000 (12:06 +0200)]
wait_ms: takes an int argument
Typecasts added since I changed more code to use long for timeouts
Daniel Stenberg [Sat, 4 Jun 2011 19:19:14 +0000 (21:19 +0200)]
Curl_socket_ready: make timeout a 'long'
It was mostly typecasted to int all over the code so switching to long
instead all over should be a net gain.
Yang Tse [Sat, 4 Jun 2011 02:27:09 +0000 (04:27 +0200)]
xlc: avoid preprocessor definition usage when linking
Yang Tse [Fri, 3 Jun 2011 18:06:42 +0000 (20:06 +0200)]
unit tests: disable unit tests for a given cross-compilation configuration.
cross-compilation of unit tests static library/programs fails when
libcurl shared library is also built. This might be due to a libtool or
automake issue. In this case we disable unit tests.
Daniel Stenberg [Fri, 3 Jun 2011 18:02:07 +0000 (20:02 +0200)]
cookie_output: made private
Daniel Stenberg [Fri, 3 Jun 2011 17:54:17 +0000 (19:54 +0200)]
digest_cleanup_one: made private
Daniel Stenberg [Fri, 3 Jun 2011 17:51:08 +0000 (19:51 +0200)]
privatise: make private functions static
Daniel Stenberg [Fri, 3 Jun 2011 17:33:23 +0000 (19:33 +0200)]
Curl_fileinfo_dup: removed, not used
Daniel Stenberg [Fri, 3 Jun 2011 17:31:32 +0000 (19:31 +0200)]
parsedate: turn private and static
I removed the prefix as well accordingly.
Dan Fandrich [Fri, 3 Jun 2011 01:41:57 +0000 (18:41 -0700)]
curl hasn't sent a Pragma: header by default for a while
Yang Tse [Thu, 2 Jun 2011 20:26:01 +0000 (22:26 +0200)]
unit tests: attempt to fix linkage issue
Yang Tse [Thu, 2 Jun 2011 20:19:39 +0000 (22:19 +0200)]
urlglob: fix zero size malloc
Yang Tse [Thu, 2 Jun 2011 17:42:24 +0000 (19:42 +0200)]
Remove unnecessary typecast
Yang Tse [Thu, 2 Jun 2011 17:19:36 +0000 (19:19 +0200)]
compiler warning: fix
Fix compiler warning: cast increases required alignment
Yang Tse [Thu, 2 Jun 2011 15:02:46 +0000 (17:02 +0200)]
unit tests: make unit tests building actually depend on --enable-debug option.
Yang Tse [Thu, 2 Jun 2011 10:52:52 +0000 (12:52 +0200)]
OpenSSL enabled: require OPENSSL_VERSION_NUMBER definition before usage.
Yang Tse [Wed, 1 Jun 2011 19:39:18 +0000 (21:39 +0200)]
unit tests: more build adjustments
Daniel Stenberg [Wed, 1 Jun 2011 17:50:08 +0000 (19:50 +0200)]
CURLOPT_WILDCARDMATCH: minor style edit
Due to some flaw in roffit I removed some style changes to make the web
page look better.
Yang Tse [Wed, 1 Jun 2011 12:43:25 +0000 (14:43 +0200)]
makefile: avoid preprocessor definition usage when linking
Yang Tse [Wed, 1 Jun 2011 10:13:42 +0000 (12:13 +0200)]
warnless: icc 9.1 workaround
Daniel Stenberg [Tue, 31 May 2011 08:44:10 +0000 (10:44 +0200)]
testcurl.pl: allow configure args to use '='
Yang Tse [Mon, 30 May 2011 20:32:58 +0000 (22:32 +0200)]
Makefile.am: fix spurious CFLAGS duplication
Dan Fandrich [Mon, 30 May 2011 20:11:38 +0000 (13:11 -0700)]
Removed types.h from Android makefile
Daniel Stenberg [Mon, 30 May 2011 09:57:28 +0000 (11:57 +0200)]
configure.ac: skip /dev/urandom check when cross-compiling
Bug: http://curl.haxx.se/bug/view.cgi?id=3307835
Yang Tse [Sun, 29 May 2011 16:25:49 +0000 (18:25 +0200)]
main: fix header inclusion order
Currently, Windows cross-compiled autobuilds require inclusion of setup.h
before curl.h to get definitions of CURL_STATICLIB and BUILDING_LIBCURL.
Yang Tse [Sun, 29 May 2011 01:56:26 +0000 (03:56 +0200)]
main: fix header inclusion order
Yang Tse [Fri, 27 May 2011 11:34:54 +0000 (13:34 +0200)]
distribution: Fix EXTRA_DIST letter case
Daniel Stenberg [Fri, 27 May 2011 09:12:52 +0000 (11:12 +0200)]
curl_easy_setopt.3: NOPROGRESS also affects the callback
Yang Tse [Fri, 27 May 2011 04:56:56 +0000 (06:56 +0200)]
warnless: header inclusion fix
Yang Tse [Thu, 26 May 2011 17:17:10 +0000 (19:17 +0200)]
Make checksrc.pl work on more out-of-tree builds
Source files given with relative paths do not have the
-D directory specifier prepended.
Yang Tse [Thu, 26 May 2011 13:44:53 +0000 (15:44 +0200)]
compiler warning: fix
Fix compiler warning: conversion may lose significant bits
Yang Tse [Thu, 26 May 2011 12:53:13 +0000 (14:53 +0200)]
socks: fix unaligned memory access
Yang Tse [Thu, 26 May 2011 10:40:04 +0000 (12:40 +0200)]
compiler warning: fix
Fix compiler warning: variable was set but never used
Fix compiler warning: clobber ignored
Yang Tse [Wed, 25 May 2011 18:22:46 +0000 (20:22 +0200)]
unit tests: build adjustment
Also define UNITTESTS macro when building unit test sources.
Fixing compiler warning: external definition with no prior declaration