Arun Raghavan [Sat, 25 Aug 2012 04:58:44 +0000 (10:28 +0530)]
Update NEWS with fix for bug 682346
Forgot to push this out with the original commit.
Arun Raghavan [Tue, 21 Aug 2012 11:13:14 +0000 (16:43 +0530)]
build: Make telepathy backend optional
This is handy for while developing for those who don't always have
bleeding edge telepathy-glib. As a side-effect, tests are also made
optional (but on by default).
https://bugzilla.gnome.org/show_bug.cgi?id=682346
Jeremy Whiting [Fri, 24 Aug 2012 21:54:04 +0000 (15:54 -0600)]
inspect: Fix crash when Utils.output_filestream is uninitialized.
Philip Withnall [Thu, 23 Aug 2012 21:40:45 +0000 (22:40 +0100)]
Bug 682572 — Build failures due to accessing static members
Fix some more build failures due to accessing static members using an instance
variable. Also fix an instance of calling an async function with an implicit
‘.begin()’.
Hopefully that’s the last of them.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=682572
Piotr Drąg [Thu, 23 Aug 2012 00:52:39 +0000 (02:52 +0200)]
Updated Polish translation
Dirgita [Tue, 21 Aug 2012 09:49:01 +0000 (16:49 +0700)]
Updated Indonesian translation
Philip Withnall [Mon, 30 Jul 2012 10:03:21 +0000 (12:03 +0200)]
Bug 664072 — Folks should only use assert*() for critical, program-terminating errors
Turn various assert()s into return[_val]_if_fail()s.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=664072
Fran Diéguez [Thu, 16 Aug 2012 22:31:42 +0000 (00:31 +0200)]
Updated Galician translations
Travis Reitter [Wed, 15 Aug 2012 00:40:16 +0000 (17:40 -0700)]
Note fixes for bgo#681420 in NEWS.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Travis Reitter [Wed, 15 Aug 2012 00:37:39 +0000 (17:37 -0700)]
Access static class members through class; use explicit .begin()
This covers the libsocialweb backend tests.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Travis Reitter [Mon, 13 Aug 2012 16:51:09 +0000 (09:51 -0700)]
Access static class members through class, not instance.
This covers the libsocialweb backend.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Philip Withnall [Tue, 14 Aug 2012 20:21:05 +0000 (21:21 +0100)]
docs: Use correct Valadoc syntax for monospaced content
The syntax is ‘``monospaced text``’ rather than ‘`monospaced text`’, which
we were consistently getting wrong. Valadoc now produces the correct markup
for monospaced text, but it doesn’t appear differently from other text at
the moment due to Valadoc not having any CSS for it. That will change soon.
Similarly, Valadoc currently produces the wrong markup for monospaced text
with the gtkdoc doclet, but that will soon be fixed.
See: https://bugzilla.gnome.org/show_bug.cgi?id=681721
Jeremy Whiting [Fri, 6 Jul 2012 20:21:02 +0000 (14:21 -0600)]
Add gir and .vapi files to DISTCLEANFILES if not building a release
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=643128
Erick Pérez Castellanos [Tue, 14 Aug 2012 17:22:10 +0000 (13:22 -0400)]
eds: Add create_source_registry to eds tests.
Erick Pérez Castellanos [Mon, 13 Aug 2012 19:18:58 +0000 (15:18 -0400)]
tracker tests fixed to match last vala release.
Vala change:
1. Warn when accessing static members with an instance reference.
2. Deprecate implicit .begin for async methods.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Erick Pérez Castellanos [Mon, 13 Aug 2012 19:17:55 +0000 (15:17 -0400)]
tracker backend fixed to match last vala release.
Vala change:
1. Warn when accessing static members with an instance reference.
2. Deprecate implicit .begin for async methods.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Philip Withnall [Mon, 13 Aug 2012 20:45:20 +0000 (21:45 +0100)]
docs: Add replacement symbols to ‘Deprecated’ annotations
This improves the documentation (and valac error messages) a little.
Sandeep Sheshrao Shedmake [Sun, 12 Aug 2012 11:03:08 +0000 (16:33 +0530)]
Added Marathi Translation
A S Alam [Sun, 12 Aug 2012 03:44:20 +0000 (09:14 +0530)]
Update Punjabi Translation
Jeremy Whiting [Fri, 10 Aug 2012 23:00:53 +0000 (17:00 -0600)]
eds: Add create_source_registry to eds-backend to fix build.
Jeremy Whiting [Tue, 7 Aug 2012 02:13:00 +0000 (20:13 -0600)]
Prefer earlier alphabetical uid persona when two personas from the same persona store.
Fixes bug https://bugzilla.gnome.org/show_bug.cgi?id=681346
Sweta Kothari [Fri, 10 Aug 2012 11:27:07 +0000 (16:57 +0530)]
Updated gujarati file
Sweta Kothari [Fri, 10 Aug 2012 11:01:07 +0000 (16:31 +0530)]
Updated gujarati file
Sweta Kothari [Fri, 10 Aug 2012 09:41:08 +0000 (15:11 +0530)]
Updated gujarati file
Philip Withnall [Thu, 9 Aug 2012 23:15:40 +0000 (00:15 +0100)]
docs: Various small fixes and expansions of documentation
• Various links fixed to point to class documentation rather than its
constructor documentation (this is a quirk of Valadoc; if using
“{@link ClassName}” inside a method of ClassName, the link will point to
ClassName’s constructor because symbols are resolved relatively and the
class’ constructor is called “ClassName”).
• Various bits of documentation expanded (mostly trivially) to shut gtk-doc
up about missing long descriptions.
• Some Vala code attributes moved around so the documentation comments are
correctly associated with the code. (This shouldn’t change the behaviour
of the attributes themselves.)
• Some trivial constructors added to classes in order to give them
documentation.
• Constructor for Utils added and deprecated immediately. Utils should
become a nested namespace on the next API break, since it will only ever
contain static methods, and thus doesn’t need to be instantiable (which
folks will make it at the moment).
Philip Withnall [Thu, 9 Aug 2012 23:13:11 +0000 (00:13 +0100)]
docs: Remove protected symbols from the documentation
Folks isn’t really extensible outside its own source tree, so why clutter
up the documentation (and its build process/logs) with protected symbols?
Philip Withnall [Thu, 9 Aug 2012 23:11:20 +0000 (00:11 +0100)]
eds: Minor API fixes in the EDS backend
These APIs, introduced in folks 0.7.1 (so this is an unstable API break,
but that’s OK), weren’t quite right in C. The SourceRegistry constructor
shouldn’t be exposed publicly as part of folks, and the PersonaStore
constructor had a stray extra parameter.
Erick Pérez Castellanos [Thu, 9 Aug 2012 18:57:15 +0000 (14:57 -0400)]
tests fixed to match last vala release.
Vala change:
1. Warn when accessing static members with an instance reference.
2. Deprecate implicit .begin for async methods.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Erick Pérez Castellanos [Thu, 9 Aug 2012 18:55:38 +0000 (14:55 -0400)]
Fixes to build with last vala release.
Vala change:
1. Warn when accessing static members with an instance reference.
2. Deprecate implicit .begin for async methods.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Erick Pérez Castellanos [Thu, 9 Aug 2012 18:54:54 +0000 (14:54 -0400)]
telepathy backend fixed to match last vala release.
Vala change:
1. Warn when accessing static members with an instance reference.
2. Deprecate implicit .begin for async methods.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Erick Pérez Castellanos [Thu, 9 Aug 2012 18:54:04 +0000 (14:54 -0400)]
key-file backend fixed to match last vala release.
Vala change:
1. Warn when accessing static members with an instance reference.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Erick Pérez Castellanos [Thu, 9 Aug 2012 18:52:52 +0000 (14:52 -0400)]
eds backend fixed to match last vala release.
Vala change:
1. Warn when accessing static members with an instance reference.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=681420
Arvis Lacis [Tue, 7 Aug 2012 19:22:53 +0000 (22:22 +0300)]
Added Latvian translation
chandankumar [Tue, 7 Aug 2012 05:52:34 +0000 (11:22 +0530)]
LINGUAS updated and new hindi translation added
Nilamdyuti Goswami [Mon, 6 Aug 2012 08:16:18 +0000 (13:46 +0530)]
Assamese translation completed
Nilamdyuti Goswami [Mon, 6 Aug 2012 03:41:52 +0000 (09:11 +0530)]
Added Assamese to LINGUAS
Alban Browaeys [Wed, 1 Aug 2012 12:43:21 +0000 (14:43 +0200)]
configure: -Werror= make no sense for "no" and "extra"
gcc error out when -Werror=extra -Werror=no-*
are used. And it is the most sensible thing to do.
https://bugzilla.gnome.org/show_bug.cgi?id=680976
Philip Withnall [Tue, 31 Jul 2012 15:04:06 +0000 (17:04 +0200)]
Post-release version bump
Philip Withnall [Mon, 30 Jul 2012 10:50:08 +0000 (12:50 +0200)]
build: Add a missing file to MAINTAINERCLEANFILES
Philip Withnall [Mon, 30 Jul 2012 09:12:05 +0000 (11:12 +0200)]
build: Remove -Werror from CFLAGS
Replace it with a more targetted set of -Werror=[flag] flags, copied from
libsoup: http://git.gnome.org/browse/libsoup/tree/configure.ac?id=
f5902fce98ae0314f0d9ca6e544895548c94a456#n339
Fran Diéguez [Mon, 30 Jul 2012 00:50:19 +0000 (02:50 +0200)]
Updated Galician translations
Philip Withnall [Sun, 29 Jul 2012 18:06:02 +0000 (20:06 +0200)]
eds: Remove unnecessary valadoc taglet
The [Deprecated] code attribute serves the same purpose.
Philip Withnall [Sun, 29 Jul 2012 18:04:44 +0000 (20:04 +0200)]
docs: Add “wiki” pages to the documentation
These, aptly enough, contain information moved from the wiki on
freedesktop.org about folks concepts, debugging and a glossary.
Philip Withnall [Sun, 29 Jul 2012 15:26:07 +0000 (17:26 +0200)]
Release version 0.7.3
Philip Withnall [Sun, 29 Jul 2012 07:50:38 +0000 (09:50 +0200)]
build: Add a missing file to the tests Makefile
Stas Solovey [Sun, 29 Jul 2012 14:09:24 +0000 (18:09 +0400)]
Updated Russian translation
Christian Kirbach [Sat, 28 Jul 2012 22:16:34 +0000 (00:16 +0200)]
Updated German translation
Sweta Kothari [Fri, 27 Jul 2012 10:00:54 +0000 (15:30 +0530)]
Updated gujarati file & Added LINGUAS file for gujarati
Jeremy Whiting [Tue, 24 Jul 2012 18:46:06 +0000 (12:46 -0600)]
Revert "Change libgee dependency from 0.6 to 0.8."
This reverts commit
5b5360bff7a61ef17173cbe35cc32712ca0fc329.
Jeremy Whiting [Tue, 24 Jul 2012 18:44:25 +0000 (12:44 -0600)]
Revert "Port folks to libgee 0.8."
This reverts commit
e069bbe59dc54eb3595d8ee5c96aea4a36cff9aa.
Philip Withnall [Sat, 21 Jul 2012 00:25:01 +0000 (01:25 +0100)]
Bug 660236 — Paging for long text in folks-inspect
Use $PAGER to allow paging of the output of really long commands in
folks-inspect.
Based on work by Raúl Gutierrez Segales and Jeremy Whiting.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=660236
Jeremy Whiting [Mon, 23 Jul 2012 18:52:18 +0000 (12:52 -0600)]
Remove extra calls to set this._prepare_pending to false.
Jeremy Whiting [Fri, 20 Jul 2012 20:57:56 +0000 (14:57 -0600)]
Removed locks in trf-persona-store that are not needed.
Minor style fixes based on review of previous changes.
Jeremy Whiting [Fri, 20 Jul 2012 16:51:08 +0000 (10:51 -0600)]
Remove additional locks around this._is_prepared.
Travis Reitter [Thu, 7 Jul 2011 01:13:36 +0000 (18:13 -0700)]
Cut unnecessary locking in Tracker backend tests.
Closes: bgo#652637 - Don't hold locks across async calls
Travis Reitter [Thu, 7 Jul 2011 00:54:01 +0000 (17:54 -0700)]
Cut unnecessary Swf.PersonaStore._is_prepared locking.
Helps: bgo#652637 - Don't hold locks across async calls
Travis Reitter [Thu, 7 Jul 2011 00:51:07 +0000 (17:51 -0700)]
Cut unnecessary Kf.PersonaStore._is_prepared locking.
Helps: bgo#652637 - Don't hold locks across async calls
Travis Reitter [Thu, 7 Jul 2011 00:39:40 +0000 (17:39 -0700)]
Cut unnecessary Tpf.PersonaStore._is_prepared locking.
Helps: bgo#652637 - Don't hold locks across async calls
Travis Reitter [Thu, 7 Jul 2011 00:21:56 +0000 (17:21 -0700)]
Cut unnecessary Trf.PersonaStore._is_prepared locking.
Helps: bgo#652637 - Don't hold locks across async calls
Travis Reitter [Thu, 7 Jul 2011 00:58:05 +0000 (17:58 -0700)]
Prevent extra "concurrent" Aggregator prepare() calls from one thread.
Helps: bgo#652637 - Don't hold locks across async calls
Travis Reitter [Wed, 6 Jul 2011 21:48:43 +0000 (14:48 -0700)]
Prevent extra "concurrent" PersonaStore.prepare() calls from one thread.
The lock() calls which were in place only prevent concurrent calls from
different threads; however, the critical section could still be reached
from two async calls in the same thread a la:
backend.prepare.begin ((s,r) => {...});
backend.prepare.begin ((s,r) => {...});
The bodies of the handlers would not literally execute concurrently, but
would be interleaved if each were sufficiently long. Our fix simply
ignores any calls which happen while one is still working.
(yield backend.prepare(); yield backend.prepare(); was already safe, of
course)
Helps: bgo#652637 - Don't hold locks across async calls
Travis Reitter [Wed, 6 Jul 2011 18:09:26 +0000 (11:09 -0700)]
Add test cases for mutexing for async calls from the same thread.
The standard Vala lock() call is a recursive lock, so it only prevents
concurrent access between different threads. But we rarely run in
distinct threads, so this test uses a more-complete solution that we can
depend upon (since the test will fail if its assumptions ever change in
Vala).
Helps: bgo#652637 - Don't hold locks across async calls
Travis Reitter [Tue, 5 Jul 2011 21:36:49 +0000 (14:36 -0700)]
Fix Tracker structure locking for user-initiated Persona adds.
Helps: bgo#652637 - Don't hold locks across async calls
Kjartan Maraas [Mon, 23 Jul 2012 10:27:16 +0000 (12:27 +0200)]
Updated Norwegian bokmål translation
Philip Withnall [Sun, 22 Jul 2012 12:04:59 +0000 (13:04 +0100)]
eds: Make some PersonaStore methods synchronous
There was absolutely no point in them being asynchronous (they didn’t yield
at all, and didn’t run any blocking operations), so were just generating
excess C code and slowing everything down.
This cuts 1200 lines from edsf-persona-store.c.
Philip Withnall [Sun, 22 Jul 2012 08:10:29 +0000 (09:10 +0100)]
eds: Hide the “Starred in Android” group from the set of groups
For Google address books, it’s used to determine whether a contact is a
favourite, so needn’t be shown in the set of groups.
Note that this requires commit
161faab40fa65e813ac98042ef822298dc58cfde
from EDS in order to behave properly.
See: https://bugzilla.gnome.org/show_bug.cgi?id=661490
Ihar Hrachyshka [Thu, 19 Jul 2012 21:07:52 +0000 (00:07 +0300)]
Added Belarusian translation.
Philip Withnall [Thu, 19 Jul 2012 04:04:31 +0000 (05:04 +0100)]
core: Fix documentation on GroupDetails.groups
It was out of date and didn’t match the data type of GroupDetails.groups
any more.
See: https://bugzilla.gnome.org/show_bug.cgi?id=679743
Philip Withnall [Fri, 22 Jun 2012 18:17:42 +0000 (19:17 +0100)]
telepathy: Preserve Tpf.Persona avatars from the cache for online contacts
This is a fairly hacky way of fixing the problem in bug #660128: maintaining
a map of IIDs to avatar files for all personas in the Telepathy backend, and
referring to it in case Telepathy doesn’t know the current avatar for a
TpContact. This can happen if that contact is currently offline while we’re
online, for example. This allows use of the avatars cached from last time
contacts were online, even though those contacts are now offline.
A more comprehensive fix, which I would have implemented if I hadn’t just got
my degree classification and weren’t just heading out to celebrate, would
involve rearchitecting the caching of the Telepathy backend so that the
Tpf.Personas weren’t destroyed and re-created whenever the backend went
offline/online; instead, they would have their properties updated from the
cache/online contact list. This would eliminate spurious personas-changed
signals, unify the code implementing the different properties (currently it’s
split between the properties and separate implementations in
Tpf.Persona.from_cache()), and allow property values to persist from offline
to online without the need for hacks like this.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=660128
Philip Withnall [Fri, 22 Jun 2012 18:09:57 +0000 (19:09 +0100)]
telepathy: Allow for updated Tpf.Personas properties to update the cache
Currently, the cache is only written when going offline, which means that any
properties of Tpf.Personas which are updated at runtime aren’t written to the
cache unless the client explicitly goes offline before being closed. This
doesn’t often happen, meaning the property updates are lost and the cache
becomes stale.
This commit keeps track of the clean/dirty state of the cache and writes it
out when PersonaStore.flush() is called. It also adds a new method,
IndividualAggregator.unprepare(), which ensures all the persona stores handled
by the aggregator are flushed. Clients should call this method before closing
their main loop.
(Calling flush() in the finalise function of the PersonaStore doesn’t work
because Tpf.PersonaStores are often never finalised due to the implementation
of Tpf.PersonaStore.dup_for_account(). Furthermore, calling flush() in the
finalise function of the IndividualAggregator doesn’t work because the client
will typically quit the main loop immediately afterwards, which will cancel
the asynchronous flush call.)
New API:
• IndividualAggregator.unprepare()
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=660128
Philip Withnall [Fri, 22 Jun 2012 18:03:55 +0000 (19:03 +0100)]
core: Don’t keep references to PersonaStores in each Individual
Pointless and it makes debugging reference counting bugs a real pain.
Jeremy Whiting [Wed, 18 Jul 2012 18:44:06 +0000 (12:44 -0600)]
telepathy: Change warning about CM not implementing contact list to debug message.
fixes: 675223
Мирослав Николић [Tue, 17 Jul 2012 20:03:17 +0000 (22:03 +0200)]
Updated Serbian translation
Мирослав Николић [Tue, 17 Jul 2012 20:00:50 +0000 (22:00 +0200)]
Added Serbian translation
Jeremy Whiting [Mon, 16 Jul 2012 22:30:14 +0000 (16:30 -0600)]
Update NEWS file adding recently fixed bug.
Jeremy Whiting [Mon, 16 Jul 2012 22:10:33 +0000 (16:10 -0600)]
eds: Trust google address books FULL since authorization is required to load.
Jeremy Whiting [Mon, 16 Jul 2012 22:09:55 +0000 (16:09 -0600)]
folks: Don't downgrade persona store trust level.
Jeremy Whiting [Mon, 16 Jul 2012 21:37:49 +0000 (15:37 -0600)]
tracker: Fix tracker unit tests to wait until persona store is prepared.
Jeremy Whiting [Mon, 16 Jul 2012 21:30:16 +0000 (15:30 -0600)]
tracker: Throw an error if personas are added before store is prepared.
Jeremy Whiting [Mon, 16 Jul 2012 16:19:10 +0000 (10:19 -0600)]
tests: Add execute-test.sh to do test output capturing.
tests: Call execute-test.sh from each of with-session-bus scripts.
Jeremy Whiting [Mon, 16 Jul 2012 16:16:39 +0000 (10:16 -0600)]
Send eds server debug output into /dev/null along with regular output.
Extend sleep time to 2 seconds.
Daniel Mustieles [Mon, 16 Jul 2012 14:42:24 +0000 (16:42 +0200)]
Updated Spanish translation
Aurimas Černius [Sat, 14 Jul 2012 11:59:28 +0000 (14:59 +0300)]
Added Lithuanian translation
Chao-Hsiung Liao [Sat, 14 Jul 2012 05:40:54 +0000 (13:40 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Philip Withnall [Fri, 13 Jul 2012 22:17:33 +0000 (23:17 +0100)]
telepathy: Tidy up group change notification handling in Tpf.Persona
Philip Withnall [Sun, 24 Jun 2012 10:50:06 +0000 (11:50 +0100)]
eds: Add an Edsf.Persona.in_google_personal_group property
This is set whenever the persona is in the “My Contacts” group in Google
Contacts, which is normally exposed by EDS as being in the “Personal”
category. This system group can’t be reliably detected normally as “Personal”
is translated by EDS. This caused problems for gnome-contacts, hence the
new API.
The new API requires EDS 3.5.3 at runtime, and will always be false
otherwise.
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=676383
Jeremy Whiting [Tue, 10 Jul 2012 20:48:59 +0000 (14:48 -0600)]
Remove gconf soft dependency used for eds unit tests.
Fixes: bgo 674611
Jeremy Whiting [Fri, 13 Jul 2012 21:11:27 +0000 (15:11 -0600)]
Add a sleep for one second after starting the eds servers.
Fixes inconsistent eds unit test failures. All tests pass here now.
Jeremy Whiting [Fri, 13 Jul 2012 16:59:39 +0000 (10:59 -0600)]
telepathy: Set _prepare_pending to true at beginning of prepare.
Fixes folks init unit test failure.
Jeremy Whiting [Thu, 12 Jul 2012 20:22:41 +0000 (14:22 -0600)]
Merge branch 'cleantestoutput'
Reviewed-by: Philip Withnal
Closes: bgo 657456 https://bugzilla.gnome.org/show_bug.cgi?id=657456
Philip Withnall [Mon, 9 Jul 2012 20:18:41 +0000 (21:18 +0100)]
Bug 679618 — Crash when unsetting all groups
Rework the group changing code in Tpf.Persona so that:
1. change_groups() no longer changes the set of groups while iterating
over it; and
2. batch Telepathy calls are made where possible, rather than one call per
group change.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=679618
Jeremy Whiting [Tue, 10 Jul 2012 20:22:29 +0000 (14:22 -0600)]
Make test output use color for PASS/FAIL.
Don't show test output unless CHECK_VERBOSE is set.
Fixes: bgo 657456
Kjartan Maraas [Mon, 9 Jul 2012 12:33:34 +0000 (14:33 +0200)]
Updated Norwegian bokmål translation
Bruno Brouard [Sun, 8 Jul 2012 09:28:19 +0000 (11:28 +0200)]
New French translation
Piotr Drąg [Sat, 7 Jul 2012 20:58:13 +0000 (22:58 +0200)]
Updated POTFILES.in and POTFILES.skip
Philip Withnall [Sun, 6 May 2012 21:59:45 +0000 (22:59 +0100)]
key-file: Add anti-linking support
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=629537
Philip Withnall [Sun, 6 May 2012 21:59:34 +0000 (22:59 +0100)]
eds: Add anti-linking support
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=629537
Philip Withnall [Mon, 25 Jul 2011 19:27:29 +0000 (20:27 +0100)]
core: Add core anti-linking support
This adds the core of the anti-linking support, based around a new
AntiLinkable interface. This will be implemented by Persona subclasses which
can store anti-linking information (in the form of a set of Persona UIDs
which the given Persona should never be linked to).
This approach allows anti-linking information to be stored with the personas
(presumably in the primary persona store) and thus it should be network
transparent. i.e. Using folks on two different computers with a Google
Contacts address book as primary should cause the anti-linking data to be
shared.
This also includes the necessary IndividualAggregator changes.
Sadly, no unit tests are included.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=629537
Philip Withnall [Mon, 7 May 2012 23:01:42 +0000 (00:01 +0100)]
core: Replace the linking step in IA.ensure_individual_property_writeable()
It’s a waste of time to create a new Persona to ensure the property is
writeable, then create _another_ new Persona to link it to the Individual.
Why not just create the writeable Persona so that it’s automatically linked
to the Individual?
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=629537
Philip Withnall [Mon, 7 May 2012 22:59:56 +0000 (23:59 +0100)]
core: Split details table code out of IA.link_personas()
Helps: https://bugzilla.gnome.org/show_bug.cgi?id=629537