cdalton [Fri, 12 Jun 2015 15:21:26 +0000 (08:21 -0700)]
Move blend enums into GrBlend.h
Moves blend enums from GrXferProcessor.h to GrBlend.h, makes GrBlend.h
public.
BUG=skia:
Review URL: https://codereview.chromium.org/
1180713008
caryclark [Fri, 12 Jun 2015 15:18:45 +0000 (08:18 -0700)]
fix portable text in test
TBR=djsollen@google.com
Review URL: https://codereview.chromium.org/
1179173003
borenet [Fri, 12 Jun 2015 14:22:26 +0000 (07:22 -0700)]
SkiaLab doc: add another step for new Android devices
BUG=skia:3718
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1185663003
Review URL: https://codereview.chromium.org/
1185663003
reed [Fri, 12 Jun 2015 14:09:59 +0000 (07:09 -0700)]
change Resize to take pixmap for src
BUG=skia:
Review URL: https://codereview.chromium.org/
1174293005
reed [Fri, 12 Jun 2015 12:49:01 +0000 (05:49 -0700)]
remove unused private Resizer
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1177173003
caryclark [Fri, 12 Jun 2015 12:42:58 +0000 (05:42 -0700)]
next batch of portable typeface changes
TBR=djsollen@google.com
Review URL: https://codereview.chromium.org/
1177303005
msarett [Thu, 11 Jun 2015 21:27:27 +0000 (14:27 -0700)]
DM testing for skipping and scaling
BUG=skia:
Review URL: https://codereview.chromium.org/
1175993005
reed [Thu, 11 Jun 2015 21:22:19 +0000 (14:22 -0700)]
fix deserialization after FirstDirection change to paths
BUG=skia:
Review URL: https://codereview.chromium.org/
1185453003
bungeman [Thu, 11 Jun 2015 20:19:23 +0000 (13:19 -0700)]
Update README.chromium.
Capitalize Skia and use new site url.
Review URL: https://codereview.chromium.org/
1183503002
senorblanco [Thu, 11 Jun 2015 18:51:29 +0000 (11:51 -0700)]
Fix for dashing shader on Mali: use highp where necessary.
The varyings used to compute rect coverage need to be high precision,
since they're offset by the frag coord.
R=egdaniel
BUG=skia:3935
Review URL: https://codereview.chromium.org/
1178123004
msarett [Thu, 11 Jun 2015 17:13:03 +0000 (10:13 -0700)]
Eliminate the check for ANDROID_LARGE_MEMORY in jpeg decoders
BUG=skia:1282
Review URL: https://codereview.chromium.org/
1103313002
caryclark [Thu, 11 Jun 2015 17:09:06 +0000 (10:09 -0700)]
remove duplicate assign of fLastGlyphID
Hal found a brain-dead bug on my part. Thanks Hal!
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
1176423003
caryclark [Thu, 11 Jun 2015 16:40:44 +0000 (09:40 -0700)]
PDF expects fonts to map glyph ID 0 to the missing character.
Add a mapping of glyph ID 0 to the toy font to allow for this.
TBR=bungeman@google.com
Review URL: https://codereview.chromium.org/
1175243004
reed [Thu, 11 Jun 2015 15:03:32 +0000 (08:03 -0700)]
retro add copyright
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/
1183463002
caryclark [Thu, 11 Jun 2015 13:46:21 +0000 (06:46 -0700)]
initialize font metrics for pdf (found by valgrind)
TBR=halcanary@google.com
Review URL: https://codereview.chromium.org/
1175253004
cdalton [Thu, 11 Jun 2015 02:23:46 +0000 (19:23 -0700)]
Init GrGLSLCaps fields from inside GrGLCaps
Fixes circular dependencies by allowing the initialization to be done
intertwined.
BUG=skia:
Review URL: https://codereview.chromium.org/
1177053002
reed [Wed, 10 Jun 2015 21:23:15 +0000 (14:23 -0700)]
SkPath::Direction serves two masters:
- input param to addFoo (e.g. addRect), where only CW or CCW are valid)
- output param from computing functions, that sometimes return kUnknown
This CL's intent is to split these into distinct enums/features:
- Direction (public) loses kUnknown, and is only used for input
- FirstDirection (private) is used for computing the first direction we see when analyzing a contour
BUG=skia:
Review URL: https://codereview.chromium.org/
1176953002
Derek Sollenberger [Wed, 10 Jun 2015 19:58:48 +0000 (15:58 -0400)]
fix broken build by not passing the verbose flag through
Review URL: https://codereview.chromium.org/
1176543004
djsollen [Wed, 10 Jun 2015 19:37:56 +0000 (12:37 -0700)]
Remove verbose bash logging
Review URL: https://codereview.chromium.org/
1170283004
ethannicholas [Wed, 10 Jun 2015 19:11:17 +0000 (12:11 -0700)]
Added GrAAFlatteningConvexPathRenderer.
This is an alternate version of GrAAConvexPathRenderer which handles
curves by first flattening them to straight lines.
BUG=skia:
Review URL: https://codereview.chromium.org/
1158803002
fmalita [Wed, 10 Jun 2015 17:46:50 +0000 (10:46 -0700)]
Label some unused static vars as SK_UNUSED
Makes my gcc 5.1.1 much happier.
R=mtklein@google.com,scroggo@google.com
[ mtklein mischief below here ]
No public API changes.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1170863006
caryclark [Wed, 10 Jun 2015 17:34:08 +0000 (10:34 -0700)]
turn on antialiased text
Aliased text didn't work with msaa16, so make it all
antialiased.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1169173006
caryclark [Wed, 10 Jun 2015 16:31:09 +0000 (09:31 -0700)]
Today's gm include many differences caused by platform font implementations.
This experiment replaces the label used in the aaxfermodes gm with
aliased text generated from paths common to all platforms.
Since there is no way today to generate all dm output from trybots,
this will be checked in to confirm that this strategy provides simpler
output across devices.
This does not introduce a new public interface; instead, dm uses
a extern backdoor to install the SkTypeface::CreateFromName
handler.
Review URL: https://codereview.chromium.org/
1163283002
djsollen [Wed, 10 Jun 2015 16:05:14 +0000 (09:05 -0700)]
Update flags passed to Android GPU bots to exclude running skps and image sources.
Review URL: https://codereview.chromium.org/
1176923003
mtklein [Wed, 10 Jun 2015 15:57:28 +0000 (08:57 -0700)]
Remove overly-promiscuous SkNx syntax sugar.
I haven't figured out a pithy way to have these apply to only classes
originating from SkNx, so let's just remove them. There aren't too
many use cases, and it's not really any less readable without them.
Semantically, this is a no-op.
BUG=skia:
Review URL: https://codereview.chromium.org/
1167153002
bsalomon [Wed, 10 Jun 2015 15:49:28 +0000 (08:49 -0700)]
Towards removing getTexture() on SkImage
Review URL: https://codereview.chromium.org/
1166993002
mtklein [Tue, 9 Jun 2015 22:06:22 +0000 (15:06 -0700)]
Use SkMScalar as float by default to match Chromium.
Tweak some test values to pass with floats.
As expected, this regresses matrix44_setconcat_general by about 2x.
BUG=skia:
Review URL: https://codereview.chromium.org/
1169813006
msarett [Tue, 9 Jun 2015 20:56:10 +0000 (13:56 -0700)]
Subset decoding benchmarks
It was my goal to create benchmarks that could measure all
of the use cases that we have identified. I think single
subsets, translating, and scaling are the important ones.
It might be a good idea to discuss the document in greater
detail as well. I just wanted to share this to aid the
discussion.
https://docs.google.com/a/google.com/document/d/1OxW96GDMAlw6dnzNXmiNX-F9oDBBlGXzSsgd0DMIkbI/edit?usp=sharing
BUG=skia:
Review URL: https://codereview.chromium.org/
1160953002
reed [Tue, 9 Jun 2015 20:13:16 +0000 (13:13 -0700)]
add copyright
BUG=skia:
NOTRY=True
TBR=
Review URL: https://codereview.chromium.org/
1170343002
joshualitt [Tue, 9 Jun 2015 19:33:13 +0000 (12:33 -0700)]
Add android native_app_glue to platform_tools/android/third_party
BUG=skia:
Review URL: https://codereview.chromium.org/
1175673002
reed [Tue, 9 Jun 2015 19:16:53 +0000 (12:16 -0700)]
Revert[2] SkDraw and all Blitters to use pixmap instead of bitmapi
This reverts commit
b3f0ec9f9967da2f80f0d842cb7fd53617b48de3.
BUG=skia:
Review URL: https://codereview.chromium.org/
1168303006
mtklein [Tue, 9 Jun 2015 18:47:01 +0000 (11:47 -0700)]
A bunch of little SkMScalar-as-float build fixes.
Landing this before http://crrev.com/
1169813006 so the test changes needed
there are clearer. This just lets things build with floats, and is a no-op for
doubles.
No public API changes we didn't intend to already have...
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1173673003
smcgruer [Tue, 9 Jun 2015 17:18:50 +0000 (10:18 -0700)]
Fix build for UCLIBC platforms (newlocale/freelocale)
UCLIBC does not have locale support by default.
BUG=skia:
Review URL: https://codereview.chromium.org/
1162953003
mtklein [Tue, 9 Jun 2015 16:29:12 +0000 (09:29 -0700)]
Pump up matrix44_setconcat benches 1000x so they can be timed on Android.
BUG=skia:
Review URL: https://codereview.chromium.org/
1174583002
bungeman [Tue, 9 Jun 2015 15:40:51 +0000 (08:40 -0700)]
Fill capHeight and maxCharWidth on Mac.
BUG=skia:3924
Review URL: https://codereview.chromium.org/
1164423006
reed [Tue, 9 Jun 2015 15:18:39 +0000 (08:18 -0700)]
remove subclassing from ImageFilter::Proxy
BUG=skia:
Review URL: https://codereview.chromium.org/
1172693002
reed [Tue, 9 Jun 2015 13:38:49 +0000 (06:38 -0700)]
remove Proxy entrypoints for canHandleFilter
BUG=skia:
Review URL: https://codereview.chromium.org/
1169923002
mtklein [Tue, 9 Jun 2015 11:44:07 +0000 (04:44 -0700)]
Split SetConcatMatrix44Bench to cover both internal paths.
The existing bench only tests the fast path, but we're looking to speed
up the general case. It'd be nice to be able to measure that speedup.
BUG=skia:
Review URL: https://codereview.chromium.org/
1146953003
reed [Tue, 9 Jun 2015 02:58:07 +0000 (19:58 -0700)]
Revert of change SkDraw and all Blitters to use pixmap instead of bitmap (patchset #6 id:100001 of https://codereview.chromium.org/
1148793007/)
Reason for revert:
speculative revert to try to unblock DEPS roll
Original issue's description:
> change SkDraw and all Blitters to use pixmap instead of bitmap
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
c31af44336f5eb4a50e83e76e51962d46c3ed458
TBR=scroggo@google.com,jvanverth@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1164373003
cdalton [Mon, 8 Jun 2015 22:11:04 +0000 (15:11 -0700)]
Add mixed samples support to XPs
BUG=skia:
Review URL: https://codereview.chromium.org/
1164973002
bungeman [Mon, 8 Jun 2015 21:47:06 +0000 (17:47 -0400)]
Restore support for 10.6 SDK in header.
Must use ApplicationServices, can't use CoreText directly.
bungeman [Mon, 8 Jun 2015 21:32:24 +0000 (14:32 -0700)]
Remove attempted bug mitigation in Mac typeface.
An attempt was made to hold onto the 'sbix' table when it existed
when drawing to mitigate an issue with vanishing font data. This
code has not affected the crash rate, so remove it.
Review URL: https://codereview.chromium.org/
1168793003
cdalton [Mon, 8 Jun 2015 20:43:33 +0000 (13:43 -0700)]
Fix regression in GrXferProcessor
Fix segfault introduced in https://codereview.chromium.org/
1170553002/
BUG=skia:
Review URL: https://codereview.chromium.org/
1167243002
bungeman [Mon, 8 Jun 2015 20:39:12 +0000 (13:39 -0700)]
Provide tag-along for SkCreateTypefaceFromCTFont.
This provides a means of keeping an object alive for the entire
lifetime of an SkTypeface.
Review URL: https://codereview.chromium.org/
1163573007
halcanary [Mon, 8 Jun 2015 19:14:56 +0000 (12:14 -0700)]
SkPDF: fix name escape code
BUG=494913
Review URL: https://codereview.chromium.org/
1152283014
cdalton [Mon, 8 Jun 2015 19:14:44 +0000 (12:14 -0700)]
Apply coverage in XP base class when using dst reads
Moves the coverage logic into GrGLXferProcessor for XPs that perform
dst reads. XPs that don't use a dst read are still responsible to
handle coverage on their own.
BUG=skia:
Review URL: https://codereview.chromium.org/
1170553002
reed [Mon, 8 Jun 2015 17:47:12 +0000 (10:47 -0700)]
change SkDraw and all Blitters to use pixmap instead of bitmap
BUG=skia:
Review URL: https://codereview.chromium.org/
1148793007
rmistry [Mon, 8 Jun 2015 17:22:34 +0000 (10:22 -0700)]
Add benjaminwagner@ to CQ_COMMITTERS.
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/
1164933007
reed [Mon, 8 Jun 2015 17:22:22 +0000 (10:22 -0700)]
Revert "Revert of move erase into SkPixmap (patchset #1 id:1 of https://codereview.chromium.org/
1161033005/)"
This reverts commit
cca9b3ac908cf3e9a0c5774a5ffd118d8429e08a.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1153473012
djsollen [Mon, 8 Jun 2015 17:03:49 +0000 (10:03 -0700)]
Revert of move erase into SkPixmap (patchset #1 id:1 of https://codereview.chromium.org/
1161033005/)
Reason for revert:
broken builds
Original issue's description:
> move erase into SkPixmap
>
> harvested from https://codereview.chromium.org/
1148793007
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/
0963f5dab079627c5523ce6a443af27a33e361f7
TBR=reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1157303008
reed [Mon, 8 Jun 2015 16:16:53 +0000 (09:16 -0700)]
move erase into SkPixmap
harvested from https://codereview.chromium.org/
1148793007
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1161033005
robertphillips [Mon, 8 Jun 2015 14:10:49 +0000 (07:10 -0700)]
Cap color index values
In the provided example the color table has 10 entries but some of the pixels in the bitmap overflow. This CL goes through the pixel values and caps them to the max index.
An alternate approach would be to just have the color table always have 256 entries but zero out the unused ones.
BUG=492265
Review URL: https://codereview.chromium.org/
1165493003
robertphillips [Mon, 8 Jun 2015 13:21:14 +0000 (06:21 -0700)]
Add bigtileimagefilter GM & improvements to toString
This is all the ancillary code from https://codereview.chromium.org/
1152553006/ (Fix dst bound reported by SkTileImageFilter).
TBR=reed@google.com, senorblanco@google.com
Review URL: https://codereview.chromium.org/
1169713003
sergiyb [Mon, 8 Jun 2015 12:12:56 +0000 (05:12 -0700)]
Added CQ config to skia repo
This must land in sync with https://chromereviews.googleplex.com/
204307013 and
revert in sync.
R=rmistry@chromium.org, tandrii@chromium.org
NOTRY=true
NOTREECHECKS=true
BUG=chromium:471767
Review URL: https://codereview.chromium.org/
1153093004
skia.buildbots [Sun, 7 Jun 2015 07:20:33 +0000 (00:20 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/
1167563004
reed [Fri, 5 Jun 2015 21:33:17 +0000 (14:33 -0700)]
add extractSubset and SkAutoPixmapStorage
extracted from larger CL in progress: https://codereview.chromium.org/
1148793007
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1162013008
reed [Fri, 5 Jun 2015 21:11:32 +0000 (14:11 -0700)]
clarify that accessPixels is for write-access, and peekPixels is RO
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1162203005
bungeman [Fri, 5 Jun 2015 20:38:12 +0000 (13:38 -0700)]
Add cmap 3,0 (symbol) as Unicode fallback.
FreeType automatically selects the 'most Unicode' cmap available,
otherwise the default cmap is NULL. When this happens the fallback
should include the 3,0 symbol cmap, as is outlined in the Apple
TrueType documentation. This cmap should effectively be a Unicode
mapping, but exclusively in the private use area.
BUG=skia:1873,chromium:489452
Review URL: https://codereview.chromium.org/
1163833003
cdalton [Fri, 5 Jun 2015 20:26:20 +0000 (13:26 -0700)]
Opt for advanced blend at creation time in CrCustomXfermode
Modifies GrCustomXfermode to decide at creation time whether it will
use advanced blend, instead of deciding during getOptimizations.
BUG=skia:
Review URL: https://codereview.chromium.org/
1161913003
reed [Fri, 5 Jun 2015 18:31:26 +0000 (11:31 -0700)]
delete (unused) TransparentShader
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1153193014
djsollen [Fri, 5 Jun 2015 16:41:18 +0000 (09:41 -0700)]
Add ColorMatrix filter tests from Android CTS.
BUG=skia:3848
Review URL: https://codereview.chromium.org/
1134753008
djsollen [Fri, 5 Jun 2015 16:39:30 +0000 (09:39 -0700)]
Update how we package skia resource for android testing
Review URL: https://codereview.chromium.org/
1119283004
reed [Fri, 5 Jun 2015 13:58:22 +0000 (06:58 -0700)]
use pixmaps for dst in sprites -- NO BITMAPS
BUG=skia:
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
1143173011
bsalomon [Thu, 4 Jun 2015 22:34:34 +0000 (15:34 -0700)]
Remove memcmp from GrProgramDesc op== and Less
Works around an ASAN complaint.
BUG=skia:3891
Review URL: https://codereview.chromium.org/
1154773007
borenet [Thu, 4 Jun 2015 22:15:42 +0000 (15:15 -0700)]
Presubmit: add PRESUBMIT=false to non-master branch changes
BUG=skia:
Review URL: https://codereview.chromium.org/
1161973005
bsalomon [Thu, 4 Jun 2015 22:10:45 +0000 (15:10 -0700)]
Stop running tiles_rt-gpu on the bots
BUG=skia:
Review URL: https://codereview.chromium.org/
1152003009
jschuh [Thu, 4 Jun 2015 22:10:37 +0000 (15:10 -0700)]
Remove unused PackBits methods and fix length checks
Also a bit of general cleanup.
BUG=chromium:486944
Review URL: https://codereview.chromium.org/
1152163004
bsalomon [Thu, 4 Jun 2015 21:15:33 +0000 (14:15 -0700)]
Add prelog flag to DM
Review URL: https://codereview.chromium.org/
1158263004
reed [Thu, 4 Jun 2015 21:12:25 +0000 (14:12 -0700)]
switch bitmapshader internals over to pixmap
BUG=skia:
NOTRY=True
Review URL: https://codereview.chromium.org/
1158273007
borenet [Thu, 4 Jun 2015 20:57:10 +0000 (13:57 -0700)]
Add documentation for SkiaLab
BUG=skia:3850
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1154623006
Review URL: https://codereview.chromium.org/
1154623006
bsalomon [Thu, 4 Jun 2015 20:57:00 +0000 (13:57 -0700)]
Disable unused attributes when using copy shader
BUG=chromium:496540
Review URL: https://codereview.chromium.org/
1157943007
robertphillips [Thu, 4 Jun 2015 18:15:27 +0000 (11:15 -0700)]
Revert of Fix dst bound reported by SkTileImageFilter (patchset #3 id:40001 of https://codereview.chromium.org/
1152553006/)
Reason for revert:
Blink
Original issue's description:
> Fix dst bound reported by SkTileImageFilter
>
> In the example from the bug we had the filter DAG:
>
> color filter (table)
> 0: xfermode filter (arith)
> 0: tile filter [0,80,34,114] -> [0,80,800,480]
> 0: color filter (table)
> 0: bitmap src 34x34 -> [0,80,34,114]
> 1: color filter (table)
> 0: picture filter [0, 80, 800, 480]
>
> computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.
>
> This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.
>
> BUG=493783
>
> Committed: https://skia.googlesource.com/skia/+/
05be93bbdf09576f7903130e3b106b0a8c7c4b4e
>
> Committed: https://skia.googlesource.com/skia/+/
0be685755f942baea26c66a87226b569fc17e960
TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493783
Review URL: https://codereview.chromium.org/
1156583004
caryclark [Thu, 4 Jun 2015 16:27:43 +0000 (09:27 -0700)]
make test hittestpath random calls deterministic
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
1157943006
joshualitt [Thu, 4 Jun 2015 16:13:46 +0000 (09:13 -0700)]
Trivial change to bump minimum block size for Buffer pool
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
1146073004
bsalomon [Thu, 4 Jun 2015 15:49:34 +0000 (08:49 -0700)]
Disable dual source blending support when GLSL version is too old
BUG=skia:3891
Review URL: https://codereview.chromium.org/
1160923007
fmalita [Thu, 4 Jun 2015 14:52:41 +0000 (07:52 -0700)]
Fallback bitmap devices should observe the computed pixel geometry
When onCreateDevice() fails, internalSaveLayer() attempts to create a
fallback bitmap device instead - but it ignores the computed pixel geometry
in this case.
BUG=496054
R=reed@google.com
Review URL: https://codereview.chromium.org/
1144153007
bungeman [Thu, 4 Jun 2015 14:38:52 +0000 (07:38 -0700)]
Remove SK_ANDROID_FREETYPE_HAS_MM from build.
This flag is now no longer used now that GX variations now seem
to have landed for good.
Review URL: https://codereview.chromium.org/
1155303007
halcanary [Thu, 4 Jun 2015 14:26:54 +0000 (07:26 -0700)]
Add GM that tests clipping annotations
TBR=reed@google.com
BUG=skia:3880
Review URL: https://codereview.chromium.org/
1159273003
robertphillips [Thu, 4 Jun 2015 13:53:37 +0000 (06:53 -0700)]
Fix dst bound reported by SkTileImageFilter
In the example from the bug we had the filter DAG:
color filter (table)
0: xfermode filter (arith)
0: tile filter [0,80,34,114] -> [0,80,800,480]
0: color filter (table)
0: bitmap src 34x34 -> [0,80,34,114]
1: color filter (table)
0: picture filter [0, 80, 800, 480]
computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.
This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.
BUG=493783
Committed: https://skia.googlesource.com/skia/+/
05be93bbdf09576f7903130e3b106b0a8c7c4b4e
Review URL: https://codereview.chromium.org/
1152553006
joel.liang [Thu, 4 Jun 2015 13:52:29 +0000 (06:52 -0700)]
Fix edge-line artifacts issue on Mali
Some GMs show edge-line artifacts on Mali at the bottom/right of the canvas.
Change the 'rtAdjustment' uniform precision from 'midiump' to 'highp' if the GPU vendor is ARM.
NOTE: Vertex Shader should have default 'highp' precision, but now we explicit declared some uniform/attribute precision as 'midiump'.
This patch should fix these issues:
Issue 3693: Some GMs produce random artifacts on Mali in MSAA4
https://code.google.com/p/skia/issues/detail?id=3693
Issue 3685: srcmode GM has top/right line artifacts on Mali T604 in MSAA4
https://code.google.com/p/skia/issues/detail?id=3685
BUG=skia:
Review URL: https://codereview.chromium.org/
1154163012
reed [Thu, 4 Jun 2015 13:31:31 +0000 (06:31 -0700)]
refactor bitmapshader to use a controller
BUG=skia:
Review URL: https://codereview.chromium.org/
1153123003
reed [Thu, 4 Jun 2015 13:27:44 +0000 (06:27 -0700)]
remove stray printf
BUG=skia:
TBR=junov@google.com
Review URL: https://codereview.chromium.org/
1149083008
bungeman [Wed, 3 Jun 2015 19:58:40 +0000 (12:58 -0700)]
Remove SK_FREETYPE_HAS_MM.
The SK_FREETYPE_HAS_MM define was added to delay the changes to
support GX variation fonts on platforms which did not compile ftmm.c
into their FreeType build. Now that all builds should have this file
the define can be removed.
Committed: https://skia.googlesource.com/skia/+/
4f61fee53af956a8beb4c56fa6479cb6b1aa5159
Review URL: https://codereview.chromium.org/
1143133006
joshualitt [Tue, 2 Jun 2015 20:48:38 +0000 (13:48 -0700)]
Reenable reordering
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
1160063003
cdalton [Tue, 2 Jun 2015 20:05:52 +0000 (13:05 -0700)]
Begin tracking driver info in GrGLContextInfo
BUG=skia:
Review URL: https://codereview.chromium.org/
1165463005
borenet [Tue, 2 Jun 2015 19:38:16 +0000 (12:38 -0700)]
Add adb_wait_for_device script
BUG=skia:3718
Review URL: https://codereview.chromium.org/
1149163003
junov [Tue, 2 Jun 2015 18:47:45 +0000 (11:47 -0700)]
Fixing leaky handling of SkImage in SkDeferredCanvas.
Long lived SkImageHeap objects currently accumulate refs indefinitely.
This leads to massive memory leaks in the gpu-accelerated 2D canvas
code path. This CL does not implement a general fix for SkGPipe, but
it resolves the leak in SkDeferredCanvas (currently the only user
of SkGPipe) by resetting the image heap when the deferral queue is
flushed. This change also fixes the accounting of bytes allocated
by referenced images in order to trigger flushing heuristics
appropriately.
BUG=crbug.com/494148
Review URL: https://codereview.chromium.org/
1145893007
robertphillips [Tue, 2 Jun 2015 17:57:26 +0000 (10:57 -0700)]
Revert of Fix dst bound reported by SkTileImageFilter (patchset #3 id:40001 of https://codereview.chromium.org/
1152553006/)
Reason for revert:
breaking tests
Original issue's description:
> Fix dst bound reported by SkTileImageFilter
>
> In the example from the bug we had the filter DAG:
>
> color filter (table)
> 0: xfermode filter (arith)
> 0: tile filter [0,80,34,114] -> [0,80,800,480]
> 0: color filter (table)
> 0: bitmap src 34x34 -> [0,80,34,114]
> 1: color filter (table)
> 0: picture filter [0, 80, 800, 480]
>
> computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.
>
> This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.
>
> BUG=493783
>
> Committed: https://skia.googlesource.com/skia/+/
05be93bbdf09576f7903130e3b106b0a8c7c4b4e
TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493783
Review URL: https://codereview.chromium.org/
1143083006
robertphillips [Tue, 2 Jun 2015 17:52:43 +0000 (10:52 -0700)]
Fix dst bound reported by SkTileImageFilter
In the example from the bug we had the filter DAG:
color filter (table)
0: xfermode filter (arith)
0: tile filter [0,80,34,114] -> [0,80,800,480]
0: color filter (table)
0: bitmap src 34x34 -> [0,80,34,114]
1: color filter (table)
0: picture filter [0, 80, 800, 480]
computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn.
This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit.
BUG=493783
Review URL: https://codereview.chromium.org/
1152553006
reed [Tue, 2 Jun 2015 17:47:42 +0000 (10:47 -0700)]
check (runtime) for null-pixels even when lock succeeds
BUG=492818
TBR=
Review URL: https://codereview.chromium.org/
1159953006
cdalton [Tue, 2 Jun 2015 17:43:39 +0000 (10:43 -0700)]
Update XPF invariant info to not account for conflation
Renames getInvariantOutput to getInvariantBlendedColor on GrXPFactory
and redefines it to not account for coverage conflation. This is the
information that all the callsites actually wanted to know.
BUG=skia:
Review URL: https://codereview.chromium.org/
1161273005
joshualitt [Tue, 2 Jun 2015 17:35:04 +0000 (10:35 -0700)]
whitespace change to trigger android bots
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
1160853005
joshualitt [Tue, 2 Jun 2015 17:10:28 +0000 (10:10 -0700)]
whitespace change to trigger android bots
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
1164813002
joshualitt [Tue, 2 Jun 2015 16:10:31 +0000 (09:10 -0700)]
disable reordering until android bots clear up
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
1167693006
joshualitt [Tue, 2 Jun 2015 15:12:08 +0000 (08:12 -0700)]
whitespace change to get android bots to cycle
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
1155293008
joshualitt [Tue, 2 Jun 2015 14:26:43 +0000 (07:26 -0700)]
fix dm crash
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1149243006
joshualitt [Tue, 2 Jun 2015 14:09:31 +0000 (07:09 -0700)]
re-enable reordering
BUG=skia:
Review URL: https://codereview.chromium.org/
1164763002
reed [Tue, 2 Jun 2015 01:40:52 +0000 (18:40 -0700)]
Revert of Remove SK_FREETYPE_HAS_MM. (patchset #1 id:1 of https://codereview.chromium.org/
1143133006/)
Reason for revert:
seems to be breaking DEPS roll
FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -fuse-ld=gold -Wl,--no-undefined -Wl,--exclude-libs=libgcc.a -Wl,--exclude-libs=libc++_static.a -Wl,--exclude-libs=libvpx_assembly_arm.a -Wl,--icf=safe -Wl,--warn-shared-textrel -nostdlib --sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-14/arch-arm -Wl,--warn-shared-textrel -Wl,-O1 -Wl,--gc-sections -Wl,--as-needed -Wl,--version-script=/b/build/slave/android_chromium_gn/build/src/build/android/android_no_jni_exports.lst -L../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libs/armeabi-v7a -o ./libskia.so -Wl,-soname=libskia.so @./libskia.so.rsp && { /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-readelf -d ./libskia.so | grep SONAME ; /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-nm -gD -f p ./libskia.so | cut -f1-2 -d' '; } > ./libskia.so.tmp && if ! cmp -s ./libskia.so.tmp ./libskia.so.TOC; then mv ./libskia.so.tmp ./libskia.so.TOC; fi && mkdir -p lib.stripped && ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-strip --strip-unneeded -o lib.stripped/libskia.so.tmp libskia.so && if ! cmp -s lib.stripped/libskia.so.tmp lib.stripped/libskia.so; then mv lib.stripped/libskia.so.tmp lib.stripped/libskia.so; fi
../../third_party/skia/src/ports/SkFontHost_FreeType.cpp:283: error: undefined reference to 'FT_Get_MM_Var'
../../third_party/skia/src/ports/SkFontHost_FreeType.cpp:302: error: undefined reference to 'FT_Set_Var_Design_Coordinates'
../../third_party/skia/src/ports/SkFontHost_FreeType.cpp:1766: error: undefined reference to 'FT_Get_MM_Var'
collect2: error: ld returned 1 exit status
Original issue's description:
> Remove SK_FREETYPE_HAS_MM.
>
> The SK_FREETYPE_HAS_MM define was added to delay the changes to
> support GX variation fonts on platforms which did not compile ftmm.c
> into their FreeType build. Now that all builds should have this file
> the define can be removed.
>
> Committed: https://skia.googlesource.com/skia/+/
4f61fee53af956a8beb4c56fa6479cb6b1aa5159
TBR=djsollen@google.com,bungeman@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1148303005
joshualitt [Mon, 1 Jun 2015 23:17:03 +0000 (16:17 -0700)]
Fix for crashing bots
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1159183006
joshualitt [Mon, 1 Jun 2015 21:17:47 +0000 (14:17 -0700)]
Set GeometryBufferMapThreshold defaults
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1161543003