platform/upstream/libSkiaSharp.git
10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 23 Apr 2014 03:04:11 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14320 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRefactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.
commit-bot@chromium.org [Wed, 23 Apr 2014 02:46:20 +0000 (02:46 +0000)]
Refactor SkPictureStateTree::Iterator to avoid use of kClip_SaveFlag.

The current implementation relies on soon-to-be-deprecated
kClip_SaveFlag behavior. Updated to use default save flags
(kMatrixClip_SaveFlag) and stop assuming that the matrix survives
restore() calls.

R=junov@chromium.org, reed@google.com, robertphillips@chromium.org, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/246893005

git-svn-id: http://skia.googlecode.com/svn/trunk@14319 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix double to SkScalar issues in SkTwoPointConicalGradient_gpu.cpp
commit-bot@chromium.org [Tue, 22 Apr 2014 21:24:22 +0000 (21:24 +0000)]
Fix double to SkScalar issues in SkTwoPointConicalGradient_gpu.cpp
NOTREECHECKS=True
NOTRY=True
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/247833003

git-svn-id: http://skia.googlecode.com/svn/trunk@14318 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFactor out common template code. Send stdout back to web page.
commit-bot@chromium.org [Tue, 22 Apr 2014 21:13:45 +0000 (21:13 +0000)]
Factor out common template code. Send stdout back to web page.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/246823004

git-svn-id: http://skia.googlecode.com/svn/trunk@14317 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd gpu fast path for two point conical gradients.
commit-bot@chromium.org [Tue, 22 Apr 2014 20:56:37 +0000 (20:56 +0000)]
Add gpu fast path for two point conical gradients.

Also shader changes should help numerical issues on certain android gpus

BUG=179264
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/238443006

git-svn-id: http://skia.googlecode.com/svn/trunk@14316 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoexpose CGImage -> SkBitmap
commit-bot@chromium.org [Tue, 22 Apr 2014 20:24:33 +0000 (20:24 +0000)]
expose CGImage -> SkBitmap

BUG=skia:
R=scroggo@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/243463005

git-svn-id: http://skia.googlecode.com/svn/trunk@14315 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of make drawText calls non-virtual, to ease SkFont and TextBlob (https://coder...
commit-bot@chromium.org [Tue, 22 Apr 2014 20:07:30 +0000 (20:07 +0000)]
Revert of make drawText calls non-virtual, to ease SkFont and TextBlob (https://codereview.chromium.org/243853006/)

Reason for revert:
need to test more the code-path where we don't opt into the new virtuals

Original issue's description:
> make drawText calls non-virtual, to ease SkFont and TextBlob
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14307

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/247983003

git-svn-id: http://skia.googlecode.com/svn/trunk@14314 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogyp: only include windows *_x64 targets if GYP_GENERATORS includes ninja
commit-bot@chromium.org [Tue, 22 Apr 2014 20:05:35 +0000 (20:05 +0000)]
gyp: only include windows *_x64 targets if GYP_GENERATORS includes ninja

BUG=skia:2442
R=caryclark@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/247143003

git-svn-id: http://skia.googlecode.com/svn/trunk@14313 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChange valgrind suppresion names for bug 2455.
bsalomon@google.com [Tue, 22 Apr 2014 19:58:58 +0000 (19:58 +0000)]
Change valgrind suppresion names for bug 2455.

BUG=skia:2455

Review URL: https://codereview.chromium.org/248063002

git-svn-id: http://skia.googlecode.com/svn/trunk@14312 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReverting Skia r14299 ( Remove guards Chromium no longer needs - https://codereview...
robertphillips@google.com [Tue, 22 Apr 2014 19:53:25 +0000 (19:53 +0000)]
Reverting Skia r14299 ( Remove guards Chromium no longer needs - https://codereview.chromium.org/246403004)

git-svn-id: http://skia.googlecode.com/svn/trunk@14311 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdding the ability to click on the images in the history and have that load the code...
commit-bot@chromium.org [Tue, 22 Apr 2014 19:32:06 +0000 (19:32 +0000)]
Adding the ability to click on the images in the history and have that load the code and image back into the editor space.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/246393002

git-svn-id: http://skia.googlecode.com/svn/trunk@14310 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate valgrind suppression names for bug 2453
bsalomon@google.com [Tue, 22 Apr 2014 19:30:16 +0000 (19:30 +0000)]
Update valgrind suppression names for bug 2453

BUG=skia:2453

Review URL: https://codereview.chromium.org/246653004

git-svn-id: http://skia.googlecode.com/svn/trunk@14309 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark bench suppressions with bug #
bsalomon@google.com [Tue, 22 Apr 2014 19:17:54 +0000 (19:17 +0000)]
Mark bench suppressions with bug #

BUG=skia:2452

Review URL: https://codereview.chromium.org/246513005

git-svn-id: http://skia.googlecode.com/svn/trunk@14308 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agomake drawText calls non-virtual, to ease SkFont and TextBlob
commit-bot@chromium.org [Tue, 22 Apr 2014 19:03:02 +0000 (19:03 +0000)]
make drawText calls non-virtual, to ease SkFont and TextBlob

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/243853006

git-svn-id: http://skia.googlecode.com/svn/trunk@14307 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd Valgrind suppression file for bench
bsalomon@google.com [Tue, 22 Apr 2014 18:47:02 +0000 (18:47 +0000)]
Add Valgrind suppression file for bench

BUG=skia:2450
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/246313007

git-svn-id: http://skia.googlecode.com/svn/trunk@14306 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix build: Windows has dibs on IGNORE
commit-bot@chromium.org [Tue, 22 Apr 2014 18:32:58 +0000 (18:32 +0000)]
Fix build: Windows has dibs on IGNORE

Also, make sure to undef macros after we're done with them.

BUG=skia:

NOTRY=true
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/247573003

git-svn-id: http://skia.googlecode.com/svn/trunk@14305 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoIncrease range for skp that triggers a perf regression periodically
bsalomon@google.com [Tue, 22 Apr 2014 18:31:55 +0000 (18:31 +0000)]
Increase range for skp that triggers a perf regression periodically

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/247073004

git-svn-id: http://skia.googlecode.com/svn/trunk@14304 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoeliminate config param -- it was always self's config
reed@google.com [Tue, 22 Apr 2014 18:22:30 +0000 (18:22 +0000)]
eliminate config param -- it was always self's config

BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/246513002

git-svn-id: http://skia.googlecode.com/svn/trunk@14303 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix size_t/int warnings in pictures
commit-bot@chromium.org [Tue, 22 Apr 2014 17:54:29 +0000 (17:54 +0000)]
fix size_t/int warnings in pictures

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/244273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14302 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove SK_IGNORE_FREETYPE_ROTATION_FIX and guarded code.
bungeman@google.com [Tue, 22 Apr 2014 17:37:34 +0000 (17:37 +0000)]
Remove SK_IGNORE_FREETYPE_ROTATION_FIX and guarded code.

Chromium/Blink have removed this define and rebaselined.
The guarded code is no longer used.

git-svn-id: http://skia.googlecode.com/svn/trunk@14301 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRefactor SkRecord opts, converting playback optimizations where possible.
commit-bot@chromium.org [Tue, 22 Apr 2014 16:57:20 +0000 (16:57 +0000)]
Refactor SkRecord opts, converting playback optimizations where possible.

This adds back two optimizations from SkPicture: drawPosText strength reduction to drawPosTextH, and pointless save-foo-restore blocks are noop'd away.

The small-T optimization in SkRecord gets in the way of implementing replace(), so I removed it.

Just to keep the API focused, I removed the methods on SkRecord that iterate over i for you; it's just as efficient to do it yourself, and all of the interesting code does its own custom iteration.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/245853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14300 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove guards Chromium no longer needs
commit-bot@chromium.org [Tue, 22 Apr 2014 16:26:29 +0000 (16:26 +0000)]
Remove guards Chromium no longer needs

Note: Android still needs these guards.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/246403004

git-svn-id: http://skia.googlecode.com/svn/trunk@14299 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse GradFlags for gradient Flags in SkGradientShader
commit-bot@chromium.org [Tue, 22 Apr 2014 16:25:15 +0000 (16:25 +0000)]
Use GradFlags for gradient Flags in SkGradientShader

This is done to avoid confusion with other Flag variable used for alpha
type in shader

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/247433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14298 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd asADash entry point into SkPathEffect to allow extracting Dash info from PathEffects
commit-bot@chromium.org [Tue, 22 Apr 2014 15:21:18 +0000 (15:21 +0000)]
Add asADash entry point into SkPathEffect to allow extracting Dash info from PathEffects

BUG=skia:
R=bsalomon@google.com, reed@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/212103010

git-svn-id: http://skia.googlecode.com/svn/trunk@14297 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNewRasterDirect should *not* erase the pixels -- direct means the client is in-charge
commit-bot@chromium.org [Tue, 22 Apr 2014 15:02:43 +0000 (15:02 +0000)]
NewRasterDirect should *not* erase the pixels -- direct means the client is in-charge

BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/246493002

git-svn-id: http://skia.googlecode.com/svn/trunk@14296 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSK_API-export SkBBHFactory & friends.
commit-bot@chromium.org [Tue, 22 Apr 2014 13:33:16 +0000 (13:33 +0000)]
SK_API-export SkBBHFactory & friends.

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/243333008

git-svn-id: http://skia.googlecode.com/svn/trunk@14295 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 22 Apr 2014 03:05:17 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14294 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebase flaky skp bench range on win7
bsalomon@google.com [Mon, 21 Apr 2014 21:43:41 +0000 (21:43 +0000)]
rebase flaky skp bench range on win7
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/245563006

git-svn-id: http://skia.googlecode.com/svn/trunk@14293 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd --runOnce flag to run benchs once in release or to force convergence in debug
commit-bot@chromium.org [Mon, 21 Apr 2014 21:12:32 +0000 (21:12 +0000)]
Add --runOnce flag to run benchs once in release or to force convergence in debug

R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/242103013

git-svn-id: http://skia.googlecode.com/svn/trunk@14292 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd missing scale value to fix SkGradientShader memory error
commit-bot@chromium.org [Mon, 21 Apr 2014 21:09:49 +0000 (21:09 +0000)]
Add missing scale value to fix SkGradientShader memory error

BUG=skia:2446
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/245623005

git-svn-id: http://skia.googlecode.com/svn/trunk@14291 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd optional origin parameter to accessTopLayerPixels
commit-bot@chromium.org [Mon, 21 Apr 2014 21:09:38 +0000 (21:09 +0000)]
add optional origin parameter to accessTopLayerPixels

BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/244763004

git-svn-id: http://skia.googlecode.com/svn/trunk@14290 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRemove offset to SkMallocPixelRef::NewWithData - use SkData::NewSubset instead.
commit-bot@chromium.org [Mon, 21 Apr 2014 21:08:14 +0000 (21:08 +0000)]
Remove offset to SkMallocPixelRef::NewWithData - use SkData::NewSubset instead.

R=scroggo@google.com, mtklein@google.com, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/243483002

git-svn-id: http://skia.googlecode.com/svn/trunk@14289 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFixes for SkPictureShader.
commit-bot@chromium.org [Mon, 21 Apr 2014 19:33:12 +0000 (19:33 +0000)]
Fixes for SkPictureShader.

Update comment in header to make it more clear that the picture
should be unaltered after creating the shader. We want our shaders
to be immutable, and this supports that.

Make the factory return NULL if the shader would have never drawn
anyway i.e. for a null picture or picture with no width/height.

Addresses comments I brought up in
https://codereview.chromium.org/221923007/#msg16.

BUG=skia:1976
R=reed@google.com, fmalita@chromium.org, robertphillips@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/238253005

git-svn-id: http://skia.googlecode.com/svn/trunk@14288 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agowarn that docs/quickstart.md is out of sync with official docs
commit-bot@chromium.org [Mon, 21 Apr 2014 19:18:46 +0000 (19:18 +0000)]
warn that docs/quickstart.md is out of sync with official docs

(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=halcanary@google.com, hcm@google.com, mtklein@google.com
TBR=borenet

Author: epoger@google.com

Review URL: https://codereview.chromium.org/245283002

git-svn-id: http://skia.googlecode.com/svn/trunk@14287 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate flaky bench range for tabl_hsfi.skp_simple_viewport_1000x1000_gpu_ on Win7
bsalomon@google.com [Mon, 21 Apr 2014 19:08:30 +0000 (19:08 +0000)]
Update flaky bench range for tabl_hsfi.skp_simple_viewport_1000x1000_gpu_ on Win7

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/242453010

git-svn-id: http://skia.googlecode.com/svn/trunk@14286 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogit-sync-deps verifies that directory is a top-level git directory.
commit-bot@chromium.org [Mon, 21 Apr 2014 19:03:05 +0000 (19:03 +0000)]
git-sync-deps verifies that directory is a top-level git directory.

NOTRY=true
R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/245503003

git-svn-id: http://skia.googlecode.com/svn/trunk@14285 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoIncrease ranges for flaky skp benches
bsalomon@google.com [Mon, 21 Apr 2014 17:45:28 +0000 (17:45 +0000)]
Increase ranges for flaky skp benches

TBR=bensong@google.com

Review URL: https://codereview.chromium.org/245433002

git-svn-id: http://skia.googlecode.com/svn/trunk@14284 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove to using HTML templates when filling out the workspace history.
commit-bot@chromium.org [Mon, 21 Apr 2014 17:36:44 +0000 (17:36 +0000)]
Move to using HTML templates when filling out the workspace history.

This is a pre-step to having a history list that you can click on
and having the code moved back into the textarea, which will come
as a follow-up CL.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/244313007

git-svn-id: http://skia.googlecode.com/svn/trunk@14283 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a .gypi to insulate Chrome from refactorings in src/record.
commit-bot@chromium.org [Mon, 21 Apr 2014 17:08:19 +0000 (17:08 +0000)]
Add a .gypi to insulate Chrome from refactorings in src/record.

Rather than listing out sources explicitly in skia_library.gypi, I'll add this new .gypi to its includes.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/242733005

git-svn-id: http://skia.googlecode.com/svn/trunk@14282 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMark mixedxfermodes as ignored on Ubunutu12 Release 64 bit for nvprmsaa4 config
bsalomon@google.com [Mon, 21 Apr 2014 15:47:17 +0000 (15:47 +0000)]
Mark mixedxfermodes as ignored on Ubunutu12 Release 64 bit for nvprmsaa4 config

BUG=skia:2443

Review URL: https://codereview.chromium.org/245263003

git-svn-id: http://skia.googlecode.com/svn/trunk@14281 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkDELETE() -> SkDELETE_ARRAY() in gradients_many test
bsalomon@google.com [Mon, 21 Apr 2014 15:30:45 +0000 (15:30 +0000)]
SkDELETE() -> SkDELETE_ARRAY() in gradients_many test

Attempt to fix valgrind failure:
http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind/builds/489/steps/GenerateGMs/logs/stdio

TBR=reed@google.com

Review URL: https://codereview.chromium.org/245273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14280 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate baseline for mixed_xfermodes on nvprmsaa4
bsalomon@google.com [Mon, 21 Apr 2014 15:13:19 +0000 (15:13 +0000)]
Update baseline for mixed_xfermodes on nvprmsaa4

Review URL: https://codereview.chromium.org/243583007

git-svn-id: http://skia.googlecode.com/svn/trunk@14279 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdate DESIGN, forgot to add new perms for the new tables.
commit-bot@chromium.org [Mon, 21 Apr 2014 15:10:56 +0000 (15:10 +0000)]
Update DESIGN, forgot to add new perms for the new tables.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/243013005

git-svn-id: http://skia.googlecode.com/svn/trunk@14278 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoanticipate more optimizations by renaming some files and methods
commit-bot@chromium.org [Mon, 21 Apr 2014 15:03:36 +0000 (15:03 +0000)]
anticipate more optimizations by renaming some files and methods

also, call the new SkRecordOptimize in bench_playback

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/243243003

git-svn-id: http://skia.googlecode.com/svn/trunk@14277 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd --match to bench tools, extra decimal to bench_pictures.
commit-bot@chromium.org [Mon, 21 Apr 2014 14:59:59 +0000 (14:59 +0000)]
Add --match to bench tools, extra decimal to bench_pictures.

BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/243273002

git-svn-id: http://skia.googlecode.com/svn/trunk@14276 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPicking from the wrong end of the workspace history list.
commit-bot@chromium.org [Mon, 21 Apr 2014 14:57:50 +0000 (14:57 +0000)]
Picking from the wrong end of the workspace history list.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/244133002

git-svn-id: http://skia.googlecode.com/svn/trunk@14275 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase test f7927dd
commit-bot@chromium.org [Mon, 21 Apr 2014 14:48:53 +0000 (14:48 +0000)]
bench rebase test f7927dd
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/245223002

git-svn-id: http://skia.googlecode.com/svn/trunk@14274 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow running gyp_to_android without SkUserConfig.
commit-bot@chromium.org [Mon, 21 Apr 2014 14:45:01 +0000 (14:45 +0000)]
Allow running gyp_to_android without SkUserConfig.

The old code requires that include/config/SkUserConfig.h exists,
to ensure that it gets copied into Android's
include/core/SkUserConfig.h when we do a merge. However, if a
developer wants to make changes and rerun the script, they
should not have to recreate include/config/SkUserConfig.h just
to rerun the script. By default, allow the original to not
exist and just skip the copy.

Update tests to pass. Also add tests to support this use case.

Make gyp_to_android.py executable.

R=robertphillips@google.com, halcanary@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/242203008

git-svn-id: http://skia.googlecode.com/svn/trunk@14273 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSupport clip to layer flag on Android framework.
commit-bot@chromium.org [Mon, 21 Apr 2014 14:42:38 +0000 (14:42 +0000)]
Support clip to layer flag on Android framework.

This flag is being transitioned out, but the Android framework
still needs it.

R=reed@google.com, fmalita@google.com, robertphillips@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/243843002

git-svn-id: http://skia.googlecode.com/svn/trunk@14272 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd flipped gradient branch to two point conical gradient
commit-bot@chromium.org [Mon, 21 Apr 2014 13:10:25 +0000 (13:10 +0000)]
Add flipped gradient branch to two point conical gradient

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14235

R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/227623004

git-svn-id: http://skia.googlecode.com/svn/trunk@14271 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sun, 20 Apr 2014 03:04:55 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14270 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove sizeof check -- triggers warning in chrome
reed@google.com [Sun, 20 Apr 2014 00:56:50 +0000 (00:56 +0000)]
remove sizeof check -- triggers warning in chrome

git-svn-id: http://skia.googlecode.com/svn/trunk@14269 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoinline SkMulDiv now that 64bit mul is inlineable
commit-bot@chromium.org [Sat, 19 Apr 2014 22:12:35 +0000 (22:12 +0000)]
inline SkMulDiv now that 64bit mul is inlineable

TBR=caryclark@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/242493006

git-svn-id: http://skia.googlecode.com/svn/trunk@14268 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix warnings around size_t/int
commit-bot@chromium.org [Sat, 19 Apr 2014 22:00:40 +0000 (22:00 +0000)]
fix warnings around size_t/int
fix warnings around undeclared (non-static) functions

TBR=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/242643008

git-svn-id: http://skia.googlecode.com/svn/trunk@14267 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd support for serving up a view that can be iframed.
commit-bot@chromium.org [Sat, 19 Apr 2014 14:50:23 +0000 (14:50 +0000)]
Add support for serving up a view that can be iframed.

Also add support for creating the <iframe /> code needed for embedding.

This CL must land after https://codereview.chromium.org/240773003/

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/242613005

git-svn-id: http://skia.googlecode.com/svn/trunk@14266 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFirst pass at workspaces.
commit-bot@chromium.org [Sat, 19 Apr 2014 13:55:50 +0000 (13:55 +0000)]
First pass at workspaces.

Ability to create new workspaces. Run tries in a workspace, each try is added to a history of a workspace.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/240773003

git-svn-id: http://skia.googlecode.com/svn/trunk@14265 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 19 Apr 2014 03:04:56 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14264 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMass baseline for filltypespersp
bsalomon@google.com [Fri, 18 Apr 2014 21:57:48 +0000 (21:57 +0000)]
Mass baseline for filltypespersp

Review URL: https://codereview.chromium.org/243853002

git-svn-id: http://skia.googlecode.com/svn/trunk@14263 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMass baselining of drrect GM
bsalomon@google.com [Fri, 18 Apr 2014 21:06:59 +0000 (21:06 +0000)]
Mass baselining of drrect GM

Review URL: https://codereview.chromium.org/243723003

git-svn-id: http://skia.googlecode.com/svn/trunk@14262 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMass rebaseline of the rrect_* GMs
bsalomon@google.com [Fri, 18 Apr 2014 20:13:43 +0000 (20:13 +0000)]
Mass rebaseline of the rrect_* GMs

Review URL: https://codereview.chromium.org/243693002

git-svn-id: http://skia.googlecode.com/svn/trunk@14261 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove unused fOverflowed from SkClampRange
reed@google.com [Fri, 18 Apr 2014 19:36:22 +0000 (19:36 +0000)]
remove unused fOverflowed from SkClampRange

TBR=scroggo@google.com

Review URL: https://codereview.chromium.org/243563002

git-svn-id: http://skia.googlecode.com/svn/trunk@14260 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix int/size_t warnings
reed@google.com [Fri, 18 Apr 2014 19:29:07 +0000 (19:29 +0000)]
fix int/size_t warnings

patch from issue 239933002

BUG=skia:
R=bungeman@google.com

Review URL: https://codereview.chromium.org/242113010

git-svn-id: http://skia.googlecode.com/svn/trunk@14259 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStaging for cleanup of SkPicture-related headers
robertphillips@google.com [Fri, 18 Apr 2014 18:04:41 +0000 (18:04 +0000)]
Staging for cleanup of SkPicture-related headers

https://codereview.chromium.org/243173002

git-svn-id: http://skia.googlecode.com/svn/trunk@14258 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agogradient_many gm to test banding and precision
reed@google.com [Fri, 18 Apr 2014 17:55:37 +0000 (17:55 +0000)]
gradient_many gm to test banding and precision

BUG=skia:

Review URL: https://codereview.chromium.org/243133005

git-svn-id: http://skia.googlecode.com/svn/trunk@14257 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for r14201. (Fix size of rotated text with FreeType.)
bungeman@google.com [Fri, 18 Apr 2014 17:38:43 +0000 (17:38 +0000)]
Rebaselines for r14201. (Fix size of rotated text with FreeType.)

git-svn-id: http://skia.googlecode.com/svn/trunk@14256 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorename SkPaintParts.* to SkPaintPart.*
reed@google.com [Fri, 18 Apr 2014 15:14:25 +0000 (15:14 +0000)]
rename SkPaintParts.* to SkPaintPart.*

BUG=skia:
R=caryclark@google.com

Review URL: https://codereview.chromium.org/242943004

git-svn-id: http://skia.googlecode.com/svn/trunk@14255 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGet gradient information for gpu effect directly from SkGradientShader instead of...
commit-bot@chromium.org [Fri, 18 Apr 2014 14:42:11 +0000 (14:42 +0000)]
Get gradient information for gpu effect directly from SkGradientShader instead of calling asAGradient

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/241173005

git-svn-id: http://skia.googlecode.com/svn/trunk@14254 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReduce internal explicit SaveFlags usage.
commit-bot@chromium.org [Fri, 18 Apr 2014 14:19:31 +0000 (14:19 +0000)]
Reduce internal explicit SaveFlags usage.

Most of these are either redundant/defaults or (hopefully)
unnecessarily specific.

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/241453003

git-svn-id: http://skia.googlecode.com/svn/trunk@14253 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 18 Apr 2014 03:03:54 +0000 (03:03 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14252 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStaged removal of SkPicture-derived classes
commit-bot@chromium.org [Thu, 17 Apr 2014 23:35:06 +0000 (23:35 +0000)]
Staged removal of SkPicture-derived classes

This CL removes the SkPicture-derived classes (with a flag to keeps clients working). In the process it also lightens the recording factory function so it is no longer ref counted).

The only interesting bits are in SkPicture* and Sk*Picture.*

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/238273012

git-svn-id: http://skia.googlecode.com/svn/trunk@14251 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd SK_SUPPORT_LEGACY_PROCXFERMODE to skia_for_chromium_defines.gypi
commit-bot@chromium.org [Thu, 17 Apr 2014 23:25:50 +0000 (23:25 +0000)]
add SK_SUPPORT_LEGACY_PROCXFERMODE to skia_for_chromium_defines.gypi

R=reed@google.com
TBR=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/242053002

git-svn-id: http://skia.googlecode.com/svn/trunk@14250 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoclean up gitignore; sort, add chromeos/externals, remove trailing /.
commit-bot@chromium.org [Thu, 17 Apr 2014 22:56:46 +0000 (22:56 +0000)]
clean up gitignore; sort, add chromeos/externals, remove trailing /.

R=mtklein@google.com, epoger@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/240173008

git-svn-id: http://skia.googlecode.com/svn/trunk@14249 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Roll ANGLE. (https://codereview.chromium.org/237173002/)
commit-bot@chromium.org [Thu, 17 Apr 2014 21:31:32 +0000 (21:31 +0000)]
Revert of Roll ANGLE. (https://codereview.chromium.org/237173002/)

Reason for revert:
http://skbug.com/2437

Original issue's description:
> Roll ANGLE.
>
> BUG=skia:2272
>
> Committed: http://code.google.com/p/skia/source/detail?r=14243

R=bsalomon@chromium.org, geofflang@chromium.org
TBR=bsalomon@chromium.org, geofflang@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2272

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/238863006

git-svn-id: http://skia.googlecode.com/svn/trunk@14248 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Extract most of the mutable state of SkShader into a separate Context objec...
commit-bot@chromium.org [Thu, 17 Apr 2014 21:09:49 +0000 (21:09 +0000)]
Revert of Extract most of the mutable state of SkShader into a separate Context object. (https://codereview.chromium.org/207683004/)

Reason for revert:
Causing memory leaks in Chromium.

Original issue's description:
> Extract most of the mutable state of SkShader into a separate Context object.
>
> SkShader currently stores some state during draw calls via setContext(...).
> Move that mutable state into a separate SkShader::Context class that is
> constructed on demand for the duration of the draw.
>
> Calls to setContext() are replaced with createContext() which returns a context
> corresponding to the shader object or NULL if the parameters to createContext
> are invalid.
>
> TEST=out/Debug/dm
> BUG=skia:1976
>
> Committed: http://code.google.com/p/skia/source/detail?r=14216

R=scroggo@google.com, skyostil@chromium.org, tomhudson@chromium.org, senorblanco@chromium.org, reed@google.com, dominikg@chromium.org
TBR=dominikg@chromium.org, reed@google.com, scroggo@google.com, senorblanco@chromium.org, skyostil@chromium.org, tomhudson@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:1976

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/241283003

git-svn-id: http://skia.googlecode.com/svn/trunk@14247 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert r14218.
bungeman@google.com [Thu, 17 Apr 2014 21:09:00 +0000 (21:09 +0000)]
Revert r14218.

git-svn-id: http://skia.googlecode.com/svn/trunk@14246 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Fix memory leak in SkGradientShader. (https://codereview.chromium.org/24030...
commit-bot@chromium.org [Thu, 17 Apr 2014 21:02:29 +0000 (21:02 +0000)]
Revert of Fix memory leak in SkGradientShader. (https://codereview.chromium.org/240303003/)

Reason for revert:
This and https://codereview.chromium.org/207683004 are causing memory leaks.

Original issue's description:
> Fix memory leak in SkGradientShader.
>
> Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap.
> Rename methods returning a "pre-reffed" object to indicate obligations.
>
> BUG=skia:1976
>
> Committed: http://code.google.com/p/skia/source/detail?r=14223

R=reed@google.com, scroggo@google.com, dominikg@chromium.org
TBR=dominikg@chromium.org, reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:1976

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/241603002

git-svn-id: http://skia.googlecode.com/svn/trunk@14245 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSkiaSampleRenderer - handle case where compiler won't cast jint to void*.
commit-bot@chromium.org [Thu, 17 Apr 2014 19:41:06 +0000 (19:41 +0000)]
SkiaSampleRenderer - handle case where compiler won't cast jint to void*.

R=djsollen@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/239703016

git-svn-id: http://skia.googlecode.com/svn/trunk@14244 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRoll ANGLE.
commit-bot@chromium.org [Thu, 17 Apr 2014 18:29:06 +0000 (18:29 +0000)]
Roll ANGLE.

BUG=skia:2272
R=bsalomon@chromium.org, bsalomon@google.com

Author: geofflang@chromium.org

Review URL: https://codereview.chromium.org/237173002

git-svn-id: http://skia.googlecode.com/svn/trunk@14243 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAshmem functions compile when size_t != __u32
commit-bot@chromium.org [Thu, 17 Apr 2014 17:28:20 +0000 (17:28 +0000)]
Ashmem functions compile when size_t != __u32

R=djsollen@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/241123002

git-svn-id: http://skia.googlecode.com/svn/trunk@14242 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd some asserts for mipmaps, and cleanup fFilterLevel if mipping failed
commit-bot@chromium.org [Thu, 17 Apr 2014 16:46:07 +0000 (16:46 +0000)]
add some asserts for mipmaps, and cleanup fFilterLevel if mipping failed

BUG=skia:
R=scroggo@google.com, humper@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/240633003

git-svn-id: http://skia.googlecode.com/svn/trunk@14241 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix expected size in 32bit builds
reed@google.com [Thu, 17 Apr 2014 16:14:26 +0000 (16:14 +0000)]
fix expected size in 32bit builds

BUG=skia:

Review URL: https://codereview.chromium.org/240283012

git-svn-id: http://skia.googlecode.com/svn/trunk@14240 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoallow gyp_skia to be run from any directory.
commit-bot@chromium.org [Thu, 17 Apr 2014 16:11:58 +0000 (16:11 +0000)]
allow gyp_skia to be run from any directory.

R=epoger@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/240383003

git-svn-id: http://skia.googlecode.com/svn/trunk@14239 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoOrphan ProcXfermode, with an eye towards removing it
commit-bot@chromium.org [Thu, 17 Apr 2014 15:19:32 +0000 (15:19 +0000)]
Orphan ProcXfermode, with an eye towards removing it

BUG=skia:
R=scroggo@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/240533003

git-svn-id: http://skia.googlecode.com/svn/trunk@14238 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove unused tests to fix new clang build
commit-bot@chromium.org [Thu, 17 Apr 2014 15:18:21 +0000 (15:18 +0000)]
remove unused tests to fix new clang build

R=mtklein@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/241043002

git-svn-id: http://skia.googlecode.com/svn/trunk@14237 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Add flipped gradient branch to two point conical gradient (https://coderevi...
commit-bot@chromium.org [Thu, 17 Apr 2014 13:57:31 +0000 (13:57 +0000)]
Revert of Add flipped gradient branch to two point conical gradient (https://codereview.chromium.org/227623004/)

Reason for revert:
Breaking all CompareGMs

Original issue's description:
> Add flipped gradient branch to two point conical gradient
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14235

R=bsalomon@google.com, mtklein@google.com
TBR=bsalomon@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/239993006

git-svn-id: http://skia.googlecode.com/svn/trunk@14236 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd flipped gradient branch to two point conical gradient
commit-bot@chromium.org [Thu, 17 Apr 2014 13:28:06 +0000 (13:28 +0000)]
Add flipped gradient branch to two point conical gradient

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/227623004

git-svn-id: http://skia.googlecode.com/svn/trunk@14235 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 17 Apr 2014 03:05:10 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@14234 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMore flags needed to build Android framework.
commit-bot@chromium.org [Wed, 16 Apr 2014 23:06:29 +0000 (23:06 +0000)]
More flags needed to build Android framework.

R=djsollen@google.com
TBR=djsollen@google.com
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/240563005

git-svn-id: http://skia.googlecode.com/svn/trunk@14233 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDon't unset gFCSafeToUse when it's still safe to use.
commit-bot@chromium.org [Wed, 16 Apr 2014 22:10:52 +0000 (22:10 +0000)]
Don't unset gFCSafeToUse when it's still safe to use.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/240513003

git-svn-id: http://skia.googlecode.com/svn/trunk@14232 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoinstall_dependencides tool for posix-type systems
commit-bot@chromium.org [Wed, 16 Apr 2014 22:10:48 +0000 (22:10 +0000)]
install_dependencides tool for posix-type systems

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/239303010

git-svn-id: http://skia.googlecode.com/svn/trunk@14231 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSupport picture recording in Android framework.
commit-bot@chromium.org [Wed, 16 Apr 2014 22:08:32 +0000 (22:08 +0000)]
Support picture recording in Android framework.

Fixes master-skia build.

R=djsollen@google.com
TBR=djsollen@google.com
NOTREECHECKS=true
NOTRY=true

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/240093007

git-svn-id: http://skia.googlecode.com/svn/trunk@14230 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoalways store bitfields along with dirty in FlatteningTraits
commit-bot@chromium.org [Wed, 16 Apr 2014 20:48:10 +0000 (20:48 +0000)]
always store bitfields along with dirty in FlatteningTraits

This allows us to simplify lots of setters in SkPaint, which in the non-android case, could now be just assignments (and therefore inlineable).

R=mtklein@google.com, robertphillips@google.com, tomhudson@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/240273004

git-svn-id: http://skia.googlecode.com/svn/trunk@14229 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRoll ANGLE.
commit-bot@chromium.org [Wed, 16 Apr 2014 20:31:54 +0000 (20:31 +0000)]
Roll ANGLE.

Contains small changes to ANGLE to pass skia tests.

BUG=skia:2272
R=bsalomon@google.com

Author: geofflang@chromium.org

Review URL: https://codereview.chromium.org/235923020

git-svn-id: http://skia.googlecode.com/svn/trunk@14228 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThis is an short replacement for gclient.
commit-bot@chromium.org [Wed, 16 Apr 2014 19:21:00 +0000 (19:21 +0000)]
This is an short replacement for gclient.

Makes use of our current DEPS file to allow for a smooth transition.

BUG=skia:291
NOTRY=true
R=borenet@google.com, tfarina@chromium.org, epoger@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/191133005

git-svn-id: http://skia.googlecode.com/svn/trunk@14227 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoReverting r14225 (Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling - https://coderevie...
robertphillips@google.com [Wed, 16 Apr 2014 17:10:12 +0000 (17:10 +0000)]
Reverting r14225 (Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling - https://codereview.chromium.org/237673017/) due to compiler complaints

git-svn-id: http://skia.googlecode.com/svn/trunk@14226 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling
robertphillips@google.com [Wed, 16 Apr 2014 17:00:05 +0000 (17:00 +0000)]
Fix SK_SUPPORT_DEPRECATED_RECORD_FLAGS handling

https://codereview.chromium.org/237673017/

git-svn-id: http://skia.googlecode.com/svn/trunk@14225 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoread/write function_ptrs as just void*, and not as 'array of bytes'
commit-bot@chromium.org [Wed, 16 Apr 2014 16:24:08 +0000 (16:24 +0000)]
read/write function_ptrs as just void*, and not as 'array of bytes'

BUG=skia:
R=mtklein@google.com, bungeman@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/240013005

git-svn-id: http://skia.googlecode.com/svn/trunk@14224 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix memory leak in SkGradientShader.
commit-bot@chromium.org [Wed, 16 Apr 2014 16:17:39 +0000 (16:17 +0000)]
Fix memory leak in SkGradientShader.

Make sure pointer to gradient shader cache is unreffed in SkGradientShaderBase::getGradientTableBitmap.
Rename methods returning a "pre-reffed" object to indicate obligations.

BUG=skia:1976
R=reed@google.com, scroggo@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/240303003

git-svn-id: http://skia.googlecode.com/svn/trunk@14223 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDouble assignment in GrGpuGL::configToGLFormats()
commit-bot@chromium.org [Wed, 16 Apr 2014 16:07:37 +0000 (16:07 +0000)]
Double assignment in GrGpuGL::configToGLFormats()

Remove the first one.

R=hcm@google.com, bsalomon@google.com
BUG=skia:2427

Author: siglesias@igalia.com

Review URL: https://codereview.chromium.org/240123002

git-svn-id: http://skia.googlecode.com/svn/trunk@14222 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRetract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API
commit-bot@chromium.org [Wed, 16 Apr 2014 16:02:10 +0000 (16:02 +0000)]
Retract SkPicture::kOptimizeForClippedPlayback_RecordingFlag from public API

This CL sets the stage for retracting the SkPicture::kOptimizeForClippedPlayback_RecordingFlag flag
from the public API (more work needs to be done in Blink & Chrome). In the new world the only way
to set this flag (and thus instantiate an SkPicture-derived
class) is by passing a factory to the SkPictureRecorder class. This is to get all clients always using
factories so that we can then change the factory call used (i.e., so the factory just creates a BBH) and
do away with the SkPicture-derived classes.

BUG=skia:2315
R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/239703006

git-svn-id: http://skia.googlecode.com/svn/trunk@14221 2bbb7eff-a529-9590-31e7-b0007b416f81