Derek Foreman [Thu, 12 Apr 2018 18:33:53 +0000 (13:33 -0500)]
efl_ui_win: Always show the wayland pointer
It's hidden by the compositor as required, so this just makes life much
more complicated in other code.
ref T6834
Change-Id: Ib40f9fd189edea084acdf99b18436adc5ce2f3e5
Derek Foreman [Thu, 12 Apr 2018 18:40:24 +0000 (13:40 -0500)]
ee_wayland: Remove use of draw_ok
This appears vestigial, as the evas render path we use has no custom
draw_ok handling, so nothing ever reads this variable.
ref T6834
Change-Id: I8c8aef946e4cc6a7d097b1ad954777beae274e02
Derek Foreman [Thu, 12 Apr 2018 18:27:17 +0000 (13:27 -0500)]
ee_cocoa: Remove draw_ok sets
draw_ok isn't currently used by anything but the X custom render function,
so it's doing absolutely nothing here.
ref T6834
Change-Id: Ibc68e65d147ce2b255683b5aac3342e4e583a7a3
Derek Foreman [Thu, 8 Mar 2018 19:46:42 +0000 (13:46 -0600)]
gl_common: Make extension string checks more robust
strstr() can give false positives if the extension name is a subset of
a string in the extension list, for example EGL_EXT_image_dma_buf_import
would match EGL_EXT_image_dma_buf_import_modifiers.
I've opted for a mildly badgered copy of epoxy's test, which should be
robust in the face of subsets.
Change-Id: Ie2b0a4045795c9b11d5b526ce135bfb7ed7ee218
Derek Foreman [Thu, 8 Mar 2018 19:33:32 +0000 (13:33 -0600)]
gl_common: Replace strstr() for extension checks with a helper function
The helper incorporates NULL checks, and we love those, so it's better.
Change-Id: I9fb9b17f7f325fe58a563138acb4de14857500c6
Mike Blumenkrantz [Fri, 23 Feb 2018 19:17:54 +0000 (14:17 -0500)]
elm_win: disable handling of auto_norender_withdrawn for fake wins
these wins are not to be trifled with.
fix T6377
Daniel Hirt [Fri, 22 Jun 2018 09:46:40 +0000 (12:46 +0300)]
Edje: recalc edje before fetching the real part
Summary:
There are many calls to `_edje_real_part_recursive_get`. Though, it is
not guaranteed that the Edje object had instantiated all of the real
parts.
This change makes edje to always recalc before retrieving the real part.
The D6364 patch raised a good point, but presented a local fix, where
it seems that a global fix such as this is needed, instead.
The local fix is removed in favor of this. Test suite still passes.
ref T7057
@fix
Test Plan: See T7057
Reviewers: devilhorns
Subscribers: cedric, zmike, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6365
Change-Id: I7defe4441a87a485070082903153d0f34767bcf5
Youngbok Shin [Fri, 22 Jun 2018 09:15:11 +0000 (12:15 +0300)]
edje: fix text set/get issue without edje calculation
Summary:
Some changes broke really basical function behavior of text.
I couldn't get text from an edje object which I just set to the given edje object.
In the past code, edje called recalc function before trying to get text.
So, this patch bring that code to fix this issue.
@fix
Test Plan: Included. Run "make check"
Reviewers: herdsman, raster, cedric, woohyun, devilhorns
Subscribers: #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6364
Change-Id: I51af5389755d5f2f6dfb66ddf55e097c2a239e38
Wonki Kim [Thu, 21 Jun 2018 07:16:10 +0000 (16:16 +0900)]
Revert "efl_ui_win: add missing wayland interface for setting role of winodw"
This reverts commit
a8ebaee4149c91b7d8f5473d5a5f463b1ac39c90.
Change-Id: Iebe9c4078d8e71d88f9649067098cbcafdcde2c1
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Xavi Artigas [Thu, 21 Jun 2018 11:10:56 +0000 (13:10 +0200)]
eo_debug: Fix segfault when parsing EO_LIFECYCLE_DEBUG envvar
Summary:
The 'if' block should only be executed when the string contains the colon and
something else behind, but sscanf cannot be used in this case.
If the string contained no colon, the following line with strchr(s, ':')
returns NULL and everything explodes.
Test Plan: eo_debug -l now works for me without segfaulting.
Reviewers: bu5hm4n, zmike, devilhorns, q66
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6347
Chris Michael [Thu, 21 Jun 2018 14:14:18 +0000 (10:14 -0400)]
efl: Bump required libinput version for Elput
Since commit 7a7abb, LIBINPUT_EVENT_SWITCH_TOGGLE was introduced to
Elput, however this enum did not get released into libinput until 1.7
so we need to require updated libinput now in our configure.ac
@fix
Alastair Poole [Thu, 21 Jun 2018 13:58:25 +0000 (14:58 +0100)]
ecore_cocoa_cnp: Check for nil object before adding.
This is fixing a segfault. More work needs to be done in
efl_selection_manager.c. Current status is broken.
Alastair Poole [Thu, 21 Jun 2018 12:34:20 +0000 (13:34 +0100)]
ecore_cocoa: fix ECORE_EVENT_KEY_DOWN/UP on MacOS.
Fixing issue with modifier keys on MacOS. These events were missing
window information. Tested with Fyne.io. Window ID and keyname
are valid. See: http://bogosys.org/images/fyne_OSX.png. Thanks
zmike for initial investigation.
@fix T6944
Daniel Kolesa [Thu, 21 Jun 2018 12:09:59 +0000 (14:09 +0200)]
efl: include sys/types.h where ssize_t is used
This include is necessary according to POSIX. Without it, build
fails on certain platforms (QNX). It may already be included
implicitly in some of those files, but declare intent.
Fixes T6667.
Hermet Park [Thu, 21 Jun 2018 10:15:47 +0000 (19:15 +0900)]
Revert "edje: code refactoring for readibility."
This reverts commit
7fb47fc064b8f429242b4d5cdf57071475087821.
subsequential revert for previous one.
90a89d1ab2b5d23b29ad0f2680b77b5ba7f56b42.
Hermet Park [Thu, 21 Jun 2018 10:12:53 +0000 (19:12 +0900)]
Revert "edje: fix a regression error by
7fb47fc064b8f429242b4d5cdf57071475087821."
This reverts commit
475c93fd7599badad0c073e5eb025b92481b53ec.
long time after touch,
forgot that eet data has key-data pairing structure.
this change would break theme compatibility.
Thanks bu5hm4n for pointing out this.
Alastair Poole [Thu, 21 Jun 2018 09:22:08 +0000 (10:22 +0100)]
ecore_con: do proper version test for TLS_method.
Marcel Hollerbach [Thu, 21 Jun 2018 05:53:36 +0000 (14:53 +0900)]
efl_ui_navigation_bar: less warnings
Reviewers: zmike, ManMower, devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6344
Marcel Hollerbach [Thu, 21 Jun 2018 05:52:29 +0000 (14:52 +0900)]
efl_ui_focus_manager_calc: fix warnings
Summary: its a false positive...
Reviewers: zmike, ManMower, devilhorns, Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6342
SangHyeon Lee [Thu, 21 Jun 2018 05:09:06 +0000 (14:09 +0900)]
elm_gengrid : fix gengrid cached items disapearing issue by wrong reference counting
gengrid item view is managed by cache while scrolling,
but efl_wref_add/del and VIEW_ADD is not paired well.
this commit is fixing the issue of item dispearing when it scrolls.
Change-Id: I28c08f12bbb0d2a098bcceea107c6a0993c220d7
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Marcel Hollerbach [Thu, 21 Jun 2018 03:56:07 +0000 (12:56 +0900)]
efl_ui_widget_focus_manager: less warnings
Summary: fix T7050
Reviewers: zmike, ManMower, devilhorns, Hermet
Reviewed By: Hermet
Subscribers: Hermet, cedric, #committers
Tags: #efl
Maniphest Tasks: T7050
Differential Revision: https://phab.enlightenment.org/D6341
SangHyeon Lee [Thu, 21 Jun 2018 05:13:21 +0000 (14:13 +0900)]
elm_gengrid : fix gengrid cached items disapearing issue by wrong reference counting
this patch is porting from upstream.
Change-Id: Iee1af82ca1a121433015f2b84abdd43ce9e25337
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Gwanglim Lee [Tue, 19 Jun 2018 13:26:11 +0000 (22:26 +0900)]
efl_ui_win: add missing wayland interface for setting role of winodw
@tizen_fix
Change-Id: I359bc4589260ffaabfae5b75e18e499c1dd2d282
Mike Blumenkrantz [Wed, 20 Jun 2018 16:33:01 +0000 (11:33 -0500)]
elm_colorselector: fix improperly named API theme parts
Summary:
API parts require namespacing, these parts have been namespaced with
compatibility code added to handle legacy naming
Reviewers: cedric, Hermet, devilhorns, stephenmhouston
Subscribers: segfaultxavi, Hermet, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6213
Daniel Hirt [Wed, 20 Jun 2018 16:24:05 +0000 (19:24 +0300)]
Edje load: add safecheck for TEXTBLOCK-specific code path
There is a specific TEXTBLOCK part code path that shouldn't be taken
for other parts.
@fixes T6279
Marcel Hollerbach [Wed, 20 Jun 2018 16:24:06 +0000 (12:24 -0400)]
elm: refactor do not call efl_data_scope_get on a object without data
Summary:
A call to efl_data_Scope_get is actually quite dangerous,
efl_data_scope_get will return a pointer to a 0 sized segment in memory,
this is happening based on how the class data is organized. So in theory
you could use this pointer and accidently write to it. This resolves
this issue.
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6337
Alastair Poole [Wed, 20 Jun 2018 14:24:02 +0000 (15:24 +0100)]
ecore_con: FreeBSD 11.2 not providing TLS generic methods.
On some systems the TLS_client/server_method() is not available.
Using fallback. In time as openssl changes propagate this really
shouldn't be necessary.
Alastair Poole [Wed, 20 Jun 2018 13:11:52 +0000 (14:11 +0100)]
Patch for T6342
Summary: Deprecate SSLv3.
Reviewers: zmike, raster, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6334
Shinwoo Kim [Tue, 19 Jun 2018 06:55:37 +0000 (15:55 +0900)]
ecore_wl2_display: remove infinite loop possibility
The wl_display_dispatch_pending returns -1 on failure.
This could make infinite loop in _ecore_wl_cb_pre_handle_data.
Change-Id: I1730e6007fd08db308be4412f0a8c9f51d7f3726
Bowon Ryu [Mon, 18 Jun 2018 11:29:57 +0000 (20:29 +0900)]
elm_toolbar: fix icon sizing issue
icon size * scale - this causes the issue.
this is not wrong,
but Tizen UX did not consider scale to icon size.
so, this is removed for compatibility.
@tizen_fix
Change-Id: Ib71ec1998767988bc7ad39299c3282132f8a0fd5
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Mike Blumenkrantz [Tue, 19 Jun 2018 18:08:08 +0000 (14:08 -0400)]
tests: remove eldbus special casing from checks to enable parallel test runs
Summary:
now that eldbus tests can safely run in parallel there is no reason to
prevent them from doing so
fix T6848
Depends on D6204
Reviewers: stefan_schmidt, cedric, ManMower, devilhorns
Reviewed By: cedric, ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6848
Differential Revision: https://phab.enlightenment.org/D6205
Mike Blumenkrantz [Tue, 19 Jun 2018 18:08:20 +0000 (14:08 -0400)]
tests: use unique dbus bus names for each eldbus test case fixture
Summary:
dbus bus names are unique and cannot be acquired by multiple connections
simultaneously; by making this per-file unique, this part of the test can
run in parallel without bus collisions
ref T6848
Depends on D6201
Reviewers: stefan_schmidt, cedric, bu5hm4n, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: ManMower, cedric, #committers
Tags: #efl
Maniphest Tasks: T6848
Differential Revision: https://phab.enlightenment.org/D6202
Mike Blumenkrantz [Tue, 19 Jun 2018 18:04:45 +0000 (14:04 -0400)]
eina_debug_bt: only enable SIGPROF handler when profiling is enabled
Summary:
if profiling is not enabled then reaching this signal handler will always
result in a crash
moreover, the signal handler has no functional value if profiling is not active,
so do not add it until that point
fix T7028
@fix
Depends on D6311
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7028
Differential Revision: https://phab.enlightenment.org/D6312
Mike Blumenkrantz [Tue, 19 Jun 2018 18:04:40 +0000 (14:04 -0400)]
tests: add test for eina_debug signal handling
Summary:
currently this crashes, so add a simple test to ensure that it works
eventually
ref T7028
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7028
Differential Revision: https://phab.enlightenment.org/D6311
Mike Blumenkrantz [Tue, 19 Jun 2018 17:54:16 +0000 (13:54 -0400)]
ecore: call eina_debug_fork_reset() in fork reset function
Summary:
ensure that this occurs as expected when forks happen
note that this is already being actively tested in the elm unit tests
Depends on D6307
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6308
Mike Blumenkrantz [Fri, 15 Jun 2018 20:56:06 +0000 (16:56 -0400)]
eina_debug: add function to reset debug subsystem after fork
fork() kills this entire subsystem and leaves its internals
in an inactive but allocated state, so it's necessary to explicitly restart
everything in order to guarantee behavior
@feature
Differential Revision: https://phab.enlightenment.org/D6307
Mike Blumenkrantz [Fri, 15 Jun 2018 20:51:03 +0000 (16:51 -0400)]
eina_debug: make shutdown perform cleanups and kill the timer thread
this should not remain active after eina has been deactivated, so ensure
that everything stops as expected
ref T7019
Differential Revision: https://phab.enlightenment.org/D6306
Mike Blumenkrantz [Fri, 15 Jun 2018 20:51:03 +0000 (16:51 -0400)]
eina_debug_cpu: make shutdown perform cleanups and kill the timer thread
this should not remain active after eina has been deactivated, so ensure
that everything stops as expected
ref T7019
Differential Revision: https://phab.enlightenment.org/D6305
Mike Blumenkrantz [Fri, 15 Jun 2018 20:51:03 +0000 (16:51 -0400)]
eina_debug_timer: make shutdown perform cleanups and kill the timer thread
this should not remain active after eina has been deactivated, so ensure
that everything stops as expected
ref T7019
Differential Revision: https://phab.enlightenment.org/D6304
Mike Blumenkrantz [Fri, 15 Jun 2018 20:43:39 +0000 (16:43 -0400)]
eina: prevent threads subcomponent from being shutdown while eina is active
this basically breaks all thread usage if it happens, so ensure that the
threads infrastructure stays active for as long as eina is active
@fix
Differential Revision: https://phab.enlightenment.org/D6303
Mike Blumenkrantz [Fri, 15 Jun 2018 20:42:29 +0000 (16:42 -0400)]
eina: call eina_threads_init from eina_debug_init
eina is guaranteed to crash in any process without this call now that
eina_debug exists and requires threads
@fix
Differential Revision: https://phab.enlightenment.org/D6302
Mike Blumenkrantz [Fri, 15 Jun 2018 20:40:23 +0000 (16:40 -0400)]
eina: don't init subcomponents inside eina_debug
this should be done in a single location to avoid dependency conflicts
and make the code easier to read
Differential Revision: https://phab.enlightenment.org/D6301
Mike Blumenkrantz [Tue, 19 Jun 2018 17:42:16 +0000 (13:42 -0400)]
eo: CRI when class constructor or destructor is called from thread
Summary:
calling the constructor and deconstructor from different threads
causes issues with mempool deallocation, so ensure that the class is
always initialized in the main thread for safety, e.g., call the
SOME_NAMED_CLASS macro during init to instantiate the class
fix T7003
Reviewers: bu5hm4n, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7003
Differential Revision: https://phab.enlightenment.org/D6332
Mike Blumenkrantz [Tue, 19 Jun 2018 17:41:44 +0000 (13:41 -0400)]
elm_list: return from sizing_eval immediately if called during constructor
Summary:
this is both invalid and useless, so return immediately before spending cpu
time and generating error messages
fix T7035
Depends on D6324
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7035
Differential Revision: https://phab.enlightenment.org/D6325
Mike Blumenkrantz [Tue, 19 Jun 2018 17:41:16 +0000 (13:41 -0400)]
elm_colorselector: avoid calling functions with null objects
Summary:
a number of calls during construction resulted in null object errors here
fix T7036
Depends on D6323
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7036
Differential Revision: https://phab.enlightenment.org/D6324
Mike Blumenkrantz [Tue, 19 Jun 2018 17:41:02 +0000 (13:41 -0400)]
elm_colorselector: avoid passing null to efl functions
Summary:
this check already existed in the function but was not applied to the
entire function
ref T7030
Depends on D6322
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6323
Mike Blumenkrantz [Tue, 19 Jun 2018 17:40:52 +0000 (13:40 -0400)]
evas: switch to EFL_EVENT_INVALIDATE for event grabber sub-object deletion
Summary:
this requires the parent of the deleted object to be reachable, so use the
invalidate callback as this is the last point during which it's possible to
retrieve a parent object
ref T7030
Depends on D6320
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7030
Differential Revision: https://phab.enlightenment.org/D6321
Mike Blumenkrantz [Tue, 19 Jun 2018 17:40:43 +0000 (13:40 -0400)]
efl_ui_win: check frame_obj existence before operating on it in pre_render
Summary:
this object will not exist for fake win objects, e.g., in enlightenment
fix T7033
Depends on D6319
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7033
Differential Revision: https://phab.enlightenment.org/D6320
Mike Blumenkrantz [Tue, 19 Jun 2018 17:40:27 +0000 (13:40 -0400)]
efl_ui_win: do not attempt to focus a null object on focus-in
Summary:
ref T7033
Depends on D6318
Reviewers: bu5hm4n, Hermet, woohyun, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7033
Differential Revision: https://phab.enlightenment.org/D6319
Marcel Hollerbach [Tue, 19 Jun 2018 17:36:04 +0000 (13:36 -0400)]
eo: make the debug build print leaked errors
Summary: Depends on D6328
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6329
Marcel Hollerbach [Tue, 19 Jun 2018 17:35:53 +0000 (13:35 -0400)]
eo: get rid of eo_id
Summary:
build with this disabled is just not working as the thread model of eo
falls apart. The threadmodel is required to have eo_id, as it decoded
the thread information in the eo_id, which is not working without eo_id.
This also fixes the testcases that have never been executed due to the
fact of the missing HAVE_EO_ID
fix T6610
Depends on D6327
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T6610
Differential Revision: https://phab.enlightenment.org/D6328
Marcel Hollerbach [Tue, 19 Jun 2018 17:35:38 +0000 (13:35 -0400)]
eo: only call efl_parent_set when parent_id is available
Summary:
this is no functinal change, we safe the calling to efl_parent_set.
Nothing else, the base implementation is initializated with NULL as
parent, and efl_parent_set with NULL would have returned in the first
few lines.
fix T7032
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T7032
Differential Revision: https://phab.enlightenment.org/D6327
Mike Blumenkrantz [Tue, 19 Jun 2018 17:33:30 +0000 (13:33 -0400)]
tests: set monitoring interval for eio tests to 0.05s
Summary:
cpu usage is not an issue during test runs, we want the tests to finish
as fast as possible in all cases regardless of the cost. this resolves
the last remaining issue with eio tests where sometimes the fallback
monitor would trigger and the test suite would hang for 60+ seconds
fix T6915
Depends on D6248
Reviewers: stefan_schmidt, bu5hm4n, ManMower, devilhorns
Reviewed By: bu5hm4n, ManMower
Subscribers: bu5hm4n, cedric, #committers
Tags: #efl
Maniphest Tasks: T6915
Differential Revision: https://phab.enlightenment.org/D6249
Mike Blumenkrantz [Tue, 19 Jun 2018 17:33:19 +0000 (13:33 -0400)]
tests: use fixtures for eio tests
Summary:
remove a lot of duplicated code and make this test suite read more like
all the other suites
fix T6813
Depends on D6247
Reviewers: stefan_schmidt, bu5hm4n, ManMower, devilhorns
Reviewed By: bu5hm4n, ManMower
Subscribers: Hermet, bu5hm4n, cedric, #committers
Tags: #efl
Maniphest Tasks: T6813
Differential Revision: https://phab.enlightenment.org/D6248
Mike Blumenkrantz [Tue, 19 Jun 2018 17:33:14 +0000 (13:33 -0400)]
eio: add method for setting the global file polling rate for fallback monitors
Summary:
the default value for the fallback poll monitor timer interval is 60.0 seconds,
which is not useful for all cases, such as CI, where we don't care about cpu
usage and just want things to process as fast as possible at all times
this enables setting the interval to any value, ensuring that any existing
timers are modified to use that value immediately
@feature
Reviewers: stefan_schmidt, bu5hm4n, raster, devilhorns, ManMower
Reviewed By: bu5hm4n, ManMower
Subscribers: ManMower, raster, bu5hm4n, cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6247
Mike Blumenkrantz [Tue, 19 Jun 2018 17:30:44 +0000 (13:30 -0400)]
eina_threadqueue: add locking for variable used between threads
Summary:
the 'first' member of this struct is used simultaneously across
threads and can have conflicting read/write operations occurring at this
time
as int operations are not guaranteed to be atomic, ensure that we are
using atomic operations or locking as necessary
@fix
Depends on D6299
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6300
Mike Blumenkrantz [Tue, 19 Jun 2018 17:30:36 +0000 (13:30 -0400)]
eina_threadqueue: simplify/unify some locking code
Summary:
this moves lock calls outside #ifdef blocks to make the code more
readable
no functional changes
Depends on D6298
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6299
Mike Blumenkrantz [Tue, 19 Jun 2018 17:30:26 +0000 (13:30 -0400)]
eina_threadqueue: fix spinlock destruction by using spinlock api
Summary:
this would deadlock in some cases
@fix
Depends on D6297
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6298
Mike Blumenkrantz [Tue, 19 Jun 2018 17:30:20 +0000 (13:30 -0400)]
eina: replace memsets in thread debugging lock create/free with manual zeroing
Summary:
memset overwrites the thread value, triggering errors when running tools like
helgrind
attempting an operation on an invalid thread will cause errors naturally,
so zeroing the rest of the struct and ignoring the thread member is fine
Reviewers: ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6297
Mike Blumenkrantz [Tue, 19 Jun 2018 17:29:16 +0000 (13:29 -0400)]
emotion_generic: clean up event handlers on fork failure
Summary:
this case would guarantee a crash if the module was ever unloaded
and the event handlers were called, and it leaks otherwise
@fix
Reviewers: ManMower, devilhorns, bu5hm4n
Reviewed By: ManMower, bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6296
Lauro Moura [Tue, 19 Jun 2018 17:28:57 +0000 (13:28 -0400)]
efl_mono: Fix call to System.Threading.Thread.
Summary: It was resolving to efl.Thread instead.
Reviewers: devilhorns, felipealmeida, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6261
Mike Blumenkrantz [Tue, 19 Jun 2018 17:28:27 +0000 (13:28 -0400)]
theme: rename non-API actionslider part to avoid confusion when reading
Summary:
no functional changes
Depends on D6211
Reviewers: cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6212
Mike Blumenkrantz [Tue, 19 Jun 2018 17:28:15 +0000 (13:28 -0400)]
elm_dayselector: fix improperly named API theme parts
Summary:
API parts require namespacing, these parts have been namespaced with
compatibility code added to handle legacy naming
Depends on D6210
Reviewers: cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6211
Mike Blumenkrantz [Tue, 19 Jun 2018 17:27:49 +0000 (13:27 -0400)]
theme: fix part namespacing in multibuttonentry theme
Summary:
this was released with improperly namespaced parts which must be maintained
for future releases, but the namespacing can be corrected for future
releases while adding aliasing to preserve compatibility
Depends on D6208
Reviewers: cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6210
Mike Blumenkrantz [Tue, 19 Jun 2018 17:27:26 +0000 (13:27 -0400)]
theme: change part in elm photo group from swallow to spacer
Summary:
this appears to be a remnant of the time before edje had spacer parts
and other part types were randomly used instead
there is no library reference to this part and it is not namespaced so
there is no reason to leave it as a (confusing) swallow
Depends on D6040
Reviewers: cedric, Hermet
Reviewed By: Hermet
Subscribers: Hermet, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6208
Mike Blumenkrantz [Tue, 19 Jun 2018 17:27:00 +0000 (13:27 -0400)]
theme: use elm namespace for spinner button signal source
Summary:
ref D6036
Depends on D6037
Reviewers: cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6040
Mike Blumenkrantz [Tue, 19 Jun 2018 17:26:28 +0000 (13:26 -0400)]
theme: rename 'sizer.content' parts to 'sizer_content'
Summary: non-api parts should avoid using '.' in the name to avoid confusion
Reviewers: cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6037
Marcel Hollerbach [Tue, 19 Jun 2018 16:31:32 +0000 (18:31 +0200)]
ecore-audio: make this a Efl_Object
sorry for the late fixup, the Ecore_Audio_Object is documented as "the
audio object" however, it is not, internally it is used as struct, thus
gdb gets confused.
Marcel Hollerbach [Tue, 19 Jun 2018 13:44:35 +0000 (15:44 +0200)]
ecore_audio: add back function that is stable
this function was removed, but should not have been removed.
Differential Revision: https://phab.enlightenment.org/D6330
Hermet Park [Tue, 19 Jun 2018 03:42:09 +0000 (12:42 +0900)]
Revert "elementary: fix wrong signal emission"
This reverts commit
1b245787fe1fc5da41b6ed77dd67cb022900afa6.
This is a workaround patch, even occurs a regression bug that
breaks widget signal emission logic. (Happened in Enventor toolbar)
I reviewed this code seriously and found out
ui_layout sub object unset logic has been changed.
Obviously that breaks the elm compatibility.
When sub-object of layout is removed, it tries to remove sub-object from
the layout internal list. Problem is, some widgets sends internal signals
when sub-object is removed(i.e "icon,hidden") , but layout returns the
valid object even though sub-object unset is called prior to signal,
means, "icon,visible" not "icon,hidden" emitted.
This logic obvisouly changed from the previous efl version.
And we need to fix that logic first.
See _efl_ui_button_legacy_efl_ui_widget_widget_sub_object_del()
to check this issue.
1. button: sub_object_del()
2. layout: sub_object_del() => sub object must be removed.
3. button: signal emit() => for updating states
4. layout: content_get() => returns valid object?????! (Issue)
Hermet Park [Tue, 19 Jun 2018 01:50:50 +0000 (10:50 +0900)]
evas map: fix a typo.
Hermet Park [Mon, 18 Jun 2018 23:35:46 +0000 (08:35 +0900)]
evas vg: add warning msgs for users.
Since usage has been changed under the beta version,
Some users may keep the old-usage that breaks the vg behavior now.
For their information, vg prints messages in case of breaks.
Bowon Ryu [Mon, 18 Jun 2018 11:29:57 +0000 (20:29 +0900)]
elm_toolbar: fix icon sizing issue
icon size * scale - this causes the issue.
this is not wrong,
but Tizen UX did not consider scale to icon size.
so, this is removed for compatibility.
@tizen_fix
Change-Id: Ib71ec1998767988bc7ad39299c3282132f8a0fd5
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Jaehyun Cho [Tue, 19 Jun 2018 06:41:49 +0000 (15:41 +0900)]
elm_slider: do not clip indicator to slider
By calling evas_object_smart_member_add(), indicator is clipped to slider.
To keep backward compatibility, indicator should not be clipped to slider.
Change-Id: I2028b5edb8b6ce911d83771480ad18f9bf803a41
Mike Blumenkrantz [Wed, 7 Feb 2018 16:50:57 +0000 (11:50 -0500)]
ecore: fix event flushing to not erase+leak events
stealing the message data here prevents events which aren't being flushed from
ever being usable again and is unnecessary since the free callback will be
automatically called during the destructor
ref
5dd52fd09b7d79c70b3134423a87aa6400a2d994
Change-Id: I981b597e42e47c5d94e6d009e241da4d7aec09d3
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Derek Foreman [Mon, 18 Jun 2018 20:12:41 +0000 (15:12 -0500)]
evas_cpu: Avoid SIGILL in evas startup on x86
Summary:
To determine if a system supports SIMD instructions, the cpuid facility
should be used. However, for 15+ years EFL has been trapping SIGILL,
then attempting to execute these intstructions.
Continuing after SIGILL is explicitly undefined behaviour and can never
safely be relied upon - it is possible the CPU will respond to the
unknown instruction in an upredictable way and the program will not
continue correctly. Even if it hasn't caused problems before, there's
no reason to believe a processor released in the future won't behave
differently.
Lately we've had a couple of bug tickets where SIGILL appears to cause
problems at a system level as well, but there seems little point in
chasing those problems down as we shouldn't even be doing this in the
first place.
ref T6711
ref T6989
We still rely on SIGILL in a few configurations where eina_cpu doesn't
know how to query features properly (powerpc, sparc, and non linux
ARM configurations). Hopefully someone with expertise on those
platforms can follow up and we can remove this entirely.
Note: MMX2 appears to not really be a thing, and is instead provided by
both 3DNow! and SSE. We already conflate it with SSE in other parts of
evas, so I've just used SSE here to test for its presence.
Depends on D6313
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T6989, T6711
Differential Revision: https://phab.enlightenment.org/D6314
Derek Foreman [Mon, 18 Jun 2018 20:12:36 +0000 (15:12 -0500)]
evas_cpu: Refactor checks that use eina_cpu_features_get
Summary: Minor code simplification.
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6313
Felipe Magno de Almeida [Mon, 18 Jun 2018 17:49:43 +0000 (14:49 -0300)]
eo: Fix internal reference count wrongly 0 when constructor returns a different object
The class's Eo constructor can return a different object, which makes
the efl_add return that object instead. However, a bug was not
initializing the internal reference count when a different object was
returned.
Marcel Hollerbach [Mon, 18 Jun 2018 13:54:26 +0000 (15:54 +0200)]
Revert "eina debug - fix segv if an app is compiled with -pg for profiling"
This reverts commit
8343de6ce3163f27257d386fb212d1eacf78ba7d.
This borke mac os build, CI is spamming on irc channels and addtional
tests are failing. I would give this back to the drawingboard.
ref T7029
Differential Revision: https://phab.enlightenment.org/D6310
Marcel Hollerbach [Mon, 18 Jun 2018 10:45:12 +0000 (12:45 +0200)]
ecore_con: fix possible segfault
with -O3 i get a segfault in this test. (with gcc and clang)
It looks like the compilers are doing constant folding because we
declared the struct as constant, however, due to using the address of
the fild the keyword const is simply not true, thus we are getting a
segfault because the address returned by &desc is not correct anymore,
due to the fact the constants are rolled out.
Differential Revision: https://phab.enlightenment.org/D6309
Mike Blumenkrantz [Tue, 12 Jun 2018 23:20:21 +0000 (19:20 -0400)]
tests: wrap critical errors to disable aborting in eo tests
ref T7002
Differential Revision: https://phab.enlightenment.org/D6271
Mike Blumenkrantz [Tue, 12 Jun 2018 22:37:15 +0000 (18:37 -0400)]
tests: disable eo test timeouts when not forked
this makes debugging much easier
Differential Revision: https://phab.enlightenment.org/D6270
Mike Blumenkrantz [Tue, 12 Jun 2018 20:57:48 +0000 (16:57 -0400)]
tests: add macros to selectively disable aborting on critical log messages
in many cases, a test will intentionally trigger an error to verify that it
is handled correctly. when the test is manually run with EINA_LOG_ABORT set,
this may cause the test to abort, preventing further debugging. by wrapping
intentional cases where critical errors are triggered, debugging tests
becomes easier
ref T7002
Differential Revision: https://phab.enlightenment.org/D6269
Carsten Haitzler (Rasterman) [Mon, 18 Jun 2018 03:05:03 +0000 (12:05 +0900)]
emotion - emotion_test - dont limit fps to 30 as this doesn't help tests
so i noticed it was jerky... to move/resize the video obj. it's
because it set fps to 30... well that was silly. didn't help chasing a
ghost, so remove this to avoid chasing hosts.
Carsten Haitzler (Rasterman) [Mon, 18 Jun 2018 02:51:21 +0000 (11:51 +0900)]
eina debug - fix segv if an app is compiled with -pg for profiling
gprof uses SIGPROF ... and this causes all sorts of bad things with
the eina debug profiling too. so - use SIGRT instead ... fixes T7028
Jihoon Kim [Sun, 17 Jun 2018 23:45:29 +0000 (08:45 +0900)]
ecore_imf: Remove security_code in autofill type
Change-Id: Ice2c20358f37ecd047b6012b8a9a619b37e211df
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Sun, 17 Jun 2018 23:45:29 +0000 (08:45 +0900)]
ecore_imf: Remove security_code in autofill type
Change-Id: I7221d1bbe311da5523151c889e71585785eead26
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jaehyun Cho [Mon, 18 Jun 2018 08:48:47 +0000 (17:48 +0900)]
elm_slider: keep backward compatibility of Tizen 3.0
This commit sets indicator hidden by default for backward compatibility.
This commit restores overwritten code of
6dae707407894f16a9bd87b62cbc087695f0e868
Change-Id: I6df50a8bdfa82c442c6e6d61c319c9a512c14d66
Juyeon Lee [Fri, 15 Jun 2018 06:39:20 +0000 (15:39 +0900)]
Revert "eocre_wl2_window: unset zxdg_surface zxdg_toplevel when hide"
This reverts commit
520034511855d67b5da9d5e63b179788d581f784.
Change-Id: I94564c39f5e8c50dcd32365fdd06fe0b33d468f6
Zbigniew Kempczyński [Sun, 17 Jun 2018 06:52:48 +0000 (15:52 +0900)]
ecore - handle G_IO_ERR conditions for net sockets
Glib integration with using of select() syscall doesn't properly
propagates G_IO_ERR condition for network sockets. Problem relies in
_ecore_glib_context_poll_to() where rewriting filedescriptor events to
GPollFD structures reside.
This fixes T5725
@fix
Daniel Zaoui [Sat, 16 Jun 2018 20:14:47 +0000 (23:14 +0300)]
efl_debugd: don't force unlinking UNIX socket before binding
If two daemons are launched one after the other, we would like the
second one to exit directly. The problem is that if the UNIX socket is
unlinked before the binding, the second daemon will succeed to create this
socket, stoling it from the first daemon, and exit because the network
socket is not bindable.
It results in the first daemon to continue running and accepting
connections from the debuggers (network connection) but ignoring the
applications connection (local UNIX connection).
Mike Blumenkrantz [Fri, 15 Jun 2018 20:34:50 +0000 (16:34 -0400)]
tests: disable toggling clouseau_enabled option in elm tests
Summary:
this option triggers codepaths which require and interface with an
external project not in the EFL tree, so it should not be tested in
the efl tree
also depending on the version of clouseau used, this causes the test
suite to fail 100% of the time
fix T6985
ref T7023
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6985, T7023
Differential Revision: https://phab.enlightenment.org/D6295
Mike Blumenkrantz [Fri, 15 Jun 2018 20:34:39 +0000 (16:34 -0400)]
eet: handle decode failures as errors in variant decoding
Summary:
all other null returns of _eet_data_descriptor_decode() are treated as
fatal errors when decoding, and failure to do so in this case guarantees
errors later due to incomplete decoding
@fix
ref T5379
Depends on D6293
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T5379
Differential Revision: https://phab.enlightenment.org/D6294
Mike Blumenkrantz [Fri, 15 Jun 2018 20:34:32 +0000 (16:34 -0400)]
eet: print errors any time an error occurs while decoding
Summary:
catching these errors was super annoying since the codebase is mostly
comprised of goto statements, so this should make future debugging easier
Depends on D6292
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6293
Mike Blumenkrantz [Fri, 15 Jun 2018 20:34:00 +0000 (16:34 -0400)]
eet: add #if 0 around macro which will cause compile errors if used
Summary:
this macro wraps a function which is also inside an #if 0 block,
so it's best not to leave it where someone might try to use it
no functional changes
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6292
Mike Blumenkrantz [Fri, 15 Jun 2018 19:38:49 +0000 (15:38 -0400)]
eina_lock: remove safety checks for main thread
Summary:
these effectively prevent locks from being used to synchronize operations
between (non-main) threads, which restricts their usefulness and also
prevents our own unit tests from passing
fix T7004
Depends on D6267
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7004, T1984
Differential Revision: https://phab.enlightenment.org/D6285
Mike Blumenkrantz [Fri, 15 Jun 2018 19:38:33 +0000 (15:38 -0400)]
eina: disable abort on shutdown when triggered by system monitoring thread
Summary:
this lock/thread never gets destroyed, so it should not trigger failure cases
when that is always the case
@fix
Depends on D6266
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6267
Mike Blumenkrantz [Fri, 15 Jun 2018 19:38:20 +0000 (15:38 -0400)]
eina_lock: remove locks from eina tracking list on free while thread debugging
Summary:
this prevents invalid memory access during subsequent inlist operations
@fix
sq
Depends on D6265
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6266
Mike Blumenkrantz [Fri, 15 Jun 2018 19:37:56 +0000 (15:37 -0400)]
eina_lock: modify mutex debugging to ignore recursive locks
Summary:
recursive locks are locked multiple times in the same thread, leading to
failure with the tracking infrastructure which was written prior to
the addition of recursive locks and assumed that locks would only be
taken exactly once
given that this debug info is meant to handle non-recursive locks,
it makes little sense to include them in the handling
@fix
Depends on D6264
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6265
Derek Foreman [Fri, 15 Jun 2018 18:18:56 +0000 (13:18 -0500)]
ecore_wl2: purge surface buffers in semi_free
Summary:
This fixes a session recovery bug with software render.
An attempt to re-use a buffer in a new wayland connection resulted
in another disconnect and broken rendering.
Depends on D6281
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6282