Ali Alzyod [Mon, 22 Jun 2020 07:54:51 +0000 (16:54 +0900)]
eina_strbuf: resolve segfault when replace used with read_only buffer
Summary: when eina_strbuf_replace is used by read_only buffer, this will cause segfault (access invalid memory)
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8757
Differential Revision: https://phab.enlightenment.org/D11989
AbdullehGhujeh [Mon, 22 Jun 2020 07:31:53 +0000 (16:31 +0900)]
Textblock : Fix cursor cluster movement when emoji at the line start
Summary:
if we have emoji only or emoji at line start we can move cursor using mouse click to be inside the emoji.
{
F3868502}
this should fix T8664
Test Plan:
#include <Elementary.h>
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("emoji-test", "emoji-test");
elm_win_autodel_set(win, EINA_TRUE);
/* and now just resize the window to a size you want. normally widgets
* will determine the initial size though */
evas_object_resize(win, 320, 320);
Evas_Object *box;
box = elm_box_add(win);
evas_object_size_hint_weight_set(box, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(box, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_win_resize_object_add(win, box);
Evas_Object *entry;
entry = elm_entry_add(box);
elm_entry_entry_set(entry, "☪️");
evas_object_size_hint_weight_set(entry, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(entry, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_box_pack_end(box, entry);
evas_object_show(entry);
evas_object_show(box);
/* and show the window */
evas_object_show(win);
elm_run(); /* and run the program now, starting to handle all
* events, etc. */
/* exit code */
return 0;
}
ELM_MAIN()
Reviewers: ali.alzyod, woohyun, bowonryu, zmike, bu5hm4n
Reviewed By: ali.alzyod
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8664
Differential Revision: https://phab.enlightenment.org/D11732
Myoungwoon Roy, Kim [Tue, 23 Jun 2020 08:29:35 +0000 (17:29 +0900)]
docs: Changes non public Tizen APIs in API reference to internal
Change-Id: I579e1af8a8006391bdb51fc63873ddb794cd7792
Shinwoo Kim [Tue, 23 Jun 2020 07:31:09 +0000 (16:31 +0900)]
ecore_wl2: update documentation
This patch is following doxygen rule.
*tizen_fix
Change-Id: I4d638465af923cad13de4d8110f286380c0efc51
Shinwoo Kim [Fri, 5 Jun 2020 02:48:59 +0000 (11:48 +0900)]
ecore_wl2: sync between UI and video
There is a requirement to sync of geometry changes such as move
and resize between UI and video. EFL could not take care of the
video geometry becasue it is handled by separated process.
This patch makes it possible by using a subsurface.
The video process will use the subsurface and surface commits
on this subsurface will be cached and only applied when the
parent surface's state is applied. In this case the parent
surface is working for UI.
*tizen_only
Change-Id: I287cb7bf7858ea5e3efc7f2bd32ce6279896586f
Shinwoo Kim [Fri, 19 Jun 2020 07:07:06 +0000 (16:07 +0900)]
elm_scroller: use region of proxy soruce for loop
Summary:
If size of elm_sclloer content is too big, then the proxy of
elm_scroller to show loop effect does not work. Because
evas_gl_common_image_surface_new does not allow
bigger size surface than max_texture_size.
Reviewers: Hermet, jsuya, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11996
Change-Id: I7c0e83e70f0ac11a413cc4ae0dd05fc35678ef80
Shinwoo Kim [Fri, 19 Jun 2020 05:08:23 +0000 (14:08 +0900)]
Revert "ui scroller: fix broken scroller loop"
This reverts commit
036423307c7eafec904d650a71ef64dac646151a.
The commit 76b89b8 "evas proxy: use part of source" was reverted.
So we need to revert "ui scroller: fix broken scroller loop" to
avoid build break.
New commit using evas_object_image_load_region_set will handle.
Change-Id: Ibed05025c028555dc490f7b0bdd707c104b17943
Shinwoo Kim [Fri, 19 Jun 2020 03:14:16 +0000 (12:14 +0900)]
Revert "evas proxy: use part of source"
This reverts commit
76b89b8e49f4b16ad490c04134a9bdddea27950f.
The commit was for fix an issue quickly.
Now we are able to rever the commit because
evas_object_image_load_region_set is available.
New commit using evas_object_image_load_region_set is comming.
Change-Id: I5f8cf04f92065db22342521b9102e6d26d5121d6
Boris Faure [Sat, 20 Jun 2020 10:37:56 +0000 (11:37 +0100)]
eina_unicode: have explicit type conversions
Summary:
Found by running terminology's tests with UBSAN:
include/eina-1/eina/eina_inline_unicode.x:
runtime error: implicit conversion from type 'char' of value
-62 (8-bit, signed) to type 'unsigned char' changed the value to 194
(8-bit, unsigned)
Reviewers: #reviewers, vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11972
Carsten Haitzler (Rasterman) [Thu, 18 Jun 2020 23:56:08 +0000 (00:56 +0100)]
efreet caceh - fix coverity report
fix CID 1429935
Vincent Torri [Thu, 18 Jun 2020 13:35:46 +0000 (14:35 +0100)]
meson: add Solaris support
Summary: Add Solaris support for meson
Test Plan: test on OpenIndiana
Reviewers: raster, bu5hm4n, stefan_schmidt
Reviewed By: raster, stefan_schmidt
Subscribers: alarcher, stefan_schmidt, bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11973
Vincent Torri [Tue, 16 Jun 2020 21:47:43 +0000 (21:47 +0000)]
tests: eina: fix ENOMEM message on Windows and solaris
On Windows and solaris the string associated to ENOMEM is "Not enough space"
Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11983
Carsten Haitzler (Rasterman) [Thu, 18 Jun 2020 10:35:44 +0000 (11:35 +0100)]
efreet - mtime 0 fix build on windows
Carsten Haitzler (Rasterman) [Thu, 18 Jun 2020 10:03:02 +0000 (11:03 +0100)]
efreetd - cache - add more statinfo work around 0 mtime distros
some distros 9notably in this case nixos) want to do reproducible
builds. to them this means going around setting mtime for all files to
0. this means efreetd not only thinks mtime is invalid/stupid (0 is
generally just that as midnight on jan 1 1970 is not exactly a
sensible dare for a modified timestamp of a file as no filesystem with
any sanity will have not been modified since that time), but it keeps
mtime at 0 even when things update. this totally breaks efreetd that
expects to find mtime increases over time as things change. it's
necessary because it has to perform a "are mu caches up to date" scan
of all file data it caches and it needs to know if it should rebuild
something based on this.
so this does a few things:
1. it makes mtime have to be an exact match to the cache, not cache
mtime >= file mtime. so any change forward or back is an inavlidation.
2. it now also uses ctime, mode, size, uid, gid, block count and if a
symlink, the sha1 of the symlink path in addition and any change to
these == invalid.
this adds a lot of code and changes how dirs get scanned a bit but it
means it can pick up changes on these 0 mtime distros.
interestingly the policy of mtime being 0 is to have a reprodcible fs
... but ctime still changes and is > 0, as does inode info, so it's
not actually possible to have it totally work... but they try still,
so this is a fix for that problem.
whilst i was doing thisi also noticed efreetd re-red dirs many times
due to icon theme inhritance. i also fixed that to do a LOT less
syscalls by only scanning a dir once as i was rejigging the scanning
code at the time anyway. this should optimize thr scan costs at
efreetd startup too.
@fix
@opt
Artur Świgoń [Mon, 23 Mar 2020 11:33:52 +0000 (12:33 +0100)]
Revert "Revert "eldbus: change to idle_enterer from idler""
This reverts commit
2bcc7b48bf2f34a19b0712b030ab143d09dc30fb.
Handling DBus messages during idle carries the risk of starving the DBus
communication (and making the UI unresponsive if screen reader is used). This
is well-explained in the original (reverted) upstream commit: "If an
application does not give idle time, then the eldbus cannot have chance to
work."
Change-Id: Iffde1be749f5dba1ac1e8642c4ce4e3436770b5a
Stefan Schmidt [Tue, 9 Jun 2020 12:22:19 +0000 (14:22 +0200)]
benchmarks: eina: make sure we do not divide by zero
Make sure we do not divide by i if it is zero here.
CID: 1400768
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11956
Stefan Schmidt [Wed, 10 Jun 2020 10:30:48 +0000 (12:30 +0200)]
tests: eio: make sure we check return value
Make sure we fail the test if the call does not succeed.
CID: 1412364
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11963
Carsten Haitzler (Rasterman) [Wed, 17 Jun 2020 11:30:23 +0000 (12:30 +0100)]
evas gl common - remove comment - not valid anymore
Carsten Haitzler (Rasterman) [Wed, 17 Jun 2020 11:17:13 +0000 (12:17 +0100)]
gl common - actually allow vertex limits
fix non-commented out return that should have been commented out
Marcel Hollerbach [Wed, 17 Jun 2020 07:13:05 +0000 (09:13 +0200)]
efl_ui_widget: addition to the previous commit
in the previous commit we started to only receive the parent_obj from
the evas object when its not a widget. However, we still need to ensure
that the parent is equal to the current one in order to remove it when a
widget.
While this is one more call, the call to get the parent is not as
heavy as the data_get call, as this directly addresses a struct, and
does not read from a hash table.
This also fixes a test case failure.
Subhransu Mohanty [Wed, 17 Jun 2020 06:28:44 +0000 (06:28 +0000)]
elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls.
in genlist testcase the number of calls reduced by 30000.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Hermet Park <<hermetpark@gmail.com>>
Reviewed-by: Youngbok Shin <youngb.shin@samsung.com>
Differential Revision: https://phab.enlightenment.org/D11984
Subhransu Mohanty [Wed, 17 Jun 2020 06:36:02 +0000 (06:36 +0000)]
elementary/perf:remove unnecessary elm_widget_is() check
As we always make sure the parent is a widget class we don't have to check anymore.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Hermet Park <<hermetpark@gmail.com>>
Differential Revision: https://phab.enlightenment.org/D11985
Taehyub Kim [Wed, 17 Jun 2020 12:17:23 +0000 (21:17 +0900)]
elm_image: remove the spaces and keep the indentation for elm_image_file_set()
Summary: there are wrong indentation in the elm_image_file_set, so removed the tabs
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11988
Change-Id: I797d0861fff02a8b49aacc748cec9c7238926441
Taehyub Kim [Wed, 17 Jun 2020 12:04:08 +0000 (21:04 +0900)]
elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice
Summary:
when trying to set file using url path twice, the second api call's return value is EINA_FALSE
since image obj has already has same file path. After applying Efl.File interface, the behavior is changed compared to before.
both of the return values should be EINA_TRUE.
@fix
ex)
Eina_Bool ret1, ret2;
ret1 = elm_image_file_set(image, "http://sameurl/image.jpg", NULL);
ret2 = elm_image_file_set(image, "http://sameurl/image.jpg", NULL);
ret1 and ret2 should be EINA_TURE
Test Plan:
1. call elm_image_file_set api with same url path
2. see the return value
Reviewers: Hermet, kimcinoo, jsuya
Reviewed By: Hermet
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11979
Change-Id: If64d8d58424b559ea07dba14efb36996484c2fd5
Taehyub Kim [Tue, 16 Jun 2020 12:16:40 +0000 (21:16 +0900)]
efl.spec: enable WebP Animation Feature
libwebp-1.1.0 library is included in the binary after tizen_unified_20200528.2
WebP Animation can be enabeld now.
Change-Id: I20b17049f7caca332a1af7ceb5c4e32e252bdaa5
Stefan Schmidt [Tue, 16 Jun 2020 09:03:26 +0000 (11:03 +0200)]
modules: eina: chained_pool: check for NULL before passing it to deref
Make sure we check if pool->first_fill is NULL before passing it onwards
where it gets dereferenced. In case this happens return NULL instead of
garbage.
CID: 1293520
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11980
Stefan Schmidt [Tue, 16 Jun 2020 14:19:04 +0000 (16:19 +0200)]
Revert "ci: travis: disable the webp loader on CI builds for now"
This reverts commit
29c491b977543e9ef86147604ab3a297ece18327.
We went back to a much older version which should be available on all
our CI test systems. Safe to enable again.
Jaehyun Cho [Tue, 16 Jun 2020 11:40:59 +0000 (20:40 +0900)]
evas_object_table: fix not to use hint_fill on elm_table
Summary:
The hint_fill logic in evas_object_table was designed to be used for
Efl.Ui.Table not for elm_table.
Since Efl.Ui.Table does not use evas_object_table logic, hint_fill logic
in evas_object_table is removed.
Reviewers: YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11982
Change-Id: Ide4fe092d9eeee4120596bae3dc3cb2eab2a1da5
Woochanlee [Mon, 15 Jun 2020 09:55:45 +0000 (18:55 +0900)]
efl : Fix build warnings.
Change-Id: I0777c22ad7784beee94646cf17420e41b0e798e8
JunsuChoi [Tue, 16 Jun 2020 04:10:25 +0000 (13:10 +0900)]
Efl.Canvas.Vg.Object: Fix wrong render area
Summary:
When determining the size of the ector buffer,
it was used the smaller of the object's geometry or path_bounds.
However, because of that, path worked as absolute coordinates.
path_bounds should be relative to geometry of object.
Test Plan:
{
F3900444}
original
{
F3900445}
before
+ evas_object_geometry_set(vg, 100, 100, 200, 200);
{
F3900447}
after
+ evas_object_geometry_set(vg, 100, 100, 200, 200);
{
F3900448}
Reviewers: Hermet, kimcinoo, herb, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11974
Change-Id: Id190aeb88735be0b9cbb5f60879c6a8a63eb33e7
Hosang Kim [Mon, 15 Jun 2020 10:41:03 +0000 (19:41 +0900)]
doxygen: remove unsupported links to preview images
Change-Id: I936462469e6713268fb8a41e0d10f77b4c78a424
Stefan Schmidt [Mon, 15 Jun 2020 11:20:07 +0000 (13:20 +0200)]
tests: edje: check result of evas_engine_info_set()
Make sure we check the result of evas_engine_info_set and only continue
if it succeeds.
CID: 1401077
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11978
Stefan Schmidt [Mon, 15 Jun 2020 10:48:37 +0000 (12:48 +0200)]
modules: gl_x11: ensure we check the result of evas_eglMakeCurrent()
In case we fail make sure we error out to allow better debugging.
Also fix some surrounding indent.
CID: 1402693, 1402670
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11976
Kamil Konieczny [Fri, 12 Jun 2020 13:37:50 +0000 (15:37 +0200)]
elm_atspi_bridge: call _elm_win_atspi only once
Change-Id: I843c37646f60dfad985db66ee49838a68c239c25
Kamil Konieczny [Fri, 12 Jun 2020 13:18:54 +0000 (15:18 +0200)]
efl_ui_win_socket: fix socket_proxy release
socket_proxy was created with efl_add method, so use efl_del
instead of efl_unref for object release.
Change-Id: I81a470f1acc8d803aa1146dd0d6b8a1663c797ec
Kamil Konieczny [Fri, 12 Jun 2020 13:30:16 +0000 (15:30 +0200)]
elm_atspi_bridge: fix memory leak
Fix memory leak on error path.
Change-Id: I314f200ec20f2f0810d15ed1b6ae9fec1597e775
Carsten Haitzler (Rasterman) [Sun, 14 Jun 2020 00:09:04 +0000 (01:09 +0100)]
webp - 0.5.0 is actually new enough
webp anim apis came out in 0.5.0 not 1.1.0 :)
Daniel Kolesa [Fri, 12 Jun 2020 16:46:33 +0000 (18:46 +0200)]
evas/engines/gl_generic: fix byte order after glReadPixels on BE
This fixes the screenshot tool in Enlightenment on big endian
systems besides other things.
Stefan Schmidt [Fri, 12 Jun 2020 14:03:48 +0000 (16:03 +0200)]
meson_options: really fix the typo
Sigh, check your patch, even if it appears to be tiny.
Stefan Schmidt [Fri, 12 Jun 2020 14:02:43 +0000 (16:02 +0200)]
meson_options: fix typo in option description
Stefan Schmidt [Fri, 12 Jun 2020 11:25:01 +0000 (13:25 +0200)]
modules: vnc: allow building for FreeBSD with a different header path
Original patch provided by phyb user CeDeROM.
Fixes T8713
Stefan Schmidt [Fri, 12 Jun 2020 07:32:39 +0000 (09:32 +0200)]
build: decrease the minimal needed meson verion to 0.50
When we jumped from 0.47 to 0.52 to fix problems some users have been
seeing when building we might jumped a bit to far. We want a good
balance between stable and fast building but also mature enough to be in
distro releases and widely available.
We will try to settle for a middle-ground with 0.50 here. If that causes
problems for you building please let us know instantly.
WooHyun Jung [Fri, 12 Jun 2020 07:57:45 +0000 (16:57 +0900)]
efl_ui_win: reuse bg which was created for version check
Summary: This is just for not creating bg object twice.
Reviewers: bu5hm4n, zmike, YOhoho
Reviewed By: YOhoho
Subscribers: YOhoho, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11936
Change-Id: I548a3f12a728d90212d47c110b2d1904b3d472b7
Hermet Park [Fri, 12 Jun 2020 07:33:21 +0000 (16:33 +0900)]
ui image: fix a missing else case.
it sholud be turned on enabled status.
it's side issue by
0826b4916efb0bce20a353cece56e84d05fb406c
Change-Id: I84b06594fda8694f865c74db4bdabfda505665c3
Taehyub Kim [Fri, 12 Jun 2020 07:14:56 +0000 (16:14 +0900)]
efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set
Summary:
when elm_image_preload_disabled_set(img, EINA_TRUE) is called before file set.
The image preload is not canceled, because the function will be returned since the image is not loaded.
so preload disabled api is fixed to work even if it is called before file set.
@fix
Reviewers: Hermet, kimcinoo, jsuya
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11969
Change-Id: I72e559314dbe494bbcf1dddf91f309ff8772780c
Stefan Schmidt [Thu, 11 Jun 2020 11:35:52 +0000 (13:35 +0200)]
tests: elm: check return of efl_config_bool_set
Make sure we fail the test, unless this settign succeed.
CID: 1403891
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11968
Daniel Kolesa [Thu, 11 Jun 2020 13:14:03 +0000 (15:14 +0200)]
modules: only build gl_drm evas engine when using es-egl
This module does not work with desktop opengl contexts,
and needs EGL to work.
Jaehyun Cho [Thu, 11 Jun 2020 09:57:30 +0000 (18:57 +0900)]
edje_cc_handlers: update documentation of "fixed" to be clearer
Summary:
Since "fixed" does not affect the group size by the part's min size, the
documentation is updated to be clearer.
Reviewers: woohyun, raster
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11934
Woochanlee [Thu, 11 Jun 2020 07:34:16 +0000 (16:34 +0900)]
elm_calendar: Do not pass NULL to function.
Summary:
T7076
legacy calendar inc/dec button has auto repeat feature.
for that if user click the button very quickly, we delete internal timer than it will pass to function.
to prevent this, need to check NULL pointer.
Reviewers: devilhorns, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11966
Daniel Kolesa [Thu, 11 Jun 2020 00:32:07 +0000 (02:32 +0200)]
ecore: use standard LC_ALL instead of __LC_ALL in systemd module
The former is a POSIX name, the latter is non-standard. I don't
know why the latter was used, considering glibc literally has
just #define LC_ALL __LC_ALL, but change it and unbreak build
on musl and other systems.
Daniel Kolesa [Thu, 11 Jun 2020 00:18:50 +0000 (02:18 +0200)]
eina: only enable EINA_LOG_BACKTRACE when backtrace API is present
This prevents build breakage on platforms that either don't have
backtrace() or don't have the appropriate library for it installed.
Hermet Park [Thu, 11 Jun 2020 07:10:36 +0000 (16:10 +0900)]
evas glengine: fix code sync after migration.
Introduced a wrong result after upstream migration,
since we have tizen only code diff....
Change-Id: Ia4bac99a244a63a1d54c63dd93aea80c5a0bfce0
Carsten Haitzler (Rasterman) [Wed, 10 Jun 2020 18:30:14 +0000 (19:30 +0100)]
efl - build again - test suite break in using undefined ERR macro
Stefan Schmidt [Tue, 9 Jun 2020 13:21:28 +0000 (15:21 +0200)]
tests: eina: make sure we always check on eina_matrixsparse_data_idx_get return
It has been checked in all other places, but has been forgotten in these
two.
CID: 1401081
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11960
Stefan Schmidt [Tue, 9 Jun 2020 13:09:08 +0000 (15:09 +0200)]
tests: eo: handle error return of eina_value_int_convert()
CID: 1400962
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11958
Stefan Schmidt [Tue, 9 Jun 2020 12:04:31 +0000 (14:04 +0200)]
tests: eina: also handle failure cases when cleaning up created files/folders
Somethign fishy is going on if we can not delete the files and folders
we created.
CID: 1400986
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11955
Stefan Schmidt [Wed, 10 Jun 2020 12:12:59 +0000 (14:12 +0200)]
ecore_drm: check return of drmModeSetCrtc()
Report if we fail to reset the Crtc during output free. Only print an
error and keep going with the rest of the output free.
CID: 1402668
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11965
Christopher Michael [Wed, 10 Jun 2020 12:38:02 +0000 (08:38 -0400)]
tests/ecore_wl2: Fix unchecked return value
Coverity reports that we do not check the return of eglInitialize
here.
Fixes Coverity CID1412362
Christopher Michael [Wed, 10 Jun 2020 12:32:40 +0000 (08:32 -0400)]
tests/ecore_wl2: Fix unchecked return value
Coverity reports eglChooseConfig is called without checking return
value here. This patch fixes the issue by checking the return value
and by also making _init_egl return a bool so that we can fail the
test if eglChooseConfig results in failure.
Fixes Coverity CID1412365
Christopher Michael [Wed, 10 Jun 2020 12:26:29 +0000 (08:26 -0400)]
ecore_wl2_tests: Fix formatting
Stefan Schmidt [Tue, 9 Jun 2020 13:17:36 +0000 (15:17 +0200)]
tests: eina: check return of eina_module_load and unload
These could fail as well. Check in testsuite.
CID: 1400961
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11959
Stefan Schmidt [Tue, 9 Jun 2020 12:29:35 +0000 (14:29 +0200)]
tests: evas: check fd being non -1 before using close()
eina_file_mkstemp would return -1 in an error case. Make sure we check
the return when clsoing here.
CID: 1400790
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11957
Vincent Torri [Wed, 10 Jun 2020 05:07:47 +0000 (05:07 +0000)]
Use extern after EAPI
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11961
Hermet Park [Wed, 10 Jun 2020 11:30:19 +0000 (20:30 +0900)]
evas stack: ++safe code.
null check to prevent any crashes (just in case)
Change-Id: Ic77a2c785feba9be32eb1460439f4c3315087e07
Hermet Park [Wed, 10 Jun 2020 06:49:49 +0000 (15:49 +0900)]
ui textpath: updated doc.
Change-Id: I562734a64b5ad8f371c1952a996a80f54a05e0c7
Taehyub Kim [Wed, 10 Jun 2020 06:39:03 +0000 (15:39 +0900)]
efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style
Summary:
For the text style customizing, added the new API to apply user text style.
The following example is the user style sample.
DEFAULT='font_size=16 color=#F00 underline=on underline_color=#00ffff'";
{
F3899541}
Test Plan:
1. run elementary_text (textpath)
2. toggle user style check box
3. see the result
Reviewers: Hermet, kimcinoo, jsuya, bu5hm4n
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11953
Change-Id: Ia3a182aebadcad24383c3021e358d4e40e5e9515
Marcel Hollerbach [Tue, 9 Jun 2020 10:09:25 +0000 (12:09 +0200)]
mono: update window construction
they simply missed parameters here
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11954
Stefan Schmidt [Tue, 9 Jun 2020 07:11:52 +0000 (09:11 +0200)]
ci: travis: disable the webp loader on CI builds for now
With the bump of the needed libwebp version to 1.1.0 we have have our
Debian and Ubuntu builds failing with a to old version. Disable by
default in CI for now and check back later.
Carsten Haitzler (Rasterman) [Tue, 9 Jun 2020 09:13:04 +0000 (10:13 +0100)]
efreet - handle runtime relocation right with default XDG_DATA_DIRS
XDG_DATA_DIRS was only set up to a default including where efl was
installed prefix-wise as the compiled-=in prefix, not runtime
determined prefix. it shouldn't actually affect most people except
those making use of this.
@fix
Carsten Haitzler (Rasterman) [Sun, 7 Jun 2020 00:33:43 +0000 (01:33 +0100)]
eina - prefix - use smaller buffers for building strings
use less stack space but no features as buffers are big enough for all
content used or alloca'd now.
Carsten Haitzler (Rasterman) [Sun, 7 Jun 2020 00:28:18 +0000 (01:28 +0100)]
eina - abstratc content - smaller stack buffer for limited size string
no need for a 4k buffer when 128 bytes will be plenty - short string.
Marcel Hollerbach [Sat, 18 Apr 2020 17:43:11 +0000 (19:43 +0200)]
efl_ui_win: declare constructors not optional
they cannot be optional, or in later languages types will collide.
Differential Revision: https://phab.enlightenment.org/D11741
Felipe Magno de Almeida [Mon, 8 Jun 2020 21:05:49 +0000 (18:05 -0300)]
cxx: Fix uses of intrinsic eolian binbuf type
Add special binbuf and Eina_Strbuf conversions
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11950
Marcel Hollerbach [Sun, 19 Apr 2020 13:14:12 +0000 (15:14 +0200)]
eo-files: convert all Eina.Strbuf & Eina.Binbuf
these structs should not be used, but rather the builtin types that
exist for it.
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11742
Felipe Magno de Almeida [Mon, 8 Jun 2020 21:32:22 +0000 (18:32 -0300)]
dotnet: Ignore Efl.Object.parent as constructor
In C# we already have Efl.Object.parent as an implicit constructor. Ignore it if it is marked as a constructor.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11951
Marcel Hollerbach [Sun, 19 Apr 2020 19:34:17 +0000 (21:34 +0200)]
eo: make the parent a optional constructor
this is needed in order to sanely bind parent calls to some objejcts,
but not all.
However, from the canvas structure up we *need* a parent, so we can
fetch the evas from it. So declare it there a none optional
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11734
Stefan Schmidt [Tue, 9 Jun 2020 07:43:57 +0000 (09:43 +0200)]
Revert "ci: disable wepb loader until we have a change to update the mingw cross env"
This reverts commit
63b1334e2c98f0c0f08801ce77d66f372e7abb30.
No longer needed as we have updated the mingw image to have 1.1.0
available.
JunsuChoi [Tue, 9 Jun 2020 01:57:20 +0000 (10:57 +0900)]
evas_vg_cache: Don't caching vg file if value_provider is applied.
Summary:
value_provider can change the value of the property received from VG file.
When a file is cached, the changed properties are applied to all other objects using the same file.
So. If value provider is applied, evas_vg_cache is not caching vg file.
Test Plan: N/A
Reviewers: Hermet, herb, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11924
Ali Alzyod [Tue, 9 Jun 2020 01:25:10 +0000 (10:25 +0900)]
evas_common_font: release reallocated glyphs bitmaps data
Reviewers: woohyun, smohanty
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8743
Differential Revision: https://phab.enlightenment.org/D11945
Myoungwoon Roy, Kim [Tue, 9 Jun 2020 05:08:11 +0000 (14:08 +0900)]
doxygen docs: Fix API reference group to Ecore_Eo and eina_vector
Change-Id: Ic20831f0db719f935dbf4e7421c70f7c4cdbd5cb
Subhransu Mohanty [Mon, 8 Jun 2020 11:28:14 +0000 (20:28 +0900)]
elementary/example: Fix memory leak in gengrid test
Reviewers: Hermet, SanghyeonLee
Reviewed By: Hermet, SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11928
Subhransu Mohanty [Mon, 8 Jun 2020 11:27:42 +0000 (20:27 +0900)]
ecore_ipc: Fix memory leak
Summary:
As delete_me flag was not updated in the delete callback it dosen't
call ecore_ipc_client_del() on the client hence the leak.
Reviewers: Hermet, raster, bu5hm4n, CHAN
Reviewed By: Hermet, CHAN
Subscribers: CHAN, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11927
Hermet Park [Mon, 8 Jun 2020 10:46:31 +0000 (19:46 +0900)]
canvas gl: remove out-dated compiler keywords
Stefan Schmidt [Thu, 4 Jun 2020 10:52:07 +0000 (12:52 +0200)]
exactness: record and print test time on success
Having the runtime of a test is interesting for debugging and
optimization. Printing them only on success for now.
Differential Revision: https://phab.enlightenment.org/D11935
Stefan Schmidt [Tue, 2 Jun 2020 14:03:00 +0000 (16:03 +0200)]
ci: travis: add more fold and timing markers in some forgotten places
In teh initial patch we forgot some interesting places we also want to
fold and get timing info on. Dependency installation, cross native build
step, coverity tools download and codecov run.
Differential Revision: https://phab.enlightenment.org/D11938
Stefan Schmidt [Thu, 4 Jun 2020 13:19:47 +0000 (15:19 +0200)]
ci: simplify ccache setup handling
We no longer need the special case for release ready. This was needed
for the way autotools setup directories, which we no longer use. (We are
not having a config.log anymore)
Differential Revision: https://phab.enlightenment.org/D11937
Stefan Schmidt [Mon, 8 Jun 2020 07:10:51 +0000 (09:10 +0200)]
ci: disable wepb loader until we have a change to update the mingw cross env
We now need webp 1.1.0 and our current mingw cross env only has 1.0.2.
Disable to keep CI working while we update.
WooHyun Jung [Mon, 8 Jun 2020 02:03:07 +0000 (11:03 +0900)]
webp: add version check in configuration time
Reviewers: Hermet, herb, bu5hm4n, stefan_schmidt
Reviewed By: stefan_schmidt
Subscribers: stefan_schmidt, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11926
Hermet Park [Mon, 8 Jun 2020 02:00:26 +0000 (11:00 +0900)]
eldbus: fix the data size issue.
Summary:
dbus message requires the void* value for the message data,
the returned value of dbus_message_iter_get_basic() can be mismatched by to the architure,
This could bring the returned va_argues memory corrupted among the series of values.
We can use the defined type for exceptions.
Reviewers: herb, kimcinoo, jsuya, raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11940
Carsten Haitzler (Rasterman) [Tue, 2 Jun 2020 10:39:06 +0000 (11:39 +0100)]
evas gl - tune gl engine to use a bit less cpu overhead
we have used a fair bit of cpu to avoid gpu overhead and this tunes
the balance back a bit to throwing more at the gpu and less at the cpu
by reducing the number of pipes and max vertex counts per pipe by
default and only resetting pipe state vars if adding the first pipe
member.
@opt
Change-Id: Id102255c532ec7d116ca9a4d45f18ad69cde3829
Hermet Park [Mon, 8 Jun 2020 05:00:04 +0000 (14:00 +0900)]
ui scroller: fix broken scroller loop
image is streched since proxy fill/region size is mismatched
this is a regression bug introduced by
76b89b8e49f4b16ad490c04134a9bdddea27950f
Change-Id: I1eb4de61e6a5e080a2f350de30cb76d1db575429
Daniel Kolesa [Sat, 6 Jun 2020 21:29:23 +0000 (23:29 +0200)]
ci: drop lua from default binding set as elua is off by default
Daniel Kolesa [Sat, 6 Jun 2020 17:09:21 +0000 (19:09 +0200)]
build: disable elua by default, plus nicer detection
Elua is now disabled by default. There are some other changes:
1) Elua scripts are only installed if Elua is enabled
2) Lua bindings are only installed if Elua is enabled
3) Elua with interpreter is clearly experimental and will message
Stefan Schmidt [Fri, 24 Apr 2020 07:35:31 +0000 (09:35 +0200)]
emotion: remove all left overs from removed backends
We removed them in the last release. Make sure we cleanup all the
references and dead code still belonging to it.
Extra note on the Emotion_Module enum removal. While it was exposed in
the public Emotion.h header it is never used anywhere in the code and
has no purpose, thus it can safely be removed.
Reviewed-by: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Differential Revision: https://phab.enlightenment.org/D11941
Marcel Hollerbach [Thu, 4 Jun 2020 08:23:29 +0000 (10:23 +0200)]
build: do not publish surface .eo files
they are privat, they should never be installed.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11933
Marcel Hollerbach [Thu, 4 Jun 2020 08:03:44 +0000 (10:03 +0200)]
evas: correctly declare filter_internal as public API
I know this is internal. However it is public used in public .eo files.
Even if it is internal, and beta, we still need to expose the API in
order to have it correctly in the .so.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11932
Bowon Ryu [Fri, 5 Jun 2020 05:26:22 +0000 (14:26 +0900)]
edje: markup flag should be TRUE in legacy edje_object_part_text_set
Summary:
Through some APIs (elm_entry_editable_set, elm_entry_single_line_set, etc.)
located after edje_object_part_text_set(legacy)
If efl_ui_widget_theme_apply is called,
In edje_object_part_text_raw_generic_set, the legacy flag becomes FALSE.
And in this case, the logic works in the unintended direction
because the set_markup flag is FALSE.
Test Plan:
/*
gcc -o entry_example entry.c `pkg-config --cflags --libs elementary`
*/
#include <Elementary.h>
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win, *en;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("entry-example", "test");
elm_win_autodel_set(win, EINA_TRUE);
en = elm_entry_add(win);
evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
elm_object_part_text_set(en, "elm.guide", "<font_size=32 color=#FFF>TEST</font_size>");
elm_entry_editable_set(en, EINA_FALSE);
evas_object_show(en);
elm_object_content_set(win, en);
evas_object_resize(win, 300, 200);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
Reviewers: woohyun, ali.alzyod
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11868
Carsten Haitzler (Rasterman) [Thu, 4 Jun 2020 19:25:46 +0000 (20:25 +0100)]
evas - genetic update regions smart merge - merge v adjacent regions
regions sometimes produce box sets like:
// +---+
// | |
// +---+ +-------+
// | | | |
// +---+ +-------+---------+
// | |
// | |
// +-----------------+
so the upper-left 2 boxes can be merged into 1 and they have the same
x coords and are flush-aligned one above the other. that is what
this does - find these and merge them to have fewer rects
@fix
Carsten Haitzler (Rasterman) [Thu, 4 Jun 2020 19:23:13 +0000 (20:23 +0100)]
evas render - add debug to draw boxes around update regions
helps debug update regions to see if there is too much overdraw or too
many regions. i smelled too manhy and this showed it. i was right. fix
for too many regions coming next
Carsten Haitzler (Rasterman) [Thu, 4 Jun 2020 19:22:03 +0000 (20:22 +0100)]
tiler - add maxreg for newtiler - not used atm but matches current