platform/upstream/gstreamer.git
11 years agovaapisink: add "use-glx" property for OpenGL rendering.
Gwenole Beauchesne [Thu, 27 Jun 2013 11:53:46 +0000 (13:53 +0200)]
vaapisink: add "use-glx" property for OpenGL rendering.

Now that VA/GLX capable buffers are generated by default on X11, thus
depending on a VA/GLX display, we stil want to use vaPutSurface() for
rendering since it is faster.

Anyway, OpenGL rendering in vaapisink was only meant for testing and
enabling "fancy" effects to play with. This has no real value. So,
disable OpenGL rendering by default.

11 years agoplugins: try to allocate a GLX display first over an X11 one.
Víctor Manuel Jáquez Leal [Thu, 6 Jun 2013 09:36:03 +0000 (05:36 -0400)]
plugins: try to allocate a GLX display first over an X11 one.

If the gstreamer-vaapi plug-in elements are built with GLX support, then
try to allocate a GstVaapiDisplayGLX first before resorting to a VA/X11
display next.

https://bugzilla.gnome.org/show_bug.cgi?id=701742

11 years agoconfigure: use GST_PLUGIN_PATH_1_0 instead of GST_PLUGIN_PATH for Gst 1.0.
Lionel Landwerlin [Thu, 25 Apr 2013 16:07:13 +0000 (17:07 +0100)]
configure: use GST_PLUGIN_PATH_1_0 instead of GST_PLUGIN_PATH for Gst 1.0.

jhbuild sets $GST_PLUGIN_PATH_1_0 which overrides $GST_PLUGIN_PATH.

https://bugzilla.gnome.org/show_bug.cgi?id=698858

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
11 years agoimage: fix wrong check for rect bounds in copy_image().
Wind Yuan [Sat, 27 Apr 2013 07:15:49 +0000 (15:15 +0800)]
image: fix wrong check for rect bounds in copy_image().

11 years agoBump version for development.
Gwenole Beauchesne [Fri, 14 Jun 2013 11:41:14 +0000 (13:41 +0200)]
Bump version for development.

11 years ago0.5.4.
Gwenole Beauchesne [Fri, 14 Jun 2013 09:47:50 +0000 (11:47 +0200)]
0.5.4.

11 years agoNEWS: updates.
Gwenole Beauchesne [Fri, 14 Jun 2013 09:43:46 +0000 (11:43 +0200)]
NEWS: updates.

11 years agoconfigure: always build the MPEG-4 parser.
Gwenole Beauchesne [Fri, 14 Jun 2013 09:39:54 +0000 (11:39 +0200)]
configure: always build the MPEG-4 parser.

Always build the MPEG-4 parser for now as there are also core fixes
included in the parser that cannot be tested for with API checks.

11 years agoconfigure: add --enable-builtin-codecparsers [default="yes"] option.
Gwenole Beauchesne [Fri, 14 Jun 2013 09:32:36 +0000 (11:32 +0200)]
configure: add --enable-builtin-codecparsers [default="yes"] option.

Add flag to have all codecparsers built-in, thus ensuring that the
resulting binaries have all the necessary bug fixes and this is what
the QA has been testing anyway.

Of course, for a completely up-to-date Linux distribution, you could
also opt for --disable-builtin-codecparsers and use the system ones.
Though, some core fixes could be missing, and those cannot be tested
for with API checks.

11 years agocodecparsers: update to gst-vaapi-branch commit 843ce3e.
Gwenole Beauchesne [Fri, 14 Jun 2013 09:14:23 +0000 (11:14 +0200)]
codecparsers: update to gst-vaapi-branch commit 843ce3e.

843ce3e jpeg: fix default Huffman tables generation.
8655187 mpeg2: fix the pixel-aspect-ratio calculation
21099dc mpeg2: actually store video bitrate values
dd02087 mpeg2: fix picture packet extension size check
25948e9 mpeg2: increase min size for picture coding ext
f1f5a40 ensure the debug category is properly initialized

11 years agodebian: fix list of generated files for .deb packaging.
Gwenole Beauchesne [Wed, 12 Jun 2013 13:16:17 +0000 (14:16 +0100)]
debian: fix list of generated files for .deb packaging.

11 years agodebian: fix libgstvaapi -dev package name.
Gwenole Beauchesne [Wed, 12 Jun 2013 12:48:26 +0000 (13:48 +0100)]
debian: fix libgstvaapi -dev package name.

Fix libgstvaapi -dev package name so that to allow installation of both
GStreamer 0.10 and 1.0.x based packages.

11 years agoNEWS: updates.
Gwenole Beauchesne [Wed, 5 Jun 2013 15:42:00 +0000 (17:42 +0200)]
NEWS: updates.

11 years agowayland: fix memory leak of display resources.
Gwenole Beauchesne [Fri, 31 May 2013 09:09:40 +0000 (11:09 +0200)]
wayland: fix memory leak of display resources.

11 years agovaapisink: fix build without VA/GLX support.
Zhao Halley [Mon, 3 Jun 2013 23:14:22 +0000 (07:14 +0800)]
vaapisink: fix build without VA/GLX support.

11 years agoplugins: allow buffer mappings to GstVaapiSurfaceProxy.
Gwenole Beauchesne [Wed, 5 Jun 2013 09:01:51 +0000 (11:01 +0200)]
plugins: allow buffer mappings to GstVaapiSurfaceProxy.

Allow plain gst_buffer_map() interface to work with gstreamer-vaapi
video buffers, i.e. expose the underlying GstVaapiSurfaceProxy to the
caller. This is the only sensible enough thing to do in this mode as
the underlying surface pixels need to be extracted through an explicit
call to the gst_video_frame_map() function instead.

A possible use-case of this is to implement a "handoff" signal handler
to fakesink or identity element for further processing.

11 years agoplugins: silence check for direct-rendering mode in video memory.
Gwenole Beauchesne [Mon, 3 Jun 2013 08:22:44 +0000 (10:22 +0200)]
plugins: silence check for direct-rendering mode in video memory.

Fix gst_vaapi_video_allocator_new() to silently check for direct-rendering
mode support, and not trigger fatal-criticals if either test surface or
image could not be created. Typical case: pixel format mismatch, e.g. NV12
supported by most hardware vs. I420 supported by most software decoders.

11 years agoplugins: improve video memory flags safety checks.
Gwenole Beauchesne [Mon, 3 Jun 2013 08:06:29 +0000 (10:06 +0200)]
plugins: improve video memory flags safety checks.

On map, ensure we have GST_MAP_WRITE flags since this is only what we
support for now. Likewise, on unmap, make sure that the VA image is
unmapped for either read or write, while still committing it to the
VA surface if write was requested.

11 years agosurface: fix memory leak through unreleased parent context.
Gwenole Beauchesne [Thu, 30 May 2013 16:17:07 +0000 (18:17 +0200)]
surface: fix memory leak through unreleased parent context.

Break the circular references between GstVaapiContext and its children
GstVaapiSurfaces. Since the VA surfaces held an extra reference to the
context, which holds a reference to its VA surfaces, then none of those
were released.

How does this impact support for subpictures?

The only situation when the parent context needs to disappear is when
it is replaced with another one because of a resolution change in the
video stream for instance, or a normal destroy. In this case, it does
not really matter to apply subpictures to the peer surfaces since they
are either gone, or those that are left in the pipe can probably bear
a reinstantiation of the subpictures for it.

So, parent_context is set to NULL when the parent context is destroyed,
other VA surfaces can still get subpictures attached to them, individually
not as a whole. i.e. subpictures for surface S1 will be created from
active composition buffers and associated to S1, subpictures for S2 will
be created from the next active composition buffers, etc. We don't try
to cache the subpictures in those cases (pending surfaces until EOS
is reached, or pending surfaces until new surfaces matching new VA context
get to be used instead).

11 years agovaapisink: fix one-time initialization when display property is set.
Gwenole Beauchesne [Mon, 27 May 2013 12:01:48 +0000 (14:01 +0200)]
vaapisink: fix one-time initialization when display property is set.

Fix gst_vaapisink_ensure_display() to perform one-time initialization
tasks even if the `display' property was explicitly set.

11 years agowindow: fix GLX window initialization.
Gwenole Beauchesne [Mon, 27 May 2013 13:59:08 +0000 (15:59 +0200)]
window: fix GLX window initialization.

Make sure to create the GLX context once the window object has completed
its creation. Since gl_resize() relies on the newly created window size,
then we cannot simply overload the GstVaapiWindowClass::create() hook.
So, we just call into gst_vaapi_window_glx_ensure_context() once the
window object is created in the gst_vaapi_window_glx_new*() functions.

11 years agodisplay: validate display types.
Gwenole Beauchesne [Mon, 27 May 2013 15:18:40 +0000 (17:18 +0200)]
display: validate display types.

11 years agodisplay: drop internal NAME_PREFIX, store the real display name.
Gwenole Beauchesne [Mon, 27 May 2013 14:13:33 +0000 (16:13 +0200)]
display: drop internal NAME_PREFIX, store the real display name.

Always store a valid display name/device path, instead of adding a
particular prefix. i.e. make it simply a strdup(), or "" if it was
initially NULL.

11 years agodisplay: make it possible to lookup the display cache by type.
Gwenole Beauchesne [Mon, 27 May 2013 11:17:31 +0000 (13:17 +0200)]
display: make it possible to lookup the display cache by type.

Make it possible to add extra an extra filter to most of display cache
lookup functions so that the GstVaapiDisplay instance can really match
a compatible and existing display by type, instead of relying on extra
string tags (e.g. "X11:" prefix, etc.).

11 years agodisplay: cope with new display cache API.
Gwenole Beauchesne [Fri, 24 May 2013 14:19:23 +0000 (16:19 +0200)]
display: cope with new display cache API.

11 years agodisplay: rework display cache API.
Gwenole Beauchesne [Fri, 24 May 2013 14:12:01 +0000 (16:12 +0200)]
display: rework display cache API.

Simplify display cache API, while making it more flexible. We can now create
custom lookup functions with gst_vaapi_display_cache_lookup_custom().

11 years agotests: improve check for display cache.
Gwenole Beauchesne [Fri, 24 May 2013 13:05:45 +0000 (15:05 +0200)]
tests: improve check for display cache.

Improve check for display cache infrastructure. In particular, for X11 and
GLX backends, we need to make sure that we can create a GstVaapiDisplayX11
from another GstVaapiDisplayGLX, i.e. underlying X11 and VA displays can be
shared. Besides, allocating a GstVaapiDisplayGLX while a GstVaapiDisplayX11
already exists will have to generate different VA displays.

11 years agouploader: fix memory leak in GStreamer 0.10 builds.
Zhao Halley [Wed, 15 May 2013 02:33:16 +0000 (10:33 +0800)]
uploader: fix memory leak in GStreamer 0.10 builds.

In GStreamer 0.10 builds, gst_vaapi_uploader_get_buffer() was used
but it exhibited a memory leak because the surface generated for the
GstVaapiVideoMeta totally lost its parent video pool. So, it was not
possible to release that surface back to the parent pool when the meta
gets released, and the memory consumption kept growing.

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
11 years agoplugins: fix gst_vaapi_video_meta_new_from_pool().
Gwenole Beauchesne [Thu, 23 May 2013 16:56:43 +0000 (18:56 +0200)]
plugins: fix gst_vaapi_video_meta_new_from_pool().

Since GST_VAAPI_IS_xxx_VIDEO_POOL() was only testing for NULL and not
the underlying object type, the gst_vaapi_video_meta_new_from_pool()
was hereby totally broken. Fixed this regression by using the newly
provided gst_vaapi_video_pool_get_object_type() function.

11 years agoplugins: cope with GST_VAAPI_IS_xxx() macros removal.
Gwenole Beauchesne [Thu, 23 May 2013 16:22:50 +0000 (18:22 +0200)]
plugins: cope with GST_VAAPI_IS_xxx() macros removal.

11 years agotests: cope with GST_VAAPI_IS_xxx() macros removal.
Gwenole Beauchesne [Thu, 23 May 2013 16:19:24 +0000 (18:19 +0200)]
tests: cope with GST_VAAPI_IS_xxx() macros removal.

11 years agolibs: add query for GstVaapiVideoPool object types.
Gwenole Beauchesne [Thu, 23 May 2013 16:45:23 +0000 (18:45 +0200)]
libs: add query for GstVaapiVideoPool object types.

Add API to identify the underlying GstVaapiVideoPool object type.

11 years agolibs: drop GST_VAAPI_IS_xxx() helper macros.
Gwenole Beauchesne [Thu, 23 May 2013 16:15:48 +0000 (18:15 +0200)]
libs: drop GST_VAAPI_IS_xxx() helper macros.

Drop obsolete GST_VAAPI_IS_xxx() helper macros since we are no longer
deriving from GObject and so those were only checking for whether the
argument was NULL or not. This is now irrelevant, and even confusing
to some extent, because we no longer have type checking.

Note: this incurs more type checking (review) but the libgstvaapi is
rather small, so this is manageable.

11 years agoBump library major version.
Gwenole Beauchesne [Tue, 7 May 2013 16:52:28 +0000 (18:52 +0200)]
Bump library major version.

The whole libgstvaapi libraries got a major refresh to get rid of GObject.
This is a fundamental change that requires a new SONAME. More changes are
underway to streamline the core libraries.

So far, the net result is a reduction of .text size (code) by 32KB, i.e. -10%.
On one particular test (sintel HD trailer), the total number of executed
instruction was reduced by 8%.

11 years agodocs: cope with removed APIs.
Gwenole Beauchesne [Tue, 7 May 2013 16:37:24 +0000 (18:37 +0200)]
docs: cope with removed APIs.

Some APIs are dead because they are no longer based on GObject.

11 years agoplugins: cope with new GstVaapiMiniObject objects.
Gwenole Beauchesne [Mon, 6 May 2013 12:43:38 +0000 (14:43 +0200)]
plugins: cope with new GstVaapiMiniObject objects.

11 years agotests: cope with new GstVaapiMiniObject objects.
Gwenole Beauchesne [Tue, 7 May 2013 09:45:10 +0000 (11:45 +0200)]
tests: cope with new GstVaapiMiniObject objects.

11 years agodisplay: fix set_synchronous() to lock display.
Gwenole Beauchesne [Tue, 7 May 2013 13:38:51 +0000 (15:38 +0200)]
display: fix set_synchronous() to lock display.

11 years agovideopool: simplify creation of video objects pool.
Gwenole Beauchesne [Fri, 3 May 2013 17:02:23 +0000 (19:02 +0200)]
videopool: simplify creation of video objects pool.

11 years agolibs: simplify GstVaapiID definitions.
Gwenole Beauchesne [Tue, 7 May 2013 16:17:10 +0000 (18:17 +0200)]
libs: simplify GstVaapiID definitions.

Make GstVaapiID a gsize instead of guessing an underlying integer large
enough to hold all bits of a pointer. Also drop GST_VAAPI_ID_NONE since
this is plain zero and that it is no longer passed as varargs.

11 years agolibs: drop obsolete function helpers and objects.
Gwenole Beauchesne [Thu, 2 May 2013 14:11:53 +0000 (16:11 +0200)]
libs: drop obsolete function helpers and objects.

Drop obsolete GstVaapiID related function helpers for passing them as
GValues.

11 years agolibs: use GstVaapiMiniObject for display objects.
Gwenole Beauchesne [Tue, 7 May 2013 09:39:34 +0000 (11:39 +0200)]
libs: use GstVaapiMiniObject for display objects.

11 years agolibs: use GstVaapiMiniObject for video decoders.
Gwenole Beauchesne [Mon, 6 May 2013 12:07:17 +0000 (14:07 +0200)]
libs: use GstVaapiMiniObject for video decoders.

Port GstVaapiDecoder and GstVaapiDecoder{MPEG2,MPEG4,JPEG,H264,VC1} to
GstVaapiMiniObject. Add gst_vaapi_decoder_set_codec_state_changed_func()
helper function to let the user add a callback to a function triggered
whenever the codec state (e.g. caps) changes.

11 years agolibs: use GstVaapiMiniObject for video object pools.
Gwenole Beauchesne [Fri, 3 May 2013 09:01:12 +0000 (11:01 +0200)]
libs: use GstVaapiMiniObject for video object pools.

Port GstVaapiVideoPool, GstVaapiSurfacePool and GstVaapiImagePool to
GstVaapiMiniObject. Drop gst_vaapi_video_pool_get_caps() since it was
no longer used for a long time. Make object allocators static, i.e.
local to the shared library.

11 years agolibs: use GstVaapiObject for texture objects.
Gwenole Beauchesne [Tue, 30 Apr 2013 15:22:00 +0000 (17:22 +0200)]
libs: use GstVaapiObject for texture objects.

11 years agolibs: use GstVaapiObject for window objects.
Gwenole Beauchesne [Tue, 30 Apr 2013 15:20:14 +0000 (17:20 +0200)]
libs: use GstVaapiObject for window objects.

11 years agolibs: use GstVaapiObject for VA objects.
Gwenole Beauchesne [Tue, 30 Apr 2013 15:22:15 +0000 (17:22 +0200)]
libs: use GstVaapiObject for VA objects.

11 years agoPort GstVaapiObject to GstVaapiMiniObject.
Gwenole Beauchesne [Tue, 30 Apr 2013 15:20:46 +0000 (17:20 +0200)]
Port GstVaapiObject to GstVaapiMiniObject.

11 years agolibs: refine GstVaapiMiniObject.
Gwenole Beauchesne [Tue, 30 Apr 2013 08:28:30 +0000 (10:28 +0200)]
libs: refine GstVaapiMiniObject.

Drop support for user-defined data since this capability was not used
so far and GstVaapiMiniObject represents the smallest reference counted
object type. Add missing GST_VAAPI_MINI_OBJECT_CLASS() helper macro.

Besides, since GstVaapiMiniObject is a libgstvaapi internal object, it
is also possible to further simplify the layout of the object. i.e. merge
GstVaapiMiniObjectBase into GstVaapiMiniObject.

11 years agodecoder: update picture size from the bitstream.
Gwenole Beauchesne [Tue, 7 May 2013 14:43:51 +0000 (16:43 +0200)]
decoder: update picture size from the bitstream.

Propagate the picture size from the bitstream to the GstVaapiDecoder,
and subsequent user who installed a signal on notify::caps. This fixes
decoding of TS streams when the demuxer failed to extract the required
information.

11 years agodecoder: fix raw decoding mode.
Gwenole Beauchesne [Thu, 25 Apr 2013 12:16:01 +0000 (14:16 +0200)]
decoder: fix raw decoding mode.

Fix gst_vaapi_decoder_get_surface() to actually transfer ownership of the
surface proxy to the caller.

11 years agodecoder: add gst_vaapi_decoder_get_frame_with_timeout().
Gwenole Beauchesne [Thu, 25 Apr 2013 11:56:18 +0000 (13:56 +0200)]
decoder: add gst_vaapi_decoder_get_frame_with_timeout().

Add gst_vaapi_decoder_get_frame_with_timeout() helper function that will
wait for a frame to be decoded, until the specified timeout in microseconds,
prior to returning to the caller.

This is a fix to performance regression from 851cc0, whereby the vaapidecode
loop executed on the srcpad task was called to often, thus starving all CPU
resources.

11 years agoBump version for development.
Gwenole Beauchesne [Fri, 19 Apr 2013 12:38:59 +0000 (14:38 +0200)]
Bump version for development.

11 years ago0.5.3.
Gwenole Beauchesne [Thu, 18 Apr 2013 17:09:45 +0000 (19:09 +0200)]
0.5.3.

11 years agoNEWS: updates.
Gwenole Beauchesne [Thu, 18 Apr 2013 17:08:39 +0000 (19:08 +0200)]
NEWS: updates.

11 years agovaapidecode: rework heuristics to detect decode timeout.
Gwenole Beauchesne [Thu, 18 Apr 2013 13:55:26 +0000 (15:55 +0200)]
vaapidecode: rework heuristics to detect decode timeout.

Rework heuristics to detect when downstream element ran into errors,
and thus failing to release any VA surface in due time for the current
frame to get decoded. In particular, recalibrate the render time base
when the first frame gets submitted downstream, or when there is no
timestamp that could be inferred.

11 years agovaapidecode: rework GstVideoDecoder::handle_frame() with a task.
Gwenole Beauchesne [Thu, 18 Apr 2013 13:50:02 +0000 (15:50 +0200)]
vaapidecode: rework GstVideoDecoder::handle_frame() with a task.

Rework GstVideoDecoder::handle_frame() to decode the current frame,
while possibly waiting for a free surface, and separately submit all
decoded frames from a task. This makes it possible to pop and render
decoded frames as soon as possible.

11 years agoplugins: use gst_object_unref() wherever applicable.
Gwenole Beauchesne [Thu, 18 Apr 2013 08:06:15 +0000 (10:06 +0200)]
plugins: use gst_object_unref() wherever applicable.

Use gst_object_unref() wherever applicable, e.g. objects derived from
GstElement, GstVideoPool, etc.

11 years agodocs: drop obsolete plug-ins.
Gwenole Beauchesne [Wed, 17 Apr 2013 12:21:16 +0000 (14:21 +0200)]
docs: drop obsolete plug-ins.

Drop documentation for obsolete plug-ins, even for GStreamer 0.10.
i.e. vaapiupload and vaapidownload are no longer the recommended
plug-ins to use.

11 years agodebian: fix build of GStreamer 0.10 packages.
Gwenole Beauchesne [Wed, 17 Apr 2013 11:17:26 +0000 (13:17 +0200)]
debian: fix build of GStreamer 0.10 packages.

Fix build of Debian packages to scan the actual GStreamer API version
from the generated changelog file.

11 years agovaapipostproc: minor clean-ups.
Gwenole Beauchesne [Wed, 17 Apr 2013 08:58:04 +0000 (10:58 +0200)]
vaapipostproc: minor clean-ups.

Use g_clear_object() wherever appropriate and remove dead-code.

11 years agovaapipostproc: fix reference counting buf for passthrough mode.
Gwenole Beauchesne [Wed, 17 Apr 2013 08:53:03 +0000 (10:53 +0200)]
vaapipostproc: fix reference counting buf for passthrough mode.

Fix reference counting bug for passthrough mode, whereby the input buffer
was propagated as is downstream through gst_pad_push() without increasing
its reference count before. The was a problem when gst_pad_push() returns
an error and we further decrease the reference count of the input buffer.

11 years agovaapipostproc: port to GStreamer 1.0.
Gwenole Beauchesne [Wed, 17 Apr 2013 08:18:45 +0000 (10:18 +0200)]
vaapipostproc: port to GStreamer 1.0.

Add support for interlaced streams with GStreamer 1.0 too. Basically,
this enables vaapipostproc, though it is not auto-plugged yet. We also
make sure to reply to CAPS queries, and happily handle CAPS events.

11 years agodecoder: fix GstVideoCodecFrame flags for interlaced contents.
Gwenole Beauchesne [Wed, 17 Apr 2013 08:14:55 +0000 (10:14 +0200)]
decoder: fix GstVideoCodecFrame flags for interlaced contents.

Fix support for interlaced contents with GStreamer 0.10. In particular,
propagate GstVaapiSurfaceProxy frame flags to GstVideoCodecFrame flags
correctly.

This is a regression from commit 87e5717.

11 years agodecoder: rename GstVaapiDecoderFrame to GstVaapiParserFrame.
Gwenole Beauchesne [Tue, 16 Apr 2013 11:23:41 +0000 (13:23 +0200)]
decoder: rename GstVaapiDecoderFrame to GstVaapiParserFrame.

Rename GstVaapiDecoderFrame to GstVaapiParserFrame because this data
structure was only useful to parsing and a proper GstvaapiDecoderFrame
instance will be created instead.

11 years agodecoder: export presentation timestamp for raw decoding mode.
Gwenole Beauchesne [Tue, 16 Apr 2013 17:09:30 +0000 (19:09 +0200)]
decoder: export presentation timestamp for raw decoding mode.

Fix regression from 0.4-branch whereby GstVaapiSurfaceProxy no longer
held any information about the expected presentation timestamp, frame
duration or additional flags like interlaced or top-field-first.

11 years agodecoder: use new GstVaapiSurfaceProxy utility functions.
Gwenole Beauchesne [Tue, 16 Apr 2013 16:56:24 +0000 (18:56 +0200)]
decoder: use new GstVaapiSurfaceProxy utility functions.

Use new GstVaapiSurfaceProxy internal helper functions to propagate the
necessary GstVideoCodecFrame flags to vaapidecode (GStreamer 0.10).

Also make GstVaapiDecoder push_frame() operate similarly to drop_frame().
i.e. increase the GstVideoCodecFrame reference count in push_frame rather
than gst_vaapi_picture_output().

11 years agosurfaceproxy: add more attributes for raw decoding modes.
Gwenole Beauchesne [Tue, 16 Apr 2013 16:35:48 +0000 (18:35 +0200)]
surfaceproxy: add more attributes for raw decoding modes.

Add more attributes for raw decoding modes, i.e. directly through the
libgstvaapi helper library. In particular, add presentation timestamp,
duration and a couple of flags (interlaced, TFF, RFF, one-field).

11 years agosurfaceproxy: drop user-data support from GstVaapiSurfaceProxy.
Gwenole Beauchesne [Tue, 16 Apr 2013 11:48:00 +0000 (13:48 +0200)]
surfaceproxy: drop user-data support from GstVaapiSurfaceProxy.

Drop user-data support from GstVaapiSurfaceProxy. Rather make it explicit
to call some user-provided function when the surface proxy is released.

11 years agobuild: link libgstvaapi-glx-1.0.so against libdl.
Víctor Manuel Jáquez Leal [Mon, 15 Apr 2013 08:52:51 +0000 (12:52 +0400)]
build: link libgstvaapi-glx-1.0.so against libdl.

Ensure libgstvaapi-glx*.so builds against libdl since dlsym() is used
to resolve glXGetProcAddress() from GLX libraries. This fix builds on
Fedora 17.

https://bugzilla.gnome.org/show_bug.cgi?id=698046

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
11 years agodecoder: fix gst_vaapi_decoder_get_codec_state().
Gwenole Beauchesne [Mon, 15 Apr 2013 12:22:57 +0000 (14:22 +0200)]
decoder: fix gst_vaapi_decoder_get_codec_state().

Fix previous commit whereby gst_vaapi_decoder_get_codec_state() was
supposed to make GstVaapiDecoder own the return GstVideoCodecState
object. Only comment was updated, not the actual code.

11 years agodecoder: make gst_vaapi_decoder_get_codec_state() return the original state.
Gwenole Beauchesne [Mon, 15 Apr 2013 11:58:58 +0000 (13:58 +0200)]
decoder: make gst_vaapi_decoder_get_codec_state() return the original state.

Make gst_vaapi_decoder_get_codec_state() return the original codec state,
i.e. make the GstVaapiDecoder object own the return state so that callers
that want an extra reference to it would just gst_video_codec_state_ref()
it before usage. This aligns the behaviour with what we had before with
gst_vaapi_decoder_get_caps().

This is an ABI incompatible change, library major version was bumped from
previous release (0.5.2).

11 years agoplugins: mark a few more functions as internal.
Gwenole Beauchesne [Mon, 15 Apr 2013 11:52:19 +0000 (13:52 +0200)]
plugins: mark a few more functions as internal.

Mark the following functions are internal, i.e. private to the vaapi plug-in:
- gst_vaapi_video_buffer_pool_get_type()
- gst_vaapi_video_converter_glx_get_type()
- gst_vaapi_video_converter_glx_new()

11 years agoplugins: implement GstSurfaceMeta API.
Gwenole Beauchesne [Mon, 15 Apr 2013 11:48:43 +0000 (13:48 +0200)]
plugins: implement GstSurfaceMeta API.

Implement GstSurfaceMeta API for GStreamer 1.0.x. Even though this is
an unstable/deprecated API, this makes it possible to support Clutter
sink with minimal changes. Tested against clutter-gst 1.9.92.

11 years agovaapisink: optimize GstVideoOverlayInterface::expose().
Gwenole Beauchesne [Fri, 12 Apr 2013 15:12:43 +0000 (17:12 +0200)]
vaapisink: optimize GstVideoOverlayInterface::expose().

When render-mode is "overlay", then it is not really useful to peek into
the GstBaseSink::last_buffer, since we have our own video_buffer already
recorded and maintained into GstVaapiSink.

11 years agovaapisink: fix memory leak of GstSample objects.
Gwenole Beauchesne [Fri, 12 Apr 2013 15:05:06 +0000 (17:05 +0200)]
vaapisink: fix memory leak of GstSample objects.

Fix memory leak of GstSample objects in GstVideoOverlayInterface::expose().
This also fixes extra unreferencing of the underlying GstBuffer in the common
path afterwards (for both 0.10 or 1.0).

11 years agoplugins: fix description for gst-inspect.
Gwenole Beauchesne [Fri, 12 Apr 2013 11:44:52 +0000 (13:44 +0200)]
plugins: fix description for gst-inspect.

Fix the name of the plug-in element reported to gst-inspect-1.0. i.e. we
need an explicit definition for GStreamer >= 1.0 because the GST_PLUGIN_DEFINE
incorrectly uses #name for creating the plug-in name, instead of using macro
expansion (and let further expansion of macros) through e.g. G_STRINGIFY().

11 years agoREADME: updates.
Gwenole Beauchesne [Thu, 11 Apr 2013 07:24:44 +0000 (09:24 +0200)]
README: updates.

Update build requirements for GStreamer 1.0.x support. Add section for
ways to report bugs.

11 years agoNEWS: updates.
Gwenole Beauchesne [Wed, 10 Apr 2013 14:54:01 +0000 (16:54 +0200)]
NEWS: updates.

11 years agoFix make dist to include all source files, in any case.
Gwenole Beauchesne [Wed, 10 Apr 2013 13:31:41 +0000 (15:31 +0200)]
Fix make dist to include all source files, in any case.

Fix make dist to allow build for either GStreamer 0.10 or 1.0. i.e. make
sure to include all source files in either case while generating source
tarballs.

11 years agoBump library major version.
Gwenole Beauchesne [Wed, 10 Apr 2013 13:21:57 +0000 (15:21 +0200)]
Bump library major version.

Bump library major version, while preserving a major version of 0 for
GStreamer 1.0 based libraries, and a major version of 2 for GStreamer
0.10 based librarieS.

11 years agoplugins: implement direct-rendering mode for raw YUV buffer uploads.
Gwenole Beauchesne [Wed, 10 Apr 2013 12:37:42 +0000 (14:37 +0200)]
plugins: implement direct-rendering mode for raw YUV buffer uploads.

Allow direct-rendering (writes) into target VA surfaces.

11 years agoplugins: implement uploads from raw YUV buffers for GStreamer 1.0.
Gwenole Beauchesne [Tue, 9 Apr 2013 14:02:06 +0000 (16:02 +0200)]
plugins: implement uploads from raw YUV buffers for GStreamer 1.0.

Implement GstVideoMeta::{,un}map() to support raw YUV buffer upload when
the last component is unmapped. Downloads are not supported yet. The aim
was to first support SW decoding + HW accelerated rendering (vaapisink).
e.g. for Wayland.

11 years agovaapidecode: submit all decoded frames before decoding a new one.
Gwenole Beauchesne [Wed, 3 Apr 2013 09:10:41 +0000 (11:10 +0200)]
vaapidecode: submit all decoded frames before decoding a new one.

Make sure to purge all pending frames that were already decoded prior
to decoding a new one. This helps release VA surfaces as early as
possible.

11 years agovaapidecode: reply to CAPS queries.
Gwenole Beauchesne [Tue, 2 Apr 2013 14:12:16 +0000 (16:12 +0200)]
vaapidecode: reply to CAPS queries.

Handle GST_QUERY_CAPS, which is the GStreamer 1.0 mechanism to retrieve
the set of allowed caps, i.e. it works similar to GstPad::get_caps().

This fixes fallback to SW decoding if no HW decoder is available.

11 years agodecoder: fix unpaired GstBuffer map/unmaps.
Gwenole Beauchesne [Wed, 20 Mar 2013 10:26:38 +0000 (11:26 +0100)]
decoder: fix unpaired GstBuffer map/unmaps.

This possibly fixes a few memory leaks along the way.

11 years agoAllow build against either GStreamer API (0.10 or 1.0).
Gwenole Beauchesne [Wed, 20 Mar 2013 13:40:57 +0000 (14:40 +0100)]
Allow build against either GStreamer API (0.10 or 1.0).

Introduce a new configure option --with-gstreamer-api that determines
the desired GStreamer API to use. By default, GStreamer 1.0 is selected.
Also integrate more compatibility glue into gstcompat.h and plugins.

11 years agoplugins: use new video buffer pools.
Sreerenj Balachandran [Thu, 8 Nov 2012 14:41:22 +0000 (16:41 +0200)]
plugins: use new video buffer pools.

Use new GstVaapiVideoBufferPool to maintain video buffers. Implement
GstBaseSink::propose_allocation() to expose that pool to upstream
elements; and also implement GstVideoDecoder::decide_allocation() to
actually use that pool (from downstream), if any, or create one.

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
11 years agoplugins: add GstVaapiVideoMemory and GstVaapiVideoBufferPool objects.
Sreerenj Balachandran [Thu, 8 Nov 2012 14:41:22 +0000 (16:41 +0200)]
plugins: add GstVaapiVideoMemory and GstVaapiVideoBufferPool objects.

Add initial support for GstVaapiVideoMemory backed buffer pool. The memory
object currently holds a reference to GstVaapiVideoMeta.

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
11 years agoplugins: allow copies of GstVaapiVideoMeta objects.
Gwenole Beauchesne [Thu, 4 Apr 2013 15:36:45 +0000 (17:36 +0200)]
plugins: allow copies of GstVaapiVideoMeta objects.

Make it possible to copy GstVaapiVideoMeta objects, unless they contain VA
objects created from GstVaapiVideoPool. This is mostly useful to clone a
GstVaapiVideoMeta object containing a VA surface proxy so that to alter its
rendering flags.

11 years agoplugins: make it possible to clear VA objects from GstVaapiVideoMeta.
Gwenole Beauchesne [Thu, 4 Apr 2013 14:16:31 +0000 (16:16 +0200)]
plugins: make it possible to clear VA objects from GstVaapiVideoMeta.

Fix GstVaapiVideoMeta to allow VA objects to be destroyed when they are
reset to NULL. i.e. make gst_vaapi_video_meta_set_{image,surface}() and
gst_vaapi_video_meta_set_surface_proxy() actually clear VA objects when
argument is NULL.

11 years agoplugins: initial port to GStreamer 1.0.
Sreerenj Balachandran [Mon, 3 Sep 2012 11:00:25 +0000 (14:00 +0300)]
plugins: initial port to GStreamer 1.0.

Port vaapidecode and vaapisink plugins to GStreamer API >= 1.0. This
is rather minimalistic so that to test the basic functionality.

Disable vaapiupload, vaapidownload and vaapipostproc plugins. The latter
needs polishing wrt. to GStreamer 1.x functionality and the former are
totally phased out in favor of GstVaapiVideoMemory map/unmap facilities,
which are yet to be implemented.

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
11 years agotests: add support for GStreamer 1.0.
Gwenole Beauchesne [Thu, 21 Mar 2013 09:12:09 +0000 (10:12 +0100)]
tests: add support for GStreamer 1.0.

11 years agoAdd initial support for GStreamer 1.0.
Sreerenj Balachandran [Tue, 4 Sep 2012 12:12:18 +0000 (15:12 +0300)]
Add initial support for GStreamer 1.0.

This integrates support for GStreamer API >= 1.0 only in the libgstvaapi
core decoding library. The changes are kept rather minimal here so that
the library retains as little dependency as possible on core GStreamer
functionality.

Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
11 years agovaapisink: improve check for raw YUV format mode.
Gwenole Beauchesne [Wed, 3 Apr 2013 13:58:57 +0000 (15:58 +0200)]
vaapisink: improve check for raw YUV format mode.

Improve check for raw YUV format modes by avoiding checks against strings
("video/x-raw-yuv") for each new GstBuffer allocation. In the usual case,
GstBaseSink::set_caps() is called first and if VA surface format mode is
used, then GstBaseSink::buffer_alloc() is not called. If the latter is
called before set_caps(), then we just make a full check. This one is
pretty rare though, e.g. it usually happens once for custom pipelines.

11 years agoplugins: don't fail if there is no overlay composition to apply.
Gwenole Beauchesne [Wed, 3 Apr 2013 13:06:46 +0000 (15:06 +0200)]
plugins: don't fail if there is no overlay composition to apply.

Fix gst_vaapi_apply_composition() to not fail if no overlay composition
was found. i.e. return success (TRUE). This was harmless though extra
debug messages are not nice.

This is a regression introduced by commit 95b8659.

11 years agovaapidecode: expose the exact set of supported HW decoders.
Gwenole Beauchesne [Wed, 3 Apr 2013 12:59:33 +0000 (14:59 +0200)]
vaapidecode: expose the exact set of supported HW decoders.

Don't return static caps that don't mean anything for the underlying codecs
that are actually supported for decoding. i.e. always allocate a VA display
and retrieve the exact set of HW decoders available. That VA display may be
re-used later on during negotiation through GstVideoContext "prepare-context".

This fixes fallback to SW decoding if no HW decoder is available.

11 years agodecoder: drop obsolete functions.
Gwenole Beauchesne [Wed, 3 Apr 2013 11:08:55 +0000 (13:08 +0200)]
decoder: drop obsolete functions.

Drop the following functions that are now obsolete:
- gst_vaapi_context_get_surface()
- gst_vaapi_context_put_surface()
- gst_vaapi_context_find_surface_by_id()
- gst_vaapi_surface_proxy_new()
- gst_vaapi_surface_proxy_get_context()
- gst_vaapi_surface_proxy_set_context()
- gst_vaapi_surface_proxy_set_surface()

This is an API change.

11 years agodecoder: delegate surface size check to VA context reset.
Gwenole Beauchesne [Wed, 3 Apr 2013 11:14:59 +0000 (13:14 +0200)]
decoder: delegate surface size check to VA context reset.

Now that the surface pool is reference counted in the surface proxy wrapper,
we can safely ignore surface size checks in gst_vaapi_decoder_ensure_context().
Besides, this check is already performed in gst_vaapi_context_reset_full().

11 years agodecoder: simplify acquisition/release of spare surface.
Gwenole Beauchesne [Wed, 3 Apr 2013 09:37:44 +0000 (11:37 +0200)]
decoder: simplify acquisition/release of spare surface.

Introduce gst_vaapi_surface_proxy_new_from_pool() to allocate a new surface
proxy from the context surface pool. This change also makes sure to retain
the parent surface pool in the proxy.

Besides, it was also totally useless to attach/detach parent context to
VA surface each time we acquire/release it. Since the whole context owns
all associated VA surfaces, we can mark this as such only once and for all.