Behdad Esfahbod [Fri, 12 Oct 2018 00:15:00 +0000 (20:15 -0400)]
[graphite] Remove assert
Behdad Esfahbod [Thu, 11 Oct 2018 23:39:07 +0000 (19:39 -0400)]
Minor
Behdad Esfahbod [Thu, 11 Oct 2018 23:24:52 +0000 (19:24 -0400)]
[test] Add test for USE indic3
Behdad Esfahbod [Thu, 11 Oct 2018 23:23:36 +0000 (19:23 -0400)]
Minor
Behdad Esfahbod [Thu, 11 Oct 2018 21:51:21 +0000 (17:51 -0400)]
Pass indic3 tags to USE shaper
Fixes https://github.com/harfbuzz/harfbuzz/issues/539
David Corbett [Thu, 11 Oct 2018 21:15:22 +0000 (17:15 -0400)]
Parse Indic3 tags
Behdad Esfahbod [Thu, 11 Oct 2018 21:31:29 +0000 (17:31 -0400)]
Remove remains of get-codepoint-fuzzer
Behdad Esfahbod [Thu, 11 Oct 2018 21:08:12 +0000 (17:08 -0400)]
[fuzzing] Fold get-codepoints-fuzzer into subset-fuzzer
Behdad Esfahbod [Thu, 11 Oct 2018 20:41:01 +0000 (16:41 -0400)]
[aat] Fix two wrongs that made a right before!
Unfortunately our static asserts (DEFINE_SIZE_STATIC) don't actually
fail when used in templates, thanks to SFINAE. Le sighs.
Probably fixes https://oss-fuzz.com/v2/testcase-detail/
5740171484463104
Behdad Esfahbod [Thu, 11 Oct 2018 19:56:17 +0000 (15:56 -0400)]
[aat] Fix mul overflow
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10897
Behdad Esfahbod [Thu, 11 Oct 2018 19:42:54 +0000 (15:42 -0400)]
Minor
Behdad Esfahbod [Thu, 11 Oct 2018 19:14:18 +0000 (15:14 -0400)]
[arabic] Update to latest UTR#53
From Lorna Evans: "That was a new character added to Unicode 11.0"
Behdad Esfahbod [Thu, 11 Oct 2018 19:03:21 +0000 (15:03 -0400)]
[test] Fix use of deprecated symbols
Behdad Esfahbod [Thu, 11 Oct 2018 18:32:59 +0000 (14:32 -0400)]
[graphite] Remove deprecated symbol use
Behdad Esfahbod [Thu, 11 Oct 2018 18:30:15 +0000 (14:30 -0400)]
Whitespace
Behdad Esfahbod [Thu, 11 Oct 2018 18:25:48 +0000 (14:25 -0400)]
[graphite] Fix deva/dev2 resolution
See https://github.com/harfbuzz/harfbuzz/pull/730#issuecomment-
428277800
Behdad Esfahbod [Thu, 11 Oct 2018 18:16:55 +0000 (14:16 -0400)]
Add doc stubs for recently added API
Thanks to David Corbett who revamped our script and language processing
and implemented full BCP 47 support.
https://github.com/harfbuzz/harfbuzz/pull/730
New API:
+hb_ot_layout_table_select_script()
+hb_ot_layout_script_select_language()
+HB_OT_MAX_TAGS_PER_SCRIPT
+HB_OT_MAX_TAGS_PER_LANGUAGE
+hb_ot_tags_from_script_and_language()
+hb_ot_tags_to_script_and_language()
Deprecated API:
-hb_ot_layout_table_choose_script()
-hb_ot_layout_script_find_language()
-hb_ot_tags_from_script()
-hb_ot_tag_from_language()
Behdad Esfahbod [Thu, 11 Oct 2018 18:07:44 +0000 (14:07 -0400)]
Remove use of deprecated function
David Corbett [Mon, 10 Sep 2018 17:15:00 +0000 (13:15 -0400)]
Increase HB_OT_MAX_TAGS_PER_SCRIPT to 3
No script has 3 tags yet, but the plan is for the Indic scripts to each
get a third tag someday.
David Corbett [Mon, 10 Sep 2018 16:05:51 +0000 (12:05 -0400)]
Update language system tag registry to OT 1.8.3
David Corbett [Tue, 24 Jul 2018 01:19:23 +0000 (21:19 -0400)]
Add hb_ot_tags_to_script_and_language
David Corbett [Thu, 19 Jul 2018 17:48:07 +0000 (13:48 -0400)]
Switch on the first char of a complex language tag
This results in a tenfold speed-up for the common case of tags that are
not complex, in the sense of `hb_ot_tags_from_complex_language`.
David Corbett [Tue, 17 Jul 2018 01:14:48 +0000 (21:14 -0400)]
Map Quechua languages to closest ones with tags
OpenType only officially maps four ISO 639 codes to Quechua languages,
but prior versions of HarfBuzz also mapped qu to 'QUZ '. Because qu is a
macrolanguage, the mapping now applies to all individual Quechua
languages. OpenType calls 'QUZ ' "Quechua", but it really corresponds to
Cusco Quechua, so the individual Quechua languages should not all
necessarily be mapped to it.
David Corbett [Thu, 18 Jan 2018 21:33:39 +0000 (16:33 -0500)]
Test deprecated tag fallback in a font
The font supports the deprecated tag 'DHV ' instead of 'DIV '. dv is
mapped to 'DIV ' and 'DHV ', in that order. The test specifies
`--language=dv`, demonstrating that if a font does not support the first
OpenType tag mapped to a BCP 47 tag, it will fall back to the next tag.
David Corbett [Sat, 20 Jan 2018 20:53:09 +0000 (15:53 -0500)]
Match extlang subtags
If the second subtag of a BCP 47 tag is three letters long, it denotes
an extended language. The tag converter ignores the language subtag and
uses the extended language instead.
There are some grandfathered exceptions, which are handled earlier.
David Corbett [Sat, 9 Dec 2017 03:45:52 +0000 (22:45 -0500)]
Autogenerate the BCP 47 to OpenType mappings
The new script, gen-tag-table.py, generates `ot_languages` automatically
from the [OpenType language system tag registry][ot] and the [IANA
Language Subtag Registry][bcp47] with some manual modifications. If an
OpenType tag maps to a BCP 47 macrolanguage, all the macrolanguage's
individual languages are mapped to the same OpenType tag, except for
individual languages with their own OpenType mappings. Deprecated
BCP 47 tags are canonicalized.
[ot]: https://docs.microsoft.com/en-us/typography/opentype/spec/languagetags
[bcp47]: https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
Some OpenType tags correspond to multiple ISO 639 codes. The mapping
from ISO 639 codes lists OpenType tags in priority order, such that more
specific or more likely tags appear first.
Some OpenType tags have no corresponding ISO 639 code in the registry so
their mappings use BCP 47 subtags besides the language. For example, any
BCP 47 tag with a fonipa variant subtag is mapped to 'IPPH', and 'IPPH'
is mapped back to und-fonipa.
Other OpenType tags have no corresponding ISO 639 code because it is not
clear what they are for. HarfBuzz just ignores these tags.
One such ignored tag is 'ZHP ' (Chinese Phonetic). It probably means
zh-Latn. However, it is used in Microsoft JhengHei and Microsoft YaHei
with the script tag 'hani', implying that it is not a romanization
scheme after all. It would be simple enough to add this mapping to
gen-tag-table.py once a definitive mapping is determined.
The manual modifications are mainly either obvious mappings that the
OpenType registry omits or mappings for compatibility with previous
versions of HarfBuzz. Some of the old mappings were discarded, though,
for homophonous language names. For example, OpenType maps 'KUI ' to
kxu; previous versions of HarfBuzz also mapped it to kvd, because kvd
and kxu both happen to be called "Kui".
gen-tag-table.py also generates a function to convert multi-subtag tags
like el-polyton and zh-HK to OpenType tags, replacing `ot_languages_zh`
and the hard-coded list of special cases in `hb_ot_tags_from_language`.
It also generates a function to convert OpenType tags to BCP 47,
replacing the hard-coded list of special cases in
`hb_ot_tag_to_language`.
David Corbett [Fri, 29 Dec 2017 12:19:05 +0000 (20:19 +0800)]
Deprecate obsolete functions
`hb_ot_tags` replaces `hb_ot_tags_from_script` and
`hb_ot_tag_from_language`.
`hb_ot_layout_table_select_script` replaces
`hb_ot_layout_table_choose_script`.
`hb_ot_layout_script_select_language` replaces
`hb_ot_layout_script_find_language`.
David Corbett [Fri, 8 Dec 2017 16:21:14 +0000 (11:21 -0500)]
Refactor the selection of script and language tags
The old hb-ot-tag.cc functions, `hb_ot_tags_from_script` and
`hb_ot_tag_from_language`, are now wrappers around a new function:
`hb_ot_tags`. It converts a script and a language to arrays of script
tags and language tags. This will make it easier to add new script tags
to scripts, like 'dev3'. It also allows for language fallback chains;
nothing produces more than one language yet though.
Where the old functions return the default tags 'DFLT' and 'dflt',
`hb_ot_tags` returns an empty array. The caller is responsible for
using the default tag in that case.
The new function also adds a new private use subtag syntax for script
overrides: "x-hbscabcd" requests a script tag of 'abcd'.
The old hb-ot-layout.cc functions,`hb_ot_layout_table_choose_script` and
`hb_ot_layout_script_find_language` are now wrappers around the new
functions `hb_ot_layout_table_select_script` and
`hb_ot_layout_script_select_language`. They are essentially the same as
the old ones plus a tag count parameter.
Closes #495.
David Corbett [Thu, 28 Dec 2017 14:59:29 +0000 (22:59 +0800)]
Replace "ISO 639" with "BCP 47"
`hb_language_from_string` accepts not only ISO 639 but also BCP 47. Not
all ISO 639 codes are valid BCP 47 tags but the function does not accept
overlong language subtags anyway.
Behdad Esfahbod [Thu, 11 Oct 2018 17:26:58 +0000 (13:26 -0400)]
[aat] Apply kerx if GPOS kern was not applied
Ned tells me this is what Apple does.
Behdad Esfahbod [Thu, 11 Oct 2018 17:24:17 +0000 (13:24 -0400)]
Minor
Behdad Esfahbod [Thu, 11 Oct 2018 15:30:45 +0000 (11:30 -0400)]
[trak] Add tests
Behdad Esfahbod [Thu, 11 Oct 2018 15:25:07 +0000 (11:25 -0400)]
[trak] Implement extrapolation
This concludes trak, as well as AAT shaping support!
Behdad Esfahbod [Thu, 11 Oct 2018 15:10:06 +0000 (11:10 -0400)]
[trak] Fix, and hook up
Works beautifully! Test coming.
Behdad Esfahbod [Thu, 11 Oct 2018 14:32:08 +0000 (10:32 -0400)]
[trak] Handle nSizes=0 and 1
Behdad Esfahbod [Thu, 11 Oct 2018 14:30:32 +0000 (10:30 -0400)]
[trak] Fix counting
Behdad Esfahbod [Thu, 11 Oct 2018 14:29:02 +0000 (10:29 -0400)]
[trak] More
Behdad Esfahbod [Thu, 11 Oct 2018 14:22:01 +0000 (10:22 -0400)]
[trak] Only adjust around first glyph
Assumes graphemes only have one base glyph.
Behdad Esfahbod [Thu, 11 Oct 2018 14:18:46 +0000 (10:18 -0400)]
[trak] Clean up
Behdad Esfahbod [Thu, 11 Oct 2018 05:22:29 +0000 (01:22 -0400)]
[kerx] Implement Format4 action_type=1 contour-point-based attachment
Untested.
This concludes kerx table support!
Behdad Esfahbod [Thu, 11 Oct 2018 05:17:57 +0000 (01:17 -0400)]
[kerx] Implement Format4 action_type=2 coordinate-based attachment
Untested.
Behdad Esfahbod [Thu, 11 Oct 2018 05:14:18 +0000 (01:14 -0400)]
[kerx] Implement Format4 'ankr'-based mark attachment
Tested with Kannada MN:
$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0CCD,0C95,0CD6
[kn_ka.vattu=0+230|kn_ai_length_mark=1@326,0+607]
Behdad Esfahbod [Thu, 11 Oct 2018 04:52:07 +0000 (00:52 -0400)]
[aat] Wire up 'ankr' table to apply context
Behdad Esfahbod [Thu, 11 Oct 2018 04:12:49 +0000 (00:12 -0400)]
[kerx] Flesh out Format4
Doesn't apply actions yet.
Behdad Esfahbod [Thu, 11 Oct 2018 03:07:03 +0000 (23:07 -0400)]
[ankr] Implement table access
Behdad Esfahbod [Thu, 11 Oct 2018 02:56:52 +0000 (22:56 -0400)]
[ankr] Start fixing
Behdad Esfahbod [Thu, 11 Oct 2018 02:17:07 +0000 (22:17 -0400)]
Ugh. Re-enable accidentally disabled GPOS
Behdad Esfahbod [Thu, 11 Oct 2018 02:15:13 +0000 (22:15 -0400)]
[kerx] Allow granularly disabling kerning
Behdad Esfahbod [Thu, 11 Oct 2018 01:53:14 +0000 (21:53 -0400)]
[kerx] Comment
Behdad Esfahbod [Thu, 11 Oct 2018 01:46:58 +0000 (21:46 -0400)]
[kerx] Make Format1 work
Tested using Kannada MN:
$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD
[kn_ka.virama=0+1299|kn_ka.vattu=0+115|_blank=0@-115,0+385]
$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD --features=-kern
[kn_ka.virama=0+1799|kn_ka.vattu=0+230|_blank=0+0]
I don't see the GPOS table in the font do the same. ¯\_(ツ)_/¯
Behdad Esfahbod [Thu, 11 Oct 2018 01:29:46 +0000 (21:29 -0400)]
Disable mark advance zeroing as well as mark fallback positioning if doing kerx
Behdad Esfahbod [Thu, 11 Oct 2018 01:18:37 +0000 (21:18 -0400)]
[kerx] Implement Format1
Untested.
Behdad Esfahbod [Thu, 11 Oct 2018 00:43:21 +0000 (20:43 -0400)]
[kerx] More UnsizedArrayOf<>
Behdad Esfahbod [Thu, 11 Oct 2018 00:41:16 +0000 (20:41 -0400)]
[kerx] Fix bound-checking error introduced a couple commits past
Behdad Esfahbod [Thu, 11 Oct 2018 00:37:22 +0000 (20:37 -0400)]
[kerx] Start fleshing out Format1
Behdad Esfahbod [Thu, 11 Oct 2018 00:10:20 +0000 (20:10 -0400)]
[kerx] Implement Format6
Untested. The only Apple font shipping with this format is San Francisco fonts
that use this for their kerx variation tables, which we don't support.
Behdad Esfahbod [Thu, 11 Oct 2018 00:00:44 +0000 (20:00 -0400)]
[kerx] Move bounds-checking to subtable length itself
Behdad Esfahbod [Wed, 10 Oct 2018 23:58:20 +0000 (19:58 -0400)]
[kerx] Start fleshing out Format6
Behdad Esfahbod [Wed, 10 Oct 2018 23:20:06 +0000 (19:20 -0400)]
[kerx] When rejecting variable kerning, also check for tupleCount
Behdad Esfahbod [Wed, 10 Oct 2018 23:11:30 +0000 (19:11 -0400)]
[kerx] No-op
Tested that Format0 works with Kannada MN font:
$ make -j5 lib -s && HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2
[kn_ka=0+1000|kn_matra_uu=0@-30,0+1345]
$ make -j5 lib -s && HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2 --features=-kern
[kn_ka=0+1030|kn_matra_uu=0+1375]
Note that GPOS does the same with 'dist' feature, and applies the whole difference to the
same glyph:
$ make -j5 lib -s && ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2
[kn_ka=0+970|kn_matra_uu=0+1375]
$ make -j5 lib -s && ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2 --features=-dist
[kn_ka=0+1030|kn_matra_uu=0+1375]
Behdad Esfahbod [Wed, 10 Oct 2018 23:02:32 +0000 (19:02 -0400)]
Comment
Behdad Esfahbod [Wed, 10 Oct 2018 22:59:07 +0000 (18:59 -0400)]
Fix option string matching
Behdad Esfahbod [Wed, 10 Oct 2018 22:14:41 +0000 (18:14 -0400)]
[kern/kerx] Fix offset base
Disable kern Format2.
Fix kerx Format2. Manually tested this with Tamil MN font and it works:
$ HB_OPTIONS=aat ./hb-shape Tamil\ MN.ttc -u 0B94,0B95
[tgv_au=0+3435|tgc_ka=1@-75,0+1517]
HB_OPTIONS=aat ./hb-shape Tamil\ MN.ttc -u 0B94,0B95 --features=-kern
[tgv_au=0+3510|tgc_ka=1+1592]
Behdad Esfahbod [Wed, 10 Oct 2018 22:10:05 +0000 (18:10 -0400)]
[kerx] Don't loop over kerning subtables if kerning disabled
Behdad Esfahbod [Wed, 10 Oct 2018 21:44:46 +0000 (17:44 -0400)]
Allow HB_OPTIONS=aat to prefer AAT tables over OT
Fixes https://github.com/harfbuzz/harfbuzz/issues/322
Behdad Esfahbod [Wed, 10 Oct 2018 21:32:32 +0000 (17:32 -0400)]
[kerx] Skip variation subtables
Behdad Esfahbod [Wed, 10 Oct 2018 20:32:35 +0000 (16:32 -0400)]
Remove HAVE_OT
We never tested compiling without it. Just kill it. We always build
our own shaper.
Behdad Esfahbod [Wed, 10 Oct 2018 17:24:51 +0000 (13:24 -0400)]
[kerx] Actually hook up, and fix crash
Behdad Esfahbod [Wed, 10 Oct 2018 16:07:49 +0000 (12:07 -0400)]
Add per-subtable set-digests
This speeds up Roboto shaping by ~10%. I was hoping for more.
Still, good defense against lookups with many subtables.
Behdad Esfahbod [Wed, 10 Oct 2018 15:54:48 +0000 (11:54 -0400)]
Move apply down into subtables accel
Behdad Esfahbod [Wed, 10 Oct 2018 15:50:46 +0000 (11:50 -0400)]
Move subtable array into lookup accel
Behdad Esfahbod [Wed, 10 Oct 2018 15:41:05 +0000 (11:41 -0400)]
Move more code
Behdad Esfahbod [Wed, 10 Oct 2018 15:36:28 +0000 (11:36 -0400)]
Move code
In preparation to move add per-subtable set digests...
Behdad Esfahbod [Wed, 10 Oct 2018 14:57:28 +0000 (10:57 -0400)]
Fix GPOS/kern interaction
Oops. Was checking for kern feature in GSUB, not GPOS.
Behdad Esfahbod [Wed, 10 Oct 2018 14:49:45 +0000 (10:49 -0400)]
More rewriting plan compile
Hopefully more clear.
Behdad Esfahbod [Wed, 10 Oct 2018 14:42:10 +0000 (10:42 -0400)]
More reshuffle plan compile
Behdad Esfahbod [Wed, 10 Oct 2018 14:41:08 +0000 (10:41 -0400)]
[kerx] Hook up to shaper
Behdad Esfahbod [Wed, 10 Oct 2018 14:18:39 +0000 (10:18 -0400)]
[kern] Minor
Behdad Esfahbod [Wed, 10 Oct 2018 14:16:09 +0000 (10:16 -0400)]
Apply TT or fallback kerning when GPOS does not have kern feature
Previously we only did if there was no GPOS whatsoever. This applies
to Arial, Times New Roman, etc in Win7. Was not kerning before. It
is now.
Behdad Esfahbod [Wed, 10 Oct 2018 14:04:05 +0000 (10:04 -0400)]
Minor
Ebrahim Byagowi [Wed, 10 Oct 2018 13:42:52 +0000 (17:12 +0330)]
[circleci] Add an iOS bot (#1233)
Behdad Esfahbod [Wed, 10 Oct 2018 03:35:07 +0000 (23:35 -0400)]
[kerx] Comment
Behdad Esfahbod [Wed, 10 Oct 2018 03:27:00 +0000 (23:27 -0400)]
[aat] Rename
Behdad Esfahbod [Wed, 10 Oct 2018 03:18:19 +0000 (23:18 -0400)]
[morx] Use subtable range for embedded sanitizer here as well
Behdad Esfahbod [Wed, 10 Oct 2018 03:17:32 +0000 (23:17 -0400)]
[aat] Fixup recent commit
For
329f2401082011007d9ce12b15ce0225cd267c57
max_ops is signed.
Behdad Esfahbod [Wed, 10 Oct 2018 03:07:47 +0000 (23:07 -0400)]
[kerx] Use subtable range for runtime checks
Behdad Esfahbod [Wed, 10 Oct 2018 03:02:53 +0000 (23:02 -0400)]
[aat] Set embedded sanitizer max ops really high
Since we consume it legitimately during shaping.
Behdad Esfahbod [Wed, 10 Oct 2018 02:57:00 +0000 (22:57 -0400)]
[kerx] Comment
Behdad Esfahbod [Wed, 10 Oct 2018 02:55:47 +0000 (22:55 -0400)]
[kerx] Remove junk
Behdad Esfahbod [Wed, 10 Oct 2018 02:52:41 +0000 (22:52 -0400)]
[kern/kerx] Adjust bounds check
Behdad Esfahbod [Wed, 10 Oct 2018 02:49:33 +0000 (22:49 -0400)]
[kerx] Implement Format2 apply()
Still, not hooked.
Behdad Esfahbod [Wed, 10 Oct 2018 02:46:30 +0000 (22:46 -0400)]
Fix check
Behdad Esfahbod [Wed, 10 Oct 2018 02:46:12 +0000 (22:46 -0400)]
[kern] Use kern subtable length for sanitizing in the accelerator
Behdad Esfahbod [Wed, 10 Oct 2018 02:39:31 +0000 (22:39 -0400)]
[kern] Minor
Behdad Esfahbod [Wed, 10 Oct 2018 02:35:22 +0000 (22:35 -0400)]
[kerx] Implement Format0 apply()
Not hooked up to be called yet.
Behdad Esfahbod [Wed, 10 Oct 2018 02:25:53 +0000 (22:25 -0400)]
Minor
Behdad Esfahbod [Wed, 10 Oct 2018 01:56:37 +0000 (21:56 -0400)]
[kern] Sanitize 4 bytes, not 2
Behdad Esfahbod [Tue, 9 Oct 2018 20:24:50 +0000 (16:24 -0400)]
[ft] Use mutex to lock access to FT_Face
Makes our FT-backed hb_font_t safe to use from multiple threads. Still,
the underlying FT_Face should NOT be used from other threads by client
or other libraries.
Maybe I add a lock()/unlock() public API ala PangoFT2 and cairo-ft.
Maybe not.
Behdad Esfahbod [Tue, 9 Oct 2018 20:07:55 +0000 (16:07 -0400)]
[ft] Remove (probably) stale comment
Behdad Esfahbod [Tue, 9 Oct 2018 19:55:26 +0000 (15:55 -0400)]
Minor