Jes Sorensen [Mon, 21 Jul 2014 09:24:55 +0000 (11:24 +0200)]
staging: rtl8723au: ODM_DMWatchdog23a(): Take a struct hal_data_8723a *
This will allow us to access variables in the hal_data struct
directly, and get rid of the horrendous ODM_CMNINFO spaghetti API.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:54 +0000 (11:24 +0200)]
staging: rtl8723au: We don't need two APIs to set pHalData->odmpriv.SupportAbility
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:53 +0000 (11:24 +0200)]
staging: rtl8723au: Remove another pile of awful unused ODM variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:52 +0000 (11:24 +0200)]
staging: rtl8723au: Remove another pile of useless ODM variables
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:51 +0000 (11:24 +0200)]
staging: rtl8723au: Remove useless ODM_CMNINFO_{WM_MODE, BAND} related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:50 +0000 (11:24 +0200)]
staging: rtl8723au: Remove ODM_CMNINFO_[RT]X_UNI and related code
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:49 +0000 (11:24 +0200)]
staging: rtl8723au: Remove write-only variables struct dm_priv->{Init,}DMFlag
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:48 +0000 (11:24 +0200)]
staging: rtl8723au: Remove write-only struct dm_priv->DM_Type variable
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:47 +0000 (11:24 +0200)]
staging: rtl8723au: Remove no-op function dm_CheckStatistics()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:46 +0000 (11:24 +0200)]
staging: rtl8723au: Remove no-op rtl8723a_deinit_dm_priv()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:45 +0000 (11:24 +0200)]
staging: rtl8723au: Remove some redundant check for hw_init_completed
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:44 +0000 (11:24 +0200)]
staging: rtl8723au: Remove unused DefaultInitialGain array
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:43 +0000 (11:24 +0200)]
staging: rtl8723au: bDMInitialGainEnable is always true
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:42 +0000 (11:24 +0200)]
staging: rtl8723au: Declare odm_EdcaTurbo*() functions static
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jes Sorensen [Mon, 21 Jul 2014 09:24:41 +0000 (11:24 +0200)]
staging: rtl8723au: Fold odm_EdcaTurboCheck23aCE23a() into odm_EdcaTurboCheck23a()
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Samuel Thibault [Thu, 17 Jul 2014 21:34:58 +0000 (23:34 +0200)]
Update speakup mailing list address
The speakup mailing list only works on the linux-speakup.org domain now.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
NeilBrown [Fri, 18 Jul 2014 05:39:19 +0000 (15:39 +1000)]
staging/lustre: fix misuse of current->parent.
current->parent is used by ptrace to redirect some signal delivery
to the ptracer. It should only be used by 'ptrace' or 'signal' code.
All other users should use current->real_parent, which is the real
parent.
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Asadi [Fri, 18 Jul 2014 20:13:08 +0000 (23:13 +0300)]
Staging: comedi: adl_pci9118: line over 80 fixed
A 'line over 80 characters' issue fixed.
Signed-off-by: Sam Asadi <asadi.samuel@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Fri, 18 Jul 2014 15:33:58 +0000 (00:33 +0900)]
staging: vme: Add missing CR in printk messages in vme_pio2_core.c
This patch add missing CR in messages within vme_pio2_core.c
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Fri, 18 Jul 2014 15:33:57 +0000 (00:33 +0900)]
staging: vme: Add missing CR in error message
This patch adds missing CR in dev_err message.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masanari Iida [Fri, 18 Jul 2014 15:33:56 +0000 (00:33 +0900)]
staging: vme: Fix typo in vme_pio2_gpio.c
This patch fix spelling typo in printk message.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 22:00:56 +0000 (23:00 +0100)]
staging: vt6656: remove unused macros
Remove macros start are unlikely to be reused
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 22:00:55 +0000 (23:00 +0100)]
staging: vt6656: mac.h clean up macros
White space and comment clean up
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 22:00:54 +0000 (23:00 +0100)]
staging: vt6656: put radio power off and on into correct state every time.
When radio is off bit GPIO3_INTMD should be on and off when radio is on.
Add these to the tail of vnt_radio_power_off and vnt_radio_power_on
and remove variable bHWRadioOff.
In device_init_registers just check GPIO3_DATA are in correct state and
always power on.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 22:00:53 +0000 (23:00 +0100)]
staging: vt6656: struct vnt_private remove unused variable bRadioOff
The variable flips from true to false but does nothing
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 22:00:52 +0000 (23:00 +0100)]
staging: vt6656: struct vnt_private remove unused variable bRadioControlOff
This variable is never set.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:16 +0000 (14:28 -0700)]
staging: comedi: comedi_compat32.h: checkpatch.pl --strict cleanup
Fix the checkpatch.pl --strict issues:
CHECK: extern prototypes should be avoided in .h files
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:15 +0000 (14:28 -0700)]
staging: comedi: comedidev.h: checkpatch.pl --strict cleanup
Fix the checkpatch.pl --strict issues:
CHECK: Please use a blank line after function/struct/union/enum declarations
CHECK: Alignment should match open parenthesis
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:14 +0000 (14:28 -0700)]
staging: comedi: comedi_fops: checkpatch.pl --strict cleanup
Fix the checkpatch.pl --strict issues:
CHECK: braces {} should be used on all arms of this statement
CHECK: Alignment should match open parenthesis
CHECK: Prefer kzalloc(sizeof(*dev)...) over kzalloc(sizeof(struct comedi_device)...)
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:13 +0000 (14:28 -0700)]
staging: comedi: comedi.h: checkpatch.pl --strict cleanup
Fix the checkpatch.pl --strict issues:
CHECK: Please use a blank line after function/struct/union/enum declarations
For aesthetics, convert the inline functions into simple macros.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:12 +0000 (14:28 -0700)]
staging: comedi: comedi_internal.h: checkpatch.pl --strict cleanup
Fix the checkpatch.pl --strict issues:
CHECK: Please use a blank line after function/struct/union/enum declarations
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:11 +0000 (14:28 -0700)]
staging: comedi: drivers.c: checkpatch.pl --strict cleanup
Fix the checkpatch.pl --strict issues:
CHECK: DEFINE_MUTEX definition without comment
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 21:28:10 +0000 (14:28 -0700)]
staging: comedi: comedi_compat32: checkpatch.pl --strict cleanup
Fix the checkpatch.pl --strict issues:
CHECK: Logical continuations should be on the previous line
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:30:02 +0000 (13:30 -0700)]
staging: comedi: hwdrv_apci3120: cleanup printk messages
Remove the printk messages that are just driver development debug noise
and convert the rest to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:30:01 +0000 (13:30 -0700)]
staging: comedi: hwdrv_apci3200: remove commented out printk messages
The commented out printk() messages all apear to be development noise.
Just remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:30:00 +0000 (13:30 -0700)]
staging: comedi: ni_atmio: remove printk noise in ni_isapnp_find_board()
The printk() messages in this function a just added noise. Remove them.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:59 +0000 (13:29 -0700)]
staging: comedi: hwdrv_apci3200: remove disabled PRINT_INFO debug
Remove all the PRINT_INFO debug.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:58 +0000 (13:29 -0700)]
staging: comedi: comedi_fops: remove commented out debug messages
Remove the commented out printk() debug.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:57 +0000 (13:29 -0700)]
staging: comedi: das1800: tidy up das1800_probe()
The (*attach) of driver calls this function to probe the 'id' of the
hardware to verify that a valid boardinfo has been selected by the
user.
The dev_dbg() messages when the boardinfo is valid is just added
noise. The printk messages when the id does not match the boardinfo
does have some value.
Refactor the function to remove the noise and use a common message
for the "(probed, not recommended)" message.
Convert the printk() messages to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:56 +0000 (13:29 -0700)]
staging: comedi: ni_at_a2150: convert printk to dev_err
Convert the printk() message to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:55 +0000 (13:29 -0700)]
staging: comedi: ni_atmio: convert printk to dev_err in ni_getboardtype()
Convert these printk() messages to dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:54 +0000 (13:29 -0700)]
staging: comedi: ni_atmio: remove board attach noise
Remove the printk messages in the (*attach) of this driver. These are
just added noise.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:53 +0000 (13:29 -0700)]
staging: comedi: ni_mio_common: consolidate call to ni_mseries_get_pll_parameters()
All cases of the switch call ni_mseries_get_pll_parameters() with the same
parameters. Move the call out of the switch.
Also, move the printk from ni_mseries_get_pll_parameters() so that it can
be converted into a dev_err().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Fri, 18 Jul 2014 20:29:52 +0000 (13:29 -0700)]
staging: comedi: ni_mio_common: convert printk messages to dev_err
Where possible, convert the printk() messages in this file to dev_err().
Remove a couple commented out printk() messages.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:16 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_private rename apTD to tx_context
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:15 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_private rename apRCB to rcb
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:14 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_private pInterruptURB rename to interrupt_urb
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:13 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_private remove dead variables
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:12 +0000 (06:36 +0100)]
staging: vt6656: remove dead structure struct vnt_tx_pkt_info
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:11 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_rcb remove camel case
Camel case changes
pDevice -> priv
pUrb -> urb
bBoolInUse -> in_use
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:10 +0000 (06:36 +0100)]
staging: vt6656: struct vnt_rcb remove unused members
Remove Next and Ref
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:09 +0000 (06:36 +0100)]
staging: vt6656: fix module_param_named tx_buffers variable
Should point to vnt_tx_buffers
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Fri, 18 Jul 2014 05:36:08 +0000 (06:36 +0100)]
staging: vt6656: usb_device_reset remove camel case
Camel case change
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Khoa Mai [Fri, 18 Jul 2014 01:45:05 +0000 (04:45 +0300)]
staging: bcm: Qos.c: Fix coding style
Switch and case should be in same indent level
Signed-off-by: Khoa Mai <mdk194@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Khoa Mai [Fri, 18 Jul 2014 01:45:04 +0000 (04:45 +0300)]
staging: bcm: Qos.c: Fix coding style
Fix C99 comment
Signed-off-by: Khoa Mai <mdk194@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Greg Kroah-Hartman [Fri, 18 Jul 2014 01:33:02 +0000 (18:33 -0700)]
staging: gdm72xx: fix build errors
This fixes the build errors in the dev_dbg() fixes in a previous patch.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
To: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 16 Jul 2014 20:57:52 +0000 (02:27 +0530)]
devres: Add devm_kasprintf and devm_kvasprintf API
devm_kasprintf() and devm_kvasprintf() are the managed counterparts
for kasprintf() and kvasprintf().
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Josep Puigdemont [Wed, 16 Jul 2014 23:03:39 +0000 (01:03 +0200)]
staging: lustre: plain interger was used as NULL pointer
This patch fixes the following warnings found when running sparse:
.../lproc_echo.c:43:11: warning: Using plain integer as NULL pointer
.../lproc_echo.c:49:11: warning: Using plain integer as NULL pointer
Signed-off-by: Josep Puigdemont <josep.puigdemont@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Thu, 17 Jul 2014 16:39:58 +0000 (12:39 -0400)]
staging: unisys: detect controlvm channel on module load
The controlvm channel is not removable from a guest after the guest starts,
so it makes no sense to constantly check for it. Move the channel address
discovery to visorchipset_init(), and remove all of the checks for the channel
address from the rest of the module, as the module will not load if the
channel pointer is not valid.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benjamin Romer [Thu, 17 Jul 2014 16:39:57 +0000 (12:39 -0400)]
staging: unisys: simplify controlvm channel address function
There is no reason to have controlvm_get_channel_address() defined in a
separate file. Move it to visorchipset_main.c, remove the no-op functions
controlvm_init() and controlvm_deinit() from visorchipset_main.c, and remove
the controlvm.h and controlvm_direct.c files from the module.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Utkin [Thu, 17 Jul 2014 16:28:21 +0000 (19:28 +0300)]
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c: drop incorrect checks
Dropped some "< 0" and ">= 0" checks on unsigned int values.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80501
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Thu, 17 Jul 2014 16:09:39 +0000 (17:09 +0100)]
staging: gdm72xx: replace print_hex_dump_debug() with dev_dbg()
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michalis Pappas [Thu, 17 Jul 2014 16:09:38 +0000 (17:09 +0100)]
staging: gdm72xx: remove debug code
Removed dump_eth_packet() and helper functions called upon packet tx/rx.
Signed-off-by: Michalis Pappas <mpappas@fastmail.fm>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sachin Kamat [Thu, 17 Jul 2014 05:47:15 +0000 (11:17 +0530)]
staging: ion: Remove left over comment
Commit
2bb9f5034ec7 ("gpu: ion: Remove heapmask from client")
removed the heap_type_mask parameter. Remove the associated
kernel-doc comment too.
Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
Cc: Rebecca Schultz Zavin <rebecca@android.com>
Cc: John Stultz <john.stultz@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kiran Padwal [Thu, 17 Jul 2014 04:05:18 +0000 (09:35 +0530)]
Staging: gdm724x: gdm_tty.c: fix missing blank line after variable declaration
Checkpatch fix - Add missing blank line after variable declaration
Signed-off-by: Kiran Padwal <kiran.padwal21@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Larry Finger [Thu, 17 Jul 2014 03:03:09 +0000 (22:03 -0500)]
staging: rtl8192ee: Fix setting highest n rate
Commit
4fb6a37c3f94c1cb4b828bfcc4347771e1628f88 by Andrey Utkin
<andrey.krieger.utkin@gmail.com> and entitled "staging: rtl8192ee:
"Correct bitmask in comparsion" fixed what appeared to be a typo. After
consultation with the Realtek engineers, merely testing for a 2T2R device
is sufficient to ensure that the TX MCS map will equal 0x0c, thus the second
test can be ignored.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:11 +0000 (22:22 +0100)]
staging: vt6656: Remove commented out long frequency_list
These frequencies are already defined in new tables channel.c
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:10 +0000 (22:22 +0100)]
staging: vt6656: main_usb remove static function declarations.
All these functions are in visibility order.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:09 +0000 (22:22 +0100)]
staging: vt6656: main_usb remove dead module params macros
All these macros relate to module parameters already removed
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:08 +0000 (22:22 +0100)]
staging: vt6656: remove dead code DEVICE_PARAM
All these module parameters are dead
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:07 +0000 (22:22 +0100)]
staging: vt6656: main_usb.c Replace DEVICE_PARAM TxDescriptors0
Replace with vnt_tx_buffers using module_param_named and
MODULE_PARM_DESC
Check user doe not set tx_buffer beyond the define limits of driver
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:06 +0000 (22:22 +0100)]
staging: vt6656: main_usb.c Replace DEVICE_PARAM RxDescriptors0
Replace with vnt_rx_buffers using module_param_named and
MODULE_PARM_DESC
Check user doe not set rx_buffer beyond the define limits of driver
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:05 +0000 (22:22 +0100)]
staging: vt6656: remove DBG_PRT kernel messages macro and enums
All dead code and nolonger used by driver.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:04 +0000 (22:22 +0100)]
staging: vt6656: power.c replace DBG_PRT debug messages
Replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:03 +0000 (22:22 +0100)]
staging: vt6656: replace DBG_PRT error messages
replace with dev_err
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:02 +0000 (22:22 +0100)]
staging: vt6656: main_usb replace DBG_PRT debug messages
replace with dev_dbg
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:01 +0000 (22:22 +0100)]
staging: vt6656: device_init_registers remove camel case
camel case changes
pDevice -> priv
byAntenna -> antenna
ntStatus -> status
byTmp-> tmp
byCalibTXIQ -> calib_tx_iq
byCalibTXDC -> calib_tx_dc
byCalibRXIQ -> calib_rx_iq
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:22:00 +0000 (22:22 +0100)]
staging: vt6656: device_set_options remove camel case
Camel case changes
pDevice -> priv
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:59 +0000 (22:21 +0100)]
staging: vt6656: device_set_options fix opening function bracket
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:58 +0000 (22:21 +0100)]
staging: vt6656: rename BBvUpdatePreEDThreshold to vnt_update_pre_ed_threshold
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:57 +0000 (22:21 +0100)]
staging: vt6656: rename BBvExitDeepSleep to vnt_exit_deep_sleep
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:56 +0000 (22:21 +0100)]
staging: vt6656: rename BBvSetDeepSleep to vnt_set_deep_sleep
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:55 +0000 (22:21 +0100)]
staging: vt6656: rename BBvSetVGAGainOffset to vnt_set_vga_gain_offset
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:54 +0000 (22:21 +0100)]
staging: vt6656: rename BBvSetShortSlotTime to vnt_set_short_slot_time
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:53 +0000 (22:21 +0100)]
staging: vt6656: rename BBbVT3184Init to vnt_vt3184_init
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:52 +0000 (22:21 +0100)]
staging: vt6656: rename BBvSetAntennaMode to vnt_set_antenna_mode
Dropping BB
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Wed, 16 Jul 2014 21:21:51 +0000 (22:21 +0100)]
staging: vt6656: baseband.c rename awcFrameTime to vnt_frame_time
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 19:27:32 +0000 (12:27 -0700)]
staging: comedi: comedi_fops: use pr_fmt()
There are a number of pr_{level} messages in this file that are used
to print kernel messages when the device pointer is not available for
a dev_{level} message.
Use pr_fmt() to ensure all of these messages have the module prefix.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 19:27:31 +0000 (12:27 -0700)]
staging: comedi: ni_labpc: tidy up labpc_ai_scan_mode()
This function checks the cmd->chanlist to determine the scan mode
used to sample the analog inputs. All possible modes are checked
so the final pr_err() and return 0 can never be reached.
Tidy up the function a bit and remove the unreachable code.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 19:27:30 +0000 (12:27 -0700)]
staging: comedi: cb_pcidas64: remove unused pr_fmt() macro
This macro is not used. Remove it.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 19:27:29 +0000 (12:27 -0700)]
staging: comedi: usbduxfast: convert pr_warn() to dev_warn()
Use dev_warn() to output the warning message.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 19:27:28 +0000 (12:27 -0700)]
staging: comedi: usbduxfast: convert pr_err() to dev_err()
Use dev_err() to output the error message and remove the unnecessary
pr_fmt() macro.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 18:57:56 +0000 (11:57 -0700)]
staging: comedi: remove comedi_error()
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character.
All of the users of this function have been converted to use dev_err()
directly. Remove the now unused function.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 18:57:55 +0000 (11:57 -0700)]
staging: comedi: hwdrv_apci1500: remove use of comedi_error()
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.
Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 18:57:54 +0000 (11:57 -0700)]
staging: comedi: hwdrv_apci1564: remove use of comedi_error()
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.
Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 18:57:53 +0000 (11:57 -0700)]
staging: comedi: hwdrv_apci3120: remove use of comedi_error()
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.
Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 18:57:52 +0000 (11:57 -0700)]
staging: comedi: addi_apci_3501: remove use of comedi_error()
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.
Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 18:57:51 +0000 (11:57 -0700)]
staging: comedi: adl_pci9118: remove use of comedi_error()
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.
Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 18:57:50 +0000 (11:57 -0700)]
staging: comedi: adv_pci1724: remove use of comedi_error()
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.
Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
H Hartley Sweeten [Thu, 17 Jul 2014 18:57:49 +0000 (11:57 -0700)]
staging: comedi: adv_pci_dio: remove use of comedi_error()
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
characters.
Use dev_err() directly instead of comedi_error() to avoid any confusion
and so that all the comedi generated kernel messages have the same format.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-rpi3.git / log