Lennart Poettering [Mon, 10 Dec 2018 11:31:30 +0000 (12:31 +0100)]
Merge pull request #10897 from keszybz/etc-fstab-parsing
Forbid dashes in hostnames and /etc/fstab parsing improvements
Lennart Poettering [Mon, 10 Dec 2018 10:13:21 +0000 (11:13 +0100)]
Merge pull request #11093 from yuwata/update-python-scripts-for-lgtm
Update python scripts for lgtm
Yu Watanabe [Sat, 8 Dec 2018 09:33:38 +0000 (18:33 +0900)]
systemctl: check triggering units only for stopped units
Fixes #11088.
Lennart Poettering [Mon, 10 Dec 2018 10:04:14 +0000 (11:04 +0100)]
Merge pull request #10999 from wkennington/static-neighbor-master
networkd: Static neighbor support
Zbigniew Jędrzejewski-Szmek [Wed, 5 Dec 2018 11:27:29 +0000 (12:27 +0100)]
basic/hostname-util: do truncation last when cleaning up
This allows more of the original name to be used if there are invalid
chars in the beginning.
Zbigniew Jędrzejewski-Szmek [Wed, 5 Dec 2018 11:26:29 +0000 (12:26 +0100)]
Partially unify hostname_is_valid() and dns_name_is_valid()
This makes hostname_is_valid() apply the ldh checks too, rejecting more
hostnames.
Zbigniew Jędrzejewski-Szmek [Wed, 21 Nov 2018 21:58:13 +0000 (22:58 +0100)]
resolve: reject host names with leading or trailing dashes in /etc/hosts
https://tools.ietf.org/html/rfc1035#section-2.3.1 says (approximately)
that only letters, numbers, and non-leading non-trailing dashes are allowed
(for entries with A/AAAA records). We set no restrictions.
hosts(5) says:
> Host names may contain only alphanumeric characters, minus signs ("-"), and
> periods ("."). They must begin with an alphabetic character and end with an
> alphanumeric character.
nss-files follows those rules, and will ignore names in /etc/hosts that do not
follow this rule.
Let's follow the documented rules for /etc/hosts. In particular, this makes us
consitent with nss-files, reducing surprises for the user.
I'm pretty sure we should apply stricter filtering to names received over DNS
and LLMNR and MDNS, but it's a bigger project, because the rules differ
depepending on which level the label appears (rules for top-level names are
stricter), and this patch takes the minimalistic approach and only changes
behaviour for /etc/hosts.
Escape syntax is also disallowed in /etc/hosts, even if the resulting character
would be allowed. Other tools that parse /etc/hosts do not support this, and
there is no need to use it because no allowed characters benefit from escaping.
Zbigniew Jędrzejewski-Szmek [Fri, 23 Nov 2018 14:52:38 +0000 (15:52 +0100)]
resolved: rework parsing of /etc/hosts
Do not treat various errors (missing hostname, invalid address) as fatal,
just warn and continue. /etc/hosts is written by humans and we should not
reject the whole file just because a singly entry is not to our liking.
Handle comments as described in hosts(5):
everything from the comment character until the end of the line should be
ignored.
Fixes #10779.
Add tests.
William A. Kennington III [Thu, 29 Nov 2018 03:00:58 +0000 (19:00 -0800)]
networkd: Static neighbor support
When using networkd we currently have no way of ensuring that static
neighbor entries are set when our link comes up. This change adds a new
section to the network definition that allows multiple static neighbors
to be set on a link.
William A. Kennington III [Fri, 30 Nov 2018 23:36:33 +0000 (15:36 -0800)]
networkd: Use only a generic CONFIGURING state
This allows us to convey that we are performing multiple link
configuration changes in parallel. This is needed to support configuring
neighbors while simultaneously configuring addresses and routes.
William A. Kennington III [Fri, 30 Nov 2018 23:54:45 +0000 (15:54 -0800)]
networkd: Track address configuration
This will be useful to assert that our static route configuration always
happens after address configuration once our individual configure state
goes away.
Yu Watanabe [Sun, 9 Dec 2018 18:17:33 +0000 (03:17 +0900)]
tree-wide: drop header for emacs from python scripts
Yu Watanabe [Sun, 9 Dec 2018 18:08:52 +0000 (03:08 +0900)]
tools: add one more SPDX license header
Yu Watanabe [Sat, 8 Dec 2018 11:51:56 +0000 (20:51 +0900)]
lgtm: use python3
Yu Watanabe [Sat, 8 Dec 2018 10:33:37 +0000 (19:33 +0900)]
tools: drop unused variable
Yu Watanabe [Sat, 8 Dec 2018 10:31:24 +0000 (19:31 +0900)]
hwdb: drop unused imported object
Yu Watanabe [Sat, 8 Dec 2018 10:27:27 +0000 (19:27 +0900)]
hwdb: drop comment
Evgeny Vereshchagin [Sun, 9 Dec 2018 13:53:03 +0000 (16:53 +0300)]
Merge pull request #11095 from evverx/use-systemd-as-pid1-yolo
travis: use systemd as PID1 in debian containers
Zbigniew Jędrzejewski-Szmek [Sun, 9 Dec 2018 11:10:57 +0000 (12:10 +0100)]
Merge pull request #10931 from yuwata/daemon-util
sd-daemon: add notify_on_cleanup() helper function and use it where applicable
Zbigniew Jędrzejewski-Szmek [Sun, 9 Dec 2018 10:50:39 +0000 (11:50 +0100)]
Merge pull request #11097 from jwrdegoede/hwdb-sensors5
Hwdb sensors5
Evgeny Vereshchagin [Sun, 9 Dec 2018 09:29:25 +0000 (10:29 +0100)]
travis: mount tmpfs on /tmp before running the tests
To judge from https://api.travis-ci.org/v3/job/
465547774/log.txt,
overlayfs on Travis CI is having trouble delivering inotify events,
which is why `test-path` and `test-event` are failing there.
Evgeny Vereshchagin [Sat, 8 Dec 2018 20:49:52 +0000 (21:49 +0100)]
travis: use systemd as PID1 in debian containers
Turns out some tests like `test-execute` are tightly coupled with
systemd as PID1 (which should be fixed of course). In the meantime,
let's see how it goes.
Lennart Poettering [Sat, 8 Dec 2018 19:21:43 +0000 (20:21 +0100)]
mount-point: honour AT_SYMLINK_FOLLOW correctly
Fixes: #11092
Hans de Goede [Fri, 7 Dec 2018 19:50:30 +0000 (20:50 +0100)]
hwdb: Add accelerometer orientation quirk for the PoV P1005W-232 tablet
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Hans de Goede [Fri, 7 Dec 2018 17:35:51 +0000 (18:35 +0100)]
hwdb: Add accelerometer orientation quirk for the Prowise PT301 tablet
Zbigniew Jędrzejewski-Szmek [Thu, 6 Dec 2018 14:45:19 +0000 (15:45 +0100)]
coding style: reduce text width to 109 characters
Patches are shown on github with a fixed width (no matter how wide the window
is). When line numbers are high (we have some files with 5 digit line numbers),
the diff does not fit, and horizontal scrolling must be used when viewing the
patch. This is super annoying. Let's reduce the width a bit. I think 109 is
still very wide, but at least the github issue should be alleviated.
Yu Watanabe [Mon, 26 Nov 2018 08:51:32 +0000 (17:51 +0900)]
journal-remote: define main through macro
Also, this fixes memleaks on failure.
Yu Watanabe [Mon, 26 Nov 2018 08:50:52 +0000 (17:50 +0900)]
journal-remote: destroy RemoteServer object by using _cleanup_ attribute
Yu Watanabe [Mon, 26 Nov 2018 08:35:04 +0000 (17:35 +0900)]
journal-upload: define main through macro
Yu Watanabe [Sun, 25 Nov 2018 20:24:55 +0000 (05:24 +0900)]
journal-upload: use _cleanup_ attribute to clear uploader
Yu Watanabe [Sun, 25 Nov 2018 20:21:50 +0000 (05:21 +0900)]
journal-gateway: define main through macro
Yu Watanabe [Sun, 25 Nov 2018 20:13:00 +0000 (05:13 +0900)]
journal-gateway: use _cleanup_ attribute to stop microhttpd daemon
Yu Watanabe [Mon, 26 Nov 2018 07:56:58 +0000 (16:56 +0900)]
wait-online: define main through macro
Yu Watanabe [Mon, 26 Nov 2018 07:47:07 +0000 (16:47 +0900)]
timesync: define main through macro
Yu Watanabe [Mon, 26 Nov 2018 07:37:52 +0000 (16:37 +0900)]
network: define main through macro
Yu Watanabe [Mon, 26 Nov 2018 07:29:02 +0000 (16:29 +0900)]
resolve: define main through macro
Yu Watanabe [Mon, 26 Nov 2018 08:55:56 +0000 (17:55 +0900)]
sd-daemon: add notify_start() and notify_on_cleanup() helper function
Yu Watanabe [Mon, 26 Nov 2018 07:18:40 +0000 (16:18 +0900)]
meson: rename sd_event_c to sd_event_sources
Lennart Poettering [Fri, 7 Dec 2018 23:23:43 +0000 (00:23 +0100)]
Merge pull request #11055 from poettering/resolved-close-fix
a number of resolved fixes
Lennart Poettering [Fri, 7 Dec 2018 23:23:15 +0000 (00:23 +0100)]
Merge pull request #10980 from poettering/mount-no-extras
mount and swap improvements
Lennart Poettering [Wed, 28 Nov 2018 19:35:50 +0000 (20:35 +0100)]
swap: always add in extras when we load a swap unit
Much like for the mount units we need fields such as the slice
initialized by the time we activate the swap, hence when the kernel
let's us know about a new swap that appeared we need to initialize the
slice in any Swap object we allocated for that right-away, even if we
can't read the real unit file for the swap device.
Lennart Poettering [Wed, 28 Nov 2018 19:24:48 +0000 (20:24 +0100)]
swap: drop return value
We don't actually return any valid 'r' here, let's explicitly return 0
here hence instead.
Lennart Poettering [Wed, 28 Nov 2018 19:24:07 +0000 (20:24 +0100)]
swap: don't propagate issues with processing /proc/swaps
This follows similar recent changes in mount.c: error should be consider
local, and not be propagated.
Lennart Poettering [Wed, 28 Nov 2018 19:23:32 +0000 (20:23 +0100)]
swap: when loading a unit from /proc/swaps, mark its load state as good
This follows similar logic in the mount unit.
Lennart Poettering [Wed, 28 Nov 2018 19:22:31 +0000 (20:22 +0100)]
swap: split out code adding in additional unit props into a function of its own
This adds swap_add_extras() similar to mount_add_extras().
No change in behaviour, just some refactoring.
Lennart Poettering [Wed, 28 Nov 2018 19:06:55 +0000 (20:06 +0100)]
swap: fix misplaced comment
Lennart Poettering [Wed, 28 Nov 2018 19:05:49 +0000 (20:05 +0100)]
swap: flush out state when activating a unit, not when deactivating it
This is similar to the previous commit which did the same change for
mount units.
Lennart Poettering [Wed, 28 Nov 2018 19:01:24 +0000 (20:01 +0100)]
mount: flush out cycle state on DEAD→MOUNTED only, not the other way round
For services (and other units) we generally follow the rule that at the
beginning of each cycle, i.e. when the INACTIVE/FAILED state is left for
ACTIVATING/ACTIVE we flush out various state variables. Mount units
handled this differently so far when the unit state change was effected
outside of systemd: in that case these variables would be flushed out
when going back to INACTIVE/FAILED already.
Let's fix that, and flush out this state always during the activating
transition, not during the deactivating transition.
Lennart Poettering [Wed, 28 Nov 2018 18:06:30 +0000 (19:06 +0100)]
mount: replace three closely related mount flags into a proper flags enum
We pass these flags around, and even created a structure for them. Let's
fix things properly, and make them a flags value of its own.
Lennart Poettering [Wed, 28 Nov 2018 18:02:47 +0000 (19:02 +0100)]
mount: strdup() device paths we collect
We never know what the changes triggered by mount_set_state() do to the
unit. Let's be safe and copy the device path into our set, so that we
are safe against that.
Lennart Poettering [Wed, 28 Nov 2018 13:58:18 +0000 (14:58 +0100)]
mount: when the kernel reports a mount to be established reset all kinds of load failures
It doesn't matter what kind of precise failure we had earlier with
loading the unit, let's report that it loaded successfully now, after
all the kernel is an OK source for that, like any other.
Lennart Poettering [Wed, 28 Nov 2018 13:56:27 +0000 (14:56 +0100)]
mount: regenerate all deps whenever a mount's parameters changes
Whenever we notice a change on an existing /proc/self/mountinfo line,
let's update the deps generated from it. For that, let's flush out the
old deps generated this way, and add in the new ones.
This takes benefit of the fact that today (unlike a comment this patch
removes says) we can remove deps in a somewhat reasonable way.
Lennart Poettering [Wed, 28 Nov 2018 13:51:04 +0000 (14:51 +0100)]
mount: when allocating a Mount object based on /proc/self/mountinfo mark it so
Let's set 'from_proc_self_mountinfo' right away, since we know its from
there. This is important so that when the load queue is dispatched (and
thus mount_load() called) this
fact is already known.
Lennart Poettering [Wed, 28 Nov 2018 13:42:21 +0000 (14:42 +0100)]
mount: let mount_add_extras() take care of remote-fs.target deps
In a previous commit we added logic that mount_add_extras() (or more
precisely mount_add_default_dependencies()) adds in dependencies on
remote-fs.target and local-fs.target, hence we can drop this from
mount_setup_new_unit() and let the usual load queue dispatching take
care of this.
Lennart Poettering [Wed, 28 Nov 2018 13:40:56 +0000 (14:40 +0100)]
mount: use free_and_strdup() over plain strdup()
Let's initialize two fields with free_and_strdup() rather than directly
with strdup(). The fields should not be initialized so far, but it's
still nicer to be prepared for futzre code changes and always free
what's stored before replacing it.
Lennart Poettering [Wed, 28 Nov 2018 11:52:12 +0000 (12:52 +0100)]
mount: generate error message matching the error location
Lennart Poettering [Wed, 28 Nov 2018 11:50:01 +0000 (12:50 +0100)]
mount: move allocation of Unit object into mount_setup_new_unit()
This should encapsulate things in a nicer way.
Lennart Poettering [Wed, 28 Nov 2018 11:46:35 +0000 (12:46 +0100)]
mount: add a common helper for filling in info from /proc/self/mountinfo
Lennart Poettering [Wed, 28 Nov 2018 11:41:44 +0000 (12:41 +0100)]
mount: don't propagate errors from mount_setup_unit() further up
If we can't process a specific line in /proc/self/mountinfo we should
log about it (which we do), but this should not affect other lines, nor
further processing of mount units. Let's keep these failures local.
Fixes: #10874
Lennart Poettering [Wed, 28 Nov 2018 11:41:14 +0000 (12:41 +0100)]
mount: simplify de-serialization of control PID a bit
Lennart Poettering [Wed, 28 Nov 2018 11:40:37 +0000 (12:40 +0100)]
mount: serialize umount retry counter across reloads/reexec
Lennart Poettering [Wed, 28 Nov 2018 11:37:43 +0000 (12:37 +0100)]
mount: make sure mount_add_extras() is always invoked when we load a mount unit
We need to make sure that the slice property is initialized whenever
mount_load() is invoked, even if we fail to load things properly off
disk. This is important since we generally don't allow changing the
slice after a unit has been started. But given that we must track the
state of external objects with mount units we must hence initialize the
property no matter what.
Lennart Poettering [Wed, 28 Nov 2018 11:37:23 +0000 (12:37 +0100)]
mount: document that mount_add_extras() must work with active units, too
Lennart Poettering [Wed, 28 Nov 2018 11:35:37 +0000 (12:35 +0100)]
mount: set up local-fs.target/remote-fs.target deps in mount_add_default_dependencies() too
This deps are very similar to the -pre deps, hence establish them at the
same place, in particular as they should only be generated if default
deps are on.
This allows us to later on remove similar code that adds in these deps
whenever /proc/self/mountinfo changes.
Lennart Poettering [Wed, 28 Nov 2018 11:33:45 +0000 (12:33 +0100)]
mount: remove unnecessary initialization of device_wants_mount and 'if'
Lennart Poettering [Wed, 28 Nov 2018 11:33:21 +0000 (12:33 +0100)]
mount: use mfree() where appropriate
Lennart Poettering [Wed, 28 Nov 2018 11:32:35 +0000 (12:32 +0100)]
mount: rename needs_quota() → mount_needs_quota()
No change of logic, just some renaming, in order to match more closely
the naming of the other, similar functions.
Lennart Poettering [Wed, 28 Nov 2018 11:32:14 +0000 (12:32 +0100)]
mount: merge redundant call mount_needs_network() into mount_is_network()
Lennart Poettering [Tue, 4 Dec 2018 21:18:57 +0000 (22:18 +0100)]
resolved: drop unused field structure
Lennart Poettering [Tue, 4 Dec 2018 21:17:49 +0000 (22:17 +0100)]
resolved: implicitly disconnect a stream from its server when a stream is closed
Previously, the callback function did this, but let's do this in the
caller instead, to make this more robust, and use our new helper
function for it.
Lennart Poettering [Tue, 4 Dec 2018 21:15:22 +0000 (22:15 +0100)]
resolved: add new helper for carefully detach a stream from any server
This adds a helper call for detaching a DnsServer from a DnsStream if
the latter is the "default" stream of the server.
Also, let's unref the stream in dns_stream_stop() rather than
dns_stream_free(): as soon as our stream is disconnected by stopping
there's really no need to keep it as default stream for the server
around.
Since dns_stream_free() calls dns_stream_stop() we can remove it from
the former.
Lennart Poettering [Tue, 4 Dec 2018 21:13:39 +0000 (22:13 +0100)]
resolved: pin stream while calling callbacks for it
These callbacks might unref the stream, but we still have to access it,
let's hence ref it explicitly.
Maybe fixes: #10725
Lennart Poettering [Tue, 4 Dec 2018 21:09:08 +0000 (22:09 +0100)]
resolved: take particular care when detaching DnsServer from its default stream
DnsStream and DnsServer have a symbiotic relationship: one DnsStream is
the current "default" stream of the server (and thus reffed by it), but
each stream also refs the server it is connected to. This cyclic
dependency can result in weird situations: when one is
destroyed/unlinked/stopped it needs to unregister itself from the other,
but doing this will trigger unregistration of the other. Hence, let's
make sure we unregister the stream from the server before destroying it,
to break this cycle.
Most likely fixes: #10725
Lennart Poettering [Tue, 4 Dec 2018 19:53:14 +0000 (20:53 +0100)]
resolved: before assuming we have a server, check we are talking DNS and not LLMNR/mDNS
Lennart Poettering [Tue, 4 Dec 2018 19:52:43 +0000 (20:52 +0100)]
resolved: comment headers better
Lennart Poettering [Tue, 4 Dec 2018 19:41:06 +0000 (20:41 +0100)]
resolved: add small helper to pick DNS port number
This shouldn't be hidden in some function argument expression. Let's
make this more explicit by turning this into its own helper function.
Lennart Poettering [Tue, 4 Dec 2018 19:40:20 +0000 (20:40 +0100)]
resolved: rename dns_stream_on_packet() → on_stream_packet()
Let's name this similar to on_stream_complete(). Moreover we shouldn't
invade dns_stream's namespace if we are a consumer of it.
Lennart Poettering [Tue, 4 Dec 2018 19:24:26 +0000 (20:24 +0100)]
resolved: use structured initialization for DnsServer allocation
Lennart Poettering [Tue, 4 Dec 2018 19:21:02 +0000 (20:21 +0100)]
resolved: exit early on failure
Lennart Poettering [Tue, 4 Dec 2018 19:19:16 +0000 (20:19 +0100)]
resolved: don't read packet from DnsStream on on_stream_complete() of DnsTransaction
We register an on_packet() handler anyway, which is called first.
There's hence no need to check in on_stream_complete() again, as it is
already taken by that time.
Lennart Poettering [Tue, 4 Dec 2018 19:18:11 +0000 (20:18 +0100)]
resolved: add new accessor dns_stream_take_read_packet() for taking read packet from stream
This ensures the packet is complete when it is taken out, and resets
n_read so that we can start reading the next one.
Lennart Poettering [Tue, 4 Dec 2018 18:50:11 +0000 (19:50 +0100)]
resolved: remove redundant code
Lennart Poettering [Tue, 4 Dec 2018 18:29:15 +0000 (19:29 +0100)]
resolved: add some assert()s
Lennart Poettering [Tue, 4 Dec 2018 18:27:25 +0000 (19:27 +0100)]
resolved: be more careful with types in dns_stream_writev()
Let's not name a variable of type ssize_t "r". We usually use "r" for
return values of API calls that return some kind of error as in int.
This creates a lot of confusion if used differently here, which actually
resulted in connect()'s return value being assigned to this mistyped "r"
by accident.
Let's rename the variable "m" hence, and not use it for connect() return
values.
Lennart Poettering [Tue, 4 Dec 2018 18:26:54 +0000 (19:26 +0100)]
resolved: line split dns_stream_new() function signature
Lennart Poettering [Tue, 4 Dec 2018 18:14:51 +0000 (19:14 +0100)]
resolved: reorder things, to place registration of DnsStream in Manager close to each other
Lennart Poettering [Tue, 4 Dec 2018 18:14:28 +0000 (19:14 +0100)]
resolved: ensure DnsStream.fd is initialized before first error path
Lennart Poettering [Tue, 4 Dec 2018 18:13:55 +0000 (19:13 +0100)]
resolved: simplify on_stream_io() a bit
Evgeny Vereshchagin [Fri, 7 Dec 2018 08:49:51 +0000 (09:49 +0100)]
travis: also compile systemd on Debian Testing
This should help to catch issues like https://github.com/systemd/systemd/issues/11075
Filipe Brandenburger [Wed, 5 Dec 2018 22:13:02 +0000 (14:13 -0800)]
man: fix reference to sd_journal_print(3)
The reference in systemd-journald.service(8) was incorrectly pointing to
man volume 4 instead of 3.
This commit should fix the broken link at
https://www.freedesktop.org/software/systemd/man/systemd-journald.service.html
Yu Watanabe [Fri, 7 Dec 2018 09:11:36 +0000 (18:11 +0900)]
missing: re-add drm related entries
This effectively reverts
dab28f09051445fe370466e767e31652e0804a0f.
Fixes #11075.
Yu Watanabe [Thu, 6 Dec 2018 17:51:56 +0000 (18:51 +0100)]
bash-completion: analyze: support 'security'
Zbigniew Jędrzejewski-Szmek [Fri, 7 Dec 2018 07:03:32 +0000 (08:03 +0100)]
Merge pull request #11072 from yuwata/fix-networkctl-ip6gre
networkctl: fix TYPE field of ip6gre devices
Yu Watanabe [Thu, 6 Dec 2018 16:42:44 +0000 (17:42 +0100)]
missing: add ARPHRD_IP6GRE
This fixes TYPE field of networkctl's output for ip6gre devices.
Yu Watanabe [Thu, 6 Dec 2018 16:42:21 +0000 (17:42 +0100)]
af-list,arphrd-list: also include relevant missing_*.h headers
Yu Watanabe [Fri, 7 Dec 2018 02:48:37 +0000 (11:48 +0900)]
journal: use missing_audit.h to generate audit_type-list.txt
Yu Watanabe [Thu, 6 Dec 2018 16:38:37 +0000 (17:38 +0100)]
cap-list: use missing_capabilty.h to generate list of capabilities
Yu Watanabe [Fri, 7 Dec 2018 01:53:40 +0000 (02:53 +0100)]
Merge pull request #11038 from keszybz/man-timeouts
Small improvements for documentation of timeout options
Zbigniew Jędrzejewski-Szmek [Thu, 6 Dec 2018 14:04:14 +0000 (15:04 +0100)]
systemctl: be nice to users and give hint how to specify "-.mount"
https://bugzilla.redhat.com/show_bug.cgi?id=1656639
Using "--" is a trick that is hard to discover. Let's give users a hint:
$ build/systemctl status -.service
build/systemctl: invalid option -- '.'
Hint: to specify units starting with a dash, use "--":
build/systemctl [OPTIONS...] {COMMAND} -- -.service ...
I use program_invocation_name because that's what getopt seems to use.
"::" is used in the option string so that getopt doesn't complain about
a missing argument in case somebody passes "-." as the argument. After all
"." is not a real option.
Zbigniew Jędrzejewski-Szmek [Thu, 6 Dec 2018 08:56:37 +0000 (09:56 +0100)]
shared/blkid-util: do not include util.h needlessly