reed [Sun, 21 Dec 2014 19:03:36 +0000 (11:03 -0800)]
remove dead SK_SUPPORT_LEGACY_DEVICE_CLEAR code
BUG=skia:
TBR=robertphilips@google.com
Review URL: https://codereview.chromium.org/
807083003
robertphillips [Sun, 21 Dec 2014 18:52:01 +0000 (10:52 -0800)]
Allow the alpha folding optimization if the single draw's paint has a shader
Let's land this and then leave for 2 weeks.
BUG=skia:3119
Review URL: https://codereview.chromium.org/
817033002
tfarina [Sun, 21 Dec 2014 18:27:07 +0000 (10:27 -0800)]
Cleanup: More override fixes - include version.
BUG=skia:3075
TEST=ninja -C out/Debug
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
800663003
skia.buildbots [Sun, 21 Dec 2014 06:55:43 +0000 (22:55 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
824483002
reed [Sat, 20 Dec 2014 23:23:55 +0000 (15:23 -0800)]
remove dead SK_LEGACY_ENCODE_BITMAP flag
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
820903002
joshualitt [Sat, 20 Dec 2014 18:30:09 +0000 (10:30 -0800)]
rebase coloremoji
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
822553002
tfarina [Sat, 20 Dec 2014 14:53:43 +0000 (06:53 -0800)]
Cleanup: Another round of override fixes.
BUG=skia:3075
TEST=ninja -C out/Debug
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
815883002
skia.buildbots [Sat, 20 Dec 2014 07:10:53 +0000 (23:10 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
814393002
joshualitt [Fri, 19 Dec 2014 22:43:33 +0000 (14:43 -0800)]
fix leak
NOTREECHECKS=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
817083002
robertphillips [Fri, 19 Dec 2014 21:54:22 +0000 (13:54 -0800)]
Rebaseline (and ignore failure) on flaky NexusPlayer MPD GMs
BUG=skia:3267
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
814983004
reed [Fri, 19 Dec 2014 21:50:39 +0000 (13:50 -0800)]
mega rebaseline --tiny differences
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
802433004
robertphillips [Fri, 19 Dec 2014 21:49:15 +0000 (13:49 -0800)]
Add toString methods to SkImageFilter-derived classes
This isn't definitive but at least makes something show up in the debugger.
Review URL: https://codereview.chromium.org/
789163006
joshualitt [Fri, 19 Dec 2014 21:45:20 +0000 (13:45 -0800)]
initial changes to add local matrix to primitive processor
BUG=skia:
Review URL: https://codereview.chromium.org/
820523002
reed [Fri, 19 Dec 2014 20:53:10 +0000 (12:53 -0800)]
rebaselines after gradient fix
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
818853002
reed [Fri, 19 Dec 2014 20:43:47 +0000 (12:43 -0800)]
fix SK_LEGACY_ENCODE_BITMAP missing cast
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
815223002
bsalomon [Fri, 19 Dec 2014 20:26:37 +0000 (12:26 -0800)]
When bitmap is texture backed, don't download and reupload pixels
Review URL: https://codereview.chromium.org/
820683002
reed [Fri, 19 Dec 2014 20:26:07 +0000 (12:26 -0800)]
add const to encodePixels pixel parameter
BUG=skia:
Review URL: https://codereview.chromium.org/
788143007
reed [Fri, 19 Dec 2014 20:21:32 +0000 (12:21 -0800)]
rebaseline Nexus GMs
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
811263004
egdaniel [Fri, 19 Dec 2014 20:05:49 +0000 (12:05 -0800)]
More ignores for complexclip2
TBR=
NOTRY=True
NOTREECHECKS=True
BUG=skia:
Review URL: https://codereview.chromium.org/
814133003
reed [Fri, 19 Dec 2014 19:51:39 +0000 (11:51 -0800)]
rebaseline after gradient fix
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
807193004
bsalomon [Fri, 19 Dec 2014 17:32:40 +0000 (09:32 -0800)]
disable GM that asserts on gpu
BUG=skia:3265
TBR=egdaniel@google.com
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
818743002
reed [Fri, 19 Dec 2014 15:54:11 +0000 (07:54 -0800)]
update ignore list for prev CL
BUG=skia:
TBR=
NOTRY=True
NOTREECHECKS=True
Review URL: https://codereview.chromium.org/
810123003
reed [Fri, 19 Dec 2014 15:40:26 +0000 (07:40 -0800)]
Enable new gradients + suppress gms for now
This reverts commit
2c770271e612376508c18793c7067598378a00d9.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
811753003
scroggo [Fri, 19 Dec 2014 15:28:00 +0000 (07:28 -0800)]
Remove legacy Picture defines.
No longer needed by Android.
Review URL: https://codereview.chromium.org/
788903006
joshualitt [Fri, 19 Dec 2014 14:47:19 +0000 (06:47 -0800)]
rebase and update ignore
TBR=
NOTRY=True
BUG=skia:
Review URL: https://codereview.chromium.org/
816963002
egdaniel [Fri, 19 Dec 2014 14:26:48 +0000 (06:26 -0800)]
Initial rebaselines for complexclip3
TBR=
NOTRY=True
BUG=skia:
Review URL: https://codereview.chromium.org/
810423003
skia.buildbots [Fri, 19 Dec 2014 07:09:07 +0000 (23:09 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
810403002
joshualitt [Fri, 19 Dec 2014 00:40:54 +0000 (16:40 -0800)]
Remove the low hanging fruit with coord change matrices
BUG=skia:
Review URL: https://codereview.chromium.org/
793013003
joshualitt [Thu, 18 Dec 2014 23:52:55 +0000 (15:52 -0800)]
rebase blurrects
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
810593004
joshualitt [Thu, 18 Dec 2014 22:36:17 +0000 (14:36 -0800)]
quick adding to ignore
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
795943003
joshualitt [Thu, 18 Dec 2014 22:24:34 +0000 (14:24 -0800)]
rebase and update ignores
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
816813002
mtklein [Thu, 18 Dec 2014 21:29:54 +0000 (13:29 -0800)]
Fill SkRRect::fType proactively.
I found no external mentions of SkRRect::kUnknown_Type.
Motivating race found by TSAN:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-TSAN-Trybot/builds/48/steps/dm/logs/stdio
BUG=skia:
Review URL: https://codereview.chromium.org/
801693003
reed [Thu, 18 Dec 2014 21:01:39 +0000 (13:01 -0800)]
remove flag (not ready for it yet)
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
803553006
reed [Thu, 18 Dec 2014 20:59:39 +0000 (12:59 -0800)]
Revert of enable new gradients + suppress gms for now (patchset #1 id:1 of https://codereview.chromium.org/
807513004/)
Reason for revert:
crashy
Original issue's description:
> enable new gradients + suppress gms for now
>
> BUG=skia:
> TBR=
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/
8142a57fa1bf582b66efde276cd43d40c525bc16
TBR=
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
814963002
reed [Thu, 18 Dec 2014 20:53:37 +0000 (12:53 -0800)]
enable new gradients + suppress gms for now
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
807513004
reed [Thu, 18 Dec 2014 20:48:16 +0000 (12:48 -0800)]
remove dead code behind SK_SUPPORT_LEGACY_ALLOCPIXELS_BOOL
BUG=skia:
Review URL: https://codereview.chromium.org/
814753004
egdaniel [Thu, 18 Dec 2014 20:44:55 +0000 (12:44 -0800)]
Add an InvariantOutput for the XPF.
The Invariant output holds information about final post blended color and other
general information like will it blend with dst. Having this new struct allowed
me to also remove some functions that were previously querying subsets of the
invariant output.
BUG=skia:
Review URL: https://codereview.chromium.org/
814933002
reed [Thu, 18 Dec 2014 20:43:08 +0000 (12:43 -0800)]
improve precision of gradients (disabled for now)
BUG=skia:2898
TBR=caryclark
Review URL: https://codereview.chromium.org/
815623004
joshualitt [Thu, 18 Dec 2014 20:11:40 +0000 (12:11 -0800)]
rebase
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
798323006
joshualitt [Thu, 18 Dec 2014 19:54:13 +0000 (11:54 -0800)]
I could create new GMs if you prefer.
BUG=skia:
Review URL: https://codereview.chromium.org/
812163002
joshualitt [Thu, 18 Dec 2014 19:08:48 +0000 (11:08 -0800)]
adding bleed back to ignore
TBR=
NOTRY=True
BUG=skia:
Review URL: https://codereview.chromium.org/
810713003
joshualitt [Thu, 18 Dec 2014 19:00:51 +0000 (11:00 -0800)]
rebase
TBR=
NOTRY=True
BUG=skia:
Review URL: https://codereview.chromium.org/
812423002
bsalomon [Thu, 18 Dec 2014 18:17:44 +0000 (10:17 -0800)]
Remove GrCoordTransform::kPosition_CoordSet
Review URL: https://codereview.chromium.org/
811373002
reed [Thu, 18 Dec 2014 16:13:03 +0000 (08:13 -0800)]
remove dead code for SK_SUPPORT_LEGACY_TEXTRENDERMODE
BUG=skia:
TBR=robertphilips
Review URL: https://codereview.chromium.org/
812363002
joshualitt [Thu, 18 Dec 2014 15:47:16 +0000 (07:47 -0800)]
Change to create device coord coordset
BUG=skia:
Review URL: https://codereview.chromium.org/
812063002
egdaniel [Thu, 18 Dec 2014 15:04:12 +0000 (07:04 -0800)]
Various complex clip rebases
TBR=
NOTRY=
BUG=skia:
Review URL: https://codereview.chromium.org/
806223006
reed [Thu, 18 Dec 2014 14:40:08 +0000 (06:40 -0800)]
rebaseline after perspective/conic fix
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
811383002
bsalomon [Thu, 18 Dec 2014 14:20:52 +0000 (06:20 -0800)]
Fix complexclip3 test on gpu
BUG=skia:3260
R=egdaniel@google.com
Review URL: https://codereview.chromium.org/
813653003
tfarina [Thu, 18 Dec 2014 13:48:53 +0000 (05:48 -0800)]
Cleanup: Remove a bunch of SkFontHost.h includes (unused).
Nobody that is including SkFontHost is using SkFontHost API, so lets
remove this includes, since the API per se is deprecated.
BUG=None
R=reed@google.com
Review URL: https://codereview.chromium.org/
803733006
jvanverth [Thu, 18 Dec 2014 13:44:55 +0000 (05:44 -0800)]
One more pass at getting half float texture configs correct.
Added in check for sized internal format.
Made choice between RED and ALPHA orthogonal to HALF_FLOAT and
HALF_FLOAT_OES.
Enabled rendertarget support on ES 2.0.
Review URL: https://codereview.chromium.org/
805033002
skia.buildbots [Thu, 18 Dec 2014 07:06:08 +0000 (23:06 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
814633003
tfarina [Thu, 18 Dec 2014 01:50:21 +0000 (17:50 -0800)]
Cleanup: More override fixes.
Fixes errors like:
../../src/gpu/GrGeometryProcessor.h:172:25: error: 'name' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override]
virtual const char* name() const = 0;
^
../../include/gpu/GrProcessor.h:66:25: note: overridden virtual function is here
virtual const char* name() const = 0;
BUG=skia:3075
TEST=ninja -C out/Debug skia_lib
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
789343003
joshualitt [Thu, 18 Dec 2014 01:13:37 +0000 (17:13 -0800)]
rebase
TBR=
NOTRY=True
BUG=skia:
Review URL: https://codereview.chromium.org/
811243002
joshualitt [Wed, 17 Dec 2014 23:50:11 +0000 (15:50 -0800)]
remove view matrix from context
BUG=skia:
Review URL: https://codereview.chromium.org/
808703006
reed [Wed, 17 Dec 2014 22:42:09 +0000 (14:42 -0800)]
use conics for addRRect
BUG=skia:
Review URL: https://codereview.chromium.org/
792493005
bsalomon [Wed, 17 Dec 2014 22:38:49 +0000 (14:38 -0800)]
add inverted path draw cases to complexclip gm
Review URL: https://codereview.chromium.org/
809163002
egdaniel [Wed, 17 Dec 2014 22:03:51 +0000 (14:03 -0800)]
Ignore buggy clip gm on Mac 10.9
TBR=
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
793403005
bsalomon [Wed, 17 Dec 2014 21:43:13 +0000 (13:43 -0800)]
Stop creating GrODS for stencilPath commands.
Review URL: https://codereview.chromium.org/
816513003
egdaniel [Wed, 17 Dec 2014 21:37:13 +0000 (13:37 -0800)]
Add Coverage Drawing XP
BUG=skia:
Review URL: https://codereview.chromium.org/
808813002
reed [Wed, 17 Dec 2014 21:32:20 +0000 (13:32 -0800)]
rebaseline after perspective/conic fix
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
816543002
reed [Wed, 17 Dec 2014 21:08:17 +0000 (13:08 -0800)]
version 0 of imgconv tool
BUG=skia:
Review URL: https://codereview.chromium.org/
809143002
jvanverth [Wed, 17 Dec 2014 20:07:20 +0000 (12:07 -0800)]
Rebaseline HD7770 GMs for https://codereview.chromium.org/
811133002.
TBR=bensong@google.com
Review URL: https://codereview.chromium.org/
808173004
reed [Wed, 17 Dec 2014 19:28:35 +0000 (11:28 -0800)]
rebaseline after perspective/conic change
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
812863002
robertphillips [Wed, 17 Dec 2014 19:27:47 +0000 (11:27 -0800)]
Turn off warnings as errors for the debugger
Compiling the debugger on Linux was running afoul of warnings-as-errors
Review URL: https://codereview.chromium.org/
812673004
egdaniel [Wed, 17 Dec 2014 19:22:37 +0000 (11:22 -0800)]
Add new complexclip3 gm.
This GM is used to test the combined clipping of a complex clip (packman shape)
and a simple one (circle). We loop over all combinations of clip ops, aa/bw clip,
and inverse/non-inverse clips.
This GM triggers a current bug in the gpu clipping code which fires an assert. Thus
the skipGPU flag is set until that bug is fixed.
BUG=skia:
Review URL: https://codereview.chromium.org/
798793003
Brian Salomon [Wed, 17 Dec 2014 19:05:17 +0000 (14:05 -0500)]
Mark flaky gm as ignore-failure on mac 10.9
BUG=skia:3256
Review URL: https://codereview.chromium.org/
803443005
jvanverth [Wed, 17 Dec 2014 18:46:01 +0000 (10:46 -0800)]
Re-enable default sized formats, handling BGRA exception.
Sized texture formats are accepted by OpenGL desktop and ES 3.0,
except when using BGRA with GL_EXT_texture_format_BGRA8888.
In that case we fall back to using the unsized format.
Review URL: https://codereview.chromium.org/
811133002
reed [Wed, 17 Dec 2014 17:47:28 +0000 (09:47 -0800)]
rebaseline after perspective/conic fix
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
785333004
bsalomon [Wed, 17 Dec 2014 17:43:13 +0000 (09:43 -0800)]
Stop calling flushGLState in onStencilPath
Review URL: https://codereview.chromium.org/
805293003
reed [Wed, 17 Dec 2014 17:40:50 +0000 (09:40 -0800)]
remove flags that are now in chrome's userconfig
BUG=skia:
Review URL: https://codereview.chromium.org/
809073002
reed [Wed, 17 Dec 2014 17:27:34 +0000 (09:27 -0800)]
rebaseline after perspective fix (using conics)
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
811123003
reed [Wed, 17 Dec 2014 16:21:04 +0000 (08:21 -0800)]
use conics
BUG=skia:
Review URL: https://codereview.chromium.org/
455043002
reed [Wed, 17 Dec 2014 15:49:58 +0000 (07:49 -0800)]
rebaseline after fix to cornerpatheffect
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
814523004
scroggo [Wed, 17 Dec 2014 14:55:02 +0000 (06:55 -0800)]
Fix a case of kPartialSuccess.
Missed in https://codereview.chromium.org/
647023006/
When JPEG decoder does not have the remainder of the image, it should
return kPartialSuccess.
BUG:b/
17419670
BUG:b/
18769124
Review URL: https://codereview.chromium.org/
807983002
jvanverth [Wed, 17 Dec 2014 14:34:45 +0000 (06:34 -0800)]
Rebaseline HD7770 images after sized texture format revert.
TBR=bensong@google.com
Review URL: https://codereview.chromium.org/
815463002
reed [Wed, 17 Dec 2014 13:50:55 +0000 (05:50 -0800)]
fix end-point and conic bugs in cornerpatheffect
fixes bug in GM/patheffect -- will need to be rebaselined
BUG=skia:
Review URL: https://codereview.chromium.org/
803213003
skia.buildbots [Wed, 17 Dec 2014 12:52:31 +0000 (04:52 -0800)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
813743002
kkinnunen [Wed, 17 Dec 2014 12:06:54 +0000 (04:06 -0800)]
webpages_playback.py: Page sets to use changed telemetry API (AddUserStory)
Make page sets to use telemetry.page.page_set.AddUserStory instead of
AddPage.
BUG=chromium:439512
BUG=skia:3196
NOTRY=true
Review URL: https://codereview.chromium.org/
811003002
reed [Wed, 17 Dec 2014 09:47:32 +0000 (01:47 -0800)]
add arcto patheffect
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
813513003
fmalita [Wed, 17 Dec 2014 09:25:33 +0000 (01:25 -0800)]
Whitespace change
To re-trigger the build bots.
TBR=bensong@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
811623004
robertphillips [Tue, 16 Dec 2014 22:25:08 +0000 (14:25 -0800)]
Give the hoisting surfaces surface props
This mimics how layers are set up in SkGpuDevice::onCreateCompatibleDevice
Review URL: https://codereview.chromium.org/
809823003
jvanverth [Tue, 16 Dec 2014 21:32:27 +0000 (13:32 -0800)]
Revert using sized formats for everything except ES 2.0.
Temporary fix for WritePixels test on Nexus 5/Nexus 7-2013.
Review URL: https://codereview.chromium.org/
794273005
bsalomon [Tue, 16 Dec 2014 21:05:12 +0000 (13:05 -0800)]
Remove GrGpu::flushGraphicsState
Review URL: https://codereview.chromium.org/
809843002
scroggo [Tue, 16 Dec 2014 20:59:56 +0000 (12:59 -0800)]
Catch the stragglers from skbug.com/3241
Update expectations for tests that were using SkLCGRandom (and now
use SkRandom).
TBR=benchen
BUG=skia:3241
Review URL: https://codereview.chromium.org/
813513002
jvanverth [Tue, 16 Dec 2014 20:00:12 +0000 (12:00 -0800)]
Update expectations for Win8-HD7770.
TBR=bensong@google.com
Review URL: https://codereview.chromium.org/
806283002
scroggo [Tue, 16 Dec 2014 18:59:55 +0000 (10:59 -0800)]
Massive rebaseline for SkRandom.
All of the following GMs have been switched from SkLCGRandom to
SkRandom. Update their expectations for the new images.
-beziers
-circles
-convexpaths
-complexclip2
-complexclip2_rect_aa
-complexclip2_rect_bw
-complexclip2_path_aa
-complexclip2_path_bw
-complexclip2_rrect_aa
-complexclip2_rrect_bw
-cubicpath
-cubicclosepath
-degeneratesegments
-emptypath
-getpostextpath
-hittestpath
-linepath
-lineclosepath
-points
-polygons
-quadpath
-quadclosepath
-strokerects
-strokes_round
-strokes_poly
BUG=skia:3241
TBR=mtklein
Review URL: https://codereview.chromium.org/
806263002
jvanverth [Tue, 16 Dec 2014 17:49:38 +0000 (09:49 -0800)]
Change desktop and ES 3.0 to always use sized internal texture formats.
Committed: https://skia.googlesource.com/skia/+/
bc02bf0ee4221604796cd6d0394ca3af60c0a579
Review URL: https://codereview.chromium.org/
806943002
robertphillips [Tue, 16 Dec 2014 17:31:42 +0000 (09:31 -0800)]
Alter GM's --mpd option to write out images
Review URL: https://codereview.chromium.org/
811863002
fs [Tue, 16 Dec 2014 16:36:11 +0000 (08:36 -0800)]
SkMatrix44(const SkMatrix&) needs to initialize the type mask
Review URL: https://codereview.chromium.org/
791723006
robertphillips [Tue, 16 Dec 2014 16:25:55 +0000 (08:25 -0800)]
Fix layer hoisting image filter corner cases
This CL fixes 5 bugs related to hoisting image filters:
For image filters the src layer (the one prior to filtering) often needs to be
smaller then the final layer. This requires the saveLayer's optional bounds
to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in
compute_source_rect and carried around in GrCachedLayer.
The image filters can add an extra offset to the final draw operation.
This is now computed in GrLayerHoister::FilterLayer and carried around in
GrCachedLayer.
Filtered layers must use exact matches. This is now done in GrLayerCache::lock.
The filter cache requires a valid matrix so it can compute the correct offset.
This is now done in GrLayerHoister::FilterLayer.
Filtered layers need to be drawn with drawSprite while unfiltered (and therefore
hopefully atlased) layers can be drawn with drawBitmap. This is now done in
draw_replacement_bitmap.
Committed: https://skia.googlesource.com/skia/+/
702eb9622102599d94ab6798e6227cf29f48c2d3
Review URL: https://codereview.chromium.org/
803183003
bsalomon [Tue, 16 Dec 2014 16:13:53 +0000 (08:13 -0800)]
Rename GrGpuGL_program.cpp to GrGLGpuProgramCache.cpp
Review URL: https://codereview.chromium.org/
807133002
reed [Tue, 16 Dec 2014 16:07:43 +0000 (08:07 -0800)]
add sample for arcTo
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
808793002
robertphillips [Tue, 16 Dec 2014 15:41:37 +0000 (07:41 -0800)]
Revert of Fix layer hoisting image filter corner cases (patchset #3 id:40001 of https://codereview.chromium.org/
803183003/)
Reason for revert:
Breaking DM
Original issue's description:
> Fix layer hoisting image filter corner cases
>
> This CL fixes 5 bugs related to hoisting image filters:
>
> For image filters the src layer (the one prior to filtering) often needs to be
> smaller then the final layer. This requires the saveLayer's optional bounds
> to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in
> compute_source_rect and carried around in GrCachedLayer.
>
> The image filters can add an extra offset to the final draw operation.
> This is now computed in GrLayerHoister::FilterLayer and carried around in
> GrCachedLayer.
>
> Filtered layers must use exact matches. This is now done in GrLayerCache::lock.
>
> The filter cache requires a valid matrix so it can compute the correct offset.
> This is now done in GrLayerHoister::FilterLayer.
>
> Filtered layers need to be drawn with drawSprite while unfiltered (and therefore
> hopefully atlased) layers can be drawn with drawBitmap. This is now done in
> draw_replacement_bitmap.
>
> Committed: https://skia.googlesource.com/skia/+/
702eb9622102599d94ab6798e6227cf29f48c2d3
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
790643009
bsalomon [Tue, 16 Dec 2014 15:33:49 +0000 (07:33 -0800)]
Rename GrGpuGL to GrGLGpu for consistency
Review URL: https://codereview.chromium.org/
808593003
robertphillips [Tue, 16 Dec 2014 15:27:30 +0000 (07:27 -0800)]
Fix layer hoisting image filter corner cases
This CL fixes 5 bugs related to hoisting image filters:
For image filters the src layer (the one prior to filtering) often needs to be
smaller then the final layer. This requires the saveLayer's optional bounds
to be stored (in SkLayerInfo.h and SkRecordDraw.cpp) and then used in
compute_source_rect and carried around in GrCachedLayer.
The image filters can add an extra offset to the final draw operation.
This is now computed in GrLayerHoister::FilterLayer and carried around in
GrCachedLayer.
Filtered layers must use exact matches. This is now done in GrLayerCache::lock.
The filter cache requires a valid matrix so it can compute the correct offset.
This is now done in GrLayerHoister::FilterLayer.
Filtered layers need to be drawn with drawSprite while unfiltered (and therefore
hopefully atlased) layers can be drawn with drawBitmap. This is now done in
draw_replacement_bitmap.
Review URL: https://codereview.chromium.org/
803183003
mtklein [Tue, 16 Dec 2014 14:31:01 +0000 (06:31 -0800)]
Revert of Use SkPaint::getFontBounds() for text bounding boxes in pictures. (patchset #1 id:1 of https://codereview.chromium.org/
805983003/)
Reason for revert:
Test-Win7-ShuttleA-HD2000-x86-Debug-GDI
Original issue's description:
> Use SkPaint::getFontBounds() for text bounding boxes in pictures.
>
> Now that SkTextBlobs have landed, this is a perf no-op, but it at least lets us eliminate a bunch of questionable hacks.
>
> CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot,Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
02d2b9831579173e783569530ab7bae08de907e9
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
789793004
jvanverth [Tue, 16 Dec 2014 14:17:59 +0000 (06:17 -0800)]
Revert of Change desktop and ES 3.0 to always use sized internal texture formats. (patchset #2 id:20001 of https://codereview.chromium.org/
806943002/)
Reason for revert:
Failing GMs on Mac, Windows and Ubuntu12.
Original issue's description:
> Change desktop and ES 3.0 to always use sized internal texture formats.
>
> Committed: https://skia.googlesource.com/skia/+/
bc02bf0ee4221604796cd6d0394ca3af60c0a579
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
805193003
mtklein [Tue, 16 Dec 2014 14:17:54 +0000 (06:17 -0800)]
Use SkPaint::getFontBounds() for text bounding boxes in pictures.
Now that SkTextBlobs have landed, this is a perf no-op, but it at least lets us eliminate a bunch of questionable hacks.
CQ_EXTRA_TRYBOTS=client.skia:Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot,Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug-Trybot
BUG=skia:
Review URL: https://codereview.chromium.org/
805983003
jvanverth [Tue, 16 Dec 2014 13:45:49 +0000 (05:45 -0800)]
Change desktop and ES 3.0 to always use sized internal texture formats.
Review URL: https://codereview.chromium.org/
806943002
joshualitt [Tue, 16 Dec 2014 01:42:43 +0000 (17:42 -0800)]
rebase gms and update ignore
NOTRY=True
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
811433004