David Zeuthen [Fri, 17 Jun 2011 15:55:19 +0000 (11:55 -0400)]
Use a{sv} for options instead of just as
It's much more future-proof to do it this way.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Jun 2011 20:14:11 +0000 (16:14 -0400)]
Use udisksd, not udisks, as the name in syslog
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Jun 2011 19:54:24 +0000 (15:54 -0400)]
Update license and copyright headers
No big changes, basically we just want to convey that the library is
LGPLv2+ and everything else is GPLv2+. If there is any doubt that this
is the intention, this commit can be used to set the record straight.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Jun 2011 19:43:27 +0000 (15:43 -0400)]
Add better logging routines
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Jun 2011 18:28:19 +0000 (14:28 -0400)]
Make error output prettier
No need to mention both stdout and stderror unless both are non-empty.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Jun 2011 17:36:18 +0000 (13:36 -0400)]
Move SetLabel() method from BlockDevice to Filesystem interface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Jun 2011 17:09:20 +0000 (13:09 -0400)]
Use g_unix_signal_add_watch_full() instead of own GPosixSignal
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Jun 2011 16:46:59 +0000 (12:46 -0400)]
Remove configuration-item interface and the fstab provider implementing this
Was never really implemented and is easier to implement in another
way.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 16 Jun 2011 16:42:05 +0000 (12:42 -0400)]
Update docs
100% doc coverage now.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Jun 2011 16:55:56 +0000 (12:55 -0400)]
Rename Lun interface to Drive
The term "Lun" (Logical Unit Number) is too abstract / overloaded for
what we are trying to convey. Drive is a lot closer so rename it to
that.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Jun 2011 15:47:38 +0000 (11:47 -0400)]
Remove iSCSI bits for now
Will add this back later.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 15 Jun 2011 15:30:05 +0000 (11:30 -0400)]
Add WIP iSCSI patches
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 25 May 2011 16:21:44 +0000 (12:21 -0400)]
Get info via iscsiadm(8), not by parsing private data in /var/lib/iscsi
Also make it work for the case where we don't know the tpgt for the
configured target.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 23 May 2011 21:59:40 +0000 (17:59 -0400)]
Catch up with latest gdbus-codegen(1) changes
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sat, 16 Apr 2011 18:54:12 +0000 (14:54 -0400)]
Add introspection bits for libudisks2 and a small pygi example
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 13 Apr 2011 20:35:19 +0000 (16:35 -0400)]
Catch up with s/Stub/Skeleton/ rename in GLib's gdbus-codegen branch
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 13 Apr 2011 01:06:21 +0000 (21:06 -0400)]
Use GLib's gdbus-codegen branch for now
This will get merged onto GLib master in the near future.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 4 Apr 2011 19:19:55 +0000 (15:19 -0400)]
Nuke interface org.freedesktop.UDisks2.LinuxSysfsDevice
There's no need for this interface. Clients can get the device file
themselves and listen for uevents via libgudev1 or similar.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 4 Apr 2011 18:22:46 +0000 (14:22 -0400)]
Use new gdbus-codegen(1) facility for generating D-Bus docs
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Mar 2011 19:36:35 +0000 (15:36 -0400)]
Properly name types header file for daemon
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Mar 2011 19:09:51 +0000 (15:09 -0400)]
Use intltool to generate merged .policy file
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Mar 2011 19:02:46 +0000 (15:02 -0400)]
Implement Swapspace's Start() and Stop() method
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Mar 2011 17:46:06 +0000 (13:46 -0400)]
Add org.freedesktop.UDisks2.Swapspace interface
Whether an swap device is in use or not, can be tracked via the
:Active property. A swap device can be activated or deactivated with
the Start() and Stop() methods.
For now, Start() and Stop() are not actually hooked up.
Implementation-wise, monitoring /proc/swaps requires this patch
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=
66d7dd518ae413a383ab2c6c263cc30617329842
which is in Linux 2.6.38 or later.
Example:
$ udisksctl monitor
Monitoring the udisks daemon. Press Ctrl+C to exit.
13:49:08.441: The udisks-daemon is running (name-owner :1.315).
13:49:11.720: /org/freedesktop/UDisks2/block_devices/sda3: org.freedesktop.UDisks2.Swapspace: Properties Changed
Active: false
13:49:11.746: /org/freedesktop/UDisks2/block_devices/sda3: org.freedesktop.UDisks2.LinuxSysfsDevice::UEvent (b'change',)
13:49:15.310: /org/freedesktop/UDisks2/block_devices/sda3: org.freedesktop.UDisks2.Swapspace: Properties Changed
Active: true
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Mar 2011 14:34:58 +0000 (10:34 -0400)]
Set Lun:ConnectionBus for firewire drives
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Mar 2011 11:32:37 +0000 (07:32 -0400)]
Don't probe the LUN for information
It's no longer needed since we now use the block device (not the LUN
scsi_device) for tracking LUNs.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Mar 2011 11:21:58 +0000 (07:21 -0400)]
Print better warning when unable to find iscsi_session device
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 30 Mar 2011 11:20:01 +0000 (07:20 -0400)]
Use persistent_address sysfs file, not address, for iscsi connections
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 29 Mar 2011 22:20:05 +0000 (18:20 -0400)]
Add Lun:ConnectionBus property and use it in udisks_util_get_lun_info()
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 29 Mar 2011 21:55:09 +0000 (17:55 -0400)]
Reimplement udisks_util_get_lun_info()
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 29 Mar 2011 21:51:45 +0000 (17:51 -0400)]
Actually use WARN_CFLAGS
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 29 Mar 2011 18:22:44 +0000 (14:22 -0400)]
Specify behavior of udisks_util_get_lun_info()
We still need to actually implement this behavior - most of it can be
lifted from gnome-disk-utility....
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 29 Mar 2011 17:24:01 +0000 (13:24 -0400)]
Put files with translatable strings in POTFILES.in, not POTFILES.skip
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 29 Mar 2011 16:43:55 +0000 (12:43 -0400)]
Fix 'make distcheck'
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 29 Mar 2011 16:29:52 +0000 (12:29 -0400)]
Nuke blackbox tests for now
They don't work because the udisks2 interfaces are different from the
old ones - better to add the tests back when they are ported to the
new interface.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 29 Mar 2011 16:27:24 +0000 (12:27 -0400)]
Rework autotooling and setup i18n
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 25 Mar 2011 22:17:39 +0000 (18:17 -0400)]
Preliminary support for iSCSI targets
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 20 Mar 2011 17:26:26 +0000 (13:26 -0400)]
Update signal names
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 18 Mar 2011 19:26:40 +0000 (15:26 -0400)]
Update docs
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 18 Mar 2011 19:21:53 +0000 (15:21 -0400)]
Factor out filesystem to sep D-Bus interface and unify polkit interaction
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 18 Mar 2011 16:46:35 +0000 (12:46 -0400)]
Use new type-safe CALLBACK macros
Incidently, this actually found a bug - I was missing the user_data
parameters of the callback functions. So YAY!
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 17 Mar 2011 18:33:11 +0000 (14:33 -0400)]
Update to latest gdbus-codegen changes
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 16 Mar 2011 19:45:02 +0000 (15:45 -0400)]
Update to latest GDBus
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 14 Mar 2011 21:24:52 +0000 (17:24 -0400)]
Export udisks_util_get_media_compat_for_display()
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 14 Mar 2011 11:13:24 +0000 (07:13 -0400)]
Cope with the fact that ID_FS_VERSION is udev encoded
For example, LVM2 PVs have version LVM2\x20001 which should be
presented as "LVM2 001".
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 14 Mar 2011 10:59:46 +0000 (06:59 -0400)]
Capitalize short filesystem names
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 14 Mar 2011 10:57:26 +0000 (06:57 -0400)]
Fix copy-paste error for short filesystem name
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 14 Mar 2011 10:55:51 +0000 (06:55 -0400)]
Show 'Unknown' for unknown volume, not a blank string
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 14 Mar 2011 10:44:07 +0000 (06:44 -0400)]
Use /dev/mapper/vg-FOO-lv-BAR instead of /dev/dm-0 as PreferredDevice for LVM2
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 13 Mar 2011 20:49:54 +0000 (16:49 -0400)]
Fix typo so fs labels on mounted filesystems can be changed
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 13 Mar 2011 19:56:44 +0000 (15:56 -0400)]
Add FilesystemSetLabel method
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 13 Mar 2011 18:43:24 +0000 (14:43 -0400)]
Nuke helper option for now
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 13 Mar 2011 18:12:42 +0000 (14:12 -0400)]
Fix warnings triggered by gcc 4.6
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 13 Mar 2011 16:03:50 +0000 (12:03 -0400)]
Add udisks_util_get_part_types_for_scheme() util function
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 11 Mar 2011 23:34:21 +0000 (18:34 -0500)]
Add functions to get human-readable strings for partitions and filesystems
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 10 Mar 2011 22:57:54 +0000 (17:57 -0500)]
Export partition label and UUID
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 10 Mar 2011 20:18:37 +0000 (15:18 -0500)]
Add a CryptoBackingDevice property on BlockDevice for dm-crypt
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 10 Mar 2011 17:19:04 +0000 (12:19 -0500)]
Make the Size property on BlockDevice be 0 if no media is available
Also unify code for determing device size for Lun and BlockDevice.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 10 Mar 2011 17:18:53 +0000 (12:18 -0500)]
Add PartEntryNumber attribute to the BlockDevice interface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 9 Mar 2011 17:40:45 +0000 (12:40 -0500)]
Add utility function to get info about a LUN
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 8 Mar 2011 22:43:16 +0000 (17:43 -0500)]
Add a Size property to the Lun interface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 8 Mar 2011 19:24:26 +0000 (14:24 -0500)]
Add LoopBackingFile property to BlockDevice
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 8 Mar 2011 18:16:45 +0000 (13:16 -0500)]
Demote complaint about no serial/wwn on block device from warning to debug
Now that we're using block devices instead of scsi devices for this,
it's far more common to run into block devices without any serial
number or WWN.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 8 Mar 2011 18:10:01 +0000 (13:10 -0500)]
Minor updates
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 6 Mar 2011 15:08:30 +0000 (10:08 -0500)]
Remove TODO
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 6 Mar 2011 15:01:03 +0000 (10:01 -0500)]
Fix PolicyKit policy file
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 6 Mar 2011 13:31:42 +0000 (08:31 -0500)]
Add UDisksClient
This class will be used for all the common things that clients such as
udisksctl(1) and palimpsest will need to do.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sat, 5 Mar 2011 15:50:03 +0000 (10:50 -0500)]
Improve how data is collected in the fallback branch for LUN
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sat, 5 Mar 2011 15:44:50 +0000 (10:44 -0500)]
Use block instead of scsi devices for LUNs
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Fri, 4 Mar 2011 18:13:37 +0000 (13:13 -0500)]
Actually make the libudisks2 library work for 3rd party apps
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 2 Mar 2011 19:56:25 +0000 (14:56 -0500)]
Rename Drive to LUN
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 2 Mar 2011 19:42:45 +0000 (14:42 -0500)]
Handle removing a drive correctly
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 17 Feb 2011 19:22:22 +0000 (14:22 -0500)]
Don't show partitions in udisksctl status output
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 17 Feb 2011 19:00:28 +0000 (14:00 -0500)]
Rework how serial numbers are handled
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 17 Feb 2011 16:36:14 +0000 (11:36 -0500)]
Add a PreferredDevice property
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 17 Feb 2011 16:19:06 +0000 (11:19 -0500)]
Fix spelling of property names
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 17 Feb 2011 15:57:13 +0000 (10:57 -0500)]
Add properties for partition tables and entries
Right now we rely on the existing UDISKS_PARTITION* properties from an
existing udisks 1.x installation. Long-term we are going to switch to
the blkid stuff.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 16 Feb 2011 20:30:00 +0000 (15:30 -0500)]
Fix up docs
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 16 Feb 2011 20:26:12 +0000 (15:26 -0500)]
Move contents of BlockDevice.Probed and Filesystem into the BlockDevice iface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 16 Feb 2011 18:46:07 +0000 (13:46 -0500)]
Avoid multiple Drive objects with the same VPD
So the way this works is that with multiple paths, more than one block
device will point to the Drive in question.
$ ./udisksctl status
PORT MODEL REVISION SERIAL BLOCK
--------------------------------------------------------------------------------
HP LOGICAL VOLUME 3.00
5001438008F61790 sda sda1 sda2
SEAGATE ST3300657SS 0006 3SJ1QNMQ00009052NECM sdan sdl
SEAGATE ST3300657SS 0006 3SJ1RFP900009051HZ5S sdaf sdd
SEAGATE ST3300657SS 0006 3SJ1RJS700009050VYEA sdal sdj
SEAGATE ST3300657SS 0006 3SJ1RPFJ00009052BZ10 sdah sdf
SEAGATE ST3300657SS 0006 3SJ1RSJC00009052MWTB sdam sdk
SEAGATE ST3300657SS 0006 3SJ1RWZ100009101T12H sdai sdg
SEAGATE ST3300657SS 0006 3SJ1S3NE00009101TB5Y sdao sdm
SEAGATE ST3300657SS 0006 3SJ1S40K00009101T1XU sdak sdi
SEAGATE ST3300657SS 0006 3SJ1S4MH00009052RG6Z sdae sdc
SEAGATE ST3300657SS 0006 3SJ1S66L00009052QGZA sdag sde
SEAGATE ST3300657SS 0006 3SJ1S7C500009052RKPP sdaj sdh
SEAGATE ST3300657SS 0006 3SJ1S7K600009051M0CE sdad sdb
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30010853 sds
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30012560 sdn
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30014347 sdac
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30021345 sdaa
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30024753 sdt
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30025874 sdw
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30030732 sdr
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30031826 sdv
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30032003 sdz
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30039741 sdp
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30063724 sdx
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30064055 sdq
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30064486 sdy
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30064749 sdo
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30065104 sdu
WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30067287 sdab
Still need to hook up support for dm-multipath such that we get e.g.
SEAGATE ST3300657SS 0006 3SJ1QNMQ00009052NECM sdan sdl mpatha
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 16 Feb 2011 17:04:15 +0000 (12:04 -0500)]
Drop Controller, AtaDrive and ScsiDrive interfaces (for now)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Wed, 16 Feb 2011 16:26:05 +0000 (11:26 -0500)]
Move object path and interface names to the UDisks2 name-space
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Feb 2011 19:59:18 +0000 (14:59 -0500)]
Probe LUNs for device information
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Feb 2011 19:41:22 +0000 (14:41 -0500)]
Nuke all custom udev rules
Current code-base actually don't yet depend on these. Additionally,
the long-term plan is to have as few udev rules / custom probers as
possible - for example, we will use blkid(1)'s partition table probing
and so on.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Feb 2011 18:56:03 +0000 (13:56 -0500)]
Make parallel installable with udisks version 1
This includes renaming a bunch of stuff so we don't conflict. For now
we ignore collisions in man pages. We still have to rename object
paths and interfaces.
Also bump to version 1.90. First stable release will be 2.0.
Another huge user-visible change is that the udisks(1) command has
been renamed to udisksctl(1).
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Feb 2011 16:59:34 +0000 (11:59 -0500)]
For now, don't enable -Werror by default, not even in maintainer mode
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Tue, 15 Feb 2011 16:27:59 +0000 (11:27 -0500)]
Catch up with latest gdbus-codegen
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 8 Nov 2010 15:25:39 +0000 (10:25 -0500)]
Show controllers
Signed-off-by: David Zeuthen <davidz@redhat.com>
Martin Pitt [Wed, 3 Nov 2010 22:15:36 +0000 (18:15 -0400)]
Fix uninitialized variables in mounted_fs_entry_is_valid()
Don't unref uninizialized variables in mounted_fs_entry_is_valid() if the hash
table lookup fails and we exit (goto out) early.
Fixes this compiler warning/error:
cc1: warnings being treated as errors
udiskspersistentstore.c: In function ‘udisks_persistent_store_mounted_fs_cleanup’:
udiskspersistentstore.c:563:13: error: ‘block_device_file_value’ may be used uninitialized in this function
Martin Pitt [Wed, 3 Nov 2010 22:08:23 +0000 (18:08 -0400)]
Fix uninitialized variables in udisks_daemon_log_valist()
Assert that we don't get an undefined log level in udisks_daemon_log_valist().
This avoids falling through the switch and using uninitialized string
variables.
Fixes these warnings/errors:
cc1: warnings being treated as errors
udisksdaemon.c: In function ‘udisks_daemon_log’:
udisksdaemon.c:782:16: error: ‘level_str’ may be used uninitialized in this function
udisksdaemon.c:783:16: error: ‘level_color_str’ may be used uninitialized in this function
udisksdaemon.c:784:8: error: ‘syslog_priority’ may be used uninitialized in this function
David Zeuthen [Tue, 2 Nov 2010 14:03:27 +0000 (10:03 -0400)]
Add a --controller option to 'udisks info'
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 22:11:08 +0000 (18:11 -0400)]
Add Address and PhysicalSlot properties to Controller interface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 21:47:20 +0000 (17:47 -0400)]
Add missing files
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 21:46:10 +0000 (17:46 -0400)]
Add org.freedesktop.UDisks.Controller interface
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 18:27:17 +0000 (14:27 -0400)]
Add --drive option to info verb of udisks(1) command
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 18:11:31 +0000 (14:11 -0400)]
Show block device in status output
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 17:28:12 +0000 (13:28 -0400)]
Properly sort according to CTDS
So it looks like e.g. this
$ udisks status
CTDS MODEL REVISION SERIAL BLOCK
--------------------------------------------------------------------------------
0:0:0:0 SEAGATE ST3300657SS 0006 3SJ1S7K600009051M0CE -
0:0:1:0 SEAGATE ST3300657SS 0006 3SJ1S4MH00009052RG6Z -
0:0:2:0 SEAGATE ST3300657SS 0006 3SJ1RFP900009051HZ5S -
0:0:3:0 SEAGATE ST3300657SS 0006 3SJ1S66L00009052QGZA -
0:0:4:0 SEAGATE ST3300657SS 0006 3SJ1RPFJ00009052BZ10 -
0:0:5:0 SEAGATE ST3300657SS 0006 3SJ1RWZ100009101T12H -
0:0:6:0 SEAGATE ST3300657SS 0006 3SJ1S7C500009052RKPP -
0:0:7:0 SEAGATE ST3300657SS 0006 3SJ1S40K00009101T1XU -
0:0:8:0 SEAGATE ST3300657SS 0006 3SJ1RJS700009050VYEA -
0:0:9:0 SEAGATE ST3300657SS 0006 3SJ1RSJC00009052MWTB -
0:0:10:0 SEAGATE ST3300657SS 0006 3SJ1QNMQ00009052NECM -
0:0:11:0 SEAGATE ST3300657SS 0006 3SJ1S3NE00009101TB5Y -
0:0:13:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30012560 -
0:0:14:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30064749 -
0:0:15:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30039741 -
0:0:16:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30064055 -
0:0:17:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30030732 -
0:0:18:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30010853 -
0:0:19:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30024753 -
0:0:20:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30065104 -
0:0:21:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30031826 -
0:0:22:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30025874 -
0:0:23:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30063724 -
0:0:24:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30064486 -
0:0:25:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30032003 -
0:0:26:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30021345 -
0:0:27:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30067287 -
0:0:28:0 WDC WD1002FAEX-00Y9A0 01.01V10 WD-WCAW30014347 -
0:0:30:0 SEAGATE ST3300657SS 0006 3SJ1S7K600009051M0CE -
0:0:31:0 SEAGATE ST3300657SS 0006 3SJ1S4MH00009052RG6Z -
0:0:32:0 SEAGATE ST3300657SS 0006 3SJ1RFP900009051HZ5S -
0:0:33:0 SEAGATE ST3300657SS 0006 3SJ1S66L00009052QGZA -
0:0:34:0 SEAGATE ST3300657SS 0006 3SJ1RPFJ00009052BZ10 -
0:0:35:0 SEAGATE ST3300657SS 0006 3SJ1RWZ100009101T12H -
0:0:36:0 SEAGATE ST3300657SS 0006 3SJ1S7C500009052RKPP -
0:0:37:0 SEAGATE ST3300657SS 0006 3SJ1S40K00009101T1XU -
0:0:38:0 SEAGATE ST3300657SS 0006 3SJ1RJS700009050VYEA -
0:0:39:0 SEAGATE ST3300657SS 0006 3SJ1RSJC00009052MWTB -
0:0:40:0 SEAGATE ST3300657SS 0006 3SJ1QNMQ00009052NECM -
0:0:41:0 SEAGATE ST3300657SS 0006 3SJ1S3NE00009101TB5Y -
1:0:0:0 HP LOGICAL VOLUME 3.00
5001438008F61790 -
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 17:15:08 +0000 (13:15 -0400)]
Add a 'status' verb to udisks(1)
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 15:21:20 +0000 (11:21 -0400)]
Improve drive object paths slightly
Example:
$ udisks info --object-path drives/
drives/HP_LOGICAL_VOLUME_5001438008F61790
drives/SEAGATE_ST3300657SS_3SJ1QNMQ00009052NECM
drives/SEAGATE_ST3300657SS_3SJ1QNMQ00009052NECM_1
drives/SEAGATE_ST3300657SS_3SJ1RFP900009051HZ5S
drives/SEAGATE_ST3300657SS_3SJ1RFP900009051HZ5S_1
drives/SEAGATE_ST3300657SS_3SJ1RJS700009050VYEA
drives/SEAGATE_ST3300657SS_3SJ1RJS700009050VYEA_1
drives/SEAGATE_ST3300657SS_3SJ1RPFJ00009052BZ10
drives/SEAGATE_ST3300657SS_3SJ1RPFJ00009052BZ10_1
drives/SEAGATE_ST3300657SS_3SJ1RSJC00009052MWTB
drives/SEAGATE_ST3300657SS_3SJ1RSJC00009052MWTB_1
drives/SEAGATE_ST3300657SS_3SJ1RWZ100009101T12H
drives/SEAGATE_ST3300657SS_3SJ1RWZ100009101T12H_1
drives/SEAGATE_ST3300657SS_3SJ1S3NE00009101TB5Y
drives/SEAGATE_ST3300657SS_3SJ1S3NE00009101TB5Y_1
drives/SEAGATE_ST3300657SS_3SJ1S40K00009101T1XU
drives/SEAGATE_ST3300657SS_3SJ1S40K00009101T1XU_1
drives/SEAGATE_ST3300657SS_3SJ1S4MH00009052RG6Z
drives/SEAGATE_ST3300657SS_3SJ1S4MH00009052RG6Z_1
drives/SEAGATE_ST3300657SS_3SJ1S66L00009052QGZA
drives/SEAGATE_ST3300657SS_3SJ1S66L00009052QGZA_1
drives/SEAGATE_ST3300657SS_3SJ1S7C500009052RKPP
drives/SEAGATE_ST3300657SS_3SJ1S7C500009052RKPP_1
drives/SEAGATE_ST3300657SS_3SJ1S7K600009051M0CE
drives/SEAGATE_ST3300657SS_3SJ1S7K600009051M0CE_1
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30010853
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30012560
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30014347
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30021345
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30024753
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30025874
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30030732
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30031826
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30032003
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30039741
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30063724
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30064055
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30064486
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30064749
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30065104
drives/WDC_WD1002FAEX_00Y9A0_WD_WCAW30067287
Note that the SEAGATE drives appear twice because of multiple paths to
each drive (each SAS drive has two ports).
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Mon, 1 Nov 2010 14:59:25 +0000 (10:59 -0400)]
Catch up with latest gdbus-codegen and use this to make better drive paths
E.g.
$ udisks info --object-path drives/ <TAB>
drives/INTEL_20SSDSA2MH080G1GCCVEM842101HD080DGN
drives/MATSHITADVD_2fCDRW_20UJDA775
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Sun, 31 Oct 2010 16:16:58 +0000 (12:16 -0400)]
Only consider SCSI devices with type 0x00 and 0x05 as drives
Signed-off-by: David Zeuthen <davidz@redhat.com>