review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

reed@google.com [Wed, 13 Nov 2013 16:02:18 +0000 (16:02 +0000)]

Revert "Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice""

This reverts commit ff0152ec5e2a0faf38ae1a317c5d77df08139104.

BUG=

Review URL: https://codereview.chromium.org/68203018

git-svn-id: http://skia.googlecode.com/svn/trunk@12271 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 13 Nov 2013 15:22:15 +0000 (15:22 +0000)]

drawPosTextOnPath is now deprecated, removing all overrides and impls

BUG=
R=djsollen@google.com

Review URL: https://codereview.chromium.org/61743017

git-svn-id: http://skia.googlecode.com/svn/trunk@12270 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 13 Nov 2013 15:04:41 +0000 (15:04 +0000)]

Whitespace change: Updates should be fixed

Review URL: https://codereview.chromium.org/59623010

git-svn-id: http://skia.googlecode.com/svn/trunk@12269 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 13 Nov 2013 14:26:52 +0000 (14:26 +0000)]

"Fix" another crash in DeferredCanvasTest on valgrind bot

https://codereview.chromium.org/71463003/

git-svn-id: http://skia.googlecode.com/svn/trunk@12265 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 13 Nov 2013 13:59:44 +0000 (13:59 +0000)]

Whitespace change to trigger builds after r12262.

"Fixes for auto-detecting access to the git mirror in Update"

Review URL: https://codereview.chromium.org/59533004

git-svn-id: http://skia.googlecode.com/svn/trunk@12263 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 13 Nov 2013 07:02:17 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12261 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 12 Nov 2013 22:27:30 +0000 (22:27 +0000)]

Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice"

This reverts commit 72958c374bdb9457419beeba7de1387da3293882.

BUG=

Review URL: https://codereview.chromium.org/58933007

git-svn-id: http://skia.googlecode.com/svn/trunk@12260 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 12 Nov 2013 22:14:08 +0000 (22:14 +0000)]

switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice

BUG=
R=robertphillips@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/70473003

git-svn-id: http://skia.googlecode.com/svn/trunk@12259 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 12 Nov 2013 21:56:39 +0000 (21:56 +0000)]

pdfviewer: remove sqrt from the formula computing the scale (DPI is dots per inch, not dots per square inch)

Review URL: https://codereview.chromium.org/70793003

git-svn-id: http://skia.googlecode.com/svn/trunk@12258 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Tue, 12 Nov 2013 20:58:41 +0000 (20:58 +0000)]

Rebaseline bench expectations for tabl_theverge.skp_tile_256x256_grid.

git-svn-id: http://skia.googlecode.com/svn/trunk@12257 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 20:53:05 +0000 (20:53 +0000)]

Hide implementation details: SkFrontBufferedStream

R=reed@google.com

Review URL: https://codereview.chromium.org/25581002

git-svn-id: http://skia.googlecode.com/svn/trunk@12256 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 12 Nov 2013 20:43:34 +0000 (20:43 +0000)]

Ignore Windows verylargebitmap GMs for 565 and 8888

BUG=Skia:1822
R=robertphillips@google.com, reed@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/68123010

git-svn-id: http://skia.googlecode.com/svn/trunk@12255 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 12 Nov 2013 19:36:14 +0000 (19:36 +0000)]

[PDF] Speculative fix for chrome crash w/ SRC xfer mode.

BUG=chromium:316546
R=edisonn@google.com, reed@google.com

Author: vandebo@chromium.org

Review URL: https://codereview.chromium.org/61153003

git-svn-id: http://skia.googlecode.com/svn/trunk@12253 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Tue, 12 Nov 2013 18:29:17 +0000 (18:29 +0000)]

fix multithread related crashes in skpdiff

BUG=skia:1798
R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/60833002

git-svn-id: http://skia.googlecode.com/svn/trunk@12252 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 12 Nov 2013 18:16:34 +0000 (18:16 +0000)]

Remove deprecated setIsOpaque() API from SkBitmap.

Clients we care (Blink, Chromium) were updated, so we can remove this now.

BUG=None
R=bsalomon@google.com, reed@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/66723017

git-svn-id: http://skia.googlecode.com/svn/trunk@12251 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 12 Nov 2013 17:44:28 +0000 (17:44 +0000)]

pdfviewer: compile pdfviewer in gm, only if the flag is set (currently we compile pdfviewer, even if it is not used)

R=scroggo@google.com, jvanverth@google.com

Author: edisonn@google.com

Review URL: https://codereview.chromium.org/68533003

git-svn-id: http://skia.googlecode.com/svn/trunk@12249 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 12 Nov 2013 17:33:02 +0000 (17:33 +0000)]

"Fix" another crash on valgrind bot

https://codereview.chromium.org/70463002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12248 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 17:10:02 +0000 (17:10 +0000)]

Override drawRRect in fake SkBitmapDevices.

Recent changes to SkBitmapDevice modified ::drawRRect() to take
an optimized drawing case. Some subclasses of SkBitmapDevice were
depending on the old behavior of calling ::drawPath(). Since they
do not draw, attempting to take the drawing path can cause problems.
For these subclasses, call drawPath() in the subclass.

R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/70443002

git-svn-id: http://skia.googlecode.com/svn/trunk@12247 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Tue, 12 Nov 2013 16:46:43 +0000 (16:46 +0000)]

Remove some now-unused #ifdefs.

R=mtklein@google.com, mtklein, reed@google.com

Review URL: https://codereview.chromium.org/68473003

git-svn-id: http://skia.googlecode.com/svn/trunk@12246 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Tue, 12 Nov 2013 16:11:07 +0000 (16:11 +0000)]

add colortable enum to SkImage to ease interop between it and SkBitmap::Config

BUG=
R=halcanary@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/68853003

git-svn-id: http://skia.googlecode.com/svn/trunk@12245 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 15:30:06 +0000 (15:30 +0000)]

Clean up after longjmp in SkImageDecoder_libpng.

In onDecodeInit, if longjmp sends us back to setjmp, destroy the
png_struct and info_ptr before returning false. Since the
PNGAutoClean has not been created yet, we were previously
leaking resources.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/68453006

git-svn-id: http://skia.googlecode.com/svn/trunk@12244 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 15:25:31 +0000 (15:25 +0000)]

Make bench_compare executable.

(SkipBuildbotRuns)

Review URL: https://codereview.chromium.org/63153005

git-svn-id: http://skia.googlecode.com/svn/trunk@12243 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Tue, 12 Nov 2013 15:25:29 +0000 (15:25 +0000)]

Fix leak detected in FontMgrMatchGM::onDraw by Valgrind.

git-svn-id: http://skia.googlecode.com/svn/trunk@12242 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:52:47 +0000 (14:52 +0000)]

Add a script for running pdfviewer and comparing to existing results.

For quick, local checking to see how changes to pdfviewer have changed
PDF files.

Scripts were originally written by edisonn, and updated here for checkin.

R=epoger@google.com

Review URL: https://codereview.chromium.org/62103008

git-svn-id: http://skia.googlecode.com/svn/trunk@12241 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:43:44 +0000 (14:43 +0000)]

Use SkPathJoin and SkBasename in Pdfviewer.

Remove redundant code.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/68263003

git-svn-id: http://skia.googlecode.com/svn/trunk@12240 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:41:20 +0000 (14:41 +0000)]

Changes to make SkPDiff more robost.

bitmap_to_cielab now returns a boolean. Instead of asserting that the
config is 8888, copy to 8888 (and return false on failure). This allows
skpdiff to work on Index8 bitmaps (without changing the code that does
the real work). If it returns false, do not attempt to create a pmetric.

In pmetric, exit early if maxLevels is <= 2, since this would crash later
in the function (creation of an ImageL3D if maxLevels is 0, and then the
creation of an array of a negative number of entries). maxLevels is small
if the width or height of the image is small (i.e. a bitmap with width 1
has maxLevels of 0).

R=djsollen@google.com

Review URL: https://codereview.chromium.org/65253002

git-svn-id: http://skia.googlecode.com/svn/trunk@12239 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:38:41 +0000 (14:38 +0000)]

Create nonPOD before setjmp.

With PNGAutoClean created after setjmp, when longjmp is called its destructor
is never called. Create it before setjmp, ensuring that its destructor is
called.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/65283002

git-svn-id: http://skia.googlecode.com/svn/trunk@12238 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Tue, 12 Nov 2013 14:32:38 +0000 (14:32 +0000)]

Fix a memory leak in SkGPipeCanvas.

In cross process mode (currently unused but tested on the bots),
SkGPipeCanvas has a tangle of circular references, which prevents
it from being deleted. Break the chain of references.

R=junov@chromium.org

Review URL: https://codereview.chromium.org/69633003

git-svn-id: http://skia.googlecode.com/svn/trunk@12237 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 12 Nov 2013 14:05:15 +0000 (14:05 +0000)]

Silence another valgrind leak

https://codereview.chromium.org/68523006/

git-svn-id: http://skia.googlecode.com/svn/trunk@12236 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 12 Nov 2013 13:51:03 +0000 (13:51 +0000)]

Fix crash in tests on valgrind bot

https://codereview.chromium.org/63543005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12234 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Tue, 12 Nov 2013 13:49:52 +0000 (13:49 +0000)]

New SVG SKPs have been added to the buildbot repo. Triggering rebuilds.

git-svn-id: http://skia.googlecode.com/svn/trunk@12233 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 12 Nov 2013 07:02:05 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12232 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 12 Nov 2013 01:16:56 +0000 (01:16 +0000)]

Disable Blurred RR optimization in Chrome

https://codereview.chromium.org/68773005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12231 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 11 Nov 2013 20:55:15 +0000 (20:55 +0000)]

Implement DPI for perspective bitmaps in PDF - we save the bitmap at the resolution requested.

R=reed@google.com, vandebo@chromium.org

Review URL: https://codereview.chromium.org/54913004

git-svn-id: http://skia.googlecode.com/svn/trunk@12230 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Mon, 11 Nov 2013 20:54:09 +0000 (20:54 +0000)]

Hook in rough distance field support for fonts

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/41213003

git-svn-id: http://skia.googlecode.com/svn/trunk@12229 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 11 Nov 2013 20:12:34 +0000 (20:12 +0000)]

Implement a speedup for Y-only blurs by transposing.

R=mtklein@google.com, mtklein, reed@google.com
BUG=

Review URL: https://codereview.chromium.org/66413007

git-svn-id: http://skia.googlecode.com/svn/trunk@12227 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 11 Nov 2013 20:04:28 +0000 (20:04 +0000)]

Add another FontConfig suppression to valgrind suppressions

https://codereview.chromium.org/69403002/

git-svn-id: http://skia.googlecode.com/svn/trunk@12226 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 19:59:40 +0000 (19:59 +0000)]

The coloremoji GM should now look like it did before.

With r12224 we now check that a stream looks like a font
before trying to use it.

git-svn-id: http://skia.googlecode.com/svn/trunk@12225 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 19:52:29 +0000 (19:52 +0000)]

Make onCreateFromStream check that the stream looks like a font.

git-svn-id: http://skia.googlecode.com/svn/trunk@12224 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Mon, 11 Nov 2013 19:48:14 +0000 (19:48 +0000)]

Ignore coloremoji GM for now.

git-svn-id: http://skia.googlecode.com/svn/trunk@12223 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Mon, 11 Nov 2013 18:45:18 +0000 (18:45 +0000)]

Fix memory leak in filterRRectToNine

https://codereview.chromium.org/65723005/

git-svn-id: http://skia.googlecode.com/svn/trunk@12222 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 18:36:46 +0000 (18:36 +0000)]

Android FontHost cannot use FontMgr yet.

git-svn-id: http://skia.googlecode.com/svn/trunk@12221 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 17:49:42 +0000 (17:49 +0000)]

Give Android a SkFontMgr::Factory which was missing as of r12217.

git-svn-id: http://skia.googlecode.com/svn/trunk@12220 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Mon, 11 Nov 2013 16:48:51 +0000 (16:48 +0000)]

Implement a NEON version of morphology. This is good for ~2.2X speedup on Tegra3.

R=mtklein@google.com, mtklein, reed@google.com

Review URL: https://codereview.chromium.org/68123003

git-svn-id: http://skia.googlecode.com/svn/trunk@12219 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 16:26:55 +0000 (16:26 +0000)]

Re-add NULL FontMgr::Factory hadnling code removed in r12217.

git-svn-id: http://skia.googlecode.com/svn/trunk@12218 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Mon, 11 Nov 2013 15:53:29 +0000 (15:53 +0000)]

Remove SK_FONTHOST_USES_FONTMGR.

Review URL: https://codereview.chromium.org/66783003

git-svn-id: http://skia.googlecode.com/svn/trunk@12217 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 11 Nov 2013 15:36:44 +0000 (15:36 +0000)]

pdfviewer: fix build break in windows (wrong return type on function)

Review URL: https://codereview.chromium.org/68973002

git-svn-id: http://skia.googlecode.com/svn/trunk@12216 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 11 Nov 2013 15:10:47 +0000 (15:10 +0000)]

Initial draft code to run pdfviewer withg gms
draft cl to run pdfviewer with gms modified: gm/gmmain.cpp modified: gyp/gm.gyp modified: src/utils/SkPDFRasterizer.cpp modified: src/utils/SkPDFRasterizer.h

R=scroggo@google.com, borenet@google.com

Author: edisonn@google.com

Review URL: https://codereview.chromium.org/26269002

git-svn-id: http://skia.googlecode.com/svn/trunk@12214 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

jvanverth@google.com [Mon, 11 Nov 2013 14:36:54 +0000 (14:36 +0000)]

Update bench expectations.

git-svn-id: http://skia.googlecode.com/svn/trunk@12213 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Mon, 11 Nov 2013 13:43:22 +0000 (13:43 +0000)]

Specify --patchlevel 0 to trychange.py

For some reason, trychange.py creates patches with level 0, even from a git
repo. We were assuming that the patch level was 1 from a git repo, so patches
were failing to apply.

BUG=skia:1669
R=rmistry@google.com

Review URL: https://codereview.chromium.org/61733011

git-svn-id: http://skia.googlecode.com/svn/trunk@12212 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 10 Nov 2013 15:08:45 +0000 (15:08 +0000)]

Removed deprecated API calls that have crept in

git-svn-id: http://skia.googlecode.com/svn/trunk@12210 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Sun, 10 Nov 2013 14:40:21 +0000 (14:40 +0000)]

Re-enable SK_ATTR_DEPRECATED (i.e., revert r12067)

git-svn-id: http://skia.googlecode.com/svn/trunk@12209 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 9 Nov 2013 07:02:23 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12208 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Sat, 9 Nov 2013 04:45:18 +0000 (04:45 +0000)]

More new baselines for stragglerbots.

TBR=epoger
BUG=

Review URL: https://codereview.chromium.org/63173014

git-svn-id: http://skia.googlecode.com/svn/trunk@12207 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Sat, 9 Nov 2013 01:37:30 +0000 (01:37 +0000)]

add GM case nonclosedpaths. The 2 bugs below showed some non-closed paths which are easy to get wrong rendering results. So add a GM case for this kind paths to avoid potential bugs to be introduced.

BUG=skia:1782
BUG=skia:1811
R=bsalomon@google.com, caryclark@google.com, reed@google.com, robertphillips@google.com

Author: yunchao.he@intel.com

Review URL: https://codereview.chromium.org/64173009

git-svn-id: http://skia.googlecode.com/svn/trunk@12206 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 8 Nov 2013 21:24:40 +0000 (21:24 +0000)]

Blur rebaselines for some straggler bots that just caught up.

R=epoger
BUG=

Review URL: https://codereview.chromium.org/58853007

git-svn-id: http://skia.googlecode.com/svn/trunk@12205 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 8 Nov 2013 20:49:04 +0000 (20:49 +0000)]

SSE2 implementation of RGBA box blurs. This yields ~2X perf improvement on Xeon ES-2690.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/61643011

git-svn-id: http://skia.googlecode.com/svn/trunk@12204 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 20:14:16 +0000 (20:14 +0000)]

Add sk_float_rsqrt with SSE + NEON fast paths.

Current numbers:

N4:
running bench [640 480]      math_fastIsqrt    NONRENDERING: cmsecs =      3.12
running bench [640 480]      math_slowIsqrt    NONRENDERING: cmsecs =      4.82
running bench [640 480] math_sk_float_rsqrt    NONRENDERING: cmsecs =      1.99

Desktop:
running bench [640 480]      math_fastIsqrt    NONRENDERING: cmsecs =      0.89
running bench [640 480]      math_slowIsqrt    NONRENDERING: cmsecs =      0.94
running bench [640 480] math_sk_float_rsqrt    NONRENDERING: cmsecs =      0.09

Haven't found any other benches where this is a significant effect yet.

BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/60083014

git-svn-id: http://skia.googlecode.com/svn/trunk@12203 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 19:22:57 +0000 (19:22 +0000)]

Adding error checks to SkRBuffer

BUG=
R=robertphillips@google.com, bsalomon@google.com, reed@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/61913002

git-svn-id: http://skia.googlecode.com/svn/trunk@12202 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 18:45:27 +0000 (18:45 +0000)]

Fix stale assert in GrDrawTarget::print

Fix stale assert in GrDrawTarget::print.

R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/66333002

git-svn-id: http://skia.googlecode.com/svn/trunk@12201 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 8 Nov 2013 18:11:08 +0000 (18:11 +0000)]

fix compile error

git-svn-id: http://skia.googlecode.com/svn/trunk@12200 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 8 Nov 2013 18:05:02 +0000 (18:05 +0000)]

optimize floating pt, save a few instructions

git-svn-id: http://skia.googlecode.com/svn/trunk@12199 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 8 Nov 2013 18:02:53 +0000 (18:02 +0000)]

Add ability to ninepatch blurred rounded rectangle

Speed up drawing large blurry round rectangles by converting them to
nine patches.

SkDraw:
Add drawRRect.

SkBitmapDevice:
Call SkDraw::drawRRect instead of converting SkRRect to an SkPath.

SkMaskFilter/SkBlurMaskFilter:
Create a nine patch of a blurred round rect and draw it instead of
drawing the entire thing.

SkPDFDevice:
Override drawRRect to perform the old behavior in
SkBitmapDevice::drawRect.

Depends on https://codereview.chromium.org/52703003

Tests are in https://codereview.chromium.org/52793005

BUG=https://b.corp.google.com/issue?id=11174385
R=reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/48623006

git-svn-id: http://skia.googlecode.com/svn/trunk@12198 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Fri, 8 Nov 2013 18:00:01 +0000 (18:00 +0000)]

fix line intersection

git-svn-id: http://skia.googlecode.com/svn/trunk@12197 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 8 Nov 2013 17:50:14 +0000 (17:50 +0000)]

remove bogus assert, and remove outdated #ifdef

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/66923002

git-svn-id: http://skia.googlecode.com/svn/trunk@12196 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 8 Nov 2013 17:23:54 +0000 (17:23 +0000)]

rebaseline_server: improve thread locks to allow read access during updates
(SkipBuildbotRuns)
TBR=jcgregorio

Review URL: https://codereview.chromium.org/66803004

git-svn-id: http://skia.googlecode.com/svn/trunk@12195 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 8 Nov 2013 16:47:01 +0000 (16:47 +0000)]

New baselines for all currently-failing tests. All of these are minor pixel diffs, except for dashcubics_gpu on Tegra, whose baseline was previously missing.

TBR=robertphillips
BUG=

Review URL: https://codereview.chromium.org/67013002

git-svn-id: http://skia.googlecode.com/svn/trunk@12194 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 8 Nov 2013 16:25:25 +0000 (16:25 +0000)]

rebaseline_server: add pixel diffs, and sorting by diff metrics
(SkipBuildbotRuns)

R=bsalomon@google.com, jcgregorio@google.com

Review URL: https://codereview.chromium.org/59283006

git-svn-id: http://skia.googlecode.com/svn/trunk@12193 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 16:16:05 +0000 (16:16 +0000)]

ARM Skia NEON patches - 31 - Xfermode: xfer16
Xfermode: xfer16

This adds support for 16bit Xfermodes. It also tunes the gcc test
macros in xfer32() to add compatibility for gcc > 4.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/33063002

git-svn-id: http://skia.googlecode.com/svn/trunk@12192 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 15:51:12 +0000 (15:51 +0000)]

use quads for mixed radius rrects

Create a specialized version of adding a pair of corner quads
that avoids the overhead of the full arc machinery.

This is on the way to changing Chrome to calling Skia directly to create fully general round rects rather than rolling their own.

R=robertphillips@google.com, reed@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/60203002

git-svn-id: http://skia.googlecode.com/svn/trunk@12190 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 15:24:12 +0000 (15:24 +0000)]

Removed unnecessary define

BUG=
R=bsalomon@google.com, sugoi@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/59033009

git-svn-id: http://skia.googlecode.com/svn/trunk@12189 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 15:09:22 +0000 (15:09 +0000)]

Update bleed GM to use HQ filtering.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/61133002

git-svn-id: http://skia.googlecode.com/svn/trunk@12188 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 8 Nov 2013 14:42:56 +0000 (14:42 +0000)]

Revert "Do not apply hairline optimization for paths if nv_path_rendering is used"

This reverts commit r12185.

Review URL: https://codereview.chromium.org/66813002

git-svn-id: http://skia.googlecode.com/svn/trunk@12187 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 8 Nov 2013 07:01:56 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12186 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 8 Nov 2013 06:19:34 +0000 (06:19 +0000)]

Do not apply hairline optimization for paths if nv_path_rendering is used

Do not convert thin, non-hairline paths to hairline paths if
nv_path_rendering is used.

The current nv_path_rendering implementation does not render
hairlines. Rendering the hairlines with normal renderers cause
unneccessary gl program changes, which is quite slow.

Changes the behavior of non-nv_path_rendering paths to always perform
the optimization if the shape ends up being painted by the
path-drawing code (GrContext::drawPathInternal). Previously the
optimization was applied only when callgraph started with
SkCanvas::drawPath. This changes drawlooper_msaa4, dashing3_msaa4 and
dashing3_gpu

R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/38573007

git-svn-id: http://skia.googlecode.com/svn/trunk@12185 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 8 Nov 2013 04:08:34 +0000 (04:08 +0000)]

Rebaseline verylargebitmap test

Review URL: https://codereview.chromium.org/60733013

git-svn-id: http://skia.googlecode.com/svn/trunk@12184 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Fri, 8 Nov 2013 02:31:52 +0000 (02:31 +0000)]

New baselines for all imageblur-related tests.

TBR=robertphillips

Review URL: https://codereview.chromium.org/60803006

git-svn-id: http://skia.googlecode.com/svn/trunk@12183 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 7 Nov 2013 22:43:04 +0000 (22:43 +0000)]

Can't be leaving that crucial newline off the end of a file

git-svn-id: http://skia.googlecode.com/svn/trunk@12182 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 7 Nov 2013 22:25:21 +0000 (22:25 +0000)]

Add GM to verify removal of 32767 limit in SkBlurMaskFilter::filterRectsToNine is okay

https://codereview.chromium.org/60513013/

git-svn-id: http://skia.googlecode.com/svn/trunk@12181 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 7 Nov 2013 22:20:31 +0000 (22:20 +0000)]

"Fix" bug in debug canvas

https://codereview.chromium.org/59073008/

git-svn-id: http://skia.googlecode.com/svn/trunk@12180 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 7 Nov 2013 22:07:34 +0000 (22:07 +0000)]

pdfviewr: include what you use (stdio)

Review URL: https://codereview.chromium.org/64913003

git-svn-id: http://skia.googlecode.com/svn/trunk@12179 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 7 Nov 2013 22:06:08 +0000 (22:06 +0000)]

Added support for Chrome's gpu command buffer extension BindUniformLocation.

R=bsalomon@google.com, bsalomon

Author: skaslev@chromium.org

Review URL: https://codereview.chromium.org/62163004

git-svn-id: http://skia.googlecode.com/svn/trunk@12178 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 7 Nov 2013 20:33:17 +0000 (20:33 +0000)]

pdfviewer: fix typos (|| instead of |)

Review URL: https://codereview.chromium.org/65263002

git-svn-id: http://skia.googlecode.com/svn/trunk@12176 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 7 Nov 2013 19:40:35 +0000 (19:40 +0000)]

fix broken build on mac due to compiler warning

R=epoger@google.com

Review URL: https://codereview.chromium.org/64423004

git-svn-id: http://skia.googlecode.com/svn/trunk@12175 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

djsollen@google.com [Thu, 7 Nov 2013 19:24:06 +0000 (19:24 +0000)]

update skpdiff visualization (image magnification with alpha mask)

R=epoger@google.com

Review URL: https://codereview.chromium.org/29103005

git-svn-id: http://skia.googlecode.com/svn/trunk@12174 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

senorblanco@chromium.org [Thu, 7 Nov 2013 18:35:12 +0000 (18:35 +0000)]

Implement the y-transpose optimization in image (RGBA) blurs. This gives ~38% performance improvement on my Linux box. Also unify the box blur functions with a template.

R=mtklein@google.com, mtklein, reed@google.com

Review URL: https://codereview.chromium.org/59133006

git-svn-id: http://skia.googlecode.com/svn/trunk@12171 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Thu, 7 Nov 2013 18:22:18 +0000 (18:22 +0000)]

Fix Mac warning in PdfViewer.

Move a function only used by code guarded by #ifdef PDF_REPORT inside
guard.

R=edisonn@google.com

Review URL: https://codereview.chromium.org/60763003

git-svn-id: http://skia.googlecode.com/svn/trunk@12170 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 7 Nov 2013 16:36:46 +0000 (16:36 +0000)]

Mark Xoom scaled_tilemodes_npot GPU images as ignore

BUG=skia:1814

Review URL: https://codereview.chromium.org/61763011

git-svn-id: http://skia.googlecode.com/svn/trunk@12169 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 7 Nov 2013 16:34:53 +0000 (16:34 +0000)]

Fix for thin filled and hairline roundrects.

The roundrect renderer was dropping into the
ConvexPathRenderer when it didn't need to -- if a stroke is
just on the edge of being acceptable it will now use the
roundrect renderer.

BUG=Skia:1802
R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/59903005

git-svn-id: http://skia.googlecode.com/svn/trunk@12168 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 7 Nov 2013 16:06:53 +0000 (16:06 +0000)]

Revert "Revert "speed up A8 by creating a new entry-point in SkDraw that blits the path's coverage directly into an A8 target, regardless of the previous pixel values.""

This reverts commit 3c77887b3eb2d32ab668ab4e5f2f9e79103956e8.

BUG=

Review URL: https://codereview.chromium.org/50673005

git-svn-id: http://skia.googlecode.com/svn/trunk@12167 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 7 Nov 2013 15:57:32 +0000 (15:57 +0000)]

ARM Skia NEON patches - 33 - Convolution filter
NEON version of the convolutionProcs

The bitmap_scale benchmark is now twice as fast on ARM.

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=

Committed: http://code.google.com/p/skia/source/detail?r=12154

R=djsollen@google.com, mtklein@google.com, humper@google.com, epoger@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://codereview.chromium.org/27533004

git-svn-id: http://skia.googlecode.com/svn/trunk@12166 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Thu, 7 Nov 2013 13:43:03 +0000 (13:43 +0000)]

Whitespace change to trigger builds after r12163

Review URL: https://codereview.chromium.org/64283003

git-svn-id: http://skia.googlecode.com/svn/trunk@12165 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

rmistry@google.com [Thu, 7 Nov 2013 12:18:35 +0000 (12:18 +0000)]

Whitespace change to test master responsiveness.

git-svn-id: http://skia.googlecode.com/svn/trunk@12162 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 7 Nov 2013 07:02:19 +0000 (07:02 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@12161 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 7 Nov 2013 04:22:46 +0000 (04:22 +0000)]

whitespace change after killing trybots
BUG=skia:1810

git-svn-id: http://skia.googlecode.com/svn/trunk@12160 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 6 Nov 2013 20:58:25 +0000 (20:58 +0000)]

2nd whitespace change after git-repo filtering
BUG=skia:1808

git-svn-id: http://skia.googlecode.com/svn/trunk@12159 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 6 Nov 2013 20:44:12 +0000 (20:44 +0000)]

Whitespace commit after git-repo filtering
BUG=skia:1808

git-svn-id: http://skia.googlecode.com/svn/trunk@12158 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

vandebo@chromium.org [Wed, 6 Nov 2013 16:32:15 +0000 (16:32 +0000)]

Update gm flags so that it can be run without a pdf rasterizer.

BUG=1806
R=edisonn@google.com

Review URL: https://codereview.chromium.org/61643004

git-svn-id: http://skia.googlecode.com/svn/trunk@12157 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 6 Nov 2013 15:49:04 +0000 (15:49 +0000)]

Revert r12154
BUG=skia:1807

git-svn-id: http://skia.googlecode.com/svn/trunk@12156 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

halcanary@google.com [Wed, 6 Nov 2013 15:07:44 +0000 (15:07 +0000)]

New SkRTConf macro SK_CONF_TRY_SET: no complaint on missing configuration

SK_CONF_TRY_SET() is like SK_CONF_SET(), but doesn't complain if
confname can't be found.  This is useful if the SK_CONF_DECLARE is
inside a source file whose linkage is dependent on the system.

Internally to the SkRTConf system, SkRTConfRegistry::set() was given
an additional parameter controling wanrings.

A new RuntimeConfig unit test was introduced.  It should run silently.
In the future, it should be expanded to cover all of the SkRTConf
functionality.

(For example, the images.jpeg.suppressDecoderWarnings variable is
defined and used only in SkImageDecoder_libjpeg.cpp, but on MacOS, we
use Core Graphics via SkImageDecoder_CG.cpp - SkImageDecoder_libjpeg
is never linked in.  The same is true of the Windows Imaging Component
on Windows.)

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/54503007

git-svn-id: http://skia.googlecode.com/svn/trunk@12155 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;

RSS Atom