skia.committer@gmail.com [Tue, 26 Nov 2013 07:02:21 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12389
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Nov 2013 21:46:31 +0000 (21:46 +0000)]
Adding more validation
- Added a way to check that the number of inputs of a filter is not more than a filter expects
- Added validation of reftype in SkBitmap::unflatten()
- Added validation on fKD (diffuse lighting constant) and fKS (specular lighting constant) to make sure that they are always non-negative numbers
- Added validation of SkPerlinNoiseShader::fType and SkPerlinNoiseShader::fNumOctaves
BUG=
R=reed@google.com, senorblanco@google.com, mtklein@google.com, senorblanco@chromium.org, sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
83343003
git-svn-id: http://skia.googlecode.com/svn/trunk@12388
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Nov 2013 20:54:56 +0000 (20:54 +0000)]
Revert "remove kA1_Config, as it is no longer supported"
This reverts commit
2d72d8b242eac6e9d30228f5b0a407236491c369.
git-svn-id: http://skia.googlecode.com/svn/trunk@12387
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Nov 2013 20:39:27 +0000 (20:39 +0000)]
Export GrGLCreateNullInterface for use in Chromium compositor unit tests.
R=bsalomon@google.com
Author: mvujovic@adobe.com
Review URL: https://codereview.chromium.org/
86353002
git-svn-id: http://skia.googlecode.com/svn/trunk@12386
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Nov 2013 19:44:07 +0000 (19:44 +0000)]
remove SkFloatToScalar macro
BUG=
R=reed@google.com, djsollen@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
85463005
git-svn-id: http://skia.googlecode.com/svn/trunk@12385
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 25 Nov 2013 18:58:29 +0000 (18:58 +0000)]
remove kA1_Config, as it is no longer supported
BUG=
R=djsollen@google.com
Review URL: https://codereview.chromium.org/
83093005
git-svn-id: http://skia.googlecode.com/svn/trunk@12384
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Nov 2013 18:54:44 +0000 (18:54 +0000)]
Add logan to android_setup.sh
R=djsollen@google.com, bsalomon@google.com, robertphillips@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
82523006
git-svn-id: http://skia.googlecode.com/svn/trunk@12383
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 25 Nov 2013 18:13:33 +0000 (18:13 +0000)]
Rebaseline lingering (Ubuntu13) image for r12357
https://codereview.chromium.org/
85203004/
git-svn-id: http://skia.googlecode.com/svn/trunk@12382
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 25 Nov 2013 18:06:29 +0000 (18:06 +0000)]
rebaseline_server: remove deprecated-expectations-dir option
followup to https://codereview.chromium.org/
81243002/ ('rebaseline_server:
deprecate --expectations-dir option in advance of git transition')
(SkipBuildbotRuns)
R=borenet@google.com
Review URL: https://codereview.chromium.org/
86043002
git-svn-id: http://skia.googlecode.com/svn/trunk@12381
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Nov 2013 15:44:37 +0000 (15:44 +0000)]
Adding SkDeferredCanvas::NoticifationClient to the exported API.
R=reed@android.com, robertphillips@google.com, reed, robertphillips
BUG=1861
Author: schenney@chromium.org
Review URL: https://codereview.chromium.org/
83383007
git-svn-id: http://skia.googlecode.com/svn/trunk@12380
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 25 Nov 2013 15:05:05 +0000 (15:05 +0000)]
remove more unused static functions
git-svn-id: http://skia.googlecode.com/svn/trunk@12379
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 25 Nov 2013 14:36:58 +0000 (14:36 +0000)]
remove unused static function
git-svn-id: http://skia.googlecode.com/svn/trunk@12378
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 25 Nov 2013 14:18:21 +0000 (14:18 +0000)]
remove unused reduce order code
BUG=
Review URL: https://codereview.chromium.org/
85763002
git-svn-id: http://skia.googlecode.com/svn/trunk@12377
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Nov 2013 14:03:52 +0000 (14:03 +0000)]
Revert of https://codereview.chromium.org/
85343004/
Reason for revert: Reverting the temporary CL
TBR=
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
85823002
git-svn-id: http://skia.googlecode.com/svn/trunk@12376
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 25 Nov 2013 14:02:01 +0000 (14:02 +0000)]
Temporary changes to test one-click revert.
(SkipBuildbotRuns)
BUG=
NOTRY=true
TBR=borenet@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
85343004
git-svn-id: http://skia.googlecode.com/svn/trunk@12375
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 25 Nov 2013 13:39:12 +0000 (13:39 +0000)]
fix pathops quad line intersection
git-svn-id: http://skia.googlecode.com/svn/trunk@12374
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 24 Nov 2013 03:50:22 +0000 (03:50 +0000)]
Revert of https://1215-
da983df0eebc.chromiumcodereview-hr.appspot.com/
84603002/
Reason for revert: Testing one-click revert
TBR=
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
84523003
git-svn-id: http://skia.googlecode.com/svn/trunk@12373
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 24 Nov 2013 03:47:03 +0000 (03:47 +0000)]
Whitespace change to test CQ and one-click revert.
TBR=borenet@google.com
(SkipBuildbotRuns)
BUG=
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
84603002
git-svn-id: http://skia.googlecode.com/svn/trunk@12372
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 22 Nov 2013 21:25:55 +0000 (21:25 +0000)]
Inline performance-critical methods on SkAlphaRuns.
Clang needs to be forced to inline add, so we do that.
GCC on desktop
bench conf time old new diff diffP
draw_coverage_false 8888 c 236.08 212.01 +24.07 +10.2%
draw_coverage_true 8888 c 125.67 104.49 +21.18 +16.9%
GCC on N5
bench conf time old new diff diffP
draw_coverage_false 8888 c 566.33 529.96 +36.37 +6.4%
draw_coverage_true 8888 c 315.39 293.85 +21.54 +6.8%
Clang on desktop
bench conf time old new diff diffP
draw_coverage_false 8888 c 337.37 330.63 +6.74 +2.0%
draw_coverage_true 8888 c 126.87 119.32 +7.55 +6.0%
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
83243005
git-svn-id: http://skia.googlecode.com/svn/trunk@12370
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 22 Nov 2013 20:43:54 +0000 (20:43 +0000)]
I feel like my clang is especially sensitive to unused variables.
BUG=
Review URL: https://codereview.chromium.org/
82913006
git-svn-id: http://skia.googlecode.com/svn/trunk@12369
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 22 Nov 2013 20:34:59 +0000 (20:34 +0000)]
[GPU] Use view matrix + rect to implement subrect for drawBitmap when there is a mask filter and bleed.
R=robertphillips@google.com, reed@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
65133003
git-svn-id: http://skia.googlecode.com/svn/trunk@12368
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 22 Nov 2013 19:42:13 +0000 (19:42 +0000)]
Disable the save/clip/restore peephole optimization when a bounding hierarchy is used
This optimization is redundant with the state traversal optimization that is
performed by SkPictureStateTree and it introduces significant record time
overhead. Therefore it is better not to perform this optimization when using
a BBoxHierarchy.
BUG=1852
R=tomhudson@google.com, robertphillips@google.com, reed@google.com
Author: junov@chromium.org
Review URL: https://codereview.chromium.org/
79313003
git-svn-id: http://skia.googlecode.com/svn/trunk@12367
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 22 Nov 2013 19:26:18 +0000 (19:26 +0000)]
rebaseline_server: improve pixel diff reporting
- fix differing pixels count (we weren't always doing this right)
- report number of differing pixels, as well as percentage
- report worst difference per RGB channel
- apply alpha mask to difference image (changed pixels = opaque, unchanged = transparent)
- add tooltips with further explanation of pixel diffs
(SkipBuildbotRuns)
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
82823005
git-svn-id: http://skia.googlecode.com/svn/trunk@12366
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Fri, 22 Nov 2013 16:56:22 +0000 (16:56 +0000)]
Add SK_ALWAYS_INLINE.
I'm working on some code that's much faster when compiled by GCC than by Clang
because GCC inlines more aggressively. Using SK_ATTRIBUTE(always_inline) on
the appropriate methods narrows the performance gap considerably.
This should work for MSVC, GCC, and Clang, otherwise falling back to "inline".
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
83333005
git-svn-id: http://skia.googlecode.com/svn/trunk@12364
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 22 Nov 2013 16:43:14 +0000 (16:43 +0000)]
Fixing issues found by fuzzer
BUG=321802,321790
R=reed@google.com, senorblanco@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
83073005
git-svn-id: http://skia.googlecode.com/svn/trunk@12362
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 22 Nov 2013 14:32:27 +0000 (14:32 +0000)]
Laggard rebaselines for r12357
https://codereview.chromium.org/
82733005/
git-svn-id: http://skia.googlecode.com/svn/trunk@12360
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 22 Nov 2013 13:40:48 +0000 (13:40 +0000)]
Rebaseline dashing3 GMs for r12357
https://codereview.chromium.org/
83543002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12359
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 22 Nov 2013 07:02:24 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12358
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 22 Nov 2013 07:02:11 +0000 (07:02 +0000)]
Apply hairline optimization only if the path renderer wants it
Make the decision to convert thin, non-hairline paths to hairline
paths at the renderer level.
The current nv_path_rendering implementation does not render
hairlines. Rendering the hairlines with normal renderers cause
unneccessary gl program changes, which is quite slow.
Changes the behavior of non-nv_path_rendering paths to always perform
the optimization if the shape ends up being painted by a renderer that
wants the optimization. Previously the optimization was applied only
when callgraph started with SkCanvas::drawPath.
Applies the optimization for GrAAHairLineRenderer and
GrDefaultPathRenderer.
This changes gm results for dashing3_{msaa4,gpu} and drawlooper_msaa4.
R=bsalomon@google.com, jvanverth@google.com, rmistry@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
38573007
git-svn-id: http://skia.googlecode.com/svn/trunk@12357
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 21 Nov 2013 21:05:06 +0000 (21:05 +0000)]
move SkProcCoeffXfermode unflatten constructor into .cpp, and range-check its mode
BUG=
Review URL: https://codereview.chromium.org/
79543009
git-svn-id: http://skia.googlecode.com/svn/trunk@12355
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 21 Nov 2013 20:12:37 +0000 (20:12 +0000)]
Update ChromeOS expectations after warning changes
The diffs are tiny. They resulted from changes in between revisions
12307 and 12334, inclusive. We suspect the change is from r12314.
Would have gone in along with r12318, except the ChromeOS bots were
down at the time, and not generating new images.
Review URL: https://codereview.chromium.org/
77453011
git-svn-id: http://skia.googlecode.com/svn/trunk@12354
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 21 Nov 2013 18:47:01 +0000 (18:47 +0000)]
Remove unwanted gFTMutex from DirectWrite port.
This mutex exists because this file started life as a copy of the
FreeType port. There is no global library state to protect here,
so there is no need for the mutex.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
80983003
git-svn-id: http://skia.googlecode.com/svn/trunk@12353
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 21 Nov 2013 18:29:53 +0000 (18:29 +0000)]
fix compiler error where SK_SCALAR_IS_FLOAT is not defined. (attempt 2)
R=reed@google.com
Review URL: https://codereview.chromium.org/
81323002
git-svn-id: http://skia.googlecode.com/svn/trunk@12352
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 21 Nov 2013 18:11:34 +0000 (18:11 +0000)]
rebaseline_server: deprecate --expectations-dir option in advance of git transition
(SkipBuildbotRuns)
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
81243002
git-svn-id: http://skia.googlecode.com/svn/trunk@12351
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Thu, 21 Nov 2013 18:11:14 +0000 (18:11 +0000)]
Roll gyp deps from 1765 to 1796.
This also adds gyp_skia.py which defers to gyp_skia.
This matches Chromium usage and allows parallel gyp-ing
(now the default) to work on Windows.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
81073002
git-svn-id: http://skia.googlecode.com/svn/trunk@12350
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Thu, 21 Nov 2013 17:59:19 +0000 (17:59 +0000)]
fix compiler error where SK_SCALAR_IS_FLOAT is not defined.
Review URL: https://codereview.chromium.org/
80993004
git-svn-id: http://skia.googlecode.com/svn/trunk@12349
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Thu, 21 Nov 2013 17:50:15 +0000 (17:50 +0000)]
Fix SkScalar conversion warning.
TBR=scroggo@google.com
Review URL: https://codereview.chromium.org/
81293002
git-svn-id: http://skia.googlecode.com/svn/trunk@12348
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 17:20:17 +0000 (17:20 +0000)]
Fix VC++ ptr-to-... and va_list confusion
R=bungeman@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
78903006
git-svn-id: http://skia.googlecode.com/svn/trunk@12346
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 17:08:12 +0000 (17:08 +0000)]
Show basic SkPicture details in debugger.
R=robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
80223003
git-svn-id: http://skia.googlecode.com/svn/trunk@12345
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 17:04:29 +0000 (17:04 +0000)]
optimize pathops coverage
Remove unused code from SkOpSegment.cpp and friends.
Add new tests exposed by coverage.
Fix a bug exposed by coverage -- removing the need to detect points that are nearby when intersecting.
Add gyp rule for building coverage flavor on Mac.
R=mtklein@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
75453003
git-svn-id: http://skia.googlecode.com/svn/trunk@12344
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 15:57:40 +0000 (15:57 +0000)]
Minor fix in Ganesh shader generation.
R=bsalomon@google.com
Author: skaslev@chromium.org
Review URL: https://codereview.chromium.org/
78843006
git-svn-id: http://skia.googlecode.com/svn/trunk@12343
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 15:37:29 +0000 (15:37 +0000)]
Convert debugger settings controls to combo boxes.
This reduces the height of the settings panel significantly compared to
radio buttons.
With some luck, the debugger may now fit on non-4K monitors :)
R=bungeman@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
78843005
git-svn-id: http://skia.googlecode.com/svn/trunk@12342
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Thu, 21 Nov 2013 15:32:08 +0000 (15:32 +0000)]
Add SkImageGenerator Interface
- Add SkDiscardablePixelRef class that uses SkDiscardableMemory and
a SkImageGenerator.
- Add SkDecodingImageGenerator class as an example of a
SkImageGenerator.
- Add DecodingImageGenerator unit test.
- Add SkBasicDiscardableMemory implmentation for unit tests only.
R=reed@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
74793011
git-svn-id: http://skia.googlecode.com/svn/trunk@12341
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 15:23:15 +0000 (15:23 +0000)]
Avoid printing draw target info to stderr while running unit tests
Change draw target dump function to return a SkString. Clients can do
whatever they want with the string.
BUG=skia:1837
R=caryclark@google.com, bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
72353003
git-svn-id: http://skia.googlecode.com/svn/trunk@12340
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 15:22:18 +0000 (15:22 +0000)]
Remove mutex around image decoding in skpdiff.
I removed the mutex to investigate BUG=skia:1803, and I get no
crashes. The crashes may have been related to other multithreading
issues.
Removing the mutex will allow skpdiff to run faster.
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
61603008
git-svn-id: http://skia.googlecode.com/svn/trunk@12339
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 15:09:33 +0000 (15:09 +0000)]
Minor fixes for distance field fonts:
- Remove additional transform in drawpostext()
- Use bitmap fonts if rasterizer set in paint
- Correctly set scale ratio for drawtext()
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
79283004
git-svn-id: http://skia.googlecode.com/svn/trunk@12338
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 21 Nov 2013 14:24:16 +0000 (14:24 +0000)]
More Windows 64b compilation warning fixes
https://codereview.chromium.org/
47513017/
git-svn-id: http://skia.googlecode.com/svn/trunk@12337
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 13:41:37 +0000 (13:41 +0000)]
Make the debugger left panel resizable.
Use QSplitters to allow resizing the left debugger panels.
R=robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
79573002
git-svn-id: http://skia.googlecode.com/svn/trunk@12336
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 21 Nov 2013 07:02:36 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12335
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 21 Nov 2013 06:21:58 +0000 (06:21 +0000)]
Implement a benchmark for GrResourceCache
Adds "grresourcecache_add" and "grresourcecache_find" bench tests to test
GrResourceCache::add and GrResourceCache::find. The tests work only
with GPU backends, since GrResourceCache needs an GrGpu.
Modifies bench tests to override SkBenchmark::isSuitableFor(Backend)
function that specifies what kind of backend the test is inteded
for. This replaces the previous "fIsRendering" flag that would
indicate test that did no rendering.
Adds SkCanvas::getGrContext() call to get the GrContext that the
canvas ends up drawing to. The member function solves a common
use-case that is also used in the benchmark added here.
R=mtklein@google.com, bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
73643005
git-svn-id: http://skia.googlecode.com/svn/trunk@12334
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 20 Nov 2013 23:12:25 +0000 (23:12 +0000)]
Move PdfTokenLooper into its own file.
Otherwise, leave the class unchanged.
Review URL: https://codereview.chromium.org/
79773002
git-svn-id: http://skia.googlecode.com/svn/trunk@12333
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 20 Nov 2013 22:50:40 +0000 (22:50 +0000)]
Ifdef guard for SkPdfContext.
Review URL: https://codereview.chromium.org/
79723002
git-svn-id: http://skia.googlecode.com/svn/trunk@12332
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 20 Nov 2013 22:42:13 +0000 (22:42 +0000)]
Only SkFontMgr_New_DirectWrite should call GetSystemFontCollection.
Aside from the factory helper, there should be no calls to
IDWriteFactory::GetSystemFontCollection. All other code should work in
terms of IDWriteFontCollection for flexibility and correctness.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
77023006
git-svn-id: http://skia.googlecode.com/svn/trunk@12331
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 20 Nov 2013 22:33:39 +0000 (22:33 +0000)]
Move SkPdfContext into its own files.
Otherwise, the class is unchanged.
Review URL: https://codereview.chromium.org/
77763007
git-svn-id: http://skia.googlecode.com/svn/trunk@12330
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 20 Nov 2013 22:02:32 +0000 (22:02 +0000)]
Make changes based on talks with Edison.
Mostly FIXMEs, to go back and look at in more detail.
Fix a bug where ET did not set fTextBlock back to false.
Corresponds to notes in https://code.google.com/p/skia/source/detail?r=12270
git-svn-id: http://skia.googlecode.com/svn/trunk@12329
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 20 Nov 2013 21:40:57 +0000 (21:40 +0000)]
Changes to SkTDStackNester.
SkTDStackNester is a class used by PdfViewer to assist in saving
and restoring the PDF state. Clean up and test this class.
Add some documentation.
Add FIXME's where I have questions to resolve.
Fix a bug where fNestingLevel was not initialized.
Remove a commented out line of code copied over from
SkTDStack.
Rename SkTDStackNester::nests() to nestingLevel() and make it const.
Remove unnecessary predeclaration and friend declaration.
Remove index() (both const and non-const versions). They were
unused, return something that may not be expected (index from
the top, rather than from the bottom), and don't work to get any
elements in earlier Recs once the first one is full.
Report a warning if the nesting level goes above the maximum level,
or if we attempt to bring it below zero.
Prevent fNestingLevel from dropping below zero.
Add kUnusedObject_SkPdfIssue, and use it where appropriate.
Depends on https://codereview.chromium.org/
64093009/
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
68843006
git-svn-id: http://skia.googlecode.com/svn/trunk@12328
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 20 Nov 2013 21:32:27 +0000 (21:32 +0000)]
Fix SkMatrix44::invert(...) for identity matrices and a NULL parameter
Currently, to check if an SkMatrix44 is singular, we call ::invert(NULL) and
check the result. Usually this does no more work than is necessary. One
case where we do far too much work is if |this| is an identity matrix. In
this case, we do not early out and compute a (partial) determinant (we don't
do the full shebang because there are no perspective components).
BUG=None
R=ajuma@chromium.org, reed@google.com
Author: vollick@chromium.org
Review URL: https://codereview.chromium.org/
79333002
git-svn-id: http://skia.googlecode.com/svn/trunk@12327
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 20 Nov 2013 21:32:10 +0000 (21:32 +0000)]
Remove unnamed namespace usage from 'gm'.
Skia prefers static over unnamed namespaces.
BUG=None
TEST=None
R=bsalomon@google.com, robertphillips@google.com
Author: tfarina@chromium.org
Review URL: https://codereview.chromium.org/
79173002
git-svn-id: http://skia.googlecode.com/svn/trunk@12326
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 20 Nov 2013 20:47:21 +0000 (20:47 +0000)]
Move SkTDStackNester into its own private file.
Also remove depth(), which is unused.
Otherwise the class is unchanged.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
64093009
git-svn-id: http://skia.googlecode.com/svn/trunk@12324
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Wed, 20 Nov 2013 19:58:06 +0000 (19:58 +0000)]
rebaseline_server: clean up thread locks
followup to https://codereview.chromium.org/
66803004/ ('rebaseline_server: improve thread locks to allow read access during updates')
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/
64273011
git-svn-id: http://skia.googlecode.com/svn/trunk@12323
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 20 Nov 2013 18:06:10 +0000 (18:06 +0000)]
More common_conditions simplifications.
BUG=
R=bungeman@google.com, djsollen@google.com
Review URL: https://codereview.chromium.org/
78653002
git-svn-id: http://skia.googlecode.com/svn/trunk@12322
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 20 Nov 2013 18:02:00 +0000 (18:02 +0000)]
Hide unused gFormats.
Presumably this is WIP code? Otherwise, we delete it?
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
78503003
git-svn-id: http://skia.googlecode.com/svn/trunk@12321
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 20 Nov 2013 17:59:54 +0000 (17:59 +0000)]
GpuTest::GetContext() doesn't exist.
BUG=
R=bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
76143003
git-svn-id: http://skia.googlecode.com/svn/trunk@12320
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 20 Nov 2013 17:59:48 +0000 (17:59 +0000)]
Remove the SKIA_IGNORE_GPU_MIPMAPS now that Chrome sets glGenMipmap for
the skia GL interface.
R=bsalomon@google.com, humper@google.com
Author: skaslev@chromium.org
Review URL: https://codereview.chromium.org/
74783011
git-svn-id: http://skia.googlecode.com/svn/trunk@12319
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 20 Nov 2013 17:08:13 +0000 (17:08 +0000)]
Update expectations for Ubuntu x32 bot.
GM diffs are few, tiny, and unreproducable on our workstations.
BUG=
Review URL: https://codereview.chromium.org/
78913002
git-svn-id: http://skia.googlecode.com/svn/trunk@12318
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 20 Nov 2013 16:44:59 +0000 (16:44 +0000)]
Fix a warning building DM using ninja on Mac.
Here is the warning:
../../dm/DMTask.cpp: In copy constructor ‘DM::Task::Task(const DM::Task&)’:
../../dm/DMTask.cpp:17: warning: base class ‘class SkRunnable’ should be explicitly initialized in the copy constructor
Also add an SK_OVERRIDE.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
76903002
git-svn-id: http://skia.googlecode.com/svn/trunk@12317
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 20 Nov 2013 15:56:14 +0000 (15:56 +0000)]
Reverting r12315 (More Windows 64b compilation warning fixes) due to compilation failures
git-svn-id: http://skia.googlecode.com/svn/trunk@12316
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 20 Nov 2013 15:46:10 +0000 (15:46 +0000)]
More Windows 64b compilation warning fixes
https://codereview.chromium.org/
47513017/
git-svn-id: http://skia.googlecode.com/svn/trunk@12315
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 20 Nov 2013 15:13:49 +0000 (15:13 +0000)]
Add extra warnings to match what Android uses.
R=mtklein@google.com
Committed: https://code.google.com/p/skia/source/detail?r=12310
Review URL: https://codereview.chromium.org/
74193005
git-svn-id: http://skia.googlecode.com/svn/trunk@12314
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Wed, 20 Nov 2013 15:11:05 +0000 (15:11 +0000)]
De-generalize create_typeface on Windows.
The gdi and dw backends have a local create_typeface function.
This function is now called in only one place, onLegacyCreateTypeface.
Move the implementation into the caller.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
76763002
git-svn-id: http://skia.googlecode.com/svn/trunk@12313
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Wed, 20 Nov 2013 14:29:51 +0000 (14:29 +0000)]
Add missing (trivial) virtual destructors.
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
78543002
git-svn-id: http://skia.googlecode.com/svn/trunk@12312
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Wed, 20 Nov 2013 13:58:58 +0000 (13:58 +0000)]
Revert "Add extra warnings to match what Android uses."
This reverts commit
d234662df1ffeb1bf45b2ade16c4acfb94f89450.
This change broke the build. Will resubmit after fixing warnings.
git-svn-id: http://skia.googlecode.com/svn/trunk@12311
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 20 Nov 2013 13:16:47 +0000 (13:16 +0000)]
Add extra warnings to match what Android uses.
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
74193005
git-svn-id: http://skia.googlecode.com/svn/trunk@12310
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 20 Nov 2013 13:15:40 +0000 (13:15 +0000)]
fix bench so that if SK_SUPPORTS_GPU even when not provided as compiler option
In the case that SK_SUPPORTS_GPU is not provided to the compiler the value is
eithe defined in in the SkUserConfig.h or SkPostConfig.h. Prior to this change
those headers were not read prior to trying to include the GPU headers which
resulted in a failed compile.
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
76213004
git-svn-id: http://skia.googlecode.com/svn/trunk@12309
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 18 Nov 2013 21:29:36 +0000 (21:29 +0000)]
SkMemoryStream::setData should also set the current offset to 0.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
73273004
git-svn-id: http://skia.googlecode.com/svn/trunk@12308
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 18 Nov 2013 21:01:29 +0000 (21:01 +0000)]
Remove unused kMaxPOI.
BUG=
R=djsollen@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
62333026
git-svn-id: http://skia.googlecode.com/svn/trunk@12307
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 18 Nov 2013 20:55:29 +0000 (20:55 +0000)]
Revert SK_REQUIRE_LOCAL_VAR changes for DEPS roll.
BUG=
Review URL: https://codereview.chromium.org/
59703012
git-svn-id: http://skia.googlecode.com/svn/trunk@12306
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 18 Nov 2013 17:27:16 +0000 (17:27 +0000)]
Remove unnecessary includes.
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
68893028
git-svn-id: http://skia.googlecode.com/svn/trunk@12304
2bbb7eff-a529-9590-31e7-
b0007b416f81
mtklein@google.com [Mon, 18 Nov 2013 16:33:08 +0000 (16:33 +0000)]
Fix Windows build after the SkAutoFoo guard CL.
BUG=
Review URL: https://codereview.chromium.org/
66593004
git-svn-id: http://skia.googlecode.com/svn/trunk@12303
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 18 Nov 2013 16:26:25 +0000 (16:26 +0000)]
Fix DocumentTest/SkDocument memory leaks
https://codereview.chromium.org/
72833002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12302
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 18 Nov 2013 16:03:59 +0000 (16:03 +0000)]
Guard against most unintentionally ephemeral SkAutoFoo instantiations.
I think I applied the trick everywhere possible. Limitations:
- can't be used with templated classes
- all constructors and destructors must be defined inline
A couple of the SkAutoFoo were unused in Skia, Chromium, and Android, so I
deleted them. This change caught the same bugs Cary found in SkPath, plus one
more in SampleApp.
BUG=
R=reed@google.com, caryclark@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
72603005
git-svn-id: http://skia.googlecode.com/svn/trunk@12301
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 17 Nov 2013 16:19:11 +0000 (16:19 +0000)]
Whitespace change to test CQ.
TBR=
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
74723002
git-svn-id: http://skia.googlecode.com/svn/trunk@12300
2bbb7eff-a529-9590-31e7-
b0007b416f81
mike@reedtribe.org [Thu, 14 Nov 2013 20:15:51 +0000 (20:15 +0000)]
fix general-pespective for conical gradient bug=1744
BUG=
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
71303003
git-svn-id: http://skia.googlecode.com/svn/trunk@12299
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 14 Nov 2013 19:50:26 +0000 (19:50 +0000)]
Ignore GM dashing_gpu on Debug ANGLE
BUG=Skia:1844
Committed: http://code.google.com/p/skia/source/detail?r=12297
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
72993002
git-svn-id: http://skia.googlecode.com/svn/trunk@12298
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 14 Nov 2013 19:39:49 +0000 (19:39 +0000)]
Ignore GM dashing_gpu on Debug ANGLE
BUG=Skia:1844
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
72993002
git-svn-id: http://skia.googlecode.com/svn/trunk@12297
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 14 Nov 2013 19:09:27 +0000 (19:09 +0000)]
Pdfviewer refactoring.
Mostly superficial changes, to help me make sure I understand the
code while making modifications.
SkPdfRenderer:
First class I'm modifying. Move it into include/ and src/ directories.
Inherit from SkNoncopyable.
Replace load() with factory function which returns NULL if the load
fails.
Remove unload() and loaded(), which no longer make sense, since the
factory will return NULL on a failure to load, and unload() happens
on destruction.
Use a const char* for loading a PDF, following the convention of
SkStream::NewFromFile.
Remove unnecessary call to sqrt in SkPDFNativeRenderToBitmap.
Also in SkPDFNativeRenderToBitmap, use an appropriate SkScalar macro
to convert to an integer.
Use this-> when calling member functions.
pdf_viewer_main.cpp:
Call the new interface for SkPdfRenderer.
gyp files:
Refer to the new location of SkPdfRenderer.
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
59493011
git-svn-id: http://skia.googlecode.com/svn/trunk@12296
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 14 Nov 2013 19:02:41 +0000 (19:02 +0000)]
Add missing functions to SkNWayCanvas
R=reed@google.com
BUG=none
Author: enne@chromium.org
Review URL: https://codereview.chromium.org/
65513003
git-svn-id: http://skia.googlecode.com/svn/trunk@12295
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 14 Nov 2013 18:52:52 +0000 (18:52 +0000)]
Remove suppression of blurrect_outer
git-svn-id: http://skia.googlecode.com/svn/trunk@12294
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 14 Nov 2013 18:45:13 +0000 (18:45 +0000)]
rebaseline blurrect_outer images
https://codereview.chromium.org/
70103015/
git-svn-id: http://skia.googlecode.com/svn/trunk@12293
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 14 Nov 2013 17:05:05 +0000 (17:05 +0000)]
Fix warnings and Win only error in pdf_viewer.
git-svn-id: http://skia.googlecode.com/svn/trunk@12292
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 14 Nov 2013 16:53:22 +0000 (16:53 +0000)]
increase coverage of SkPath.cpp, remove unused code
Using Mike Klein's excellent coverage tool, increase the
unit testing of SkPath.cpp from 70% to 95%.
Along the way, determined that these functions were not
maintained or used:
SkPath::pathTo
SkPath::contains
as well as a large block of SkPath::cheapGetDirection().
Changed SkPath::validate() to permit infinities in
the path data points.
Fixed errors in preserving direction.
Fixed error setting direction when convexity is unknown.
Added missing conic to moveTo only detector.
BUG=
R=bsalomon@google.com, reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
65493004
git-svn-id: http://skia.googlecode.com/svn/trunk@12291
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 14 Nov 2013 16:35:35 +0000 (16:35 +0000)]
Rebaseline and re-enable rrect_aa, rrect_bw, simpleaaclip_aaclip, simpleaaclip_path, strokerect, strokes_round
git-svn-id: http://skia.googlecode.com/svn/trunk@12290
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 14 Nov 2013 16:01:23 +0000 (16:01 +0000)]
Include SkBitmapDevice for pdf_viewer.
git-svn-id: http://skia.googlecode.com/svn/trunk@12289
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 14 Nov 2013 15:46:25 +0000 (15:46 +0000)]
Include pdfviewer in everything.
This simplifies the process for building pdfviewer. Now it can be
built using
./gyp_skia
make pdfviewer
(ninja can also be used).
R=edisonn@google.com
Review URL: https://codereview.chromium.org/
70353003
git-svn-id: http://skia.googlecode.com/svn/trunk@12288
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 14 Nov 2013 14:47:56 +0000 (14:47 +0000)]
Address some more valgrind issues
R=borenet@google.com
Review URL: https://codereview.chromium.org/
59713010
git-svn-id: http://skia.googlecode.com/svn/trunk@12286
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Thu, 14 Nov 2013 14:43:16 +0000 (14:43 +0000)]
pdfviewer: ignore flanky test
Review URL: https://codereview.chromium.org/
64223008
git-svn-id: http://skia.googlecode.com/svn/trunk@12285
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 14 Nov 2013 07:02:31 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12283
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 13 Nov 2013 22:00:11 +0000 (22:00 +0000)]
Add rrect_aa and rrect_bw to ignore list
git-svn-id: http://skia.googlecode.com/svn/trunk@12282
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Wed, 13 Nov 2013 21:36:30 +0000 (21:36 +0000)]
Ignore failures for blurrect_outer (needs rebaselining).
git-svn-id: http://skia.googlecode.com/svn/trunk@12281
2bbb7eff-a529-9590-31e7-
b0007b416f81
edisonn@google.com [Wed, 13 Nov 2013 21:32:12 +0000 (21:32 +0000)]
pdfviewer: seed expectations for Mac 10.8 native renderer
Review URL: https://codereview.chromium.org/
61683010
git-svn-id: http://skia.googlecode.com/svn/trunk@12280
2bbb7eff-a529-9590-31e7-
b0007b416f81