platform/upstream/VK-GL-CTS.git
6 years agoLower correlation threshold in flush-finish tests again
Gurchetan Singh [Thu, 12 Oct 2017 17:44:21 +0000 (17:44 +0000)]
Lower correlation threshold in flush-finish tests again
am: 59f4fcde5a

Change-Id: I9b510ab7163cd135942a26f22ab5abdccaae2c76

6 years agoLower correlation threshold in flush-finish tests again
Gurchetan Singh [Fri, 6 Oct 2017 16:06:21 +0000 (09:06 -0700)]
Lower correlation threshold in flush-finish tests again

This test expects predictability from glFlush/glFinish timing.
In particular,  the code from FlushFinishCase::analyzeResults()
checks that the result falls within specific timing thresholds.

Notice that in the GLES3 specification, there is no requirement for
timing, just a guarantee that "commands [...] complete in finite time".
This is a problem because it makes the test very flaky, for example
if the CPU/GPU clocks are not ramping up fast enough.

BUG=b:67331095
TEST=Ran dEQP-GLES3.functional.flush_finish.finish on Elm for over 3+ hours
     Observed 1.5% to 2% flakiness without this patch. Observed no flakiness
     with this patch.

6 years agoDisable some UBO tests which got broken by recent glslang change am: d81d8e2af7
Chris Forbes [Tue, 3 Oct 2017 22:41:03 +0000 (22:41 +0000)]
Disable some UBO tests which got broken by recent glslang change am: d81d8e2af7
am: 3a1de9094d

Change-Id: I2bf5e7232412cfd54bb5321a9357262ba6f73116

6 years agoDisable some UBO tests which got broken by recent glslang change
Chris Forbes [Tue, 3 Oct 2017 22:23:11 +0000 (22:23 +0000)]
Disable some UBO tests which got broken by recent glslang change
am: d81d8e2af7

Change-Id: I1dadbabb85dfe7ecb5da296acb84a91538521e3e

6 years agoDisable some UBO tests which got broken by recent glslang change
Chris Forbes [Tue, 3 Oct 2017 17:17:59 +0000 (10:17 -0700)]
Disable some UBO tests which got broken by recent glslang change

Bug: b/67013571
Change-Id: I54c3f9aba636381a57e398de603b09dad4d14188

6 years agoUpdate owners file
Mika Isojrvi [Mon, 2 Oct 2017 20:47:33 +0000 (20:47 +0000)]
Update owners file
am: 412471299c

Change-Id: Ifcd38fa1f0eeaeeb37348793d897886182888d24

6 years agoUpdate owners file
Mika Isojärvi [Thu, 28 Sep 2017 17:25:24 +0000 (10:25 -0700)]
Update owners file

Test: build/make/tools/checkowners.py -c -v OWNERS
Change-Id: I117459d91f39055aaa5f0bc6abfbda32f31cdab2

6 years agoUse hidden visibility with GCC and Clang
Emil Velikov [Mon, 25 Sep 2017 22:31:22 +0000 (22:31 +0000)]
Use hidden visibility with GCC and Clang
am: 0fa7ebccc4

Change-Id: I556e6233f7af2818786fbc2798eec1658cf3a590

6 years agoAdd missing JNIEXPORT and JNICALL to createTestActivity() JNI call
Mika Isojrvi [Mon, 25 Sep 2017 22:31:20 +0000 (22:31 +0000)]
Add missing JNIEXPORT and JNICALL to createTestActivity() JNI call
am: 1e7c5746fb

Change-Id: Ie89e7d9aa13b0a29d5953a26d79a218c288eda53

6 years agoUse hidden visibility with GCC and Clang
Emil Velikov [Wed, 30 Aug 2017 14:12:14 +0000 (15:12 +0100)]
Use hidden visibility with GCC and Clang

The final result of the build are standalone executables, with all the
code statically linked.

Change the visibility to hidden, to avoid the symbol leakage and allow
the compiler to discard some code.

As a result the binary size is drastically decreased.

Total executable size on my setup drops by ~20%
 158M    before
 128M    after

Note: The binaries still export multiple unneeded symbols. Resolving
those is left as an exercise for later.

Test: full rebuild, running resulting binaries.

Change-Id: Ife10bbd123d59f4480349794785f13978516df30
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
6 years agoAdd missing JNIEXPORT and JNICALL to createTestActivity() JNI call
Mika Isojärvi [Fri, 8 Sep 2017 19:36:34 +0000 (12:36 -0700)]
Add missing JNIEXPORT and JNICALL to createTestActivity() JNI call

Test: Ran internal deqp tests on couple of Google devices
Change-Id: I08c8ff0a040261aaf60fa761158a12cccff987c2

6 years agoFix missing SSBO binding in EGL robustness tests am: 645b470b61
Mika Isojrvi [Fri, 22 Sep 2017 20:22:10 +0000 (20:22 +0000)]
Fix missing SSBO binding in EGL robustness tests am: 645b470b61
am: 87d4d9b276

Change-Id: I4d28d7578a19dbae243bd9386acd16b45809b358

6 years agoFix unused uniform bug in EGL robustness tests am: cd1ec788ec
Mika Isojrvi [Fri, 22 Sep 2017 20:22:04 +0000 (20:22 +0000)]
Fix unused uniform bug in EGL robustness tests am: cd1ec788ec
am: bb29eba5c0

Change-Id: I1741605596d31ea4097e698032b16f8c03217b60

6 years agoDo not use degenerate frames in EGL tests am: 8adce77ee5
Michael Chock [Fri, 22 Sep 2017 20:21:33 +0000 (20:21 +0000)]
Do not use degenerate frames in EGL tests am: 8adce77ee5
am: 4893ad697d

Change-Id: Id07cb2772285cf81ae26685dd4782a25ffb899e9

6 years agoExclude mutable image tests from Android CTS am: ae838ac1c9
Mika Isojrvi [Fri, 22 Sep 2017 20:21:30 +0000 (20:21 +0000)]
Exclude mutable image tests from Android CTS am: ae838ac1c9
am: 2c65a2676c

Change-Id: I1da36a9b7d337af85983258ed17b651b4c8806cb

6 years agoresolve merge conflicts of 9b726ab8 to master
Mika Isojärvi [Fri, 22 Sep 2017 20:21:08 +0000 (20:21 +0000)]
resolve merge conflicts of 9b726ab8 to master
am: 02473c7876

Change-Id: Ibd5f5c37ad2e3590fe5fa4d3512985178c0fb2a9

6 years agoFix missing SSBO binding in EGL robustness tests
Mika Isojrvi [Fri, 22 Sep 2017 20:18:06 +0000 (20:18 +0000)]
Fix missing SSBO binding in EGL robustness tests
am: 645b470b61

Change-Id: Iead5688ac950b539338d12f5d67d7fdf721e2425

6 years agoFix unused uniform bug in EGL robustness tests
Mika Isojrvi [Fri, 22 Sep 2017 20:18:04 +0000 (20:18 +0000)]
Fix unused uniform bug in EGL robustness tests
am: cd1ec788ec

Change-Id: If01714db26cabd3b12d6d1bac7d7cf32ce3ad381

6 years agoDo not use degenerate frames in EGL tests
Michael Chock [Fri, 22 Sep 2017 20:17:44 +0000 (20:17 +0000)]
Do not use degenerate frames in EGL tests
am: 8adce77ee5

Change-Id: If6e08077865264ff25bdf05a494f1d6e1799ba22

6 years agoExclude mutable image tests from Android CTS
Mika Isojrvi [Fri, 22 Sep 2017 20:17:38 +0000 (20:17 +0000)]
Exclude mutable image tests from Android CTS
am: ae838ac1c9

Change-Id: Iaee028a392f31f0af0b069ce1bf0dcd980bcbf3a

6 years agoresolve merge conflicts of 9b726ab8 to master
Mika Isojärvi [Fri, 22 Sep 2017 17:39:21 +0000 (10:39 -0700)]
resolve merge conflicts of 9b726ab8 to master

Test: Ran scripts/check_build_sanity.py build Android CTS.
Change-Id: Ibc797d43c71edee9a82592369f30d6a72bfcde2f

6 years agoFix missing SSBO binding in EGL robustness tests
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests

Bug: 64845581
Bug: 65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0

6 years agoFix unused uniform bug in EGL robustness tests
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests

Bug: 64845766
Bug: 65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127

6 years agoDo not use degenerate frames in EGL tests
Michael Chock [Mon, 14 Aug 2017 18:55:14 +0000 (11:55 -0700)]
Do not use degenerate frames in EGL tests

The dEQP-EGL.functional.buffer_age.* and
dEQP-EGL.functional.partial_update.* tests use randomly-generated frames
for rendering. The test allows the generation of frames with a width or
height of 0, but the tcu::PixelBufferAccess interface does not permit
0-sized subregions (see assertions inside getSubregion overloads in
tcuTextureUtil.cpp).

Skip the rendering of degenerate frames in the reference renderer, as
they are unsupported but would not affect the rendering if they were.

Bug: 65317274
Test: Ran tests on couple of Google devices
Change-Id: I3977c3c293715db633dde74132e56b5d9303ab28

6 years agoExclude mutable image tests from Android CTS
Mika Isojärvi [Mon, 18 Sep 2017 20:27:19 +0000 (13:27 -0700)]
Exclude mutable image tests from Android CTS

Bug: 65844886
Test: Ran scripts/check_build_sanity.py
Change-Id: Ia779ed1e9c3339f0e4ddb599647284c15f1aeaaf

6 years agofix a copy-paste error in wide_color tests
Tapani Plli [Mon, 18 Sep 2017 17:15:04 +0000 (17:15 +0000)]
fix a copy-paste error in wide_color tests
am: af7a952886

Change-Id: I97d11d9a5332be67cb79c3c2a5e8f268816d9373

6 years agofix a copy-paste error in wide_color tests
Tapani Pälli [Mon, 18 Sep 2017 10:31:04 +0000 (13:31 +0300)]
fix a copy-paste error in wide_color tests

Change "10:10:10:2" to "16:16:16:16" in checkFP16Support print out.

Change-Id: Id3eb25ed4f72b08fc1465af786177175579490ce
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
6 years agoMerge Vulkan CTS 1.0.2.6 into aosp/oreo-cts-dev
Mika Isojärvi [Fri, 15 Sep 2017 21:15:20 +0000 (14:15 -0700)]
Merge Vulkan CTS 1.0.2.6 into aosp/oreo-cts-dev

Bug: 65677277
Test: Run Android CTS deqp tests
Change-Id: I2ffb7d3929448e721f8097f323eaab011b445d8b

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am...
Pyry Haulos [Thu, 14 Sep 2017 05:26:14 +0000 (05:26 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2 am: 6d0cee6923
am: b2c811831a

Change-Id: I8b7782f37749cad734e667a98b981711ede6ebb3

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Thu, 14 Sep 2017 05:25:57 +0000 (05:25 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: b8e4ff4043 am: a2d901c3d8 am: 2431a0b0d9 am: 5fe6ec300f am: 781a2ef1e0 am: b85caaf64f
am: 71e31a40d0

Change-Id: Ib4fd2a45e25578e6f5b0c07cd3880d10fcc3f1ab

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Thu, 14 Sep 2017 05:25:36 +0000 (05:25 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: 5bd0fb31a1 am: 3558abf238 am: 222fa619e5 am: 37ce9a1ac7 am: 1801be75eb
am: 7a13186710

Change-Id: Iba3b94ec72f4a79c1824503ccde2080d5b9bb199

6 years agoCP: Add triangle edge guardband for Tex2D lookup diff am: e345d7b6ba
Kalle Raita [Thu, 14 Sep 2017 05:25:18 +0000 (05:25 +0000)]
CP: Add triangle edge guardband for Tex2D lookup diff am: e345d7b6ba
am: 4c1d622080

Change-Id: I46980d0de4e498ea6b34c3660100ef42207abb83

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e...
Mika Isojrvi [Thu, 14 Sep 2017 05:25:03 +0000 (05:25 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e am: 550064261f am: 1b81ecf035 am: 68d441aedd am: 088fbbc341 am: e3939224e7 am: 495df8aec0 am: 271d2c56f9
am: 9225c91f56

Change-Id: I05304de8f983d48f81095c5fb5da202ffcde588e

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac...
Mika Isojrvi [Thu, 14 Sep 2017 05:24:44 +0000 (05:24 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac am: 754e8f0192 am: d422ad8111 am: a8804ca914 am: 802854925b
am: 20b0bc0b90

Change-Id: Iae259f288e7ab9e5e8018d35d881fed878e04fa3

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3 am: d20475d813...
Mika Isojrvi [Thu, 14 Sep 2017 05:24:25 +0000 (05:24 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3 am: d20475d813 am: 66bd71c817 am: c06d76b076 am: 5e5d57c9d9
am: c390c23bce

Change-Id: Ia11b6baedab9da29a39a1d3062bebce1bd50f73e

6 years agoMask compared bits in atomic operation tests. am: b2ed9fbe1a am: 4d1d6446da am: b78f9...
Mika Isojrvi [Thu, 14 Sep 2017 05:24:05 +0000 (05:24 +0000)]
Mask compared bits in atomic operation tests. am: b2ed9fbe1a am: 4d1d6446da am: b78f9b0e57 am: c2180f74a8 am: 76b48a0db2 am: ff2205c90c am: bde0d133a4
am: 2649b40abc

Change-Id: Ib7d8baf77b6451a4e5a6a11c3d7f2a9d8e75953c

6 years agoMask compared bits in atomic operation tests. am: b2ed9fbe1a am: 4d1d6446da am: 6c0e0...
Mika Isojrvi [Thu, 14 Sep 2017 05:23:40 +0000 (05:23 +0000)]
Mask compared bits in atomic operation tests. am: b2ed9fbe1a am: 4d1d6446da am: 6c0e0ebde7 am: 371f033807 am: e64be738f6 am: a242f668a7 am: 7ed7199caf am: a921fc5252
am: aa0d12fbef

Change-Id: Idbcf6629200847deb6840ff516efb7e46d32faaf

6 years agoMask compared bits in atomic operation tests. am: b2ed9fbe1a am: e37b18673d am: 97ce4...
Mika Isojrvi [Thu, 14 Sep 2017 05:23:19 +0000 (05:23 +0000)]
Mask compared bits in atomic operation tests. am: b2ed9fbe1a am: e37b18673d am: 97ce4c6f8c am: 4c56c58687 am: 0ddc9faea1 am: d2d7d49296 am: 301312d147 am: 4dd9680c5d am: bf288e2971 am: 1678011b33 am: 14f0575d74
am: bd57c1986d

Change-Id: Ie53cb6206c1bea284ee1f4036b2fc710ba2d6133

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
Pyry Haulos [Thu, 14 Sep 2017 02:20:20 +0000 (02:20 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
am: 6d0cee6923

Change-Id: I7155ee4dfca234f42d6cdd02ac65f65a6b10d504

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Thu, 14 Sep 2017 02:20:00 +0000 (02:20 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: b8e4ff4043 am: a2d901c3d8 am: 2431a0b0d9 am: 5fe6ec300f am: 781a2ef1e0
am: b85caaf64f

Change-Id: I1ef65460f3e67367b871e9b601401ba767c6c674

6 years agoMerge "Fix extension support checks in negative api tests" into nougat-cts-dev am...
Graeme Leese [Thu, 14 Sep 2017 02:19:45 +0000 (02:19 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am: 4f1051ad32 am: 5bd0fb31a1 am: 3558abf238 am: 222fa619e5 am: 37ce9a1ac7
am: 1801be75eb

Change-Id: I7753a883d40e28eb6020218ee3ac1944d3f8d974

6 years agoCP: Add triangle edge guardband for Tex2D lookup diff
Kalle Raita [Thu, 14 Sep 2017 02:19:26 +0000 (02:19 +0000)]
CP: Add triangle edge guardband for Tex2D lookup diff
am: e345d7b6ba

Change-Id: I1d52d5d5d0cb5b1c53de7fc43e27f526680608e5

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e...
Mika Isojrvi [Thu, 14 Sep 2017 02:19:10 +0000 (02:19 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: b426d8bfad am: 580f143209 am: 73a16f417e am: 550064261f am: 1b81ecf035 am: 68d441aedd am: 088fbbc341 am: e3939224e7 am: 495df8aec0
am: 271d2c56f9

Change-Id: I0a239959cda4fce12548f79b20fe12a12519320c

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac...
Mika Isojrvi [Thu, 14 Sep 2017 02:18:56 +0000 (02:18 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: 6e80057a20 am: cae1fe52ac am: 754e8f0192 am: d422ad8111 am: a8804ca914
am: 802854925b

Change-Id: I1be013ce9a238f81e973ecff1eac9ad45dfaaa44

6 years agoFix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3 am: d20475d813...
Mika Isojrvi [Thu, 14 Sep 2017 02:18:38 +0000 (02:18 +0000)]
Fix atomic ssbo xor test am: f0fa05e898 am: 14cd264501 am: d4c01761d3 am: d20475d813 am: 66bd71c817 am: c06d76b076
am: 5e5d57c9d9

Change-Id: Ia837c1a5524aa4935fefcf015f3f832aba1e739e

6 years agoMask compared bits in atomic operation tests. am: b2ed9fbe1a am: 4d1d6446da am: b78f9...
Mika Isojrvi [Thu, 14 Sep 2017 02:18:18 +0000 (02:18 +0000)]
Mask compared bits in atomic operation tests. am: b2ed9fbe1a am: 4d1d6446da am: b78f9b0e57 am: c2180f74a8 am: 76b48a0db2 am: ff2205c90c
am: bde0d133a4

Change-Id: Id371d2842d97e3f5d3d52d2b107e8e3d74b80719

6 years agoMask compared bits in atomic operation tests. am: b2ed9fbe1a am: 4d1d6446da am: 6c0e0...
Mika Isojrvi [Thu, 14 Sep 2017 02:18:01 +0000 (02:18 +0000)]
Mask compared bits in atomic operation tests. am: b2ed9fbe1a am: 4d1d6446da am: 6c0e0ebde7 am: 371f033807 am: e64be738f6 am: a242f668a7 am: 7ed7199caf
am: a921fc5252

Change-Id: I0825b4f59d2fbc8485ff24f6eec748757e7f8f09

6 years agoMask compared bits in atomic operation tests. am: b2ed9fbe1a am: e37b18673d am: 97ce4...
Mika Isojrvi [Thu, 14 Sep 2017 02:17:29 +0000 (02:17 +0000)]
Mask compared bits in atomic operation tests. am: b2ed9fbe1a am: e37b18673d am: 97ce4c6f8c am: 4c56c58687 am: 0ddc9faea1 am: d2d7d49296 am: 301312d147 am: 4dd9680c5d am: bf288e2971 am: 1678011b33
am: 14f0575d74

Change-Id: I0e0ae598f390c38b1d57cb83d161ab6921020168

6 years agoCatch BAD_MATCH from createWindowSurface
Courtney Goeltzenleuchter [Wed, 13 Sep 2017 21:41:53 +0000 (21:41 +0000)]
Catch BAD_MATCH from createWindowSurface
am: 7df6c12492

Change-Id: I03ba8d57c83f0f50bdceeb9e91f8bd312cefd667

6 years agoRequire EGL_KHR_gl_colorspace for wide_color tests
Courtney Goeltzenleuchter [Wed, 13 Sep 2017 21:32:07 +0000 (21:32 +0000)]
Require EGL_KHR_gl_colorspace for wide_color tests
am: b446f2dd21

Change-Id: I3cee6f50232dcb639f4aba9e51c3c050b18bc2cc

6 years agoCatch BAD_MATCH from createWindowSurface
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 23:11:21 +0000 (17:11 -0600)]
Catch BAD_MATCH from createWindowSurface

On some platforms, it's possible to fail createWindowSurface
for some attribute combinations. Catch that case and return
NotSupported rather than a test failure.
Test: adb -d shell am start \
        -n com.drawelements.deqp/android.app.NativeActivity \
        -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
        --deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug: 65376495

Change-Id: I6546cbdfc011c7d26cfa3cdad7cc6f0df1b67122

6 years agoRequire EGL_KHR_gl_colorspace for wide_color tests
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 23:10:51 +0000 (17:10 -0600)]
Require EGL_KHR_gl_colorspace for wide_color tests

These tests utilize enum EGL_GL_COLORSPACE_KHR which is introduced by
EGL_KHR_gl_colorspace extension, check first for support and skip the
test if extension is not supported.

v2: loosen the check, only check when enum in use (Courtney)
v3: use EGL_NONE instead of DE_NULL when indicating that test
should use the default colorspace. That is do not include
the EGL_GL_COLORSPACE_KHR attribute in the appropriate
create function.
Test: adb -d shell am start \
      -n com.drawelements.deqp/android.app.NativeActivity \
      -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
      --deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug: 65291400

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
(cherry picked from commit fbf132dcf9467388408627bee73d90f7e8a1d401)

Change-Id: I6bd6423e6eb5fe4bb4df0222ab624c41446b0b60

6 years agoCheck for depthBounds support in shader builtin frag depth tests
Tony Wasserka [Tue, 12 Sep 2017 11:03:13 +0000 (12:03 +0100)]
Check for depthBounds support in shader builtin frag depth tests

Depth bounds testing was enabled without checking for feature support
in a couple of tests. With this change, tests that don't need this
feature leave it disabled, whereas other tests (currently only
dEQP-VK.glsl.builtin_var.fragdepth.*) now throw NotSupported when
the device doesn't support it.

Affects:

dEQP-VK.clipping.*
dEQP-VK.glsl.builtin_var.*

Components: Vulkan

VK-GL-CTS issue: 685

Change-Id: I44d94142e295ff135ad1a55d0d6e212b65994257

6 years agoFix handling of EGL_NONE as color space
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 14:10:14 +0000 (14:10 +0000)]
Fix handling of EGL_NONE as color space
am: dd7aa9e15d

Change-Id: Iae79d7d37f1147fca2c956a2497da0047e5c1176

6 years agoFix handling of EGL_NONE as color space
Courtney Goeltzenleuchter [Mon, 11 Sep 2017 19:06:48 +0000 (13:06 -0600)]
Fix handling of EGL_NONE as color space

Color space of EGL_NONE was getting passed down and
driver threw EGL_BAD_ATTRIBUTE in response.
Issue was caused when changing the colorspace from nullptr
to EGL_NONE, missed a couple of places that needed to
test against EGL_NONE instead of nullptr.

Bug: 65376495
Test: adb -d shell am start \
          -n com.drawelements.deqp/android.app.NativeActivity \
          -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
          --deqp-log-filename=/sdcard/dEQP-Log.qpa"'

Change-Id: If8812725be9d3858bf610c647ba53ff38944dd50
(cherry picked from commit 0d4e616c35fd3cbad82eb3c1f0a604dbbc6c8662)

6 years agoMerge changes Id437e220,I9d6b3fba
Kenneth Graunke [Mon, 11 Sep 2017 19:36:02 +0000 (19:36 +0000)]
Merge changes Id437e220,I9d6b3fba
am: 94b6d11640

Change-Id: Ide9468359dc4bdfd9e47a3f5f3aaa345d8096cd8

6 years agoMerge changes Id437e220,I9d6b3fba
Treehugger Robot [Mon, 11 Sep 2017 19:30:30 +0000 (19:30 +0000)]
Merge changes Id437e220,I9d6b3fba

* changes:
  Allow ES 3.2 contexts to run sRGB write control unsupported test.
  Require GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable

6 years agoMerge "Use 64-bit math in work group size assertion."
Kenneth Graunke [Mon, 11 Sep 2017 19:27:27 +0000 (19:27 +0000)]
Merge "Use 64-bit math in work group size assertion."
am: bc6743fe27

Change-Id: I8852b7cb4f89e1a7500cf5e216731a9b9f10ae31

6 years agoMerge "Delete incorrect invalid map tests."
Kenneth Graunke [Mon, 11 Sep 2017 19:27:13 +0000 (19:27 +0000)]
Merge "Delete incorrect invalid map tests."
am: 6352f3c7c0

Change-Id: I66916c3bcd4a064719062e3bb87c24c5f6ac2414

6 years agoMerge "Use 64-bit math in work group size assertion."
Treehugger Robot [Mon, 11 Sep 2017 18:58:52 +0000 (18:58 +0000)]
Merge "Use 64-bit math in work group size assertion."

6 years agoMerge "Delete incorrect invalid map tests."
Treehugger Robot [Mon, 11 Sep 2017 18:57:22 +0000 (18:57 +0000)]
Merge "Delete incorrect invalid map tests."

6 years agoAllow ES 3.2 contexts to run sRGB write control unsupported test.
Kenneth Graunke [Sat, 9 Sep 2017 06:30:15 +0000 (23:30 -0700)]
Allow ES 3.2 contexts to run sRGB write control unsupported test.

GL_EXT_sRGB_write_control functionality is not part of ES 3.2.
So there's no need to restrict this to older contexts.

Affects:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_unsupported_enum

Components: AOSP

Change-Id: Id437e220958c66acf65fd5c40004e1fde13fdf64

6 years agoRequire GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable
Kenneth Graunke [Sat, 9 Sep 2017 06:26:15 +0000 (23:26 -0700)]
Require GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable

This test required GL_EXT_sRGB_write_control or ES 3.2.  But glEnable
and glDisable of GL_FRAMEBUFFER_SRGB requires the extension - ES 3.2
doesn't provide that functionality.  ES 3.2 implementations without the
extension would fail.  Now they report NotSupported.

Affects:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled

Components: AOSP

Change-Id: I9d6b3fba892288354620ecbbc51ef7a351507e43

6 years agoDelete incorrect invalid map tests.
Kenneth Graunke [Fri, 8 Sep 2017 22:37:38 +0000 (15:37 -0700)]
Delete incorrect invalid map tests.

The citation given in these tests comes from the OpenGL man pages, which
are not authoritative.  The ES 3.2 specification says:

   "6.3.2 Effects of Mapping Buffers on Other GL Commands

    Any GL command which attempts to read from, write to, or change the
    state of a buffer object may generate an INVALID_OPERATION error if
    all or part of the buffer object is mapped. However, only commands
    which explicitly describe this error are required to do so. If an
    error is not generated, using such commands to perform invalid
    reads, writes, or state changes will have undefined results and may
    result in GL interruption or termination."

Importantly, it says "_may_ generate an INVALID_OPERATION error".  Some
drivers choose not to implement this to avoid the CPU overhead required
to enforce this optional restriction.

Affects:
- dEQP-GLES31.functional.debug.negative_coverage.*.vertex_array.*_invalid_map

Components: AOSP

Change-Id: I26eb6ac0dfffbfc50612bed44d1beb6eb3d366c9

6 years agoMerge "Relax EGL functional test thresholds"
james.glanville [Fri, 8 Sep 2017 21:39:27 +0000 (21:39 +0000)]
Merge "Relax EGL functional test thresholds"
am: a1ec716449

Change-Id: I719ba3fa67da541722ac65f2b5d2c847b98824e0

6 years agoMerge "Relax EGL functional test thresholds"
Treehugger Robot [Fri, 8 Sep 2017 21:25:48 +0000 (21:25 +0000)]
Merge "Relax EGL functional test thresholds"

6 years agoUse 64-bit math in work group size assertion.
Kenneth Graunke [Thu, 13 Jul 2017 01:44:11 +0000 (18:44 -0700)]
Use 64-bit math in work group size assertion.

If the maximum workgroup size in each dimension is large enough, this
can overflow, causing the comparison to fail.  For example, on Intel
Haswell, we get:

   assert(2048 * 2048 * 2048 > 2048) -> assert(0 > 2048) -> fail

Casting one value to deInt64 causes the multiplications to occur as
64-bit values, so we don't overflow.

Affects:

dEQP-GLES31.functional.debug.negative_coverage.*.compute.invalid_maximum_work_group_sizes

Components: AOSP

Change-Id: Ie03627a378f4fdc46ce241bbdd3693ae829c217d

6 years agoRelax EGL functional test thresholds
james.glanville [Tue, 29 Aug 2017 10:40:53 +0000 (11:40 +0100)]
Relax EGL functional test thresholds

The current threshold of 0.02 was selected as suitable for 8-bit color depths.
However, for smaller bit depths such as RGB565 this threshold is too strict
and it has been relaxed to allow a larger error for low bit depth formats.

Affects:
dEQP-EGL.functional.render.*

Change-Id: I6d6e061be02bc8e63cb5d9662feb804bc839d567

6 years agoMerge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2
Alexander Galazin [Fri, 8 Sep 2017 07:13:24 +0000 (09:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.0.1 into vk-gl-cts/vulkan-cts-1.0.2

Change-Id: Ied1a7d639c56dbdffd3db89085b4b771741e43f7

6 years agoChange required sample counts for storage images
Graeme Leese [Wed, 30 Aug 2017 15:37:14 +0000 (16:37 +0100)]
Change required sample counts for storage images

Update the API feature info tests to set requiredSampleCounts to 1 for
all images that are not usable as some type of framebuffer attachment.
Previously images that were not usable as attachments but could be used
as a storage image were incorrectly exempted from the requirement.

Components: Vulkan
VK-GL-CTS Issue: 645
Affects: dEQP-VK.api.info.image_format_properties.*

Change-Id: Ia0d09ad0ff51029b75cd3a264860a3dd63c249fb

6 years agoFix VK_KHR_maintenance2 extended_usage_bit tests
Boris Zanin [Thu, 7 Sep 2017 07:19:08 +0000 (09:19 +0200)]
Fix VK_KHR_maintenance2 extended_usage_bit tests

Due to test runs over uncompressed formats it cannot include
VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR bit.
Remove this bit from the tests.

Update tests:
 * dEQP-VK.image.extended_usage_bit.*

Components: Vulkan

VK-GL-CTS issue: 673, 614

Change-Id: I0adb26c5306a9d5f49936ffef070050fd5936faa

6 years agoFixup some missing/incorrect flushes and invalidates
Gary Sweet [Mon, 4 Sep 2017 10:14:58 +0000 (11:14 +0100)]
Fixup some missing/incorrect flushes and invalidates

Some of the flushes were too small, and there were a few
missing invalidates.

Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test

Components: Vulkan

VK-GL-CTS issue: 660

Change-Id: I27fac24397984f82865683f30b823570c3e52aed

6 years agoCheck for EGL_KHR_gl_colorspace before using it
Courtney Goeltzenleuchter [Wed, 6 Sep 2017 16:45:57 +0000 (16:45 +0000)]
Check for EGL_KHR_gl_colorspace before using it
am: 2cf32ffa6e

Change-Id: I862ea02e9803fc946a2e71e3145d806f76278676

6 years agoUse SRC image layout for copy image to buffer
Slawomir Cygan [Wed, 6 Sep 2017 14:47:04 +0000 (16:47 +0200)]
Use SRC image layout for copy image to buffer

The test was calling vkCmdCopyImageToBuffer with
VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL layout, which is not a valid
parameter value for this function (and not the layout the image is currently in).

Affects: dEQP-VK.memory.binding.*.*.image_*

Components: Vulkan

VK-GL-CTS issue: 666

Change-Id: Ifb5a1bd8726535de02a0dc134f5ac76a2734a661

6 years agoCheck for EGL_KHR_gl_colorspace before using it
Courtney Goeltzenleuchter [Tue, 5 Sep 2017 23:48:27 +0000 (17:48 -0600)]
Check for EGL_KHR_gl_colorspace before using it

Bug: 65376495
Test: adb -d shell am start \
        -n com.drawelements.deqp/android.app.NativeActivity \
        -e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
        --deqp-log-filename=/sdcard/dEQP-Log.qpa"'

Change-Id: Ief654c998e93d72899225120b0ca1ab2fa3ca624

6 years agoMerge "Add more allowed 'dot' alternatives"
Alexander Galazin [Tue, 5 Sep 2017 21:44:31 +0000 (21:44 +0000)]
Merge "Add more allowed 'dot' alternatives"
am: 7e8c3b2d00

Change-Id: I8ea74cc7658e034905be82c02fafc7f01b4e3705

6 years agoMerge "Add more allowed 'dot' alternatives"
Treehugger Robot [Tue, 5 Sep 2017 21:35:29 +0000 (21:35 +0000)]
Merge "Add more allowed 'dot' alternatives"

6 years agoFix unused uniform bug in EGL robustness tests
Mika Isojrvi [Tue, 5 Sep 2017 19:47:23 +0000 (19:47 +0000)]
Fix unused uniform bug in EGL robustness tests
am: 7806d74666

Change-Id: I7bdb3742437ed0abe590f5c011bf1b78cade9419

6 years agoDo not use ycbcr formats if ycbcr extension is not supported
Slawomir Cygan [Tue, 5 Sep 2017 14:39:12 +0000 (16:39 +0200)]
Do not use ycbcr formats if ycbcr extension is not supported

Spec says (on "vkGetPhysicalDeviceFormatProperties"):
"format must be a valid VkFormat value"

Formats from future or unsupported extensions do not
constitute a "valid VkFormat values".

Affects: dEQP-VK.memory.requirements.*.image.*

Components: Vulkan

VK-GL-CTS issue: 663

Change-Id: Ia284977b830d5fda14bcbd9d96010995d84014d5

6 years agoMerge "Fix missing SSBO binding in EGL robustness tests"
Mika Isojärvi [Tue, 5 Sep 2017 17:33:37 +0000 (17:33 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"
am: e19c3ff127

Change-Id: I4eadac66e4d313347a6b3fea1c4585bb98507641

6 years agoFix unused uniform bug in EGL robustness tests
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests

Bug: 64845766
Bug: 65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127

6 years agoMerge "Fix missing SSBO binding in EGL robustness tests"
Treehugger Robot [Tue, 5 Sep 2017 17:18:37 +0000 (17:18 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
Pyry Haulos [Tue, 5 Sep 2017 15:31:57 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20 am: 9e85a126d2
am: 342eb176e6

Change-Id: Iad7f205649553e7096d52a0cbf16d868ba405085

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
Pyry Haulos [Tue, 5 Sep 2017 15:22:27 +0000 (15:22 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
am: 9e85a126d2

Change-Id: I86a852a2216971095d4aa256a97f0b8e68e73646

6 years agoFix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
Pyry Haulos [Tue, 5 Sep 2017 15:21:58 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am: 0f672f2a20
am: 9e85a126d2

Change-Id: Ia7cd7612e6c2f0f961837734f1900a21b52a0e39

6 years agoFix issues in pipeline.timestamp.transfer_tests
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am: 0f672f2a20

Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e

6 years agoFixup some missing/incorrect flushes and invalidates
Gary Sweet [Mon, 4 Sep 2017 09:39:36 +0000 (10:39 +0100)]
Fixup some missing/incorrect flushes and invalidates

Some of the flushes were too small, and there were a few
missing invalidates.

Affects:
dEQP-VK.ssbo.layout.*
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test

Components: Vulkan

VK-GL-CTS issue: 660

Change-Id: Id29b59d127e004a028c04a1075db563d697140a1

6 years agoAdd more allowed 'dot' alternatives
Alexander Galazin [Tue, 22 Aug 2017 13:59:49 +0000 (15:59 +0200)]
Add more allowed 'dot' alternatives

Expanded dot may be re-associated in multiple ways.
Add all possible alternatives to prevent precision failures.

Components: AOSP

VK-GL-CTS issue: 634
Google issue: 28767510

Affects:
dEQP-GLES3.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES3.functional.shaders.builtin_functions.precision.reflect.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.reflect.*

Change-Id: I2a91add1b92363acab2172179320cd880da779ec

6 years agoFix missing SSBO binding in EGL robustness tests
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests

Bug: 64845581
Bug: 65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0

6 years agoWhitelist new extensions for VK 1.0.2.6
Daniel Koch [Thu, 31 Aug 2017 13:48:53 +0000 (09:48 -0400)]
Whitelist new extensions for VK 1.0.2.6

VK-GL-CTS issue: 653
Component: Vulkan
Affects:
dEQP-VK.api.info.device.extensions

Change-Id: I7f5ef7511ce8312e67833e07c154cd6b9fea6041

6 years agoAdd tests for image copies between YCbCr formats
Mika Isojärvi [Tue, 15 Aug 2017 23:57:24 +0000 (16:57 -0700)]
Add tests for image copies between YCbCr formats

Components: Vulkan, Framework
VK-GL-CTS issue: 111

Change-Id: I3a7050ae5605c4397cd678e14438f851a7cf48ce
(cherry picked from commit f24269bdd0c4d3801c2118b153082f0b0223f55a)

6 years agoAdd tests for VK_KHR_sampler_ycbcr_conversion
Mika Isojärvi [Tue, 16 May 2017 21:17:49 +0000 (14:17 -0700)]
Add tests for VK_KHR_sampler_ycbcr_conversion

Components: Vulkan, Framework
VK-GL-CTS issue: 111

Change-Id: Id0810b196f0a148903922df3fc08f1c5db88f86e
(cherry picked from commit 595b5f763a8f6ef1c68bfd133a55ded9c25ac101)

6 years agoTest VK_KHR_dedicated_allocation mem requirement queries
Boris Zanin [Fri, 12 May 2017 08:11:01 +0000 (10:11 +0200)]
Test VK_KHR_dedicated_allocation mem requirement queries

Add tests:
 * dEQP-VK.memory.requirements.dedicated_allocation.buffer.*
 * dEQP-VK.memory.requirements.dedicated_allocation.image.*

Components: Vulkan

VK-GL-CTS issue: 391

Change-Id: I9510464987e33b395a5ac20c2fdb9129eefd91da
(cherry picked from commit 6c472cc5e98a1a73aeac019ce34cccac7f3fa30e)

6 years agoAdd tests for FragCoord interaction with multisampling
David Sodman [Fri, 24 Feb 2017 19:04:46 +0000 (11:04 -0800)]
Add tests for FragCoord interaction with multisampling

Components: Vulkan
VK-GL-CTS issue: 89

Test: fragcoord_msaa, frontface, fragdepth, clipping
Change-Id: Ibf342e63f224b88fe0b0cffde59b10b34afd1faf
(cherry picked from commit 69a7a0079a6cc06d556ecb5314f275d2fa01a60d)

6 years agoFix VS12 compilation error (typedef)
Maciej Jesionowski [Wed, 26 Jul 2017 13:53:13 +0000 (15:53 +0200)]
Fix VS12 compilation error (typedef)

Change-Id: Iebfece1455df2a49c79885d42f43817001a31b84
(cherry picked from commit 68c41978cf7a76391e898af7faaddea0598a3911)

6 years agoFix wrong transition in dEQP-VK.glsl.builtin_var.fragdepth
Slawomir Cygan [Wed, 5 Jul 2017 17:17:02 +0000 (19:17 +0200)]
Fix wrong transition in dEQP-VK.glsl.builtin_var.fragdepth

The test was using vkCmdClearDepthStencilImage to clear an
image, than used this image as a depth attachment in
redering performed by VulkanDrawContext utility.

However, this utility always starts the renderpass on depth
attachment from UNDEFINED layout. As no depth clear is done
in the renderpass, the depth attachment contents are undefined
(and initially cleared image contents may be corrupted).

The easiest fix here is to move the clear to LOAD_OP - as
is already done for color, leaving the UNDEFINED layout as is.

Affects: dEQP-VK.glsl.builtin_var.fragdepth*

Components: Vulkan
VK-GL-CTS issue: 559

Change-Id: Icef3289ba62f71bf1ed989f84085a4d9d3b7218a
(cherry picked from commit f3a36239082b721e1f5f6849afc70af65b42e3ed)

6 years agoAdd test for FragDepth shader built-in
David Sodman [Fri, 24 Feb 2017 18:41:59 +0000 (10:41 -0800)]
Add test for FragDepth shader built-in

Components: Vulkan

VK-GL-CTS issue: 93

Test: fragdepth, frontface, clipping
Change-Id: I531e39a58dd6b577108bff14b2206d7bf9d9cd4f
(cherry picked from commit 3aeb0c565fe64441466247fe381fc815209d46e4)

6 years agoExtend gl_FrontFacing tests
David Sodman [Tue, 6 Sep 2016 21:05:59 +0000 (14:05 -0700)]
Extend gl_FrontFacing tests

Update gl_FrontFacing tests to include more tests as well as to use the
vktDrawUtil utility class

Change-Id: If94fb552f5f9366c79ffa3fcac6f085611a23f65
(cherry picked from commit 417115b2676c3064a06385184573b6d7a0644f42)

6 years agoAdd ability to generate images with the reference renderer
David Sodman [Fri, 9 Sep 2016 02:58:35 +0000 (19:58 -0700)]
Add ability to generate images with the reference renderer

*Separate DrawContext into a DrawContext and DrawContextState to reflect
  graphics API's are split between state and action parts
* Add abstract DrawContext class

Test: Test clipping and synchronization primitives

Change-Id: I9f3945c6c3de169325fadea7bf70a9d5d7bfd932
(cherry picked from commit 11da53fb71eced942e89bac59407a5681dba3bb1)

6 years agoAdd Vulkan DrawContext utility class
David Sodman [Thu, 1 Sep 2016 17:40:21 +0000 (10:40 -0700)]
Add Vulkan DrawContext utility class

This is the first in a series of changes to move the DrawContext class
for more general use.

Test: run clipping tests on Vulkan
Affects: dEQP-VK.clipping.*

Change-Id: Ia9b8953d25c10ec2a6c227bf300637dcd62ea898
(cherry picked from commit 9a928cdc2014c830eb8cb43043746f8f2ea6969a)