platform/upstream/efl.git
8 years agogengrid: Prevent duplicated selected function calls when item is unselected in the...
Youngbok Shin [Wed, 18 Nov 2015 10:39:13 +0000 (19:39 +0900)]
gengrid: Prevent duplicated selected function calls when item is unselected in the function.

Summary:
If item is unselected in a selected function,
selected function will be called once more from _elm_gengrid_elm_widget_on_focus.
It is happened when elm_gengrid object has no focus and one of item is selected by mouse up event.
To fix this issue, we need to set focus to item and keep the address of selected item before calling selected function.
@fix

Test Plan:
1. Install & Run efbb (Escape From Booty Bay: https://git.enlightenment.org/games/efbb.git/)
2. Select a level in the main menu. (It is using elm_gengrid).
3. See duplicated target images.

Reviewers: cedric, SanghyeonLee

Reviewed By: SanghyeonLee

Differential Revision: https://phab.enlightenment.org/D3323

8 years agoElm entry: Keep cursor at inserted position after dnd.
Subodh Kumar [Wed, 18 Nov 2015 02:57:49 +0000 (11:57 +0900)]
Elm entry: Keep cursor at inserted position after dnd.

Summary:
Keep cursor at inserted position after dnd.

For good user experience, after dnd users expect
the cursor should be at the last inserted position.

@feature

Test Plan: NA

Reviewers: thiepha, herdsman, cedric, tasn

Subscribers: shilpasingh

Differential Revision: https://phab.enlightenment.org/D3267

8 years agowin: only perform maximize frame state updating during ecore-evas callback
Mike Blumenkrantz [Tue, 17 Nov 2015 23:19:15 +0000 (18:19 -0500)]
win: only perform maximize frame state updating during ecore-evas callback

running this during csd button activation leads to state mismatches when
maximize is not triggered from the csd button

@fix

8 years agoClouseau: handle case when the library is not installed
Daniel Zaoui [Thu, 12 Nov 2015 06:39:46 +0000 (08:39 +0200)]
Clouseau: handle case when the library is not installed

Eina module errors are printed on the screen when the library is not
installed in the system and Clouseau debug is enabled.

The module pointer is not NULL checked, leading to an error message when trying
to load this NULL module.

@fix

8 years agoelm_prefs: mark some local symbols static and align thus with their declaration
Stefan Schmidt [Wed, 11 Nov 2015 16:47:57 +0000 (17:47 +0100)]
elm_prefs: mark some local symbols static and align thus with their declaration

8 years agoelm_prefs: remove some unused functions
Stefan Schmidt [Wed, 11 Nov 2015 16:45:13 +0000 (17:45 +0100)]
elm_prefs: remove some unused functions

8 years agoelm_transit: mark some local symbols static
Stefan Schmidt [Wed, 11 Nov 2015 16:31:48 +0000 (17:31 +0100)]
elm_transit: mark some local symbols static

8 years agoelm_map: mark some local symbols static
Stefan Schmidt [Wed, 11 Nov 2015 16:27:29 +0000 (17:27 +0100)]
elm_map: mark some local symbols static

8 years agoelm_main: mark some local symbols static
Stefan Schmidt [Wed, 11 Nov 2015 16:23:59 +0000 (17:23 +0100)]
elm_main: mark some local symbols static

8 years agoGenlist: Fixed a possible crash in filter iterator and a typo.
shashank.p [Wed, 11 Nov 2015 06:30:58 +0000 (15:30 +0900)]
Genlist: Fixed a possible crash in filter iterator and a typo.

Summary:
1. If the sd->items list is empty any time and container_get is used on filter iterator, it will lead to crash. Solution is to not rely on sd->items and maintain a pointer to container when iterator is created.

2. There was a typo while filter feature was added earlier. Fixed it

@fix

Test Plan: NA

Reviewers: SanghyeonLee

Reviewed By: SanghyeonLee

Subscribers: rajeshps, shilpasingh

Differential Revision: https://phab.enlightenment.org/D3319

8 years agohoversel: add item disabling support.
godly.talias [Tue, 10 Nov 2015 23:15:29 +0000 (15:15 -0800)]
hoversel: add item disabling support.

Summary:
Hoversel items can be disabled using elm_object_item_disabled_set
@feature

Test Plan: elementary_test

Reviewers: prince.dubey, shilpasingh, raster, Hermet, conr2d, cedric

Subscribers: poornima.srinivasan, rajeshps

Differential Revision: https://phab.enlightenment.org/D3122

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoslider: fix slider focus bug
Hosang Kim [Tue, 10 Nov 2015 22:31:03 +0000 (14:31 -0800)]
slider: fix slider focus bug

Summary: when slider is focused and slider's indicator mode is not ELM_SLIDER_INDICATOR_VISIBLE_MODE_ON_FOCUS, slider's indicator popup blinked.

Test Plan: elementary_test -> slider -> focus out -> click slider again

Reviewers: seoz, cedric, raster, Hermet, woohyun, CHAN, id213sin

Differential Revision: https://phab.enlightenment.org/D3308

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agospinner: code clean up for readability.
woochan lee [Tue, 10 Nov 2015 00:29:05 +0000 (16:29 -0800)]
spinner: code clean up for readability.

Summary: Line change by meaningful paragraph.

Test Plan: N/A

Reviewers: Hermet, cedric

Differential Revision: https://phab.enlightenment.org/D3300

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agospinner: add entry filter for accepted only digits and "."
woochan lee [Tue, 10 Nov 2015 00:28:19 +0000 (16:28 -0800)]
spinner: add entry filter for accepted only digits and "."

Summary:
When spinner activated with entry, user can input any characters in entry.
It degrades the usability.

Add filter for only can input numbers and "." for case of decimal point existing.

I will add entry filter for limit size as well after this commit.
This spinner features may help for app developer and users too.

@feature

Test Plan:
Run elementary_test
Test various spinner format for check this.

Reviewers: Hermet, cedric

Subscribers: id213sin, shilpasingh

Differential Revision: https://phab.enlightenment.org/D3299

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agosegment_control: fix variable affectation
Jean Guyomarc'h [Tue, 10 Nov 2015 00:13:13 +0000 (16:13 -0800)]
segment_control: fix variable affectation

Summary:
When an Elm_Segment_Control object is created, the constructor calls
the smart_add() behind the scenes. It then calls _update_list() which
calls _position_items(), with the sd->obj unset (because it was set
after calling super constructors). This led to a CRI() (and therefore
to a backtrace) on the creation of each Elm_Segment_Control.

@fix

Test Plan: elementary_test

Reviewers: stefan_schmidt, cedric, raster

Differential Revision: https://phab.enlightenment.org/D3276

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agohoversel: refactor a bit to avoid code duplication.
Subodh Kumar [Tue, 10 Nov 2015 00:05:05 +0000 (16:05 -0800)]
hoversel: refactor a bit to avoid code duplication.

Summary:
Avoid code duplication

Two dismissal signals at two different places
created some confusion and also code is duplicated.
Also removed some extra space.

Test Plan: NA

Reviewers: cedric

Differential Revision: https://phab.enlightenment.org/D3269

8 years agogenlist: modified first/last/prev/next get API for filtered list.
shashank.p [Tue, 10 Nov 2015 00:03:05 +0000 (16:03 -0800)]
genlist: modified first/last/prev/next get API for filtered list.

Summary: elm_genlist_first_item_get(), elm_genlist_last_item_get(), elm_genlist_item_prev_get(), elm_genlist_item_next_get() should return the next filtered item if filter is applied on the genlist.

Test Plan: test_genlist.c => Genlist Filter demo updated

Reviewers: shilpasingh, cedric, SanghyeonLee

Subscribers: divyesh, rajeshps

Differential Revision: https://phab.enlightenment.org/D3263

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoconform: retry connect to indicator when confrom fails connect.
Shinwoo Kim [Tue, 10 Nov 2015 00:00:17 +0000 (16:00 -0800)]
conform: retry connect to indicator when confrom fails connect.

Summary:
An application starts before the indicator has. In this case,
the application should try to connect again with the indicator.

Test Plan:
1. Start an application without the indicator service.
2. Start the indicator service.

Reviewers: raster, Hermet, woohyun, jaehwan, cedric

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D3258

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agonaviframe: subtitle,show signal not sent
Shilpa Singh [Mon, 9 Nov 2015 22:34:37 +0000 (14:34 -0800)]
naviframe: subtitle,show signal not sent

Summary:
1. When subtitle is set using actual part name "elm.text.subtitle",
subtitle,show signal is not sent issue fix.
2. Remove unnecessary checks, maintain code readability.

@fix

Test Plan:
Set text using edc part name elm.text.subtitle

Reviewers: Hermet, cedric

Reviewed By: cedric

Subscribers: shashank0990

Differential Revision: https://phab.enlightenment.org/D2988

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoindex: internal item's edje object handling logic changed to improve performance.
woochan lee [Mon, 9 Nov 2015 20:25:27 +0000 (12:25 -0800)]
index: internal item's edje object handling logic changed to improve performance.

Summary:
The box_clear, box_fill internal functions called when almost every internal chage happend.
(resize, theme apply, item append, item delete etc...)
Then those APIs delete/create item's edje object for all of the items.

It's very not good action for performance.
So, i changed this just edje object box unpack/pack instead of delete/create.

@fix

Test Plan:
Working test on elementary_test
and Call all of the index APIs for check this change.

Reviewers: Hermet, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3268

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agotoolbar: reduce changing widget parent-child relationship when an item is added.
Youngbok Shin [Mon, 9 Nov 2015 20:25:04 +0000 (12:25 -0800)]
toolbar: reduce changing widget parent-child relationship when an item is added.

Summary:
It is an legacy of old code. When the view object of item was edje,
I think there was no meaningless parent-child relationship changes.
But, now, the view object is elm_layout and if we add object in proper order,
we don't need to make an useless parent-child realationship in any moments.

Test Plan: None

Reviewers: woohyun, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3254

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agotoolbar: add item_signal_emit.
Shilpa Singh [Mon, 9 Nov 2015 20:24:37 +0000 (12:24 -0800)]
toolbar: add item_signal_emit.

Summary:
Application cannot send signals to toolbar item using elm_object_item_signal_emit API.

@feature

Test Plan: Send signal to toolbar item from app using elm_object_item_signal_emit widget.

Reviewers: cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D3251

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agotoolbar: remove a legacy code.
Youngbok Shin [Mon, 9 Nov 2015 20:24:08 +0000 (12:24 -0800)]
toolbar: remove a legacy code.

Summary:
The icon is already sub object of VIEW(item) by content_set.
We don't need to make icon as a sub object of obj again.
It was used when VIEW(item) is Edje object.

Test Plan: None

Reviewers: Hermet, eagleeye, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3249

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agocolorselector: read color names instead of RGBA when accessibility is set
Shilpa Singh [Mon, 9 Nov 2015 20:23:46 +0000 (12:23 -0800)]
colorselector: read color names instead of RGBA when accessibility is set

Summary:
Issue: When accessibility is set, individual color item's RGBA values are read
instead of actual color names.
Solution: Read color names by matching the color RGBA from the array.

Test Plan:
enable accessibility
run elementary test
select colorselector demo
click on individual color palette items

Reviewers: cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3240

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agohover/hoversel: clean up code for getting edje_object_data
Jee-Yong Um [Mon, 9 Nov 2015 20:23:18 +0000 (12:23 -0800)]
hover/hoversel: clean up code for getting edje_object_data

Summary:
There are several lines to get edje_object_data from elm_hover
or elm_hoversel like edje_object_data_get(elm_layout_edje_get(obj), "key");
These codes can be replaced with elm_layout_data_get(obj, "key");

Reviewers: Hermet, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3193

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoconform: if window is in background, indicator must not update the plug information.
Prince Kumar Dubey [Mon, 9 Nov 2015 20:22:32 +0000 (12:22 -0800)]
conform: if window is in background, indicator must not update the plug information.

Summary:
When the window is in background, for associated conformant, indicator must not update the plug information.
To fix this issue, On window goes to background, the associated plug handled by confromant is deleted.

Test Plan:
On any device (like handset) which should have indicator support, this scenario can be reproduce. I tested on a handset
with gdb attach to running process having window and confromant with indicator support.

Reviewers: raster, Hermet, cedric

Reviewed By: cedric

Subscribers: rajeshps, govi

Differential Revision: https://phab.enlightenment.org/D3177

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agocalendar: weekdays do not get translated when language is dynamically changed issue fix
Shilpa Singh [Mon, 9 Nov 2015 20:21:09 +0000 (12:21 -0800)]
calendar: weekdays do not get translated when language is dynamically changed issue fix

Summary:
When calendar widget is already created and if we change language,
weekdays do not get translated because weekday string is statically
stored only during create.
Update the weekdays again when object is changed.

@fix

Test Plan:
1.Create and show calendar widget
2.Change the language
Weekdays do not get translated

Reviewers: Hermet, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3149

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agohoversel: do item view creation at the time of item addition.
godly.talias [Mon, 9 Nov 2015 20:18:49 +0000 (12:18 -0800)]
hoversel: do item view creation at the time of item addition.

Summary:
Currently hoversel creates the item view when user clicks on hoversel,
So it will cause a delay for the hover to come depending on number
of items as the items in hover have to be created. If item creation
is done during item_add that delay can be avoided and pressed effect also
will become smooth (item_add will be taking more time with this change, but
it happens only once). If applications prefer memory usage more than execution
time, then applications can do item_add in hoversel clicked callback.

Test Plan: elementary_test

Reviewers: raster, Hermet, conr2d, prince.dubey, shilpasingh, cedric

Reviewed By: cedric

Subscribers: rajeshps, poornima.srinivasan

Differential Revision: https://phab.enlightenment.org/D3058

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agobuild: don't provide --eo to eolian_gen
Daniel Kolesa [Tue, 13 Oct 2015 13:40:07 +0000 (14:40 +0100)]
build: don't provide --eo to eolian_gen

8 years agoconfigure: Switch to dev mode again. Merge window for 1.17 is open now
Stefan Schmidt [Mon, 9 Nov 2015 10:46:30 +0000 (11:46 +0100)]
configure: Switch to dev mode again. Merge window for 1.17 is open now

8 years agorelease: Update NEWS and bump version for 1.16.0 release
Stefan Schmidt [Mon, 9 Nov 2015 10:08:34 +0000 (11:08 +0100)]
release: Update NEWS and bump version for 1.16.0 release

8 years agopo: update po files for release
Stefan Schmidt [Mon, 9 Nov 2015 10:04:36 +0000 (11:04 +0100)]
po: update po files for release

8 years agowin : Prohibiting auto-rendering, until elm_win is shown.
Wonsik Jung [Thu, 5 Nov 2015 11:37:11 +0000 (20:37 +0900)]
win : Prohibiting auto-rendering, until elm_win is shown.

Summary:
Although elm_win is only created and evas_object_show with elm_win is not called,
evas_rendering works sometimes.
This rendering is not necessary. Because on one is shown and just back buffer is allocated.
This patch is the prohibiting auto-rendering, if elm_win is shown by calling evas_object_show()
It is effective for power consumption and reducing memory.

@fix

Test Plan:
1. elementary_test : checking all menus's working
2. modifed bg_example_02 : updated elm_bg's color by animator without evas_object_show(elm_win)

Reviewers: jpeg, jypark, raster

Reviewed By: raster

Differential Revision: https://phab.enlightenment.org/D3282

8 years agoatspi: add missing SELECTED changed signals
Lukasz Stanislawski [Thu, 5 Nov 2015 09:52:28 +0000 (10:52 +0100)]
atspi: add missing SELECTED changed signals

@fix

8 years agoelm_segment_control: fix invalid parameter
Jean Guyomarc'h [Thu, 5 Nov 2015 07:12:44 +0000 (16:12 +0900)]
elm_segment_control: fix invalid parameter

Summary:
Eo complained about an invalid type 'Edje_Object' passed to
elm_widget_sub_object_add(). It is the segment control itself
that should be the subject of the call to this function.

@fix

Test Plan: elementary_test: no more Eo errors

Reviewers: cedric, stefan_schmidt

Differential Revision: https://phab.enlightenment.org/D3277

8 years agogenlist tree test - minor - show all callbacks called so people know
Carsten Haitzler (Rasterman) [Wed, 4 Nov 2015 03:33:46 +0000 (12:33 +0900)]
genlist tree test - minor - show all callbacks called so people know

act as "docs" so people can see what is called when. minor just in elm
test.

8 years agoautoscroll focus: pass the object region position relative to the scroller.
chris [Thu, 5 Nov 2015 00:16:11 +0000 (16:16 -0800)]
autoscroll focus: pass the object region position relative to the scroller.

Summary:
The region position passed to region_show and region_bring_in used to be
relative to the object position, not the scroller.

This fixes T1686.

@fix

Reviewers: seoz

Maniphest Tasks: T1686

Differential Revision: https://phab.enlightenment.org/D3168

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agointerface_scrollable: delete unnecessary smart callback call.
Hosang Kim [Tue, 3 Nov 2015 20:29:05 +0000 (12:29 -0800)]
interface_scrollable: delete unnecessary smart callback call.

Summary:
When _elm_interface_scrollable_page_bring_in is called, page is not changed yet.
So "page,changed" smart callback is unnecessary.

Sometimes "page,changed" smart callback is called twice.
Because "drag,stop" and "anim,stop"is called it.
So I add updating current page code.

Test Plan:
elementary_test -> scroller

1. using wheel.
2. using "prev page" and "next page".
3. draging sceen

Reviewers: Hermet, singh.amitesh, cedric, raster, jaehwan, seoz

Differential Revision: https://phab.enlightenment.org/D3260

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agocolorselector: picker spinner UI not proper issue fix.
Shilpa Singh [Tue, 3 Nov 2015 20:17:03 +0000 (12:17 -0800)]
colorselector: picker spinner UI not proper issue fix.

Summary:
Picker spinner UI not proper, showing blank buttons issue fix.

@fix T2401

Test Plan:
1. Launch elementary_test
2. Select colorselector
3. Tap on picker
4. observe, spinner UI not proper.

Reviewers: cedric, subodh6129

Reviewed By: subodh6129

Maniphest Tasks: T2401

Differential Revision: https://phab.enlightenment.org/D3266

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agonotify: animate on hide
Jean-Philippe Andre [Wed, 21 Oct 2015 08:23:10 +0000 (17:23 +0900)]
notify: animate on hide

There was all the necessary code, except that the default
theme did not implement properly the signal & required data.

There is still a problem though, as the "timeout" smart callback
will be called at the start of the animation, so it's not possible
for an app to hide() or del() at this point (that would get
rid of the animation). But there's no other callback after
the animation ends.

elementary_test -to Notify > "Bottom" illustrates this issue.

8 years agoRevert "elm: Add eglfs backend support."
Cedric BAIL [Mon, 2 Nov 2015 23:54:41 +0000 (15:54 -0800)]
Revert "elm: Add eglfs backend support."

This reverts commit 0d6aedbf44e5c371bddfa2b6b61c9409ed2184e3.

This patch landed a little bit to early.

8 years agoelm: Add eglfs backend support.
Nicolas Aguirre [Mon, 2 Nov 2015 23:13:20 +0000 (00:13 +0100)]
elm: Add eglfs backend support.

8 years agoRemove #include for config.h from C++ public header
Felipe Magno de Almeida [Mon, 2 Nov 2015 21:39:55 +0000 (19:39 -0200)]
Remove #include for config.h from C++ public header

Removed #include for elementary_config.h if HAVE_CONFIG_H is
defined. Which causes errors with external projects. Instead,
defined the necessary macros to use the Eo API.

8 years agoHoversel: Fix dismiss callback
Yeshwanth Reddivari [Mon, 2 Nov 2015 13:59:57 +0000 (19:29 +0530)]
Hoversel: Fix dismiss callback

Summary: Dismiss callback was getting called on hover object instead of hoversel object.

Reviewers: raster, Hermet, alok25, mvsovani, conr2d, singh.amitesh

Reviewed By: singh.amitesh

Subscribers: sachin.dev

Differential Revision: https://phab.enlightenment.org/D3261

8 years agotest_explode: use evas_object_clipees_has instead
Amitesh Singh [Mon, 2 Nov 2015 03:27:51 +0000 (08:57 +0530)]
test_explode: use evas_object_clipees_has instead

fixes memory leak and better performance

8 years agowidget: update child_can_focus flag on focusability change
Lukasz Stanislawski [Fri, 30 Oct 2015 06:22:05 +0000 (07:22 +0100)]
widget: update child_can_focus flag on focusability change

Summary:
Previously child_can_focus flag could be only updated when
child is deleted from object's subobject list. This patch
additionally updates child_can_focus flag when focusability
is changed with elm_widget_focus_can_set function.

Patch solves child_can_focus issue in similar situations:

elm_icon_add(layout);
elm_object_content_set(layout, icon);
elm_widget_child_can_focus_get(layout); // returns EINA_TRUE

icon = elm_icon_add(win);
elm_object_content_set(layout, icon);
elm_widget_child_can_focus_get(layout); // returns EINA_FALSE

@fix

Reviewers: cedric, stefan_schmidt

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D3237

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agomultibuttonentry: fix internal entry be an orphan when editable set API called.
woochan lee [Fri, 30 Oct 2015 05:52:00 +0000 (06:52 +0100)]
multibuttonentry: fix internal entry be an orphan when editable set API called.

Summary:
When user called "elm_multibuttonetnry_editable_set()" API as false.
the internal entry will be unpacked from box.

Then called that API as true again.
the internal entry just show without box packed.

Also, editable set API should not work in MBE shrink mode.

Test Plan:
Alternately Call elm_multibuttonentry_ediable_set API as true, false.
Then check the internal entry state.

Reviewers: Hermet, cedric

Differential Revision: https://phab.enlightenment.org/D3134

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agomultibuttonentry: when item is clicked/selected, select function not called issue...
Shilpa Singh [Fri, 30 Oct 2015 05:26:31 +0000 (06:26 +0100)]
multibuttonentry: when item is clicked/selected, select function not called issue fix.

Summary:
The select function set in item_append does not get called on item selection issue fix.
As per documentation, the function has to get called.

@fix

Test Plan: elementary_test is updated with the demo

Reviewers: navnbeet, Hermet, CHAN, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3158

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agohoversel: remove scrollable_set/get() API
Jee-Yong Um [Fri, 30 Oct 2015 03:09:28 +0000 (04:09 +0100)]
hoversel: remove scrollable_set/get() API

Summary:
Hoversel scrollability can be considered as default behavior of hoversel.
These APIs are not necessary any more.

Reviewers: cedric, DaveMDS

Subscribers: DaveMDS, cedric

Differential Revision: https://phab.enlightenment.org/D3241

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agotest_gesture_layer: use bigger font size for entry
Amitesh Singh [Fri, 30 Oct 2015 04:47:01 +0000 (10:17 +0530)]
test_gesture_layer: use bigger font size for entry

8 years agowin: reemit atspi "focused" event on bridge connection
Lukasz Stanislawski [Wed, 28 Oct 2015 16:02:01 +0000 (17:02 +0100)]
win: reemit atspi "focused" event on bridge connection

At-spi clients assume that object:state-changed:focused event is emitted
on application start. By the time atspi_bridge will establish
connection on at-spi bus all focused events are already emitted.
To fix this we reemit "focused" event in bridge connection callback.

This fixes a bug when Orca screen reader do not read first element after
application launch.

@fix

8 years agoelm: Fix typos fun!
Daniel Juyung Seo [Wed, 28 Oct 2015 17:06:29 +0000 (02:06 +0900)]
elm: Fix typos fun!

8 years agorelease: Update NEWS and bump version for 1.16.0-beta3 release
Stefan Schmidt [Mon, 26 Oct 2015 02:59:15 +0000 (03:59 +0100)]
release: Update NEWS and bump version for 1.16.0-beta3 release

8 years agopo: update po files
Stefan Schmidt [Mon, 26 Oct 2015 02:48:00 +0000 (03:48 +0100)]
po: update po files

8 years agohoversel: expands scrollable hoversel as large as it can
Jee-Yong Um [Mon, 26 Oct 2015 00:27:02 +0000 (01:27 +0100)]
hoversel: expands scrollable hoversel as large as it can

Summary:
In D2063, "max_size" data item is added to limit the number of items
to show at a time when hoversel is expanded.
However, it limits the number of items too few, so makes scrollable
function useless.
This patch removes limitation of hoversel size with pixels,
but if it needs, developers can set the limitation yet.
(By theme customization)

Test Plan:
elementary_test "hoversel"
click the second hoversel

Reviewers: DaveMDS, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3223

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agomultibuttonentry: fix label packed many times in internal box.
woochan lee [Mon, 26 Oct 2015 00:20:53 +0000 (01:20 +0100)]
multibuttonentry: fix label packed many times in internal box.

Summary:
The Internal box can has a lot of label for child when user set text many times.
Fix this wrong implement. It has to get only one label for child.

@fix

Test Plan:
Call elm_object_text_set() many times for MBE.
Check the label got a wrong geometry.

Reviewers: Hermet, cedric

Differential Revision: https://phab.enlightenment.org/D3133

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agogesture_layer: fix long tap gesture has wrong timestamp.
woochan lee [Thu, 8 Oct 2015 10:35:07 +0000 (12:35 +0200)]
gesture_layer: fix long tap gesture has wrong timestamp.

Summary:
The timestamp has 0 value when n_long_tap_start callback called.
Then timestamp is same on each n_long_tap_move callback functions.

For fix this bug, update timestamp before called state_set function.
Also update timestamp in every timeout.

Test Plan:
Run test_gesture_layer2.c
Print timestamp in every n_long_tap_XXX callback.

Reviewers: tasn, cedric

Differential Revision: https://phab.enlightenment.org/D3144

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoelm_colorselector: fix color selection with spinners
Andrii Kroitor [Thu, 8 Oct 2015 10:29:39 +0000 (12:29 +0200)]
elm_colorselector: fix color selection with spinners

Reviewers: cedric, Hermet, raster, reutskiy.v.v

Differential Revision: https://phab.enlightenment.org/D3145

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoelm_hoversel: remove unused internal functions
Jee-Yong Um [Thu, 8 Oct 2015 10:10:07 +0000 (12:10 +0200)]
elm_hoversel: remove unused internal functions

Summary:
remove unused internal functions
(that added for scrollability, but not used any more)

T2765

Reviewers: Hermet, cedric

Maniphest Tasks: T2765

Differential Revision: https://phab.enlightenment.org/D3132

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoRevert "elementary: Comment out (#if 0) unused functions"
Cedric BAIL [Thu, 8 Oct 2015 10:09:32 +0000 (12:09 +0200)]
Revert "elementary: Comment out (#if 0) unused functions"

This reverts commit 74a7661119d122ec52844ad58c0901db739949f1.

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoelm_hoversel: change API name (label_auto_changed -> auto_update)
Jee-Yong Um [Thu, 8 Oct 2015 10:05:31 +0000 (12:05 +0200)]
elm_hoversel: change API name (label_auto_changed -> auto_update)

Summary: elm_hoversel_label_auto_changed_set/get() API names are not clear.

Reviewers: Hermet, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3139

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoelm_hoversel: change Elm_Hoversel_Data member name from scroll_enabled to scrollable
Jee-Yong Um [Thu, 8 Oct 2015 10:03:37 +0000 (12:03 +0200)]
elm_hoversel: change Elm_Hoversel_Data member name from scroll_enabled to scrollable

Summary:
elm_hoversel_scroll_enabled_set/get() API were changed to
elm_hoversel_scrollable_set/get().
However, the name of member of Elm_Hovsersel_Data related to those API
are not changed.
It can confuse developers later, so change it same to the name defined
in elm_hoversel.eo file.

Reviewers: Hermet, cedric

Differential Revision: https://phab.enlightenment.org/D3140

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoelm_index: Fix memory leak issue in realloc failure
Vivek Ellur [Thu, 22 Oct 2015 19:38:28 +0000 (12:38 -0700)]
elm_index: Fix memory leak issue in realloc failure

Summary:
@Fix

Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric

Differential Revision: https://phab.enlightenment.org/D3214

8 years agodayselector: fix warning related to argument type
Vivek Ellur [Thu, 22 Oct 2015 19:37:44 +0000 (12:37 -0700)]
dayselector: fix warning related to argument type

Summary:
@fix

Signed-off-by: Vivek Ellur <vivek.ellur@samsung.com>
Reviewers: cedric

Differential Revision: https://phab.enlightenment.org/D3215

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoFix typo in docs
Dave Andreoli [Thu, 22 Oct 2015 17:35:51 +0000 (19:35 +0200)]
Fix typo in docs

not "a castrated ram (a male sheep)"  :D

8 years agoflip: use eo_isa for checking object types
Amitesh Singh [Thu, 22 Oct 2015 17:06:01 +0000 (22:36 +0530)]
flip: use eo_isa for checking object types

8 years agoimage: use eo_isa for checking object types instead of string comparison
Amitesh Singh [Thu, 22 Oct 2015 16:44:40 +0000 (22:14 +0530)]
image: use eo_isa for checking object types instead of string comparison

8 years agoelm_cnp: DnD/X11: correct drag window position in rotation
Shilpa Singh [Wed, 21 Oct 2015 21:39:05 +0000 (14:39 -0700)]
elm_cnp: DnD/X11: correct drag window position in rotation

Summary:
For various angles 90, 180, 270,  the calculation of dnd window position
is not proper causing window to be placed wrongly while dragging.
Signed-Off By: Kumar Navneet <k.navneet@samsung.com>

@fix

Test Plan:
Longpress and drag and drop in entry by placing device at various angles
90, 180 and 270.

Reviewers: woohyun, cedric, thiepha

Reviewed By: thiepha

Subscribers: navnbeet

Differential Revision: https://phab.enlightenment.org/D3188

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agobuild: simplify SUBDIR usage in examples
Stefan Schmidt [Wed, 21 Oct 2015 08:57:17 +0000 (10:57 +0200)]
build: simplify SUBDIR usage in examples

8 years agoexamples/sphere_hunter: fix another instance of floating point incorrectness
Stefan Schmidt [Wed, 21 Oct 2015 08:26:00 +0000 (10:26 +0200)]
examples/sphere_hunter: fix another instance of floating point incorrectness

I missed this one yesterday. Also change it to use floating point values
instead of casting which does not make much sense for hard-coded values.

CID: 1327343

8 years agoexamples/sphere_hunter: remove unused function
Stefan Schmidt [Tue, 20 Oct 2015 15:23:19 +0000 (17:23 +0200)]
examples/sphere_hunter: remove unused function

After fixing the Coverity issue clang told me that this function is actually
not used at all.

8 years agoelm_widget_prefs: no need to redefine a typedef we already have
Stefan Schmidt [Tue, 20 Oct 2015 15:10:12 +0000 (17:10 +0200)]
elm_widget_prefs: no need to redefine a typedef we already have

Spotted by clang. This was already typedef'ed in elm_prefs_data.h

8 years agoexamples/sphere_hunter: initialize struct in all cases
Stefan Schmidt [Tue, 20 Oct 2015 14:53:53 +0000 (16:53 +0200)]
examples/sphere_hunter: initialize struct in all cases

If l == 0 we would never initialize vec3 struct members.

CID: 1327345

8 years agoexamples/sphere_hunter: make sure we do not loose fractional part of double.
Stefan Schmidt [Tue, 20 Oct 2015 14:39:42 +0000 (16:39 +0200)]
examples/sphere_hunter: make sure we do not loose fractional part of double.

When dividing with an int we would loose the fractional part. Better cast to
a double to make clear we want double precision here.

CID: 1327343, 1327344

8 years agoexamples/sphere_hunter: use coorect logic for if condition.
Stefan Schmidt [Tue, 20 Oct 2015 14:27:10 +0000 (16:27 +0200)]
examples/sphere_hunter: use coorect logic for if condition.

We want a value here which is between 0 and 10. We need a logical AND here. If
we use OR this condition could never be false.

CID: 1327357

8 years agoexamples/camera_light: free resources if we fail to allocate all and leave
Stefan Schmidt [Tue, 20 Oct 2015 14:16:31 +0000 (16:16 +0200)]
examples/camera_light: free resources if we fail to allocate all and leave

We return here leaving maybe some other allocations around and leaking.

CID: 1327348, 1327349, 1327350

8 years agoatspi: fix invalid shift operation.
Lukasz Stanislawski [Tue, 20 Oct 2015 09:56:55 +0000 (11:56 +0200)]
atspi: fix invalid shift operation.

Add additional check in case when Elm_Atspi_Role_Type enum will enlarge.

CID: 1325724

8 years agoelm test - make automated test betetr by auto-exiting after 50 bounces
Carsten Haitzler (Rasterman) [Tue, 20 Oct 2015 05:05:05 +0000 (14:05 +0900)]
elm test - make automated test betetr by auto-exiting after 50 bounces

8 years agoelm test - genlist test - add bounce option test for testing performance
Carsten Haitzler (Rasterman) [Tue, 20 Oct 2015 03:18:59 +0000 (12:18 +0900)]
elm test - genlist test - add bounce option test for testing performance

for release we need to test performance - esp of evas and eo in real life usage
and scroling is just such one. this adds a simple automated scrolling
test to genlist test (hit the button or ELM_TEST_AUTOBOUNCE=1
elementary_test -to genlist) so you can get consistent input and benchmark info

8 years agotoolbar: limit number of min restricted calc to exacly what we need.
Cedric BAIL [Tue, 20 Oct 2015 00:06:38 +0000 (17:06 -0700)]
toolbar: limit number of min restricted calc to exacly what we need.

This change is the simplest I could do, but I think it would be better
to move _item_theme_hook inside _item_new. This is a further attempt
to fix T2777.

8 years agoelm_win: fix wrong comment.
Nak-Gyeong Kim [Mon, 19 Oct 2015 18:44:50 +0000 (11:44 -0700)]
elm_win: fix wrong comment.

Summary:
static const char SIG_FOCUS_OUT[] = "focus,out"; // deprecated. use "unfocused" instead.
static const char SIG_FOCUS_IN[] = "focus,in"; // deprecated. use "focused" instead.

@fix

Test Plan: N/A

Reviewers: seoz, cedric

Reviewed By: cedric

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D3187

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoelc_file_selector_button: free allocated path name
Sung-Taek Hong [Mon, 19 Oct 2015 18:43:13 +0000 (11:43 -0700)]
elc_file_selector_button: free allocated path name

Summary:
Currently path is strdup() when getting real path, but it is not freed
in some cases.

@fix

Reviewers: seoz, Hermet, woohyun, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3194

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agoelm_map: block longpressed event when scrolled, zoomed, or rotated
Sung-Taek Hong [Mon, 19 Oct 2015 18:42:35 +0000 (11:42 -0700)]
elm_map: block longpressed event when scrolled, zoomed, or rotated

Summary:
Currently, longpressed event can be called when map is
scrolled, zoomed or rotated. This might cause unintentional
result, because mouse need to be down at lease once to
execute scroll, zoom, or rotate, and longpressed event will start
when those events takes long enough time.

Reviewers: seoz, Hermet, woohyun, cedric

Reviewed By: cedric

Differential Revision: https://phab.enlightenment.org/D3195

Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
8 years agohoversel: rename label_auto_changed -> auto_update
Cedric BAIL [Mon, 19 Oct 2015 18:41:14 +0000 (11:41 -0700)]
hoversel: rename label_auto_changed -> auto_update

Thanks to Davide Andreoli for his review and suggestion.

8 years agoatspi: clean-up children-changed event emission.
Lukasz Stanislawski [Thu, 8 Oct 2015 10:23:15 +0000 (12:23 +0200)]
atspi: clean-up children-changed event emission.

Patch fixes bugs caused by difference between elm widget
and atspi objects hierarchy.

8 years agoatspi: always update cache
Lukasz Stanislawski [Fri, 9 Oct 2015 14:17:52 +0000 (16:17 +0200)]
atspi: always update cache

libatspi implementation allows to call methods on objects which
are not added to client cache with "AddAccessible" at-spi signal.
Bridge should allow to perform such calls by updating its internal
cache as soons as it returns a reference to the dbus object to client.

8 years agorelease: Update NEWS and bump version for 1.16.0-beta2 release
Stefan Schmidt [Mon, 19 Oct 2015 11:55:40 +0000 (13:55 +0200)]
release: Update NEWS and bump version for 1.16.0-beta2 release

8 years agoatspi: fix typo
Lukasz Stanislawski [Mon, 19 Oct 2015 11:39:56 +0000 (13:39 +0200)]
atspi: fix typo

8 years agotest_genlist: set focus on popup's button
Amitesh Singh [Fri, 16 Oct 2015 19:20:17 +0000 (00:50 +0530)]
test_genlist: set focus on popup's button

8 years agotoolbar: shutup compiler warning.
Cedric BAIL [Fri, 16 Oct 2015 00:23:21 +0000 (17:23 -0700)]
toolbar: shutup compiler warning.

8 years agotoolbar: delay evaluation of the toolbar size until it stabilize.
Cedric BAIL [Thu, 15 Oct 2015 23:33:15 +0000 (16:33 -0700)]
toolbar: delay evaluation of the toolbar size until it stabilize.

Elementary is not using much the calculate callback from Evas. This
create all sort of problem where it transform O(n) algorithm. Like
sizing a toolbar for next frame to O(n^n) by actually sizing the
toolbar every time an object is inserted.

T2777

8 years agotoolbar: remove useless call to _sizing_eval.
Cedric BAIL [Thu, 15 Oct 2015 23:31:00 +0000 (16:31 -0700)]
toolbar: remove useless call to _sizing_eval.

_sizing_eval is very costly on toolbar as it recalc all edje part and sends
signal to all of them. _item_theme_hook was already calling _sizing_eval
doubling the cost of adding new item.

8 years agoborder: bring sparklebear theme up-to-date with current efl rendering
Mike Blumenkrantz [Thu, 15 Oct 2015 20:35:46 +0000 (16:35 -0400)]
border: bring sparklebear theme up-to-date with current efl rendering

various fixes have occurred over the years to improve proxy rendering.
as a result, this theme, which is apparently the only other user of proxy
edje parts besides deskmirror, was broken.

@fix

8 years agodeskmirror: unset proxy.source_clip for urgency effects
Mike Blumenkrantz [Thu, 15 Oct 2015 20:09:39 +0000 (16:09 -0400)]
deskmirror: unset proxy.source_clip for urgency effects

cfedba598c23844946c5af2e038870c7ca6befdc in efl fixed source clipping
for proxy objects, breaking badly-clipped edje proxy objects everywhere

@fix

8 years agoexample: genlist - intialize buffer array to 0
Amitesh Singh [Wed, 14 Oct 2015 15:17:46 +0000 (20:47 +0530)]
example: genlist - intialize buffer array to 0

CID: 1327347

8 years agoexample: genlist - intialize buffer array to 0
Amitesh Singh [Wed, 14 Oct 2015 15:12:39 +0000 (20:42 +0530)]
example: genlist - intialize buffer array to 0

CID: 1327346

8 years agoexample: glview - use delete to deallocate memory
Amitesh Singh [Wed, 14 Oct 2015 15:02:51 +0000 (20:32 +0530)]
example: glview - use delete to deallocate memory

CID: 1327362

8 years agoexample: glview - use delete to deallocate memory
Amitesh Singh [Wed, 14 Oct 2015 14:57:57 +0000 (20:27 +0530)]
example: glview - use delete to deallocate memory

CID: 1327363

8 years agoelementary: Fix genlist example to not free data until After it has
Chris Michael [Wed, 14 Oct 2015 14:52:03 +0000 (10:52 -0400)]
elementary: Fix genlist example to not free data until After it has
been removed from the list

@fix CID1327342

Signed-off-by: Chris Michael <cp.michael@samsung.com>
8 years agoelementary: Remove unused static variable
Chris Michael [Wed, 14 Oct 2015 14:04:03 +0000 (10:04 -0400)]
elementary: Remove unused static variable

Summary: clang reports _list_focus_objects as being an unused static
variable, so remove

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>