Stefan Schmidt [Mon, 20 Feb 2017 21:45:31 +0000 (22:45 +0100)]
release: Update NEWS and bump version for 1.19.0-beta2 release
Mykyta Biliavskyi [Mon, 20 Feb 2017 09:29:56 +0000 (11:29 +0200)]
eina utils: fix build without getpwent.
If HAVE_GETPWENT isn't defined - the closing brace was missed.
Also prevent situation when strdup() tried to duplicate NULL
pointer, because that could cause segfault.
@fix
Wonki Kim [Mon, 20 Feb 2017 02:31:12 +0000 (11:31 +0900)]
interface_scrollable: Improve gravity_set api to support pan changing
Summary:
When you set gravity 1 on scroller, scroller sticks to the bottom
even content is changed.
however, scroller don't work like above, if size of pan is changed.
this commit uses pan_pos_max rather than w/h of content_info
because pan_pos_max is related with both content_size and pan size.
gravity_set will work properly even if both size of content and pan are
changed simultaneously.
Test Plan:
1. Select 'scroll3' in the elementary_test
2. Append enough items so that scroll bar appears (about 30 items)
3. Go to the bottom and Set gravity 1.0
4. Check that scroller sticks to the bottom once you append another item
(it works)
5. Check that scroller sticks to to bottom once you resize window(pan)
(it doesn't work without this patch)
Reviewers: eagleeye, jpeg, cedric, woohyun, z-wony, herdsman
Differential Revision: https://phab.enlightenment.org/D4665
Marcel Hollerbach [Mon, 20 Feb 2017 02:11:34 +0000 (11:11 +0900)]
evas: do not error for smart class objects
Summary: this should fix some spamming in e
Reviewers: jpeg
Reviewed By: jpeg
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D4675
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Jiyoun Park [Mon, 20 Feb 2017 01:28:27 +0000 (10:28 +0900)]
ecore_evas_wayland_common: fix bug that window is not rotated when app request rotate.
In landscape mode, width & height of evas are different with ecore's.
so diff is checked differently according to the portrait & landscape mode.
Jean-Philippe Andre [Fri, 17 Feb 2017 07:59:41 +0000 (16:59 +0900)]
elm_test: Add autobounce test for "Scroller 2"
Daniel Hirt [Sun, 19 Feb 2017 16:10:24 +0000 (18:10 +0200)]
Canvas text: fix clearing existing style
Fixes T5187.
This fixes a leak in evas_textblock_style_user_pop, that made use of the
new key-based efl_canvas_text_style_set api.
@fix
Andy Williams [Sun, 19 Feb 2017 14:15:29 +0000 (14:15 +0000)]
elm_code: Another Coverity fix, better this time.
@fix CID1371322
Carsten Haitzler (Rasterman) [Sun, 19 Feb 2017 12:11:57 +0000 (21:11 +0900)]
readme - systemd is default on now... --disable if you dont want it
Carsten Haitzler (Rasterman) [Sun, 19 Feb 2017 06:48:41 +0000 (15:48 +0900)]
elm code - fix warning about sign comparisons
Andy Williams [Sat, 18 Feb 2017 21:41:53 +0000 (21:41 +0000)]
elm_code: Fix Coverity issues.
@fix CID1356612 CID1368335 CID1368489 CID1371123 CID1371124 CID1371126 CID1371128
Carsten Haitzler (Rasterman) [Fri, 17 Feb 2017 08:34:44 +0000 (17:34 +0900)]
elm config base profiles - fixselect allow to be orrectly iniitted
fixes previous commit...
Carsten Haitzler (Rasterman) [Fri, 17 Feb 2017 08:21:20 +0000 (17:21 +0900)]
fix entry selection by having proper cfg update and def fields
this should fix T5183
Marcel Hollerbach [Thu, 16 Feb 2017 21:37:16 +0000 (13:37 -0800)]
eo: ensure the generation is correctly clamped
Summary:
when a few recursive event emissions are happening, and in some deep
recursive level a subscription to the same object is happening, the
subscription would just be executed when the complete recursion is done.
that is wrong. The subscription needs to be executed when the event is
called after the subscription is added, undepended from any recursive
level. That fixes that and adds a regression test for it.
This was discovered in e, since e gives a lot of error messages about a eo object
that is already freed. It turned out this object is returned from evas, and exactly
the above happened to the EFL_EVENT_DEL subscription of that object.
Test Plan: make check
Reviewers: tasn, cedric, stefan_schmidt
Subscribers: stefan_schmidt, netstar, zmike, raster, jpeg
Differential Revision: https://phab.enlightenment.org/D4656
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Myoungwoon Roy, Kim [Thu, 16 Feb 2017 18:16:49 +0000 (10:16 -0800)]
doxygen: fix typos and some wrong expressions in Edje and Eet API reference documentation.
Summary: I had fixed some typos and some wrong expressions, such as capital letters, singular, and orders of groups in Edje and Eet API reference doxygen.
Test Plan: Doxygen Revision
Reviewers: stefan, cedric, raster, Jaehyun_Cho, jpeg
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4666
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Daniel Kolesa [Thu, 16 Feb 2017 16:29:23 +0000 (17:29 +0100)]
docgen: add -p to print what exactly is being generated currently
Daniel Kolesa [Thu, 16 Feb 2017 16:20:00 +0000 (17:20 +0100)]
docgen: make sure all class retrievals are cached
Daniel Kolesa [Thu, 16 Feb 2017 16:12:43 +0000 (17:12 +0100)]
docgen: cache function instantiations
Daniel Kolesa [Thu, 16 Feb 2017 15:06:56 +0000 (16:06 +0100)]
docgen: cache class retrievals for performance
Jean-Philippe Andre [Thu, 16 Feb 2017 13:05:58 +0000 (22:05 +0900)]
gengrid: Remove duplicated smart callbacks
WRN... evas_smart.c:219 evas_smart_cb_descriptions_fix() duplicated
smart callback description with name 'item,focused' and type ''
Jean-Philippe Andre [Thu, 16 Feb 2017 13:00:19 +0000 (22:00 +0900)]
widget: Reduce WRN to DBG for on_focus_region message
Many widgets don't implement this function, and this case is
perfectly well handled by the caller. No need to WRN here.
Jean-Philippe Andre [Thu, 16 Feb 2017 12:56:11 +0000 (21:56 +0900)]
evas: Silence useless WRN message on canvas del
Jean-Philippe Andre [Thu, 16 Feb 2017 12:51:47 +0000 (21:51 +0900)]
ecore_evas: Fix mouse event in inlined windows
This fixes the following ERR message:
ERR<10589>:eina_safety /home/jpeg/e/core/efl/src/lib/ecore_evas/ecore_evas.c:3149
_ecore_evas_mouse_move_process_internal() safety check failed: cursor == NULL
Jean-Philippe Andre [Thu, 16 Feb 2017 12:45:12 +0000 (21:45 +0900)]
win: Avoid magic check failed in ecore with inline win
Fixes T4663
Jean-Philippe Andre [Thu, 16 Feb 2017 12:32:39 +0000 (21:32 +0900)]
elm_test: Fix invalid API use (EO)
Jean-Philippe Andre [Thu, 16 Feb 2017 11:40:22 +0000 (20:40 +0900)]
win: Avoid malloc in icon_object_set
Also support both Evas.Image and EO Efl.Canvas.Image classes.
Add a test case in elm_test (under "Icon").
I'm not so happy about this patch... it shows that the API
barrier between legacy and EO implemented for images may not
be such a great idea after all :(
Jean-Philippe Andre [Thu, 16 Feb 2017 11:17:12 +0000 (20:17 +0900)]
evas: Flush post-event callbacks only when needed
This avoids flushing the post-event cb queue when processing
recursive events. See
54e5841b2f6386765dd5e2831aa3481b952e5.
Jean-Philippe Andre [Thu, 16 Feb 2017 11:05:04 +0000 (20:05 +0900)]
win: Fix window icons with object set
Fixes T4981
Jean-Philippe Andre [Thu, 16 Feb 2017 10:34:08 +0000 (19:34 +0900)]
evas: Re-fix post-event cb by supporting recursion
The previous patch (
b184874fa5a0c3177c) was preventing
post-event callbacks from triggering any form of input event,
including side-effects due to mouse,in. In fact by tracking
which exact events we want to post-process we can support
proper recursion. This fixes crashes in Bryce.
I'm not changing the documentation as this is still a dubious
code design.
Fixes T3144
Fixes T5157
Jean-Philippe Andre [Thu, 16 Feb 2017 07:47:57 +0000 (16:47 +0900)]
evas: Strengthen post-event callbacks
See T3144 that I marked as Wontfix.
Bryce in E manually feeds events from a post-event callback
resulting in Evas going insane and leading to frequent crashes.
The ideal solution (for E) would be to ensure that everything works
smoothly, the input event data is valid up until the post-event cb
is called, etc... Unfortunately, with recursive events the exact
order of operations may be messed up: the post-event
I don't want to add yet more complexity to Evas events here (it's
already spaghetti all over the place) so I'm simply blocking any
new event feed when running the post-event callback list.
It's not possible to just freeze the events (I tried, it failed).
**********************
Some more explanation:
post-event callbacks are used to implement reverse-order logic
where the on-hold flag of an input event may be set by an event
listener that does not come first.
Here's a situation to illustrate: scroller A inside scroller B.
As events are propagated from children to parents (assuming the
propagate flag is set), we'd assume the events to go first to A
and then to B, which means a mouse wheel event would make the
inner-most scroller (A) scroll, and the outer-most scroller (B)
wouldn't budge.
But as things are designed, A and B are not simple evas objects,
and the actual event-catching object is a top-most transparent
rectangle (top-most in Z stack order). Since A is inside B, B's
rectangle BR is over A's rectangle AR, thus catches the wheel
event first. But in terms of UX we still want A to scroll, not B.
The solution then is to reverse the event processing order and
post-event callbacks are the way to do that. This comes with the
consequence that the event_info needs to remain valid until the
post-event is called, and stay the same (so that the on-hold flag
set by A can be read by B).
Recursive events (by explicit feed or modifying the canvas so
that mouse,in or mouse,out are triggered) mess with this logic,
and trigger the post-events too early (event is not fully
processed) or too late (event_info is not valid anymore... and
crash!).
Thanks @raster for explaining the goal of post-event callbacks!
Jean-Philippe Andre [Thu, 16 Feb 2017 07:26:42 +0000 (16:26 +0900)]
evas: Ensure post-event cb push is called from an event cb
This rejects calls to evas_post_event_callback_push() that don't
originate from inside an input event callback.
Jean-Philippe Andre [Thu, 16 Feb 2017 07:25:50 +0000 (16:25 +0900)]
evas/doc: Add warning about post_event_callback_push
Carsten Haitzler (Rasterman) [Thu, 16 Feb 2017 01:18:54 +0000 (10:18 +0900)]
Revert "Revert "evas textblock: keep previous size when the calculation is skipped""
This reverts commit
b8beb6834b01f9688cb5e7aa177bacbc713318b9.
this now actually works... for some mysterious reason... ? :/ i am
baffled. go back in until we can find the issue then...
Myoungwoon Roy, Kim [Thu, 16 Feb 2017 00:30:18 +0000 (16:30 -0800)]
doxygen: fix typos and some wrong expressions in API reference.
Summary: I had fixed some typos and some wrong expressions, such as capital letters, singular, and orders of groups in API reference doxygen.
Test Plan: Doxygen revision
Reviewers: stefan, cedric, raster, Jaehyun_Cho, jpeg
Subscribers: conr2d
Differential Revision: https://phab.enlightenment.org/D4658
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Godly T.Alias [Thu, 16 Feb 2017 00:29:05 +0000 (16:29 -0800)]
efl: fix memory leak in edje and evas.
Summary:
Signed-off-by: Godly T.Alias <godlytalias@yahoo.co.in>
Signed-off-by: Ayush Srivastava <ayush.sriv@samsung.com>
Test Plan: EFL apps
Reviewers: cedric, raster
Subscribers: rajeshps, ayush.sriv, jpeg, prince.dubey
Differential Revision: https://phab.enlightenment.org/D4660
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Derek Foreman [Wed, 15 Feb 2017 15:51:32 +0000 (09:51 -0600)]
ecore_drm2: ERR once when page flip fails with EBUSY
On systems where this happens it'll probably happen a lot, so
we don't want to continuously log this, but since it's definitely
showing a bug somewhere (efl or kernel) it probably should be an ERR.
Jean-Philippe Andre [Wed, 15 Feb 2017 11:55:58 +0000 (20:55 +0900)]
edje: Fix object leak with Efl.Part
A call to efl_reuse was missing.
Stefan Schmidt [Wed, 15 Feb 2017 11:07:02 +0000 (12:07 +0100)]
evas_loader: add since tag to newly added task_cancelled API
Stefan Schmidt [Wed, 15 Feb 2017 10:13:36 +0000 (11:13 +0100)]
eina_strbuf / eina_ustrbuf: add since tags for newly added APIs
These six have been added in this cycle but missed the since tags.
Stefan Schmidt [Wed, 15 Feb 2017 10:07:42 +0000 (11:07 +0100)]
eina_lock: add since tag to now exposed eina_lock_debug API
This function was static inline before but form 1.19 onwards its EAPI so give
it a since tag.
Stefan Schmidt [Wed, 15 Feb 2017 09:57:11 +0000 (10:57 +0100)]
eina: binbuf: add since tags new append_slice and insert_slice APIs
Jean-Philippe Andre [Wed, 15 Feb 2017 11:07:38 +0000 (20:07 +0900)]
fileselector: Add missing call to group_del
Remove unused refcount thingy and enforce call to smart del.
Fixes T4598
Jean-Philippe Andre [Wed, 15 Feb 2017 11:07:11 +0000 (20:07 +0900)]
group: Track calls to group_del
After a long search I found that fileselector was not calling
super.group_del on deletion, leading to the use of dangling pointers.
So let's verify that group_del is properly called.
See T4598
Jean-Philippe Andre [Wed, 15 Feb 2017 07:23:44 +0000 (16:23 +0900)]
eo: Fix shadow variable warning
Amitesh Singh [Wed, 15 Feb 2017 10:18:38 +0000 (15:48 +0530)]
genlist: remove uncessary _item_cache_zero call
_item_cache_zero() is already getting called in _mirrored_set
Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>
Vyacheslav Reutskiy [Fri, 10 Feb 2017 08:50:35 +0000 (10:50 +0200)]
elm_genlist_item: update docs for 'next_get'
Jean-Philippe Andre [Wed, 15 Feb 2017 06:43:20 +0000 (15:43 +0900)]
textblock: Fix dangling data ref
In this case data_scope_get is more appropriate as the data is
indeed stored on the stack (function scope) and not somewhere else.
After this last fix I see no eo_debug error logs in elementary test.
Yay! eo_debug is now usable :)
Jean-Philippe Andre [Wed, 15 Feb 2017 06:04:20 +0000 (15:04 +0900)]
evas & elm: Fix invalid uses of efl_data_ref(obj, NULL)
The data class should be specified for debug purposes.
Also, this fixes invalid uses inside the smart object
implementation where it assumed that the smart data was part
of the eo data. It may not (legacy objects).
Jean-Philippe Andre [Wed, 15 Feb 2017 06:32:04 +0000 (15:32 +0900)]
evas_render: Remove data_unref that has no data_ref
Jean-Philippe Andre [Wed, 15 Feb 2017 06:25:15 +0000 (15:25 +0900)]
eo_debug: Remove some abusive goto where not needed
goto was used for micro-optimization. There is absolutely no
need for those if we're using the slow path with eo_debug.
Simplify the code.
Jean-Philippe Andre [Wed, 15 Feb 2017 06:19:08 +0000 (15:19 +0900)]
eo_debug: Some more log improvements
Nothing fancy here...
Jean-Philippe Andre [Wed, 15 Feb 2017 05:43:35 +0000 (14:43 +0900)]
eo_debug: Improve dangling xref debug logs even more
In case of manual free, as is heavily used by Evas, we can't really
print an ERR if there are still references before free has been
called.
This may not be ideal from a pure EO point of view but considering
how Evas uses manual free this is the best solution to avoid
polluting debug logs.
Jean-Philippe Andre [Wed, 15 Feb 2017 04:42:29 +0000 (13:42 +0900)]
eo_debug: Improve one log
This changes the following message when the object is referencing
its own data. Also lowers from ERR to WRN and adds the class
name for the referenced data.
ERR<17450>:eo /home/jpeg/e/core/efl/src/lib/eo/eo_private.h:337
_efl_unref_internal() in /home/jpeg/e/core/efl/src/lib/eo/eo.c:620:
func '_efl_object_call_end' Data of object 0x400000021008db58 is
still referenced by object 0x400000021008db58
Note that evas and elm have a few calls to efl_data_ref(obj, NULL)
which are imho quite ugly: not using the return value and not
specifying the data class. I'm keeping them as-is for now.
Jean-Philippe Andre [Wed, 15 Feb 2017 04:32:15 +0000 (13:32 +0900)]
elm_widget: Fix order of operations (isa before data_get)
This fixes some of the occurences of the following error message
when using eo_debug:
ERR<23101>:eo /home/jpeg/e/core/efl/src/lib/eo/eo.c:1955
efl_data_scope_get() Tried getting data of class 'Elm.Widget'
from object of class 'Edje.Object', but the former is not a
direct inheritance of the latter.
If we're going to call efl_isa, then let's at least do it before
efl_data_scope_get.
Woochan Lee [Wed, 15 Feb 2017 04:06:49 +0000 (13:06 +0900)]
elc_multibuttonentry: input panel should be shown whenever mbe is clicked.
Summary:
When mbe got focus the input panel will be shown.
Otherwise, input panel will be hidden.
If the mbe still got focus then input panel hide by user action.
there is no way to reactivate the input panel in case.
Reviewers: woohyun, jpeg, cedric, Hermet
Reviewed By: jpeg
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4661
Shinwoo Kim [Wed, 15 Feb 2017 04:00:13 +0000 (13:00 +0900)]
ecore_input: add API to set/get deadzone of joystick event for an axis.
Summary:
The axis type joystick event could occur without user's control if joystick is too sensitive.
The deadzone prevents this unnecessary event. The default value is 200.
The event value for an axis is a signed integer between -32767 and +32767.
Test Plan: Using example
Reviewers: raster, cedric, jpeg
Reviewed By: jpeg
Subscribers: stefan_schmidt
Differential Revision: https://phab.enlightenment.org/D4654
Derek Foreman [Tue, 14 Feb 2017 23:00:34 +0000 (17:00 -0600)]
build: Add our wayland protocols to the dist
Oops, without these in the distribution tarball you can't
build wayland support.
Stefan Schmidt [Tue, 14 Feb 2017 20:42:20 +0000 (21:42 +0100)]
emotion: add since tag to new emotion_file_meta_artwork_get API
Stefan Schmidt [Tue, 14 Feb 2017 20:33:33 +0000 (21:33 +0100)]
efl: add since tag to new invalid object error type
Stefan Schmidt [Tue, 14 Feb 2017 20:31:59 +0000 (21:31 +0100)]
eo: add missing since tags for functions added during 1.19 cycle
Stefan Schmidt [Tue, 14 Feb 2017 20:16:00 +0000 (21:16 +0100)]
ecore_x: add singce tags for ecore_x_stack_* functions added during 1.19 cycle
Stefan Schmidt [Tue, 14 Feb 2017 20:06:38 +0000 (21:06 +0100)]
ecore_evas: add brief docs and since tags for new ecore_evas_shadow_geometry_*
These have been missing when introduced during the 1.19 cycle.
Chris Michael [Tue, 14 Feb 2017 16:31:57 +0000 (11:31 -0500)]
ecore-wl2: Fix setting input region on a window
Previous code here would store incorrect values into the
window->input rectangle. These values should be what is actually
getting set in the wl_region. This code also fixes an issue when
setting input region for transparent/alpha windows by clearing out
any pending input region (wl_surface_set_input_region(surface, null)).
Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 14 Feb 2017 14:58:49 +0000 (09:58 -0500)]
ecore-wl2: Fix setting opaque region on a window
Previous code here would store incorrect values into the
window->opaque rectangle. These values should be what is actually
getting set in the wl_region. This code also fixes an issue when
setting opaque region for transparent/alpha windows by clearing out
any pending opaque region (wl_surface_set_opaque_region(surface, null)).
Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Carsten Haitzler (Rasterman) [Tue, 14 Feb 2017 08:32:26 +0000 (17:32 +0900)]
Revert "evas textblock: keep previous size when the calculation is skipped"
This reverts commit
c39855a8ac6f86c2dd8b1856ed70f85e0e521f3e.
This actually breaks 1 dialog in e (app exited with error exit code).
it worked everywhere else so i thought it was good. seemingly not
after i saw one of these. revert D3595
Youngbok Shin [Tue, 14 Feb 2017 07:16:45 +0000 (16:16 +0900)]
Edje calc: Fix textblock size calculation logic
Summary:
In singleline textblock, using "text.min: 1 0" and min, max width,
Edje allows to use expandable text with ellipsis. It shows ellipsis
when only text's width reach the max width.
But, Edje couldn't support same feature on multiline textblock.
Edje dose not use max height or text.max properly if ellipsis is enabled.
This feature is very useful to make a layout with dynamically aligned text.
@fix
Reviewers: cedric, tasn, woohyun, raster, herdsman
Subscribers: z-wony, eagleeye, jpeg
Differential Revision: https://phab.enlightenment.org/D3595
Youngbok Shin [Tue, 14 Feb 2017 07:16:26 +0000 (16:16 +0900)]
evas textblock: keep previous size when the calculation is skipped
Summary:
When a size calculation is skipped because of some reasons,
Evas Textblock should keep same size with the previous size.
@fix
Test Plan: N/A
Reviewers: raster, herdsman, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4659
Jean-Philippe Andre [Tue, 14 Feb 2017 06:09:36 +0000 (15:09 +0900)]
ecore_evas: Avoid safety check error log
If an engine can not be used (eg. GL inside a standard Xephyr),
some ERR logs will be printed out by ecore_evas_x. This patch
avoids extra eina_safety error logs from using a NULL pointer.
Jean-Philippe Andre [Tue, 14 Feb 2017 06:02:30 +0000 (15:02 +0900)]
evas key: Add null safety to EAPIs
This avoids a crash with Bryces. This does not fix the problem
with the Bryce itself. Ping @zmike
See T5157
Jean-Philippe Andre [Tue, 14 Feb 2017 05:42:33 +0000 (14:42 +0900)]
evas: Fix double free in post events
A use of the post event callback in Bryce triggered a double free
as an event was being processed but not yet removed from its list,
leading to an invalid state of the Eina_List.
Also remove obj from struct as it is unused.
Fixes T5157
Jean-Philippe Andre [Tue, 14 Feb 2017 01:54:32 +0000 (10:54 +0900)]
evas gl: Fix memory tracking
See
b16c961680579ad13 which by "fixing" indentation changed the
logic of the code. Yes the indentation was misleading (because of
the #if / #else) but the logic was correct. Anyway this is was not
a harmful issue as those memory trackers aren't really used.
Chris Michael [Mon, 13 Feb 2017 18:43:21 +0000 (13:43 -0500)]
ecore-evas-drm: Fix setting rotation during async render
If we are in async render and a call to rotation_set has been made,
then we should delay setting that rotation until rendering is
completed. This patch fixes that issue by setting ee->delayed.rotation
and handling it during _drm_render_updates
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 13 Feb 2017 18:37:06 +0000 (13:37 -0500)]
ecore-evas-wayland: Fix setting rotation during async render
If we are in async render when a call to set rotation happens, we
should not be setting the engine info->rotation until we have actually
handled the rotation. Old code here would set delayed.rotation on the
ecore_evas itself, but then it would tell the engine to rotate. What
we actually want here is If in async render, set the delayed rotation
property and let render_updates deal with any delayed setting.
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 13 Feb 2017 15:31:59 +0000 (10:31 -0500)]
evas-gl-common: Fix misleading indentation
gcc reports that the 'else' here does not guard the latter
statement...seems like a cause of some missing parens so fix.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Mon, 13 Feb 2017 13:56:06 +0000 (14:56 +0100)]
release: Update NEWS and bump version for 1.19.0-beta1 release
Chris Michael [Mon, 13 Feb 2017 14:44:30 +0000 (09:44 -0500)]
ecore-drm2: Fix debug messages to use proper type
Small patch which fixes some FB flipping messages to use the proper
type (ie: some messages were ERR when should be DBG or WRN, etc).
NB: No functional changes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Stefan Schmidt [Mon, 13 Feb 2017 13:30:27 +0000 (14:30 +0100)]
eina: make the ein_file_unlink symbol availbale form the ein_file header
It was only defined in the c file. Without any documentation, since tag, etc.
tests/eina/eina_test_file.c:855:4: warning: implicit declaration of function ‘eina_file_unlink’
[-Wimplicit-function-declaration]
Stefan Schmidt [Mon, 13 Feb 2017 13:20:17 +0000 (14:20 +0100)]
tests: eina_file: check if the fd is really 0 when we set close file to true
The return value from create_file_not_empty was saved but never checked if it
really is 0. Whcih should be the case if we call the function with file_close
true.
Stefan Schmidt [Mon, 13 Feb 2017 13:12:38 +0000 (14:12 +0100)]
tests: eina_file: fix coding style in file_unlink test case
Stefan Schmidt [Mon, 13 Feb 2017 13:10:03 +0000 (14:10 +0100)]
tests: eina_file: remove unused variable
Woochan Lee [Mon, 13 Feb 2017 11:21:52 +0000 (20:21 +0900)]
elm_index: Skip box auto fill when index size is invalid.
Summary:
_index_box_auto_fill will be called when user calling elm_index_level_go(), elm_index_omit_enabled_set().
item size re-calculated and each item style reset even index size is invalid.
It can make performance issue during index creation time.
Test Plan:
elementary_test
index sample
Reviewers: taxi2se, jpeg, cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4653
Jean-Philippe Andre [Mon, 13 Feb 2017 08:42:10 +0000 (17:42 +0900)]
evas gl: Partially fix MSAA for GLES 3 drivers
MSAA (multisampled_render_to_texture) support was implemented with
GLES 2 in mind, but for GLES 3 it comes as a core feature, not as
an extension. Also it relies on renderbuffers, not textures. GL
is awesome.
Note: MSAA still doesn't work!
Jean-Philippe Andre [Mon, 13 Feb 2017 08:11:56 +0000 (17:11 +0900)]
win: Make ELM_ACCEL work with msaa, depth & stencil
This makes the env var override and the elementary config
global override on accel preference work for not only "gl"
but also advanced configs such as "gl:msaa_high:depth:stencil"
Myoungwoon Roy, Kim [Mon, 13 Feb 2017 06:29:11 +0000 (15:29 +0900)]
doxygen: Fix typos & invalid statements in ecore
This covers ecore audio, avahi, buffer and con.
Summary: There are some typos and cacologigue statements in
doxygen of ecore_audio, ecore_avahi, ecore_buffer, and ecore_con.
Test Plan: API Doxygen Revision
Reviewers: stefan, cedric, raster, Jaehyun_Cho
Subscribers: jpeg, conr2d
Differential Revision: https://phab.enlightenment.org/D4652
Myoungwoon Roy, Kim [Mon, 13 Feb 2017 06:29:01 +0000 (15:29 +0900)]
doxygen: Fix typos & invalid statements in Ecore_Getopt and Ecore_Legacy
Summary: There are some typos and calogique statements in doxygen
of Ecore_Getopt and Ecore_Legacy so I had fixed typos and cacologique statements.
Test Plan: Doxygen revision
Reviewers: stefan, cedric, raster, Jaehyun_Cho
Subscribers: jpeg, conr2d
Differential Revision: https://phab.enlightenment.org/D4651
Minkyoung Kim [Mon, 13 Feb 2017 06:11:56 +0000 (15:11 +0900)]
EvasGL: For depth&stencil&msaa, use renderbuffer instead of texture
Summary:
glFramebufferTexture2DMultisampleEXT() supports color attachment only.
so depth&stencil attachment should be bound via renderbuffer not texture.
According to http://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_multisampled_render_to_texture.txt
In order to allow the use of multisampled depth and stencil buffers
when performing multisampled rendering to a texture, the extension
also adds the command RenderbufferStorageMultisampleEXT.
target, textarget, texture, and level correspond to the same
parameters for FramebufferTexture2D and have the same restrictions.
attachment must be COLOR_ATTACHMENT0.
Test Plan: Evas GL on GLES 3
Reviewers: jpeg, raster, dkdk, wonsik
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D4648
Carsten Haitzler (Rasterman) [Mon, 13 Feb 2017 10:00:47 +0000 (19:00 +0900)]
efl net proxy helper - use infinite for and sleeps instead of pause
so the process was waiting to be killed (waiting forever) and i used
pause() but this isnt windows-friendly, so since this process expects
to be killed by the parent process, then use a for (;;) with lon long
long sleeps... instead.
this shoud fix T5174
Carsten Haitzler (Rasterman) [Mon, 13 Feb 2017 09:54:43 +0000 (18:54 +0900)]
configure - eolian seemingly still needs evil due to eina
this should fix T5172
Carsten Haitzler (Rasterman) [Mon, 13 Feb 2017 06:29:09 +0000 (15:29 +0900)]
vpath file - add a keey property to know if obj should be kept around
if its a file downloading (to a tmp location) or a zip/tar/whatever
file being extracted also to a tmp location and that tmp file needs to
be removed after ...you need to keep the obj around to know when to
delete the file. this makes the keeping optional and you query if the
vpath obj is meant to be kept or not. if it's not it's safe to del
immediately.
this cuts down 1 obj per image obj/edje obj when generally unused.
save some mem.
Jaeun Choi [Fri, 10 Feb 2017 07:56:50 +0000 (16:56 +0900)]
evas: fix bugs in gif image loader
gif's logical screen size (which is considered the image size)
might be different from the size of each frame.
when decoding a frame, the width and height of the decoded data should be
based on the size of the frame, not on the size of the logical screen size.
if a frame is decoded into a buffer of screen size, this might happen
(frame = 6 X 3, logical screen = 5 X 3)
OOOXXX OOOXX
OOOXXX => XOOOX
OOOXXX XXOOO
@fix
Carsten Haitzler (Rasterman) [Sun, 12 Feb 2017 06:48:51 +0000 (15:48 +0900)]
evas gl common - make render op explicitly signed as we set it to -1
this just is cleaner and now also matches types for render_op in gl
common context.
Carsten Haitzler (Rasterman) [Sun, 12 Feb 2017 05:45:04 +0000 (14:45 +0900)]
eina inlist - cast container via void ptr to avoid warnings
we really can't do much here but our direct casting causes warnings in
apps or anyone using this macro so keep things silent as our pointer
tricks are actually ok but the compiler can't figure it out.
Marcel Hollerbach [Sat, 11 Feb 2017 22:20:22 +0000 (23:20 +0100)]
evas_table: abort when there is already the option struct
otherwise we would just reuse that struct. This results in
freeing/writing/reading the memory twice.
This error message should give the dev a tip on what went wrong, instead
of leaving cryptic valgrind messages and crashes.
This fixes the sysinfo desktop gadget in enlightenment.
ref T5173
Marcel Hollerbach [Sat, 11 Feb 2017 22:16:25 +0000 (23:16 +0100)]
evas: fix child position when the container is moved
when the position of the container is changed the children should also be
repositioned, so setting the changed flag.
The visual effect where you saw that was in luncher where items of the
bar did not get fully up.
Carsten Haitzler (Rasterman) [Sat, 11 Feb 2017 15:29:01 +0000 (00:29 +0900)]
evlog/log bt - fix size casting tot stop warning when printing errs
Carsten Haitzler (Rasterman) [Sat, 11 Feb 2017 14:08:28 +0000 (23:08 +0900)]
evas color copy neon asm - declare tmp as output not input for warning--
less warnings - use output not input for tmp var. much better.
Carsten Haitzler (Rasterman) [Sat, 11 Feb 2017 13:53:04 +0000 (22:53 +0900)]
eo base - fix warnings for debug logs to get format string types happy
gcc is very unhappy with these log prints - specifically on arm 32bit.
this fixes it so we can focus on real warnings/issues.
Carsten Haitzler (Rasterman) [Sat, 11 Feb 2017 13:41:22 +0000 (22:41 +0900)]
evas generic loader ps - fix warning about printf format mismatch type
it's right. types are uint but format exects unsigned long. fix.
Carsten Haitzler (Rasterman) [Sat, 11 Feb 2017 13:29:26 +0000 (22:29 +0900)]
evas wayland egl engine - fix warning about struct wl_resource not used
this struct is not actually used other than in this func ptr decl and
it's warning-land for gcc, so .. make it void * and do things like
pretty much all other gl extn func ptrs... be very generic
Carsten Haitzler (Rasterman) [Sat, 11 Feb 2017 13:27:21 +0000 (22:27 +0900)]
evas gl drm engine - fix warning about struct wl_resource not used
this struct is not actually used other than in this func ptr decl and
it's warning-land for gcc, so .. make it void * and do things like
pretty much all other gl extn func ptrs... be very generic