Marek Olsak [Fri, 25 Nov 2016 16:03:06 +0000 (16:03 +0000)]
Revert "AMDGPU: Remove m0 spilling code"
This reverts commit
f18de36554eb22416f8ba58e094e0272523a4301.
llvm-svn: 287931
Marek Olsak [Fri, 25 Nov 2016 16:03:02 +0000 (16:03 +0000)]
Revert "AMDGPU: Preserve m0 value when spilling"
This reverts commit
a5a179ffd94fd4136df461ec76fb30f04afa87ce.
llvm-svn: 287930
Eric Liu [Fri, 25 Nov 2016 16:02:49 +0000 (16:02 +0000)]
Do not do raw name replacement when FromDecl is a class forward-declaration.
Summary:
If the `FromDecl` is a class forward declaration, the reference is
still considered as referring to the original definition given the nature
of forward-declarations, so we can't do a raw name replacement in this case.
Reviewers: bkramer
Subscribers: cfe-commits, klimek
Differential Revision: https://reviews.llvm.org/D27132
llvm-svn: 287929
Simon Pilgrim [Fri, 25 Nov 2016 15:07:15 +0000 (15:07 +0000)]
[X86][SSE] Added knownbits through bitcast test
llvm-svn: 287928
Pavel Labath [Fri, 25 Nov 2016 14:43:37 +0000 (14:43 +0000)]
Fix builds Windows and OSX builds after Connection refactor in r287922
Switch various bits of platform-specific code to chrono that I did not notice
when doing a linux build. This exposed a bug that ConnectionGenericFileWindows
did not handle the magic UINT32_MAX timeout value (instead it waited for about an
hour, which is close enough I guess). Fix that as well.
llvm-svn: 287927
Joerg Sonnenberger [Fri, 25 Nov 2016 14:14:43 +0000 (14:14 +0000)]
Document the arguments form of commands.
llvm-svn: 287926
Abhilash Bhandari [Fri, 25 Nov 2016 14:07:44 +0000 (14:07 +0000)]
[Loop Unswitch] Patch to selective unswitch only the reachable branch instructions.
Summary:
The iterative algorithm for Loop Unswitching may render some of the branches unreachable in the unswitched loops.
Given the exponential nature of the algorithm, this is quite an overhead.
This patch fixes this problem by selectively unswitching only those branches within a loop that are reachable from the loop header.
Reviewers: Michael Zolothukin, Anna Thomas, Weiming Zhao.
Subscribers: llvm-commits.
Differential Revision: http://reviews.llvm.org/D26299
llvm-svn: 287925
Eric Liu [Fri, 25 Nov 2016 12:39:03 +0000 (12:39 +0000)]
Consider nested namespaces in the canonical namespace as canonical as well.
Summary:
For example, this case was missed when looking for different but canonical
namespaces. UseContext in this case should be considered as in the canonical
namespace.
```
namespace a { namespace b { <FromContext> } }
namespace a { namespace b { namespace c { <UseContext> } } }
```
Added some commenting.
Reviewers: bkramer
Subscribers: klimek, cfe-commits
Differential Revision: https://reviews.llvm.org/D27125
llvm-svn: 287924
Pavel Labath [Fri, 25 Nov 2016 12:37:49 +0000 (12:37 +0000)]
Fix darwin build broken by r287920
I accidentally used the wrong brackets when including llvm headers.
llvm-svn: 287923
Pavel Labath [Fri, 25 Nov 2016 12:22:32 +0000 (12:22 +0000)]
Introduce Chrono to the Connection class. NFCI.
llvm-svn: 287922
Pavel Labath [Fri, 25 Nov 2016 12:15:17 +0000 (12:15 +0000)]
Fix FreeBSD build error in r287920
The conditional expression is ambiguous there, so help it by explicitly casting.
This will go away once we use chrono all the way down.
llvm-svn: 287921
Pavel Labath [Fri, 25 Nov 2016 11:58:44 +0000 (11:58 +0000)]
Introduce chrono to the Communication class
This replaces the raw integer timeout parameters in the class with their
chrono-based equivalents. To achieve this, I have moved the Timeout class to a
more generic place and added a quick unit test for it.
llvm-svn: 287920
Simon Pilgrim [Fri, 25 Nov 2016 11:10:43 +0000 (11:10 +0000)]
[X86][SSE] Added v16i8 shuffle test case from PR31151
llvm-svn: 287919
Simon Dardis [Fri, 25 Nov 2016 11:06:43 +0000 (11:06 +0000)]
[mips] Correct jal expansion for local symbols in .local directives.
This patch corrects the behaviour of code such as:
.local foo
jal foo
foo:
to use the correct jal expansion when writing ELF files.
Patch by: Daniel Sanders
Reviewers: zoran.jovanovic, seanbruno, vkalintiris
Differential Revision: https://reviews.llvm.org/D24722
llvm-svn: 287918
Johan Engelen [Fri, 25 Nov 2016 11:01:12 +0000 (11:01 +0000)]
Use Clang for D language support.
Differential revision: https://reviews.llvm.org/D24794
llvm-svn: 287917
Pavel Labath [Fri, 25 Nov 2016 10:28:09 +0000 (10:28 +0000)]
Merge Linux and FreeBSD arm64 register contexts
Summary:
This is a test-the-water change about possibilities of reducing duplication in
the register context definitions.
I've named the new class RegisterInfoPOSIX, as RegisterContextPOSIX was already
taken :(. The two files were identical except for a fix by Tamas in D12636,
which was applied to the Linux version only, which fixed a discrepancy between
the definitions of fpsr and fpcr on one hand, and all other floating point
register definitions on the other.
Linux test suite still passes after this change. For freebsd, make the floating
point register behavior consistent, but I don't know whether it will be
consistently fixed, or consistently broken. By eyeballing the code, I have a
feeling that a similar fix to D12636 will be required in
RegisterContextPOSIXProcessMonitor_arm64::ReadRegister, but I can't be sure as I
have no way to test it (the assert in that function should fire upon accessing
the registers if it is wrong though).
Reviewers: emaste, clayborg
Subscribers: aemerson, rengolin, beanz, mgorny, modocache, dmikulin, lldb-commits
Differential Revision: https://reviews.llvm.org/D25947
llvm-svn: 287916
Eugene Leviant [Fri, 25 Nov 2016 08:56:36 +0000 (08:56 +0000)]
[ELF] Refactor getDynRel to print error location
Differential revision: https://reviews.llvm.org/D27055
llvm-svn: 287915
Eugene Leviant [Fri, 25 Nov 2016 08:27:15 +0000 (08:27 +0000)]
[ELF] EhOutputSection improvements
Differential revision: https://reviews.llvm.org/D27098
llvm-svn: 287914
George Rimar [Fri, 25 Nov 2016 08:05:41 +0000 (08:05 +0000)]
[ELF] - Add support for access to most of synthetic sections from linkerscript.
This is important for cases like:
.sdata : {
*(.got.plt .got)
...
}
That was not supported before as there was no way to get access to
synthetic sections from script.
More details on review page.
Differential revision: https://reviews.llvm.org/D27040
llvm-svn: 287913
Dean Michael Berris [Fri, 25 Nov 2016 03:54:45 +0000 (03:54 +0000)]
Revert "[XRay][compiler-rt] XRay Buffer Queue"
Broke the build on arm7 and aarch64.
llvm-svn: 287911
Dean Michael Berris [Fri, 25 Nov 2016 03:14:10 +0000 (03:14 +0000)]
[XRay][compiler-rt] XRay Buffer Queue
Summary:
This implements a simple buffer queue to manage a pre-allocated queue of
fixed-sized buffers to hold XRay records. We need this to support
Flight Data Recorder (FDR) mode. We also implement this as a sub-library
first to allow for development before actually using it in an
implementation.
Some important properties of the buffer queue:
- Thread-safe enqueueing/dequeueing of fixed-size buffers.
- Pre-allocation of buffers at construction.
Reviewers: majnemer, rSerge, echristo
Subscribers: mehdi_amini, mgorny, llvm-commits
Differential Revision: https://reviews.llvm.org/D26232
llvm-svn: 287910
Craig Topper [Fri, 25 Nov 2016 02:29:24 +0000 (02:29 +0000)]
[X86] Invert an 'if' and early out to fix a weird indentation. NFCI
llvm-svn: 287909
Craig Topper [Fri, 25 Nov 2016 02:29:21 +0000 (02:29 +0000)]
[X86] Size a SmallVector to the worst case mask size for a 512-bit shuffle. NFCI
llvm-svn: 287908
Kuba Mracek [Thu, 24 Nov 2016 22:50:22 +0000 (22:50 +0000)]
Add "compiler-rt", "libcxx" and "libcxxabi" to svn:ignore under projects/
Differential Revision: https://reviews.llvm.org/D27069
llvm-svn: 287905
Craig Topper [Thu, 24 Nov 2016 21:48:52 +0000 (21:48 +0000)]
[DAGCombine] Teach DAG combine that if both inputs of a vselect are the same, then the condition doesn't matter and the vselect can be removed.
Selects with scalar condition already handle this correctly.
llvm-svn: 287904
Craig Topper [Thu, 24 Nov 2016 21:48:50 +0000 (21:48 +0000)]
[X86] Modify two tests that passed undef to both sides of a vselect to instead pass unique values.
I'd like to teach DAG combine to remove vselects where both sides are identical and these tests were in the way of that.
llvm-svn: 287903
Kuba Mracek [Thu, 24 Nov 2016 21:24:54 +0000 (21:24 +0000)]
[tsan] Add support for GCD dispatch_suspend and dispatch_resume
GCD queues can be suspended and resumed with dispatch_suspend and dispatch_resume. We need to add synchronization between the call to dispatch_resume and any subsequent executions of blocks in the queue that was resumed. We already have an Acquire(q) before the block executes, so this patch just adds the Release(q) in an interceptor of dispatch_resume.
Differential Revision: https://reviews.llvm.org/D27112
llvm-svn: 287902
Rui Ueyama [Thu, 24 Nov 2016 20:59:44 +0000 (20:59 +0000)]
Use toString() to report incompatible files.
llvm-svn: 287901
Rui Ueyama [Thu, 24 Nov 2016 20:31:43 +0000 (20:31 +0000)]
Include a hint how to see all errors if error is truncated.
This patch changes the error message from
too many errors emitted, stopping now
to
too many errors emitted, stopping now (use -error-limit=0 to see all errors)
Thanks for Sean for the suggestion!
llvm-svn: 287900
Rui Ueyama [Thu, 24 Nov 2016 20:24:18 +0000 (20:24 +0000)]
Define toString(const SymbolBody &) and remove maybeDemangle instead.
Differential Revision: https://reviews.llvm.org/D27065
llvm-svn: 287899
Serge Rogatch [Thu, 24 Nov 2016 18:51:47 +0000 (18:51 +0000)]
Test commit access.
llvm-svn: 287898
Craig Topper [Thu, 24 Nov 2016 18:24:46 +0000 (18:24 +0000)]
[AVX-512] Add tests demonstrating failure to generated masked instructions for VSHUFF32x4 and VSHUFI32x4 due to shuffle lowering widening elements.
llvm-svn: 287897
Pavel Labath [Thu, 24 Nov 2016 17:10:10 +0000 (17:10 +0000)]
Add a couple of tests for the Listener class
I'm considering doing some refactor there, so I am adding these to guard the
current behavior.
llvm-svn: 287896
Rafael Espindola [Thu, 24 Nov 2016 16:38:35 +0000 (16:38 +0000)]
Use a more explicit type for the sizeof.
llvm-svn: 287895
Benjamin Kramer [Thu, 24 Nov 2016 16:01:20 +0000 (16:01 +0000)]
[CodeGen] Pass objects that are expensive to copy by const ref.
No functionality change. Found by clang-tidy's
performance-unnecessary-value-param.
llvm-svn: 287894
Pavel Labath [Thu, 24 Nov 2016 15:54:15 +0000 (15:54 +0000)]
Fix TestMiExec.test_lldbmi_exec_next_instruction
The line numbers come out slightly differently when the test is run with gcc-4.9
as a compiler. The test probably should not depend on that, but that is a
different story.
llvm-svn: 287893
Benjamin Kramer [Thu, 24 Nov 2016 15:42:29 +0000 (15:42 +0000)]
[Format] Avoid copying std::sets and simplify code a bit.
No functional change.
llvm-svn: 287892
Abhilash Bhandari [Thu, 24 Nov 2016 15:40:19 +0000 (15:40 +0000)]
Test Commit, removing a blank line in CREDITS.TXT
llvm-svn: 287891
Benjamin Kramer [Thu, 24 Nov 2016 15:36:17 +0000 (15:36 +0000)]
[Sema] Pass APSInts by const ref, avoiding copies.
No functionality change intended. Fix by clang-tidy's
performance-unnecessary-value-param check.
llvm-svn: 287890
Simon Pilgrim [Thu, 24 Nov 2016 15:24:47 +0000 (15:24 +0000)]
Fix unused variable warning
llvm-svn: 287889
Benjamin Kramer [Thu, 24 Nov 2016 15:17:39 +0000 (15:17 +0000)]
[X86] Don't round trip a unique_ptr through a raw pointer for assignment.
No functional change.
llvm-svn: 287888
Pavel Labath [Thu, 24 Nov 2016 15:16:07 +0000 (15:16 +0000)]
Enable MiExecTestCase-test_lldbmi_exec_next_instruction
Test passes consistently, at least on linux.
llvm-svn: 287887
Simon Pilgrim [Thu, 24 Nov 2016 15:12:56 +0000 (15:12 +0000)]
[X86][SSE] Improve UINT_TO_FP v2i32 -> v2f64
Vectorize UINT_TO_FP v2i32 -> v2f64 instead of scalarization (albeit still on the SIMD unit).
The codegen matches that generated by legalization (and is in fact used by AVX for UINT_TO_FP v4i32 -> v4f64), but has to be done in the x86 backend to account for legalization via 4i32.
Differential Revision: https://reviews.llvm.org/D26938
llvm-svn: 287886
Pavel Labath [Thu, 24 Nov 2016 15:10:15 +0000 (15:10 +0000)]
Enable TestMultithreaded-sb_api_listener_event_process_state on linux/gcc
Passing consistently now.
llvm-svn: 287885
Pavel Labath [Thu, 24 Nov 2016 15:03:31 +0000 (15:03 +0000)]
Enable TestBitfields on linux with clang
The test has been passing for a while now.
llvm-svn: 287884
Pavel Labath [Thu, 24 Nov 2016 14:54:53 +0000 (14:54 +0000)]
Enable TestRegisterVariables for some configurations
It consistently passes for linux-clang-i386, and linux-gcc-x86_64.
llvm-svn: 287883
Simon Pilgrim [Thu, 24 Nov 2016 14:46:55 +0000 (14:46 +0000)]
[X86][AVX512] Add support for v2i64 fptosi/fptoui/sitofp/uitofp on AVX512DQ-only targets
Use 512-bit instructions with subvector insertion/extraction like we do in a number of similar circumstances
llvm-svn: 287882
Pavel Labath [Thu, 24 Nov 2016 14:41:36 +0000 (14:41 +0000)]
Enable WatchpointPythonCommandTestCase-test_continue_in_watchpoint_command
This test passes consistently on linux, so I am removing the overall XFAIL. If it
fails on your configuration, please put a targeted xfail instead (i'll add them
my self if I get any breakage emails).
llvm-svn: 287881
Pavel Labath [Thu, 24 Nov 2016 14:11:47 +0000 (14:11 +0000)]
Use more chrono in AdbClient
This refactors AdbClient interface in terms of std::chrono.
llvm-svn: 287880
Pavel Labath [Thu, 24 Nov 2016 14:03:57 +0000 (14:03 +0000)]
Use chrono in AdbClient
This refactors the class implementations to use chrono. I'll follow this up with
a refactor of the class interface.
llvm-svn: 287879
Simon Pilgrim [Thu, 24 Nov 2016 14:02:30 +0000 (14:02 +0000)]
[X86][AVX512DQVL] Add awareness of vcvtqq2ps and vcvtuqq2ps implicit zeroing of upper 64-bits of xmm result
llvm-svn: 287878
Simon Pilgrim [Thu, 24 Nov 2016 13:38:59 +0000 (13:38 +0000)]
[X86][AVX512DQVL] Add support for v2i64 -> v2f32 SINT_TO_FP/UINT_TO_FP lowering
llvm-svn: 287877
Simon Pilgrim [Thu, 24 Nov 2016 13:26:51 +0000 (13:26 +0000)]
[X86][AVX512DQVL] Add v2i64 -> v2f32 + zero codegen tests
llvm-svn: 287876
Nikolai Bozhenov [Thu, 24 Nov 2016 13:23:35 +0000 (13:23 +0000)]
[x86] Fixing PR28755 by precomputing the address used in CMPXCHG8B
The bug arises during register allocation on i686 for
CMPXCHG8B instruction when base pointer is needed. CMPXCHG8B
needs 4 implicit registers (EAX, EBX, ECX, EDX) and a memory address,
plus ESI is reserved as the base pointer. With such constraints the only
way register allocator would do its job successfully is when the addressing
mode of the instruction requires only one register. If that is not the case
- we are emitting additional LEA instruction to compute the address.
It fixes PR28755.
Patch by Alexander Ivchenko <alexander.ivchenko@intel.com>
Differential Revision: https://reviews.llvm.org/D25088
llvm-svn: 287875
Nikolai Bozhenov [Thu, 24 Nov 2016 13:15:49 +0000 (13:15 +0000)]
[x86] Minor refactoring of X86TargetLowering::EmitInstrWithCustomInserter
Move the definitions of three variables out of the switch.
Patch by Alexander Ivchenko <alexander.ivchenko@intel.com>
Differential Revision: https://reviews.llvm.org/D25192
llvm-svn: 287874
Nikolai Bozhenov [Thu, 24 Nov 2016 13:05:43 +0000 (13:05 +0000)]
[x86] Rewrite getAddressFromInstr helper function
- It does not modify the input instruction
- Second operand of any address is always an Index Register,
make sure we actually check for that, instead of a check for
an immediate value
Patch by Alexander Ivchenko <alexander.ivchenko@intel.com>
Differential Revision: https://reviews.llvm.org/D24938
llvm-svn: 287873
Ehsan Amiri [Thu, 24 Nov 2016 12:40:04 +0000 (12:40 +0000)]
[PPC] support for arithmetic builtins in the FE
(commit again after fixing the buildbot failures)
This adds various overloads of the following builtins to altivec.h:
vec_neg
vec_nabs
vec_adde
vec_addec
vec_sube
vec_subec
vec_subc
Note that for vec_sub builtins on 32 bit integers, the semantics is similar to
what ISA describes for instructions like vsubecuq that work on quadwords: the
first operand is added to the one's complement of the second operand. (As
opposed to two's complement which I expected).
llvm-svn: 287872
Dylan McKay [Thu, 24 Nov 2016 12:38:54 +0000 (12:38 +0000)]
[AVR] Mark the 'select-must-add-unconditional-jump' test as 'XFAIL'
llvm-svn: 287871
Simon Pilgrim [Thu, 24 Nov 2016 12:13:46 +0000 (12:13 +0000)]
[X86] Generalize CVTTPD2DQ/CVTTPD2UDQ and CVTDQ2PD/CVTUDQ2PD opcodes. NFCI
Replace the CVTTPD2DQ/CVTTPD2UDQ and CVTDQ2PD/CVTUDQ2PD opcodes with general versions.
This is an initial step towards similar FP_TO_SINT/FP_TO_UINT and SINT_TO_FP/UINT_TO_FP lowering to AVX512 CVTTPS2QQ/CVTTPS2UQQ and CVTQQ2PS/CVTUQQ2PS with illegal types.
Differential Revision: https://reviews.llvm.org/D27072
llvm-svn: 287870
Peter Smith [Thu, 24 Nov 2016 11:43:55 +0000 (11:43 +0000)]
[ELF] Add terminating sentinel .ARM.exidx table entry
The .ARM.exidx table has an entry for each function with the first entry
giving the start address of the function, the table is sorted in ascending
order of function address. Given a PC value, the unwinder will search the
table for the entry that contains the PC value.
If the table entry happens to be the last, the range of the addresses that
the final unwinding table describes will extend to the end of the address
space. To prevent an incorrect address outside the address range of the
program matching the last entry we follow ld.bfd's example and add a
sentinel EXIDX_CANTUNWIND entry at the end of the table. This gives the
final real table entry an upper bound.
In addition the llvm libunwind unwinder currently depends on the presence
of a sentinel entry (PR31091).
Differential revision: https://reviews.llvm.org/D26977
llvm-svn: 287869
Roger Ferrer Ibanez [Thu, 24 Nov 2016 11:28:02 +0000 (11:28 +0000)]
Reverting wrong diff
I managed to confuse me with two reviews of the same thing and ended commiting the wrong one.
llvm-svn: 287868
Pavel Labath [Thu, 24 Nov 2016 11:22:43 +0000 (11:22 +0000)]
Attempt to fix freebsd build after r287864
the chrono library there uses long long as the underlying chrono type, but
defines int64_t as long (or the other way around, I am not sure). In any case,
this caused the implicit conversion to not trigger. This should address that.
Also fix up the relevant unit test.
llvm-svn: 287867
Roger Ferrer Ibanez [Thu, 24 Nov 2016 11:17:09 +0000 (11:17 +0000)]
Protect tests for std::uninitialized_{copy,fill} under libcpp-no-exceptions
Skip tests that expect an exception be thrown.
Differential Revision: https://reviews.llvm.org/D26606
llvm-svn: 287866
Roger Ferrer Ibanez [Thu, 24 Nov 2016 11:15:09 +0000 (11:15 +0000)]
Protect std::string tests under libcpp-no-exceptions
Skip tests that expect an exception be thrown and/or disable
unreachable catch handlers.
Differential Revision: https://reviews.llvm.org/D26608
llvm-svn: 287865
Pavel Labath [Thu, 24 Nov 2016 10:54:49 +0000 (10:54 +0000)]
Introduce chrono to more gdb-remote functions
Summary:
This replaces the usage of raw integers with duration classes in the gdb-remote
packet management functions. The values are still converted back to integers once
they go into the generic Communication class -- that I am leaving to a separate
change.
The changes are mostly straight-forward (*), the only tricky part was
representation of infinite timeouts.
Currently, we use UINT32_MAX to denote infinite timeout. This is not well suited
for duration classes, as they tend to do arithmetic on the values, and the
identity of the MAX value can easily get lost (e.g.
microseconds(seconds(UINT32_MAX)).count() != UINT32_MAX). We cannot use zero to
represent infinity (as Listener classes do) because we already use it to do
non-blocking polling reads. For this reason, I chose to have an explicit value
for infinity.
The way I achieved that is via llvm::Optional, and I think it reads quite
natural. Passing llvm::None as "timeout" means "no timeout", while passing zero
means "poll". The only tricky part is this breaks implicit conversions (seconds
are implicitly convertible to microseconds, but Optional<seconds> cannot be
easily converted into Optional<microseconds>). For this reason I added a special
class Timeout, inheriting from Optional, and enabling the necessary conversions
one would normally expect.
(*) The other tricky part was GDBRemoteCommunication::PopPacketFromQueue, which
was needlessly complicated. I've simplified it, but that one is only used in
non-stop mode, and so is untested.
Reviewers: clayborg, zturner, jingham
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D26971
llvm-svn: 287864
Haojian Wu [Thu, 24 Nov 2016 10:17:17 +0000 (10:17 +0000)]
[clang-move] Enable dump all declarations in old header.
Summary:
* Add -dump_dels option to dump all declarations from old header. It
will allow clang-move used as a frontend to get declarations from
header. Further more, this will make debugging stuff easier. Currently only
class/function types are supported.
* Refactoring code a little bit by creating a ClangMoveContext which
holds all options for ClangMoveTool, which can simplify the code in
some degree.
Reviewers: ioeric
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D27059
llvm-svn: 287863
Adrian Kuegel [Thu, 24 Nov 2016 10:01:34 +0000 (10:01 +0000)]
Remove \x13 (^S) character that was likely added by mistake.
r287386 added a \x13 character inside a string literal. Most likely this
was by mistake, so remove it.
Differential Revision: https://reviews.llvm.org/D26973
llvm-svn: 287862
Howard Hellyer [Thu, 24 Nov 2016 09:54:09 +0000 (09:54 +0000)]
Patch for lldb bug 26322 “core load hangs”
Correct 0 byte core files uploaded by arc.
llvm-svn: 287861
George Rimar [Thu, 24 Nov 2016 09:42:10 +0000 (09:42 +0000)]
[ELF] - Removed unused method. NFC.
llvm-svn: 287860
Benjamin Kramer [Thu, 24 Nov 2016 09:41:33 +0000 (09:41 +0000)]
[ASTDumper] Add some more character escapes for convenience.
llvm-svn: 287859
Howard Hellyer [Thu, 24 Nov 2016 08:56:37 +0000 (08:56 +0000)]
Patch for lldb bug 26322 “core load hangs”
Summary:
This patch changes the way ProcessElfCore.cpp handles signal information.
The patch changes ProcessElfCore.cpp to use the signal from si_signo in SIGINFO notes in preference to the value of cursig in PRSTATUS notes. The value from SIGINFO seems to be more thread specific. The value from PRSTATUS is usually the same for all threads even if only one thread received a signal.
If it cannot find any SIGINFO blocks it reverts to the old behaviour and uses the value from cursig in PRSTATUS. If after that no thread appears to have been stopped it forces the status of the first thread to be SIGSTOP to prevent lldb hanging waiting for any thread from the core file to change state.
The order is:
- If one or more threads have a non-zero si_signo in SIGINFO that will be used.
- If no threads had a SIGINFO block with a non-zero si_signo set all threads signals to the value in cursig in their PRSTATUS notes.
- If no thread has a signal set to a non-zero value set the signal for only the first thread to SIGSTOP.
This resolves two issues. The first was identified in bug 26322, the second became apparent while investigating this problem and looking at the signal values reported for each thread via “thread list”.
Firstly lldb is able to load core dumps generated by gcore where each thread has a SIGINFO note containing a signal number but cursig in the PRSTATUS block for each thread is 0.
Secondly if a SIGINFO note was found the “thread list” command will no longer show the same signal number for all threads. At the moment if a process crashes, for example with SIGILL, all threads will show “stop reason = signal SIGILL”. With this patch only the thread that executed the illegal instruction shows that stop reason. The other threads show “stop reason = signal 0”.
Reviewers: jingham, clayborg
Subscribers: sas, labath, lldb-commits
Differential Revision: https://reviews.llvm.org/D26676
llvm-svn: 287858
Malcolm Parsons [Thu, 24 Nov 2016 08:54:05 +0000 (08:54 +0000)]
[CommandLine] Remove redundant initializers for StringRef members
Summary: The default constructor for a StringRef stores an empty string.
Reviewers: beanz, zturner
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D27067
llvm-svn: 287857
Jacob Baungard Hansen [Thu, 24 Nov 2016 08:53:28 +0000 (08:53 +0000)]
TableGen: Allow signed immediates for instruction aliases
Patch by Daniel Cederman.
Reviewers: stoklund, arsenm
Subscribers: arsenm, llvm-commits
Differential Revision: https://reviews.llvm.org/D27046
llvm-svn: 287856
Craig Topper [Thu, 24 Nov 2016 05:36:50 +0000 (05:36 +0000)]
[AVX-512] Fix some mask shuffle tests to actually test the case they were supposed to test.
llvm-svn: 287854
Craig Topper [Thu, 24 Nov 2016 05:36:47 +0000 (05:36 +0000)]
[AVX-512] Move a 16 x float shuffle test to the v16 test file and add an integer variant.
llvm-svn: 287853
Kelvin Li [Thu, 24 Nov 2016 03:18:07 +0000 (03:18 +0000)]
Remove comments (NFC)
Differential Revision: https://reviews.llvm.org/D27006
llvm-svn: 287852
Douglas Yung [Thu, 24 Nov 2016 01:53:38 +0000 (01:53 +0000)]
Make these tests work more reliably with Release builds.
Differential Revision: https://reviews.llvm.org/D26827
llvm-svn: 287851
Rui Ueyama [Thu, 24 Nov 2016 01:44:21 +0000 (01:44 +0000)]
Update comment.
llvm-svn: 287850
Rui Ueyama [Thu, 24 Nov 2016 01:43:21 +0000 (01:43 +0000)]
Remove HasError and use ErrorCount instead.
HasError was always true if ErrorCount > 0, so we can use ErrorCount instead.
llvm-svn: 287849
Taras Tsugrii [Thu, 24 Nov 2016 01:34:43 +0000 (01:34 +0000)]
Fix a comparison of integers of different signs warning.
source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:403:21: warning: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Wsign-compare]
for (int i = 0; i < llvm::array_lengthof (magicks); i++)
~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Differential Revision: https://reviews.llvm.org/D27081
llvm-svn: 287848
Joerg Sonnenberger [Thu, 24 Nov 2016 01:24:38 +0000 (01:24 +0000)]
Spelling.
llvm-svn: 287847
Peter Collingbourne [Thu, 24 Nov 2016 01:13:09 +0000 (01:13 +0000)]
Object: Add IRObjectFile::getTargetTriple().
This lets us remove a use of IRObjectFile::getModule() in llvm-nm.
Differential Revision: https://reviews.llvm.org/D27074
llvm-svn: 287846
Peter Collingbourne [Thu, 24 Nov 2016 00:41:05 +0000 (00:41 +0000)]
Object: Simplify the IRObjectFile symbol iterator implementation.
Change the IRObjectFile symbol iterator to be a pointer into a vector of
PointerUnions representing either IR symbols or asm symbols.
This change is in preparation for a future change for supporting multiple
modules in an IRObjectFile. Although it causes an increase in memory
consumption, we can deal with that issue separately by introducing a bitcode
symbol table.
Differential Revision: https://reviews.llvm.org/D26928
llvm-svn: 287845
Matt Arsenault [Thu, 24 Nov 2016 00:26:50 +0000 (00:26 +0000)]
AMDGPU: Preserve m0 value when spilling
llvm-svn: 287844
Matt Arsenault [Thu, 24 Nov 2016 00:26:47 +0000 (00:26 +0000)]
TRI: Add hook to pass scavenger during frame elimination
The scavenger was not passed if requiresFrameIndexScavenging was
enabled. I need to be able to test for the availability of an
unallocatable register here, so I can't create a virtual register for
it.
It might be better to just always use the scavenger and stop
creating virtual registers.
llvm-svn: 287843
Matt Arsenault [Thu, 24 Nov 2016 00:26:44 +0000 (00:26 +0000)]
AMDGPU: Remove m0 spilling code
Since m0 isn't allocatable it should never be spilled anymore.
llvm-svn: 287842
Matt Arsenault [Thu, 24 Nov 2016 00:26:40 +0000 (00:26 +0000)]
AMDGPU: Make m0 unallocatable
m0 may need to be written for spill code, so
we don't want general code uses relying on the
value stored in it.
This introduces a few code quality regressions where copies
from m0 are not coalesced into copies of a copy of m0.
llvm-svn: 287841
Davide Italiano [Thu, 24 Nov 2016 00:23:09 +0000 (00:23 +0000)]
[lib/LTO] Rename few instances of Lto to LTO.
llvm-svn: 287840
Greg Clayton [Wed, 23 Nov 2016 23:30:37 +0000 (23:30 +0000)]
Rely on a single DWARF version instead of having two copies
This patch makes AsmPrinter less reliant on DwarfDebug by relying on the DWARF version in the AsmPrinter's MCStreamer's MCContext. This allows us to remove the redundant DWARF version from DwarfDebug. It also lets us change code that used to access the AsmPrinter's DwarfDebug just to get to the DWARF version by changing the DWARF version accessor on AsmPrinter so that it grabs the version from its MCStreamer's MCContext.
Differential Revision: https://reviews.llvm.org/D27032
llvm-svn: 287839
Eugene Zelenko [Wed, 23 Nov 2016 23:16:32 +0000 (23:16 +0000)]
[DebugInfo] Fix some Clang-tidy modernize-use-default and Include What You Use warnings; other minor fixes (NFC).
Per Zachary Turner and Mehdi Amini suggestion to make only post-commit reviews.
llvm-svn: 287838
Rui Ueyama [Wed, 23 Nov 2016 22:58:25 +0000 (22:58 +0000)]
[COFF] Add DebugInfoCodeView dependency
rL287555 introduces a link error when building with BUILD_SHARED_LIBS:
undefined reference to llvm::codeview::CVSymbolDumper::dump(),
and more...
The functions are available in libDebugInfoCodeView, from LLVM.
Patch by Visoiu Mistrih Francis!
llvm-svn: 287837
Rui Ueyama [Wed, 23 Nov 2016 22:41:00 +0000 (22:41 +0000)]
Set default entry point to .text if no entry point is found.
Previously, if a symbol specified by -e or ENTRY() is not found,
we didn't set entry point address. That is incompatible with GNU
because GNU linkers set the first address of .text to entry.
This patch implement that behavior.
llvm-svn: 287836
Simon Pilgrim [Wed, 23 Nov 2016 22:35:06 +0000 (22:35 +0000)]
[X86][SSE] Add awareness of (v)cvtpd2dq and vcvtpd2udq implicit zeroing of upper 64-bits of xmm result
We've already added the equivalent for (v)cvttpd2dq (rL284459) and vcvttpd2udq
llvm-svn: 287835
Eugene Zelenko [Wed, 23 Nov 2016 22:25:16 +0000 (22:25 +0000)]
[IR] Fix some Clang-tidy modernize-use-default, modernize-use-equal-delete and Include What You Use warnings; other minor fixes (NFC).
Per Zachary Turner and Mehdi Amini suggestion to make only post-commit reviews.
llvm-svn: 287834
Vedant Kumar [Wed, 23 Nov 2016 22:23:42 +0000 (22:23 +0000)]
[test] Use a helper macro to refer to MAP_ANON (NFC)
Some of our internal bots use old SDK's which don't define MAP_ANON.
Use a helper macro to pass the right flag into mmap().
llvm-svn: 287833
Simon Atanasyan [Wed, 23 Nov 2016 22:22:16 +0000 (22:22 +0000)]
[ELF][MIPS] Fix handling of _gp/_gp_disp/__gnu_local_gp symbols
Offset between beginning of a .got section and _gp symbols used in MIPS
GOT relocations calculations. Usually the expression looks like
VA + Offset - GP, where VA is the .got section address, Offset - offset
of the GOT entry, GP - offset between .got and _gp. Also there two "magic"
symbols _gp_disp and __gnu_local_gp which hold the offset mentioned above.
These symbols might be referenced by MIPS relocations.
Now the linker always defines _gp symbol and uses hardcoded value for
its initialization. So offset between .got and _gp is 0x7ff0. The _gp_disp
and __gnu_local_gp defined if required and initialized by 0x7ff0.
In fact that is not correct because _gp symbol might be defined by a linker
script and holds arbitrary value. In that case we need to use this value
in relocation calculation and initialize _gp_disp and __gnu_local_gp
properly.
The patch fixes the problem and completes fixing the bug #30311.
https://llvm.org/bugs/show_bug.cgi?id=30311
Differential revision: https://reviews.llvm.org/D27036
llvm-svn: 287832
Nicolai Haehnle [Wed, 23 Nov 2016 22:14:20 +0000 (22:14 +0000)]
[SelectionDAG] Early-out in TargetLowering::expandMUL (NFC)
Summary: Reduce indentation level; preparation for D24956.
Reviewers: efriedma
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D27063
llvm-svn: 287831
Rui Ueyama [Wed, 23 Nov 2016 22:10:46 +0000 (22:10 +0000)]
Remove trailing whitespace.
llvm-svn: 287830
Stephan T. Lavavej [Wed, 23 Nov 2016 22:03:28 +0000 (22:03 +0000)]
[libcxx] [test] D27027: Strip trailing whitespace.
llvm-svn: 287829
Stephan T. Lavavej [Wed, 23 Nov 2016 22:02:59 +0000 (22:02 +0000)]
[libcxx] [test] D27026: Fix copy-paste silliness; ULL can't ever be 32-bit.
llvm-svn: 287828