Marek Olšák [Fri, 18 Feb 2011 23:06:52 +0000 (00:06 +0100)]
r300g: fix invalid dereference in winsys
radeon_bo_unref may destroy the buffer, so call it after p_atomic_dec, not before.
José Fonseca [Fri, 18 Feb 2011 19:03:08 +0000 (19:03 +0000)]
svga: Fix NULL dereference.
Probably introduced with the surface view move from screen to context.
Brian Paul [Fri, 18 Feb 2011 17:34:06 +0000 (10:34 -0700)]
vbo: add debug code to verify that buffers are unmapped before drawing
Brian Paul [Fri, 18 Feb 2011 16:53:29 +0000 (09:53 -0700)]
mesa: MESA_VERBOSE logging for glRead/Draw/CopyPixels, glBlitFramebuffer
Brian Paul [Fri, 18 Feb 2011 17:28:27 +0000 (10:28 -0700)]
st/mesa: set renderbuffer _BaseFormat in a few places
NOTE: This is a candidate for the 7.9 and 7.10 branches
Brian Paul [Fri, 18 Feb 2011 17:18:34 +0000 (10:18 -0700)]
st/mesa: check buffer orientation in blit_copy_pixels()
Can't invert the region if copying between surfaces with different
orientations.
José Fonseca [Fri, 18 Feb 2011 14:33:55 +0000 (14:33 +0000)]
svga: Ensure pending drawing commands other surface operations are emitted before DMAs.
This behavior was last when moving the transfers to the contexts.
This fixes several piglit failures, which were reading the color renderbuffer
before the draw operations were emitted.
José Fonseca [Fri, 18 Feb 2011 15:07:50 +0000 (15:07 +0000)]
svga: Cannot use negate or abs on source to dsx/dsy instructions.
José Fonseca [Fri, 18 Feb 2011 14:29:48 +0000 (14:29 +0000)]
svga: Ensure SWTNL is created after HWTNL.
Matches the internal driver layering, and prevents null svga->hwtnl
dereferencing from inside the swtnl.
José Fonseca [Fri, 18 Feb 2011 13:53:45 +0000 (13:53 +0000)]
svga: Ensure LRP's restrictions are observed in all uses.
The dst reg must be a temporary, and not be the same as src0 or src2.
José Fonseca [Fri, 18 Feb 2011 13:24:12 +0000 (13:24 +0000)]
svga: Preserve src swizzles in submit_op2/3/4.
Several opcodes require scalar swizzle, and this requirement was
being was not being observed when creating temporaries for other reasons.
Marek Olšák [Fri, 18 Feb 2011 14:29:00 +0000 (15:29 +0100)]
r300g: remove tracking whether vertex buffers need to be validated
This was getting hard to maintain and didn't really bring any real benefits.
Instead, validate buffers when the vertex array state is dirty.
Marek Olšák [Thu, 17 Feb 2011 15:17:34 +0000 (16:17 +0100)]
st/mesa: fix geometry corruption by always re-binding vertex arrays
This is a temporary workaround. It fixes sauerbrauten with shaders enabled.
I guess we might be changing vertex attribs somewhere and not updating
the appropriate dirty flags, therefore we can't rely on them for now.
Or maybe we need to make this state dependent on some other flags too.
More info:
https://bugs.freedesktop.org/show_bug.cgi?id=34378
Jakob Bornecrantz [Thu, 17 Feb 2011 17:16:14 +0000 (17:16 +0000)]
svga: Disable surface cache for textures
Signed-off-by: Jakob Bornecrantz <jakob@vmware.com>
Jakob Bornecrantz [Thu, 17 Feb 2011 14:58:55 +0000 (14:58 +0000)]
svga: Describe svga_sampler_views for refcnt debugging
Signed-off-by: Jakob Bornecrantz <jakob@vmware.com>
Jakob Bornecrantz [Thu, 17 Feb 2011 17:14:44 +0000 (17:14 +0000)]
svga: Make sure that refcnt debugger gets the correct backtrace for create
Signed-off-by: Jakob Bornecrantz <jakob@vmware.com>
Jakob Bornecrantz [Thu, 17 Feb 2011 11:18:02 +0000 (11:18 +0000)]
util: Make refcnt and symbol debuggers work on windows
Signed-off-by: Jakob Bornecrantz <jakob@vmware.com>
Cyril Brulebois [Fri, 18 Feb 2011 08:10:28 +0000 (00:10 -0800)]
Point to bugs.freedesktop.org rather than bugzilla.freedesktop.org
Suggested by a freedesktop.org admin.
Signed-off-by: Cyril Brulebois <kibi@debian.org>
Marek Olšák [Fri, 18 Feb 2011 12:45:29 +0000 (13:45 +0100)]
u_vbuf_mgr: initialize flag indicating that buffers have been updated
This fixes r300g errors:
r300: Cannot get a relocation in radeon_drm_cs_write_reloc.
Thomas Hellstrom [Fri, 18 Feb 2011 10:36:34 +0000 (11:36 +0100)]
gallium/svga: Fix unnecessary swtnl fallbacks
When we drop the in_swtnl_draw flag, we must force a rerun of
update_need_swtnl to reset the need_swtnl flag to its correct value outside
of a swtnl vbo draw.
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Dave Airlie [Fri, 18 Feb 2011 05:59:58 +0000 (15:59 +1000)]
r600g: reorganise rgtc pieces.
when the cs checker fixes go upstream a lot of this can disappear
into a drm version check.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Brian Paul [Fri, 18 Feb 2011 02:10:13 +0000 (19:10 -0700)]
st/mesa: implement blit-based path for glCopyPixels
If doing a simple non-overlapping glCopyPixels with no per-fragment ops
we can use pipe_context::resource_copy_region().
Brian Paul [Fri, 18 Feb 2011 01:12:25 +0000 (18:12 -0700)]
mesa: fix comments for _mesa_clip_readpixels()
Brian Paul [Thu, 17 Feb 2011 16:44:44 +0000 (09:44 -0700)]
st/mesa: indentation fix
Fabian Bieler [Wed, 16 Feb 2011 09:02:47 +0000 (10:02 +0100)]
r600g: Start a new TEX clause if the texture lookup address was fetched in the current clause
Signed-off-by: Dave Airlie <airlied@redhat.com>
Fabian Bieler [Tue, 15 Feb 2011 12:00:49 +0000 (13:00 +0100)]
r600g: Add support to dump vertex- and texture-fetch clauses
Signed-off-by: Dave Airlie <airlied@redhat.com>
Dave Airlie [Thu, 17 Feb 2011 23:34:53 +0000 (09:34 +1000)]
r600g: add BC4/5 to RGTC conversion
this doesn't do anything much since the rest of mesa doesn't
support RGTC yet.
José Fonseca [Thu, 17 Feb 2011 17:13:51 +0000 (17:13 +0000)]
util: Fix typo in last commit.
Brian Paul [Thu, 17 Feb 2011 17:09:37 +0000 (10:09 -0700)]
st/mesa: fix incorrect glCopyPixels position on fallback path
If we hit the pipe_get/put_tile() path for setting up the glCopyPixels
texture we were passing the wrong x/y position to pipe_get_tile().
The x/y position was already accounted for in the pipe_get_transfer()
call so we were effectively reading from 2*readX, 2*readY.
NOTE: This is a candidate for the 7.9 and 7.10 branches.
Brian Paul [Thu, 17 Feb 2011 16:21:24 +0000 (09:21 -0700)]
draw: update comments, rename vars in pstipple code
José Fonseca [Thu, 17 Feb 2011 10:09:06 +0000 (10:09 +0000)]
svga: Don't use more than one constant per IFC instruction.
José Fonseca [Thu, 17 Feb 2011 09:48:17 +0000 (09:48 +0000)]
mesa: Do copy propagation across if-else-endif.
Addresses excessive TEMP allocation in vertex shaders where all CONSTs are
stored into TEMPS at the start, but copy propagation was failing due to
the presence of IFs.
We could do something about loops, but ifs are easy enough.
José Fonseca [Thu, 17 Feb 2011 15:26:15 +0000 (15:26 +0000)]
util: Cleanup symbol name resolution on Windows.
- Support symbol name resolution on MinGW.
- Use dbghelp.dll (which should allow 64bit support), but untested yet.
- Cleanup.
Brian Paul [Thu, 17 Feb 2011 14:29:20 +0000 (07:29 -0700)]
docs: updated environment variable list
Brian Paul [Thu, 17 Feb 2011 14:28:51 +0000 (07:28 -0700)]
st/mesa: remove unused screen variables
Brian Paul [Thu, 17 Feb 2011 14:27:17 +0000 (07:27 -0700)]
mesa: remove the MESA_NO_DITHER env var
This was sometimes useful back when 16-bit framebuffers were prominent.
Brian Paul [Thu, 17 Feb 2011 14:23:40 +0000 (07:23 -0700)]
softpipe: rename env vars to be consistent
Haitao Feng [Thu, 17 Feb 2011 04:05:15 +0000 (23:05 -0500)]
egl_dri2: add swrast
This enables the egl_dri2 driver to load swrast driver
for software rendering. It could be used when hardware
dri2 drivers are not available, such as in VM.
Signed-off-by: Haitao Feng <haitao.feng@intel.com>
Dave Airlie [Thu, 17 Feb 2011 00:25:57 +0000 (10:25 +1000)]
r600g: get s3tc working on cards with crappy 64/128 bit types.
Some cards don't appear to work correctly with the UNORM type,
so switch to the integer type, however since gallium has no
integer types yet from what I can see we need to do a hack to
workaround it for the blitter.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Dave Airlie [Thu, 17 Feb 2011 00:24:15 +0000 (10:24 +1000)]
r600g: add missing type to color buffer swap.
Brian Paul [Thu, 17 Feb 2011 00:10:35 +0000 (17:10 -0700)]
gallium/util: init key with memset()
To silence missing initializers warning.
Brian Paul [Wed, 16 Feb 2011 21:20:14 +0000 (14:20 -0700)]
svga: flush when transitioning between HW and SW rendering paths
To avoid mixing HW and SW rendering with the same vertex buffer.
Brian Paul [Wed, 16 Feb 2011 21:17:41 +0000 (14:17 -0700)]
rtasm: add dummy return statement to silence MSVC warning
And use assert(0) instead of abort() to be consistent with rest
of Gallium.
Brian Paul [Tue, 15 Feb 2011 21:06:21 +0000 (14:06 -0700)]
svga: use TRUE/FALSE instead of 0/1
Some fields are booleans, others are bitmasks. Use TRUE/FALSE to
clarify what's what.
Brian Paul [Tue, 15 Feb 2011 20:24:41 +0000 (13:24 -0700)]
svga: fix incorrect comment
Brian Paul [Tue, 15 Feb 2011 20:24:21 +0000 (13:24 -0700)]
svga: dimension the dirty[] array with SVGA_STATE_MAX
Brian Paul [Tue, 15 Feb 2011 17:26:56 +0000 (10:26 -0700)]
mesa: make _mesa_write_renderbuffer_image() non-static
Brian Paul [Fri, 11 Feb 2011 21:30:31 +0000 (14:30 -0700)]
svga: disable a debug_printf() call
Sam Hocevar [Thu, 17 Feb 2011 00:04:20 +0000 (17:04 -0700)]
docs: add glsl info
Sam Hocevar [Thu, 17 Feb 2011 00:04:03 +0000 (17:04 -0700)]
docs: fix glsl_compiler name
Brian Paul [Wed, 16 Feb 2011 17:35:21 +0000 (10:35 -0700)]
mesa: 80-column wrap
José Fonseca [Wed, 16 Feb 2011 21:52:49 +0000 (21:52 +0000)]
svga: Proper redefine_user_buffer implementation.
Unfortunately still not enough to make GoogleEarth happy.
Marek Olšák [Wed, 16 Feb 2011 21:23:23 +0000 (22:23 +0100)]
r300g: fix a race between CS and SET_TILING ioctls
Marek Olšák [Wed, 16 Feb 2011 19:09:06 +0000 (20:09 +0100)]
r300g: fix blitting NPOT compressed textures
Marek Olšák [Wed, 16 Feb 2011 19:37:28 +0000 (20:37 +0100)]
mesa: fix texture3D mipmap generation for UNSIGNED_BYTE_3_3_2 and 4_4
Oops, I copy-pasted a typo from 3_3_2.
The 3_3_2 part is a candidate for 7.9 and 7.10.
The 4_4 part isn't, because AL44 is in neither branches.
Marek Olšák [Wed, 16 Feb 2011 09:07:05 +0000 (10:07 +0100)]
mesa: fix mipmap generation for MESA_FORMAT_AL44
This was missed when implementing AL44.
José Fonseca [Tue, 15 Feb 2011 17:31:31 +0000 (17:31 +0000)]
scons: Recognize 'AMD64' processor as well.
José Fonseca [Tue, 15 Feb 2011 17:01:20 +0000 (17:01 +0000)]
scons: Don't get fooled by 32bit python on a 64bit windows.
José Fonseca [Tue, 15 Feb 2011 15:31:19 +0000 (15:31 +0000)]
scons: Avoid depending on scons 2.0 in general.
José Fonseca [Tue, 21 Sep 2010 10:47:19 +0000 (11:47 +0100)]
mesa: Remove the DXT compression via blit path.
No longer used.
José Fonseca [Tue, 21 Sep 2010 10:46:20 +0000 (11:46 +0100)]
svga: Don't fake DXT compression ability.
Christoph Bumiller [Wed, 16 Feb 2011 14:41:32 +0000 (15:41 +0100)]
nvc0: fix blend factor mapping
Christoph Bumiller [Wed, 16 Feb 2011 10:57:00 +0000 (11:57 +0100)]
nvc0: fix emit_dfdx,dfdy
Christoph Bumiller [Wed, 16 Feb 2011 10:42:28 +0000 (11:42 +0100)]
nvc0: don't swap sources if either value is not in a GPR
The memory / immediate source should already be in the only valid
position.
Christoph Bumiller [Tue, 15 Feb 2011 20:36:57 +0000 (21:36 +0100)]
nvc0: add missing break statements in constant_operand
Christoph Bumiller [Tue, 15 Feb 2011 13:41:20 +0000 (14:41 +0100)]
nvc0: fix clipping and use VIEWPORT instead of SCISSOR
Christoph Bumiller [Mon, 14 Feb 2011 13:10:41 +0000 (14:10 +0100)]
nvc0: demagic the clear flags and fix region clears
The CLIP_RECTs always affect dedicated clears, and it's nicer than
having to mark the viewport or scissor state dirty after it.
Christoph Bumiller [Mon, 14 Feb 2011 01:04:58 +0000 (02:04 +0100)]
nvc0: front stencil mask and func mask methods are swapped
Christoph Bumiller [Sat, 12 Feb 2011 23:17:43 +0000 (00:17 +0100)]
nvc0: clone memory values with multiple refs before modifying them
Christoph Bumiller [Sat, 12 Feb 2011 21:02:26 +0000 (22:02 +0100)]
nvc0: disable early fragment tests if KIL is used
Early-Z pass raises the occlusion counter.
Christoph Bumiller [Sat, 12 Feb 2011 18:18:19 +0000 (19:18 +0100)]
nvc0: force vertex data through FIFO if we need to convert it
We may want to put the converted vertex buffer in persistent
storage instead, but these are rare corner cases.
Christoph Bumiller [Sat, 12 Feb 2011 17:50:03 +0000 (18:50 +0100)]
nvc0: use format from the template on surface creation
Fixes piglit/fbo-srgb.
Christoph Bumiller [Sat, 12 Feb 2011 17:27:47 +0000 (18:27 +0100)]
nvc0: update the set of formats supported by the 2D engine
Christoph Bumiller [Tue, 15 Feb 2011 18:12:41 +0000 (19:12 +0100)]
nvc0: fix user vertex buffer updates
Brian Paul [Wed, 16 Feb 2011 14:08:47 +0000 (07:08 -0700)]
mesa: use gl_format type instead of GLuint
Dave Airlie [Wed, 16 Feb 2011 06:51:41 +0000 (16:51 +1000)]
r600g: fix typo in previous s3tc commit
pointed out by Marek on irc.
Marek Olšák [Wed, 16 Feb 2011 04:28:40 +0000 (05:28 +0100)]
r300g: fix texture border color for float formats
Dave Airlie [Wed, 16 Feb 2011 06:13:58 +0000 (16:13 +1000)]
Revert "util: fix DXT1 RGBA texture compression if the source color is (0, 0, 0, 0)"
This reverts commit
6e7d782da506da233b2ac695b022ac393e1c719e.
Oops, I just had this locally for testing and forgot to remove it before pushing.
Dave Airlie [Wed, 16 Feb 2011 06:09:43 +0000 (16:09 +1000)]
r600g: add L8A8 SRGB formats.
this fixes the piglit mipmap generation sRGB on my rv730.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Marek Olšák [Wed, 16 Feb 2011 03:18:42 +0000 (04:18 +0100)]
util: fix DXT1 RGBA texture compression if the source color is (0, 0, 0, 0)
This is a workaround for a bug in libtxc_dxtn.
Fixes:
- piglit/GL_EXT_texture_compression_s3tc/fbo-generatemipmap-formats
Signed-off-by: Dave Airlie <airlied@redhat.com>
Dave Airlie [Wed, 16 Feb 2011 06:01:36 +0000 (16:01 +1000)]
r600g: add L4A4 support.
this fixes piglit fbo-generatemipmap-formats on my rv730.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Dave Airlie [Wed, 16 Feb 2011 05:56:11 +0000 (15:56 +1000)]
r600g: fix s3tc-texsubimage
we need to translate the destination box as well.
fixes piglit's s3tc-texsubimage test.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Ian Romanick [Wed, 16 Feb 2011 02:17:53 +0000 (18:17 -0800)]
linker: Fix off-by-one error implicit array sizing
Arrays are zero based. If the highest element accessed is 6, the
array needs to have 7 elements.
Fixes piglit test glsl-fs-implicit-array-size-03 and bugzilla #34198.
NOTE: This is a candidate for the 7.9 and 7.10 branches.
Vinson Lee [Wed, 16 Feb 2011 01:29:43 +0000 (17:29 -0800)]
st/python: add usage parameter to pipe_buffer_create
This is a follow-up to commit
eafb7f234d11a290b00dcaf5492b9bdad1cf5148.
Fixes Linux SCons build.
Marek Olšák [Tue, 15 Feb 2011 23:51:01 +0000 (00:51 +0100)]
r300g: disable linear filtering for float textures
Chad Versace [Mon, 14 Feb 2011 21:22:39 +0000 (13:22 -0800)]
glsl: Reinstate constant-folding for division by zero
Fixes regression: https://bugs.freedesktop.org/show_bug.cgi?id=34160
Commit
e7c1f058d18f62aa4871aec623f994d7b68cb8c1 disabled constant-folding
when division-by-zero occured. This was a mistake, because the spec does
allow division by zero. (From section 5.9 of the GLSL 1.20 spec: Dividing
by zero does not cause an exception but does result in an unspecified
value.)
For floating-point division, the original pre-e7c1f05 behavior is
reinstated.
For integer division, constant-fold 1/0 to 0.
Chad Versace [Mon, 14 Feb 2011 19:16:42 +0000 (11:16 -0800)]
Revert "glsl: Fix constant-folding for reciprocal expressions"
This reverts commit
b3cf92aa916ee0537ee37723c23a9897ac9cd3e0.
The reverted commit prevented constant-folding of reciprocal expressions
when the reciprocated expression was 0. However, since the spec allows
division by zero, constant-folding *is* permissible in this case.
From Section 5.9 of the GLSL 1.20 spec:
Dividing by zero does not cause an exception but does result in an
unspecified value.
Chad Versace [Tue, 15 Feb 2011 23:30:05 +0000 (15:30 -0800)]
tnl: Add support for datatype GL_FIXED in vertex arrays
Before populating the vertex buffer attribute pointer (VB->AttribPtr[]),
convert vertex data in GL_FIXED format to GL_FLOAT.
Fixes bug: http://bugs.freedesktop.org/show_bug.cgi?id=34047
NOTE: This is a candidate for the 7.9 and 7.10 branches.
Dave Airlie [Tue, 15 Feb 2011 22:50:30 +0000 (08:50 +1000)]
r600g: add srgb compressed formats to the list.
Marek Olšák [Sun, 13 Feb 2011 08:13:14 +0000 (09:13 +0100)]
gallium: add usage parameter to pipe_buffer_create
And set a reasonable buffer usage flag everywhere instead of
just PIPE_USAGE_DEFAULT.
Fabian Bieler [Thu, 10 Feb 2011 15:57:34 +0000 (16:57 +0100)]
r600g: Fix RGB10_A2 format handling
Dave Airlie [Tue, 15 Feb 2011 08:42:48 +0000 (18:42 +1000)]
r600g: fix regression in r6/7xx since mipmap rework
I typod this when copy-pasting.
Vinson Lee [Tue, 15 Feb 2011 08:25:08 +0000 (00:25 -0800)]
nvc0: Fix uninitialized variable warning.
Fixes this GCC warning.
nvc0_tgsi_to_nc.c: In function 'bld_tex':
nvc0_tgsi_to_nc.c:1392: warning: 'dim' may be used uninitialized in this function
Marek Olšák [Tue, 15 Feb 2011 04:43:44 +0000 (05:43 +0100)]
r300g: offload the CS ioctl to another thread
This is a multi-threading optimization which hides the kernel overhead
behind a thread. It improves performance in CPU-limited apps by 2-15%.
Of course you must have at least 2 cores for it to make any difference.
It can be disabled with:
export RADEON_THREAD=0
Dave Airlie [Fri, 11 Feb 2011 03:42:52 +0000 (13:42 +1000)]
r600g: add support for s3tc formats.
On r600, s3tc formats require a 1D tiled texture format,
so we have to do uploads using a blit, via the 64-bit and 128-bit formats
Based on the r600c code we use a 64 and 128-bit type to do the
blits.
Still requires R600_ENABLE_S3TC until the kernel fixes are in,
this has only been tested on evergreen where the kernel doesn't
yet get in the way.
Dave Airlie [Tue, 15 Feb 2011 03:21:50 +0000 (13:21 +1000)]
r600g: fix miptree calculations
the miptree setup and pitch storing didn't work so well for block
based things like compressed textures. The CB takes blocks, where
the texture sampler takes pixels, and transfers need bytes,
So now we store blocks/bytes and translate to pixels in the sampler.
This is necessary for s3tc to work properly.
Dave Airlie [Mon, 14 Feb 2011 03:34:11 +0000 (13:34 +1000)]
r600g: drop tiled flag
we can work this out from the array_mode and it makes more sense
to do that.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Dave Airlie [Tue, 15 Feb 2011 02:50:37 +0000 (12:50 +1000)]
st/mesa: fix compressed mipmap generation.
If the underlying transfer had a stride wider for hw alignment reasons,
the mipmap generation would generate badly strided images.
this fixes a few problems I found while testing r600g with s3tc
Signed-off-by: Dave Airlie <airlied@redhat.com>
Marek Olšák [Tue, 15 Feb 2011 03:41:57 +0000 (04:41 +0100)]
st/mesa: fix GLES build
Broken since
d5062fb3a315c46d77d5c954a3e3c14be1907d33.
I wonder why this code is hidden behind #if by default.
Marek Olšák [Tue, 15 Feb 2011 02:54:24 +0000 (03:54 +0100)]
r300g: actually implement the is_buffer_busy hook the right way
Ooops.