mtklein [Tue, 21 Oct 2014 19:20:04 +0000 (12:20 -0700)]
SkLazyPtr follow ups
- moves test to LazyPtrTest.cpp
- adds the ability to use a Create() method with an argument
BUG=skia:
Review URL: https://codereview.chromium.org/
669783002
robertphillips [Tue, 21 Oct 2014 18:25:37 +0000 (11:25 -0700)]
Widen the set of nested rects that can be drawn natively on the GPU
GrAARectRenderer::fillAANestedRects only handles thin stroked rects correctly if the margins are all the same. It is also correct if all the margins are >= 1.0f. This CL allows such cases to use the fillAANestedRects fast path.
This seems to halve the gpu rendering time of the picture in bug crbug.com/425427.
Review URL: https://codereview.chromium.org/
672473002
mtklein [Tue, 21 Oct 2014 17:55:22 +0000 (10:55 -0700)]
small tweaks to SkResourceCache::Key
- remove unused method and obsolete note
- add a reminder that yes, we are checking counts are equal
BUG=skia:
Review URL: https://codereview.chromium.org/
667993002
reed [Tue, 21 Oct 2014 17:46:01 +0000 (10:46 -0700)]
use - and = to zoom text in slides
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/
668023002
robertphillips [Tue, 21 Oct 2014 17:31:38 +0000 (10:31 -0700)]
Fix debugger's SaveAs functionality
Without this patch the SaveAs functionality only copies the portion of the picture from the current command in the GUI.
Review URL: https://codereview.chromium.org/
672453002
scroggo [Tue, 21 Oct 2014 15:06:05 +0000 (08:06 -0700)]
Check SkStream::isAtEnd before attempting to read.
In FrontBufferedStream, when attempting to read and buffer more
data, do not try to read if the underlying stream is at the end.
Prevents a bug where we continue trying to read a stream that
has nothing more to read.
Review URL: https://codereview.chromium.org/
665303002
egdaniel [Tue, 21 Oct 2014 14:47:10 +0000 (07:47 -0700)]
Add check to see if we need to remove fixed funciton VA in OptDrawState
BUG=skia:
Review URL: https://codereview.chromium.org/
667033003
jvanverth [Tue, 21 Oct 2014 14:39:51 +0000 (07:39 -0700)]
Rebaseline dftext GM for new color emoji test.
BUG=skia:3033
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
671513007
mtklein [Tue, 21 Oct 2014 14:21:36 +0000 (07:21 -0700)]
Clean up some warnings about unused code.
BUG=skia:
Review URL: https://codereview.chromium.org/
663093004
reed [Tue, 21 Oct 2014 14:12:58 +0000 (07:12 -0700)]
add gradients and drawPaint to lua
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
667803004
mtklein [Tue, 21 Oct 2014 14:12:52 +0000 (07:12 -0700)]
Add an assert that we still have a buffer to readFromBuffer().
sk_free(fBuffer.detach()) means fBuffer will be left as NULL, not a zero-length malloc.
BUG=skia:
Review URL: https://codereview.chromium.org/
669813002
senorblanco [Mon, 20 Oct 2014 21:03:12 +0000 (14:03 -0700)]
Fix image filters for PDF backend.
Currently, the PDF backend does not support image filters (since PDF
does not have that functionality), so it simply removes them. This is
causing Chrome print preview to render incorrectly (see bug). The fix
here is to fall back to a raster device for image filters, as we used
to do in Blink. The resulting bitmap will be drawn to the destination
device as a normal main-memory-backed bitmap.
Note: this change invalidates the PDF results of all GMs containing
image filters (since they'll actually be rendered).
BUG=422144
Review URL: https://codereview.chromium.org/
644323006
mtklein [Mon, 20 Oct 2014 20:46:11 +0000 (13:46 -0700)]
SkLazyPtr suitable as a local or class member.
BUG=skia:
Review URL: https://codereview.chromium.org/
653183006
mtklein [Mon, 20 Oct 2014 20:44:24 +0000 (13:44 -0700)]
Dilate approximated text bounds to squelch recent assertion failure.
This is once again an issue related to logo fonts, so I don't
see any easy way to add a regression test for this.
BUG=424824
Review URL: https://codereview.chromium.org/
665103002
bungeman [Mon, 20 Oct 2014 20:33:19 +0000 (13:33 -0700)]
Replace SkTypeface::Style with SkFontStyle.
Committed: https://skia.googlesource.com/skia/+/
43b8b36b20ae00e2d78421c4cda1f3f922983a20
Review URL: https://codereview.chromium.org/
488143002
jvanverth [Mon, 20 Oct 2014 20:12:54 +0000 (13:12 -0700)]
Add color emoji fallback for distance field text.
BUG=skia:3033
Review URL: https://codereview.chromium.org/
670533002
mtklein [Mon, 20 Oct 2014 20:07:03 +0000 (13:07 -0700)]
Stop doing at-exit cleanup of lazy pointers.
There are only a fixed number of them, and we're already intentionally leaking in Release.
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot
BUG=skia:2940
Review URL: https://codereview.chromium.org/
606013004
mtklein [Mon, 20 Oct 2014 19:54:31 +0000 (12:54 -0700)]
Revert of Replace SkTypeface::Style with SkFontStyle. (patchset #9 id:160001 of https://codereview.chromium.org/
488143002/)
Reason for revert:
CrOS GM failures:
[*] 2 ExpectationsMismatch: fontmgr_iter_565.png fontmgr_iter_8888.png
Original issue's description:
> Replace SkTypeface::Style with SkFontStyle.
>
> Committed: https://skia.googlesource.com/skia/+/
43b8b36b20ae00e2d78421c4cda1f3f922983a20
TBR=reed@google.com,bungeman@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
667023002
bungeman [Mon, 20 Oct 2014 19:33:59 +0000 (12:33 -0700)]
Replace SkTypeface::Style with SkFontStyle.
Review URL: https://codereview.chromium.org/
488143002
jcgregorio [Mon, 20 Oct 2014 17:44:35 +0000 (10:44 -0700)]
Move init() to Init() so that flag.Parse() can be called first.
Otherwise the --log_dir flag doesn't affect where glog output goes to.
TBR=humper
BUG=skia:
Review URL: https://codereview.chromium.org/
667493002
mtklein [Mon, 20 Oct 2014 17:43:55 +0000 (10:43 -0700)]
Revert of Start to vectorize SkTileGrid. (patchset #48 id:
1670001 of https://codereview.chromium.org/
634543004/)
Reason for revert:
breaks chrome GPU debug bots
Original issue's description:
> Start to vectorize SkTileGrid.
>
> This adds Sk4x.h to help.
>
> BUG=skia:3041
>
> Committed: https://skia.googlesource.com/skia/+/
90c7992bfc6330f070f7704d63372a0ec8410170
>
> CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot
>
> Committed: https://skia.googlesource.com/skia/+/
958e9628d5f9a81aeafa78572cb4afc4b19a455a
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3041
Review URL: https://codereview.chromium.org/
637863005
scroggo [Mon, 20 Oct 2014 16:55:28 +0000 (09:55 -0700)]
Remove content from public_headers.
The file is unused, but we cannot safely delete it until we remove
the reference in a chromium gyp file.
BUG=skia:2350
Review URL: https://codereview.chromium.org/
663913003
robertphillips [Mon, 20 Oct 2014 15:52:40 +0000 (08:52 -0700)]
Add clip to layer cache
This CL adds the clip region to the GPU layer hoisting image cache. It also switches back to the old caching behavior of using the entire CTM in the cache key rather then just the upper 2x2. This latter change is to focus more on hoisting rather then caching.
It also includes 2 smaller fixes:
a) layer's that have an image filter are no longer atlased (b.c. doing so complicates applying the image filter)
b) the result of clipping the layer's bounds to the current clip is used as the hoisted layer's size. This reduces the amount of pixels drawn to match a normal (non-hoisted) draw pass.
Review URL: https://codereview.chromium.org/
640773004
robertphillips [Mon, 20 Oct 2014 15:45:57 +0000 (08:45 -0700)]
Fix clearing issue in render_pictures
This bug only crops up when using the "--writeWholeImage" option in tile mode
Review URL: https://codereview.chromium.org/
664103003
robertphillips [Mon, 20 Oct 2014 15:12:04 +0000 (08:12 -0700)]
Remove unused parameters from filter_texture
Trivial cleanup.
Review URL: https://codereview.chromium.org/
665863003
mtklein [Mon, 20 Oct 2014 14:12:34 +0000 (07:12 -0700)]
Start to vectorize SkTileGrid.
This adds Sk4x.h to help.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
90c7992bfc6330f070f7704d63372a0ec8410170
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot
Review URL: https://codereview.chromium.org/
634543004
jvanverth [Mon, 20 Oct 2014 13:48:59 +0000 (06:48 -0700)]
When rendering df fonts, pass drawText() down to drawPosText().
First pass at getting color emoji working for distance fields.
BUG=skia:3033
Review URL: https://codereview.chromium.org/
660853003
mtklein [Mon, 20 Oct 2014 13:44:58 +0000 (06:44 -0700)]
Remove obsolete SkRecording.
Can land after https://codereview.chromium.org/
664583002/ does.
BUG=skia:
Only API removed.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
660903002
kkinnunen [Mon, 20 Oct 2014 05:07:23 +0000 (22:07 -0700)]
Make SkImageDecoder_libpng be compilable with Chromium libpng
Chromium has libpng with pngusr.h that disables certain functionality with
defines. Use those defines when compiling SkImageDecoder_libpng.cpp.
This makes it possible to use Skia PNG decoder and encoder when compiling dm
with Chromium. Skia PNG decoder and encoder of course is not compiled to the
skia library, but to dm with Chromium.
BUG=skia:2992
Review URL: https://codereview.chromium.org/
645883004
reed [Sun, 19 Oct 2014 18:42:54 +0000 (11:42 -0700)]
add blurimagefilter to lua
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
663993002
skia-deps-roller [Fri, 17 Oct 2014 22:00:23 +0000 (15:00 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
647973003
halcanary [Fri, 17 Oct 2014 21:36:10 +0000 (14:36 -0700)]
Fix DMWriteTask to write PDF files correctly
Previously, it was not rewinding the asset.
Review URL: https://codereview.chromium.org/
659793004
tfarina [Fri, 17 Oct 2014 21:25:07 +0000 (14:25 -0700)]
bug_chomper: Cleanup template initialization.
Use the same tricks used by webtry and perf. Code seems more robust and
easier to check for errors this way.
BUG=None
TEST=./run_server.sh, then navigate to 127.0.0.1:8000 and
127.0.0.1:8000/res
R=borenet@google.com
Review URL: https://codereview.chromium.org/
661613004
borenet [Fri, 17 Oct 2014 21:17:18 +0000 (14:17 -0700)]
Fix RecreateSKPs bot (again)
It's killing its own process...
BUG=skia:3008
TBR=rmistry
NOTRY=true
Review URL: https://codereview.chromium.org/
661203002
borenet [Fri, 17 Oct 2014 19:15:46 +0000 (12:15 -0700)]
Fix recreate_skps?
run_measurement was removed in https://codereview.chromium.org/
655563007.
Based on the comments, I think the right thing to do is replace it with
run_benchmark. Hopefully this fixes the bot.
BUG=skia:
TBR=rmistry
NOTRY=true
Review URL: https://codereview.chromium.org/
658513004
joshualitt [Fri, 17 Oct 2014 17:54:04 +0000 (10:54 -0700)]
bug fix for glsl identity string
BUG=skia:
Review URL: https://codereview.chromium.org/
659313004
borenet [Fri, 17 Oct 2014 14:37:05 +0000 (07:37 -0700)]
Add recreate_skps script
BUG=skia:3008
Review URL: https://codereview.chromium.org/
655313003
tfarina [Fri, 17 Oct 2014 14:36:36 +0000 (07:36 -0700)]
webtry: Add logserver to serve /tmp/glog.
This setup and runs a logserver, like the one being used by skiaperf, to
serve the directory /tmp/glog, so we don't need to ssh into the instance
to see the logs of the webtry application.
This is a follow up to suggestion made in codereview.chromium.org/
655323002.
BUG=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/
643903003
rmistry [Fri, 17 Oct 2014 13:19:27 +0000 (06:19 -0700)]
Revert of Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe (patchset #5 id:80001 of https://codereview.chromium.org/
613673005/)
Reason for revert:
Trying to fix DEPS roll failure:
https://codereview.chromium.org/
660113002/
Link to failing builds:
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29578
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/29354
Original issue's description:
> Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe
>
> BUG=skia:2947
>
> Committed: https://skia.googlesource.com/skia/+/
687732fe046c9cfec940f2d7f661cd97651d10a8
TBR=junov@chromium.org,reed@google.com,bsalomon@chromium.org,piotaixr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2947
Review URL: https://codereview.chromium.org/
658293004
rmistry [Fri, 17 Oct 2014 13:07:08 +0000 (06:07 -0700)]
Revert of Revert of Support GLSL es 3.00 (patchset #1 id:1 of https://codereview.chromium.org/
661603009/)
Reason for revert:
DEPS roll still failing:
https://codereview.chromium.org/
661993002/
Reverting the revert.
Original issue's description:
> Revert of Support GLSL es 3.00 (patchset #5 id:80001 of https://codereview.chromium.org/
659443007/)
>
> Reason for revert:
> Trying to fix DEPS roll failure:
> https://codereview.chromium.org/
660113002/
>
> Link to failing builds:
> http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29578
> http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/29354
>
> Original issue's description:
> > Support GLSL es 3.00
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/
62372bcc6abe3537dac98dd9b9172cf3b85afa2b
>
> TBR=bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
79b2b1fb12202d22411b607a095cb26c6e4fe8b7
TBR=bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
647043005
rmistry [Fri, 17 Oct 2014 12:14:28 +0000 (05:14 -0700)]
Revert of Support GLSL es 3.00 (patchset #5 id:80001 of https://codereview.chromium.org/
659443007/)
Reason for revert:
Trying to fix DEPS roll failure:
https://codereview.chromium.org/
660113002/
Link to failing builds:
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29578
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/29354
Original issue's description:
> Support GLSL es 3.00
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
62372bcc6abe3537dac98dd9b9172cf3b85afa2b
TBR=bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
661603009
Florin Malita [Fri, 17 Oct 2014 00:45:49 +0000 (20:45 -0400)]
Rebaseline textblob GM
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
654303006
mtklein [Thu, 16 Oct 2014 22:27:47 +0000 (15:27 -0700)]
Revert of Start to vectorize SkTileGrid. (patchset #45 id:
1430002 of https://codereview.chromium.org/
634543004/)
Reason for revert:
Many GCC bots missing __builtin_shuffle, e.g. Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot.
Original issue's description:
> Start to vectorize SkTileGrid.
>
> This adds Sk4x.h to help.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
90c7992bfc6330f070f7704d63372a0ec8410170
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
663663002
mtklein [Thu, 16 Oct 2014 22:21:43 +0000 (15:21 -0700)]
Start to vectorize SkTileGrid.
This adds Sk4x.h to help.
BUG=skia:
Review URL: https://codereview.chromium.org/
634543004
robertphillips [Thu, 16 Oct 2014 21:28:28 +0000 (14:28 -0700)]
"Fix" debugger's setMatrix handling
This remedies two problems with the debugger's matrix handling:
1) the user matrix was not being passed to the setMatrix command (for a concat)
2) the setting of the user matrix was not consistently forcing a complete re-rendering of the scene
BUG=skia:3018
Review URL: https://codereview.chromium.org/
660883002
bsalomon [Thu, 16 Oct 2014 20:41:43 +0000 (13:41 -0700)]
Remove AutoScratchTexture
Remove AST from GrClipMaskCache
Remove AST from GrClipMaskManager
BUG=skia:2889
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
663583002
sugoi [Thu, 16 Oct 2014 20:10:57 +0000 (13:10 -0700)]
JPEG YUV Decoding
Enabling JPEG YUV Decoding in Skia
BUG=skia:3005, skia:1674, skia:3029
Committed: https://skia.googlesource.com/skia/+/
8e6c3b93a39e19111662a760ede97df55e51d39f
Review URL: https://codereview.chromium.org/
399683007
joshualitt [Thu, 16 Oct 2014 19:25:11 +0000 (12:25 -0700)]
Support GLSL es 3.00
BUG=skia:
Review URL: https://codereview.chromium.org/
659443007
piotaixr [Thu, 16 Oct 2014 18:58:39 +0000 (11:58 -0700)]
Override SkCanvas::drawImage() in SkRecorder.
BUG=skia:2947
Review URL: https://codereview.chromium.org/
610003002
piotaixr [Thu, 16 Oct 2014 18:55:35 +0000 (11:55 -0700)]
Override SkCanvas::drawImage() in SkDeferredCanvas and SkGPipe
BUG=skia:2947
Review URL: https://codereview.chromium.org/
613673005
fmalita [Thu, 16 Oct 2014 18:53:30 +0000 (11:53 -0700)]
Implicit SkTextBlob bounds
Compute blob bounds when the client doesn't pass explicit run rects to
the builder. This allows us to remove a couple of internal workarounds.
R=reed@google.com,mtklein@google.com,bungeman@google.com
Review URL: https://codereview.chromium.org/
654873003
Greg Humphreys [Thu, 16 Oct 2014 18:23:02 +0000 (14:23 -0400)]
fix display of fiddles that DON'T have compile errors
BUG=skia:
Review URL: https://codereview.chromium.org/
644253003
halcanary [Thu, 16 Oct 2014 17:32:52 +0000 (10:32 -0700)]
render_pdfs cull rect output formated better
Review URL: https://codereview.chromium.org/
657353004
halcanary [Thu, 16 Oct 2014 16:53:20 +0000 (09:53 -0700)]
Const-correctness in PDF drawText() call
If SkPDFDevice::drawText is called with glyph encoding and a font with
cubic outlines (CFF or Type1) and a glyph code > 255 then it was
mutating the in(const) glyph codes in place. Instead, a copy is made.
BUG=skia:3019
Review URL: https://codereview.chromium.org/
656143002
mtklein [Thu, 16 Oct 2014 16:23:21 +0000 (09:23 -0700)]
Tweak out SkTileGrid::insert() loop.
BUG=skia:
Review URL: https://codereview.chromium.org/
658913002
mtklein [Thu, 16 Oct 2014 16:23:17 +0000 (09:23 -0700)]
Pull nanomsg from our mirror instead of from github.
https://skia.googlesource.com/third_party/nanomsg/
BUG=skia:3027
Review URL: https://codereview.chromium.org/
657113004
humper [Thu, 16 Oct 2014 16:18:16 +0000 (09:18 -0700)]
Properly parse compiler errors for fiddles and mark them in the editor.
You can also click on the errors in the parsed output to jump directly to the offending location in the editor.
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/
660573003
bsalomon [Thu, 16 Oct 2014 16:18:09 +0000 (09:18 -0700)]
Auto-compare GrProcessors' texture accesses in isEqual().
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/
654313002
rmistry [Thu, 16 Oct 2014 15:37:31 +0000 (08:37 -0700)]
Whitespace change to verify lab machines can now sync
TBR=
BUG=skia:3031
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
664533002
jvanverth [Thu, 16 Oct 2014 15:04:39 +0000 (08:04 -0700)]
Revert of Change drawText() to generate positions and send to drawPosText() (patchset #4 id:60001 of https://codereview.chromium.org/
653133004/)
Reason for revert:
A large number of GMs on Ubuntu12 are failing. The text layout on GPU is visibly different than that for 8888.
Original issue's description:
> Change drawText() to generate positions and send to drawPosText()
>
> The idea here is to have a central place that does layout for drawText(), and
> then always feed text through drawPosText(). This both makes all of the
> GrTextContexts consistent in drawText() output, and does a better job of
> stressing drawPosText().
>
> Because of the effect of matrices on hinting and approximation error, the
> generated text is not 100% identical to that produced by the raster pipeline.
>
> BUG=skia:2778
>
> Committed: https://skia.googlesource.com/skia/+/
7851a56895c9c076f73a835a7dd51d3c6180c16f
TBR=cdalton.nvidia@gmail.com,bungeman@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2778
Review URL: https://codereview.chromium.org/
659993003
jvanverth [Thu, 16 Oct 2014 13:20:35 +0000 (06:20 -0700)]
Change drawText() to generate positions and send to drawPosText()
The idea here is to have a central place that does layout for drawText(), and
then always feed text through drawPosText(). This both makes all of the
GrTextContexts consistent in drawText() output, and does a better job of
stressing drawPosText().
Because of the effect of matrices on hinting and approximation error, the
generated text is not 100% identical to that produced by the raster pipeline.
BUG=skia:2778
Review URL: https://codereview.chromium.org/
653133004
tfarina [Thu, 16 Oct 2014 12:57:39 +0000 (05:57 -0700)]
webtry: Do not forget the close the rows.
This should prevent further enumeration according to the docs.
http://golang.org/pkg/database/sql/#Rows.Close
BUG=None
TEST=None
R=humper@google.com
Review URL: https://codereview.chromium.org/
638373003
sugoi [Thu, 16 Oct 2014 12:19:31 +0000 (05:19 -0700)]
Disabled YUV decoding for subsets
Image subsets were always showing the same tile and were causing an image to be fully YUV decoded once per tile, which was both slow and wrong.
BUG=413001, 419718
Review URL: https://codereview.chromium.org/
661483002
kkinnunen [Thu, 16 Oct 2014 06:03:54 +0000 (23:03 -0700)]
Refactor SkGLContext to be actually extendable
Refactor SkGLContext to be actually extendable. Before, non-trivial subclass
would need to destroy the GL connection upon running the destructor. However,
the base class would run GL commands in its own destructor (with destroyed GL
connection)
Refactor so that SkGLContext subclass object creation is completely done by
the factory function. If the factory function returns a non-NULL ptr, it means the context
is usable.
The destruction is done with the destructor instead of virtual function called
upon destruction. Make the destructors not to call virtual functions, for
clarity.
Remove custom 1x1 FBO setup code from the base class. It appears not to be used
anymore.
BUG=skia:2992
Review URL: https://codereview.chromium.org/
640283004
bsalomon [Thu, 16 Oct 2014 02:06:21 +0000 (19:06 -0700)]
Make GrFragmentProcessor auto-compare coord xforms.
Review URL: https://codereview.chromium.org/
657923002
bsalomon [Thu, 16 Oct 2014 02:04:14 +0000 (19:04 -0700)]
Prefer to recycle non-RT scratch textures that don't have pending IO
BUG=skia:2889
Review URL: https://codereview.chromium.org/
650283002
bsalomon [Thu, 16 Oct 2014 01:34:46 +0000 (18:34 -0700)]
Last round of effect->processor (for now)
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/
659803005
Thiago Farina [Wed, 15 Oct 2014 22:20:27 +0000 (19:20 -0300)]
webtry: Forgot onr log.Fatal.
Update it to use glog variant.
BUG=skia:2980
TEST=go build webtry.go
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/
659813003
tfarina [Wed, 15 Oct 2014 21:59:33 +0000 (14:59 -0700)]
webtry: Switch from Go's log package to golang/glog.
BUG=skia:2980
TEST=go get -d && go build webtry.go
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/
655323002
mtklein [Wed, 15 Oct 2014 21:20:00 +0000 (14:20 -0700)]
Treat (private, internal) grid bounds as doubly-inclusive in SkTileGrid.
The net effect is that two "+1" instructions are removed from insert().
search() nets no change: two +1 removed, two +1 added.
When vectorized, this removes the need to add in userToGrid() at all and
so the need to read an awkward {0, 0, 1, 1} constant from memory. Mostly
the benefit is less vector code to look at and think about.
BUG=skia:
Review URL: https://codereview.chromium.org/
659823004
bungeman [Wed, 15 Oct 2014 20:53:54 +0000 (13:53 -0700)]
Don't use 'defined' in macro expansion.
A careful reading of the preprocessor specification indicates that
any use of the 'defined' operator outside the form of 'defined X' or
'defined ( X )' directly in the constant expression of a '#if' or
'#elif' may cause undefined behavior.
In particular, msvc is very unpredictable. The 'defined X' and
'defined ( X )' forms behave differently when created from marco
expansion, with 'defined ( X )' generally evaluating to '0L'. The
'defined X' form generally behaves more the way one would expect,
but still has a number of quirks which should simply be considered
undefined behavior.
BUG=chromium:419245
Review URL: https://codereview.chromium.org/
657183002
egdaniel [Wed, 15 Oct 2014 20:49:02 +0000 (13:49 -0700)]
Move willUseInputColor check to computeInvariantOutput
BUG=skia:
Review URL: https://codereview.chromium.org/
656503002
tfarina [Wed, 15 Oct 2014 20:48:47 +0000 (13:48 -0700)]
webtry: Check the result of os.Chdir().
As mentioned in http://golang.org/doc/effective_go.html#blank_assign,
errors are provided for a reason, so always check them.
The documentation for this function is available at
http://golang.org/pkg/os/#Chdir.
BUG=None
TEST=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/
651343002
cdalton [Wed, 15 Oct 2014 20:43:48 +0000 (13:43 -0700)]
Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
all its commands interleaved in contiguous memory. GrTRecorder also
supports extra data associated with objects, so we can store arrays
inline without having to call malloc().
Committed: https://skia.googlesource.com/skia/+/
360b6801cfd90485891d709e44cf395d527ba69e
Review URL: https://codereview.chromium.org/
628453002
scroggo [Wed, 15 Oct 2014 20:43:36 +0000 (13:43 -0700)]
Remove unused NeedsDeepCopy.
It was used to check to see if an SkPaint had mutable fields on it.
Now that all the fields are immutable, this function is no longer
used. Remove it.
BUG=skia:2097
Review URL: https://codereview.chromium.org/
661543002
rmistry [Wed, 15 Oct 2014 20:15:58 +0000 (13:15 -0700)]
Revert of JPEG YUV Decoding (patchset #5 id:180001 of https://codereview.chromium.org/
399683007/)
Reason for revert:
Caused many test bots to go red:
http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Alex-GMA3150-x86-Release/builds/22/steps/dm/logs/stdio
http://build.chromium.org/p/client.skia/builders/Test-ChromeOS-Link-HD4000-x86_64-Debug/builds/168/steps/dm/logs/stdio
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX660-x86-Release/builds/38/steps/dm/logs/stdio
Original issue's description:
> JPEG YUV Decoding
>
> Enabling JPEG YUV Decoding in Skia
>
> BUG=skia:3005, skia:1674
>
> Committed: https://skia.googlesource.com/skia/+/
8e6c3b93a39e19111662a760ede97df55e51d39f
TBR=reed@google.com,scroggo@google.com,sugoi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:3005, skia:1674
Review URL: https://codereview.chromium.org/
656163002
rmistry [Wed, 15 Oct 2014 18:58:48 +0000 (11:58 -0700)]
Whitespace change to confirm Google Storage uploads are working
BUG=skia:
TBR=
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/
657083004
bsalomon [Wed, 15 Oct 2014 18:25:21 +0000 (11:25 -0700)]
More effect->processor cleanup
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/
660563003
bsalomon [Wed, 15 Oct 2014 18:05:26 +0000 (11:05 -0700)]
Some cleanup in processor header files.
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/
659803004
sugoi [Wed, 15 Oct 2014 18:04:17 +0000 (11:04 -0700)]
JPEG YUV Decoding
Enabling JPEG YUV Decoding in Skia
BUG=skia:3005, skia:1674
Review URL: https://codereview.chromium.org/
399683007
bsalomon [Wed, 15 Oct 2014 17:50:36 +0000 (10:50 -0700)]
Split GrFragmentProcessor into its own header
Review URL: https://codereview.chromium.org/
660573002
reed [Wed, 15 Oct 2014 16:00:27 +0000 (09:00 -0700)]
update dox for bounds in supersampler
BUG=skia:
TBR=caryclark@google.com
NOTRY=True
Review URL: https://codereview.chromium.org/
657793003
reed [Wed, 15 Oct 2014 15:52:00 +0000 (08:52 -0700)]
interesct path bounds with clip bounds before initializing supersampler
BUG=skia:
Review URL: https://codereview.chromium.org/
656473004
bsalomon [Wed, 15 Oct 2014 15:19:04 +0000 (08:19 -0700)]
Push isEqual/onIsEqual down from GrProcessor to subclasses.
R=joshualitt@google.com
Review URL: https://codereview.chromium.org/
654273002
reed [Wed, 15 Oct 2014 14:05:09 +0000 (07:05 -0700)]
add tests for large cordinates bounds when building aaclip
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
658753002
tfarina [Wed, 15 Oct 2014 03:14:03 +0000 (20:14 -0700)]
bug_chomper: Consolidate public flag in a single place.
BUG=None
TEST=./run_server.sh --help and ./run_server.sh -public
R=borenet@google.com
Review URL: https://codereview.chromium.org/
649303003
mtklein [Tue, 14 Oct 2014 21:29:30 +0000 (14:29 -0700)]
Revert of Create a single command buffer for GrInOrderDrawBuffer (patchset #17 id:
1240001 of https://codereview.chromium.org/
628453002/)
Reason for revert:
Leaking memory:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu12-ShuttleA-GTX550Ti-x86_64-Release-Valgrind/builds/9/steps/gm/logs/stdio
Original issue's description:
> Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
> all its commands interleaved in contiguous memory. GrTRecorder also
> supports extra data associated with objects, so we can store arrays
> inline without having to call malloc().
>
> Committed: https://skia.googlesource.com/skia/+/
360b6801cfd90485891d709e44cf395d527ba69e
TBR=bsalomon@google.com,reed@google.com,cdalton@nvidia.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
654863003
sugoi [Tue, 14 Oct 2014 20:15:58 +0000 (13:15 -0700)]
Changed "Profile" to "Cube" in ColorCube
A few references to "profile" still existed in SkColorCubeFilter, so I removed them.
BUG=skia:
Review URL: https://codereview.chromium.org/
651303002
Brian Salomon [Tue, 14 Oct 2014 20:12:23 +0000 (16:12 -0400)]
Ignore ubuntu nvprmsaa4/mixed_xfermodes GM result.
BUG=skia:2443
Review URL: https://codereview.chromium.org/
653153003
Brian Salomon [Tue, 14 Oct 2014 19:52:46 +0000 (15:52 -0400)]
Rebaseline mixedxfermodes on ubuntu/nvprmsaa4
TBR=
Review URL: https://codereview.chromium.org/
657603005
bsalomon [Tue, 14 Oct 2014 19:29:17 +0000 (12:29 -0700)]
Only use sized format on IMG/ES3 for single channel.
BUG=skia:2922
Review URL: https://codereview.chromium.org/
638293004
cdalton [Tue, 14 Oct 2014 18:53:04 +0000 (11:53 -0700)]
Adds a GrTRecorder class that GrInOrderDrawBuffer uses to allocate
all its commands interleaved in contiguous memory. GrTRecorder also
supports extra data associated with objects, so we can store arrays
inline without having to call malloc().
Review URL: https://codereview.chromium.org/
628453002
bsalomon [Tue, 14 Oct 2014 18:47:22 +0000 (11:47 -0700)]
Remove uses of GrAutoScratchTexture.
Rename GrContext::lockAndRefScratchTexture to refScratchTexture.
GrSurface::writePixels returns bool instead of void.
BUG=skia:2889
Review URL: https://codereview.chromium.org/
638403003
bsalomon [Tue, 14 Oct 2014 17:52:00 +0000 (10:52 -0700)]
Flush text contexts before drawing text as path
BUG=416289
Review URL: https://codereview.chromium.org/
636233008
tfarina [Tue, 14 Oct 2014 16:39:02 +0000 (09:39 -0700)]
webtry: Simplify template construction.
text/template and html/template both have a helper function called
"Must" that according to the docs in http://golang.org/pkg/text/template/#Must
and http://golang.org/pkg/html/template/#Must, wraps a call to a function
returning (*Template, error) and panics if the error is non-nil.
So we don't need to that ourselves. Which is a good thing and makes code
cleaner.
BUG=None
TEST=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/
642243004
reed [Tue, 14 Oct 2014 16:34:52 +0000 (09:34 -0700)]
create and modify matrices in lua
BUG=skia:
Review URL: https://codereview.chromium.org/
651823004
jvanverth [Tue, 14 Oct 2014 15:45:50 +0000 (08:45 -0700)]
Change GrTextContext fallbacks to be a linked list chain.
Preliminary work for getting color emoji working with
distance field text.
BUG=skia:2887
Review URL: https://codereview.chromium.org/
650273003
bsalomon [Tue, 14 Oct 2014 15:40:57 +0000 (08:40 -0700)]
Use GL_R8 rather than GL_RED for glTexImage2D on IMG/ES3. Check for failure of FP creation in SkImageFilter
BUG=skia:2922
Review URL: https://codereview.chromium.org/
656853002
mtklein [Tue, 14 Oct 2014 15:40:43 +0000 (08:40 -0700)]
nanobench: flush after recording every Nth data point.
Got to keep our precious data in event of a crash.
With --flushEvery 10 I'm not seeing this cost any wall time.
BUG=skia:
Review URL: https://codereview.chromium.org/
653083003
reed [Tue, 14 Oct 2014 15:26:33 +0000 (08:26 -0700)]
add gamma value to deviceproperties
BUG=skia:
Review URL: https://codereview.chromium.org/
652273002