Denis Kenzior [Sat, 24 Nov 2012 13:50:44 +0000 (07:50 -0600)]
ifx: Rework SIM state handling
When performing a SIM REFRESH, particularly NAA Initialization, we need
to wait until the modem sends XSIMSTATE: 7, not XSIMSTATE:2. Even on
normal initialization it seems safer to wait until XSIMSTATE:2.
Denis Kenzior [Sat, 24 Nov 2012 13:49:54 +0000 (07:49 -0600)]
atmodem: For IFX XSIMSTATE 7 should never occur
in the case of a PIN entry, XSIMSTATE of 7 (Ready to Attach) should
never occur
Denis Kenzior [Sat, 24 Nov 2012 13:49:30 +0000 (07:49 -0600)]
stk: Handle self explanatory icons in idle mode text
Denis Kenzior [Sat, 24 Nov 2012 13:49:02 +0000 (07:49 -0600)]
test: Use pretty-printing from monitor-ofono
Denis Kenzior [Sat, 24 Nov 2012 07:13:36 +0000 (01:13 -0600)]
stk: Handle icon self explanatory in play tone
Denis Kenzior [Sat, 24 Nov 2012 07:13:22 +0000 (01:13 -0600)]
stk: Handle icon self explanatory in get input
Denis Kenzior [Sat, 24 Nov 2012 07:13:09 +0000 (01:13 -0600)]
stk: Handle icon self explanatory in get inkey
Denis Kenzior [Sat, 24 Nov 2012 07:12:55 +0000 (01:12 -0600)]
stk: Handle icon self explanatory in display text
Denis Kenzior [Sat, 24 Nov 2012 07:12:31 +0000 (01:12 -0600)]
stk: Handle icon self explanatory in menus
Denis Kenzior [Sat, 24 Nov 2012 07:11:44 +0000 (01:11 -0600)]
sim: Fix crash
When modem is brought online, then sim removed and re-inserted. We
crash when going online again due to the spn related data-structures not
being initialized properly
Marcel Holtmann [Wed, 28 Nov 2012 09:34:43 +0000 (10:34 +0100)]
tools: Wait an extra second before opening the TTY
Marcel Holtmann [Wed, 28 Nov 2012 09:21:51 +0000 (10:21 +0100)]
tools: Add simple TTY redirector utility
Marcel Holtmann [Tue, 27 Nov 2012 22:31:52 +0000 (23:31 +0100)]
qmimodem: Fix reporting of PIN or PUK states
Marcel Holtmann [Tue, 27 Nov 2012 10:09:52 +0000 (11:09 +0100)]
test: Allow LoopTone to be interrupted by incoming calls
Marcel Holtmann [Tue, 27 Nov 2012 10:09:21 +0000 (11:09 +0100)]
test: Remove unneeded semicolons in STK test script
Szymon Janc [Wed, 21 Nov 2012 10:21:03 +0000 (11:21 +0100)]
gdbus: Remove not needed NULL pointer checks
g_strdup returns NULL if argument passed is NULL and there is no need
to double check that.
Syam Sidhardhan [Tue, 23 Oct 2012 13:57:06 +0000 (19:27 +0530)]
gdbus: Replace leading spaces with tabs
Trivial formatting fix.
Syam Sidhardhan [Wed, 14 Nov 2012 13:07:10 +0000 (18:37 +0530)]
gdbus: Fix compilation error due to missing #defines
Since these are simple #define strings, we are defining it here
instead of upgrading to D-Bus 1.5 or later.
Log:
CC gdbus/object.o
gdbus/object.c: In function ‘properties_set’:
gdbus/object.c:876:7: error: ‘DBUS_ERROR_UNKNOWN_PROPERTY’ undeclared
(first use in this function)
gdbus/object.c:876:7: note: each undeclared identifier is reported
only once for each function it appears in
gdbus/object.c:881:6: error: ‘DBUS_ERROR_PROPERTY_READ_ONLY’
undeclared (first use in this function)
make[1]: *** [gdbus/object.o] Error 1
make: *** [all] Error 2
Lucas De Marchi [Wed, 17 Oct 2012 15:14:28 +0000 (12:14 -0300)]
gdbus: Remove connection from pending_property functions
The reply to a DBus.Properties.Set() method call should go through the
same D-Bus connection. Thus remove the DBusConnection parameter from the
following functions:
- g_dbus_pending_property_success()
- g_dbus_pending_property_error_valist()
- g_dbus_pending_property_error()
Johan Hedberg [Mon, 15 Oct 2012 10:21:11 +0000 (13:21 +0300)]
gdbus: Fix invalid memory access during interface removal
If an interface is removed from the root path during the same mainloop
iteration that it was added we need to check for data->added before
doing the check for data->parent == NULL in the remove_interface()
function. Otherwise the added interface doesn't get removed from the
data->added list and will result in accessing freed memory:
==337== Invalid read of size 8
==337== at 0x4F65AFA: dbus_message_iter_append_basic (in /usr/lib64/libdbus-1.so.3.7.1)
==337== by 0x1247B5: append_interface (object.c:556)
==337== by 0x4C8DC5C: g_slist_foreach (gslist.c:840)
==337== by 0x1261F7: process_changes (object.c:594)
==337== by 0x126372: generic_unregister (object.c:997)
==337== by 0x4F69669: ??? (in /usr/lib64/libdbus-1.so.3.7.1)
==337== by 0x4F5CE51: dbus_connection_unregister_object_path (in /usr/lib64/libdbus-1.so.3.7.1)
==337== by 0x125E81: object_path_unref (object.c:1236)
==337== by 0x126136: g_dbus_unregister_interface (object.c:1361)
==337== by 0x14CDF0: service_exit (service.c:581)
==337== by 0x177556: plugin_cleanup (plugin.c:242)
==337== by 0x12221F: main (main.c:559)
==337== Address 0x5bc1550 is 0 bytes inside a block of size 56 free'd
==337== at 0x4A079AE: free (vg_replace_malloc.c:427)
==337== by 0x4C7850E: g_free (gmem.c:252)
==337== by 0x125DB0: remove_interface (object.c:671)
==337== by 0x125E3B: object_path_unref (object.c:1230)
==337== by 0x126136: g_dbus_unregister_interface (object.c:1361)
==337== by 0x14CDF0: service_exit (service.c:581)
==337== by 0x177556: plugin_cleanup (plugin.c:242)
==337== by 0x12221F: main (main.c:559)
Johan Hedberg [Fri, 12 Oct 2012 08:55:37 +0000 (10:55 +0200)]
gdbus: Add g_dbus_get_properties function
This function can be used to construct custom D-Bus messages containing
the properties for a specific interface on a given path.
Johan Hedberg [Thu, 11 Oct 2012 09:53:27 +0000 (11:53 +0200)]
gdbus: Add support for invalidated properties
If there's a pending property but its exists() callback returns false
the property should be considered invalidated and included in the
relevant list of the PropertiesChanged signal.
Johan Hedberg [Mon, 8 Oct 2012 12:36:12 +0000 (14:36 +0200)]
gdbus: Fix processing pending properties in remove_interface()
Lucas De Marchi [Sat, 6 Oct 2012 07:02:35 +0000 (04:02 -0300)]
gdbus: Fix up Properties.Set() code path
Minor fixes to make setter actually work:
- Add propdata in pending_property_set
- Break loop when we are removing propdata from list and we
found it
- in_args and out_args were swapped
- interface and method name arguments were swapped
Lucas De Marchi [Thu, 4 Oct 2012 20:42:33 +0000 (17:42 -0300)]
gdbus: Fix invalid memory access while unregistering
If an interface is added and removed on the same mailoop iteration,
ObjectManager would try to send InterfacesAdded signal while running the
idler because the interface was added to data->added list.
This is easily reproduced by forcing an error path in a plugin
registration, like on sap_server_register(), resulting in the following
error:
==11795== Invalid read of size 4
==11795== at 0x496F592: dbus_message_iter_append_basic (dbus-message.c:2598)
==11795== by 0x117B39: append_interface (object.c:554)
==11795== by 0x48955E7: g_slist_foreach (gslist.c:840)
==11795== by 0x11923B: process_changes (object.c:592)
==11795== by 0x11956D: generic_unregister (object.c:980)
==11795== by 0x4973BAC: _dbus_object_tree_unregister_and_unlock (dbus-object-tree.c:516)
==11795== by 0x4965240: dbus_connection_unregister_object_path (dbus-connection.c:5776)
==11795== by 0x1178A5: object_path_unref (object.c:1219)
==11795== by 0x118517: g_dbus_unregister_interface (object.c:1344)
==11795== by 0x19AF5B: sap_exit (sap.c:385)
==11795== by 0x13E9E2: sap_server_register (server.c:1428)
==11795== by 0x13C092: sap_server_probe (manager.c:44)
With this patch we don't send the InterfacesAdded signal, removing it
from data->added while unregistering.
Lucas De Marchi [Thu, 4 Oct 2012 07:26:37 +0000 (04:26 -0300)]
gdbus: Implement PropertiesChanged signal
Luiz Augusto von Dentz [Thu, 4 Oct 2012 07:26:36 +0000 (04:26 -0300)]
gdbus: Simplify code for appending properties
This reuse append_properties for GetAll and GetManagedObjects
Luiz Augusto von Dentz [Thu, 4 Oct 2012 07:26:35 +0000 (04:26 -0300)]
gdbus: Integrates ObjectManager with Properties interface
This appends the properties and its values when using ObjectManager.
Luiz Augusto von Dentz [Thu, 4 Oct 2012 07:26:34 +0000 (04:26 -0300)]
gdbus: Only export ObjectManager interface on root path
ObjectManager should be exported only in the root path and list all
the children paths.
Luiz Augusto von Dentz [Thu, 4 Oct 2012 07:26:33 +0000 (04:26 -0300)]
gdbus: Group interface changes to reduce the amount of signals emitted
InterfacesAdded and InterfacesRemoved can group all the interfaces
changes together in one message.
Luiz Augusto von Dentz [Thu, 4 Oct 2012 07:26:32 +0000 (04:26 -0300)]
gdbus: Add support for org.freedesktop.DBus.ObjectManager interface
This implements initial support for ObjectManager, it automatically adds
objects to its parents so no action is needed by daemons to get their
objects managed by this interface.
ObjectManager is part of D-Bus spec since revision 0.17:
http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-objectmanager
Lucas De Marchi [Thu, 4 Oct 2012 07:26:31 +0000 (04:26 -0300)]
gdbus: Add properties into Introspectable interface
Lucas De Marchi [Thu, 4 Oct 2012 07:26:30 +0000 (04:26 -0300)]
gdbus: Implement DBus.Properties.Set method
Contrary to Get() and GetAll(), Set() is asynchronous so we pass an id
to the setter so later it can declare the Set() as successful or
otherwise.
Lucas De Marchi [Thu, 4 Oct 2012 07:26:29 +0000 (04:26 -0300)]
gdbus: Implement DBus.Properties.GetAll method
Lucas De Marchi [Thu, 4 Oct 2012 07:26:28 +0000 (04:26 -0300)]
gdbus: Implement DBus.Properties.Get method
Lucas De Marchi [Thu, 4 Oct 2012 07:26:27 +0000 (04:26 -0300)]
gdbus: Add skeleton of DBus.Properties interface
This interface is responsible for handling properties of all objects in
a given path. Right now it only registers itself, doing nothing useful.
A conversion to this new layout will be done by subsequent patches.
org.freedesktop.org.DBus.Properties spec can be found at
http://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces-properties
Lucas De Marchi [Thu, 4 Oct 2012 07:26:26 +0000 (04:26 -0300)]
gdbus: Use macros to add annotations
Besides being more readable this way it avoids going over 80 chars.
Lucas De Marchi [Thu, 4 Oct 2012 07:26:25 +0000 (04:26 -0300)]
gdbus: Move typedefs up
Move the typedefs up so they can be used by functions and callbacks.
Marcel Holtmann [Sun, 25 Nov 2012 20:18:03 +0000 (21:18 +0100)]
unit: Fix SMS unit tests
Denis Kenzior [Fri, 23 Nov 2012 13:21:46 +0000 (07:21 -0600)]
atmodem: Always quote data in CRSM write operations
Denis Kenzior [Fri, 23 Nov 2012 13:09:29 +0000 (07:09 -0600)]
atmodem: Support CRSM with paths
For GET STATUS and READ BINARY variations, support appending of the
optional path in the CRSM command
Denis Kenzior [Fri, 23 Nov 2012 12:41:27 +0000 (06:41 -0600)]
sim: Read icons with a full SIM/USIM path
Denis Kenzior [Fri, 23 Nov 2012 12:40:55 +0000 (06:40 -0600)]
simfs: Handle optional EF paths
Denis Kenzior [Fri, 23 Nov 2012 12:39:59 +0000 (06:39 -0600)]
include: Tweak ofono_sim_read_bytes API
Reading of icons requires us to specify the path
Marcel Holtmann [Sun, 25 Nov 2012 19:02:59 +0000 (20:02 +0100)]
qmimodem: Add support for UIM service handling
Marcel Holtmann [Sun, 25 Nov 2012 19:00:38 +0000 (20:00 +0100)]
udev: Let Huawei detection also check for cdc_wdm drivers
Marcel Holtmann [Sun, 25 Nov 2012 19:00:07 +0000 (20:00 +0100)]
udev: Use Qualcomm Gobi driver if QMI based modem
Marcel Holtmann [Sun, 25 Nov 2012 18:57:43 +0000 (19:57 +0100)]
udev: Handle USB descriptors from Vodafone K5005 modem
Marcel Holtmann [Sun, 25 Nov 2012 18:56:42 +0000 (19:56 +0100)]
gobi: Use UIM service is available
Marcel Holtmann [Sun, 25 Nov 2012 14:34:41 +0000 (15:34 +0100)]
sim: Assume CPHS files are in ADFusim
Marcel Holtmann [Sun, 25 Nov 2012 14:02:23 +0000 (15:02 +0100)]
test: Fix modem path handling for icon testing
Marcel Holtmann [Sun, 25 Nov 2012 09:20:15 +0000 (10:20 +0100)]
test: Allow STK testing without voice call manager
Marcel Holtmann [Sun, 25 Nov 2012 09:19:40 +0000 (10:19 +0100)]
qmimodem: Print error string instead of code if available
Marcel Holtmann [Sat, 24 Nov 2012 23:05:54 +0000 (00:05 +0100)]
qmimodem: Pretty print service name in debug logs
Marcel Holtmann [Sat, 24 Nov 2012 23:05:15 +0000 (00:05 +0100)]
qmimodem: Fix debug printing of messages
Marcel Holtmann [Sat, 24 Nov 2012 23:04:14 +0000 (00:04 +0100)]
qmimodem: Add helper for error message strings
Denis Kenzior [Thu, 22 Nov 2012 15:42:28 +0000 (09:42 -0600)]
unit: Add 2G and 3G path lookup tests
Denis Kenzior [Thu, 22 Nov 2012 15:42:16 +0000 (09:42 -0600)]
unit: Fix Style
Denis Kenzior [Thu, 22 Nov 2012 15:41:29 +0000 (09:41 -0600)]
unit: Remove failing test
We removed the needed file id from the sim database. It was not being
used.
Denis Kenzior [Thu, 22 Nov 2012 15:41:08 +0000 (09:41 -0600)]
simutil: Add 2G and 3G path lookup utilities
Denis Kenzior [Thu, 22 Nov 2012 15:40:52 +0000 (09:40 -0600)]
simfs: Update to the new SIM api
Denis Kenzior [Thu, 22 Nov 2012 15:40:39 +0000 (09:40 -0600)]
sim: Update to the new sim reading API
Denis Kenzior [Thu, 22 Nov 2012 15:40:18 +0000 (09:40 -0600)]
atmodem: Update sim driver to the new api
Denis Kenzior [Thu, 22 Nov 2012 15:40:05 +0000 (09:40 -0600)]
qmi: Update sim-legacy driver to the new API
Denis Kenzior [Thu, 22 Nov 2012 15:39:52 +0000 (09:39 -0600)]
isi: Update UICC driver to the new API
Denis Kenzior [Thu, 22 Nov 2012 15:39:37 +0000 (09:39 -0600)]
isimodem: Update sim driver to the new API
Denis Kenzior [Thu, 22 Nov 2012 15:38:34 +0000 (09:38 -0600)]
include: Add path and path_len arguments
The CRSM command has an additional parameter called pathlen which can be
used to specify the path of the elementary file outside the well-known
path range.
Denis Kenzior [Thu, 22 Nov 2012 14:24:03 +0000 (08:24 -0600)]
simutil: Introduce 2G and 3G parent paths
Marcel Holtmann [Sat, 24 Nov 2012 18:14:27 +0000 (19:14 +0100)]
test: Allow DisplayText to be interrupted by incoming calls
Denis Kenzior [Thu, 22 Nov 2012 12:56:33 +0000 (06:56 -0600)]
voicecall: Handle RESETTING sim state
Denis Kenzior [Thu, 22 Nov 2012 12:56:23 +0000 (06:56 -0600)]
modem: Handle RESETTING sim state
Denis Kenzior [Thu, 22 Nov 2012 12:50:32 +0000 (06:50 -0600)]
test: Fix ascii conversion exception
Denis Kenzior [Thu, 22 Nov 2012 12:47:50 +0000 (06:47 -0600)]
simutil: Add file type information to sim_db
Denis Kenzior [Thu, 22 Nov 2012 12:33:22 +0000 (06:33 -0600)]
simutil: Rename structure variable
Denis Kenzior [Thu, 22 Nov 2012 12:44:34 +0000 (06:44 -0600)]
ifx: Move connman atom to post_sim state
Denis Kenzior [Thu, 22 Nov 2012 12:42:04 +0000 (06:42 -0600)]
ifx: Get rid of have_sim tracking
Denis Kenzior [Thu, 22 Nov 2012 12:45:10 +0000 (06:45 -0600)]
sim: Fix SIM re-init case of SIM Refresh
When the SIM is being refreshed, we try to access the SIM too fast after
the SIM REFRESH proactive command is received. Instead set the sim atom
into the 'RESETTING' state and wait until the modem driver signals the
sim insertion again.
Denis Kenzior [Thu, 22 Nov 2012 12:48:11 +0000 (06:48 -0600)]
include: Add RESETTING state
Denis Kenzior [Thu, 22 Nov 2012 12:47:23 +0000 (06:47 -0600)]
stk: Fix crash in SIM refresh handling
Denis Kenzior [Wed, 21 Nov 2012 13:26:28 +0000 (07:26 -0600)]
stk: Always include IdleModeText in GetProperties
Denis Kenzior [Wed, 21 Nov 2012 13:11:46 +0000 (07:11 -0600)]
sim: destroy spn info as part of sim main state
Denis Kenzior [Tue, 20 Nov 2012 14:55:28 +0000 (08:55 -0600)]
stk: Use the shorter timeout for select item
Denis Kenzior [Mon, 19 Nov 2012 16:43:10 +0000 (10:43 -0600)]
stk: use longer timeout for ImmediateResponse
Denis Kenzior [Thu, 22 Nov 2012 12:46:57 +0000 (06:46 -0600)]
stk: Use short timeout for get_inkey
Denis Kenzior [Mon, 19 Nov 2012 16:42:24 +0000 (10:42 -0600)]
stk: Use a shorter timeout for DisplayText
For any commands that are tagged as wait-for-user to clear, we should
use the shorter timeout. The test system expects 25 to 35 seconds.
Marcel Holtmann [Fri, 23 Nov 2012 15:41:23 +0000 (16:41 +0100)]
ifx: Add comments about unhandled SIM states
Marcel Holtmann [Fri, 23 Nov 2012 15:20:15 +0000 (16:20 +0100)]
atmodem: Monitor IFX technology and band changes
Marcel Holtmann [Fri, 23 Nov 2012 15:18:52 +0000 (16:18 +0100)]
test: Handle DisplayText with async_callbacks option
Cedric Jehasse [Thu, 15 Nov 2012 08:35:51 +0000 (09:35 +0100)]
atmodem: add PIN retry count for Alcatel modems
Cedric Jehasse [Wed, 14 Nov 2012 11:08:40 +0000 (12:08 +0100)]
alcatel: create sim atom with vendor alcatel
Denis Kenzior [Mon, 12 Nov 2012 19:31:21 +0000 (13:31 -0600)]
AUTHORS: Mention Cedric's contributions
Cedric Jehasse [Fri, 9 Nov 2012 13:16:53 +0000 (14:16 +0100)]
atmodem: Poll SIM state after entering PIN
Encountered a problem of CME ERROR 14: SIM busy on Alcatel and Huawei modem.
The Huawei modem has a ^SIMST unsollicited sim state indication, but not all
Huawei modems support this.
So poll the SIM state, as was already done for ZTE modems.
Cedric Jehasse [Fri, 9 Nov 2012 13:16:53 +0000 (14:16 +0100)]
atmodem: Add ALCATEL vendor
Denis Kenzior [Wed, 7 Nov 2012 13:59:57 +0000 (07:59 -0600)]
mbm: Fix SIM not inserted detection
Denis Kenzior [Fri, 2 Nov 2012 19:17:31 +0000 (14:17 -0500)]
stktest: Add Poll Interval test sequence 1.1
Denis Kenzior [Fri, 2 Nov 2012 19:17:17 +0000 (14:17 -0500)]
unit: Move Poll Interval test data 1.1
Denis Kenzior [Fri, 2 Nov 2012 19:04:49 +0000 (14:04 -0500)]
stktest: Label stktest modem as type TEST
Denis Kenzior [Fri, 2 Nov 2012 19:03:16 +0000 (14:03 -0500)]
modem: Add support for modem type TEST
Denis Kenzior [Fri, 2 Nov 2012 19:03:03 +0000 (14:03 -0500)]
doc: Update modem API to reflect modem type test
Denis Kenzior [Fri, 2 Nov 2012 19:02:26 +0000 (14:02 -0500)]
include: Add TEST modem type