platform/upstream/libSkiaSharp.git
12 years agoPseudo-reverted r4396 (SkGrPixelRef files are still in source pool but are unused)
robertphillips@google.com [Fri, 29 Jun 2012 00:30:13 +0000 (00:30 +0000)]
Pseudo-reverted r4396 (SkGrPixelRef files are still in source pool but are unused)

git-svn-id: http://skia.googlecode.com/svn/trunk@4402 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTemporarily readding SkGrTexturePixelRef.h/.cpp until WebKit is transitioned to SkGrP...
robertphillips@google.com [Thu, 28 Jun 2012 21:59:38 +0000 (21:59 +0000)]
Temporarily readding SkGrTexturePixelRef.h/.cpp until WebKit is transitioned to SkGrPixelRef

git-svn-id: http://skia.googlecode.com/svn/trunk@4401 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years ago[PDF] Fix PDF code to not crash on SkComposeShader.
vandebo@chromium.org [Thu, 28 Jun 2012 21:37:20 +0000 (21:37 +0000)]
[PDF] Fix PDF code to not crash on SkComposeShader.

Review URL: https://codereview.appspot.com/6354053

git-svn-id: http://skia.googlecode.com/svn/trunk@4400 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed memory deletion error in instance counting mechanism
robertphillips@google.com [Thu, 28 Jun 2012 21:30:45 +0000 (21:30 +0000)]
Fixed memory deletion error in instance counting mechanism

http://codereview.appspot.com/6344057/

git-svn-id: http://skia.googlecode.com/svn/trunk@4399 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMoved SkGrTexturePixelRef to SkGrPixelRef
robertphillips@google.com [Thu, 28 Jun 2012 20:59:13 +0000 (20:59 +0000)]
Moved SkGrTexturePixelRef to SkGrPixelRef

http://codereview.appspot.com/6344054/

git-svn-id: http://skia.googlecode.com/svn/trunk@4397 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoCollapsed SkGrTexturePixelRef and SkGrRenderTargetPixelRef into SkGrPixelRef using...
robertphillips@google.com [Thu, 28 Jun 2012 20:02:39 +0000 (20:02 +0000)]
Collapsed SkGrTexturePixelRef and SkGrRenderTargetPixelRef into SkGrPixelRef using new GrSurface class

http://codereview.appspot.com/6359045/

git-svn-id: http://skia.googlecode.com/svn/trunk@4396 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDisable pipe for bitmapfilters gm on Android.
scroggo@google.com [Thu, 28 Jun 2012 19:55:06 +0000 (19:55 +0000)]
Disable pipe for bitmapfilters gm on Android.

Until I can investigate why the test is broken.

Review URL: https://codereview.appspot.com/6357045

git-svn-id: http://skia.googlecode.com/svn/trunk@4395 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRebaseline MSAA16 AA clip images. We now enable MSAA when stencil clipping if the...
bsalomon@google.com [Thu, 28 Jun 2012 19:50:27 +0000 (19:50 +0000)]
Rebaseline MSAA16 AA clip images. We now enable MSAA when stencil clipping if the clip element is AA.

git-svn-id: http://skia.googlecode.com/svn/trunk@4393 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoChange CT assert to RT assert
bsalomon@google.com [Thu, 28 Jun 2012 18:56:22 +0000 (18:56 +0000)]
Change CT assert to RT assert

git-svn-id: http://skia.googlecode.com/svn/trunk@4391 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoInitial support for GL_NV_path_renering. Experimental, there are still some issues...
bsalomon@google.com [Thu, 28 Jun 2012 18:48:06 +0000 (18:48 +0000)]
Initial support for GL_NV_path_renering. Experimental, there are still some issues to resolve, set gyp variable skia_nv_path_rendering=1 or build flag GR_GL_USE_NV_PATH_RENDERING to enable.

http://codereview.appspot.com/6349049/

git-svn-id: http://skia.googlecode.com/svn/trunk@4390 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoImprove sorting of skdiff output, and make it consistent across platforms
epoger@google.com [Thu, 28 Jun 2012 16:47:34 +0000 (16:47 +0000)]
Improve sorting of skdiff output, and make it consistent across platforms
BUG=https://code.google.com/p/skia/issues/detail?id=677
Review URL: https://codereview.appspot.com/6351045

git-svn-id: http://skia.googlecode.com/svn/trunk@4388 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agofix the build
djsollen@google.com [Thu, 28 Jun 2012 16:19:03 +0000 (16:19 +0000)]
fix the build

git-svn-id: http://skia.googlecode.com/svn/trunk@4387 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTurn off the blurs GM for Pipe playback.
scroggo@google.com [Thu, 28 Jun 2012 16:09:39 +0000 (16:09 +0000)]
Turn off the blurs GM for Pipe playback.

It was failing on FIXED. Turn it off while we fix the real problem.

Review URL: https://codereview.appspot.com/6349051

git-svn-id: http://skia.googlecode.com/svn/trunk@4386 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSeparate target architecture type and width into separate variables.
djsollen@google.com [Thu, 28 Jun 2012 16:08:05 +0000 (16:08 +0000)]
Separate target architecture type and width into separate variables.

Also add support for building mac in 64 bit mode.
Review URL: https://codereview.appspot.com/6343050

git-svn-id: http://skia.googlecode.com/svn/trunk@4385 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix SkGPipe drawing, and turn it on by default.
scroggo@google.com [Thu, 28 Jun 2012 15:41:32 +0000 (15:41 +0000)]
Fix SkGPipe drawing, and turn it on by default.

A recent change broke SkGPipe. Fix it, and turn on pipe drawing
in GM by default so we will catch these in the future.

We already had a bug where SkGPipeWriter had to use its Cross Process
flag to work, so for a quick fix, force the reader to use the Cross
Process flag as well. The bug to allow both cross and non cross process
is http://code.google.com/p/skia/issues/detail?id=663

Review URL: https://codereview.appspot.com/6333071

git-svn-id: http://skia.googlecode.com/svn/trunk@4384 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd SkData::NewFromCString()
reed@google.com [Thu, 28 Jun 2012 15:40:09 +0000 (15:40 +0000)]
add SkData::NewFromCString()

git-svn-id: http://skia.googlecode.com/svn/trunk@4383 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agofixed another clang++ compiler error
robertphillips@google.com [Thu, 28 Jun 2012 01:01:53 +0000 (01:01 +0000)]
fixed another clang++ compiler error

git-svn-id: http://skia.googlecode.com/svn/trunk@4382 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded EOF marker to address clang++ error
robertphillips@google.com [Thu, 28 Jun 2012 00:29:23 +0000 (00:29 +0000)]
Added EOF marker to address clang++ error

git-svn-id: http://skia.googlecode.com/svn/trunk@4381 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSplit GrSWMaskHelper into its own files
robertphillips@google.com [Wed, 27 Jun 2012 20:44:52 +0000 (20:44 +0000)]
Split GrSWMaskHelper into its own files

http://codereview.appspot.com/6350046/

git-svn-id: http://skia.googlecode.com/svn/trunk@4380 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agofixed missing "return" error
robertphillips@google.com [Wed, 27 Jun 2012 20:13:49 +0000 (20:13 +0000)]
fixed missing "return" error

git-svn-id: http://skia.googlecode.com/svn/trunk@4379 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdding checksum to SkFlatData to accelerate SkPicture recording.
junov@chromium.org [Wed, 27 Jun 2012 20:03:16 +0000 (20:03 +0000)]
Adding checksum to SkFlatData to accelerate SkPicture recording.
The checksum triggers an early exit in the mem compare use to search for duplicate flattened objects. Also, call to memcmp was replaced with 64-bit at a time comparison loop.

Review URL: http://codereview.appspot.com/6339046/
BUG=http://code.google.com/p/chromium/issues/detail?id=54079
TEST=Checksum and PictureRecord tests in bench.exe

git-svn-id: http://skia.googlecode.com/svn/trunk@4378 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAltered SkInstCnt to print out atexit
robertphillips@google.com [Wed, 27 Jun 2012 19:52:20 +0000 (19:52 +0000)]
Altered SkInstCnt to print out atexit

http://codereview.appspot.com/6348043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4377 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSeparated Inst counting from the SK_DEBUG #define (now SK_ENABLE_INST_COUNT)
robertphillips@google.com [Wed, 27 Jun 2012 19:41:42 +0000 (19:41 +0000)]
Separated Inst counting from the SK_DEBUG #define (now SK_ENABLE_INST_COUNT)

http://codereview.appspot.com/6353047/

git-svn-id: http://skia.googlecode.com/svn/trunk@4376 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoland https://codereview.appspot.com/6349043/
reed@google.com [Wed, 27 Jun 2012 19:33:29 +0000 (19:33 +0000)]
land https://codereview.appspot.com/6349043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4375 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded ReadPixels format-supported check to GL Caps
robertphillips@google.com [Wed, 27 Jun 2012 19:31:41 +0000 (19:31 +0000)]
Added ReadPixels format-supported check to GL Caps

http://codereview.appspot.com/6336055/

git-svn-id: http://skia.googlecode.com/svn/trunk@4374 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agowhitespace change to trigger Skia buildbots after updating Android build
epoger@google.com [Wed, 27 Jun 2012 19:08:37 +0000 (19:08 +0000)]
whitespace change to trigger Skia buildbots after updating Android build

git-svn-id: http://skia.googlecode.com/svn/trunk@4373 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agowhitespace change to trigger Skia buildbots after updating Android build
epoger@google.com [Wed, 27 Jun 2012 19:06:59 +0000 (19:06 +0000)]
whitespace change to trigger Skia buildbots after updating Android build

git-svn-id: http://skia.googlecode.com/svn/trunk@4372 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoWhen building for Android, package executables in APKs (trunk)
borenet@google.com [Wed, 27 Jun 2012 19:04:39 +0000 (19:04 +0000)]
When building for Android, package executables in APKs (trunk)
Review URL: https://codereview.appspot.com/6307101

git-svn-id: http://skia.googlecode.com/svn/trunk@4368 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd explicit purgeAll() so we don't get foiled by the min cache-limit
reed@google.com [Wed, 27 Jun 2012 18:23:01 +0000 (18:23 +0000)]
add explicit purgeAll() so we don't get foiled by the min cache-limit
call unref instead of delete on the GrFontScaler
Review URL: https://codereview.appspot.com/6353045

git-svn-id: http://skia.googlecode.com/svn/trunk@4366 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoEnable Scratch texture detach in SW path renderer's onDrawPath (again)
robertphillips@google.com [Wed, 27 Jun 2012 18:02:57 +0000 (18:02 +0000)]
Enable Scratch texture detach in SW path renderer's onDrawPath (again)

http://codereview.appspot.com/6331057/

git-svn-id: http://skia.googlecode.com/svn/trunk@4365 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoBump max flattenable from 64 to 1024.
bungeman@google.com [Wed, 27 Jun 2012 15:57:34 +0000 (15:57 +0000)]
Bump max flattenable from 64 to 1024.
Ran into limit on Mac.

git-svn-id: http://skia.googlecode.com/svn/trunk@4364 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoremove duplicate definition of SkAlign8()
reed@google.com [Wed, 27 Jun 2012 15:41:54 +0000 (15:41 +0000)]
remove duplicate definition of SkAlign8()

git-svn-id: http://skia.googlecode.com/svn/trunk@4363 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd SkAlign8 and SkIsAlign8 macros
reed@google.com [Wed, 27 Jun 2012 15:07:11 +0000 (15:07 +0000)]
add SkAlign8 and SkIsAlign8 macros

git-svn-id: http://skia.googlecode.com/svn/trunk@4362 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed Resource counting bug in AutoScratchTexture detach mechanism
robertphillips@google.com [Wed, 27 Jun 2012 14:59:18 +0000 (14:59 +0000)]
Fixed Resource counting bug in AutoScratchTexture detach mechanism

http://codereview.appspot.com/6356043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4361 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agofix leak of Light object (in this private instance, the caller is transferring
reed@google.com [Wed, 27 Jun 2012 14:24:29 +0000 (14:24 +0000)]
fix leak of Light object (in this private instance, the caller is transferring
ownership of the object, so the receive does not need to call ref).
Review URL: https://codereview.appspot.com/6348045

git-svn-id: http://skia.googlecode.com/svn/trunk@4360 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdded Inst counting to SkFlattenable-derived classes
robertphillips@google.com [Wed, 27 Jun 2012 14:03:26 +0000 (14:03 +0000)]
Added Inst counting to SkFlattenable-derived classes

http://codereview.appspot.com/6355043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4359 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agodon't leak filters
reed@google.com [Wed, 27 Jun 2012 14:00:06 +0000 (14:00 +0000)]
don't leak filters

git-svn-id: http://skia.googlecode.com/svn/trunk@4358 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agowrite my own os.path.abspath() to work around Win path-length limits
epoger@google.com [Wed, 27 Jun 2012 13:38:37 +0000 (13:38 +0000)]
write my own os.path.abspath() to work around Win path-length limits
BUG=https://code.google.com/p/skia/issues/detail?id=674
Review URL: https://codereview.appspot.com/6342052

git-svn-id: http://skia.googlecode.com/svn/trunk@4357 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMake GrInOrderDrawBuffer playback command driven
bsalomon@google.com [Tue, 26 Jun 2012 21:04:22 +0000 (21:04 +0000)]
Make GrInOrderDrawBuffer playback command driven

Review URL: http://codereview.appspot.com/6341052/

git-svn-id: http://skia.googlecode.com/svn/trunk@4356 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed alignment issue in Linux build
robertphillips@google.com [Tue, 26 Jun 2012 21:01:05 +0000 (21:01 +0000)]
Fixed alignment issue in Linux build

git-svn-id: http://skia.googlecode.com/svn/trunk@4355 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRemoved cached copy of the GrDebugGLInterface
robertphillips@google.com [Tue, 26 Jun 2012 20:19:41 +0000 (20:19 +0000)]
Removed cached copy of the GrDebugGLInterface

http://codereview.appspot.com/6329068/

git-svn-id: http://skia.googlecode.com/svn/trunk@4354 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoplumb SkInstCnt to all subclasses of GrRefCnt
reed@google.com [Tue, 26 Jun 2012 20:16:17 +0000 (20:16 +0000)]
plumb SkInstCnt to all subclasses of GrRefCnt

git-svn-id: http://skia.googlecode.com/svn/trunk@4353 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoremove SkInstCnt tracking of SkViewRegistry
reed@google.com [Tue, 26 Jun 2012 20:15:42 +0000 (20:15 +0000)]
remove SkInstCnt tracking of SkViewRegistry

git-svn-id: http://skia.googlecode.com/svn/trunk@4352 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agodon't add SkViewRegistry to SkInstCnt
reed@google.com [Tue, 26 Jun 2012 19:54:52 +0000 (19:54 +0000)]
don't add SkViewRegistry to SkInstCnt

git-svn-id: http://skia.googlecode.com/svn/trunk@4351 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoremove bogus SkViewFactory reference
reed@google.com [Tue, 26 Jun 2012 19:48:09 +0000 (19:48 +0000)]
remove bogus SkViewFactory reference

git-svn-id: http://skia.googlecode.com/svn/trunk@4350 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd dump for SkWStream inst-leaks
reed@google.com [Tue, 26 Jun 2012 19:25:18 +0000 (19:25 +0000)]
add dump for SkWStream inst-leaks

git-svn-id: http://skia.googlecode.com/svn/trunk@4349 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agomore SkInstCnt plumbing
reed@google.com [Tue, 26 Jun 2012 19:24:50 +0000 (19:24 +0000)]
more SkInstCnt plumbing
fix some typeface leaks

git-svn-id: http://skia.googlecode.com/svn/trunk@4348 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoshow # of unknown subclasses in dump
reed@google.com [Tue, 26 Jun 2012 18:58:03 +0000 (18:58 +0000)]
show # of unknown subclasses in dump

git-svn-id: http://skia.googlecode.com/svn/trunk@4347 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoIn GrBatchedTextContext, use GrSafeSetNull(), for more safeness!
tomhudson@google.com [Tue, 26 Jun 2012 17:57:03 +0000 (17:57 +0000)]
In GrBatchedTextContext, use GrSafeSetNull(), for more safeness!

http://codereview.appspot.com/6326058/

git-svn-id: http://skia.googlecode.com/svn/trunk@4345 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agomore SkInstCnt plumbing
reed@google.com [Tue, 26 Jun 2012 17:55:30 +0000 (17:55 +0000)]
more SkInstCnt plumbing

git-svn-id: http://skia.googlecode.com/svn/trunk@4344 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd more SkInstCnt plumbing
reed@google.com [Tue, 26 Jun 2012 17:43:26 +0000 (17:43 +0000)]
add more SkInstCnt plumbing

git-svn-id: http://skia.googlecode.com/svn/trunk@4343 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRe-enable gm fontscaler for Android
borenet@google.com [Tue, 26 Jun 2012 17:23:52 +0000 (17:23 +0000)]
Re-enable gm fontscaler for Android

This was fixed in 4.1, and we're upgrading the bots since no non-beta client
uses 4.0.
Review URL: https://codereview.appspot.com/6334058

git-svn-id: http://skia.googlecode.com/svn/trunk@4342 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agostick SkInstCnt in more classes, to help track down leaks
reed@google.com [Tue, 26 Jun 2012 15:30:08 +0000 (15:30 +0000)]
stick SkInstCnt in more classes, to help track down leaks

git-svn-id: http://skia.googlecode.com/svn/trunk@4341 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoCleanup flattening code to properly serialize lighting image filters.
djsollen@google.com [Tue, 26 Jun 2012 14:33:13 +0000 (14:33 +0000)]
Cleanup flattening code to properly serialize lighting image filters.
Review URL: https://codereview.appspot.com/6333070

git-svn-id: http://skia.googlecode.com/svn/trunk@4340 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoReduce iteration count on picture_playback benchmarks to bring their cost
tomhudson@google.com [Tue, 26 Jun 2012 14:25:53 +0000 (14:25 +0000)]
Reduce iteration count on picture_playback benchmarks to bring their cost
more in line with the rest of the benches.

http://codereview.appspot.com/6325063/

git-svn-id: http://skia.googlecode.com/svn/trunk@4339 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoReverting r4324
robertphillips@google.com [Tue, 26 Jun 2012 12:56:54 +0000 (12:56 +0000)]
Reverting r4324

git-svn-id: http://skia.googlecode.com/svn/trunk@4338 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoBaseline images for msaa complexclip tests
bsalomon@google.com [Mon, 25 Jun 2012 22:04:13 +0000 (22:04 +0000)]
Baseline images for msaa complexclip tests

git-svn-id: http://skia.googlecode.com/svn/trunk@4337 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoTemporarily disable failing GM tests on Android
borenet@google.com [Mon, 25 Jun 2012 21:03:04 +0000 (21:03 +0000)]
Temporarily disable failing GM tests on Android

- fontscaler - this test fails due to a GL driver bug fixed in Jelly Bean
- drawbitmaprect - suspect this is also a driver bug
- shadertext - causes the device to reboot
Review URL: https://codereview.appspot.com/6330057

git-svn-id: http://skia.googlecode.com/svn/trunk@4336 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRegister some flattenable factories.
scroggo@google.com [Mon, 25 Jun 2012 20:32:12 +0000 (20:32 +0000)]
Register some flattenable factories.

Now, SkComposeShaders, SkDiscreteMapper, SkCosineMapper,
Line2DPathEffect, and SkTransparentShader can be flattened
and unflattened. This makes more of our samples work when
using a pipe.

Review URL: https://codereview.appspot.com/6338064

git-svn-id: http://skia.googlecode.com/svn/trunk@4334 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd -o option to bench_graph_svg.py: write the output to a file rather than stdout
epoger@google.com [Mon, 25 Jun 2012 20:29:04 +0000 (20:29 +0000)]
Add -o option to bench_graph_svg.py: write the output to a file rather than stdout
While I was at it, put the command-line options in alphabetical order.
BUG=https://code.google.com/p/skia/issues/detail?id=674
Review URL: https://codereview.appspot.com/6329061

git-svn-id: http://skia.googlecode.com/svn/trunk@4333 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoDisable assert blocking DEPS roll. This is a sanity-checking assert not
tomhudson@google.com [Mon, 25 Jun 2012 20:18:47 +0000 (20:18 +0000)]
Disable assert blocking DEPS roll. This is a sanity-checking assert not
necessary to correct operation (yet). Will pursue a fix & reenable.

http://codereview.appspot.com/6330056/

git-svn-id: http://skia.googlecode.com/svn/trunk@4332 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoif bounds don't intersect in DIFF mode, just return src (don't return empty)
reed@google.com [Mon, 25 Jun 2012 20:06:33 +0000 (20:06 +0000)]
if bounds don't intersect in DIFF mode, just return src (don't return empty)
Review URL: https://codereview.appspot.com/6337052

git-svn-id: http://skia.googlecode.com/svn/trunk@4331 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoskdiff: no longer skip .pdf files by default
epoger@google.com [Mon, 25 Jun 2012 18:45:50 +0000 (18:45 +0000)]
skdiff: no longer skip .pdf files by default
Review URL: https://codereview.appspot.com/6257080

git-svn-id: http://skia.googlecode.com/svn/trunk@4330 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix crash when buidling with no deferred drawing in grcontext
bsalomon@google.com [Mon, 25 Jun 2012 18:41:04 +0000 (18:41 +0000)]
Fix crash when buidling with no deferred drawing in grcontext

git-svn-id: http://skia.googlecode.com/svn/trunk@4329 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix the stencil rules to perfom an rdiff with an inverse path
bsalomon@google.com [Mon, 25 Jun 2012 18:03:46 +0000 (18:03 +0000)]
Fix the stencil rules to perfom an rdiff with an inverse path

Review URL: http://codereview.appspot.com/6336056/

git-svn-id: http://skia.googlecode.com/svn/trunk@4328 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd header needed to use the SWAP_PER_DRAW debug facility on windows.
bsalomon@google.com [Mon, 25 Jun 2012 17:49:25 +0000 (17:49 +0000)]
Add header needed to use the SWAP_PER_DRAW debug facility on windows.

git-svn-id: http://skia.googlecode.com/svn/trunk@4327 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd GrPaint::*StageEnabled() and GrDrawState::stageEnabled() functions.
tomhudson@google.com [Mon, 25 Jun 2012 17:27:28 +0000 (17:27 +0000)]
Add GrPaint::*StageEnabled() and GrDrawState::stageEnabled() functions.
These wrap the question of "is this stage of the shader enabled?" so that
we can change the semantics - previously iff there was a texture, now
if there is a texture OR a GrCustomStage, soon (post-cl 6306097) iff there
is a GrCustomStage, which at that point will hold whatever texture is
necessary.

http://codereview.appspot.com/6306104/

git-svn-id: http://skia.googlecode.com/svn/trunk@4325 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoEnable Scratch texture detach in SW path renderer's onDrawPath (take 2)
robertphillips@google.com [Mon, 25 Jun 2012 17:26:29 +0000 (17:26 +0000)]
Enable Scratch texture detach in SW path renderer's onDrawPath (take 2)

http://codereview.appspot.com/6331057/

git-svn-id: http://skia.googlecode.com/svn/trunk@4324 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix metrics test to no longer include the cpp.
djsollen@google.com [Mon, 25 Jun 2012 17:01:46 +0000 (17:01 +0000)]
Fix metrics test to no longer include the cpp.

The inclusion of the cpp caused linker errors when building skia
components as shared libaries for inclusion in an Android app.
Review URL: https://codereview.appspot.com/6338063

git-svn-id: http://skia.googlecode.com/svn/trunk@4323 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoSimplify vertex layout bitfields by making Position-as-texcoords the
tomhudson@google.com [Mon, 25 Jun 2012 15:22:12 +0000 (15:22 +0000)]
Simplify vertex layout bitfields by making Position-as-texcoords the
default.

http://codereview.appspot.com/6337050/

git-svn-id: http://skia.googlecode.com/svn/trunk@4321 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoReverting r4319
robertphillips@google.com [Mon, 25 Jun 2012 15:17:32 +0000 (15:17 +0000)]
Reverting r4319

git-svn-id: http://skia.googlecode.com/svn/trunk@4320 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoEnable Scratch texture detach in SW path renderer's onDrawPath
robertphillips@google.com [Mon, 25 Jun 2012 14:37:11 +0000 (14:37 +0000)]
Enable Scratch texture detach in SW path renderer's onDrawPath

http://codereview.appspot.com/6331057/

git-svn-id: http://skia.googlecode.com/svn/trunk@4319 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoexport flags on the state of the world when a picture was serialized.
reed@google.com [Mon, 25 Jun 2012 14:36:28 +0000 (14:36 +0000)]
export flags on the state of the world when a picture was serialized.
e.g. don't read/write functionptrs in that case (sizeof may be different for one)
Review URL: https://codereview.appspot.com/6331050

git-svn-id: http://skia.googlecode.com/svn/trunk@4318 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRemove multi-byte character constants.
bungeman@google.com [Mon, 25 Jun 2012 14:26:48 +0000 (14:26 +0000)]
Remove multi-byte character constants.
http://codereview.appspot.com/6305117/

git-svn-id: http://skia.googlecode.com/svn/trunk@4317 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years ago[android] Add an API to load customized font config for testing.
djsollen@google.com [Mon, 25 Jun 2012 13:58:22 +0000 (13:58 +0000)]
[android] Add an API to load customized font config for testing.

When running WebKit layout tests, we need to load some fonts from Linux to
match baselines of chromium linux. However, font config file is
hard-coded in Skia now. This change add an API to customize font config
in skia.

https://codereview.appspot.com/6296067/

git-svn-id: http://skia.googlecode.com/svn/trunk@4316 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix misplaced return in GrDrawState::stageDisabled().
tomhudson@google.com [Mon, 25 Jun 2012 12:30:34 +0000 (12:30 +0000)]
Fix misplaced return in GrDrawState::stageDisabled().
Original patch by guanqun.lu@gmail.com

http://codereview.appspot.com/6338058/

git-svn-id: http://skia.googlecode.com/svn/trunk@4315 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRaster implementation of diffuse and specular lighting filters. Externally,
senorblanco@chromium.org [Fri, 22 Jun 2012 21:01:23 +0000 (21:01 +0000)]
Raster implementation of diffuse and specular lighting filters.  Externally,
the caller instantiates a light (distant, point or spot), and an
SkDiffuseLightingFilter or SkSpecularLightingImageFilter with that light.  A
Sobel edge detection filter is applied to the alpha of the incoming bitmap, and
the result is used as a height map for lighting calculations.

Review URL:  http://codereview.appspot.com/6302101/

git-svn-id: http://skia.googlecode.com/svn/trunk@4314 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoExtend texture release on GrDrawState to also handle custom stages.
tomhudson@google.com [Fri, 22 Jun 2012 20:10:50 +0000 (20:10 +0000)]
Extend texture release on GrDrawState to also handle custom stages.
Add asserts to GrContext::setPaint() to make sure we're keeping things
cleaned up.
Remove double-call of setPaint() during text context initialization.

http://codereview.appspot.com/6324046/

git-svn-id: http://skia.googlecode.com/svn/trunk@4313 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdding files skipped from previous patch: http://code.google.com/p/skia/source/detail...
twiz@google.com [Fri, 22 Jun 2012 18:55:55 +0000 (18:55 +0000)]
Adding files skipped from previous patch: code.google.com/p/skia/source/detail?r=4310

Review URL: https://codereview.appspot.com/6339043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4312 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agorebaseline after recent aa-clipping fix on gpu
reed@google.com [Fri, 22 Jun 2012 18:29:40 +0000 (18:29 +0000)]
rebaseline after recent aa-clipping fix on gpu

git-svn-id: http://skia.googlecode.com/svn/trunk@4311 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRefactoring in preparation for adding the picture benchmarking program.
twiz@google.com [Fri, 22 Jun 2012 18:24:56 +0000 (18:24 +0000)]
Refactoring in preparation for adding the picture benchmarking program.

Review URL: https://codereview.appspot.com/6339043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4310 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRevert #if 0ed out code accidentally committed as part of r4299.
bsalomon@google.com [Fri, 22 Jun 2012 18:18:08 +0000 (18:18 +0000)]
Revert #if 0ed out code accidentally committed as part of r4299.

git-svn-id: http://skia.googlecode.com/svn/trunk@4309 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoExpand header in serialized pictures
reed@google.com [Fri, 22 Jun 2012 15:38:39 +0000 (15:38 +0000)]
Expand header in serialized pictures
Make chunk/tag reading allow for optional and (somewhat) out-of-order chunks.
Return empty picture instead of throwing on error
Review URL: https://codereview.appspot.com/6329049

git-svn-id: http://skia.googlecode.com/svn/trunk@4308 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agochange gm option from -config to --config, to match the double-dash convention of
reed@google.com [Fri, 22 Jun 2012 15:27:39 +0000 (15:27 +0000)]
change gm option from -config to --config, to match the double-dash convention of
all of its other options.
Review URL: https://codereview.appspot.com/6337044

git-svn-id: http://skia.googlecode.com/svn/trunk@4307 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRevert r4287. Large numbers of textures created by random gradients can cause poor...
bsalomon@google.com [Fri, 22 Jun 2012 15:15:59 +0000 (15:15 +0000)]
Revert r4287. Large numbers of textures created by random gradients can cause poor driver performance (at least on Mac)

BUG=670

git-svn-id: http://skia.googlecode.com/svn/trunk@4306 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRemoving redundant calls to GEN_ID_INC_EVAL in SkPaint.cpp
junov@chromium.org [Fri, 22 Jun 2012 14:37:21 +0000 (14:37 +0000)]
Removing redundant calls to GEN_ID_INC_EVAL in SkPaint.cpp

Review URL: http://codereview.appspot.com/6302099/

git-svn-id: http://skia.googlecode.com/svn/trunk@4305 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoImage rebaseline for r4303
robertphillips@google.com [Fri, 22 Jun 2012 14:20:47 +0000 (14:20 +0000)]
Image rebaseline for r4303

git-svn-id: http://skia.googlecode.com/svn/trunk@4304 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFix clipping of ovals on top & right
robertphillips@google.com [Fri, 22 Jun 2012 13:14:29 +0000 (13:14 +0000)]
Fix clipping of ovals on top & right

http://codereview.appspot.com/6294091/

git-svn-id: http://skia.googlecode.com/svn/trunk@4303 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoadd PictInfo chunk to serialized pictures
reed@google.com [Fri, 22 Jun 2012 13:12:17 +0000 (13:12 +0000)]
add PictInfo chunk to serialized pictures
Review URL: https://codereview.appspot.com/6325048

git-svn-id: http://skia.googlecode.com/svn/trunk@4302 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAutoScratchTexture can now release its texture and it will return to the texture...
robertphillips@google.com [Fri, 22 Jun 2012 12:41:43 +0000 (12:41 +0000)]
AutoScratchTexture can now release its texture and it will return to the texture cache when freed

http://codereview.appspot.com/6262043/

git-svn-id: http://skia.googlecode.com/svn/trunk@4301 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMove GrTemplates.h to src
bsalomon@google.com [Fri, 22 Jun 2012 12:34:22 +0000 (12:34 +0000)]
Move GrTemplates.h to src

Review URL: http://codereview.appspot.com/6333053/

git-svn-id: http://skia.googlecode.com/svn/trunk@4300 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoMinor GrStencilSettings cleanup
bsalomon@google.com [Fri, 22 Jun 2012 12:23:29 +0000 (12:23 +0000)]
Minor GrStencilSettings cleanup

Review URL: http://codereview.appspot.com/6329044/

git-svn-id: http://skia.googlecode.com/svn/trunk@4299 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAltered GrDrawState to always ref texture and render target
robertphillips@google.com [Fri, 22 Jun 2012 12:01:30 +0000 (12:01 +0000)]
Altered GrDrawState to always ref texture and render target

http://codereview.appspot.com/6251049/

git-svn-id: http://skia.googlecode.com/svn/trunk@4298 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoanother whitespace change to trigger buildbots, now that new win7 bots should work
epoger@google.com [Fri, 22 Jun 2012 07:58:36 +0000 (07:58 +0000)]
another whitespace change to trigger buildbots, now that new win7 bots should work

git-svn-id: http://skia.googlecode.com/svn/trunk@4297 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoWhitespace change to trigger all buildbots
epoger@google.com [Fri, 22 Jun 2012 00:33:28 +0000 (00:33 +0000)]
Whitespace change to trigger all buildbots

git-svn-id: http://skia.googlecode.com/svn/trunk@4296 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd empty directories to hold expected GM images for Shuttle PCs running Win7 using...
epoger@google.com [Thu, 21 Jun 2012 22:04:14 +0000 (22:04 +0000)]
Add empty directories to hold expected GM images for Shuttle PCs running Win7 using Intel GPU

git-svn-id: http://skia.googlecode.com/svn/trunk@4294 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoAdd GrSurface parent class above GrTexture & GrRenderTarget
robertphillips@google.com [Thu, 21 Jun 2012 21:09:06 +0000 (21:09 +0000)]
Add GrSurface parent class above GrTexture & GrRenderTarget

http://codereview.appspot.com/6297092/

git-svn-id: http://skia.googlecode.com/svn/trunk@4292 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoExpanded distribution of instance counting
robertphillips@google.com [Thu, 21 Jun 2012 20:25:03 +0000 (20:25 +0000)]
Expanded distribution of instance counting

http://codereview.appspot.com/6300114/

git-svn-id: http://skia.googlecode.com/svn/trunk@4291 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoFixed two bugs in SW-only clip mask generation
robertphillips@google.com [Thu, 21 Jun 2012 20:15:48 +0000 (20:15 +0000)]
Fixed two bugs in SW-only clip mask generation

http://codereview.appspot.com/6306086/

git-svn-id: http://skia.googlecode.com/svn/trunk@4290 2bbb7eff-a529-9590-31e7-b0007b416f81

12 years agoRecord pixel ref's gen ID in picture
bsalomon@google.com [Thu, 21 Jun 2012 20:13:04 +0000 (20:13 +0000)]
Record pixel ref's gen ID in picture

Review URL: http://codereview.appspot.com/6325046/

git-svn-id: http://skia.googlecode.com/svn/trunk@4289 2bbb7eff-a529-9590-31e7-b0007b416f81