Amitesh Singh [Wed, 11 Apr 2018 03:47:03 +0000 (12:47 +0900)]
theme: bg - remove the elm bg inheritance
Wonki Kim [Fri, 13 Apr 2018 04:38:53 +0000 (13:38 +0900)]
Disable getuid feature to fix build error on arm environment
Change-Id: I97760b84e104503bc6d2b5ba7d8cf6e9df531b4d
Marcel Hollerbach [Wed, 11 Apr 2018 08:36:24 +0000 (10:36 +0200)]
elc_popup: no need to make them focusable
if they have content the content will be focusable, if there is no
content the rect of root_focus will be focused instead.
Marcel Hollerbach [Wed, 11 Apr 2018 08:33:19 +0000 (10:33 +0200)]
efl_ui_focus_manager_root_focus: maintain focus state over state eval
the rect is unregistered and registered again, if it was focused, still
focus it.
Marcel Hollerbach [Tue, 10 Apr 2018 14:51:26 +0000 (16:51 +0200)]
elm_suite: a new testcase for checking focus chains with redirects
Carsten Haitzler (Rasterman) [Wed, 11 Apr 2018 05:34:40 +0000 (14:34 +0900)]
ecore ipc - fix send to skip data payload if null/0
conversion to efl.nmet didnt deal with null/0 zised payloads properly
and tried to send them, resulting in lots of ERR complaints which were
not errors. fix that to not try and send such empty payloads
@fix
Cedric Bail [Tue, 10 Apr 2018 22:01:23 +0000 (15:01 -0700)]
ecore_evas: remove dead code.
Cedric Bail [Tue, 10 Apr 2018 21:39:21 +0000 (14:39 -0700)]
evas: we directly use the main loop, we do not need external integration anymore.
Cedric Bail [Tue, 10 Apr 2018 21:02:48 +0000 (14:02 -0700)]
evas: protection during canvas shutdown.
Jaehyun Cho [Tue, 10 Apr 2018 13:03:26 +0000 (22:03 +0900)]
efl_canvas_animation_player: Reset map after animation is finished
Previously, beginning state of animation is applied after animation is
finished if final_state_keep_get() is false.
Now, map is reset (no animation is applied) after animation is finished
if final_state_keep_get() is false.
Jaehyun Cho [Tue, 10 Apr 2018 13:24:28 +0000 (22:24 +0900)]
efl_canvas_animation_player: Change Running_Event_Info to Event_Running
To synchronize other types of event info,
Efl_Canvas_Animation_Player_Running_Event_Info is changed to
Efl_Canvas_Animation_Player_Event_Running.
Remove unused struct.
Marcel Hollerbach [Tue, 10 Apr 2018 09:52:49 +0000 (11:52 +0200)]
ecore_file: switch from buf to tmpstr
before
c65782b15c0af7c25c5506cdf79cbbfa39604fec the acutal path has
been filled into buf, with eina_file_mkstemp the string is filled into
tmpstr, so that path should be chmoded instead of the template buf.
Thx to MatP for the report!
Marcel Hollerbach [Mon, 9 Apr 2018 23:46:30 +0000 (01:46 +0200)]
elm_suite: fixup test suite
the testcase was only added, but not executed, my bad!
Wonki Kim [Wed, 11 Apr 2018 08:37:04 +0000 (17:37 +0900)]
elementary: resolve build error
Change-Id: I8ace6bcbde3b2df29e756cfc635e8de863af374d
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Wed, 11 Apr 2018 06:47:08 +0000 (15:47 +0900)]
elementary_tizen: add override method for genlist_finalize to resolve build fail
Change-Id: If76dbd781b9a68d720eb861c0e9ecb8bd8ee9b76
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Tue, 10 Apr 2018 14:28:38 +0000 (23:28 +0900)]
elementary: Add missing diff to fix a build error
This patch should have been applied by a patch(
faeb798c6e682c3ed9967b189b41dbebc42d0496)
Change-Id: Icef27417bff8c4a2ab0400cc08939bdfc1490712
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Shinwoo Kim [Tue, 10 Apr 2018 11:38:47 +0000 (20:38 +0900)]
ecore_evas_wayland: handle 0x0 content problem
Someone could NOT use elementary and use ecore_evas only. In this case, content
size which is defined by elementary is 0x0. If content size is 0x0, then frame
size is equal to window size. But the frame size is defined by elementary as
well. So if there is not a content, then the frame size should be 0.
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:12 +0000 (13:37 +0200)]
tests: split ecore thread queue tests into 2 test cases
Summary:
enable running these tests in parallel
ref T6851
Depends on D5905
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6851
Differential Revision: https://phab.enlightenment.org/D5906
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:04 +0000 (13:37 +0200)]
tests: split efl_app promise tests into separate test cases
Summary:
each test case can run in parallel, so this provides a ~300% speedup
ref T6850
Depends on D5904
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6850
Differential Revision: https://phab.enlightenment.org/D5905
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:04 +0000 (13:37 +0200)]
tests: ensure eina/efl_object are initialized for all efl_app tests
Summary:
these aren't tested so don't init/shutdown for every test
ref T6850
Depends on D5903
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6850
Differential Revision: https://phab.enlightenment.org/D5904
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:03 +0000 (13:37 +0200)]
tests: move ecore promise tests into efl_app_suite
Summary:
ref T6815
Depends on D5902
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6815
Differential Revision: https://phab.enlightenment.org/D5903
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:03 +0000 (13:37 +0200)]
tests: add more timing info for per-file timing
Summary:
ref T6825
Depends on D5901
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6825
Differential Revision: https://phab.enlightenment.org/D5902
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:02 +0000 (13:37 +0200)]
tests: split ecore poller tests into separate file
Summary:
ref T6850
Depends on D5900
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6850
Differential Revision: https://phab.enlightenment.org/D5901
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:02 +0000 (13:37 +0200)]
tests: split ecore idler tests into separate file
Summary:
ref T6850
Depends on D5899
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6850
Differential Revision: https://phab.enlightenment.org/D5900
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:01 +0000 (13:37 +0200)]
tests: move efl_loop_fd tests into efl_app_suite
Summary:
ref T6815
Depends on D5898
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6815
Differential Revision: https://phab.enlightenment.org/D5899
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:01 +0000 (13:37 +0200)]
tests: break out simple timer failure test into separate test
Summary: Depends on D5897
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5898
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:01 +0000 (13:37 +0200)]
tests: add fixtures for efl_app tests
Summary:
ref T6811
Depends on D5896
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6811
Differential Revision: https://phab.enlightenment.org/D5897
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:00 +0000 (13:37 +0200)]
tests: move disabled efl loop timer test into efl_app_suite
Summary:
ref T6815
Depends on D5895
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6815
Differential Revision: https://phab.enlightenment.org/D5896
Mike Blumenkrantz [Mon, 9 Apr 2018 11:37:00 +0000 (13:37 +0200)]
tests: split efl_loop tests out of efl_app_suite.c
Summary: Depends on D5894
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5895
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:59 +0000 (13:36 +0200)]
tests: reduce duration of ecore_test_timers
Summary:
fix T6852
Depends on D5893
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6852
Differential Revision: https://phab.enlightenment.org/D5894
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:59 +0000 (13:36 +0200)]
tests: move ecore_test_ecore_main_loop_timer into timers test file
Summary: Depends on D5892
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5893
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:59 +0000 (13:36 +0200)]
tests: reduce duration of ecore_test_animators
Summary:
fix T6852
Depends on D5891
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6852
Differential Revision: https://phab.enlightenment.org/D5892
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:58 +0000 (13:36 +0200)]
tests: reduce duration of ecore_test_ecore_main_loop_timer test
Summary:
fix T6852
Depends on D5890
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6852
Differential Revision: https://phab.enlightenment.org/D5891
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:58 +0000 (13:36 +0200)]
tests: improve ecore thread queue reliability
Summary:
* check inside thread callbacks whether thread has been canceled
* clean up (global) objects
* wait for threads to die before exiting each test
ref T6851
Depends on D5889
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6851
Differential Revision: https://phab.enlightenment.org/D5890
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:57 +0000 (13:36 +0200)]
tests: remove "info" messages from ecore-drm/input tests
Summary: Depends on D5888
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5889
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:57 +0000 (13:36 +0200)]
tests: quiet useless printf spam from thread queue tests
Summary: Depends on D5886
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5887
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:56 +0000 (13:36 +0200)]
tests: remove extra download in ecore_test_ecore_file_download
Summary:
this function is just a wrapper, avoid downloading the same file
multiple times
ref T6853
Depends on D5885
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6853
Differential Revision: https://phab.enlightenment.org/D5886
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:56 +0000 (13:36 +0200)]
tests: use different website for ecore_test_ecore_file_download
Summary:
while it may be the case that we do not control example.com, it is also
the case that loading anything from enlightenment.org takes 10+ seconds
longer (at minimum) than loading example.com
ref T6853
Depends on D5884
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6853
Differential Revision: https://phab.enlightenment.org/D5885
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:55 +0000 (13:36 +0200)]
tests: use 0.05s as poller interval in ecore_test_ecore_main_loop_poller
Summary:
fix T6852
Depends on D5883
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6852
Differential Revision: https://phab.enlightenment.org/D5884
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:55 +0000 (13:36 +0200)]
tests: split ecore_test_ecore_main_loop_poller_add_del into separate tests
Summary:
unit tests should verify only small pieces of functionality to ensure
that they are testing what they claim to be testing
fix T6852
Depends on D5882
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6852
Differential Revision: https://phab.enlightenment.org/D5883
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:54 +0000 (13:36 +0200)]
tests: remove random usleeps from ecore thread queue tests
Summary:
fix T6851
Depends on D5881
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6851
Differential Revision: https://phab.enlightenment.org/D5882
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:54 +0000 (13:36 +0200)]
tests: enable some commented out eldbus tests
Summary:
these are able to run now that a dbus session is always launched
Depends on D5880
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5881
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:54 +0000 (13:36 +0200)]
tests: remove timing info for eina mempool initializer
Summary:
this is buggy somehow and prints its info a few dozen times, likely
taking longer to print the info than to run the actual test
Depends on D5879
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5880
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:53 +0000 (13:36 +0200)]
tests: use dbus-run-session when running tests
Summary: Depends on D5878
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5879
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:53 +0000 (13:36 +0200)]
tests: add all xml files to gitignore
Summary: Depends on D5877
Reviewers: stefan_schmidt
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5878
Mike Blumenkrantz [Mon, 9 Apr 2018 11:36:52 +0000 (13:36 +0200)]
tests: parallelize most test suites
Summary:
check does not internally do any parallelizing and is impossible to use
with threads, so using fork appears to be the only viable option for
using more cpu without radically redesigning all existing tests
ref T6825
ref T6848
Reviewers: stefan_schmidt
Subscribers: cedric
Maniphest Tasks: T6848, T6825
Differential Revision: https://phab.enlightenment.org/D5877
Shinwoo Kim [Tue, 10 Apr 2018 07:13:44 +0000 (16:13 +0900)]
efl_io_queue: add null check for slice->mem
A negative test case leads to segmentation fault.
If ecore_evas_msg_parent_send is called with NULL data, then slice->mem would
be NULL, and _efl_io_queue_efl_io_writer_write calls memcpy with NULL src.
Hermet Park [Tue, 10 Apr 2018 02:25:25 +0000 (11:25 +0900)]
elementary: apply anti-aliasing at the gesture layer example.
Hermet Park [Tue, 10 Apr 2018 02:09:35 +0000 (11:09 +0900)]
evas: improve evas map anti-alising rendering quality.
Old version algorithm was imperfection a bit, quality was poor at some specific
degrees, specifically, when pixel increment pattern on the diagonal lines is
unstable.
This revised version was better than old one even source code is much cleaner
and simpler.
See belows.
*NonAA vs AA:
https://ibb.co/bCNfMc
*Compare the worst case aa in the old version:
https://ibb.co/bEJsZx
*Test video:
https://youtu.be/Wn20Tym5lfg
Woochan Lee [Mon, 9 Apr 2018 17:27:57 +0000 (10:27 -0700)]
elementary: add new config value to handle tap finger size.
Summary:
The tap_finger_size value of the concept is different from the finger_size value used in the past.
We need a minimum value for recognize the gesture as a tap or not.
Since the actual screen has different screen sizes, there is a problem that the recognition rate of tap is lowered when using the existing value(finger_size)
Test Plan: elementary_test -> gesture sample.
Reviewers: cedric, woohyun, Jaehyun_Cho, herb, id213sin
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5842
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Woochan Lee [Mon, 9 Apr 2018 17:18:38 +0000 (10:18 -0700)]
ecore_evas: check return value.
Summary: After migration this code in Tizen. The coverity said it needs to check return value(CID 39562).
Reviewers: raster, myoungwoon, woohyun, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5907
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
JunsuChoi [Mon, 9 Apr 2018 17:12:58 +0000 (10:12 -0700)]
evas: add null check
Summary:
this commit add null check.
In EVAS_OBJECT_DATA_SAFE_GET, if eo_obj is null, obj can also be null.
and In _efl_canvas_output_async_block() can return null.
Test Plan: N/A
Reviewers: woohyun, kimcinoo, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5870
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
JunsuChoi [Mon, 9 Apr 2018 17:11:19 +0000 (10:11 -0700)]
ecore_fb: fix divided by zero
Summary:
w and h must not be zero.
because of the divide_by_zero exception occurs on line 649 and 653.
Test Plan: N/A
Reviewers: woohyun, kimcinoo, cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5873
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Marcel Hollerbach [Fri, 6 Apr 2018 10:48:41 +0000 (12:48 +0200)]
efl_ui_focus_object:
make the prepare call safe to recursive calls. There is no need to
prepare a item again if it is already in prepare.
Marcel Hollerbach [Mon, 9 Apr 2018 16:27:09 +0000 (18:27 +0200)]
efl_ui_focus_manager_root_focus: refactor _state_eval
Summary:
we have to check whether all of descendant are none_logical.
this fixes T6800
Test Plan:
1. elementary_test -to ctxpopup
2. Click 'Ctxpopup with user content'
3. Try focus ctxpopup content(button) using arrow key.
4. Check that the content is focused (you can move scroll bar)
Reviewers: bu5hm4n
Subscribers: raster, cedric
Maniphest Tasks: T6800
Differential Revision: https://phab.enlightenment.org/D5856
Marcel Hollerbach [Mon, 9 Apr 2018 14:16:16 +0000 (16:16 +0200)]
introduce efl_ui_focus_manager_window_root
Which is a interface that indicates that this is the root of all focus
managers.
Marcel Hollerbach [Sat, 7 Apr 2018 21:59:47 +0000 (23:59 +0200)]
efl_ui_focus_util: support later managers not beeing registered
this should fix some corner cases when setting focus by hand
Marcel Hollerbach [Sat, 7 Apr 2018 15:25:35 +0000 (17:25 +0200)]
efl_ui_focus_layer: return the registered focus manager when active
this fixes in chain setting for hovers and ctxpopups
Marcel Hollerbach [Sat, 7 Apr 2018 12:47:00 +0000 (14:47 +0200)]
elm_hoversel: make the keyevent handlers work again
i am not sure when this stopped working, elm hover sends focus to the
children it has, thus the propergation line for the key down events is
going from the hover up accross the over parent, however, the
hoverparent can be different to the hoversel, which would lead to
missing navigation in the hoversel.
this fixes T6802
Stefan Schmidt [Mon, 9 Apr 2018 10:24:53 +0000 (12:24 +0200)]
tests: eolian: remove reference to no longer existing files
These have been renamed in commit
f19a905261c6b02f788ce7b5167223555d324712
No need to keep the reference in the makefile. distcheck was also
getting confused about them.
Hermet Park [Mon, 9 Apr 2018 02:46:13 +0000 (11:46 +0900)]
ecore: fix a potential memory leak.
if the func argument is null, allocated memory won't be freed properly.
return it as soon as possible.
@fix
Hermet Park [Mon, 9 Apr 2018 02:29:41 +0000 (11:29 +0900)]
edje: fix potential memory leak.
next_token() requires free() for it's returned value and a string attribute.
Here token usage didn't take care of the memory freeing.
@fix
Hermet Park [Mon, 9 Apr 2018 02:14:07 +0000 (11:14 +0900)]
edje: fix potential memory leak.
next_token() requires free() for it's returned value and a string attribute
Here logic didn't take care of the memory usage.
@fix
Felipe Magno de Almeida [Wed, 21 Feb 2018 18:40:15 +0000 (15:40 -0300)]
gendoc-mono: Add documentation generation for C# language
Felipe Magno de Almeida [Tue, 2 Jan 2018 14:00:31 +0000 (12:00 -0200)]
efl-js: Fix dependency generation in JavaScript binding compilation
Use C++ as dependency in automake so concurrent builds will not fail to compile
Dave Andreoli [Sat, 7 Apr 2018 18:02:51 +0000 (20:02 +0200)]
A really small fix for test focus 5
Just place one of the buttons in the perfect position.
Carsten Haitzler (Rasterman) [Sat, 7 Apr 2018 07:34:29 +0000 (16:34 +0900)]
Revert "efl_ui_focus_manager_root_focus: refactor _state_eval"
This reverts commit
c6ce04e48f7813475e929f6205a2f6a2e7eb9729.
OK. I bisected and found that this is ythe root cause for 2 pretty
chunky bugs. Reverting this fixes T6870 and fixes T6871.
so that's 2 segvs in existing uses and even olne (elm config) ships
with efl. Having a look at the diff doesn't jump out what is wrong
here, but the best course IMHO is to take this patch and put it back
into review again... :)
Cedric Bail [Fri, 6 Apr 2018 18:28:55 +0000 (11:28 -0700)]
evas: when passed an Evas_Object, we should try to access it directly so that during destructor Evas is still accessible.
JunsuChoi [Fri, 6 Apr 2018 17:16:23 +0000 (10:16 -0700)]
evas: fix typo written twice
Summary: disp is written twice with the same value.
Test Plan: N/A
Reviewers: woohyun, kimcinoo, cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5874
Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
Cedric Bail [Fri, 6 Apr 2018 18:31:03 +0000 (11:31 -0700)]
elementary: in case of an object being destroyed, there is no point to warn.
Bowon Ryu [Fri, 6 Apr 2018 17:10:42 +0000 (10:10 -0700)]
ecore_wayland: remove logically dead code.
Summary:
remove logically dead code.
execution cannot reach this statement.
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D5876
Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
YeongJong Lee [Fri, 6 Apr 2018 17:10:05 +0000 (10:10 -0700)]
efl_part: remove duplicated text_aliases code
Summary: this widgets inherit from Layout. they can use same text_aliases of Layout.
Reviewers: Jaehyun_Cho, woohyun
Subscribers: herb, cedric
Differential Revision: https://phab.enlightenment.org/D5859
Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
Mike Blumenkrantz [Fri, 6 Apr 2018 17:08:29 +0000 (10:08 -0700)]
arc: update config to use current config value names
Summary: Depends on D5867
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5868
Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
Mike Blumenkrantz [Fri, 6 Apr 2018 17:08:24 +0000 (10:08 -0700)]
ecore: reduce pipe wait time during shutdown
Summary:
this is only meant to listen to data which is currently available,
not wait for new data
@fix
Depends on D5866
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5867
Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
Mike Blumenkrantz [Fri, 6 Apr 2018 17:08:23 +0000 (10:08 -0700)]
ecore: poll the thread pipe twice during shutdown
Summary:
this resolves a race condition when a thread join was pending during
shutdown but a pipe write was needed in order for the join to be
successfully executed before shutdown had occurred
@fix
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5866
Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
YeongJong Lee [Fri, 6 Apr 2018 16:28:20 +0000 (09:28 -0700)]
elm_inwin: use macro for content set/get/unset
Summary: also, content_aliases is not necessary. it can use Layout's content_aliases.
Test Plan:
elementary_test -to inwin
elementary_test -to inwin2
elementary_test -to inwin3
Reviewers: Jaehyun_Cho, woohyun
Subscribers: herb, cedric
Differential Revision: https://phab.enlightenment.org/D5860
Reviewed-by: Cedric Bail <cedric@osg.samsung.com>
Alastair Poole [Fri, 6 Apr 2018 15:11:41 +0000 (16:11 +0100)]
efl_selection_manager: fix build on MacOS and WL2.
YeongJong Lee [Fri, 6 Apr 2018 14:38:10 +0000 (09:38 -0500)]
efl_wl: Add NULL check
Reviewers: zmike, ManMower, Jaehyun_Cho, woohyun
Reviewed By: ManMower
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5862
Carsten Haitzler (Rasterman) [Fri, 6 Apr 2018 13:40:00 +0000 (22:40 +0900)]
ecore audio - add comment that this is an intended leak...
Stefan Schmidt [Fri, 6 Apr 2018 09:36:51 +0000 (11:36 +0200)]
tests: eldbus: mark unused parameter as such
Stefan Schmidt [Fri, 6 Apr 2018 09:19:40 +0000 (11:19 +0200)]
tests: ecore: remove no longer needed jenkins check function
After changes to the ecore_timer tests this function is no longer used
or needed. It can safely go.
Stefan Schmidt [Thu, 5 Apr 2018 14:12:25 +0000 (16:12 +0200)]
tests: elementary: remove unused variable
Looks like a copy and paste left over from another test.
../../../src/tests/elementary/elm_test_genlist.c:58:16: warning: unused variable ‘type’ [-Wunused-variable]
Carsten Haitzler (Rasterman) [Fri, 6 Apr 2018 08:08:44 +0000 (17:08 +0900)]
ecore audio - dont unload modules etc. in case audio obj around on exit
if audio objects are around after ecore_audio has been shut down then
they may access the sndfile or pulse lib ptrs/funcs and thus dont
unload these. should fix crashes on shutdown.
Cedric Bail [Wed, 4 Apr 2018 23:12:49 +0000 (16:12 -0700)]
ecore: and rename the test for Eina_Future to be the only promise test.
Cedric Bail [Wed, 4 Apr 2018 22:59:41 +0000 (15:59 -0700)]
ecore: remove tests of old Efl_Future based on Eo.
Cedric Bail [Wed, 4 Apr 2018 22:36:24 +0000 (15:36 -0700)]
evas: by moving lifecycle management to be handle by the death of the parent, there should be no call to efl_del.
Cedric Bail [Wed, 4 Apr 2018 21:50:42 +0000 (14:50 -0700)]
evas: the life cycle of an object inside an hash can not rely on the parent destroying, use ref/unref properly.
Cedric Bail [Thu, 22 Mar 2018 01:20:53 +0000 (18:20 -0700)]
ecore: rely on object being destroyed on parent invalidate.
Cedric Bail [Thu, 22 Mar 2018 01:19:24 +0000 (18:19 -0700)]
ecore: pipe fd can become invalid while being processed.
Cedric BAIL [Thu, 5 Apr 2018 18:27:44 +0000 (11:27 -0700)]
evas: we should always sync the canvas before destroying the object.
Mike Blumenkrantz [Thu, 5 Apr 2018 18:03:50 +0000 (14:03 -0400)]
tests: ck_assert_ptr_null -> ck_assert_ptr_eq
Mike Blumenkrantz [Thu, 5 Apr 2018 17:43:15 +0000 (13:43 -0400)]
tests: ck_assert_ptr_null -> ck_assert_ptr_ne
Cedric BAIL [Thu, 5 Apr 2018 17:39:30 +0000 (10:39 -0700)]
eina: mark thread by default as not cancellable as per Eina documentation.
By default all Pthread are cancellable. This leads to strange behavior that
happen during shutdown and hasn't been figured out. Most likely fix for T6622.
Mike Blumenkrantz [Thu, 5 Apr 2018 17:15:36 +0000 (13:15 -0400)]
tests: move bindings tests to using checked fixtures too.
T6862
T6811
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Xavi Artigas [Thu, 5 Apr 2018 16:59:54 +0000 (09:59 -0700)]
elementary: fix efl_ui_view_list examples
Reviewers: SanghyeonLee
Reviewed By: SanghyeonLee
Subscribers: cedric
Differential Revision: https://phab.enlightenment.org/D5863
Reviewed-by: Cedric BAIL <cedric@osg.samsung.com>
Mike Blumenkrantz [Thu, 5 Apr 2018 16:25:16 +0000 (12:25 -0400)]
tests: add test for check < 0.11 to enable timing info
Stefan Schmidt [Thu, 5 Apr 2018 12:30:50 +0000 (14:30 +0200)]
tests: elementary: fix build break after rename of efl_ui_view examples
Commit
ae8df9ba076e6086900353f0e10480bb2302b44d renamed the files but
did not rename the references in the Makefile.
Carsten Haitzler (Rasterman) [Thu, 5 Apr 2018 12:12:10 +0000 (21:12 +0900)]
elm - selection manager - fix string buffer handling and format types
this has 2 bugs really. 1 - the format masks for plain text included
markup which ... is wrong - right? that should have a mime type of its
own... either way it leads to plain text pasts being handled wrong in
wayland... so this fixes that
also the string buffers in wayland just were nothandled right. buffers
were raw binary buffers plus size,not strings, but they were strdup'd
etc. assuming nul termination. oh so wrong to do that. this also fixes
that as i fpound it while fixing the above format bug.
this fixes T6284
@fix
Daniel Kolesa [Thu, 5 Apr 2018 11:53:13 +0000 (13:53 +0200)]
eolian: _ is allowed in doc references
Shinwoo Kim [Thu, 5 Apr 2018 04:18:03 +0000 (13:18 +0900)]
Fix static analysis result
[Dereference after null check]
(1) src/lib/ecore/ecore_main.c
- _efl_loop_handler_efl_object_finalize checks if pd->loop_data is NULL.
After that, _handler_reset > _handler_clear > _ecore_main_fd_handler_del >
_ecore_main_fdh_pool_del is directly dereferencing pd->pool_data.
- _efl_loop_handler_efl_object_parent_set checks if pd->loop_data as well.
Then it calls _handler_reset as well.
(2) src/lib/ecore_wayland/ecore_wl_dnd.c
- ecore_wl_dnd_selection_set checks if t - result of wl_array_add - is NULL.
And it is dereferecing t directly for wl_data_source_offer.
(3) src/lib/elementary/efl_ui_dnd.c
- Third parameter const char *data could be NULL.
In this case strlen dereferences NULL. The data should be non NULL value.
I have checked this with Mr. Thiep Ha.
(4) src/lib/evas/canvas/evas_object_inform.c
- _efl_canvas_object_efl_gfx_stack_stack_below checks if obj->layer is NULL.
So it could call evas_object_inform_call_call_restack which is dereferencing
obj->layer directly.