Removed Cereal from Build Except where necessary

Only 3 file compilations (InProcClientWrapper.cpp, OCResourceRequest.cpp,
and OCRepresentation.cpp) actually need the cereal include, so this fix
removes it from everywhere else.  This will result in faster compile times.

Change-Id: I8f9c7b6c3991089189fe85fd8ebff6a9e1e2aa80
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/300
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>

Fixed make_unique to work with C++14+ compilers

Previous solution didn't correctly import the make_unique from
C++14/1z when using the new compiler.  This ensures that OC::make_unique
will always work correctly.

Change-Id: Ibb7456f6375c5c16553bb76c71646ec911190c0f
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/299
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Added support in tinyDTLS to support rehandshake

As per RFC 6347 section 4.2.8, DTLS Server should support requests
from clients who have silently abandoned the existing association
and initiated a new handshake request by sending a ClientHello.
Code is updated to detect this scenario and delete the old
association when client successfully responds to HelloVerifyRequest.

Change-Id: I6e256921215c1a22e9e5013499c4dfd98659f8cc
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/120
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit 6baf3d32af01b99cc56466e51b541a6be3a911f4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/311

Fixed issue to pass PSK identity hint to application in callback

In cases (with PSK ciphersuite) where Server is sending
'PSK Identity Hint’ inside ServerKeyExchange message, DTLS library
is not passing the ‘identity hint’ inside ‘desc’ argument in
get_psk_info(DTLS_PSK_KEY, desc) callback. Instead, ‘desc’ contains
the identity of the client itself. The reason for this is that the
code inside dtls_send_client_key_exchange() method
overwrites the ‘identity hint’ received earlier.

Change-Id: Ibf447e3a6b33284118908a52aed4cf636038ab23
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/119
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit 72a92249258601e2ab799628733afcb7c4c9b1e9)
Reviewed-on: https://gerrit.iotivity.org/gerrit/310

Fix errors on Arduino caused by proper initialization.

Initializing structs with "{0}" causes errors on Arduino where the
struct's first member is a non-primitive or something that can not be
properly set to "0" without a cast. I re-arranged the structs such that
the first member of the structs are of a primitive type or are typedef'd
as a primitive type.

Change-Id: Ib7ecced34ea85b1a8c9106c34e1d27890a4cf039
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/304
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Fixed OCLogger enum log levels to be legal

Double-underscores at the beginning of a token are reserved
for the compiler usage, so these values were removed.  I've also
altered the names a bit to make them look different enough so that
our users don't use them.

Finally, I made sure that they don't actually WORK, so that our
users won't be tempted to use them.

Change-Id: I3ae04ff32f01dfc6e0d89948a3b5b858157de6ab
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/298
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Removed boost program_options from build

Program Options were only used for the ocicuc directory, however
that has been removed.  Therefore we don't need to use it to build
anymore.  Additionally, it was not included in any files or used
in any make files.

Change-Id: I12a195b28d549fc1ca86062f9628aca59def4a61
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/301
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>

Clean up the C samples

Update the URI in the samples for Unicast discovery and device discovery.

Change-Id: Ice2ec98bb33033743c17f3259e6a86380c0afc0e
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/285
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed Scons script changes to include CA flags in IoTivity build.

Include Linux Scons changes , Tizen scons build script changes.

Change-Id: I4a95f4887b9f4cb1c78d18659fd35fcf13584789
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/270
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Removed warnings from calls to OC_LOG_BUFFER from within stack.

OC_LOG_BUFFER() expected "const uint8_t*" not "const unsigned char *".

Change-Id: I1e092abaf6af84ad66083c9bcf567d024e64b4d8
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/290
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Removed extraneous definitions of CA_INT in makefiles and sconscripts.

These definitions are no longer needed to run the RI layer on the CA
layer.

Change-Id: I9751b4d4d7ab0c35f2a277d4f100910070c976f6
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/291
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

RESET/ACK messages requirement to add additional data from CA .

 1) CA layer provide new CAResponseResult_t element to represent empty message.
2) RI can use 'SendResponse' for RESET and ACK(separated response)
with CAResponseResult and CA_Info_t->CAMessageType_t
 3) CA layer will add token information according to the message id of empty message. and
        ( The message id should be from CON type message. )

Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Change-Id: Ib926601cf9eb1693a0faedf9834d67f9ba0ccd50
Reviewed-on: https://gerrit.iotivity.org/gerrit/268
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed uninitialized memory/invalid memory issues

ocstack.c had a string being allocated without enough room, causing
readers/writers of the code to stomp on the next byte.  A few locations
had unintialized memory causing jumps to be made on uninitialized data.

Change-Id: Ifbccb463f1d09f7a09b752ee95cf84c9ae9a26c4
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/183
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Changes to make Linux build with CA_INT flag specified.

These changes also include some work to ensure better global cleanup
in makefiles. Some of this clean up work also overlaps with cleaning
Arduino outputs. This commit only affects makefile builds.

Change-Id: Idcfce740f1ec5766599a1f0aafb5e635647e7692
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/129
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Made changes to support Arduino 1.5.8 with Connectivity Abstraction.

Since the CA Layer assumes version 1.5.8 of Arduino, our original
makefile implementation had to be updated to match this.

Since the directory structure is mildly different between 1.0.5 and
1.5.8, these changes were necessary that are found in
arduinomega.proerties.

Due to casting errors, source code was updated accordingly.

Change-Id: Ib8f68fa9dd4f14af2dfadbeac2f0d85cc0d292d4
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/34
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Code cleanup in Security sample apps

Removed CA_INT specific code. Updated OCInit calls to remove IP address
and port number.

Change-Id: Iba506b67e33060ea32b2430b443443305bfa0243
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/264
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Removed #ifdef CA_INTs and other code cleanup.

Change-Id: I664f0e2e500ba60ed35f2bd8c000ab3988672733
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/281
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix build issue

Fix CA branch build issue by removing ocsecurity.c from makefile
and ocsecurityinternal.h from ocstack.c files.

Change-Id: Ic0b5926b82d555fdabfa8679bde9b0e68aa75af3
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/266
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Build OICMiddle using Scons on CA branch

Change-Id: I63ad62700ee87b13c316fcf04d8e2c1fa42f4cc0
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/274
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix build warnings

Fix all build warnings in the CA branch. Build warnings due to
different pointer types for token, endpoint, and request info.

Change-Id: Ia29f8cb6f020457985ed1d6138e633eec412395e
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/259
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed OCDOResource interface

OCDoResource previously used uint8_t for connectivity type
This was replaced with OCConnectivityType

Change-Id: Ia5ddb4d72a7cd41786ffe27bfeae250ef21e6104
Signed-off-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/279
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Added appropriate comment to address a TODO

Change-Id: I8299a7e6c3e3617d02513e794d4ff0c01b669f51
Signed-off-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/275
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Resolve Klocwork c++ issues

Fixed memory leak issue in InProcClientWrapper.cpp
Fixed infinite loop issue in groupclient.cpp, groupserver.cpp,
simpleclient.cpp and simpleclientHQ

Change-Id: I27938f138a069a64ccf000afc16563dc5e9579e2
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/255
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Reduce footprint by using string literals.

Original author: Ossama Othman <ossama.othman@intel.com>
This change is cherry picked from master to
connectivity-abstraction branch.

This change replaces the std::string based exception description
string constants in resource/include/StringConstants.h with
string literals instead.  Switching to string literals has a number of
advantages in this case:

- reduced start-up time for binaries that link against liboc
  since the static std::string constants no longer have to
  be initialized at run-time.
- the compiler is free to place the strings in read-only
  memory.
- reduced static and run-time footprint.

Please refer to original commit for more details:
https://gerrit.iotivity.org/gerrit/#/c/128/

Change-Id: I234545cdc288e71f4e7e8594e1634fcbdadafe70
Signed-off-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/273
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Fixed C++ unit tests for connectivity abstraction integration

Updated  C++ unit tests to reflect connectivity abstraction API changes.
Disabled tests that became irrelevant due to connectivity abstraction changes

Change-Id: Ic4d11c973592e27e4e17e26ab69b735c0e7c6d66
Signed-off-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/263
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Removing Internal calls to CA APIs in OCPlatform

Previously on the CA branch, we had APIs calling the CA APIs internally
with hard coded connectivity types.
Made changes in "service" project to enable using "#ifdef CA_INT" and
added the same in appropriate places.

Change-Id: Ie9f9faf9b7fa90556b4633528b0fa60de9df451c
Signed-off-by: omkar <omkar.m.hegde@intel.com>
Signed-off-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/154
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>

example: link to libraries using -L flag

executable will be able to load them
from standard paths (/usr/lib*/)

Change-Id: I0728c196b766ce55e7185dffb69d9790b5b065c5
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/246
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit b274c49e7e566cb2cb550a6a0946850a15834c6d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/262

Validate input parameters

Validate input parameters endpoint, protocol request,
and client response pointers before use them.

Change-Id: I47d084d19e523f695202782e02480f9f14fe529b
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix issue where logger files aren't built for Arduino on CA Branch.

The logger file has to be built with a C++ compiler so that we can
use Arduino's Serial functions as they are prepared in C++ world. With
a ".c" extension, the CA layer makefiles enforce it to be build with
a C compiler. We are forcing only the logger.c file to built for c++.

Change-Id: If2c17d15ebdb3b9942cb6c8391b4c2f7865b1fcd
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/187
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Updated RI layer to register 'GetDtlsPSKCredentials' as callback

RI layer now uses CARegisterDTLSCredentialsHandler method to register
callback to retrieve credentials. Also, moved security sources and
headers in separate directory as discussed previously for better
integration with CA layer.

Change-Id: I23f481a087d8400be0402ea2854fe3601580dfb6
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/241
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed makefile for unittests

Added connectivity abstraction to linker

Change-Id: Iae76e9423b58a29e704092bf65fc009341453f5c
Signed-off-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/258
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Log invalid request in HandleCARequests

Log a message when the number of header-options is incorrect and
the client recives any request in the HandleCARequests method.

Change-Id: I03e6522b4c306eebd89f581d47ed656d34923219
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/239
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Remove OCICUC from build and repo

The OCICUC library isn't properly being maintained and isn't really being
used, so it is being removed.

Change-Id: I613072d5256fd53c6d7ef179cd971356caf18d41
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/237
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Replaced (conditionally) OCCoAPToken with CAToken_t

Replaced old style CoAP tokens with CA tokens under #ifdef CA_INT.
Fixed token related warnings except occoap ones.

Change-Id: I413966570de9e43eab0a8c3311395d9c8e4d8de9
Signed-off-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/118
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Removing csdk samples dependency on liboc

csdk samples are not dependent on liboc.
Updated SConscript files to remove the dependency.

Change-Id: Ic4e72ecf281c131f3ba28c19091edbf5456d8fb4
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/190
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed simpleclient crash caused by curResource being altered

The foundResource function is called asynchronously, and was written
in a way that was not thread safe. This fix adds a lock and exit logic
so that it works prooperly and only uses the first found curResource
that matches its requirements.

NOTE: This change (author: Erich Keane) is from 01.org.

Change-Id: I984ce1623ff491713ecf5d621f1283ebad33bfef
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
Signed-Off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/236
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix for seg fault due to double free

This fix is for IOT-285.
https://jira.iotivity.org/browse/IOT-285

Thanks to Sam for root causing the issue.

Change-Id: I92a53e312998684270f26c94db955195feafae86
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/234
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>

Added temporary fix for building with connectivity support

This is a temporary fix for IOT-281:
https://jira.iotivity.org/browse/IOT-281

Without this temporary fix, it would be unable to run
C and C++ samples with CA.

Change-Id: I02f6aedcfda7c05b296cb943e2b0f929896b0c02
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/233
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Update the multicast port and GenerateToken code in RI accordingly.

Update the Multicast port to 5683 accordingly in RI as per connectivity code.
Connectivity code fixed generate token code. Remove the temporary fix that
was added in RI code.

Change-Id: Iec9b07b98d65309a4cc2998252fcc8c445975f55
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/231
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Tested-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

[SSM] Change to make SSM work with Connectivity Abstraction

Modify ResourceFinder to find Resources and check presence status with connectivity type

Change-Id: I2478904ff08b28ef2cbe131e06b95e3f059618fb
Signed-off-by: Minji Park <minjii.park@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/232
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>

Fixed crash on rec'd invalid data.

This issue is a fix for IOT 114.

Previously, a bad series of JSON coming in would cause an exception
to be thrown. this would result in the callback/server crashing, which
is not appropriate behavior. This fix catches and logs any JSON
errors keeping the callback/server from crashing.

NOTE: This changeset is originally from 01.org(changeset 695,
author: Erich Keane).

Change-Id: I1e7d042f243bc1b86771778c308f1187bcda875f
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/103
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
(cherry picked from commit 65ecd8a508bf04d03153a9510a78995715242963)
Reviewed-on: https://gerrit.iotivity.org/gerrit/226

Modified connection type variable to match OC prefix

Change-Id: Ia62eee6d0f7810a819aa0d26129c3c21dd898950
Signed-Off-By:Sudarshan Prasad<sudarshan.prasad@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/180
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Omkar Hegde <omkar.m.hegde@intel.com>

Adding tinyDTLS into iotivity repo

Picked GIT commit id 7d039c from
http://sourceforge.net/projects/tinydtls/ .

iotivity build system can compile tinydtls using autotools
with below steps:
1)autoconf
2)./configure --without-debug --without-ecc 'CFLAGS=-fPIC'
3)make

Change-Id: I97a917955ca13a06914ecee178c0cee0701eda12
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
(cherry picked from commit 35e1a2e526a8cfe19a360aa711998d787303e63e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/225
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

tizen: packaging: build on x86_64 arm64 and others too

Without this change only 2 arch were possible to build :
arm and x86 (32bits)

Since some scon's variables are not aligned with Tizen's infra name,
mapping is needed for x86 amd arm64.

While for x86_64 it can use the generic RPM macro %{_arch} value
which is same, it prevents writing an extra "if endif block".

Other unsuported arch were not tested (ie: mips, ppc ...)
and would  probably need more sources or make/scon/files adaptations.

With a couple of other fixes (to come later),
rpmbuild was successful using Tizen:Common's repos
with those archs : x86, x86_64, armv7l, aarch64.

Feel free to me ask support upstream or on tizen trackers

Change-Id: I1034d66ac29bee1667a7e12d6ceb9e08806c3a15
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Reviewed-on: https://gerrit.iotivity.org/gerrit/157
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit f737269c24f96abbec60eeedc3c178ce2ee8eee0)
Reviewed-on: https://gerrit.iotivity.org/gerrit/224

Improve usability of ActionSet for Group Action Feature.

ActionSet structure is not show directly to developer.
Because there is the definition of ActionSet in GroupManager.h.
So we separate the definition of ActionSet from Groupmanager to ActionSet.h
And it is exposed to developer by one type of header file.

Change-Id: I2ccb93cf70ec42b122aaead4943aed56df161641
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
(cherry picked from commit 9520eb3c228275be55a3ee0401a8c590571c3168)
Reviewed-on: https://gerrit.iotivity.org/gerrit/223
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Added release notes for Jan 17th release

Change-Id: I62b1457e8a35082f7896fb5d64630a173c59f233
Signed-Off-by:Sudarshan Prasad<sudarshan.prasad@intel.com>
(cherry picked from commit d6838c11d8882850337a99ede23fd61ba48d0e5b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/222
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix zeroing of OCServerResponse payload array

Change-Id: I93ba1720a3de0c54937d5d8d48d72574b2dbb65d
Signed-off-by: Maks Naumov <maksqwe1@ukr.net>
(cherry picked from commit 1a74b39708d3c9d616ee3cdaf19a97dc9c91134b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/163
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Remove high frequency log to avoid the log full with useless information

The OCProcess function is invoked in while loop. The functions that are
invoked by OCProcess will be invoked very frequently. If add log in these
functions, it may make the log full of useless information.

This patch removes frequent log from OCProcess/OCProcessPresence/
OCProcessCoAP/coap_read/OCRecvFrom function.

Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Change-Id: Iabe182aca8430438085296cd16d69f5bde0626a8
(cherry picked from commit e234f7e623683d2d015752c9db8b8d564131fb4e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/221
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Changed OCStackResult to be consistent across compile flags.

Issue 245 was reported that pointed out that the presence flag in
the compiler makes OCStackResult incompatible across differently
compiled versions of the CStack.  Additionally, this spaces out the
error codes from success codes, permitting additional room for more
success codes.

Change-Id: Ia93f34e23756e7663ea80f6667699d59e358058e
Signed-off-by: Erich Keane <erich.keane@intel.com>
(cherry picked from commit b7786c89ef40ec15c904633b979be6c73dfee53d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/220
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Update gitignore.

Change-Id: Ie3f1c5a6b6d2c1e8b7d9df6336eea9083597b697
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>
(cherry picked from commit 3df96e9d2f9968512ce87954e7967ea2687e435e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/219
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Add method of Things-Manager.

It was not included implementation.
So We implement about bindResourceToGroup for Group Formation feature.

Change-Id: Iade53004d8b3d974846a3b9056c6c3b6649104fa
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
(cherry picked from commit dab7666e8db685c0a4dc16a1f1ed38e79e9ce219)
Reviewed-on: https://gerrit.iotivity.org/gerrit/218
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix Memory leak of getResourceType() in ocstack.c

When memory allocation is failed, add free memory for already allocated memory.

Change-Id: I601367e7bfe3ff6a616d870636d5b535a32047fd
Signed-off-by: YW Sung <yw.sung@samsung.com>
(cherry picked from commit ede5597d2740085e182a9f3f301873ec94ebba9c)
Reviewed-on: https://gerrit.iotivity.org/gerrit/217
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed seg fault in simpleclient sample app (Bug IOT-130)

Arduino server sample uses light representation which is different
from what simpleclient expects. Updated simpleclient to catch
exception in this scenario.

Change-Id: I3d5d2e2f7785a9345655bc347662efb7fd0927a2
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
(cherry picked from commit 16aaed92f74fedf975a1631800200b8ffc526f7d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/216
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Added style formatting config files for iotivity coding standards

The style config files are used to apply IoTivity coding style, as
described on the wiki https://wiki.iotivity.org/iotivity_coding_standards.

Change-Id: Ifd3937bebde658a76aa7c9918b4c699c1384f341
Signed-off-by: William Dieter <william.r.dieter@intel.com>
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
(cherry picked from commit 859a79508f993a73ad56d2b42a986915e1584958)
Reviewed-on: https://gerrit.iotivity.org/gerrit/215
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed InProcServerWrapper to be thread safe

A few of the variables/collections in the server wrapper were not
properly protected against multi-threading.  This fix adds a mutex
to the class to ensure that all accessed items are protected.
Additionally, they are moved out of the root namespace to prevent
polution.

Change-Id: I2eedb9bf9b1960ff7a018a2ca1e15183e42bd9cd
Signed-off-by: Erich Keane <erich.keane@intel.com>
(cherry picked from commit a31834d16272a5b8d3382fb2959676804157c732)
Reviewed-on: https://gerrit.iotivity.org/gerrit/214
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix failed unit tests for CSDK stack.

The existing unit tests in stacktests.cpp had not kept up with
ongoing modifications to the C API.  Modified failing tests to
align with latest C API functionality.

Also modified to remove limitation that required the eth0 network
interface to be available on the test machine.  If eth0 was not
available, some tests would fail.

Also added a local function to handle C stack initialization and
modified tests to call this function.  Added local functions to
intialize the number of expected resources and resource index
depending on whether presence is defined.

Re-grouped related test cases and created common group test names.

Change-Id: Ief59854d762ef9837f8b1d5b95bebc6514bd545a
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
(cherry picked from commit 15c4be36928eafe79176dfa785d832276a2a1c2a)
Reviewed-on: https://gerrit.iotivity.org/gerrit/213
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

C++ Avoid crash in case of Invalid/Empty Payload

This change is based on a bug reported by SHP wherein
they want to be able to send response with empty payload.
Instead of throwing an error, we now send an empty
OCRepresentation() object to the client callback.

Change-Id: I16f298bf8a0bdbb545e1133d751582f418991352
Signed-off-by: omkar <omkar.m.hegde@intel.com>
(cherry picked from commit 43e5a4f0a42a739e93f65ccf31eff82df11144c3)
Reviewed-on: https://gerrit.iotivity.org/gerrit/212
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Change the definition of GROUP_INTERFACE.

The definition of GROUP_INTERFACE as "oc.mi.c"
does not get big meaning.
So, we change the definition to "oc.mi.grp".
Regarding opinion of Caiwen.

Issue : [IOT-253]

Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
Change-Id: Ia196e8a2a0856ed0651874eec419f77468e8329e
(cherry picked from commit 2733ac3486521c0491819e3c9b6b65b8ca8c07f4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/211
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Adding OK Response Code for POST

Earlier, we were setting response code for POST only if a new resource
is created assuming that the value is by default OK.
TE tests showed error on using different version of Ubuntu.
Modified simpleserver to explicitly add OK status.
Added constructors to OCResourceRequest and
OCResourceResponse classes to avoid undefined behavior.
This Fixes IOT-128.

Change-Id: I13faff2fb254c777ccc8c8979824d53f5111ab3e
Signed-off-by: omkar <omkar.m.hegde@intel.com>
(cherry picked from commit ad7450d4c430e4936969e8e29b0738db9ffeea29)
Reviewed-on: https://gerrit.iotivity.org/gerrit/210
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Removed executable bit from non-executable files.

Change-Id: Ifa125423fb435575e391471cc7dafe3f1bd84972
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
(cherry picked from commit 393d481d4a05809d608937ed31f807828f637a73)
Reviewed-on: https://gerrit.iotivity.org/gerrit/209
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Add quick guide into the readme

Change-Id: I502acfebf6a4752bf2ffa57d05dc31e8eac65959
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
(cherry picked from commit c7f29618b936895b74ba75760aa2e579ec9ba56e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/208
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

[SSM] Fix issues about initializing SSM

1. modify to return error code when xml parsing error occurs
2. apply new SSM Interface
3. modify sample apps according to the new interface design
4. modify ResourceFinder to stop checking presence when SSM terminates

Change-Id: Id5cd6aade44fe531cb547400d15bb343ba28655a
Signed-off-by: Minji Park <minjii.park@samsung.com>
(cherry picked from commit 755906466e380ef87011385b89af29004e616bb0)
Reviewed-on: https://gerrit.iotivity.org/gerrit/207
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

[SSM] Add omitted arduino sample and soft sensor sample

1. Add omitted arduino sample app
2. Modify previous arduino sample to use proper resource name
3. Add IndoorTrajectory Soft Sensor

Change-Id: I90e7a69ef203d3f57e8350f73ffa47039f883878
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
(cherry picked from commit d887fda27142837f6de6d2a307558a001405fc27)
Reviewed-on: https://gerrit.iotivity.org/gerrit/206
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

[SSM] Fix context query parser issues

This patch resolves issues that related to context query

which occures infinite loop and crash

Change-Id: I5acd9c57ee82a7ba1d3a5a416680a23676acfabb
Signed-off-by: jk13 <jihyeok13.kim@samsung.com>
(cherry picked from commit ba9725edbd9dccf87e8e57184e440168122b2cac)
Reviewed-on: https://gerrit.iotivity.org/gerrit/205
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

[PPM] fix Plugin Manager Destructor segment fault.

1. Modify PluginManager Destructor.
2. Remove "free(handle)" and add "dlclose(handle)".

Change-Id: Ib2fc492631914664eac76d0db0d78126e1cefd95
Signed-off-by: junho13.lee <junho13.lee@samsung.com>
(cherry picked from commit 6622fca961729a7bccc23ce54759b35b55c5fca9)
Reviewed-on: https://gerrit.iotivity.org/gerrit/204
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Add C++ Unit tests

Added unit tests for OCPlatform and OCResource C++ APIs.
All tests are passing

Change-Id: Ib31295db92ad3934dec1ea32e59315cea8fff2a8
Signed-off-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>
(cherry picked from commit f488ad57ad2b45197ab5a1f4a5ed06565d7b473d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/203
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixing OCCancel with High_QOS in observe isn't deleting CB.

(Bug IOT-126) Calling OCCancel should result in deleting all
associated structures including callbacks. This also should
happen when we deregister observation.

Change-Id: I34dd67288873ce27919a12a1d5fe244ef80751b7
Signed-off-by: Yamin Al-Mousa <yamin.s.al-mousa@intel.com>
(cherry picked from commit bd3dd4b91f1bca31402240052199f2557ad1d055)
Reviewed-on: https://gerrit.iotivity.org/gerrit/202
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Removing getting started and how to guides from API references.

Developer content will be available on iotivity.org going forward, so
there is no need for these files in the API docs code. Direct links were
added to the Home.txt for the iotivity.org/documentation and
wiki.iotivity.org sites.

IOT-218 - Removed the "M1 release" text in title from Doxygen output
IOT-219 - Remove "About OIC" , "Programmer's guide" and "how to"

Change-Id: I28e26328a82cb6ff037ce451a5ed6fee368ad635
Signed-off-by: mshaver <michael.r.shaver@intel.com>
(cherry picked from commit 6a6e69ce6c64b2f7ec85cf2e4c28dd2558192aef)
Reviewed-on: https://gerrit.iotivity.org/gerrit/201
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix some issues of GroupSynchronization
- findGroup() with null callback parameter issue is fixed.
  : return OC_STACK_ERROR, when callback parameter is passed with a null value.
- joinGroup() failure when there is no group match with group type parameter is fixed.
- deleteGroup() failure when delete group with no child is fixed.

Erase "else" statement for guard condition in findCallback NULL checking.

Change-Id: Id00160e3b2e85e03c4e4dd5bd5fb401f6a8bbd42
Signed-off-by: Soyoung Youn <sy01.youn@samsung.com>
(cherry picked from commit e219efd2f099557895748f081c284868c837621b)
Reviewed-on: https://gerrit.iotivity.org/gerrit/199
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix some issues of GroupManager

    - subscribeCollectionPresence()
        - IOT-197 : Handle null parameter
        - IOT-198 : Check that resource has child resource.
    - findCandidateResources()
        - IOT-210 : Handle null parameter

Change-Id: I6961aa776e5883890da226f07d3cfcf64571279c
Signed-off-by: Jack Lee <jjack.lee@samsung.com>
(cherry picked from commit be736343b6afaadba39bcfd64f2b6a50a9a83858)
Reviewed-on: https://gerrit.iotivity.org/gerrit/198
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

fix "Coding convention followed in this commit"

Change-Id: Icf3085cc5767330c908ab02c855759ad004509a2
Signed-off-by: Heewon Park <h_w.park@samsung.com>
(cherry picked from commit d59e8dcabe4a7829dbd529d7b24f44145ce0d008)
Reviewed-on: https://gerrit.iotivity.org/gerrit/197
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

This a complete version of OICMiddle.
The ReST capability has limited functionality, which we hope to expand
shortly after release.  We believe the other parts of OICMiddle are
sufficiently robust that the application will be useful as both demo
and example in the OIC 0.9.0 release.

In a partial review prior to moving from 01.org to IoTivity, one
reviewer provided 50 comments.  All of the comments were addressed,
though not all were agreed with.  In some cases, comments were added
to the code to address the concern.  Others may require further
discussion.

Change-Id: I3e52de09a0737dd8dd0323fa2a20e4c94224f9c7
Signed-off-by: John.Light <john.j.light@intel.com>
Signed-off-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit 87f7589e62489e9a100fe11fa418f8ab120e2f44)
Reviewed-on: https://gerrit.iotivity.org/gerrit/196
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Updated the README files to reference the master build in root

Change-Id: Ibeb95e7a872ca51e29656a825c37247e48d89fe5
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit 6db91505bfc2c877c3bf0a41b187c1db58e2619d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/195
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Added build dependencies script

Created build script that prepares two dependencies (cereal and
boost) for use by the build environment. This also adds the
dependency builder in the auto build script used by the continuous
integation servers.

Change-Id: I776a3b3f208b1ea0c253cc693d639c19b603fbca
Signed-off-by: Patrick Lankswert <patrick.lankswert@intel.com>
(cherry picked from commit 93e87e9959d536120bedd47a837603418743cc6d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/194
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Add missing dependency to readme.

Change-Id: I86cf5280edbe70dfa5c8f0076c9475ee18e5ab0b
Signed-off-by: Sanjeev BA <as2902.b@samsung.com>
(cherry picked from commit 59a91fe583495f14e05c7c7567d4f2241c9b4498)
Reviewed-on: https://gerrit.iotivity.org/gerrit/191
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

OICSensorBoard: App for Intel Edison Platform.

(Please refer to https://oic-review.01.org/gerrit/#/c/668/8/
for prior review status)

Build for OICSensorBoard is NOT included in the
standard Iotivity build.

It requires the Yocto cross-toolchain for
a chosen target, and would therefore be
built separately.

It demonstrates Iotivity Server capabilities through
the integration of an add-on breadboard that hosts
temperature, ambient light and LED sensors.
In addition, there is a command-line Iotivity Client
application to test server functionality from a
separate machine.

The included scons build script expects to build
the client for Linux (tested on Ubuntu 12.04)
and the server to be built via the Yocto
cross-toolchain for Edison.

Brief instructions for constructing this
toolchain are provided in the included README.

Change-Id: I26d12c2334d84a6e0245e0f3689e09a51152fea5
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
(cherry picked from commit 7cd6e2214c0eb9a70ac8cb94b38f9dc682a6691e)
Reviewed-on: https://gerrit.iotivity.org/gerrit/182
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed prevent and klock work issues reported.

Static analysis reported issues are fixed in this commit.

Change-Id: I1c4cefe46650a2acaafb374fbb04ca1936434ab4
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/179
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Scons Script Changes for disabling debug for release mode

Scripts also changed to take current Iotivity structure changes

Change-Id: I589082e9675d99aa9dd6cc1bace26e11b1210510
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/178
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix soft-sensor-manager service build errors

Change-Id: I96bd2463fe5f0fd9fd09d5b31570c0bc778019a7
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
(cherry picked from commit dc999011a116251a2275b18baddbad61a827a4bc)
Reviewed-on: https://gerrit.iotivity.org/gerrit/181
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fixed issue with HeaderOptions not correctly being sent

If HeaderOptions count was greater than 1, the sender side did not correctly
allocate and copy the memory for it, resulting in the second headeroption being
an invalid read/copy, thus resulting in garbage data in the second HeaderOption.

This fix ensures that ALL header option data is correctly copied.  Validation
shows that the rst of the stack is working properly, so the correct data will
be transferred.

Change-Id: I08d9ccf8943bf7e85f6d24055b5f11881ba2bd24
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/153
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: Ashok Babu Channa <ashok.channa@samsung.com>

Fixed klockwork memory leaks and modified the logs

[IoT 252] CAGenerateToken creates the same token if it
is called less than 500 milli seconds
Removed un-necessary files and added more test cases
Updated for compilation warning and klockwork fixes

Change-Id: I3710e92e9609441affcb40f10f92ef60f8d9f236
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/151
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Add spec file for Tizen build

Change-Id: I9d70f69b174c1fedad12116c2dba75f84773e50b
Signed-off-by: sudarshan prasad <sudarshan.prasad@intel.com>
(cherry picked from commit 1e7452670814663e4c74500956ce5661bbcedfa8)
Reviewed-on: https://gerrit.iotivity.org/gerrit/174
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Fix android build compatibility problems

1. Some C++11 features are used in IoTivity. Old Android NDK may doesn't
support a part of these features directly. Implement and include it if
it is required.

2. Fix libc function missing problem. Some functions, e.g. rand, srand.
strtof ... are static inline prior to android-L(it is defined and
implemented in the header file). So before android-L libc.so doesn't
include them. If build on android-L and run on an old platform(earlier
than android-L), there will be 'can't locate xxx' problem.

e.g.:
rand, it is defined in stdlib.h as "static __inline__ int rand() { ....} in
the ndk < 10. it's defined as 'extern int rand();' from ndk-10x. With old
ndk, if a file (x.c) used 'rand' function, when build x.c, 'rand' is compiled
into x.o. 'rand' won't exit in neither libc.so nor libc.a. If build an
application with ndk-10x and run it on emulator or device(developed with
NDK < 10), it requires implement 'rand' function by owerself or there
will be be 'can't locate rand' problem.

For convenience, add these functions in a file, if necessary, build it as
library and auto link into binary.

Change-Id: If47da94db7d06fde9887eba335bc0c67762514a9
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
(cherry picked from commit f56a9ad5a7c86609cf8895e8a579fb192f0ebfdb)
Reviewed-on: https://gerrit.iotivity.org/gerrit/175
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

API for DTLS registration and Scon script addition

A new API is added for DTLS credential registration.
SCons scripts for connectivity abstraction with secured flag.
Different platforms with secured flag ==1 can be built with modifications.

Change-Id: I6a94ce27eb8c2cdd62899b7810ebbec35b3cf385
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/145
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Tizen, Android BT , BLE optimization - making similar to wifi, eth adapters

For adapting new platforms at adapter level , common logic is added for each adapter.
Platform related calls are divided into client, server and network monitor.

Change-Id: I0086619ae5207e79fee08a6776bbc1a033ac6f44
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/143
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

IoT-243 Connectivity Abstraction single-threaded module missing definition for CASendRequestToAll().

IoT-161 PCF Command is not used in OIC_LOG() calls under the connectivity directory.

Updated documentation and few memory leaks .

Change-Id: I10db0f4e2c50cbe1ace726a0577905ea52afcf3f
Signed-off-by: Ashok Channa <ashok.channa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/142
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Added services programmer's guides without DRM for June Young

Change-Id: Ifa7b359cabae84d3dcd1b48feac3fe7b4423af69
Signed-off-by: George Bowden <george.bowden@intel.com>
(cherry picked from commit 943e9632dbe422c43c707c3bb9adabc0c7fd4627)
Reviewed-on: https://gerrit.iotivity.org/gerrit/173
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Update scons build relative documents

Change-Id: I5296365d941d876ec20252282f8bae1cb5d8b7ff
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
(cherry picked from commit ad40c3bbcf0830033de0f312ebcf6ea2f61cd7ad)
Reviewed-on: https://gerrit.iotivity.org/gerrit/172
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Remove DRM doc

Change-Id: Icc34f18a66d87ae74748e496c3f01ff94ae84aa9
Signed-Off-By:Sudarshan Prasad <sudarshan.prasad@intel.com>
(cherry picked from commit f408ac1506923ea6fcaaa3f61659b69374bc4675)
Reviewed-on: https://gerrit.iotivity.org/gerrit/170
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

CA: Enable Building C++ Samples, remove hardcoded connectivity type

Modifying the C++ examples SConscript to build samples.
Modifying C++ samples to remove hard coded Connectivity Type.
Instead, accepting it as command line argument from the user.
Remove hard coded Multicast URl. Instead, added URLs for CA
in ocstack.h .

Change-Id: If7c16ae75ec9aa492f4d523cf382eb0f9930c417
Signed-off-by: omkar <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/148
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

remove DRM doc

Change-Id: Idd96a81cd79d1b6c54776c6b39cb080743107f8f
Signed-Off-By:Sudarshan Prasad<sudarshan.prasad@intel.com>
(cherry picked from commit eac0042ba862d7f370d4e4bc03830acb5097ae30)
Reviewed-on: https://gerrit.iotivity.org/gerrit/169
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>

Remove the magic number

Remove the magic number 4 in the CA branch code.

Change-Id: I6fdc81e5a06a2ebdca5245bbf056f5a3d6f36ed4
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/162
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sashi Penta <sashi.kumar.penta@intel.com>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix GroupAction API of Things Manager.

Crash is occurred when some api of ThingsManager is called
with null ocresource or null actionset.
It will return OC_STACK_ERROR, if ocresource or actioset is null.

Fix [IOT-199], [IOT-200], [IOT-201], [IOT-202]

Change-Id: I1bf1070caaa4d06aad21aa26011474aae263a544
Signed-off-by: HyunJun Kim <hyunjun2.kim@samsung.com>
(cherry picked from commit d2a9360615f1e0818f9b386c6d5b8321bd04d5c4)
Reviewed-on: https://gerrit.iotivity.org/gerrit/166
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Fix an exception handling issue in doBootStrap() function of
ThingsConfiguration class.

In the case that a callback pointer of the function is NULL,
a return value for the function call will be OC_STACK_ERROR
rather than OC_STACK_OK.

Reference issue ID : [IOT-196]

Change-Id: Ieb280bc6e5317496b96342a0374129c1e692b415
Signed-off-by: jihun.ha <jihun.ha@samsung.com>
(cherry picked from commit f3344c1e09c42722c023a1ae3940496e2025a97d)
Reviewed-on: https://gerrit.iotivity.org/gerrit/165
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sudarshan Prasad <sudarshan.prasad@intel.com>

Merge "Fix build warnings" into connectivity-abstraction

Fix build warnings

Fix non-token build warnings in the stack.
The token related build warnings are fixed in a separate commit.

Change-Id: Ie43db965df3c434fc5a75b5949322505532bf796
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>

Fixed build issue in csdk samples

Fixed build issue in csdk samples scons script

Change-Id: Ibdc7cba19f295f262c35d8778beabbfc72f446b1
Signed-off-by: Yuliya Kamatkova <yuliya.kamatkova@intel.com>

Merge "C++ SDK Adding OCConnectivity Type" into connectivity-abstraction

C++ SDK Adding OCConnectivity Type

Previously, we had connectivity type being passed as a
unsigned integer in the C++ SDK. Changing that to
OCConnectivity type.

Change-Id: I5f1690cc0295a2448515d7681a792eb6f6f5811c
Signed-off-by: omkar <omkar.m.hegde@intel.com>

Enable building C Samples using scons

Enable building C Samples using scons on CA Branch.
Added third party conditional check for glib-2.0.

Change-Id: Iecaf20645c9d7881021bacc54c756c9d5559f3b6
Signed-off-by: Sashi Penta <sashi.kumar.penta@intel.com>
Signed-off-by: Yamin Al-Mousa <yamin.s.al-mousa@intel.com>