David Mitchell [Wed, 13 Nov 2013 17:30:10 +0000 (17:30 +0000)]
Opcode: fix 'null argument' warning
HvNAME_get() can return NULL, and strNE() wants non-null args.
[
As a side note: on debugging builds this line
if (strNE(HvNAME_get(hv),"main")) {
macro-expands into an 18,000 character line (!) due to the fact that
HvNAME_get() is quite a big expansion under debugging, and strNE expands to
strlen, which under gcc expands to a huge macro (which is mainly lots of
different compile-time alternatives depending on which of its args are
constants), that references its args several times.
]
David Mitchell [Wed, 13 Nov 2013 16:48:11 +0000 (16:48 +0000)]
IO.xs: fix compiler warning
PerlIO_unread() returns SSize_t, although from its sparse documentation
it doesn't seem that it would ever return a negative value. So cast away
the 'comparison between signed and unsigned integer' warning.
David Mitchell [Wed, 13 Nov 2013 15:01:40 +0000 (15:01 +0000)]
File::Glob: fix warnings and non-\0-ended strings
The lower levels of File::Glob expect null-terminated strings, while
the higher levels do s = SvPV(sv,len) and pass the len. Ease the impedance
mismatch by ensuring that s[len] is always \0. Most perl SVs will already
have that \0 anyway, so in practice this hasn't been an issue.
It also ignores the utf8-ness of the string. I've kept that as-is (too big
a can of works to open for now), but I've fixed the 'is_utf8 var not used'
warning and added an XXX comment instead.
David Mitchell [Wed, 13 Nov 2013 12:33:40 +0000 (12:33 +0000)]
File::Glob: silence some compiler warnings
In bsd_glob.c, there are nested set of functions glob0(), glob1() etc,
which among their parameters pass a pointer to a compiled pattern, and also
to its end. It turns out the end pointer isn't usually used, since the
pattern is usually scanned for BG_EOS instead. Also, glob3() is
passed two pattern ranges, both within the same pattern, and both with
the same pointer to the end of the pattern buffer. Since both end pointers
are the same, eliminate one of them. This removed an unused var compiler
warning. Use the remaining end pointer in the glob*() functions to add
assertions that we haven't fallen off the end of the buffer.
Finally, ARG_MAX may be signed.
Karl Williamson [Wed, 13 Nov 2013 17:25:57 +0000 (10:25 -0700)]
podcheck: Remove workaround no longer needed
The bug this worked around has been fixed by
406e3fef7f4bebd2003087bce74d22303981ac48
David Mitchell [Tue, 12 Nov 2013 16:11:33 +0000 (16:11 +0000)]
Devel::Peek: fix some compiler warnings
David Mitchell [Tue, 12 Nov 2013 16:02:12 +0000 (16:02 +0000)]
arybase: silence some compiler warnings
some of the static functions in ptable.h are unused. It looks
like ptable.h has been written to be more general-purpose and reusable,
but at the moment its only used in one place, so '#if 0' the unused
functions for now, to shut up the compiler..
David Mitchell [Tue, 12 Nov 2013 16:00:35 +0000 (16:00 +0000)]
File-DosGlob: silence some compiler warnings
David Mitchell [Tue, 12 Nov 2013 15:55:38 +0000 (15:55 +0000)]
B: silence some compiler warnings
The renaming of the 'form' arg to 'format' is due to form being #deffed to
Perl_form() or similar.
Some of the unused vars were due to things like BmPREVIOUS() being #deffed
to 0 in recent builds.
The pad ones were due to the PADOFFSET type being used to index a pad
*list*, not a pad - that's SSize_t.
David Mitchell [Tue, 12 Nov 2013 15:54:40 +0000 (15:54 +0000)]
DynaLoader: silence some compiler warnings
David Mitchell [Tue, 12 Nov 2013 15:51:21 +0000 (15:51 +0000)]
silence some compiler warnings
Actually, most of this commit is adding (void) to various function returns
where we know its ok to ignore the return value. This doesn't actually
silence the -Wunused-result warning (thanks a bundle gcc), but at least
it marks our intentions.
David Mitchell [Tue, 12 Nov 2013 15:39:04 +0000 (15:39 +0000)]
fix definition of GvFILEGV()
It was:
#define GvFILE(gv) (GvFILE_HEK(gv) ? HEK_KEY(GvFILE_HEK(gv)) : NULL)
#define GvFILEGV(gv) (gv_fetchfile(GvFILE(gv)))
which is a problem, since gv_fetchfile() doesn't accept a non-null
argument. Change it so that the (cond ? foo : NULL) thing is outside
gv_fetchfile(). This is all a bit academic since GvFILE_HEK should never
be null, but it at least it shuts up a compiler warning.
Chris 'BinGOs' Williams [Wed, 13 Nov 2013 00:33:27 +0000 (00:33 +0000)]
Update Test-Harness to CPAN version 3.30
[DELTA]
3.30 2013-11-12
- Fix missing parent prereq in META.{yml,json} and NotBuild.PL
(Dagfinn Ilmari Mannsåker, #89650)
- Respect PERL5LIB in tainting source handler test (Dagfinn Ilmari Mannsåker,
Leon Timmermans)
- Use base instead of parent:
This dist is used for testing all other modules, so it should avoid
having any non-core prerequisites. Having parent as a prereq leads to a
circular dependency of parent -> Test::More -> Test::Harness. (Graham Knop)
- Various POD fixes (Nathan Gary Glenn)
- Don't localize all of %ENV in harness.t (Craig Berry)
- Give TAP::Harness::Beyond a unique NAME (Leon Timmermans)
Father Chrysostomos [Tue, 12 Nov 2013 22:45:39 +0000 (14:45 -0800)]
Another perldelta to-do
Father Chrysostomos [Tue, 12 Nov 2013 22:44:47 +0000 (14:44 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 22:43:15 +0000 (14:43 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 22:43:00 +0000 (14:43 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 22:35:36 +0000 (14:35 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 22:33:20 +0000 (14:33 -0800)]
Another perldelta to-do
that I don’t understand well enough to explain
Father Chrysostomos [Tue, 12 Nov 2013 22:32:37 +0000 (14:32 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 22:28:26 +0000 (14:28 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 22:26:07 +0000 (14:26 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 22:23:44 +0000 (14:23 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 20:55:57 +0000 (12:55 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 20:54:52 +0000 (12:54 -0800)]
Chris 'BinGOs' Williams [Tue, 12 Nov 2013 16:28:12 +0000 (16:28 +0000)]
Update Module-Build to CPAN version 0.4200
[DELTA]
0.4200 - Tue Nov 12 12:39:25 CET 2013
- Released 0.40_11 as 0.4200
0.40_11 - Wed Nov 6 12:46:59 CET 2013
[BUG FIXES]
- Do not set provides in metadata if no_index is set [Leon Timmermans]
0.40_10 - Tue Nov 5 12:11:37 CET 2013
[BUG FIXES]
- Lowercase license in fallback logic [Leon Timmermans]
0.40_09 - Tue Nov 5 00:13:11 CET 2013
[ENHANCEMENTS]
- Converted to using Meta 2.0
Father Chrysostomos [Tue, 12 Nov 2013 13:58:27 +0000 (05:58 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:54:36 +0000 (05:54 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:51:21 +0000 (05:51 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:48:14 +0000 (05:48 -0800)]
perldelta: potential to-do item
I don’t understand this commit enough to know whether it warranst
inclusion, let alone to write a description for it.
Father Chrysostomos [Tue, 12 Nov 2013 13:46:34 +0000 (05:46 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:44:38 +0000 (05:44 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:42:06 +0000 (05:42 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:39:43 +0000 (05:39 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:36:21 +0000 (05:36 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:33:10 +0000 (05:33 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:31:40 +0000 (05:31 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:16:02 +0000 (05:16 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:14:57 +0000 (05:14 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:04:14 +0000 (05:04 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:03:29 +0000 (05:03 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 13:00:55 +0000 (05:00 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 06:16:41 +0000 (22:16 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 06:11:47 +0000 (22:11 -0800)]
perldelta for
8cece9139ae
Father Chrysostomos [Tue, 12 Nov 2013 02:03:05 +0000 (18:03 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 01:58:53 +0000 (17:58 -0800)]
Father Chrysostomos [Tue, 12 Nov 2013 01:56:31 +0000 (17:56 -0800)]
perldelta: put things in the right sections
I could have sworn I had them in the right place. I think git’s
ability to merge changes can be fooled.
Father Chrysostomos [Mon, 11 Nov 2013 21:39:24 +0000 (13:39 -0800)]
Father Chrysostomos [Mon, 11 Nov 2013 21:35:40 +0000 (13:35 -0800)]
Father Chrysostomos [Mon, 11 Nov 2013 20:54:53 +0000 (12:54 -0800)]
Father Chrysostomos [Mon, 11 Nov 2013 20:53:46 +0000 (12:53 -0800)]
Father Chrysostomos [Mon, 11 Nov 2013 20:48:29 +0000 (12:48 -0800)]
Father Chrysostomos [Mon, 11 Nov 2013 20:41:44 +0000 (12:41 -0800)]
Father Chrysostomos [Mon, 11 Nov 2013 20:35:01 +0000 (12:35 -0800)]
Father Chrysostomos [Mon, 11 Nov 2013 05:41:49 +0000 (21:41 -0800)]
In newATTRSUB, clear glob slot before lowering refcount.
(Actually in its subroutine, S_already_defined.)
Otherwise, when newATTRSUB redefines a sub, the previous sub’s DESTROY
can see the same sub still in the typeglob, but without a reference
count, so *typeglob = sub {} frees the sub currently in $_[0].
$ perl5.18.1 -le '
sub foo{}
bless \&foo;
DESTROY {
print "before: $_[0]"; *foo=sub{}; print "after: $_[0]"
}
eval "sub foo{}";
'
before: main=CODE(0x7fa88382d6d8)
before: main=CODE(0x7fa88382d6d8)
after: main=CODE(0x7fa88382d6d8)
after: UNKNOWN(0x7fa88382d6d8)
Father Chrysostomos [Sun, 10 Nov 2013 14:26:39 +0000 (06:26 -0800)]
In newXS, clear glob slot before lowering refcount.
Otherwise, when newXS redefines a sub, the previous sub’s DESTROY can
see the same sub still in the typeglob, but without a reference count,
so *typeglob = sub {} frees the sub currently in $_[0].
$ perl5.18.1 -le '
sub re::regmust{}
bless \&re::regmust;
DESTROY {
print "before: $_[0]"; *re::regmust=sub{}; print "after: $_[0]"
}
require re;
'
before: main=CODE(0x7ff7eb02d6d8)
before: main=CODE(0x7ff7eb02d6d8)
after: main=CODE(0x7ff7eb02d6d8)
after: UNKNOWN(0x7ff7eb02d6d8)
Father Chrysostomos [Sun, 10 Nov 2013 20:04:51 +0000 (12:04 -0800)]
Undeffing a gv in DESTROY triggered by undeffing the same gv
$ ./perl -Ilib -e 'sub foo{} bless \&foo; DESTROY { undef *foo } undef *foo'
Attempt to free unreferenced glob pointers, Perl interpreter: 0x7fd6a3803200 at -e line 1.
Lowering the reference count on the glob pointer only after freeing
the contents fixes this.
Father Chrysostomos [Sun, 10 Nov 2013 13:24:42 +0000 (05:24 -0800)]
Simplify code for deparsing socketpair
Instead of fixing a typo programmatically, just spell it correctly to
begin with. This should make things just slightly faster.
Daniel Dragan [Mon, 4 Nov 2013 08:18:58 +0000 (03:18 -0500)]
check existence of headers and libs for WinCE in Makefile.ce
Macro LIBC was used since day 1 of WinCE port (commit
e1caacb4fd ), but
never before defined. On Desktop Win32 Perl, LIBC is msvcrt.lib, so fix
corelibc/msvcrt to be LIBC and not part of CELIBS. Then use LIBC in a
sanity check. Sanity checks will give an error message, vs running the
C compiler and geting cryptic messages about unknown .hs and random
missing symbols.
David Mitchell [Thu, 7 Nov 2013 12:17:26 +0000 (12:17 +0000)]
fix chop formats with non PV vars
[perl #119847], [perl #119849], [perl #119851]
Strange vars like ties, overloads, or stringified refs (and in recent
perls, pure NOK vars) would generally do the wrong thing in formats
when the var is treated as a string and repeatedly chopped, as in
^<<<~~ and similar. This would manifest itself in infinite loops, utf8
errors etc. A recent change that stopped a stringified NOK getting
converted into a POK made the same badness happen for plain NVs too.
This commit contains two main fixes. First, the chopping was done
using sv_chop(), which only worked on POK strings. If its !POK, we now do
sv_setpvn() instead, which is less efficient, but will ensure the right
thing is always done.
Secondly, we make sure that the sv is accessed only once per cycle,
doing s = SvPV(sv, len) or similar. After that, all access is done only
via s and len. One place was using SvPVX(sv), and several places
were using the sv for utf8<->byte length conversions, such as
sv_pos_b2u().
It turns out that all the complex utf8 handling could be enormously
simplified. Since the code that needed to do utf8/byte length conversions
already scanned the string looking for suitable split points (such as
spaces or \n or \r), it was easiest to include any utf8 processing in the
same loop - i.e. incrementing s by UTF8SKIP(s) each time, but incrementing
the character count by 1.
The original diagnosis and reporting of this issue was done by Nicholas
Clark, who also supplied most of the tests.
David Mitchell [Wed, 30 Oct 2013 15:06:53 +0000 (15:06 +0000)]
pp_formline(): document switch cases
The individual ops (such as FF_END) of the format bytecode are documented
in form.h; appned those descriptive texts also to the individual 'case
FF_END:' lines in pp_formline, to make navigation easier. Also ensure
there's a blank line before each 'case'.
No functional changes.
H.Merijn Brand [Mon, 11 Nov 2013 10:07:10 +0000 (11:07 +0100)]
Synology support now more explicit
Johan Vromans tested the changes on DS413. The changes I added before
are more Synology specific (though perhaps not only appropriate for
Synology) but at least wider than just armv5tel
Tony Cook [Wed, 18 Sep 2013 05:55:12 +0000 (15:55 +1000)]
[perl #75156] fix the return value and bits for removing a closed fh
Tony Cook [Wed, 18 Sep 2013 05:20:19 +0000 (15:20 +1000)]
[perl #75156] tests for deleting a closed handle from IO::Select
Daniel Dragan [Fri, 8 Nov 2013 02:33:57 +0000 (21:33 -0500)]
fix multi-eval of Perl_custom_op_xop in XopENTRY
Commit
1830b3d9c8 introduced a flaw where XopENTRY calls
Perl_custom_op_xop twice to retrieve the same XOP *. This is inefficient
and causes extra machine code. Since I found no CPAN or upstream=blead
usage of Perl_custom_op_xop, and its previous docs say it isn't 100%
public, it is being converted to a macro.
Most usage of Perl_custom_op_xop is to conditionally fetch a member of the
XOP struct, which was previously implemented by XopENTRY. Move the XopENTRY
logic and picking defaults to an expanded version of Perl_custom_op_xop.
The union allows Perl_custom_op_get_field to return its result in 1
register, since the union is similar to a void * or IV, but with the
machine code overhead of casting, if any, being done in the callee
(Perl_custom_op_get_field), not the caller. Perl_custom_op_get_field can
also return the XOP * without looking inside it to implement
Perl_custom_op_xop.
XopENTRYCUSTOM is a wrapper around Perl_custom_op_get_field with
XopENTRY-like usage.
XopENTRY is used by the OP_* macros, which are heavily used (but rarely
called, since custom ops are rare) by Perl lang warnings system. The
vararg warning arguments are usually evaluted no matter if the warning
will be printed to STDERR or not. Since some people like to ignore warnings
or run no strict; and warnings branches are frequent in pp_*, it is
beneficial to make the OP_* macros smaller in machine code. The design
of Perl_custom_op_get_field supports these goals.
This commit does not pass judgement on Ben Morrow's unclear public or
private API designation of Perl_custom_op_xop, and whether
Perl_custom_op_xop should deprecated and removed from public API. It was
trivial to leave a form of Perl_custom_op_xop in the new design.
XOPe enums are identical to XOPf constants so no conversion has to be
done between the field selector parameter and the field flag to test
in machine code.
ASSUME and NOT_REACHED are being introduced. The closest to the 2
previously was "assert(0)". Perl has not used ASSUME or CC specific
versions of it before. Clang, GCC >= 4.5, and Visual C are supported. For
completeness, ARMCC's __promise was added, but Perl is not known to have
any support for ARMCC by this commiter.
This patch is part of perl #115032.
Chris 'BinGOs' Williams [Sun, 10 Nov 2013 11:09:07 +0000 (11:09 +0000)]
Update Unicode-Collate to CPAN version 1.02
[DELTA]
1.02 Sun Nov 10 18:39:37 2013
- POD: fix [rt.cpan.org #90170] about iso-8859-1 letters in pod.
E<> is used for the compatibility with perl 5.6.1 and possibly EBCDIC.
- 1.01 forgot to increase the version number of CJK/Korean.pm.
- modified tests: cjkrange.t, compatui.t, hangtype.t, illegal.t,
loc_ja.t, loc_ta.t, overcjk0.t, overcjk1.t, view.t in t.
Father Chrysostomos [Sun, 10 Nov 2013 05:44:26 +0000 (21:44 -0800)]
op.c: Factor out common entersub-building code
This same incantation occurs four times, though the readpipe variant
was slightly different. The only difference was the lack of a scalar
flag on a null op, which makes no difference:
- <1> ex-rv2cv sK ->-
5 <$> gv(*require) s ->6
- <1> ex-rv2cv K ->-
5 <$> gv(*readpipe) s ->6
So I did not include the scalar() call, as it was unnecessary. Also,
I changed op_append_elem to newLISTOP, since the former calls the lat-
ter anyway in these cases.
Father Chrysostomos [Sun, 10 Nov 2013 05:15:32 +0000 (21:15 -0800)]
Fix deparsing of glob(my $x) and CORE::glob
A git bisect run like this:
$ ../perl.git/Porting/bisect.pl --start=v5.12.0 --end=v5.18.0 -e 'use B::Deparse; die if new B::Deparse->coderef2text(sub{glob my $x}) =~ /</'
points to v5.13.8-86-gd1bea3d as being the commit that cause it to
output <my $x>.
But my local 5.14.4 installation still outputs glob(my $x), so I am
not sure which commit is responsible. I suspect it changed multi-
ple times.
In any case, B::Deparse was expecting the argument to pp_glob always
to be a string, which is certainly not guaranteed.
This commit also causes CORE::glob to be deparsed correctly. glob is
one of those oddities like require that gets only half-overridden by
overrides. In this particular case the built-in pp_glob is still
used, but takes a different code path depending on whether it was pre-
fixed with CORE::. So, while glob is a strong keyword, it needs to be
treated as a weak one for deparsing purposes.
Father Chrysostomos [Sat, 9 Nov 2013 21:44:27 +0000 (13:44 -0800)]
Stop open fh, ">>", \$undef from warning
$ ./perl t/TEST ../cpan/Test-Simple/t/subtest/bail_out.t
t/../cpan/Test-Simple/t/subtest/bail_out ... Use of uninitialized value in open at /Users/sprout/Perl/perl.git-copy/cpan/Test-Simple/../../lib/Test/Builder.pm line 1895.
ok
All tests successful.
u=0.01 s=0.00 cu=0.09 cs=0.01 scripts=1 tests=2
Notice the uninitialized value.
$ ./perl -Ilib -Mwarnings=uninitialized -e 'open $fh, ">>", \$x'
Use of uninitialized value $x in open at -e line 1.
$ perl5.18.1 -Mwarnings=uninitialized -e 'open $fh, ">>", \$x'
I caused that in v5.19.5-44-g5a2bc23:
$ ../perl.git/Porting/bisect.pl --start=
045071eede --end=blead -e 'use warnings FATAL=>"uninitialized"; open $fh, ">>", \$x'
...
5a2bc23bfe5dc60ff957cb44ffaa57668d56d238 is the first bad commit
commit
5a2bc23bfe5dc60ff957cb44ffaa57668d56d238
Author: Father Chrysostomos <sprout@cpan.org>
Date: Fri Oct 25 06:15:30 2013 -0700
Better fix for #119529
Father Chrysostomos [Sat, 9 Nov 2013 21:40:04 +0000 (13:40 -0800)]
op.c: Remove unused var
From
2186f87343.
Father Chrysostomos [Sat, 9 Nov 2013 21:22:43 +0000 (13:22 -0800)]
perldiag: Two minor tweaks
One typo and one copy-and-paste error.
Karl Williamson [Thu, 31 Oct 2013 16:14:55 +0000 (10:14 -0600)]
perl.c: White space only
Properly indent a few lines
Karl Williamson [Fri, 8 Nov 2013 16:11:49 +0000 (09:11 -0700)]
numeric.c: White-space only
Properly indent the branch of an 'if'.
Karl Williamson [Thu, 7 Nov 2013 19:22:48 +0000 (12:22 -0700)]
regexec.c: Fix compiler warning
We add an #ifdef DEBUGGING around a variable declaration, as that
variable actually only gets used in DEBUGGING compiles.
David Mitchell [Fri, 8 Nov 2013 16:55:28 +0000 (16:55 +0000)]
make perl core quiet under -Wfloat-equal
The gcc option -Wfloat-equal warns when two floating-point numbers
are directly compared for equality or inequality, the idea being that
this is usually a logic error, and that you should be checking that the
values are instead very near to each other.
perl on the other hand has lots of reasons to do a direct comparison.
Add two macros, NV_eq_nowarn(a,b) and NV_eq_nowarn(a,b)
that do the same as (a == b) and (a != b), but without the warnings.
They achieve this by instead doing (a < b) || ( a > b).
Under gcc at least, this is optimised into the same code as the direct
comparison.
The are three places that I've left untouched, because they are handling
NaNs, and that gets a bit tricky. In particular (nv != nv) is a test for a
NaN, and replacing it with (< || >) creates signalling NaNs (whereas ==
and != create quiet NaNs)
David Mitchell [Sat, 9 Nov 2013 12:14:37 +0000 (12:14 +0000)]
porting/diag.t: restrict what's a warn function
add a couple of judicious \b's so that while warn() etc are seen
as calls to a warn-related function, this_is_not_a_warn() etc aren't.
This is needed for the next commit which will introduce the macro
NV_ne_nowarn().
Father Chrysostomos [Sat, 9 Nov 2013 05:44:18 +0000 (21:44 -0800)]
perldiag: Remove ‘The %s feature...’
The idea when this was added was for ‘use feature’ to warn when
an experimental feature was enabled. Things didn’t turn out that
way. Only lexical subs follow that wording, and they have their
own entry in perldiag, so this one is unnecessary.
Father Chrysostomos [Sat, 9 Nov 2013 05:42:12 +0000 (21:42 -0800)]
toke.c: Remove unnecessary assignment
LOP returns, so the value of orig_keyword is not used after this.
Father Chrysostomos [Sat, 9 Nov 2013 01:58:49 +0000 (17:58 -0800)]
[Merge] Make &CORE:: subs respect vmsish hints
Most lexical hints are stored in the statement’s nextstate(ment)
op (aka cop or control op). That op is available at run time as
PL_curcop, while the current op being executed is PL_op.
&CORE:: subs intentionally lack a nextstate op so they can see the
hints in the caller’s nextstate op.
Two vmsish hints were being stored in the current op, so &CORE::exit()
would not respect those hints, as &CORE::exit() executes the *same*
exit op each time.
This branch moves those hints to the nextstate op, so that &CORE::exit
behaves the same way as exit().
Father Chrysostomos [Sun, 3 Nov 2013 00:28:48 +0000 (17:28 -0700)]
Make &CORE::exit respect vmsish exit hint
by removing the hint from the exit op itself and just having pp_exit
look in the cop hint hash, where it is already stored (as a result of
having been in %^H at compile time).
&CORE:: subs intentionally lack a nextstate op (cop) so they can see
the hints in the caller’s nextstate op.
Father Chrysostomos [Sat, 9 Nov 2013 01:46:17 +0000 (17:46 -0800)]
Update dump.c for the exit->nextstate hush hint move
Father Chrysostomos [Thu, 7 Nov 2013 14:02:46 +0000 (06:02 -0800)]
Update B::Concise for the exit->nextstate hush hint move
Father Chrysostomos [Thu, 7 Nov 2013 13:56:19 +0000 (05:56 -0800)]
Fix &CORE::exit/die under vmsish "hushed"
This commit makes them behave like exit and die without the ampersand
by moving the OPpHUSH_VMSISH hint from exit/die op to the current
statement (nextstate/cop) instead. &CORE:: subs intentionally lack a
nextstate op, so they can see the hints in the caller’s nextstate op.
Father Chrysostomos [Sun, 3 Nov 2013 00:10:37 +0000 (17:10 -0700)]
Teach B::Concise about VMS hushed flag
Father Chrysostomos [Sat, 2 Nov 2013 05:00:35 +0000 (22:00 -0700)]
Failing tests for &CORE::exit/die with vmsish
Father Chrysostomos [Sat, 9 Nov 2013 01:41:31 +0000 (17:41 -0800)]
Fix pod screwup in
a05ea1cf8be
Thanks to Daniel Dragan for pointing it out.
Father Chrysostomos [Fri, 8 Nov 2013 21:13:29 +0000 (13:13 -0800)]
Long verbatim pod line in INSTALL
Father Chrysostomos [Fri, 8 Nov 2013 21:04:19 +0000 (13:04 -0800)]
Consistent spaces after dots in sv.c apidocs
Daniel Dragan [Fri, 8 Nov 2013 10:38:51 +0000 (05:38 -0500)]
POD-only mention sv_setsv does get magic but not set magic
Father Chrysostomos [Fri, 8 Nov 2013 14:04:20 +0000 (06:04 -0800)]
Warn for all uses of %hash{...} in scalar cx
and reword the warning slightly.
See <
20131027204944.20489.qmail@lists-nntp.develooper.com>.
To avoid getting a warning about scalar context for ‘delete %a[1,2]’,
which dies anyway, I stopped scalar context from being applied to
delete’s argument. Scalar context is not meaningful here anyway, and
the context is not really scalar.
This also means that ‘delete sort’ no longer produces a warning about
scalar context before dying, so I added a test for that.
Father Chrysostomos [Thu, 7 Nov 2013 13:33:24 +0000 (05:33 -0800)]
Make _charnames comparison null-safe
This comparison in toke.c checks whether the charnames translators is
the core’s own and, if so, skips certain validation checks.
Charnames translators coming from any package beginning with
"_charnames\0" would also be exempt from the checks, because the name
comparison stopped at the first null.
Father Chrysostomos [Thu, 7 Nov 2013 00:18:48 +0000 (16:18 -0800)]
Stop lexical CORE sub from interfering with CORE::
The way CORE:: was handled in the lexer was convoluted.
CORE was treated initially as a keyword, with exceptions in the lexer
to make it behave correctly. If it turned out not to be followed
by ::, then the lexer would fall back to treating it as a bareword
or sub name.
Before even checking for a keyword, the lexer looks for :: and goes
to the bareword/sub code. But it made a special exception there
for CORE::.
In the end, treating CORE as a keyword recognized by the keyword()
function requires more special cases than simply special-casing CORE::
in toke.c.
This fixes the lexical CORE sub bug, while reducing the total num-
ber of lines.
Father Chrysostomos [Wed, 6 Nov 2013 18:55:36 +0000 (10:55 -0800)]
toke.c: Remove dead code handling <FH> //
A few lines of code added by this commit:
commit
6f33ba736d46c2f5bfdb2405fd09d82ec18a1d07
Author: Rafael Garcia-Suarez <rgarciasuarez@gmail.com>
Date: Sun Aug 25 18:42:46 2002 +0000
Fix parsing problems with the // operator.
Make // able to follow various unary operators used without
arguments or parens (shift, pop, getc, pos, readline,
readlink, undef, umask, and the filetest operators), as
well as the <FH> operator.
were already unreachable when they were added, specifically the code
for handling // after <FH> (which is fortunate, because XTERMORDORDOR
after <FH> would break <FH>+1).
S_scan_inputsymbol sets pl_yylval.ival to OP_NULL, since it has
already created the ops; it has done so since perl 5.000. So this
branch is never reached when parsing <FH>.
The if-block containing these lines has had ‘|| op_type ==
OP_READLINE’ since perl 5.000, which has also always been redundant
for the same reason.
David Mitchell [Fri, 8 Nov 2013 15:13:23 +0000 (15:13 +0000)]
threads::shared: fix compiler warning
make the file name stored in the lock on debugging builds
be const char* rather than char*, so that passing __FILE__ doesn't give
lots of
shared.xs:1287:323: warning: deprecated conversion from string
constant to 'char *' [-Wwrite-strings]
David Mitchell [Fri, 8 Nov 2013 14:25:28 +0000 (14:25 +0000)]
t/x2p/find2perl.t: expand output
Currently there is one ok() per test case; split that into 4 ok()s
per case, so that different sorts of failures can be differentiated
(i.e. ability to: run find2perl, run its output, run find, and compare the
outputs.)
H.Merijn Brand [Fri, 8 Nov 2013 14:36:57 +0000 (15:36 +0100)]
This version bump also got lost in the merge
Guess there will always be ways in git to explore ...
H.Merijn Brand [Fri, 8 Nov 2013 14:34:11 +0000 (15:34 +0100)]
pod fix
I did this in the merge and the tests passed!
H.Merijn Brand [Mon, 2 Sep 2013 21:09:11 +0000 (23:09 +0200)]
Note (new) platform support
Do I need to add some more extensive reading in README.arm or the like?
H.Merijn Brand [Mon, 2 Sep 2013 17:02:22 +0000 (19:02 +0200)]
Enhance INSTALL instructions for missing libraries
H.Merijn Brand [Mon, 2 Sep 2013 17:01:31 +0000 (19:01 +0200)]
With symlinks in /lib m and crypt are are no longer exceptions
Configure will only look for libfoo.so. If libfoo.so.{num} exists and
libfoo.so does not, make a symbolic link and start over. For this
Synology DS213, I needed
# cd /lib
# ln -s libm.so.6 libm.so
# ln -s libcrypt.so.1 libcrypt.so