platform/upstream/efl.git
4 years agoelm_slider: Add return value check
JunsuChoi [Wed, 26 Feb 2020 07:35:28 +0000 (16:35 +0900)]
elm_slider: Add return value check

Summary:
Calling eina_value_get() without checking return value.
CID: 1400991

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho, CHAN

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11416

4 years agotest/suite_helpers : Fix warnings about use to uninitialized value.
JunsuChoi [Wed, 26 Feb 2020 07:34:44 +0000 (16:34 +0900)]
test/suite_helpers : Fix warnings about use to uninitialized value.

Summary:
remove warnings.
../src/tests/elementary/suite_helpers.c:779:86: warning: ?idy2? may be used uninitialized in this function [-Wmaybe-uninitialized].
...

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11417

4 years agoelementary_test/ui_spotlight: Fix warnings about use to uninitialized value.
JunsuChoi [Wed, 26 Feb 2020 07:33:21 +0000 (16:33 +0900)]
elementary_test/ui_spotlight: Fix warnings about use to uninitialized value.

Summary:
remove warnings.
../src/bin/elementary/test_ui_spotlight.c:1126:9: warning: 'view' may be used uninitialized in this function [-Wmaybe-uninitialized]
...

Test Plan: N/A

Reviewers: YOhoho, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11418

4 years agoexactness: injector: free local buffers
Stefan Schmidt [Tue, 25 Feb 2020 11:34:18 +0000 (12:34 +0100)]
exactness: injector: free local buffers

Make sure we free local resources before we break.

CID: 1419845

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11414

4 years agoexactness: inspect: free image before leaving scope
Stefan Schmidt [Tue, 25 Feb 2020 11:29:01 +0000 (12:29 +0100)]
exactness: inspect: free image before leaving scope

We need to amke sure we free this images before we return.

CID: 1419848

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11413

4 years agoexactness: close file we opened
Stefan Schmidt [Tue, 25 Feb 2020 10:59:51 +0000 (11:59 +0100)]
exactness: close file we opened

We only opened it read only, but this should still be closed before
leaving.

CID: 1419853

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11412

4 years agoexactness: inspect: free local allocation before leaving scope
Stefan Schmidt [Tue, 25 Feb 2020 09:51:29 +0000 (10:51 +0100)]
exactness: inspect: free local allocation before leaving scope

Before we leave the scope here this needs to get free'd up or it will
leak.

CID: 1419877

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11408

4 years agoexactness: inspect: fix memory leak of buffer in error path
Stefan Schmidt [Tue, 25 Feb 2020 09:36:39 +0000 (10:36 +0100)]
exactness: inspect: fix memory leak of buffer in error path

If we hit this error path we need to release the allocated buffer.

CID: 1419878

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11407

4 years agoEcore_Win32: free 'compose' field when needed, fix memory leak
Vincent Torri [Tue, 25 Feb 2020 15:27:14 +0000 (10:27 -0500)]
Ecore_Win32: free 'compose' field when needed, fix memory leak

Reviewers: raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11415

4 years agoEvil: add evil_utf8_to_utf16() API ; use evil_utf16_to_utf8() in Ecore_Win32
Vincent Torri [Tue, 25 Feb 2020 14:23:48 +0000 (09:23 -0500)]
Evil: add evil_utf8_to_utf16() API ; use evil_utf16_to_utf8() in Ecore_Win32

Summary: use existing utf-16 to utf-8 conversion function in Ecore_Win32. Add API to convert utf-8 to utf-16 in Evil for copy'n paste on Windows

Test Plan: compilation

Reviewers: raster, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11406

4 years agotests/elm: verify image file_set -> memfile_set -> file_set
Mike Blumenkrantz [Tue, 25 Feb 2020 14:23:46 +0000 (09:23 -0500)]
tests/elm: verify image file_set -> memfile_set -> file_set

Summary:
ref D11392
Depends on D11397

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11398

4 years agotests/elm: fix elm_icon test
Mike Blumenkrantz [Tue, 25 Feb 2020 14:23:44 +0000 (09:23 -0500)]
tests/elm: fix elm_icon test

Summary:
* this was left as a duplicated efl_ui_image test
* elm_image doesn't have a legacy api for setting icons
* elm_icon doesn't actually have any tests for icon loading
Depends on D11396

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11397

4 years agotest_efl_gfx_vg_value_provider: expand buffer to avoid truncation by snprintf
Yeongjong Lee [Tue, 25 Feb 2020 11:23:30 +0000 (12:23 +0100)]
test_efl_gfx_vg_value_provider: expand buffer to avoid truncation by snprintf

Test Plan: compile with `-Wformat-truncation`

Reviewers: raster, Hermet, segfaultxavi

Reviewed By: segfaultxavi

Subscribers: segfaultxavi, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11405

4 years agoelm/image: restore legacy behavior of elm_image_file_get
Mike Blumenkrantz [Tue, 25 Feb 2020 03:17:12 +0000 (12:17 +0900)]
elm/image: restore legacy behavior of elm_image_file_get

Summary:
this should operate on the internal image object to reflect the file
state there instead of the outer object

Reviewers: kimcinoo, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11396

4 years agoefl_ui/image_zoomable: add icon setting fallback for fdo icons
Mike Blumenkrantz [Mon, 24 Feb 2020 14:34:45 +0000 (15:34 +0100)]
efl_ui/image_zoomable: add icon setting fallback for fdo icons

Summary:
same as D11381
ref 697308a16f77e3e7b7dac6e74293850a3950e3d3

Reviewers: segfaultxavi

Reviewed By: segfaultxavi

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11403

4 years agoEfl.Ui.Image: Add fallback when icon is not found in default theme
Xavi Artigas [Mon, 24 Feb 2020 14:02:30 +0000 (09:02 -0500)]
Efl.Ui.Image: Add fallback when icon is not found in default theme

Summary:
If _icon_standard_set() fails, _icon_freedesktop_set() is tried.

This was causing missing icons in the homescreen example, which uses
application icons which are obviously not present in the default theme.

Thanks to @bu5hm4n!

Test Plan: The homescreen sample application from the examples repository now correctly shows all missing icons.

Reviewers: bu5hm4n, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers, bu5hm4n

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11381

4 years agoelm : move unrealize callback call before the content caching.
SangHyeon Jade Lee [Mon, 24 Feb 2020 13:52:09 +0000 (08:52 -0500)]
elm : move unrealize callback call before the content caching.

Summary:
item edje and contents are cached for performance improvement in genlist & gengrid.
but to provide elm_genlist(gengrid)_all_contents_unset method before the contents
are being cached, unrealize callback must be come before the unrealize process.

currently,
item_unrealize
1.unrealize process
2.contents cached
3.unrealize callback
4.all_contents_unset : nothing to unset in the item.

by this patch,
item_unrealize
1.unrealize callback
2.all_contents_unset : contents are unset.
3.unrealize process
4.contents(null) cached

Reviewers: bu5hm4n, cedric, eagleeye, zmike

Reviewed By: zmike

Subscribers: zmike, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11402

4 years agoRevert "elm_spinner: Fixed to apply the %d format."
Jaehyun Cho [Fri, 21 Feb 2020 09:07:13 +0000 (09:07 +0000)]
Revert "elm_spinner: Fixed to apply the %d format."

This reverts commit b8a24679a6f7995ccc1da19eb86c6c2ef6826d1a.

Differential Revision: https://phab.enlightenment.org/D11394

4 years agoeina: Fix warnings about unused variables on Windows
Christopher Michael [Sun, 23 Feb 2020 12:38:05 +0000 (07:38 -0500)]
eina: Fix warnings about unused variables on Windows

NB: Patch from vtorri

4 years agoci: travis: ensure we update brew as well to avoid a problem on Travis
Stefan Schmidt [Fri, 21 Feb 2020 08:15:53 +0000 (09:15 +0100)]
ci: travis: ensure we update brew as well to avoid a problem on Travis

We normally did not use update as it could take up a few minutes for
every macos build and the packages have been recent enough. Since a few
hours we see build problems now on Travis:
Error: Unknown command: bundle

A way to get them fixed (until Travis updates their images for macos) is
to use the update command.
https://travis-ci.community/t/macos-build-fails-because-of-homebrew-bundle-unknown-command/7296/9

Also moving to a newer osx image here to avoid falling further behind on
the dependencies.

4 years agogl_generic: do not return when RGBA_Image is NULL 15/226515/3
Shinwoo Kim [Tue, 3 Mar 2020 08:08:45 +0000 (17:08 +0900)]
gl_generic: do not return when RGBA_Image is NULL

From following commit
_rotate_image_data does not work if RGBA_Image (im1->im) is NULL.

   0abf1ee [evas_gl] change oreint_set() ... like sw backend

But there is a case the RGBA_Imange is NULL as below.

   Evas_Object *proxy;
   proxy = evas_object_image_add(evas);
   evas_object_image_source_set(proxy, source);
   evas_object_image_save(proxy, "file name", NULL, NULL);

And the following is its stack when the RGBA_Image is NULL

   (#0) _rotate_image_data
   (#1) eng_image_data_map
   (#2) _efl_canvas_image_internal_efl_file_save_save
   (#3) efl_file_save
   (#4) evas_object_image_save

*tizen_fix

Change-Id: Ifa1fd452836a5048f11313ea8c746dd684838470

4 years agoevas: ++safety by prevent invalid accesses. 29/226529/1
Hermet Park [Tue, 3 Mar 2020 10:17:29 +0000 (19:17 +0900)]
evas: ++safety by prevent invalid accesses.

Change-Id: Ib1637f6ff6bd2093a2d525641339cae4553f96e2

4 years agoelc_popup: support eext popup 60/226160/2
Taehyub Kim [Thu, 27 Feb 2020 07:33:44 +0000 (16:33 +0900)]
elc_popup: support eext popup

Change-Id: Ifeeb71ad863522d5e67cd5427cf7288b79fd6d8f

4 years agoevas event: fix typo at map coord transform. 89/226389/3
Hermet Park [Mon, 2 Mar 2020 07:55:40 +0000 (16:55 +0900)]
evas event: fix typo at map coord transform.

Change-Id: If03fd054ece3de57f7e728184babdbee299bd771

4 years agoelm_label: sizing eval is called _on_label_resize to ensure label size. 88/226388/1
Bowon Ryu [Mon, 2 Mar 2020 07:53:10 +0000 (16:53 +0900)]
elm_label: sizing eval is called _on_label_resize to ensure label size.

Summary:
EFL should guarantee size of label in various situations that the label is resized.
elm_layout_sizing_eval called on on_label_resize.

Test Plan: N/A

Reviewers: YOhoho, zmike, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, Hermet, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11435

Change-Id: I531d2333a1b5d9ff9fd273cb8a70767f96b153e2

4 years agoevas_render: Keep to tizen_only logic about proxy_subrender 37/226037/2
JunsuChoi [Wed, 26 Feb 2020 07:55:00 +0000 (16:55 +0900)]
evas_render: Keep to tizen_only logic about proxy_subrender

The tizen only code added in 76b89b8 is the code to use the proxy's source region if it exists.
(evas proxy: use part of source / 76b89b8)
However, this logic became a separate condition with the addition of 2ab3149dd3,
and the value assign for w and h is overwritten.
(evas proxy: make it work for load_region / 2ab3149dd3)
Therefore, modify the code to keep the tizen only code.

@tizen_only
CID: 1125046, 1125041

Change-Id: I98e541913ffbc90ad381334772d9e398158a1639

4 years agoevas_model_load_ply: Prevent memory leak 97/226097/1
JunsuChoi [Thu, 27 Feb 2020 00:55:37 +0000 (09:55 +0900)]
evas_model_load_ply: Prevent memory leak

Summary:
If use ein_str_split, have to free the first element of the array
and free the array.

Test Plan: N/A

Reviewers: Hermet, YOhoho, bu5hm4n, zmike

Reviewed By: zmike

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11419

Change-Id: Ibd8327fc249dd7a503fdb7b7b1527e25c90e87a1

4 years agoelm_config: remove explict null terminator for snprintf 90/225890/2
Yeongjong Lee [Tue, 25 Feb 2020 07:25:41 +0000 (16:25 +0900)]
elm_config: remove explict null terminator for snprintf

snprintf will add a null terminator at the end of string.
Also, this fixes `Wformat-contains-nul` compiler warnings.
```
../src/lib/elementary/elm_config.c: In function '_product_color_overlay_get':
../src/lib/elementary/elm_config.c:1383:87: warning: embedded '\0' in format [-Wformat-contains-nul]
 1383 |         snprintf(config_path, sizeof(config_path), "%s/config/%s/%s_color_overlays.cfg\0",
      |                                                                                       ^~
../src/lib/elementary/elm_config.c: In function '_elm_config_product_font_overlay_get':
../src/lib/elementary/elm_config.c:1538:86: warning: embedded '\0' in format [-Wformat-contains-nul]
 1538 |         snprintf(config_path, sizeof(config_path), "%s/config/%s/%s_font_overlays.cfg\0",
      |
```

@tizen_fix

Change-Id: Id2c73c9186b820e9398bd3d8a5cc27432edee09a

4 years agowayland_egl: use glsym_func_bool instead of glsym_func_int 03/225903/2
Yeongjong Lee [Tue, 25 Feb 2020 08:04:58 +0000 (17:04 +0900)]
wayland_egl: use glsym_func_bool instead of glsym_func_int

return type of `glsym_eglDestroySyncKHR` is EGLBoolean.

@tizen_fix
Change-Id: I20c9b6371a26f9a6a2ce88cabd83364e74267ed1

4 years agoedje_load: fix possible null pointer dereference 43/226043/2
Jaehyun Cho [Wed, 26 Feb 2020 07:52:38 +0000 (16:52 +0900)]
edje_load: fix possible null pointer dereference

Change-Id: I526c65fa0530c4064d06b903db7bde18b6f0d764

4 years agoevas: software_engine: free allocation on error path 29/226029/1
Stefan Schmidt [Tue, 25 Feb 2020 09:57:24 +0000 (10:57 +0100)]
evas: software_engine: free allocation on error path

When we allocated s but fail to allocate l we need to make sure to free
the first allocation before erroring out.

CID: 1419874

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11409

Change-Id: I4016c7bab0347519e03345f4bb46d16377479dc4

4 years agoedje/style: Fix a problem where embedded font does not load in edj 63/225963/1
Bowon Ryu [Mon, 24 Feb 2020 11:16:40 +0000 (20:16 +0900)]
edje/style: Fix a problem where embedded font does not load in edj

Summary:
When edje_font_is_embedded the path of the font must be "font=edje/fonts/%s"
The previous code is "font=%s"
This causes the font to not load properly when edje_font_is_embedded.

Test Plan:
edje_cc test.edc
edje_player test.edj

collections {
    group { "main";
        fonts {
            // Set any two fonts in your local path.
            font: "ANYFONT_1.TTF" "font_1";
            font: "ANYFONT_2.TTF" "font_2";
        }
        styles {
            style { name: "textblock_style_1";
                base: "font=font_1 font_size=30 color=#ffffff";
            }
            style { name: "textblock_style_2";
                base: "font=font_2 font_size=30 color=#ffffff";
            }
        }
        parts {
            spacer { "base";
                scale;
                desc { "default";
                    min: 600 250;
                    max: 600 250;
                }
            }
            rect { "bg";
                scale;
                desc { "default";
                    rel.to: "base";
                    color: 5 5 5 255;
                }
            }
            textblock { "tb1";
                scale;
                desc { "default";
                    rel.to: base;
                    rel1.relative: 0 0;
                    rel2.relative: 1 0.5;
                    text.text: "THIS IS FONT 1";
                    text.style: "textblock_style_1";
                }
            }
            textblock { "tb2";
                scale;
                desc { "default";
                    rel.to: base;
                    rel1.relative: 0 0.5;
                    rel2.relative: 1 1;
                    text.text: "THIS IS FONT 2";
                    text.style: "textblock_style_2";
                }
            }
        }
    }
}

Reviewers: smohanty, CHAN, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11401

Change-Id: I53241e39de9c337a7959c6ed05a60dfc88eebcd2

4 years agoedje_cc_handlers: fix warning 09/225909/1
Taehyub Kim [Tue, 25 Feb 2020 08:32:31 +0000 (17:32 +0900)]
edje_cc_handlers: fix warning

Change-Id: Ie6f527dbfccf39e4b70f7c7b47457ecf8eb14ee6

4 years agoefl_ui_selection_manager: change parameter to unsigned int from Ecore_Wl2_Window * 31/225731/2
Yeongjong Lee [Mon, 24 Feb 2020 07:01:46 +0000 (16:01 +0900)]
efl_ui_selection_manager: change parameter to unsigned int from Ecore_Wl2_Window *

Tizen has not been appied patch which is to replace window ids with pointers
from upstream.
```
commit 78f27a3efff24ba3b935cc9e2620718e51af9304
Author: Derek Foreman <derekf@osg.samsung.com>
Date:   Fri Jul 6 10:16:21 2018 -0400

ecore_wl2: Replace window ids with pointers
```

To fix casting compiler warnings, we need to change parameter to `unsigned int`
from `Ecore_Wl2_Window *`.

@tizen_fix

Change-Id: Ifba51ba7f933a817ba98600924a956feb1c2f6b4

4 years agoefl_ui_selection_manager: fix casting warning for elm_win_wl_window_get API 30/225730/2
Yeongjong Lee [Mon, 24 Feb 2020 06:48:47 +0000 (15:48 +0900)]
efl_ui_selection_manager: fix casting warning for elm_win_wl_window_get API

@tizen_fix

Change-Id: If4f3f8c63b26f0feb57c6e70e064b2e36f05fefc

4 years agoelm_genlist: add content_loop_get method for genlist eo 83/225583/3
Yeongjong Lee [Fri, 21 Feb 2020 05:38:30 +0000 (14:38 +0900)]
elm_genlist: add content_loop_get method for genlist eo

Fixes `-Wunused-function`.

@tizen_fix

Change-Id: I09f47346794e3d0d751b00fa1a48fb86ec061c0a

4 years agoelementary_tizen: fix compiler warnings 26/225626/2
Yeongjong Lee [Fri, 21 Feb 2020 07:36:59 +0000 (16:36 +0900)]
elementary_tizen: fix compiler warnings

 - Unused functions, variables and label are removed.
 - ELM_FOCUS enum is replaced with EFL_UI_FOCUS_DIRECTION enum.

note:
`_elm_genlist_efl_object_finalize` should have been removed at commit
84819f36f83696caa143fdf72e9f4f1cdbcc1200.

@tizen_fix

Change-Id: I14ce88ab7ef0a02c43ff2db57e537d0746cd35a2

4 years agoevas_engine: fix warning 70/225770/2
Taehyub Kim [Mon, 24 Feb 2020 09:32:47 +0000 (18:32 +0900)]
evas_engine: fix warning

Change-Id: I4f79a8565d17cefb6f948675c20ca6487674f41a

4 years agoefl_ui_slider: remove unused functions 03/225703/2
Yeongjong Lee [Mon, 24 Feb 2020 05:06:13 +0000 (14:06 +0900)]
efl_ui_slider: remove unused functions

@tizen_fix
Change-Id: Iacdeefd5d780aa1c085141eb07b89dec135a95d7

4 years agodatabase_expr: fix memory leak when type error happens 34/225834/2
Jaehyun Cho [Mon, 24 Feb 2020 14:52:25 +0000 (15:52 +0100)]
database_expr: fix memory leak when type error happens

Summary: Memory leak is fixed when type error happens.

Reviewers: q66

Reviewed By: q66

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11400

Change-Id: Ifa3f5f1d7bea3f0e3499a98729c31ce7094f7283

4 years agoevas_gl_context: fix warning 68/225768/3
Taehyub Kim [Mon, 24 Feb 2020 09:31:03 +0000 (18:31 +0900)]
evas_gl_context: fix warning

Change-Id: Ib7834dfc78a3df3bb6d3d6ed808bad662a8718ee

4 years agovg_common_json: Fix to duplication of mask and matte.
JunsuChoi [Tue, 25 Feb 2020 02:54:57 +0000 (11:54 +0900)]
vg_common_json: Fix to duplication of mask and matte.

Summary:
There is a case that uses a mask and a mat at the same time.
One of them did not apply. This patch modifies two attributes to be parent-child.

Test Plan: N/A

Reviewers: Hermet, smohanty, kimcinoo

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11399

Change-Id: I14b1e2ab38c042c6845b2232ca8a7b79abccc8c6

4 years agoemile_image: fix warning for COLORSPACE_PALETTE 53/225753/2
Taehyub Kim [Mon, 24 Feb 2020 09:03:03 +0000 (18:03 +0900)]
emile_image: fix warning for COLORSPACE_PALETTE

Change-Id: Idf34992f40015972853b4b4259cc9100c75d02ef

4 years agoefl_ui_win: fix return value 36/225736/2
Yeongjong Lee [Mon, 24 Feb 2020 05:20:57 +0000 (14:20 +0900)]
efl_ui_win: fix return value

@tizen_fix

Change-Id: I65920785747f2bf65dc952b22ab23c2607197d22

4 years agoefl_ui_win: fix casting warnings of Win_Keyboard_Mode 35/225735/2
Yeongjong Lee [Mon, 24 Feb 2020 05:19:45 +0000 (14:19 +0900)]
efl_ui_win: fix casting warnings of Win_Keyboard_Mode

@tizen_fix

Change-Id: I338a7bb0df8bba81a35519eb95a3035e01873e1c

4 years agobuild: fix compiler warnings related to const qualifier 16/225716/2
Yeongjong Lee [Mon, 24 Feb 2020 06:20:05 +0000 (15:20 +0900)]
build: fix compiler warnings related to const qualifier

@tizen_fix

Change-Id: I9992862a849c36227616ff91c4449107f7a4c1bb

4 years agoelm_interface_scrollable: comment out unused goto label 32/225732/2
Yeongjong Lee [Mon, 24 Feb 2020 03:56:04 +0000 (12:56 +0900)]
elm_interface_scrollable: comment out unused goto label

Fixes `-Wunused-label`
```
../src/lib/elementary/elm_interface_scrollable.c:1190:1: warning: label 'skip_bars' defined but not used [-Wunused-label]
 1190 | skip_bars:
```e

@tizen_fix

Change-Id: Ib4b9bc83d79379c02b5785a9961efca3a1127047

4 years agoelm_atspi_bridge: fix return type 12/225712/2
Yeongjong Lee [Mon, 24 Feb 2020 05:55:13 +0000 (14:55 +0900)]
elm_atspi_bridge: fix return type

Fixes `-Wint-conversion` compiler warning.
```
../src/lib/elementary/elm_atspi_bridge.c:7248:14: warning: returning 'void *' from a function with return type 'Eina_Bool' {aka 'unsigned char'} makes integer from pointer without a cast [-Wint-conversion]
  7248 |       return NULL;
```

@tizen_fix

Change-Id: Ie9d4ea80b209210616ef498e3122963cbe4cf169

4 years agoelm_atspi_bridge: correct EFL_EVNET_DEL callback parameters 00/225700/2
Yeongjong Lee [Mon, 24 Feb 2020 04:02:40 +0000 (13:02 +0900)]
elm_atspi_bridge: correct EFL_EVNET_DEL callback parameters

Fixes `-Wincompatible-pointer-types` compiler warnings.

@tizen_fix

Change-Id: I413ed239f6f5bfdad07b10823b6956af865f2614

4 years agoelm_config: remove redundant code 01/225701/2
Yeongjong Lee [Mon, 24 Feb 2020 04:53:30 +0000 (13:53 +0900)]
elm_config: remove redundant code

`theme_overlay_mmap` is freed by following step.
 `_elm_theme_file_clean` - `_elm_theme_clear` - `_elm_theme_free_internal` -
`_efl_ui_theme_efl_object_destructor`.
We don't need to call explicit del.

@tizen_fix

Change-Id: Icf522386e51321297b78746d9371b9476db56a38

4 years agoelementary: remove unused variable in tizen only code 76/225576/3
Yeongjong Lee [Fri, 21 Feb 2020 05:00:06 +0000 (14:00 +0900)]
elementary: remove unused variable in tizen only code

Fixes '-Wunused-variable' compiler warnings.

@tizen_fix
Change-Id: I462ca6212f97f00e628e839b19e1b05f4f1dd7ca

4 years agoecje_cc_handlers: fix warning 42/225742/1
Taehyub Kim [Mon, 24 Feb 2020 07:41:03 +0000 (16:41 +0900)]
ecje_cc_handlers: fix warning

Change-Id: Ibf2fc18f16ed6d9fc05c3c270647680a17f16ecb

4 years agobuild: comment out unused variables 82/225582/2
Yeongjong Lee [Fri, 21 Feb 2020 05:35:07 +0000 (14:35 +0900)]
build: comment out unused variables

Fixes '-Wunused-variable' compiler warnings.

@tizen_fix

Change-Id: I7237668cf83cdd985c61bff6e226082793ed4451

4 years agoelementary: return proper value when failed to get widget data 96/225496/2
Yeongjong Lee [Thu, 20 Feb 2020 08:26:22 +0000 (17:26 +0900)]
elementary: return proper value when failed to get widget data

Fixes '-Wreturn-type' compiler warning.

@tizen_fix
Change-Id: I96a404c41c6eacc9e3d9d6d02c9022c4be2663ce

4 years agoedje_cc_out: correct comment pair 91/225491/3
Yeongjong Lee [Thu, 20 Feb 2020 07:28:52 +0000 (16:28 +0900)]
edje_cc_out: correct comment pair

Fixes following compiler warning.
```
../src/bin/edje/edje_cc_out.c:751:9: warning: "/*" within comment [-Wcomment]
   751 |         /*
```

@tizen_fix

Change-Id: I21c88ac97892a2e9ce5ed0b4ab91f2a4c3359aa1

4 years agoelementary: add EINA_UNUSED for unused parameters 66/225466/3
Yeongjong Lee [Thu, 20 Feb 2020 06:33:33 +0000 (15:33 +0900)]
elementary: add EINA_UNUSED for unused parameters

@tizen_fix

Change-Id: Ia9307a02741281b8412b436b177090676f56cd23

4 years agoefl_ui_image: unload file before memfile_set 07/225607/1
Shinwoo Kim [Fri, 21 Feb 2020 04:16:32 +0000 (13:16 +0900)]
efl_ui_image: unload file before memfile_set

Summary:
If memfile_set does not remove prev file information, it is not possilbe to
load image using the same file information after memefile_set.

It means that below line 3 does not work because the same file information
remains for Efl.Ui.Image_Legacy.

1 |  elm_image_file_set(obj, "1.jpg", NULL)
2 |  elm_image_memfile_set(obj, img, size, "jpg", NULL)
3 |  elm_image_file_set(obj, "1.jpg", NULL)

This patch removes line calling _efl_ui_image_file_set_do becasue it is called
in efl_file_unload > _efl_ui_image_efl_file_unload.

Test Plan:
[Sample Code]
{F3848315}

[Reproduce Step]
1. File2
2. Memfile
3. File2

Reviewers: Hermet, jsuya

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11392

Change-Id: I0f583ff0e8ada23a1bad334b716c952f42b904c2

4 years agoelm_interface_scrollable: remove unused tizen only function 97/225597/1
Yeongjong Lee [Fri, 21 Feb 2020 06:21:49 +0000 (15:21 +0900)]
elm_interface_scrollable: remove unused tizen only function

`_elm_scroll_bar_size_reconfigure` is not used anymore.

Fixes `Wunused-function` compiler warning.

@tizen_fix
Change-Id: I850b10d8b7095f2c27a7ae609ca2ba1bd17cdb4a

4 years agoRevert "elementary: use array instead of list for subchildren" submit/tizen/20200220.222107
Jongmin Lee [Thu, 20 Feb 2020 22:06:01 +0000 (07:06 +0900)]
Revert "elementary: use array instead of list for subchildren"

This reverts commit cf583498a72be5f18b2dd6a4fb10ff1f1dbca53f.

4 years agoefl_ui_exact_model: use eina APIs to get the nth data
Yeongjong Lee [Thu, 20 Feb 2020 14:11:02 +0000 (09:11 -0500)]
efl_ui_exact_model: use eina APIs to get the nth data

Summary:
Also, fixes a compiler warning
```
../src/lib/elementary/efl_ui_exact_model.c:60:17: warning: variable 'tbuf' set but not used [-Wunused-but-set-variable]
```

Test Plan: ninja

Reviewers: cedric, zmike, bu5hm4n

Reviewed By: zmike

Subscribers: #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11380

4 years agocanvas proxy: fix broken proxy source clipping function.
Hermet Park [Thu, 20 Feb 2020 12:20:09 +0000 (21:20 +0900)]
canvas proxy: fix broken proxy source clipping function.

The issue is proxy source clipping is not applied properly,
Obviously that is a regression bug by the code refactoring.

Found out this condition is insane, looks like a wrongly introduced.

@fix

4 years agoEfl.Ui.Spotlight: Fix indicator initialization
Xavi Artigas [Thu, 20 Feb 2020 08:59:29 +0000 (09:59 +0100)]
Efl.Ui.Spotlight: Fix indicator initialization

This caused incorrectly-centered indicator icons in the homescreen example.

4 years agoelementary: use array instead of list for subchildren
Marcel Hollerbach [Mon, 17 Feb 2020 12:56:06 +0000 (13:56 +0100)]
elementary: use array instead of list for subchildren

this safes in the runtime of elm_test round about 9kb (*).
Additionally, using a array here is jumping way fewer times arround in
memory, as we do not need to jump from node to node in a list.

Additionally, this commit replaces a few abort disabler macros with a
error checking macro. (which cleans the log).

*: explanation: we have round about 600 widgets in elm_test, every
widget is normally refered once, every list node has 4 pointer, makes
round about 9600 bytes or rougly 9 KB. So the messured savings are more
or less explaining the reality.

Reviewed-by: Carsten Haitzler (Rasterman) <rasterman.com>
Differential Revision: https://phab.enlightenment.org/D11374

Change-Id: I8653d875ab8bd7db4a48910dc2ed08cee1e76623

4 years agoedje: guarantee the theme abi compatility.
Hermet Park [Thu, 20 Feb 2020 11:22:27 +0000 (20:22 +0900)]
edje: guarantee the theme abi compatility.

if old edj doesn't include "zoom_center" properly,
the initial value will be set with zero,

We can overwrite it in that case since zoom_center initial value is -1.

Change-Id: Id8fdc81bf9ad9749a0e887093773e8eca44a953d

4 years agoedje: Fixed issue that caused color_class changes to be applied to global styles. 63/225463/1
Woochanlee [Thu, 20 Feb 2020 05:30:59 +0000 (14:30 +0900)]
edje: Fixed issue that caused color_class changes to be applied to global styles.

There was issue because the application to the object, file, and global units to which color_class is applied is mixed.

Solved by dividing internal function according to the scope.

Change-Id: I42929c5558e5078a8bdcca1aec032a3bf6161bce

4 years agogengrid: fix item append wanted region adjust in mirrored screen submit/tizen/20200219.213751
SangHyeon Jade Lee [Wed, 19 Feb 2020 10:57:28 +0000 (19:57 +0900)]
gengrid: fix item append wanted region adjust in mirrored screen

Change-Id: If71bed64a95ef3b7bdc5b4a411b7e735702ee89b
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
4 years agogen : fix on_deletion check on item deletion
SangHyeon Jade Lee [Wed, 19 Feb 2020 07:19:51 +0000 (16:19 +0900)]
gen : fix on_deletion check on item deletion

Change-Id: I8200b249a2339def12a34275e08d2de41160e26c
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
4 years agoecore/evas: add key event cancel flag
Hosang Kim [Tue, 18 Feb 2020 08:07:54 +0000 (17:07 +0900)]
ecore/evas: add key event cancel flag

Add new event flag for canceling key event.

Change-Id: I105d763025795bd4196b8c6caa16bdc05f9b9f95
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
4 years agoedje_text: Use legacy ellisis logic for evas text.
Subodh Kumar [Tue, 18 Feb 2020 13:37:06 +0000 (19:07 +0530)]
edje_text: Use legacy ellisis logic for evas text.
Some use cases are breaking like lock pin layout

@tizen_fix

Change-Id: Idcd96a7bd4155e893bd464c70aa8d1df7f990470

4 years agoedje: modify to respect user set fixed property
Wonki Kim [Wed, 19 Feb 2020 17:40:39 +0000 (12:40 -0500)]
edje: modify to respect user set fixed property

Summary:
this patch is related with @D11365.

rather than undoing optimization edje calc,
this patch introduces a user_set property which enables edje_calc
to respect user set property.

Reviewers: bu5hm4n, eagleeye, YOhoho, Hermet, zmike

Reviewed By: zmike

Subscribers: zmike, cedric, #reviewers, #committers, woohyun, eagleeye, bu5hm4n

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11366

4 years agodocs: A bit more info and formatting for Eina_Process_Cb
Xavi Artigas [Fri, 10 Jan 2020 16:35:37 +0000 (16:35 +0000)]
docs: A bit more info and formatting for Eina_Process_Cb

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11063

4 years agoeina: introduce eina_iterator_process
Marcel Hollerbach [Fri, 10 Jan 2020 15:35:57 +0000 (16:35 +0100)]
eina: introduce eina_iterator_process

this brings a functional-map function to the iterator implementations.
https://en.wikipedia.org/wiki/Map_(higher-order_function)

Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D11062

4 years agoefl_ui_draggable: move these events back to legacy
Marcel Hollerbach [Sun, 26 Jan 2020 09:22:55 +0000 (10:22 +0100)]
efl_ui_draggable: move these events back to legacy

they are not used yet in efl.ui. namespace, and they are needed for
different events.

Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11196

4 years agoAdding "elm,calendar,ch_%d,weekend" and "elm,calendar,ch_%d,weekday" signals from...
rafspiny [Tue, 18 Feb 2020 16:12:45 +0000 (16:12 +0000)]
Adding "elm,calendar,ch_%d,weekend" and "elm,calendar,ch_%d,weekday" signals from "elm".

The calendar object in elementary needs to know which days are weekdays and which
are weekend days in order to properly change the state of the header's labels.
This code add a signal emission from e_calendar.c when setting the header.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11375

4 years agoeina_array: interpret the count of a NULL array as 0
Marcel Hollerbach [Mon, 17 Feb 2020 12:55:33 +0000 (13:55 +0100)]
eina_array: interpret the count of a NULL array as 0

this makes the usage way more convinient.

Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11373

4 years agoecore_con: fix to check a return value of functions
Wonki Kim [Tue, 18 Feb 2020 00:58:16 +0000 (00:58 +0000)]
ecore_con: fix to check a return value of functions

this path fixes to check a return value of functions.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11371

4 years agoefl_con: add a default condition to switch statement
Wonki Kim [Tue, 18 Feb 2020 01:07:12 +0000 (01:07 +0000)]
efl_con: add a default condition to switch statement

this patch modifies conditions
to extract range conditions out of switch statement

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11370

4 years agoelm_spinner: Fixed to apply the %d format.
Woochanlee [Wed, 19 Feb 2020 12:09:15 +0000 (21:09 +0900)]
elm_spinner: Fixed to apply the %d format.

Summary:
The part object does not apply the logic in efl_ui_format, so it does not work correctly when you format it with %d.

This is the commit that gets the necessary part of the logic of efl_ui_format.

Test Plan: elementary_test

Reviewers: Jaehyun_Cho

Reviewed By: Jaehyun_Cho

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11378

4 years agoecore_wl2_input: cleanup cursor resources when a Ecore_Wl2_Input is destroy 83/225383/2
jeon [Wed, 19 Feb 2020 10:24:25 +0000 (19:24 +0900)]
ecore_wl2_input: cleanup cursor resources when a Ecore_Wl2_Input is destroy

Change-Id: I464f42ee9e845bee7def2c8fb577f0669c18da8a

4 years agoelm_list : fix build warnings. accepted/tizen/unified/20200221.093540 submit/tizen/20200218.214546
SangHyeon Jade Lee [Fri, 14 Feb 2020 06:35:53 +0000 (15:35 +0900)]
elm_list : fix build warnings.

Change-Id: I79ed9a4328d3a772a79f317d744bbaeb2f66e2d9

4 years agoelementary: remove unused functions 30/225230/2
Yeongjong Lee [Mon, 17 Feb 2020 06:41:31 +0000 (15:41 +0900)]
elementary: remove unused functions

elm_atspi_bridge: remove `_target_validation_check` which should have been
removed at commit 98d14ca80d3d5540760ff41d85f2c61e7bd40c6b.

efl_ui_widget: remove `_on_ewk_del` which should have been removed from commit
22a1e551be364c0d65cd6693b40bf9d9ceed67be.

efl_ui_win: remove _on_atspi_bus_connected` that is not used for tizen.

elementary_tizen: remove `widget_parent_set` which should have been removed at
commit a40eb658890da0ee142c91ff9f900ae797521252.

@tizen_fix

Change-Id: I9a4fd26c2c7ea1b3260e2961bc10cc65bb476938

4 years agobuild: comment out unused functions 18/225218/2
Yeongjong Lee [Tue, 18 Feb 2020 07:16:27 +0000 (16:16 +0900)]
build: comment out unused functions

@tizen_fix
Change-Id: I28cee3b69b7977a2a917e2dc9b1ceb27fd2af96d

4 years agoelementary_tizen/ctxpopup: rename widget_event to input_event_handler 16/225116/4
Yeongjong Lee [Mon, 17 Feb 2020 10:28:27 +0000 (19:28 +0900)]
elementary_tizen/ctxpopup: rename widget_event to input_event_handler

`widget_event` has been renamed to `input_event_handler` since commit
298d112dbb1151fe119480af275931b45828fafd.

For tizen elc_ctxpopup, KeyEvent will work again.

Also, Fixes compiler warnings.
```
 ../src/lib/elementary_tizen/elc_ctxpopup.c:1314:1: warning: '_elm_ctxpopup_efl_ui_widget_event' defined but not used [-Wunused-function]
  1314 | _elm_ctxpopup_efl_ui_widget_event(Eo *obj, Elm_Ctxpopup_Data *sd, Evas_Object *src EINA_UNUSED, Evas_Callback_Type type, void *event_info)
       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 ../src/lib/elementary_tizen/elc_ctxpopup.c:165:1: warning: '_key_action_move' defined but not used [-Wunused-function]
   165 | _key_action_move(Evas_Object *obj, const char *params)
```

@tizen_fix

Change-Id: I95faa5d0d5647df276be03de109e45c2baaf6bfe

4 years agoelm_conform: comment out unused CONFORMANT_KEY 74/225074/2
Yeongjong Lee [Mon, 17 Feb 2020 05:21:23 +0000 (14:21 +0900)]
elm_conform: comment out unused CONFORMANT_KEY

Change-Id: Idb4cc65936318550664b44b544509ce4516b080e

4 years agoedje_text: Restore legacy edje text x fit calculation.
Subodh Kumar [Mon, 17 Feb 2020 09:03:40 +0000 (14:33 +0530)]
edje_text: Restore legacy edje text x fit calculation.

Current fit calculation is breaking some use cases from Tizen 4.0
example: Edit mode ctxpopup text

@tizen_fix

Change-Id: I785e5f53ae795952e8c2ac21c0c5b4b35f41607d

4 years agoC#: Add error checking for Eina.Success_Flag return type
Felipe Magno de Almeida [Tue, 11 Feb 2020 17:48:26 +0000 (17:48 +0000)]
C#: Add error checking for Eina.Success_Flag return type

When a get and/or set from property is defined to return, explicitly,
a Eina.Success_Flag, the mono generator will check the return value
and generate an exception if the call fails.
Resolves T8383.

Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11281

4 years agocsharp: Add IntPtr to/from IEnumerable conversion for "accessor" types
João Paulo Taylor Ienczak Zanette [Tue, 18 Feb 2020 19:17:56 +0000 (19:17 +0000)]
csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types

Adds a special case for "accessor" complex types in `implicit operator` for
structs and `IntPtr`s, in which an IEnumerator must be converted to/from an
IntPtr.

Reviewed-by: YeongJong Lee <cleanlyj@naver.com>
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11210

4 years agoeolian-mono: Make Get/Set internal for generated properties
Felipe Magno de Almeida [Thu, 30 Jan 2020 19:49:04 +0000 (16:49 -0300)]
eolian-mono: Make Get/Set internal for generated properties

Make Get and Set methods internal for properties that get the
property syntax generated.

Reviewed-by: João Paulo Taylor Ienczak Zanette <joao.tiz@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D11252

4 years agoRevert "canvas mask: fix incorrect render surface size."
Hermet Park [Tue, 18 Feb 2020 11:07:08 +0000 (20:07 +0900)]
Revert "canvas mask: fix incorrect render surface size."

This reverts commit e3af5eb27f70edf531d5d8de3e3f2c940536d396.

Seems previous is correct. My misunderstanding.

4 years agocanvas mask: fix incorrect render surface size.
Hermet Park [Tue, 18 Feb 2020 10:09:16 +0000 (19:09 +0900)]
canvas mask: fix incorrect render surface size.

This render context works on a mask surface,
Size should be mask's own, not canvas output size.

@fix

4 years agoEfl.Gfx.Path: Fix condition of for loop in current search 52/225252/1
JunsuChoi [Tue, 18 Feb 2020 07:23:11 +0000 (16:23 +0900)]
Efl.Gfx.Path: Fix condition of for loop in current search

END enum is 0. Fixed due to 064690d46e7ed67becf9710588e7c37a31ab807f
@fix

Change-Id: I9c70d34c102d57284ae93f1e211f960ebe1dc555

4 years agoecore: fix a memory leaking 36/225136/2
Wonki Kim [Mon, 17 Feb 2020 12:57:01 +0000 (21:57 +0900)]
ecore: fix a memory leaking

this patch fixes a memory leaking.

Change-Id: I909d038812f2a66c6bd5e503b16767e73472f5bc

4 years agoelm_atspi_ewk_wrapper: Prevent memory leak 78/225178/1
JunsuChoi [Tue, 18 Feb 2020 04:33:28 +0000 (13:33 +0900)]
elm_atspi_ewk_wrapper: Prevent memory leak

Change-Id: Id6e26224b2b4fdbf21134cdd2016ca0de37f8132

4 years agoedje: Disable the json vector animation feature with a flag. 64/225164/1
JunsuChoi [Mon, 17 Feb 2020 10:05:22 +0000 (19:05 +0900)]
edje: Disable the json vector animation feature with a flag.

Summary:
Json vector animation requires the json loader to be loaded.
Therefore, if the loader does not load,
it prints an appropriate error message and disables the feature.

Depends on D11228

Test Plan: N/A

Reviewers: Hermet, Jaehyun_Cho, id213sin

Reviewed By: Hermet

Subscribers: raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11230

Change-Id: I4c7b966189c8612d06ff44739d0e57b6d15c9faa

4 years agoedje: add json file support feature 63/225163/1
YoungBok Shin [Mon, 17 Feb 2020 09:59:09 +0000 (18:59 +0900)]
edje: add json file support feature

Summary:
It also starts to support following new edc properties.
This is backported patch from Tizen 5.0

1. frame
desc { "default"
   vector {
      frame: 0.5; // 0.0 ~ 1.0
   }
}

2. actions
program { "vector_animation";
   // VG_ANIM_PLAY, VG_ANIM_PLAY_BACK, VG_ANIM_LOOP,
   // VG_ANIM_STOP, VG_ANIM_PAUSE, VG_ANIM_RESUME
   action: VG_ANIM_PLAY;
   target: "your_vector_part";
}

@feature

Co-authored-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
  - Fix to remove Efl.Canvas.Animation_Player on edje

Test Plan:
{F3840540}
{F3840542}
{F3840543}
make and test attached file

edje_cc -beta -id ./ json_edc.edc json.edj
gcc -o test test_edc.c -g `pkg-config --cflags --libs evas elementary rlottie`
./test

Reviewers: Hermet, Jaehyun_Cho, id213sin

Reviewed By: Hermet

Subscribers: segfaultxavi, raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11228

Change-Id: I3f27e381e5ae2ed76794ec738809c78f095cbc02

4 years agomono: Add "out" as a reserved word submit/tizen/20200217.221032
Xavi Artigas [Mon, 17 Feb 2020 11:35:00 +0000 (12:35 +0100)]
mono: Add "out" as a reserved word

This will turn it into kw_out just like it is done for "in".
Otherwise it cannot be used as a parameter name, for example.

4 years agoefl_ui_selection_manager: fix a compiler warning for Wayland support
Yeongjong Lee [Mon, 17 Feb 2020 09:48:11 +0000 (18:48 +0900)]
efl_ui_selection_manager: fix a compiler warning for Wayland support

Summary: `_sel_manager_seat_selection_get` is used only for x11.

Test Plan: meson build -Dx11=false -Dwl=true

Reviewers: Hermet, zmike

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11363

4 years agoefl_ui_selection_manager: remove unnecessary variable
Yeongjong Lee [Mon, 17 Feb 2020 09:47:54 +0000 (18:47 +0900)]
efl_ui_selection_manager: remove unnecessary variable

Summary: No logical changes.

Test Plan: meson build

Reviewers: Hermet, zmike

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11362

4 years agoels_cursor: Fix a compiler warning for Wayland support
Yeongjong Lee [Mon, 17 Feb 2020 06:36:03 +0000 (15:36 +0900)]
els_cursor: Fix a compiler warning for Wayland support

Summary:
`_curosors` is not used when Elementary is compiled for Wayland.
It Fixes a compiler warning.
```
../src/lib/elementary/els_cursor.c:46:26: warning: ‘_cursors’ defined but not used [-Wunused-variable]
 static struct _Cursor_Id _cursors[] =

```

Test Plan: meson build -Dx11=false -Dwl=true

Reviewers: zmike, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11360

4 years agoedje_multisense: fix a compiler warning for pulseaudio disable mode
Yeongjong Lee [Mon, 17 Feb 2020 06:35:57 +0000 (15:35 +0900)]
edje_multisense: fix a compiler warning for pulseaudio disable mode

Summary: `_out_fail` is not used when edje is compiled without pulseaudio.

Test Plan: meson build -Dpulseaudio=false

Reviewers: zmike, Hermet, Jaehyun_Cho

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D11361