platform/upstream/rpm.git
16 years agoheaderfmt.c has translatable strings, add to POTFILES
Panu Matilainen [Mon, 12 May 2008 15:26:11 +0000 (18:26 +0300)]
headerfmt.c has translatable strings, add to POTFILES

16 years agoUse rpmTagGetFoo() instead of local myTagFoo() versions
Panu Matilainen [Mon, 12 May 2008 15:03:47 +0000 (18:03 +0300)]
Use rpmTagGetFoo() instead of local myTagFoo() versions
- hsa tags will always be our default rpmTagTable so we can use the
  somewhat optimized rpmTagGet() versions instead of dumb linear searchs

16 years agoPush extension defaults one level deeper into headerFormat()
Panu Matilainen [Mon, 12 May 2008 14:25:54 +0000 (17:25 +0300)]
Push extension defaults one level deeper into headerFormat()

16 years agoSimplify header extension handling
Panu Matilainen [Mon, 12 May 2008 14:08:12 +0000 (17:08 +0300)]
Simplify header extension handling
- remove the now unnecessary chaining to different extension tables

16 years agoMove headerVerifyInfo() to header.[ch] where it logically belongs
Panu Matilainen [Mon, 12 May 2008 13:53:26 +0000 (16:53 +0300)]
Move headerVerifyInfo() to header.[ch] where it logically belongs
- removes the need for copy-paste typeAlign array in package.c

16 years agoEliminate copy-paste versions of hdrchkFoo() macros
Panu Matilainen [Mon, 12 May 2008 13:31:27 +0000 (16:31 +0300)]
Eliminate copy-paste versions of hdrchkFoo() macros
- just stick 'em into header_internal.h, both header.c and package.c
  need it anyway

16 years agoConvert internal uses of headerSprintf() to headerFormat()
Panu Matilainen [Mon, 12 May 2008 13:20:13 +0000 (16:20 +0300)]
Convert internal uses of headerSprintf() to headerFormat()

16 years agoAdd simpler headerFormat() function, deprecate headerSprintf()
Panu Matilainen [Mon, 12 May 2008 13:16:37 +0000 (16:16 +0300)]
Add simpler headerFormat() function, deprecate headerSprintf()
- headerSprintf() is just a dumb wrapper around headerFormat() now,
  tbltags and extensions are not used at all
- baby steps towards eliminating the the tag and extension tables from
  the API/ABI...

16 years agoSplit header sprintf formatting to separate source
Panu Matilainen [Mon, 12 May 2008 12:48:31 +0000 (15:48 +0300)]
Split header sprintf formatting to separate source
- header.c is now just low level header handling, headerfmt.c is the
  formatting engine and formats.c has the actual formats
- also move bunch of formatting-related stuff from header_internal.h to
  headerfmt.c, nothing else needs it

16 years agofully translate to CZ after latest po files regeneration
Jindrich Novy [Mon, 12 May 2008 10:46:37 +0000 (12:46 +0200)]
fully translate to CZ after latest po files regeneration

16 years agoMove header "default" formats to formats.c along with the rest of 'em
Panu Matilainen [Mon, 12 May 2008 09:54:36 +0000 (12:54 +0300)]
Move header "default" formats to formats.c along with the rest of 'em

16 years agoUpdate translations after the big shuffle
Panu Matilainen [Mon, 12 May 2008 09:31:54 +0000 (12:31 +0300)]
Update translations after the big shuffle

16 years agoAdjust pkg-config now that librpmdb is gone
Panu Matilainen [Mon, 12 May 2008 09:30:00 +0000 (12:30 +0300)]
Adjust pkg-config now that librpmdb is gone

16 years agoFixup paths and Makefiles for rpmdb/ elimination
Panu Matilainen [Mon, 12 May 2008 09:28:12 +0000 (12:28 +0300)]
Fixup paths and Makefiles for rpmdb/ elimination

16 years agoStart (re-)joining librpmdb and librpm
Panu Matilainen [Mon, 12 May 2008 09:17:01 +0000 (12:17 +0300)]
Start (re-)joining librpmdb and librpm
- the split is largely arbitrary and mostly just causes, well, arbitrary
  issues and limitations
- just move content from rpmdb/ to lib/ for now

16 years agoRip old, bit-rotten librpm test programs
Panu Matilainen [Mon, 12 May 2008 07:45:33 +0000 (10:45 +0300)]
Rip old, bit-rotten librpm test programs

16 years agoRip old, bit-rotten librpmio test programs
Panu Matilainen [Mon, 12 May 2008 07:44:07 +0000 (10:44 +0300)]
Rip old, bit-rotten librpmio test programs

16 years agoRip old, bit-rotten librpmdb test programs
Panu Matilainen [Mon, 12 May 2008 07:40:14 +0000 (10:40 +0300)]
Rip old, bit-rotten librpmdb test programs

16 years agoRemove internal copy of Lua for good
Panu Matilainen [Mon, 12 May 2008 06:14:09 +0000 (09:14 +0300)]
Remove internal copy of Lua for good
- we can do just fine with externally linked lua, no need to carry
  this around

16 years agoFully transale RPM to Czech
Jindrich Novy [Sat, 10 May 2008 06:55:04 +0000 (08:55 +0200)]
Fully transale RPM to Czech
- convert the po file to UTF-8
- translate all strings

16 years agoCaught pants down with strlcpy() vs strncpy() semantics
Panu Matilainen [Thu, 8 May 2008 16:03:12 +0000 (19:03 +0300)]
Caught pants down with strlcpy() vs strncpy() semantics
- rstrlcpy() calculates source string size regardless of length limit,
  but cpio fields are fixed length character arrays, not strings -> kaboom
- wondering if zero-terminating strncpy() variant might be more fit to our
  purposes than strlcpy()-clone

16 years agoEliminate static print buffer from prDbiOpenFlags()
Panu Matilainen [Thu, 8 May 2008 14:10:10 +0000 (17:10 +0300)]
Eliminate static print buffer from prDbiOpenFlags()
- unlikely to actually overflow but it'd be all the more embarrasing
  as it's just diagnostics/debug code...

16 years agoAvoid entirely unnecessary static temp string buffer
Panu Matilainen [Thu, 8 May 2008 12:24:46 +0000 (15:24 +0300)]
Avoid entirely unnecessary static temp string buffer

16 years agoRip useless ROOT_GROUP checking from configure
Panu Matilainen [Thu, 8 May 2008 11:37:29 +0000 (14:37 +0300)]
Rip useless ROOT_GROUP checking from configure
- it was only used for an ancient RH-specific %_fixgroup anyway which
  in turn only ever did anything when building as root - bad bad...

16 years agoDon't run fixowner and fixgroup at end of %prep
Panu Matilainen [Thu, 8 May 2008 11:36:08 +0000 (14:36 +0300)]
Don't run fixowner and fixgroup at end of %prep
- they'd only work for root, and we don't want to encourage people to build
  as root...

16 years agoOops, matchpathcon() wants st_mode, not the entire struct stat
Panu Matilainen [Thu, 8 May 2008 10:40:26 +0000 (13:40 +0300)]
Oops, matchpathcon() wants st_mode, not the entire struct stat

16 years agoBlock signals while moving the rpmdb to final location after rebuild
Panu Matilainen [Thu, 8 May 2008 10:35:27 +0000 (13:35 +0300)]
Block signals while moving the rpmdb to final location after rebuild
- interrupt there would be pretty disastrous..

16 years agoLose the silly db argument from block/unblockSignals()
Panu Matilainen [Thu, 8 May 2008 10:30:16 +0000 (13:30 +0300)]
Lose the silly db argument from block/unblockSignals()
- unused, and unusable anyway as signals are global, not per db thing...

16 years agoRestore rpmdb selinux contexts to default after rebuild (rhbz#442149)
Panu Matilainen [Thu, 8 May 2008 10:06:34 +0000 (13:06 +0300)]
Restore rpmdb selinux contexts to default after rebuild (rhbz#442149)

16 years agois_selinux_enabled() returns 0 if not enabled, not -1
Panu Matilainen [Thu, 8 May 2008 09:40:37 +0000 (12:40 +0300)]
is_selinux_enabled() returns 0 if not enabled, not -1

16 years agoCheck for transaction root sanity in rpmtsSetRootDir()
Panu Matilainen [Thu, 8 May 2008 08:53:42 +0000 (11:53 +0300)]
Check for transaction root sanity in rpmtsSetRootDir()
- only regular paths starting with / permitted
- change prototype to permit return codes

16 years agoSet ts rootdir to /, not empty if rootDir arg is NULL
Panu Matilainen [Thu, 8 May 2008 08:38:52 +0000 (11:38 +0300)]
Set ts rootdir to /, not empty if rootDir arg is NULL
- lets see what break... ;)

16 years agoOnly append trailing slash to ts rootdir if rootdir != "/"
Panu Matilainen [Thu, 8 May 2008 08:27:58 +0000 (11:27 +0300)]
Only append trailing slash to ts rootdir if rootdir != "/"

16 years agoFix up some fuzz in Finnish translation
Panu Matilainen [Thu, 8 May 2008 07:20:39 +0000 (10:20 +0300)]
Fix up some fuzz in Finnish translation

16 years agoFix up / remove some fuzzy German translations
Panu Matilainen [Thu, 8 May 2008 07:07:31 +0000 (10:07 +0300)]
Fix up / remove some fuzzy German translations

16 years agoUpdated Serbian translations from Igor Miletic (rhbz#441101)
Panu Matilainen [Thu, 8 May 2008 07:00:04 +0000 (10:00 +0300)]
Updated Serbian translations from Igor Miletic (rhbz#441101)

16 years agoUpdated Polish translation from Piotr Drąg
Panu Matilainen [Thu, 8 May 2008 06:56:54 +0000 (09:56 +0300)]
Updated Polish translation from Piotr Drąg

16 years agoUpdated German translation from Fabian Affolter (rhbz#438178)
Panu Matilainen [Thu, 8 May 2008 06:53:36 +0000 (09:53 +0300)]
Updated German translation from Fabian Affolter (rhbz#438178)

16 years agoCheck rpmAddSignature() return codes (rhbz#442761)
Panu Matilainen [Thu, 8 May 2008 04:48:51 +0000 (07:48 +0300)]
Check rpmAddSignature() return codes (rhbz#442761)
- headerGetEntry() on RPMTAG_HEADERIMMUTABLE already caught the corrupted
  package, we just didn't paying attention
- make the hge failed error message a bit more meaningful

16 years agoOops, don't access variable after freeing
Panu Matilainen [Wed, 7 May 2008 09:15:22 +0000 (12:15 +0300)]
Oops, don't access variable after freeing

16 years agoOops, plug leak introduced by previous commit
Panu Matilainen [Wed, 7 May 2008 08:33:33 +0000 (11:33 +0300)]
Oops, plug leak introduced by previous commit

16 years agoSimplify doPatch()
Panu Matilainen [Wed, 7 May 2008 08:12:17 +0000 (11:12 +0300)]
Simplify doPatch()
- use %{uncompress} macro to pass files to patch always
- gains support for lzma patches for free

16 years agoPlug another memleak from genCpioListAndHeader()
Panu Matilainen [Wed, 7 May 2008 06:48:39 +0000 (09:48 +0300)]
Plug another memleak from genCpioListAndHeader()
- free fuser + fgroup info instead of NULLing, add comment on side-effects

16 years agorpmfi actions is already alloced by rpmfiNew(), don't leak memory
Panu Matilainen [Wed, 7 May 2008 05:32:36 +0000 (08:32 +0300)]
rpmfi actions is already alloced by rpmfiNew(), don't leak memory

16 years agoEliminate nasty hackery with "special" doc + docdir format
Panu Matilainen [Tue, 6 May 2008 09:48:09 +0000 (12:48 +0300)]
Eliminate nasty hackery with "special" doc + docdir format
- figure out docdir early on in spec parsing, store in package struct
  instead of abusing parse buffer
- fixes memleaks from docdir_fmt and headerSprintf too

16 years agoEliminate static buffer in lua findkey()
Panu Matilainen [Tue, 6 May 2008 07:00:07 +0000 (10:00 +0300)]
Eliminate static buffer in lua findkey()

16 years agoNuke EXPRBUFSIZ, it is now useless
Jindrich Novy [Tue, 6 May 2008 06:47:18 +0000 (08:47 +0200)]
Nuke EXPRBUFSIZ, it is now useless

16 years agoDon't use static buffer for parsing an expression
Jindrich Novy [Tue, 6 May 2008 06:46:50 +0000 (08:46 +0200)]
Don't use static buffer for parsing an expression

16 years agoIndentation fixes
Panu Matilainen [Mon, 5 May 2008 10:52:19 +0000 (13:52 +0300)]
Indentation fixes

16 years agoEliminate static sized string buffer in parseScript()
Panu Matilainen [Mon, 5 May 2008 08:53:48 +0000 (11:53 +0300)]
Eliminate static sized string buffer in parseScript()

16 years agoTrap RPMRC_FAIL returns from spec parse with abort() for now
Panu Matilainen [Mon, 5 May 2008 08:37:08 +0000 (11:37 +0300)]
Trap RPMRC_FAIL returns from spec parse with abort() for now

16 years agoMake readLine() return PART_ERROR on errors
Panu Matilainen [Mon, 5 May 2008 08:31:09 +0000 (11:31 +0300)]
Make readLine() return PART_ERROR on errors

16 years agoFix (hopefully ;) signaling for line continuations on spec parsing
Panu Matilainen [Mon, 5 May 2008 08:27:49 +0000 (11:27 +0300)]
Fix (hopefully ;) signaling for line continuations on spec parsing

16 years agoIndentation fixes
Panu Matilainen [Mon, 5 May 2008 08:20:13 +0000 (11:20 +0300)]
Indentation fixes

16 years agoMake parseSpec() return PART_ERROR on all errors
Panu Matilainen [Mon, 5 May 2008 08:15:12 +0000 (11:15 +0300)]
Make parseSpec() return PART_ERROR on all errors
- also fix memleak from buildroot errors

16 years agoMake parseFiles() return PART_ERROR on failure
Panu Matilainen [Mon, 5 May 2008 08:00:45 +0000 (11:00 +0300)]
Make parseFiles() return PART_ERROR on failure
- streamline exits by assuming failure

16 years agoMake parseScript() return PART_ERROR on errors
Panu Matilainen [Mon, 5 May 2008 07:56:55 +0000 (10:56 +0300)]
Make parseScript() return PART_ERROR on errors
- streamline exists by assuming failure

16 years agoMake parseDescription() return PART_ERROR on errors
Panu Matilainen [Mon, 5 May 2008 07:46:43 +0000 (10:46 +0300)]
Make parseDescription() return PART_ERROR on errors

16 years agoMake parseChangeLog() return PART_ERROR on errors
Panu Matilainen [Mon, 5 May 2008 07:42:41 +0000 (10:42 +0300)]
Make parseChangeLog() return PART_ERROR on errors
- streamline exits, fixing memleak from stringbuf on various paths

16 years agoMake parseBuildInstallClean() return PART_ERROR on errors, streamline exits
Panu Matilainen [Mon, 5 May 2008 07:34:33 +0000 (10:34 +0300)]
Make parseBuildInstallClean() return PART_ERROR on errors, streamline exits

16 years agoMake parsePrep() return PART_ERROR on errors
Panu Matilainen [Mon, 5 May 2008 07:24:22 +0000 (10:24 +0300)]
Make parsePrep() return PART_ERROR on errors

16 years agoStreamline parsePreamble() exists
Panu Matilainen [Mon, 5 May 2008 07:08:33 +0000 (10:08 +0300)]
Streamline parsePreamble() exists
- assume failure, single point of exit
- fixes memleak from NVR
- use PART_ERROR for error exits

16 years agoStart cleaning up the rpmerr removal mess of build/ return codes
Panu Matilainen [Mon, 5 May 2008 06:51:14 +0000 (09:51 +0300)]
Start cleaning up the rpmerr removal mess of build/ return codes
- define PART_ERROR for error returns from various parse bits,
  teach parseSpec() about it
- streamline parseSpec() exists

16 years agoRemove obsolete parseForRegexLang()
Jindrich Novy [Mon, 5 May 2008 06:12:04 +0000 (08:12 +0200)]
Remove obsolete parseForRegexLang()
- no use for it since _langpatt is now gone

16 years agomacros.in cleanup
Jindrich Novy [Mon, 5 May 2008 06:05:50 +0000 (08:05 +0200)]
macros.in cleanup
- really deprecate _langpatt
- obsolete _package_version
- use paths more conforming to FHS
- fix typos

16 years agoUse fprintf() for writing PGP passphrase (like we do for GPG)
Panu Matilainen [Mon, 5 May 2008 05:38:57 +0000 (08:38 +0300)]
Use fprintf() for writing PGP passphrase (like we do for GPG)
- avoids having two separate write()'s to check
- ...if we actually checked the result, gcc doesn't whine about
  unchecked fprintf() return...

16 years agoCheck for pipe() returns on GPG and PGP signature creation
Panu Matilainen [Mon, 5 May 2008 05:27:07 +0000 (08:27 +0300)]
Check for pipe() returns on GPG and PGP signature creation

16 years agoCheck for pipe() returns in rpmfc helper output reading
Panu Matilainen [Mon, 5 May 2008 05:23:24 +0000 (08:23 +0300)]
Check for pipe() returns in rpmfc helper output reading

16 years agoSilence bogus warning on memset()
Panu Matilainen [Mon, 5 May 2008 05:15:17 +0000 (08:15 +0300)]
Silence bogus warning on memset()
- gcc doesn't realize shrank == 0 would terminate the process via error()
  before reaching memset(), work around...

16 years agoCheck for pipe() return code on --pipe
Panu Matilainen [Mon, 5 May 2008 04:37:50 +0000 (07:37 +0300)]
Check for pipe() return code on --pipe

16 years agoAdd missing include
Panu Matilainen [Sat, 3 May 2008 09:44:16 +0000 (12:44 +0300)]
Add missing include

16 years agoInitialize nb before use
Panu Matilainen [Sat, 3 May 2008 09:43:37 +0000 (12:43 +0300)]
Initialize nb before use

16 years agoCreate signature target rpm in same directory as original
Panu Matilainen [Sat, 3 May 2008 09:38:02 +0000 (12:38 +0300)]
Create signature target rpm in same directory as original
- rename() doesn't work across devices, oops...

16 years agoTemp file handling tweaks
Panu Matilainen [Sat, 3 May 2008 09:34:19 +0000 (12:34 +0300)]
Temp file handling tweaks
- rename rpmMkTemp() (back) to rpmMkTempFile()
- rpmMkTemp() is now a lower level thin wrapper around mkstemp()

16 years agorpmReSign() doesn't return rpmRC codes, make it more obvious
Panu Matilainen [Sat, 3 May 2008 07:36:00 +0000 (10:36 +0300)]
rpmReSign() doesn't return rpmRC codes, make it more obvious
- cleanup "rc = RPMRC_FAIL" copy-paste leftovers

16 years agoEliminate static sized string buffer frpm rpmReSign()
Panu Matilainen [Sat, 3 May 2008 07:27:16 +0000 (10:27 +0300)]
Eliminate static sized string buffer frpm rpmReSign()
- use rpmMkTemp() for creating the temp file instead of insecure
  close(mkstemp())

16 years agoCheck for arch compatibility on multilib too
Panu Matilainen [Fri, 2 May 2008 08:48:27 +0000 (11:48 +0300)]
Check for arch compatibility on multilib too

16 years agoEnsure default SIGPIPE handler for --pipe (rhbz#444389)
Panu Matilainen [Fri, 2 May 2008 08:40:29 +0000 (11:40 +0300)]
Ensure default SIGPIPE handler for --pipe (rhbz#444389)

16 years agoRIP alloca()
Panu Matilainen [Wed, 30 Apr 2008 11:38:09 +0000 (14:38 +0300)]
RIP alloca()

16 years agoRewrite xmlFormat() and remove useless xmlstrlen() and xmlstrcpy()
Jindrich Novy [Wed, 30 Apr 2008 11:24:51 +0000 (13:24 +0200)]
Rewrite xmlFormat() and remove useless xmlstrlen() and xmlstrcpy()

16 years agoKill of alloca() from tufdio tests
Panu Matilainen [Wed, 30 Apr 2008 10:34:28 +0000 (13:34 +0300)]
Kill of alloca() from tufdio tests
- yes it leaks, who cares

16 years agoLazily copy basenames in relocation if needed
Panu Matilainen [Wed, 30 Apr 2008 10:30:54 +0000 (13:30 +0300)]
Lazily copy basenames in relocation if needed
- couple of tiny array helper funcs to push stuff out of relocateFileList()
  instead of adding yet more gunk
- use the helpers for dirnames too

16 years agoSimplify relocation directory name manipulation
Panu Matilainen [Wed, 30 Apr 2008 09:45:16 +0000 (12:45 +0300)]
Simplify relocation directory name manipulation

16 years agoDon't use alloca in rpmal.c
Jindrich Novy [Wed, 30 Apr 2008 09:39:49 +0000 (11:39 +0200)]
Don't use alloca in rpmal.c

16 years agoAllocate relocation dirnames on heap, not stack
Panu Matilainen [Wed, 30 Apr 2008 09:29:40 +0000 (12:29 +0300)]
Allocate relocation dirnames on heap, not stack

16 years agoDon't use alloca() in fpsCompare()
Jindrich Novy [Wed, 30 Apr 2008 08:32:33 +0000 (10:32 +0200)]
Don't use alloca() in fpsCompare()

16 years agoBegin untangling relocation alloca()'s
Panu Matilainen [Wed, 30 Apr 2008 07:32:57 +0000 (10:32 +0300)]
Begin untangling relocation alloca()'s
- allocate rpmRelocation paths on heap, not stack

16 years agoKill the remaining alloca in fp doLookup()
Panu Matilainen [Wed, 30 Apr 2008 07:05:48 +0000 (10:05 +0300)]
Kill the remaining alloca in fp doLookup()

16 years agoOne alloca() down in fp doLookup()
Panu Matilainen [Wed, 30 Apr 2008 06:47:25 +0000 (09:47 +0300)]
One alloca() down in fp doLookup()
- single point of exit from the point where buf gets allocated

16 years agoPlug a memleak in lzclose()
Panu Matilainen [Tue, 29 Apr 2008 14:38:21 +0000 (17:38 +0300)]
Plug a memleak in lzclose()

16 years agoPlug memleak in parseSimplePart()
Panu Matilainen [Tue, 29 Apr 2008 14:09:07 +0000 (17:09 +0300)]
Plug memleak in parseSimplePart()

16 years agoPlug memleak in macro doFoo()
Panu Matilainen [Tue, 29 Apr 2008 14:04:08 +0000 (17:04 +0300)]
Plug memleak in macro doFoo()

16 years agoDon't use alloca in rpmGenPath()
Jindrich Novy [Tue, 29 Apr 2008 14:08:19 +0000 (16:08 +0200)]
Don't use alloca in rpmGenPath()

16 years agoCalm down compiler warnings due to fsm->patch being const
Jindrich Novy [Tue, 29 Apr 2008 13:40:20 +0000 (15:40 +0200)]
Calm down compiler warnings due to fsm->patch being const

16 years agoMerge branch 'master' of ssh://login.linux.duke.edu/home/groups/rpm/git/rpm
Jindrich Novy [Tue, 29 Apr 2008 13:01:53 +0000 (15:01 +0200)]
Merge branch 'master' of ssh://login.linux.duke.edu/home/groups/rpm/git/rpm

16 years agoAvoid general ETXBSY and allow it for HP-UX exclusively
Jindrich Novy [Tue, 29 Apr 2008 13:01:05 +0000 (15:01 +0200)]
Avoid general ETXBSY and allow it for HP-UX exclusively
- for more info: http://www.uwsg.iu.edu/hypermail/linux/kernel/9808.3/0883.html
- remove the rest of alloca()s

16 years agoRemove useless alloca_strdup()
Jindrich Novy [Tue, 29 Apr 2008 12:59:18 +0000 (14:59 +0200)]
Remove useless alloca_strdup()
- and yet more alloca usage in writeFile()

16 years agoRemove unused alloca_strdup() define
Panu Matilainen [Tue, 29 Apr 2008 12:50:43 +0000 (15:50 +0300)]
Remove unused alloca_strdup() define

16 years agoAllocate directory names on heap in compressFilelist()
Panu Matilainen [Tue, 29 Apr 2008 12:08:47 +0000 (15:08 +0300)]
Allocate directory names on heap in compressFilelist()

16 years agoUse rpmGetPath() to construct full dbpath in db3open()
Panu Matilainen [Tue, 29 Apr 2008 11:44:28 +0000 (14:44 +0300)]
Use rpmGetPath() to construct full dbpath in db3open()
- another alloca() bites the dust...