Nicolas Portmann [Fri, 18 Jan 2019 06:34:15 +0000 (07:34 +0100)]
Remove unnecessary checks in ConsumeNumber (dotnet/corefx#33294) (dotnet/corefx#34500)
* Remove unnecessary checks in ConsumeNumber (dotnet/corefx#33294)
* Remove unnecessary _isNotPrimitive check
Commit migrated from https://github.com/dotnet/corefx/commit/
d2b28cc506e5858dccdd388e2c8189d10e5687f9
Roman Marusyk [Fri, 18 Jan 2019 04:54:53 +0000 (06:54 +0200)]
Utf8JsonReader throw when isFinal is true and the first call to Read returns false (dotnet/corefx#34155)
* Utf8JsonReader throw when isFinal is true and the first call to Read returns false
* Fix unit tests
* Code review fixes
* Fix unit test
* Fix unit test
* Fixes after code review
Commit migrated from https://github.com/dotnet/corefx/commit/
4431b3c63cbe121e5587c6bc6b18c69e80385b14
Matt Mitchell [Fri, 18 Jan 2019 01:53:51 +0000 (17:53 -0800)]
Merge pull request dotnet/corefx#34658 from chcosta/addlocation
Add Location info to asset manifest
Commit migrated from https://github.com/dotnet/corefx/commit/
d8c200414ccf65e0be94358937e9c711c0fd532d
Stephen Toub [Fri, 18 Jan 2019 01:07:12 +0000 (20:07 -0500)]
Move Environment to shared CoreLib (dotnet/corefx#34654)
Rather than having Environment partially live in corefx and call into an EnvironmentAugments type in CoreLib that in turn calls into an Environment type in CoreLib, we're just moving Environment to live in CoreLib.
To start that, this PR moves Environment and its dependencies from their current locations into the shared CoreLib. Those changes will mirror over to coreclr. After that, I'll fix it up to work in CoreLib. And once those changes are built and available back to corefx, I'll update System.Runtime.Extensions to just use the functionality from CoreLib and delete remaining unnecessary code from corefx.
Commit migrated from https://github.com/dotnet/corefx/commit/
b2d890a311ff66857339c7dae493efa43237284c
dotnet-maestro-bot [Fri, 18 Jan 2019 00:29:55 +0000 (16:29 -0800)]
Update BuildTools to preview1-03617-02 (dotnet/corefx#34656)
Commit migrated from https://github.com/dotnet/corefx/commit/
34ce0d08ee59fe1a64d547c2088fbe4c5062f038
Christopher Costa [Thu, 17 Jan 2019 23:59:47 +0000 (15:59 -0800)]
Add Location info to asset manifest
Commit migrated from https://github.com/dotnet/corefx/commit/
8c2107c72495780dac61dd3a2b14518a165ab786
Eugene Rozenfeld [Thu, 17 Jan 2019 23:55:59 +0000 (15:55 -0800)]
Merge pull request dotnet/corefx#34653 from erozenfeld/FixExceptionTest
Fix ThrowAndRethrowOtherMethod test.
Commit migrated from https://github.com/dotnet/corefx/commit/
2fc5a59589d07ea4f2f5bd2bcce987100e24eaa6
Santiago Fernandez Madero [Thu, 17 Jan 2019 23:45:04 +0000 (15:45 -0800)]
Change all configurations PR job to use non-hosted pool for more space in machines (dotnet/corefx#34655)
Commit migrated from https://github.com/dotnet/corefx/commit/
d322f797e3d5c94496ae6f38cce5f6afaa1d2ecd
Maryam Ariyan [Thu, 17 Jan 2019 23:21:30 +0000 (15:21 -0800)]
Removing assertion not true for all events (dotnet/corefx#34650)
Commit migrated from https://github.com/dotnet/corefx/commit/
caebf8a1173d4f09bcf3007aa8607f981e8ec9af
Stephen Toub [Thu, 17 Jan 2019 22:03:41 +0000 (17:03 -0500)]
Use RemoteInvoke with tracing tests (dotnet/corefx#34645)
Various test projects validate that EventSource data is being appropriately generated. Since these tests can run concurrently with others in the process, they should be done as out-of-process such that they don't interfere with each other, but some test projects aren't doing that. This fixes that, ensuring we're using RemoteInvoke everywhere we should be.
Commit migrated from https://github.com/dotnet/corefx/commit/
827f91c666c2b40e078c3f1df7a7e5ab13781eaa
Fred Silberberg [Thu, 17 Jan 2019 21:58:29 +0000 (13:58 -0800)]
Renamed Microsoft.VisualBasic to Microsoft.VisualBasic.Core (dotnet/corefx#34087)
* Renamed Microsoft.VisualBasic to Microsoft.VisualBasic.Core
Part of porting Microsoft.VisualBasic to core. A facade for
Microsoft.VisualBasic is now generated in place of the original dll so
existing applications will be able to continue with the same set of
references.
* Addressed feedback
* Address PR feedback.
* Continued work on renaming
* Remove package for Microsoft.VisualBasic.Core and make API additions framework specific
(cherry picked from commit dotnet/corefx@
0ef22b502e77b06f68e97e0614144da8c05b08ef)
* Fix test Configurations
* Fix VB test build for UAP
* PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
90dc9459b8eaf0c8ac93440e58c7535c67dacc22
Eugene Rozenfeld [Thu, 17 Jan 2019 21:11:46 +0000 (13:11 -0800)]
Fix ThrowAndRethrowOtherMethod test.
ThrowAndRethrowOtherMethod is sensitive to jit inlining decisions.
In particular, it fails if the jit decides to inline ThrowException.
That can happen with, e.g., random inlining policy.
In that case the stack trace doesn't have frame info for ThrowException
and VerifyCallStack skips the wrong frame.
One of the jit stress legs is failing because of that:
https://github.com/dotnet/coreclr/issues/21644 .
The fix is to ensure that ThrowException is not inlined.
Commit migrated from https://github.com/dotnet/corefx/commit/
165e71266f79025209f293dd26d755a1c268f40c
Ahson Khan [Thu, 17 Jan 2019 20:52:13 +0000 (12:52 -0800)]
Fix outerloop JsonWriter test by creating new instance of the writer when writing invalid JSON (dotnet/corefx#34637)
* Re-initialize json writer within invalid test that throws to avoid writing a value in a JSON object.
* Uncomment outerloop attribute.
Commit migrated from https://github.com/dotnet/corefx/commit/
54f3a59c5e0cd0db90e9c74cd11eebfd28f028b7
Ahson Khan [Thu, 17 Jan 2019 20:50:48 +0000 (12:50 -0800)]
Update S.T.Json sources with ifdefs so that a netstandard compatible source package can be produced (dotnet/corefx#34611)
* Test changes necessary to build S.T.Json sources targetting netstandard
* Revert unnecessary change from private to internal.
* Revert props and csproj changes to support netstandard along with test
changes.
* Address PR feedback.
* Revert "Revert props and csproj changes to support netstandard along with test"
This reverts commit dotnet/corefx@
7a2f22e127c4ef0476f20bddd64796045f79ddb5.
* Fix code formatting/spacing.
* Invert the ifdef so it is false by default (for source package) and add
comments.
Commit migrated from https://github.com/dotnet/corefx/commit/
36893daefdc114306efe86eca4170836bc02ff68
Stephen Toub [Thu, 17 Jan 2019 20:13:56 +0000 (15:13 -0500)]
Avoid unnecessary Span to ReadOnlySpan casts (dotnet/corefx#34646)
In a bunch of places we're creating a Span only to then cast it (generally implicitly) to a ReadOnlySpan. While the JIT is generally able to do the RightThing(tm), we can avoid the unnecessary IL and pressure on the JIT by just creating a ReadOnlySpan to begin with.
Commit migrated from https://github.com/dotnet/corefx/commit/
ab925533fade636748f5d932546e1ce2fe33c1dd
Matt Mitchell [Thu, 17 Jan 2019 19:17:51 +0000 (11:17 -0800)]
Change to build each commit (dotnet/corefx#34644)
Commit migrated from https://github.com/dotnet/corefx/commit/
31a9af82c15e4553cec9d10c1d0ce55c86b93df9
Santiago Fernandez Madero [Wed, 16 Jan 2019 00:50:54 +0000 (16:50 -0800)]
Disable System.Drawing.Common flaky tests
Commit migrated from https://github.com/dotnet/corefx/commit/
ea36815081fcc8dfac19dfe7343db77c33803a61
Santiago Fernandez Madero [Fri, 4 Jan 2019 00:24:27 +0000 (16:24 -0800)]
Enable Azure Devops CI leg for PRs
Commit migrated from https://github.com/dotnet/corefx/commit/
efc74834dccabb4d1b779a549b942c9d2c0069fa
Swaroop Sridhar [Thu, 17 Jan 2019 16:57:11 +0000 (08:57 -0800)]
Expose NativeLibrary APIs (dotnet/corefx#34567)
Expose the System.Runtime.Interop.NativeLibrary APIs implemented in CoreCLR.
API review: dotnet/corefx#32015
CoreCLR Change: https://github.com/dotnet/coreclr/pull/21821
Tests for the API are here:
https://github.com/dotnet/coreclr/blob/master/tests/src/Interop/NativeLibrary/NativeLibraryTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
5241ad4927d1a124976ea7de5f0f610a2c7be777
dotnet-maestro-bot [Thu, 17 Jan 2019 13:41:25 +0000 (05:41 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27317-00, beta-27317-00, respectively (dotnet/corefx#34634)
Commit migrated from https://github.com/dotnet/corefx/commit/
be1557ae32a0f652d6e3af47c840d307b6555573
Adeel Mujahid [Thu, 17 Jan 2019 09:26:47 +0000 (11:26 +0200)]
Enable official portable musl build (dotnet/corefx#34352)
* Enable portable builds in linux-musl.groovy
* Enable official portable musl build
* Add back Windowws_NT condition
Commit migrated from https://github.com/dotnet/corefx/commit/
1072799465f41315f2d041e09db17e0390445739
Afsaneh Rafighi [Wed, 16 Jan 2019 23:04:38 +0000 (15:04 -0800)]
Merge pull request dotnet/corefx#34134 from Wraith2/sqlperf-asynchelper
SqlClient minor memory improvements
Commit migrated from https://github.com/dotnet/corefx/commit/
abd0482315951333d051abdac89b33f2985aba0a
Layomi Akinrinade [Wed, 16 Jan 2019 19:59:47 +0000 (14:59 -0500)]
Add roundtrip tests for EncoderNLS and DecoderNLS (dotnet/corefx#34610)
This increases code coverage for System.Text.Encoding.Codepages from
68.9% to 74.5%.
Commit migrated from https://github.com/dotnet/corefx/commit/
4febb444f82cabed2b3df186bcc8e9ad0b31dbf9
dotnet-maestro-bot [Wed, 16 Jan 2019 17:24:47 +0000 (09:24 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19066.1, beta-27316-00, beta-27316-00, respectively (dotnet/corefx#34614)
Commit migrated from https://github.com/dotnet/corefx/commit/
536ef01e18d6b3b2e7ef74057d0772c3daf893fa
Sven Boemer [Wed, 16 Jan 2019 06:28:19 +0000 (22:28 -0800)]
Consume coreclr dependencies (dotnet/corefx#34169)
* Consume coreclr dependencies using new dependency flow
* Use consistent casing for new package versions
* Use dotnet-coreclr source in Directory.Build.props, NuGet.config, and symbol asset urls
Directory.Build.props is used for packagereferences, NuGet.config is used for assets in global.json, and constructed urls are used to download symbols.
Commit migrated from https://github.com/dotnet/corefx/commit/
23a05d37db809e2fb76db60abb80e6f8ed5168a6
Jeremy Koritzinsky [Wed, 16 Jan 2019 03:38:49 +0000 (19:38 -0800)]
Expose System.Runtime.Loader.AssemblyDependencyResolver. (dotnet/corefx#34484)
* Expose AssemblyDependencyResolver.
* PR feedback.
* Update ApiCompatBaseline.
Commit migrated from https://github.com/dotnet/corefx/commit/
fa50c5c55b47e14e0da26a4be940347ec71b2885
Roman Marusyk [Wed, 16 Jan 2019 01:19:31 +0000 (03:19 +0200)]
System.Management. Refactor DllImports (dotnet/corefx#34477)
* System.Management. Refactor DllImports
Commit migrated from https://github.com/dotnet/corefx/commit/
290538004e795df183e7fd7c583cb28d6d243346
Stephen Toub [Wed, 16 Jan 2019 00:55:56 +0000 (19:55 -0500)]
Test to validate that TaskCompletionSource doesn't capture ExecutionContext (dotnet/corefx#34587)
Commit migrated from https://github.com/dotnet/corefx/commit/
db7daabdb592da062d8a80f27bbad1178c364530
Stephen Toub [Wed, 16 Jan 2019 00:55:30 +0000 (19:55 -0500)]
Merge pull request dotnet/corefx#34451 from stephentoub/teststringconcat
Expose/test/use string.Concat(ReadOnlySpan, ...)
Commit migrated from https://github.com/dotnet/corefx/commit/
34078a7d3259c6b2d929949babde3a24f9a03e84
Karel Zikmund [Wed, 16 Jan 2019 00:43:28 +0000 (16:43 -0800)]
Add area-System.Numerics.Tensors
Commit migrated from https://github.com/dotnet/corefx/commit/
c5f4baf47cc952b29432300305f5d69129cd7f34
Ahson Khan [Tue, 15 Jan 2019 22:42:39 +0000 (14:42 -0800)]
Add Utf8JsonWriter along with unit tests (dotnet/corefx#34425)
* Move JsonReader related files to the Reader directory.
* Update S.T.Json ref to include new JsonWriter APIs.
* Port initial JsonWriter files from corefxlab.
* Auto-generate System.Text.Json ref to update the ordering for
consistency.
* Fixed some TODOs, delete dead code, and formatting cleanup.
* Make use of self-descriptive constants where possible.
* Fix leftover TODOs and update throw helper/exception messages.
* Add xml comments/docs to the public surface area.
* Add JsonWriter unit tests.
* Change GetCurrentState back to a property and explicitly Flush on the
callers behalf instead of throwing.
* Save current depth as part of state and update tests.
* Fix constant names, account for quotes in bytes needed, and add fixed buffer writer tests.
* Fix inconsistent use of braces by adding them for single line ifs
* Update parameter name to exclude encoding.
* Remove JsonWriterException and use InvalidOperationException instead.
* Use Rune and Utf8Formatter/TryFormat in more places and remove
UnicodeScalar.
* Fix nits, typos, and reorder field assignment and method calls.
* Pass spans by in (or by value) instead of by ref.
* Update comments and remove unnecessary test.
* Remove some aggressive inlining and pass spans by value rather than in
* Update comments, dont compute bytes needed, and use if instead of loop before advancing.
* Reduce code bloat by removing duplciate calls to ValidateX.
* Add details on how .NET types are formatted to comments.
* Reduce code duplication when writing values.
* Change the StandardFormat used for DateTime(Offset) to 'O'
* Refactor calculating the maximum escaped length to a helper.
* Remove unnecessary checks and rename locals to be more descriptive.
* Rename suppressEscaping to escape and flip default from false to true.
* Comment cleanup, add debug.asserts, and move transcoding helpers to a
separate file.
* Increase the deicmal max size to account for sign and add tests.
* Rename ROS<byte> property name and value params to include utf8 in the
name.
* Remove redundant code where idx is set to 0 unnecessarily.
* Remove dead code (dont escape forward slash) and make tests culture
invariant.
Commit migrated from https://github.com/dotnet/corefx/commit/
f84927d4a85444e63ede2da38a49eff7116790db
Stephen Toub [Tue, 15 Jan 2019 21:52:54 +0000 (16:52 -0500)]
Merge pull request dotnet/corefx#34596 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27315-02, preview.19065.1, beta-27315-00, beta-27315-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
2fde649511160865d09398e657645489a669182a
Stephen Toub [Tue, 15 Jan 2019 19:14:49 +0000 (14:14 -0500)]
Fix ManualResetValueTaskSource tests missing event Waits (dotnet/corefx#34603)
These are sporadically failing because they're missing required .Wait() calls on an event that gets set.
Commit migrated from https://github.com/dotnet/corefx/commit/
c0da1a5b0b5028e43ea5ad5369672f298b272daa
Tomas Weinfurt [Tue, 15 Jan 2019 18:20:56 +0000 (10:20 -0800)]
skip SetDateTimeMax test on 32b Unix platforms (dotnet/corefx#34595)
* skip SetDateTimeMax test on 32b Unix platforms
* s/OsHasMaxTime/SupportsLongMaxDateTime/g
Commit migrated from https://github.com/dotnet/corefx/commit/
403deb436d91dcad4340fa45520d307767d297c9
Stephen Toub [Tue, 15 Jan 2019 15:35:05 +0000 (10:35 -0500)]
Undo workarounds for CoreLib types
Commit migrated from https://github.com/dotnet/corefx/commit/
94c43e147d6aac8de3f9d6ad8f4db5881b1007df
Tarek Mahmoud Sayed [Sat, 12 Jan 2019 00:26:11 +0000 (16:26 -0800)]
Update TimeSpan Parsing Test
Commit migrated from https://github.com/dotnet/corefx/commit/
a58777883c9102f9586dd723e2d4ba35aeedf0ef
dotnet-maestro-bot [Tue, 15 Jan 2019 06:16:40 +0000 (22:16 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27315-01, preview.19064.4, beta-27315-00, beta-27315-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
cc7ff9490ae7ba898d531ae4174cb43af9881f05
Santiago Fernandez Madero [Tue, 15 Jan 2019 01:23:33 +0000 (17:23 -0800)]
Consume core-setup using darc (dotnet/corefx#34344)
* Consume core-setup using darc
* Import versions.props in package tests now that versions where moved
* Run darc update with latest core-setup build
Commit migrated from https://github.com/dotnet/corefx/commit/
6df97f7e9434a34e62288444993cf6e782c44191
Nicolas Portmann [Mon, 14 Jan 2019 23:29:07 +0000 (00:29 +0100)]
Utf8JsonReader should store if parsed number contains exponent (dotnet/corefx#34386)
* Store if number contains exponent
* Store number format directly
Commit migrated from https://github.com/dotnet/corefx/commit/
60f871b05ac8db8de316dc9ed5e7647808011225
Jeremy Koritzinsky [Mon, 14 Jan 2019 23:24:18 +0000 (15:24 -0800)]
Remove flaky ReadByte assert. (dotnet/corefx#34589)
* Remove flaky ReadByte assert.
We've hit the flaky assert in the Marshal.ReadByte test. I don't think that this test is worth the flaky-ness in the `Byte` case, so I'm just going to remove this assert and bring it back to how it was beforehand. Fixes dotnet/corefx#34579.
See dotnet/corefx#34445.
cc: @AaronRobinsonMSFT
* Update ByteTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
4d82935de75cff4893efbc1340626995601e49dc
dotnet-maestro-bot [Sun, 13 Jan 2019 16:53:51 +0000 (08:53 -0800)]
Update CoreClr, CoreFx to preview-27312-01, preview.19063.1, respectively (dotnet/corefx#34571)
Commit migrated from https://github.com/dotnet/corefx/commit/
77096755443730962810662501f82550fdb4656d
Stephen Toub [Sat, 12 Jan 2019 16:22:45 +0000 (11:22 -0500)]
Merge pull request dotnet/corefx#34549 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27311-02, preview.19061.1, beta-27311-00, beta-27311-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
6ba7d88d9eea91d38f8580546be6319e0e09880c
Dan Moseley [Sat, 12 Jan 2019 15:21:20 +0000 (07:21 -0800)]
Disable SyncRoot test for NETFX (dotnet/corefx#34563)
* Disable SyncRoot test for NETFX
* comment
Commit migrated from https://github.com/dotnet/corefx/commit/
6b5bd3d6cad1ef334a0a1d7122ecb875152d5742
Stephen Toub [Fri, 11 Jan 2019 19:39:15 +0000 (14:39 -0500)]
Work around OperationStatus's move to CoreLib
In coreclr, but not yet in .NET Native
Commit migrated from https://github.com/dotnet/corefx/commit/
19614806d5c8e01da387db704cd18a82d096354d
Stephen Toub [Fri, 11 Jan 2019 18:37:21 +0000 (13:37 -0500)]
Temporarily work around lack of types in uapaot
Commit migrated from https://github.com/dotnet/corefx/commit/
128c263061d157aaac1f34bf0e6163f76a436492
Stephen Toub [Fri, 11 Jan 2019 17:21:38 +0000 (12:21 -0500)]
Delete DefaultParameterValueAttribute after its move to Corelib
Commit migrated from https://github.com/dotnet/corefx/commit/
7e2b7adc5cf469dd30cd77913e3585db33802815
Stephen Toub [Fri, 11 Jan 2019 17:12:22 +0000 (12:12 -0500)]
Delete ComEventInterfaceAttribute after its move to CoreLib
Commit migrated from https://github.com/dotnet/corefx/commit/
07fc7043711eeb00007c1a0d800ce460c4540c19
Stephen Toub [Thu, 10 Jan 2019 20:31:51 +0000 (15:31 -0500)]
Expose/test WithCancellation for async enumerables
Commit migrated from https://github.com/dotnet/corefx/commit/
74a04273fb5219210c69d6d117fc29af26017721
Jan Kotas [Wed, 9 Jan 2019 17:29:57 +0000 (09:29 -0800)]
Unify DispatchWrapper behavior for null
Commit migrated from https://github.com/dotnet/corefx/commit/
8ab09a414c2a1afd1fd974bd4d937822f3c2f74a
dotnet-maestro-bot [Fri, 11 Jan 2019 15:24:02 +0000 (07:24 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27311-02, preview.19061.1, beta-27311-00, beta-27311-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
2d3c7c630ac0b079ac4f620b88edc9cfe29124f4
Dan Moseley [Sat, 12 Jan 2019 01:28:42 +0000 (17:28 -0800)]
Disable some tests from Windows IoT
Commit migrated from https://github.com/dotnet/corefx/commit/
8818a22e116abe547e49046bc5b61466401003f3
Andrew Au [Sat, 12 Jan 2019 00:36:12 +0000 (16:36 -0800)]
Merge pull request dotnet/corefx#34556 from cshung/dev/andrewau/eventcounter-blog-updates
Update EventCounter blog with visualization
Commit migrated from https://github.com/dotnet/corefx/commit/
a53ada190e2e0bd229e76ae4a6d45c13a986ab18
Santiago Fernandez Madero [Fri, 11 Jan 2019 22:34:09 +0000 (14:34 -0800)]
Fix UAP Helix source to match mission control config (dotnet/corefx#34557)
Commit migrated from https://github.com/dotnet/corefx/commit/
8fa7094c5609b496cedf742359fe779335e9bb8e
Caesar Chen [Fri, 11 Jan 2019 22:34:02 +0000 (14:34 -0800)]
Fix CVE-2019-0545: .NET Core Information Disclosure Vulnerability (.NET Core 3.0) (dotnet/corefx#34507)
* fix 100-continue issues
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
04b237b2f91ae4b4bb709fa60b51fa6ad7f4bc97
Andrew Au [Fri, 11 Jan 2019 21:54:54 +0000 (13:54 -0800)]
Update EventCounter blog with visualization
Commit migrated from https://github.com/dotnet/corefx/commit/
6363a11e0509ab47c3097c87a123ac10bc0a76e9
Santiago Fernandez Madero [Fri, 11 Jan 2019 21:18:16 +0000 (13:18 -0800)]
Remove trailing / from helix source to match mission control info (dotnet/corefx#34554)
Commit migrated from https://github.com/dotnet/corefx/commit/
6076353a274100b6839570fe2fca2ee395014a30
Stephen Toub [Fri, 11 Jan 2019 16:11:34 +0000 (11:11 -0500)]
Disable EventLogRecordTests.FormatDescription test that's failing frequently (dotnet/corefx#34548)
Commit migrated from https://github.com/dotnet/corefx/commit/
1d6e44b7d98501c36b2a407b351201f091f99744
Kurt Schelfthout [Fri, 11 Jan 2019 15:02:37 +0000 (15:02 +0000)]
Properly Dispose SocketAsyncEventArgs' FileStreams. (dotnet/corefx#34331)
* Properly Dispose SocketAsyncEventArgs' FileStreams.
* Add a test.
* Make the first call in the test succeed.
Otherwise the socket might be disconnected in error by the time we get to the second call.
* Skip test on .net framework as that does not have the fix.
* Fix comment.
Commit migrated from https://github.com/dotnet/corefx/commit/
9ec2919fbd8d4ea955bf175e922dcb2777fe9ef5
Tanner Gooding [Fri, 11 Jan 2019 05:39:06 +0000 (21:39 -0800)]
Removing some ApiCompat workarounds (dotnet/corefx#34504)
* Removing some IgnoredTypes entries for System.Memory
* Removing the ApiCompatBaseline for System.Runtime.Intrinsics
Commit migrated from https://github.com/dotnet/corefx/commit/
8f7b490ca874ee2a9f11f0163412f7c95811298b
Santiago Fernandez Madero [Fri, 11 Jan 2019 00:47:20 +0000 (16:47 -0800)]
Disable Tizen leg from PRs while move to the new system (dotnet/corefx#34533)
Commit migrated from https://github.com/dotnet/corefx/commit/
01fd0c22869c67bbf8f722db2c64ae71bbbbc456
dotnet-maestro-bot [Thu, 10 Jan 2019 22:00:46 +0000 (14:00 -0800)]
Update CoreFx to preview.19060.1 (dotnet/corefx#34495)
Commit migrated from https://github.com/dotnet/corefx/commit/
12676b01a9b31f8050725ada7ceaacadc596ae55
Wraith2 [Thu, 10 Jan 2019 19:57:09 +0000 (19:57 +0000)]
fix merge conflict
Commit migrated from https://github.com/dotnet/corefx/commit/
1d5308cfa85c1b9c05874f0aa6b4a9396797750f
Eric StJohn [Thu, 10 Jan 2019 19:53:22 +0000 (11:53 -0800)]
Exclude apphost.exe from test shared framework (dotnet/corefx#34496)
* Exclude apphost.exe from test shared framework
We do not need apphost.exe and the 3.0 SDK will actually remove it.
Exclude here so that when building with the 2.x SDK we don't place it in the test shared framework.
This can be removed once we have a new SDK
This is necessary because folks doing a build.cmd use the 2.x SDK when building the product
and get a shared framework with AppHost.exe in it. Then they do an incremental build with
whatever SDK is on their machine, if it is 3.0 it removes apphost.exe (due to incremental clean)
and then tests fail to run. Fixes dotnet/corefx#34455
* Simplify some package references
Commit migrated from https://github.com/dotnet/corefx/commit/
0c5d35e65254a9a57e4bd6eb59e5e6c7f36d3789
Caesar Chen [Thu, 10 Jan 2019 19:44:21 +0000 (11:44 -0800)]
Fix CookieContainer memory leak (dotnet/corefx#34006)
* fix CookieContainer memory leak
* disable test on netfx
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
41e4a8c74f8cdb4843c6d11a404ad094b54ae992
Wraith2 [Thu, 10 Jan 2019 19:41:59 +0000 (19:41 +0000)]
SqlClient improve managed memory usage (dotnet/corefx#34234)
* add missing packet disposal calls
remove temporary array use with mux header
* revert to using array in mux header
* mark MarsConnection mux header as readonly
Commit migrated from https://github.com/dotnet/corefx/commit/
715c1e632ccec57b46a18eed2a268109e666ddab
Wraith2 [Thu, 10 Jan 2019 19:40:29 +0000 (19:40 +0000)]
SqlClient spanify netcore guid writes (dotnet/corefx#34390)
* add netcore specific stackalloc paths for guid writes
* remove temp byte array allocation in favour of direct span
* remove reliance on span zeroing on allocation
* change to branch and explain why clear is needed
* split netstandard and netcore #ifdef regions out into conditionally included files
revised WriteGuid, WriteFloat and WriteDouble to use new Get*Bytes functions
* convert single line netcoreapp variants to expression body form
* rename Get*Bytes to Fill*Bytes
Commit migrated from https://github.com/dotnet/corefx/commit/
36037e16523a947aa2de05eca587a6a3bd5d18b5
Marco Rossignoli [Thu, 10 Jan 2019 19:13:18 +0000 (20:13 +0100)]
Remove UNC path check from System.Drawing.Icon.ExtractAssociatedIcon (dotnet/corefx#34467)
* remove UNC check
* add ActiveIssue to test
* address PR feedback
* address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
fd999b17c19a6f6cef0eb6be8c2df5bdb3f863e7
Calvin Buckley [Thu, 10 Jan 2019 18:41:31 +0000 (14:41 -0400)]
Fix ConvertDirent for AIX by always returning PAL_DT_UNKNOWN (dotnet/corefx#34088)
* Fix ConvertDirent for AIX by always returning PAL_DT_UNKNOWN
I commited the sin of untested code, as this function wasn't wired
up to Mono's BCL until a few days ago, and I had triggered the
situation where I needed this working by purging stale build
artifacts.
What happened here was me being too clever; I tried stat, but
we only have the file name, and from the unmanaged call stack this
would run in, we'd have no way to get the directory it's in
(without butchering the function signature) to properly use stat
for non-cwd directories. This meant that the check would get random
garbage on the stack; sometimes the data for "..", sometimes
another function would clobber it, and it'd read that. This caused
the Mono gensources tool to act erratically, preventing the BCL
from building.
Fix this by always returning DT_UNKNOWN. This isn't ideal, but the
BCL seems to handle this with grace and does a stat afterwards
to properly fill in data. It's enough to get the Mono build from
scratch working again. (The stat bit was verified by me running the
syscall tracing tool, `truss` over it, plus Mono's JIT trace.)
* Handle DT_UNKNOWN cases in FileSystemEntry.Initialize
On some OSes like AIX, we return DT_UNKNOWN as a sentinel value,
because they don't have a type field in dirent. If so, or the OS
does return a type and we got an unknown, also set symlink status
if so when making the managed equivalent structures.
TimeZoneInfo.Unix also calls ReadDir and thus ConvertDirent, but
it does this logic already.
* Move symlink check to its own if-elif block
Commit migrated from https://github.com/dotnet/corefx/commit/
c34dd2fb843c45ad135ef2b0348c06224e15c736
Stephen Toub [Thu, 10 Jan 2019 02:19:21 +0000 (21:19 -0500)]
Use string.Concat(ReadOnlySpan, ...) in a few places across corefx
Commit migrated from https://github.com/dotnet/corefx/commit/
3f63fe48c9663c1c607a02fe3c78197181d8e74b
Stephen Toub [Tue, 8 Jan 2019 20:21:48 +0000 (15:21 -0500)]
Expose/test string.Concat(ReadOnlySpan, ...)
Commit migrated from https://github.com/dotnet/corefx/commit/
7a87e5a27cd115816a92868585971fe68f71172a
dotnet-maestro-bot [Thu, 10 Jan 2019 12:57:58 +0000 (04:57 -0800)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview.19059.7, beta-27310-00, beta-27310-00, respectively (dotnet/corefx#34483)
Commit migrated from https://github.com/dotnet/corefx/commit/
976248ec183ae510777ef284cf9c065243025675
Geoff Kizer [Thu, 10 Jan 2019 04:02:19 +0000 (20:02 -0800)]
Merge pull request dotnet/corefx#34458 from geoffkizer/httpclienttest
Clean up HttpClientTest
Commit migrated from https://github.com/dotnet/corefx/commit/
94a2d0e52360f24d08c26191e20dfa8f015f9f68
Wraith2 [Thu, 10 Jan 2019 02:32:42 +0000 (02:32 +0000)]
SecurityIdentifier.ToString test fixes (dotnet/corefx#34399)
* SecurityIdentifier.ToString test fixes
* enable SecurityIdentifier.ToString tests
* address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
0abe7d6454f6e08ab335661493c7b8b2abc314ea
Stephen Toub [Thu, 10 Jan 2019 01:31:34 +0000 (20:31 -0500)]
Re-enable GenerateGuidForType exception tests (dotnet/corefx#34408)
Commit migrated from https://github.com/dotnet/corefx/commit/
f7b09b1af8318b457d55a6f14943a3fa36127960
Stephen Toub [Thu, 10 Jan 2019 01:30:16 +0000 (20:30 -0500)]
Re-enable ReleaseComObject_NullObject_ThrowsNullReferenceException test (dotnet/corefx#34405)
Commit migrated from https://github.com/dotnet/corefx/commit/
48b367299a1ed4d79a6ab6eecd6897c78ce5d8ef
dotnet-maestro-bot [Wed, 9 Jan 2019 22:30:03 +0000 (14:30 -0800)]
Update CoreClr, ProjectNTfs, ProjectNTfsTestILC to preview-27309-02, beta-27309-01, beta-27309-01, respectively (dotnet/corefx#34456)
Commit migrated from https://github.com/dotnet/corefx/commit/
2c214ecfa72a6162c397a1285cac1b8126d57a0d
Aaron Robinson [Wed, 9 Jan 2019 21:49:26 +0000 (13:49 -0800)]
Mitigate potential case where allocated marshal data is aligned to th… (dotnet/corefx#34445)
* Mitigate potential case where allocated marshal data is aligned to the primitive being read.
- Int16 and Int8.
Commit migrated from https://github.com/dotnet/corefx/commit/
724acf974be58159518b9302197fa278dc90b194
Geoff Kizer [Wed, 9 Jan 2019 20:49:33 +0000 (12:49 -0800)]
fix UWP test
Commit migrated from https://github.com/dotnet/corefx/commit/
3fb6dd4a0298f61a1a896a0d29e117d8ee95af0f
Viktor Hofer [Wed, 9 Jan 2019 19:24:54 +0000 (20:24 +0100)]
Bump ReportGenerator to 4.0.5 stable (dotnet/corefx#34468)
Commit migrated from https://github.com/dotnet/corefx/commit/
2918c74fc5a8f01c685b26553cdb1efcc985e43b
Geoff Kizer [Wed, 9 Jan 2019 10:44:04 +0000 (02:44 -0800)]
rename HttpClientTestBase to HttpClientHandlerTestBase
Commit migrated from https://github.com/dotnet/corefx/commit/
b26e2a66e5c41c3263caf5fdaa8a1811dd360e33
Geoff Kizer [Wed, 2 Jan 2019 00:13:07 +0000 (16:13 -0800)]
remove handler dependency in HttpClientTest
Commit migrated from https://github.com/dotnet/corefx/commit/
93719a61bb57729d940a8f20d7884e06dd935af7
Tanner Gooding [Wed, 9 Jan 2019 02:38:26 +0000 (18:38 -0800)]
Fixing up the S.R.Intrinsics ref assembly (dotnet/corefx#34449)
Commit migrated from https://github.com/dotnet/corefx/commit/
f3d808ac786dec0bd0a9b1e58cd49320c2059387
Stephen Toub [Wed, 9 Jan 2019 02:34:14 +0000 (21:34 -0500)]
Merge pull request dotnet/corefx#34438 from benaadams/filesystemwatcher-osx
Handle flowsuppressed context in FileSystemWatcher on OSX
Commit migrated from https://github.com/dotnet/corefx/commit/
cc86198e5b3c3b48be87f634d5474e124a6d93cc
Stephen Toub [Wed, 9 Jan 2019 01:22:19 +0000 (20:22 -0500)]
Merge pull request dotnet/corefx#34406 from stephentoub/clearlocals
Enable ILLinkClearInitLocals across corefx
Commit migrated from https://github.com/dotnet/corefx/commit/
b26339b6f6c7537875c70b5f3c8af376d0bbded5
Maryam Ariyan [Wed, 9 Jan 2019 00:18:07 +0000 (16:18 -0800)]
Modify FormatDescription test (dotnet/corefx#34440)
* Fix FormatDescription Error
* Fix FormatDescription Test
Commit migrated from https://github.com/dotnet/corefx/commit/
bcfcb83d63fb8dfe1ec09ce45ba6fca8191d12d3
Keerat Singh [Tue, 8 Jan 2019 23:59:29 +0000 (15:59 -0800)]
Merge pull request dotnet/corefx#34268 from AfsanehR/CredentialsFixMaster
Fix passing null for credentials in SqlConnectionPoolKey in master
Commit migrated from https://github.com/dotnet/corefx/commit/
2ff4a40aa0865e4bcaf85016188c77d52b24ec56
Santiago Fernandez Madero [Tue, 8 Jan 2019 23:59:07 +0000 (15:59 -0800)]
Fix Helix Repo Name to be dotnet/corefx in telemetry (dotnet/corefx#34448)
Commit migrated from https://github.com/dotnet/corefx/commit/
bbc48e258b10344207cc329c4340f3babf3aadb3
Santiago Fernandez Madero [Tue, 8 Jan 2019 23:42:09 +0000 (15:42 -0800)]
Enable helix telemetry for official builds and PRs (dotnet/corefx#34441)
* Enable helix telemetry for official builds and PRs
* Only send telemetry for official builds
Commit migrated from https://github.com/dotnet/corefx/commit/
2acc3e4858d5305bbf8b51d5f3797c1cd41c3912
Dan Moseley [Tue, 8 Jan 2019 23:36:06 +0000 (15:36 -0800)]
Fix sorted list syncroot test (dotnet/corefx#34446)
Commit migrated from https://github.com/dotnet/corefx/commit/
cba3c6416f311779dc77e25161d450b1456ec0ab
Ben Adams [Tue, 8 Jan 2019 23:27:08 +0000 (23:27 +0000)]
remove extra watcher
Commit migrated from https://github.com/dotnet/corefx/commit/
b20a4917f19243a6ec2b12ae420736ac83cb05a0
Ben Adams [Tue, 8 Jan 2019 23:23:07 +0000 (23:23 +0000)]
Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
08fa194915024438cf1bbdf47ccd4f45f5f42ec7
Wraith2 [Tue, 8 Jan 2019 23:00:36 +0000 (23:00 +0000)]
address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
386a90e64daa7e3dc65f094de21f20c649fd15b3
Ben Adams [Tue, 8 Jan 2019 22:37:23 +0000 (22:37 +0000)]
Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
c82d211923fe5a2bd6381f717df951cf4c11dbf0
Ben Adams [Tue, 8 Jan 2019 22:24:11 +0000 (22:24 +0000)]
Add Test
Commit migrated from https://github.com/dotnet/corefx/commit/
c3ccfe22c1ec06d2b158697f765d4d456e348c71
Ben Adams [Tue, 8 Jan 2019 22:04:56 +0000 (22:04 +0000)]
Handle flowsuppressed context in FileSystemWatcher on OSX
Commit migrated from https://github.com/dotnet/corefx/commit/
f3b83a9e73dcda79dec41b44963b46a0ff8c7fa4
dotnet-maestro-bot [Tue, 8 Jan 2019 22:23:42 +0000 (14:23 -0800)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview-27308-03, preview.19058.1, beta-27308-00, beta-27308-00, respectively (dotnet/corefx#34375)
Commit migrated from https://github.com/dotnet/corefx/commit/
d9f66e827ccec86f8663878206a7431f1a1c2cf9
Dan Moseley [Tue, 8 Jan 2019 18:16:06 +0000 (10:16 -0800)]
Fix path length 255 (dotnet/corefx#34389)
* long name test
* typo
* typo
* Enable test as WSL fixed
* Disable test for WSL
* Test update
* Fix tests
* Properly reuse buffer length
* Fix actual bug
* Tests for create on Linux
* Extend to unix
* netfx
* Update interop file
Commit migrated from https://github.com/dotnet/corefx/commit/
23521cc75428e38b8ff62cbac188c86b32184d42
Viktor Hofer [Tue, 8 Jan 2019 17:01:35 +0000 (18:01 +0100)]
Stop building native components for netfx (dotnet/corefx#34382)
* Stop building native components for netfx
* Remove unnecessary condition in build.proj
Commit migrated from https://github.com/dotnet/corefx/commit/
492a1f993c347f3c4b0f64ab7fc20b3b095b5f1d
Viktor Hofer [Tue, 8 Jan 2019 16:46:36 +0000 (17:46 +0100)]
Add SyncSortedList serialization test and remove SyncRoot (dotnet/corefx#34339)
* Add SyncSortedList serialization tests and remove SyncRoot
* Disable blob comparison for SyncSortedList
On UWP we get different blobs for SyncSortedList as reflection behaves
differently as the amount of types that we tests is less than in
.NET Core and .NET Framework. The order of fields that are serialized
into the payload are different in such a case.
Therefore we just disable the blob comparison for this type entirely.
Commit migrated from https://github.com/dotnet/corefx/commit/
de591233c04efa019ea2aed0a8fc5181f6d4210b
Stephen Toub [Mon, 7 Jan 2019 22:33:11 +0000 (17:33 -0500)]
Pass DecodeObject pointer length to callback
Commit migrated from https://github.com/dotnet/corefx/commit/
5e906172943897d032080e3d991b1cee96561ad0