Oswald Maskens [Tue, 13 Feb 2018 21:04:14 +0000 (22:04 +0100)]
Added tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx#1… (dotnet/corefx#26744)
* Added tests for Microsoft.VisualBasic.CompilerServices.Conversions dotnet/corefx#14344
* added tests for ToBoolean fro Object
Commit migrated from https://github.com/dotnet/corefx/commit/
c705032f0f4f6e3d34f65cf5660e3c8ea109ad47
dotnet-maestro-bot [Tue, 13 Feb 2018 20:02:54 +0000 (14:02 -0600)]
Update BuildTools, CoreClr, CoreFx to preview2-02513-01, preview2-26213-05, preview2-26213-06, respectively (dotnet/corefx#27093)
Commit migrated from https://github.com/dotnet/corefx/commit/
b9b5b807378f7d17817749288c6b89db9694181a
Tomáš Matoušek [Tue, 13 Feb 2018 19:41:05 +0000 (11:41 -0800)]
Remove 'PDBC' data signature
Commit migrated from https://github.com/dotnet/corefx/commit/
a3647d844791f916dff1053665bbce4574d0b8ee
Eric Erhardt [Fri, 9 Feb 2018 05:02:42 +0000 (21:02 -0800)]
Fix Process Start tests in outerloop on Unix.
Get the real user name in the test process, not the child process. The outerloop tests are run with 'sudo'. Which means by the time we are in the child process SUDO_USER will be set to 'root', since the parent test process was run with 'sudo'.
Fixes dotnet/corefx#26675
Commit migrated from https://github.com/dotnet/corefx/commit/
bca11a079c914ed971b2f300b876f89a920a0398
Stephen Toub [Tue, 13 Feb 2018 13:38:32 +0000 (08:38 -0500)]
Fix SocketsHttpHandler connection pool accounting for dropped connections (dotnet/corefx#27068)
When MaxConnectionsPerServer is set to anything other than int.MaxValue, the SocketsHttpHandler pool keeps track of the number of connections handed out, and this count is updated when a connection is disposed. But if a response stream isn't disposed of, resulting in the connection never being disposed of, the count may never be updated. This fix adds an HttpConnection derived type that simply adds a finalizer, making it pay-for-play when MaxConnectionsPerServer is set to something other than the default.
Commit migrated from https://github.com/dotnet/corefx/commit/
ffa5db357252913c52e0cdad63c1573020185f6e
Stephen Toub [Tue, 13 Feb 2018 11:30:25 +0000 (06:30 -0500)]
Clear initlocals in a bunch of assemblies (dotnet/corefx#26993)
* Clear initlocals in a bunch of assemblies
Sets
```XML
<ILLinkClearInitLocals>true</ILLinkClearInitLocals>
```
for the assemblies:
- System.IO.FileSystem
- System.IO.Pipes
- System.Memory
- System.Net.Http
- System.Net.Http.WinHttpHandler
- System.Net.NameResolution
- System.Net.NetworkInformation
- System.Net.Primitives
- System.Net.Requests
- System.Net.Security
- System.Net.Sockets
- System.Net.WebSockets
- System.Net.WebSockets.Client
- System.Net.WebSockets.WebSocketsProtocol
- System.Private.Uri
- System.Runtime
- System.Runtime.Extensions
Eventually we'd ideally set the flag for the whole repo; these are just the ones I audited thus far. In a few cases I had to make code changes to adapt, where the code was expecting stackallocs to be cleared. I also looked at a few other projects (System.Collections, System.Runtime.Numerics) where there were more significant dependencies on clearing and I decided to leave those for later.
* Disable ILLinkClearInitLocals running on Unix until it works there
Commit migrated from https://github.com/dotnet/corefx/commit/
f0a032e4a1c8a848574a5db3e69e8a6fa0aae91e
Saurabh Singh [Tue, 13 Feb 2018 09:47:02 +0000 (01:47 -0800)]
Revert Managed SNI usage flag (dotnet/corefx#27089)
Commit migrated from https://github.com/dotnet/corefx/commit/
23709d07c3cb8e5c4be36ffe7f480151becc54b3
Saurabh Singh [Tue, 13 Feb 2018 07:54:59 +0000 (23:54 -0800)]
Workstation Id should be returned correctly (dotnet/corefx#27076)
* Fix workstation Id
* Tests for workstation id
* Add more test cases
Commit migrated from https://github.com/dotnet/corefx/commit/
7425455ace4c7819b786c2f0b42fb630944aeef3
Geoff Kizer [Tue, 13 Feb 2018 07:11:11 +0000 (23:11 -0800)]
Merge pull request dotnet/corefx#27069 from stephentoub/cachessl
Cache SslClientAuthenticationOptions on SocketsHttpHandler pool
Commit migrated from https://github.com/dotnet/corefx/commit/
a438733f09a739bfbd4b9f945ba049386858019a
dotnet-maestro-bot [Tue, 13 Feb 2018 05:58:07 +0000 (23:58 -0600)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-26213-00, beta-26213-00, respectively (dotnet/corefx#27083)
Commit migrated from https://github.com/dotnet/corefx/commit/
73d8163328b17fee3d32ff295b03fab13fdb721e
dotnet-maestro-bot [Tue, 13 Feb 2018 03:59:14 +0000 (21:59 -0600)]
Update CoreClr, CoreFx to preview2-26212-08, preview2-26213-01, respectively (dotnet/corefx#27080)
Commit migrated from https://github.com/dotnet/corefx/commit/
bf5f02752633d92afcb249fe166a81ae84d59c77
Eric Erhardt [Tue, 13 Feb 2018 01:39:17 +0000 (19:39 -0600)]
Lower the default stack buffer size for calling getpwXXX_r methods.
By default, 1K is too large of a buffer to allocate on the stack.
Fixes dotnet/corefx#26959
Commit migrated from https://github.com/dotnet/corefx/commit/
5cbac95f5530695a31a43e7748a4561e3a2dd32d
Jeremy Kuhne [Mon, 12 Feb 2018 21:56:17 +0000 (13:56 -0800)]
Switch from using SafeHandle for Unix enumeration (dotnet/corefx#27052)
* Switch from using SafeHandle for Unix enumeration
* Address feedback
* Fix faceplant, dispose in test.
Commit migrated from https://github.com/dotnet/corefx/commit/
c9100ffc2988a0faf0e92898762a445ccb3c0e13
Maryam Ariyan [Mon, 12 Feb 2018 19:35:36 +0000 (14:35 -0500)]
Disable drawing test for distro Ubuntu18.04 (dotnet/corefx#27036)
* Disable drawing test for distro Ubuntu18.04
* Adding a new properties called IsUbuntu1804 and IsUbuntu1710OrHigher in PlatformDetection
Related to dotnet/corefx#27021
Commit migrated from https://github.com/dotnet/corefx/commit/
4b4440b4c0fc280d3a9c09d117a1a6eafbbcb6c2
Max Kerr [Mon, 12 Feb 2018 19:28:09 +0000 (11:28 -0800)]
Clear Authorization Headers on Redirect (dotnet/corefx#26864)
When a user has added an Authorization header to a request via the HttpClient DefaultRequestHeaders Authorization field, ensure that header is stripped on redirect.
This change adds a method to strip Authorization headers that were set via the HttpClient DefaultRequestHeaders Authorization field, and calls that method on redirect. In addition, it adds a test to ensure that this behavior occurs as expected.
The new method ResetAuthRequestHeaders is based on the method ResetCookieRequestHeaders, which is used to reset cookie headers on redirect.
The issue also occurs in CurlHandler, but the fix is slightly different. Rather than remove the headers that have already been set, we can instead just skip them when copying over the new headers to the redirected request.
Fixes dotnet/corefx#26426
Commit migrated from https://github.com/dotnet/corefx/commit/
7e6396b2bcb4d372b199cfb7b3b13e290c441124
Tarek Mahmoud Sayed [Mon, 12 Feb 2018 19:20:55 +0000 (11:20 -0800)]
Fix the throwing exception from ChannelReader.ReadAsync (dotnet/corefx#27070)
Commit migrated from https://github.com/dotnet/corefx/commit/
20d9824ac3f877b2a72dd6a729134e0c5fd960ee
Stephen Toub [Mon, 12 Feb 2018 18:39:02 +0000 (13:39 -0500)]
Fix HttpClientMiniStress.UnreadResponseMessage_Collectible test (dotnet/corefx#27061)
The async state machine was holding a reference to the response content object, which in turn prevented the response stream from being collected.
Commit migrated from https://github.com/dotnet/corefx/commit/
6c9b62981190ae5886196f37d0f5dc614f4b0244
Karel Zikmund [Mon, 12 Feb 2018 17:51:53 +0000 (09:51 -0800)]
Update rename of ManagedHandler to SocketsHttpHandler
Commit migrated from https://github.com/dotnet/corefx/commit/
a07b356e61a0a1d8e2d6d02bcc1e2062fbbd64ae
Stephen Toub [Mon, 12 Feb 2018 17:17:33 +0000 (12:17 -0500)]
Cache SslClientAuthenticationOptions on SocketsHttpHandler pool
For the common case, we can just use a singleton cached instance with settings computed when the pool is created. Only if it's accessed via HttpClientHandler with a server certificate callback do we need to still create an instance per request, in order to wrap the delegate to provide the expected semantics.
Commit migrated from https://github.com/dotnet/corefx/commit/
911d4aff095f1c8648334d4a221c217cd09e466b
dotnet-maestro-bot [Mon, 12 Feb 2018 17:13:52 +0000 (11:13 -0600)]
Update CoreClr, CoreFx to preview2-26212-05, preview2-26212-05, respectively (dotnet/corefx#27060)
Commit migrated from https://github.com/dotnet/corefx/commit/
38ff6d112eee1b93d402521f924d9952bef98ef9
Jon Hanna [Mon, 12 Feb 2018 16:30:14 +0000 (16:30 +0000)]
Allow RangeAttribute use to request InvariantCulture conversions. (dotnet/corefx#25918)
* Allow RangeAttribute use to request InvariantCulture conversions.
Adds a ParseLimitsInInvariantCulture that affects the interpretation of
the extrema set, and ConvertValueInInvariantCulture that affects the
interpretation of values.
Separate methods allows for e.g. a component assuming a
dot-decimal-separator culture defining a property with the attribute
(so invariant culture should be used) the use of the property is done
in a comma-decimal-separator (so the current culture should be used),
or any permutation of the two booleans.
Fixes dotnet/corefx#2648
* Skip NetFX on associated tests.
* Update tests in dotnet/corefx#25918 to work with changes from dotnet/corefx#26050
Commit migrated from https://github.com/dotnet/corefx/commit/
015cf5d9832ed9d6734367c8a2e29dfa8bae4a25
Geoff Kizer [Mon, 12 Feb 2018 12:25:24 +0000 (04:25 -0800)]
fix stress response generation, and disable failing test (dotnet/corefx#27059)
Commit migrated from https://github.com/dotnet/corefx/commit/
472c3d95749910ba600df296bbf01d78d7c4f6d8
dotnet-maestro-bot [Mon, 12 Feb 2018 10:28:43 +0000 (04:28 -0600)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview2-26212-01, preview2-26212-01, beta-26212-00, beta-26212-00, respectively (dotnet/corefx#27053)
Commit migrated from https://github.com/dotnet/corefx/commit/
241ea5372d4770a7f596adf272833aa6dd63a289
Stephen Toub [Mon, 12 Feb 2018 10:27:57 +0000 (05:27 -0500)]
Tweak CurlHandler SSL not supported messages to be more helpful (dotnet/corefx#27043)
* Tweak CurlHandler SSL not supported messages to be more helpful
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
9cde3e174b2495cbcdf95995aea0bea4030d4aa9
Dan Moseley [Mon, 12 Feb 2018 03:33:12 +0000 (19:33 -0800)]
Ensure services get removed (dotnet/corefx#27054)
Commit migrated from https://github.com/dotnet/corefx/commit/
744c4cf021c1744082e12caf3e9b8dacf05a671a
Geoff Kizer [Mon, 12 Feb 2018 02:23:50 +0000 (18:23 -0800)]
Merge pull request dotnet/corefx#26989 from geoffkizer/fixcookiehandling
SocketsHttpHandler: Fix some issues with cookie handling, and add cookie tests
Commit migrated from https://github.com/dotnet/corefx/commit/
8cee267154ef9dc6dde7a76a828844a200437872
John Doe [Mon, 12 Feb 2018 00:18:31 +0000 (16:18 -0800)]
acutal -> actual (dotnet/corefx#27050)
Commit migrated from https://github.com/dotnet/corefx/commit/
36a15af564c8359881da9f98a7011a89253c0847
Jeff Cyr [Mon, 12 Feb 2018 00:18:08 +0000 (19:18 -0500)]
Modified Dns.GetHostAddressesAsync to be truly async (dotnet/corefx#26850)
* Modified Dns.GetHostAddressesAsync to be truly async
* Applied code review recommendations
* Unix build fix
* Unix build fix dotnet/corefx#2
* Unix build fix dotnet/corefx#3
* NETFX build fix
* Fixed useGetHostByName logic
* Simplified ProcessResult code
* Cleaned up cancel code
* cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
d3ff31e3b9e8c7b1e6003196650bae4a658ef889
Geoff Kizer [Sun, 11 Feb 2018 22:49:42 +0000 (14:49 -0800)]
fix tests on netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
c7cc2a879d0a5b5f039caff36bef0c99f52604a2
Geoff Kizer [Sun, 11 Feb 2018 20:38:20 +0000 (12:38 -0800)]
consolidate cookie tests
Commit migrated from https://github.com/dotnet/corefx/commit/
c20262c69a93449498d511014e9e69bad18f987a
dotnet-maestro-bot [Sun, 11 Feb 2018 17:41:34 +0000 (11:41 -0600)]
Update CoreClr, CoreFx to preview2-26211-03, preview2-26211-04, respectively (dotnet/corefx#27041)
Commit migrated from https://github.com/dotnet/corefx/commit/
14185df4430c7f9432ea4654676c7663c5f8957e
Stephen Toub [Sun, 11 Feb 2018 17:19:03 +0000 (12:19 -0500)]
Add SocketsHttpHandler check for TransferEncodingChunked w/o Content (dotnet/corefx#27040)
Commit migrated from https://github.com/dotnet/corefx/commit/
bf5a3183bc901723ebe0bb3d178bec86cda57429
Stephen Toub [Sun, 11 Feb 2018 17:18:33 +0000 (12:18 -0500)]
Fix more new T[0] to be Array.Empty<T>() (dotnet/corefx#27042)
We've done several passes through the repo in the past. More cases have snuck in since then.
Commit migrated from https://github.com/dotnet/corefx/commit/
a127f01141ff4ffe2224da9ff63a1b5233ee5f06
Stephen Toub [Sun, 11 Feb 2018 13:55:26 +0000 (08:55 -0500)]
Fix some license headers across the repo (dotnet/corefx#27039)
Commit migrated from https://github.com/dotnet/corefx/commit/
7f19e761b7400521030707df2e6fac10daa36f26
Stephen Toub [Sun, 11 Feb 2018 10:15:15 +0000 (05:15 -0500)]
Mark {Configured}ValueTaskAwaiter as readonly in contracts (dotnet/corefx#27030)
Commit migrated from https://github.com/dotnet/corefx/commit/
4ff3c791c0eac88d96f135b16fc5425d48e02211
Stephen Toub [Sun, 11 Feb 2018 10:10:13 +0000 (05:10 -0500)]
Add tests for T[] -> ArraySegment<T> cast (dotnet/corefx#27032)
Commit migrated from https://github.com/dotnet/corefx/commit/
d690bb63b15556190fad7e6bb85eb7a4dce69c79
dotnet-maestro-bot [Sun, 11 Feb 2018 08:50:47 +0000 (02:50 -0600)]
Update BuildTools to preview2-02511-02 (dotnet/corefx#27034)
Commit migrated from https://github.com/dotnet/corefx/commit/
f54ee41039db4b84fb5dc58bec4e1dd393fc2d0b
Maryam Ariyan [Sun, 11 Feb 2018 06:46:58 +0000 (01:46 -0500)]
Fixing test CurrencyNegativePattern_Get() on newly added distro Ubuntu18.04 (dotnet/corefx#27035)
From class/project System.Globalization.Tests.NumberFormatInfoCurrencyNegativePattern
Fixes dotnet/corefx#27022
Commit migrated from https://github.com/dotnet/corefx/commit/
8fdf896ebb78fcab5612de7a0ea84518d416d7c7
Dan Moseley [Sun, 11 Feb 2018 03:13:07 +0000 (19:13 -0800)]
Fix TestService shutdown (dotnet/corefx#27028)
Commit migrated from https://github.com/dotnet/corefx/commit/
2af251c3c083817975d76d659069400d98073965
dotnet-maestro-bot [Sun, 11 Feb 2018 02:43:50 +0000 (20:43 -0600)]
Update CoreClr to preview2-26210-06 (dotnet/corefx#27026)
Commit migrated from https://github.com/dotnet/corefx/commit/
530385c33afaf373ae28f5ab49cf5c0d902dda3e
John Doe [Sun, 11 Feb 2018 01:57:33 +0000 (17:57 -0800)]
clasname -> classname (dotnet/corefx#27025)
Commit migrated from https://github.com/dotnet/corefx/commit/
08bcfb4b95ec4be00ce70eb985682aca8aec8fe9
Jeremy Kuhne [Sun, 11 Feb 2018 01:19:49 +0000 (17:19 -0800)]
Fix *Info classes for Unix when opened on root (dotnet/corefx#27024)
Commit migrated from https://github.com/dotnet/corefx/commit/
5349873018e481a2ad8a14bbdd5ff237780f02e3
dotnet-maestro-bot [Sat, 10 Feb 2018 15:27:34 +0000 (09:27 -0600)]
Update CoreClr to preview2-26210-04 (dotnet/corefx#27020)
Commit migrated from https://github.com/dotnet/corefx/commit/
221950b31c1057b040670936519ddbc13f893062
Stephen Toub [Sat, 10 Feb 2018 12:11:12 +0000 (07:11 -0500)]
Add FileStream tests for custom OwnedMemory with Read/WriteAsync (dotnet/corefx#26931)
Commit migrated from https://github.com/dotnet/corefx/commit/
7130581c8bd7114143628679624f7ae29cb56818
Tarek Mahmoud Sayed [Sat, 10 Feb 2018 12:11:03 +0000 (04:11 -0800)]
Add Hebrew Months test (dotnet/corefx#26915)
* Add Hebrew Months test
* add some spaces
Commit migrated from https://github.com/dotnet/corefx/commit/
57ba13cbfa203c8bc5003dd9b3ab4aaa796c22f8
dotnet-maestro-bot [Sat, 10 Feb 2018 04:58:58 +0000 (22:58 -0600)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02509-01, preview2-26209-08, preview2-26210-01, preview2-26209-04, beta-26209-02, beta-26209-02, respectively (dotnet/corefx#26940)
Commit migrated from https://github.com/dotnet/corefx/commit/
1fc770a6cbc26dc072a44ee9ae6e6d9af5e61e1c
Jeremy Kuhne [Sat, 10 Feb 2018 04:33:26 +0000 (20:33 -0800)]
Fix Unix enumeration (dotnet/corefx#27019)
For non-trivial recursive enumerations we were running out of file descriptors. Stop creating them when we queue pending subdirectories and only create when we dequeue.
Commit migrated from https://github.com/dotnet/corefx/commit/
430de8f582afb111697dd1e203f5c7a20f46acb2
Saurabh Singh [Sat, 10 Feb 2018 01:57:04 +0000 (17:57 -0800)]
Restrict the Long Running option to MARS (dotnet/corefx#27010)
* Restrict the Long Running option to MARS
* Code review comments
Commit migrated from https://github.com/dotnet/corefx/commit/
8cc3ffbea1da042f4f0ca61ad81e234630434f21
Paulo Janotti [Fri, 9 Feb 2018 23:48:29 +0000 (15:48 -0800)]
Trying to collect info about ping test failures in macOS 10.12 (dotnet/corefx#26997)
See dotnet/corefx#26358
Commit migrated from https://github.com/dotnet/corefx/commit/
7406c4c12ab76df15e0fde191856860eb87166d5
Wes Haggard [Fri, 9 Feb 2018 23:24:18 +0000 (15:24 -0800)]
Update intellisense file drop based on 2-2-2018 doc build (dotnet/corefx#27005)
Commit migrated from https://github.com/dotnet/corefx/commit/
54c80d877e2f90c4973b44db5033f2cb7abf5ce2
Geoff Kizer [Fri, 9 Feb 2018 19:34:51 +0000 (11:34 -0800)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
15beaca5f2062792bf4a2dd137a42d6e53f98e5e
Tomas Weinfurt [Fri, 9 Feb 2018 20:05:30 +0000 (12:05 -0800)]
minimal support for ManagedHandler proxy configuration on Windows (dotnet/corefx#26878)
* initial implementation
Commit migrated from https://github.com/dotnet/corefx/commit/
468db63e2648f8a4c0c82d97e301e308b7887f7e
Matt Galbraith [Fri, 9 Feb 2018 18:54:36 +0000 (10:54 -0800)]
Merge pull request dotnet/corefx#26981 from MattGal/Ubuntu18
Add Ubuntu 18 to supported Linux list
Commit migrated from https://github.com/dotnet/corefx/commit/
be4cdaecf9374f1addf15eb10b3bbd1dc7550ed2
Jose Perez Rodriguez [Fri, 9 Feb 2018 18:03:17 +0000 (10:03 -0800)]
Increasing OSX build timeout while we investigate the Performance hit (dotnet/corefx#27002)
Commit migrated from https://github.com/dotnet/corefx/commit/
a72988c3793cc19b27e11d4599173cd0a5291b13
John Doe [Fri, 9 Feb 2018 15:58:43 +0000 (07:58 -0800)]
conditionsed -> conditioned (dotnet/corefx#26998)
Commit migrated from https://github.com/dotnet/corefx/commit/
30f0b6323f7f4661c924b6229dbfc1fecc11cc0e
Konst Khurin [Fri, 9 Feb 2018 12:59:40 +0000 (04:59 -0800)]
Fixing a regression introduced by the previous test fix. (dotnet/corefx#26970)
Commit migrated from https://github.com/dotnet/corefx/commit/
59f5f604794e562fdc000d5dbedb53f68b7ceac7
Geoff Kizer [Fri, 9 Feb 2018 04:22:46 +0000 (20:22 -0800)]
rework cookie logic to address issues and remove CookieHandler
Commit migrated from https://github.com/dotnet/corefx/commit/
7d11d419421cc9bea0b8fa3d186bb6a406cd3a4b
Geoff Kizer [Thu, 8 Feb 2018 02:57:01 +0000 (18:57 -0800)]
add protocol tests for cookie handling
Commit migrated from https://github.com/dotnet/corefx/commit/
750b29bbb1433ad5d4c3727217192dddbef90eef
Jeremy Kuhne [Fri, 9 Feb 2018 06:50:38 +0000 (22:50 -0800)]
Make Unix filename conversion lazy (dotnet/corefx#26978)
* Make Unix filename conversion lazy
Also hook error handling.
* Address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
ef0aca54454748002325b750c839dacba6ed3999
Caesar Chen [Fri, 9 Feb 2018 04:54:34 +0000 (20:54 -0800)]
Disable Http status line test cases on CurlHandler (dotnet/corefx#26982)
Commit migrated from https://github.com/dotnet/corefx/commit/
6730463bd0bb1a65e679b8a6643d611b69086b29
Jon Hanna [Fri, 9 Feb 2018 04:26:23 +0000 (04:26 +0000)]
Refactor and tests for MS.CSharp's GetBestAccessibleType() (dotnet/corefx#26391)
* Rearrange GetBestAccessibleType to avoid repeated tests & recursion.
Keep all code for AggregateType in the first branch for AggregateType,
etc.
# Conflicts:
# src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/Types/TypeManager.cs
* Use ContextForMemberLookup instead of BindingContext for best accessible
The BindingContext is only used for this property, which it hits
repeatedly, so just pass it in instead.
# Conflicts:
# src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/Types/TypeManager.cs
* Don't use intermediate variables for out parameters.
If just going to assign it to something anyway.
# Conflicts:
# src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/Types/TypeManager.cs
* Return type directly from GetBestAccessibleType()
The type passed in can never be ParameterModifierType or PointerType so
the case where false is returned can never be hit. Change to returning
the accessible type directly, and remove branches for false returns.
# Conflicts:
# src/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/Types/TypeManager.cs
* Add tests for getting best accessible type.
Commit migrated from https://github.com/dotnet/corefx/commit/
ee64cb0126834cf8563d22db6fc73cdffc9ac4cd
Jon Hanna [Fri, 9 Feb 2018 04:21:17 +0000 (04:21 +0000)]
Remove some dead branches from Microsoft.CSharp (dotnet/corefx#26370)
* Don't report constrained in AdjustMemberObject.
Never gets set, and constrained isn't meaningful when not producing IL
directly.
* Remove FieldSymbol.isAssigned
Set but never used. CS1612 is meaningless in dynamic code.
* Remove objectIsLvalue(pOptionalObject) from check field is lvalue.
This test will always pass, so the second part is all that is required.
* Move lvalue-detection into ExprField ctor
* Remove objectIsLvalue(pOptionalObject) from check property is lvalue.
This test will always pass, so the second part is all that is required.
* Move lvalue-detection into ExprProperty ctor
* Make objectIsLvalue a debug-only assertion.
Now only used in assertions, so make it an assertion method.
* Remove dead branches from TryReportLvalueFailure
Since we can now see that we can't enter the branch for properties, nor
escape the branch for fields, we can see that pObject will never be set
and isNested never true. Remove branches for those conditions.
Includes removal of ERR_ReturnNotLValue, contributes to dotnet/corefx#22470
* Remove path for isNested from ReportReadOnlyError
Never true.
Includes removal of ERR_AssgReadonlyStatic2 and ERR_AssgReadonly2,
contributes to dotnet/corefx#22470
* Inline ReportReadOnlyError and TryReportLvalueFailure
These are now very small, and CheckLvalue's logic is clearer with all
errors happening within the same switch
* Use FundamentalType to judge whether value is unsigned.
We've already obtained and branched on this value, and they suffice to
know whether the type is unsigned or not, so just infer from that.
Commit migrated from https://github.com/dotnet/corefx/commit/
47a92df7f73d8570176c18a499dbdda4d9323101
Stephen Toub [Fri, 9 Feb 2018 04:04:18 +0000 (23:04 -0500)]
Merge pull request dotnet/corefx#26964 from stephentoub/exposemanagedhandler
Expose SocketsHttpHandler
Commit migrated from https://github.com/dotnet/corefx/commit/
eb892471f8691dad65ff47f5b12ddc8d378ae460
Matt Galbraith [Fri, 9 Feb 2018 03:08:12 +0000 (19:08 -0800)]
Add Ubuntu 18 to supported Linuxes
Commit migrated from https://github.com/dotnet/corefx/commit/
5875a4ddad59a1bd40555af0375d3d6345a7e754
Tarek Mahmoud Sayed [Fri, 9 Feb 2018 01:30:56 +0000 (17:30 -0800)]
Restore Channels ReadAsync implementation (dotnet/corefx#26934)
* Restore Channels ReadAsync implementation
* Remove AutoResetAwaiter
* Add Base class ReadAsync test
* address the feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
ce0de73e21635252ceffdb140d3a56c6c19bb565
Eric Erhardt [Fri, 9 Feb 2018 01:27:21 +0000 (17:27 -0800)]
Fix ProcessStartInfo tests on CentOS in Debug (dotnet/corefx#26945)
There is a bug in CentOS7.1 getpwnam_r where it returns the wrong value if you pass in a buffer that is too small to hold the data. In Debug builds, we are purposefully passing in a buffer that is too small to test the fallback code, which is running into this OS bug.
See https://bugs.centos.org/view.php?id=7324
Fixes dotnet/corefx#26673
Commit migrated from https://github.com/dotnet/corefx/commit/
03414aae30a0a90c5a54a85d79189e95f7f81ab4
Stephen Toub [Fri, 9 Feb 2018 00:14:22 +0000 (19:14 -0500)]
Return canceled task from WaitToReadAsync even if data available (dotnet/corefx#26974)
Commit migrated from https://github.com/dotnet/corefx/commit/
5cec1f3491e8eac76255e48274cadccd040caf81
Stephen Toub [Thu, 8 Feb 2018 22:42:19 +0000 (17:42 -0500)]
Fix WebSocketProtocol test that never worked on netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
f6f5188044b126f3f6058ce361b060fc0b83257e
Stephen Toub [Thu, 8 Feb 2018 18:44:32 +0000 (13:44 -0500)]
Add more SocketsHttpHandler tests
Commit migrated from https://github.com/dotnet/corefx/commit/
8cb4d130bc3e8151fc72fe9494787643c7b00c4b
Stephen Toub [Thu, 8 Feb 2018 16:33:13 +0000 (11:33 -0500)]
Expose SocketsHttpHandler
- Renames ManagedHandler to SocketsHttpHandler
- Moves a bunch of files around accordingly
- Updates System.Net.WebSockets.Client to use SocketsHttpHandler directly
- Updates System.Net.Http's tests with a reflection-based rather than TLS-based method for instantiating an HttpClientHandler backed by a SocketsHttpHandler.
Commit migrated from https://github.com/dotnet/corefx/commit/
852d40e723c849e8d0c486676d40332343e12ca5
Tomáš Matoušek [Thu, 8 Feb 2018 23:59:47 +0000 (15:59 -0800)]
PDB Checksum Debug Directory Record Specification (dotnet/corefx#26912)
* PDB Checksum Debug Directory Record Specification
* Hash zeroed PDB ID
* Update PE-COFF.md
* Update PE-COFF.md
Commit migrated from https://github.com/dotnet/corefx/commit/
d374be89418236e29ed3f88a3f622a3719242089
Saurabh Singh [Thu, 8 Feb 2018 22:44:03 +0000 (14:44 -0800)]
Provide GetSchema override for DbConnectionClosed (dotnet/corefx#26951)
* Provide GetSchema override for DbConnectionClosed
* Change names
* Code review comment
Commit migrated from https://github.com/dotnet/corefx/commit/
ccc21d00a5db9386e4e25e68850dd2520ff5c57f
Stephen Toub [Thu, 8 Feb 2018 22:42:43 +0000 (17:42 -0500)]
Ensure EventData structs in EventSource implementations are zero'd (dotnet/corefx#26968)
In preparation for clearing initlocals.
Commit migrated from https://github.com/dotnet/corefx/commit/
f3e7e18b4baa70adeb0ba9a02d80d3acf0f796e3
Tanner Gooding [Thu, 8 Feb 2018 20:57:46 +0000 (12:57 -0800)]
Adding some math tests to ensure additional values outside the input domain are tested. (dotnet/corefx#26955)
Commit migrated from https://github.com/dotnet/corefx/commit/
8cd6cf7f3bec1c483ef9b25826733318c2fd024f
Jeremy Kuhne [Thu, 8 Feb 2018 20:55:15 +0000 (12:55 -0800)]
Reduce Unix enumeration allocations (dotnet/corefx#26942)
* Reduce Unix enumeration allocations
This change factors out the FileStatus access into a helper struct and adds overloads
for the stat imports that allow passing a span.
The next steps:
- Handle errors manually
- Skip using safehandle
- Look for further opportunities around UTF-8/16 conversion
* Address feedback
Shuffle code around a bit in FileInfo for clarity. Also shift directory determination
to FileSystemEntry to avoid allocation on links.
Commit migrated from https://github.com/dotnet/corefx/commit/
c64171e379090b372fe232ec3f27a57ae838406c
Eric StJohn [Thu, 8 Feb 2018 20:20:33 +0000 (12:20 -0800)]
Merge pull request dotnet/corefx#26958 from ericstj/cng.xamarin
Treat Crypto.Cng as inbox on Xamarin profiles.
Commit migrated from https://github.com/dotnet/corefx/commit/
a6046cb7338f04044f96c4d1855ea11caccb3448
Caesar Chen [Thu, 8 Feb 2018 17:18:21 +0000 (09:18 -0800)]
Enable HttpProtocolTest status line test cases (dotnet/corefx#26798)
* enable all test data
* seperate test data
* add one missing data
* address pr feedabck
* address feedback
* disable test by active issue & add else clause
Commit migrated from https://github.com/dotnet/corefx/commit/
426e1c72a0dbda1aece127ec5f56696dc465d74b
Eric St. John [Thu, 8 Feb 2018 16:25:44 +0000 (08:25 -0800)]
Treat Crypto.Cng as inbox on Xamarin profiles.
Commit migrated from https://github.com/dotnet/corefx/commit/
5114e42ddc313f470cc41e49eb80f33d2d0f5c4f
k0st1x [Thu, 8 Feb 2018 13:28:31 +0000 (16:28 +0300)]
PropertyDescriptor - MemberDescriptor.Attributes (iteration 2) (dotnet/corefx#26756)
* PropertyDescriptor - MemberDescriptor.Attributes returns base attribute instead of ancestor's attribute dotnet/corefx#26600
* PropertyDescriptor - MemberDescriptor.Attributes returns base attribute instead of ancestor's attribute dotnet/corefx#26600
Commit migrated from https://github.com/dotnet/corefx/commit/
a4ab230cd2fe61b3af283b19dda7709891d83ddd
Rodrigo Kumpera [Thu, 8 Feb 2018 12:38:13 +0000 (04:38 -0800)]
Improve OSX build instructions (dotnet/corefx#26874)
* Improve OSX build instructions
* Fix instructions to handle multiple installed openssl.
Commit migrated from https://github.com/dotnet/corefx/commit/
ac72f91bfcaed694c789e24a2a0a6a042fa18916
Max Kerr [Thu, 8 Feb 2018 00:55:49 +0000 (16:55 -0800)]
Re-Enable disabled DNS tests on OSX (dotnet/corefx#26949)
These were disabled a few days ago, but it looks like the issue may have been caused by problematic test infrastructure. One of the offending machines has been re-imaged, and the others have been rebooted.
Re-enabling the tests should allow us to determine if it was an infrastructure issue, or if there is a real problem here.
Fixes: dotnet/corefx#26789
Commit migrated from https://github.com/dotnet/corefx/commit/
b60618197972da445ff5e675d425459fc9c0d3ae
Stephen Toub [Thu, 8 Feb 2018 00:36:53 +0000 (19:36 -0500)]
Switch ManagedHandler to use SslClientAuthenticationOptions (dotnet/corefx#26870)
Simplifies the public ManagedHandler API by using the now existing SslClientAuthenticationOptions bag as a way to pass in all of the SSL-related options. This also means we start enabling anything already on SslClientAuthenticationOptions as well as anything new added in the future, without requiring new API on ManagedHandler.
In the process of doing that, also added an implemention of HttpClientHandler.ClientCertificateOption for ManagedHandler; previously Automatic was just ignored.
I also removed UseDefaultCredentials from ManagedHandler, as it's ignored and not relevant until additional auth mechanisms are supported.
Commit migrated from https://github.com/dotnet/corefx/commit/
ee7d4599ed8ac2bca796cc7627ebf33b75f8b7cb
Tanner Gooding [Wed, 7 Feb 2018 20:41:06 +0000 (12:41 -0800)]
Removing the Sse2.LoadScalarVector128 overloads that are invalid.
Commit migrated from https://github.com/dotnet/corefx/commit/
ee63fe7e6ad36ca9ca25544c38a9aecd003b629f
Paulo Janotti [Wed, 7 Feb 2018 23:19:43 +0000 (15:19 -0800)]
Make content in response have length matching content-length (dotnet/corefx#26932)
See dotnet/corefx#26754
Commit migrated from https://github.com/dotnet/corefx/commit/
a73c8f9920be8b1fa8accc1eb7be6f5305f7f7ad
Stephen Toub [Wed, 7 Feb 2018 22:58:05 +0000 (17:58 -0500)]
Implement MaxResponseHeadersLength on ManagedHandler (dotnet/corefx#26906)
Commit migrated from https://github.com/dotnet/corefx/commit/
b6b7eb09600c18d35c6f9bf9ca484d5b8399f718
Tanner Gooding [Sat, 23 Dec 2017 01:08:28 +0000 (17:08 -0800)]
Adding tests for the Acosh, Asinh, Atanh, and Cbrt functions in System.Math and System.MathF
Commit migrated from https://github.com/dotnet/corefx/commit/
758b3f952008c98836a258a595aca5880fbd4533
Tanner Gooding [Fri, 22 Dec 2017 23:53:30 +0000 (15:53 -0800)]
Adding the Acosh, Asinh, Atanh, and Cbrt functions to System.Math and System.MathF
Commit migrated from https://github.com/dotnet/corefx/commit/
2aee413653a0661b47f1c168a13a89523b18c878
Alexander Soldatov [Wed, 7 Feb 2018 21:20:00 +0000 (00:20 +0300)]
[Unix] Passing extra CMake args (dotnet/corefx#26792)
Added support for compiler and linker additional arguments in CMake.
By using CLR_ADDITIONAL_LINKER_FLAGS and CLR_ADDITIONAL_COMPILER_OPTIONS
it's possible to pass toolchain options without changing build scripts.
Commit migrated from https://github.com/dotnet/corefx/commit/
3c24c32ae9866c158b7f6e174d43dfb36711bc96
Jeremy Kuhne [Wed, 7 Feb 2018 21:01:16 +0000 (13:01 -0800)]
Fix accessing trimmed paths (dotnet/corefx#26918)
* Fix accessing trimmed paths
Paths with trailing spaces or periods are normally trimmed by Windows. They can, however, be created using `\\?\` or be exposed via mapping of remote file systems. This change fixes the ability to work with returned *Info classes on files of this type.
This change also cleans up the Info classes:
- removes non-relevant comments
- removes "display" paths (limited trust holdover)
Also remove dead PathPair class.
* Fix helper for .NET Standard
Commit migrated from https://github.com/dotnet/corefx/commit/
e2cd5a8fc468b63255f91f4f28bccddb3bb31e8f
dotnet-maestro-bot [Wed, 7 Feb 2018 20:56:57 +0000 (14:56 -0600)]
Update BuildTools to preview2-02507-01 (dotnet/corefx#26928)
Commit migrated from https://github.com/dotnet/corefx/commit/
1363d07c098008826297c58d069f5df3b6aa6860
Maryam Ariyan [Wed, 7 Feb 2018 20:29:48 +0000 (15:29 -0500)]
Adding TrimExcess API to Dictionary and providing tests (dotnet/corefx#26239)
Commit migrated from https://github.com/dotnet/corefx/commit/
301708f83572084775b7b339fb5e0d6a3217c1d6
Geoff Kizer [Wed, 7 Feb 2018 20:09:08 +0000 (12:09 -0800)]
Merge pull request dotnet/corefx#26920 from geoffkizer/upgradetest
add test for connection upgrade
Commit migrated from https://github.com/dotnet/corefx/commit/
257a149d3c3af85e3a486b3a713d3267fd591107
Matt Mitchell [Wed, 7 Feb 2018 19:31:11 +0000 (11:31 -0800)]
Fix duplicated refnames (dotnet/corefx#26929)
* Fix duplicated refnames
Commit migrated from https://github.com/dotnet/corefx/commit/
800974a7170390b364b64643e39777c6907551e6
Max Kerr [Wed, 7 Feb 2018 19:00:10 +0000 (11:00 -0800)]
Remove an incorrect CookieParser test. (dotnet/corefx#26927)
The test CookieParserGet_SetCookieHeaderValue_Success was written with an incorrect understanding of the desired behavior of CookieParser.Get().
The test was disabled when it was merged, and is fundamentally incorrect enough that it doesn't make sense to rewrite it. The relevant code is already covered by the regular cookie parsing tests.
Fixes: dotnet/corefx#22925
Commit migrated from https://github.com/dotnet/corefx/commit/
ff003980926913d799850233ea59b1ebee3ed837
Geoff Kizer [Wed, 7 Feb 2018 17:32:58 +0000 (09:32 -0800)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
7b9be1d656ecba48fdb4082b37a66574c3172a4e
Geoff Kizer [Wed, 7 Feb 2018 08:00:42 +0000 (00:00 -0800)]
add test for connection upgrade
Commit migrated from https://github.com/dotnet/corefx/commit/
61eb7b2667465dcc6e4c52829a505d74e51adc4a
Stephen Toub [Wed, 7 Feb 2018 17:27:29 +0000 (12:27 -0500)]
Fix ServicePointManager.ProxyAddressIfNecessary to ignore "system" proxy failures (dotnet/corefx#26925)
The whole ServicePointManager implementation is there just to make basic stuff not fail. But HttpWebRequest's Proxy defaults to an internal dummy singleton SystemWebProxy whose GetProxy method throws a PlatformNotSupportedException. Until we can clean that up and have a real proxy in place, we should just eat that PlatformNotSupportedException when the ServicePointManager calls GetProxy.
Commit migrated from https://github.com/dotnet/corefx/commit/
a9e01da6f1b3a0dfbc36d17823a2264e2ec47050
Stephen Toub [Wed, 7 Feb 2018 12:51:10 +0000 (07:51 -0500)]
Add Connection{Idle}Timeouts to ManagedHandler (dotnet/corefx#26839)
* Add Connection{Idle}Timeouts to ManagedHandler
We can agree on the final name(s) when going through API reviews. For now, I chose what I think are easy to understand names:
- ConnectionTimeout: how long a connection is allowed to be reused before it's no longer usable, defaults to infinite
- ConnectionIdleTimeout: how long a connection can sit idle in the pool before it's no longer usable, defaults to 2 minutes (that value was hardcoded before this change)
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
1a5cdbe1af7a5befe16bb4581f29f0af64f4a101
dotnet-maestro-bot [Wed, 7 Feb 2018 11:23:30 +0000 (05:23 -0600)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-26207-00, beta-26207-00, respectively (dotnet/corefx#26923)
Commit migrated from https://github.com/dotnet/corefx/commit/
e03cc8f4c786936ebe63a064088c3554cacddf10
Geoff Kizer [Wed, 7 Feb 2018 08:12:58 +0000 (00:12 -0800)]
Merge pull request dotnet/corefx#26782 from geoffkizer/httpmisc2
ManagedHandler: support LF line endings and trailer headers
Commit migrated from https://github.com/dotnet/corefx/commit/
ddf2a6d45973d5ceb6b2c9920a23f64094c6da3c