platform/upstream/dbus.git
13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Wed, 25 May 2011 17:18:00 +0000 (18:18 +0100)]
Merge branch 'dbus-1.4'

13 years agoNEWS
Simon McVittie [Wed, 25 May 2011 17:17:53 +0000 (18:17 +0100)]
NEWS

13 years agobus_context_log: divert messages to stderr if we're not using syslog
Simon McVittie [Wed, 16 Mar 2011 14:52:39 +0000 (14:52 +0000)]
bus_context_log: divert messages to stderr if we're not using syslog

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoprocess_config_first_time_only: initialize syslog as intended.
Simon McVittie [Tue, 15 Mar 2011 15:42:56 +0000 (15:42 +0000)]
process_config_first_time_only: initialize syslog as intended.

On Linux, we previously called openlog() (with different options!) while
initializing SELinux; leave SELinux messages as LOG_USER|LOG_INFO in case
anyone was relying on that, but let the rest of our log messages come
out as LOG_DAEMON.

Also enable LOG_PERROR (copy syslog messages to stderr) unconditionally;
we can make this an autoconf check if anyone's pet Unix doesn't have
LOG_PERROR.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358
Reviewed-by: Colin Walters <walters@verbum.org>
13 years ago_dbus_init_system_log: remove FIXME on Windows
Simon McVittie [Tue, 15 Mar 2011 15:32:02 +0000 (15:32 +0000)]
_dbus_init_system_log: remove FIXME on Windows

We don't need any initialization here, so there's nothing to fix.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agobus_context_check_security_policy: syslog if we hit the outgoing quota
Simon McVittie [Tue, 15 Mar 2011 14:16:18 +0000 (14:16 +0000)]
bus_context_check_security_policy: syslog if we hit the outgoing quota

In practice, nothing copes with missing broadcast signals, so the least
we can do is make the failure mode visible.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agobus_context_check_security_policy: for SELinux denials, share code to set errors
Simon McVittie [Tue, 15 Mar 2011 14:02:06 +0000 (14:02 +0000)]
bus_context_check_security_policy: for SELinux denials, share code to set errors

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agobus_context_check_security_policy: factor out complain_about_message
Simon McVittie [Tue, 15 Mar 2011 13:05:23 +0000 (13:05 +0000)]
bus_context_check_security_policy: factor out complain_about_message

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35358
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Wed, 25 May 2011 16:39:34 +0000 (17:39 +0100)]
Merge branch 'dbus-1.4'

13 years agoCheck for X even if X11 autolaunching is disabled
Simon McVittie [Fri, 25 Feb 2011 12:49:54 +0000 (12:49 +0000)]
Check for X even if X11 autolaunching is disabled

DBUS_ENABLE_X11_AUTOLAUNCH obviously requires DBUS_BUILD_X11. However,
the converse is not true.

If DBUS_BUILD_X11 is defined, dbus-launch will be able to connect to
the X server to determine when the session ends; most distributors will
want this, but it can be disabled with the standard Autoconf option
--without-x.

If DBUS_ENABLE_X11_AUTOLAUNCH is *also* defined, dbus-launch and libdbus
will be willing to perform autolaunch. Again, most distributors will want
this, but it can be disabled with --disable-x11-autolaunch.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19997
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agotest-autolaunch: don't expect autolaunching to work if X11 is disabled
Simon McVittie [Fri, 25 Feb 2011 12:34:38 +0000 (12:34 +0000)]
test-autolaunch: don't expect autolaunching to work if X11 is disabled

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19997
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Wed, 25 May 2011 16:00:18 +0000 (17:00 +0100)]
Merge branch 'dbus-1.4'

13 years agoNEWS
Simon McVittie [Wed, 25 May 2011 16:00:07 +0000 (17:00 +0100)]
NEWS

13 years agoWhen checking for __sync_sub_and_fetch, don't underquote, to shut up recent autoconf
Simon McVittie [Mon, 9 May 2011 17:49:54 +0000 (18:49 +0100)]
When checking for __sync_sub_and_fetch, don't underquote, to shut up recent autoconf

Without the correct number of levels of quoting, autoconf mistakenly
believes we didn't use AC_LANG_SOURCE where required. (In fact,
AC_LANG_PROGRAM calls AC_LANG_SOURCE.)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoWhen checking for va_copy, use AC_LANG_SOURCE to shut up recent autoconf
Simon McVittie [Mon, 9 May 2011 17:48:52 +0000 (18:48 +0100)]
When checking for va_copy, use AC_LANG_SOURCE to shut up recent autoconf

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoUse TP_ADD_COMPILER_FLAG to simplify application of warning-like CFLAGS
Simon McVittie [Mon, 9 May 2011 18:03:12 +0000 (19:03 +0100)]
Use TP_ADD_COMPILER_FLAG to simplify application of warning-like CFLAGS

This also means we check for support for them.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoUse TP_COMPILER_WARNINGS for all -Wfoo options
Simon McVittie [Mon, 9 May 2011 18:02:46 +0000 (19:02 +0100)]
Use TP_COMPILER_WARNINGS for all -Wfoo options

This consistently checks whether all these options actually work in the
current version of gcc.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoImport tp-compiler-flag.m4 and tp-compiler-warnings.m4 from telepathy-glib
Simon McVittie [Mon, 9 May 2011 17:32:51 +0000 (18:32 +0100)]
Import tp-compiler-flag.m4 and tp-compiler-warnings.m4 from telepathy-glib

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19681
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoNEWS
Simon McVittie [Wed, 25 May 2011 15:52:41 +0000 (16:52 +0100)]
NEWS

13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Wed, 25 May 2011 15:51:23 +0000 (16:51 +0100)]
Merge branch 'dbus-1.4'

13 years agoNEWS
Simon McVittie [Wed, 25 May 2011 15:50:09 +0000 (16:50 +0100)]
NEWS

13 years agohandle_server_data_anonymous_mech: remove unnecessary debug output
Simon McVittie [Tue, 18 Jan 2011 16:34:12 +0000 (16:34 +0000)]
handle_server_data_anonymous_mech: remove unnecessary debug output

Doing a malloc and a hex-encoding pass just to produce a _dbus_verbose
message (i.e. a message that, in practice, nobody will see) seems like
overkill, and this block had incorrect error handling (not checking the
result of _dbus_string_init) which upsets static analysis tools.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29881
Bug-NB: NB#180486
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
13 years agodbus-launch: pass_info: always free strings on OOM
Simon McVittie [Tue, 18 Jan 2011 16:29:53 +0000 (16:29 +0000)]
dbus-launch: pass_info: always free strings on OOM

This doesn't really do anything, because we're about to exit anyway, but
it placates static analysis tools.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29881
Bug-NB: NB#180486
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
13 years agodbus-send: remove minor dead code
Simon McVittie [Wed, 26 Jan 2011 18:40:49 +0000 (18:40 +0000)]
dbus-send: remove minor dead code

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33128
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
13 years agodbus_connection_dispatch: remove dead code
Simon McVittie [Wed, 26 Jan 2011 18:38:01 +0000 (18:38 +0000)]
dbus_connection_dispatch: remove dead code

There's no way pending can be non-NULL here; if it was, we'd have jumped
straight past this block (getting filters from the connection), because
replies to pending calls don't go through filters.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33128
Reviewed-by: Cosimo Alfarano <cosimo.alfarano@collabora.co.uk>
13 years agoSpelling fix.
Ralf Habacker [Sun, 22 May 2011 18:33:47 +0000 (20:33 +0200)]
Spelling fix.

13 years agoDefinition is obsolate with commit e0fc90bdf2c60a4c77fffaf490d6f06b2bd6999d
Ralf Habacker [Sun, 22 May 2011 14:53:48 +0000 (16:53 +0200)]
Definition is obsolate with commit e0fc90bdf2c60a4c77fffaf490d6f06b2bd6999d

13 years agoTo avoid double dbus version definitions take values from configure.ac.
Ralf Habacker [Sun, 22 May 2011 11:02:34 +0000 (13:02 +0200)]
To avoid double dbus version definitions take values from configure.ac.

13 years agoDBusNonceFile: don't always fail when use_subdir=TRUE, i.e. on Unix
Simon McVittie [Tue, 22 Feb 2011 13:42:46 +0000 (13:42 +0000)]
DBusNonceFile: don't always fail when use_subdir=TRUE, i.e. on Unix

In shell-like pseudocode, the desired result is:

if $use_subdir
  dir = $tmpdir/dbus_nonce-$random
  path = $dir/nonce
  mkdir $dir
  write file at $path
else
  dir = $user_owned_place
  path = $dir/dbus_nonce-$random
  write file at $path

However, /nonce was accidentally appended to $dir instead of $path,
resulting in an attempt to mkdir /tmp/dbus_nonce-XXXX/nonce when
dbus_nonce-XXXX hadn't been created yet.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34569
Tested-by: David Zeuthen <davidz@redhat.com>
Reviewed-by: David Zeuthen <davidz@redhat.com>
13 years agoRelax review criteria for the review cabal themselves, as discussed on-list
Simon McVittie [Wed, 25 May 2011 15:02:43 +0000 (16:02 +0100)]
Relax review criteria for the review cabal themselves, as discussed on-list

Colin agreed in principle and nobody actually objected, so here we go...

13 years agoAdd davidz to the review cabal
Simon McVittie [Wed, 25 May 2011 15:01:57 +0000 (16:01 +0100)]
Add davidz to the review cabal

Acked-by: Will Thompson <will.thompson@collabora.co.uk>
Acked-by: Colin Walters <walters@verbum.org>
13 years agofix verb-subject agreement in ObjectManager spec
Simon McVittie [Wed, 25 May 2011 14:25:45 +0000 (15:25 +0100)]
fix verb-subject agreement in ObjectManager spec

13 years agoAdd org.freedesktop.DBus.ObjectManager interface
David Zeuthen [Tue, 8 Mar 2011 15:41:26 +0000 (10:41 -0500)]
Add org.freedesktop.DBus.ObjectManager interface

The org.freedesktop.DBus.ObjectManager provides a standardized and
efficient way of keeping one or more tree of objects synchronized
between one server and several clients.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34869
Signed-off-by: David Zeuthen <davidz@redhat.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
13 years agoAdded cmake 'help-options' target to print out all available configure options
Ralf Habacker [Sun, 22 May 2011 21:01:13 +0000 (23:01 +0200)]
Added cmake 'help-options' target to print out all available configure options

13 years agoCleaned public cmake option naming.
Ralf Habacker [Sun, 22 May 2011 20:53:37 +0000 (22:53 +0200)]
Cleaned public cmake option naming.

13 years agoSpelling fix.
Ralf Habacker [Sun, 22 May 2011 18:33:47 +0000 (20:33 +0200)]
Spelling fix.

13 years agoDefinition is obsolate with commit e0fc90bdf2c60a4c77fffaf490d6f06b2bd6999d
Ralf Habacker [Sun, 22 May 2011 14:53:48 +0000 (16:53 +0200)]
Definition is obsolate with commit e0fc90bdf2c60a4c77fffaf490d6f06b2bd6999d

13 years agoTo avoid double dbus version definitions take values from configure.ac.
Ralf Habacker [Sun, 22 May 2011 11:02:34 +0000 (13:02 +0200)]
To avoid double dbus version definitions take values from configure.ac.

13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Tue, 3 May 2011 09:27:52 +0000 (10:27 +0100)]
Merge branch 'dbus-1.4'

13 years agodbus_connection_can_send_type: clarify that invalid codes are allowed here
Simon McVittie [Thu, 3 Mar 2011 17:02:23 +0000 (17:02 +0000)]
dbus_connection_can_send_type: clarify that invalid codes are allowed here

This is sufficiently unusual that it seems worth saying explicitly

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35182
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Fri, 29 Apr 2011 14:45:20 +0000 (15:45 +0100)]
Merge branch 'dbus-1.4'

13 years agoNEWS
Simon McVittie [Fri, 29 Apr 2011 14:44:35 +0000 (15:44 +0100)]
NEWS

13 years agominotaur: bail if asked to monitor >1 bus
Will Thompson [Fri, 12 Feb 2010 19:19:05 +0000 (19:19 +0000)]
minotaur: bail if asked to monitor >1 bus

A coworker was just tripped up by `dbus-monitor --session --system` only
monitoring the system bus. This patch would have saved him reproducing a
tricky bug several times!

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=26548
Reviewed-by: Colin Walters <walters@verbum.org>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
13 years agoNEWS for 1.5
Simon McVittie [Wed, 27 Apr 2011 17:05:19 +0000 (18:05 +0100)]
NEWS for 1.5

13 years agoClarify that 'r' and 'e' cannot appear in signatures
Simon McVittie [Tue, 26 Apr 2011 15:06:58 +0000 (16:06 +0100)]
Clarify that 'r' and 'e' cannot appear in signatures

Reviewed-by: Colin Walters <walters@verbum.org>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34529

13 years agoReserve 'm', '*', '?', '@', '&' and '^' for their uses in GVariant
Simon McVittie [Tue, 26 Apr 2011 16:14:23 +0000 (17:14 +0100)]
Reserve 'm', '*', '?', '@', '&' and '^' for their uses in GVariant

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34529
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Wed, 27 Apr 2011 16:59:35 +0000 (17:59 +0100)]
Merge branch 'dbus-1.4'

13 years agoNEWS for 1.4
Simon McVittie [Wed, 27 Apr 2011 16:59:28 +0000 (17:59 +0100)]
NEWS for 1.4

13 years agomachine-id: fall back to reading /etc/machine-id if D-Bus machine ID is not available
Lennart Poettering [Fri, 11 Mar 2011 01:58:39 +0000 (02:58 +0100)]
machine-id: fall back to reading /etc/machine-id if D-Bus machine ID is not available

Newer systemd-based systems support a global machine ID with the same
metrics as the D-Bus machine ID, but more powerful semantics (for
example on ro media) in /etc/machine-id.

If the D-Bus machine ID cannot be read, fall back to the systemd machine
ID.

This is a first step towards allowing D-Bus to be started up during
early boot where /var is not available.

[plus a whitespace fix -smcv]

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Colin Walters <walters@verbum.org>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35228

13 years ago_dbus_check_fdleaks_enter, _dbus_check_fdleaks_leave: whitespace
Simon McVittie [Mon, 21 Mar 2011 10:16:28 +0000 (10:16 +0000)]
_dbus_check_fdleaks_enter, _dbus_check_fdleaks_leave: whitespace

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35173
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoDon't report file descriptors as "leaked" if they were already open
Simon McVittie [Mon, 14 Mar 2011 16:53:23 +0000 (16:53 +0000)]
Don't report file descriptors as "leaked" if they were already open

This is necessary to run the regression tests under valgrind (if
telling it to output to a dedicated fd), gdb, fakeroot etc.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35173
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Tue, 26 Apr 2011 18:20:18 +0000 (19:20 +0100)]
Merge branch 'dbus-1.4'

Conflicts:
NEWS

13 years agoNEWS
Simon McVittie [Tue, 26 Apr 2011 18:19:24 +0000 (19:19 +0100)]
NEWS

13 years agoMerge remote-tracking branch 'origin/dbus-1.4' into dbus-1.4
Simon McVittie [Tue, 26 Apr 2011 18:18:35 +0000 (19:18 +0100)]
Merge remote-tracking branch 'origin/dbus-1.4' into dbus-1.4

13 years agoNEWS
Simon McVittie [Tue, 26 Apr 2011 18:17:29 +0000 (19:17 +0100)]
NEWS

13 years agodbus-1.pc.in: move -lpthread, -lrt, Winsock to Libs.private
Simon McVittie [Thu, 2 Dec 2010 13:21:04 +0000 (13:21 +0000)]
dbus-1.pc.in: move -lpthread, -lrt, Winsock to Libs.private

"Private libraries  are  libraries  which  are  not  exposed through your
library, but are needed in the case of static linking"  -- pkg-config(1)

Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Tue, 26 Apr 2011 18:15:18 +0000 (19:15 +0100)]
Merge branch 'dbus-1.4'

13 years agoNEWS
Simon McVittie [Tue, 26 Apr 2011 18:15:09 +0000 (19:15 +0100)]
NEWS

13 years agoactivation: Use _dbus_system_log for activation information
Colin Walters [Sat, 26 Mar 2011 19:52:50 +0000 (15:52 -0400)]
activation: Use _dbus_system_log for activation information

Log when we are activating something (and whether it's via systemd)
as well as when we fail to activate, and when one succeeds.

https://bugs.freedesktop.org/show_bug.cgi?id=35705

13 years agoAdd dbus-1-uninstalled.pc.in
Simon McVittie [Tue, 4 Jan 2011 19:12:46 +0000 (19:12 +0000)]
Add dbus-1-uninstalled.pc.in

See: http://smcv.pseudorandom.co.uk/2008/09/pc-uninstalled/

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32827
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Tue, 26 Apr 2011 18:05:53 +0000 (19:05 +0100)]
Merge branch 'dbus-1.4'

Conflicts:
NEWS

13 years agoAdd support for --disable-gc-sections for broken toolchains
Simon McVittie [Mon, 21 Feb 2011 17:13:12 +0000 (17:13 +0000)]
Add support for --disable-gc-sections for broken toolchains

Also use AC_LINK_IFELSE rather than reinventing it as a shell function.
This was the last user of ld_supports_flag, so, delete it.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33466
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoDrop outdated list of options from README, mention configure --help instead
Simon McVittie [Mon, 21 Feb 2011 16:33:29 +0000 (16:33 +0000)]
Drop outdated list of options from README, mention configure --help instead

13 years agoRelease notes for the -fPIE change
Simon McVittie [Mon, 21 Feb 2011 16:34:13 +0000 (16:34 +0000)]
Release notes for the -fPIE change

13 years agoDon't force use of -fPIE for the dbus-daemon if apparently supported
Simon McVittie [Mon, 21 Feb 2011 16:23:24 +0000 (16:23 +0000)]
Don't force use of -fPIE for the dbus-daemon if apparently supported

It's a minor security benefit, but not automatically beneficial (it
enables ASLR, but breaks prelinking, some buggy toolchains, and some gdb
versions). Distributions who know their infrastructure works well can
enable it just as easily via

    ./configure CFLAGS="-fPIE" LDFLAGS="-pie"

without extra support from us, and that's a generic solution applicable to
many packages.

Similarly, don't force libdbus and libdbus-internal to be PIC: libtool
knows better than we do whether that's necessary/beneficial on a
particular platform.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=16621
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=27215
Bug-NB: NB#171940
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoInstall dbus-daemon and dbus-daemon-launch-helper in the conventional way
Simon McVittie [Tue, 22 Mar 2011 12:11:27 +0000 (12:11 +0000)]
Install dbus-daemon and dbus-daemon-launch-helper in the conventional way

Also remove some pointless indirection (extra_tests etc.), don't install
the unused directory $(libexecdir)/dbus-1 (we actually install the
launch helper directly into $(libexecdir)), and allow dbus_daemondir to be
set on Windows rather than forcing dbus-daemon to be installed to
$(bindir) there.

dbus_daemon_execdir has to contain "exec" so that the dbus-daemon will be
installed by "make install-exec" and not "make install-data".

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=14512
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agodbus_bus_add_match: improve error documentation.
Will Thompson [Thu, 14 Apr 2011 17:18:25 +0000 (18:18 +0100)]
dbus_bus_add_match: improve error documentation.

It's simply not true that the only possible error is a lack of resources
in the bus.

13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Tue, 12 Apr 2011 10:27:09 +0000 (11:27 +0100)]
Merge branch 'dbus-1.4'

13 years agoWhen uploading docs, use rsync -p to set permissions
Simon McVittie [Mon, 11 Apr 2011 11:04:19 +0000 (12:04 +0100)]
When uploading docs, use rsync -p to set permissions

It turns out that rsync --chmod means "pretend the source files had
already had this chmod operation applied to them", and not "chmod the
destination files" like you'd expect.

As a result, the -p (--perms) option is also needed, so that rsync will
"preserve" the modified permissions. Otherwise, the docs will not be
group-writeable as intended, and only the person who made the previous
upload will be able to upload them next time.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=36130
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
13 years agoDevelopment version: 1.5.1, dbus-specification 0.17
Simon McVittie [Mon, 11 Apr 2011 18:04:30 +0000 (19:04 +0100)]
Development version: 1.5.1, dbus-specification 0.17

13 years agoPrepare 1.5.0 dbus-1.5.0
Simon McVittie [Mon, 11 Apr 2011 12:34:28 +0000 (13:34 +0100)]
Prepare 1.5.0

- D-Bus Specification 0.16
- libtool 9:0:6

13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Fri, 8 Apr 2011 14:23:17 +0000 (15:23 +0100)]
Merge branch 'dbus-1.4'

Conflicts:
NEWS

13 years agodevelopment version
Simon McVittie [Fri, 8 Apr 2011 14:22:31 +0000 (15:22 +0100)]
development version

13 years agoPrepare version 1.4.8 dbus-1.4.8
Simon McVittie [Fri, 8 Apr 2011 13:30:23 +0000 (14:30 +0100)]
Prepare version 1.4.8

13 years agoactivation: Strip out code to compare by Exec=
Colin Walters [Mon, 28 Mar 2011 17:21:35 +0000 (13:21 -0400)]
activation: Strip out code to compare by Exec=

In commit:
 075945f6        (John (J5) Palmieri     2005-07-14 20:44:15 +0000

some code was added to compare services by Exec key.  The changelog is
not pariticularly informative as to why this was added. But while
debugging other code, we noticed this.

Comparing by Exec key is not in the specification, and triggered a
problem where while converting services to use systemd for activation,
a change was made to use Exec=/bin/false and simply rely on systemd
to activate.

While I think it was broken for the service files to be changed
to Exec=/bin/false, we shouldn't be doing something here that's
not in the spec either.

Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35750

13 years agooops, fix XML mis-nesting
Simon McVittie [Thu, 7 Apr 2011 17:27:52 +0000 (18:27 +0100)]
oops, fix XML mis-nesting

13 years agolist which parts of the Desktop Entry spec apply to service files
Sven Herzberg [Thu, 7 Apr 2011 17:25:34 +0000 (18:25 +0100)]
list which parts of the Desktop Entry spec apply to service files

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19159

13 years agoMerge branch 'arg0namespace-24317'
Simon McVittie [Thu, 7 Apr 2011 16:16:01 +0000 (17:16 +0100)]
Merge branch 'arg0namespace-24317'

Reviewed-by: David Zeuthen <davidz@redhat.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=24317
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=31818
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34870

13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Thu, 7 Apr 2011 16:15:41 +0000 (17:15 +0100)]
Merge branch 'dbus-1.4'

13 years agoMention dbus-specification.xml's separate versioning in HACKING
Simon McVittie [Thu, 7 Apr 2011 15:31:06 +0000 (16:31 +0100)]
Mention dbus-specification.xml's separate versioning in HACKING

13 years agoCheck parsing (or otherwise) of path_namespace in match rules
Simon McVittie [Thu, 7 Apr 2011 15:30:41 +0000 (16:30 +0100)]
Check parsing (or otherwise) of path_namespace in match rules

13 years agoRemove support for trailing "." on arg0namespace
Simon McVittie [Thu, 7 Apr 2011 12:13:56 +0000 (13:13 +0100)]
Remove support for trailing "." on arg0namespace

13 years agoRename path_prefix to path_namespace and disallow trailing '/'
Simon McVittie [Thu, 7 Apr 2011 15:12:22 +0000 (16:12 +0100)]
Rename path_prefix to path_namespace and disallow trailing '/'

Also disallow having both path and path_namespace in the same match rule
(it wouldn't make sense, path is more specific than path_namespace).

As per IRC discussion with davidz and wjt.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34870

13 years agoDocument when arg0namespace was added, for completeness
Simon McVittie [Thu, 7 Apr 2011 14:27:01 +0000 (15:27 +0100)]
Document when arg0namespace was added, for completeness

13 years agoDocument when argNpath was added, for completeness
Simon McVittie [Thu, 7 Apr 2011 14:26:49 +0000 (15:26 +0100)]
Document when argNpath was added, for completeness

13 years agospecification: fix versioning
Simon McVittie [Thu, 7 Apr 2011 13:46:04 +0000 (14:46 +0100)]
specification: fix versioning

We've added things since 0.15, so this isn't still 0.15.

13 years agopath_prefix: anchor matches at path-component boundaries, and give examples
Simon McVittie [Thu, 7 Apr 2011 13:45:19 +0000 (14:45 +0100)]
path_prefix: anchor matches at path-component boundaries, and give examples

It seems wrong that path_prefix="/foo" matches /foobar, and it isn't
difficult or expensive to check.

13 years agoAdd path_prefix match rule
David Zeuthen [Tue, 8 Mar 2011 15:32:34 +0000 (10:32 -0500)]
Add path_prefix match rule

Add a new path_prefix match rule that can be used for efficient
implementations of the org.freedesktop.DBus.ObjectManager interface
(see bug 34869).

https://bugs.freedesktop.org/show_bug.cgi?id=34870

Signed-off-by: David Zeuthen <davidz@redhat.com>
13 years agore-word description of arg0namespace
Simon McVittie [Thu, 7 Apr 2011 12:12:02 +0000 (13:12 +0100)]
re-word description of arg0namespace

It's unclear at first reading whether "may contain only one element"
means "elements >= 1, as an exception to the usual rule that
elements >= 2" (which is what was intended), or "elements == 1".

"Like a bus name or interface name" is a little ambiguous because they
have different syntactic restrictions: specifically allow any valid bus
name, which also allows all interface names.

13 years agosignals.h: rename argument in declaration to match implementation
Simon McVittie [Thu, 7 Apr 2011 11:41:52 +0000 (12:41 +0100)]
signals.h: rename argument in declaration to match implementation

13 years agoMerge remote-tracking branch 'wjt/arg0namespace' into arg0namespace-24317
Simon McVittie [Thu, 7 Apr 2011 11:40:30 +0000 (12:40 +0100)]
Merge remote-tracking branch 'wjt/arg0namespace' into arg0namespace-24317

13 years agoBreak up the monster conditional in config-parser so gcov can cope
Simon McVittie [Mon, 14 Mar 2011 11:45:04 +0000 (11:45 +0000)]
Break up the monster conditional in config-parser so gcov can cope

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=10887
Reviewed-by: Colin Walters <walters@verbum.org>
13 years agoUpdate NEWS for master
Simon McVittie [Mon, 14 Mar 2011 12:02:19 +0000 (12:02 +0000)]
Update NEWS for master

13 years agoMerge branch 'dbus-1.4'
Simon McVittie [Mon, 14 Mar 2011 11:58:36 +0000 (11:58 +0000)]
Merge branch 'dbus-1.4'

13 years agoUpdate NEWS
Simon McVittie [Mon, 14 Mar 2011 11:58:28 +0000 (11:58 +0000)]
Update NEWS

13 years agoMerge branch 'dbus-1.4', rejecting all changes
Simon McVittie [Mon, 14 Mar 2011 11:53:24 +0000 (11:53 +0000)]
Merge branch 'dbus-1.4', rejecting all changes

This commit changes nothing, but means that merge tracking won't try to
apply the reversion of d1d395774435..09c9d6406b75f to master in future.

13 years agoRevert merge of master (dbus-1.5) into dbus-1.4
Simon McVittie [Mon, 14 Mar 2011 11:53:09 +0000 (11:53 +0000)]
Revert merge of master (dbus-1.5) into dbus-1.4

This reverts commits d1d395774435..09c9d6406b75f, keeping Lennart's
addition of UnknownInterface etc.

13 years agoconnection: hook UnknownObject and UnknownInterface up where appropriate
Lennart Poettering [Thu, 10 Mar 2011 03:10:31 +0000 (04:10 +0100)]
connection: hook UnknownObject and UnknownInterface up where appropriate

This makes use of UnknownInterface and UnknownObject where appropriate
in the D-Bus core.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34527
Reviewed-By: Simon McVittie <simon.mcvittie@collabora.co.uk>
13 years agoprotocol: introduce four new errors
Lennart Poettering [Thu, 10 Mar 2011 03:06:32 +0000 (04:06 +0100)]
protocol: introduce four new errors

UnknownInterface, UnknownObject, UnknownProperty and PropertyReadOnly,
as discussed on the ML.

The first two are already used by various bindings, such as the Qt and
Java binding, but have never been made official.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=34527
Reviewed-by: David Zeuthen <davidz@redhat.com>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
13 years agoMake dbus_type_is_valid into public API
Simon McVittie [Thu, 3 Mar 2011 17:35:14 +0000 (17:35 +0000)]
Make dbus_type_is_valid into public API

This is just as useful for bindings as dbus_signature_validate, and I
think it's a good design principle to say that anything checked in a
_dbus_return_if_fail should be something the caller could check
for themselves.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=20496
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>