review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

epoger [Thu, 7 Aug 2014 19:13:12 +0000 (12:13 -0700)]

rebaseline_server: allow live queries to examine JSONKEY_EXPECTEDRESULTS or JSONKEY_ACTUALRESULTS

See https://goto.google.com/CorrectnessTestingBigIssues for full context

BUG=skia:1942
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/453433004

commit | commitdiff | tree

reed [Thu, 7 Aug 2014 18:48:10 +0000 (11:48 -0700)]

add isRect() check to AAClip, to detect if a soft-clip is really just an irect

taken from (https://codereview.chromium.org/445233006/)

fix: don't assume that the first yoffset is 0, since we may have performed a translate and not
re-alloced our data.

This reverts commit 0aeea6d344f12e35e29a79f4bbc48af88f913204.

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/443353004

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 18:33:59 +0000 (11:33 -0700)]

Revert of - Add astcbitmap to gm slides (https://codereview.chromium.org/444093002/)

Reason for revert:
Breaking DM

Original issue's description:
> - Add astcbitmap to gm slides
> - Add additional ASTC formats
> - Add astc image decoder files
>
> Committed: https://skia.googlesource.com/skia/+/2fc05823fed4b9649338f3029cd1ba05ef49a02f

R=reed@google.com, robertphillips@google.com, halcanary@google.com
TBR=halcanary@google.com, reed@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/447343002

commit | commitdiff | tree

djsollen [Thu, 7 Aug 2014 18:30:30 +0000 (11:30 -0700)]

Disable suspect NEON function for 64-bit Android

R=halcanary@google.com, mtklein@google.com, kevin.petit@arm.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/451633006

commit | commitdiff | tree

borenet [Thu, 7 Aug 2014 18:28:20 +0000 (11:28 -0700)]

Duplicate NoGPU expectations for new recipes bot

BUG=skia:761
R=epoger@google.com
TBR=epoger
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/447323003

commit | commitdiff | tree

reed [Thu, 7 Aug 2014 18:19:11 +0000 (11:19 -0700)]

Revert of add isRect() check to AAClip, to detect if a soft-clip is really just an irect (https://codereview.chromium.org/445233006/)

Reason for revert:
new code asserts on some pictures

Original issue's description:
> add isRect() check to AAClip, to detect if a soft-clip is really just an irect
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/592cb8d552556b1e922887d506d00b64bc5d0547

R=bsalomon@google.com, humper@google.com
TBR=bsalomon@google.com, humper@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/452533002

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 18:18:09 +0000 (11:18 -0700)]

- Add astcbitmap to gm slides
- Add additional ASTC formats
- Add astc image decoder files

R=reed@google.com, robertphillips@google.com, halcanary@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444093002

commit | commitdiff | tree

halcanary [Thu, 7 Aug 2014 18:13:45 +0000 (11:13 -0700)]

Assert allocation so we can catch it sooner.

R=bungeman@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/445363007

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 18:10:22 +0000 (11:10 -0700)]

Pass a struct of functions instead of a function to the compressed blitter

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/443303006

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 17:58:43 +0000 (10:58 -0700)]

Add support for compressed alpha ktx files

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/447283002

commit | commitdiff | tree

tomhudson [Thu, 7 Aug 2014 17:20:51 +0000 (10:20 -0700)]

Don't fail unit test if resources not found on device.

Not 100% sure about the right thing to do here; looks like some other
tests warn but don't officially fail.

R=djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/451703004

commit | commitdiff | tree

reed [Thu, 7 Aug 2014 16:20:12 +0000 (09:20 -0700)]

add isRect() check to AAClip, to detect if a soft-clip is really just an irect

BUG=skia:
R=bsalomon@google.com, humper@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/445233006

commit | commitdiff | tree

fmalita [Thu, 7 Aug 2014 15:39:24 +0000 (08:39 -0700)]

Clamp SkPictureShader's tile size.

Blink used to clamp the max size for its pattern bitmaps (several SVG
pattern tests rely on/verify this behavior).

This CL clamps the maximum tile area to a reasonable value (16M pixels),
and scales beyond that.

R=bsalomon@google.com, reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/446243002

commit | commitdiff | tree

krajcevski [Thu, 7 Aug 2014 15:15:14 +0000 (08:15 -0700)]

Pass compressed blitters to our mask drawing algorithm

R=robertphillips@google.com, reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/446103002

commit | commitdiff | tree

dandov [Thu, 7 Aug 2014 14:49:53 +0000 (07:49 -0700)]

Stopped skipping tests in dm of SkPatch by implementing the
corresponding drawPath calls on classes that derive from SkCanvas.

BUG=skia:
R=egdaniel@google.com, bsalomon@google.com, mtklein@google.com, robertphillips@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/429343004

commit | commitdiff | tree

Robert Phillips [Thu, 7 Aug 2014 14:34:03 +0000 (10:34 -0400)]

Remove mandrill_128.r11.ktx from resources directory

Review URL: https://codereview.chromium.org/449503003

commit | commitdiff | tree

halcanary [Thu, 7 Aug 2014 14:24:47 +0000 (07:24 -0700)]

render_pdfs implements --match

BUG=skia:2743
NOTRY=true
R=djsollen@google.com, mtklein@google.com, borenet@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/441423002

commit | commitdiff | tree

Robert Phillips [Thu, 7 Aug 2014 14:06:24 +0000 (10:06 -0400)]

Added mandrill_128.r11.ktx to resources

Review URL: https://codereview.chromium.org/443303005

commit | commitdiff | tree

Derek Sollenberger [Wed, 6 Aug 2014 20:34:40 +0000 (16:34 -0400)]

Revert "Remove SkPaintOptionsAndroid"

This reverts commit 27fb94999b8eec448423884e1d071e563c4c95d9.

Review URL: https://codereview.chromium.org/450513002

commit | commitdiff | tree

Derek Sollenberger [Wed, 6 Aug 2014 20:31:41 +0000 (16:31 -0400)]

Fix Android framework builds

R=mtklein@google.com

Review URL: https://codereview.chromium.org/450503002

commit | commitdiff | tree

Derek Sollenberger [Wed, 6 Aug 2014 20:30:51 +0000 (16:30 -0400)]

Remove SkPaintOptionsAndroid

Review URL: https://codereview.chromium.org/447873003

commit | commitdiff | tree

bungeman [Wed, 6 Aug 2014 20:20:59 +0000 (13:20 -0700)]

Fix reference counting on SkStream in SkFontMgr_android.

R=tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/447003002

commit | commitdiff | tree

fmalita [Wed, 6 Aug 2014 20:07:15 +0000 (13:07 -0700)]

Explicit tile bounds for SkPictureShader

The integer picture size is not granular enough to allow precise tiling
in arbitrary coordinate systems. This CL adds an optional tile bounds
float rect param to control the tile size and location.

(this also allows tile spacing emulation for picture
shaders).

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/437393003

commit | commitdiff | tree

krajcevski [Wed, 6 Aug 2014 19:47:59 +0000 (12:47 -0700)]

Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444433002

commit | commitdiff | tree

reed [Wed, 6 Aug 2014 19:43:09 +0000 (12:43 -0700)]

fix concat order for local matrices

BUG=skia:
R=bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/446013004

commit | commitdiff | tree

humper [Wed, 6 Aug 2014 19:39:59 +0000 (12:39 -0700)]

make the action buttons for rebaseline server stick to the top of the window as you scroll

NOTRY=true

BUG=skia:1912
R=stephana@google.com, epoger@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/446933002

commit | commitdiff | tree

krajcevski [Wed, 6 Aug 2014 19:35:27 +0000 (12:35 -0700)]

Revert of Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes. (https://codereview.chromium.org/444433002/)

Reason for revert:
Breaking chrome.

Original issue's description:
> Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.
>
> Committed: https://skia.googlesource.com/skia/+/1840dcd2f1368279df907988a9b584ffd500de4c

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444103002

commit | commitdiff | tree

krajcevski [Wed, 6 Aug 2014 19:02:49 +0000 (12:02 -0700)]

Initial ASTC decoder -- currently only supports 2D LDR decomrpession modes.

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444433002

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 18:57:00 +0000 (11:57 -0700)]

SkPicture: try to no-op away clone().

Will actually enable this by #defining SK_PICTURE_CLONE_NOOP in Chrome's SkUserConfig.h as a separate CL after this rolls in.

BUG=skia:
R=reed@google.com, robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/447753003

commit | commitdiff | tree

robertphillips [Wed, 6 Aug 2014 18:26:53 +0000 (11:26 -0700)]

Second pass at rebaselining flaky N4 performance triggers

R=bungeman@google.com
TBR=bungeman@google.com
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/444063002

commit | commitdiff | tree

bungeman [Wed, 6 Aug 2014 18:12:20 +0000 (11:12 -0700)]

Implement SkFontMgr_Android::onMatchFamilyStyleCharacter.

This will allow us to replace SkGetFallbackFamilyNameForChar
and also eventually fix issues with it's reliance on names.

R=djsollen@google.com, tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/427293003

commit | commitdiff | tree

krajcevski [Wed, 6 Aug 2014 18:12:14 +0000 (11:12 -0700)]

Allow custom blitters to be passed to SkDraw::drawPath

R=reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/444003004

commit | commitdiff | tree

halcanary [Wed, 6 Aug 2014 18:07:11 +0000 (11:07 -0700)]

Roll android/third_party/jpeg DEPS

BUG=skia:2791
R=djsollen@google.com
TBR=djsollen@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/449493004

commit | commitdiff | tree

egdaniel [Wed, 6 Aug 2014 18:07:02 +0000 (11:07 -0700)]

Create struct in GrDrawState to hold key DrawState data.

Eventually this struct will be used to easily set values for a reduced, optimized drawstate

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/448453002

commit | commitdiff | tree

djsollen [Wed, 6 Aug 2014 18:01:58 +0000 (11:01 -0700)]

Remove references to __system_property_get from Skia

BUG=392201
R=tomhudson@chromium.org, bungeman@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/433163002

commit | commitdiff | tree

bsalomon [Wed, 6 Aug 2014 18:01:44 +0000 (11:01 -0700)]

Fix drawVertices() on GPU when texs=colors=shaders=indices=null

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/449433003

commit | commitdiff | tree

epoger [Wed, 6 Aug 2014 17:56:50 +0000 (10:56 -0700)]

rebaseline_server: add "prefetch" directive that just warms the cache without awaiting results

This will allow the buildbots to warn the production rebaseline_server: "I just
generated some new results; here's a comparison that a human might ask for
soon. Download whatever images and generate whatever diffs you would need to
provide those results."

BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/443013002

commit | commitdiff | tree

bsalomon [Wed, 6 Aug 2014 17:52:33 +0000 (10:52 -0700)]

Add angle config to nanobench and make angle a default config for dm and nanobench.

NOTREECHECKS=true
R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/441333003

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 17:08:42 +0000 (10:08 -0700)]

On the bots, there's no need to link GMs into SampleApp.

We build SampleApp on the bots to make sure it's not broken, but we don't run it. So, there's no need to link in all the GMs as samples.

This reduces the number of copies of our GMs from 4 to 3 (gm, dm, and nanobench remain).

NOTREECHECKS=true

BUG=skia:2142
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/447803002

commit | commitdiff | tree

reed [Wed, 6 Aug 2014 16:54:19 +0000 (09:54 -0700)]

parameterize tesselation params

TBR=
NOTREECHECKS=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/446913002

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 15:39:36 +0000 (08:39 -0700)]

Bye bye bench.

NOTREECHECKS=true

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/442343004

commit | commitdiff | tree

epoger [Wed, 6 Aug 2014 15:37:53 +0000 (08:37 -0700)]

rebaseline_server live queries: allow comparison against summary files within the Skia repo

This is a step towards providing SKP comparisons against expectations, not just
other actual results... we still need to allow the user to select
JSONKEY_EXPECTEDRESULTS vs JSONKEY_ACTUALRESULTS within the summary
files found.

BUG=skia:1942
NOTREECHECKS=true
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/442203002

commit | commitdiff | tree

bungeman [Wed, 6 Aug 2014 15:15:50 +0000 (11:15 -0400)]

Revert "Adds a GrGLPathRendering class that wraps the NV_path_rendering"

This reverts commit 5672da0fa54f31c9727568e9dd5fe82c6e1585bc.

This appears to be blocking the Skia roll by causing failures in the blink layout tests on the canvas-lost-gpu-context.html test.

The bisect for this can be seen at:

https://codereview.chromium.org/449473002/

Original issue's description:
> Adds a GrGLPathRendering class that wraps the NV_path_rendering
> extension and manages its various API versions. It also provides
> backup implementations when certain NVpr methods from later API
> versions are not present on the current system.
>
> Committed: https://skia.googlesource.com/skia/+/5672da0fa54f31c9727568e9dd5fe82c6e1585bc

commit | commitdiff | tree

bungeman [Wed, 6 Aug 2014 15:14:31 +0000 (11:14 -0400)]

Revert "Calculate rough approximations for nvpr path sizes"

This reverts commit 61bff7097251755bf9fa9a4ec60cc057c766b4a4.

This is built on 5672da0fa54f31c9727568e9dd5fe82c6e1585bc
which is causing blink test failures on canvas-lost-gpu-context.html.

commit | commitdiff | tree

Robert Phillips [Wed, 6 Aug 2014 14:50:53 +0000 (10:50 -0400)]

Add ASTC resource files

Review URL: https://codereview.chromium.org/442363003

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 14:46:30 +0000 (07:46 -0700)]

DM: expand peak RAM usage to Mac and Android too.

BUG=skia:

NOTREECHECKS=true
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/445963002

commit | commitdiff | tree

reed [Wed, 6 Aug 2014 14:00:27 +0000 (07:00 -0700)]

fix hittest in Patch sample

TBR=
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/441373002

commit | commitdiff | tree

djsollen [Wed, 6 Aug 2014 13:58:06 +0000 (06:58 -0700)]

Remove ALL font fallback logic from Skia.

R=reed@google.com, bungeman@google.com, caryclark@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/434623002

commit | commitdiff | tree

mtklein [Wed, 6 Aug 2014 13:55:12 +0000 (06:55 -0700)]

SkThreadPool and co. are not public.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/444583006

commit | commitdiff | tree

borenet [Wed, 6 Aug 2014 13:04:00 +0000 (06:04 -0700)]

Remove Mac 10.8 x86 Perf expectations

This is one of the problems with the way the RecreateSKPs bot determines which trybots to run: Rather than use a hard-coded list, it figures out which bots have perf expectations and then runs those bots to generate new expectations. This is problematic when we remove a bot because we have to remove its expectations as well. This is really not that different from maintaining a hard-coded list...

NOTRY=true
BUG=skia:
R=bensong@google.com, rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/443093002

commit | commitdiff | tree

robertphillips [Wed, 6 Aug 2014 12:16:29 +0000 (05:16 -0700)]

Rebaseline flaky N4 & N7 performance triggers

R=bungeman@google.com
TBR=bungeman@google.com
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/440423002

commit | commitdiff | tree

senorblanco [Tue, 5 Aug 2014 21:27:27 +0000 (14:27 -0700)]

Greenify bench bot Perf-Android-Nexus10-MaliT604-Arm7-Release at build 2563

R=bsalomon@google.com
TBR=bsalomon@google.com

Bypassing trybots:
NOTRY=true

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/442083003

commit | commitdiff | tree

senorblanco [Tue, 5 Aug 2014 21:26:28 +0000 (14:26 -0700)]

Greenify bench bot Perf-Android-GalaxyNexus-SGX540-Arm7-Release at build 1811

R=bsalomon@google.com
TBR=bsalomon@google.com

Bypassing trybots:
NOTRY=true

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/443743002

commit | commitdiff | tree

krajcevski [Tue, 5 Aug 2014 21:13:36 +0000 (14:13 -0700)]

Add support for all compressed formats in KTX file format

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/440783004

commit | commitdiff | tree

tomhudson [Tue, 5 Aug 2014 20:35:00 +0000 (13:35 -0700)]

Parses sample code provided by Android project. Attempts to keep FontFamily data structures produced consistent with expectations of previous versions of Skia.

R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/446473003

commit | commitdiff | tree

ch.dumez [Tue, 5 Aug 2014 19:20:19 +0000 (12:20 -0700)]

Expose SkColorTable class

Expose SkColorTable class as it is used in SkBitmap::allocPixels(SkColorTable*)
API, which is already exposed.

R=reed@google.com, ben@chromium.org

Author: ch.dumez@samsung.com

Review URL: https://codereview.chromium.org/418173011

commit | commitdiff | tree

senorblanco [Tue, 5 Aug 2014 19:05:03 +0000 (12:05 -0700)]

Greenify bench bot Perf-Ubuntu12-ShuttleA-GTX660-x86-Release at build 1551

R=bensong@google.com, bensong@chromium.org

Bypassing trybots:
NOTRY=true
BUG=2794

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/442903002

commit | commitdiff | tree

tomhudson [Tue, 5 Aug 2014 19:01:09 +0000 (12:01 -0700)]

Fix bad gypi

Must not depend directly on ports; depend on skialib!

R=bungeman@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/442883002

commit | commitdiff | tree

cdalton [Tue, 5 Aug 2014 17:58:19 +0000 (10:58 -0700)]

Calculate rough approximations for nvpr path sizes

Calculates a rough approximation of the actual value for gpuMemorySize
in GrGLPath and GrGLPathRange, instead of assuming every path is the
same fixed size.

BUG=skia:
R=bsalomon@google.com, markkilgard@gmail.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/442603002

commit | commitdiff | tree

epoger [Tue, 5 Aug 2014 17:07:22 +0000 (10:07 -0700)]

teach rebaseline_server to generate diffs of rendered SKPs

Creates a new live-view.html page, served by the rebaseline_server, that will display diffs between two sets of rendered SKP images.

BUG=skia:1942
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/424263005

commit | commitdiff | tree

bsalomon [Tue, 5 Aug 2014 14:50:06 +0000 (07:50 -0700)]

Move functions from GrDrawState.h to GrDrawState.cpp and delete unused functions.

R=egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/427713005

commit | commitdiff | tree

krajcevski [Tue, 5 Aug 2014 14:37:26 +0000 (07:37 -0700)]

Add ETC1 format to SkTextureCompressor

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/432143002

commit | commitdiff | tree

bsalomon [Tue, 5 Aug 2014 14:35:56 +0000 (07:35 -0700)]

Don't compare constant color and coverage between GrDrawStates when they are provided by vertex attributes.

R=egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/439273007

commit | commitdiff | tree

mtklein [Tue, 5 Aug 2014 14:19:46 +0000 (07:19 -0700)]

For some reason, starting tests before gms makes DM run much faster.

Must be getting the path ops tests going early helps?

On my desktop,
Release: 50s -> 24s
Debug: 62s -> 40s

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/435423003

commit | commitdiff | tree

bsalomon [Tue, 5 Aug 2014 14:15:57 +0000 (07:15 -0700)]

Replace op== with CombineIfPossible in GrDrawState.

R=egdaniel@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/439853002

commit | commitdiff | tree

rmistry [Tue, 5 Aug 2014 13:55:14 +0000 (06:55 -0700)]

Test new CQ bot

TBR=

(SkipBuildbotRuns)

BUG=skia:

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/441833004

commit | commitdiff | tree

tomhudson [Tue, 5 Aug 2014 13:36:11 +0000 (06:36 -0700)]

Test and generalize font configuration parser

Add a basic unit test for the Android font configuration parser.
Add a check for the new LMP file format; on detection, switch to a new
(as-yet unwritten) parser.

R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/439813002

commit | commitdiff | tree

mtklein [Tue, 5 Aug 2014 10:51:04 +0000 (03:51 -0700)]

Revert of whitespace change to force a build (https://codereview.chromium.org/432183002/)

Reason for revert:
force

Original issue's description:
> whitespace change to force a build
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/490d49c5dcc4b2242c9b25f082b23ec5e842c4e7

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/442603005

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 21:10:19 +0000 (14:10 -0700)]

Print max memory usage on Linux.

This is meant to help debug http://skbug.com/2793

BUG=skia:2793
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/433403005

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 20:57:39 +0000 (13:57 -0700)]

Fix calibration loop failure condition.

With the old logic, if the last attempt succeeded, we'd say we failed.

We also print two lines for loop calibration failures. Quiet that down.

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/431503004

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 20:11:19 +0000 (13:11 -0700)]

disable all warnings from nanomsg

They're annoying.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/437323002

commit | commitdiff | tree

egdaniel [Mon, 4 Aug 2014 19:54:39 +0000 (12:54 -0700)]

Enable gpu Debug markers if tracing category skia.gpu is enabled

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/438023004

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 19:51:19 +0000 (12:51 -0700)]

Force linking as C++ library.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/420183004

commit | commitdiff | tree

cdalton [Mon, 4 Aug 2014 18:19:11 +0000 (11:19 -0700)]

Adds a GrGLPathRendering class that wraps the NV_path_rendering
extension and manages its various API versions. It also provides
backup implementations when certain NVpr methods from later API
versions are not present on the current system.

R=bsalomon@google.com, kkinnunen@nvidia.com, markkilgard@gmail.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/437473002

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 18:10:14 +0000 (11:10 -0700)]

Don't call out -lstdc++ -lm explicitly.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/440643004

commit | commitdiff | tree

bsalomon [Mon, 4 Aug 2014 17:56:39 +0000 (10:56 -0700)]

Don't compare coord change matrices to determine effect compatibility when using explicit local coords.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/438053002

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 17:18:27 +0000 (10:18 -0700)]

Remove dependency on std::string

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/437253003

commit | commitdiff | tree

dandov [Mon, 4 Aug 2014 17:02:00 +0000 (10:02 -0700)]

SkCanvas interface for drawing a patch.

Added function SkCanvas::drawPatch to the API. This function
receives the patch to draw and the paint.

Added function SkBaseDevice::drawPatch to the API. This function also receives the patch to draw and the paint.

Currently SkGpuDevice and SkBitmapDevice generate the mesh taking into
account the scale factor and call the corresponding device's drawVertices.

BUG=skia:
R=jvanverth@google.com, egdaniel@google.com, bsalomon@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/424663006

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 16:57:37 +0000 (09:57 -0700)]

Stop building tests in the Android tree.

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/440653004

commit | commitdiff | tree

krajcevski [Mon, 4 Aug 2014 16:47:31 +0000 (09:47 -0700)]

Revert of Add ETC1 format to SkTextureCompressor (https://codereview.chromium.org/432143002/)

Reason for revert:
Breaking Chrome.

Original issue's description:
> Add ETC1 format to SkTextureCompressor
>
> Committed: https://skia.googlesource.com/skia/+/5d8b1b44ea7636fc8e98247cb311568f277ce3a5

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/438443004

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 16:36:45 +0000 (09:36 -0700)]

small skia_shared_lib=1 build fix for cross-process picture demo

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/439333002

commit | commitdiff | tree

mtklein [Mon, 4 Aug 2014 16:36:16 +0000 (09:36 -0700)]

Stop building tests.

BUG=skia:
R=borenet@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/423073011

commit | commitdiff | tree

bsalomon [Mon, 4 Aug 2014 16:21:30 +0000 (09:21 -0700)]

Remove unused matrix param from GrContext/GrDrawTarget rect drawing functions.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/441623005

commit | commitdiff | tree

krajcevski [Mon, 4 Aug 2014 16:08:29 +0000 (09:08 -0700)]

Add ETC1 format to SkTextureCompressor

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/432143002

commit | commitdiff | tree

Mike Klein [Mon, 4 Aug 2014 15:50:32 +0000 (11:50 -0400)]

Rename skimage expectations for renamed bot.

BUG=skia:

Review URL: https://codereview.chromium.org/436253004

commit | commitdiff | tree

bsalomon [Mon, 4 Aug 2014 15:31:39 +0000 (08:31 -0700)]

Exit early when draw can be skipped. Be more robust against abandoned GrContext.

R=egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/428103003

commit | commitdiff | tree

humper [Mon, 4 Aug 2014 15:31:34 +0000 (08:31 -0700)]

fix missing return in error case for bitmap scaler

BUG=skia:
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/431613003

commit | commitdiff | tree

kkinnunen [Mon, 4 Aug 2014 06:19:46 +0000 (23:19 -0700)]

Make GrGLProgram be available to GrGLProgramDataManager

GL APIs such as glProgramPathFragmentInputGenNV need the explicit program id in
order to set the program resources. For GrGLProgramDataManager to call the APIs,
the program id needs to be available to the GrGLProgramDataManager.

One GrGLProgramDataManager is used to explicitly manage the resources of one
GrGLProgram. Refactor the classes to reflect this: make GrGLProgram create and
own GrGLProgramDataManager. This way the program id can be made available through
GrGLProgram backpointer.

In order to do this, remove the population of the program link results
information for uniforms in GrGLProgramDataManager during shader generation.

Instead, accumulate the info to the uniform list of GrGLShaderBuilder. After the
generation, compilation and link is successful, this info can be used to
construct both GrGLProgram and GrGLProgramDataManager.

Changes names of functions to create UniformHandles and convert them to list
indices. This tries to highlight that they're different lists, even though at
the moment they match index-wise. E.g the contract is that handles can be
created based on the shader builder state, and the object can later be set with
the handle and the manager that was created with the builder.

This is needed to support NV_path_rendering for GLES.

R=bsalomon@google.com

Author: kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/426553011

commit | commitdiff | tree

jvanverth [Sat, 2 Aug 2014 00:15:20 +0000 (17:15 -0700)]

Fix for Chrome Canaries.

R=bsalomon@google.com
TBR=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/434623010

commit | commitdiff | tree

jvanverth [Fri, 1 Aug 2014 21:05:19 +0000 (14:05 -0700)]

Rollback text allocation changes.

This also addresses an inadvertantly introduced distance field bug.

BUG=399125
R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/438683006

commit | commitdiff | tree

bungeman [Fri, 1 Aug 2014 19:00:20 +0000 (15:00 -0400)]

No longer ignore and rebaseline fontmgr gms.

commit | commitdiff | tree

george [Fri, 1 Aug 2014 19:02:07 +0000 (12:02 -0700)]

Ensure that SkDebugf is exported from the library.

This was caused by the change to always call SkDebugf() in SkASSERT(). There are many headers in Skia that call SkASSERT and so we were seeing linking issues in Gecko where we were using Skia across DLL boundaries.

R=reed@google.com, bsalomon@google.com, reed1
BUG=skia:

Author: george@mozilla.com

Review URL: https://codereview.chromium.org/438783002

commit | commitdiff | tree

halcanary [Fri, 1 Aug 2014 18:54:48 +0000 (11:54 -0700)]

Revert of Memory improvements to render_pdfs; better DM pool size defaults (https://codereview.chromium.org/433063002/)

Reason for revert:
breaking android tests

Original issue's description:
> Memory improvements to render_pdfs; better DM pool size defaults
>
> Make SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE equal to
> skia_resource_cache_mb_limit, if that value is >0 (true for some
> low-memory Android devices).
>
> render_pdfs test program uses lazy decoding (and the discardable
> memory pool).
>
> BUG=skia:2743
>
> Committed: https://skia.googlesource.com/skia/+/66058b614d9c8cb63c24b1c779dd1a9a80752217

R=djsollen@google.com, mtklein@google.com
TBR=djsollen@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2743

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/418173012

commit | commitdiff | tree

halcanary [Fri, 1 Aug 2014 17:31:48 +0000 (10:31 -0700)]

add a libjpeg test

This tests for a bug in libjpeg where INT32 is typedefed to long
and memory is written to outside of the array.

BUG=skia:2791
R=djsollen@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/435753002

commit | commitdiff | tree

halcanary [Fri, 1 Aug 2014 16:25:11 +0000 (09:25 -0700)]

Memory improvements to render_pdfs; better DM pool size defaults

Make SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE equal to
skia_resource_cache_mb_limit, if that value is >0 (true for some
low-memory Android devices).

render_pdfs test program uses lazy decoding (and the discardable
memory pool).

BUG=skia:2743
R=djsollen@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/433063002

commit | commitdiff | tree

mtklein [Fri, 1 Aug 2014 15:23:39 +0000 (08:23 -0700)]

Skip all .skps in 565.

More SKPs are failing with a 565 target on other platforms:

http://108.170.220.120:10117/builders/Test-Win7-ShuttleA-HD2000-x86-Debug/builds/2938/steps/RunNanobench/logs/stdio

BUG=skia:2797
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/431983006

commit | commitdiff | tree

mtklein [Fri, 1 Aug 2014 14:46:52 +0000 (07:46 -0700)]

SKPs-as-benches in nanobench

This is meant to replace bench_pictures.

CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Release-iOS-Trybot

BUG=skia:
R=bsalomon@google.com, jcgregorio@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/425393004

commit | commitdiff | tree

Florin Malita [Fri, 1 Aug 2014 14:17:42 +0000 (10:17 -0400)]

Remove SK_IGNORE_QUAD_RR_CORNERS_OPT-related code.

Now that the flag is no longer used in Chromium
(https://codereview.chromium.org/426593006/), we can remove it.

R=bsalomon@google.com, reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/430473012

commit | commitdiff | tree

joshualitt [Fri, 1 Aug 2014 13:44:53 +0000 (06:44 -0700)]

FBFetch refactor + arm support

BUG=skia:
R=krajcevski@google.com, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/433603002

commit | commitdiff | tree

Derek Sollenberger [Fri, 1 Aug 2014 13:21:19 +0000 (09:21 -0400)]

Remove copile time enabling of SK_ARM_HAS_NEON.

We need to know this in our build system so that we can include
the necessary neon CPP files.

R=mtklein@google.com

Review URL: https://codereview.chromium.org/432453003

Domain: Dotnet / API;